update version check in GBT Model Builder

resolves conflict with oneDAL version update to 2024.1.0

/intelci: run

/intelci: run

/intelci: run


Update logic on corrdiff patch based training

The existing patch based training check automatically assumes that the patch size is not the full region. If a full domain region that is rectangular is being trained It is incorrectly rejected as being patch based.

Modulus Pull Request
Description
Updates the logic on the patch based size checking to avoid incorrectly rejecting full domain trainings.
Fixes issue:
https://github.com/NVIDIA/modulus/issues/522
Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[x] The CHANGELOG.md is up to date with these changes.
[x] An issue is linked to this pull request.

Dependencies

/blossom-ci

/blossom-ci


Symbols overlay

closes #1550
WIP screenshot

Here are the broad strokes of how the overlays work.

updateSegment has been updated to return a function that has information about each segment
it returns a function so that they can all be called together later so to not cause perf issues when a segment is being dragged (because this calls updateSegment very often)
The information for the segment that we get from this is basically this here. There's a few things there, but most importantly is the windowCoords, as this is how we know where to position all of the coordinates.
The math for how we get these windowCoords is here, but the basics of it is that given a three.js entity (like the segment arrowheads) we can project that into screen space.
The info for all the segments get added to xState context, from there we can render them like any other react component.
All of the react component stuff is in ClientSideSceneComp, the math of exactly where we place the components is here because there's some nuances about exactly where we put the overlay depending on the segments angle and what not.
Are far as overlay info goes we've only covered how we know where to place them and not the specifics that's going to depend on the type of segment line, angledLien, tangentialArcTo etc. because this is going to change depending on the segment it's best to co-locate these with other information about these stdlib functions.
The way this is done is by adding the getConstraintInfo function type to stdTypes
This now requires these function to defined for each stdlib function in sketch.ts In that file you can see they are all defined but with some abstractions since there are similarities between each.
The information we get from this is the name of the stdlib function, what kind of input it is xRelative, angle etc, the pathToNode and more.
All of these individual getConstraintInfo is abstracted to the master getConstraintInfo that takes the callExpression node for a segment and returns an array of contraintInfo
From there I'd say most of the rest of the diff in this PR is both tests, and ast query and mod cod for allowing the constraints to be added/removed by clicking the overlays as well as the delete segment button.

TODO list

[x] add delete to thee-dot menu

[x] make it safe (query for segments that depend on the segment being deleted) (1025e66)

[x] clean up overlays after sketch is exited (43a3e6a)
[x] make sure overlays adjust properly on rejig
[x] Make robust to small changes in source ranges (literal changing from 1.01 to -10.25 is two characters longer and can cause issues if we source ranges instead of pathToNode) (8ad0452)
[x] Make overlays only show on hover for a segment (but then stay for 500ms or so) (e0a33b1)
[x] Overlays should assist tests, (therefore they need to exist when not visible to users) (dcb19f0)

[x] Refactor at least one tests to remove hardcoded px coords (dcb19f0)

[x] overlay should not appear for very small (in screen space) segment, user will need to zoom in (78a011d)
[x] Clicking symbols should add or remove constraint (7371cb2)
[x] Make CI happy again.
[x] Double-check performance (5bd19c6 yup found a lurking render issue that wasn't created in the PR but was made worse by)
[x] Unit tests for:

[x] deleteSegmentFromPipeExpression (6c6e4f7)
[x] findUsesOfTagInPipe (2b6a195)
[x] removeSingleConstraintInfo/removeSingleConstraint (eea199b)
[x] getConstraintInfo (ba51601)

[x] e2e tests for:

[x] Hovering on segment for overlays
[x] Hovering on overlay to see popover and code highlight
[x] Clicking on Unconstrained overlay (add variable)
[x] Clicking on Constrained overlay (unconstrain it)
[x] Clicking on overlay three-dot and deleting segment (f73e5d2 - 4ae3b30)

[x] Deleting segment that have dependant segment
[x] Deleting segment that depends on the tag outside of the current sketch

Task for Frank:

[x] Make overlays compatible with light mode

Fast follow tasks:

[ ] https://github.com/KittyCAD/modeling-app/issues/2390

Other misc notes

figure out why disabling button changes styles that can't be overridden
implement dot above constraint (link of dependencies etc)

I went through the code and it looks good. I got a lot of engine errors while doing an integration test. I'll sync up with @franknoirot to assess fully tomorrow.

What are the engine error are these, I could look now if I knew.

I'm actually somewhat confused, we don't really have access to engine errors during the e2e tests as far as I'm aware, unless you're looking at some other dashboard i.e. not in the github action?

I'm actually somewhat confused, we don't really have access to engine errors during the e2e tests as far as I'm aware, unless you're looking at some other dashboard i.e. not in the github action?

Not e2e "integration test", but me running the code and integration testing on my system.

Ah I see.

Variables pane seems to have updated once and then stopped as I continued to add more.

Re-ran unbuntu playwright tests that had timed out

What are the engine error are these, I could look now if I knew.

Did testing today on the vertex instance and was not seeing any engine errors. Might have been a local build issue. I've been working in rust and may not have properly reset my local environment to be able to test properly.


Implement display trait for ResourceId

For https://github.com/webb-tools/relayer/issues/387. You can see the tests for examples how the resources are rendered. Im open for suggestions how to improve that.

Well this overall good for debugging, however, it is not good for filtering information, by nature the resource Ids are designed to be machine readable, easy to decode and encode, but not designed to be readable by us, humans; Hence https://github.com/webb-tools/relayer/issues/387 Task was trying to open the idea of how we could make the metrices system dynamic and at the same time human readable, so that we can represent it to the Relayer operator.

Okay I changed these to debug impls (replacing derived ones) and removed the tests. Will implement metrics like you suggested in the other PR.


fix: 1105BugBash.B (#1582)

First round of fixes, to get the UX correct. PR found higher level possible logic error now under investigation

superseded by 1105BugBash.C, merged 11/20


Problem in custom sms v1.751.0 - strconv.ParseInt

Issue: Failed to Sign In Using OTP Code
I am encountering an issue with the Casdoor Docker image (casbin/casdoor) while attempting to log in using an OTP code. The login attempt fails, and the following error message is displayed:
Failed to sign in: phone - strconv.ParseInt: parsing "": invalid syntax
Steps to Reproduce

Deploy the Casdoor Docker image (casbin/casdoor) using the latest version.
Set up an application and configure it to use OTP-based authentication.
Attempt to log in by entering a valid phone number and the OTP code sent to it.
Observe the error after submitting the login form.

Observations

The error suggests that the backend is attempting to parse an empty value ("") as a phone number using strconv.ParseInt, which fails with a parsing "" error.
Based on the logs and behavior, it seems the phone field in the request might not be populated correctly, or the backend is not handling it properly.

Request Payload
Here is the payload I am sending as part of the login request (sanitized for security):
{
  "application": "app-built-in",
  "organization": "built-in",
  "username": "12345678910",
  "autoSignin": true,
  "code": "943269",
  "signinMethod": "Verification code",
  "type": "login"
}

Environment Details

Casdoor Docker Image: casbin/casdoor
Version: v1.751.0
Deployment Environment: Docker
Request Payload: See above.

@realxoman provide the Go backend stack log for this error: phone - strconv.ParseInt: parsing "": invalid syntax

I have this log:

Note that I have same issue on email too.
In casbin/casdoor-all-in-one we don't have this issue but on casbin/casdoor we have.

Cannot reproduce, closed for now


v2.1.16

To release new version with issue #20 fixed

Changes Unknown when pulling c1ca76b5532d040e9b21a503ad97372029350128 on dev into ** on master**.

Changes Unknown when pulling c1ca76b5532d040e9b21a503ad97372029350128 on dev into ** on master**.

Changes Unknown when pulling c1ca76b5532d040e9b21a503ad97372029350128 on dev into ** on master**.

Changes Unknown when pulling c1ca76b5532d040e9b21a503ad97372029350128 on dev into ** on master**.


How to user 0 result queries to something positive: Synonyms

Figure out which synonyms to add and how to do it wit OR-search
(expand search with more OR-queries, but boost the original query)

https://github.com/NaturalNode/natural#stemmers
The general strategy would be to index stems on the way in, and then do a search for the search term and its stem.

I was more thinking about something like:
car -> transportation
When the user has one vocabulary, and the content/organization a different vocabulary.

Sorry- yes, you are talking about synonyms and I am talking about stemming- doh!

In a way, synonyms are easier to solve, because you just set up a query processor that substitutes in the synonym
[
  {
    AND: {body: ['car', 'repair']}
  }
]

...transformation ('car' -> 'automobile')...
[
  {
    AND: {body: ['car', 'repair']}
  },
  {
    AND: {body: ['automobile', 'repair']}
  }
]

And, you can get some clear indications that you need to add synonyms if you have logging on 0 results queries.

Could be cool to create a small synonyms module where you could connect a google drive spreadsheet with synonyms.

Just the layout for the synonyms-module.

Fixed with https://github.com/eklem/search-index-cookbook/commit/de1c9b61bb6016f3bbdfaa69a1b8770d580134be


Small, but important, track bundle fixes

Keep oldest entry during deduplication
Fix deduplication logic to take into account newly added entries

https://issues.redhat.com/browse/HACBS-1513

I'd go with sort by EffectiveOn rather than assume that the YAML file would be only modified by ec track bundle, but that's just nitpickery. Let's merge this and see if we ever come across this...

@zregvart , we have a story to sort things in rego, https://issues.redhat.com/browse/HACBS-1507, but that won't help here. I'll take your suggestion to avoid having to sort the data here as well, at least for now.


No versions in requirements.txt

Hello. Thanks for publishing your code and checkpoints 😃
I've come across the following error
dataset.py:145: VisibleDeprecationWarning: Creating an ndarray from ragged nested sequences (which is a list-or-tuple of lists-or-tuples-or ndarrays with different lengths or shapes) is deprecated. If you meant to do this, you must specify 'dtype=object' when creating the ndarray.

Although this warning disappears when you add dtype=object, I came across another problem later on and was unable to get the system running.
My suggestion is to add version numbers for each dependency in requirements.txt. That way, we can know which versions of each library form a working solution, and the code will continue to work in the future after libraries have changed.

Sorry for the delay and thank you so much for the suggestion.
I have added the version numbers.
If you have any further problems, please let me know.


improved speed of atr indicator

Based on #326. Now it satisfies tests.

Timeit info based on QQQ quotes.

Btw, based on #288 issue, I suggest to delete that row:
self._atr.iloc[:self._window-1] = 0

Btw, based on #288 issue, I suggest to delete that row:
self._atr.iloc[:self._window-1] = 0

any update on this @Groni3000

@Khalizo What do you mean by "updates"? I just suggested deleting the unnecessary row (and, probably, we need to add min_periods argument to the calculation) to fix an issue. It would be great to hear maintainer/s opinions! Only after this we can make updates or just merge it as it is right now.


Updated "X years, X month ago" can be experienced as confusing in page list.

Right we now we take the column "Update" into account in our page-listings. For recently edited pages it can be quite helpful what the timings were of editing by formatting like "X hours ago" or "X days, X hours ago". If you hover over the field you will still see the actual date and time of editing.
But when you have pages which were last mutated a couple of weeks or months ago. This information can be a bit confusing and you're bound to hover each of the dates to see when it was actually updated. At this point some editors lose the overview.

Possible solutions:

Show the actual date by default and the relative date on hover (no settings);
Create a setting for showing the actual date or a relative date;
Create a setting for showing the actual date after a X number of days;

I'm kind of curious how our Wagtail community feels about this as well.

This may be fixed or at least improved via https://github.com/wagtail/wagtail/pull/8697

Update - looks like the approach is basically the same with a nicer hover.
I might also flag this as Needs UI Design - cc @thibaudcolas


Axe issue: "All page content must be contained by landmarks"

Hello 👋
We’ve noticed for a while that prototype kit and GOV.UK Frontend examples keep the “Back link” and “Phase banner” outside landmark regions.
i.e. They’re not in a <header>, <footer> or <main>.
This throws up moderate issues in axe:
https://dequeuniversity.com/rules/axe/3.3/region?application=AxeChrome
Components not in <main> or <header>
This example shows showing both components outside regions:
http://govuk-frontend-review.herokuapp.com/full-page-examples/upload-your-photo

But the "Breadcrumbs" component is in <main>
This example shows breadcrumbs inside a region:
http://govuk-frontend-review.herokuapp.com/full-page-examples/renew-driving-licence

Here's what we see in the axe sidebar when follow the examples (with “Back link” and “Phase banner” outside landmark regions):

It would be great to see the research behind when to use a landmark or not.
Should this be logged under https://github.com/alphagov/govuk-frontend/issues/1280#issuecomment-509588851?
Thanks

Just to clarify, the 'govuk-frontend-review' application is not intended to be guidance and contains intentionally legacy and therefore out of date patterns for test the 'compatibility mode'.
So that's the reason why one of the examples in there is wrong.
In the official guidance on the Design System website we intentionally do not have the phase banner, back links, or breadcrumbs in the 'main' element.
This is for two reasons I know of:

the skip link is less useful if it does not skip the phase banner, back links and breadcrumbs
too many navigation landmarks on GOV.UK have been reported to be an issue so we intentionally have removed some navigation landmarks in order to make it clear what the main navigation is.

I don't have the original research for the latter decision, but will ask around and see if I can dig it up.
Will leave this in triage for us to decide as a team what direction we want to take, thanks a lot for raising this I'm sure others will run into this too.

With the help from @36degrees @selfthinker I've pulled out some of the historical stuff:

It turns out some of our nav tags were redundant. They either added no extra meaning to the links they wrapped or were unnecessary as user agents got the same information from the links' context instead.
Among those that were needed, the navigational theme that grouped their contents was sometimes unclear.
The above came out of an accessibility review by Léonie Watson. In it she explained that having too many nav tags devalued their use for screen reader users. It was suggested that when multiple ones were necessary we could help those users find the links they needed by identifying them properly.

Rethinking navigation by Tom Byers
GitHub change to GOV.UK

@nickcolley This is exactly the sort of thing I was after! Thank you for the detective work 🕵

I've added this to https://github.com/alphagov/govuk-frontend/issues/1280#issuecomment-509588851 as it can also seen on the GOV.UK Frontend Template. Thanks again for raising this @colinrotherham

Re-opening this in favour of #1949 as this has more context.
Whilst we previously decided against moving the phase banner, back link or breadcrumbs into the <main> element, we have recently discussed whether it would make sense instead to extend the <header> to include them alongside the header component.

We could also revisit wrapping the breadcrumbs and back link in navigation landmarks, taking into consideration https://insidegovuk.blog.gov.uk/2013/07/03/rethinking-navigation/ and validating with user research.

I have come across this issue recently in our code and have worked up a potentional solution for the phase banner being moved into the header. How do I go about getting rights to push a PR for discussion?

@robertparkinson we do not grant write permissions to users outside of the team, but we're more than happy for you to raise a pull request from a fork.
It does sound like the change you're suggesting would be fairly substantial (and breaking), so it would need to be managed carefully. To avoid any wasted effort on your part, are you able to describe the change that you're planning on proposing first?

Thanks @36degrees I've opened a PR. Would love your feedback and have just focussed on the phase banner as that should be an easier conversation than surroundign the back button with nav tags. https://github.com/alphagov/govuk-frontend/pull/1984

Having the ability to add additional content before the HEADER closing tag would definitely be a step forward. This would be for content that is semantically part of the header for screen reader purposes, for example, a departmental banner, but visually under the grey bar.
Allowing this would mean screenreader users can get to the main content quicker and avoid Aria difficulties around having multiple banner landmarks on the same page.

With the help from @36degrees @selfthinker I've pulled out some of the historical stuff:

It turns out some of our nav tags were redundant. They either added no extra meaning to the links they wrapped or were unnecessary as user agents got the same information from the links' context instead.
Among those that were needed, the navigational theme that grouped their contents was sometimes unclear.
The above came out of an accessibility review by Léonie Watson. In it she explained that having too many nav tags devalued their use for screen reader users. It was suggested that when multiple ones were necessary we could help those users find the links they needed by identifying them properly.

Rethinking navigation by Tom Byers
GitHub change to GOV.UK

Yes. It Is understandable the rationale of Leónie Watson, but a div title="breadcrumb" and a aria-current="page" at the last link (if I'm here why I need a link?) of the sequence is a good improve to screenreader users understand the structure of this element.

skip-link still throws the same warning in Axe. i can't see any reference to this being tackled so far. any plans or have I missed something?

We should consider the skip link component as part of this issue, but worth noting that Deque themselves say:

It is best practice to contain all content excepting skip links, within distinct regions such as the header, nav, main, and footer.

We revisited this very briefly in a discussion amongst some of the devs today. The takeaways:

Whilst this is something worth fixing for the sake of suppressing warnings and saving dev teams time, we are skeptical that it's an actual issue for users so it is still low priority
We're going to run this past our accessibility specialist to verify that skepticism
This could be solved by a long term idea to not couple the header component to the header landmark which itself could potentially go into v5

It's worth noting that Axe changed this from a "must" and flagging it as a WCAG fail to a "should" and now flags it as "best practice". See more on what Deque say about the issue from Axe.


GTMOAuth2ViewControllerTouch.h file not found

As per issue Issue #164 , I updated the pod to point to this repo. However, now I am getting the 'GTMOAuth2ViewControllerTouch.h' file not found error. This was earlier used for logging in securely to the Google backend.
Has this been removed in the new pod?

The pod doesn't directly depend on the OAuth2 support because some of the services can be used without authentication.  Additionally it can be used with the Identity Toolkit (for the folks that want that instead of the simpler OAuth2 UI).  So just add a dependency on https://github.com/google/gtm-oauth2/blob/master/GTMOAuth2.podspec to get OAuth2 if you want that dependency.

@thomasvl Thanks! I was successfully able to build the same.


Cleanup unused/unnecessary Configurations and messages for 7.0

References

Fixes #2997
Fixes #2996

Description
Simply put, this PR removes all unused configurations (from [src]/dspace/config and messages (from Messages.properties).

Removed any configuration from dspace.cfg which seems to be unused at this time.  (I searched the code using my IDE to find usages & removed ones that seemed unused.  I cannot guarantee I found all unused configs, but this should be most of them.)
Removed a few unused configuration files (similar process was used)
Removed all org.dspace.plugin.* classes.  When searching configs, I stumbled on these and they seem obviously JSPUI related and are not referenced elsewhere
Minor comment cleanup (removing mentions of XMLUI or JSPUI, or references to unused configs that I removed)
Added some TODO comments to note some configs that are not really used in 7.0, but may be useful in a later 7.x release
Remove old dspace-info.pl perl script. It was outdated & unmaintained.

NOTE: There are some configs (e.g. webui.itemlist.*) which seem to be unnecessary in 7.0 that are still referenced in existing code. I decided to leave those settings in place, until the code referencing them can be refactored and/or removed.
Instructions for Reviewers

Review changes & verify tests all succeed.

+1 removing the Perl script, which could no longer be made to work on a well-secured database.  If we want such reports (and they would be nice to have), we should provide a REST endpoint to expose the data so that one may admire them in the UI or slurp them into local downstream reporting code.

@mwoodiupui : Just a quick note that this PR has been rebased & is ready for review.

You are correct:  log.init.config should be unused.  bin/dspace adds the configuration directory to the classpath, and log4j2 will find its configuration there.  dspace-server-webapp finds the configuration because we set logging.config = ${dspace.dir}/config/log4j2.xml in classpath:application.properties.

@mwoodiupui : Thanks for your initial review on this PR.  I've addressed the small issues you noted & this is ready for another look when you get the chance.  Thanks!

Merging, as this is at +1 and was flagged for 1 Approval in a recent meeting.


Add conda packaging and deployment to accessnri channel

Fixes #71
I pretty much just copied what @dougiesquire had done on the payu repo.

I could change the target to main, or keep on develop and merge develop with main ASAP.

Seems the CI interprets the python version as a number, so "3.10" becomes 3.1.
https://github.com/ACCESS-NRI/um2nc-standalone/actions/runs/10399122598/job/28797544390?pr=74#step:3:4
I've quote the strings, and they seem to work ok in the intake catalogue CI, which looks the same to my eye
https://github.com/ACCESS-NRI/access-nri-intake-catalog/actions/runs/10295656976/job/28495683756#step:3:4
Any suggestions/help would be welcome.

I'm not sure I understand the failing tests, though...

The primary dev branch is temporarily set to develop while there's a lot of change activity.

I am not sure why the conda build is failing, my initial guess was there's no git tag versions for versioneer so the meta.yaml isn't valid but I think versioneer might give a default? I wonder if it's worth adding a --debug flag to the conda build cmd conda build . --no-anaconda-upload  and hope it gives some more information?

In payu, the filename is meta.yaml vs meta.yml? The conda docs use meta.yaml - https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html. This stack-overflow issue run into issues with conda build ignoring the meta.yml file (https://stackoverflow.com/questions/73405205/conda-build-ignoring-meta-yml). I don't know if that would make a difference

In payu, the filename is meta.yaml vs meta.yml?

Heh. Yeah, thanks @jo-basevi. I was sure I'd copied that from somewhere else, but now I'm not so sure. meta.yml seems to work in some cases. conda certainly complained when I had both files present, which is kinda weird.
So yes that was the proximate error of not being able to find a recipe file.

I am not sure why the conda build is failing, my initial guess was there's no git tag versions for versioneer so the meta.yaml isn't valid but I think versioneer might give a default? I wonder if it's worth adding a --debug flag to the conda build cmd conda build . --no-anaconda-upload and hope it gives some more information?

Again most excellent advice. I was testing locally with those commands, and yeah I wonder if we should just add the --debug flag so there is some more verbose output if something goes awry.

Now the CI tests complain because um2nc isn’t pip install-able without the mule conda dependency being installed in the environment.
An elegant solution is to save the package from the conda-build stage as an artefact and conda install it in the test conda env, which will pull down the conda package dependencies.
@CodeGat can you point me to an example I can shamelessly copy to achieve this?

So all the infra stuff is working, now failing on the tests
https://github.com/ACCESS-NRI/um2nc-standalone/actions/runs/10414392571/job/28843293751?pr=74#step:8:12
Will consult with @truth-quark, but am considering having allowed-fails for these and fix them later when the interface if stabilised.

There was an import of um2netcdf4 that is left over crufty transition to new infra. This was fixed/avoided in https://github.com/ACCESS-NRI/um2nc-standalone/pull/57 so I rebased and force-pushed.

SUCCESS!!!!!!!! 🥳

Well hello there passing tests, looking pretty good in your slinky green ticks ...

@truth-quark is going to take a look on Monday, so will wait on that for merging.

I cleaned up commit history and force-pushed ready for merging on Monday.

I cleaned up commit history and force-pushed ready for merging on Monday.

I'm not a CI specialist, but will review what I can...

@truth-quark can you check you're happy with my responses to your queries. If you're satisfied please mark the unresolved conversations as resolved and if you could provide another approval as I've pushed some changes based on your review.
Thanks!

@truth-quark can you check you're happy with my responses to your queries. If you're satisfied please mark the unresolved conversations as resolved and if you could provide another approval as I've pushed some changes based on your review.

Good to go! The only outstanding conversation is @CodeGat's comment on the debug section.

If we want nice entry points, e.g. the ability to just call um2nc from the command line, then we'll need main or similar functions defined, as entry points need to point at a function.
https://packaging.python.org/en/latest/specifications/pyproject-toml/#entry-points
This looks like this in the pyproject.toml script:
[project.scripts]
um2nc = "umpost.um2netcdf:main"

When I try and omit the function specifier
[project.scripts]
um2nc = "umpost.um2netcdf"

it throws this error:
ERROR: For req: um2nc==0+untagged.179.g0e246cc.dirty. Invalid script entry point: <ExportEntry um2nc = umpost.um2netcdf:None []> - A callable suffix is required. Cf http
s://packaging.python.org/specifications/entry-points/#use-for-scripts for more information.

I've tested __main__ as the target function, but that also doesn't work with the current set up.
I'm going to remove entry points for this PR and they can be added back in a separate issue when appropriate functions are available as targets.


android pull to refresh not work

This package has external dependencies of react-native-reanimated and react-native-gesture-handler which must be installed separately. Before opening an issue related to animations or gestures please verify that you have completed ALL installation steps, including the changes to MainActivity.
Describe the bug
A clear and concise description of what the bug is.
android pull to refresh not work,but ios work
<DraggableFlatList
              onRef={(flatList) => (this.homeList = flatList)}
              style={styles.mt10}
              data={items}
              extraData={isDelete}
              renderItem={this._renderItem}
              ItemSeparatorComponent={this._separator}
              ListFooterComponent={this._footer}
              ListEmptyComponent={this._listEmpty}
              keyExtractor={item => item.id}
              onEndReachedThreshold={0.1}
              onEndReached={this._loadMoreData}
              keyboardDismissMode="on-drag"
              onScrollOffsetChange={this._onHomeListScroll}
              onDragEnd={this.handleDragEnd}
              refreshControl={
                <RefreshControl
                    onRefresh={this._refreshData}
                    refreshing={isRefreshing}
                />
              }
          />

To Reproduce
Link a snack if possible.
Platform & Dependencies
Please list any  applicable dependencies in addition to those below (react-navigation etc).

Platform:
React Native or Expo version:
Reanimated version:
React Native Gesture Handler version:

Additional context
Add any other context about the problem here.

This problem is serious...

Closing as this is a duplicate of #135


[docs] fix readme typos; use the same scala style in the examples

Fixes issues with #1736 I didn't have to report ;)

Looks good (even though I personally prefer to not use the underscores in inline functions).
+1

I can change it back, but I chose this because this is how it's also implemented in SocketTextStreamWordCount.scala.


Support for assertions resulting in non-empty string

See discussion in #128

This should be possible to do now thx to https://github.com/phpstan/phpstan-src/pull/1254 which also solved a couple of other problems. See https://github.com/phpstan/phpstan-src/pull/1068 where something similar was done in phpstan itself. I think we should use the same approach here too.
I can take a look at it soon.


mismatch in dropdown vs saved search: API

On the Reports -> API Call Viewer, the predefined searches dropdown displays 2 options (none, slow api calls). But if you hit  configure, and go to the Saved Search: API Browser page, there are 3 options listed (api call query, service status, slow api calls).  Either the Saved Search page or predefined searches dropdown needs to be updated to reflect the same options. Screenshot attached.

added to UI Design epic. Will be addressed as part of site usability redesign process.

@vichargrave can you double check that the "service status" search has hidden = true?  I believe client is using that to filter out things to not display.

The hidden field in this case is set to 'false'.

It appears that we have a filter in the client for a few queries:
// do not render these searches in any of the dropdown lists
    bannedSearchList: {
        'service status': true,
        'api call query': true,
        'event query': true,
        'log query': true
    },

On Thu, Apr 14, 2016 at 4:17 PM, Vic Hargrave<EMAIL_ADDRESS>wrote:

The hidden field in this case is set to 'false'.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/Solinea/goldstone-server/issues/470#issuecomment-210200098

So should I set the hidden field to 'true'?

@vichargrave yes.  @lexjacobs if you want to filter on hidden=false, that was what it was created for.

please pass the ticket to me before you merge this for client modifications.
On Thu, Apr 14, 2016 at 5:48 PM, John Stanford<EMAIL_ADDRESS>wrote:

@vichargrave https://github.com/vichargrave yes. @lexjacobs
https://github.com/lexjacobs if you want to filter on hidden=false,
that was what it was created for.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/Solinea/goldstone-server/issues/470#issuecomment-210226700

Over to you  alex.

@jxstanford side affect of setting search to hidden=false rediscovered:
core/saved_search/?page_size=25&page=1&ordering=name&index_prefix=api_stats-*
originally returned 3 results which showed up under "Saved Searches: API Browser
" viewable at http://localhost:8000/#reports/apibrowser/search  and pasted in the first message in this issue thread. they were: api call query/ service status/ slow api calls.
please note that the hidden key does not show up in the api result returned to the client.
so this is not a viable key for the client to use in order to hide a saved search.
after setting the saved search to hidden: true, the result is not returned when the api call is made to: /core/saved_search/.
when viewing the list of saved searches, including the systems searches that cannot be deleted, the hidden saved search is now invisible. as seen at http://localhost:8000/#reports/apibrowser/search
so as long as hidden searches being completely obscured to the client is okay, then we can continue with this usage of "hidden" and it should also be used for:

api call query
event query
log query

please advise.

After reviewing with @lexjacobs my understanding of the role of the hidden field has been clarified.  Hidden searches are filtered and not sent via the API to the client.  We probably need another boolean field on a SavedSearch like 'viewer_enabled' so the client can choose to only present those Searches in the Log/Event/API call viewers and associated editors.

Added the viewer_enabled flag.  Over to Alex for the UI.

@vichargrave client modifications pushed. Please note that viewer_enabled is currently returning false for all searches.
I have enabled client sensitivity to this key for all of the predefined search drop downs on pages such as:
http://localhost:8000/#reports/logbrowser
as well as on the saved search manager pages such as:
http://localhost:8000/#reports/logbrowser/search
Please verify that you get the same results and that when you load these pages there are currently 0 results returning.

Closed after pull request https://github.com/Solinea/goldstone-server/pull/495 closed


Implement call to move to highest supported REST API version

Implemented during TC16 Hackathon!
Today, by default we sign in as '2.3' hard coded as our API version.
Now users can call server.use_highest_version() and it will negotiate the highest-supported API version for the current Server.

@LGraber I don't follow your comments on the Server constructor -- I didn't change the behavior of __init__. We can chat more when I'm back to I can figure out what oyu mean (but remember I'm in 🗾 and :taiwan: for a while!)

I was commenting on the question of whether we should add a flag to the constructor to do this versus having them always call the method. It is not actually in your code.

I just rebased on top of the latest changes -- I didn't make any code changes to the PR.
I think I saw these issues still open:

Default to API v2.2 instead of v2.1 per @LGraber
Why don't I put it all in use_highest_version <- I much prefer the code this way because it keeps the logic around version-detecting clean and keeps the try/except blocks out of the publish function. I can move this if there's strong objection but I really don't want to
Should we have a flag somewhere to do this automatically? @LGraber and @RussTheAerialist both commented, no decisions.


Description missing for OCIS_GRPC_TLS_ENABLED in multiple locations (services)

Running: grep -rn "yaml:" | grep "env:" | grep -v "desc:"
Checking if the descriptions are definitely missing by looking into the ocis admin docs into the services
Services list where OCIS_GRPC_TLS_ENABLED has no description:

auth-machine
storage-users
groups
storage-shares
storage-publiclink
storage-system
auth-basic
sharing
gateway
app-provider
app-registry
auth-bearer
users

Services list where REVA_GATEWAY_TLS_MODE and REVA_GATEWAY_TLS_CACERT has no description:

thumbnails
notifications

Note, see #4935 (Add REVA_ env description for WebDav) where the above was missing too - fixed.
@wkloucek @micbar @rhafer pls fix by adding a description.
@dragonchaser fyi

Will be fixed with #4910


Specify doctree location in Sphinx build

Otherwise it defaults to being in the output,
and gets copied to the webheads,
bloating disk usage.

I actually used this "feature" when working annotatedocs. I scraped the zips of all current sphinx builds. They contained the doctree files that I was able to parse and had then a AST available of the docs without going through the trouble of building all the docs locally :) Was really useful to test the project on many existing projects.
This is just an anecdote I wanted to let you know. Absolutely no argument against this change :)

Ha, yea. They are taking up like ~50G+ of disk space on our servers though, which is less cool.


Issue 202 search term

Allowing filtering a numeric column type with a number to cover scenario described in #202:

slightly modified filtering logic
added missing unit tests covering filtering data types columns

:+1:


[TF 2.0 Build] Fix bug caused by typo in check_bazel_version()

This PR resolves issue #27450.
Previously typo enters '0.24' instead of '0.24.0' for max bazel version in call to 'check_bazel_version' function, causing build to fail when compiling from source. Such typo is now fixed.
This PR may also relates to @perfinion 's comment in #27399 where he states that he will re-access min max version everywhere else later.

You are welcomed! By the way, this is my first time contributing to Tensorflow. Is there anything I can improve upon in terms of opening issue and making PR?

You are welcomed! By the way, this is my first time contributing to Tensorflow. Is there anything I can improve upon in terms of opening issue and making PR?

Congrats :) The PR is great. One small thing for future PRs i'll point out is that github has special tags, if you put Closes: https://github.com/tensorflow/tensorflow/issues/27450 at the bottom of the commit then github can automatically close the corresponding issue when the PR is merged. (no need to change this PR tho). and Thanks for the PR :).

@perfinion Thank you so much for the advice!

Closing this PR as this not against master, please open a new PR against master
CC @mihaimaruseac


MacOS wrong resolution

Description
Just installed Neofetch (stable 7.1.0) on my MB Pro (M1) and it reports the wrong display resolution. It does so both with my 4K external display as with the 'internal' display.
Neofetch version
7.1.0
Screenshot

Config file
Verbose log

Run neofetch -vv 2> neofetchlog
Upload the contents of neofetchlog to pastebin, gist or equivalent.

https://pastebin.com/Wkqgt1aF

Duplicate of: https://github.com/dylanaraps/neofetch/issues/1067


Unable to import Koa middleware

I have delayed making this request in the hopes that my company would allow the Koa dependency into our network. I don't want to be a community member who says, "fix my issue even though there may only be 3 people who have this problem." However, I have been waiting for over 9 months for my company to allow this simple middleware which is a part of the @open-wc Storybook implementation as well as Karma. I desperately need to use Storybook and the @open-wc implementation uses Koa, which has security vulnerabilities, which admittedly are not really their issue. They have a closed ticket where they talk about the issue, and the supposed vulnerability. The problem that is explained is that they allow cross site scripting (XSS). They rightly state that handling of XSS is not the job of middleware but should be handled by the server and the development team in their code.
This aside, the package has been marked as a security risk for quite some time, and I can't seem to get around it. I am currently working on implementing Webpack or Snowpack with Storybook but Storybook's recent blog post about allowing Snowpack and Webpack 5 offers an example script that utilizes @open-wc/demoing-storybook which uses Koa. I am walking in circles, and would love to have some sort of implementation where we can add a flag to use the pre-configuration that @open-wc has worked so hard on, but doesn't require Koa, such as "--no-koa".

Unfortunately it won't be possible to not use Koa, it is a core dependency of web dev server.


Ability to set SSHD allowed source IPs

Is your feature request related to a problem? Please describe.
I'm working off a standard build document for an environment, this is necessary to restrict SSH access to our devices.  We are trying to match features from the standard build with DO features.
https://support.f5.com/csp/article/K5380
Describe the solution you'd like
I'd like the ability to set the allowed source IPs for SSHD using Declarative Onboarding.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Using tmsh:
modify sys sshd allow replace-all-with { <IP_ADDRESS>/<IP_ADDRESS>   <IP_ADDRESS>/<IP_ADDRESS> }

Thank you for your feedback. I have added this feature request to our internal product backlog as AUTOTOOL-1307.

This issue should be resolved in the 1.15.0 release.


llvm: Improve accuracy of reported line counts by not counting blanks in

Previously line counts were calculated as a difference between the start and end line numbers of a function definition. This led to blank lines or lines with comments being included in the count. In order to bring the reported values closer to what cargo-llvm-lines reports, we only count non-empty lines (that aren't comments). For a medium-sized crate (that I cannot publish), this brings the sum of sizes reported by cargo-show-asm from 2591619 lines to 1577786, where the size reported by cargo-llvm-lines is 1523260. The difference can likely be explained by codegen option differences between llvm-lines and show-asm (show-asm uses single CGU)

CI is very unhappy...

Hey, I had to step away for a bit (typing from mobile) - I'll take a look at CI later tonight; the change is pretty much what llvm-lines does as seen here.

No rush, take your time. I would prefer to do proper parsing if possible. cargo-llvm-lines is very hacky.

I'll write up a proper parser for lines that should be excluded from line counts. Oddly enough though, these tests do pass for me on aarch64 Mac.. :/

Okay, that's unfortunate. It looks like the failures are related to the Rust version being used and not the changes in this PR itself. The tests do not pass on master or on c1ae8a6 (which is the last commit before yesterday's changes) for 1.75. Could we spin up a workflow on master just to confirm that this is the case @pacak ?
Should I open a separate issue for that?

Will take a look in 30 minutes
On Thu, Dec 28, 2023, 17:56 Piotr Osiewicz @.***> wrote:

Okay, that's unfortunate. It looks like the failures are related to the
Rust version being used and not the changes in this PR itself. The tests do
not pass on master or on c1ae8a6
https://github.com/pacak/cargo-show-asm/commit/c1ae8a686a51a07f1ce251affc045e6bd134e33d
(which is the last commit before yesterday's changes) for 1.75. Could we
spin up a workflow on master just to confirm that this is the case @pacak
https://github.com/pacak ?
Should I open a separate issue for that?
—
Reply to this email directly, view it on GitHub
https://github.com/pacak/cargo-show-asm/pull/229#issuecomment-1871611789,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAQFI6BWXCPPNQB3ZN6NJ3YLX2LXAVCNFSM6AAAAABBF4WGDOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZRGYYTCNZYHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

If you rebase - CI should pass.

It doesn't look like ASM/Mir have any blank lines that could reuse that logic, so in these modes the line count should not change at all.

Great comment! Are you planning making any other changes? If so - I can wait with the next release.

Hm, no, I don't think I have anything else coming up. If anything though, I'll open an issue/PR by the end of the day. Thanks!

I released 0.2.25, happy new year!

Thanks, you too!


Simplify solr loading

I'm wondering if the managed schema can be simplified: https://github.com/castorini/anserini/blob/master/src/main/resources/solr/anserini/conf/managed-schema
In particular, there's all this non-English text fields that's not being used... along with lots of dynamic fields...
Could also eliminate the need to upload all the stopwords lists:
https://github.com/castorini/anserini/blob/master/src/main/resources/solr/anserini/conf/lang.zip

Hi, you could use the Alexander Rafalovitch's simple Solr config as a basis for this issue: https://github.com/arafalov/simplest-solr-config
References:

http://www.slideshare.net/lucidworks/rebuilding-solr-6-examples-layer-by-layer-presented-by-alexandre-rafalovitch-search-stack-solutions

http://www.slideshare.net/arafalov/rapid-solr-schema-development-phone-directory


Downloading all notebooks as a zip gives an old and non-functioning version of notebooks

Dear all,
The notebooks that are in the zip file you get from

Click here to download all notebooks as a zip.

are not the same as the ones listed separately. For example, krusell_smith.ipynb gives multiple warnings, and hank.ipynb throws an error. In case someone runs into the same issue, download the files separately.
This could be easily fixed: The file notebooks.zip in the folder

sequence-jacobian/notebooks/

needs to be updated with the versions of the notebooks in that folder.
Best,
Ben

Thanks for pointing this out! I finally fixed it.


Module not sending push notification

I am trying to send notifications, but they are not being sent. Here is my code:
var apn = require('apn');
var options = {
	production: true
};
apnConnection = new apn.Connection(options);
apnConnection.on("connected", function (openSockets) {
	console.log("APN connected: " + openSockets);
	device = new apn.Device('484cfb1ce2e25a8b83a761fe9cebe73e67971c7600494d1e2fedeb33f383b16a');
	note = new apn.Notification();
	note.expiry = Math.floor(Date.now() / 1000) + 3600; // Expires 1 hour from now.
	note.badge = 3;
	note.sound = "ping.aiff";
	note.alert = "\uD83D\uDCE7 \u2709 You have a new message";
	note.payload = {'messageFrom': 'Caroline'};
	apnConnection.pushNotification(note, device);
});
apnConnection.connect();

Below is the output I get in debug mode:
apn Initialising connection +0ms
apn Initialising module +3ms
apn Connection established +569ms
APN connected: 1
apn 1 left to send +3ms

After that, nothing happens.

The connect() method should never be called directly.
Create the apn connection then immediately begin sending push notifications, the module takes care of setting up and tearing down the connections.
―A

On 1 Jun 2015, at 19:13, josebldo<EMAIL_ADDRESS>wrote:
I am trying to send notifications, but they are not being sent. Here is my code:
var apn = require('apn');
var options = {
production: true
};
apnConnection = new apn.Connection(options);
apnConnection.on("error", function (error) {
console.log("APN error: " + error);
});
apnConnection.on("socketError", function (error) {
console.log("APN socketError: " + error);
});
apnConnection.on("transmitted", function (notification, device) {
console.log("APN transmitted");
});
apnConnection.on("completed", function () {
console.log("APN completed");
});
apnConnection.on("cacheTooSmall", function (sizeDifference) {
console.log("APN cacheTooSmall");
});
apnConnection.on("connected", function (openSockets) {
console.log("APN connected: " + openSockets);
device = new apn.Device('484cfb1ce2e25a8b83a761fe9cebe73e67971c7600494d1e2fedeb33f383b16a');
note = new apn.Notification();
note.expiry = Math.floor(Date.now() / 1000) + 3600; // Expires 1 hour from now.
note.badge = 3;
note.sound = "ping.aiff";
note.alert = "\uD83D\uDCE7 \u2709 You have a new message";
note.payload = {'messageFrom': 'Caroline'};
//note.setMDM('F8B240C1-5D7B-494D-A799-9003A6EE21DD');
apnConnection.pushNotification(note, device);

});
apnConnection.on("disconnected", function (openSockets) {
console.log("APN disconnected");
});
apnConnection.on("timeout", function () {
console.log("APN timeout");
});
apnConnection.on("transmissionError", function (errorCode, notification, device) {
console.log("APN error: " + errorCode);
});
apnConnection.connect();
Below is the output I get in debug mode:
apn Initialising connection +0ms
apn Initialising module +3ms
apn Connection established +569ms
APN connected: 1
apn 1 left to send +3ms
―
Reply to this email directly or view it on GitHub.

Thanks, that was it


Update sql-server-backup-to-url-best-practices-and-troubleshooting.md

ICM https://portal.microsofticm.com/imp/v3/incidents/incident/424962517/summary

@bluefooted for help with review

@WilliamDAssafMSFT
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

@ujpat If you want to have sign-off rights on your own PRs, you need to open them in the private sql-docs-pr repository.
@bluefooted Can we sign this off?


Closes #94 | Create dataset loader for Filipino Age-of-Acquisition Words

Closes #94 .
Notes

Decided not to include the seq_label task for the POS tags in the dataset because (a) they don't follow the schema, and (b) in my opinion, it isn't "true" POS-tagging. As a native Filipino speaker, there are some words in the dataset that can vary in POS based on how they're used.
dl_manager isn't used in _split_generators. I used urllib.request.urlretrieve() and the openpyxl package instead.

Checkbox

[x] Confirm that this PR is linked to the dataset issue.
[x] Create the dataloader script seacrowd/sea_datasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
[x] Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _SEACROWD_VERSION variables.
[x] Implement _info(), _split_generators() and _generate_examples() in dataloader script.
[x] Make sure that the BUILDER_CONFIGS class attribute is a list with at least one SEACrowdConfig for the source schema and one for a seacrowd schema.
[x] Confirm dataloader script works with datasets.load_dataset function.
[x] Confirm that your dataloader script passes the test suite run with python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py.
[ ] If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

A quick question. Do you plan to use the dataset only for word translation? Would it be possible to extend the dataset for other tasks? like POS tag?

A quick question. Do you plan to use the dataset only for word translation? Would it be possible to extend the dataset for other tasks? like POS tag?

Not sure about using the current task schema for POS tagging here since the data isn't a sequence of texts. Feel free to let me know if we can still do something about it though


Update popup.md

As a Program Manager of XAML, I have added information about RoutedEvents and Popup. These events are not fired by design.

@marb2000,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Create your biography

Since you'll start speaking at conferences at some point, you should take the time to create a bio. If you want I can brainstorm with you. Here is an example (you don't need all versions) https://docs.google.com/document/d/1kF4GmIrs3Ogxpe46ZpK_Q8LcVcYk3SjD6zYyHuUsjUg/edit#

Where should I write this bio? Github, blog?

Just add a link to the document here, not sure the structure of our repo data-wise yet.

https://docs.google.com/document/d/16V_kiMRyzOFC66oMKbTq1A5KPYiUk-R7sJSXj3pprMI/edit?usp=sharing


Tamper Protection

Update this section to mention that turning on Tamper Protection with Win10 1903+ overrides Group Policy.
"If your organization has disabled Windows Defender Antivirus through group policy or other methods, machines that are onboarded to Microsoft Defender ATP must be excluded from this group policy."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b8aca66a-5a8b-64d2-7201-a7b915c5d309
Version Independent ID: c3cc0543-db20-a8f2-288c-d1dea5ea479f
Content: Minimum requirements for Microsoft Defender ATP - Microsoft 365 Security
Content Source: windows/security/threat-protection/microsoft-defender-atp/minimum-requirements.md
Product: w10
Technology: windows
GitHub Login: @mjcaparas
Microsoft Alias: macapara

@SwiftOnSecurity -  Thank you for submitting feedback.
From our understanding, the issue has been resolved based on this merged commit https://github.com/MicrosoftDocs/windows-itpro-docs/commit/c098d5afac668ac76441977a798c0d027c68c275.
Thank you for your contribution to make the docs better! Much appreciated!


Enabling Feature Gates and kubernetes custom configuration on CAPA

Currently Vintage is a heavy user of k8s initiator app which allows customers to customize the settings directly on the nodes file systems/configuration. Following the investigation of the currently used features: https://github.com/giantswarm/giantswarm/issues/28558, we have to make the adjustments to CAPA such that the migration of given features is possible and there are 'features' enabled to migrate to.
Feature Gates
As a customer i would like to be able to enable the features gates available on the k8s. Currently on Vintage this part is done via the k8s-initiator-app.
There are several groups of feature gates used by customers:

The k8s api feature gates such as:

TTLAfterFinished=true
JobTrackingWithFinalizers=true
EphemeralContainers=true

k8s Controller Manager:

TTLAfterFinished=true
CSIMigrationAWS=true
JobTrackingWithFinalizers=true

Admission controller:

configure API to enable PodNodeSelector admission controller - https://github.com/giantswarm/k8s-initiator-app/blob/main/examples/values_enable_admission_controller.yaml

k8s API configuration
Additionally via k8s-initiator-app it is available to customers to edit the e.g. audit-policy for k8s api such as: https://github.com/giantswarm/k8s-initiator-app/blob/main/examples/values_audit_policy.yaml
This feature is extensively used by one customer, where several policies are applied per cluster.
kubelet max log size
This feature is also used by one customer:
command:
 - sh
 - -c
 - |
   KUBELETCONFIG=config/kubelet.yaml
   if ! grep -q containerLogMaxSize $KUBELETCONFIG; then
     echo "Kubelet containerLogMaxSize Settings not present, applying"
     echo "Previous Kubelet Config  yaml"
     cat $KUBELETCONFIG
     echo "containerLogMaxSize: 30Mi" >> $KUBELETCONFIG
     echo "New kubelet config:"
     cat $KUBELETCONFIG;
   else
     echo "Kubelet containerLogMaxSize Settings present"
     echo "Replacing the Kubelet containerLogMaxSize"
     cp $KUBELETCONFIG /tmp/tmp_api.yaml
     sed -i -r -e "s,containerLogMaxSize:(.+),containerLogMaxSize: 30Mi," /tmp/tmp_api.yaml
     mv /tmp/tmp_api.yaml $KUBELETCONFIG
     echo "New kubelet config:"
     cat $KUBELETCONFIG;
   fi
 extraHostPaths:
 - hostPath: /etc/kubernetes/config
   mountPath: /config
   name: kubefs
 initiators:
 - bash
 masterOnly: false
 nodeSelector:
   kubernetes.io/role: worker
 psp:
   privileged: true

I checked the feature gates mentioned from above
k8s api feature gates
TTLAfterFinished=true - GA and active since 1.23, we do not need to add this
JobTrackingWithFinalizers=true - Beta and active by default since 1.25, we do not need to add this
EphemeralContainers=true - Beta and active by default 1.23, we do not need to add this
k8s Controller Manager
TTLAfterFinished=true - see above no action needed
CSIMigrationAWS=true - Beta and active since 1.23, we do not need to add this
JobTrackingWithFinalizers=true - see above
Regarding Feature Gates in general, I think it would make sense having a feature gate configuration for each component but only BETA:

kubelet .Values.internal.advancedConfiguration.controlPlane.kubelet and .Values.internal.advancedConfiguration.workers.kubelet
kube-apiserver .Values.internal.advancedConfiguration.controlPlane.apiServer
kube-controller-manager .Values.internal.advancedConfiguration.controlPlane.controlerManager
kube-scheduler .Values.internal.advancedConfiguration.controlPlane.kubeScheduler
kube-proxy (is not needed due to Cilium)

For documentation purposes, i would ask to add each topic as a separate entry in directory such as: https://github.com/giantswarm/capi-migration-cli/pull/13

There is an additional requirement identified in adidas, the audit log policy.
Currently they create a file in /etc/kubernetes/policies/audit-policy-filter.yaml and then add the --audit-policy-file=/etc/kubernetes/policies/audit-policy-filter.yaml parameter to the api-server in order to filter out non relevant events for them and have a less verbose log.

I read https://github.com/giantswarm/giantswarm/issues/28558 and compared it to what's listed here and what @njuettner stated above.
@T-Kukawka: If I'm getting everything right, the only three features we need to implement to get this story done are the following:

PodNodeSelector Admission Controller
API Server Audit Policies
Kubelet containerLogMaxSize

Is this correct?

correct @Gacko 👍

We already have a quite extensive audit policy in place for CAPI: https://github.com/giantswarm/cluster/blob/main/helm/cluster/files/etc/kubernetes/policies/audit-policy.yaml

well, customers like to set their own as on Vintage, u can refer to the discovery ticket @Gacko

@Gacko can u provide documentation for those features? or references so we can document as well as integrate that in the migration CLI?

Sure, I'll put something in the README.md of this repository. IIRC the old way of using the k8s-initiator-app was a bit tricky as you needed to change stuff in the code to customize it, but now it's more about setting the right values, that's it.

@Gacko i have added this for the node-tainting - i believe we should do the same for your case: https://github.com/giantswarm/capi-migration-cli/blob/main/k8s-initiator-features/node-tainting.md
We can have a call if u like

Added requested docs here.


__float128 on ppc64le

I'm trying to compile boost 1.85.0 with gcc 13.2.1 on ppc64le machine that does not have a 'real' long double:
LDBL_MANT_DIG: 106
LDBL_MAX_EXP: 1024

But on this system libquadmath is available and __float128 seems to work.
I'm getting the following error:
[...]
libs/charconv/build/../src/from_chars.cpp: In function 'boost::charconv::from_chars_result boost::charconv::from_chars_erange(const char*, const char*, __ieee128&, chars_format)':
libs/charconv/build/../src/from_chars.cpp:120:48: error: 'compute_float128' is not a member of 'boost::charconv::detail'; did you mean 'compute_float32'?
  120 |     auto return_val = boost::charconv::detail::compute_float128(exponent, significand, sign, success);
      |                                                ^~~~~~~~~~~~~~~~
      |                                                compute_float32
libs/charconv/build/../src/from_chars.cpp: In function 'boost::charconv::from_chars_result boost::charconv::from_chars_erange(const char*, const char*, long double&, chars_format)':
libs/charconv/build/../src/from_chars.cpp:258:48: error: 'compute_float80' is not a member of 'boost::charconv::detail'; did you mean 'compute_float64'?
  258 |     auto return_val = boost::charconv::detail::compute_float80<long double>(exponent, significand, sign, success);
      |                                                ^~~~~~~~~~~~~~~
      |                                                compute_float64
[...]

It looks like BOOST_CHARCONV_LDBL_BITS is not defined on this system, but BOOST_CHARCONV_HAS_FLOAT128 is. So boost/charconv/detail/compute_float80.hpp is not included by from_chars.cpp, but from_chars_erange overload for __float128 is not preprocessed away.

Are you trying to convert that long double type (__ibm128)? From the docs: Long doubles can be 64, 80, or 128-bit, but must be IEEE 754 compliant. An example of a non-compliant, and therefore unsupported, format is __ibm128.

Actually if you are trying with __float128 can you try latest develop? I reworked __float128 and quadmath support since release freeze: https://github.com/boostorg/charconv/pull/177

I don't think he's trying to use long double or __float128, the library just fails to build.

I don't think he's trying to use long double or __float128, the library just fails to build.

I was able to replicate on develop with -mabi=ibmlongdouble -mlong-double-128 on fedora 39. I forgot that it had transitioned to __float128: https://developers.redhat.com/articles/2023/05/16/benefits-fedora-38-long-double-transition-ppc64le#

I was able to replicate on develop with -mabi=ibmlongdouble -mlong-double-128 on fedora 39. I forgot that it had transitioned to __float128: https://developers.redhat.com/articles/2023/05/16/benefits-fedora-38-long-double-transition-ppc64le#

Yup, Fedora transitioned to ieeelongdouble,  but I'm not using Fedora, so we still have ibmlongdouble as the default.

@iv-m can you please give https://github.com/boostorg/charconv/pull/183 a try? Everything seemed fine on QEMU Fedora 39 with both long double ABIs, but I want to make sure there's not some difference from emulation.

Sorry for the delay, my ppc64le test environment was broken and it took some time to rebuild it.
Current develop branch (100473b1dc3c3dfff0513e584c8f447824c7e34c, with #183 merged)  works for me when explicitly specifying C++ standard -- for example, the following command run from the top of the boost tree completes successfully:
b2 cxxstd=11 charconv

But when I don't specify cxxstd, the default is used, which for my compiler is gnu++17. This enables GNU extensions, including __float128 and Q literals. Their presence is correctly detected by the build system, and the compilation fails:
In file included from libs/charconv/build/../src/to_chars.cpp:8:
libs/charconv/build/../src/to_chars_float_impl.hpp: In function 'boost::charconv::to_chars_result boost::charconv::detail::to_chars_hex(char*, char*, Real, int)':
libs/charconv/build/../src/to_chars_float_impl.hpp:277:140: error: 'ieee754_binary80' was not declared in this scope; did you mean 'ieee754_binary64'?
  277 |                     typename std::conditional<std::is_same<Real, __float128>::value || BOOST_CHARCONV_LDBL_BITS == 128, ieee754_binary128, ieee754_binary80>::type
      |                                                                                ^~~~~~~~~~~~~~~~
      |                                                                                ieee754_binary64
libs/charconv/build/../src/to_chars_float_impl.hpp:277:156: error: template argument 3 is invalid
  277 |                     typename std::conditional<std::is_same<Real, __float128>::value || BOOST_CHARCONV_LDBL_BITS == 128, ieee754_binary128, ieee754_binary80>::type
      |                                                                                ^
libs/charconv/build/../src/to_chars_float_impl.hpp:277:157: error: '<declaration error>' is not a template [-fpermissive]
  277 |                     typename std::conditional<std::is_same<Real, __float128>::value || BOOST_CHARCONV_LDBL_BITS == 128, ieee754_binary128, ieee754_binary80>::type
      |                                                                                ^~
libs/charconv/build/../src/to_chars_float_impl.hpp:285:13: error: template argument 3 is invalid
  285 |             >::type>::type
      |             ^
libs/charconv/build/../src/to_chars_float_impl.hpp:285:14: error: '<declaration error>' is not a template [-fpermissive]
  285 |             >::type>::type
      |              ^~
libs/charconv/build/../src/to_chars_float_impl.hpp:285:20: error: template argument 3 is invalid
  285 |             >::type>::type
      |                    ^
libs/charconv/build/../src/to_chars_float_impl.hpp:285:21: error: '<declaration error>' is not a template [-fpermissive]
  285 |             >::type>::type
      |                     ^~
libs/charconv/build/../src/to_chars_float_impl.hpp:302:67: error: 'type_layout' has not been declared
  302 |     const Unsigned_Integer denorm_mask = (Unsigned_Integer(1) << (type_layout::significand_bits)) - 1;
      |                                                                   ^~~~~~~~~~~
libs/charconv/build/../src/to_chars_float_impl.hpp:304:61: error: 'type_layout' has not been declared
  304 |     std::uint64_t exponent = extract_exp(value, uint_value, type_layout::significand_bits);
      |                                                             ^~~~~~~~~~~
libs/charconv/build/../src/to_chars_float_impl.hpp:365:33: error: 'type_layout' has not been declared
  365 |         unbiased_exponent = 1 + type_layout::exponent_bias;
      |                                 ^~~~~~~~~~~
libs/charconv/build/../src/to_chars_float_impl.hpp:370:40: error: 'type_layout' has not been declared
  370 |         unbiased_exponent = exponent + type_layout::exponent_bias;
      |                                        ^~~~~~~~~~~

Unfortunately I am unable to replicate that. Running the tests with b2 cxxstd=11 cxxflags="-mabi=ibmlongdouble -mlong-double-128" and with b2 cxxstd=11 cxxstd-dialect=gnu cxxflags="-mabi=ibmlongdouble -mlong-double-128" both pass the entire test suite with the latter correctly detecting support for quadmath.


Use parentheses in describing sessions

It's a little more readable in this case than using em dashes.

Coverage remained the same at 93.794% when pulling 6d49f7e9cc9548a1d803244f167e5af45444c1c5 on tbodt:patch-1 into 0f4dce98c70ca4517128990184c47388e58e04dd on jakubroztocil:master.

Thanks!


Baselines the MAINTAINERS.md and CODEOWNERS files per #2275

Description
Baselines the MAINTAINERS.md and CODEOWNERS files.
Adds the Emeritus section with previous maintainers.
Issues Resolved
Resolves #2275
Check List

[x] New functionality includes testing.
[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-project/admin, Please update the permissions of this repository to match the users included in the CODEOWNERS file shown in this PR.

@opensearch-project/admin, Please also remove old teams associated with the repository.

Hi @dlvenable ,
Updated the permissions as below:

Let me know if anything needs to be changed

Codecov Report

Merging #2564 (b3a307c) into main (a053d40) will increase coverage by 0.02%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main    #2564      +/-   ##
============================================
+ Coverage     93.44%   93.46%   +0.02%
- Complexity     2163     2167       +4
============================================
  Files           256      257       +1
  Lines          6037     6059      +22
  Branches        488      488
============================================
+ Hits           5641     5663      +22
+ Misses          268      267       -1
- Partials        128      129       +1

see 5 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Thank you @gaiksaya !


After a while, item sorting is stuck on alphabetic, and season order doesn't work

Expected Behavior
Browsing a season show show the episodes in the season order by default, unless the user manually requests to sort in a different way.
Current Behavior
After a while, instead of the default view being season episode order, it becomes alphabetical, and trying to cycle through the different ways to sort (date, alphabetical, default) can not bring back the default "season" order.
Possible Solution
Not sure, will try to investigate.
Steps to Reproduce (for bugs)
Hard to say.

Wait?

Context
Choosing what item to play next becomes complicated, as items are no longer in watching order.
One has to use external information, such as a wikipedia page, to determine what item comes next.
Your Environment

Version used:
plugin.video.elementum v0.1.83
Environment name and version:
Kodi 19.3 CoreELEC
Operating System and version:
CoreELEC (official): 19.3-Matrix
Link to Kodi debug log:
https://zero.crans.org/?d9fb50e878264c9d#8mPWCoGX2rz2Ay4G2xDfXb66YhXSTQJjTh9FCqAqvxwF

I just had a look at the PRs, and this comment in #836 makes me think that PR directly addresses this issue.

I have the same problem
I go in and set to default view in context menu but have to do it very often
would be really happy if some one could fix this

@elgatito @antonsoroko
Is there any chance that this will be sorted out soon? I see that there is a pull request but elementum is not updated almost 6 months. This bug is a real problem especially with episodes when randomly mix them up instead of going in order. Please guys don't leave this project. This is the only addon I really use in kodi. Happy New Year.

@matke-84 only elgatito can make releases. you can try to contact him directly in gitter messenger (link in README.md - https://gitter.im/ElementumApp/Lobby ).

@antonsoroko Thanks. I will try. I hope we will continue to get support for this great addon. I hope that you will continue to help @elgatito with this addon, I know that you are doing very well. ;-)


Update default to latest Zinc compiler version

Version 1.6.1 of the Zinc compiler brings in a dependency with a critical security vulnerability. While there's no evidence that this issue impacts Gradle, if it can easily
be resolved with this upgrade, then we should do it.

Force pushed to resolve the doc test issues, see #25909

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

I've triggered a build for you. Click here to see all failures if there's any.

Pre-tested commit build failed. Click here to see all build failures.

Your PR is queued. See the queue page for details.

I've triggered a build for you. Click here to see all failures if there's any.


enable imports without naming to be sorted

Currently plugin works for imports that are named like this:

Default

import Module from '...'

Named

import { Module } from '...'

With asterisks

import * as Module from '...'

BUT:
The imports without naming like this:
import<EMAIL_ADDRESS>
is ignored even writing such rules from documentation:
[

 "^(@/styles)(/*)$",
 "^(?!.*[.]css$)[./].*$",
 ".css$"
]

Describe the solution you'd like
Maybe makes sense to configure that imports may not have namings, but being imported directly in file, like global styles where no need to name it and apply somewhere
Thanks in advance!)

@m-kolomoyets these are called "side-effect imports" because they do not import any code from the module being imported, and therefore are only used to trigger side-effects.  In general, the order of these side-effects can matter a lot.  For instance, if you import two css files, the order you import them can change the order in the final css cascade, and therefore change the styling of your site.  For this reason, we do not sort files that nothing is being imported from.

Thanks for the message. It totally makes sense this way.


Non-blocing Input Implementation

First test it out on Windows and Linux, I have tested on MacOS.. working fine

It is only one working in Linux.


Simplify APIs using structs

We pass around too many parameters, pass a settings struct instead.

@chriseth this is probably fixed now?

I would say in this form it is much to vague, and I think we have improved the interfaces in many places.


Add linting to Makefile test target

A few times I've forgotten to run the lint target before committing resulting in a failed build so I think that if something can fail the build then it's natural home is the test target.
I've also added an npm test script to package.json. I know you dislike aliases David so I'm happy to remove it, it's just that every other project I work on uses npm test to kick off tests and I keep accidentally typing it into my terminal only to get an error.

I know you dislike aliases David so I'm happy to remove it, it's just that every other project I work on uses npm test to kick off tests and I keep accidentally typing it into my terminal only to get an error.

I'm sympathetic. I'm so used to make setup, make test, and make lint that I get tripped when working on projects which don't support these. I'm happy to support npm test.
I'd like to keep make test and make lint separate. When working on a patch I like to run make test; only once I'm ready to commit will I run make lint to check my style. As a compromise, we could make npm test an alias for make test lint. :)

Sounds good!


add toBeCollection docs for Laravel Plugin

related to: pestphp/pest-plugin-laravel#13

This needs a release of the Laravel plugin first,


The swapped hold piece should be more visible

This feature has been removed. It was difficult to get the same look in no-color mode.


Fix bug in find command message

Summary
resolves #323
Fix bug in error message in find command classes
Checks

[ ] Link PR to issue
[ ] Add Reviewer
[ ] Pass CI

Codecov Report

Merging #324 (affd111) into master (49303cc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #324   +/-   ##
=========================================
  Coverage     74.06%   74.06%
  Complexity     1037     1037
=========================================
  Files           141      141
  Lines          3385     3385
  Branches        384      384
=========================================
  Hits           2507     2507
  Misses          735      735
  Partials        143      143

Impacted Files
Coverage Δ

...ogic/commands/findcommand/FindActivityCommand.java
100.00% <ø> (ø)

.../logic/commands/findcommand/FindDoctorCommand.java
100.00% <ø> (ø)

...logic/commands/findcommand/FindPatientCommand.java
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49303cc...affd111. Read the comment docs.


Unable to redeem outcomes(market 158)

Unable to redeem outcome tokens for winning outcome on market 158. Could not redeem via portfolio page, or via market page.

Could you give more information? Is the button disabled, transaction failing, no response, etc?

@Boibit maybe you are VPN blocked? Could you send a screenshot of the buy and sell modal? The button should show a message if you are

I made this issue in the Amsterdam airport so I doubt it.


bug: workflow failed due to trying to request author as reviewer

Overview
Github user Nashqueue submitted a PR and the workflow failed to assign reviewers because the workflow picked Nashqueue as a reviewer.
Can we update the workflow to proactively check the PR author and exclude them from the list of potential reviewers?
Log
Example failure:
https://github.com/rollkit/rollkit/actions/runs/6533811456/job/17739738877
Run<EMAIL_ADDRESS>  with:
    token: ***
    config: .github/auto_request_review.yml
    use_local: false
Fetching configuration file from the source branch
Fetching changed files in the pull request
Identifying reviewers based on the changed files
Identifying reviewers based on the author
"per_author" is not set; returning no reviewers for the author.
Adding other group members to reviewers if group assignment feature is on
Group assignment feature is disabled
Randomly picking reviewers if the number of reviewers is set
Requesting review to Manav-Aggarwal, tuxcanfly, Nashqueue
Error: HttpError: Review cannot be requested from pull request author.

auto_request_review.yml
reviewers:
  defaults:
    - code-owners
  groups:
    code-owners:
      - Nashqueue
      - tzdybal
      - gupadhyaya
    rollkit:
      - Manav-Aggarwal
      - S1nus
      - tuxcanfly
    devops:
      - smuu
      - sysrex
      - jrmanes
      - Bidon15
    celestia:
      - team:celestia
files:
  '**':
    - code-owners
    - rollkit
  '**/*Dockerfile':
    - devops
  '.github/**':
    - devops
options:
  ignore_draft: true
  ignored_keywords:
    - WIP
  number_of_reviewers: 3

workflow yml
  # See https://github.com/marketplace/actions/auto-request-review for more
  # information on how to use this action
  auto-request-review:
    if: ${{ inputs.run-auto-request-review }}
    runs-on: ubuntu-latest
    permissions:
      pull-requests: write
    steps:
      - uses<EMAIL_ADDRESS>        with:
          # There is a rollkit level PAT_FOR_AUTO_REQUEST_REVIEW secret that
          # belongs to MSevey who should have sufficient access for all public
          # repos
          token: ${{ secrets.PAT_FOR_AUTO_REQUEST_REVIEW }}

cc @Nashqueue

We are also experiencing this issue


Demo page does not build

Hello,
I wanted to try this implementation to evaluate how it would be a practical use of ShenScript. And I wanted to try the demo advertised on the main page, but it seems to fail:
$ brew install webpack
$ npm start
><EMAIL_ADDRESS>start /Users/vresko/projects/ShenScript
> webpack-cli --watch

webpack is watching the files…

Hash: 70a761fd3a6c065ce219
Version: webpack 4.39.2
Time: 194ms
Built at: 17.08.2019 09:15:55
    Asset      Size  Chunks             Chunk Names
bundle.js  72.8 KiB    main  [emitted]  main
Entrypoint main = bundle.js
[../../../../usr/local/Cellar/webpack/4.39.2/libexec/lib/node_modules/webpack-cli/node_modules/webpack/buildin/global.js] (webpack)/buildin/global.js 472 bytes {main} [built]
[./dist sync recursive ^\.\/kernel\..*$] ./dist sync ^\.\/kernel\..*$ 160 bytes {main} [built]
[./index.js] 423 bytes {main} [built]
[./lib sync recursive ^\.\/config\..*$] ./lib sync ^\.\/config\..*$ 252 bytes {main} [built]
[./lib sync recursive ^\.\/frontend\..*$] ./lib sync ^\.\/frontend\..*$ 262 bytes {main} [built]
[./lib/ast.js] 6.24 KiB {main} [built]
[./lib/backend.js] 25.4 KiB {main} [built]
[./lib/config.js] 458 bytes {main} [built]
[./lib/config.node.js] 325 bytes {main} [optional] [built]
[./lib/config.web.js] 1.28 KiB {main} [optional] [built]
[./lib/frontend.js] 15.4 KiB {main} [built]
[./lib/frontend.node.js] 563 bytes {main} [optional] [built]
[./lib/frontend.web.js] 814 bytes {main} [optional] [built]
[./lib/utils.js] 1.41 KiB {main} [built]
[./shen.js] 651 bytes {main} [optional] [built]
    + 2 hidden modules

ERROR in ./lib/ast.js
Module not found: Error: Can't resolve 'astring' in '/Users/vresko/projects/ShenScript/lib'
 @ ./lib/ast.js 1:21-39
 @ ./lib/frontend.js
 @ ./lib sync ^\.\/frontend\..*$
 @ ./shen.js
 @ ./index.js

Unfortunately I am not that skilled with shen to debug that just myself. Any assistance to get to a demo page with an example is running would be great.

Seems that I forgot to run the mandatory npm install, my bad. I also saw that in order to run the demo page the main index.html has to be served with an external server.
Then it just prints environment created in 25536ms. (that was a modern laptop, chrome browser).
I hope there was a way to speed up this load time to something more practical. Any ideas?


django-guardian: style is broken

Hello,
Something happened to break the style on the django-guardian project. It looks fine when built locally, however it is broken on readthedocs.
This has resulted in several bug reports. https://github.com/django-guardian/django-guardian/issues/397 and https://github.com/django-guardian/django-guardian/issues/398.
I have asked about this on stack overflow however the only response I have had is a rating of -1.
As this looks like a readthedocs bug, I am now reporting a bug here.
Thanks.

Not sure what have changed, but your theme isn't loading the required css.  You might have luck altering paths and using 'sphinx_rtd_theme' as the theme name.

Oops. Hadn't realized the project was setting the theme to one included in the project. Have fixed this now by using sphinx_rtd_theme as per your suggestion, so will close this issue.


[CBR-289] Review mnemonic implementation

Description
This is actually an implementation of BIP-39. The current implementation is inspired from Haskoin and is rather hard to grasp. This refactor merges together Pos.Util.BackupPhrase and Pos.Util.Mnemonic. The entire implementation has been reviewed to rely on smart constructors and maintain invariant this way.
Quite some tests have been added, and I am open to any idea of things that could also be tested and that aren't currently included.

Note
At the moment, the PR still contains the old code, moved in a test folder and used for comparison
with Quickcheck. This is to make sure that the new code behaves exactly as the old one
since it touches to a quite sensitive part of the code. I am not sure if this has to stay or can be removed if we all get convinced that the behavior has been preserved (keeping only the relevant tests).

Linked issue
[CBR-289]
Type of change

[ ] 🐞 Bug fix (non-breaking change which fixes an issue)
[ ] 🛠 New feature (non-breaking change which adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)
[x] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
[x] 🔨 New or improved tests for existing code
[ ] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

[x] I have read the style guide document, and my code follows the code style of this project.
[x] If my code deals with exceptions, it follows the guidelines.
[x] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

QA Steps

We need to make sure that once this get merged, users with an existing backup phrase can still restore their wallet (and it has to be the same wallet). Said differently, changing the implementation shouldn't have changed the behavior.

It shouldn't be possible to use the example mnemonic advertised in the API doc anymore

Paper wallet already emitted should also not be affected and we must verify they can still be redeemed as expected.

Screenshots (if available)

Hi! Can someone, please, clear one thing for me - do I get it right that changes in mnemonics are completely backward-compatible? So old mnemonics can be restored in new version, and new mnemonics can be restored in an old Daedalus version and will give the same wallet in the result?
Would really appreciate this clarification, thank you :)

@vantuz-subhuman
Yes, the whole point of this change is to review the implementation to get clearer code without changing anything to the current behavior. That's why we currently compare side-by-side the old and new implementations, making sure we generate the exact same wallet from a given mnemonic.

That's why we currently compare side-by-side the old and new implementations, making sure we generate the exact same wallet from a given mnemonic.

@KtorZ, this is awesome! Nice clean changes. So the result will be the exact following of the BIP-39, do I get this right?

@vantuz-subhuman
Unfortunately not. There are some discrepancy between the current implementation and BIP-39. As much as I would like this to be fully compliant with BIP-39, it conflicts with the "backward-compatible" approach. Applying changes to be fully BIP-39 compliant would invalidate every existing wallets :) .. which is well, not good.

Addressed most of the comments above:

Created a new module Pos.Util.Bits which contains all the binary conversions, using newtype instead of aliases for more type-safety and tested with QuickCheck.

Differentiated mnemonicToSeed and mnemonicToAesKey by using an explicit type for AesKey (instead of raw bytestring)

Introduce number of words at the type-level (e.g. Mnemonic 12 and Entropy 12). This makes the code slightly more complex but also removes a whole category of possible error. The main downside (which is incidentally the main benefit of that change) is that we can't interchange mnemonic phrases with different number of words, they are now different types. If really needed at some point, we may simply define a dedicated ADT with the supported types. Like:

data MultiMnemonic
  = Multi12 (Mnemonic 12)
  | Multi15 (Mnemonic 15)

Note also that this last change is to-be-discussed and can easily be removed by discarding the underlying commit.

ahem ? https://github.com/input-output-hk/cardano-crypto/blob/master/src/Crypto/Encoding/BIP39.hs

@vincenthz Yes.. I actually found that one during the weekend and I was about to ask you. I believe we can avoid the duplication here ^.^

@parsonsmatt
Sooooooo. I've made use of cardano-crypto implementation to avoid duplicating code here, simply building a thin wrapper around it with functions that are ready-to-use in cardano-sl. For those, I've defined a MnemonicErr error type. We lost some ... granularity along the way though. cardano-crypto actually returns Maybe * for various functions, which we turn in a generic FailedToCreate error.
Let me know what you think of that.
@vincenthz
Your review of the new Pos.Util.Mnemonic is highly welcome :)

Thanks @vincenthz, I will borrow a couple of test vectors from cardano-crypto :)


Accounts: login 2fa and layout state decisions

The login needs to account for 2FA (two factor authentication), look at old accounts for reference https://github.com/zesty-io/accounts-ui/blob/master/src/shell/views/Login/Login.js

State need to verify login state to generate the page, this authentication will need to happen at every load to properly serve the app bar

Need a periodic (every 90 seconds verify request when logged into to keep the session alive)

2FA docs https://auth-api.zesty.org/#548abd67-dc1e-40c0-b6dc-9d4ea2c48a4a

Make a universally accessible hook in react https://reactjs.org/docs/hooks-custom.html we can use like
import isLoggedIn from '....'
So it can be called from anywhere. This will be used to determine app bar status and running things like google analytics


No on-response / last-response trigger

Hey all,
not sure wether it should be posted here or not, but I'm not getting a response trigger from the byutv.
It does fetch the data correctly trough as seen trough google dev mode.
Any idea's ?
<link rel="import" href="../../bower_components/polymer/polymer.html">
<link rel="import" href="../polymer-app/shared-styles.html">

<dom-module id="contact-pagina">
 <template>
 <style include="shared-styles">
 :host {
 display: block;
 }
 </style>

  <byutv-jsonp
    auto
    id="ajax_members_get"
    method="GET"
    url="https://api.guildwars2.com/v2/guild/code/members"
    params='{"access_token":"code"}'
    handle-as="json"
    last-response="{{_c_studenten}}"
    on-response="members_get_response_handler">
  </byutv-jsonp>

 </template>
 <script>
 Polymer({
 is: 'contact-pagina',
 properties: {
   c_visible: {
     type: Boolean,                                      /* true when element is the active visible item */
     value: false,
     observer: '_initializing',
   },
 },
 _initializing : function() {
   if (this.c_visible) {
      console.log("about-pagina");
      this.members_get_request_handler();
   }
 },
 members_get_request_handler: function() {
   console.log("members_get_request_handler");
   this.$.ajax_members_get.contentType="application/json";
   this.$.ajax_members_get.body={
   };
   this.$.ajax_members_get.generateRequest();
 },

 members_get_response_handler: function(request) {
   console.log("members_get_response_handler aantal studenten="+request.detail.response.length);
   this._c_studenten = request.detail.response;
 },
 });
 </script>
</dom-module>

You have an extra </vaadin-grid-column> before </vaadin-grid>.  Also, requests are not automatically performed.  If you want the request to fire automatically set the auto attribute.  There may be other issues but these are a few that I was.  Check out the docs here: http://coderfin.github.io/byutv-jsonp/components/byutv-jsonp/.  I would recommend isolating the byutv-jsonp portion to ensure that it works and then move on to the other stuff.

I've moved the jsonp to a new page (and edited above), it does the request but the on-response method isn't fired.
In google developer I do get the right json file in "response" tab.

I've looked into this some more.  It appears that JSONP is not supported by the API you are using.  See https://forum-en.guildwars2.com/forum/community/api/JSONP-callbacks and https://forum-en.guildwars2.com/forum/community/api/HTTP-access/.
A quick check confirms that this is the case.  Calling https://api.guildwars2.com/v2/colors?callback=byutv_jsonp_callback_53dc550fbdb94e37b128963115436e13&_=d2609539e5614bf0b2854755ffa84382 returns an array but the array is not properly wrapped in a callback.  JSONP requires that the response be wrapped but the API you are using does not support this.  The response is just [   1,   2,   3,   4,   5,   6,   7, ...   1499,   1537,   1538,   1539,   1540,   1541,   1542 ]
byutv-jsonp will not help you with this problem.  You will need to look into CORS.
If you have any other questions feel free to ask.


Merge develop into main

Codecov Report
Attention: Patch coverage is 28.57143% with 360 lines in your changes missing coverage. Please review.

Project coverage is 12.54%. Comparing base (8db9e58) to head (07b966a).
Report is 4 commits behind head on main.

Files
Patch %
Lines

src/hooks/useDeleteAccount.jsx
0.00%
48 Missing and 1 partial :warning:

src/components/Layout/ScrollTop.jsx
0.00%
38 Missing and 1 partial :warning:

src/components/Profile/index.jsx
0.00%
34 Missing and 1 partial :warning:

src/components/UserContext/index.jsx
0.00%
34 Missing and 1 partial :warning:

src/components/Layout/index.jsx
0.00%
31 Missing :warning:

src/components/LoadingContext/index.jsx
0.00%
29 Missing and 1 partial :warning:

src/components/GameCards/GameCardsLoading.jsx
0.00%
22 Missing and 1 partial :warning:

src/components/Router/PrivateRoute.jsx
0.00%
16 Missing :warning:

src/components/GameCards/View.jsx
0.00%
15 Missing :warning:

src/components/Router/index.jsx
0.00%
15 Missing :warning:

... and 8 more

Additional details and impacted files
@@            Coverage Diff            @@
##            main      #42      +/-   ##
=========================================
+ Coverage   9.04%   12.54%   +3.50%
=========================================
  Files         19       26       +7
  Lines        984     1315     +331
  Branches      18       37      +19
=========================================
+ Hits          89      165      +76
- Misses       878     1128     +250
- Partials      17       22       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


xGroup Throws Error When Using Invoke-DscResource

Hello,
When running Invoke-DscResource on xGroup when specifying a domain account to include as a member, I get an error stating "You cannot call a method on a null-valued expression". This issue doesn't come up when using local accounts only.
Running xGroup with these same parameters in a compiled MOF file presents no problems, but this issue prevents Chef users from using this resource.
Output:
PS C:\Users\vagrant> Invoke-DscResource -Method Test -Name 'xGroup' -Property @{Ensure = 'Present'; GroupName = 'S-1-5-32-544'; Credential = $creds; MembersToInclude = @('Dev\Domain Admins')} -ModuleName xPsDesiredStateConfiguration
Invoke-DscResource : You cannot call a method on a null-valued expression.
At line:1 char:1
+ Invoke-DscResource -Method Test -Name 'xGroup' -Property @{Ensure = ' ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (:) [Invoke-DscResource], CimException
    + FullyQualifiedErrorId : InvokeMethodOnNull,Microsoft.PowerShell.DesiredStateConfiguration.Commands.InvokeDscReso
   urceMethodCommand

Invoke-DscResource : The PowerShell DSC resource '[xGroup]DirectResourceAccess' with SourceInfo '' threw one or more
non-terminating errors while running the Test-TargetResource functionality. These errors are logged to the ETW channel
called Microsoft-Windows-DSC/Operational. Refer to this channel for more details.
At line:1 char:1
+ Invoke-DscResource -Method Test -Name 'xGroup' -Property @{Ensure = ' ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (root/Microsoft/...gurationManager:String) [Invoke-DscResource], CimEx
   ception
    + FullyQualifiedErrorId : NonTerminatingErrorFromProvider,Microsoft.PowerShell.DesiredStateConfiguration.Commands.
   InvokeDscResourceMethodCommand

I'm just looking into this one at the moment. This particular resource doesn't contain any Unit or Integration tests and needs a bit of work (lots of violations of style guidelines) -so any changes should include work on these issues. I'll try and put some work into it over the next few weeks.

After some investigation, the error appears to be occurring in this line:
https://github.com/PowerShell/xPSDesiredStateConfiguration/blob/dev/DSCResources/MSFT_xGroupResource/MSFT_xGroupResource.psm1#L803
This is because $PrincipalContext.ConnectedServer is null in this situation. I'm certain why this is yet, but thought I'd document it now.

Some further information on this: The issue only occurs if the account that is being used to call Invoke-DSCResource (e.g. $creds) is not a member of the domain that the account being added is a member of.

@PlagueHO, nice find. Thank you for looking into it.

@PrahlM93 - no worries! I'll get onto submitting a PR for this as well as bringing the resource up to standards later on this week.

Some tests will be added as part of #160

@PlagueHO @PrahlM93 Good find! That change seems to fix the ability to add domain accounts to local groups for me.

@iainbrighton - Awesome! I'll get onto this tomorrow now that I've finished the xADComputer ODJ one.

@kwirkykat - If I add this fix now without creating unit tests, with the understanding that some tests will be added in #160, will the PR be accepted? I can write unit tests for xGroup, but I don't want to conflict with what you're implementing.

@PlagueHO Yes you can submit the PR now without the tests

Thanks @kwirkykat  - I'll submit it this weekend. Cheers!

Still working on this. I got side tracked. Will try and submit the pr over the next couple of days.

Just an update on this: The most recent code commits changed the https://github.com/PowerShell/xPSDesiredStateConfiguration/blob/dev/DSCResources/MSFT_xGroupResource/MSFT_xGroupResource.psm1 significantly. The bug still exists though, so I've got to rework my original fix (the code I originally proposed changing no longer exists).