Lane information in rgb image observation

Is your feature request related to a problem? Please describe.
Currently our top-down rgb image observation in SMARTS looks like the following. It does not contain any lane information.

Describe the solution you'd like
It would be helpful, if we could add lane dividers into the top-down rgb image observations. An example image is as follows:

Describe alternatives you've considered
Without embedded lane information in rgb image observations, users will have to manually combine (i) lane information (i.e., lane index, waypoints, etc.) and (ii) rgb images, to form input to RL training.

I fully support this.  Just a few questions (@Adaickalavan):

Do we need to indicated other semantic aspects as well, such as whether adjacent lanes go in the same direction (white lines) or opposite directions (yellow lines)?
Are there any requirements (or even "desirable properties") for the lane dividing marks?  For example, can the dashed line in you example be more like a "dotted line"?  How think should this dashed (or dotted) line be?
Do we also need to add (presumably-solid)  "road boundary lines" (as in your picture above)?  If so, does it matter whether we have them "crossing through the intersections" (as in your picture above), or should they instead indicate places where vehicles should not normally cross (and so not be drawn in intersections)?

(Note that the quality of what we can do here will heavily depend on other properties of our representation, such as its resolution, and the precision with which the polygons are drawn.  That's something that is probably a good topic for another issue.  I will link that one to here once I've made it.)

We may consider adding the following:

Yellow solid/broken lines - separate traffic travelling in opposite directions. https://files.ontario.ca/3-1.jpg
White broken lines - separate traffic travelling in the same direction. https://files.ontario.ca/3-1.jpg
White broken lines that are wider and closer - lane is ending or exiting. https://files.ontario.ca/3-4.jpg
White line painted across the road at an intersection - a stop line. https://files.ontario.ca/3-5.jpg

I guess, the more realistic the road markings are in our RGB image, the better it is.

Broken lines can be dashes rather than dots.
Not sure of the exact thickness of the dashes. I guess any reasonable thickness with respect to the lane width would be okay.
Dashes could be curved if it is easier to draw curved dashes by following the lane curvature. If the dashes are short, then they may not need to curve.
Road boundary lines would be nice feature, considering we have on-shoulder event. Road boundary lines should not cross intersections. Our current road and off-road are of different colours, hence road boundary lines are not immediately needed if they are difficult to draw properly without crossing through intersections.


Zig v0.10.0 support

Hey! First, thanks for maintaining this library - using it has been a joy.
Zig 0.10.0 was released today, and has a few breaking changes that affect zig-cli:

Function types have to be declared as constant pointers.
The empty formatting directive {} is no longer allowed.
The std.process.ArgIterator signature has changed to... exactly what your iterators.SystemArgIterator was. I removed iterators.SystemArgIterator and just pass std.process.ArgIterator directly into Parser.

These changes make it compile and pass the tests (and work in real usage for my project). One thing you might want to do is reconsider how the command line args system works since iterators.zig now just has one iterator defined. I didn't want to try make those kind of decisions and kept the changes as minimal as possible.
Of course, if you'd rather work in 0.10.0 support on your own, feel free to close this. Thanks again!

@joeltg thank you for contribution! Great work.
I see a check has failed. I'll fix it directly on main.

The check failed only because of the old zig version in the github action file.


Add --depth=1 parameter for cloning rbenv using Git

People don't need to clone the whole Git history of rbenv when they want to use it. This is can be done by adding --depth=1 parameter at Git clone command. By not cloning the whole Git history, clone time and space occupied will be reduced.
Benchmarking
Clone all history
$ time git clone https://github.com/rbenv/rbenv.git ~/.rbenv-depth-all
Cloning into '/home/nieltg/.rbenv-depth-all'...
remote: Enumerating objects: 4, done.
remote: Counting objects: 100% (4/4), done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 2763 (delta 0), reused 2 (delta 0), pack-reused 2759
Receiving objects: 100% (2763/2763), 534.99 KiB | 515.00 KiB/s, done.

Disc usage shrinkage: 27.95% smaller.
And these number will be increasing as this repository grows.

Thank you for the benchmark!
Rbenv repo isn't very big, and is not going to become significantly bigger either, so I don't feel like there are significant gains of using --depth. The 4.31% speedup isn't very much if you consider that the total time was 3.27s. There are some drawbacks to --depth too: a shallow repo cannot be pushed to a fork, so this approach impedes contribution.
If someone is concerned about download and disk size, the best way to fetch the lastest state of the project without fetching the whole history is to avoid git clone and download a tarball or zip archive.

I see. Thanks too!


Refactor on-demand download to use a RequestContext param

Per discussion on Slack:
@problame: The way I see it, retry_get  is a crutch that we need in the cases where we can't do the download because it's a sync function. So we bubble up the future to the earliest caller that is async , then execute it.We need this now, because so much code is still sync.
(Can we get a runtime handle and use block_on, though?)But I think should get rid of retry_get ASAP, though not in this PR.
The way to do it is

make all code paths that call page reconstruct async
plumb through a "getpage policy struct" all the way from the protocol handlers that contains

a value that says whether we should download at all or fail with a (distinguished?) error instead
absolute deadline of the protocol-level operation. If we cross it, we should return from the .await with a deadline exceeded error. (The read task will likely continue in the background to not waste the work, but the protocol handler can respond with something)
some kind of "soft-hold" on the layer files that the operation already downloaded. I think we will need this once we add layer file eviction, to avoid thrashing whenever possible.

Same idea rephrased by @hlinnaka :
In the long run, and maybe even pretty soon, I think we need to refactor this. I'm thinking that we should go more async, and implicitly download layer files wherever one is needed. One problem I've had with that is that there might be cases where we don't want to download a file, and would rather return an error to the caller. For example, we might want to have a more fine-grained heuristic in compaction, and refrain from compacting if it would require lots of downloads. We don't try to be smart like that currently, but still.We also talked about timeouts earlier. tokio_util::CancellationToken seems like a nice approach for that (
@Joonas Koivunen
has brought that up a few times). (Per discussion yesterday, this is for the future, no need to do anything wrt. timeouts right now)Here's a proposal. Let's add a new argument to all the relevant functions to specify the download behavior, and also include a CancellationToken in it. Something like thi, taking Timeline::get as an example:
struct CancellationBehavior {
   /// Returns true, if missing layer files should be downloaded.
    /// If 'false', then an operation that needs a remote layer should fail with PageReconstructError::NeedsDownload
    download_missing: bool,

    /// Can be used to cancel long-running operations, e.g. to implement timeouts.
    token: CancellationToken,
}
...
    pub fn get(&self, key: Key, lsn: Lsn, behavior: CancellationBehavior) -> PageReconstructResult<Bytes> {

This 'behavior' argument needs to sprinkled through all the functions that might need to download layer files. That's a bit tedious, but it's nicer than sprinkling the handling for PageReconstructError::NeedDownload in all of those same places, IMHO.Thoughts?
@shanyp: yep and it could also carry the UUID of the originating flow if present

@hlinnaka
Can we do the following in Rust
struct CancellationBehavior {};
...
using(CancellationBehavior::WithNoDownload) { //this sets a local thread state with the CancellationBehavior needed which will go out of scope when the code block ends
get(key, lsn);
}
pub fn get(&self, key: Key, lsn: Lsn) -> PageReconstructResult {
//retrieve the local state CancellationBehavior and do the logic
}


Alertmanager loses in-memory alerts when it restarts

What did you do?
Alertmanager stores fingerprints of current alerts in the memory send via clients. It stores nf-logs and silences in the disk(if configured).
When alertmanger starts it reads nf-logs and silences from the the disk. The in-memory store is recreated when the alertmanager restarts. Now, if the client has stopped sending alerts to alertmanager while alertmanager was down, the AM will not be able to send resolve notifications to receivers.
What did you expect to see?
AM should be able to send resolve notification after it restarts.
Can we also store the in-memory alerts onto the disk via snapshot(similar to nf-logs and silences) and/or while graceful shutdown and recover them from disk when AM restarts?

Something similar has been already discussed a while ago (see #2042). The maintainers had concluded that it isn't something we're willing to support for now. To increase Alertmanager resiliency, you should first look at running several Alertmanager instances.

Something similar has been already discussed a while ago (see #2042). The maintainers had concluded that it isn't something we're willing to support for now.

@simonpasquier Hi, my understanding is that the topic of #2042 discussion is the persistence of alerts at any time, and the main discussion here is the persistence of alerts at graceful shutdown. The latter solution will be much simpler, as OP mentioned:

Can we also store the in-memory alerts onto the disk via snapshot(similar to nf-logs and silences) and/or while graceful shutdown and recover them from disk when AM restarts?

And about:

To increase Alertmanager resiliency, you should first look at running several Alertmanager instances.

This solution cannot cope with all scenarios, such as rolling updates. You will eventually lose all alerts no matter how many instances you have. Rolling update is a common scenario and requirement, isn't it? So I support OP, and if I can, I'd be happy to new a PR to achieve this.

IMHO we need more details about how it would work in practice and look at edge cases. For instance, when reloading alerts from disk, should Alertmanager consider all past alerts or discard alerts older than a certain period? I'm sure that there are other scenarios needing consideration.
A document describing the issue + possible solution would be helpful.

The main issue with rolling releases of Alertmanager is when the rollout is completed within ResendDelay seconds in Prometheus. What happens is all the Alertmanagers are restarted, but none of them have alerts. To avoid this situation you should wait ResendDelay seconds between rolling out pods in a deployment, as this will ensure at least one Alertmanager has alerts at all times. However, I don't think this is possible in Kubernetes.
A more nuanced issue is that rolling releases reset both the Group wait and Group interval timers. That means if you have an alert that is at the fourth minute of a five minute Group wait, and then a rollout is started, the alert will need to wait another five minutes before a notification is sent.
This means the recommendation above needs to be restricted further such that, at a minimum, you should wait the maximum Group wait and Group interval seconds between rolling out pods.


Plugin E2E: Decouple panel from pages

What this PR does / why we need it:
This panel decouples panel logic from pages. This makes sense, as different pages render panels differently. For example, Panel edit page can have one panel only, whereas the Explore page can render many different types of panels depending on the data frame format.
There's not much logic in the Panel model right now, but there will be soon when we add support for asserting on panel data and add support for testing link extensions.
💥 Breaking Change
With this refactoring, there's no longer a need for the toHavePanelError expect matcher. If a page that has a panel, one can simply use the built in Playwright matcher instead. E.g
await expect(panelEditPage.panel.getErrorIcon()).toBeVisible();
await expect(explorePage.timeSeriesPanel.getErrorIcon()).not.toBeVisible();

Note this doesn't require a new major release since we haven't officially released a version 1.0.0 yet.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>

(Is this breaking change affecting any internal plugins already?)

Yes I know for sure it will break tests in the infinity data source. But I've been having close contact with Sriram lately, so will definitely reach out to him. 👍


Xpath support

This branch is based on branch 9-decouple-ref-formulation. It adds an XPath resolver.
I also added a test based on the xml example in the spec, but had to make some changes. First, the xpath expressions in the mapping were absolute and contained syntax errors. Second (and I'm less sure about this part), the example iterates over busses, and each bus contains multple <stop>s. In the example, two triples for each stop are generated, but this does not make sense to me. I simplified the example to have just one stop.

Could we cache compiled XPathExpressions in resolver for recurring expression evals?


Entity persistance error

Hello,
When I update DoctrineExtensions from v2.4.33 to v2.4.34 I have this error:
Doctrine\ORM\ORMInvalidArgumentException: Entity #1 is not managed. An entity is managed if its fetched from the database or registered as new through EntityManager#persist

My code looks like:
$entity = $repository->findOneById(1);
$entityManager->remove($entitty);
$entityManager->flush();
$entityManager->refresh($entity);

The entity is loggable, soft deleteable with some versionned fields.

And this gets more interesting:
$repo = $this->em->getRepository(Entity::class);
$anotherRepo = $this->em->getRepository(EntityOther::class);
$entity = $repo->find(2);
$entity2 = $anotherRepo->find(2); // this entity has association with first Entity and loads proxy object
$this->em->remove($entity);
$this->em->flush();

$entity2->setSomething('something');
$this->em->flush();

I get Doctrine\ORM\ORMInvalidArgumentException : A new entity was found through the relationship.... Proxy is still here. I am not super aware about underlying workings of ORM, but it seems that these changes breaks normal flow in app. My first example has antipattern, but this one I am not sure.

Numerous client complaints coming in after a recent update.. just found this issue and it looks like im not alone.. good to know.

Thank you.

yes sadly did not expect such behavior while merging a pull request. guess it is tied too deep in orm to allow such object detaching. anyway update to new release if you experience this issue


Add gut microbiome and sediment studies

Pull Request
This PR is for a

[x] New Publication(s)
[ ] Correction

For the follow list (s)

[x] Ancient Microbiome
[x] sedaDNA
[ ] Ancient Pathogen

New Publication
Publication Information

This pull request is to add samples from the following publication(s):

Tett et al. (2019)
Hagan et al. (2019)
Rifkin et al. (2020)
Borry et al. (2020)

Checklist

[x] Publication is published (preprints currently not accepted)
[x] Checked the publication is not already in the database
[x] Checked samples in this publication are not previously published data (newly re-sequenced metagenomes are OK!)
[ x] Checked the list follows conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)
[ ] (If applicable) Updated the JSON files under /assets/enums with new categories (e.g. material or archive).
[ ] Does your PR pass validation checks?

If you do not know how to check errors in failed validation checks, expand here

Press 'details' next to the failed check.
Expand the test ancient <list> line with the red X next to it.
Scroll to the bottom of the log, and look for a DatasetValidationError (usually the last line).
Read the error, and fix accordingly. Check the README for a given list for more guidance. If in doubt, ask!

Correction
This PR is for

[ ] Ancient Microbiome
[ ] sedaDNA
[ ] Ancient Pathogen

Reference
This pull request is to correct samples from the following publication(s):

Description
The issue is:

Checklist

[ ] Checked the list follows conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)
[ ] Does your PR pass validation checks?

#10
#11
#8
#17

Ok, notes from more thorough check:
Microbiome

[ ] The Zape site name is: Cueva de los Muertos Chiquitos (see Hagan 2019))
[ ] Update dog to species name sa in NCBI taxonomy (I believe Canis lupus)
[ ] For Lat:Lon, if you don't have the exact Lat:Lon (e.g. rockhshelter), please do 2 decimals not 3.

Sediment

[ ] country for UK should just be United Kingdom. See:  http://www.insdc.org/country.html
[ ]


Various minor improvements to the Makefile

We use various find commands to figure out what to build; stop these traversing various large directories they shouldn't.
Update to go 1.10 and start using its build caching.

Before these changes:
$ make clean
$ time make cmd/distributor/distributor
...
real	1m26.436s
user	0m0.848s
sys	0m0.699s

After:
$ make clean
$ time make cmd/distributor/distributor
...
real	0m35.185s
user	0m0.813s
sys	0m0.379s

The .pkg directory was used for go build -i output - does this still happen with GOCACHE or is it all under .cache now?

Yeah it still happens.  I don't think the build caching will be a massive improvement, because we were installing the dependant libraries, although it should still help.  The big improvement here is the find filters, which were super slow when using docker for mac.

FWIW instead of mapping the filesystem from the mac into a Linux VM, I work entirely in the Linux filesystem.  You can map it outwards (e.g. using Samba) if you want to use a Mac editor.

Yes that works well too - I do all the build & test on my mac not even using the makefile (and produce mac binaries).  1.10 has massively sped up local dev.


implement shadow stacks

This PR implements shadow stacks.
Shadow stacks are enabled/disabled at compile time. AFAIK all processors supporting either AMD SEV-SNP or Intel TDX support shadow stacks, so no runtime checks are implemented. This also avoids the pitfall where the hypervisor lies about shadow stack availability to maliciously lower the security of the SVSM.
KVM intercepts accesses to the MSRs used for shadow stacks, so some host-side modifications are required to make this work.
I implemented a #CP exception handler to display diagnostic information when a shadow stack-related issue occurs. We might want to disable this exception handler for release builds and cause a triple fault instead. #CP exceptions are likely a sign of something fishy going on and we might want to terminate the guest just to be sure.
Currently, shadow stacks are disabled by default for a couple of reasons:

The KVM patches mentioned above are needed to make this work.
~We haven't implemented proper user syscalls (using syscall & sysret) yet and I don't want to hinder any efforts in that direction by forcing a proper syscall implementation to support shadow stacks out of the box. We should probably get syscalls without shadow stacks working first and once that's merged, we can add shadow stack support later and eventually enable shadow stacks by default.~
I haven't tested shadow-stacks together with enable-gdb yet, but I suspect this probably needs some additional work.

There are some open questions, one around the task-switch handling. I left a comment there. The other question is, whether there is a way to enable/disable this feature at boot-time, instead of compile time.

I added a patch that tries to detect CET support at runtime by enabling CET in CR4 and catching any faults that might occur if not supported. This still doesn't technically detect shadow stack support because AFAICT CPUs could theoretically only support CET lBT (indirect branch tracking) and not CET SHSTK (shadow stacks), but in practice no such CPUs exist (and AFAICT TDX only allows turning all of CET on or off, not individual sub-parts).

Finally, I found that it uses the old PageRef interface. Since the new one is merged now, this can be re-based on top of latest HEAD.

Done.

It doesn't look like this change is compatible with the existing #HV handling code.  For example, there is code in asm_entry_hv which specifically checks to see whether a recursive #HV has been delivered while executing an IRET sequence, and if so, it overwrites the old IRET data with the newly pushed IRET data.  The shadow stack equivalent of this code must be written, but it is also inherently unsafe, because it requires popping values from the shadow stack and using the WRSS instruction to write them to a previous location on the shadow stack.  Regardless of what approach we ultimately decide to take here, it is critical to support Restricted Injection correctly, and we can't allow shadow stack support to break it.

It doesn't look like this change is compatible with the existing #HV handling code. For example, there is code in asm_entry_hv which specifically checks to see whether a recursive #HV has been delivered while executing an IRET sequence, and if so, it overwrites the old IRET data with the newly pushed IRET data. The shadow stack equivalent of this code must be written, but it is also inherently unsafe, because it requires popping values from the shadow stack and using the WRSS instruction to write them to a previous location on the shadow stack. Regardless of what approach we ultimately decide to take here, it is critical to support Restricted Injection correctly, and we can't allow shadow stack support to break it.

Interesting, thanks for pointing that out, I'll take a look at that. Do you know if there are KVM patches implementing restricted injection that I can test with?

Do you know if there are KVM patches implementing restricted injection that I can test with?

Unfortunately, there are none that I am aware of.  However, I'm happy to review and test any changes you have in our environment which does support restricted injection.  Let me know if you want a more thorough description of how the existing #HV handler works and interacts with the IRET flow.

AFAIK all processors supporting either AMD SEV-SNP or Intel TDX support shadow stacks

That's not actually true.  The Zen3 architecture supports SEV-SNP but not shadow stacks.

AFAIK all processors supporting either AMD SEV-SNP or Intel TDX support shadow stacks

That's not actually true.  The Zen3 architecture supports SEV-SNP but not shadow stacks.

EPYC Milan (based on Zen 3) supports shadow stacks. I used an EPYC Milan based machine to test these patches.

EPYC Milan (based on Zen 3) supports shadow stacks. I used an EPYC Milan based machine to test these patches.

You are correct; I was misinformed.

It doesn't look like this change is compatible with the existing #HV handling code. For example, there is code in asm_entry_hv which specifically checks to see whether a recursive #HV has been delivered while executing an IRET sequence, and if so, it overwrites the old IRET data with the newly pushed IRET data. The shadow stack equivalent of this code must be written, but it is also inherently unsafe, because it requires popping values from the shadow stack and using the WRSS instruction to write them to a previous location on the shadow stack. Regardless of what approach we ultimately decide to take here, it is critical to support Restricted Injection correctly, and we can't allow shadow stack support to break it.

I added a patch to adjust the shadow stack in the #HV.

Do you know if there are KVM patches implementing restricted injection that I can test with?

Unfortunately, there are none that I am aware of. However, I'm happy to review and test any changes you have in our environment which does support restricted injection. Let me know if you want a more thorough description of how the existing #HV handler works and interacts with the IRET flow.

Could you please test my patches on your environment? I tried testing by manually adding int $28 to some places, but I still don't have a proper test setup, so I might have missed something. I also came across some bugs/regressions unrelated to shadow stacks, so I opened a separate PR to fix those: #466. You might need those changes to properly test the changes in this PR.

Could you please test my patches on your environment? I tried testing by manually adding int $28 to some places, but I still don't have a proper test setup, so I might have missed something. I also came across some bugs/regressions unrelated to shadow stacks, so I opened a separate PR to fix those: #466. You might need those changes to properly test the changes in this PR.

Other than the specific stack adjustment problem I commented on (the one that's missing), everything appears to work.  The other two shadow stack adjustments are correct.  And I found another problem with the #HV handler that's not addressed by your other PR so I'll submit a fix for that too.  Thanks for prompting me to review this code again!

KVM intercepts accesses to the MSRs used for shadow stacks, so some host-side modifications are required to make this work.

Not very relevant yet, but this is not true for TDX case. The CET/shadow stack related MSRs are handled natively for the guest (given that the feature is enabled for the guest during its creation via config) with no host involvement (wont be secure otherwise). TDX module ensures this. So you should be able to enable this for TDX without any host/kvm support (but enabling TD_PARAMS.XFAM[11] || TD_PARAMS.XFAM[12] - matching XSAVE[11],XSAVE[12] for a given guest).

There's still one issue. You changed the size of the exception frame, and you've adjusted most of the places that refer to the stack frame accordingly. However, the reference at line 151 was never updated, and it is now inaccurate. So this sequence:
        testl   $0x200, 18*8(%rcx)
        jz      postpone_hv

needs to become
        testl   $0x200, 20*8(%rcx)
        jz      postpone_hv

If I make that change locally, then everything works as expected (or would work, if all of the other #HV-related PRs were included).

Good catch, should be fixed now! Thank you very much for your review!

@joergroedel I think this PR is ready.

I just found one additional serious problem.
There are functions that generate page table flags to represent different page permissions.  However, some of these functions will make the PTE dirty without also marking it writable, and these functions will effectively generate shadow stack permissions, which is not correct for those permission types.  Specifically, all methods of PTEntryFlags other than PTEntryFlags::data() and PTEntryFlags::task_data() need to remove the DIRTY bit (anything that does not set WRITABLE should not set DIRTY).  These must be fixed or else the shadow stack logic will not be secure.

I just found one additional serious problem.
There are functions that generate page table flags to represent different page permissions. However, some of these functions will make the PTE dirty without also marking it writable, and these functions will effectively generate shadow stack permissions, which is not correct for those permission types. Specifically, all methods of PTEntryFlags other than PTEntryFlags::data() and PTEntryFlags::task_data() need to remove the DIRTY bit (anything that does not set WRITABLE should not set DIRTY). These must be fixed or else the shadow stack logic will not be secure.

Good catch! Should be fixed now.


ui: Update ResizablePanelGroup internals

This refactors ResizablePanelGroup and its Panel and Handle children. I originally planned to fix a bug where the panels don’t resize when one has been hidden but the fix needs more attention, so I’ll make a followup PR when it’s ready.
Bookkeeping via parallel PanelContext arrays is gone:

the group now has arrays of Panel and Handle

elements are stored on the components, there’s no longer indirection via specially-constructed ids (${ResizeHandleElIdPrefix}-${this.args.orientation}-${id})
the id seen there is instead derived from the component’s position in the array

ratio, length, and other properties are stored directly on Panel
this led to the removal of ember-ref-bucket

ResizeHandler is now Handle internally, ResizeHandle when exported.
@isHidden for a panel is now documented in Freestyle.
Tests now exercise horizontal orientation too. I thought of combining the horizontal and vertical tests as they’re identical other than using the appropriate dimensions but that seemed harder to understand. That means any new tests for the component would need to be added to two files, so if people think combining them is a good idea, I’m open to that.

I recall messing about freestyle usage stuff and the the resizable panel doesn't work exactly as expected.  Do u experience this?

I recall messing about freestyle usage stuff and the the resizable panel doesn't work exactly as expected. Do u experience this?

Which part? The isHidden definitely doesn’t, that’s what I’ll address in the followup.
Thanks for the earlier feedback, I’ll address it today 😀


Discussion: primary and accent colors

(I've opened this new issue to extend off of discussion in #167)
Colors are taken from https://www.google.com/design/spec/style/color.html#
I've taken a few screenshots of possible primary/accent color combinations. Please discuss what is good/bad about them. Also feel free to request more sample color combos / screenshots.

Primary
Accent
Hosts View
Settings View

Cyan
Deep Orange

Cyan
Cyan

Cyan
Light Blue

Cyan
Light Blue (lightened)

Light Blue
Blue

Light Blue
Light Blue

Light Blue
Light Blue (lightened)

Light Blue
Light Blue (slightly lightened)

Light Blue
Teal

cc @bengolds.
Thanks for fleshing out all the options, @rhansby!!
My vote is for Light Blue + Light Blue lightened or Cyan + light blue lightened.

Logo for reference

(added a cyan + light blue (lightened) sample)

(added a light blue + light blue (slightly lightened) sample)

OK my final vote is for  Light Blue + Light Blue lightened.

I vote for Light Blue + Light Blue (slightly lightened)

@rhansby & @jklein24 :
As far as I can tell, blue on blue would not be allowed according to the Google Material Design Guidelines, see:

https://www.google.com/design/spec/style/color.html#color-ui-color-application
[...] Limit your selection of colors by choosing three hues from the primary palette and one accent color from the secondary palette. [...]
[...] Don’t use the accent color for app bars or larger areas of color. Avoid using the same color for the floating action button and the background. [...]

As far as I can tell, with secondary palette it means a different color than the primary palette, which is also illustrated in the example there ("Primary - Indigo / Accent - Pink" in the example).
So the accent color has to be a different color altogether AFAICT.
The following would probably look nice:
Theme: Light
Primary: Cyan 500 (#00bcd4)
Primary Dark: Cyan 700 (#0097a7)
Accent: Light Blue A400 (#00b0ff) or Light Blue A700 (#0091ea)
Similar to what is shown in the following screenshot from Amaze File Manager (the screenshots shows Light Blue 500 (#03a9f4) and Blue 500 (#2196f3) as accent colors, because that's what Amaze File Manager allows for accent color selection, it does not offer the special accent colors with the "A" in front of the number):

I think the light theme really is key here. It looks much better with a light theme IMHO.
Regards

@wp9015362, your feedback is noted and appreciated, but we've gotten some feedback from some UX folks on our side (including some people on the material design team) who have recommended going with the light blue + light blue (slightly lightened). I at least think we can all agree it's an improvement over the orange :-).

@jklein24 please close this issue.

@jklein24 :
we've gotten some feedback from some UX folks on our side (including some people on the material design team)

If you don't mind answering, I am just wondering:
Is so many Google employees now actively maintaining ConnectBot (judging from the GitHub profiles of @kruton , @khorimoto , @rhansby , @jklein24 ) due to ConnectBot basically being a Google project (for @kruton it say's "Owner")?

@jklein24 :
I at least think we can all agree it's an improvement over the orange :-).

Yes we can :yum: .
Regards

ConnectBot is a project I started before Google. You can read up on Google's 20% time at various places, though.

Hi
Sorry for reopening this but I think this new theme suck. I've installed last release from here to get the last fixes but had to get back to v1.8.7 (fdroid).
My device is a Lt26i (aka Sony Xperia S) and with this theme I can't see/read properly many input text boxes, like url, passphrase, etc... that blue background shadow on those input boxes messes everything.
I have also problems with interface text/items appearing on top of each other, and problems when working on terminal, like keyboard doesn't open (show up).
Maybe it's related to the small HD screen/high ppi 342??
As for the theme colors, I dislike them very much, but would be ok if we could customize theme colors, within app settings, like many others..

@jklein24 :

I at least think we can all agree it's an improvement over the orange :-).

Yes we can :yum: .

You can only always speak for yourself.


Language tags

Atm. we have @nb hardcoded. We could perhaps use the value from 040 $b, and default to English.
I'm a bit puzzled by the definition for 040 $b in Marc21 Classification though: “MARC code for the language used in the textual portions of the record in the Note fields (6XX).” (https://www.loc.gov/marc/classification/cd040.html). Wonder why they chose to limit it to note fields.. In Marc21 Bibliographic the definition is more general.
For converting from ISO 639-2 to 639-1 I've used iso-639 before.

Yes, 040 $b is the right place. I've looked up in German DDC, it's in there with ger.


Rename wom_i2c.ino to wom۱_i2c.ino

I don't see any reason to merge this pull request, especially since it will cause the Arduino IDE to rename the file back to match the folder name.

Tanks


Update postMessage interface with methods to update segment and to navigate to other url

navigate is implemented in #1352
https://github.com/aeternity/aepp-base/pull/1352/files#diff-d552bf59583a76977d2e509b49224fe8R105-R107


Allow initialIndex, initialIndex in NativeRouter

Fix #4413
Need help with tests here, as this is not something I'm familiar with at the moment (yep 😔)

Codecov Report

:exclamation: No coverage uploaded for pull request base (v4@e3cc25a).

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3cc25a...489f767. Read the comment docs.

Travis seems to fail due to react-router-dom package

Yeah, don't worry about that. It'll get fixed soon.

Thanks, @IljaDaderko! 👍  Our tests are a bit spotty atm, but we'll get better.


ST-339 Case list view and filter change

Before creating a pull request make sure that:

[ x] commit messages are meaningful and follow good commit message guidelines
[x ] README and other documentation has been updated / added (if needed)
[x ] tests have been updated / new tests has been added (if needed)

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/ST-339
Change description
View list and filters changed
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ x] No

merged


trezor-suite's use of appimageTools makes it hard to use allowUnfreePredicate

Describe the bug
I tried my hand at this, but I'm not sure what to do since I'm not familiar with appimageTools.
It seems that the trezor-suite derivation sets "name" for the wrapType2 which produces the output.
The results in the version being part of the package name, which means I have this:
{
  config,
  lib,
  pkgs,
  modulesPath,
  inputs,
  ...
}:

{
  config = {
    nixpkgs.config.allowUnfreePredicate =
      pkg:
      builtins.elem (lib.getName pkg) [
        ### misc
        "google-chrome"
        "google-chrome-dev"

        # trezor-suite... is unfree?
        # "trezor-suite-23.12.3" # why's the version inside?
        # "trezor-suite-24.1.2" # why's the version inside?
        # "trezor-suite-24.2.2" # why's the version inside?
        "trezor-suite-24.3.2"
      ];
  };
}

Which is clearly not ideal.
How can we fix this? Or can we change the docs for allowUnfreePredicate so that it partially matches package name, etc?
Thanks for any tips.

Add a :+1: reaction to issues you find important.

I just realized this was marked broken. I might actually have a fix other than it being broken for whatever reason.

#262350 essentially

Thanks @eclairevoyant, maybe I'll go ahead and close this and subscribe to that issue. Thanks for the pointer.


Timed announcement

A plug-in to send an announcement to the announcement channel at a specific date and time.
This could be added to broadcast as well. Could potentially save a plug-in creation by adding an option to broadcast to a specific channel (e.g. #announcements) instead of only classes and adds the extra option for delayed broadcasts.

A friend worked on something similar to this if we need some inspiration:
https://github.com/amanzanero/cronnouncer


Feature Request - allow the use of UTF-8 characters in SSID

would be nice to use UTF-8 in SSIDs

I got stuck trying to solve this. Has anyone managed so far?

so i looked in to this a while back and this is what i figured out:

it is possible to send UTF-8 SSID (this was made possible after IEEE 802.11-2012)
from what i seen the library esp8266wifi  does not support it in it's current state ( i hope i am wrong about this part)
changing to a library that supports this (have not found one) will require to rewrite the whole project due to obvious reasons

but maybe you tried this from a different angle can you share your progress?

Thanks for answering. I've tried several things. Entered UTF-8 characters directly into the code, entered the hex code etc but neither worked. This guy  forked the code and just pasted emojis into the SSID names and it seems to work but I couldn't get it run on my ESP8266... 😎

https://github.com/m13253/wifijam/blob/master/esp8266/wifijam/wifijam.ino


Insecure password exposure in values.yaml

Creating issue related to hardcoded password in the values.yaml file:
At line https://github.com/eclipse-tractusx/sldt-discovery-finder/blob/0eb0393a89a54fce25655a062e57119a5642f483/charts/discoveryfinder/values.yaml#L85C1-L85C1 password is set to 'password'. Suggest to use existing postgresql secret with auto-generated password.
updates #https://github.com/eclipse-tractusx/sldt-discovery-finder/issues/64

Hi @tomaszbarwicki,
is this QG relevant or can it solved after QG?
At the moment we have a ticket about that topic created for another application. We are also already in contact with the DevSecOps team about that topic.

Hi @bs-sili, yes, let's fix it afterwards.

Hi @bs-sili , @tomaszbarwicki ,
great spotting of the plain-text password! There's another one in the same file:
https://github.com/eclipse-tractusx/sldt-discovery-finder/blob/0eb0393a89a54fce25655a062e57119a5642f483/charts/discoveryfinder/values.yaml#L53-L54


the components folder restructured

Thank you for contributing! To help the review process, please provide the following:
Proposal
Provide a short description of the change you are proposing and the reasons for it.
Related
Provide links to any associated pull requests or issues. You can use #123 to link to a PR or issue in this repository, or user/repo#123 to link to other repositories.
Checklist

[ ] I have read the code of conduct and contributing guide
[ ] I have made this pull request to the master branch
[ ] I have run all of the automated validation using npm run ship
[ ] I have added myself to the "contributors" list in the package.json (or do not want to)

I think you meant to make your PR to mnashawati/feedback-tracker not this repo.


Running Races

Added Running Races feature to the library. Defined in http://strava.github.io/api/v3/running_races/

These changes are just additions to the existing api wrapper. No changes to old features, so should be possible to promote in master.

Looks good to me. Thanks for the contribution!


[6.0.1][docs] Fix typo issue at Foundation_Build_Process.md

Clone of https://github.com/apple/swift-foundation/pull/876 for 6.0.1
Fix typo issue at Foundation_Build_Process.md

This is not a critical issue. I think it's fine to leave it out of 6.0.1

Dear @itingliu ,
Thank you for your feedback. I am clear now.
Thanks,
Lam


redocly: 1.17.0 -> 1.18.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/redocly/versions.
meta.description for redocly is: Makes OpenAPI easy. Lint/validate to any standard, generate beautiful docs, and more
meta.homepage for redocly is: https://github.com/Redocly/redocly-cli
meta.changelog for redocly is: https://redocly.com/docs/cli/changelog/
Updates performed

NPM version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.18.0 with grep in /nix/store/ccivczpnpy8ha2a5nb6x9s9j9pg8m5ax-redocly-1.18.0
found 1.18.0 in filename of file in /nix/store/ccivczpnpy8ha2a5nb6x9s9j9pg8m5ax-redocly-1.18.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

redocly

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ccivczpnpy8ha2a5nb6x9s9j9pg8m5ax-redocly-1.18.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A redocly https://github.com/r-ryantm/nixpkgs/archive/d91cb30da5c11b030b80a9cc3125a42f3866e9f0.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/d91cb30da5c11b030b80a9cc3125a42f3866e9f0#redocly

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ccivczpnpy8ha2a5nb6x9s9j9pg8m5ax-redocly-1.18.0
ls -la /nix/store/ccivczpnpy8ha2a5nb6x9s9j9pg8m5ax-redocly-1.18.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

redocly

Maintainer pings
cc @szlend for testing.

@NixOS/nixpkgs-merge-bot merge


Use correct language value in organization metadata

The translations weren't working for the organization block and
only english translations were used. This is fixed.
https://www.pivotaltracker.com/story/show/169257771

As you can see this class could be used by all possible entities and is only a helper to present metadata. So the situation you're describing is only applicable for EB and for example not for the Stepup metadata endpoint.
The logic you're describing was earlier on moved to \OpenConext\EngineBlock\Metadata\Factory\Decorator\EngineBlockServiceProviderInformation were the configuration is injected and all configuration fields are mapped accordingly.
This way the responsibility of presenting metadata is the responsibility of the metadata helper and the responsibility how name and description fields are mapped are the responsibility of the EngineBlockServiceProviderInformation-decorator. So this was needed for separation of concerns.
In order to fix the decorator it was needed and was therefore related.  Added a task to the PR.

Not sure this was introduced in this PR. But looking at the IdPs metadata, the UIInfo of the individual IdPs is no longer filled with their actual information. But the EngineBlock values are displayed instead.
I'll try to find where this was introduced and come back to this PR.

Note that this PR breaks on a JS securty warning that has already been resolved downstream. #805


Cant find Android Devices

Description
Cant find Android Devices In Replay Context
Steps to reproduce
I add my own android_home and android_sdk_root and adb paths In Path Environment,I can also use "adb devices" to find my phone.
but I can't find my phone at Replay Context.
My Own adb_version was 41,but I see the adb_version In renderdoc plugin was 40.
I also tried to kill my own adb-server and start the adb-server in renderdoc plugin,but it doesn't work.
Originally My PC can find Android Devices,but after I updated renderdoc v 1.28,it doesn't work now(maybe I changed something, because I didn't use rederdoc to capture Android for almost one month)
Environment

OS:Windows 10
Renderdoc Version: v 1.28 (also try v1.26)
graphics API(s) : Vulkan

I don't completely understand what you are describing.  Do you have a UI extension for RenderDoc that you are using?
You should make sure you only ever use one adb version across your whole system. Android is a completely terribly designed platform and adb is not backwards or forwards compatible so you must only use one version, and any conflict could cause adb to become non-functional.
Normally RenderDoc will use your Android SDK's adb, as long as it is configured to be located. Make sure that if you don't have the Android SDK configured with a global environment variable (ANDROID_HOME, ANDROID_SDK_ROOT, ANDROID_SDK, or ANDROID_SDK_HOME) that you configure the android SDK path in RenderDoc's settings under the android section.
Can you share the output from adb devices once you have configured the SDK correctly so that only one version of adb is in use?
Also since Android is a terrible platform sometimes devices are broken and have debugging capabilities disabled since different vendors customise Android in different ways. Do you have a different Android device you can test with to see if the problem only happens with one particular device?

renderdoc plugin means the folder plugin in renderdoc
I mainly to refer the adb.exe in renderdoc which paths is renderdoc/plugin/android/adb.exe
I configured all the environment variable (ANDROID_HOME, ANDROID_SDK_ROOT, ANDROID_SDK, or ANDROID_SDK_HOME)
you mentioned
The Output from adb devices is :
List of devices attached
3cb9d7c5        device
And I also test  3 other android phones,And I can also attach them with Another PC which has renderdoc.
Because my computer was able to run normally before, I think it was caused by some configuration errors?

Please do not run internal files within the RenderDoc folder manually, they are not intended to be run directly by users.
When you say you've tried other phones on another PC, do you mean you have the same problem there or that RenderDoc only fails to enumerate devices on the PC you're on right now, and works on a different PC?
Can you please start RenderDoc v1.28 and wait for 30 seconds to let it try to enumerate android devices, then send a manual error report from the help menu? Include this issue number in the description so that I know what it corresponds to.

RenderDoc only fails to enumerate devices on the PC you're on right now, and works on a different PC.
Yes It fails Only on this PC. And I sent the  manual error report with the title Cant find Android Devices.
Thank you so much

You are running RenderDoc as administrator. There is no reason to do this and it may cause adb to fail. Can you please run RenderDoc as a normal user and see if that resolves the problem?

I really just clicked it and open it.And In Windows taskmanager,In details ,I can also find renderdoccmd.exe and qrenderdoc.exe running with  normal user .
I resend another error report.

I also find that Adminstrator On In the upper left corner.I just double-click to run renderdoc, and when it opens, there will be an administrator logo in the upper left corner.
Also,The same applies to renderdoc on another computer, but renderdoc can attach normally on that PC.

Do you have UAC disabled or have your user configured as an unconditional/unelevated administrator?
Perhaps this is due to the company's security policy, and I am not sure how to fix it
Can you go to the interactive python shell and run this:and share the output?
Yes,It Outputs Nothing...

If it outputs nothing then something is wrong with adb, you will need to investigate that yourself and find out why it doesn't output anything when run from RenderDoc. If it works from the command line then you could look at the difference - it may be a permissions or environment issue but it's not a RenderDoc bug since unfortunately adb only offers the ability to run commands and parse the output so nothing is under RenderDoc's control.


Update launcher.py for infinite scrolling

changed the logic, so that you start again on the top page if you scroll further down on the last page.

You should be able to use:
  if pin == badger2040.BUTTON_UP:
        state["page"] = (state["page"] - 1) % MAX_PAGE
        render()
    if pin == badger2040.BUTTON_DOWN:
        state["page"] = (state["page"] + 1) % MAX_PAGE
        render()

Which will keep state["page"] between 0 and MAX_PAGE, since:
>>> math.fmod(-1, 2)
-1.0
>>> -1 % 2
1

(because Python is weird, yay)
Your approach works because Python's list support negative indices and ranges:
>>> list("abcdef")[-1]
f

But having -1 in the saved launcher state would be a little weird!


Item filter not working

Issue description
Either i dont know how to use it or it is just not working, plz help.
Steps to reproduce
No response
Minecraft version
1.21.1 (Latest)
Fabric loader version
0.16.9 latest
Fabric API version
Latest
Oritech version
Latest
Other relevant versions
No response
If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)
No response

Well i place in a chest, add an item pipe that goes to the item filter, and exactly on the oppelosite side, another item pipe to another chest, i toggle extraction mode on the first chest item pipe and on the output side of the item filter, and anything in the first chest would get stuck in the item fikter as i see it with jade upon hovering over it, and it wouldnt go into the second chest.

Can you provide a small picture/video? The item filter needs to face the target storage in order to work

Yeah about that, it seems i actually DIDN'T knoelw hoe to use them, as i placed the


How does UDOT handle space?

In your blogpost you mention:

The space is printed by pushing a fake "digit" that will get converted into a space.

but if I read correctly https://github.com/NieDzejkob/miniforth/blob/2842b9a303c07d8d8ace8dc890c531d55866348e/boot.s#L326-L345
You go:

from " " - "0" = 32 - 48 = -16 https://github.com/NieDzejkob/miniforth/blob/2842b9a303c07d8d8ace8dc890c531d55866348e/boot.s#L328
to -16 + "0" = 32 https://github.com/NieDzejkob/miniforth/blob/master/boot.s#L337
to 32 + "A" - "0" - 10 = 32 + 65 - 48 - 10 = 39 ≠ 32 https://github.com/NieDzejkob/miniforth/blob/2842b9a303c07d8d8ace8dc890c531d55866348e/boot.s#L340

Am I missing something or should "A" - "0" - 10 be "A" - "0" - 17 ?

The part that that adds "A" - "0" - 10 won't run because 32 is less than
"9" = 57.

🤦 I need to sleep !!! Sorry!


Add Debian 9 builds to CI

It would be nice to have builds for Debian 9

@EliSnow we've added a Debian 9 (Stretch) build and they'll be published via the normal CI flow moving forward. We'll get around to updating the downloads page of our website, and I also went ahead and added a Debian 9 binary to the latest release:
https://github.com/pipelinedb/pipelinedb/releases/tag/0.9.7u8
Thanks for the suggestion!

Also, Debian 9 introduced some changes to the libreadline packaging, so you may have to do something like this:
apt-get install libreadline7

Thank you!


feat: support specify mac addr via annotation

Pull Request Description
Describe what this PR does / why we need it
Introduce a new feature: support specifying MAC address via pod annotation.
Does this pull request fix one issue?

Fixes #190
Describe how you did it

Verify the validness of specified MAC address in validating webhook;
Check whether the specified MAC address is in conflict with existing IP instances.

Describe how to verify it
Special notes for reviews

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

What's the new feature for? I'm asking this because pod MAC address is not "exported" for hybridnet, in another word, a pod will always use the MAC address of its local node to communicate with the pods on other nodes.

What's the new feature for? I'm asking this because pod MAC address is not "exported" for hybridnet, in another word, a pod will always use the MAC address of its local node to communicate with the pods on other nodes. The same as CNI ipvlan.

Yes, it's true that user-specified MAC address is not necessary in terms of communicating with pods on other nodes. But we've also seen the need in some "non-communication" scenarios, e.g., internal auditing or generating product license. So I think it's more like a nice-to-have feature with no interference in core data-plane functionality.

Could you please provide a sample usage for this feature in "Describe how to verify it" section?
I've noticed that a pod's MAC address can be specified with an "networking.alibaba.com/specified-mac" annotation. What will happen if the pod is create as a part of deployment? One specified MAC address for a pod seems not work out.
Maybe it should be implemented similarly as "networking.alibaba.com/ip-pool", which we already have.

Could you please provide a sample usage for this feature in "Describe how to verify it" section?

OK, edited!

I've noticed that a pod's MAC address can be specified with an "networking.alibaba.com/specified-mac" annotation. What will happen if the pod is create as a part of Deployment or StatefulSet? One specified MAC address for a pod seems not work out.
Maybe it should be implemented similarly as the annotation of "networking.alibaba.com/ip-pool", which we already have in wiki docs.

Current implementation is only for single pod scenario and does not support workloads like Deployment or StatefulSet. Unlike IP retain, specifying static MAC address shouldn't be limited to stateful workloads. I think that specifying a "MAC-Pool" would be great, and it will require some additional work.

Could you please provide a sample usage for this feature in "Describe how to verify it" section?

OK, edited!

I've noticed that a pod's MAC address can be specified with an "networking.alibaba.com/specified-mac" annotation. What will happen if the pod is create as a part of Deployment or StatefulSet? One specified MAC address for a pod seems not work out.
Maybe it should be implemented similarly as the annotation of "networking.alibaba.com/ip-pool", which we already have in wiki docs.

Current implementation is only for single pod scenario and does not support workloads like Deployment or StatefulSet. Unlike IP retain, specifying static MAC address shouldn't be limited to stateful workloads. I think that specifying a "MAC-Pool" would be great, and it will require some additional work.

Fine. If only for a single pod, maybe this should be considered as a feature for developers (of k8s controllers) but not for all the users. Looks good for me, cc @mars1024 .

Please rebase main branch to fix the golangci-lint error.

This PR is closed since IPAM module is refactored a lot and leads to multiple conflicts. I will open another PR on supporting mac address pool assignment.


[Bug]

Bug report
In the controller method setupCreateOperation Field with the select2_nested type, the depth field is not updated on save.
MYSQL VERSION
Mysql 5.7
PHP VERSION:
PHP 7.3.2 (cli) (built: Feb  5 2019 22:55:35) ( ZTS MSVC15 (Visual C++ 2017) x64 )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.2, Copyright (c) 1998-2018 Zend Technologies
with Xdebug v2.7.0, Copyright (c) 2002-2019, by Derick Rethans
LARAVEL VERSION:
v8.12.3@6707480c5f0db7aa07537f9ad93255b64b65b85e
BACKPACK VERSION:
4.1.26@ae68ca24844929ac38d2e792197551e823c43570

Hello @potkot
Thanks for raising this issue.
From my understanding select2_nested is not intended to save the depth, it's intended to show you the items you can select with some depth ordering (that you should previously setup in your model: https://backpackforlaravel.com/docs/4.1/crud-fields#select2_nested)
I don't think there is a bug here, if I am wrong, please re-open.
Best,
Pedro


Add ability to filter out pending jobs (part feature, part bug)

When we run A big scenario against hkube (hkube_qa), hkube can get filled with jobs to the point where It only has room to display pending jobs. In the current scenario there are 500 jobs. The UI can only display the first 100 or so
There needs to be a way to see all the non-pending jobs
It will also be helpfull to be able to filter by status.
I have currently been waiting for a couple of hours not realizing the system was stuck because I assumed that hkube was handling jobs not in the UI.
Also given the limitation of 100 jobs it will also be a good idea to provide perhaps some sort of pagination interface or an ability to choose the amount of jobs displayed in the UI.

will fix in job search api   #1446


Remove development logging at INFO

Make to FINEST:
14:31:17,257 INFO  [org.kontinuity.catapult.web.api.CatapultResource] (default task-21) Redirect issued to: https://<IP_ADDRESS>:8443/console/project/jboss-eap-quickstarts/overview/

e8e11e9


Incorrect parsing of tuple

Tuple type; Tuple[X, Y] is the type of a tuple of two items with the first item of type X and the second of type Y.
Example: Tuple[T1, T2] is a tuple of two elements corresponding to type variables T1 and T2. Tuple[int, float, str] is a tuple of an int, a float and a string.
To specify a variable-length tuple of homogeneous type, use literal ellipsis, e.g. Tuple[int, ...]. A plain Tuple is equivalent to Tuple[Any, ...], and in turn to tuple.

Fixed in version 0.5


[BUG] - Errors when dismantling prebuilds using DragRemoveBuildTool.

Describe the bug
Got IndexOutOfRangeException.
To Reproduce
Steps to reproduce the behavior:

Go to Delete option.
Click on the Area Selection button.
See error

Log files
output_log.txt

This issues seems to only happen if prebuilds are in selection. Should be fixed in the next release.

Thank you.


[OC-140] Declarative templates initialisation on a registry level

Templates declaration is now more explicit when configuring the registry (same API as per the node client):
conf = {
...
templates: [require('oc-template-react')]
...
}

Merged. @nickbalestra can you publish and update the wiki? Cheers.

@matteofigus done (0.41.0 out and wiki updated)


Update Deploy.yml

This PR will do two things:

Run CI on pull requests, without deploying the page
Allow the repo owner(s) to trigger a new build via the GitHub interface via workflow_dispatch.

I already removed my branch for #7, so that's why I created a new PR.

So, its just a suggestion. Maybe, you don't really want to collaborate on the site or check changes by others. If you want to really check that there aren't any errors, you can do something like I mentioned in https://github.com/tlienart/Franklin.jl/issues/785. I'm using this successfully and for a long time already here and here

We definitely want this to be a collaborative website ! Thanks for the PR


feat: add tool calling flags

Adds missing flags required for tool calling using vLLM. Tool call parser names have been taken from vLLM's OpenAI compatible server docs.
I only added the variables to 0.6.3 and above, because Llama function calling support seems to have been added around this time.

Closes #113


performance fixes for rna import

Resolves #1436
Increases batchSize to 2000 and restricts featureSetName lookup to the list passed into rnaseq2ga()
With these changes a test dataset load went from 6 minutes (37K entries with feature lookup) to 12 seconds (37K entries no feature lookup) on an underpowered laptop

Uh, yes please!


PR: Save file before running

Description of Changes
Save files before running when running files from the kernel

[ ] Wrote at least one-line docstrings (for any new functions)
[ ] Added unit test(s) covering the changes (if testable)

[ ] Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

Hello @impact27! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/plugins/ipythonconsole/comms/tests/test_comms.py:

Line 40:1: E722 do not use bare 'except'
Line 178:1: E305 expected 2 blank lines after class or function definition, found 1

Could someone have a look at the windows test fails?

@impact27, please remove all merges in this branch and leave a single one with master.

@impact27, this is ready. Please don't more commits here.


Add .github/ISSUE_TEMPLATE.md

Where I work, we use https://github.com/CuBoulder/express/blob/dev/.github/ISSUE_TEMPLATE.md, and that has helped make our issues much more complete and standardized.
...and that is in a team where we are in the same location most of the time, lol, and still write crappy tickets. So, for an open source project with the potential for many "It's broken" issues, I think adding an issue template would be a good idea.

We do use issue templates for many other Vue repos and I've thought about adding one for this one as well, but despite the fact that we get some poor descriptions occasionally, it's not actually too often. I'd also rather get someone's poorly described feedback that I can follow up on and ask questions about, than risk losing potentially valuable feedback with too much bureaucracy.
Does that make sense?

Just my 2 cents ..
If the members (i.e. powers that be) comments on an issue with some finality, should probably close it. Might also want to close dormant issues and where a response isn't heard from the OP or others in several months.

Agreed.
We often times delete all of the template's sections when submitting issues anyway so requiring an issue template for people to fill out could de-motivate them from submitting an issue.


Token Sale Proxy

contract for the proxy box that the buyer sends funds to (or their whitelist token) to obtain a Token/NFT/card pack.
this box interacts directly with the token sale tx instead of the buyer's PK.


add getter as public api for ErrorUtils._globalHandler

As discussed here #1194 . This add an getter the default handler, so that custom handler can be added (monkey patch?) without overwriting the default handler

This seems useful.
@facebook-github-bot shipit


Make login flow more customizable

Especially form validation.
See https://groups.google.com/forum/#!topic/weppy-talk/gmlTVx5fOCs

"for humans", then i seen this... OK :D


Consumer Report Permissible Purpose Object

https://github.com/viceroypenguin/Going.Plaid/blob/master/src/Plaid/Entity/LinkTokenCreateRequestConsumerReportPermissiblePurposeObject.cs
This is the link to the file.
LinkTokenCreateRequest class, type for ConsumerReportPermissiblePurpose is changed to Entity.LinkTokenCreateRequestConsumerReportPermissiblePurposeObject which was earlier an ENUM but now the new class/type doesn't have any value/property in the class
[JsonPropertyName("consumer_report_permissible_purpose")]
public Entity.LinkTokenCreateRequestConsumerReportPermissiblePurposeObject? ConsumerReportPermissiblePurpose { get; set; } = default!;

Addressed in db9a7a8ab75909059317550708df1b1c05badec8, released as v6.31.1.


Segues taking a long time to perform

Hello. My code is set up so that when it a barcode is scanned it will segue to another view controller. When a barcode is scanned and read, it takes about 10 seconds before it segues into the next view controller. Is it supposed to take this long?

I just had to put my UIKit code in an async block.


Ex2 Task 8 Debug Shader can't find hlsl file

When I attempt to do Ex2 Task 8 Debug Shader, the debugger can't find the hlsl file

I have the same problem. Don't know why, but it also does only happen on some computers. The error occurs eventhough all symbols seem to be loaded correctly.

What version of the Diagnostics Tools are you using? This is because of a bug in an earlier version of the tools. Not sure if it's fixed yet but will check it.

I have VS2015 Enterprise with Update 3. Version says 14.0.25421.03, but I don't know where to find the version of the Graphics Debugger tool.


command: Add jump to perform a relative goto

This is the second try to properly solve #2897, by adding an additional function for relative goto's without affecting the existing one.
Fixes #2897

Works like a charm for me, thanks a lot!!


fix: acorn secrets reveal and general non-table output (#1812)

We had 3 problems here:

Secret was printed twice because we were putting the source object into buffer once for every secret data key
[General] Due to the map[string]any type output, the object fields (e.g. managed fields) were not cleaned anymore
Secret data values were not encoded as it printed the plain objects, where the secret data values fields are []byte

Ref #1812
Checklist

[ ] The title of this PR would make a good line in Acorn's Release Note's Changelog
[ ] The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
[ ] All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
[ ] Commits follow contributing guidance
[ ] Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
[ ] Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
[ ] PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

Now some more tests are failing, because the list output is cleaned (again, as it looks like it was done before) from Acorn labels and some more stuff... question is if we really want that to happen, since some acorn.io labels may be valuable to the user, right?


Bug: OffsetCommit failed for mixed subscribtion on Kafka topic

Describe the bug
When subscribing to a topic through a coordinator and to partitions directly using one group_id, an error occurs, making consuming of messages is imposible.
How to reproduce
Include source code:
import logging

from faststream import FastStream
from faststream.kafka import KafkaRouter, TopicPartition, KafkaBroker

router = KafkaRouter()

@router.subscriber(
    't1',
    group_id='cg1',
)
async def handle_group(msg):
    print('handle_group')

@router.subscriber(
    group_id='cg1',
    partitions=[TopicPartition('t2', 0), TopicPartition('t2', 1)]
)
async def handle_partition(msg):
    print('handle_partition')

broker = KafkaBroker(
    log_level=logging.INFO,
    graceful_timeout=5.0,
)
broker.include_router(router, prefix='rtr_')

app = FastStream(broker)

And/Or steps to reproduce the behavior:

...

Expected behavior
Works fine and consume messages from both topics
Observed behavior
Got an error in logs:
24-07-05 16:52:04,221 INFO     - FastStream app starting...
2024-07-05 16:52:04,228 INFO     - rtr_t1            | cg1 |            - `HandleGroup` waiting for messages
Topic rtr_t1 not found in cluster metadata
2024-07-05 16:52:04,343 INFO     - rtr_t2-0,rtr_t2-1 | cg1 |            - `HandlePartition` waiting for messages
Topic rtr_t2 not found in cluster metadata
2024-07-05 16:52:04,451 INFO     - FastStream app started successfully! To exit, press CTRL+C
OffsetCommit failed for group cg1 due to group error ([Error 25] UnknownMemberIdError: cg1), will rejoin
OffsetCommit failed for group cg1 due to group error ([Error 25] UnknownMemberIdError: cg1), will rejoin
Auto offset commit failed: [Error 25] UnknownMemberIdError: cg1
OffsetCommit failed for group cg1 due to group error ([Error 25] UnknownMemberIdError: cg1), will rejoin
OffsetCommit failed for group cg1 due to group error ([Error 25] UnknownMemberIdError: cg1), will rejoin
Auto offset commit failed: [Error 25] UnknownMemberIdError: cg1
OffsetCommit failed for group cg1 due to group error ([Error 25] UnknownMemberIdError: cg1), will rejoin
OffsetCommit failed for group cg1 due to group error ([Error 25] UnknownMemberIdError: cg1), will rejoin
Auto offset commit failed: [Error 25] UnknownMemberIdError: cg1

Environment
Running FastStream 0.5.14 with CPython 3.11.4 on Linux

Your example is inherently flawed because you are specifying two different topics for the same consumer group. Use a single topic for one consumer group.

Seems like you are using Kafka in a wrong way and this problem does not related to FastStream iself. Please, reopen the Issue if you don't agree

Is there a problem to use one consumer group ID for several Kafka topics? I didn't find any restrictions in the Kafka architecture or its documentation. If you have any other information, please let me know.

Is there a problem to use one consumer group ID for several Kafka topics? I didn't find any restrictions in the Kafka architecture or its documentation. If you have any other information, please let me know.

This looks like an issue with aiokafka rather than an issue with FastStream or a restriction from Kafka. There are multiple issues from multiple time period indicating the same issue in aiokafka - https://github.com/aio-libs/aiokafka/issues/880, https://github.com/aio-libs/aiokafka/issues/575, https://github.com/aio-libs/aiokafka/issues/727.
@dem214 The example you have mentioned works with confluent-kafka library without any change.
import asyncio
import logging

from faststream import FastStream
# import from faststream.confluent instead of faststream.kafka
from faststream.confluent import KafkaRouter, TopicPartition, KafkaBroker

router = KafkaRouter()

@router.subscriber(
    't1',
    group_id='cg1',
)
async def handle_group(msg):
    print('handle_group')

@router.subscriber(
    group_id='cg1',
    partitions=[TopicPartition('t2', 0), TopicPartition('t2', 1)]
)
async def handle_partition(msg):
    print('handle_partition')

broker = KafkaBroker(
    log_level=logging.INFO,
    graceful_timeout=5.0,
)
broker.include_router(router, prefix='rtr_')

app = FastStream(broker)

# Added to publish a message to topics rtr_t1 and rtr_t2
@app.after_startup
async def publish_msgs() -> None:
    async def _publish_msgs() -> None:
        await asyncio.sleep(5)
        print("Publishing messages")
        await broker.publish({"name": "Alice"}, topic="rtr_t1")
        await broker.publish({"name": "Bob"}, topic="rtr_t2")

    asyncio.create_task(_publish_msgs())

If you need the behaviour you have mentioned, you could use confluent-kafka instead of aiokafka.


IOS: Problem with notification

notification is shown when app is background but  when app is foreground notification does not show.
here is my payload:
{
"to":"token",
"notification":{
"title":"test",
"body":"great match!",
"show_in_foreground": true
},
"data" : {
"title" : "test",
"body" : "body"
},
"priority": "high"
}
also presentLocalNotification does not show the notification ios.

"show_in_foreground" should in data

@TarunDas005 did you solved it ?
@evollu I'm facing this issue too. Here's my payload :
{
  "to": token,
   "notification": {
    	"body": "Hey there",
    	"sound": "default"
    },
    "data": {
    	"show_in_foreground": "true",
    	"priority": "high"
    }
}

Any idea ?

try
{
  "to": "token",
   "notification": {
    	"body": "Hey there",
    	"sound": "default"
    },
    "data": {
    	"show_in_foreground": "true"
    },
    	"priority": "high",
   "content_available": true
}


boards: nucleo_l432kc: fix GPIO definitions

The ST Nucleo L432KC board only has a reset switch and not user switch.
It has a single user LED connected to PB3, and called LD3 in the ST
documentation.
This patch fixes the corresponding device tree definition. At the same
time also it also fixes the documentation, where the name of the power
and user LEDs are swapped.
Signed-off-by: Aurelien Jarno<EMAIL_ADDRESS>This patch allows me to run basic/blinky example and get LD3 blinking. Note however that configuring PB3 in push-pull output or in open-drain with the output low causes the USART2 RX to stop working. I have spend some time investigating and I wonder if my board is somehow broken.

Codecov Report

Merging #7641 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7641   +/-   ##
=======================================
  Coverage   55.31%   55.31%
=======================================
  Files         469      469
  Lines       51907    51907
  Branches     9923     9923
=======================================
  Hits        28713    28713
  Misses      19271    19271
  Partials     3923     3923

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e5b021...0de6546. Read the comment docs.


Added some basic benchmarks	new file:   benches/basic.rs

new file:   benches/testfile.txt

LGTM, thanks for the PR! I like how you used the code itself as the data for benchmarking.


Update HHVM to 3.15

Please update hhvm to 3.15, since it's a new LTS release, thank you

Sorry for a delayed reply. We no longer support HHVM. Please use PHP 7.
We are cleaning up issue tracker and closing this issue because we won't be able to contribute to this discussion further.
Please use http://community.rtcamp.com/c/easyengine for future support questions.


Fix start script

The start script wasn't updated when the content to be served was moved to the dist directory.

Thanks! I don't think we need to bother publishing this change - this script is just for local development.


⚠ Bofrost.lu has degraded performance

In 1301338, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1173 ms

Resolved: Bofrost.lu performance has improved in f5587c2 after 54 minutes.


testing

Summary

Changelist

Testing Done

Resolved Issues

Checklist
Please change [ ] to [x] when you are ready.

[ ] I have read and followed the code conventions detailed in README.md (This will save time for both you and the reviewer!).
[ ] If this pull request is longer then 500 lines, I have provided explicit justification in the summary above explaining why I cannot break this up into multiple pull requests (Small PR's are faster and less painful for everyone involved!).

Lame

Seems like they aren't triggered but are required? ...Can we remove branch protections, think it could be a repo settings thing :)


Add House of Cards to TV shows

@gsrajadh fix the conflict and I will merge it. thanks =)

@jdorfman resolved :)

This is a duplicate and I think it was my fault by not being proactive. My apologies. =( Closing


Radar chart does not work with beginAtZero

Expected behavior
Chart center must be at 0 when min:0 and beginAtZero is set
Current behavior
Fields are ignored or there is second scale appearing if used in "scales" object:
Reproducible sample
https://codepen.io/FlexCoral/pen/MWEGJed
Optional extra steps/info to reproduce
No response
Possible solution
No response
Context
Here is page that I am trying to fix: https://wz2100-autohost.net/players/3
After clicking on "Load research classification" a chart will be rendered with issue I am interested in.
Configuration used on website:
{
        type: 'radar', parsing: false, normalized: false,
        data: {
                labels: Object.keys(resp),
                datasets: [{data: Object.values(resp), fill: true, label: '{{.Player.Name}}', borderColor: '#0d6efd'}]
        },
        options: {spanGaps: true, showLine: true,
                animation: {duration: 20}, responsive: true, maintainAspectRatio: false,
                plugins: {
                        legend: {position: 'top'},
                        title: {display: true, text: title, position: 'top'},
                        subtitle: {display: true, text: subtitle}
                }, radius: 3,
                scale: {ticks: {
                        beginAtZero: true, min: 0
                }}
        }
}

chart.js version
v3.7.0
Browser name and version
Firefox 97 nightly
Link to your project
https://wz2100-autohost.net/

min and beginAtZero are no longed under ticks in v3.
https://codepen.io/kurkle/pen/PoJeWme

Yep, Just now realized that correct config would be scales: {r: {beginAtZero: true, min: 0}}, maybe improve docs on that?

Yep, Just now realized that correct config would be scales: {r: {beginAtZero: true, min: 0}}, maybe improve docs on that?

Sure, I reopened this and labeled it documentation. Would you be able to submit a PR ?

Actually, no, it is not a docs problem, it is just me not reading docs in the right order and/or completely blanking places where it is said that it should be "r" scale and it follows linear radial parameters. Sorry for noise...


jupyter-server cannot co-habitate with cirq --pre

Description of the issue
In a fresh virtual environment for Python 3.10
$ pip install jupyter jupyter-server
$ pip install --pre cirq
...
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
jupyter-events 0.9.1 requires jsonschema[format-nongpl]>=4.18.0, but you have jsonschema 4.17.3 which is incompatible.
jupyterlab 4.1.4 requires httpx>=0.25.0, but you have httpx 0.23.3 which is incompatible.
jupyterlab-server 2.25.4 requires jsonschema>=4.18.0, but you have jsonschema 4.17.3 which is incompatible.
referencing 0.33.0 requires attrs>=22.2.0, but you have attrs 21.4.0 which is incompatible.

After this jupyter notebook fails to start with TypeError from the referencing package.
An attempt to install jupyter-server with existing notebook requirements fails to resolve a compatible set of packages:
$ pip install -r dev_tools/requirements/notebooks.env.txt jupyter-server
... 30 minutes of trial resolutions ...
ERROR: Exception
pip._vendor.resolvelib.resolvers.ResolutionTooDeep: 200000

Note: jupyter-server can be installed with cirq-core so the incompatible requirement is in some other cirq-something-not-core package.
Proposed Solution
Update package dependencies so they are compatible with jupyter-server requirements.
Cirq version
1.4.0.dev at dc1065d4c393453cde17e0ae6a2089efa3edef2d.

Typically we don't install cirq but rather cirq-core, cirq-google, etc to bring in a minimal set of dependencies. I suspect it's one of the other cirq-* packages that is actually causing a problem here.

I installed the subpackages one by one, it looks like the issue comes from cirq-rigetti which depends on an old version of pyquil<4.0 which has the transitive dependency on old jupyter. pyquil is no at 4.8 so I think changing this line https://github.com/quantumlib/Cirq/blob/0f4822b1ee85373c675222a22040d7f75adc6e60/cirq-rigetti/requirements.txt#L1
to pyquil~4.8.0 should fix the issue

better you check this PR: https://github.com/quantumlib/Cirq/pull/6281


Update requirements.txt

issue #385
Impacted Areas in Application
It will only affect the version of dependicies to be downloaded
Ii have also tested it

@adeyosemanputra please review this PR , Any suggestions of you  would be admired and I will implement those


create: Add missing flags to re-create script

A few flags were missing from the re-create command output.
Also since the interfacer has been deprecated due to it being prone to bad suggestions, we remove it from this repository.

/lgtm


request help: How to use the Coraza waf plugin by configuring CRD？

Issue description
There are relatively few documents on Coraza on the official website, and even when using the admin API, I can hardly see any Coraza documents. I would like to use the generated CRD resources to configure and use Coraza WAF. How should I configure CRD?
I see these are some rules, but I don't know how to configure them to take effect either
https://github.com/coreruleset/coreruleset/tree/v4.0/dev/rules

Have you looked at this doc? https://apisix.apache.org/blog/2023/09/08/APISIX-integrates-with-Coraza/

I have seen it, but this only provides the simplest demo and we are not sure how to configure the complete rules

Do you have any more detailed documents or examples?


What's wrong with this file?

Hello,
Can you tell me what's wrong with this GPX file? I can read it on other tools without any problem.
Thanks in advance for your help.
Best regards,
Mélanie.

The file uses the tag gpxtpx:TrackPointExtension without including the schema that defines it (xmlns:gpxtpx="http://www.garmin.com/xmlschemas/TrackPointExtension/v1").
You can use any XML validator to find the errors. For more thorough validation, you can also use Garmin Basecamp in debug mode and check the logs.


Error Inflecting class

I am getting this on kitkat devices java.lang.NoClassDefFoundError: org.threeten.bp.DayOfWeek.
Can you help me to solve it.

Try adding compile 'com.jakewharton.threetenabp:threetenabp:1.0.3' to your dependencies.

Hello It Shows me an Error Like this Error:Execution failed for task ':app:packageAllDebugClassesForMultiDex'.

java.util.zip.ZipException: duplicate entry: org/threeten/bp/chrono/AbstractChronology.class

sorry my bad. Could you try adding compile 'org.threeten:threetenbp:1.3.1' instead of what i mentioned above

I have the line:
compile 'org.threeten:threetenbp:1.3.1'
and the error persist
java.lang.NoClassDefFoundError: org.threeten.bp.DayOfWeek


Fixed Power BI Desktop Version

Based on the version I downloaded it should be 2.61.5192.641 instead of 2.61.5192.64 (assume it was a typo)

@nojetlag : Thanks for your contribution! The author, @jtarquino, has been notified to review your proposed change.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

powerbi-docs/report-server/changelog.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@nojetlag : Thanks for your contribution! The author, @jtarquino, has been notified to review your proposed change.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] An exception occurred during the build process. Please check the raw log and retry building your content again. If the issue persists, please open a ticket in http://SiteHelp and include the URL of publishing report.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@maggiesMSFT : Thanks for your contribution! The author, @jtarquino, has been notified to review your proposed change.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

powerbi-docs/report-server/changelog.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Allow constructor wildcarding in AccessTransformers for non-abstract classes

Link to: https://github.com/neoforged/JavaSourceTransformer/issues/34
We have ATs that make the constructor of all non-abstract blocks be public and soon we will do the same for Particles. It would be nice to have a way to specify ATing constructors in bulk for these cases. How that looks, no idea. It will also need to not apply to mod's own blocks too.
For PRs like this: https://github.com/neoforged/NeoForge/pull/1244

closing in favor of gradle task: https://github.com/neoforged/NeoForge/issues/1317


Added option for Bold Text in Editor

Fixes #932
Description:

Re-used the dropdown component to create a new one for controlling font-weight in Settings.
Added bodyFontWeight as an option to the editContext and implemented it in the Output section
Customized the functionality and styling of DropdownItem for this new option

Screenshots:

Output when bold is chosen:

Dropdown Menu for Font Weight:

Nice work @N-Shar-ma . 🔥🔥🔥
We have some bonus work for the awesome_portfolio branch. Do check it out if you wish to.


Documentation website freezes when clicking the Pizza Party button repeatedly

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Website should not freeze.
What is the current behavior?
Website freezes, and stops functioning.
What are the steps to reproduce?
Click the Pizza Party button repeatedly @ (https://material.angular.io/components/component/snack-bar)
Spam left mouse button.
Providing a Plunker (or similar) is the best way to get the team to see your issue.
Plunker template: http://plnkr.co/edit/o077B6uEiiIgkC0S06dd
What is the use-case or motivation for changing an existing behavior?
Site shouldn't break.
Which versions of Angular, Material, OS, browsers are affected?
No idea, its on https://material.angular.io/components/component/snack-bar. I'm using Google Chrome.
Is there anything else we should know?
https://material.angular.io/components/component/snack-bar

This was fixed with https://github.com/angular/material2/pull/2392, but hasn't been released yet.


Improve performance a little bit

1. Why is this change necessary?
Don't use sCheckUser method on detail page,
because it's slow and not really used.
2. What does this change do, exactly?
Only check the session state. It is enough.
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Because the detail page is cached, you could drop it completely, because the logged in state is useless on a cached page

Because the detail page is cached, you could drop it completely, because the logged in state is useless on a cached page

It's used in the rating action. Additionally it would be breaking change.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-25408
Please use this issue to track the state of your pull request.

Thanks for your Contribution! 💙


Run Unittests in docker

Builds on PR #4 docker-compose.
The coverage report was returning 0% for me, so this fixes that and also prints it to both a stdout and a file.

Unit tests shouldn't need to run in docker - the coverage config is just setup to put out to codeclimate which is working as expected: https://codeclimate.com/github/samrussell/chewie


How to edit my.conf

Hi there,
I want to add some config to my.conf but "command not found".
So i need to install an editor like: vi, vim, nano but can't.
Can you help me check this..

apt-get update
apt-get install vim


Separate release and debug diagnostics

Describe the solution you'd like
In HockeyApp was a very useful feature which allows to separate uploaded debug builds being internally tested and diagnostics (crash reports and e.t.c) collected from them from data, collected with real production users and released builds.
AppCenter SDK, according to the docs, does not have any equivalents for [[BITHockeyManager sharedHockeyManager] configureWithBetaIdentifier:liveIdentifier:delegate]
It is very useful to have a built in way to separate diagnostics collected from released builds and all others as it was available in HockeyApp
Describe alternatives you've considered
Speaking to a support engineer we were assured that now there is the only way to do what we want and it's to create 2 different app items in AppCenter and implement diagnostics separation by ourself.

Hey thanks for the feature request! This isn't on our immediate roadmap but we will continue to monitor this issue for feedback and interest.

I second this feature request.  Creating 2 separate apps in App Center for each app that my company publishes seems like a hassle.  It would be much better to just be able to filter diagnostics by debug or release.


Synchronise hostnames in inventory.yml to jenkins host

The hostnames in the inventory.yml have been changed to match the hostnames in the jenkins inventory.
Fixes: #619

closing as this is the wrong approach, we should work to update the hosts to all use the schema defined here


Switch to typescript?

On another project I've started from the grafana template data source which already uses typescript. Shall be convert this plugin?

I like typescript. It's sad there's no type definition though but maybe it's coming as well https://github.com/DefinitelyTyped/DefinitelyTyped/pull/25899

Done via #6


5238 removing blog from Docusaurus

This pull request removes the blog feature (and all the other stuff that goes along with it) from the website folder.
Addresses #5238

Thanks! We'll try to keep up with merging these to let you iterate fast.


Add support for codeowners to repo

Signed-off-by: Ryan Bogan<EMAIL_ADDRESS>Description
Adding a codeowners file.
Issues resolved
Progress on:
Meta issue
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The commit message "initial commit" looks not match what this PR changed, can you tune the commit message and explain what this PR for?

@ryanbogan You also will need to amend the message in the actual commit, please.

@ryanbogan You also will need to amend the message in the actual commit, please.

Done

@opensearch-project/anomaly-detection I've updated the branch rules to use this codeowner file. What do you want to set the number of approvals required to merge a PRs as? 1 or 2?
At some point we may require consistency, but I don't think the direction is clear right now. So since I'm having to go in and update the rules, if you have a preference, LMK.

@CEHENKLE I think 1 approval is preferred to prevent being blocked on merging urgent PRs, such as backporting things to a release branch. But no strong preference.


can you release it to nuget gallery?

@jakubmaguza
I really like your open-source project and have used one of its components in my project. I was wondering if it would be possible to publish this component on NuGet Gallery so that others can easily use it as well.

Hello,
Thank you very much. It is published https://www.nuget.org/packages/Html5QrcodeBlazor.Wrapper.

good


Update tales-of-majeyal to 1.5.3

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask's name and version.

This thing is 470MB, so likely will fail

Verified locally.


Take advantage of startswith accepting a tuple

Coverage decreased (-0.4%) to 76.984% when pulling 04414cfb81d10e4794f47e8399779f7c934e13d9 on michael-k:patch-1 into c07a906ed52f131bcdda67d84e493390c614b3ae on klen:develop.

@michael-k Cool, didn't know it, thank you!


Update documentation to reflect changes in stack

 Write documentation for go-model-service stack upgrades

 Document past month of work on go-model-service (stack upgrades, db associations)

Fix issues pointed out by golint.


Wire up a Backend example broken on angularjs.org

The save button on the create a new project view in the Wire up a Backend example section demo of the front page of angularjs.org appears to be broken.
Steps to reproduce:

Navigate to angularjs.org.
Scroll down to Wire up a Backend section.
In demo on the right side of the page, click the plus sign to add a new project.
Type in valid data.
Hit save button--nothing happens.

Chrome's console gives a "TypeError: Projects.$add is not a function" error. I assume the code in detail.js should be Projects.projects.$add instead of Projects.$add, but that's a guess. The edit project save button works correctly, but the new project save button does nothing.

Duplicate of https://github.com/angular/angularjs.org/issues/171.

BTW, this repo is for AngularJS. Issues regarding https://angularjs.org should be filed at https://github.com/angular/angularjs.org.


Chapter 7.1  issues

The use of "currently" here is probably not appropriate:
Currently, these counters are not filtered by privilege mode, and thus they continue to increment while traps (e.g., page faults or interrupts) to more privileged code are handled.
I would replace "Currently" with "By default".
I would also replace "This proposal" below with "Smcntrpmf".
This proposal remedies these issues by introducing privilege mode filtering for the cycle and instret counters.

Agreed.  Can you make a PR?

sure


feat(shared): add unit test

add shared unit test
modify isEqual type check logic

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.松屹 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Infiniband lagg type support

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[ x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[ x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Is your feature request related to a problem? Please describe.
Infiniband (ipoib) isnt supported by default. But after installing required kernel modules, infiniband and ipoib are working as per-port standalone interface.
But i cannot create infiniband lagg type.
Once i put infiniband interfaces inside lagg, it is not working.
LAGG Statistics active ports:0
flapping:0
I installed infiniband modules by temporary enabling freebsd repo, then installed auto-admin package,
and then used this command:
"auto-install-infiniband-modules datagram"
Which installed infiniband and ipoib modules with datagram mode.
I tried also connected mode, but mtu was limited to 2044 exactly like datagram mode limitation, so i think it installed modules with datagram mode anyways. But to be sure, i removed modules and installed them rather in datagram mode, just to be sure which mode is used, as i dont know how to check it.
Describe the solution you like
I dont know how OPNSense handles interfaces, but if freebsd network management is used, then "infiniband" checkbox in lagg settings can use this:
"ifconfig lagg0 create laggtype infiniband"
instead of just this:
"ifconfig lagg0 create"
This way, lagg would be set to infiniband type, when user uses checkbox (maybe hidden inside advanced settings)
Afaik, infiniband doesnt support some lagg types, but roundrobin and failover should be possible, so it would be nice if non-possible modes would be hidden since infiniband checkbox is checked in lagg settings.
Also, bundlung infiniband support (kernel modules) with opnsense would be great, but its not preventing ipoib from working, as those can be compiled by user, and loaded.
Describe alternatives you considered
Currently idont use failover, and have just one port active, because i cannot get lagg working with ipoib.

Took a brief look, but unfortunately it's not very easy to implement on our end as it needs quite some additional validations and only works when laggtype is specified on initial creation (all other attributes are changeable without removing the device node).


[FINE]Fine with osp12 infra refresh

This backports https://github.com/ManageIQ/manageiq-providers-openstack/pull/99 to fine branch.
It reflects the change in tripleo-heat-templates that enables Pluggable
server type per Role -
openstack/tripleo-heat-templates@87ce5d4 and make fine refresh of OSP12 Infra recognizing Deployment Roles again.
Solves https://bugzilla.redhat.com/show_bug.cgi?id=1540579
Steps for Testing/QA
Have a TripleO setup with OSP12 using quickstart with updated new resource types.
After refresh without this patch you will see no deployment role / cluster in Infra provider for Undercloud. With this patch deployment roles are present and so the matching with physical nodes works.

Updated with rerecorded VCRs for OpenStack Infra.
Will rebase later.

@miq-bot remove_label wip

Looks good to me :+1: