Keyboard shortcut for search doesn't work

At the moment, the keyboard shortcut for Search is not working. ⌘ F is assigned to it, but it doesn't activate the search bar as expected. The shortcut actually doesn't seem to do anything at all.
Also, pressing the return key to search works as expected, but also activates the alert sound set for OS X as if something didn't work properly.

This should be fixed by #413


Zone Listing Selection Dropdown Doesn't List All Zones

Bug Report
If you have a Cloudflare Account with numerous zones (we have about 80), the dropdown selection once verifying your API credentials, does not show all zones, and repeats some zones. Or most likely confusing some domain name pairings with other zones ids and incorrectly listing them by name.
Additionally, if you don't verify credentials first and simply add in the zone ID into the text field and save, it generates an internal error and Admin is no longer accessible. We had to remove plugin to get admin working again.
Plugin Version
putyourlightson/craft-cloudflare:^2.1.0
Craft CMS Version
4.10.0
PHP Version
8.1

If you have a Cloudflare Account with numerous zones (we have about 80), the dropdown selection once verifying your API credentials, does not show all zones, and repeats some zones.

The zones are output as retrieved from Cloudflare’s API, which you can test using CURL as follows:
curl --request GET \
  --url https://api.cloudflare.com/client/v4/zones \
  --header 'X-Auth-Email<EMAIL_ADDRESS>\
  --header 'X-Auth-Key:<PHONE_NUMBER>' \
  --header 'Content-Type: application/json'

Additionally, if you don't verify credentials first and simply add in the zone ID into the text field and save, it generates an internal error and Admin is no longer accessible. We had to remove plugin to get admin working again.

I’ve addressed this issue in https://github.com/putyourlightson/craft-cloudflare/commit/0151146a6019398ee42250c76cc74933a1323400, which should prevent the error from causing a timeout. If you continue to get errors then please check the storage/logs/web-*.log files for specific errors.

Hi there.. Thanks for the update.
First, if I verify credentials in the plugin for the API, the dropdown will list a max of 50 zones. We have just over 100 I think, but certainly this exact number seems to be that the results are being limited.
Second, I noticed that the internal server error if I tried to save the settings was a result of CKEditor Plugin not having settings (disabling this plugin allowed the Cloudflare plugin settings to save).
I can see that it did save the zone ID I specified in my project.yaml file, but due to the above 50 zone limitation, it still doesn't show the zone selected in the dropdown.
Thanks

First, if I verify credentials in the plugin for the API, the dropdown will list a max of 50 zones.

Pagination wasn’t working correctly and has been fixed in https://github.com/putyourlightson/craft-cloudflare/commit/d6e0cf4a284befa5e5b8a3f579d1212151f6a946, please test it out.

Second, I noticed that the internal server error if I tried to save the settings was a result of CKEditor Plugin not having settings (disabling this plugin allowed the Cloudflare plugin settings to save).

That sounds unusual but thanks for the heads-up.

That fixed it! Thanks for your work.
As FYI, this is what seemed to conflict or show in the logs when I got internal errors, which I had not actually setup CKEditor and maybe was the cause for ANY plugin trying to save the project.yaml file. Once disabling CKEditor, Cloudflare plugin saved.
2024-06-17 12:49:35 [web.WARNING] [application] Attempting to set settings on a plugin that doesn't have settings: ckeditor

Great! Released in 2.1.1 and 3.0.1.


Removing uncessary unboxing at several places

Coverage increased (+0.01%) to 94.664% when pulling 114f0b8d30d9622504ea81228d4ec905f3ab7c9e on mehwhatever:master into e80339626333396a216d7e81a7d7ab6a8ea2de6f on apache:master.

-1 In a low level level component like this one, it is important IMO to explicitly see and be aware of where boxing and unboxing takes place since this could impact performance.


Theme support

Does this library intend to support semantic-ui theming? I'm currently using https://github.com/Semantic-Org/Semantic-UI-CSS and dropping it into a react project. But the biggest limitation is lack of theme support. However, I don't want to add all of SemanticUI in my react project either. Could stardust help with this?

Yep, we use multiple themes with Stardust here at TechnologyAdvice. Stardust replaces SUI markup and jQuery plugins with React components.  You can use any SUI css theme you like on top.

I should note, we are also using semantic-ui-css for the doc site.  You can take a look in docs/app/index.ejs to see where we included it.  Also, our package.json where we are installing it.
Let me know if I missed anything and I'll re-open this issue.  Cheers!

documentation for this usecase would be amazing. Thanks for the reply.

Hm, perhaps I'm misunderstanding.  I am under the impression this is already documented in the README.md under Usage.  After creating your theme, just include it's css in the <head> of your index.html:
<!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="UTF-8">
  <title>Try Stardust</title>

  <!-- SUI CSS -->
  <link href="//cdnjs.cloudflare.com/ajax/libs/semantic-ui/2.1.8/semantic.css" rel="stylesheet">
</head>
<body>
  <script src="bundle.js"></script>
</body>
</html>

Just use any SUI theme css in place of the one included there ^.  Let me know if I've misunderstood something.

I was expecting an analogue to site.variables or theme.config I could supply to stardust or include in the  to achieve theming. http://semantic-ui.com/usage/theming.html

Ah, that would be rad.  Unfortunately this kind of theming is not reasonably possible with React components alone due to the cascading nature of CSS and the limited awareness of components in a render tree. Moreover, changing variables requires a costly build step and recompile of the LESS to generate the new stylesheets.  Unfortunately, this is far too slow to perform on the fly.
I've toyed with the idea of components handling theming though, since it is so novel.  I've also built in browser theme compilers in the distance past, like bootstyle for bootstrap.  IMO the tech just isn't quite here yet to properly handle this kind of thing live in an app.
The good news is that in the meantime, you can go about theming as you normally would with any SUI site and just include the final result CSS when you're done.

Is this still the case? Meaning I have to just create a theme with semantic then just import the cdn ?


Add frequency (Hz) line type

Unison is at base frequency and the rest of the scale is interpreted relative to that.

Stephen Weigel — Today at 7:42 PM

Someone expressed interest in being able to input Hz values into Scale Workshop for pitches; would that be possible?

To specify further, I'd like to have Hz lines with all of the SI prefixes supported.
Also consider the inverted units so that we can use orbital periods or whatever to specify the intervals as well. It that case it would be nice to be able to specify the base frequency as a period of vibration as well.

Already implemented in SW3 alpha.


refactor: update the default behavior of import check, closes #858

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[x] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[x] No

Checklist

[x] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[x] I have added a convincing reason for adding this feature, if necessary

Other information

👋 @Rel1cx! I think I’ve noticed an unexpected issue in @eslint-react/no-array-index-key, and bisecting releases has pointed to this commit.
In 1.16.2-beta.6 code like this produces a linting error, which is expected:
foo.bar.map((value, index) => <MyComponent key={index} />);

However, after upgrading to 1.16.2-beta.7, the issue is no longer reported.
If I replace nesting with const { bar } = foo and then call bar.map in JSX, @eslint-react/no-array-index-key works again as expected.
I am thinking of creating a new issue but in needs a reproduction and I don’t have time on it today. I’ve decided to ping you here first with my initial investigation to just sense-check what I observe. WDYT?

👋 @Rel1cx! I think I’ve noticed new issue in @eslint-react/no-array-index-key, and bisecting has pointed me to this commit.
In 1.16.2-beta.6 code like this produces a linting error, which is expected:
foo.bar.map((value, index) => <MyComponent key={index} />);

However, after upgrading to 1.16.2-beta.7, the issue is no longer reported.
If I replace property chaining with const { bar } = foo; and then call bar.map(...) in JSX, @eslint-react/no-array-index-key is reported again as expected.
I am thinking of creating a new issue but in needs a proper reproduction and I don’t have time on it today. I’ve decided to ping you here first with my initial investigation to just sense-check what I observe. WDYT?

Hello! I just reviewed the code and have pinpointed the issue and started fixing it. Your initial investigation was correct and helpful; this commit indeed introduced the problem. Thank you for providing the information.

Great, thanks for responding so quickly @Rel1cx! I just tried 1.17.3-beta.1 which included https://github.com/Rel1cx/eslint-react/pull/868 and it worked 🎉

Another thing that I noticed after upgrading from 1.16.1 to newer versions is @eslint-react/prefer-read-only-props triggering everywhere. We use this definition style for components:
import * as React from 'react';

export const Foo: React.FunctionComponent<{
  bar: string;
}> = ({ bar }) => {
  return <></>;
};

The rule I believe that it’s actually fixing a problem rather introducing a new one. The rule is included in recommended-type-checked but it was not triggering for us, probably until this PR.
No action needed on this one, just an FYI.


The project does not build with Java 11

Fixed by following https://bugs.openjdk.java.net/browse/JDK-8212233


"Run Cell" does not pickup on jupyter installed via virtualenv but conda works

Environment data

VS Code version: 1.29.0 5f24c93878bd4bc645a4a17c620e2487b11005f9 x64

Extension version (available under the Extensions sidebar): 2018.10.1

OS and version: Ubuntu 18.04

Python version (& distribution if applicable, e.g. Anaconda): pipenv with python 3.7

Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv

Relevant/affected Python packages and their versions: -

Actual behavior
When using a virtualenv/pipenv environment clicking on "Run Cell" yields the error msg:
Running cells requires Jupyter notebooks to be installed.
(But it works with conda.)
Expected  behavior
Cell is executed.
Steps to reproduce:
mkdir hello
cd hello
pipenv --python 3.7
pipenv shell
pipenv install jupyter
which jupyter
# /home/somebody/.local/share/virtualenvs/hello-UXM3mEkX/bin/jupyter
# jupyter notebook also works on its own

Open vscode, select the interpreter for the "hello" pipenv environment, create a file demo.py with the following content:
#%%
print("hello")

Clicking on "Run Cell" yields the error msg:
Running cells requires Jupyter notebooks to be installed.
Relevant excerpt from Pipfile.lock
        "jupyter-client": {
            "version": "==5.2.3"
        },
        "jupyter-console": {
            "version": "==6.0.0"
        },
        "jupyter-core": {
            "version": "==4.4.0"
        },

Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
No output.
Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)
/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:294 [Extension Host] Python Extension: Error: Error executing Jupyter command 'nbconvert': [Errno 2] No such file or directory

t.log @ /usr/share/code/resources/app/out/vs/workbench/workbench.main.js:294
/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:294 [Extension Host] Python Extension: Error: Running cells requires Jupyter notebooks to be installed.
t.log @ /usr/share/code/resources/app/out/vs/workbench/workbench.main.js:294
/usr/share/code/resources/app/out/vs/workbench/workbench.main.js:2429 Running cells requires Jupyter notebooks to be installed.

nbconvert is not available via the venv, but jupyter-nbconvert is.
Maybe Related
See https://github.com/Microsoft/vscode-python/issues/3341 and https://github.com/Microsoft/vscode-python/issues/3332

Update:  It seem to be related to how you start vscode.

When vscode is started from the activated virtualenv code . then "run cell" works.
When vscode is started without any environment (and jupyter is not available in the current PATH)

"run cell" works with a conda interpreter
"run cell" does not work with the interpreter from the virtualenv

conda and virtualenv seem to be handled differently. Is this a bug or accepted behavior?

I have the same setup as @sotte except I am on MacOS Mojave 10.14.1. But, event if I start vscode within the environment started by Pipenv, vscode is not able to find Jupyter.
The Jupyter Python Package from @DonJayamanne is able to find the Jupyter executable.

I can't repro @sotte's bug on Linux, but I can on Windows. Hopefully the fix I have out will address the problem.

@sotte Ah, your venv doesn't support nbconvert so you can't do an import. There's a bug in the code that it checks for nbconvert instead of notebook being available.
This line here:
https://github.com/Microsoft/vscode-python/blob/40554c8effdba308744ff68de24e5fd83ee84f12/src/client/datascience/history.ts#L492
That line should say:
if (!(await this.jupyterExecution.isNotebookSupported())) {
Sorry took me so long to notice you didn't have nbconvert installed in your venv.
I'll submit a fix for this right away.

Should be fixed now in https://github.com/Microsoft/vscode-python/commit/d2a5e21ecd8e8ad5ecaf27f864f54f27b6a604af

@rchiodo thanks, you're great!

@sotte Were you able to take advantage of the fix? I have very similar issue (macOS 10.14.1) and I've been navigating the related issues that've been merged, but can't make out if the fix is available

Yes, it worked for me. The fix is only available through the nightly/insider build though.

Thanks @sotte, no luck for me though. Looks like the commit with the fix has already been pushed to Extension Version 2018.11.0, which is what I am using. After looking at #3537 it's worth mentioning that I'm on python 3.6.7 (pyenv install) and my virtual environment is created with venv (via pyenv-virtualenv), so maybe worth opening my own issue? @rchiodo

@leonjonathan if you're using a pip venv then #3537 is likely the culprit. If you start code from the terminal that has the environment activated, does it work then?

Yes, works as expected when starting code with environment activated in terminal. Not using pipenv though (as in #3537). If I understand correctly, pipenv uses VirtualEnv, while pyenv-virtualenv uses native python3 -m venv despite its name.


Add some stats functions

Some interesting statistics we may wish to collect

Number of miners
Computing total hash rate in the pool

(Please feel free to add more)

I will work on it.
Note that most statstic will be gathered by a javascript client/webpage.
I will added minimal needed support in the contract (events) and make a javascript code that calculates it.
Once we start working on front end, we can make it less ugly.


How to make a new burmilla kernel-config base on standard Linux kernel config?

In order to support some specific arm machine, We have to build burmilla kernel base on our own standard Linux kernel source and config. But the result is it report "error: out of memory" during system boot.
My question is: How to make a new burmilla kernel-config base on a standard Linux kernel config? Any step to cut the size to a burmilla like one?

Most probably issue is that standard config includes too much drivers which why kernel and/or initrd gets too big. Disabling drivers which you do not need should helps.


an_req is returning null with this cookie

Thanks for your interest. I just tested on my end and that request is necessary to get the cookies needed for an_req. Without it we won't be able to retrieve history bills. Let me know if you proved otherwise and we can look into the details if you would like.

Hey @nareshku,
Recently I was testing this with other accounts and I think you were (and still are) right. I found that for some AT&T accounts (accounts without Uverse services) that request does mess up with the cookies. Since I've pushed the change and together with some other changes, I'll close this PR.
I hope you can pip install the latest version of the app and try it out on your account. Again, I appreciate your interest in using this package and I'd like to hear about how it works for you now.


[1.19.2] Add support for repair item customization through the GearConfig system

Dungeons Gear used to have a universal repair item tag that allow for repairing the melee weapons. Currently, the changes made to incorporate gear config has removed any kind of melee weapon repair.

Closing as I misunderstood gear config's use of the material entry.


include-files sub files pipe table can not wrap

If these's a pipe table in .md file, it will wrap lines only when line content length >72.
so if the line content lenght is long but <=72, pandoc to pdf, the table will expand far to page right and can not see all the content.
I can walk around this problem using:
pandoc --columns=10 test.md -o test.pdf

(set columns a very small value than 72) the pipe table line will wrap even the line content<72.
But, if the pipe table is in sub files included by include-files.lua, this trick will not function, I test sub file pipe table only wrap  when pipe table line content >80, even I set --columns=10

@tarleb I guess the underlying issue is that there currently isn't a way to set reader options using pandoc.read() in a lua filter -- is that correct?

Yes, the only read options that can currently be controlled in pandoc.read() are format extensions.

I looks like changes that would enable this have landed in Pandoc and this comment suggests this filter is also updated. Is this fixed now?

I believe it's fixed, at least when the filter is used with the pandoc nightly.


Support Content-Digest header in StagingsController

The Content-Digest header takes precedence over Content-MD5. The following header format is supported:
<algorithm>=:<base64-digest>:

Whereas 'algorithm' is one of the following: sha-512, sha-256, sha-1 (or sha) and md5.
Addresses one of the issues identified in: #3544

[x] I have reviewed the contributing guide

[x] I have viewed, signed, and submitted the Contributor License Agreement

[x] I have made this pull request to the main branch

[x] I have run all the unit tests using bundle exec rake

[ ] I have run CF Acceptance Tests

With these changes from this PR applied I'm still getting (should not block this PR, just trying to keep track of the error I encounter).:
cf push cf-env --stack cflinuxfs4 --buildpack ruby_buildpack
Pushing app cf-env to org system / space dev as admin...
Applying manifest file /Users/rubenk/workspace/cf-env/manifest.yml...
Manifest applied
Packaging files to upload...
Uploading files...
 186.20 KiB / 186.20 KiB [=============================================================] 100.00% 2s

Waiting for API to complete processing files...

Staging app and tracing logs...
Unexpected Response
Response Code: 500
Request ID:    58eaa0f9-60a0-4e8f-4576-552bca391abe::e81b4d24-449b-4667-8c61-0aa9d20ef8c0
Code: 0, Title: , Detail: {"errors":[{"detail":"Stager error: Digest initialization failed: initialization error","title":"CF-StagerError","code":170011}]}

WIth CC stack trace:
{
  "errors": [
    {
      "detail": "Stager error: Digest initialization failed: initialization error",
      "title": "CF-StagerError",
      "code": 170011,
      "test_mode_info": {
        "detail": "Stager error: Digest initialization failed: initialization error",
        "title": "CF-StagerError",
        "backtrace": [
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/cloud_controller_ng/lib/cloud_controller/diego/stager.rb:36:in `rescue in send_stage_package_request'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/cloud_controller_ng/lib/cloud_controller/diego/stager.rb:31:in `send_stage_package_request'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/cloud_controller_ng/lib/cloud_controller/diego/stager.rb:9:in `stage'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/cloud_controller_ng/app/actions/build_create.rb:87:in `create_and_stage'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/cloud_controller_ng/app/controllers/v3/builds_controller.rb:51:in `create'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/abstract_controller/base.rb:228:in `process_action'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_controller/metal/rendering.rb:30:in `process_action'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/abstract_controller/callbacks.rb:42:in `block in process_action'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:106:in `run_callbacks'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/abstract_controller/callbacks.rb:41:in `process_action'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_controller/metal/rescue.rb:22:in `process_action'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_controller/metal/instrumentation.rb:34:in `block in process_action'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/notifications.rb:203:in `block in instrument'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/notifications/instrumenter.rb:24:in `instrument'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/notifications.rb:203:in `instrument'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_controller/metal/instrumentation.rb:33:in `process_action'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_controller/metal/params_wrapper.rb:249:in `process_action'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/abstract_controller/base.rb:165:in `process'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionview-<IP_ADDRESS>/lib/action_view/rendering.rb:39:in `process'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_controller/metal.rb:190:in `dispatch'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_controller/metal.rb:254:in `dispatch'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/routing/route_set.rb:50:in `dispatch'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/routing/route_set.rb:33:in `serve'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/journey/router.rb:50:in `block in serve'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/journey/router.rb:32:in `each'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/journey/router.rb:32:in `serve'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/routing/route_set.rb:842:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/rack-2.2.8/lib/rack/tempfile_reaper.rb:15:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/http/permissions_policy.rb:22:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/http/content_security_policy.rb:19:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/middleware/callbacks.rb:27:in `block in call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/callbacks.rb:98:in `run_callbacks'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/middleware/callbacks.rb:26:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/middleware/actionable_exceptions.rb:18:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/middleware/debug_exceptions.rb:29:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/middleware/show_exceptions.rb:33:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/middleware/remote_ip.rb:81:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/rack-2.2.8/lib/rack/runtime.rb:22:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/cache/strategy/local_cache_middleware.rb:29:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/middleware/executor.rb:14:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/rack-2.2.8/lib/rack/sendfile.rb:110:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/middleware/host_authorization.rb:142:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/rack-2.2.8/lib/rack/urlmap.rb:74:in `block in call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/rack-2.2.8/lib/rack/urlmap.rb:58:in `each'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/rack-2.2.8/lib/rack/urlmap.rb:58:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/cloud_controller_ng/middleware/cef_logs.rb:18:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/cloud_controller_ng/middleware/request_logs.rb:13:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/cloud_controller_ng/middleware/zipkin.rb:22:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/cloud_controller_ng/middleware/security_context_setter.rb:41:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/cloud_controller_ng/middleware/vcap_request_id.rb:16:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/cloud_controller_ng/middleware/cors.rb:49:in `call_app'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/cloud_controller_ng/middleware/cors.rb:14:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/cloud_controller_ng/middleware/request_metrics.rb:12:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/rack-2.2.8/lib/rack/builder.rb:244:in `call'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/thin-1.8.2/lib/thin/connection.rb:86:in `block in pre_process'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/thin-1.8.2/lib/thin/connection.rb:84:in `catch'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/thin-1.8.2/lib/thin/connection.rb:84:in `pre_process'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/thin-1.8.2/lib/thin/connection.rb:50:in `block in process'",
          "/var/vcap/data/packages/cloud_controller_ng/2de9ff7be298a52784f0ab031db749f2a7d01ee5/gem_home/ruby/3.2.0/gems/eventmachine-1.2.7/lib/eventmachine.rb:1077:in `block in spawn_threadpool'"
        ]
      }
    }
  ]
}


max_bin doesnt change result

Hey,
Im using the python API.
For regression
when i change the max_bin param to say 51 by using a dict
params = {"max_bin":51}
and then :
lgb_train = lgb.dataset(x,y);
gbm = lgb.train(params,lgb_train,10)
i get the same result as if i used params = {"max_bin":255}
also if i check after the training
lgb_train .max_bin = 255
Only if before training i set the dataset to
lgb_train .max_bin = 51
then i do get differnt results ..
Is this how i should use the max_bin params? shouldnt the first method work as well?
thanks!

Same issue #1053.


Potentially unhandled rejection [2] ReferenceError: Map is not defined

Went through all installation instructions and got this:
Potentially unhandled rejection [2] ReferenceError: Map is not defined
    at execute (http://localhost:9000/jspm_packages/github/aurelia/metadata@0.3.1/system/origin.js:24:27)
    at p (http://localhost:9000/jspm_packages/system.js:1:6384)
    at p (http://localhost:9000/jspm_packages/system.js:1:6319)
    at p (http://localhost:9000/jspm_packages/system.js:1:6319)
    at p (http://localhost:9000/jspm_packages/system.js:1:6319)
    at p (http://localhost:9000/jspm_packages/system.js:1:6319)
    at p (http://localhost:9000/jspm_packages/system.js:1:6319)
    at p (http://localhost:9000/jspm_packages/system.js:1:6319)
    at Object.execute (http://localhost:9000/jspm_packages/system.js:1:8091)
    at o (http://localhost:9000/jspm_packages/es6-module-loader.js:7:17751)

Also i had to fix font-awesome css link to<EMAIL_ADDRESS>at index.html

What browser are you trying this in?

Chromium 37.0.2000.0 (SRWare Iron) :)

I think it's just not an Evergreen browser :)

Try referencing core-js manually in our html page before any code runs. That might do it. It looks like it needs a Map polyfill.

Added
<script<EMAIL_ADDRESS>
Now:
Uncaught ReferenceError: require is not defined     core.js:2267

But everything is ok in Safari

Ok. you can try something else. If you go grab es6-shim, and reference that instead of core-js, see if that does it.

Thanks. Adding
<script src="bower_components/es6-shim/es6-shim.min.js"></script>

helped.
There was a hope that everything will run out of the box

I agree. You aren't using a supported browser, so that's the reason for these workaround. I think we can do some work to make it easier though and possibly expand our browser support.


[WIP] prototype of de-duping styles

Issue: https://github.com/lit/lit/issues/4357
Background
Currently, there is no way to deduplicate styles in the declarative shadow DOM. This PR provides an opt-in mechanism (if JavaScript is enabled), to deduplicates declarative shadow DOM styles from LitElement's static styles array.
Design
During SSR, if this feature is enabled, each css tag present in the static styles array will be servers side rendered into a <style> element once. This element will be wrapped with the deduplicate element.
After the first instance of the styles have been encountered, any subsequent instances encountered during SSR rendering will only send down the deduplication element with an id attribute which references the first instance.
During parse time, the deduplication element can synchronously pull in the styles and attach them. This avoids any FOUC.
I've made it so Constructable style sheets are used if available, falling back to cloning the style element directly.
Results
This is a hard feature to measure, because it impacts network size, but also will result in changes in runtime characteristics. E.g., less style tokens are parsed, but a style element or constructable style sheet is added instead.
Below are measurements I took using material-web.dev as an example of a Lit SSR'd website.

Test
No compression
gzip
brotli

button.html
993kB
45kB
23kB

button.html (with deduplicated styles)
327kB (-67%)
31kB (-31%)
23kB (-0%)

What is the impact on browser performance timings. Note this was done locally using Chrome developer tools, and I jotted down the rough numbers after a couple refreshes. This is for ballpark figures.

Test
Parse HTML time (ms)
FCP
DCL

button catalog page
7.6ms (self 7.0ms)
200ms
183ms

button.html (with deduplicated styles)
10.02ms (self 5.73ms)
225ms
241ms

The increased parse HTML time makes sense with deduplicated styles because we are applying the styles during parse time via the new element. This seems to slightly increase all other timings.

The primary reason for making this prototype was to measure if there would be any benefit. I've now measured against a page in material-web.dev which uses Lit SSR.
Method:
I npm packed a new eleventy ssr plugin which contained the de-duping styles prototype and ran it on material-web.dev. I visually inspected that the styles were not duplicated and also ensured the page worked great.
Most importantly, I could inspect the file size of the generated catalog.

Test
No compression
gzip
brotli

button.html
993kB
45kB
23kB

button.html (with style-module)
327kB (-67%)
31kB (-31%)
23kB (-0%)

Conclusion:
Brotli is pretty fantastic and handling duplicated text content, and thus de-duping styles provides less benefit than I initially expected. The gzip benefit of 30% is compelling but I'd like feedback to see if this benefit is worth pursuing.

67% smaller is a lot less to parse, regardless of compression. And it's a lot less for any downstream processing: the server, browser, any transforms or middleware. So we should at least measure first paint, but even if we didn't detect a huge improvement there I think this should still be an option because we can make it semantically correct (with some client-side changes).

IMO, the main reason to add this feature is to make the styling behave as authored, using adopted stylesheets.
The performance testing is mostly important to ensure it doesn't regress performance, but if it makes FCP faster, that's great.

@sorvell I've addressed your great feedback. This change still needs docs, however I'd love your thoughts now that the logic has been fixed and works semantically correctly.
Thank you!

@AndrewJakubowicz, can you provide any updates on this?

It would be great to be able to opt in to this feature. We use a security package that parses the HTML and adds nonces to any script/links etc. And right now, the HTML size is really a problem there. Would be amazing to have no repeated styles.

Hi @AndrewJakubowicz ,
I hope this message finds you well. We are currently working on a project that heavily relies on the Lit framework, and we have encountered a challenge that we believe could be addressed by this pull request.
Context and Need:
Our project involves rendering pages statically, and as it stands, the current approach to styles in Lit is proving to be a significant bottleneck. Specifically, the inlined styles within each statically rendered component are causing our pages to bloat, resulting in increased load times and negatively impacting the overall performance and user experience.
It would be great if we can use this feature in a near future.
Kind Regards
Marcel

@marcmalerei do you comrpess the HTML? gzip/brotli should compress these duplicate styles really well and significantly reduce the performance overhead.

@marcmalerei do you comrpess the HTML? gzip/brotli should compress these duplicate styles really well and significantly reduce the performance overhead.

@prashantpalikhe, yes we do but if you have hundreds of the same component it still leads to a bloat of html. is there any progress here?


runtime/pprof: does StartTrace belong?

Dmitriy's new tracing has API entry points in runtime/pprof because all the other runtime tracing does. But it's not consumed by pprof and probably belongs somewhere else. Decide.

"runtime/trace"
trace.Start ?
On 29 January 2015 at 02:59, Russ Cox<EMAIL_ADDRESS>wrote:

Dmitriy's new tracing has API entry points in runtime/pprof because all
the other runtime tracing does. But it's not consumed by pprof and probably
belongs somewhere else. Decide.
—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/9710.

I did it looking at CPU profiling support which is essentially the same.
The design doc also mentions functions that allow to emit user marks into the trace to denote scopes of something or just one-off events (a-la TraceEvent, TraceScopeBegin, TraceScopeEnd). I've already seen two inquiries about this on golang-nuts.
So StartTrace/EndTrace + TraceEvent/TraceScopeBegin/TraceScopeEnd can make a case for runtime/trace package.

Hi Russ,
We need to decide on this asap.
People continue to ask about user-emitted events in traces. Some people also proposed some options for tracing, like disable stack collection.
We don't need to decide on all that for 1.5, I am sure we will have more trace-related functions in future, so it can make sense to move all trace-related functions to runtime/trace before the release.

golang.org/issue/8552 does not mention this issue but should.

Humm... I can't change that change anymore:
$ git checkout master
$ git checkout -b trace_pkg
$ git fetch https://go.googlesource.com/go refs/changes/52/8552/3 && git cherry-pick FETCH_HEAD
$ git change
git rev-parse --abbrev-ref trace_pkg@{u}
fatal: no upstream configured for branch 'trace_pkg'
git-codereview: exit status 128

@dvyukov try running git branch -u master trace_pkg after git checkout -b trace_pkg

I've mailed a new change https://go-review.googlesource.com/#/c/12511/ that just moves StartTrace/StopTrace to the new package.
8552 was more about new tracing APIs and is now cluttered with lots of unrelated stuff.


modules: hostap: 11k/v/r roaming support

Added 11k/v/r roaming support.

The 11kvr roaming RFC link: https://github.com/zephyrproject-rtos/zephyr/issues/76307

@jukkar
Hi Jukka, could you please help review the PR again. I did some changes based on your latest comments. Thanks!

@jukkar
Hi Jukka, I have this build error of my roaming PR. Do you know the cause of the build error?

It happened today and no such error previously.

It happened today and no such error previously.

Yes, the reason is that we now compile test hostap properly (done by  #79973), I mentioned this yesterdays wifi meeting.
Your changes cause this issue to be seen (probably indirectly), you need to just find where the aes_unwrap is defined and add it to the compilation.

Hmm, the aes_wrap() is actually mentioned in the list at
https://github.com/zephyrproject-rtos/zephyr/blob/1689eaf6a4551165905979772d981ed6713acef5/modules/hostap/CMakeLists.txt#L247
I wonder what is going on here. I will check what is going on here.

Found the aes_unwrap issue. This will solve it
diff --git a/modules/hostap/CMakeLists.txt b/modules/hostap/CMakeLists.txt
index efddecaf250..d5f9c97baef 100644
--- a/modules/hostap/CMakeLists.txt
+++ b/modules/hostap/CMakeLists.txt
@@ -251,8 +251,10 @@ zephyr_library_sources_ifdef(CONFIG_WIFI_NM_WPA_SUPPLICANT_CRYPTO_NONE

        # FIXME: why do we need these when crypto is not selected?
        ${HOSTAP_SRC_BASE}/crypto/aes-wrap.c
+       ${HOSTAP_SRC_BASE}/crypto/aes-unwrap.c
        ${HOSTAP_SRC_BASE}/crypto/aes-internal.c
        ${HOSTAP_SRC_BASE}/crypto/aes-internal-enc.c
+       ${HOSTAP_SRC_BASE}/crypto/aes-internal-dec.c
        ${HOSTAP_SRC_BASE}/crypto/aes-omac1.c
        ${HOSTAP_SRC_BASE}/crypto/md5.c
        ${HOSTAP_SRC_BASE}/crypto/md5-internal.c

Could you add a commit to your PR for this, the commit could say something like
hostap: More fixes to crypto=none compilation

The aes_unwrap and aes_decrypt functions were missing if
CONFIG_WIFI_NM_WPA_SUPPLICANT_CRYPTO_NONE is enabled.
Add missing C files to the compilation to fix this.

Ok, got it. Thanks!

@nxf58150 the hostap PR is now merged, please update the manifest

@krish2718
Hi Chaitanya, I rebased the PR today but your previous approvement was gone. Could you please help approve it again? And if everything is ok, could you please help merge it today? Thanks!

Hi @jukkar @krish2718 @dleach02 @danieldegrasse  please review this PR


Update page.styl

The content section is wider.

The content is actually deliberately this size. I think 800px is a little too wide for optimal readability.


feat(upgrade):  get upgrade status from events

ashish@vm:~/code/rust/mayastor-extensions(upgrade-status)$ ./target/debug/kubectl-mayastor get upgrade-status
Upgrade From : 2.0.0
Upgrade To : 0.0.0
Upgrade Status : Upgrading Mayastor data-plane

bors try

bors try


Added adopters

This pull request adds known adopters based on recent references.
Related issues

https://github.com/SAP/project-portal-for-innersource/issues/39

Looks good from my point of view - thank you! :-)

Thanks for adding additional references, great 👍

all done :-)


Pasting text while in ssh session drops special characters

Environment
Windows build number: Microsoft Windows [Version 10.0.18363.1198]
Windows Terminal version: Windows Terminal Preview 1.5.3242.0
OR
Windows Terminal 1.4.3243.0

Steps to reproduce
I expect this bug to be difficult to reproduce since I cannot find any mention of this behaviour anywhere despite being seemingly obvious on my machine. I can provide a video demonstration and necessary system config files if needed.

(Have a second language/keyboard layout installed? - not sure, but I have Russian lang and kb layout installed and have encountered similar issues in the past which seemed to be related to that )
Open Windows Terminal (freshly installed from MS Store)
ssh to remote linux server (tried both Ubuntu 16 and Raspbian on several machines)
Copy the following string:

a{b}c[d]e-f*g/h~i`j%k^l$m#n@o"p'q<r>s

Paste the string into Terminal via right-click or Shift-Insert or Ctrl-Shift-V
Observe as the string turns into the following, losing a bunch of characters:

abcde-f*g/hij%klmno"pqrs

Expected behavior
I expect the text to remain the same.

Actual behavior
Pasted text loses brackets, curly braces, single quotation marks, and other symbols, such as <>^$#&~.
Symbols can still be typed manually (even though I have encountered a bug in Terminal in the past where this was not the case).
Copy-pasting symbols from terminal works fine.
Repeating the same steps in stand-alone cmd or powershell also works fine.

Thanks for the report! This looks like a /duplicate of https://github.com/PowerShell/Win32-OpenSSH/issues/1505, which is an issue in windows' ssh.exe. It's been fixed and the release is available on their github page.


Make sure validation errors from schxslt are parsed properly

Thanks to @SubandiK, we have proper detection of actual validation errors (Thanks for reporting #1 and providing a fix in #3) but looking at the output in the provided test case it seems to me like an error is reported in multiple lines and it would be good if we could parse these lines into actual ValidationError objects.
If someone wants to give this a go, please go ahead. I am not in the best position right now to spend a lot of time on this, but I will eventually get to it if nobody will pick this up.

Thanks for parsing the errors!


CV2.Rectangle fails when shift is not euqal 0 or 8.

Summary of your issue
CV2.Rectangle fails when shift is not euqal 0 or 8.
Environment
Win 10 X64 VS2019
What did you do when you faced the problem?
I have found the reason and fixed this.
Example code:
            Rect2d tmp = new Rect2d(X, Y, Width, Height);
            var tmp1 = tmp.TopLeft * 256;
            Point point1 = new Point(tmp1.X, tmp1.Y);
            var tmp2 = tmp.BottomRight * 256;
            Point point2 = new Point(tmp2.X, tmp2.Y);
            Cv2.Rectangle(mat, new Rect(point1.X, point1.Y, point2.X - point1.X, point2.Y - point1.Y), color, -1, LineTypes.Link8, 8);

Output:
An Exception thrown.
What did you intend to be?
I located the code below in improc.h (line 1199~1206).
CVAPI(ExceptionStatus) imgproc_rectangle_InputOutputArray_Point(
    cv::_InputOutputArray *img, MyCvPoint pt1, MyCvPoint pt2,
    MyCvScalar color, int thickness, int lineType, int shift)
{
    BEGIN_WRAP
    cv::rectangle(*img, cpp(pt1), cpp(pt2), cpp(color), thickness, shift);
    END_WRAP
}

It should be
CVAPI(ExceptionStatus) imgproc_rectangle_InputOutputArray_Point(
    cv::_InputOutputArray *img, MyCvPoint pt1, MyCvPoint pt2,
    MyCvScalar color, int thickness, int lineType, int shift)
{
    BEGIN_WRAP
    cv::rectangle(*img, cpp(pt1), cpp(pt2), cpp(color), thickness, lineType,shift);
    END_WRAP
}

Some other wappers have  the same problem.

Thank you! 👍


fix: test GH action

Trying to fix the test Github Action.
The pytest-xdist plugin isn't available in the execution container, hence the failure. When using xdist, the -s flag for pytest doesn't have any effect, so removing that as well.

There's only a single test file executed in the bin/test file, why is that? Shouldn't all be? I know it takes ages to run them all, but it's kinda ok a CI environment.

This all looks good, I had set up the conftest cache initially only for the Marketplace, @ponderingdemocritus will the test cache be implemented into the other contracts?


[FR]: Show Wireguard client state (online/offline)

Describe the new feature or enhancement idea
Currently for each client we have a switch where (among other things) we can track its state, understanding state as whether wireguard (and possibly other VPN servers) accepts connections for that particular client / with its associated credentials.
What we don't have (that I can see) is whether there is an active connection associated with the client, ie. what we see in the wireguard widget represented as a green/red coloured network icon.
We could also track the number of active connections associated withe a server, which is also available in the widget at the top, eg. Tunnels: 4 | Online: 1 | Offline: 3
This would be great to have to, for example, trigger HA automations (eg. notifications) based on new active connections to the VPN.
Thanks in advance
Will you be building this?

[ ] I intend to submit a PR to implement this

Additional Details
No response

Wireguard is stateless so there isn't exactly a great definition of connected or not. However, I never even enabled the OPNsense Wireguard Widget since they went to the new version. That's a great pointer/suggestion.
Looking at their code, it looks like they count a Wireguard client as online if the last handshake was <3 min ago. I could duplicate that logic if that sounds good.
https://github.com/opnsense/core/blob/8e41be2ebe8b53d59fded39d289c5d73822c8083/src/opnsense/www/js/widgets/Wireguard.js#L89
Now to see how they are counting OpenVPN clients and may replicate that as well ....


No option to enable repositories by subscription-manager

General information

OS:  Windows
Hypervisor:  Hyper-V
Start with crc start -n <IP_ADDRESS>

CRC version
crc version: 1.3.0+918756b
OpenShift version: 4.2.10 (embedded in binary)

CRC status
CRC VM:          Running
OpenShift:       Running (v4.2.10)
Disk Usage:      16.06GB of 32.2GB (Inside the CRC VM)
Cache Usage:     14.78GB
Cache Directory: C:\Users\*****\.crc\cache

CRC config
<empty>

How to enable repositories (e.g. rhel-7-server-ansible-2.8-rpms) when run CRC? It seems not an option to run below: (because there is no real host):
subscription-manager repos --enable rhel-7-server-ansible-VERSION-rpms
or use the entitlements method because there is no subscription in https://cloud.redhat.com/openshift/subscriptions :
https://docs.openshift.com/container-platform/4.2/builds/running-entitled-builds.html#builds-strategy-docker-entitled-subman_running-entitled-builds
Just try to install Ansible to a base Jenkins slave with a DockerFile:
FROM registry.redhat.io/openshift4/ose-jenkins-agent-base:latest
RUN yum install -y yum-utils && \
    yum-config-manager --enable rhel-server-rhscl-7-rpms && \
    yum-config-manager --enable rhel-7-server-extras-rpms && \
    yum-config-manager --enable rhel-7-server-rpms && \
    yum-config-manager --enable rhel-7-server-ansible-2.8-rpms && \
    yum-config-manager --enable rhel-7-server-ose-4.2-rpms && \
    yum update -y && \
    yum install -y ansible && \
    yum install -y python-openshift && \
    yum clean all -y

This results in a :
No package ansible available.
Error: Not tolerating missing names on install, stopping.

What steps did you perform before this?
You must have access to Red Hat entitlements through your subscription.

You must have access to Red Hat entitlements through your subscription.

Maybe I miss something? But how or where can I have access?
When I look at https://cloud.redhat.com/openshift/subscriptions  nothing is listed.

@michelmeeuwissen Have a look to https://docs.openshift.com/container-platform/4.2/builds/running-entitled-builds.html

@michelmeeuwissen Have a look to https://docs.openshift.com/container-platform/4.2/builds/running-entitled-builds.html

Thanks. But this is exactly the url I posted in the original issue.
The problem is that I don't have / or don't understand the following prerequisites:

You must have access to Red Hat entitlements through your subscription, and the entitlements must have separate public and private key files.

But this is exactly the URL I posted in the original issue.

@michelmeeuwissen My mistake, didn't read the issue throughly.

Maybe an option to add a small note in the CRC documentation?

I think, this shouldn't be part of CRC document but handled it in openshift documentation side. Can you please file an issue on openshift doc side https://github.com/openshift/openshift-docs

I found my CRC virtual system under https://access.redhat.com/management/systems

@michelmeeuwissen when you say you found it under systems, does it auto appear there for you or you need to perform any action?

I found my CRC virtual system under https://access.redhat.com/management/systems

@michelmeeuwissen when you say you found it under systems, does it auto appear there for you or you need to perform any action?

Yes it appears as Virtual System . When you click on it will get the option to download the Identity Certificates with private and public keys.

Note: I didn't test it yet if it works in combination with the https://docs.openshift.com/container-platform/4.2/builds/running-entitled-builds.html#builds-strategy-docker-entitled-subman_running-entitled-builds method. Will try to do it later today.

The system I talked about earlier about is a different virtual system, unfortunately.
I tried to test it, but unfortunately, I didn't get it to work. I got some pem files from the Customer Portal, by creating a dummy System and attached my Develop subscription. But none of them seems to fit the needs described in the https://docs.openshift.com/container-platform/4.2/builds/running-entitled-builds.html documentation.
As a developer, I'm currently lost in the whole Subscription Management world. I had hoped these things were already set up or well documented. Am I still missing some online documentation or is what I want simply not possible?
Maybe SSH into the CRC VM is an option? if so... How to do this?

You are able to SSH into the VM, but this is not the proper OpenShift 4.x
way. This is why we suggest to report this against the openshift repo.
Understand that this scenario is not something we usually test, but I will
also bring this up, as it is a gap in our development story/stories
On Fri, Jan 3, 2020 at 4:03 AM Michel Meeuwissen<EMAIL_ADDRESS>wrote:

The system I talked about earlier about is a different virtual system,
unfortunately.
I tried to test it, but unfortunately, I didn't get it to work. I got some
pem files from the Customer Portal, by creating a dummy System and attached
my Develop subscription. But none of them seems to fit the needs described
in the
https://docs.openshift.com/container-platform/4.2/builds/running-entitled-builds.html
documentation.
As a developer, I'm currently lost in the whole Subscription Management
world. I had hoped these things were already set up or well documented. Am
I still missing some online documentation or is what I want simply not
possible?
Maybe SSH into the CRC VM is an option? if so... How to do this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/code-ready/crc/issues/914?email_source=notifications&email_token=AAAAOZTRJPG7Z43WPL47RT3Q3ZCB3A5CNFSM4KBURNC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH7H45I#issuecomment-570326645,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAAOZW45XUZYSOLOUJP45TQ3ZCB3ANCNFSM4KBURNCQ
.

--
Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]

I understand. thanks.
I don't think this is a problem with the Openshift repo. Because normally (what we did with the Openshift 3.11 system) you can register the subscription with the subscription manager on the host system of the Openshift cluster and enable the needed Ansible repositories with the same subscription manager tool with the commando:
subscription-manager repos --enable rhel-7-server-ansible-VERSION-rpms
But with the CRC environment, you are not able to access the host system and enable repositories out of the box. And to make the migration from 3 to 4 easier I want to test some of our pipelines (with Ansible playbooks) on CRC .
But thanks in advance for bringing this up. Please let me know if I can help you with information or reproduction steps.

But with the CRC environment, you are not able to access the host system and enable repositories out of the box.

This is actually not CRC specific, but how things have changed for OpenShift 4.x. The host runs RHCOS (CoreOS) which is maintained by the operators from the cluster.
@code-ready/crc-devel who best to ask about this?

The problem still occurs.
See following example

crc version: 1.6.0+8ef676f
OpenShift version: 4.3.0 (embedded in binary)

Dockerfile
FROM registry.redhat.io/openshift4/ose-jenkins-agent-base
USER root
RUN yum-config-manager --enable rhel-7-server-ansible-2.8-rpms && \
    yum install -y ansible && \
USER 1001

Commando's
$ oc login -u kubeadmin -p *****-qmTth-oxaoD-p3xQF https://api.crc.testing:6443
$ oc new-project sandbox
$ oc new-build --name ansible-slave --binary --strategy docker
$ docker login registry.redhat.io -u <RH_LOGIN> -p <RH_PASSWORD>
$ oc create secret generic redhat-registry --from-file=.dockerconfigjson=/home/<USERNAME>/.docker/config.json --$ type=kubernetes.io/dockerconfigjson
$ oc secrets link builder redhat-registry
$ oc set build-secret --pull bc/ansible-slave redhat-registry
$ oc start-build ansible-slave --from-dir=. --follow

Result
Uploading directory "." as binary input for the build .....
Uploading finished
build.build.openshift.io/ansible-slave-1 started
Receiving source from STDIN as archive ...
Caching blobs under "/var/cache/blobs".

Pulling image registry.redhat.io/openshift4/ose-jenkins-agent-base ...
Getting image source signatures
Copying blob sha256:edf561fefe181b648d6502acfd17fd6a6bb8d378057dae272f36ffc850f65bf8
Copying blob sha256:bb13d92caffa705f32b8a7f9f661e07ddede310c6ccfa78fb53a49539740e29b
Copying blob sha256:e1f7ef81f6300ddeb927955e07d9dfd51b768729fb1630a881bc0bd9418a4f9b
Copying blob sha256:13be0effd90b69b59a7109cbb6133186be48c386dfb5a69e99965ad383451789
Copying blob sha256:455ea8ab06218495bbbcb14b750a0d644897b24f8c5dcf9e8698e27882583412
Copying blob sha256:2a69f56e08208bf952d5307e8b47f8aa4642ff1e5102675330909c99f033827d
Copying config sha256:01a612ddb4ba8fa10b4914cd1c276c6c9e29824264936c66e90d7f240075651f
Writing manifest to image destination
Storing signatures
STEP 1: FROM registry.redhat.io/openshift4/ose-jenkins-agent-base
STEP 2: USER root
d1afe43b1a71f7c2534cdb00758fb0769901b783e422a592f3b1ad2347c278d3
STEP 3: RUN yum-config-manager --enable rhel-7-server-ansible-2.8-rpms &&     yum install -y ansible && USER 1001
Loaded plugins: ovl, product-id, subscription-manager
This system is not receiving updates. You can use subscription-manager on the host to register and assign subscriptions.
Loaded plugins: ovl, product-id, search-disabled-repos, subscription-manager
This system is not receiving updates. You can use subscription-manager on the host to register and assign subscriptions.
No package ansible available.
Error: Not tolerating missing names on install, stopping.
subprocess exited with status 1
subprocess exited with status 1
error: build error: error building at STEP "RUN yum-config-manager --enable rhel-7-server-ansible-2.8-rpms &&     yum install -y ansible && USER 1001": exit status 1

See No package ansible available.
This wouldn't happen if I'm able to run a command like this on the CRC host:
$ subscription-manager repos --enable rhel-7-server-ansible-VERSION-rpms
See:
https://access.redhat.com/articles/3174981

This wouldn't happen if I'm able to run a command like this on the CRC host:
$ subscription-manager repos --enable rhel-7-server-ansible-VERSION-rpms

Running subscription-manager register on the RHCOS 4.3 results in subscription-manager: command not found

As indicated by Gerard https://github.com/code-ready/crc/issues/914#issuecomment-571064763 I don't think running subscription-manager on the crc VM is the correct way of configuring additional repositories.
Looking again at https://docs.openshift.com/container-platform/4.2/builds/running-entitled-builds.html#builds-strategy-docker-entitled-subman_running-entitled-builds , for the COPY parameters, I'd use /etc/pki/entitlement , /etc/rhsm/rhsm.conf and /etc/rhsm/ca from a machine already configured to access the ansible channel that you need (I checked that they exist on my devel machine which uses subscription manager)
Your Dockerfile would become:
FROM registry.redhat.io/openshift4/ose-jenkins-agent-base
USER root
# Copy entitlements
COPY ./etc-pki-entitlement /etc/pki/entitlement
# Copy subscription manager configurations
COPY ./rhsm-conf /etc/rhsm
COPY ./rhsm-ca /etc/rhsm/ca
# Delete /etc/rhsm-host to use entitlements from the build container
RUN rm /etc/rhsm-host && \
    # Initialize /etc/yum.repos.d/redhat.repo
    # See https://access.redhat.com/solutions/1443553
    yum repolist --disablerepo=* && \
    subscription-manager repos --enable rhel-7-server-ansible-2.8-rpms && \
    yum -y update && \
    yum -y install ansible && \
    # Remove entitlements and Subscription Manager configs
    rm -rf /etc/pki/entitlement && \
    rm -rf /etc/rhsm
# OpenShift requires images to run as non-root by default
USER 1001
ENTRYPOINT ["/bin/bash"]

Great! Got it working with a, in my opinion, workaround:
To get some entitlement certificates you need of course a RedHat Subscription and a RHEL system to run the subscription-manager.

Downloaded DVD ISO RHEL 7.7 from https://developers.redhat.com/products/rhel/download
Install RHEL 7.7 in Hyper-V and start the VM and login with the root user setup during installation (maybe you need to setup a new virtual external network switch to make an external connection)
Run:
$ subscription-manager register --username <rh-username> --password <rh-password> --auto-attach
Setup Samba share on the RHEL 7.7 Virtual Machine
Copy the two pem files (create by the RHSM command from above) from /etc/pki/entitlement to the Samba share directory
Pick the two files from the Samba share. Called them ent.pem and ent-key.pem
Create directory with the following structure:

├── Dockerfile
└── etc-pki-entitlement
    ├── ent-key.pem
    └── ent.pem

Dockerfile contains:

FROM registry.redhat.io/openshift4/ose-jenkins-agent-base

USER root

COPY ./etc-pki-entitlement /etc/pki/entitlement

RUN rm /etc/rhsm-host && \
    yum repolist --disablerepo=* && \
    subscription-manager repos --enable rhel-7-server-ansible-2.9-rpms && \
    yum -y update && \
    yum -y install ansible && \
    rm -rf /etc/pki/entitlement

USER 1001
ENTRYPOINT ["/bin/bash"]

Start CRC:
Run commands:

$ oc login -u kubeadmin -p *****-qmTth-oxaoD-p3xQF https://api.crc.testing:6443
$ oc new-project sandbox
$ oc new-build --name ansible-slave --binary --strategy docker
$ docker login registry.redhat.io -u <RH_LOGIN> -p <RH_PASSWORD>
$ oc create secret generic redhat-registry --from-file=.dockerconfigjson=/home/<USERNAME>/.docker/config.json --$ type=kubernetes.io/dockerconfigjson
$ oc secrets link builder redhat-registry
$ oc set build-secret --pull bc/ansible-slave redhat-registry
$ oc start-build ansible-slave --from-dir=. --follow

Which results in the following result:
Push successful 🍀
It would be great to get the entitlements files from the RedHat Portal. Just like the Pull-Secret

Improvements to this are being discussed in https://github.com/openshift/enhancements/pull/214
See also https://blog.openshift.com/how-to-use-entitled-image-builds-to-build-drivercontainers-with-ubi-on-openshift/ for a slightly different way of setting up these entitlements.
There is nothing which is CRC-specific though, so I'll close this issue.

Related:
https://bugzilla.redhat.com/show_bug.cgi?id=1823710


GO:0015563 uptake transmembrane transporter activity vs. GO:0098663 transmembrane transporter activity involved in import into cell

moved from #14278
Please note the term:
GO:0015563 uptake transmembrane transporter activity
Definition: Enables the transfer of a specific substance or related group of substances from the outside of a cell to the inside across a membrane.
seems to be equivalent to:
GO:0098663 transmembrane transporter activity involved in import into cell
But GO:0015563 does not have the parent term: GO:0098657 import into cell
It looks to me like it should. And then the phrase 'transmembrane transporter activity involved in import into cell' should be added as a synonym to GO:0015563 uptake transmembrane transporter activity
Ruth

Hi all,

I will propose to obsolete 'GO:0098663 transmembrane transporter activity involved in import into cell'; there are no annotations, and I dont think the specific location of the transport is relevant in the MF.

Does anyone know about 'uptake transmembrane transporter activity'? I am tempted to rename the terms with this string to remove the "uptake". It seems like the terms were created to also capture the process of import into cell, but really that needs to be a BP annotation to be consistent across all types of transporters.

Moreover about point 2 above: the textual definitions and the logical definition of children of 'uptake transmembrane transporter activity' is not consistent with the 'uptake' textual definition "Enables the transfer of a specific substance or related group of substances from the outside of a cell to the inside across a membrane."
For example:
allantoin uptake transmembrane transporter activity
textual definition: Enables the transfer of a specific substance or related group of substances from the outside of a cell to the inside across a membrane.
logical definition:
'uptake transmembrane transporter activity'
and ('transports or maintains localization of' some allantoin)
So I will make the 'uptake' terms synonyms.

 PomBase annotations have appropriate "x import across plasma membrane"
annotation.

also spotted
high-affinity ferrous iron uptake transmembrane transporter activity
high-affinity zinc uptake transmembrane transporter activity
used by PomBAse

need a term for plasma membrane import  term for
"high-affinity zinc II ion transmembrane import"
There is a similar issue with high and low affinity, it is sometimes doubly encoded in  MF and BP
I don't think we need it in BP too do we ?

Can I assume that I don't need to do anything because you will just be renaming?
Thanks
Ruth

Hi  Ruth. I double checked the pombe ones that  the corresponding "import across plasma membrane " term had been used for the process annotation.
You might want to do this too?
v

Good point
Processes added, but there is no process term thiamine import (across plasma membrane), but are you going to create new terms for all molecules imported? Or would you be planning on a general term, such as vitamin import?
I used AEs to specify extracellular space to cytosol, as extensions to the transmembrane transport term; but not sure this is the best approach to take?
Ruth


Accessibility: Unable to view the applied filters tooltip on dashboards

How to reproduce the bug

Create a dashboard
Set up some filters on the dashboard
Save the dashboard
On the dashboard you created, apply a filter
Use your keyboard to navigate on the dashboard

Expected results
User should be able to open the applied filters menu on charts that have a filter applied to see the filters list

https://www.w3.org/TR/WCAG22/#keyboard
Actual results
Unable to open the menu
Environment
(please complete the following information):

browser type and version:
superset version: master
python version: python --version
node.js version: node -v
any feature flags active:

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

@eschutho has a draft for some work on keyboard navigation in dashboards, might be worth checking in with her to make sure none of the work will overlap or be duplicated

https://github.com/apache/superset/pull/28015


[DOC] Fix triple string fo trimmed_* so that doc can show up

Presently, trimmed_var, trimmed_mean and trimmed_std don't show up.

thanks, merged


Support objects for weighted sampling?

Example usage:
import {sample} from 'pandemonium';
sample({
    apple: 10,
    orange: 8,
    pear: 1
});
>>> 'orange'

Example implementation: https://github.com/substack/node-deck/blob/master/index.js

Sure, this would be nice to have. A version taking only a list of weight would be nice (plus you need to know if you have relative weights to avoid a O(n) pass before or not.
Reservoir sampling would also be cool.
Do you want to create a PR to add the function?

@jbilcke I just added the weightedChoice and weightedRandomIndex functions.


Initial commit for the 80rave theme :tada: :lipstick:

Note: I have tried to produce the screenshot in the format you use, but I haven't found a way to do it exactly - so at least I provided output from the colortest-16. Cheers

[x] Put an x between the brackets on this line if you have done all of the following things:

Create a new file name your-scheme-name.js under scheme folder
The code format look like this:

'use strict';

module.exports = {
  colors: {
    black: '...',
    red: '...',
    green: '...',
    yellow: '...',
    blue: '...',
    magenta: '...',
    cyan: '...',
    white: '...',
    lightBlack: '...',
    lightRed: '...',
    lightGreen: '...',
    lightYellow: '...',
    lightBlue: '...',
    lightMagenta: '...',
    lightCyan: '...',
    lightWhite: '...',
  },

  // Default
  backgroundColor: '...',
  foregroundColor: '...',
  cursorColor: '...',
  borderColor: '...',

  // Accent color
  accentColor: '...',

  // Other (optional, it will be override by foregroundColor)
  inactiveTabTitleColor: '...',
  activeTabTitleColor: '...',

  // css (optional)
  css: '...',
  termCSS: '...',
};

Add your color scheme to the :point_right: schemeIndex (ALPHABETICAL order)
Add your color scheme to the README.md list (ALPHABETICAL order)
Add your color scheme to the :point_right: keywords (ALPHABETICAL order)

@PetrBarborka Thank you for the contributing :heart:.
Could you remove the activateTabStyle, highlightActiveTab and lightEffect from the 80rave.js ?? thank :+1:

Done. Offtopic: How do I make the color palette screenshot like you do? Thx

@PetrBarborka Well, I use this shell script.
Don't worry about the screenshot, I'll do it my self 👍

Ok, last changes request, change the **26** to **27** from README.md, I forgot to put it in the PR template, sorry...

Well, could have thought of that myself... :D

Merged, thanks :zap:

:+1:

@PetrBarborka I've finished the screenshot of your 80rave and add it to the gif :tada:

Great, thank you. Hopefully someone will find it uselful. All the other themes were too little saturated and not crazy enough for my taste :rofl:


Update image compression

Technical description

[x] Feature description...

Tested on

Steps to reproduce

Screenshots (optional):
No screenshots.
This Pull Request template has been written and generated by Monk JS repository.

I just tested with webp on my pc and it works. I just need to test it on different device but it is possible to compress on webp..


Types don't seem to highlight correctly without newlines

Originally, i thought that highlighting $ variables wasn't working. Turns out it is, except in the following situation:
Function Fail([string]$Message = "") {

Closed by #36 i think


add mem tokens during inference

doesn't quite work atm:
  File "/workspace/axolotl/src/axolotl/monkeypatch/llama_landmark_attn.py", line 673, in forward
    raise ValueError(
ValueError: Attention mask should be of size (1, 1, 1, 2641), but is torch.Size([1, 1, 1, 2642])

okay, should work now!

superseded by #177


FEAT: Implement batch processing for OpenAI embeddings

Description
This pull request introduces batch processing functionality for OpenAI embeddings, significantly improving the handling of large text inputs. The new implementation allows for more efficient processing of text data exceeding 500,000 characters.
Changelog Entry
Added

New file backend/apps/rag/batch_utils.py implementing batch processing for OpenAI embeddings
Async processing for large text inputs in OpenAI embeddings generation

Changed

Updated backend/apps/rag/utils.py to incorporate the new batch processing functionality
Modified the generate_openai_batch_embeddings function to use either sync or async processing based on input size

Fixed

Improved handling of large text inputs for OpenAI embeddings, addressing potential rate limiting issues

Pull Request Checklist

[x] Target branch: This pull request targets the dev branch.
[x] Description: A concise description of the changes is provided above.
[x] Changelog: A changelog entry following the format of Keep a Changelog has been added.
[x] Documentation: No additional documentation needed, since functionality remains the same from user's side.
[x] Dependencies: No new dependencies were added. Currently supports both openai and tenacity packages.
[x] Testing: A test function test_request_async_embedding has been included in batch_utils.py.
[x] Code review: A self-review of the code has been performed, addressing coding standards and project guidelines.
[x] Prefix: The pull request title is prefixed with "FEAT" to indicate a new feature.

Additional Information
This implementation significantly enhances our ability to process large volumes of text for embedding generation. It automatically switches between synchronous and asynchronous processing based on the input size, optimizing for both small and large text inputs.
To test, set OPENAI_API_KEY in your env and call $python ./backend/apps/rag/batch_utils.py
Screenshots or Videos
N/A for this backend implementation.

As I am trying to switch to LangChain Embedding interfaces in another PR, do you think this implementation will solve the same issues you are trying to tackle?

Hello @c0sogi,
As I am trying to switch to LangChain Embedding interfaces in another PR, do you think this implementation will solve the same issues you are trying to tackle?

No, the “Batch” feature I'm adding is not the same as Langchain's Batch feature you mentioned.
To be more specific, the “Async batch” feature I'm adding is based on OpenAI's recently added Batch API (asynchronous response),
It allows user to request more tokens and produce the same results at 50% less cost.
The part you're referring to is “synchronously” requesting Batch per chunk of text, which can be told Batch, but using a completely different API.
So essentially, the reason I raised this PR is because the tokens per request limit is too high while using this “Synchronous batch”, and the only way to fix this is to either move up the OpenAI API tier, or enforce the enqueued token limit criteria using the Batch API.

Hello @c0sogi,
As I am trying to switch to LangChain Embedding interfaces in another PR, do you think this implementation will solve the same issues you are trying to tackle?

No, the “Batch” feature I'm adding is not the same as Langchain's Batch feature you mentioned.
To be more specific, the “Async batch” feature I'm adding is based on OpenAI's recently added Batch API (asynchronous response),
It allows user to request more tokens and produce the same results at 50% less cost.
The part you're referring to is “synchronously” requesting Batch per chunk of text, which can be told Batch, but using a completely different API.
So essentially, the reason I raised this PR is because the tokens per request limit is too high while using this “Synchronous batch”, and the only way to fix this is to either move up the OpenAI API tier, or enforce the enqueued token limit criteria using the Batch API.

Oh I see! That's cool. I will see then how to integrate this through the Langchain Embedding interface so we can group both implementations 😊

🙏 suffering rate limit of openai when voice/vedio calling

Closing due to conflicts, feel free to create a new PR!


Update _peak_finding.py

Fix typo: prominenence --> prominence

Reference issue

What does this implement/fix?

Additional information

Thanks @macrocosme.

Please don't merge PRs directly into maintenance branches like this--the standard workflow is pretty much always to merge into master and then backport if warranted. At this stage, typo fixes are probably more churn than it is worth for 1.3.2.


Unable to switch github account for pipelines

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Go to pipelines -> Configure Repositories
Authorize & Fetch Your Own Repositories, log in to github account
Log out User username
Log in to another user

Result:
Instantly logged in to same user again, no option to log in to another github account
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
v2.1.2

You will need to logout on github side before log in to another github account.
OAuth is used for the authentication, so it is done in the "OAuth Dance" way.

Feel free to reopen it if you have further questions


Support listening on AF_UNIX sockets

Thanks for Seasocks, works great for me so far!
This patch adds a method startListeningUnix to Server that lets the server listen on unix domain sockets as well as internet sockets.
My motivation for the patch is that I will have many servers running (one for each customer) and rather than allocate port numbers for each one and maintain a mapping from customer ID to port number, I would rather use the filesystem hierarchy for this organisation. I will use nginx to reverse proxy the connections to Seasocks.
The info line that Seasocks logs:
info: Listening on unix socket: http://unix:/var/eventstore/ws.socket

is nginx-compatible, ie:
location /ws/ {
    proxy_pass http://unix:/var/eventstore/ws.socket;
    proxy_http_version 1.1;
    proxy_set_header Upgrade $http_upgrade;
    proxy_set_header Connection $connection_upgrade;
}

In configureSocket it sets SO_REUSEADDR which I don't believe has any effect on AF_UNIX sockets (but doesn't break anything)
However, calling setMaxKeepAliveDrops will probably cause configureSocket to fail for unix sockets since it tries to set IPPROTO_TCP options. I suppose we could detect _maxKeepAliveDrops > 0 somewhere or other and throw an error but personally I feel this isn't a big deal and people should just not do that.
Some code was copied from startListening into startListeningUnix. If you think it's worthwhile to factor out the listen/epoll_ctl stuff let me know.

Hi there,
I like the idea. There seems to be a failing test, maybe take a quick look at the travis link above.
I haven't looked at the code yet but will try to do so over the next few days!
Cheers, Matt

Thanks. make test succeeds on my machine. The travis build appears to have failed due to the following error from apt-get:
E: Unable to locate package g++-6

Cheers,
Doug

Ok that looks like a separate Travis issue; I'll look in to that later too!
Thanks for checking; I guess I should have taken a quick look myself first!
On Thu, Dec 15, 2016 at 5:05 PM, Doug Hoyte<EMAIL_ADDRESS>wrote:

Thanks. make test succeeds on my machine. The travis build appears to
have failed due to the following error from apt-get:
E: Unable to locate package g++-6
Cheers,
Doug
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mattgodbolt/seasocks/pull/41#issuecomment-267470735,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAmsdWsu-HjZIcT413Xo_04qzxZkgg30ks5rIceKgaJpZM4LOZbQ
.

Looked great to me: thanks for the contribution!


WIP - Policy Groups List in the policy revision API

Signed-off-by: Vinay Satish<EMAIL_ADDRESS>Description
Currently we don't have the details of the group in the policy revision API - /organizations/[organization_id]/policies/[policy_name/revisions/[revision_id]. In automate UI we need to populate the list of groups to which the policy revision belongs to. Adding a new key - policy_group_list for the required detail.
Issues Resolved
Resolves #2679
Check List

[ ] New functionality includes tests
[ ] All buildkite tests pass
[ ] Full omnibus build and tests in buildkite pass
[ ] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/main/CONTRIBUTING.md#developer-certification-of-origin-dco
[ ] PR title is a worthy inclusion in the CHANGELOG

looking good so far!

We should also update the API documentation as a part of this change.


md-tab-group Promise rejection: Failed to execute 'animate' on 'Element'

Bug, feature request, or proposal:
Hi,
the mdTabGroup component seems doesn't like the [selectedIndex] attribute.
Each time this parameter is defined, I have this error in the Chrome console :
Promise rejection: Failed to execute 'animate' on 'Element': Partial keyframes are not supported. ; Zone: <root> ; Task: Promise.then ; Value: DOMException: Failed to execute 'animate' on 'Element': Partial keyframes are not supported.
Any idea ?
Best regards,

What version of Angular are you using?

I am using the current version, the 2.0.0-beta.1

I mean which version of the Angular framework, not Angular Material.

Sorry, 2.4.2

Thanks. This sounded similar to https://github.com/angular/material2/issues/2151, although that one should be fixed with Angular 2.4.2.

Yes ! Thanks, it's works perfectly with Angular 2.4.2,
have a nice day !

I also encountered similar issue when I generate the 2nd tier of dynamic tabs (the 1st tier of tabs are static).
error: Failed to execute 'animate' on 'Element': Partial keyframes are not supported.
Attached sample coding for reference. Thanks.
test-tab.component.txt
angular: 2.4.1
material: 2.0.0-beta.1

Can you try using Angular 2.4.2 @vivian7169?

Yes, just now upgraded to 2.4.2 and the issue fixed.
Thanks!

On 12 Jan 2017, at 5:38 PM, Kristiyan Kostadinov<EMAIL_ADDRESS>wrote:
Can you try using Angular 2.4.2 @vivian7169 https://github.com/vivian7169?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/angular/material2/issues/2597#issuecomment-272117314, or mute the thread https://github.com/notifications/unsubscribe-auth/AFLILsTIOXud7VYCOuIUTv1MKXtX-IT8ks5rRfSJgaJpZM4Lgtmp.


IE 11 support

I know, that ember-window-mock can't fully work in IE11, because of the missing Proxy support. However, it would be nice, if it wouldn't crash the full test suite. 😅
Since new URL is not available in IE11, this line crashes everything:
https://github.com/kaliber5/ember-window-mock/blob/ada959b92f104c875066140be3c3ca7f34110f7d/addon-test-support/-private/mock/location.js#L25
There's potentially more, but I haven't yet debugged it. Would you accept a PR that make ember-window-mock play a bit nicer with IE11?

Sure!
Maybe we could also export a test helper like isSupported(), that tells you if the current browser has support for the DOM APIs required by ember-window-mock, to know when to skip certain tests?

Cool. 😊
I thought about something along these lines as well. isSupported could just be a constant, I guess.
import { IS_SUPPORTED } from 'ember-window-mock':

(IS_SUPPORTED ? test : skip)('some test', function(assert) {

});

Yeah, that could work!

@buschtoens @simonihmig there is a polyfill for proxy, is there a way to optionally pull in this polyfill for IE11?
https://github.com/GoogleChrome/proxy-polyfill

Considering we deem this polyfill "feature-complete enough", I am happy to take over / to lead / lobby for / help wherever I can with the implementation. @ClarkSource has business requirements for running CI in IE11 and anything that aligns with that I can get on our road map! 🗺😄

It looks like this addon uses has and deleteProperty from the Proxy API, which isn't currently supported by the polyfill. I'm not sure if it's possible to add that to the polyfill, but that's where we'd need to start I think.

Any further thoughts on this @buschtoens?

Seems like this can be closed now that IE is deprecated.

Absolutely, yes! 🥳


FlatModifers with selector of type "-dc" don't have "check:statistic:" included in their context

For example, Forest Troll (BB) has automation for "Easily Misled":
{
	"key": "FlatModifier",
	"predicate": [
		"check:statistic:deception"
	],
	"selector": "perception-dc",
	"type": "circumstance",
	"value": -4
}

It doesn't seem to work with the predicate (it does affect the dc without the predicate).

Ah, makes sense. Since we can currently predicate on things like "action:", perhaps we need a "skill:" roll option or some such.

We can fix this specific issue by just spelling out the deception actions that target perception.

Also need this for Succubus' Seductive Presence.


[WIP] Mgmt ui integration

Coverage decreased (-0.2%) to 24.09% when pulling 1db935c68d844e26b50fc610c855f1294bc451fa on mgmt_ui_integration into 22368a06e853bd18077af683ee8388cc22b76845 on master.

Just a few notes:

What is the "save" button for on the message-flow-analyzer?
the mgmt-ui is partly is german (or does it detect browser language)?
once I receive a watcher notification, there is a "details" button, but clicking on it just makes the notification disappear, I don't get to see any details

Last but not least, did I say WOW? Really WOW! Gonna merge as is for now.


"Minimum role to post" disallows people from initially joining without that role

Currently, if you set the "Minimum role to post" of a channel in Teams, it disallows anyone without that role (or higher) to initially join it, effectively making it unreadable by anyone who doesn't have the required role.
However, if you joined the channel and then the minimum role is changed, you can still read the channel just not send messages anymore (it'll display an error saying you don't have the required role).

@Bauke thanks for reporting! a fix is in review, will update when live

@Bauke the fix has been deployed! closing this for now, let me know if you have any other issues


Error handling, tests, cleanup

Codecov Report

:exclamation: No coverage uploaded for pull request head (cleanup@62cc34d). Click here to learn what that means.
The diff coverage is n/a.


Remove dictionary alloc in routing

This changes TemplateMatcher to mutate RouteData.Values directly instead
of creating a new dictionary and then merging in values. This is one the
biggest single costs in routing in terms of both allocations and execution
time.
So Match now becomes TryMatch. This will dirty the state of the RVD, so
the caller needs to snapshot it before calling into it (handled
inside the TreeRouter or RouteCollection).
Some subtle changes were needed to how/when values are added to be
compatible with the existing tests. The general idea is that we add null
values for non-parameter defaults or catchalls, but only if they don't
trounce an existing value. This logic used to live in MergeValues but now
it's in TryMatch since TryMatch might be working from existing data.
Also fixed the .sln to avoid building a package that we use as shared
source.

Sampling Data from HelloWorldMvc (Plaintext)
Before

After

Allocation Data from HelloWorldMvc (Plaintext)
Before

After

I'm experimenting with using dotTrace's ETW collection for this, so the allocation numbers are only comparable as percentages not as totals (different number of requests). So 17.01% before vs 4.79% after.

:shipit: after addressing minor comments


Removed __EV3_MODULE_connected

I think we agree on these changes, at least

Is this helpful? It works on my brickpi....

I will look at this tonight and maybe tomorrow - super busy the next couple of days

Anton, did you also make the change in the autogen templates to generate the changes in the bindings? I'm going to do the merge now but I'll also fix up the bindings, OK?

i just pushed a first draft of autogened ev3dev.py with support for helper functions that take kwargs. I still need to clean up how string vs int arguments are handled, but I'm pretty happy with how this worked out - comments on naming etc are welcome!

Nice. You can't have slashes in parameters, though. ("hold_pid/Ki") python thinks you want to divide it then.
I would also make two lists of properties: _int_properties and _str_properties so you can sort them out and cast them in the helper function.
On Mon, Oct 12, 2015 at 10:51 PM, Ralph Hempel<EMAIL_ADDRESS>wrote:

i just pushed a first draft of autogened ev3dev.py with support for helper functions that take kwargs. I still need to clean up how string vs int arguments are handled, but I'm pretty happy with how this worked out - comments on naming etc are welcome!
Reply to this email directly or view it on GitHub:
https://github.com/rhempel/ev3dev-lang-python/pull/3#issuecomment-147515891

Yes, I caught that - check out what I just pushed - it works pretty well now

I have merged with @ddemidov's more recent pull request - closing this one.


Fix deprecation warning coming from Mill itself

Should already be fixed by https://github.com/com-lihaoyi/mill/pull/3379

Yes, I didn't notice the PR.


Use Github Actions to publish to PyPI on new tag.

Currently, it's just up to me to deploy new versions of ScreenPy. It would be nifty neato if just pushing up a new tag would trigger the deployment process!
There's a new process, too, that makes it even easier: https://docs.pypi.org/trusted-publishers/
Let's do that!

Looks like it works!!!
https://github.com/ScreenPyHQ/screenpy/actions/runs/5151642626/jobs/9277081255


Wallet Instance request media type

@rohe 's
var+jwt (Verifiable Assertion Request JWT) are there other Verifiable Assertion Request then a Wallet Instance Attestation Request?
If so I'd rather have wiar+jwt as the header typ for a Wallet Instance Attestation Request.
We should be as specific as necessary.

@peppelinux what do you think?
wiar was the value we previously had and then you asked to change to var+jwt

@grausof if it's as you mentioned then the PR is up to me, consider it done


When available, create the User interfaces based on the schema of the extension

Strapi user can be modified from the admin panel as well as creating the corresponding folder and files in the extensions folder. When that happens, those changes need to be reflected in the interface, instead of always being hardcoded.

any updates on this? really could need this feature


gst-plugins-bad-1.18.0 does not build on x86_64-linux

Describe the bug
gst-plugins-bad version 1.18.0 fails to build.
To Reproduce
Steps to reproduce the behavior:

nix-build --no-out-link -E 'with import <nixpkgs> { }; gst_all_1.gst-plugins-bad'

Expected behavior
Build properly completes.
Logs
FAILED: ext/spandsp/libgstspandsp.so.p/gstspanplc.c.o
gcc -Iext/spandsp/libgstspandsp.so.p -Iext/spandsp -I../ext/spandsp -I. -I.. -I/nix/store/hap0645fi59ch3xzsaxwhci12lhf8mli-gst-plugins-base-1.18.0-dev/include/gstreamer-1.0 -I/nix/store/np39z34vyzjfm6w67x2yw4fpsw27s5yj-gstreamer-1.18.0-dev/include/gstreamer-1.0 -I/nix/store/k0hqxfw4r08c0gk10a1g1sdy371xjhyd-glib-2.66.2-dev/include -I/nix/store/k0hqxfw4r08c0gk10a1g1sdy371xjhyd-glib-2.66.2-dev/include/glib-2.0 -I/nix/store/jckkjnmp03266z8yfw403wnzbwkn4hpk-glib-2.66.2/lib/glib-2.0/include -I/nix/store/ary678h9za0pvznv263ff9q4xyfda9cy-spandsp-3.0.0-dev/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -fvisibility=hidden -fno-strict-aliasing -Wmissing-prototypes -Wdeclaration-after-statement -Wold-style-definition -Wmissing-declarations -Wredundant-decls -Wwrite-strings -Wformat -Wformat-security -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wvla -Wpointer-arith -fPIC -DHAVE_CONFIG_H -MD -MQ ext/spandsp/libgstspandsp.so.p/gstspanplc.c.o -MF ext/spandsp/libgstspandsp.so.p/gstspanplc.c.o.d -o ext/spandsp/libgstspandsp.so.p/gstspanplc.c.o -c ../ext/spandsp/gstspanplc.c
../ext/spandsp/gstspanplc.c: In function 'gst_span_plc_create_stats':
../ext/spandsp/gstspanplc.c:87:45: error: dereferencing pointer to incomplete type 'plc_state_t' {aka 'struct plc_state_s'}
   87 |         "pitch", G_TYPE_INT, self->plc_state->pitch,
      |                                             ^~

Full build log: http://u.dk0.us/31119-gst.log
Additional context
This is blocking rebuilds.
Notify maintainers
@matthewbauer @jtojnar
Metadata

system: "x86_64-linux"
host os: Linux 5.10.0-rc2, NixOS, 21.03pre251987.2de60095d2b (Okapi)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.8
channels(root): "home-manager, nixos-21.03pre252892.1491bab2b11"
channels(anna): ""
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: gst_all_1
# a list of nixos modules affected by the problem
module:

I'm experiencing this as well.

might be due to spansp upgrade in e184cede9210608ebe5d04972d79338e92ca4b60