Hacktoberfest participation

A few issues here have the Hacktoberfest labels, which is great, but the repo does not have the Hacktoberfest topic added to it, so when people make a PR, they are not given credit for Hacktoberfest.
Please add the HACKTOBERFEST topic to the repo OR
add HACKTOBERFEST-ACCEPTED labels to merged PRs that were made in response to Hacktoberfest issues.
Specifically:

#37
#38

See relevant information here: https://hacktoberfest.com/participation/#pr-mr-details

Are you sure about that? Because all of the documentation I have read says that is really not needed and it can take up to seven days for contributions to be counted.
…
On Tue, Oct 10, 2023 at 10:43 AM CarbonNeuron @.> wrote: A few issues here have the Hacktoberfest labels, which is great, but the repo does not have the Hacktoberfest topic added to it, so when people make a PR, they are not given credit for Hacktoberfest. — Reply to this email directly, view it on GitHub <#39>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADK6I6H64QHCDWKPAZTCBHLX6VUJ7AVCNFSM6AAAAAA52SLVZSVHI2DSMVQWIX3LMV43ASLTON2WKOZRHEZTKNRXGM4DGMY . You are receiving this because you are subscribed to this thread.Message ID: @.>
-- Richard Callaby @.***

I am very sure.

You can see it says this repo is not participating.

This is the part that says you either need the topic or the label.

You see you could've just simply asked me to add the hacktoberfest-accepted
label.
I can assure you in the future this won't be an issue as this is the first
and very last time I participate in hacktoberfest.
On Tue, Oct 10, 2023 at 10:50 AM CarbonNeuron @.***>
wrote:

Are you sure about that? Because all of the documentation I have read says
that is really not needed and it can take up to seven days for
contributions to be counted.
… <#m_7496729512910122344_>
On Tue, Oct 10, 2023 at 10:43 AM CarbonNeuron @.> wrote: A few issues
here have the Hacktoberfest labels, which is great, but the repo does not
have the Hacktoberfest topic added to it, so when people make a PR, they
are not given credit for Hacktoberfest. — Reply to this email directly,
view it on GitHub <#39
https://github.com/rcallaby/Emacs-Guide/issues/39>, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADK6I6H64QHCDWKPAZTCBHLX6VUJ7AVCNFSM6AAAAAA52SLVZSVHI2DSMVQWIX3LMV43ASLTON2WKOZRHEZTKNRXGM4DGMY
https://github.com/notifications/unsubscribe-auth/ADK6I6H64QHCDWKPAZTCBHLX6VUJ7AVCNFSM6AAAAAA52SLVZSVHI2DSMVQWIX3LMV43ASLTON2WKOZRHEZTKNRXGM4DGMY
. You are receiving this because you are subscribed to this thread.Message
ID: @.>
-- Richard Callaby @.***
I am very sure.
[image: image]
https://user-images.githubusercontent.com/16768821/273976655-29dd1935-85c3-4bdb-b48f-ad4ebe68f1e0.png
You can see it says this repo is not participating.
[image: image]
https://user-images.githubusercontent.com/16768821/273976813-9210614a-c0b6-4a03-9edc-3bd0593c0389.png
This is the part that says you either need the topic or the label.
—
Reply to this email directly, view it on GitHub
https://github.com/rcallaby/Emacs-Guide/issues/39#issuecomment-1755730210,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADK6I6BVDC3D3HPEUVXBTNLX6VVERAVCNFSM6AAAAAA52SLVZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJVG4ZTAMRRGA
.
You are receiving this because you commented.Message ID:
@.***>

--
Richard Callaby
@.***

I apologize for any inconvenience my previous messages may have caused. My intent was purely to ensure that contributors receive recognition for their efforts during Hacktoberfest, and I didn't mean to come across as demanding or critical.
I truly appreciate your willingness to participate in Hacktoberfest and understand that managing a repository, especially during such events, can be quite demanding. I am grateful for your time and effort in addressing the issue, and I am sorry for any frustration I may have caused.
Thank you once again for your time and for considering my request. I appreciate your support towards the open-source community.


ITS-3375 Adding a check so the idData connector data does not call the id serv…

…ice when there is no NINO from PDV

@ajchilts  Is it good to handle it at first step in Controller?

@rambabu-posa  - I think we need to omit the call if we do not need to make it. This is proving difficult with the way that the code is written as it expects either an error of individuals details. When in reality it's OK to have non matched and no individuals details.


binexport: loop detection Ghidra-generated BinExport

          This doesn't appear to work for Ghidra-generated BinExport (see CI fails). This must be an issue with the BinExport files themselves as we don't calculate the back edges in capa. It's not clear where the issues lies in the BinExport file generation, specifically, if it's with the Ghidra extension or BinExport core. More investigation needed.

Originally posted by @mike-hunhoff in https://github.com/mandiant/capa/pull/1950#discussion_r1613954246
issue lies in the Ghidra extractor: google/binexport#131

I looked into this on the BinExport side and did not find a clear path forward for implementation w/out additional input from the BinExport developers. I've fallen back in 798894a to loop detection that uses the same method as our other feature extractors (w/ a #TODO to update the code when the bug has been resolved in BinExport).

great, thanks!


Check in myzone example to the examples directory.

README to follow. This example contains an application that fetches the GCP zone the cluster is running in and serves that information on the paths /  or /index.path  via an nginx server.

Awesome thanks @madhusudancs
cc @mdelio
How about naming it zone-printer instead of myzone?

How about naming it zone-printer instead of myzone?

@nikhiljindal good idea. Done. PTAL.

/lgtm

I tried this example just now and got the following errors:
Error from server (BadRequest): error when creating "examples/zone-printer/app/nginx-dep.yaml": the API version in the data (apps/v1beta2) does not match the expected API version (apps/v1beta1)

And while creating the lb using mci I got:
could not find matching nodeport for backend {echoheadersx {0 80 }} and service default/echoheadersx

These could be problems with my setup but wondering if anyone else ran into this?

Is this cluster 1.8.1?

Yes
On Oct 31, 2017 7:36 PM, "Madhusudan.C.S"<EMAIL_ADDRESS>wrote:

Is this cluster 1.8.1?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/28#issuecomment-340961581,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJugO82ZSHL9CrptdHjWOKS2FbS2NydAks5sx9k7gaJpZM4QNSmP
.

That's interesting...


Fix for cgroup driver link issue

Issue #43016

preview page: https://deploy-preview-43034--kubernetes-io-main-staging.netlify.app/docs/setup/production-environment/tools/kubeadm/install-kubeadm/#configuring-a-cgroup-driver

/label tide/merge-method-squash
/lgtm

/approve


SmsMessage constructor does not accept phone number as string

The SmsMessage constructor does not accept a string phone number as indicated in the documentation.
https://docs.microsoft.com/en-us/xamarin/essentials/sms?context=xamarin/xamarin-forms
The decompiled code asserts this
public static partial class Sms
    {
        public static Task ComposeAsync()
            => ComposeAsync(null);

        public static Task ComposeAsync(SmsMessage message)
        {
            if (!IsComposeSupported)
                throw new FeatureNotSupportedException();

            if (message == null)
                message = new SmsMessage();

            if (message?.Recipients == null)
                message.Recipients = new List<string>();

            return PlatformComposeAsync(message);
        }
    }

    public class SmsMessage
    {
        public SmsMessage()
        {
        }

        public SmsMessage(string body, IEnumerable<string> recipients)
        {
            Body = body;
            Recipients = recipients?.Where(x => !string.IsNullOrWhiteSpace(x)).ToList();
        }

        public string Body { get; set; }

        public List<string> Recipients { get; set; }
    }

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1b80826a-6389-7b3b-9c60-0682f735e7d2
Version Independent ID: 0987fc15-6ca4-faf3-56af-85f0bb22b92c
Content: Xamarin.Essentials: SMS - Xamarin
Content Source: docs/essentials/sms.md
Product: xamarin
GitHub Login: @jamesmontemagno
Microsoft Alias: jamont

Put in PR: https://github.com/MicrosoftDocs/xamarin-docs/compare/live...jamesmontemagno:patch-17
we should also have that constructor though... so opened an issue: https://github.com/xamarin/Essentials/issues/672

Documentation has been updated, thanks for letting us know.


Chef 13 recipe compile error.

Using lazy attribute with Chef 13.2.20 causes recipe compilation errors, e.g.
================================================================================
       Recipe Compile Error in /tmp/kitchen/cache/cookbooks/radian_chef_automate/recipes/default.rb
       ================================================================================

       RuntimeError
       ------------
       can't modify frozen PoiseDerived::LazyAttribute

       Cookbook Trace:
       ---------------
         /tmp/kitchen/cache/cookbooks/poise-derived/files/halite_gem/poise_derived/lazy_attribute.rb:111:in `_evaluate'
         /tmp/kitchen/cache/cookbooks/poise-derived/files/halite_gem/poise_derived/lazy_attribute.rb:65:in `method_missing'
         /tmp/kitchen/cache/cookbooks/radian_chef_automate/recipes/default.rb:9:in `from_file'

       Relevant File Content:
       ----------------------
       /tmp/kitchen/cache/cookbooks/poise-derived/files/halite_gem/poise_derived/lazy_attribute.rb:

       104:      private
       105:
       106:      # Evaluate the lazy attribute.
       107:      #
       108:      # @return [Object]
       109:      def _evaluate
       110:        return @evaluate_cache if defined?(@evaluate_cache)
       111>>       @evaluate_cache = if @value.is_a?(Proc)
       112:          # Block mode, just run the block.
       113:          @node.instance_eval(&@value).to_s
       114:        else
       115:          # String mode, parse the template string and fill it in.
       116:          format_keys = @value.scan(FORMAT_STRING_REGEXP).inject({}) do |memo, (key)|
       117:            # Keys must be symbols because Ruby.
       118:            memo[key.to_sym] = key.split(/\./).inject(@node) {|n, k| n.nil? ? n : n[k] }
       119:            memo
       120:          end

Attribute code for repro:
base_pkg_url = lazy 'https://packages.chef.io/files/stable/automate/%{radian_chef_automate.version}'

case node['platform_family']
when 'rhel'
  if node['platform_version'] =~ /7\..*/
    default['radian_chef_automate']['pkg_url'] = lazy {
      "#{base_pkg_url}/el/7/automate-#{node['radian_chef_automate']['version']}-1.el7.x86_64.rpm"
    }
  elsif node['platform_version'] =~ /6\..*/
    default['radian_chef_automate']['pkg_url'] = lazy {
      "#{base_pkg_url}/el/6/automate-#{node['radian_chef_automate']['version']}-1.el6.x86_64.rpm"
    }
  else
  end
when 'amazon'
  default['radian_chef_automate']['pkg_url'] = lazy {
      "#{base_pkg_url}/el/6/automate-#{node['radian_chef_automate']['version']}-1.el6.x86_64.rpm"
  }
end

Running into what seems like the same issue trying to use a template.
The source attributes are
default['sso']['hostname'] = 'www.example.org'
default['sso']['openam']['server_port'] = 8080

and the derived attribute is written in the cookbook's attributes file as
default['sso']['openam']['web']['uri'] = lazy 'http://%{sso.hostname}:%{sso.openam.server_port}'

Chef error output (truncated for brevity):
================================================================================
Error executing action `create` on resource 'template[/opt/tomcat/conf/openam_config.properties]'
================================================================================

Chef::Mixin::Template::TemplateError
------------------------------------
can't modify frozen PoiseDerived::LazyAttribute

Resource Declaration:
---------------------
# In /tmp/kitchen/cache/cookbooks/sso/recipes/opensso.rb

 9: template "#{node['sso']['tomcat']['path']}/conf/openam_config.properties" do
      ...
13:   variables(
      ...
22:     uri:                      node['sso']['openam']['web']['uri']
23:   )
24:   sensitive false
25: end
26:

Compiled Resource:
------------------
# Declared in /tmp/kitchen/cache/cookbooks/sso/recipes/opensso.rb:9:in `from_file'

template("/opt/tomcat/conf/openam_config.properties") do
 action [:create]
 default_guard_interpreter :default
 source "openam_config.properties.erb"
 variables {
    ...
    :uri=>#<PoiseDerived::LazyAttribute @value="http://%{sso.hostname}:%{sso.openam.server_port}">
 }
 declared_type :template
 cookbook_name "sso"
 recipe_name "opensso"
 ...
 path "/opt/tomcat/conf/openam_config.properties"
 verifications []
end

Template Context:
-----------------
on line #21
19: SERVER_HOST = <%= @hostname %>
20: SERVER_PORT = <%= @http_port %>
21: SERVER_URI = <%= @uri -%>/openam/config/wizard/wizard.htm
22: SERVER_URL = <%= @uri %>
23:

System Info:
------------
chef_version=13.1.31
platform=centos
platform_version=6.6
ruby=ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]
program_name=chef-client worker: ppid=8928;start=17:10:26;
executable=/opt/chef/bin/chef-client

Got the same error. To reproduce:
# test_parent_cookbook/attributes/default.rb
default['test_child_cookbook']['work_dir'] = 'C:\WORK'

# test_parent_cookbook/recipes/default.rb
include_recipe 'test_child_cookbook'

# test_child_cookbook/attributes/default.rb
default['test_child_cookbook']['work_dir'] = 'C:\TMP'
default['test_child_cookbook']['home'] = lazy "%{test_child_cookbook.work_dir}\\somefoldername"

# test_child_cookbook/recipes/default.rb
puts "HOME dir is: #{node['test_child_cookbook']['home']}"

Error:
================================================================================
Recipe Compile Error in /tmp/kitchen/cache/cookbooks/test_parent_cookbook/recipes/default.rb
================================================================================

RuntimeError
------------
can't modify frozen PoiseDerived::LazyAttribute

Cookbook Trace:
---------------
  /tmp/kitchen/cache/cookbooks/poise-derived/files/halite_gem/poise_derived/lazy_attribute.rb:111:in `_evaluate'
  /tmp/kitchen/cache/cookbooks/poise-derived/files/halite_gem/poise_derived/lazy_attribute.rb:77:in `to_s'
  /tmp/kitchen/cache/cookbooks/test_child_cookbook/recipes/default.rb:7:in `from_file'
  /tmp/kitchen/cache/cookbooks/test_parent_cookbook/recipes/default.rb:7:in `from_file'

Relevant File Content:
----------------------
/tmp/kitchen/cache/cookbooks/poise-derived/files/halite_gem/poise_derived/lazy_attribute.rb:

104:      private
105:
106:      # Evaluate the lazy attribute.
107:      #
108:      # @return [Object]
109:      def _evaluate
110:        return @evaluate_cache if defined?(@evaluate_cache)
111>>       @evaluate_cache = if @value.is_a?(Proc)
112:          # Block mode, just run the block.
113:          @node.instance_eval(&@value).to_s
114:        else
115:          # String mode, parse the template string and fill it in.
116:          format_keys = @value.scan(FORMAT_STRING_REGEXP).inject({}) do |memo, (key)|
117:            # Keys must be symbols because Ruby.
118:            memo[key.to_sym] = key.split(/\./).inject(@node) {|n, k| n.nil? ? n : n[k] }
119:            memo
120:          end

System Info:
------------
chef_version=13.6.0
platform=centos
platform_version=7.3.1611
ruby=ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-linux]
program_name=chef-client worker: ppid=4089;start=18:22:08;
executable=/opt/chef/bin/chef-client

I’m running into the same issue, I think, on Chef 14.2.0:
Relevant code:
# attributes/default.rb
default['ds_maps']['app_dir'] = '/opt/maps'
default['ds_maps']['config_dir'] = lazy '%{ds_maps.app_dir}/config'
default['ds_maps']['config_file'] = lazy "%{ds_maps.config_dir}/local-#{node.chef_environment}.json"

# recipes/default.rb
git node['ds_maps']['app_dir'] do
  # [snip]
  notifies :create, "file[#{node['ds_maps']['config_file']}]", :immediately

Error output:
================================================================================
  Recipe Compile Error in /tmp/kitchen/cache/cookbooks/ds_maps/recipes/default.rb
  ================================================================================

  FrozenError
  -----------
  can't modify frozen PoiseDerived::LazyAttribute

  Cookbook Trace:
  ---------------
    /tmp/kitchen/cache/cookbooks/poise-derived/files/halite_gem/poise_derived/lazy_attribute.rb:111:in `_evaluate'
    /tmp/kitchen/cache/cookbooks/poise-derived/files/halite_gem/poise_derived/lazy_attribute.rb:77:in `to_s'
    /tmp/kitchen/cache/cookbooks/poise-derived/files/halite_gem/poise_derived/lazy_attribute.rb:121:in `%'
    /tmp/kitchen/cache/cookbooks/poise-derived/files/halite_gem/poise_derived/lazy_attribute.rb:121:in `_evaluate'
    /tmp/kitchen/cache/cookbooks/poise-derived/files/halite_gem/poise_derived/lazy_attribute.rb:77:in `to_s'
    /tmp/kitchen/cache/cookbooks/ds_maps/recipes/default.rb:55:in `block in from_file'
    /tmp/kitchen/cache/cookbooks/ds_maps/recipes/default.rb:50:in `from_file'

  Relevant File Content:
  ----------------------
  /tmp/kitchen/cache/cookbooks/poise-derived/files/halite_gem/poise_derived/lazy_attribute.rb:

  104:      private
  105:
  106:      # Evaluate the lazy attribute.
  107:      #
  108:      # @return [Object]
  109:      def _evaluate
  110:        return @evaluate_cache if defined?(@evaluate_cache)
  111>>       @evaluate_cache = if @value.is_a?(Proc)
  112:          # Block mode, just run the block.
  113:          @node.instance_eval(&@value).to_s
  114:        else
  115:          # String mode, parse the template string and fill it in.
  116:          format_keys = @value.scan(FORMAT_STRING_REGEXP).inject({}) do |memo, (key)|
  117:            # Keys must be symbols because Ruby.
  118:            memo[key.to_sym] = key.split(/\./).inject(@node) {|n, k| n.nil? ? n : n[k] }
  119:            memo
  120:          end

  Additional information:
  -----------------------
 Ruby objects are often frozen to prevent further modifications
 when they would negatively impact the process (e.g. values inside
 Ruby's ENV class) or to prevent polluting other objects when default
 values are passed by reference to many instances of an object (e.g.
 the empty Array as a Chef resource default, passed by reference
 to every instance of the resource).

 Chef uses Object#freeze to ensure the default values of properties
 inside Chef resources are not modified, so that when a new instance
 of a Chef resource is created, and Object#dup copies values by
 reference, the new resource is not receiving a default value that
 has been by a previous instance of that resource.

 Instead of modifying an object that contains a default value for all
 instances of a Chef resource, create a new object and assign it to
 the resource's parameter, e.g.:

 fruit_basket = resource(:fruit_basket, 'default')

 # BAD: modifies 'contents' object for all new fruit_basket instances
 fruit_basket.contents << 'apple'

 # GOOD: allocates new array only owned by this fruit_basket instance
 fruit_basket.contents %w(apple)

  System Info:
  ------------
  chef_version=14.2.0
  platform=ubuntu
  platform_version=16.04
  ruby=ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux]
  program_name=/opt/chef/bin/chef-client
  executable=/opt/chef/bin/chef-client

  Running handlers:
[2018-06-27T13:48:54+00:00] ERROR: Running exception handlers
  Running handlers complete
[2018-06-27T13:48:54+00:00] ERROR: Exception handlers complete
  Chef Client failed. 5 resources updated in 27 seconds
[2018-06-27T13:48:54+00:00] FATAL: Stacktrace dumped to /tmp/kitchen/cache/chef-stacktrace.out
[2018-06-27T13:48:54+00:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
[2018-06-27T13:48:54+00:00] FATAL: FrozenError: can't modify frozen PoiseDerived::LazyAttribute

By the way, as of ba76bc8, at least, this appears to be fixed. @coderanger, any chance of shipping a new version?

I would be really nice to get a release. Currently we host local version of this cookbook.

By the way, as of ba76bc8, at least, this appears to be fixed. @coderanger, any chance of shipping a new version?

I am not sure but it seems still an issue:
node3
node3
node3 Running handlers:
node3 [2019-05-14T03:40:36+00:00] ERROR: Running exception handlers
node3 Running handlers complete
node3 [2019-05-14T03:40:36+00:00] ERROR: Exception handlers complete
node3 Chef Client failed. 11 resources updated in 09 seconds
node3 [2019-05-14T03:40:36+00:00] FATAL: Stacktrace dumped to /var/chef/cache/chef-stacktrace.out
node3 [2019-05-14T03:40:36+00:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
node3 [2019-05-14T03:40:36+00:00] FATAL: FrozenError: can't modify frozen PoiseDerived::LazyAttribute
[vagrant@node2 lamp_stack]$ chef-client --version
Chef: 14.8.12

In fact, I have copies this file https://github.com/poise/poise-derived/blob/ba76bc88d61183f450b1bf8b10625920d2ff99e5/lib/poise_derived/core_ext/deep_merge.rb i.e.
[vagrant@node2 poise-derived]$ pwd
/home/vagrant/chef-repo/cookbooks/poise-derived
[vagrant@node2 poise-derived]$ ls ./files/halite_gem/poise_derived/core_ext/deep_merge.rb
./files/halite_gem/poise_derived/core_ext/deep_merge.rb

and updated it as well but as you see, still not fix the issue at least on 14.8.12. Although, the result of the string in my defaults.rb used is correct which is using yum_repository and it provides the correct string results.


mysql-connector-python==2.0.4 is available (you have 2.1.3)

Hello
Today I use pip-review for first time.
I updated several packets successfully. Thanks to dev :)
But it remains a wonder that dilemma (I am under ARM Archlinux).
$ pip-review
mysql-connector-python==2.0.4 is available (you have 2.1.3)
It's normal?

No, that's not supposed to happen. Thanks for reporting this. I will accept pull requests that fix this, otherwise the fix is probably going to happen after I find the time to rewrite pip-review to use pip list --outdated.

I just found out that this issue appears to have been reported before to the original pip-tools repo. That ticket contained more examples.
https://github.com/nvie/pip-tools/issues/123

More examples
distro-info==0.10 is available (you have =0.14build1)
pygobject==2.28.3 is available (you have 3.22.0)
python-apt==0.7.8 is available (you have 1.1.0b5)

prettytable==7 is available (you have 0.7.2)
Upgrade now? [Y]es, [N]o, [A]ll, [Q]uit Y
Collecting prettytable==7
  Could not find a version that satisfies the requirement prettytable==7 (from versions: 0.3, 0.4, 0.5, 0.6, 0.6.1, 0.7, 0.7.1, 0.7.2)
No matching distribution found for prettytable==7

@ElMoribond @lardconcepts @k4rtik can you please try the current version from develop on the system on which you experienced this issue? It should be fixed thanks to the patch by bil-elmoussaoui.

That's great news, I have not seen the issue appear in last couple of weeks. However, is the following expected behavior?
$ pip-review -i
Everything up-to-date
$ pip list -o
setuptools (32.3.0) - Latest: 33.1.0 [wheel]
$ pip-review -i
Everything up-to-date

Well that is "expected", in the sense that it is a known but unrelated problem: #13.

@jgonggrijp as long as that is also expected on macOS, I am okay with it. 😄


Remove action args

:+1:

Explicit is better than implicit.
There should be one-- and preferably only one --obvious way to do it.

Thank you for reviewing the changes. One thing is still bothering me. This is the clean arg on the send() method. I feel like it is natural enough:
message.send(clean=True)

But if I remove this then it will require more commands to do simple thing:
message.render()
message.clean()
message.send()

Seems ugly :)
Maybe chaining may help
message.render().clean().send()

But this also seems crazy for me.

Idea 1: Use __ prefixes for internal variables, not sure if this fixes your use case though
Idea 2: In send, construct a new EmailMessage object and send this (this equivalent to always cleaning the object before sending but doesn't change the object's state)


feat: warn if deprecated/experimental declarations are used

Closes partially #543
Closes partially #540
Summary of Changes
Show a warning if deprecated or experimental declarations are used. To implement this, I've also added scoping for member accesses to results.

:tada: This PR is included in version 0.2.0 :tada:
The release is available on:

Visual Studio Marketplace
GitHub release

Your semantic-release bot :package::rocket:


Include ESM version of code in the package

Using ethereum-cryptography with a SvelteKit app, I ran into some issues due to current bugs in the treatment of CommonJS modules by either SvelteKit or Vite. While this is a bug in those tools, it would be avoided if the package included ESM modules. What do you think about including that? It looks like it would also play well with ESM modules in Node.js.

What about sub-dependencies? Do they also need to be esm?
What is the benefit of esm?
Can esm be dynamically imported? We have a few imports in noble-hashes

For reference: we also have a similar issue open here https://github.com/ethereumjs/ethereumjs-monorepo/issues/1468

See https://github.com/paulmillr/noble-ed25519/pull/17
There are no dynamic imports so this won't work for us

This should be delayed until node.js drops support for v14, which is 2023+.

Update: noble-hashes and noble-secp256k1 support ESM now. micro-base (third dep) doesn't. And we'll need to test js-e-c itself thoroughly for ESM builds.

All deps besides @scure/bip39 now support ESM. bip39 compiles to a code which can be reused between ESM and commonjs, so it should also be fine. esModuleInterop got also removed.
Now, we need to figure out what's the flow to compile everything into .esm and how to test it.

Actually I noticed that this package has no default entry point, which is technically not an issue. But by using it with the ESM syntax and following the readme.md examples, one might find this error message not super helpful:
node src/index.mjs
/Users/timdaub/Projects/replica/node_modules/ethereum-cryptography/index.js:2
throw new Error("This package has no entry-point. Please consult the README.md to learn how to
use it.");

The reason is that before ESM, people were used to e.g. importing actual .js files by specifying them without the file type in the import declaration. It's as it's being done in the readme, e.g.
const { sha256 } = require("ethereum-cryptography/sha256");

But with ESM, it's now mandatory to always include a file type extension in the import path too, so when we e.g. want to import ethereum-cryptography/sha256 using ESM, and we naively assume that we can do it without defining the filetype path, our script will error:
node src/index.mjs
internal/process/esm_loader.js:74
    internalBinding('errors').triggerUncaughtException(
                              ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/timdaub/Projects/replica/node_modules/
ethereum-cryptography/keccak' imported from /Users/timdaub/Projects/replica/src/index.mjs
Did you mean to import ethereum-cryptography/keccak.js?

The solution is to export in ESM always WITH the file type extension. So here's the equivalent that works in node 14
import { keccak256 } from "ethereum-cryptography/keccak.js";

If u want I can send a PR for the readme to that.

Thanks for the explanation, @TimDaub! I agree with you, the readme should include the extensions. Happy to receive a PR :)

Done! 2.1.2


Implement 1-4

Pitched battle against a powerful enemy, to close out Chapter 1! Featuring Lester, Shanti, and a powerful wolf. Will need sprites, animations, and data for all three of these.
Many different versions of the scenes depending on what the player did prior in the chapter.
Toughest battle yet, hopefully the player has some ignea left!

Renamed to reflect abelon-2 story


[feat] Local apply

Myks is useful even if used only for local chart rendering and validation without actually using a tool like ArgoCD for deployment. Therefore, we could add a mechanism that allows to apply to the local K8s context, e.g. myks apply envs/env1 app1
Such a mechanism would also be useful during development as an alternative to deploying from feature-branches.

Why is a dedicated command is better than using kubectl apply or kapp deploy?

resolved by #148


[Feature] Refactor RelativeDistanceStrategy

Is your feature request related to a problem? Please describe.
As pointed out in PR #55 comments, it is strange to have the distance metric as input to the .step function while all other Strategies define similar parameters as class attributes instead.
Describe the solution you'd like
For consistency, this should be aligned with the rest of the package.

Addressed in PR #59


calling an action raised an acorn error (?)

Describe the bug
I added an event, called this event from a list view (action on row > action = event), got no error, nor action got executed, but container logs:
/usr/local/lib/node_modules/@saltcorn/cli/node_modules/acorn/dist/acorn.js:3460

    var err = new SyntaxError(message);
              ^

SyntaxError: Unexpected token (1:6)

    at Parser.pp$4.raise (/usr/local/lib/node_modules/@saltcorn/cli/node_modules/acorn/dist/acorn.js:3460:15)

    at Parser.pp$9.unexpected (/usr/local/lib/node_modules/@saltcorn/cli/node_modules/acorn/dist/acorn.js:761:10)

    at Parser.pp$9.expect (/usr/local/lib/node_modules/@saltcorn/cli/node_modules/acorn/dist/acorn.js:755:28)

    at Parser.pp$5.parseObj (/usr/local/lib/node_modules/@saltcorn/cli/node_modules/acorn/dist/acorn.js:3081:14)

    at Parser.pp$5.parseExprAtom (/usr/local/lib/node_modules/@saltcorn/cli/node_modules/acorn/dist/acorn.js:2820:19)

    at Parser.pp$5.parseExprSubscripts (/usr/local/lib/node_modules/@saltcorn/cli/node_modules/acorn/dist/acorn.js:2636:21)

    at Parser.pp$5.parseMaybeUnary (/usr/local/lib/node_modules/@saltcorn/cli/node_modules/acorn/dist/acorn.js:2602:19)

    at Parser.pp$5.parseExprOps (/usr/local/lib/node_modules/@saltcorn/cli/node_modules/acorn/dist/acorn.js:2529:21)

    at Parser.pp$5.parseMaybeConditional (/usr/local/lib/node_modules/@saltcorn/cli/node_modules/acorn/dist/acorn.js:2512:21)

    at Parser.pp$5.parseMaybeAssign (/usr/local/lib/node_modules/@saltcorn/cli/node_modules/acorn/dist/acorn.js:2479:21)

    at Parser.pp$5.parseExpression (/usr/local/lib/node_modules/@saltcorn/cli/node_modules/acorn/dist/acorn.js:2442:21)

    at Function.parseExpressionAt (/usr/local/lib/node_modules/@saltcorn/cli/node_modules/acorn/dist/acorn.js:646:19)

    at parseExpressionAt (/usr/local/lib/node_modules/@saltcorn/cli/node_modules/acorn/dist/acorn.js:5575:19)

    at transform_for_async (/usr/local/lib/node_modules/@saltcorn/cli/node_modules/@saltcorn/data/models/expression.ts:340:37)

    at get_async_expression_function (/usr/local/lib/node_modules/@saltcorn/cli/node_modules/@saltcorn/data/models/expression.ts:415:27)

    at Object.run (/usr/local/lib/node_modules/@saltcorn/cli/node_modules/@saltcorn/data/base-plugin/actions.js:660:17) {

Any idea?

what is the action? Can you paste a screenshot of its configuration?

Maybe I misused it?

no formula, it was just as the screenshot.

But do you have any API call triggers? like this:

They will run when you emit this event.

Yes, that's it.
No channel.

Not sure what exactly you mean, sorry.
It was nothing more than in the screenshot and default event: API + JS (empty code).


[Bug] EX-hentai doesn't work electric boogaloo

Device information

Tachiyomi version: v8.8.2-AZ
Android version: 14
Device: OP7P

Steps to reproduce

Open TachiyomiAZ
Try to open EXH

Expected behavior
EXH to open
Actual behavior
"No results found"
Other details
Similar to #105 but that was for the chapters, this time it is the browser.
Have verified that I can access EXH on PC

have you tried logging out and back in? exh recently made a change that invalidated old cookies

Ah, that has fixed it. Maybe AZ should invalidate old cookies.


add support for activity_copy_limit to follow_many

add ?activity_copy_limit=### to request

yep

Here since #43 (v2.3.0)


cf delete app -r deletes shared routes

The -r option deletes routes even if other applications are using them.
Steps to reproduce
First issue:
cf push myapp ...
cf push myapp2 ...
cf map-route myapp cfapps.io --hostname myhost
cf map-route myapp2 cfapps.io --hostname myhost

At this point cf routes shows:
space              host                                   domain      path        apps
development   myapp                               cfapps.io                  myapp
development   myapp2                             cfapps.io                  myapp2
development   myhost                              cfapps.io                  myapp,myapp2

Now issue cf delete:
cf delete myapp2 -f -r

cf routes then shows:
space              host                                 domain      path        apps
development   myapp                             cfapps.io                  myapp

The route myhost.cfapps.io has been removed from myapp, which violates the principle of least surprise.

Hi @glyn,
I think this is something @shalako and @dkoper should look at. CLI just hits the endpoint; if a shared route should not be deleted we should be getting an error from the API.

@dieucao I believe the convention in CC is that recursively deleting an app deletes the relationship with other resources, but not those other resources. The service binding is deleted, but not the service instance. Similarly, I would expect the mapping to the route to be deleted, but not the route (even if the app being deleted is the only one mapped to the route). To delete both the app and the route (or the service instance), you'd have to recursively delete the parent object (the space).

@krishicks thanks for directing this bug to the correct parties. I raised it against the CLI because it was presumably a CLI design decision to support -r.

@glyn No worries; you did the right thing.

This behaviour also resulted in a bug in Spring Cloud Services. A "worker" application (part of the SCS service broker implementation) is upgraded by renaming the application, pushing the upgraded worker application, and then deleting the renamed application using cf delete ... -f -r. Unfortunately this destroys the route to the upgraded application.
A workaround is to omit the -r, but this example shows the ease with which this issue can cause problems.

Hi @glyn thanks for raising this issue. Since the issue you've described is CC-related, and not CLI-related, we are closing this issue. Feel free to reach out to the CAPI team if you believe the recursive behavior should change.

i'm not following how this is a CC issue.  the cli explicitly calls DELETE on the route resource.

@zrob The use case was deleting the app with recursive option. I would expect any relationships with other resources to be deleted (e.g. /v2/apps/:guid/routes/:guid), but would you expect the route to be deleted also? That seems surprising, considering that other apps may be using the route.

i believe the behavior you're describing is what already happens at the api level
for example, if you send DELETE /v2/apps/:guid?recursive=true, then the route WILL EXIST afterwards.
it is actually the cli that is explicitly finding routes for the app and calling DELETE /v2/routes/:guid

Makes sense.

@nebhale does closing mean there is a fix for the issue?

Sorry!  Wrong window!

Hi @glyn and all, thanks for commenting on this issue. On v7 beta cf CLI, we've changed the behavior when using cf delete app -r, the command no longer deletes routes if the route is bound to another app. Please see here for more information, and do not hesitate to get in touch if you have any questions. Thanks.

Hi @abbyachau,
Really delete the app dora?> y
App 'dora' was not deleted because route 'dodo.arsicault.cli.fun' is mapped to more than one app.
FAILED

Why should it fail if the route is mapped to a different app? What it warned "the route is not deleted as it is also mapped to: ..." but didn't stop from deleting an app?

@giner thanks for the feedback. In the case that the route was not deleted and the app was, it might be confusing to a user if the command exited with 0 and an ok. Failing the command and providing a TIP to tell users to Run 'cf delete app' to delete the app and 'cf delete-route' to delete the route might take an extra step but it adds more guard rails to this command. Please let me know if you have any additional thoughts. Thanks.

I don't see why it should fail. Also this breaks a common blue-green scenario:

domain.com is mapped to app1
User pushes app2 with domain.com
User stops app1
User deletes app1

One may say "don't use -r when deleting an app" but -r helps to keep the environment clean by deleting routes which only belong to the app we are deleting.

cf delete-route should be unnecessary:

Rename the original app (cf rename app app-venerable)
Push a new app using the same manifest (cf push)
Clean up if #2 is successful (cf delete app-venerable -r)

I'm wondering about the reasoning behind trying to delete routes shared by other apps, when would anybody want this?

@abbyachau, I'm not sure what you mean by deleting mappings as they only exist if the app exists. Having -r deleting only non-shared routes would just be a convenient way to keep the space clean through time.

From my understanding of this, cf delete abby -r should delete the app & the mapped routes. I would expect that the result would be to remove the route, as long as it isn't shared or being used by another app.

With the GA of the v7 CLI, we're no longer actively developing against the v6 line.  With an interest the overall hygiene of the CLI project we're closing this  issue.
If this issue is still occurring in v7 please feel free to comment and re-open. Thank you!

I tried to reproduce this with cf7 version 7.0.1+fb3f929c2.2020-06-24 and was pleased by the new behaviour:
cf7 delete myapp2 -f -r
Deleting app myapp2 in org glyn / space glyn as admin...
App 'myapp2' was not deleted because route 'myhost.apps.plum.springapps.io' is mapped to more than one app.
FAILED

TIP: Run 'cf delete myapp2' to delete the app and 'cf delete-route' to delete the route.

So problem solved!


Numpy docstrings

This PR adds numpy style docstrings to the code. This is a first step for building a usable documentation for the package. As a next step I intend to implement a propper docs page using sphinx.
Some of docstrings seem like extra boiler plate code but I added them anyway for automatic doc generating with sphinx.

fix  #60


UIEffectBase.OnValidate may be disabled when game running

NOTE: Your issue may already be reported! Please search on the issue tracker before creating one.
Is your feature request related to a problem? Please describe.
I pushed those UI-EFFECT materials into a shared asset bundle, and load all the ui assets via asset bundles (with Unity's dependence system).
Firstly I found the UI-Effect-Transition component doesn't work in mobile phone but it's OK when in Editor(also load assets via AB).
this puzzles me for a long time, and then I find this:
protected override void OnValidate()
{
	base.OnValidate ();

	var mat = GetMaterial();
	if (m_EffectMaterial != mat)
	{
		m_EffectMaterial = mat;
		UnityEditor.EditorUtility.SetDirty(this);
	}

	ModifyMaterial();
	SetVerticesDirty ();
	SetDirty ();
}

It seems when in editor mode, m_EffectMaterial will always be checked.
Otherwise, I stopped OnValidate() temporarily and  found that if I turn off the KeyWord "UIEFFECT_SEPARATE" in MaterialResolver,  a lot of sub material assets will be generated into one material asset (such as "UI-Effect-Transition"), which causes that the UI EFFECT component(such as UITransitionEffect) fails to find its material when deserialized from bundle.
(It seems a Unity bug about asset bundle system?)
(Sorry for no example project provided, it's rather complicated to make one)
the Unity version is 2018.4.21f1

Sorry for my late reply.
UIEffect v5 is now released.
Please try it. :+1:
🔄 Upgrading from v4 to v5


'error' never emitted even though 'status' is emitted with idleReason ERROR

Status event is emitted with idleReason equal to "ERROR" but no "error" event is emitted on the client for a detailed error report.
This could be an issue with chromecast, but I don't know.
Is there a way to get a detailed error report of what is happening when playback stops due to an error?

The cast2 protocol implementation seems to handle errors:
https://github.com/thibauts/node-castv2/blob/master/lib/channel.js
Although not fully, as the only one handled is unsupported protocol version.
But the "error" event cycle is broken in two places:
https://github.com/thibauts/node-castv2-client/blob/master/lib/controllers/controller.js - error is never passed on
https://github.com/thibauts/node-castv2/blob/master/lib/channel.js - error is never passed on

Technically there is no error happening in the modules, in your case. So no error is raised or triggered. If the Chromecast is able to bubble back an error status, most likely it's an app failure.
I need more information to assess your problem. Could you please tell me which app you use (post a link to the source if relevant) and send a dump of the culprit status event ? Detailed information about how / when the bug happens would be helpful too.

The issue is not in the modules, but as I said, I am expecting chromecast to send some sort of error event which we can catch.
I ran with DEBUG=castv2,castv2-client,chromecasts, which logs all events received in the socket - there was no information besides status changing and giving an "IdleReason" "ERROR", so I think we can close this and rule it an issue in Chromecast.
Off topic, I believe the reason for the errors in non-monotonous DTS stamps, as when I use ffmpeg to convert the HLS stream, I get only these warnings - it couldn't really be anything else.


Dendron commands stopped working

Describe the bug
Hi,
After updating VS Code to 1.48 all dendron commands just stopped working.
For example for lookup message says "Command 'Dendron: Lookup' resulted in an error (command 'dendron.lookup' not found)"
I have found out that when I start VS Code without any workspace, dendron commands are working. I can initialize new dendron workspace and in this new workspace commands are working. I can add new notes using lookup and so on. But after VS Code restart I all commands "cannot be found". Also I noticed that Markdown Preview is not working at all, even just after new workspace initialization.
To Reproduce
Steps to reproduce the behavior:

Try to use any command

Expected behavior
Dendron commands are working again
Screenshots

Desktop (please complete the following information):

VS Code 1.48
Dendron 0.7.4

I have created new workspace and in new one everything works fine. Any ideas what to do to fix my workspace?

Can you tell me the following information:

Dendron Markdown Preview Enhanced version?
Operating system?

Also, if you open up a new or existing workspace, use Dendron: Open Logs and send the output here: https://www.dropbox.com/request/6PuqQuZKAYli0tR95aVc

Dendron Markdown Preview Enhanced 0.5.17
Operating system: Windows 10 Pro Version 1909

I have sent you two logs: dendron1.log after commands worked and dendron2.log after VSC restart after commands stopped working

glad to hear it. we had an issue involving file paths with the previous version of "Dendron Markdown Preview Enhanced". it seems you were affected by it but moving forward, this will no longer be an issue! closing the issue but feel free to re-open if anything comes up again


Query: Convert IS operator in predicate to comparison with discriminator

Resolves #5007

:shipit:

Updated with feedback.
The translatingvisitor now works on whole query model so projection/predicate both are translated. (added test for both).
Also removed generation of Where 1 = 1 in query. If predicate is true then we don't generate where clause.

updated.

:shipit:


add RestElement

So I'm not sure I know what I'm doing - if it's right then I can do SpreadElement too.
I was going to add
    it('shouldn\'t allow multiple RestElements', () => {
        expect(() => parseAndGetStatementInFunctionParams('...a, ...b')).to.throw(SyntaxError);
    });

but I guess those are for babel to error on

Amazing work, @hzoo! Check out some notes I've left for you.

Updated

Great job, @hzoo! Merging!


Add HL required files to project repo

Hyperledger would like the following files to exist in all HL repos (see report here):

[ ] notice-file-exists: not found: (NOTICE*) The NOTICE file is described in section 4.4 of the Apache License version 2.0. Its presence is not mandated by the license itself, but by ASF policy.
[X] license-file-exists: found (LICENSE)
[X] readme-file-exists: found (README.md)
[X] contributing-file-exists: found (CONTRIBUTING.md)
[x] code-of-conduct-file-exists: not found: (CODEOFCONDUCT*, CODE-OF-CONDUCT*, CODE_OF_CONDUCT*, .github/CODEOFCONDUCT*, .github/CODE-OF-CONDUCT*, .github/CODE_OF_CONDUCT*)
[ ] changelog-file-exists: not found: (CHANGELOG*)
[X] security-file-exists: found (SECURITY.md)
[ ] support-file-exists: not found: ({docs/,.github/,}SUPPORT*)
[ ] readme-references-license: File README.md doesn't contain license
[X] binaries-not-present: Excluded file type doesn't exist (/*.exe,/*.dll,!node_modules/**)
[ ] test-directory-exists: not found: (**/test*, **/specs)
[X] integrates-with-ci: found (.circleci/config.yml)
[ ] github-issue-template-exists: not found: (ISSUE_TEMPLATE*, .github/ISSUE_TEMPLATE*)
[ ] github-pull-request-template-exists: not found: (PULL_REQUEST_TEMPLATE*, .github/PULL_REQUEST_TEMPLATE*)
[X] license-detectable-by-licensee: Licensee identified the license for project: Apache-2.0

Also see https://github.com/hyperledger/quilt/issues/435


Void tag followed by any non-whitespace character duplicates closing >

Input

a

Expected Output

a

Actual Output

>a

Same effect seen with <input> and other void tags that don't cause Prettier to insert a newline immediately after them (like
 does).
Does not occur when plugin is disabled.
package.json:
{
  "devDependencies": {
    "@awmottaz/prettier-plugin-void-html": "^1.2.0",
    "prettier": "3.1.1"
  },
  "prettier": {
    "plugins": [
      "@awmottaz/prettier-plugin-void-html"
    ]
  }
}

Confirmed, looking into this. Thanks for reporting the bug!

I did a bit of digging... this is going to be quite difficult to fix I'm afraid.
The way my plugin works is by setting the isSelfClosing property to false in the pre-processed AST for all nodes (except MathML and SVG, as per the spec). This is how I get
 to print as

, but it also means that void tags such as
 will now be printed as

.
The (incorrect) assumption I made was that the resulting Doc put the entire closing tag portion that we now don't want (
) as the last item in the contents array for that node.
https://github.com/awmottaz/prettier-plugin-void-html/blob/c3a95e4bc7c0b411827dec693876d7e026a76dfc/prettier-plugin-void-html.js#L62-L64
As it turns out, this is not always true! Prettier has a feature where closing tags might put their final > on a newline adjacent to the content following the tag. They achieve this by excluding it from the print output of the br node, with the next node "borrowing" it. You can look at this function and some of its callsites if you're curious.
I'll need to think about this some more to see if there is a workaround that isn't "implement an entire HTML printer from scratch" 😅

For the purpose of documenting my progress here — I spent a couple of hours seeing if I could inspect and mutate the Doc during the print function. It got very complex and fragile (it makes many more assumptions about how the Doc is structured). Best I could get was this:
ℹ tests 72
ℹ suites 0
ℹ pass 42
ℹ fail 18
ℹ cancelled 0
ℹ skipped 12

The failed tests are caused by the extra space character that Prettier would put in front of the /> self-closing syntax:

   ↑

I haven't found a way to reliably remove that space. It's very dependent on how each element is printed and the contents of the element's attribute set. So I was able to format these correctly:
a,

, but a space remains in <input name="test" > instead of <input name="test">, for example.
The skipped tests are for the MathML and SVG markup. These do allow self-closing syntax. I have not found a way yet to avoid removing the self-closing syntax in those cases, since the context of that node type is missing from the Doc itself and Docs get printed recursively.

The working branch for this progress is here, in case anyone else wants to build on what I've done so far: https://github.com/awmottaz/prettier-plugin-void-html/tree/fix-double-closing-bracket

This is my attempt at a solution. A fair bit more naive but maybe with enough knowledge of the potential shapes of printed it could work.

@f11xter thanks for looking at this!
Did you try testing your solution against trailing content other than a single character? A couple examples that I found tricky:

a

No, but looking at my approach, I think it might make no sense anyway.
I remove the borrowed ">", but that breaks the isLeadingSpaceSensitive handling, so perhaps it'd be better to look ahead to path.node.next.isLeadingSpaceSensitive and, if true, find and remove the closing ">" of the opening tag from the current void tag.
A rushed implementation results in:

a

a

a

which is not quite right but close-ish.

Almost working implementation: https://github.com/f11xter/prettier-plugin-void-html/commit/8d4629b4a0bd0aa8b29af523a069028e85e0e94d

<inline-element> seems to be triggering a special case, leading to an extra newline that I haven't found an answer for.
I imagine this solution is similarly short-sighted but it's probably worth a look @awmottaz :)

So I've been trying to walk through the code with
 as an example and I think the control flow is as follows:

printer-html evaluates root node and calls printChildren
printChildren calls printBetweenLine on the br
printBetweenLine calls preferHardlineAsLeadingSpaces on the span
preferHardlineAsLeadingSpaces calls preferHardlineAsTrailingSpaces on the br
preferHardlineAsTrailingSpaces returns true: return ... node.fullName === "br" ...
printBetweenLine receives true and returns hardline (L130)
printChildren receives hardline and pushes it to trailingParts (L217)
printChildren returns:

return [
  ...prevParts,
  group([
    ...leadingParts,
    group([printChild(childPath, options, print), ...trailingParts], {
      id: groupIds[childIndex],
    }),
  ]),
  ...nextParts,
];

which prints a much more complicated version of
[
  [
    ['<','br']
  ],
  [
    [{type: 'line', hard: true}, {type: 'break-parent'}],
    ['>','','']
  ]
]

All this to say that the hardline is set outside of the code we've written. So, unless we can tweak the br's fields to prevent this, I don't know how easy a fix will be.
A question worth answering is how the flow differs without the plugin. I think there are some places where a branch evaluates node.isSelfClosing which may lead to the answer.
(Side note: I abhor the codebase's use of ternaries. Utterly unreadable.)


 We should have the same for JSONSerialization. For example:
try JSONSerialization.jsonObject(with: Data(buffer: byteBuffer), ...)

is tedious, we could directly have
try JSONSerialization.jsonObject(buffer: byteBuffer, ...)

Wanted to get your thoughts on the following:

extension ByteBuffer {

    /// Attempts to derive a Foundation object from a ByteBuffer and return it  as `T`.
    ///
    /// - parameters:
    ///    - type: The Founation type that is attempting to be derived from the ByteBuffer.
    /// - returns: The Foundation value if successful or `nil` if there was an issue creating the Foundation type.
    @inlinable
    public func object<T>(_ type: T.Type) throws -> T? {
        guard let bytes = self.getData(at: 0, length: self.readableBytes),
              let t = try JSONSerialization.jsonObject(with: bytes, options: .mutableContainers) as? T else {
            return nil
        }
        return t
    }

    /// Attempts to derive a Foundation object from a ByteBuffer that is transformed into a InputStream and returned  as `T`.
    ///
    /// - parameters:
    ///    - type: The Founation type that is attempting to be derived from the ByteBuffer.
    /// - returns: The Foundation value if successful or `nil` if there was an issue creating the Foundation type.
    @inlinable
    public func objectFromStream<T>(_ type: T.Type) throws -> T? {
        guard let bytes = self.getData(at: 0, length: self.readableBytes) else {
            return nil
        }
        let stream = InputStream(data: bytes)
        stream.open()
        guard let t = try JSONSerialization.jsonObject(with: stream, options: .mutableContainers) as? T else {
            return nil
        }
        stream.close()
        return t
    }
}

With the usage looking something like the following:

let array = ["String1", "String2", "String3"]
let dictionary = ["key1": "val1", "key2": "val2", "key3": "val3"]

var dataArray = try JSONSerialization.data(withJSONObject: self.array, options: .prettyPrinted)
var dataDictionary = try JSONSerialization.data(withJSONObject: self.dictionary, options: .prettyPrinted)

let arrayDispatchData = dataArray.withUnsafeBytes { DispatchData(bytes: $0) }
let dictDispatchData = dataDictionary.withUnsafeBytes { DispatchData(bytes: $0) }

let arrayByteBuffer = ByteBuffer(dispatchData: arrayDispatchData)
let dictByteBuffer = ByteBuffer(dispatchData: dictDispatchData)

var foundationArray: [String] = []
var foundationDict: [String: String] = [:]
XCTAssertNoThrow(foundationArray = try arrayByteBuffer.object(Array<String>.self)!)
XCTAssertEqual(foundationArray, self.array)

XCTAssertNoThrow(foundationDict = try dictByteBuffer.object(Dictionary<String, String>.self)!)
XCTAssertEqual(foundationDict, self.dictionary)

Is this what you had in mind or were you looking for something different?
If this is what you had in mind, did you also see a need to include the InputStream API as well?

@agnosticdev Thanks, pretty close! I'd do extension JSONSerialization and add a jsonObject method that is the same signature as JSONSerialization.jsonObject(with:Data, ...) except that it has buffer: ByteBuffer.
This is incorrect btw: let bytes = self.getData(at: 0, length: self.readableBytes) and should be Data(buffer: self).
And we don't need the objectFromStream method because we already have the bytes, so we don't need to make it into a stream, then coalesce everything and go through the other code path essentially.

Going the extension route for JSONSerialization:
extension JSONSerialization {

    /// Attempts to derive a Foundation object from a ByteBuffer and return it  as `T`.
    ///
    /// - parameters:
    ///    - type: The Founation type that is attempting to be derived from the ByteBuffer.
    ///    - buffer: The ByteBuffer being used to derive the Foundation type.
    /// - returns: The Foundation value if successful or `nil` if there was an issue creating the Foundation type.
    @inlinable
    public func jsonObject<T>(_ type: T.Type, buffer: ByteBuffer) throws -> T? {
        guard let t = try JSONSerialization.jsonObject(with: Data(buffer: buffer), options: .mutableContainers) as? T else {
            return nil
        }
        return t
    }
}

Ends up running into two different errors when attempting to use/test the new API.  First when using a static version of JSONSerialization, I see:
Instance member 'jsonObject' cannot be used on type 'JSONSerialization'; did you mean to use a value of this type instead?
XCTAssertNoThrow(foundationArray = try JSONSerialization.jsonObject(Array<String>.self, buffer: arrayByteBuffer)!)

Okay, makes sense, but then when I created an instance of JSONSerialization it also resulted in an error:
let serializer = JSONSerialization()
...
JSONSerialization+ByteBufferTest.swift:29: error: -[NIOFoundationCompatTests.JSONSerializationByteBufferTest testSerializationRoundTripTest] : *** +[NSJSONSerialization allocWithZone:]: Do not create instances of NSJSONSerialization in this release (NSInvalidArgumentException)

Let me know your thoughts.

Instance member 'jsonObject' cannot be used on type 'JSONSerialization'; did you mean to use a value of this type instead?

You need to make jsonObject a public static func not a public func, then it should work.

Thanks @weissi!  That did work.

Looks like this one can be closed now that #1906 is merged?

Agreed.


writefreely: init at 0.10.0

Motivation for this change
My attempt with https://github.com/NixOS/nixpkgs/issues/63335
Does not work yet though. If someone has experience with go packaging, please give it a try!
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

[...]
github.com/writeas/writefreely/migrations
github.com/writeas/writefreely/page
github.com/writeas/writefreely/parse
github.com/writefreely/go-nodeinfo
github.com/writeas/writefreely
# github.com/writeas/writefreely
./app.go:719:17: undefined: Asset
builder for '/nix/store/cxxmd0ihdp3p14yc4mhm1l5vjkc4f51j-writefreely-0.10.0.drv' failed with exit code 1
error: build of '/nix/store/cxxmd0ihdp3p14yc4mhm1l5vjkc4f51j-writefreely-0.10.0.drv' failed

The error comes from not running https://github.com/writeas/writefreely/blob/develop/Makefile#L113
We'll probably need a separate drv for the go-bindata executable.

The error comes from not running https://github.com/writeas/writefreely/blob/develop/Makefile#L113
We'll probably need a separate drv for the go-bindata executable.

This should be done in the preBuild hook. However, it's not possible to pass that to the modules yet and it needs some work. I don't have any resources this weekend/week so it'll have to wait till next weekend unless someone wants to take a stab at it first.

Hi @kalbasit @matthiasbeyer, I'd like to take a stab at this but am not sure how to create a separate drv for the go-bindata executable in the preBuild hook, any pointers would be appreciated.


Handle triple backticks for pandoc and rmarkdown

Properly pair up triple backticks ``` when filetype is rmarkdown or pandoc, similar to #41.
These filetypes are defined via the https://github.com/vim-pandoc/vim-rmarkdown and https://github.com/vim-pandoc/vim-pandoc packages.
Also see #13, #14, and #30

Thank. your description is very clear


Update MetricObject

Small updates to MetricObject and related functions

[x] Tests for new functionality/models or Tests to reproduce the bug-fix in code.
[x] Updated documentation of features that add new functionality.
[x] Update CHANGELOG.md with major/minor changes.

Codecov Report
Patch coverage: 69.56% and project coverage change: -0.02 :warning:

Comparison is base (d0d8937) 73.29% compared to head (ccb97b6) 73.28%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1239      +/-   ##
==========================================
- Coverage   73.29%   73.28%   -0.02%
==========================================
  Files          75       75
  Lines       12535    12530       -5
==========================================
- Hits         9188     9182       -6
- Misses       3347     3348       +1

Impacted Files
Coverage Δ

HARK/core.py
91.18% <69.56%> (-0.31%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@llorracc this is just a reorganization of MetricObject and related functions, there is no new functionality just thought I would clean up some code.
A TimeVaryingDiscreteDistribution is kind of a list of DiscreteDistributions such that you can call them by index [i].

So, in our Brave New World in which each period has its own environment, we will not need the TimeVaryingDiscreteDistribution?  (Remember that my vision is that you construct your periods backwards by giving each one exactly what it needs).
Anyway, it seems that this is ready to merge.  Shall I merge it?

what about breaking the metric object distance functions out into something like metric.py

Maybe overkill implementations for our purposes, but we might want to think about:

https://github.com/metric-space-ai/metric
https://donsheehy.github.io/metricspaces/

... as ways to do more with 'metric objects'?

@sbenthall have moved MetricObject to metric.py


Can't install<EMAIL_ADDRESS>windows x64

RE: https://github.com/Urigo/angular2-meteor/issues/383 - Noticed<EMAIL_ADDRESS>has been released. Tried to update the package on Windows with no success.
=> Errors while adding packages:

While checking for<EMAIL_ADDRESS>error: No compatible binary build found for this package. Contact the package author and ask them to publish it
for your platform.

I have also tried
meteor remove angular2-compilers
meteor rebuild
meteor add angular2-compilers

but that did not resolve the problem.
Any ideas?

You can try with:

meteor add<EMAIL_ADDRESS>I did the same for version 0.6.0.
I hope I can help you

Which version of Meteor are you using? Meteor 1.4.1 shouldn't require compatible build any more (https://github.com/meteor/meteor/blob/devel/History.md#v141)

@barbatus
$ meteor --version
Meteor <IP_ADDRESS>

I have cloned the same repo to my Mac, tried to update<EMAIL_ADDRESS>and it works fine.
However, it still does not work on my Windows PC. :disappointed:

I am having the same issue on Windows running Meteor <IP_ADDRESS>.
meteor --version
Meteor <IP_ADDRESS>
meteor add angular2-compilers
=> Errors while adding packages:
While checking for<EMAIL_ADDRESS>error: No compatible binary build found for this package. Contact the
package author and ask them to publish it for your platform.

@derek-fong what if you follow this https://guide.meteor.com/v1.4/1.4-migration.html#binary-packages-require-build-toolchain and install MS Build Tools. Let see then if it's gonna help.

I'm having the same issue on Windows 10 x64,  If a create a new meteor project it works ok using meteor <IP_ADDRESS> (not using angular2-meteor), but doesn't work when I clone the angular2-meteor-base. I also tried with meteor add<EMAIL_ADDRESS>but same result.

Hi @barbatus.
I followed  https://guide.meteor.com/v1.4/1.4-migration.html#binary-packages-require-build-toolchain and I installed MS Build tools.
In the guide, they show how to check if everything is working or not. And it was not... After some time I found I nice way to install everything with one command:

npm install --global --production windows-build-tools

Like this meteor npm install bcrypt work well. So I guess that my Build Toolchain is now working.
But I still get

meteor add<EMAIL_ADDRESS>=> Errors while adding packages:
While checking for<EMAIL_ADDRESS>error: No compatible binary build found for this package. Contact the
package author and ask them to publish it for your platform.

I'm getting the problem on Mac after adding the xcode build tools (xcode-select --install)
xcode-select -p
/Applications/Xcode.app/Contents/Developer

gcc --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.3.0 (clang-703.0.31)
Target: x86_64-apple-darwin15.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

meteor update angular2-compilers
=> Errors while upgrading packages:

While checking for<EMAIL_ADDRESS>error: No compatible binary build found for this package. Contact the package author and ask them to publish it for your platform.

We published new version, it should fix the problem, please try.

Hi @barbatus,
I confirm that on Windows x64 it's working well now.

C:\MyTextProject>meteor add angular2-compilers
Changes to your project's package version selections:
angular2-compilers            added, version 0.6.2_1
barbatus:css-compiler         added, version 0.3.1_1
barbatus:scss-compiler        added, version 3.8.1_3
barbatus:typescript           added, version 0.4.1
barbatus:typescript-compiler  added, version 0.7.1_1
barbatus:typescript-runtime   added, version 0.1.2
urigo:static-html-compiler    added, version 0.1.8
angular2-compilers: Angular 2 Templates, HTML and TypeScript compilers for
Meteor

Thank you very much :)

Fixed on mac too

@barbatus Sorry for the late reply I have been away - Tested on Windows and confirmed it's working.
Cheers :+1:


feat(core): Support application/x-www-form-urlencoded content type

This pull request aims to support application/x-www-form-urlencoded content-type. Currently it's unsupported and attempting to use the correct headers causes issues. Closes #453

LGTM, But this needs a changeset. npx changeset

@michaelangeloio Added the changeset - Let me know if there's any issues 😄

LGTM! Thank you


Trial balance

[x] Customization 'filter by' default value 'accounts without zero balances'.

[x] Other filter by options are not working.

[x] Wrong total

[x] Default date missing in trial balance

[x] Show closing control account in liabilities

[x] Show balance of credit ledgers in credit side

[x] Spelling mistake in 'show and hide columns'

[x] No data displayed in Drilled down view of 'closing control account'.

[x] Show Previous year balance under equity section (no need drilled down view for this)

[x] Incomes and Expenses ledgers are not displayed

Issue Closed


Feature/dependabot/simulate update

Description
Auto-update based on https://github.com/dockstore/dockstore-ui2/pull/1517
Review Instructions
A little tiime dependent, will probably need to wait for a dependabot PR that affects non-generated Maven files and see if it is updated with a proper license file and generated pom files
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-4589
Security
n/a
Please make sure that you've checked the following before submitting your pull request. Thanks!

[ ] Check that you pass the basic style checks and unit tests by running mvn clean install
[ ] Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
[ ] Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
[ ] If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
[ ] Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
[ ] Do not serve user-uploaded binary images through the Dockstore API
[ ] Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
[ ] Do not create cookies, although this may change in the future
[ ] If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

wrong branch name


New HEALTHCHECK in Dockerfile is failing

Step 16/17 : HEALTHCHECK --interval=1m --start-period=5m CMD "$ORACLE_BASE/$CHECK_DB_FILE" >/dev/null || exit 1
Unknown flag: start-period
There was an error building the image.

DOCKER info:
Containers: 0
Running: 0
Paused: 0
Stopped: 0
Images: 20
Server Version: 17.03.2-ce
Storage Driver: overlay
Backing Filesystem: extfs
Supports d_type: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
Volume: local
Network: bridge host macvlan null overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 4ab9917febca54791c5f071a9d1f404867857fcc
runc version: 54296cf40ad8143b62dbcaa1d90e520a2136ddfe
init version: 949e6fa
Security Options:
seccomp
Profile: default
Kernel Version: 4.9.51-10.52.amzn1.x86_64
Operating System: Amazon Linux AMI 2017.09
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 15.67 GiB
Name: ip-10-225-77-140
ID: JY6C:Y5EF:I64C:4WXC:D63C:M5QQ:YSPY:377H:55IM:PIBA:3M5S:6RT4
Docker Root Dir: /docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Experimental: false
Insecure Registries:
<IP_ADDRESS>/8
Live Restore Enabled: false

Root cause: Server Version: 17.03.2-ce
--start-period was introduced in 17.05.1. Earlier versions of Docker will all fail on this flag.

Hey @DrStrangepork, that is correct. By now quite a few features are used that aren’t supported by earlier versions of Docker. Any reason why not to upgrade to 17.06-ce?

Corporate decision to standardize on Amazon Linux with no custom installations, so we're stuck with 17.03.2, because that's what's in the amzn repo.

I see, in that case you can modify the HEALTHCHECK instruction and get rid of the --start-period option.

# Workaround for Docker < 17.05.1
sed -i 's/^HEALTHCHECK/#HEALTHCHECK/' <IP_ADDRESS>/Dockerfile.se2
sed -i 's/^   CMD/#   CMD/' <IP_ADDRESS>/Dockerfile.se2


Cache ground truth parses to S3.

On successful builds on master, push parses to S3 as current ground truth
On pull requests and non-master branches, pull cached parses for comparison

Note: I'm using one of my personal buckets here. If this gets merged, we'll want to provision a new 18F bucket.
cc @cmc333333

Looks like the FEC build gets stuck sometimes, and hangs until travis kills the build: https://travis-ci.org/18F/regulations-parser/jobs/110875515#L4032-L4037. All we're doing is calling eregs pipeline on the relevant sections, so I'm not sure what's going on. Suggestions @cmc333333 @anthonygarvan?

Hm. Something very strange is happening -- Writing tree 2015-annual-2 appears 21 times in that output. @anthonygarvan is everything still building for you?

It's also possible that I'm making some mistake in integration_test.build, although I'm pretty sure I have the right title and parts, and all build does is call pipeline in a loop.

Sure enough, I had the retry logic for fetching dependencies a level too high, such that any missing dependency would restart all CFR parts. Not exactly sure why that would cause the build the hang for 10+ minutes, but it was definitely the wrong place for that logic, and the build actually passes now. And it's a lot faster than master:

@jmcarp great stuff. Would you mind putting in a docstring for integration_test.py in case someone stumbles upon it accidentally?

Done. Should I set up a real S3 bucket?

We need to delay getting an 18f bucket due to not having a funding code, but this is good to merge. Great stuff


[BUG] vite plugin issue with react/tsx files in astro/Docs need to mention tsx files

Please provide the environment you discovered this bug in.
When you setup an Astro project with MDX + React + Angular if your React components use typescript (.tsx) then pages that import them will fail to build. If the Angular plugin + components are removed everything works fine. If instead the React components are converted to .jsx  then everything will also work fine.
Also, awesome job with Analog, seems like a promising new development for the Angular community!
Which area/package is the issue in?
vite-plugin-angular
Description
This error is similar to #100 but seems to be a slightly different issue given we're using the latest version of the Vite Angular plugin here that should be ignoring .tsx files.
I have put together a recreation of the issue in stackblitz here: https://stackblitz.com/edit/withastro-astro-yrrypx?file=src%2Fpages%2Findex.mdx
Package versions installed:

@analogjs/astro-angular: 0.1.0-beta.3
@analogjs/vite-plugin-angular: 0.2.0-alpha.15
astro: 1.6.2

Something also seems to be off where the language server for the Angular component is ignoring tsconfig.app.json and only reports a valid file if you add certain typescript configurations to the base tsconfig.json. Not sure if this is related though.
Please provide the exception or error you saw
[ERROR] [plugin angular-compiler] File is missing from the TypeScript compilation.

    src/pages/react-test.tsx:0:0:
      0 │
        ╵ ^

  Ensure the file is part of the TypeScript program via the 'files' or 'include' property.

Build failed with 1 error:
src/pages/react-test.tsx:0:0: ERROR: [plugin: angular-compiler] File is missing from the TypeScript compilation.
Sourcemap for<EMAIL_ADDRESS>points to missing source files
Angular is running in development mode. Call enableProdMode() to enable production mode.
 error   Unable to render / because it contains an undefined Component!
  Did you forget to import the component or is it possible there is a typo?
  File:
    /node_modules/astro/dist/runtime/server/jsx.js:34:15
  Stacktrace:
Error: Unable to render / because it contains an undefined Component!
Did you forget to import the component or is it possible there is a typo?
    at renderJSX (/node_modules/astro/dist/runtime/server/jsx.js:34:15)
    at eval (/node_modules/astro/dist/runtime/server/jsx.js:28:45)
    at Array.map (<anonymous>)
    at renderJSX (/node_modules/astro/dist/runtime/server/jsx.js:28:34)
    at renderJSX (/node_modules/astro/dist/runtime/server/jsx.js:38:16)
    at renderJSX (/node_modules/astro/dist/runtime/server/jsx.js:78:22)
    at async renderChild (/node_modules/astro/dist/runtime/server/render/any.js:10:11)
    at async Module.renderChild (/node_modules/astro/dist/runtime/server/render/any.js:23:5)
    at async Module.renderSlot (/node_modules/astro/dist/runtime/server/render/slot.js:19:22)

Other information

I would be willing to submit a PR to fix this issue

[X] Yes
[ ] No

The fix here is to add "src/**/*.tsx" to the include in the tsconfig.app.json. Should probably add that to the example tsconfig.app.json in the docs. Would you like to submit a PR?

Thanks for looking into this. That definitely fixes the issue in the stackblitz example I shared.
I did have this issue locally though despite already having added this configuration due to its mention in another issue thread. I believe the cause for the issue there turned out to be something with PNPMs default hoisting method, at least how our project was configured. Since adjusting that I've come back to this and am not seeing this issue again. It was either that or Vite was somehow caching enough to cause this error even after the config change previously.
Either way, I'd be happy to update the docs. I'll try to get a PR for that submitted in the next couple of days.

Ok cool. Yes a PR would be great, thanks


npm warnings about sass-loader

Describe the bug
npm throws warnings about sass-loader missing peer dependencies
Environment
node --version && npm --version
v12.1.0
6.13.4

Steps to reproduce
Run npm install react-scripts
Expected behavior
npm should not throw errors or warnings.
Actual behavior
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of fibers@>= 3.1.0 but none is installed. You must install peer dependencies yourself.

According to the docs, node-sass should be installed separately. Since that is the case, then sass-loader should be an optional dependency or only installed if it finds node-sass.

sass-loader is included to CRA, because it allows users to use Sass seamlessly, without ejecting. It is used in webpack's configuration at module.loaders directive, and only executes upon facing imported sass/scss files.
NPM warnings are totally normal, despite the fact that one could think of them as something bad. NPM tries to warn users about potential pitfalls.
node-sass is not installed by default, because it would add complexity and compile redundant binaries for people who doesn't use sass/scss.

According to the docs, node-sass should be installed separately. Since that is the case, then sass-loader should be an optional dependency or only installed if it finds node-sass.

What you ask, is to dynamically check if node-sass exists, then install sass-loader. Looks like magic to me.
Here is my log of creating an app, I see no such warnings.
➜  /tmp npx create-react-app test13
npx: installed 91 in 5.407s

Creating a new React app in /private/tmp/test13.

Installing packages. This might take a couple of minutes.
Installing react, react-dom, and react-scripts with cra-template...

yarn add v1.21.1
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning "react-scripts > @typescript-eslint/eslint-plugin ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".
[4/4] 🔨  Building fresh packages...
success Saved lockfile.
success Saved 35 new dependencies.
info Direct dependencies
├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>└─<EMAIL_ADDRESS>info All dependencies
├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>└─<EMAIL_ADDRESS>✨  Done in 12.20s.

Installing template dependencies using yarnpkg...
yarn add v1.21.1
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning "react-scripts > @typescript-eslint/eslint-plugin ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".
warning " ><EMAIL_ADDRESS>has unmet peer dependency "@testing-library/dom@>=5".
[4/4] 🔨  Building fresh packages...
success Saved lockfile.
success Saved 18 new dependencies.
info Direct dependencies
├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>└─<EMAIL_ADDRESS>info All dependencies
├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>└─<EMAIL_ADDRESS>✨  Done in 5.00s.
Removing template package using yarnpkg...

yarn remove v1.21.1
[1/2] 🗑  Removing module cra-template...
[2/2] 🔨  Regenerating lockfile and installing missing dependencies...
warning " ><EMAIL_ADDRESS>has unmet peer dependency "@testing-library/dom@>=5".
warning "react-scripts > @typescript-eslint/eslint-plugin ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".
success Uninstalled packages.
✨  Done in 4.51s.

Initialized a git repository.

Success! Created test13 at /private/tmp/test13
Inside that directory, you can run several commands:

  yarn start
    Starts the development server.

  yarn build
    Bundles the app into static files for production.

  yarn test
    Starts the test runner.

  yarn eject
    Removes this tool and copies build dependencies, configuration files
    and scripts into the app directory. If you do this, you can’t go back!

We suggest that you begin by typing:

  cd test13
  yarn start

Happy hacking!

I don't use yarn (and no I don't plan on using it either) but npm does issue warnings.
If node-sass has to be installed separately, might as well install sass-loader then too. The webpack config  can check if they are installed and then require them if they are. That way no magic. Using sass requires extra work so typing an extra 12 characters doesn't seem that unreasonable.


Add url method

Convert a path to a URL with 'file' scheme
POSIX:
>>> path('/foo/bar/dog.txt').url()
'file:///foo/bar/dog.txt'

Windows:
>>> path('C:\Python27\README.txt').url()
'file:///C:/Python27/README.txt'

Does it handle relative paths?

I see that the tests do cover relative paths. However, in my experience, the relative paths should have only two leading slashes.

I'll have to dig around to find where I encountered this finding.

I found this.
https://github.com/pypa/pip/issues/328
I'll have to check later to see how compliant the code is with the RFC mentioned above.

Thanks for that reference. It's actually more helpful than the code I was trying to reference.
Based on my reading, path.py should invoke os.path.isabs on the path. If it's absolute, use the implementation indicated. If it's not absolute, only prefix 'file:'. In all cases, substitute os.pathsep for posixpath.pathsep.

I don't think this PR can be merged as-is. It's necessary that a relative path and absolute path be distinguishable. If stdlib modules can't do that properly, path.py should provide the proper implementation.

I still would accept a patch for this functionality. Perhaps I was being too harsh in the critique. Perhaps it makes sense to accept the functionality and refine it, rather than get it perfect the first time.

@msabramo If you would be willing to rebase your changes onto the latest master, I'll accept it as-is.


Config for CircleCI 2.0

cg-style was using the old 1.0 config format which has been sunset. This just brings it up to the 2.0 config version.


Tracking: Firefox support for WebTransport transport

A WebTransport multiaddr is used to dial a peer that's listening on a WebTransport address.  It takes the form:
/{ip4 or 6 address}/udp/4001/quic-v1/webtransport/certhash/{certhash1}/certhash/{certhash2}/p2p/{peerId}

We acquire the WebTransport multiaddr either out of band or via a message cryptographically signed by the public key that the remote peer ID is derived from.
To connect to the peer we extract the two certhashes from the multiaddr and pass them to the WebTransport constructor as serverCertificateHashes.
Once the connection is established using these hashes, we perform a noise handshake using the remote peer ID to ensure we are talking to the peer we expect to be talking to.
For further information please see the libp2p WebTransport transport spec.
The serverCertificateHashes option is supported in Chromium but it has not yet been implemented in Firefox which at the time of writing throws an error with the message "No support for serverCertificateHashes yet"
We cannot support Firefox until this option is implemented since we rely on this init option as part of our connection protocol.
References:

libp2p WebTransport overview: https://docs.libp2p.io/concepts/transports/webtransport/
libp2p WebTransport transport spec: https://github.com/libp2p/specs/blob/master/webtransport/README.md
W3C WebTransport spec: https://www.w3.org/TR/webtransport/
Firefox serverCertificateHashes tracking issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1806693
Firefox serverCertificateHashes bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1873263

All required patches have landed in Firefox Nightly so please test it out!

This has shipped in stable so WebTransport is now viable in Firefox!

@achingbrain Can this one be closed?

Shipped!! Get involved!!


Added ImageBitmap interface

Fixes ImageBitmap interface missing #14402
Adds interfaces ImageBitmap, ImageBitmapOptions and the associated typedefs to Window and Worker scope. See WHATWG HTML Living Standard
Wasn't sure about the "flavor" tag. Worker seems to be the one I need here. but is there a description of All, Web, DOM and maybe others?

@nkemnitz,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Thanks for the explanation!
I removed the typedefs for both, ImageBitmap and ImageBitmapOptions, as well as the unavailable HTMLElements in the Web Worker createImageBitmap call.
The failing Travis CI build seems not related to the code changes.

@nkemnitz,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Closed/Reopened PR to trigger the travis-ci build (Failed yesterday due to "Service temporarily unavailable" error)


submit queue UI looks terrible on wide screens

Perhaps make it wider? Or at least center it?

For me, the UI is completely unreadable because there's 0 height. (Note the empty scrollbox.)


Replace mimemagic with marcel

seems to me like we may not want to keep the old dependency around as rails moves away.
This also helps anyone who can't use a GPL license in their code.

Great!


reference -https://github.com/signalfx/splunk-otel-collector/issues/2426

reference -https://github.com/signalfx/splunk-otel-collector/issues/2426

using >promethues-fedration code
getting error-
otelcollector  | 2023-01-25T19:08:33.763Z       info    exporterhelper/queued_retry.go:427      Exporting failed. Will retry the request after interval.        {"kind": "exporter", "data_type": "metrics", "name": "splunk_hec/metrics", "error": "Post "https://splunk:8088/services/collector\": dial tcp <IP_ADDRESS>:8088: connect: connection refused", "interval": "5.021810571s"}
otelcollector  | 2023-01-25T19:08:33.796Z       info    exporterhelper/queued_retry.go:427      Exporting failed. Will retry the request after interval.        {"kind": "exporter", "data_type": "metrics", "name": "splunk_hec/metrics", "error": "Post "https://splunk:8088/services/collector\": dial tcp <IP_ADDRESS>:8088: connect: connection refused", "interval": "14.480459587s"}
splunk         |

Reopening #2426.


HHH-14918 Key-to-one to id-class entity with key-to-one doesn't work anymore

https://hibernate.atlassian.net/browse/HHH-14918
The most obvious solution seems to fix the problem; let's see if it doesn't break another test...

The failure seems caused by a flaky test. Ignoring and merging.


I dont know where can i put the model

When I try to launche the app, always hava an error accesing model. There is a way to download it manually? I doesn't understand the code.

"OSError: Cannot load model SG161222/Realistic_Vision_V6.0_B1_noVAE: model is not cached locally and an error occurred while trying to fetch metadata from the Hub. Please check out the root cause in the stacktrace above."
I get this error message, is this same issue??


Basic structure

Completed Project requirements

use Gitflow
Create an npm project with webpack.
Write plain HTML markup with minimum styling (just to make the layout)
Don't make API calls.
Use ES6 modules, with import and export.

my bad first time using GitHub desktop and didn't know that the .gitignore will ignore the dist file totally pass my radar.


Review policy script handling of payment consents with Consumed status

The policy script was updated to allow payment requests for consents with Consumed status to be authorised, see:
https://github.com/SecureBankingAccessToolkit/SecureBankingAccessToolkit/issues/505
The logic was changed such that any request for a consent with status Authorised or Consumed is authorised by the policy script (subject to the request passing other checks).
This seems dangerous as a payment consent with status Consumed indicates that the consented action has been carried out. For a domestic payment this indicates that the payment has been submitted. See spec
Potential issues could arise if further requests to submit payments are made for the same consent, if it is in Consumed state then the requests should be rejected.
Tasks

[ ] Review payments API calls and check which consent status they should allow
[ ] Update policy script to tighten the status checking
[ ] Update functional tests to do negative testing for combinations which are now disabled

Ultimately it is the job of the RS to reject additional payments being made for a consumed consent, as there could still be a race condition whereby 2 payment actions hit the policy check at the same time for the same consent before reaching the RS.
However it would be good to reject invalid requests as early in the flow as possible.

Closing as won't fix.
#1008 will remove the need for the policy script, the new Consent Store will handle consent status correctly.


Fix genes in upper pane that are not linkable

Description
Fixed the issue with the genes in upper pane that are not linkable. As per the code before this change, the stableId does not getting displayed when the gene description is missing which I think shouldn't be the case.
Views affected
http://ves-hx2-75.ebi.ac.uk:42228/Camarhynchus_parvulus_GCA_902806625.1/Location/Overview?db=core;r=2:1-152240728;region=2
Related JIRA Issues (EBI developers only)
https://www.ebi.ac.uk/panda/jira/browse/ENSWEB-6141

I can't see gene links in the zmenu I'm afraid

I can't see gene links in the zmenu I'm afraid

Hi @ens-st3 - sorry, I missed this one earlier. Could you please check again? Thanks


Improve testing

Hello Sebastián,
Classifiers at pyproject.toml says that Python 3.8 is supported already, but there are no tests for this version on Travis CI.
This PR enables tests for Python 3.8-dev and nightly.
Best regards!

Thanks @Jamim ! :tada:
I updated it to allow failures in Python 3.8-dev, as Pydantic still allows them. Once Pydantic enforces it I'll update it here.


Add a stream/2 function to the interface

This PR introduces a new stream/2 function which will return a Stream of the underlying ETS table. This Stream can then be used to iterate through all un-expired values quickly using a QLC handle.
In addition, I've included an :only option in case you wish to trim down what comes back to just being either keys or values. Default value being passed is { key, value } - I didn't feel a need to raise the entire underlying record... but if anyone requests it in future I may be inclined to tweak.
Please note that this is a moving Stream, meaning it may or may not take new writes into account during traversal. It uses raw ETS as using a transaction would result in all processing having to be done eagerly and inside the cache worker, which is far too expensive and poses an easy-to-do issue with blocking the GenServer. The current implementation allows the iteration of the cache to happen out of proc, which is actually closer to what I imagine people would expect to happen.
This will fix #22 when merged.
Edit: I have tweaked :only to :of in a follow-up commit which allows custom stream formats, with access to all internal fields (even if only :key and :value will be used). Default stays the same. I also added aliases throughout to help with match specs, instead of having to provide :"$1" & co. which are quite fiddly to type.

Coverage remained the same at 100.0% when pulling 133418e768df3e8f79c37a92382608effe433c19 on issue-22 into 13a0bdd4a128dcd9941528f263b301616f7e7834 on master.

Coverage remained the same at 100.0% when pulling 167eebad078ddfd60b61486341a17cd4817d6623 on issue-22 into 13a0bdd4a128dcd9941528f263b301616f7e7834 on master.

Coverage remained the same at 100.0% when pulling de76714d78f01901850a49acb2e0f20e93f1b51b on issue-22 into 13a0bdd4a128dcd9941528f263b301616f7e7834 on master.


asignFunctionReturnValue in engine.js is not working

I am trying to run the JSPrime for static analysis of javascript but asignFunctionReturnValue() is not working properly.
Hello Nishant can u provide a solution for it, the analyze() is not working properly and when i debugged the JSPrime i found that it is not coming out of the method asignFunctionReturnValue()  in engine.js and also the analyzeArrays requires formal parameters.kindly provide a solution.

Add exports.convertedFunction=convertedFunction;  in analyzer.js

Add exports.convertedFunction=convertedFunction; in analyzer.js

@TejaswiniU can u specify where should this block of code be added? Is it a method on some object?  I'm trying to make it work but with no luck.

@marcyss

Can you check this

@TejaswiniU thanks, I've added the lines, but the app seems to break when analyzing some code.
When I paste TEST CASE 06 from the readme file, which is:
function go(){ if (document.location.hash.split("#")[1]){ document.location.replace(document.location.hash.split("#")[1]); }}
it works fine, but when I paste code from TEST CASE 05, which is:
function timedMsg(abc,callback){ if(callback){ var t=setTimeout(eval('callback'),3000); return 0; }} function fire(){ var call = location.hash.split("#")[1]; var check=timedMsg; check("123",call); }
it breaks with the same error:

        convertedFunction.push(newFunction2);
        ^

ReferenceError: convertedFunction is not defined
at Object.asignFunctionReturnValue (/jsprime-node/engine.js:149:13)
at IncomingMessage. (/jsprime-node/server.js:71:18)
at emitNone (events.js:106:13)
at IncomingMessage.emit (events.js:208:7)
at endReadableNT (_stream_readable.js:1064:12)
at _combinedTickCallback (internal/process/next_tick.js:138:11)
at process._tickCallback (internal/process/next_tick.js:180:9)

did anyone notice similar behavior?


Reimplement parameter validation code

Right now validation code relies on strings and the reflect package to work. Because validation only works at runtime, it would be cool to change it so problems there can be found by Travis instead. It shouldn't introduce breaking changes to the SDK, but to go-autorest; and rewrite some stuff in AutoRest.

what do you mean by

so problems there can be found by Travis instead

With go build

@mcardosos great idea. Is there any reason why they couldn't be a split out into a separate re-usable 'validation' method so that validation errors could be picked up before trying to create an object?

I believe this issue should be in Azure/go-autorest, to compliment Azure/go-autorest#112. Alternatively, if we would like to solve it by change our codegen, then perhaps it would make more sense in Azure/autorest.

If we fix this, the changes would be in AutoRest and in go-autorest, but the affected code would be in this repo.

Chatted offline with @mcardosos and moved to the autorest repository. Please see the conversation linked above for further discussion.


[stable/fluentd] Duplicate pvc template

Describe the bug
Inside fluentd chart templates, there is one pvc.yml file as well as one pvc.yaml file. I think it's a mistake.

It sure seems like it:
helm install --name fluentd stable/fluentd --version 2.1.3
Error: release fluentd failed: persistentvolumeclaims "fluentd" already exists

Seems like this was fixed 5 days ago here #19131


[WIP] Try to fix gh-1154

@testcafe-build-bot \retest

@testcafe-build-bot \retest

@testcafe-build-bot \retest

@testcafe-build-bot \retest

@testcafe-build-bot

As i expected, gh-1154 test crashes TestCafe without fix - link

@testcafe-build-bot \retest

@testcafe-build-bot \retest

@testcafe-build-bot \retest

@testcafe-build-bot \retest

\cc @AlexanderMoskovkin

it's discussed with @georgiy-abbasov in private. We need to rethink this

We should come up with another approach, i will reopen when it will be ready


NFF-GO hangs when speed is large and generator is heavy

Reproducer:
package main

import (
	"fmt"
	"time"

	"github.com/intel-go/nff-go/flow"
	"github.com/intel-go/nff-go/packet"
)

func main() {
	config := flow.Config{}
	flow.CheckFatal(flow.SystemInit(&config))
	outFlow, err := flow.SetFastGenerator(generate,<PHONE_NUMBER>, nil)
	flow.CheckFatal(err)
	flow.CheckFatal(flow.SetSender(outFlow, uint16(0)))
	flow.CheckFatal(flow.SystemStart())
}

func generate(pkt *packet.Packet, context flow.UserContext) {
	if pkt == nil {
		panic("Failed to create new packet")
	}
	if !packet.InitEmptyPacket(pkt, 16) {
		panic(fmt.Sprintf("InitEmptyPacket failed"))
	}
	time.Sleep(100000)
}

run:
./tmp

Output:
DEBUG: ---------------
DEBUG: Start new clone for fast generator instance 0 at 43 core
DEBUG: Start new clone for fast generator instance 0 at 44 core
DEBUG: System is using 45 cores now. 43 cores are left available.
DEBUG: Current speed of fast generator is 194240 PKT/S, target speed is<PHONE_NUMBER> PKT/S
DEBUG: Mempool usage fast generate 1408 from 8191
DEBUG: Mempool usage slow operations 0 from 8191
DEBUG: ---------------
DEBUG: Start new clone for fast generator instance 0 at 45 core
DEBUG: System is using 46 cores now. 42 cores are left available.
DEBUG: Current speed of fast generator is 197248 PKT/S, target speed is<PHONE_NUMBER> PKT/S
DEBUG: Mempool usage fast generate 1184 from 8191
DEBUG: Mempool usage slow operations 0 from 8191
DEBUG: ---------------
DEBUG: Start new clone for fast generator instance 0 at 46 core
DEBUG: Start new clone for fast generator instance 0 at 47 core
DEBUG: System is using 48 cores now. 40 cores are left available.
DEBUG: Current speed of fast generator is 200256 PKT/S, target speed is<PHONE_NUMBER> PKT/S
DEBUG: Mempool usage fast generate 640 from 8191
DEBUG: Mempool usage slow operations 0 from 8191
DEBUG: ---------------
DEBUG: Start new clone for fast generator instance 0 at 48 core

And then nothing.
lscpu:
CPU(s):              88
On-line CPU(s) list: 0-87

Done