Dropdown list/select of available sidebars/widget areas

Issue description:
I would like to list all available sidebars/widget areas in a dropdown. I know how to get categories with:
'choices' => Kirki_Helper::get_terms( 'category' )
But I'm not sure how to do for the sidebars/widget areas.

Here is how OptionTree does it, perhaps something worth adding? I'm moving from OT and this is the only thing I have had trouble with.
if ( ! function_exists( 'ot_type_sidebar_select' ) ) {

  function ot_type_sidebar_select( $args = array() ) {

    /* turns arguments array into variables */
    extract( $args );

    /* verify a description */
    $has_desc = $field_desc ? true : false;

    /* format setting outer wrapper */
    echo '
';

      /* description */
      echo $has_desc ? '
' . htmlspecialchars_decode( $field_desc ) . '
' : '';

      /* format setting inner wrapper */
      echo '
';

        /* build page select */
        echo '<select name="' . esc_attr( $field_name ) . '" id="' . esc_attr( $field_id ) . '" class="option-tree-ui-select ' . $field_class . '">';

        /* get the registered sidebars */
        global $wp_registered_sidebars;

        $sidebars = array();
        foreach( $wp_registered_sidebars as $id=>$sidebar ) {
          $sidebars[ $id ] = $sidebar[ 'name' ];
        }

        /* filters to restrict which sidebars are allowed to be selected, for example we can restrict footer sidebars to be selectable on a blog page */
        $sidebars = apply_filters( 'ot_recognized_sidebars', $sidebars );
        $sidebars = apply_filters( 'ot_recognized_sidebars_' . $field_id, $sidebars );

        /* has sidebars */
        if ( count( $sidebars ) ) {
          echo '<option value="">-- ' . __( 'Choose Sidebar', 'kirkitheme' ) . ' --</option>';
          foreach ( $sidebars as $id => $sidebar ) {
            echo '<option value="' . esc_attr( $id ) . '"' . selected( $field_value, $id, false ) . '>' . esc_attr( $sidebar ) . '</option>';
          }
        } else {
          echo '<option value="">' . __( 'No Sidebars', 'kirkitheme' ) . '</option>';
        }

        echo '</select>';

      echo '
';

    echo '
';

  }

}

Hey there!
I'm glad you like Kirki, I really appreciate it.
For the sidebars selection it's mostly a timing issue.
Sometimes controls are registered before custom sidebars are added, so you need to delay the control a bit.
I added an example of how to do it here: https://github.com/aristath/kirki/blob/e4fc230efc8988442c0d65f3c8e613b16fee9f2a/example.php#L906-L929
The Kirki::add_field() call needs to be wrapped inside a function that will be added on init with a priority pretty high (like 999 in the example).
In this example I'm saving the sidebar-ID and displaying the sidebar-name - which is what I suppose is the most usual scenario

Perfect, thank you.
The only issue now is that when I create a sidebar area with the repeater, the new sidebar does not appear in the dropdown unless I force-refresh the customizer. Is there any way to make it appear once saved?
Example: https://i.imgur.com/qBSoYs8.png

Oh, I didn't realize you were using a repeater to create the sidebars....
I'm afraid not, there (currently) is no implementation to live-update the selections inside a dropbox from the values of another control.
It's possible if you write some custom JS, but not out of the box.

Might be stupid of me to use the repeater for it, but it will have to work for now - I'll just tell users to refresh. I'm trying to get all the features from OT to work here in Kirki.
Thanks for the quick responses, this is light night and day compared to OT which has been pretty much dead for 2 years. Awesome to see ongoing development. Fantastic work :-)

👍 I'm glad i could help!
You could add details on how to handle this in the repeater's description(save as draft and refresh page to see your new sidebars in the select - or something along those lines)

Good idea! Added both a description and extra details in a tooltip. That will work!

function kirki_sidebars_select_example() {
        do_action('widgets_init');
 	$sidebars = array();
 	if ( isset( $GLOBALS['wp_registered_sidebars'] ) ) {
 		$sidebars = $GLOBALS['wp_registered_sidebars'];
 	}
 	$sidebars_choices = array();
 	foreach ( $sidebars as $sidebar ) {
 		$sidebars_choices[ $sidebar['id'] ] = $sidebar['name'];
 	}
        return $sidebars_choices;
 }

Kirki::add_field( 'kirki_demo', array(
 		'type'        => 'select',
 		'settings'    => 'sidebars_select',
 		'label'       => esc_attr__( 'Sidebars Select', 'kirki' ),
 		'description' => esc_attr__( 'An example of how to implement sidebars selection.', 'kirki' ),
 		'section'     => 'select_section',
 		'default'     => 'primary',
 		'choices'     => kirki_sidebars_select_example(),
 		'priority'    => 30,
 	) );

in the beginning, call the do_action('widgets_init');

Hm, makes no difference here when I try. Still need to manually refresh the page for the sidebars to show up.

@AlxMedia
I use KIRKI it as a plugin (not built into the theme)
the list creation function was added after the initialization of the customizer
just checked, in 20 places where it is called all work fine
and there are no errors in the console or debug.log


don't get it

Expected behavior
Actual behavior
Information about the Issue
Steps to reproduce the behavior

...
...

No information provided or steps to replicate - Closing


fix response body property in GPT

The response from OpenAI seems changed to text -> message.content.
In local_setup branch, it still remained using previous property.
I'm not sure wether you might cherry-pick or do something for this branch, but hope this PR will help to fix it.

The issue is also reported here
https://github.com/EyuCoder/chatgpt-clone/issues/16#issuecomment-1464719747

#16 fixed

@EyuCoder
Thanks for your checking!


Provide human readable specs

This provides an array, converted as JSON. It needs to provide human readable formats, including:

[ ] yaml
[ ] HTML

Note: I should upgrade this to chevere/schwager-ui

RE: https://github.com/chevere/schwager-ui


[iOS] Swift Package Manager import by version doesn't work

When trying to import the SPM by version (the default in Xcode), I get an error.
Steps:

Add a new Swift package and point it at: https://github.com/microsoft/AdaptiveCards
Leave the options at the defaults, which uses versioning rules
Click the Next button

Result:
An error: "AdaptiveCards has no Package.swift manifest for version 2020.10.1…"
Importing by branch does work, but that's not ideal since it could unexpectedly pull in a version with breaking changes.

BTW — THANK YOU for making the SPM package. I can finally use the simulator without having to run a hacked Rosetta version of Xcode.

@jscalo,
Hello,
We haven't made a single release yet since the SPM support is added that's why we haven't generated any tags. The next official release is for v1.5 at the end of June, but I will work with the team to make it sooner.

@jwoo-msft it's end of July and importing the package in the normal way still fails. Did v1.5 ever get released?
Also should I file a separate ticket to have the "getting started" instructions updated so they don't only mention CocoaPods?

@jwoo-msft it's end of July and importing the package in the normal way still fails. Did v1.5 ever get released?
Also should I file a separate ticket to have the "getting started" instructions updated so they don't only mention CocoaPods?
@jscalo
Thanks for letting us know of this! Please do so for the instruction, and I will follow up.
the official v1.5 has not been released.
Since we have multiple platforms sharing the same repo, using git tag as versioning only for iOS doesn't work for us. Would commit hash work for you? If we note the commit hash associated with a release in the release note, would that work for you?

I'm just getting around to verifying this (we since moved to using a fork of the project to get around the issue) and I'm sorry to say it seems exactly the same as before. It looks like the Package.swift file was last changed 8 months ago, so it makes sense that this behavior wouldn't have changed.
To reiterate, the steps to reproduce are slightly different in Xcode 15:

Make a new iOS project
Select the Project, then the Package Dependencies tab
Click + to add a new SPM package
Enter https://github.com/microsoft/AdaptiveCards in the URL field at the top right
Leave dependency rule at its default, "up to next major version"
Click Add Package

Result:
This error.

BTW since I didn't close this issue myself, I can't re-open it.

@jwoo-msft - can you please provide some guidance here?

I think the problem has to do with the fact that SPM is always going to look for tags in the form of major.minor.patch and the closest thing it can currently find is 2020.10.1 which doesn't include the file Package.swift.

@jscalo
c.c. @jonmill
the issue is exactly as you mentioned. the tag has to be in that format. And the problem is that we cannot use that form. The iOS SDK is part of AdaptiveCards repo which contains other renders, Android, XAML, JS and .NET. So we can't tag the repo to a unifying version since those different renders are in different version of their own, so we have us prefix such as ios, but SPM can't handle it. So what we have discussed for the solution so far is using the commit hash. This will be continuously a problem until iOS has its repo or SPM supports prefix for tag. Sorry about the bad news.

@jwoo-msft this is probably more drastic than you'd like, but what about splitting out the iOS parts into its own repo? For better or worse SPM is the future of package management on Apple platforms and if it's not supported well in this project then it will be a significant barrier to adoption.
Also @jonmill would you mind reopening this ticket?


all users get passwordless promts

We followed these instructions to enable for only a test group being sure to scope it properly but now all users are getting passwordless auth prompts and have to choose to use password instead since they are not in the scoped group.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ae3dbcad-9d0d-c32d-7b02-2a3ffe291b2e
Version Independent ID: 4f716e15-73a2-71a0-53ba-801b6097c479
Content: Configure Azure Active Directory passwordless sign in (preview)
Content Source: articles/active-directory/authentication/howto-authentication-passwordless-enable.md
Service: active-directory
Sub-service: authentication
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@roberts2727 Thanks for your feedback! We will investigate and update as appropriate.

Our experience has been slightly different. When you enable a group of users; all the other users get prompted for passwordless; and then after successfully using the App to login; they get re-prompted for a password.

@roberts2727 As mentioned in the document it may be possible that user has created a passwordless phone sign-in credential earlier.  In that case, once the admin enables the authentication policy for passwordless phone sign-in any user with a credential registered will start experince the new sign-in prompt regardless of they have enabled for it or not.    If this is not the case I suggest you to please open a Azure Support Ticket so that Identity Support engineer can check further on this issue. In case you limitations in your support plan to open support ticket please let me know.

@roberts2727 We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


⚠ Bofrost.de has degraded performance

In 5d4280b, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1713 ms

Resolved: Bofrost.de performance has improved in 3b96436 after 13 minutes.


add method to change font

Small change to add a method that allows the font on the notification to be easily modified.

sorry i'm just getting around to these, I accidentally turned off notifications

looks good, thanks for the input


TradeRoutines: implement CalculateLotsForDeal() method

CalculateLotsForDeal() method calculates maximum lots for deal depends on current price and volume of instrument in one lot.
Formula: lots = maxCost // (currentPrice * volumeInLot), it means max count of lots, for which will be:
cost = lots * currentPrice * volumeInLot <= maxCost.
If costOneLot = currentPrice * volumeInLot > maxCost, then returned lots = 1.
If an error occurred then returned lots = 0.
This method can be used when you need to calculate lots to open position.

Implemented since build v1.6.dev134
Debug build: https://app.travis-ci.com/github/Tim55667757/TKSBrokerAPI/builds/258615346
PyPI artefact for testing: https://pypi.org/project/tksbrokerapi/1.6.dev134/


Make Workers aware of CORE Processors

@ipapapa @vinaykumarchella
In regards of https://github.com/Netflix/ndbench/issues/11
I change NdBenchConfiguration to check the available processors and them multiply this result by 4. Doing So I was able to get more than 20K RPS on Cassandra.

Cheers,
Diego Pacheco

You could change the number of writers and readers through the properties aka pappy.driver.numReaders and pappy.driver.numWriters. For Dynomite I used NUM_READERS=32 and NUM_READERS=8.

Why do we want to change the default ones from 1 to the system ones?
Why do you have 11 commits for a two line change? You could absorb the commits internally and fire just 1.

@ipapapa

IMHO 1 is too little. You can get more than ~2K RPS with 1. I'm not sure this is the best default.
Sure - I can reduce commits.  :-)


⚠ Bofrost.at has degraded performance

In 36e4271, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2059 ms

Resolved: Bofrost.at performance has improved in 0f682bd after 13 minutes.


[$1000] Attachments - Unable to upload attachments in certain rooms

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.30-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @rafecolton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705433392285439
Action Performed:

Log in with a Expensifail account
Navigate to the room #applause.expensifail.com (https://staging.new.expensify.com/r/5324367938904284)
Send an image to the chat
Login to another Expensifail account
Navigate to the room #applause.expensifail.com (https://staging.new.expensify.com/r/5324367938904284
Verify if you can see the uploaded image

Expected Result:
Image is uploaded and displayed in the conversation history.
Actual Result:
The image uploads for a while then an error is displayed in chat and in JS console
Workaround:
N/A
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015a3eadd41d507135
Upwork Job ID:<PHONE_NUMBER>297426432
Last Price Increase: 2024-02-06

This might be related to
https://github.com/Expensify/App/issues/35017
Since comes first in the process (you have to upload before seeing multiple images, I'm going to put the other on hold pending this one).

I'm experiencing this, but the attachment does seem to actually upload: other people are reacting to it, at least

![image](https://github.com/Expensify/App/assets/16888060/e6fbade6-7337-4ca2-b509-b5116d95bc6d)
I've updated OP for repro steps to check if others can see it.

@NicMendonca need a Expensifail account to test this C+/contributors  don't have one so can you make this internal please, thanks!

Happened to me last night then tested again this morn to reproduce

Open #social room
Type some text
Drag drop an image file to the compose box
Click button to upload
Leave chat at #social for a while, hoping that it uploads (never left #social for this test)
Observe receiving error and that image didn't upload

What I see in the console

@NicMendonca can you try to reproduce in #social? If you can't, will you please swap me out with you as assignees? Thx

Both the pic and the text posted, although they still shows as not on my end.

What's weird is that, on mobile, it's showing correctly, without the erros

Experiencing the same bug on iOS when I try to upload a photo.  The photo at text both post though. (for some reason I thought it might be platform specific)

@mallenexpensify I can repro! But I am going to assign this back to you since I start mat leave next week and won't be able to see this one through!

I'm unavailable next week, Please assign a new C+ Issue here if required while I am away, thanks!
cc: @mallenexpensify

Raised to $1k to try to get more 👀 on this.  Reassigned C+ @Santhosh-Sellavel since I'm hoping we can get this fixed soon.  @situchan any thoughts on what might be going on?

Can I get room invited to reproduce? Seems like not reproducible on normal report

@situchan do you have access to the 'high traffic' workspace?  If so, are there any rooms in there? I'm checking with QA too

@mallenexpensify I don't have access. Can I get invited?

I invited you @situchan , using your email that's associated with your Slack instance.  DM me if that's not the best one. Can you confirm here once you've been granted access? I'm unsure of the process after requesting access

@situchan can you invite me to a room in Crowded Policy and comment here once you have done so? Plz use<EMAIL_ADDRESS>Thanks

@mallenexpensify as an invitee, I don't have permission to invite someone

I created a room on that policy and invited you https://staging.new.expensify.com/r/1369282750079587

Know of any easy way to auto-populate that room with a bunch of chats/files.  or.. a way to regularly populate it, ie. have a few test accounts post 10 messages in there a day?

No idea how to proceed since contributors (including me) are not able to reproduce

Added Needs Reproduction and bumping to weekly since I'm also unsure of currently reproduction status.

Gonna close this until someone else runs into the bug and posts deets.


Rouding decimal inside of the mustache

I was trying to round some decimal inside of the template. Like,
# application.coffee
# ...
search.addWidget instantsearch.widgets.hits(
  container: '#hits'
  templates:
    empty: 'No results'
    item: "{{{Math.round(A)}}}") # A is a value of something from Algolia
# ...

I checked the documentation, but I didn't find anything.

Not sure what you decided, but you can use transformData for this


Fix typo in dismissable property

Fixes typo dismisable in code
Fixes #6

Hey! thx for this PR :D sorry for the delay, been really busy lately.


Adding 32bits UTF-8 reading with unicode entities conversion instead of question marks

background:
As most of you are aware, CHM does not support Unicode & so, UTF-8 (unicode encoding) files in DITA are converted by the org.dita.dost.util.ConvertLang ant task in the dita.htmlhelp.convertlang target of DITA in the correct non unicode format with a specific charset.
In consequence, the Java Charset decoder classes puts question marks on unknown/unmanaged/foreign characters when they cannot be found in the destination non unicode charset.
Potential workaround(s) found on Internet/or in this forum:
Lot of people complains around the net about this issue. Lot of them modified/tweaked/hijacked the codepages.xml file to force the output charset to be UTF-8. But CHM compiler does not really support unicode in reality.
Proposal defintive solution fix:
Goals:
Having the org.dita.dost.util.ConvertLang be able to read true/full UTF-8 chars based on 32 bits code points (instead of 16 as previsouly)
Having unmanaged/unknown/foreigen chars in the destination non unicode charset, put/converted into HTML entities instead of question marks to be still displayed correctly even if they will not be indexed or cannot be found through the index (that''s a limitation)

This fix works only for html, hhc, hhk files (so only for HTML files). Instead of having Java reading UTF-8 and using its old read() method returning only a 16 bit value, the new code read it in binary and convert the value itself into an UTF-8 32 bits code point.
As previously it will first search for an entity in the entities.properties. workflow:
As in the past, If no corresponding forced entitiy is found in the entities.properties,
the binary storage of the code point is next converted into Java String (UTF-16 internal java string format if I am right)
it next tries to convert the Java String (UTF-16) into the destination output charset.
If the converted can be converted back to the UTF-16 and is identical to the source, then the string/converted char is saved otherwise, its 32 bits code point is put in the html file as entity.

A:Byte->B:UTF-8->C:code point value of the UTF-8 code->D:Java String ->E:output encoding request->F:JavaString
A is read from the file
B is the full UTF-8 sequence
C is the B sequence converted into an int code point
D is the UTF-8 Java decoding and stored into JavaString (same for E and as I said but maybe I am wrong, but Java Strings are stored internaly into UTF-16 ?)
E is the final output
By comparing D & F, you can check if you lost something in the destination which was replaced by a question mark & if lost, then put the Unicode value as HTML entity (C)!
Why using HTML entities for lost chars in the encoded output ?
looking to this doc http://en.wikipedia.org/wiki/Unicode_and_HTML
...
Numeric character references[edit source | editbeta]
Main article: Numeric character reference
In order to work around the limitations of legacy encodings, HTML is designed such that it is possible to represent characters from the whole of Unicode inside an HTML document by using a numeric character reference: a sequence of characters that explicitly spell out the Unicode code point of the character being represented. A character reference takes the form &#N;, where N is either a decimal number for the Unicode code point, or a hexadecimal number, in which case it must be prefixed by x. The characters that compose the numeric character reference are universally representable in every encoding approved for use on the Internet
More information can be found in the dita-ot forum here: http://groups.yahoo.com/neo/groups/dita-users/conversations/topics/32823

Closing as won't fix.


Adds feature to query with an image

Description
This PR adds feature  to the textbox to query with an image.
Issues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would break existing design and interface)
[ ] Others (enhancement, documentation, validation, etc.)

Dependencies
n/a
Tests
I rebuilt the gradio ui docker and checked the image query works as expected

PR created by mistake. It is not ready yet


fix bug: cannot read property 'params' of undefined

Can you post a plunkr or submit a unit test that triggers the issue? Also: http://prjs.radify.io/#/angular-ui/ui-router/pulls/2441 — Thanks!


Insertion Sort in recursive way using c++

Title: Insertion Sort
Folder: C++/Algorithms/Sorting/InsertionSort.cpp
Functionality: This program implement Insertion sort in recursive way on integer and string values.

@SharmilaSrinivasa Change the file name to indicate that it is a recursive implementation of Insertion Sort. something like "InsertionSort_recursive.cpp"

File name changed to InsertionSort_recursive.cpp


[Vue / Webpack] using a downloaded file rather than a url

Excuse me if this is a stupid/unclear question, but is it also possible to provide a local path instead of a url?
For example in vue I'd download the rive file in to my assets folder, and then I'd want to load it into rive using
new Rive({
      src: 'assets/filename.rive',
      canvas: document.getElementById('canv'),
      layout: new Layout({fit: 'contain', alignment: 'center'}),
 })

Nevermind, this is not an issue with rive whatsoever. It was my limited webpack knowledge that prevented me from doing what I wanted.


Added the contact us page

Solved Issue #159

This PR does the following:

Adds ... Added the Contact Us Page

Changes
List the detailed changes made in this PR.

Added a new feature to ... Added the Contact Us Page

Screenshots (if applicable)
7e01f4dc-dd92-4d78-9e12-26ef674457ab.webm
Checklist

[ x] I have performed a self-review of my code
[ x] My changes generate no new warnings
[ x] I am working on this issue under GSSOC

@Trisha-tech Pls review the PR!!!


IJCK R2C2

Am I correct to state that ChemKED is a YAML file with a predefined structure?

Closed by f37a9099d8052bbd19490f550fcbed98652a2cbd


Fix mixed tabs and spaces in HTML files

I signed it!

It is Google's (and generally accepted) code style policy to never use tabs and always use spaces. If we want to fix mixed tabs and spaces, please change it so that everything is spaces.


Major drawbacks of using Application Gateway Ingress Controller

From the announcement at https://azure.microsoft.com/nb-no/blog/application-gateway-ingress-controller-for-azure-kubernetes-service/ and documentation at https://docs.microsoft.com/en-us/azure/application-gateway/application-gateway-faq#configuration---ingress-controller-for-aks one can get the impression that using the azure application gateway ingress controller in order to configure an azure application gateway using standard kubernetes ingress resources deployed to azure kubernetes service, is ready for prime time. However, our experience from using this ingress controller in production for a couple days, clearly indicates that you should not do so if you're looking for zero-downtime during deployments and other events in your cluster that might impact application gateway configuration (scaling operations, pod crashes etc etc).
It turns out that it can take several minutes for the ingress controller to perform config changes in azure application gateway. This is also backed by the FAQ found at https://docs.microsoft.com/en-us/azure/application-gateway/application-gateway-faq#how-long-does-it-take-to-deploy-an-application-gateway-will-my-application-gateway-work-while-its-being-updated where one can read:
Question: "Will my application gateway work while it's being updated?"
Answer: "Most deployments that use the v2 SKU take around 6 minutes to provision. However it can take longer depending on the type of deployment. For example, deployments across multiple Availability Zones with many instances can take more than 6 minutes."
Our experience shows that configuration changes sometimes can take significantly longer (we've experienced 10 minutes in two different clusters/application gateways). Other users have seen even longer delays: https://feedback.azure.com/forums/281804-azure-resource-manager/suggestions/19119910-application-gateway-management-operations-are-agon
The impact of this is that your app gw backend pool might point to ips of pods that are long gone, leading to users getting 502s.
I only see only possible fix to this issue: configuration changes in application gateway have to be way faster and more reliable. For instance being able to perform config changes in less than 30s , would help a lot.
Right now I would not recommend using this ingress controller to anyone.
Azure, you're loosing business.
Azure support ticket:<PHONE_NUMBER>02716

We ran into this problem as well except the updates just completely failed and timed out after 15 minutes. The gateway was then stuck in an updating state so we couldn't make any changes to it at all.
I spent the afternoon switching to use nginx-ingress instead 😞
Our ticket number is<PHONE_NUMBER>01561 if you wanna look at the logs

Hey @mscatyao,
Thanks for getting back to me.
I have a few more questions that I would like you to comment on:

Expected performance

The expected configuration update time for Application Gateway v2 is on the order of ~40 seconds.
I have found no official sources documenting this.
It would be great if you could provide us with detailed response time metrics - I'm sure you're actively tracking this number across all app gw instances that you manage. 90, 95, 99, 99.9 percentiles would be great as a reference.

Incidents

You call what happened to us on January 27 a platform issue. I can find no trace of this issue on https://status.azure.com/en-us/status/history/ - why is that?
How often do these platform issues occur? What's your track record here? Please, be sincere.

SLA

Does a delay like this count towards an SLA (to us the app gw was in practice unavailable)? If you're confident the app gw config changes normally complete within 40s, why not put it in the SLA explicitly?

FAQ

The FAQ should be updated - it says "Will my application gateway work while it's being updated?" which might lead people to think that this applies to config changes.
In addition, the support agent referred to this number during a phone call I had with him.

Timeline

When do you plan to fix the underlying issue here?

@landro You may consider using an explicit lifeCycleHook on your deployments to wait X amount of time (depending on your draining configuration) and only after that time is finished start removing the pod - it will be switched to terminating status and AGIC should reconfigure AG to remove it but let requests finish.
I hoped for being able to run RollingUpdates for my deployments swapping pods 1b1 but unfortunately for w/e reason AG backend healthchecks can fail against completely fine and working pods :(
Sometimes leaving you with no backends to handle the traffic and causing thousends of 502s responses to the client.

We're already doing what you're suggesting @hajdukd - that won't help much however if app gw spends 10 minutes performing config changes.

Hey @sdesmond46 - thanks for reaching out. We're sorry for the delays; we'll reach out to you shortly.
Hey @landro - these are all great questions. We understand your frustrations; we've reached out via the support case you opened and will be following up there. In terms of the FAQ, I'll change the wording to be more clear and specify that the answer refers to provisioning/create time and not update time.

Resolved via support ticket internally.

I see no reason for closing this ticket. The issue still remains - for workloads that require true HA, using app gw ingress controller is not adequate. Please keep this issue open until the underlying issue of config change propagation times is fixed, @mscatyao

It seems that the AGIC does not respect the readiness probes of the pods when issuing health probes? Can this be true? We observe downtime when using AGIC on every deployment, although the pods have readiness checks.

What if the timeout was paired with an AGIC proxy sidecar that forwarded calls to the new ones starting up during a rollover?

Can this be true?
This sure is true. It uses its own healthcheck mechanics and doesn't respect the settings provided by kubernetes.

Out of the different people describing those incidents and having support cases, is there any general information available on how to solve this problem? Or do I have to open a support case as well?

Haven't checked in lately but the general consensus is that it isn't fixed and you can somehow 'bypass' it using this method: https://github.com/Azure/application-gateway-kubernetes-ingress/blob/master/docs/how-tos/minimize-downtime-during-deployments.md#minimizing-downtime-during-deployments however true zero-downtime is not a thing as much as im aware of.

I0221 18:29:19.646282       1 controller.go:151] Completed last event loop run in: 7m50.758823353s

I think this issue should be opened.

Also (too) slow here:
I0216 23:18:32.849854       1 controller.go:151] Completed last event loop run in: 2m49.866471825s

I was thinking of trying AGIC for our multi tenant cluster and some on-prem workloads but after reading (by now, a bit old thread) I’m having second thoughts.
Big thanks to everyone who shared their experience!
Where there any actions from Azure side to mitigate mentioned problems with the service?

Where there any actions from Azure side to mitigate mentioned problems with the service?

Not as far as we know. The reason for closing this issue was:

Resolved via support ticket internally.

But we never got a response back from @mscatyao how and/or if this problem was resolved.
As @landro said, the actual problem (true zero downtime: AKA no 502's or timeouts) is still there but can be minimized as described in the docs https://github.com/Azure/application-gateway-kubernetes-ingress/blob/master/docs/how-tos/minimize-downtime-during-deployments.md#minimizing-downtime-during-deployments

As @landro said, the actual problem (true zero downtime: AKA no 502's or timeouts) is still there but can be minimized as described in the docs https://github.com/Azure/application-gateway-kubernetes-ingress/blob/master/docs/how-tos/minimize-downtime-during-deployments.md#minimizing-downtime-during-deployments

Note that while the above would minimize the issue during deployment, there are other cases where it won't help at all. Specifically, in cases where preStop isn't invoked (such as container crash for whatever reason, e.g OOM). I've opened a ticket with a possible compromise mitigation, feel free to upvote: https://github.com/Azure/application-gateway-kubernetes-ingress/issues/1427/.


Published the Custom task to TFS 2015

Team,
recently we published a custom task to on-prem tfs  successfully but we are not able to see that task in build/release.Please suggest here.

Sorry, I can't help with your issue, but can I ask how you published on-prem.  I can't get past the tfx login because On-prem TFS doesn't use Personal Pass Tokens.  Or am I missing something?

We have done the same, for the IISWebAppDeployment vso-agent-tasks task, but can't get it to display. I'm currently running TFS 2015 Update 2 RC 2

I am trying to publish the task on VSTS which uses PAT. I have been able to upload them successfully. If I try to reupload them I have a Error which tell me that the Extension has already been Created. But... When going to the portal I am unable to see the tasks in build and Release tasks. Plus when trying to List the tasks "tfx build tasks list" I don't have any trace of the tasks I uploaded. Do you have the same issue ?

Any news on this, the same on TFS 2017.


issues with pokeloot dropping air

I recently claimed a pokeloot on the map and did not get an item. the chat message says my inventory is full and air was dropped on the ground. My inventory was in fact, not full.

This is fixed for next restart, thanks for the report!


Session data lost on page refresh

We show the current username in the top right corner. The name is not shown on page refresh (F5 or Ctrl + R), probably due to lost session data.
This requires a fix.
We use ember-simple-auth for authentication in Ember. Issue 523 might give a hint. However, I think the problem may also origin in our session handling.

Fixed with b4d6710917c8362e2ed84b5c17216545136af983


per pvc per repo

Feature Description
Hi, Can we do per pvc per repo with gitea?
Screenshots
No response

Could you explain in more detail about what you mean by pvc?

The PVC means is Kubernetes PVC ( persistent volume claim). Currently, I have set up Gitea on kubernetes with 1 PVC and mounted that pvc under path /data.
Now whenever I create a new repository, it creates an under /data mount path. But I want every repository should be created under every different mount path which would be associated with different PVC.
Same thing I am doing by setting my own  GitSCM server on k8s. Here it's manifest.yaml
    image: ubuntu:latest
      ports:
      - containerPort: 22
      lifecycle:
        postStart:
          exec:
            command: ['/bin/sh', '-c', 'apt update; apt install -y git; apt-get install -y openssh-server tzdata-; /etc/init.d/ssh start; useradd -m git; echo "git:password" | chpasswd; mkdir -p /home/git/.ssh; cp /root/.ssh/* /home/git/.ssh; cp /root/.ssh/git-scm.pub /home/git/.ssh/authorized_keys; for dir in /home/git/repos/*; do(git init --bare "$dir"); chown -R git:git /home/*; done > git-logs.log']
      command: ['sh', '-c', 'sleep 6600']
      volumeMounts:
      - mountPath: /home/git/repos/wordpress1
        name: git-wordpress1
      - mountPath: /home/git/repos/spring-boot1
        name: git-spring-boot1
      - mountPath: /home/git/repos/dockerfile
        name: git-dockerfile
      - name: ssh-key
        mountPath: /root/.ssh

I am using ubuntu docker image and there I installed git and created bare repos and each repos are mounted to a different mount path. However currently I don't have any UI.
That's why I am checking Gitea so that I can get such configuration and plus UI.

I think this could be done based on #18147 . We can have a new implementation about how to store the git repositories.


Fix: responsive pivot items

Overview
On smaller screens, the view of the components (request/response) is altered.
Fixes #450
Demo
Desktop:

Mobile:

Notes
There is currently an open issue on the fluent ui repository to help users sort this out. Hence scrolling horizontally or having a behaviour similar to an overflowing command bar is not feasible at the moment.
This current implementation utilises an easier idea that the user will have interacted with the desktop version of GE before going mobile and so the icons will make things easier to find and remember.
Testing Instructions

Minimise your screen to mobile size
Notice the display changes to icons only

@thewahome found these errors when i tried accessing the Adaptive cards tab on this PR.
Also, it would help to have tips on each taab on small screens now that the tab names have been replaced by icons.


module Xenium Ranger

Description of feature
https://www.10xgenomics.com/support/software/xenium-ranger/latest
!! Please check with nf-core and 10x how to implement this as a module to avoid copy right and maintenance issues (check license again) !!

[ ] How to scale it up? How do we handle parallelization?

Extensive testing of the xeniumranger modules remain, additions to nf-tests required for more meaningful and corner case testing along with baysor integration.


[web] add blendmode diff_color golden

It would be great to link to the PR that created the screenshots. That way it can easily be tracked.


KAFKA-17137: Feat admin client it acl configs

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Testcases:

[x] describeAcls + timeoutMs
[x] createAcls + timeoutMs
[x] deleteAcls + timeoutMs
[x] describeConfigs + timeoutMs
[x] alterConfigs + timeoutMs
[ ] expireDelegationToken + expiryTimePeriodMs

@unknowntpo could you please fix the build error

Okay, fixed, but right now, lots of tests failed, I'll try to fix it.
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-16648/11/testReport/

@unknowntpo could you please fix the conflicts?

@chia7712 Done.

@chia7712 Done.

* What went wrong:
Execution failed for task ':clients:javadoc'.
> Javadoc generation failed. Generated Javadoc options file (useful for troubleshooting): '/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-16648/clients/build/tmp/javadoc/javadoc.options'

@unknowntpo Could you please check the error?


Why this approach, What makes it special

@cornflourblue  I like your way but why did you do it like this when instead you can take an easier way like using a prebuilt component like react-facebook-login
import React from 'react';
import ReactDOM from 'react-dom';
import FacebookLogin from 'react-facebook-login';

const responseFacebook = (response) => {
  console.log(response);
}

ReactDOM.render(
  <FacebookLogin
    appId="1088597931155576"
    autoLoad={true}
    fields="name,email,picture"
    onClick={componentClicked}
    callback={responseFacebook} />,
  document.getElementById('demo')
);

Your way works fine, but I am just curious


Xamarin vs Ionic

https://ionicframework.com/
https://www.xamarin.com/

Bluntman and chronic?
On Dec 26, 2017 8:43 PM, "Mike Mulchrone"<EMAIL_ADDRESS>wrote:

https://ionicframework.com/
https://www.xamarin.com/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mtmulch/mulchronedigital.com/issues/51, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ATe95FrQnhKPDR_tf-ioOVvBv7hrXHZOks5tEa7ogaJpZM4RNIBK
.

On Dec 27, 2017 6:35 AM, "Alex"<EMAIL_ADDRESS>wrote:

Bluntman and chronic?
On Dec 26, 2017 8:43 PM, "Mike Mulchrone"<EMAIL_ADDRESS>wrote:

https://ionicframework.com/
https://www.xamarin.com/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mtmulch/mulchronedigital.com/issues/51, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/ATe95FrQnhKPDR_tf-
ioOVvBv7hrXHZOks5tEa7ogaJpZM4RNIBK>
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mtmulch/mulchronedigital.com/issues/51#issuecomment-354100900,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APhUUY-Kr3e1Jbts5TvD1wnuYUBECx7Nks5tEit-gaJpZM4RNIBK
.

On Dec 27, 2017 6:35 AM, "Alex"<EMAIL_ADDRESS>wrote:

Bluntman and chronic?
On Dec 26, 2017 8:43 PM, "Mike Mulchrone"<EMAIL_ADDRESS>wrote:

https://ionicframework.com/
https://www.xamarin.com/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mtmulch/mulchronedigital.com/issues/51, or mute
the
thread
<https://github.com/notifications/unsubscribe-auth/ATe95FrQnhKPDR_tf-
ioOVvBv7hrXHZOks5tEa7ogaJpZM4RNIBK>
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/mtmulch/mulchronedigital.com/issues/
51#issuecomment-354100900>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APhUUY-
Kr3e1Jbts5TvD1wnuYUBECx7Nks5tEit-gaJpZM4RNIBK>
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mtmulch/mulchronedigital.com/issues/51#issuecomment-354107443,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATe95Axd3O3T465ic19Df1RksuYXK6-Tks5tEjjOgaJpZM4RNIBK
.

You need sleep sir.

I've been going to bed at 9pm and waking up at 4.
On Dec 27, 2017 7:59 AM, "Mike Mulchrone"<EMAIL_ADDRESS>wrote:

You need sleep sir.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mtmulch/mulchronedigital.com/issues/51#issuecomment-354117835,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATe95LznPVenQVVQabmef2cHHRBUqvSxks5tEk1CgaJpZM4RNIBK
.

https://ionicframework.com/ for sure to keep things consistent. Less content switching on the brain whenever this happens.

https://github.com/mtmulch/mobile.mulchronedigital


Omit username and icon_url fields from request JSON if they are empty

This is to support keyword alerts in Slack (see #42)
I think I went through all the contribution steps, but let me know if anything is missing! Thanks.

Included in 2.3.1 on splunkbase, thanks!


array_agg display incorrect (confusing) output for empty result {null}

System information:

Operating system (distribution) and version:

OS: Ubuntu 18.04 bionic
Kernel: x86_64 Linux 4.15.0-54-generic

DBeaver version 6.1.2 community edition
Java version

➤ java --version
openjdk 11.0.3 2019-04-16
OpenJDK Runtime Environment (build 11.0.3+7-Ubuntu-1ubuntu218.04.1)
OpenJDK 64-Bit Server VM (build 11.0.3+7-Ubuntu-1ubuntu218.04.1, mixed mode, sharing

Additional extensions - Excel

Connection specification:

Database name and version: postgres (PostgreSQL) 9.6.1
Driver name PostgreSQL
Do you use tunnels or proxies (SSH, SOCKS, etc)? tested with SSH and without

Describe the problem you're observing:
array_agg display incorrect (confusing) output for empty result {null}
Steps to reproduce, if exist:
Execute next SELECT
select array_agg(a) FROM (VALUES (null, 1)) AS _ (a, id) GROUP BY id;

Current output

Expected output (from psql):
postgres=# SELECT array_agg(a) FROM (VALUES (null, 1)) AS _ (a, id) GROUP BY id;
 array_agg
-----------
 {NULL}
(1 row)

p.s.
Output with type cast

Include any warning/errors/backtraces from the logs

it seems that issue is already fixed in 7.0.0


feat: get index field types

Issue
https://github.com/gravitee-io/issues/issues/5102
Description
Get index field types. It will allow us to create the good query when we update a mapping template
Additional context

Gravitee.io Automatic Deployment
🚀 A prerelease version of this package has been published on Gravitee's private artifactory, you can:

use it directly by updating your project with version: 6.1.0-apim-5102-get-field-types-SNAPSHOT
download it from Artifactory here

:tada: This PR is included in version 6.1.0 :tada:
The release is available on:

6.1.0
GitHub release

Your semantic-release bot :package::rocket:


engine: fix a bug in analytics_settings() propagation

Hello @jazzdan,
Please review the following commits I made in branch nicks/analytics:
3c3ac11d4f331cc9f13937b6abbafbd57a6e180a (2020-02-17 01:18:40 -0500)
engine: fix a bug in analytics_settings() propagation
Code review reminders, by giving a LGTM you attest that:

Commits are adequately tested
Code is easy to understand and conforms to style guides
Incomplete code is marked with TODOs
Code is suitably instrumented with logging and metrics

ping!


    Failures:

      test/unit/Cardano/Wallet/Primitive/TypesSpec.hs:304:9:
      1) Cardano.Wallet.Primitive.Types.Ranges Range (succ a) b `isSubrangeOf` Range a b
           *** Gave up! Passed only 99 tests; 3 discarded tests:
           76% has upper bound
           71% has lower bound
           54% is finite

      To rerun use: --match "/Cardano.Wallet.Primitive.Types/Ranges/Range (succ a) b `isSubrangeOf` Range a b/"

      test/unit/Cardano/Wallet/Primitive/TypesSpec.hs:313:9:
      2) Cardano.Wallet.Primitive.Types.Ranges Range a (pred b) `isSubrangeOf` Range a b
           *** Gave up! Passed only 99 tests; 3 discarded tests:
           76% has upper bound
           71% has lower bound
           54% is finite

      To rerun use: --match "/Cardano.Wallet.Primitive.Types/Ranges/Range a (pred b) `isSubrangeOf` Range a b/"

Additional context: https://github.com/input-output-hk/cardano-wallet/pull/915#issuecomment-546278537
Steps to Reproduce
To rerun use: --match "/Cardano.Wallet.Primitive.Types/Ranges/Range (succ a) b `isSubrangeOf` Range a b/"

To rerun use: --match "/Cardano.Wallet.Primitive.Types/Ranges/Range (succ a) b `isSubrangeOf` Range a b/"

Expected behavior
Should pass.
Actual behavior
They fail.

Resolution Plan

PR

Number
Base

#?
develop

QA

@jonathanknowles please remember to send this to QA if now fixed.

@jonathanknowles please remember to send this to QA if now fixed.

Done.

lgtm


MessageDialog fixes

Added back Text wrapping for MessageDialog Message (#1766) and added
styling to all MessageDialog buttons (#1755).

@soend the first one is ok, the second change not, the buttons are good so, negative buttons should be different.
/cc @flagbug


Plzm cosmos db powershell sql

Description
Rewrite Cosmos DB SQL create example to use new Az.CosmosDB cmdlets.
Checklist

[X] This pull request was tested on both of:

[X] PowerShell 5.1 (Windows)
[X] PowerShell 6.x (Latest PowerShell)

[X] Scripts do not contain static passwords or other secret tokens.
[X] All Azure resource identifiers which must be universally unique are guaranteed to be so.

Testing information
Platform: Windows 10 1909, WSL Ubuntu 18.04
Powershell version: 5.1, 6.2, 7.0
Az version: 3.5.0

#sign-off

#please-close
Replacing with larger PR


Header image and navbar on small screen

@bebatut I would like to work on this issue. :)

Hi @bebatut .
I'd love to work on this issue, please. 👍🏻

I'd love to work on this project if given access to it thank you

Hello @bebatut ,I'm an outreachy 2022 Applicant,I'd love to work on this issue.

Hello @bebatut , I'm Astrid Liu and I'm an outreachy applicant. I'd love to work on this issue. Thank you!

I’ll love to work on this issue @bebatut
My name is Nancy (an Outreachy applicant), a UX designer. Thank you

hello @bebatut my name is Jolade, an outreachy applicant, I am currently working on this issue. Thank you

Got it! Thank you so much.
On Mon, 10 Oct 2022 at 1:08 PM, Bérénice Batut @.***>
wrote:

As defined in the OLS Outreachy contribution guide
https://docs.google.com/document/d/1HP7qTBe-6YrCUYAVkrT441rGtF6zxzNbbz2E5RWQvTM/edit?usp=sharing
,

If someone else has already commented, let them try first
If they don’t update after three days, the issue is “free” again,
and you can pick it up.

@NPDebs https://github.com/NPDebs were the first one to comment here.
Are you still interested to work on this issue?
—
Reply to this email directly, view it on GitHub
https://github.com/open-life-science/open-life-science.github.io/issues/420#issuecomment-1273216559,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXUL2JHORZKZFFJBW3N3LC3WCQBKPANCNFSM6AAAAAAQOTRAPQ
.
You are receiving this because you commented.Message ID:
<open-life-science/open-life-science.github.io/issues/420/1273216559@
github.com>

As defined in the OLS Outreachy contribution guide,

If someone else has already commented, let them try first
If they don’t update after three days, the issue is “free” again, and you can pick it up.

@NPDebs were the first one to comment here. Are you still interested to work on this issue?

Yes, please. @bebatut Thank you! 😊

Hi @bebatut . Here's an update on my progress.
After inspecting this page for some hours, I realised that the problem is not just about the header. The entire page displays abnormal behaviour (excess space on the right) when the viewport width hits 570px.
This is caused by the  section, which overflows from the body. Adjusting the table will result in the expected behaviour.

@bebatut I think you forgot to close this issue. 👀

Nice catch


Missing _attachments system defined property of an item

The rest API (https://docs.microsoft.com/en-us/rest/api/cosmos-db/query-documents#body-1) mentions _attachments property and I've seen it in a database.
Perhaps the property needs to be added to https://docs.microsoft.com/en-us/azure/cosmos-db/databases-containers-items#properties-of-an-item

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d7941d92-a0ea-0f78-12af-7dc8ccb2b1ea
Version Independent ID: d6cc05c7-b724-df22-116f-b8f464293a35
Content: Work with databases, containers, and items in Azure Cosmos DB
Content Source: articles/cosmos-db/databases-containers-items.md
Service: cosmos-db
GitHub Login: @rimman
Microsoft Alias: rimman

@pwl-kdk  Thanks for your feedback! We will investigate and update as appropriate.

We are trying to discourage customers from using attachments in production workloads. The best practice is to store data in the storage and soft-link it from Cosmos DB or store it as Base64 inside a Cosmos container - to take advantage of global replication, consistency, backup-restore and SLAs, that's why the documents reflect this in this manner. Thanks.

@pwl-kdk I hope that answers your question. We will proceed to close this issue now.
If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


Stable optics and camera indices

Please describe the use case that requires this feature.
Minor stylistic request to improve consistency between runs of one production.
Describe the solution you'd like
Define an order (i.e. linked to tel ids)
Additional context

? I thought in python 3.6+ dicts and sets were ordered, but I may be wrong about sets.

Only dicts

I still don't quite see why files with the exact same subarray in them would end up with these keys in a different order - are we sure the example files at the top of this issue have the same subarray description? If not, then the order would not be expected to be the same.
As @maxnoe  said, nobody should rely on it being the same either, as it is an internal mapping to build the SubarrayDescription, not something the user should even care about.

@kosack if you want to know the CPython implementation detail that causes this, it is two things:

set iteration order happens to be ordered by hash
string hashes are randomized between python interpreter sessions:

❯ python -c 'print(hash("Hello, World!"))'
7918248467824148683
❯ python -c 'print(hash("Hello, World!"))'
-2028356294309276154
❯ python -c 'print(hash("Hello, World!"))'
2766964094343225856

Then I think it is a good idea to sort first - having the output change slightly between runs with the same input is certainly unexpected.


id -z/--zero isn't implemented

       -z, --zero
              delimit entries with NUL characters, not whitespace;

id -g -z
is failing with
error: Found argument '-z' which wasn't expected, or isn't valid in this context
As we already have
id -g
is should be easy

I'm working on this.


Auto function comment are not ceated

in case of function defined using assignment, function comments are not generated while press of tab.
var f = function (data) {
}
I don't get comments generated for this method. I am using atom.

I'm having the same issue. v0.7.3

Same here docblockr v0.7.3 atom v1.4.1

I can't reproduce this..
Version 0.7.4 made quite a few changed to the JS function parser, so this my be solved already.
Could you please test if this is still reproducible in Version 0.8.0.

Seems to be working fine now.

Perfect! I will close this issue for now. Feel free to reopen if it occurs again.


Further mod on msvc config cache locking

In the first iteration, we took a read lock in the read case. A fail was observed where the reader took a json decode error, and then tried to remove the cachefile in case it's really corrupt. That failed as the file was "busy" - on Windows removing is essentially writing the file - so take a write lock here too.
This is a tweak to an internal detail that is not yet in an SCons release, so no further changes to CHANGES/RELEASE; no doc impacts.  We don't have a test that can force this case, waiting for CI runs for more info.
Contributor Checklist:

[ ] I have created a new test or updated the unit tests to cover the new/changed functionality.
[ ] I have updated CHANGES.txt (and read the README.rst)
[ ] I have updated the appropriate documentation

When the file lock times-out, an SConsLockFailure exception is raised.
The SConsLockFailure is not handled in either the vc.py read_script_env_cache method (read cache) or the write_script_env_cache method (write cache).
I'm not sure the run should terminate if the lock can't be acquired.  In both cases, it might be better to issue a warning and proceed without the cache.
An abnormal termination of scons can also orphan the lock file (i.e., created but not deleted) which creates problems for future runs (i.e., always time-out).

I'm a little worried if it's that slow that the lock times out, but yes. no effort yet to handle that case.

We can certainly add protocol to try to detect an orphaned lock file... I think the ninja daemon setup has something like this by using the psutil package.  However, I'd like to avoid going down that route until it's more firmly established that ew need to.


Testcafè hangs without errors when there is a temporary network disconnection

Are you requesting a feature or reporting a bug?
Bug
What is your Test Scenario?
The bug appears when launching the tests on a remote machine (Browserstack or similar, remote device) and a temporary network disconnection occurs.
We were able to replicate the issue on two machines in the same LAN using the code attached in the gist below.
What is the Current behavior?
When the network returns the tests won't continue, the browser is frozen and there are no error messages in the testcafè console.
What is the Expected behavior?
When the network returns, we expect the test to continue and either fail with an error, or better pass without errors.
How would you reproduce the current behavior (if this is a bug)?
You should run the attached html file on a local httpserver (we used the "http-server" npm module to achieve that), run the test file we provided with the remote option and disconnect the network for a while. See the other readme.md file in the attached gist for more information.
Provide the test code and the tested page URL (if applicable)
Your website URL (or attach your complete example): https://gist.github.com/mgallo/e563f2a2fd69b8dc0fd6728ff00c991b
Your Environment details:

testcafe version:                   1.2.1
node.js version:                    10.15.0
command-line arguments:  testcafe remote test-spec.js
browser name and version: Chrome 75.0.377.0
platform and version:          MacOS 10.14.4
other:                                   see the readme.md in the gist for additional information

Thank you for the detailed description. I was able to reproduce the issue. This behavior seems incorrect. We need some time to research it. We will reply to you when we have news.


When I scan the C# project with the docker container, there seems to be an error, integer overflow, and no vulnerabilities scanned

[root@MiWiFi-R3600-srv Miniblog.Core]# docker run -v /home/Jonas/Project/Miniblog.Core:/infersharp/binary_path --rm mcr.microsoft.com/infersharp:v1.3 /bin/bash -c "./run_infersharp.sh binary_path; cp infer-out/report.txt /infersharp/binary_path/report.txt"
Processing {binary_path}
Copying binaries to a staging folder...

Code translation started...
Translation stage 1/3: Loading binaries.
Translation stage 2/3: Computing type environment.
Translation stage 3/3: Computing control-flow graph.

Coverage Statistics:

Method successfully translated: 0 (-2147483648%)
Method partially translated: 0 (-2147483648%)
Instructions translated: 0 (-2147483648%)
Instructions skipped: 0 (-2147483648%)
======================================

Code translation completed. Analyzing...

  No issues found

[root@MiWiFi-R3600-srv Miniblog.Core]# docker run -v /home/Jonas/Project/Miniblog.Core:/infersharp/Examples -it mcr.microsoft.com/infersharp:v1.3
root@9facf129f394:/infersharp# ./run_infersharp.sh Examples
Processing {Examples}
Copying binaries to a staging folder...

Code translation started...
Translation stage 1/3: Loading binaries.
Translation stage 2/3: Computing type environment.
Translation stage 3/3: Computing control-flow graph.

Coverage Statistics:

Method successfully translated: 0 (-2147483648%)
Method partially translated: 0 (-2147483648%)
Instructions translated: 0 (-2147483648%)
Instructions skipped: 0 (-2147483648%)
======================================

Code translation completed. Analyzing...

  No issues found

I also find this problem
[root@MiWiFi-R3600-srv Project]# docker run -v /home/Jonas/Project/OrchardCore/:/infersharp/Examples -it mcr.microsoft.com/infersharp:v1.3
root@ffd2c246885c:/infersharp# ./run_infersharp.sh Examples/
Processing {Examples/}
Copying binaries to a staging folder...

Code translation started...
Translation stage 1/3: Loading binaries.
Translation stage 2/3: Computing type environment.
Translation stage 3/3: Computing control-flow graph.

Coverage Statistics:

Method successfully translated: 0 (-2147483648%)
Method partially translated: 0 (-2147483648%)
Instructions translated: 0 (-2147483648%)
Instructions skipped: 0 (-2147483648%)
======================================

Code translation completed. Analyzing...

  No issues found

When I scan the example , this situation will not occured .

When I scan the example , this situation will not occured .

when I scan example ,I can get this result
[root@MiWiFi-R3600-srv Project]# docker run -it mcr.microsoft.com/infersharp:v1.3
root@5972e11cfb91:/infersharp# ./run_infersharp.sh Examples/
Processing {Examples/}
Copying binaries to a staging folder...

Code translation started...
Translation stage 1/3: Loading binaries.
Translation stage 2/3: Computing type environment.
Translation stage 3/3: Computing control-flow graph.

Coverage Statistics:

Method successfully translated: 11 (100%)
Method partially translated: 0 (0%)
Instructions translated: 143 (100%)
Instructions skipped: 0 (0%)
======================================

Code translation completed. Analyzing...

/Examples/Examples/Program.cs:53: error: Dotnet Resource Leak
  Leaked resource sw of type System.IO.StreamWriter in method "Void Program.ResourceLeakIntraproceduralBad()".

/Examples/Examples/Program.cs:78: error: Dotnet Resource Leak
  Leaked resource stream of type System.IO.StreamWriter in method "Void Program.ResourceLeakInterproceduralBad()".

/Examples/Examples/Program.cs:124: error: Dotnet Resource Leak
  Leaked resource p.Examples.Program.SWGlobal of type System.IO.StreamWriter, Leaked resource p.Examples.Program.SRGlobal of type System.IO.StreamReader in method "Void MainClass.Main(String[])".

/Examples/Examples/Program.cs:128: error: Null Dereference
  ``String Program.NullDeReferenceBad()`` could be null (from the call to `Program.NullDeReferenceBad()` on line 128) and is dereferenced.

Found 4 issues
                  Issue Type(ISSUED_TYPE_ID): #
  Dotnet Resource Leak(DOTNET_RESOURCE_LEAK): 3
       Null Dereference(NULLPTR_DEREFERENCE): 1

they can scan the vulnerability.and percent is correct

@chenkehao1998, @Jonas-sci, thanks for reporting this. I should have made the instructions clearer. I will make an update to the doc.
There are two modes running Docker - direct and interactive. You are using the direct mode. In that case, path_to_binary_folder should be a Windows path. For example, C:\project1\bin. If the binaries are already at a Linux path, you can use the interactive mode - ./run_infersharp.sh Examples/ where Examples/ is the path that is relative to the script.

Thanks for your reply!!!
But I have used the interactive mode , the result is still not correct .
I used the command like this.
docker run
-v /home/Jonas/Project/Miniblog.Core:/infersharp/Examples
-it mcr.microsoft.com/infersharp:v1.3

And then ,
./run_infersharp.sh Examples

the file in directory  Examples is my C# project files now.
but the result is
Processing {Examples}
Copying binaries to a staging folder...

Code translation started...
Translation stage 1/3: Loading binaries.
Translation stage 2/3: Computing type environment.
Translation stage 3/3: Computing control-flow graph.

Coverage Statistics:

Method successfully translated: 0 (-2147483648%)
Method partially translated: 0 (-2147483648%)
Instructions translated: 0 (-2147483648%)
Instructions skipped: 0 (-2147483648%)
======================================

Code translation completed. Analyzing...

  No issues found

The Example folder comes with the Docker image. It provides some example binaries that you can try. To run your own binaries, assuming you are using Windows Command Prompt, the exact steps for the interactive mode are:

Run docker run -it mcr.microsoft.com/infersharp:v1.3
Open another Command Prompt, run docker ps -a to find out the container ID. Then run docker cp <your project folder path on Windows> <container_id>:infersharp/<your project folder name>
Go back to the other Command Prompt from step 1 and run ./run_infersharp.sh <your project folder name>

Hi!
I also found this bug. I have run InferSharp 1.4 and InferSharp 1.3 via docker container on two systems: macos 12.0.1 and ubuntu 22.04.01.
I did different launches, I will describe each one separately.

InferSharp 1.4 via docker interactively on macos. Ran ./run_inferharp Examples. Everything works perfectly.

InferSharp 1.4 via docker interactively on ubuntu . Ran ./run_inferharp Examples. I get a known bug:

Code translation started...
Translation stage 1/3: Loading binaries.
Translation stage 2/3: Computing type environment.
Translation stage 3/3: Computing control-flow graph.

Coverage Statistics:

Method successfully translated: 0 (-2147483648%)
Method partially translated: 0 (-2147483648%)
Instructions translated: 0 (-2147483648%)
Instructions skipped: 0 (-2147483648%)

InferSharp 1.4 via docker in direct mode on macos. I built a project with this file using dotnet 6.0.402 on macos . Everything works perfectly.

InferSharp 1.4 via docker in direct mode on ubuntu . I built the same project but using dotnet 6.0.110 in ubutnu . The bug is reproducing.

InferSharp 1.4 via docker in direct mode on ubuntu . I used the results of building a test project from macos. Everything works perfectly. I compiled on macos for different runtimes (linux-x64, osx.12-x64). InferSharp 1.4 was able to analyze all the assembly variants made in macos.

InferSharp 1.3 works correctly through docker (in both modes) on both ubuntu and macos.

I found that the difference is in how assemblies made on macos and ubuntu are loaded. In the second case, the dll's cannot be loaded by this method. A SymbolsNotMatchingException is thrown in the Mono.cecil library. Because of this, the assembly is considered broken and cecil cannot work with it correctly, so none of the methods are loaded.
It is possible that since the release of version 1.3 you somehow affected the logic of loading assemblies, or one of your docker image dependencies was updated in such a way that the loading of dlls built on linux broke.
I will try to debug this problem, but I consider it necessary to tell you everything that I managed to find.

@m-sedl, thank you so much for providing the detailed repro steps!
We recently updated the script to speed up the binary copying process (https://github.com/microsoft/infersharp/commit/bc6fb62d01115a6edc81ad46e15d75934be1fa68). Instead of copying everything from a user-specified folder, the script only copies the .dll and pdb files and flattens the structure.
.NET produces Examples.dll under the Examples/ref folder after dotnet publish. However, it is not the matching .dll file with Examples/Examples.pdb. On Linux, the script probably copied Examples/ref/Examples.dll and Examples/Examples.pdb first, then ignored Examples/Examples.dll. It is probably why you are seeing a SymbolNotMatchingException.
I don't have a Mac, but I am guessing the reason you are not seeing it on MacOS is that the copying behavior is different. It probably copied the matching Examples/Examples.dll and Examples/Example.pdb first, then ignored Examples/ref/Examples.dll.
I made a PR https://github.com/microsoft/infersharp/pull/179 so that the copying behavior becomes consistent across different OSs. Would you mind updating run_infersharp.sh in your local docker container and try again?

@m-sedl, you are probably right. It looks like the crash comes from the Infer backend. But just to be sure, can you try reverting run_infersharp.sh to this commit and run the analysis with the 1.4 bits again?
Please note that we currently do not support MacOS officially, but we will see what we can do to unblock you. If you are still seeing the same issue on MacOS, do you mind sharing the binaries with us, or pointing us to the commit/version of NLog on GitHub so that we can investigate on our side?

@xinshiMSFT, reverting run_infersharp.sh helped. 1.4 version with reverted script worked successfully on NLog project on macos

@m-sedl, thank you! It is probably due to the copy logic then. Good to know that at least you are not blocked.
Can you please share the NLog binaries on your machine with us so that we are sure we are looking at the same binaries? Or if the size is too large or it is not convenient, can you point us to the commit/version of NLog you are using so we can build it ourselves?

Извини за то, что сразу не сбросил ссылку.
commit: fe7ed742c28a179ec96a2c26fc6fc8d60078780b
бинарные файлы, собранные на macos: https://disk.yandex.ru/d/Ns2-3nSvFXcxDA

@xi-liu-ds,
Hmm. Very strange, but I can't reproduce the error. Now everything is working properly. I'm sorry for the inconvenience.
My docker desktop version is 4.12.0
My parameters:

Closing this issue. Please feel free to open a new issue if runs into this problem again.

I had the same error when using Windows 11/Docker, it turns out my .wslconfig looked like this
[wsl2]
memory=2GB
swap=0

After changing it to below all is well
[wsl2]
memory=8GB


[BUG] Receiving different results on Safari, Firefox with App Link.

Description
Created a sample application, deployed it on cloud and opened the provided link on Firefox and Safari.
Steps to reproduce the behaviour:

Create a sample application.
Deploy it using deploy button.
Copy app link using View Application button
Open the app link on Firefox 80.0.1 and Safari 12.1.2.

On Firefox
On Safari
Important Details

Version: Cloud
OS: MacOs 10.14.6
Browser: Firefox 80.0.1 (64-bit).

@visibleajay Thanks for opening this issue!
Can you please give permissions to view the app link on Safari? I'm unable to see the image attached to the issue.

@mohanarpit Done.
Kindly let me know if anything is missing.

App Link wasn't public which threw this error. After making the app-link public, this bug became invalid.


Support high-level interface to list compiled arch

@JohanMabille this one paves the way for runtime detection of supported architecture.


Building binary ivf index 3 times slower since v1.1.14

When running knowhere benchmark, we found since knowhere-v1.1.14,
binary ivf index building time change from 102s to 362s

/assign

it's caused by https://github.com/milvus-io/knowhere/pull/246

Build IVF_FLAT_NM on sift1M, with nlist = [4, 16, 64, 256, 1024]
| threshold = 0 | threshold = 65535 | threshold = 16384
-------|-------------------|--------------------------|-------------------------
nprobe = 4 | 0.180s | 0.136s | 0.151s
nprobe = 16 | 0.155s | 0.160s | 0.157s
nprobe = 64 | 0.350s | 0.328s | 0.330s
nprobe = 256 | 1.303s | 1.301s | 1.278s
nprobe = 1024 | 10.755s | 10.432s | 11.010s

why do we simply change the parameter?
Does this parameter really make sense？
should index build and search use the same parameter?

why do we simply change the parameter?
in #242, you suggest to remove openblas support in knowhere, changing this parameter to a big value is the simplest way to disable openblas.

Does this parameter really make sense？
Yes.

should index build and search use the same parameter?
build and search all the same API knn_L2sqr(), in this API it use "distance_compute_blas_threshold" to decide to use SIMD or BLAS to compute vector distance.

/close


⚠ Bofrost.de has degraded performance

In d0a75dc, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1391 ms

Resolved: Bofrost.de performance has improved in fcdd262.


Modify the testCMV()

In pervious code we skip the compute CMV test, and now it is tested in the DecideTest class, so we can delete the testCMV() in CMVTest

Closed by #95


add GPLv3 license

Signed-off-by: Arnav Gupta<EMAIL_ADDRESS>

that's  cool. time to focus on more important things now @championswimmer !


Update deps paths

Summary: Update the deps resolution path in BUCK depending on oss_depends_on in .buckconfig
Reviewed By: bigfootjon
Differential Revision: D57915321

Seems to be merged


Publish standard modules to npm

It would make it a lot easier to consume this library from standard JS modules if it were also published as JS modules.
Module support is extremely good across current JS environments. All major browsers have supported modules for years, and Node has supported them in the last 3 major versions, and soon to be the last 4 majors and last 2 LTS's. All bundlers also automatically support consuming dependencies published as modules and will convert them to whatever output format the user chooses.

Any chance of this happening? Not being published as JS modules makes it difficult to use from projects that only use standard modules.

I'd happily make a PR for this too.

@justinfagnani  Yes, can you submit a PR?  Thanks

@jhlywa I have one incoming!


Fix using bare raise_error matcher

I fix some warnings on rspec

This is great, thanks!  If you look at the Travis build (click on "Details" for the failing check above) you'll see that jRuby isn't passing because there's one case where you're specifying ArgumentError but it's giving something else.  Could you try changing lib/neo4j-embedded/embedded_node.rb on line 171 to this:
fail "Expected to only find one relationship from node #{neo_id} matching" if iter.has_next

I think that was copy/pasted from CypherNode and so it wasn't quite right

This is great, thanks!  If you look at the Travis build (click on "Details" for the failing check above) you'll see that jRuby isn't passing because there's one case where you're specifying ArgumentError but it's giving something else.  Could you try changing lib/neo4j-embedded/embedded_node.rb on line 171 to this:
fail "Expected to only find one relationship from node #{neo_id} matching" if iter.has_next

I think that was copy/pasted from CypherNode and so it wasn't quite right

@cheerfulstoic I am sorry for late reply.
I will try it.

I modified this PR for passing test.
And, I was change to explicitly raising ArgumentError.

Awesome, thanks!  Looks like it's failing for jruby-1.7.20 because of a Gemfile issue, but I should be able to fix that pretty quickly after mereg

Thank you for merging :star:

Thanks for contributing! :metal:


Error 404

Hi , the integration can't download the data.
The log:
Version
1.3.1
Username
<EMAIL_ADDRESS>Pce
.................
ErrorMessages
Failed to query PyGazpar library for frequency=daily. The exception has been raised: Traceback (most recent call last): File "/config/custom_components/gazpar/sensor.py", line 147, in update_gazpar_data client.update() File "/usr/local/lib/python3.10/site-packages/pygazpar/client.py", line 54, in update self.__updateLiveMode() File "/usr/local/lib/python3.10/site-packages/pygazpar/client.py", line 114, in __updateLiveMode self.__downloadFile(session, downloadUrl, self.__tmpDirectory) File "/usr/local/lib/python3.10/site-packages/pygazpar/client.py", line 167, in __downloadFile response.raise_for_status() File "/usr/local/lib/python3.10/site-packages/requests/models.py", line 1021, in raise_for_status raise HTTPError(http_error_msg, response=self) requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://monespace.grdf.fr/api/e-conso/pce/consommation/informatives/telecharger?dateDebut=2019-11-21&dateFin=2022-11-20&frequence=Journalier&pceList[]=152531988682 , Failed to query PyGazpar library for frequency=weekly. The exception has been raised: Traceback (most recent call last): File "/config/custom_components/gazpar/sensor.py", line 147, in update_gazpar_data client.update() File "/usr/local/lib/python3.10/site-packages/pygazpar/client.py", line 54, in update self.__updateLiveMode() File "/usr/local/lib/python3.10/site-packages/pygazpar/client.py", line 114, in __updateLiveMode self.__downloadFile(session, downloadUrl, self.__tmpDirectory) File "/usr/local/lib/python3.10/site-packages/pygazpar/client.py", line 167, in __downloadFile response.raise_for_status() File "/usr/local/lib/python3.10/site-packages/requests/models.py", line 1021, in raise_for_status raise HTTPError(http_error_msg, response=self) requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://monespace.grdf.fr/api/e-conso/pce/consommation/informatives/telecharger?dateDebut=2019-11-21&dateFin=2022-11-20&frequence=Hebdomadaire&pceList[]=152531988682 , Failed to query PyGazpar library for frequency=monthly. The exception has been raised: Traceback (most recent call last): File "/config/custom_components/gazpar/sensor.py", line 147, in update_gazpar_data client.update() File "/usr/local/lib/python3.10/site-packages/pygazpar/client.py", line 54, in update self.__updateLiveMode() File "/usr/local/lib/python3.10/site-packages/pygazpar/client.py", line 114, in __updateLiveMode self.__downloadFile(session, downloadUrl, self.__tmpDirectory) File "/usr/local/lib/python3.10/site-packages/pygazpar/client.py", line 167, in __downloadFile response.raise_for_status() File "/usr/local/lib/python3.10/site-packages/requests/models.py", line 1021, in raise_for_status raise HTTPError(http_error_msg, response=self) requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://monespace.grdf.fr/api/e-conso/pce/consommation/informatives/telecharger?dateDebut=2019-11-21&dateFin=2022-11-20&frequence=Mensuel&pceList[]=152531988682
Hourly
Daily
Weekly
Monthly
Yearly
I see in the log the PCE number it is not the one I enter in configuration. Why?
Pat

Hello, be sure you have put some quotes around your PCE number in your configuration. Something like that:
sensor:
- platform: 'gazpar'
  username: '***'
  password: '***'
  pce_identifier: 'xxxxxxxxx'
  tmpdir: '/tmp'
  scan_interval: '01:00:00'

Let me know !

Hi,
Thanks, the quotes was the problem.
I'm a newbie in y'all.
Have a good day
Regards
Pat


Call to virtual method 'basic_pstreambuf::sync' during destruction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall]

Hello,
I have written the wrapper function below
template <typename... CmdArgs>
inline std::pair<int, std::string> system_call(const std::string& cmd, CmdArgs&&... cmd_args) {
    auto cmd_str = fmt::format(fmt::runtime(cmd), std::forward<CmdArgs>(cmd_args)...);

    redi::ipstream pipe{};

    // NOLINTNEXTLINE(cert-env33-c) Try no linting to make clang tidy happy
    pipe.open(cmd_str, redi::pstreams::pstdout | redi::pstreams::pstderr);

    // Get the full output from our stdout pipe and put possible errors into its own buffer
    std::string result(std::istreambuf_iterator<char>(pipe.out()), std::istreambuf_iterator<char>());
    std::string possible_errors(std::istreambuf_iterator<char>(pipe.err()), std::istreambuf_iterator<char>());

    if (!possible_errors.empty()) {
        NUClear::log<NUClear::WARN>(
            fmt::format("Pipe pstderr non-empty while executing command {}: {}", cmd_str, possible_errors));
    }

    return {possible_errors.empty() ? 1 : 0, result};
}

calling the function yields the following clang tidy static analyser warning (as an error)
/usr/local/include/pstreams/pstream.h:1621:7: warning: Call to virtual method 'basic_pstreambuf::sync' during destruction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall]
      sync(); // this might call wait() and reap the child process
      ^

/src/utilities.hpp:177:56: note: Calling '~basic_ipstream'
        return {possible_errors.empty() ? 1 : 0, result};
                                                       ^
/usr/local/include/pstreams/pstream.h:490:9: note: Calling '~pstream_common'
      { }
        ^
/usr/local/include/pstreams/pstream.h:2284:5: note: Calling '~basic_pstreambuf'
    }
    ^
/usr/local/include/pstreams/pstream.h:1202:7: note: Calling 'basic_pstreambuf::close'
      close();
      ^~~~~~~
/usr/local/include/pstreams/pstream.h:1621:7: note: Call to virtual method 'basic_pstreambuf::sync' during destruction bypasses virtual dispatch
      sync(); // this might call wait() and reap the child process

I made clang tidy happy by making pipe a static variable, which is not really ideal in my humble opinion. I have another bit of code that uses pstreams in a similar way but it is in a class as a private member variable (and I have not encountered this problem in that implementation) so my guess is that this problem is life time / scope related. Are there any proper fixes I can implement on my side?
Thank you very much in advance!!

The code is correct, non-virtual dispatch is what's wanted there. But I'll add a workaround to stop the earning. Making it a qualified call will make it clear it's non-virtual:
basic_pstreambuf::sync();

Isn't this an exact duplicate of #7 which was fixed by 92e3207716804454690ab937c7bbbfb9e51c8b1c in 2021?

Isn't this #7 which was already fixed by 92e3207716804454690ab937c7bbbfb9e51c8b1c ?
It looks like you're using an old version of the code.

Thank you, I'll try and pull a new version of the code and will close this issue if that works.

I've just checked and I have pulled the code from Release version 1.0.3 in SourceForge. Is this fix in that version?

No, you'll have to get the code from Git. You can just download the https://github.com/jwakely/pstreams/blob/master/pstream.h file.
I suppose I should do a 1.0.4 release...

Hi, it looks like https://github.com/jwakely/pstreams/archive/refs/tags/RELEASE_1_0_3.tar.gz contains the fix so I'll just pull from that. I was a bit confused since I assumed that the version for this release was similar to the latest SourceForge one, but this works perfectly for me.

Yeah, it should be the same ... I'm a bit confused what's happened with the tags on github, they don't seem to match the releases. I'll look into it.

I figured out what happened, it was messy.
I made a new release which should be consistent everywhere. Maybe I should just stop putting releases on sourceforge and then there's a single source of truth.

We have started pulling from the git releases so removing sf wont affect us but I think doing what's simplest and easiest for you is the best course of action :)) Thanks again!!!


Filter Large Dataset Entry by Entry

Feature request
I am not sure if this is a new feature, but I wanted to post this problem here, and hear if others have ways of optimizing and speeding up this process.
Let's say I have a really large dataset that I cannot load into memory. At this point, I am only aware of streaming=True to load the dataset. Now, the dataset consists of many tables. Ideally, I would want to have some simple filtering criterion, such that I only see the "good" tables. Here is an example of what the code might look like:
dataset = load_dataset(
    "really-large-dataset",
    streaming=True
)
# And let's say we process the dataset bit by bit because we want intermediate results
dataset = islice(dataset, 10000)

# Define a function to filter the data
def filter_function(table):
    if some_condition:
        return True
    else:
        return False

# Use the filter function on your dataset
filtered_dataset = (ex for ex in dataset if filter_function(ex))

And then I work on the processed dataset, which would be magnitudes faster than working on the original. I would love to hear if the problem setup + solution makes sense to people, and if anyone has suggestions!
Motivation
See description above
Your contribution
Happy to make PR if this is a new feature

Hi ! you can do
filtered_dataset = dataset.filter(filter_function)

Jumping on this as it seems relevant - when I use the filter method, it often results in an OOM (or at least unacceptably high memory usage).
For example in the following notebook, we load an object detection dataset from HF and imagine I want to filter such that I only have images which contain a single annotation class. Each row has a JSON field that contains MS-COCO annotations for the image, so we could load that field and filter on it.
https://colab.research.google.com/drive/1N_rWko6jzGji3j_ayDR7ngT5lf4P8at_#scrollTo=a3y9SxvwNd1X
The test dataset is only about 440 images, probably less than 1GB, but running the following filter crashes the VM (over 12 GB RAM):
import json
def filter_single_class(example, target_class_id):
  """Filters examples based on whether they contain annotations from a single class.

  Args:
    example: A dictionary representing a single example from the dataset.
    target_class_id: The target class ID to filter for.

  Returns:
    True if the example contains only annotations from the target class, False otherwise.
  """
  if not example['coco_annotations']:
    return False

  annotation_category_ids = set([annotation['category_id'] for annotation in json.loads(example['coco_annotations'])])

  return len(annotation_category_ids) == 1 and target_class_id in annotation_category_ids

target_class_id = 1
filtered_dataset = dataset['test'].filter(lambda example: filter_single_class(example, target_class_id))

Iterating over the dataset works fine:
filtered_dataset = []
for example in dataset['test']:
  if filter_single_class(example, target_class_id):
    filtered_dataset.append(example)

It would be great if there was guidance in the documentation on how to use filters efficiently, or if this is some performance bug that could be addressed. At the very least I would expect a filter operation to use at most 2x the footprint of the database (i.e. worst case would be a duplicate copy with all entries retained).

You can try passing input_columns=["coco_annotations"] to only load this column instead of all the columns. In that case your function should take coco_annotations as input instead of example

If your filter_function is large and computationally intensive, consider using multi-processing or multi-threading with concurrent.futures to filter the dataset. This approach allows you to process multiple tables concurrently, reducing overall processing time, especially for CPU-bound tasks. Use ThreadPoolExecutor for I/O-bound operations and ProcessPoolExecutor for CPU-bound operations.


Prepare for Release v4.0.0-rc1

Updates version
Updates CHANGELOG

Following Java, I went with rc1 instead of rc4 so that the JS bindings would have their own release candidate numbering.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
531

Relevant Lines:
531

💛  - Coveralls


What is the point of the GetHeadset method in the PlayerPresence script?

Is this legacy stuff that has been superseded by the device finder?

If this is removed then the TouchpadWalking script doesn't need a reference to the player presence script


Add built-in rules for ident, identStart, identPart

It would be nice to have some built-in rules for identifiers, so that we have a sensible default for people building new languages in Ohm. For reference, I took a look at a few different languages to see if any of them use the Unicode ID_Start/ID_Continue. Here are the results:

ES6 (spec): Yes
Rust (spec): Yes

Uses XID_start and XID_continue

Python3 (spec): Yes

Uses XID_start and XID_continue

F# (spec): No

identStart: Ltmou | Nl | "_"
identPart: identStart | "0..9" | Pc | Mn | Mc | Cf

Swift (spec): No

Just specifies a bunch of Unicode ranges, not sure what they correspond to

Go (spec): No

identStart: Ltmou
identPart: identStart | Nd

Scala (spec): No

identStart: Ltmou | Nl | "$" | "_"
identPart: identStart | "0..9" | "_"

Not sure this makes things any clearer, but I thought it would be good to have a few data points.

One more note: it seems that ID_Start is a subset of (Ltmou | Nl), and doesn't include _ or $. So I'm a bit confused that the Rust and Python specs say that identifiers must begin with an XID_start character.

According to http://unicode.org/reports/tr31/#Specific_Character_Adjustments, _ and $ are optional characters for ID_Start. ES5/ES2015 adds those two characters to ID_Start but Python or Rust might not do so. Since Ohm does not allow to exclude characters when overriding, I would suggest we go with the "clean" ID_Start and ID_Continue implementation and have e.g. ES6/ES2015 extend those with the extra characters.

One more thing I stumbled upon yesterday, is that ident is already heavily used in grammars (Ohm itself uses it, so do some of @alexwarth teaching grammars). It would be a bigger change (bootstrapping involved) to change this and on top of that I am not sure we would want rule names to span the full spectrum of (Unicode) identifier names (some of them not being valid in ES5).

Re: _ and $, I'm a bit confused by that Unicode document, but I think I've figured it out. From http://unicode.org/reports/tr31/#R1:

Another such profile would be to include some set of the optional characters, for example:

Start := XID_Start, plus some characters from Table 3

...where Table 3 contains exactly _ and $. So what this tells me is that _ and $ do NOT have the XID_Start property, however, this standard suggests that some languages may want to explicit add those as valid identStart characters. The unicode-9.0.0 package seems to confirm this interpretation:
> var xid_start = require('unicode-9.0.0/Binary_Property/XID_Start/regex');
undefined
> !!xid_start.exec('a')
true
> !!xid_start.exec('_')
false
> !!xid_start.exec('$')
false

What confuses me about Python and Rust is that they do both allow leading underscores in variable names...yet claim that identStart is just XID_Start. Oh well.
Anyways, now that I feel like I understand this...I agree with what you said, that our identStart rule should be "clean" and not include _ and $.

Re: ident: I don't think it's a problem to introduce ident as a built-in rule. It would be a breaking change, but anyone who upgrades would get an error at grammar instantiation time, and could just change their definition to use :=.
But now that I think about it, maybe it's better to not include a built-in ident rule, because of things like $ and _, and other similar exceptions (- and * in Lisp, ' in ML, ? in Ruby, etc.). However I still think unicodeIdStart and unicodeIdContinue would still be useful.
Thoughts?

Well, we could put in an ident rule and describe it in the documentation. It should use identStart and identPart with just reference unicodeIdStart and unicodeIdContinue by default. Any language that needs extra characters, like _ or $ could extend the identStart rule to include those as well.

Yes, that would work. However, I'd lean towards not doing it that way because we can't really provide a sensible default, and basically every grammar would need to override identStart.
This would mean that you'd need to understand rule overriding to make almost any useful grammar, which is not the case right now. (Hmmm, though I suppose to support comments you do need to extend the space rule. But ident is a bit trickier since you need to understand that the hidden definition of ident begins with identStart.)

I agree. My vote would be to not have a built-in ident rule (because as Pat said, we can't provide a sensible default) but keep unicodeIdStart and unicodeIdContinue.

Currently, there is no default. Everyone has to implement an identifier rule on his/her own.
With ident & co. there would be a default. A good one, that sometimes would need be extended, especially if you try to build a parser for an existing language and obsess over 100% correctness (in which case you should/need to know about overriding/extending).

While I agree that a built-in ident rule would be convenient, I worry about the problems and confusion that may result from programmers not fully understanding what it does. E.g., suppose I want to use $ as an operator in a new language,
Exp = ident `$` ident

but "for some reason" I can't parse foo$bar as an Exp. WAT!?!?
IMO the small amount of additional work that goes into writing your own ident rule more than pays for itself because it avoids this kind of confusion.


Create Nomad-based Hypervisor image

Software necessary

Nomad
Consul
Envoy (compatible version with Consul)
docker/containerd
qemu

Tried to install Qemu V7 on Ubuntu using a Bazel-compiled version, but wasn't able to get this to work. So installed Qemu using aptitude for now.


Transaction support

This PR adds transaction support to ZK copy, allowing the user to specify the number of operations in the transaction with -b/--batchSize.
We've tested this with up to 10,000 operations per transaction with 100,000 nodes and seen around a 6x write speedup.
Another optimization for users wanting to perform a copy multiple times is the -m/--mtime flag, which allows zkcopy to ignore nodes older than the specified mtime, skipping any writes that may have been performed by a previous run of zkcopy. To aid this, zkcopy logs the maximum mtime of the copied nodes at runtime.
This PR also refactors the CLI arg parsing to use picocil, removing a lot of manual parsing and type-checking.

Thanks, looks awesome!
I'd like to write few tests for current version before merging PR to make sure nothing is broken, using https://www.testcontainers.org. Probably will do it on a weekend.

I've added a bunch of JUnit unit-tests around the code we've changed. Not yet looked into the testcontainers setup, but it looks interesting.
The unit tests required a bit of refactoring in order to pass dependencies in.
We (myself and @ronin13) have also worked on cleaning up the zookeeper server object once zkcopy is finished, and raised the session timeout so that large transactions and reads don't fail.

I've just added an initial testcontainers integration test. Really nice library, thanks for the headsup @kshchepanovskyi
The new itest highlighted that the connections to the source ZK were still not being closed so I've scrapped the finalize() implementation and exposed a way of closing the ZooKeepers from the ThreadFactory.


[HIPIFY] I accomplish HIP code to CUDA code reference Hipify, but meet some error when I run code by cuda_runtime_api.h

this is my github link about cudify:
https://github.com/wangzy0327/Hip-conversion

Hi @wangzy0327,
So, you converted HIP to CUDA (not vice versa) and tried to compile the resulting CUDA source (by what?), got errors, and decided to file an issue to HIPIFY tools? What do you want from the HIPIFY team?

Sorry,I cannot describe it clearly.
I compile the resulting CUDA source by regular expression reference hipify-perl.
I want to know the limitations of conversion by regular expression. ep hipify-perl(what contents cannot convert?)

Well, you may provide both your source files. From the last screenshot, it looks like you are mixing CUDA and HIP APIs in your CUDA source.

Yes,I fix some bugs in my code.
This is my test source files
https://github.com/zjin-lcf/HeCBench/blob/master/atomicCAS-hip/main.cu
https://github.com/zjin-lcf/HeCBench/blob/master/atomicCAS-cuda/main.cu
And convert file code and execute results

I've successfully hipified your atomicCAS-cuda to HIP both by hipify-perl and hipify-clang. The HIP source obtained by hipify-clang is identical to your atomicCAS-hip.
Both atomicCAS-cuda and atomicCAS-hip was successfully compiled by hipcc.
The segfault you got when running atomicCAS-hip can happen for many reasons.
[Conclusions]

The issue is not related to HIPIFY tools.
You may file an issue to the HIP repo by providing your core dump log and info about ROCm HIP installed.
This issue is closing as unrelated.


Add --serverstring command line flag (see issue #197)

Hi, this adds a new (optional) command line flag, which enables the user to modify the server string:
--serverstring STRING     Descriptive string for the PostgREST server (default: "postgrest/<IP_ADDRESS>")

I'm sorry I didn't opened my PR sooner as I was working on the same problem! (now in #202)
I'd argue that serverstring is not consistent with the other variables (dash separated).
Maybe server-string?
My PR has a slightly larger aim though: to avoid hard-coding the string "postgrest" within the codebase

No worries. Since these modifications are also covered by your PR, I think @begriffs should close this one and go on with yours! There are enough other open issues to work on ;-)

@jetho I'll close the PR, thanks for your investigation.


feature(dsp) Add context to details

Add context to details to make it easier to run evaluations.
We want want to make it easier to retrieve context outside of dspy retriever

Hi @Vasilije1990 , thanks for the PR. This addition is fine to me, but it seems like in you want to use 'context' within evaluation, and my understanding is this is the 'gold context' from the data, and not actually retrieved context to be used for RAG evaluation. lmk if I'm misinterpreting.

It's a correct estimate. What we are trying to do is to enrich and process gold context, in order to have an enrichment layer. This enrichment layer then evaluates vs qa pairs.
In this way, we can see how good our enrichment does the job vs vanilla gold context.
Hope that makes sense.
For more details please check here: https://github.com/topoteretes/cognee


WFLY-17010 Upgrade to Hibernate Search 6.1.7.Final

https://issues.redhat.com/browse/WFLY-17010
This version has been tested to work with Hibernate ORM 6.1 (which WildFly recently upgraded to).
https://in.relation.to/2022/08/04/hibernate-search-6-1-6-Final
https://in.relation.to/2022/09/16/hibernate-search-6-1-7-Final

Thanks @yrodiere


Cherrypick Adding LTE List APIs (#1100)

What does this Pull Request accomplish?
This cherry-picks #1100 into the releases/2.7 branch to create a 2.7.1 release version of grpc-device
Why should this Pull Request be merged?
This change was too late to be added to the 2.7 release of grpc-device. Doing an off cycle release so that clients can use the changes easier.
What testing has been done?
PR system tests

After discussion it is probably easier to just create a 2.8 release.