Use CRD v1 API for KafkaChannel, KafkaSource and KafkaBinding

CRD v1beta1 API is deprecated and will be removed in k8s 1.22.
Similar to https://github.com/knative/eventing/pull/3360.
Webhook API bump in a follow-up.
Proposed Changes

Use CRD v1 API for KafkaChannel, KafkaSource and KafkaBinding

Release Note

- 🎁 Add new feature
KafkaChannel CustomResourceDefinition now uses apiextensions.k8s.io/v1 APIs

/cc slinkydeveloper matzew

/hold
we need upgrade tests for that
I think @aliok has some reference GH issue for this, what all needs to be done

@matzew, would you mind helping me understand why?
To clarify, I'm changing the CRD apiVersion (apiextensions.k8s.io/v1), not adding the KafkaChannel v1.

If we tackle this - can we also tackle the source ?
Does it work when applying the V1 based version on-top of a v1beta version?  and than "rolling back from V1 to beta` ?
I think when I did that for "eventing" repo, the tests there were useful

@pierDipi  Getting back to this.
We we structure those CRDs, like we have them on "eventing" repo ?
Like:

have the versions after the group (see https://github.com/matzew/eventing/blob/3974f6c67372dbc02c2fb2a0c024390ea5725553/config/channels/in-memory-channel/300-in-memory-channel.yaml#L25-L56)
have names, scope at the end, before the conversion

Can we also have the same lifting for the binding, the source and the distributed channel?

Does that make sense @pierDipi  ?

@matzew it makes sense to me.

/retest

@pierDipi I think this needs a rebase

Flaky, I opened an issue: https://github.com/knative-sandbox/eventing-kafka/issues/218
/retest

VEry cool!

Seem fine to me!   I had the same questions regarding conversionReviewVersions and so learned something from the conversation above ; )

/lgtm
/assign for @aliok to approve and unhold

/lgtm
/approve

/unhold


Migration Guide

Problem description
Describe the current state of affairs and why it needs to change.
Requirements
Create a Migration plan.
Definition of done
How do we know we've fully dealt with it?
Acceptance criteria
What are the criteria by which we determine if the issue has been resolved?

@anvabr Speak to Max and Wes on requirements of Migration plan


Improve mouse input event class reference

The value of global_position being 0,0 if you're not using Control._gui_input was a bug that was fixed at some point. The value not updating if the mouse isn't over the current control is something I noticed while testing that. Closes https://github.com/godotengine/godot-docs/issues/5464

Fixed.

Thanks!

Cherry-picked for 3.5.

Cherry-picked for 3.4.3.


Add file size and count for directories

Intent
The Files API populates the size field for directories with a total size of all contained files. There is a new fileCount field containing the count of files (not directories).
Type of Change

[ ] Bug Fix

[x] New Feature

[ ] Breaking Change

[ ] Documentation

[ ] Refactor

[ ] Tooling

Automated Tests
Added a test for this.
Directions for Reviewers
Run the agent, and access /api/configurations/$NAME/files.
Checklist

[ ] I have updated CHANGELOG.md to cover notable changes.

Should this one be targeting the branch of #2097?


Re-added implicit create feature

This commit reintroduces the implicit create feature to docker.
It also includes new configurable option to control behavior.

Hi @clintonskitson,
Do you want the setting/flag in here to be specific to Docker? Wouldn't this have benefit for other integration drivers? Shouldn't the flag be centralized and the functionality implemented in the registry manager's integration wrapper?

[Current coverage][cc-pull] is 42.57%

Merging [#110][cc-pull] into [master][cc-base-branch] will increase coverage by +<.01%

File ...tor/vbox_executor.go (not in diff) was modified. more

Misses -1
Partials 0
Hits 0

@@             master       #110   diff @@
==========================================
  Files            24         24
  Lines          1791       1790     -1
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            762        762
+ Misses          969        968     -1
  Partials         60         60

Powered by Codecov. Last updated by [81f9bd6...939c34d][cc-compare]
[cc-base-branch]: https://codecov.io/gh/emccode/libstorage/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/emccode/libstorage/compare/81f9bd60dd0892980e0ed669d42e43f8eed1f7a0...939c34d419444163e1bd330414375154c1046c65
[cc-pull]: https://codecov.io/gh/emccode/libstorage/pull/110?src=pr


Change the properties of home and about section

Is your feature request related to a problem? Please describe.
Add transition, change colour ,..etc

you can assign me this task... under gsso-ext and hacktoberfest and level 3 label..


fixing pulling of dotnet sdk

using wget to pull Debian packages from Microsoft for installing dotnet sdk in liunx then running sudo apt-get install to install dotnet sdk. the changes are tested and working repo link is below
https://github.com/ubaidullah-r/dot-net-aws-cdk

Fixes #

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT-0 License.

We realistically need to make sure that it loads the current .NET SDK, rather than the (very old, EOL) 3.1 version.


TestTarget throws a lot of warnings

I'm using XCode 7, iOS9 as target and Swift and everything is working fine.
But my testtarget throws a lot of errrors. I don't do enything with your lib in tests.
My podfile contains the line
link_with 'AppName', 'AppNameTests' to make your lib working with my project. Perhaps this has something to do with it.
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/UIKit-2LM3EQU7VVY4O.pcm: No such file or directory
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/UIKit-2LM3EQU7VVY4O.pcm: No object file for requested architecture
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/Foundation-A3SOD99KJ0S9.pcm: No such file or directory
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/Foundation-A3SOD99KJ0S9.pcm: No object file for requested architecture
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/ObjectiveC-2CD0WTQVXITO7.pcm: No such file or directory
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/ObjectiveC-2CD0WTQVXITO7.pcm: No object file for requested architecture
(null): warning: Could not resolve external type c:objc(cs)NSObject
(null): warning: Could not resolve external type c:objc(cs)UIImage
(null): warning: Could not resolve external type c:objc(cs)UIColor
(null): warning: Could not resolve external type c:objc(cs)UIView
(null): warning: Could not resolve external type c:objc(cs)NSString
(null): warning: Could not resolve external type c:objc(cs)UIFont
(null): warning: Could not resolve external type c:objc(cs)NSArray
(null): warning: Could not resolve external type c:objc(cs)NSBundle
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/UIKit-2LM3EQU7VVY4O.pcm: No such file or directory
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/UIKit-2LM3EQU7VVY4O.pcm: No object file for requested architecture
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/Foundation-A3SOD99KJ0S9.pcm: No such file or directory
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/Foundation-A3SOD99KJ0S9.pcm: No object file for requested architecture
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/CoreGraphics-1YQ59ILDR3NYI.pcm: No such file or directory
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/CoreGraphics-1YQ59ILDR3NYI.pcm: No object file for requested architecture
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/Dispatch-12O7S7HHQXK9N.pcm: No such file or directory
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/Dispatch-12O7S7HHQXK9N.pcm: No object file for requested architecture
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/ObjectiveC-2CD0WTQVXITO7.pcm: No such file or directory
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/ObjectiveC-2CD0WTQVXITO7.pcm: No object file for requested architecture
(null): warning: Could not resolve external type c:objc(cs)UIView
(null): warning: Could not resolve external type c:objc(cs)UIView
(null): warning: Could not resolve external type c:objc(cs)UIImage
(null): warning: Could not resolve external type c:@E@UIViewContentMode
(null): warning: Could not resolve external type c:objc(cs)UIPageControl
(null): warning: Could not resolve external type c:objc(cs)UIButton
(null): warning: Could not resolve external type c:objc(cs)UIScrollView
(null): warning: Could not resolve external type c:objc(cs)NSArray
(null): warning: Could not resolve external type c:@S@CGPoint
(null): warning: Could not resolve external type c:@S@CGRect
(null): warning: Could not resolve external type c:objc(cs)UIImageView
(null): warning: Could not resolve external type c:objc(cs)NSMutableArray
(null): warning: Could not resolve external type c:objc(cs)NSObject
(null): warning: Could not resolve external type c:objc(cs)UIColor
(null): warning: Could not resolve external type c:objc(cs)NSString
(null): warning: Could not resolve external type c:objc(cs)UIFont
(null): warning: Could not resolve external type c:@S@CGSize
(null): warning: Could not resolve external type c:objc(cs)NSCoder
(null): warning: Could not resolve external type c:objc(cs)NSAttributedString
(null): warning: Could not resolve external type c:objc(cs)UILabel
(null): warning: Could not resolve external type c:objc(cs)UITextView
(null): warning: Could not resolve external type c:objc(cs)NSDictionary
(null): warning: Could not resolve external type c:objc(cs)UIInterpolatingMotionEffect
(null): warning: Could not resolve external type c:objc(cs)UIMotionEffectGroup
(null): warning: Could not resolve external type c:objc(cs)NSEnumerator
(null): warning: Could not resolve external type c:objc(cs)UIWindow
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/UIKit-2LM3EQU7VVY4O.pcm: No such file or directory
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/UIKit-2LM3EQU7VVY4O.pcm: No object file for requested architecture
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/Foundation-A3SOD99KJ0S9.pcm: No such file or directory
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/Foundation-A3SOD99KJ0S9.pcm: No object file for requested architecture
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/CoreGraphics-1YQ59ILDR3NYI.pcm: No such file or directory
(null): warning: /Users/username/Library/Developer/Xcode/DerivedData/ModuleCache/284YBPN2V00YK/CoreGraphics-1YQ59ILDR3NYI.pcm: No object file for requested architecture
(null): warning: Could not resolve external type c:objc(cs)UIScrollView
(null): warning: Could not resolve external type c:objc(cs)NSArray
(null): warning: Could not resolve external type c:@S@CGPoint
(null): warning: Could not resolve external type c:@S@CGRect
(null): warning: Could not resolve external type c:objc(cs)UIView
(null): warning: Could not resolve external type c:@S@CGSize

it is gone with XCode 7.1

Still seeing this in Xcode 7.1 myself.


Add helper function for getting the source edits of two strings

This change should make it easier to test two different source by getting SourceEdit with the helper function

I just tried running some random tests on the getConcurrentEdits and it looks like there are still some bugs in it.
For example base = "0a1ab" and new = "bb01d" seems to produce incorrect edits. The following test fails
let base = "0a1ab"
let new =  "bb01d"

let diffs = getConcurrentEdits(from: base, to: new)

let appliedDiffsBase = applyEdits(diffs.edits, concurrent: true, to: base)

XCTAssertEqual(appliedDiffsBase, "??aa?")

The automated test that I used to find this failure was the following (very hacky, the code itself is not ready to be submitted to the repo)
func randomString(length: Int) -> String {
  let letters = "abcd"
  return String((0..<length).map{ _ in letters.randomElement()! })
}

public func testFoo() {
  for i in 0..<100_000 {
    let startLength = Int.random(in: 0..<6)
    let endLength = Int.random(in: 0..<6)

    let base = randomString(length: startLength)
    let new = randomString(length: endLength)

    let edits = getConcurrentEdits(from: base, to: new)
    let editsApplied = applyEdits(edits.edits, concurrent: true, to: base)

    assert(new.count == editsApplied.count)
    for (n, e) in zip(new, editsApplied) {
      assert(e == "?" || n == e)
    }
  }
}

I found String.Difference sometimes produces some unexpected outputs. e.g.
"class".difference(from: "struct")

The function seems to center on the c in "struct" and view other characters as deletions and "lass" as insertions, which is not we expect.
I opened another draft pr to use markers to mark source edits and generate original and edited source (which is a bit like the previous one in the old parser), I think this should be easier to mark and test, also avoid being trapped in the underlying logic of String.Difference.  Maybe we could close this pr and turn to that one. What do you think?

Thanks for catching that. With that explanation, I agree that being explicit about the edits makes a lot of sense. 👍🏽 So, I prefer https://github.com/apple/swift-syntax/pull/1684

Cool. Let's just close this and continue in the other pr.


Handle 30x redirects gracefully

If a bucket is in a different region than configured a 301 redirect is returned. For example:
iex> ExAws.S3.get_object("bucket", "filename") |> ExAws.request
** (CaseClauseError) no case clause matching: {:ok, %{body: "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Error>PermanentRedirect...snip...</Error>", headers: [...], status_code: 301}}
    (ex_aws) lib/ex_aws/request.ex:36: ExAws.Request.request_and_retry/7
    (ex_aws) lib/ex_aws/operation/s3.ex:40: ExAws.Operation.ExAws.Operation.S3.perform/2

It'd be nice to handle this more gracefully and perhaps provide some tips on how to configure the defaults to avoid this.
This was raised in #300 but was unrelated to that issue.

Couple of notes now that I've configured my region and it's now working:

adding a note in the README about default region config would be handy (there wasn't one I could see)
the redirect should be matched in https://github.com/CargoSense/ex_aws/blob/master/lib/ex_aws/request.ex#L36-L53 and return a helpful error reminding the user to check their region config
perhaps trying to follow the redirect as was suggested in #300 but issuing a warning describing that the region is misconfigured?

Happy to put together a PR to achieve the above once the approach is agreed

adding a note in the README about default region config would be handy (there wasn't one I could see - maybe I missed something?)
👍
the redirect should be matched in https://github.com/CargoSense/ex_aws/blob/master/lib/ex_aws/request.ex#L36-L53 and return a helpful error reminding the user to check their region config
👍
perhaps trying to follow the redirect as was suggested in #300 but issuing a warning describing that the region is misconfigured?
👎  Redirects only work for certain AWS resources anyway and are never what you want to be using in production. Fixing the region is like one line of config and solves a whole host of issues.

In this particular case following redirects would be the wrong choice, closing.


Unable to create MR: mrList.go:38: gitlab project not found

I'm looking for some help with this.  I don't know what I'm doing wrong.
I have setup gitlab in a docker container.  I am forwarding into this docker container via apache and a proxy.  I am also running on a non-standard ssh port for git.
$ lab mr list
2018/04/11 16:46:11 mrList.go:38: gitlab project not found

$ git remote -v
origin	ssh://git@git.mydomain.net:10022/mwoodson/repo.git (fetch)
origin	ssh://git@git.mydomain.net:10022/mwoodson/repo.git (push)
upstream	ssh://git@git.mydomain.net:10022/Project/repo.git (fetch)
upstream	ssh://git@git.mydomain.net:10022/Project/repo.git (push)

Any help would be greatly appreciated!

Hi @mwoodson #114 was a similar issue where the the user was running apache and having issues where apache was double encoding the urls. The fix for that was adding (below) to the config.
    AllowEncodedSlashes NoDecode

The issue also has all of our debugging steps in it which might be of help here. Addtionally I've added tests to assert that project names are correctly parsed with custom ssh ports in #131

@zaquestion thanks! I will try to post more debugging.

@zaquestion
Thanks. This took me down a crazy path, and I'm not sure why others haven't experienced this.
Thanks to some tcpdump'ing, I saw what was happening.
curl --header "Private-Token:  SECRET" 'https://git.mydomain.net/api/v4/projects/Project%2Frepo'
The URL was getting re-written to:
GET /api/v4/projects/Project%252Frepo HTTP/1.1\r\n
Notice that '%2F' got re-encoded to '%252F'.
To be clear, I had the option enabled in Apache:
 AllowEncodedSlashes NoDecode
I was able to solve the issue with by adding the option "nocanon" to the end of the proxy pass line:
ProxyPass / http://localhost:10080/ keepalive=On connectiontimeout=10 retry=0 nocanon
Again, I'm not sure why other's aren't reporting this in the gitlab community, or if they are using a different setting to avoid this.
Things seem to be working.  Thanks for pushing me in the right direction.

@mwoodson Gonna close this out, please reopen if you need more and feel free to reach out with any other issues or feature requests


Successfully updated Portuguese content to mention KubeCon 2022 conference

Updated the _index.html file content/pt-br/_index.html to include the
latest links for the Cloud Native Computing Foundation’s  conference.
KubeCon + CloudNativeCon
Although  KubeCon conferences are over but they still have :

KubeCon em Barcelona on Maio 20-23, 2019
KubeCon em Shanghai em Junho, 24-26 de 2019

These have been updated to :

KubeCon na Europa de 16 a 20 de maio de 2022
KubeCon na América do Norte de 24 a 28 de outubro de 2022

Issue Fix : Update Portuguese content to mention KubeCon 2022 conference https://github.com/kubernetes/website/issues/31618

I signed it

/retitle Update Portuguese content to mention KubeCon 2022 conference

/check-cla

/easycla


feat(apps): remove border_overflow from OUTLOOK.exe

[x] I have formatted applications.yaml with komorebic fmt-asc.

Border overflow seems to not be needed on MS Outlook anymore.

The border_overflow might still be useful for people using an old version of outlook


Failed to load plugin libgazebo

When I roslaunch px4 path_planning.launch, errors occur.
[Err] [Plugin.hh:165] Failed to load plugin libgazebo_multirotor_base_plugin.so: libgazebo_multirotor_base_plugin.so: cannot open shared object file: No such file or directory
[Err] [Plugin.hh:165] Failed to load plugin libgazebo_motor_model.so: libgazebo_motor_model.so: cannot open shared object file: No such file or directory
[Err] [Plugin.hh:165] Failed to load plugin libgazebo_motor_model.so: libgazebo_motor_model.so: cannot open shared object file: No such file or directory
[Err] [Plugin.hh:165] Failed to load plugin libgazebo_motor_model.so: libgazebo_motor_model.so: cannot open shared object file: No such file or directory
[Err] [Plugin.hh:165] Failed to load plugin libgazebo_motor_model.so: libgazebo_motor_model.so: cannot open shared object file: No such file or directory
[Err] [Plugin.hh:165] Failed to load plugin libgazebo_gps_plugin.so: libgazebo_gps_plugin.so: cannot open shared object file: No such file or directory
[Err] [Plugin.hh:165] Failed to load plugin libgazebo_mavlink_interface.so: libgazebo_mavlink_interface.so: cannot open shared object file: No such file or directory
[Err] [Plugin.hh:165] Failed to load plugin libgazebo_imu_plugin.so: libgazebo_imu_plugin.so: cannot open shared object file: No such file or directory

However all about gazebo have been installed.
gazebo7/xenial,now 7.0.0+dfsg-2 amd64 [已安装，自动]
  Open Source Robotics Simulator - Binaries

gazebo7-common/xenial,xenial,now 7.0.0+dfsg-2 all [已安装，自动]
  Open Source Robotics Simulator - Shared files

gazebo7-doc/xenial,xenial 7.0.0+dfsg-2 all
  Open Source Robotics Simulator - Documentation

gazebo7-plugin-base/xenial,now 7.0.0+dfsg-2 amd64 [已安装，自动]
  Open Source Robotics Simulator - base plug-ins

libgazebo7/xenial,now 7.0.0+dfsg-2 amd64 [已安装，自动]
  Open Source Robotics Simulator - shared library

libgazebo7-dev/xenial,now 7.0.0+dfsg-2 amd64 [已安装，自动]
  Open Source Robotics Simulator - Development Files

ros-kinetic-gazebo-dev/xenial,now 2.5.19-1xenial-20190607-165824-0800 amd64 [已安装]
  Provides a cmake config for the default version of Gazebo for the ROS distribution.

ros-kinetic-gazebo-msgs/xenial,now 2.5.19-1xenial-20190608-051945-0800 amd64 [已安装]
  Message and service data structures for interacting with Gazebo from ROS.

ros-kinetic-gazebo-plugins/xenial,now 2.5.19-1xenial-20190608-115731-0800 amd64 [已安装]
  Robot-independent Gazebo plugins for sensors, motors and dynamic reconfigurable components.

ros-kinetic-gazebo-ros/xenial,now 2.5.19-1xenial-20190608-134931-0800 amd64 [已安装]
  Provides ROS plugins that offer message and service publishers for interfacing with Gazebo through ROS.

ros-kinetic-gazebo-ros-control/xenial,now 2.5.19-1xenial-20190608-140610-0800 amd64 [已安装]
  gazebo_ros_control

ros-kinetic-gazebo-ros-pkgs/xenial,now 2.5.19-1xenial-20190608-140634-0800 amd64 [已安装]
  Interface for using ROS with the Gazebo simulator.

The problem has been solved, some directories in .bashrc are wrong.

How did you solve it? I'm facing the same issue

How did you solve it? I'm facing the same issue

Please make sure all the paths about ROS are correct in .bashrc.


Add a "verify" command (and remove verification from "query")

(We can't start this until #3 is resolved.)
There should be a verify command that does what wmq --process does (or, post-#3, what whim query --process does).
As part of this work, remove the old --process stuff.

Completed with #20


windows security

my device keeps labelling the app as a virus causing it to crash a lot.
even when i say ""allow on device" it still keeps happening.
is there a way to make this stop.

That is a false positive. The skin changer as well as the injector uses some Win32 API's that aren't commonly used in normal programs. The project is open-source, so you are welcome to compile the skin changer on your own, otherwise disable your antivirus and add the folder with the binaries to the exclusion list.
I'm tired of closing issues like this one is like a 10 issue relating to this issue this week. Please check closed issues before posting an another one.
The program needs Administrator privileges to perform certain actions to ensure that the skin changer works correctly.


No Auth Request for Google Drive - regular ipythonic notebook server?

Hi all,
I'm sure I'm missing something basic, but I was able to successfully clone, install a config and run ipython with the jupyterdrive profile, but when I open it I get a standard ipythonic server, and no auth request for Google Drive. Is there an additional config step not in the readme that I need to do? Sorry this is so basic, but I've been looking for an hour and can't find it. Using py3 and ipython 3
python -c 'import IPython; print(IPython.sys_info())'
Thanks for any suggestions,
Erik
{'commit_hash': 'cbccb68',
 'commit_source': 'installation',
 'default_encoding': 'UTF-8',
 'ipython_path': '/Users/kastman/miniconda/envs/py3/lib/python3.4/site-packages/IPython',
 'ipython_version': '3.1.0',
 'os_name': 'posix',
 'platform': 'Darwin-14.3.0-x86_64-i386-64bit',
 'sys_executable': '/Users/kastman/miniconda/envs/py3/bin/python',
 'sys_platform': 'darwin',
 'sys_version': '3.4.3 |Continuum Analytics, Inc.| (default, Mar  6 2015, '
                '12:07:41) \n'
                '[GCC 4.2.1 (Apple Inc. build 5577)]'}

Hum, I'll clean my system and try the install instruction, things have changed a bit the last few weeks.
Do you get an error in the notebook terminal, or in the browser JS console ?

Nope, no errors at all, either in terminal or through the browser. It seems to work exactly like a standard filesystem-based notebook server.
I did give permissions to coLaboratory (the older version?) - is it possible that there's a check+setup that's being skipped? I don't think this is the case because I was sitting side-by-side with another person who also had this issue and hadn't given permissions, but I thought I'd mention it.

No coLaboratory should not affect that at all. can you $ cat ~/.ipython/profile_default/ipython_notebook_config.json ? and maybe hop on gitter to debug this live ?

I think this may be a doc issue more than anything else - when I went back to try it again and forgot to use a specific profile (i.e. ipython notebook instead of ipython notebook --profile jupyter-drive) I got the authentication request and I believe it's working now. From the readme I thought you had to specifically request the drive add-on with a profile, but I guess that's not the case?
Thanks for your help, I'm closing this issue now. Just an FYI that I was confused, so maybe clarifying the steps for an initial start would help?


Snap version not work

The konstructs's snap version doesn't work on mine Ubuntu computer.

@FaraoneLele Thanks for the bug report. I can reproduce the problem on my set up (I am using ubuntu 16.04) so I'll see  if I can solve it and make an update.
@nsg I am getting a segfault when running the snap from the official source, but it works when I install the one that I build locally.

Stopping the process before it crashes and then attaching gdb to it before continuing yields that it segfaults in glfwCreateWindow. Seems to be related to open gl initialization code.

I get the following in my syslog when it crashes:
Oct 20 10:31:51 xyz kernel: [22544.715299] audit: type=1400 audit(1476952311.828:44): apparmor="DENIED" operation="open" profile="snap.konstructs-client.konstructs-client" name="/usr/share/glib-2.0/schemas/" pid=27195 comm="desktop-launch" requested_mask="r" denied_mask="r" fsuid=1000 ouid=0
Oct 20 10:31:52 xyz kernel: [22545.643136] konstructs[27262]: segfault at 0 ip<PHONE_NUMBER>60c8b8 sp 00007ffef227e740 error 4 in konstructs[400000+2ad000]

I got this, and it works for me.
Oct 20 10:23:02 narsil kernel: [  588.818578] audit: type=1400 audit(1476951782.531:35): apparmor="DENIED" operation="open" profile="snap.konstructs-client.konstructs-client" name="/usr/share/glib-2.0/schemas/" pid=5614 comm="desktop-launch" requested_mask="r" denied_mask="r" fsuid=1000 ouid=0
Oct 20 10:23:03 narsil kernel: [  589.792681] audit: type=1400 audit(1476951783.507:36): apparmor="DENIED" operation="sendmsg" profile="snap.konstructs-client.konstructs-client" pid=5697 comm="konstructs" family="unix" sock_type="dgram" protocol=0 requested_mask="send" denied_mask="send" addr=none peer_addr="@6E7669646961383434396166373200000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000" peer="unconfined"

@petterarvidsson
What if you download the snap manually and install it with --devmode (no apparmor/security)?
store snap: https://068ed04f23.site.internapcdn.net/download-snap/vz0NCdgBzBeFaDlSVYCv7zC08ikS6ImI_3.snap?t=2016-10-21T08:40:51Z&h=c9293608e787ee061f708e784a4818767fa82fe5
(source: https://uappexplorer.com/app/konstructs-client.nsg)

For security, and to prove that they are the same files:
$ sha1sum Downloads/vz0NCdgBzBeFaDlSVYCv7zC08ikS6ImI_3.snap code/konstructs/client/package/konstructs-client_7_amd64.snap
23a301e8b1e2c0908069a527936f1b66071d0f81  Downloads/vz0NCdgBzBeFaDlSVYCv7zC08ikS6ImI_3.snap
23a301e8b1e2c0908069a527936f1b66071d0f81  code/konstructs/client/package/konstructs-client_7_amd64.snap

Oh! I forgot about the download command:
$ snap download konstructs-client
$ sha1sum konstructs-client_3.snap
23a301e8b1e2c0908069a527936f1b66071d0f81  konstructs-client_3.snap

Same problem. So basically it seems I can not run a snap built on your set-up but I can run one built on mine. I thought this was the problem that snap was built to fix?
The sha of the snap I build does not match the sha of yours.

I did a cleanbuild (built inside a container) and released it to the candidate channel, you can try it with:
snap install --candidate konstructs-client

It's just a experiment at the moment, this release is broken on my nvidia based system, but it work on my intel based laptop.

@nsg The candidate version works perfectly for me.

The candidate version doesn't work for me. I give an error:
No protocol specified
Caught a fatal error: Could not initialize GLFW!

@FaraoneLele What type of GPU do you have? Intel, Nvidia, AMD, ...?

Intel

I have spent some time to read about snaps and OpenGL and it looks like there are plenty of people with trouble. I can't for example run this on my Nvidia card at the moment, haven't found a working solution yet.
I will upload a new version to stable, it is built on the same way like the candidate version, but with a few extra tweaks and plenty of debug output. I haven't had the time to research your specific problem yet.

@FaraoneLele I think the graphics card integrated into your CPU might be too old: https://en.wikipedia.org/wiki/Intel_GMA#GMA_3150 It seems to only support up to open gl 2.0 and konstructs requires at least open gl 3.3


Delete .py from resources

[18:55:52]: [Transporter Error Output]: ERROR ITMS-90035: "Invalid Signature. Code object is not signed at all. The file at path [iOS.app/Frameworks/LGButton.framework/GetTTFFontName.py] is not properly signed. Make sure you have signed your application with a distribution certificate, not an ad hoc certificate or a development certificate. Verify that the code signing settings in Xcode are correct at the target level (which override any values at the project level). Additionally, make sure the bundle you are uploading was built using a Release target in Xcode, not a Simulator target. If you are certain your code signing settings are correct, choose "Clean All" in Xcode, delete the "build" directory in the Finder, and rebuild your release target. For more information, please consult https://developer.apple.com/library/ios/documentation/Security/Conceptual/CodeSigningGuide/Introduction/Introduction.html"

This PR is just moving the .py file to a different folder. I don't see any good reason to merge it since that file is not actually linked to any resource. I was considering removing .py files, but then I thought that they may be useful for future updates of the font icons, so I kept them there. Also, the reported issue looks more like a local issue on your project. Library Pod and Example app don't have that dependency. You can check it by downloading/cloning this repo from scratch. If I'm missing something, please add a comment here. Thanks.

because, LGButton/LGButton.podspec, s.resources = "LGButton/Resources/*"
but, the .py file is't a resource,
and i delete the .py file from resources, it's success
or, please delete the .py from resources,
thank you very much

I use fastlane upload the .ipa to testflight
    gym(
      scheme: "iOSPro",
      export_xcargs: "-allowProvisioningUpdates",
      output_directory: "./output",
      export_method:'app-store',
      configuration: 'Release'
    )
    pilot(
      skip_submission: true,
      skip_waiting_for_build_processing: true,
      team_id: "118739734",
      ipa: "./output/iOS.ipa",
      app_identifier: "cc.xx.iOS"
    )

I see your point now, thanks for the clarification.


Feat: Added Contributors Page

closes #209

can you provide a video where have u put the contributors section ?

screen-capture.webm
@Sayak-Bhunia created new page as Contributors

screen-capture (2).webm
@Sayak-Bhunia created a new page for contributors

@Sayak-Bhunia i have one doubt regarding this pr to merge it right ? then why it not showing contributors page on live webstie


Handle this in computed keys of nested scope

We should handle this is nested scopes.
This is required to handle cases like
https://github.com/dudykr/stc/blob/2eadcd5ad1de5e045167ee532e51fc4295b02b7f/crates/stc_ts_type_checker/tests/conformance/es6/computedProperties/computedPropertyNames22_ES6.ts#L1-L9
Currently, we do not use the correct this.
https://github.com/dudykr/stc/blob/2eadcd5ad1de5e045167ee532e51fc4295b02b7f/crates/stc_ts_file_analyzer/src/analyzer/expr/mod.rs#L2425-L2451
We should add parent_for_this() to Scope and call it from the code above.

I found scope.this is not correctly set for ClssExpr and ClassDecl. though I implement parent_for_this(), I still could not get the correct type of this.
https://github.com/dudykr/stc/blob/62d01a370ce28b9cbe2878b6293efff888aad4dd/crates/stc_ts_file_analyzer/src/analyzer/class/mod.rs#L1946-L1947
I try to set scope.this correctly and found it not easy.
The ClassDef type is generated after validating, but to validate this, we need ClassDef while validating.

Yeah, the evaluation order is always the problem.
stc is written in rust, and rustc really hates shared mutable. We may need to store RefCell<ClassDef> in the Scope

Closing as fixed by https://github.com/dudykr/stc/pull/580


Specify email in gha run

Description
Specify email in release GHA run so that we can exclude stats written from these runs.
Type of change
(Delete what does not apply)

Bug fix (non-breaking change which fixes an issue)

Checklist
(Delete what does not apply)

[X] Have you checked to there aren't other open Pull Requests for the same update/change?
[X] Have you added an explanation of what your changes do and why you'd like us to include them?

How about this? https://github.com/faros-ai/faros-community-edition/blob/2e4e98da58cdb10824810996137a05a5721204bf/.github/workflows/pr.yml#L42


typescript defentitions

Please add @types/face-recognition if you need API for this. I can write it to you.

@ksachdeva is currently working on typescript definitions, which is highly appreciated.

Hi @HackPoint ,
There is an example project called "typed"  written in typescript which essentially duplicates the examples. You can use that to see the usage of the definitions
Regards
Kapil

Would be nice not to impose typescript on people though.

It is not imposed. The library is written using javascript. What you get as part of npm install is a file called index.d.ts which vs-code uses to provide intellisense for both typescript and javascript projects.
That being said, even if the project was written using typescript what you would have obtained from npm would be the javascript files.

That is all correct... my point is that using typescript assumes you want to add types to JavaScript... as a javascript developer I don't care about types and I don't like working with typescript. Typescript is an opinioned choice which is why I said "imposed".
Regardless of whether it arrives as Javascript I don't excessive build chains... do we need gulp too?

Not sure if i understood correctly. You can still use the package without typescript. Only a typings file has been added so that one can use this module properly with typescript if wanted.

Indeed. Ignore me! I just dislike typescript a lot.


laravel: 5.8.1 -> 5.8.3

Description of changes
Release log: https://github.com/laravel/installer/releases/tag/v5.8.3
Change log: https://github.com/laravel/installer/compare/v5.8.1...v5.8.3
Updated composer.lock

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I suggest you to sort the update script of this package instead of doing manual updates.


Materialize select issue

Hi All,
Apologies for submitting a query here in github even if I already asked it in stackoverflow. I just hope you checked my issue in there. Stackoverflow question
Thanks! :)

If you know you aren't supposed to open an issue here for How-to questions, then please don't do it.


If this is intended, 1) it is broken powerful and 2) the description of the feat should be updated.
However, I recommend that it only allow a bonus action attack with a shortbow and only if main action attack was with a shortbow.  Otherwise, this feat is bonkers broken powerful.

It's coded exactly the way you've recommended. I cannot reproduce the issue locally. Something else is granting this 2nd attack. I need your save.

Yep.  You are right.  It's not the Bow Mastery Feat.  But the War Magic feature of the Fighter Spell Shield class.  It is supposed to only grant a Bonus Action attack after casting a Spell or Cantrip.  But it's granting a Bonus Action attack after attacking (hitting?)  with any weapon and not casting any spells.
Test Bow Mastery 2.zip


Is not working in a multi compile mode. (using array notation for webpack config)

im using a webpack configuration with array [ ] however no assets are copied to the output only shown in the console. if i remove the array and simply use one config it works.
I have two sections one is the main and the others is a set of themes all work in dev webpack server as i dont use this there :P and should not ether, but in production noting outputs for this plugin however all loaders not related to the extract text plugin outputs as it should like images etc.
note that i have tried with only one configuration and that one configuration builds fine if its not in an array. the theme config was omitted when i tested so its not a configuration error.

Can you paste your webpack config, or have a repo for us to test? :)

Here is a configuration:
config.zip

oh ye i forgot the gulp/task/webpack.js needs to look like this
module.exports = function (gulp, options, plugins) {
    gulp.task("webpack",
        function () {
            const statsFunc = function(err, stats) {
                if (err) {
                    throw new plugins.util.PluginError("webpack", err);
                }
                plugins.util.log("[webpack]",
                    stats.toString({
                        // output console options
                        colors: true
                    }));
            };

            return plugins.webpackStream(options.webpack.config, options.webpack.requiredInstance, statsFunc).pipe(gulp.dest(options.distPath));
        });
};

Here is a new file.
SpecialistHjalpen.UI.Client.zip

nevermind the fix dide not work now the main "first item in the array" is not copied to the output xD

@robgha01 What the status here, is this still relevant? Could you please post your webpack.config.js as a code block here

Closing due to inactivity. Please test with latest version and feel free to reopen if still regressions. Thanks!


[$1000] Desktop - Sign in - User can not validate an account

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/17697
Action Performed:

Access the Expensify Desktop app
Input an email that does not exist
Access the email account and tap on the link (Redirect it to the Desktop app)
Input a New password

Expected Result:
User expects the password to be saved and the new account to be open
Actual Result:
The user keeps receiving an error message saying that the link has expired, making it impossible to validate an account via Desktop app.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/233431775-1c0bfa1e-61a7-40db-882f-9ae726c309eb.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016ce9697b87884431
Upwork Job ID:<PHONE_NUMBER>948047872
Last Price Increase: 2023-04-25

Triggered auto assignment to @arielgreen (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mvtglobally @kbecciv In the video, you are clicking the link which goes to production, is that not part of the problem? I am not sure

@arielgreen Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Job added to Upwork: https://www.upwork.com/jobs/~016ce9697b87884431

Current assignee @tjferriss is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

Triggered auto assignment to @bondydaa (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@mvtglobally @kbecciv In the video, you are clicking the link which goes to production, is that not part of the problem? I am not sure

Following up on @mountiny question.

@mountiny @tjferriss the account creation is done in STG app. Should the link be sent as STG as well? Maybe that's the root cause.
I will ask team to Not click the link, but paste and modify to staging to check

Looks to be still repro after URLs switch as well
https://user-images.githubusercontent.com/43995119/234629323-cdceeca5-b177-4bae-8233-e25f8b594f81.MOV

https://github.com/Expensify/App/pull/17697 should have nothing to do with sign in links.
I think I see the problem - when you load the magic code in the browser it is essentially "using that code", I'm am not sure if this also then expires that code (I think it does).
So then when you click to allow to open the link in the desktop app it's attempting to use a now expired code and fails.
cc @NikkiWines @johnmlee101 can you help us confirm this or not?

Hmm, I'm not sure where in the code do we "use the code" in this case.
Also the validateLink is in the wrong format from what I can tell. https://github.com/Expensify/Web-Expensify/blob/5dc779f8f5ed883805ea035af71d96a590cefef9/lib/Notification/Standard.php#L1529-L1535 @kbecciv can you re-test since we added passwordless to gmail accounts since then. This flow will be removed

Hmm yeah @hoangzinh that is a good call out.
I'm not actually sure how Slack handles this, are there browser APIs available to can detect if a link can be opened by another app?
Seems like the flow would need:

click link that triggers request in browser
(if possible) detect deep/universal link
if no deep/universal link then proceed with request to validate
if deep/universal link then pass off request/validateCode to that app

If there aren't ways to detect deep/universal links then we might need to come up with a way ourselves within the API to validate/pass through a session from web to the app then, nothing immediately jumps out at me.

oh interesting... I'm going to comment on that thread and link this issue.
Going to throw a hold on this for the time being then and we can see what the discussion in slack comes to.

holding until we can resolve this discussion https://expensify.slack.com/archives/C049HHMV9SM/p1683049880878109?thread_ts=1678823496.930569&cid=C049HHMV9SM

@bondydaa it looks like we came to a conclusion in Slack. What is the next step here?

ah thanks for the bump, I had been waiting to see if anyone else was going to weigh in on that thread.
Taking this off hold then and looking for proposals to implement this: https://expensify.slack.com/archives/C049HHMV9SM/p1683051477869179?thread_ts=1678823496.930569&cid=C049HHMV9SM

create a navigation route that checks for a validateCode code param and then loads a "loading page" like we had before that will allow the user to then open in app or in browser?

@rushatgabhane @bondydaa what do we think of @hoangzinh proposal?

I don't think we want to revert the everything from https://github.com/Expensify/App/pull/16383 so I'd say it's best to "re-implement the redirect page only when the route match ROUTES.VALIDATE_LOGIN, otherwise we let it render current page behind the Alert."
but otherwise 👍 going to assign you @hoangzinh

Issue not reproducible during KI retests. (First week)

oh wat... did this get fixed elsewhere already?

okay great thanks for confirming 🙇
On Wed, May 17, 2023 at 11:33 AM Vinh Hoang @.***>
wrote:

@rushatgabhane https://github.com/rushatgabhane @bondydaa
https://github.com/bondydaa PR is ready for reviewing #19125
https://github.com/Expensify/App/pull/19125. Thanks
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/issues/17724#issuecomment-1551802386,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7CPCXZDFBRGOC4ENK24YDXGUDVBANCNFSM6AAAAAAXFYGJLI
.
You are receiving this because you were mentioned.Message ID:
@.***>

@rushatgabhane looks great.

Looks like we're still waiting on this PR to see if it fixes the issue https://github.com/Expensify/App/pull/19819

sorry i haven't really been following 100% here but didn't we merge the deploy the code here? did it get reverted or is it breaking something?
If not let's get payment done then and we can spin up new issues if needed to address other things.

Great, I think we're all in agreement. We're going to process the payment and close this issue. @rushatgabhane @hoangzinh I've sent both of you an offer in Upworks.

@rushatgabhane @hoangzinh I've sent you both offers in Upworks.

The payments have been made in Upworks.

@hoangzinh it now looks like the contract has ended.

I think I found it now and ended the contract.


webm video does not play in Safari

Browsers:
macOS Safari Version 16.2 (186<IP_ADDRESS>.5)
iOS Safari (whatever version is on an iPhone running iOS 16.1.2)
Inscription:
https://ordinals.com/inscription/fdcf0b5725301493f3bbb0564d9a1ecac9ab5baa0d3c6523ca77186184f3c3fai0
Video player appears but shows black background and zero second video.
After a bit of searching, I think that this is a limitation of Safari, in which case this issue can be closed... Might be worth noting somewhere though.

This is a Safari issue, but I think it's worth keeping this issue open. We could support H.264 in MP4, which is worse but works everywhere.

I think it's best to not overthink it. Since you have preview, it can be double-checked beforehand, at least.

Here's an example of an illicit MP4 inscription: https://ordinals.com/content/2b6421c68f123e6332700133d842e14346cf2bdcda5c660465c4b3ee0f78284ei0


Adding "default direction" for doing multi-column sorting using the "orderData" option

slightly modified the _fnSortFlatten to allow for "default direction" for doing multi-column sorting, hope you would consider adding it, check for sanity.
Basically it will allow some some syntax like this orderData: [0, [2, 'asc'], 1, [3, 'desc'], .....]
Thanks.

@iimanii A big thank you for this patch!
@DataTables +1 for including it as soon as possible!


Add a Manual Sync button to settings

Along with automatically syncing we should offer a way to sync manually which shouldn't be spammable (i.e. if clicked more than once should disable for a period of X seconds)

Manual Sync implemented.


"Fixed AB#5" auto transitions AB work item only on default branch?

Auto transitioning Azure Board items with mentions like "Fixed AB#5" seems to be working only for commits to main/default branch.
If I commit to any other branch the transition does not work. After Merging the branch into main/default all transitions are executed. Is that intended? If yes, you might want to document this. If no, where can I create a bug?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c82842d8-dd84-249f-cce1-9e93ecf703bf
Version Independent ID: eaf9a299-4492-8e09-287a-f10b63d15e29
Content: Link GitHub commits, PRs, and issues to work items - Azure Boards
Content Source: docs/boards/github/link-to-from-github.md
Service: azure-devops-boards
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@Fitzbert-Fitz -- Martin, thank you for your feedback.  Please add it here:

Developer Community


[FEATURE] - Implement footer according to the spec

One or more footers MAY be provided one blank line after the body. Each footer MUST consist of a word token, followed by either a : or # separator, followed by a string value (this is inspired by the git trailer convention).

A footer’s token MUST use - in place of whitespace characters, e.g., Acked-by (this helps differentiate the footer section from a multi-paragraph body). An exception is made for BREAKING CHANGE, which MAY also be used as a token.

A footer’s value MAY contain spaces and newlines, and parsing MUST terminate when the next valid footer token/separator pair is observed.

Hi @oknozor, please could you assign this to me. I would like to work on this.
Just wanted a quick clarification regarding this issue. If I understood correctly, we would want to parse and validate the footers in the commit message body. Is that correct, or would we want to do anything more with the footers?
Also, the footers must comply with the Conventional commit spec right?

Hey @renaultfernandes I think we will get this for free when #22 is implemented. No need to work on this for now.

Alright cool, thanks for letting me know. :)


Disconnect on out of memory errors

If receiving a packet encounters an allocation error or other out of memory conditions, disconnect signalling low on resources. This means that buffer sizes must be adjusted, because otherwise the data will be lost without the other end knowing

/test


Added CentralApp to the list of companies

I've taken the liberty to use specify Web/SaaS as our Sector; since what we do overlaps both areas.

Thanks, I see you had some hiring post from half a year ago on reddit too: https://web.archive.org/save/https://www.reddit.com/r/haskell/comments/9wz7t5/were_centralapp_and_were_hiring/

@erkmos yes, we were, and we are also looking for good profiles all the time.


ipmitool: add enterprise-numbers file

Description of changes
Current ipmitool complains about missing enterprise-numbers file. See issue #204926
https://github.com/NixOS/nixpkgs/issues/204926
ipmitool tries to download the file from iana.org:
https://www.iana.org/assignments/enterprise-numbers.txt
It is quite large (~4.5 MB, ~1.5 MB compressed), so we may not want to include it in nixpkgs directly. I've set up a github repository that contains the file from iana.org, and changed default.nix to fetch it.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Or we can use the internet archive.

Or we can use the internet archive.

Indeed, I hadn't thought of this, and nixpkgs is already using archive.org quite a number of times.
There was only one version of enterprise-numbers.txt in the wayback machine. I used "Save Page Now" to create an up-to-date copy and modified default.nix to use it.

And lastly, squash the commits. diff LGTM, just need to wait for ofborg to test it out.

will this be backported to 22.11?


Publish new release and setup CI

changes made so need to publish new release and setup CI

Sorry for the late reply. I get some leisure time to do this now.
I need your help, set two action secrets would send an email to you.

Three steps to release when features are already.

update version
build
publish to where

github release
pypi

Sorry for the late reply. I get some leisure time to do this now.
I need your help, set two action secrets would send an email to you.

added


Fix flaky TestPodControllerRun unit test for SecondaryNetwork

Signed-off-by: Antonin Bas<EMAIL_ADDRESS>

I just noticed that the test sometimes fail in CI :(

/skip-all

/skip-all


[feature req] New model for testing: DummyAgent

For testing purposes we should have a dummy agent.
It should just work with @klieret's test issue in the test repo.
It should just sequentially execute the commands that fix that issue in that repo.
This would be useful for end-to-end testing purposes and would save money on API requests.
I also have some small ideas on how to improve this idea slightly more.

Kilian I'd love to hear your thoughts. Just wanted to file this before I forget.

Isn't that very similar to the replay model though? Where would we get the commands that fix the issue?
If we had gpt4 solve an issue before, we can take the trajectory and use the replay model to replay everything as if the LM was doing it.
This is the primary means by which I'm testing swe-agent at the moment :)

ok let me talk to you about this next time we chat, i think we can make this DummyAgent a bit smarter and therefore it would maybe be better than the replay solution. anyways this is not urgent at all

ok I talked with Kilian and one of the tests almost does exactly this and at some point we'll update that test to verify environment outputs too


configuration file not found, using an empty configuration

Which version are you using?
v0.22.2
Which operating system are you using?

[x] Linux amd64 standard
[ ] Linux amd64 Docker
[ ] Linux arm64 standard
[ ] Linux arm64 Docker
[ ] Linux arm7 standard
[ ] Linux arm7 Docker
[ ] Linux arm6 standard
[ ] Linux arm6 Docker
[ ] Windows amd64 standard
[ ] Windows amd64 Docker (WSL backend)
[ ] macOS amd64 standard
[ ] macOS amd64 Docker
[ ] Other (please describe)

Describe the issue
After I extracted the mediamtx_v0.22.2_linux_amd64.tar.gz in my Download folder, running the executable with ./mediamtx_v0.22.2_linux_amd64/mediamtx shows me the following message in the Logs:
    2023/05/11 13:10:14 INF MediaMTX / rtsp-simple-server v0.22.2
    2023/05/11 13:10:14 WAR configuration file not found, using an empty configuration
    2023/05/11 13:10:14 INF [RTSP] listener opened on :8554 (TCP), :8000 (UDP/RTP), :8001 (UDP/RTCP)
    2023/05/11 13:10:14 INF [RTMP] listener opened on :1935
    2023/05/11 13:10:14 INF [HLS] listener opened on :8888
    2023/05/11 13:10:14 INF [WebRTC] listener opened on :8889 (HTTP)

Not finding the configuration file. After starting the stream some more messages appeared:
    2023/05/11 13:34:32 INF [RTSP] [conn <IP_ADDRESS>:54176] opened
    2023/05/11 13:34:32 INF [RTSP] [conn <IP_ADDRESS>:54176] closed (path 'mystream' is not configured)

The weird aspect is that this issue only showed up today. I have been running mediamtx for about 2 weeks before and never had this problem starting the streaming.
Describe how to replicate the issue

start the server

start the stream with ffmpeg: ffmpeg -f v4l2 -i /dev/video0 -profile:v high -pix_fmt yuvj420p -level:v 4.1 -preset ultrafast -tune zerolatency -vcodec libx264 -r 10 -b:v 512k -s 1920x1080 -strict -2 -ac 2 -ab 32k -ar 44100 -f mpegts -f rtsp -rtsp_transport tcp rtsp://<IP_ADDRESS>:8554/mystream (the command I have been using)

Check the configuration file located in ./mediamtx_v0.22.2_linux_amd64/mediamtx.yml after searching on the internet for a solution I tried to edit the end of the file where paths are specified and left only:
 paths:
     mystream:
         source: Camera

Did you attach the server logs?

no
Did you attach a network dump?

no

try going into the folder where you have mediamtx and mediamtx.yml
example:
cd path/to/mediamtx_v0.22.2_linux_amd64
./mediamtx
or follow the instructions to add it as a service that will auto start on boot...
https://github.com/bluenviron/mediamtx#linux


lab helm charts create wrongly named services -> notebooks fail

We're having trouble running the egeria jupyter labs from the helm charts - the read-me-first.ipynb errors on the first code snippet with
ConnectionError: HTTPConnectionPool(host='lab-egeria-core-service', port=8080): Max retries exceeded with url: /open-metadata/platform-services/users/garygeeke/server-platform/origin/ (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f6bc893abe0>: Failed to establish a new connection: [Errno -2] Name or service not known'))

fixed so closing