Inconsistent behavior for optional properties with defaults

Description
I've discovered inconsistent behavior when generating types for optional fields which also provide a default value. See sandbox for more info
Given a simple Item schema:
"Item": {
    "type": "object",
    "properties": {
        "status": { "type": "string", "nullable": true, "default": "complete" },
    }
}

Depending on where it is defined in the openapi spec file we get different results:
If we define Item in the endpoint directly without using a ref we get:
"application/json": {
    /** @default complete */
    status?: string; // correct behavior
};

If we define Item in components and use a ref in the endpoint spec the result becomes:
Item: {
    /** @default complete */
    status: string; // this is now no longer optional
};

The latter behavior is unexpected and incorrect as the field should not be required

Name
Version

openapi-typescript
7.4.1

Node.js
20.12.1

Reproduction
https://codesandbox.io/p/devbox/openapi-typescript-optional-default-5zjvsz
see spec.json input file and output.d.ts result
Checklist

[x] My OpenAPI schema passes the Redocly validator (npx @redocly/cli@latest lint)
[ ] I’m willing to open a PR (see CONTRIBUTING.md)

Jus found this - https://github.com/openapi-ts/openapi-typescript/issues/1903 seems to be the same issue

Jus found this - #1903 seems to be the same issue

If a default value is specified, the field will default to an optional type and its default behavior can be modified by '--default-non-nullable'

Not sure if my issue is identical to this one.
I have a spec.json with the following response (partially redacted)
{
  "paths": {
    "/schools": {
      "post": {
        "responses": {
          "200": {
            "description": "List of school objects",
            "content": {
              "application/json": {
                "schema": {
                  "type": "object",
                  "properties": {
                    "data": {
                      "type": "array",
                      "items": {
                        "type": "object",
                        "properties": {
                          "school_id": {
                            "type": "string",
                            "format": "uuid",
                            "description": "The school identifier",
                            "example": "acb46979-1072-41fc-920c-5577816a88bc"
                          },
                          "school_name": {
                            "type": "string",
                            "description": "The school name",
                            "example": "Super School"
                          },
// closing braces

But the generated .d.ts spec looks like this:
export interface operations {
// upper content redacted
          responses: {
            /** @description List of school objects */
            200: {
                headers: {
                    [name: string]: unknown;
                };
                content: {
                    "application/json": {
                        data?: {
                            /**
                             * Format: uuid
                             * @description The school identifier
                             * @example acb46979-1072-41fc-920c-5577816a88bc
                             */
                            school_id?: string;
                            /**
                             * @description The school name
                             * @example Super school
                             */
                            school_name?: string;
// lower content redacted
}

Though I'm not using NULLABLE in my OpanAPI spec, the output data types are shown as optional, such school_id?: string when it should be school_id: string.

Not sure if my issue is identical to this one.

I don't think it's related - I can't tell from your redacted openapi schema but it looks like the fields are not specified as required eg "required": ["school_id", "school_name"], seems to be missing. If so, it's an issue with your schema itself not this library

Thanks for your reply, and you're right I am missing required: .. from my OAS file; I'll open a new issue if I find anything further.

I am seeing this as well still with version 7.4.3. Here is the spec im using (google admin API): https://pastebin.com/4d48Kyap
Command which hangs:
npx openapi-typescript ./sources/openapi.yaml -o ./schema.ts


Animal and plant part descriptions

Matthew's comment:

  2. We need a way to describe parts of animals consumed. These don't
 usually match directly with anatomical parts,  and butchering techniques
 (examples one <http://www.thirdculturemama.com/french-vs-american-butchery/#.V8YkuGhhma4>,
 two <http://eatingchile.blogspot.com/2009/12/eating-chilean-beef.html>,
 three <http://www.noordinaryhomestead.com/butcher-shop-cheet-sheet-auf-deutsch/>)
 differ widely across cultures.
  - Do we have a way for talking about portions of muscles? Whether the
  muscle has been pulled/ripped, cut across the grain, or has a portion of
  bone left in?
  - Modelling the separation of things like whey protein from milk
  would be another example.

Indeed, aside from simpler cases where anatomical parts do happen to line up precisely (could I have some carrots and eyeballs with gravy?), we run into a slew of fiat boundary issues, both anatomical and cultural.  For animal food sources, could a basic approach be that we have a general "animal carcass butchery cuts" class, perhaps subclassed into animals, then followed by names of cut regardless of language or culture, but annotated by language and culture/country, and in the future some anatomical fiat boundary descriptors?  Langual has a bit of a start on this (in facet E: Part of Animal) for French and US; I guess it is convenient to multi-home such items under culture/country.
(By the way an easy way of seeing all the descriptors in Langual is via this file: http://www.langual.org/download/LanguaL2014/LanguaL2014TREE.TXT )
    CUT OF MEAT [Z0146]
        CUT OF MEAT NOT KNOWN [Z0018]
        CUT OF MEAT, COMPOSITE [Z0047]
        CUT OF MEAT, FRENCH [Z0121]
            CUT OF MEAT, COMPOSITE [Z0047]
            QUARTIER ARRIERE [Z0135]
                ALOYAU [Z0141]
                    ENTRE-COTE [Z0142]
                    FAUX-FILET [Z0143]
                    FILET [Z0144]
                    RUMSTECK [Z0145]
                CUISSE [Z0136]
                    GITE ARRIERE [Z0137]
                    SEMELLE [Z0138]
                    TRANCHE (MEAT CUT) [Z0139]
                    TRANCHE GRASSE [Z0140]
                TAIL [Z0155]
            QUARTIER AVANT [Z0122]
                BASSES-COTES [Z0130]
                CAPARACON [Z0123]
                    BAVETTE [Z0124]
                    FLANCHET [Z0125]
                    HAMPE [Z0126]
                    PLAT-DE-COTE [Z0127]
                    POITRINE [Z0128]
                COLLIER [Z0129]
                RAQUETTE [Z0131]
                    GITE AVANT [Z0132]
                    JUMEAU [Z0133]
                    MARCREUSE [Z0134]
        CUT OF MEAT, OTHER [Z0048]
        CUT OF MEAT, U.S. [Z0008]
            BELLY MEAT [Z0063]
            BREAST (MEAT CUT) [Z0045]
            BRISKET [Z0020]
            CHUCK [Z0021]
            FLANK [Z0022]
            FOOT (MEAT CUT) [Z0041]
            JOWL, TRIMMED [Z0040]
            LOIN [Z0031]
            RIB (MEAT CUT) [Z0023]
            ROUND OR LEG (MEAT CUT) [Z0024]
            SHANK (MEAT) [Z0293]
                FORE SHANK [Z0025]
            SHORT LOIN [Z0026]
            SHORT PLATE [Z0028]
            SHOULDER (MEAT CUT) [Z0043]
                FAT BACK [Z0037]
            SIDE (MEAT CUT) [Z0046]
            SIRLOIN [Z0027]
            TAIL [Z0155]
            TENDERLOIN [Z0217]
        CUT OF POULTRY MEAT [Z0156]
            BREAST (POULTRY MEAT CUT) [Z0158]
            LEG (POULTRY MEAT CUT) [Z0159]
            THIGH (POULTRY MEAT CUT) [Z0160]
            WING (POULTRY MEAT CUT) [Z0157]

So your examples suggest Chilean, German etc. categories. Not sure if we'd have "chilean meat cuts - beef" .... etc. or instead to have each cut as a class annotated by culture, language, animal part.  (I tend to prefer the latter as it doesn't lead to combinatorial hell).  Opinions?
In the Food Schema in the food Preparation stage or process, I made the distinction between distinction between ingredient modification (where ingredient itself is modified) and extraction / separation (where end product is derived from ingredient) .  Langual has a lot to say about modification in "Facet H: Treatment Applied"
PHYSICALLY/CHEMICALLY MODIFIED [H0130]
        AERATED [H0178]
            AERATED BY CREAMING [H0359]
            AERATED BY WHIPPING [H0358]
        ALKALIZED [H0206]
        BLEACHED [H0197]
        BROMATED [H0276]
        CANDIED [H0182]
        DISTILLED [H0270]
        ENCAPSULATED [H0781]
        EXTRUDED [H0352]
        FLAKED [H0274]
        FLATTENED [H0366]
        HOMOGENIZED OR EMULSIFIED [H0306]
        HYDROGENATED [H0174]
        HYDROLYZED [H0277]
        IRRADIATED [H0121]
            IRRADIATED BY IONIZING IRRADIATION [H0179]
            IRRADIATED BY ULTRAVIOLET RADIATION [H0261]
        LIQUID INJECTED [H0275]
        PARBOILED (GRAIN) [H0220]
        PHOSPHATED [H0278]
        PREVIOUSLY FROZEN [H0241]
        PUFFED [H0268]
        ROASTED (PROCESSING METHOD) [H0391]
        ROLLED [H0239]
        TEXTURED [H0192]

And under facet E, there is some detail about meat end product, but I think this part should be reorganized into separate qualities.  (What I imagine is more problematic logically are the negatives (without bone, skin, fat, shell) which would best be set up via closure).
  "Shape achieved by forming" for a "Whole" thing, oy!
SOLID [E0151]
    CRYSTAL [E0143]
    DIVIDED OR DISINTEGRATED [E0122]
        DISINTEGRATED OR GROUND [E0136]
            FINELY GROUND [E0106]
            MEDIUM GROUND [E0117]
                MEDIUM GROUND AND SIFTED (BOLTED) [E0101]
        DIVIDED INTO HALVES, QUARTERS OR SEGMENTS [E0133]
            DIVIDED INTO HALVES [E0116]
            DIVIDED INTO QUARTERS [E0148]
            DIVIDED INTO SEGMENTS OR WEDGES [E0107]
        DIVIDED INTO PIECES [E0152]
            DIVIDED INTO PIECES, THICKNESS <0.3 CM. [E0100]
            DIVIDED INTO PIECES, THICKNESS 0.3-1.5 CM. [E0115]
                CUT INTO LONG PIECES [E0141]
                CUT INTO SHORT PIECES [E0111]
                SLICED [E0137]
                    SLICED, THICK, BETWEEN 0.5 AND 1.5 CM. [E0124]
                    SLICED, THIN, BELOW 0.5 CM. [E0145]
            DIVIDED INTO PIECES, THICKNESS MORE THAN 1.5 CM. [E0125]
    WHOLE [E0131]
        WHOLE, NATURAL SHAPE [E0150]
        WHOLE, SHAPE ACHIEVED BY FORMING [E0147]
            WHOLE, SHAPE ACHIEVED BY FORMING, THICKNESS <0.3 CM. [E0153]
            WHOLE, SHAPE ACHIEVED BY FORMING, THICKNESS 0.3-1.5 CM. [E0140]
            WHOLE, SHAPE ACHIEVED BY FORMING, THICKNESS 1.5-7 CM. [E0105]
            WHOLE, SHAPE ACHIEVED BY FORMING, THICKNESS BIGGER THAN 7 CM. [E0146]
    WHOLE AND PIECES [E0104]

I remember Codex Alimentarius has very specific things to say about what a fish-stick is for example (http://www.fao.org/input/download/standards/112/CXS_166e_2014.pdf) which would be a separate project to try to satisfy.
It will be user interface magic that makes all of the above more approachable when needed.
Thoughts?!

One note I'm bringing up that Jayne Ireland, one of the current curators of LanguaL has mentioned:

“Mixed terms” were created by the original FDA team to index common mixtures. For example, how would you index a cheese made with 50% cow’s milk and 50% goat’s milk? Without the mixture term CATTLE AND GOAT, you would have to choose between CATTLE/COW and GOAT/DOE.  Using the mixture term, the indexed cheese would be retrieved whether one chose CATTLE or GOAT as food source.

. . CATTLE B1161
. . . CALF B1349
. . . CATTLE AND GOAT B2245
. . . CATTLE AND LAMB B2396
. . . CATTLE AND SHEEP B2244
. . . CATTLE AND SHEEP AND GOAT B2247
...
I think the OWL ontology version should definitely mark these mixed terms as archaic, and would instead have people select multiple food source facet items to describe a particular food product.

All the conjunction [meat 1] and [meat 2] etc, and [vegetable 1] and [vegetable 2] etc. conjunctions have been deprecated as they do not name a food product that they represent.
As for the remaining discussion, a heavier reliance on UBERON for anatomical part has begun; as well FoodOn now has an ancestro ontology that one can link food products or food source items to.


Feature: LOOP-103-tls-functionality-to-frisbee

Description
Please include a summary of the change and which issue has been fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
This adds TLS functionality to Frisbee
Completes LOOP-103
Type of change
Please update the title of this PR to reflect the type of change. (Delete the ones that aren't required).

[x] New feature (non-breaking change which adds functionality) [title: 'feat:']

Testing
Please make sure that existing test cases pass (with go test ./... -race and go test -bench=. ./... -race),
and if required please add new test cases and list them below:
Benchmarking
Frisbee tries to adhere to strict performance requirements, so please make sure to run go test -bench=. ./... and paste the results below:
Benchmarking Results:
goos: darwin
goarch: amd64
pkg: github.com/loophole-labs/frisbee
cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
BenchmarkClientThroughput/test-16                     36          30665767 ns/op
BenchmarkClientThroughputResponse/test-16                     39          29935957 ns/op
BenchmarkThroughputPipe32-16                                  51          23698655 ns/op
BenchmarkThroughputPipe512-16                                 27          37335217 ns/op
BenchmarkThroughputNetwork32-16                               54          21412604 ns/op
BenchmarkThroughputNetwork512-16                              36          33285336 ns/op
BenchmarkThroughputNetwork1024-16                             25          46989626 ns/op
BenchmarkThroughputNetwork2048-16                             15          72398242 ns/op
BenchmarkThroughputNetwork4096-16                              8         130813877 ns/op
BenchmarkThroughputNetwork1mb-16<PHONE_NUMBER> ns/op
BenchmarkThroughput/test-16                                   33          35254055 ns/op
BenchmarkThroughputWithResponse/test-16                       33          35678132 ns/op
PASS
ok      github.com/loophole-labs/frisbee        28.995s
?       github.com/loophole-labs/frisbee/internal/errors        [no test files]
goos: darwin
goarch: amd64
pkg: github.com/loophole-labs/frisbee/internal/protocol
cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
BenchmarkEncodeHandler-16               77633718                15.20 ns/op
BenchmarkDecodeHandler-16               110708784               10.64 ns/op
BenchmarkEncodeDecodeHandler-16         39765156                28.74 ns/op
BenchmarkEncode-16                      88064384                13.72 ns/op
BenchmarkDecode-16                      163684606                7.459 ns/op
BenchmarkEncodeDecode-16                44668579                24.47 ns/op
PASS
ok      github.com/loophole-labs/frisbee/internal/protocol      9.895s
PASS
ok      github.com/loophole-labs/frisbee/internal/ringbuffer    0.100s

Linting
Please make sure you've run the following and fixed any issues that arise:

[x] go fmt ./... has been run
[x] golangci-lint run --skip-dirs-use-default has been run

Final Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

This feature is going to need some extensive test cases, so I've scheduled an issue for that here: https://linear.app/loophole-labs/issue/LOOP-104/add-test-cases-for-tls-configurations-client-and-server


Update About Us based on Milestone v1.0

Follow Milestone v1.0

Completed. Closing issue.

Almost completed as of #39
Note: Update each person's Github Portfolio when done.


Add a way to change the current Page

At the moment there's no way to set a Page as the current page, like you can do using context.document.setCurrentPage(page)

Ah, indeed it works. Thanks, closing!


Can't push with ssh-ed25519 keys

From @amingilani on November 5, 2016 21:55
Currently I can keys:add my primary ssh-ed25519 ssh key but I can't push, and have to rely on my alt RSA key.
Github let's me push using my primary ssh-ed25519, I can log in as core@coreOS using my ssh-ed25519 just fine.
Steps to reproduce:

Create a new key using ssh-keygen -o -a 100 -t ed25519
Add the key to Deis
Create and push using the key

Copied from original issue: deis/workflow#598

From @amingilani on November 8, 2016 20:58
@kmala could you independently run the following? The command to generate a ed25519 key is ssh-keygen -o -a 100 -t ed25519

From @kmala on November 8, 2016 20:1
whatever key git client passes during git push deis master is the one used by the deis to authenticate. So, if you should be able to use  ssh-ed25519 key if you can make git client to use it for ssh.

From @amingilani on November 8, 2016 20:56
@kmala here:
Checking to make sure my key exists on deis
$ deis keys:list
=== amin_shah Keys
<EMAIL_ADDRESS>ssh-ed25519 AAAA...bull.local
gilani@redbull       ssh-rsa AAAAB3Nz...ni@redbull

Testing git push
# Using RSA key on Github
$ GIT_SSH_COMMAND="ssh -i ~/.ssh/id_rsa -F /dev/null" git push github master
Everything up-to-date

# Using ED25519 key on Github
$ GIT_SSH_COMMAND="ssh -i ~/.ssh/id_ed25519 -F /dev/null" git push github master
Everything up-to-date

# Using RSA key on Deis
$ GIT_SSH_COMMAND="ssh -i ~/.ssh/id_rsa -F /dev/null" git push deis master
Everything up-to-date

# Using ED25519 key on Deis
$ GIT_SSH_COMMAND="ssh -i ~/.ssh/id_ed25519 -F /dev/null" git push deis master
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

From @kmala on November 8, 2016 21:35
yes...i get the same behavior but the weird thing is the server is getting the rsa key and not the ed25519 key even when using the  GIT_SSH_COMMAND.

From @kmala on November 8, 2016 23:10
On further investigation i found that this is happening only for ed25519 keys.... i am able to use different keys using the GIT_SSH_COMMAND

From @bacongobbler on November 8, 2016 23:24
Not sure if this is relevant (fly-by comment) but we only generate rsa, dsa and ecdsa host keys for the builder: https://github.com/deis/charts/blob/master/workflow-dev/tpl/deis-builder-secret-ssh-private-keys.yaml#L10-L13
Perhaps that is relevant?

From @bacongobbler on March 27, 2017 22:48
this has been fixed upstream so we should be able to accept ed25519 keys if someone feels like hacking up a PR for the controller and the builder. :)

From @kmala on November 9, 2016 17:1
Upon further investigation found that golang ssh implementations doesn't support ed25519 keys https://github.com/golang/go/issues/8581 .The issue is fixed but isn't released.

From @kmala on March 28, 2017 6:31
It was fixed long back but isn't released in any release.


test if errors work in voyager

As of https://github.com/cosmos/cosmos-sdk/pull/2119 errors returned by the LCD are not longer plain text (with a lot of additional noise) but a JSON object. This should deprecate the need to parse out the error message from this plain text error.
The question is, is there an additional need to adjust Voyagers error parsing (to show the correct error to the user) or do we still need to parse the error from the JSON object.

What does this mean?

Updated the description.

So is this a spike proposal?

How did it end up in Scrumptious with no one assigned?

This was a follow up for @fedekunze ticket on the SDK. I forgot the assign someone as it wasn't created in process. I will get to it if I find time.

Plan:

produce an error in the LCD (like not enough atoms to stake)
check if Voyager displays the error user friendly


repeat directive documentation

I learned from @kenchris that the repeat directive should only be used if we intend to "re-order" the items and that in other cases we can just use .map
I'm opening this issue to make the documentation with that regards clearer:
template-reference#repeat
I'd be happy to send a PR, but I'm not sure how to word it in a clearer way, so I'm opening an issue first to get feedback

cc @arthurevans

maybe make it clearer that there's an overhead of using it, to make it clearer when it's suitable

Some content I posted on Slack earlier:
The core difference between map and repeat is that repeat maintains the state of rendered nodes. If you are shuffling components around that have state, like inputs or other web components, and you are not setting that state explicitly, map will cause problems, where repeat will not.
A simple example of this is a list of items with checkboxes. Unless the checked state is explicitly set in the template, using map will cause the checks not to re-order when the input array changes.
If your nodes do not have any kind of state, or your array is append-only, it is very likely that map is better than repeat performance-wise.
Maintaining the order association is an additional requirement, and maintaining it comes at a cost.

Thanks @ruphin ... I added some generalities about performance in the docs:
https://lit-html.polymer-project.org/guide/writing-templates#repeating-templates-with-the-repeat-directive
However, I missed that point about stateful components, which is an important one.

@arthurevans Nice! I think there may be a typo in the employee example though:
const employeeList = (employees) => html`

    ${repeat(employees, (employee) => employee.id, (employee) =>
        html`<li>employee.familyName, employee.givenName</li>`}

`

Missing closing ) before the closing }

@jorenbroekema @FluorescentHallucinogen already put out a PR to address that typo. #698

I am observing something with the use of repeat, and I am not sure if it is a bug:
From the above example, if I do a re-sort of the employeeList, then modify the employees array (say, by deleting an item), and passing it back to the repeat directive, nothing happens, i.e. nothing gets deleted from the UI.
Does repeat behave correctly when elements are subsequently removed/added from the array by changing the array contents?

@ernsheong changing the items of the array doesn't necessary trigger a render. You can call this.requestUpdate() after you have changed the order/removed items

@ernsheong if you change the reference but not the value, a re-render is not triggered. This is a common issue with arrays and objects that people face.
You could do what pshihn suggested, or do the following, for example in a setter:
render() {
  return html`

Hello world!

      ${this.employeeList.map(employee => html`<li>${employee}</li>`)}

  `;
}

set employeeList (value) {
  this._employeeList = value;
}

or to simply delete the first item without needing a setter like that
const [myOldItem, ...rest];
this.employeeList = [...rest];

Or adding
this.employeeList = [...this.employeeList, 'Joe'];

Thanks all, I am aware of values vs references. I was using https://github.com/SortableJS/Sortable, and I guess repeat is just too fragile to have another library mess with the DOM at the same time.
For drag-and-drop my current conclusion is I have no choice but to handcraft down to the Drag-and-Drop API level following the example given here: https://github.com/Polymer/lit-html/issues/460#issuecomment-420250615

I'm running into this problem: https://github.com/Polymer/lit-html/issues/877#issuecomment-511003245
I have tried using the repeat directive instead of map, but the values of my textareas are still messed up.

@justinfagnani
My own confusion with repeat and what brought me to this issue is that I think the word 'repeat' does not match its purpose. It's responsible for 1) reordering elements in a list and 2) mutating a list by adding/removing elements. I understand that both repeat and Array.map don't toss out the underlying DOM elements but repeat retains their state. Why don't we call it 'list' instead of repeat as it is really a stateful list structure.
I think that would clear a lot of confusion, at least for me.
Day 1 with lit-html.

Technically, Array.prototype.map also retains the state of the DOM elements.
The difference between Array.prototype.map and repeat is that repeat is keyed. In other words, in repeat each DOM element is associated with a unique key in the source array item.
Practically this means repeat has the following behaviours:

If the source array re-arranges the items, the DOM elements will also re-arrange in the same way.
If an item in the source array is deleted and replaced with an item with a different key, the associated DOM element will also be deleted and replaced with a new one.

In these cases Array.prototype.map would retain all the original DOM elements (and their state) in the original order. It will only re-assign the dynamic values if appropriate.

Note that by default the key in repeat is the index in the array, which effectively makes repeat behave exactly like a more computationally expensive Array.prototype.map. The key function is an optional argument in the repeat directive, but you should never use repeat without a key function.

@ruphin
You stated:

In these cases Array.prototype.map would retain all the original DOM elements (and their state) in the original order. It will only re-assign the dynamic values if appropriate.

But the docs seem to say something else:

In most cases, using loops or Array.map is an efficient way to build repeating templates. However, if you want to reorder a large list, or mutate it by adding and removing individual entries, this approach can involve recreating a large number of DOM nodes.

Can you please clarify?

Note to self: when updating repeat docs should  also add a note about this issue: https://github.com/Polymer/lit-html/issues/1007 (which is related to directives in general, not repeat, although there's also a repeat-specific workaround).

The 2.0 site does a good job with this.


Search, or jump to starting letters

Can you please elaborate the issue?

Scrolling down through a couple of hundred artists is annoying. I need to
implement a simple way to jump around the list. Not sure I like searching
on a mounted tablet, so maybe an alphabet across the top of the song list
that gives an easy jump to capability would work nicely.


_node and _coffee are broken

Morale: don't test the examples inside the streamline dir; copy the examples dir outside and run them from there!

Still broken - local modules are not resolved.


Add scheduled entry time of the day

Probably this t was forgotten here. This function asks for time-stamp format, For sure when users include a time of the day there, they would like to have it included in the timestamp.

Probably this t was forgotten here. This function asks for time-stamp format, For sure when users include a time of the day there, they would like to have it included in the timestamp.

That was actually on purpose. The I'm fine with including the "hour:minute". But the tests need than to be adjusted too. This change seem to break the CI.

Could you specify which tests should get adjusted and how this breaks the CI? Of course this only adds the time to the time-stamp, which would be a great option to have for using it with org-wild-notifier(besides that it would be nice to have the option to schedule for a specific time instead of for a specific day only). If it breaks something we could just make it an option via an extra argument (and then make a separate command that calls this function with that extra argument, just like how the extra command for inserting at point was created in #335).

https://github.com/bastibe/org-journal/blob/919abc914902d78ae7556c513e671db4a327e310/tests/org-journal-test.el#L293 This is the test which fails.

I have fixed the test and merge this PR.

Haha! I just wanted to push a fix also. But anyway great! Thanks for merging.
Let me know if you have some questions about the other PR's, or if you would like me to add some extra comments to save you time from figuring out their purpose.


Part 6: Clarification on Player AI

In the tutorial text, you say:

We’ve changed each entity to make use of the Actor class, and used the HostileEnemy AI class for the Orc and the Troll types, while using the BaseAI for our player.

However, the diff and the code currently in the repo has:
player = Actor(
    char="@", color=WHITE, name="Player", ai_cls=HostileEnemy, fighter=Fighter(hp=30, defence=2, power=5)
)

Just confirming, that the ai_cls for the player actor should indeed be set to BaseAI.
But, I was wonder if the ai_cls component should in fact be Optional, as my first though was I'm the AI, and so the AI component should be set to None for the player actor.  Though this would also require changing the implementation of the is_alive property on the Actor class.

Sorry for a slow response.
Because the time system is player-centric it doesn't matter what the player AI is set to.  The players AI is ignored on the enemy turn and is ignored again on the players turn.
is_alive could be changed to look for some other indicator of alive-ness or be set directly.  The best options would involve switching to a non-player-centric time system, but that could require a rewrite.

Sorry for a slow response.
Because the time system is player-centric it doesn't matter what the player AI is set to.  The players AI is ignored on the enemy turn and is ignored again on the players turn.
is_alive could be changed to look for some other indicator of alive-ness or be set directly.  The best options would involve switching to a non-player-centric time system, but that could require a rewrite.


App crash at Alamofire stack

I have attached the stack trace below. It seems that the crash is happening due to Alamofire. Kindly verify if this is a known issue. Please help us on what can be done to fix this.
The Alamofire version we are using is 4.7.3
_#0. Crashed: com.apple.main-thread
0  libobjc.A.dylib                0x193bfc140 objc_release + 16
1  Alamofire                      0x1010fd054 $s9Alamofire12DataResponseVwxx + 176
2  libswiftCore.dylib             0x1a13e52ac (anonymous namespace)::destroyGenericBox(swift::HeapObject*) + 48
3  libswiftCore.dylib             0x1a13e4564 _swift_release_dealloc + 28
4  Alamofire                      0x10110b63c $s9Alamofire16DownloadResponseVyypGWOh + 372
5  libswiftCore.dylib             0x1a13e4564 _swift_release_dealloc + 28
6  libsystem_blocks.dylib         0x193aada48 _Block_release + 152
7  libdispatch.dylib              0x193b87184 _dispatch_client_callout + 16
8  libdispatch.dylib              0x193b39190 _dispatch_main_queue_callback_4CF$VARIANT$mp + 1044
9  CoreFoundation                 0x193e385e4 CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE + 12
10 CoreFoundation                 0x193e335d8 __CFRunLoopRun + 2004
11 CoreFoundation                 0x193e32adc CFRunLoopRunSpecific + 464
12 GraphicsServices               0x19ddb8328 GSEventRunModal + 104
13 UIKitCore                      0x197f2dae0 UIApplicationMain + 1936
14 goiq                           0x100843f44 main + 16 (main.m:16)
15 libdyld.dylib                  0x193cbc360 start + 4
--
#0. Crashed: com.apple.main-thread
0  libobjc.A.dylib                0x193bfc140 objc_release + 16
1  Alamofire                      0x1010fd054 $s9Alamofire12DataResponseVwxx + 176
2  libswiftCore.dylib             0x1a13e52ac (anonymous namespace)::destroyGenericBox(swift::HeapObject*) + 48
3  libswiftCore.dylib             0x1a13e4564 _swift_release_dealloc + 28
4  Alamofire                      0x10110b63c $s9Alamofire16DownloadResponseVyypGWOh + 372
5  libswiftCore.dylib             0x1a13e4564 _swift_release_dealloc + 28
6  libsystem_blocks.dylib         0x193aada48 _Block_release + 152
7  libdispatch.dylib              0x193b87184 _dispatch_client_callout + 16
8  libdispatch.dylib              0x193b39190 _dispatch_main_queue_callback_4CF$VARIANT$mp + 1044
9  CoreFoundation                 0x193e385e4 CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE + 12
10 CoreFoundation                 0x193e335d8 _CFRunLoopRun + 2004
11 CoreFoundation                 0x193e32adc CFRunLoopRunSpecific + 464
12 GraphicsServices               0x19ddb8328 GSEventRunModal + 104
13 UIKitCore                      0x197f2dae0 UIApplicationMain + 1936
14 goiq                           0x100843f44 main + 16 (main.m:16)
15 libdyld.dylib                  0x193cbc360 start + 4

It seems like you may have some memory management issue. I suggest you enable some of the memory diagnostics like Zombies or the Memory Sanitizer. Unfortunately there's not much we can do to help with these sorts of issues, so I suggest other support forums online. If you do find a bug in Alamofire, feel free to open another issue following our issue template with all of the appropriate details and we can investigate.


Bug: "An error occurred while trying to export the selected file"

Debug log ID
RCYJ3YSL-refs-euc/6.7.143-6
What happened?
This problem is really similar to that shown in: https://github.com/retorquere/zotero-better-bibtex/issues/1575
Steps to reproduce:

open Zotero
right click on "My Library" on the left panel
click on "export library" in the context menu
choose the "Better BibLaTeX" format in the pop-up menu
uncheck all boxes in the 'Translator Options' of the pop-up menu
click on the 'OK' button
choose a file name and click on "Save" on the Windows Explorer pop-up menu

Expected behaviour:
exporting a .bib file for my whole library
Actual behaviour:
pop-up saying: "An error occurred while trying to export the selected file."
Notes
I tried to export each collection separately and no errors occur...

You're actually running into #2315. I'm working on something that will relieve memory pressure, but that's a fair bit of work, and I don't know how long it will take. I see you've already turned off the cache, so short-term there's nothing that can be done about this (except moving to Zotero 7).

The fix will be communicated on #2315, if you want to be kept updated, please join that issue.

Hi, Thank you very much for the answer. I'll look at https://github.com/retorquere/zotero-better-bibtex/issues/2315 then. Good luck with the fix!
(By the way, if the issue is about the memory i can just select a smaller portion of my library to be exported, i guess)

I wanted to add a quick tip to solve this problem easily (up to a certain extent at least). The issue is related to memory, therefore reducing the data to export fixes it. So, instead of exporting your library by splitting it into different .bib files, you can export your library altogether but with less information for each database entry. Anyway, many fields will not even show up in your bibliography (e.g. the 'abstract' field).
So i did the following:

Tools --> better bibtex --> open better bibtex preferences --> Export --> Fields --> 'Fields to omit from export (comma-separated)'
then I put in the following list (I prefer simple bibliographies, everyone uses Google Scholar anyway): 'url, doi, language, urldate, note, annotation, file, abstract, keywords'


Not maintained. Alternative?

Buster isn't maintained anymore. Sorry for the trouble!
If you want Ghost and static site generation, checkout publishing static sites with Ghost and Gatsby:
https://www.gatsbyjs.org/blog/2019-01-14-modern-publications-with-gatsby-ghost/
https://docs.ghost.org/api/gatsby/
It's still early days for that project but looks like it's the right way to go.

If anyone's looking for a set-and-forget type of setup, I build Sitesauce inspired by Buster. You just enter the URL to your site (Ghost or whatever platform you are using) and get a static site generated and uploaded to ZEIT automatically. You can also configure it so that your site is automatically regenerated when you change your content (with a first-party Ghost integration!).

I wrote a Python 3 script to do something like this, which doesn't use wget: https://github.com/arktronic/ecto1


greater support for shell-like .env files

Tweak sbt-dotenv internals so we handle .env files that are more like other dotenv handlers.
In order to make sbt-dotenv handle .env files I had to make some changes to existing behaviour:

Variable values containing hash (#) characters now need to be wrapped in quotes so that they aren't judged to be the start of a comment
Quoted variable names are now de-quoted and any escaped quote characters inside are unescaped

Closes #22

@Philippus if you don't mind casting your eyes over this too.
I can't see an issue with it given the backwards compatibility, but it's been a while since I've been in the scala ecosystem so could be blind to certain things.

Will update the usage docs :+1:
I'm also trying to fix the scripted part of the build but it's a bit of a struggle to get decent feedback from those tests.
The Codacy check is complaining about the regex which seems a bit over-eager.

the check-special-cases test case is probably failing because behaviour has changed for single quoted variables: https://github.com/mefellows/sbt-dotenv/blob/master/src/sbt-test/sbt-dotenv/check-special-cases/build.sbt#L11

@mefellows README updated, still working on the tests

Okay the scripted tests are passing too and the README has been updated

@Philippus done 👍

Awesome work - thanks guys!!


Playing with scriptgen to generate scripts to push out to rings

java -jar /home/jose/dev-ring-getting-started/sdks/jc212_kit/lib/scriptgen.jar MyApplet.cap -o test.scr -nobanner -nobeginend
Example of grepped & parsed w/ sed output
// ExampleProject/javacard/Header.cap
80 B2 01 00 00 7F
80 B4 01 00 12 01 00 0F DE CA FF ED 01 02 04 00 00 05 01 02 03 04 05 7F
80 BC 01 00 00 7F

// ExampleProject/javacard/Directory.cap
80 B2 02 00 00 7F
80 B4 02 00 20 02 00 1F 00 0F 00 1F 00 0C 00 15 00 2A 00 0C 00 5D 00 19 00 10 00 00 00 61 00 02 00 01 00 0C 02 7F
80 B4 02 00 02 01 00 7F
80 BC 02 00 00 7F

// ExampleProject/javacard/Import.cap
80 B2 04 00 00 7F
80 B4 04 00 18 04 00 15 02 04 01 07 A0 00 00 00 62 01 01 00 01 07 A0 00 00 00 62 00 01 7F
80 BC 04 00 00 7F

// ExampleProject/javacard/Applet.cap
80 B2 03 00 00 7F
80 B4 03 00 0F 03 00 0C 01 08 01 02 03 04 05 06 07 08 00 13 7F
80 BC 03 00 00 7F

// ExampleProject/javacard/Class.cap
80 B2 06 00 00 7F
80 B4 06 00 0F 06 00 0C 00 80 03 00 FF 00 07 01 00 00 00 21 7F
80 BC 06 00 00 7F

// ExampleProject/javacard/Method.cap
80 B2 07 00 00 7F
80 B4 07 00 20 07 00 5D 00 05 40 18 8C 00 00 18 19 1E 04 41 19 1E 25 8B 00 01 7A 05 30 8F 00 02 3D 18 1D 1E 8C 7F
80 B4 07 00 20 00 03 3B 7A 05 21 18 8B 00 04 60 03 7A 19 8B 00 05 2D 1A 04 25 75 00 24 00 01 00 00 00 09 7B 00 7F
80 B4 07 00 20 06 03 1A 08 7B 00 06 92 5B 8D 00 07 3B 19 08 7B 00 06 92 5B 8B 00 08 70 08 11 6D 00 8D 00 09 7A 7F
80 BC 07 00 00 7F

// ExampleProject/javacard/StaticField.cap
80 B2 08 00 00 7F
80 B4 08 00 1C 08 00 19 00 02 00 01 00 01 03 00 0C 48 65 6C 6C 6F 20 57 6F 72 6C 64 21 00 00 00 00 7F
80 BC 08 00 00 7F

// ExampleProject/javacard/ConstantPool.cap
80 B2 05 00 00 7F
80 B4 05 00 20 05 00 2A 00 0A 06 80 03 00 03 80 03 02 01 00 00 00 06 00 00 01 03 80 03 03 03 80 0A 01 05 00 00 7F
80 B4 05 00 0D 00 06 80 10 01 03 80 0A 08 06 80 07 01 7F
80 BC 05 00 00 7F

// ExampleProject/javacard/RefLocation.cap
80 B2 09 00 00 7F
80 B4 09 00 13 09 00 10 00 00 00 0C 05 0B 06 07 08 07 10 06 05 06 05 08 7F
80 BC 09 00 00 7F

Unfortunately as I don't have working APDU auth yet I can't test playing this script into a ring ;-(

See the installForLoad function in node-gp where we build an array of APDUs. This would be 99% of a cap to script tool.

Now i finally got node-gp working i could put some time into this.
Don't know if i should make a pull request to node-gp with some kind of cap to script export method or start from scratch, what do you guys think?


Avoid flip-flopping impl items when reordering them

Closes #2634.
(The actual relevant commit that fixes the issue is the second one, I am sorry for constructing a poor commit log.)

Thanks!


is toastr asynchronous?

Hi, is toastr asynchronous under the hood ? Consider:
toastr.success('foo', 'bar');
toastr.success('ddd', 'bar');
toastr.clear();
toastr.success('yyy', 'last toastr');

I'd expect that end user will be able to see only last toastr toastr.success('yyy', 'last toastr'); ,
but instead of that he can see all of them (despite toastr.clear())
http://plnkr.co/edit/LDzttjFUxZzTHOfXCrvh?p=preview
And now the most important question: is it possible to achieve that ?

This is an interesting question and clearly seems to not work. I really need to think about this.

OK, I'll take a look in the code later this day and maybe can help somehow :)

I have been thinking on making the toasts return a promise and have .clear work with them, but I am really busy at work this days so I can't spare too much thought right now.

+1 I have the same issue here.
It would be great if the toasts could be synchronous.


Issue to trigger new releases

@JuliaRegistrator register branch=master

@JuliaRegistrator register branch=master

Registration pull request updated: JuliaRegistries/General/101486
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 63a1f8fcdea7ac95e1f3f2d3ea630c041ef7684e
git push origin v0.1.0

@JuliaRegistrator register branch=master
Release notes:

Add the TumorGrowth model for exponential growth/decay (#12)

Registration pull request created: JuliaRegistries/General/111567
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.0 -m "<description of version>" ca071f5c0c3c9807c2d4df261ecd625108124eb6
git push origin v0.2.0

@JuliaRegistrator register branch=master
Release notes:
This breaking and substantial refactor:

adds an option to use Levenberg-Marquardt or Powell's dog leg optimisers
redesigns the model API
changes the way parameter bounds are handled
renames n_iterations -> iterations
removes the feature optionally exposing the carrying capacity in bertalanffy2 output, and its inclusion in plots

Registration pull request created: JuliaRegistries/General/112193
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.3.0 -m "<description of version>" 606b739a96373ba5358cd041f4d7f7a093921e0a
git push origin v0.3.0

@JuliaRegistrator register branch=master
Release notes:
This breaking and substantial refactor:

adds an option to use Levenberg-Marquardt or Powell's dog leg optimisers
redesigns the model API
changes the way parameter bounds are handled
renames n_iterations -> iterations
removes the feature optionally exposing the carrying capacity in bertalanffy2 output, and its inclusion in plots

Registration pull request updated: JuliaRegistries/General/112193
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.3.0 -m "<description of version>" d607d789594ac1c54349ea69251e3e0116d57700
git push origin v0.3.0

@JuliaRegistrator register branch=master

Registration pull request created: JuliaRegistries/General/112457
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.3.1 -m "<description of version>" 022ed48725193e42328d33840216bb8802414b39
git push origin v0.3.1

@JuliaRegistrator register branch=master

Registration pull request created: JuliaRegistries/General/119789
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.3.2 -m "<description of version>" 2bbfa71854a0c03de21c08e4c2e018e92ff672fe
git push origin v0.3.2


addressing unexpected place startups

This logs the invisible places started up during server startup. In the future, we could build out functionality for stopping invisible places that started up unannounced.

so a couple of updates to this pr:

rather than the verify method not returning anything, I've made it return a boolean. Feel this will be useful in the future for wanting Emissary to shutdown IF places are started invisibly, but for now it still at least currently logs invis place startups as well.
@jdcove2 mentioned moving activeDirPlaces to the method, I currently left that out, as I think it may be useful to elsewhere for shutdown later on, and if not, then I can move it within the method.
wrote out unit test to test the functionality of verifyNoInvisiblePlaceStarted


e2e framework - dynamic loading new controller definition with new config map

Summary
Add an e2e test case for NumaflowControllerRollout in which we load a new Numaflow Controller definition configmap and see that the NumaflowControllerRollout creates that controller.
Use Cases
e2e testing

Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@xdevxy is this the correct description for the test case you had in mind?

@xdevxy  Is this the case in which the definition of a given Controller version actually changes? I don't think we will support that, right?


Adding create.crd and create.faas flags

booth default to true

this allows for separate releases for crd and faas

also allows for multiple faas releases in different namespaces

LGTM

rebased and merged as https://github.com/markfisher/sk8s/commit/3c78f31d76480e2cceecc5fb358cbb0a072c8fd5


Support polling interval in Gapic Java

GAX change: https://github.com/googleapis/gax-java/pull/195

Codecov Report

Merging #988 into master will increase coverage by <.01%.

@@             Coverage Diff              @@
##             master     #988      +/-   ##
============================================
+ Coverage      85.2%   85.21%   +<.01%
- Complexity     3354     3358       +4
============================================
  Files           341      341
  Lines         13376    13383       +7
  Branches       1523     1525       +2
============================================
+ Hits          11397    11404       +7
  Misses         1544     1544
  Partials        435      435

Impacted Files
Coverage Δ
Complexity Δ

...m/google/api/codegen/config/LongRunningConfig.java
33.33% <100%> (+6.66%)
3 <ø> (+1)
:white_check_mark:

...pi/codegen/transformer/ApiCallableTransformer.java
98.25% <100%> (+0.03%)
23 <ø> (+1)
:white_check_mark:

...gle/api/codegen/viewmodel/ApiCallSettingsView.java
85.71% <100%> (+2.38%)
4 <2> (+2)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 482ff37...9a9988d. Read the comment docs.

LGTM


Per Tenant setting: requests-through-public-did

Since I can define per tenant the setting public_invites, it would be great that I could also set per tenant the requests-through-public-did (in a case where I have a tenant that wants to receive those public did requests, but all other tenants don't).

Thanks — this is correct. @esune — is there a pattern/approach for making configuration parameters tenant-specific vs. global?

We have implemented an endpoint in a Traction plugin to facilitate setting these at runtime: see this. I believe that anything listed in this map is supported: we started with a subset of all the options that were available as there are several and we were not sure whether this would be useful for us only or others. I think if there are other flags that would be good to have set at a tenant level they just need to be added to that list.
c.c.: @shaangill025 for more insight.

We have implemented an endpoint in a Traction plugin to facilitate setting these at runtime: see this. I believe that anything listed in this map is supported: we started with a subset of all the options that were available as there are several and we were not sure whether this would be useful for us only or others. I think if there are other flags that would be good to have set at a tenant level they just need to be added to that list.
c.c.: @shaangill025 for more insight.

@esune , is there a plan to add this requests-through-public-did flag to that per-tenant list? Don't think that would be a breaking change to aca-py, since the global flag is there since 0.9.0.

@esune , is there a plan to add this requests-through-public-did flag to that per-tenant list? Don't think that would be a breaking change to aca-py, since the global flag is there since 0.9.0.

Looping-in @swcurran and @dbluhm for additional opinions. I don't think it is planned, but I don;t see an issue in having that setting be part of the per-tenant customizations.
@thiagoromanos if you have bandwith a PR is always welcome 😉

Agree.  I’m hoping it is well documented how to make a setting a per tenant setting so that we can easily add new ones that make sense.  Agree that this is one.


Task bounce expires but no new task scheduled

Today we experienced a task which was commanded to bounce, but the new task was unable to launch for some reason.  This led to a state where the existing task is in the CLEANING state waiting for a new task to come up, but there was no scheduled task ever to be seen.  Seen on 0.4.11
Singularity logs for the task

We've found the issue for this, but the solution might be a bit tricky. Main issue is that we weren't updating the task history. We remove the cleanup, but because the last history is a cleaning state, the task remains in cleaning.
Unfortunately the solution is not as simple as adding another history entry, because the states are stored in zk under the extended task state (i.e. TASK_RUNNING is part of the zk path) and are assumed to come in a logical progression. So we can't just add another TASK_RUNNING on the end. We are investigating options still, just wanted to keep this updated.

Thanks for looking into this, this is the first time we've seen this so I can't claim it's super urgent for us.  But I bet it happens elsewhere and nobody notices, so it'd be worth fixing anyway :)
Excited to see what the solution ends up being.

Meant to clarify this more the other day. The 'no new task scheduled' part of this actually correct, just the display of the task as still being in cleaning is wrong. We have deleted the request for singularity to clean/replace the task, but because of the task history update for the TASK_CLEANING state still being present, the task still shows as being in cleaning when it should actually be running. Currently, looks like our solution is going to be to remove that TASK_CLEANING history update (as long as there is no other reason for it to be cleaning) to return it to it's previous status.
This will be fixed by #975


Support arbitrary bytes in credentials

Required for eminence.
Also bump IO test iterations to fit with the guidelines.
@markhibberd

Missing a chance inline with second comment or?


Bluetooth doesn't work

I found a new problem with Bluetooth. The option appears and can be turned on and off. But when pairing/searching for devices it does nothing. If you could help me solve this problem.I thank you.

Enable these services via registry:
DeviceAssociationBrokerSvc
DevicesFlowUserSvc
DevicePickerUserSvc

we need video for this problem bluetooth please i will use that but i can`t

I literally left a fix for this issue on top, just enable those services via registry in the services path.

i can’t enable that because i have problems he said the parameters is
incorrect
في خميس، ٢٠ يونيو، ٢٠٢٤ في ٦:٠٢ م، كتب ancel @.***>:

I literally left a fix for this issue on top, just enable those services
via registry in the services path.
—
Reply to this email directly, view it on GitHub
https://github.com/ancel1x/Ancels-Performance-Batch/issues/6#issuecomment-2180928604,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BJHMETGQWLYDKQ7RNRIRFS3ZILVJ3AVCNFSM6AAAAABDHPWZU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBQHEZDQNRQGQ
.
You are receiving this because you commented.Message ID:
@.***>


[Feature Request] c# warper support

🚀 Feature

Motivation

Alternatives

Additional context

Thank you for your suggestion, as of now we do not yet have plan to add c# wrapper, However, the C++ API could be a good starting point to bring related support to C#.


Motion_detection_image topic suffix: no messages

When I subscribe to the topic: "yicam-1/motion_detection_image" no message is sent.
If I subscribe to the topic:  "yicam-1/motion_detection" start and stop message are sent.

Are you using the last version?
Do you have human detection enabled?
I tested again now and it works.

Yes I'm using the latest version. I tested it with human detection enabled and disabled and I listen to all topics looking for the message but no message containing the image is present: only motion_start/stop online are printed. I will investigate more and see if a message containing the image will arrive. Thanks for the quick response @roleoroleo

I'm using this command with mosquitto:
mosquitto_sub -v -h <IP_ADDRESS> -t home-assistant/yi-cam/#

Logging with MQTT-FX is working. In my application I'm using Paho-Mqtt python library. I will investigate why it doesn't receive the message.

I close the issue because now is working in Paho-mqtt.


--cnn_center_x/y/z arguments

Issue summary
Hi, Sir. I would like to ask about CNN center arguments. What do these coordinates correspond to?
Thanks!
Fatih
Steps to reproduce
Your system configuration
Operating system:
Compiler:
CUDA version (if applicable):
CUDNN version (if applicable):
Python version:

The coordinates correspond to the center of the grid used to discretise the protein-ligand binging site (used as input of the CNN).

Generally speaking, you should not set them.


fix: cancel pending-delete should increase resource quota usages

这个 PR 实现什么功能/修复什么问题:
修正：回收站资源恢复后，资源使用量未增加

是否需要 backport 到之前的 release 分支:

release/3.3
release/3.4

/cc @zexi
/area util

/hold

Codecov Report

Merging #8337 into master will decrease coverage by 2.59%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #8337      +/-   ##
=========================================
- Coverage    6.13%   3.53%   -2.60%
=========================================
  Files         762     304     -458
  Lines      118312   62528   -55784
=========================================
- Hits         7256    2213    -5043
+ Misses     110401   60162   -50239
+ Partials      655     153     -502

Flag
Coverage Δ

#aFlag
3.53% <ø> (-2.60%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/multicloud/aws/loadbalancerlistener.go

pkg/cloudcommon/db/opslog.go

pkg/cloudcommon/validators/validators.go

pkg/cloudcommon/db/statusinfrasresource.go

pkg/mcclient/options/loadbalancercertificates.go

pkg/util/seclib2/ssh.go

pkg/compute/guestdrivers/openstack.go

pkg/multicloud/ucloud/storagecache.go

pkg/util/httputils/fs.go

pkg/baremetal/tasks/rebuild.go

... and 446 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 928f6c9...d0a59d4. Read the comment docs.

/hold cancel


Build library sources in src/ext

These changes add to the library all sources in src/ext, and also ensure the includes in inc/ext are passed to GCC during builds.

Thanks, I already made the changes internally after merging the megawifi changes :D

Great :+1:

Ok i just pushed the changes. I hope i didn't break anything but it looks like to be ok (tested with partial Megawifi support from BlastEm) =)


[MM-37189] fix style issue in ProductNoticesModal

Summary
Css of ProductNoticesModal was getting overridden because of recent changes intended to increase the css of specificity of GenericModal css. These changes are increasing the css specificity ProductNoticesModal.
Ticket Link
https://mattermost.atlassian.net/browse/MM-37189
Related Pull Requests

None

Screenshots

Release Note
 fixes style issue with ProductNoticesModal

Hello @AshishDhama,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@esethna can you please take a quick look and confirm that the modal looks as expected now (based on the attached screenshot)

@esethna I have fixed breaking UI, I see scope of further improvement, subtle difference in Figma and Actual implementation.
But I think that we need to do in other modal as well

@esethna

@jgilliam17 can we confirm that this does not affect the styling of the custom category creation/rename modal, or the CRT beta warning modal when CRT is enabled via account settings

@esethna Due that bug @ogi-m mentioned during the call we can test it right now in single go as first time it will show multiple and once you refresh it will show single.

can we confirm that this does not affect the styling of the custom category creation/rename modal, or the CRT beta warning modal when CRT is enabled via account settings.

Tested. Does not impact custom category creation and rename modals, nor CRT beta warning modal.

@amyblais can we please get this in the soonest cloud release as well?

/cherry-pick cloud

Cherry pick is scheduled.


WIP: Add ESLint as a dev dependency and add some basic rules.

This is a WIP because it's using the default ESLint ruleset which is quite strict. Please review the rules, they can be set in .eslintrc and at the file level. Default settings for node and browser environments have been added.
I'm all for strict linting so let's not disable a rule unless we have a good reason.

Will address #10 .

@sponte your merged the WIP pull request :smile: fine with me if you are happy with the current linting rules.


Support standalone generation of swagger.json

This is not an issue, more of a question of understanding:
From the examples, it seems like the intended use of this library is at runtime of the Nancy application. That is, annotations or metadata modules are used to produce a .../swagger.json path on the web server where the Swagger definitions can be accessed.
Is there any support for generating this file in a standalone project? For my use case, I would very much prefer the "simple" approach of adding a new C# project referencing my Nancy project, analyze its annotations, and write the output to a file (which I can then publish/use/... separately).
(I would use this e.g. on CI to generate the swagger.json for manual inspection)
If this is not yet possible, and there is some interest in it, I would be happy to provide a PR.

Yeah, the project is designed for hosting the swagger.json at runtime.
But if your new project would have access to the Dependency Injection container, you could use that to get the ISwaggerMetadataProvider and just call this function:
provider.GetSwaggerJson(null).ToJson();
As the SwaggerModule does: https://github.com/yahehe/Nancy.Swagger/blob/master/src/Nancy.Swagger/Modules/SwaggerModule.cs
Though that null should be the Context. (I believe the Context object is only available during requests, but I'm not sure.) The Context object is not used by the Nancy.Swagger ISwaggerMetadataProvider, but by the Nancy.Swagger.Annotations ISwaggerMetadataProvider. So this method would not work for the Annotations method.
There might be some other solutions, but if you also want to create a PR to make this supported by default, go ahead.

Thanks for the explanation!
I'll get started with implementing a proof of concept, try out the methods you described and come back to you.

What use case do you envision where you do not want the swagger.json to be dynamically created? If your service also provides the swagger-ui (or you have a separate solution for swagger browsing) you should be able to just check that page at runtime and see if your documentation is what you expect.

I don't think it's unreasonable to have some sort of functionality that allows for generating json or yaml files though, I know for example AWS API Gateway allows for uploading a swagger file and generating a service skeleton from that

I am planning to version the finished swagger.json correctly and then generate a client library of Typescript definitions for that version. I would then consume these definitions in a client accessing the described API.
By including the additional step of using a swagger.json without needing the actual API around, I can verify the API and client separately by verifying that they both adhere to the Swagger definitions.


Move all tests to separate testing pkg

Motivation
We are not using white-box testing in newly styled NSM repositories. So then we should move all tests to separate pkgs and make sure that we are not testing private states
https://github.com/networkservicemesh/cmd-forwarder-sriov/blob/master/local/sdk-sriov/pkg/k8s/manager_test.go#L17

Fixed.

Fixed.

@Bolodya1997 Nice! Let's attach a link to PR and this one can be closed

@Bolodya1997 Nice! Let's attach a link to PR and this one can be closed


Remove Hide GIF/Gift Button button features

Reasoning is quite simple. The feature is broken more often than it actually works. It hasn't been working for months at this point again so I would just drop it directly instead of having some kind of deprecation period.
People suggesting dropping it from BD and replacing it with an official plugin was the main reason I created the RemoveChatButtons plugin. The plugin has the advantage of not being tied to BD updates if it breaks and even falling back to a CSS-only mode if it can't apply patches.
Closes #857, #841

This was removed


Idanode Submission

INDIRIZZO_IP: <IP_ADDRESS>
PUBKEY_IDANODE: 03cc2ba0339aa1968086547743d3d005b2faddfd42c6a59fbe820edf781f83a7f5

INDIRIZZO_IP: <IP_ADDRESS>
PUBKEY_IDANODE: 02065776a04416694eb3c440500718a7db504c1c42a9cd43ec036fa5c40c09bb39

Assigned domain is https://idanodejs08.scryptachain.org please run following commands inside scrypta-idanodejs folder:
chmod 777 secure.sh
./secure.sh idanodejs08.scryptachain.org

Last command will produce the instructions to secure the idanode with certbot.

Added with commit https://github.com/scryptachain/scrypta-idanode-network/commit/b9a461c9171f2fad33865424cc8a8358136ca20d


Display Kaltura embed code snippet on A/V object view

Add a section to the object view on A/V objects, to display the embed code for the Kaltura viewer for that object

done in viewer


Webpack issue

I get an error when building with Webpack:
ERROR in [at-loader] ./node_modules/angular2-notifications/src/simple-notifications/services/notifications.service.ts:51:72
TS7017: Element implicitly has an 'any' type because type 'Icons' has no index signature.
The way I fix it is to change line 51 in the notifications.service.ts from:
return this.set({title: title, content: content, type: type, icon: this.icons[type], override: override}, true);

to:
return this.set({title: title, content: content, type: type, icon: (<any>this.icons)[type], override: override}, true);

You've opened an issue on the wrong library.


overnode launch fails on non-amd64 platform

Hello!
I came across this issue while trying to run overnode on an Odroid N2+, which has an arm64 (armv8) architecture. When running overnode launch, the docker-compose command fails, because it cannot find a platform-matching docker-compose image. Until https://github.com/docker/compose/issues/6831 gets resolved on the docker-compose site, there are only amd64 docker-compose images.
Wanted solution:
Until docker-compose fixes its issue, I would prefer switching to the linuxserver/docker-compose image, because it is multi-arch enabled. However, the tag naming scheme is slightly different.
Currently, I am trying to build the docker-compose image myself to check whether the latest docker-compose Dockerfile produces at least a working armv8 image.
Best regards,
Miroka

@jtagcat do you think it is reasonable to switch to linuxserver/docker-compose? I understand it is not official by docker...

I'd say yes. Linuxserver is quite reputable. They official and linuxserver image may have differences — the change would need to be tested.

Will docker pull automatically detect which architecture container to download?

I think so, but it needs to be tested.

@Miroka96 then I believe you better propose pull request and test it for us. I do not have time capacity available to address this. Thanks.


Workflow updates from devel to main

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


[release-1.17] gateway-api: fix naming override

Manual cherrypick required.
#44365 failed to apply on top of branch "release-1.17":
Applying: fix gateway service name
Using index info to reconstruct a base tree...
M	pilot/pkg/config/kube/gateway/conversion.go
M	pilot/pkg/config/kube/gateway/conversion_test.go
M	pilot/pkg/config/kube/gateway/deploymentcontroller.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/config/kube/gateway/deploymentcontroller.go
CONFLICT (content): Merge conflict in pilot/pkg/config/kube/gateway/deploymentcontroller.go
Auto-merging pilot/pkg/config/kube/gateway/conversion_test.go
Auto-merging pilot/pkg/config/kube/gateway/conversion.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix gateway service name
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

https://github.com/istio/istio/pull/44382 which was to fix this is merged.


GE wrong number of released on 2020-04-09

The number of released in the xlsx is 435, which is lower than the previous day (442).

In #823 the value has been removed (set to empty), and #820 ensures that the scraper does currently not overwrite the value. This condition can be removed, once the source xlsx has been fixed.

I added a TODO to the scraper, I close this issue here.


SCIM object in access policy doesn't work on production env

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Affected Resource(s)

zpa_policy_access_rule

Code extract

Expected Behavior
Running the deploy on ZPA Beta

Actual Behavior
Running deploy on ZPA Production
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Creating...
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [10s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [19s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [28s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [35s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [42s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [49s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [56s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [1m5s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [1m14s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [1m24s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [1m35s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [1m47s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [2m0s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [2m13s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [2m25s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [2m36s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [2m45s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [2m54s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [3m2s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [3m8s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [3m15s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [3m21s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [3m28s elapsed]
module.manual_access_policy.zpa_policy_access_rule.group_access_policy["AllowToto"]: Still creating... [3m36s elapsed]
Steps to Reproduce

Create a zpa_policy_access_rule with operands having object_type=SCIM
terraform apply (on production env)

Hi @willguibr,
Thank you for the response. I'm aligned with the pre-validation as possible.
However, the values pre-validation should be limited to some fields having pre-defined values.
The code is getting all values for the userName attribute:

That make call to /userconfig/v1/customers/XXXXXXXXXXXXXXX/scimattribute/idpId/YYYYYYYYYYYYY/attributeId/XXXXXXXXXXXXX
We have tens of thousands users, so every pre-validation loads more than 3000 pages.

@dabi0ne Issue has been addressed in the latest SDK release v1.4.7 and provider version v2.7.4.
Please let us know if the issue still persists.
Thanks
William

Hi @willguibr the issue is fixed when we use userName in policy, thanks !
However, it still here when we try to get userName SCIM attribute :

The data source loads all value of the attribute: https://github.com/zscaler/terraform-provider-zpa/blob/master/zpa/data_source_zpa_scim_attribute_header.go#L94


Is it possible to style content in the placeholder area

Version
4.7.2
Here's what went wrong:
When items are selected we would like to style the number of items selected so it jumps out that we are filtering the page.
In the example below when you select items it uses the manySelectedPlaceholder to display the number of items selected. We would like to use some styling to show the number emphasized. Ideally we would like to show the number in a blue circle (with white font).
If not - is it possible that Inline Styles or markup support be used for the placeholder?
Thoughts? Is this possible?
Example
https://codesandbox.io/s/picky-demo-qnnns

Hi @mpGitHub
The only way I can think to get this to work is to pass a className to buttonProps (see readme).
See my updated example below, if items are selected then we return an object which contains a className.
https://codesandbox.io/s/picky-demo-b6qhu
Excerpt:
 get buttonProps() {
    if (this.state.arrayValue.length > 0) {
      return {
        className: "placeholder--isactive"
      };
    }
  }

 render(){
   return <Picky
     buttonProps={this.buttonProps}
     // Rest of props
    />
  }

You can also return a style if that's more your thing:
     return {
        style: {
          color: 'blue'
        }
      };


Simplify assert and stdout from library

It seems to me that the current code have mixed debugging feature and logging feature.  i.e) In order to print error log with csp_log_error(), we must enable CSP_DEBUG.  The function to set log level is called csp_debug_set_level(), instead of csp_log_set_level().  It might be a good idea to separate them.
  We only have csp_assert() for debugging.

So if I understand you correctly, you want to have CSP_DEBUG just control the CSP_ASSERT?
And rename debug_set_level to log_set_level.
Your point is valid.
It's been a while since this systems was made, and if I should make it again I would do the following:

Use native assert.h I don't know why this should have ever been it's own function. Maybe for portability. But i have yet to find one that didn't have assert.h

Delete the entire log system.

Introduce a set of variables corresponding to each of the 7 socalled log levels we have today. This set will be initialised like all the other

Okay yes we agree on the categories. This is what I meant with separate variables. One for each category. Like packet, drivers router and so on.
However I believe each category should be free to define its own levels, or bitfields (sub category). Like the error bit could be set simultaneously with a TX or RX bit or whatever flag that particular debug like will provide. As long as any bit is matched, it will produce an output.
So we can encourage the last four bits to always remain the same we have today. Err, warn, info, debug. And have the other fields in each category be free to choose from.
The call itself can be macroed or as a function call. To allow for external logging systems. However most systems should implement a way to catch stdout anyways.
We are moving more towards error counters, and we should be better to use them. Maybe together with logging for convenience.

It's actually a problem with assert.h, because it uses FILE which is considered harmful for reproducible builds. Because it contains the build folder. So one example could be if one developer builds his firmware in a short path /home/johan/git/proj, and another one has a longer name like /home/myverylongusername/git/mylongprojectname if you take this differece and multiply that with the numer of asserts in the code. The software image now does not fit the device. Changing the memory footprint and so on...

https://github.com/libcsp/libcsp/blob/5344d8d00b55ed8674f2bd32083fc1844b29acdc/include/csp/csp_debug.h#L81
One advantage of csp_assert() is that it has a hook, csp_assert_fail_action().  I assume we don't have it with standard assert().  But, a simple question, you don't want to use assert() in the FM / Release build, do you?

That's a tricky question.
I want reproducible builds, and i want to fly what i test. So YES, i want to fly the single "debug build". I just want it to fail nicely. So ideally each assert should be replaced with runtime recoverable faults, instead of the current action which is to crash the system. Even worse would be to run a build without debugging, and then just continue, potentially making more harm than a crash.
Another point is that csp_assert_fail_action() is rather useless, because i think it's individual which action should be made when an error is encountered. Sometimes you need to free some resources and return a known value. The issue with assert() is that it leaves the system in an unusable state.
The only advantage to assert is that it can be used to gain higher performance, by running rigorous testing in advance, and then removing all the error checking in a production release. However, this is NOT the philosophy i want to take. I want the code to be capable of detecting errors, and handle it gracefully. Even though it costs some performance to make the checks into runtime checks.
One method that we commonly use, is to have error counters being incremented, to let the operator aware that there is a code problem. I think the majority of the flash taken by the CSP library, actually consists of extremely verbose error messages. Many which could be replaced with simple counters or flags, raising the attention of the developer. After which, he could enable verbose debugging to include the printfs to stdout.

I want the code to be capable of detecting errors, and handle it gracefully.

I totally agree.  We want that in our flight software.  And the standard assert, or the mentality around assert isn't aligned to what we want.  This has been causing impedance mismatch in many projects.  Thus, my question: We do not want to use the standard assert() because it doesn't do what we want.

One method that we commonly use, is to have error counters being incremented

Yes, I'm aware of that.
And that is not CSP's job, IMHO.  Because it's nothing to do with network protocol.
I'd rather want libcsp to pass logging and error handing, or any other network protocol unrelated issues for that matter, down to the underlying OS or encapsulating framework.  To do that, I want libcsp to wrap as little arch specific functions as it needs, call them via wrapper in libcsp code base.
But this is a totally opposite direction if you want libcsp to be the cubesat framework.
I guess my question boils down to: "Where do you want libcsp to be?"  This is a question I wanted to ask you for quite a bit. It doesn't related to the assert issue but it'd be nice if you can give us some future direction you have.
BTW, in Zephyr, we have a plug-able logging framework; we can write a backend to do the error counting and reporting on our required request timing.

Okay, we agree thus far. Just one comment regarding the error counters. I think I do want to include the storage for those in the library. with the option of exporting them for mapping into users parameter system of choice. I will add a contrib file containing parameter mappings for our libparam. If zephyr has anything similar that could go in there too.


refactor(linter): move plugin options into separate struct

#5102
#5101
#5100  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on  Graphite


Insertion Sort | Golang

Title -
what will change -
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code
[x] Improving Code
[x] Improving Documentation
[x] Bug Fix

Programming Language
Please add/delete options that are not relevant.

[x] Python
[x] C++
[x] Java
[x] C
[x] Go
[x] Other language

Self Check

Ask for issue assignment before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Happy Coding,

Assign this issue to me I will be writing this in golang.


move-to-next-monitor issue w/ gnome-shell 3.30.1

move-to-next-monitor does not work on my system

gnome-shell v 3.30.1
gnomesome v 6

Here is some debugging info
[gnomesome] start action: handler for binding move-to-next-monitor
[gnomesome] Uncaught error in handler for binding move-to-next-monitor: TypeError: Utils.DisplayWrapper.getMonitorManager(...).get_n_monitors is not a function
roll_move_to_monitor@/home/ida/.local/share/gnome-shell/extensions/gnomesome@chwick.github.com/manager.js:423:26
wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
initKeyBindings/<@/home/ida/.local/share/gnome-shell/extensions/gnomesome@chwick.github.com/manager.js:117:80
_do@/home/ida/.local/share/gnome-shell/extensions/gnomesome@chwick.github.com/manager.js:250:13
wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
handleKey/added<@/home/ida/.local/share/gnome-shell/extensions/gnomesome@chwick.github.com/manager.js:225:41

Fixed by #16


current /home not rendering any content

const { userRecommendations } = this.props;
and userRecommendations seems to be an empty Array.
        {userRecommendations.map(
          userRecs =>
            userRecs.items &&
            userRecs.items.length && (
              <Recommendations
                key={userRecs.title}
                recs={userRecs.items}
                title={userRecs.title}
              />
            )
        )}

so nothing is rendered?

can't reproduce that. For my user w/o userRecommendations page was loaded correctly

If there are userRecommendations for the user in the correct format, something should be rendered.

I joined a public path called "First Public Path", which is the only public path available for me. And after joining that public path, the homepage still renders nothing. Above image is the console log.
How can I add data to my userID in recommendation?

oh, I thought you had completely empty page. For getting recommendations you have to fill /userRecommendations/{userKey}/{anyRecommendationsGroupKey}/{featureKey_featureTypeKey}.
e.g.
ref("/userRecommendation/<userKey>/anyRecs").set({
  title: "Some Title",
  foo_bar: {
    feature: "foo",
    featureType: "bar",
    path: "<pathKey>",
    problem: "<problemKey>"
  }
});

Maybe we should add something like /defaultRecommendations and show them for new users?


allow python subclasses of pyspiel.Policy

It would be nice if we could subclass pyspiel.Policy, and then pass those policies to pyspiel functions which expect pyspiel.Policys.
So something like this:
import pyspiel
class PolicySubclass(pyspiel.Policy):
    def __init__(self, game):
        pyspiel.Policy.__init__(self)
   def get_state_policy_from_state(self, state, player):
       ...
   def get_state_policy_from_infostate_string(self, infostate_string):
      ...

Currently, trying to do so throws an error __init__ must be called when overriding __init__ (https://github.com/pybind/pybind11/pull/2152), presumably because Policy has no constructor defined in policy.h. It looks like Game had the same issue, so a "trampoline class" was defined in open_spiel/python/pybind11/python_games.h. Would a similar solution should work for Policy?

From a quick read of the thread it seems like the trampoline class was needed because Game is not default constructible.
I wonder if we can just add an empty constructor in this case. @elkhrt, do you know?

This would be a great contribution! You'll still need a trampoline class, but the overall setup should be a lot simpler than with Game. There's an overview of the necessary setup here: https://pybind11.readthedocs.io/en/stable/advanced/classes.html

This is quite old, seems abandoned. @VitamintK please feel free to re-open if you ever get to this.


Message serialization and classes vs. plain javascript objects with React Server Components

Is your feature request related to a problem? Please describe.
Today @bufbuild deserialized grpc responses into generated classes based on protobuf. This makes using React Server Components somewhat cumbersome because the objects are not JSON.stringify serializable. Additionally, available serialization methods are relatively untyped. There is no method to produce a PlainMessage<MessageType> which might (?) work with JSON.stringify. Also, toJson produces a JsonValue instead of some type related to the original generated type (e.g. JsonValue<MessageType> similar to PlainMessage<MessageType>).
Here is a concrete example of what we're currently doing today to workaround this:
page.tsx (using Next@13)
export default function Page() {
  const answer = await eliza.say({sentence: "I feel happy."});

  return <AnswerViewWrapper answer={answer.toJson()} />;
}

AnswerViewWrapper.tsx
export interface AnswerViewWrapperProps {
  readonly answer: JsonValue;
}

export function AnswerViewWrapper({ answer }: AnswerViewWrapperProps) {
  return <AnswerView answer={SayResponse.fromJson(answer)} />;
}

AnswerView.tsx
export interface AnswerViewProps {
  readonly answer: SayResponse;
}

export function AnswerView({ answer }: AnswerViewProps) {
  return <span>{answer.sentence}</span>;
}

Describe the solution you'd like
Eliminate the need to break type safety, and ideally eliminate the extra serialize/deserialize step. Some options:

Move away from, or have an option for, generating plain javascript objects instead of classes. I'm sure there was a strong rationale for using classes, but generally, I believe that a more functional approach will lead to better compatibility across the stack. Use plain interfaces/data objects and provide functions for manipulating them rather than methods.
Provide better type-safe serialization/deserialization. E.g. toJson(): JsonValue<SayResponse> or toPlainMessage(): PlainMessage<SayResponse>

Describe alternatives you've considered

Use grpc-js or some other library. IIRC it has the same issues with class based objects, and overall poorer support.

Additional context
Add any other context or screenshots about the feature request here.

Hi @dicarlo2.  Can you provide a bit more detail on your setup?  Are you using Next.js with a custom server?  With API Routes?  We plan to offer better support for Next.js, so I want to get a better understanding of your environment.

Im experiencing this issue as well. Im using Qwik framework which can only use serializable values in a response from the server.
I can simply return MyMessage.toJSON(), however as mentioned this breaks type safety. There isn't any easily accessible interface to cast it as either.

I'm using react redux toolkit for managing states and having the same problem described here.
In short, It'd be great if I can use something like AsObject method that makes the class into a Javascript object with type information.
Context of the problem
The redux state must be serializable, meaning we cannot simply use classes as the state values IIUC.
As described in the previous comments, converting the value into JsonValue or binary loses the type information, which I want to avoid.
Examples
interface UserState {
  // I want to use the type information of `user_pb.UserProfile` instead of using JsonValue
  profile: PlainMessage<user_pb.UserProfile>
}

const initialState: UserState = {
  // this is not ideal initial state, as `new user_pb.UserProfile()` may not be serializable
  // this makes warning message described bellow
  profile: { ...new user_pb.UserProfile() },
}

export const getMyProfile = createAsyncThunk('user/fetchProfile', async (thunkAPI) => {
  const response = await userClient.getCurrentUser(new GetCurrentUserRequest())
  return {
    profile: response!.currentUser //This causes warning message described bellow
  }
})

Reference
Can I put functions, promises, or other non-serializable items in my store state? explains why the Redux does not want to have non-serializable items in the state.
Comments
Btw, this is a great library with a lot of well-defined interfaces 💡 I really thank you all for this project! 🙏

suggest:   use https://github.com/pmndrs/valtio to replace redux.

Added toPlainMessage function in @bufbuild/protobuf like the original suggestion.

Move away from, or have an option for, generating plain javascript objects instead of classes. I'm sure there was a strong rationale for using classes, but generally, I believe that a more functional approach will lead to better compatibility across the stack. Use plain interfaces/data objects and provide functions for manipulating them rather than methods.

It would be nice if someone elaborate why classes were chosen? Although toPlainMessage does the job, it makes usage of JS SDK in coupling with other framework quite a pain.

It would be nice if someone elaborate why classes were chosen? Although toPlainMessage does the job, it makes usage of JS SDK in coupling with other frameworks quite a pain.

Classes are a good fit for protobuf because schema information is required to serialize/parse, and classes can encapsulate function and schema information (also see the FAQ).
Especially with RSC, I agree that it is cumbersome to convert to a plain message. Did you know that you can easily roll your own client that returns plain messages?
We have an example for a custom client here. This example just modifies the types, but it should be straight-forward to convert to plain message.  There is also an example for a client with RxJS observables here.
It would be great to have an example for a plain client as well. Depending on how the ecosystem evolves, we're happy to add clients to @connectrpc/connect. An example would be a great start.

I'm using it with redux toolkit and redux-saga, tried toPlainMessage, Object.assign, lodash's cloneDeep as well, but it's not working for me. Eveytime it says toJSON failed for ‘value
^ @srikrsna-buf

@arpitBhalla Can you share a reproducible example?


Add SubjectAreaDefinition to types

As noted in #1641, Area 4 needs a new entity called SubjectAreaDefinition that has relationships to glossary categories, valid value sets, quality rules ....

Completed in 1.7


Fix incorrect indentation in docs.

Explanation: A small fix to .rst formatting that prevents docs from building under sphinx.
Scope of issue: Build breakage when sphinx is present.
Origination: Typo when written, as near as I can tell.
Risk: Minimal, unless sphinx changes its mind about valid docs.
Reviewed by: Jordan Rose
Testing: Normal regression tests.
Radar: rdar://37282724

@swift-ci please test

@swift-ci please nominate


Setup liberty to run SAP specific tests

This is the change necessary for this repository to turn on SAP specific testing in the nightly builds.

Note because I am adapting a Makefile from mitaka, this commit also picks up @pjbreaux 's gitlab name-fix change.


Want to add styling to the scroll bar of the website

Is your feature request related to a problem? Please describe.
Scrollbar is missing styling
Describe the solution you'd like
I want to add styling to the scroll bar of the website.it will improve the UI of the website.
Describe alternatives you've considered
No response
Additional context

We don't need this for now


Compatibility

Hello, will 4.0.0 be compatible with 1.19.0 node or will we have to wait for another version of db-sync?

Sorry, I have not tested it yet.

Just tested it. db-sync version 4.0.0 is 100% compatible with node version 1.19.0.

I can't seem to get mien running 1.18.0 or 1.19.0


Add .travis.yml

This should enable automatic Travis CI builds with gcc 4.8 and clang 3.4.
To make it work, you will need to go to https://travis-ci.org/ and enable Travis for your Vc repository.
Other compiler versions and compilers can also be implemented with a bit of work.

Nice. I have so far burned through hours of CPU time on FIAS machines to submit to a CDash dashboard (at https://cdash.gsi.de/?project=Vc). But something that integrates with github might be a nice addition. Especially useful would be compilation and unit tests on OS X, since I can't cover that yet.
AFAIK the make test target does not work with -j, still. You have to call ctest -j2 instead. Could you please rebase on current master, call ctest instead of make test and add OS X testing?

I rebased and am using ctest now. Porting it to OS X is unfortunately non-trivial, because the system compilers are too old and the package management works differently. I would suggest to merge this and make OS X a new issue for the future.

The builds should work on OS X now, but please note that a test segfaults with clang and gcc does not even compile.

Do you have a log of the crash?
I compile for Mac and the tests are running fine:
clang --version
Apple LLVM version 7.0.0 (clang-700.1.76)
Target: x86_64-apple-darwin15.0.0
Thread model: posix
2015-11-23 19:01 GMT+01:00 Vinzent Steinberg<EMAIL_ADDRESS>
The builds should work on OS X now, but please note that a test segfaults
with clang and gcc does not even compile.
—
Reply to this email directly or view it on GitHub
https://github.com/VcDevel/Vc/pull/70#issuecomment-159012814.

OS X with gcc 4.9:
$ make -j2
[  0%] Copy to /Users/travis/build/vks/Vc/build/sse_sorthelper_SSE4_1.cpp
Scanning dependencies of target download-testdata
[  1%] Downloading Test Data: reference-sincos-sp.dat
[  1%] Copy to /Users/travis/build/vks/Vc/build/trigonometric_SSE2.cpp
[  1%] Copy to /Users/travis/build/vks/Vc/build/trigonometric_SSE3.cpp
[  2%] Copy to /Users/travis/build/vks/Vc/build/trigonometric_SSSE3.cpp
[  2%] Copy to /Users/travis/build/vks/Vc/build/trigonometric_SSE4_1.cpp
[  4%] Copy to /Users/travis/build/vks/Vc/build/sse_sorthelper_SSE2.cpp
Scanning dependencies of target Vc
[  5%] Building CXX object CMakeFiles/Vc.dir/src/const.cpp.o
[  5%] Building CXX object CMakeFiles/Vc.dir/src/cpuid.cpp.o
[  6%] Building CXX object CMakeFiles/Vc.dir/src/support_x86.cpp.o
/Users/travis/build/vks/Vc/src/support_x86.cpp:54:no such instruction: `xgetbv'
/Users/travis/build/vks/Vc/src/support_x86.cpp:54:no such instruction: `xgetbv'
/Users/travis/build/vks/Vc/src/support_x86.cpp:54:no such instruction: `xgetbv'

OS X with clang:
The following tests FAILED:
	 50 - scatterinterleavedmemory_Vc_USE_MASKMOV_SCATTER_sse (SEGFAULT)
Errors while running CTest

Very cool vks! Thanks!


proxy: Update h2 to 0.1.3

Signed-off-by: Carl Lerche<EMAIL_ADDRESS>

Would you be up for automating PRs like this one? I built Dependabot to do that, and just added Rust support so am looking for beta testers. I ran it on my fork and it generated these PRs.
It's free for open source and always will be - I'm just looking for beta testers and advice. :octocat: