Name has been changed from the original repo

Signed-off-by: Olivier Lamy<EMAIL_ADDRESS>Link to GitHub repository

When modifying release permission
List the GitHub usernames of the users who should have commit permissions below:

@username1
@username2

This is needed in order to cut releases of the plugin or component.
If you are modifying the release permission of your plugin or component, fill out the following checklist:

### Release permission checklist (for submitters)
- [ ] The usernames of the users added to the "developers" section in the .yml file are the same the users use to log in to [accounts.jenkins.io](https://accounts.jenkins.io/).
- [ ] All users added have logged in to [Artifactory](https://repo.jenkins-ci.org/) and [Jira](https://issues.jenkins.io/) once.
- [ ] I have mentioned an [existing team member](https://github.com/orgs/jenkinsci/teams) of the plugin or component team to approve this request.

When enabling automated releases (cd: true)
Follow the documentation to ensure, your pull request is set up properly. Don't merge it yet.
In case of changes requested by the hosting team, an open PR facilitates future reviews, without derailing work across multiple PRs.
Link to the PR enabling CD in your plugin

### CD checklist (for submitters)
- [ ] I have provided a link to the pull request in my plugin, which enables CD according to the documentation.

### Reviewer checklist
- [ ] Check that the `$pluginId Developers` team has `Admin` permissions while granting the access.
- [ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
- [ ] If security contacts are changed (this includes add/remove), ping the security officer (currently `@Wadeck`) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it.

@timja Thanks
do you have any idea why is this failing?
https://github.com/jenkinsci/lib-fips-bundle-test/actions/runs/10829408036/job/30046917551

right it looks there is a version with an interesting number https://repo.jenkins-ci.org/artifactory/releases/io/jenkins/test/fips/lib-fips-bundle-test/-rc16.e95456a_916d7/

FWIW the prefix is intended for the GH repo name, not for the artifact ID, similar to how matrix-auth lives in matrix-auth-plugin.


tmt: initial enablement

@cevich @edsantiago @baude @Luap99 @flouthoc @mheon PTAL
This PR enables all tests for x86_64 and aarch64 on fedora, centos stream and rhel nightlies. The integration tests use the binary built by the copr rpm task, so they take a little longer. We can set them to not depend on the rpm task if it takes annoyingly long.

Why do we need so many distros to run unit an integration tests on?
Compile tests for RHEL seems like a good idea given https://github.com/containers/netavark/issues/775 but I don't see the point to run unit and integration tests on so many distros, once for x86_64 and aarch64 should be good enough IMO.
Also if we use tmt then we must configure the merge bot to actually block on these tests (it is not the case in podman so I am not sure if it is the case here). But I guess the merge bot is broken either way and allows merges without passing tests so that doesn't matter really to prevent early merges.

Even more important depending on dnf install at runtime will causes al lot of headaches down the road. Right now we static well known VM images that must be explicitly updated.
With this PR we get new compile/linting problems or general bugs in dependencies on random PRs that have nothing to do with it. And that is extremely annoying to deal with as developer.

First off, thank you @lsm5 for taking this on and experimenting with it.  It's certainly something worthwhile, since I don't pay much attention outside of maintaining our current (possibly inferrior?) setup.

Compute time is cheap, that doesn't bother me.  It's the potential for increased developer time/frustration I mostly have on my mind.

but I don't see the point to run unit and integration tests on so many distros

I also agree from the perspective of limiting the potential for flakes.

Also if we use tmt then we must configure the merge bot

The TMT setup has exactly the same problem as Cirrus that breaks the bot: Test names that change over time (they include release numbers).  Years ago when I investigated this in prow, there's no way to configure a wild-card match.  It's 100% exact name match or nothing and no in-between option.
There IS the possibility (and maybe need) to key the bot off of an aggregate "Success" task.  This is also handy because it clearly tracks which tests are REALLY required to pass, and lets you know immediately if one never "spawned" for some reason.

Right now we static well known VM images that must be explicitly updated.

Yes, this was done deliberately (again, surprise!) to save developer time/frustration.  IIRC, Lokesh said these "dynamic" environments are cached in some way.  But even with cache, the concern still applies IMHO. These environments will have both an increased chance of flakes and other unexpected outcomes due to dependence on runtime installation.
In all my experience working with various CI systems, runtime-updates are the one thing I can almost always point to as adding an unnecessary PITA factor.  But I'm also not one to overly criticize without trying to be constructive:
@lsm5 is it possible to hard-code each package version/release, and then we could (somehow) teach Renovate how to manage updates to them (maybe grouped all in one PR)?  Renovate can read new versions from a pretty large list of sources.
It's not a perfect solution (there would be some desync. from one repo. CI to another).  But maybe it's workable?

Why do we need so many distros to run unit an integration tests on?

Not our money. The people that maintain it told me we don't have to worry about capacity for the time being. Regardless, we can easily trim the number of envs the tests are run on.

Compile tests for RHEL seems like a good idea given containers/netavark#775 but I don't see the point to run unit and integration tests on so many distros, once for x86_64 and aarch64 should be good enough IMO.

IIUC, one of @edsantiago 's pain points was RHEL problems were found very late in the process. Either way, very easy to manage the test matrix and the integration tests don't wait on each other, so whatever test matrix we all can agree on is fine by me.

Also if we use tmt then we must configure the merge bot to actually block on these tests (it is not the case in podman so I am not sure if it is the case here). But I guess the merge bot is broken either way and allows merges without passing tests so that doesn't matter really to prevent early merges.

The tmt tests in podman so far are only reverse dependency tests on something outside our org and I didn't want to block on tmt until people had a good feel for it. I think just like cirrus we can create a success task and block on that once we're comfortable blocking on tmt and maybe removing cirrus.

@lsm5 is it possible to hard-code each package version/release, and then we could (somehow) teach Renovate how to manage updates to them (maybe grouped all in one PR)? Renovate can read new versions from a pretty large list of sources.

@cevich see: https://tmt.readthedocs.io/en/stable/spec/plans.html#install . We can install packages using URLs, so hardcoding shouldn't be a problem. We may need to decide what exactly we're testing though, do aardvark's integration tests fetch netavark from the distro's official repos, or from podman-next to be as close to upstream main as possible? I guess we could do both if we need both.

Why do we need so many distros to run unit an integration tests on?

Not our money. The people that maintain it told me we don't have to worry about capacity for the time being. Regardless, we can easily trim the number of envs the tests are run on.

Fair enough but I think they will care sooner or later and then we are in the same boat again. I see a lot of value in RHEL build tests as we depend on the rustc shipped there.

Compile tests for RHEL seems like a good idea given https://github.com/containers/netavark/issues/775 but I don't see the point to run unit and integration tests on so many distros, once for x86_64 and aarch64 should be good enough IMO.

IIUC, one of @edsantiago 's pain points was RHEL problems were found very late in the process. Either way, very easy to manage the test matrix and the integration tests don't wait on each other, so whatever test matrix we all can agree on is fine by me.

I think that is great for podman where we have runtime dependencies (or even netavark where we make use a lot of kernel networking APIs) but aardvark-dns is a standalone server so there is very little benefit IMO.
Instead it will multiply the changes for flakes which will be annoying.

The tmt tests in podman so far are only reverse dependency tests on something outside our org and I didn't want to block on tmt until people had a good feel for it. I think just like cirrus we can create a success task and block on that once we're comfortable blocking on tmt and maybe removing cirrus.

Yeah I think maybe I am missing the goal of this PR. I thought the point was to remove the current testing tasks.

Also for package versions netavark must be installed as latest version from main (the podman/next copr package should work fine), we cannot use the main distro versions as netavark and aardvark-dns must be kept in sync as we may change the API between them at any time.
Anyway I guess the biggest fear of mine would be the runtime breakages due whatever dnf update brings us. This would be a regular case because of the rustc updated which include new linter rules so the validate task would likely fail on each update.  I like the current way of having an explicit VM image update PR.

I think that is great for podman where we have runtime dependencies (or even netavark where we make use a lot of kernel networking APIs) but aardvark-dns is a standalone server so there is very little benefit IMO. Instead it will multiply the changes for flakes which will be annoying.

Sure, fine by me. I'll be happy to update to a smaller test matrix. FWIW, we currently don't have integration tests running in either fedora bodhi updates or rhel gating for aardvark-dns and netavark.

Yeah I think maybe I am missing the goal of this PR. I thought the point was to remove the current testing tasks.

Yes, that is one of the goals, though I don't know if we wanna do it in this PR itself or maybe let both TMT and cirrus live together for a while and then remove cirrus after some time. I'll defer to @edsantiago and @cevich .

Also for package versions netavark must be installed as latest version from main (the podman/next copr package should work fine), we cannot use the main distro versions as netavark and aardvark-dns must be kept in sync as we may change the API between them at any time.

ack

Anyway I guess the biggest fear of mine would be the runtime breakages due whatever dnf update brings us. This would be a regular case because of the rustc updated which include new linter rules so the validate task would likely fail on each update. I like the current way of having an explicit VM image update PR.

we could probably address this with installing a fixed version-release of rustc via rpm, or via their curl way and not run any dnf update before the validate task. The prepare step can be moved around into the individual tests and doesn't have to be global.

If you like to merge this as experiment without blocking anything on it that would be fine for me. We can see how stable it is over the next weeks and then later remove the cirrus jobs and block on the tmt jobs once we are confident.

If you like to merge this as experiment without blocking anything on it that would be fine for me. We can see how stable it is over the next weeks and then later remove the cirrus jobs and block on the tmt jobs once we are confident.

@Luap99 Thanks a lot. I'll wait to get acks from @cevich and @edsantiago

installing a fixed version-release of rustc via rpm

TMT should follow the setup currently used in c/automation_images.
Re: NV/AV sync:
TMT should be able to do this using the same cirrus-artifacts based mechanism, no?
Re: package updates and test-environment stability.
I found a package-repo. datasource in renovate (supports Fedora + CentOS, but no RHEL). When used with a regex-manager, it could handle managing package updates for the CI environment, substantially similar to what we do now with pre-build VM images.  It will be a brain-twister to configure it, but based on the example, seems possible.  It would need to be configured on a repo-by-repo basis, which could be a minor concern.
As an experiment, this all LGTM also.

Followup: Can TMT scoop up artifact files and present them via permalink (i.e. "latest")?

Re: NV/AV sync:

TMT should be able to do this using the same cirrus-artifacts based mechanism, no?

I think the already existent packit automation with the podman-next copr is enough, we do not need to copy files exactly.

we do not need to copy files exactly.

Ahh right, it's just using "good enough" RPMs.  k.

/lgtm
/hold

@lsm5 As a follow-up, would you be willing to experiment with that Repology datasource + regex manager (in this repo.) to see if it could replace our use of pre-built VM images in Cirrus while maintaining a developer-controlled update workflow?
I completely understand "no, Renovate is too hard".  Just thought I'd ask, since that solution could be generally applicable in an eventual Cirrus -> TMT migration IMHO.

/hold cancel

@lsm5 As a follow-up, would you be willing to experiment with that Repology datasource + regex manager (in this repo.) to see if it could replace our use of pre-built VM images in Cirrus while maintaining a developer-controlled update workflow?

@cevich sure, mind creating a jira with the exact requirements you're looking for?

Sure.


Circular Layout

It would be great to add a circular layout to the flowchart similar to visio. This could function as an easy way to create simple DFD's/Context Digrams.
Is anyone working on this?

No... but always happy for contributions...
Feel free to submit a PR


Improve getExpectedVariables in SPARQLRequest

Currently, the method getExpectedVariables in SPARQLRequest returns a set of variables only. This needs to be changed to return an ExpectedVariables instead. The underlying method getVariablesInPattern in QueryPatternUtils has to be changed for that. Jena's OpVars has a method called visibleVars that can be used here (it returns the union of the certain and the possible variables).

Addressed by commit https://github.com/LiUSemWeb/HeFQUIN/commit/2ee3c4a13fc5a9c9e58f1c733690288a1dd091ad


AT-24: Save locations for easy access

Test Case ID: AT-24
User Story: CC-36 (#36)
As a user, I want to be able to save my favourite locations so that I can easily locate them on the map.
Acceptance Criteria
Given that the user has searched for a valid outdoor location,
The user should see an information card appear at the bottom of the screen with a Save button. Once selected, the location will be stored on the side-menu option My Places.

Accepted


Permission Error

Hey there,
thanks a lot for your awesome image. However, I'm struggling to get this up and running.  I read about the magento file permission problem and that your script fixes them. However, it's not working on my machine here. I'm also using dinghy as you guys do. The setup script is not able to chown the files

chown: changing ownership of '/srv/www/vendor/magento/magento2-base/dev/tests/functional/tests/app/Magento/Backup/Test/Page/Adminhtml': Operation not permitted
chown: changing ownership of '/srv/www/vendor/magento/magento2-base/dev/tests/functional/tests/app/Magento/Backup/Test/Page': Operation not permitted
chown: changing ownership of '/srv/www/vendor/magento/magento2-base/dev/tests/functional/tests/app/Magento/Backup/Test/TestCase/NavigateMenuTest.xml': Operation not permitted
chown: changing ownership of '/srv/www/vendor/magento/magento2-base/dev/tests/functional/tests/app/Magento/Backup/Test/TestCase': Operation not permitted

Any ideas? :) Thanks!

Okay, after reading a lot up (especially from here: https://github.com/mageinferno/magento2-docker-compose/issues/5) and about dinghy, I know about the chown problem.
However, writing to /var/sessions is still not possible for me yet. I still encounter the issues you had in issue 5. Anything I'm missing?

Are you using the most recent images as in https://mageinferno.com/blog/magento-2-speed-security-permissions-docker ?
This should also all be fixed, as 2416 (magento 2.0.6) has updates to not include permission setting at the application level.

Yeah, I just updated to 2416 (2.0.6) and I'm using all recent images. That's why I'm really confused. Any special config needed for dinghy or something?

ah -- to use with dinghy, you need to set it up just like any other dinghy project, by creating docker images specifically from the bast images to get dinghy to mount with the correct file permissions.
for example, to build php image, create the Dockerfile:
FROM mageinferno/magento2-php:7.0.5-fpm-0
RUN usermod -u 501 www-data

then: docker build -t . my-php.
l'm going to close this ticket, as I believe this is just in the implementation details of dinghy + docker.

Thanks a lot @markoshust . I totaly missed that point!


Read more features

Hi Christoph,
I tried to enable reading some more features from Mastodon version 0.3 output (see enclosed demo file). mastodon_reader can now use "read_enum".
Best,
Christian

Hi @drchrisch,
that's fantastic! Thank you very much. Gonna merge and create a new release.
Cheers,
Chris


seamless, explicit API

Let's bring objects, we consider to be an API, into conu.__init__.py
so we can do from conu import Container, Image
PR for this issue should also include documentation.

This was already incepted in #18


Adding sortingoptions for creation date and last modified (closes #2448)

Not ready for review; I've to simplify this..

@emanuelschuetze Ready for review; creation date is not get from the first log message and last modified from the newest log message.


Add post body example to discharge api docs

Coverage remained the same at 82.339% when pulling d8f54ad3696d209a3a2a3ffc1e826f552505288d on endpoint-docs into 86f47aa82a65da6071a18e320925d72e84dc0156 on alma.


Missing information

I have created a preencrypted VHD and have uploaded the secret to the keyvault. It is not clear what steps I need to follow in order to create a VM that uses this information.
Can you please specify a complete example (preferably using azure-cli) that will create a virtual machine from a pre-encrypted VHD and secret?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 246df0be-86c4-083f-5896-d9ed79a94b88
Version Independent ID: cba0daf5-b5f3-e1ba-2d79-56ef94f927cb
Content: Appendix - Azure Disk Encryption for IaaS VMs
Content Source: articles/security/azure-security-disk-encryption-appendix.md
Service: security
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@SteveParson Thanks for the Comment. We are actively investigating and will get back to you soon.

@SteveParson Please refer to New IaaS VMs created from customer-encrypted VHD and encryption keys to create a new VM using existing VHD and encryption keys.

@SteveParson We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.

@SaurabhSharma-MSFT I was able to successfully build a VM using the Azure Powershell module. Unfortunately this does not fit our CI/CD flow. I need to also be able to deploy pre-encrypted VMs with ARM templates or some other method.


Pattern of http signature

Hi
This pattern is not compliant with Api Manager Tyk Io.
This Api Manager allow signature without quotation mark.
Example :
Work fine with tyk.io
Signature keyId=${keyId},algorithm=${algorithm},signature=${signature}
But don't compliant with this regexp
"(?\w+)=(("(?[^"])")|(?\d+\.?\d))"
https://github.com/tomitribe/http-signatures-java/blob/3a84217890d9c7d93d42585c4c9d86225d69f4ff/src/main/java/org/tomitribe/auth/signatures/Signature.java#L137
Is it possible to make optional  quotation mark in this pattern ?
Thanks

@bobbyben If you send a PR with a test case, I'll be happy to merge it.


[FEATURE]  set-up-an-azure-shared-disk-sbd-device

Is your feature request related to a problem? Please describe.
Please add the possibly to use a shared disk as SBD device.
Describe the solution you'd like
As described in here:
https://docs.microsoft.com/en-us/azure/virtual-machines/workloads/sap/high-availability-guide-suse-pacemaker#set-up-an-azure-shared-disk-sbd-device
Describe alternatives you've considered

iSCSI devices require additional VM, so this is not a preferred option.
Azure Fencing Agent requires a connection to azure public endpoints and a firewall entry.
SBD device on shared disks seems the best and easiest option

Additional context
Add any other context or screenshots about the feature request here.

@mimergel  - are you working on this one ?


Make sure what happens when subsidy and/or fees are underpaid in a block is well-defined

I think this is clear from the writeup of the algorithm, more or less.


SegmentedControls initial option setting doesn't work

I want to set initial selected option to SegmentedControls.
options = [
{
label: 'user1',
value: 'user1'
},
{
label: 'user2',
value: 'user2'
}
]
constructor(props) {
super(props);
this.state = {
selectedOption: {label: "user1", value: "user1"},
}
}
<SegmentedControls
options={ options }
onSelection={ setSelectedOption.bind(this) }
selectedOption={ this.state.selectedOption }
extractText={ (option) => option.label }
testOptionEqual={(selectedValue, option) => selectedValue === option.value}
/>
However, when app is started initial option is not applied to SegmentedControls.
Even though I remove testOptionEqual props, it shows same result.
What's the problem?

I faced the exact same issue.


Error fetching TaHoma Event Fetcher data: Error communicating with the TaHoma API: None

Describe the bug
Error fetching TaHoma Event Fetcher data: Error communicating with the TaHoma API: None
To Reproduce
Steps to reproduce the behavior:

Start HomeAssistant

Expected behavior
No error :)
Environment (please complete the following information):

Home Assistant version: 0.113.2

Device: (if your problem is related to a specific device)
Using version 1ef0944
Just reporting this in case it's useful

Thanks for reporting @thijsdejong. I have faced this as well, and I believe @tetienne and @vlebourl also. In my installation, it only happens once every 15 times approximately.
https://github.com/iMicknl/ha-tahoma/blob/1ef09448093c917f3bb4f5b1b1e6538519034397/custom_components/tahoma/coordinator.py#L44-L49
However, what I couldn't figure out yet is that the exception is None. That would mean that it probably is a general exception, where message has an empty value. We would need to add better error messages to the pyhoma client.
https://github.com/iMicknl/python-tahoma-api/blob/e00b472ac772701bc1573ff5f9c05ab177bb5498/pyhoma/client.py#L223-L228

I'm facing the same issue too. 23 times in less than 1 hours.
First occurred: 22:06:04 (23 occurrences)
Last logged: 22:40:51

First occurred: 17:09:09 (44 occurrences)
Last logged: 22:52:21

Using debugpy, I found out that the actual exception is ServerDisconnectedError(None). Could it be that we do multiple concurrent requests using the same session?

This is strange, if we were really disconnected from the server, the next update should fail too. This is not the case.

@tetienne most of the issues I can find mention that we need to close the connection. Apparently the remote API server closes our request, if we have to many open connections. The next update will start a new connection which will work, until the server does close it again.
We need to see if adding close does something with our performance.

HTTP keep-alive allows the same connection to be used for multiple requests, which can improve performance, especially over HTTPS, where the connection handshake can be lengthy. But the server may have a limit as to how long it's willing to keep the connection alive or how many requests it will accept on the same connection. When the limit runs out, it closes the connection.

https://github.com/aio-libs/aiohttp/issues/850#issuecomment-471663047

The tahomalink website set the header Connection: keep-alive, I will update our library to do the same.
curl 'https://www.tahomalink.com/enduser-mobile-web/enduserAPI/events/xxxxxxxxx/fetch' -H 'User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:79.0) Gecko/20100101 Firefox/79.0' -H 'Accept: */*' -H 'Accept-Language: fr,fr-FR;q=0.8,en-US;q=0.5,en;q=0.3' --compressed -H 'X-Requested-With: XMLHttpRequest' -H 'Origin: https://www.tahomalink.com' -H 'Connection: keep-alive' -H 'Referer: https://www.tahomalink.com/enduser-mobile-web/steer-html5-client/tahoma/' -H 'Cookie: JSESSIONID=xxxxxxxxx' --data-raw ''

See https://github.com/iMicknl/python-tahoma-api/pull/26 for a potential fix.

I've updated the poll interval to 10 seconds, and for half an hour, still no error.

See iMicknl/python-tahoma-api#26 for a potential fix.

How would I go about testing that version of the dependency on my installation? Do you have any guide that could help me out?

@thijsdejong I think my fix is useless. Try to update this value from 5 to 10: https://github.com/iMicknl/ha-tahoma/blob/master/custom_components/tahoma/init.py#L18

@thijsdejong I think my fix is useless. Try to update this value from 5 to 10: https://github.com/iMicknl/ha-tahoma/blob/master/custom_components/tahoma/init.py#L18

Hmm I found a way to use a git repo as a dependency and applied your fix. As I responded in the PR it SHOULD not do anything, but I have not had the error since.
Also just want to say amazing job on the updating of states. I have 26 roller shutters / windows connected to tahoma, and there would always be an incredible amount of timeouts. So far on this new version no error messages at all!

@tetienne I have done some more research and it seems a workaround for this is actually disabling keepalive. It's a workaround that sacrifices some speed but eliminates the problem of connections being closed by the server when they are open too long.
https://github.com/aio-libs/aiohttp/issues/850#issuecomment-471663047

@thijsdejong In fact just increasing the poll interval from 5 to 10 seems enough. For 3 hours, I have 0 error. No need to update our library.


Debugging tricks

Two tricks that I have been using for joint python/java development are attaching debugging data to Java exceptions and use of serialization to produce core dumps.  As these are very strong tools for working with our code they should appear in our code base somewhere.  However, they are completely unlike other tools in our module so I am not sure how to frame them.  Rather than being so part of the python  module, they are sections of pure Java code that can be used as part of any Java project.  Here are the relevant snippets from my projects internal utility library.
The following code is hereby given the public domain.  If it breaks, it you get to keep all the pieces.
The first is a utility intended to cause a failure in an algorithm to dump some context that lead to the fault into a corefile.  This file can be unloaded in JPype and then examined to see what went wrong.  This is useful when doing large batch runs of a process or capturing a failure at a remote site where the user can send the fault file back to the developer.
package example;

import java.io.IOException;
import java.io.ObjectOutputStream;
import java.io.OutputStream;
import java.io.Serializable;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.time.Instant;
import java.util.HashMap;
import java.util.zip.GZIPOutputStream;

/**
 * Utility to simplify the pattern for dumping a core file.
 *
 * To enable core dumps, specify the system property with ".dumpCore" appended
 * java.lang.System.setProperty('org.myproject.dumpCore', 'true');
 *
 *

 * Example:
 *

 * {@code
 *   package bar;
 *
 *   // Make sure the class and all members are serialiable
 *   class Foo implements Serializable
 *   {
 *      // Be sure to set the version UID so that the methods can be
 *      // altered without breaking the core file
 *      public static final long serialVersionUID=-123727878335L;
 *
 *      public void evaluate(Input input)
 *      {
 *        // Place a try block around the entire body of the function
 *        try {
 *          // something may go wrong here
 *          ...
 *        }
 *
 *        // Catch all exceptions that warrent a core or simply Exception
 *        catch (Exception ex)
 *        {
 *          // Create a core dump file condition on a System property.
 *          CoreDump dump = new CoreDump("org.myproject");
 *
 *          // Add each of the required items to produce the problem
 *          dump.add("Foo", this);
 *          dump.add("input", this.input);
 *          dump.add("exception", ex);
 *
 *          // Each of the items will be saved in the core file
 *          dump.write("foo");
 *
 *          // Rethrow the exception to keep the control flow
 *          throw ex;
 *         }
 *       }
 *    }
 * }
 *

 *
 */
public class CoreDump
{
  Path coreDirectory = null;
  HashMap<String, Object> core = null;

  /**
   * Create a core dump controlled by a system property.
   *
   * @param property is the system property that should be set to true to enable
   * core dumps.
   */
  public CoreDump(String property)
  {
    try
    {
      String dumpFlag = System.getProperty(property + ".dumpCore");
      if (dumpFlag != null && Boolean.parseBoolean(dumpFlag))
      {
        core = new HashMap<>();
        String coreDir = System.getProperty(property + ".coreDir");
        if (coreDir == null)
        {
          coreDir = ".";
        }
        coreDirectory = Paths.get(coreDir);
      }
    }
    catch (Throwable ex)
    {
    }
  }

  /**
   * Adds a named object to the core dump. This must be called before the call
   * to {@code write}. If items to added to core after it is written, a warning
   * message will be produced.
   *
   * @param key is the name of object to appear in the core.
   * @param obj is the contents of the object.
   * @return the coredump object for argument chaining.
   */
  public CoreDump add(String key, Object obj)
  {
    if (core == null)
      return this;
    try
    {
      core.put(key, obj);
    }
    catch (Throwable ex)
    {
    }
    return this;
  }

  /**
   * Write the core file if core dumps are enabled. This must be the last call
   * to the core dump object.
   *
   * @param key
   * @return true if a core was written.
   *
   */
  public boolean write(String key)
  {
    if (core == null)
      return false;

    try
    {
      int id = (int) Instant.now().getEpochSecond();
      Path file = coreDirectory.resolve(String.format("%s-%08x.ser.gz", key, id));
      if (!Files.exists(this.coreDirectory))
        Files.createDirectories(this.coreDirectory);
      save(file, core);
    }
    catch (Throwable ex)
    {
    }
    core = null;
    return true;
  }

  public void save(Path file, Serializable object) throws IOException
  {
    try (OutputStream fileOut = Files.newOutputStream(file);
            GZIPOutputStream gos = new GZIPOutputStream(fileOut);
            ObjectOutputStream out = new ObjectOutputStream(gos);)
    {
      out.writeObject(object);
    }
  }

}

The second is more useful when running an interactively.  When a fault occurs we can get more information from the exception.  Thus when we catch a Java exception in JPype we can get all the variables we need to help debug the problem.
package example;

import java.io.Serializable;
import java.util.Map;

/**
 *
 * Utility to add the context that lead to an exception to be thrown.
 *
 * Example:
 *

 * {@code
 *     if (Double.isNaN(out[i]))
 *     {
 *       throw Exceptions.builder(new RuntimeException("NaN in output"))
 *               .put("x", x).put("y", y).put("q", q)
 *               .put("inner", inner)
 *               .put("n", nearest(x, q)).get();
 *     }
 * }
 *

 */
public class Exceptions
{

  /**
   * Get a map containing any attached contexts that have been attached to a
   * throwable.
   *
   * @param throwable is the throwable to probe.
   * @return is a map of strings to objects, it may be empty.
   */
  public static Map<String, Object> getContext(Throwable throwable)
  {
    Throwable t1 = throwable;
    while (t1.getCause() != null)
    {
      t1 = t1.getCause();
      if (t1 instanceof ExceptionContext)
      {
        return ((ExceptionContext) t1).getContext();
      }
    }
    return new ArrayMap<>();
  }

  /**
   * Attach a context to a throwable.
   *
   * @param <Type> is the base type of the throwable.
   * @param throwable is a throwable to attach context to.
   * @param key is a unique key for this object.
   * @param value is the value to be stored.
   * @return the original throwable for chaining or rethrowing.
   */
  public static <Type extends Throwable> Type add(Type throwable, String key, Serializable value)
  {
    Throwable t1 = throwable;
    while (t1.getCause() != null && !(t1 instanceof ExceptionContext))
      t1 = t1.getCause();

    ExceptionContext ex = null;
    if (t1 instanceof ExceptionContext)
    {
      ex = (ExceptionContext) t1;
    }
    else
    {
      ex = new ExceptionContext();
      t1.initCause(ex);
    }

    ex.put(key, value);
    return throwable;
  }

  /**
   * Builder to add more than one item to a context.
   *
   * @param <Type>
   * @param t
   * @return
   */
  public static <Type extends Throwable> ExceptionContextBuilder<Type> builder(Type t)
  {
    return new ExceptionContextBuilder<>(t);
  }

//<editor-fold desc="internal">
  public static class ExceptionContextBuilder<Type extends Throwable>
  {
    Type t;

    ExceptionContextBuilder(Type t)
    {
      this.t = t;
    }

    @SuppressWarnings("ThrowableResultIgnored")
    public ExceptionContextBuilder<Type> put(String key, Serializable value)
    {
      add(t, key, value);
      return this;
    }

    public Type get()
    {
      return t;
    }
  }

  /**
   * Private dummy exception used to store that any context for an exception.
   */
  final static class ExceptionContext extends Throwable
  {
    ArrayMap<String, Object> context = null;

    ExceptionContext()
    {
      // Force the stack trace to be empty because this is not a real exception.
      setStackTrace(new StackTraceElement[0]);
    }

    /**
     * The message to be displayed to the user. Indicates what context
     * we can probe.
     *
     * @return
     */
    @Override
    public String toString()
    {
      StringBuilder sb = new StringBuilder();
      sb.append("Exception context with contents: ");
      sb.append(StringUtilities.join(context.keySet(), ","));
      return sb.toString();
    }

    /**
     * Add a key value to the context store.
     *
     * @param key
     * @param o
     */
    void put(String key, Serializable o)
    {
      if (context == null)
        context = new ArrayMap<>();
      context.put(key, o);
    }

    /**
     * Get the key value store.
     *
     * @return
     */
    public Map<String, Object> getContext()
    {
      if (context == null)
        context = new ArrayMap<>();
      return context;
    }
  }
//</editor-fold>
}

@marscher  I am not quite sure how or where we should place these types of snippets in the current JPype distribution.  I personally find them exceptionally helpful in dealing with problems that crop up while using JPype both locally and remotely.  However, they can't really be compiled into org.jpype codebase as they are pure Java and tying Java code to JPype would be bad.  I am fine with people incorporating and modifying them as needed for their usage.  Any ideas where to place them would be helpful.

Mine is similar to the apache ContextedException
http://commons.apache.org/proper/commons-lang/javadocs/api-3.9/org/apache/commons/lang3/exception/ContextedException.html
But there is an important difference.  The context I add does not change the exception type meaning one can add context without changing down stream exception processing.


adds FHIR infos to graph schema

Adds proposed Jsonschemagraph changes to iceberg graph schema

closed in favor of more recent PR: https://github.com/bmeg/iceberg/pull/17


Bump to release 3.2.0

Current dependencies on/for this PR:

main

PR #343  (this PR)

This comment was auto-generated by Graphite.


Decouple Play and Twirl versions

Context
This change fixes support for Play 2.6 which is currently using the Play 2.3 import list.
This also theoretically makes it so that you can use varying versions of Twirl with a given version of Play, which is something that makes upgrades between Play versions easier, allows for pulling in bug fixes for Twirl separately, and is something supported by the SBT plugin.
This changes the imports to a List from which the concatenated string version is then constructed. This change is necessary because Twirl 1.3 expects a List. (Well maybe not strictly necessary as I could explode the concatenated string version into a List, but that wouldn't be as clean)
Contributor Checklist

[X] Review Contribution Guidelines
[X] Sign Gradle CLA
[N/A] Link to Design Spec for changes that affect more than 1 public API (that is, not in an internal package) or updates to > 20 files
[X] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[X] Provide unit tests (under <subproject>/src/test) to verify logic
[N/A] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[X] Ensure that tests pass locally: ./gradlew :platformPlay:check

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation including proper use of @since and @Incubating annotations for all public APIs
[ ] Recognize contributor in release notes

Hey @benmccann, I'll be taking a look at this for the next release (4.1, which would be released ~July).  I'll let you know when I get back around to this.

@big-guy Any chance you can have another look?

@big-guy would you be able to take a look at this now? I'd like to update the Play 2.6 PR to use this one

@big-guy just a reminder about this PR to unblock Play 2.6 support. Thanks!

Thanks @benmccann -- sorry, I meant to reply last week.  I'll pick this up again once I've finished some work around Play reload.  I've got #1992 close to passing CI, so I think it'll be merged first.

thanks!

Are there restrictions on which version of Twirl can be used with each version of Play?

Possibly in older versions of Play. Not in any of the more recent versions

Are there "default" versions of Twirl that make sense for each version of Play?

Potentially. If you use a template to create a new Play project, you'll probably get whatever was the latest version of Twirl at the time that version of Play was released. Templates for old versions of Play don't really get updated to use the newest libraries, but users are free to upgrade any of their libraries as they choose

How different is Twirl 1.0, 1.1, 1.2, and 1.3?

Not very

If the Twirl version is something that can be completely decoupled from the version of Play, it makes sense to just model it that way and make it easy for someone to specify the version of Twirl they'd like to use (and provide a sensible default).

The Play team has worked to decouple its various components. Twirl versions and Play versions aren't tied to each other

@big-guy I just pushed a new version to fix the tests. I lost a line during the rebase earlier

Thanks @benmccann -- I'll be looking at this again later in the week.

@big-guy I've rebased this on top of the latest changes. Would you be able to give it a look?

@big-guy would you be able to give this one another look?

@blindpirate could you take a look at this one as well?

Sure.

@blindpirate @big-guy would we be able to get this merged? Thanks!

@blindpirate @big-guy just a quick reminder about this PR that has a bug fix for Play 2.6

@blindpirate @big-guy could you take a look at this PR? thanks!

@blindpirate I've been waiting for over a year for a review on this PR. any chance you could take a look? thanks!

@benmccann So sorry for this. I'll take a look at it.

@blindpirate thank you very much for the review! I've updated the PR per your suggestion to take care of the test failure
I wasn't able to see the test failure locally. How do you normally run the tests? I've been running ./gradlew :platformPlay:check, but it's a bit hard to use. It takes over an hour and even on master without any changes there's about a dozen tests that fail with vague messages like "compilation failed" or "port already in use". It'd be really nice if pull requests ran the continuous build you pointed me to. I'm not sure how to see that report myself
This PR doesn't yet let you specify what version of Twirl to use, so I'm not sure there are additional tests I could add. It simply picks a version of Twirl based off what version of Play you're using (see TwirlCompilerFactory.java). However, this PR lays the groundwork to make it fairly straightforward to specify a different twirl version in the future. Right now this PR is mainly a refactoring and also a bug fix (for Play 2.6 which is using the Play 2.3 import list without this PR)

@benmccann Sorry I should have explained this in detail.
https://builds.gradle.org/viewLog.html?buildId=13793439&tab=buildResultsDiv&buildTypeId=Gradle_Check_Platform_Java8_Oracle_Windows_platformPlay
You should be able to see this failure on CI as guest login.
TwirlCompileIntegrationTest is a subclass of MultiVersionIntegrationSpec and marked with PlayCoverage.DEFAULT, so it would be tested against these 4 versions. By default, on CI all these versions are tested, and on local machine only latest version of  PlayCoverage.DEFAULT is tested.
To verify a single test, we usually use ./gradlew platformPlay:integrationTest --tests TwirlCompileIntegrationTest to avoid long time running. And to test against a specific version, we usually adjust these configuration.
Please let me know if I didn't make myself clear. I'll rerun this pr on CI and merge it once everything is fine.

Thanks for the explanation @blindpirate!
It looks like the CI builds have all passed now

Thanks @benmccann !

Thank you!!


Delete IPTABLES rules for NodePortLocal when nplPortRange is updated

If we change nplPortRange and Antrea Agent is rebooted, rules with Node Port outside
current port range are supposed to be deleted. But we face a problem if all rules
have to be deleted from NPL chain. In that case we were skipping IPTABLES update -
because length of allNPLPorts in GetPodsAndGenRules function was getting set to zero.
Removed this length check so that even if all rules have to be deleted, the function
addRulesForNPLPorts is executed.

/test-all

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@e2591af). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1887   +/-   ##
=======================================
  Coverage        ?   26.18%
=======================================
  Files           ?      184
  Lines           ?    15843
  Branches        ?        0
=======================================
  Hits            ?     4149
  Misses          ?    11147
  Partials        ?      547

Flag
Coverage Δ

e2e-tests
26.18% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

/test-conformance


Fullbleed and safe zones in the editor

For context see this document.
A rough illustration:

The key points:

The canvas layout will be updated around the "fullbleed area" to be 9:16. We can redefine the breakpoints around 9:16 size.
The current 2:3 "page area" is centered inside the "fullbleed area".
The exact UI of fullbleed-vs-safezone is TBD. There will definitely be some clear design to communicate which part is overflowing.
The "page area" for the most part functions exactly like it used to: the coordinate system, geometry, drop targets  - are all the same.
The "fullbleed" will also function as a drop target for the background element.
The background and fill elements will layout differently. They will always auto-size to "cover" the fullbleed area. We can either use the fullbleed area itself to layout these elements or the page area (with negative coordinates and width/height > 100%). The page area might be actually easier with all the edit-mode features, etc.
There's no longer "Fit to device"/"Do not format" modes for background elements. All background elements are always fullbleed.
Delete-when-moved-out-of-page feature will trigger when an element is fully outside the fullbleed area.

There will be a separate issue for output of the new mode.

Closed by #1310


[HOLD for payment 2023-09-29] [$500] Request money - Scan - Brief disappearance of "Attachment too small" modal text before modal closure

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open a chat
Navigate to "Request money" > "Scan"
Attempt to upload a text file or incorrect file
Click on the "Close" button
Notice the "Attachment too small" modal text briefly disappears for a moment before the modal closes

Expected Result:
The "Attachment too small" modal text should remain visible without disappearance before the modal closes
Actual Result:
Brief disappearance of "Attachment too small" modal text before modal closure
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: v1.3.68-13
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/115492554/ee9c9ca3-b797-4ee9-a246-240133275d0f
https://github.com/Expensify/App/assets/115492554/5f0035ec-9b63-4400-9aa2-834ed9a53bf4
Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694202685326599
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01fc29b362e680f18d
Upwork Job ID:<PHONE_NUMBER>088493056
Last Price Increase: 2023-09-12
Automatic offers:

jjcoffee | Reviewer | 26724139
dukenv0307 | Contributor | 26724141

Proposal
Please re-state the problem that we are trying to solve in this issue.
Brief disappearance of "Attachment too small" modal text before modal closure
What is the root cause of that problem?
The issue is coming from the ReceiptSelector component. The prop receiptModal coming from onyx is being reset to it's initial state before the modal gets closed.
What changes do you think we should make in order to solve the problem?

Introduce a state variable to handle the modal visibility

const [showModal, setShowModal] = useState(false);

Add a useffect to update the new state variable when the receipt is invalidated

    useEffect(() => {
        if (isAttachmentInvalid) {
            setShowModal(true);
        }
    }, [isAttachmentInvalid]);

Add a new function that will be called when we close the modal. The function will set the showModal state variable to false, and once that's done it'll then call the receipt action clearUploadReceiptError.

    const closeModal = () => {
        setShowModal(false, () => {
            Receipt.clearUploadReceiptError();
        });
    }

    <ConfirmModal
        title={attachmentInvalidReasonTitle}
        onConfirm={closeModal}
        onCancel={closeModal}
        isVisible={showModal}
        prompt={attachmentInvalidReason}
        confirmText={translate('common.close')}
        shouldShowCancelButton={false}
    />

Result
https://github.com/Expensify/App/assets/23414844/7324a293-ba35-4936-9ea4-ef7647de76a7

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~017c997afef497a3d4

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://upwork.com/freelancers/~017c997afef497a3d4

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://upwork.com/freelancers/~017c997afef497a3d4

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://upwork.com/freelancers/~017c997afef497a3d4

@dukenv0307's proposal LGTM! The RCA is correct (the errors are set to empty strings before the modal hide animation completes), and the solution correctly addresses the RCA.
With @oogushikun's proposal we already have a onModalHide prop so it would be an unnecessary use of state to store modal visibility there.
@hungvu193's proposal has an incorrect RCA as the issue doesn't come down to using Onyx (it might be true that we're not standardised on using Onyx for storing errors, but it's irrelevant to this issue).
:ribbon::eyes::ribbon: C+ reviewed

Makes sense!

@dukenv0307 Are you able to use the gallery (bottom left) to attach an image to scan?

@dukenv0307 So I've tested on iOS native by selecting a tiny PNG (<240 bytes) from the gallery, but no file size validation seems to run. I don't think that's related to your changes and think adding it would be OOS for this PR.
Since there's no validation running, there's no need to test your changes as such, but it's good just to have a test of the flow anyway (so just uploading any image from the gallery). cc @johnmlee101

Payouts due:
requires payment offer (Reviewer)
requires payment offer (Contributor)
Issue Reporter: $50 @ayazhussain79
Contributor: $500 @dukenv0307
Contributor+: $500 @jjcoffee
Eligible for 50% #urgency bonus? Yes
Upwork job is here.

@jjcoffee please complete the BugZero Checklist.
@ayazhussain79 please accept the Upwork contract I sent across.

@kadiealexander offer accepted, Thank you

The PR that introduced the bug has been identified. Link to the PR: N/A - behaviour has been there since the original PR that added the feature.
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. No - low impact
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

@kadiealexander Checklist complete!

Everyone is paid!


chore: add enum constants

@aladdin-add Is this easier for you to read?

@aladdin-add If you change any of the '0' with '1' etc in the constants I'm sure you will run into OOM and lots of broken tests :)
How to prevent this?

just do not change?


GEODE-7414_2: modify init() method argument

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[*] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[*] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[*] Is your initial contribution a single, squashed commit?

[*] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

This was reverted by GEODE-8087 due to breaking API compatibility between v1.12 and forward. I'm happy to pair on a new fix, and on writing the exemption to the API check job.

Hi, could you help me how to bypass this API check, since origin class is not marked @Experimental.


CPS fails on scripts without functions

Not sure what the issue is yet, but this is the common theme among all the failing CPS tests.

We weren't handling BlockStatements in sequences. This is fixed.


[Question] Why asyncify was removed?

I used it everywhere in my project to ensure that the queries to the mihoyo apis weren't blocking my async stuff, what i can do about it now?

I removed it in favor of asyncio.to_thread(), I didn't know about it before so I tried to implement my own but when I found out about a function that does the exact same thing and is builtin I didn't see a reason for my own to even be a thing.


[AutoPR appconfiguration/resource-manager] upgrade appconfiguration package tag

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/7742

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/8528


Setup.py for install

Hi, it would be valuable to edit a setup.py then the user can do
pip install git+https://github.com/juliusbierk/gautocorr.git

I wasn't thinking of this an anything big enough for people to install, but sure! Pushing now.


No more items are loaded when the scroll container of the list view isn't the window.

If the window isn't the scroll container of the list view no more items are loaded during scrolling.

Issue resolved.


Python API SELECT with no limit

OrientDB Version: 2.2.16
Java Version: 1.8
OS: Linux 14.04
Python 2.7
Expected behavior
select from Foo should return default 20 records.
Actual behavior
select from Foo tries to return all records
Steps to reproduce
records = client.command("select from Foo")
[TIP] Query 'SELECT FROM Foo' returned a result set with more than 10000 records. Check if you really need all ...
Cannot serialize record: .....

Tried PyOrient for a day, I am assuming you are referring to it, when you said python. I always thought limit is by default 20 in only orientdb studio, but for all other type of calls you get all elements unless you specify limit. PyOrient does support Limit or select from foo limit 20 would do it.
sorry if i gave a wrong answer, i am learning and using orientdb from a week or so.

In general, the ODB APIs allow you to get up to 10K records. Above that you get the warning as you did. So yes, use the LIMIT clause, if you want less records and/ or to avoid the error message.
Scott

@luigidellaquila - is my statement correct, because I am also reading this in the "limits" section of the docs.

Queries can return a maximum of 2 Billion rows, no matter the number of the properties per record

Scott

Limit of 20 is imposed in console and studio. I made the assumption this was by default built-in to the PyOrient API.
Thanks anyway.

Hi @austx , glad this is solved.  Let us know if you have any other questions or find issues
Many thanks,


Always match excluded exceptions by case equality

... no matter if they are defined by string or constant in
Raven.configuration[:excluded_exceptions].
The upside of doing it like this is that Raven will have the same match
behavior no matter how the exception was excluded. Previously a
string-defined excluded exception wouldn't match inherited/extended
exceptions.
Use case example:
  # Raven setup
  Raven.configure do |config|
    config.excluded_exceptions = ["SentryExcludedException"]
  end

  # Application
  module SentryExcludedException; end

  # The application can decide what to exclude
  begin
    raise StandardError, "oh snap"
  rescue => error
    error.extend SentryExcludedException
    raise
  end

This only worked if the excluded_exceptions was configured with
constants, but not with strings, which this fixes.
By using strings the coupling between the Raven setup/environment
and the application is reduced, improving unit testing etc.

Thank you for your contribution!


Property 'tree' does not exist on type

Hello, i do use simple filtering, but a have error:
`
ERROR in src/app/shared/modules/products/components/products/products.component.html:44:82 - error TS2339: Property 'tree' does not exist on type 'ProductsComponent'.
44             <input type="text" class="form-control" id="filter" #filter (keyup)="tree.treeModel.filterNodes(filter.value)" placeholder="" aria-label="Text input with segmented dropdown button">
                                                                                ~~~~

  src/app/shared/modules/products/components/products/products.component.ts:15:18
    15     templateUrl: './products.component.html',
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~
    Error occurs in the template of component ProductsComponent.

`
component
template

Problem is in <ng-template #treeNodeTemplate let-node let-index="index">

I did forgot added to input: *ngIf="nodes".


Tests getting stuck

Example 1 (100% reproducible): https://ci.appveyor.com/project/peppy/osu/builds/23356732/tests
Example 2: https://ci.appveyor.com/project/peppy/osu-framework/builds/23350438

These have now been fixed via https://github.com/ppy/osu-framework/pull/2304 + https://github.com/ppy/osu/pull/4541


withPhoneLike( ) does not work properly

i have 3 contacts with below numbers:
+631230001234
+11230001234
01230001234

Below code only reterive 1 contact that is incorrect and must be 3 contacts
contactList = (new ContactsGetterBuilder(getContext())
                    .withPhoneLike("1230001234")
                    .allFields()
                    .buildList()
            );

what version are you using?
I have just created test with 50 contacts, saved them and extracted with your data and it worked fine.
    @Test
    fun withPhoneLikeFiltersPhones() {
        //create list with 50 contacts and save them
        createRandomList {
            //removing all random phones
            //adding numbers from example
            it.forEach { it.phoneList.clear() }
            it[0].phoneList.run { add(PhoneNumber("+631230001234", "1234")) }
            it[1].phoneList.run { add(PhoneNumber("+11230001234", "1234")) }
            it[2].phoneList.run { add(PhoneNumber("01230001234", "1234")) }
            //adding one number that should be filtered
            it[3].phoneList.run { add(PhoneNumber("001234", "1234")) }
        }
        //getting contacts from android
        val savedList = getList { withPhoneLike("1230001234") }
        //asserting that all of them were added
        Assert.assertTrue(savedList.size == 3)
    }

I'm using version 1.12.1
implementation 'com.tomash:androidcontacts:1.12.1

When adding contacts using the default phone application, the phone number is saved in a format that contains multiple spaces. And the function can't find it.
for example when +11230001234 becomes +1<PHONE_NUMBER>
how can i handle it?

@aliakbarRashidi working over it

@aliakbarRashidi working over it

thanks. waiting...

i think a possible way is that:
change FilterUtils.withPhoneLikeFilter (line 33)
and first format the filterData to the Standard E164 or clean it from space,dash and other characters except +, then compare to the pattern.

@aliakbarRashidi check 1.12.1 please

Thanks

Dear @aliakbarRashidi
I have some problems with copyright on a repo you are owning now (cpp_book).
(I don't find any way to contact you, so I need comment on this issue to notify you, sorry about that)
Could you give me your email to contact you?
In short, could you delete the repo cpp_book on your GitHub page? This repo is violating the copyright., and I'm trying to contact with all persons who forked the repo cpp_book.


zipkin-ui test image from last release commit 404s

maybe something different happened from the download vs local build of zipkin-ui

sorted!


Server-side execution

As https://github.com/jupyterlab/jupyter-collaboration/pull/279 has been merged, could something similar apply to vscode Jupyter notebooks?
The use case here is that one should be able to disconnect from a remote, connect again, and not miss any output.

Any progress so far? I would like to implement this functionality. I am first time to this project, just digged into APIs. Hope to learn  TODOs and insights from you guys.

Its been a few months and there haven't been enough upvotes to warrant this feature. hence closing this.

The use case here is that one should be able to disconnect from a remote, connect again, and not miss any output.
Duplicate of https://github.com/microsoft/vscode-jupyter/issues/3998

You have two parts in this issues, one is a solution referenced an upstream PR and then also mentioned the problem
The problem is a duplicate
The upstream pr is not something we can implement as the architectures are completely different, vscode don’t use Jupyter servers


[do not merge] WIP: sorting for globbed metrics

I had some inspiration on https://github.com/dgryski/carbonapi/issues/128 and did some work. It's a ways from production quality but I'd appreciate any feedback.

I think this is functionally complete now, and more-or-less bug-free (I've been running it for a while without any crashes or noticeable data errors).

@nnuss can you review and merge?

@dgryski looks suitable to me (made up a quick test to follow); merging.
Thanks @arodland !


Table grid scss cleanup

In this block - https://github.com/patternfly/patternfly-next/blob/master/src/patternfly/components/Table/table-grid.scss#L221-L233
The ::before label is supposed to be normal font, so let's remove L224 and see if L229 is necessary.
L228 seems redundant, so let's see if we can remove that.
The comment on L230 looks irrelevant.
And L231 probably isn't necessary, either.

this is addressed in https://github.com/patternfly/patternfly-next/pull/1949/


fix: represent export correctly in types

The current types are incorrect because this plugin is exported using module.exports which is not equivalent to export default; while TypeScript handles this under the hood for native TS files (which is why those don't error), attempting to use this module with require in JS files checked by TypeScript will result in an error:

This is because TypeScript expects such modules to be exporting a default property that should be used in CommonJS, so instead it wants us to do { default: RemoveEmptyScriptsPlugin }:

This property does not actually exist at runtime though:

Instead, the correct way to type a module.exports based export is to use export =, and then to use a namespace to export additional types and interfaces (as there can only be one top-level export).

@G-Rath
Thank you!


Boolean Specialization Constants

I am checking SPIRV-Reflect, but I see nowhere where the list of boolean specialization constants can be obtained from a stage. Is this supported?

Ended up implementing this in our local fork, for anyone interested:
https://github.com/godotengine/godot/pull/50325
If there is any interest in me submitting a PR with my changes, please let me know.

Hi,
Specialization constants haven't gotten a lot of love since unfortunately. It's on my list of thing sto investigate but haven't gotten to it yet. It would be greatly appreciated if you could submit a PR. It would at least get teh ball rolling on specialization constants.
Thanks,
Hai

Alright, a PR will be submitted soon!

Thanks! Looking forward to it.


Converting circular structure to json

Is there a reason why middleware parameters have to be serialized? Is there alternative way to pass in a mysql connection object, for example?
https://github.com/kamilmysliwiec/nest/blob/master/src/common/utils/bind-resolve-values.util.ts#L11
TypeError: Converting circular structure to JSON
    at JSON.stringify (<anonymous>)
    at node_modules\@nestjs\common\utils\bind-resolve-values.util.js:10:44
    at Array.map (native)
    at bindValuesToResolve (node_modules\@nestjs\core\middlewares\builder.js:37:39)
    at MiddlewareBuilder.ConfigProxy.forRoutes (node_modules\@nestjs\core\middlewares\builder.js:54:26)
    at CoreModule.<anonymous> (modules\core\index.ts:47:15)
    at Generator.next (<anonymous>)
    at fulfilled (modules\core\index.ts:10:58)
    at <anonymous>
    at process._tickDomainCallback (internal/process/next_tick.js:208:7)

nvm, looks like you can inject components into middleware


Add enum type selection in the playground

Reason/Context
For the TypeScript generator, you can select between enum or union, this should be possible in the playground as well.
To achieve this the following needs to change:

Add the option tsEnumType to the list of options, where the type is 'union' | 'enum' | undefined
Make sure we show the options being provided in the generator code output of the playground.
Adapt the UI to include a dropdown to choose between the enum types
Add a react handler to handle when the enum type selection changes value
Adapt the backend serverless function to use the new option during the generation phase

Happy to help even further in case you need it! Ping me here in the issue or in the AsyncAPI slack channel 👋

working on this.

@jonaslagoni Getting error while running npm run build in modelina website in master branch

@prayutsu make sure you follow the readme 🙂

@prayutsu make sure you follow the readme 🙂

Ah, missed it. Thanks @jonaslagoni


Fix origin offseting if i or j is not present in field for gtc backends

It seems that sid::shift_sid_origin does not match origin dimensions to dimension names but instead offsets them as they are in order. Therefor the order of shifting and renaming has to be changed for the gtc backends. Weirdly, changing this makes the renaming not have effect when querying strides through dimension names (see dace backend). We can put the index of the dimension instead.
Proper fix should probably go into gridtools repo, this works though.

bors try

bors try

Before we merge this, we need to fully understand the problem.

I understand the part about sid_shift_origin. @anstaf Let's discuss if we need another API for sid_shift_origin that takes also stride. It's not strictly necessary, the implementation in this PR is ok.
I don't fully understand. Can we make a reproducible? It's either a bug, then your workaround will break once the bug is fixed, or it's wrong use of sid.

Why do you think it will break once the (possible?) bug is fixed? When applying sid_shift_origin, the dimensions are always in the right order.

Ah I guess your second bullet refers to the changes in the dace backend.

Sorry, yes, in the second point I forgot to link it to the second problem.
Here my updated assessment:

The fix for the first part is correct, as discussed in the meeting. We could improve the code by using a hymap for the offsets.
After looking closer, it seems there is a bug in the SID implementation, regarding your second problem (DaCe backend).

bors try


LikeCoin: custom messages

LikeCoin implement x/iscn module and there are 3 custom messages. They can be found at
https://github.com/likecoin/likecoin-chain/blob/fotan-1/x/iscn/types/msgs.go#L18
And these are the protobuf.
https://github.com/likecoin/likecoin-chain/blob/fotan-1/proto/iscn/tx.proto

note: close #215 first


Slow traffic rate through VM created through Kubevirt

Kubevirt version = 15.0
Kubernetes version = 1.14.1-00
While passing traffic through VM created created through Kubevirt , I am getting really low traffic rate . Expected rate is around 1 Gbps but I am just getting 64 Mbps . Can you pease suggest some way to increase this traffic rate .
Please find below yaml file I have used for creation of VM.
apiVersion: kubevirt.io/v1alpha3
kind: VirtualMachine
metadata:
  name: vmfx-multi-inf
spec:
  running: true
  template:
    metadata:
      labels:
        kubevirt.io/size: small
        kubevirt.io/domain: dfx2
    spec:
      domain:
        devices:
          disks:
          - disk:
              bus: sata
            name: rootfs
          interfaces:
          - name: default
            bridge: {}
          - name: enp2s0
            bridge: {}
          - name: enp3s0
            bridge: {}
          - name: enp4s0
            bridge: {}
        resources:
          requests:
            memory: 4048M
      networks:
      - name: default
        pod: {}
      - multus:
          networkName: ovs-conf
        name: enp2s0
      - multus:
          networkName: ovs-conf
        name: enp3s0
      - multus:
          networkName: ovs-conf
        name: enp4s0
      volumes:
        - name: rootfs
          containerDisk:
            image: fxp-singledisk-cdisk

@mbhatnagar21 hi,
Here a few things which may help to find the root cause of the slowness:

Can you ensure that you are running kubevirt not in emulation mode? If kubevirt is you install namespace, then check the config-map via kubectl get configmap -n kubevirt kubevirt-config.
Also can you confirm that the throughput for regular pods is in the expected range?
The kubevirt version you are using is pretty old, did you try a newer version too?

@phoracek FYI

/assing @phoracek

/assign @phoracek

@rmohr
I tried checking the config map but I am getting below message :
configmap "kubevirt-config" not found
I have tested traffic through other pods, I am able to get traffic rate close to 1 Gbps.

configmap "kubevirt-config" not found

Just to be sure, if you do kubectl get pods -n kubevirt, do you then see kubevirt specific pods like virt-api, virt-handler, ... ?
If yes, then you don't have emulation enabled, because you don't have a config-map there, which means that you use the default settings.

@rmohr
Yes, I see kubevirt specific pods .
I have even tried getting performance results with Kubevirt version - v0.23.0 but still the traffic rate is stuck around 70 Mbps . Can you please suggest me some ways to increase this traffic rate.

@rmohr
Can we use some other drivers instead of virtio which might help in increasing the traffic rate ?
Currently I am using below yaml file for launching the vm :
apiVersion: kubevirt.io/v1alpha3
kind: VirtualMachine
metadata:
name: testvm1
spec:
running: false
template:
metadata:
labels:
kubevirt.io/size: small
kubevirt.io/domain: testvm1
spec:
domain:
devices:
disks:
- disk:
bus: virtio
name: rootfs
- disk:
bus: virtio
name: cloudinit
interfaces:
- name: default
masquerade: {}
- name: enp2s0
bridge: {}
- name: enp3s0
bridge: {}
resources:
requests:
memory: 2048M
networks:
- name: default
pod: {}
- name: enp2s0
multus:
networkName: ovs-conf
- name: enp3s0
multus:
networkName: ovs-conf
volumes:
- name: rootfs
containerDisk:
image: ubuntu-kvirt-412
imagePullPolicy: Never
- name: cloudinit

Hello @mbhatnagar21.
Available NIC models are e1000, e1000e, ne2k_pci, pcnet, rtl8139 and virtio https://kubevirt.io/user-guide/docs/latest/creating-virtual-machines/interfaces-and-networks.html#frontend. I don't think changing those would improve the performance, but you can try.
You can also try using multiqueue https://kubevirt.io/user-guide/docs/latest/creating-virtual-machines/interfaces-and-networks.html#virtio-net-multiqueue to improve the performance. However, I expect that the cause for such a huge loss in performance would lie elsewhere.
Could you elaborate how did you measure the throughput?

@phoracek
My testing setup is like this.

On system-A I am running Kubernetes and vm is deployed on this system and is using ovs_cni. Ovs is running DPDK . Dpdk is reading data from the NIC and passing the data to the deployed VM via ovs.

on system-B I am running packet generator tool. This system is connected to system A through physical ports directly via Ethernet cables. This tool shows all the statistics of data throughput and right now it is showing around 90Mbps with UDP traffic with packet size 1024 bytes

@mbhatnagar21 we did some testing as well and we did not see this very slow reates.
Were you ultimately able to get to better speeds?


Module Rating

Users should be able to rate modules
Currently there are 2 proposals for this at hand.

Rating system like 1-5 points
Similar systems to facebook like/dislike

2 years without comments = issue closed.

Changed my mind. I'd like to just use stars/forks on github to make a rating that will be displayed. I'm looking at this.


Tab is ignored on first line

If a put a text with tab on first line(like a code) this tab is ignored on editor , the bug can be reproduced here
<script>
$('#myEditor').markdownEditor({
  // Options
});
</script>
<div id="myEditor">
	System.out.println();
</div>

Happen with space too

@inacho Any chance of merge it?

The spaces issue is fixed in the latest release (v1.3.0) you can test it here:
http://jsfiddle.net/t476p7wp/2/


Dataframe in jupyter notebook vscode doesn't print well..

VS Code Version:1.64
OS Version:window10

I don't know how to deal with this problem....
Why my dataframe looks bad in jupyter notebook?

@sheng120777 can you please share what's your expected rendering? A screenshot would be very helpful.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


How to cut frame?

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
D435

Firmware Version

Operating System & Version
Win 10

Kernel Version (Linux Only)

Platform
PC

SDK Version
<IP_ADDRESS>

Language
C#

Segment
Robot

Issue Description
Hello!
how to cut depthframe?
I want to remove that side frame and make pointcloud.

Hi @ddov123  The wide range of different colors at approximately the same distance from the camera in the side sections makes me think that they may be inaccurate depth values, perhaps because those areas of the observed scene are difficult for the camera to read depth detail from.  Setting the camera configuration preset High Accuracy may therefore help to filter them out from the image.
If you are using the RealSense Viewer tool then High Accuracy can be selected from the drop-down menu beside Preset near the top of the Viewer's options side-panel.

@MartyG-RealSense I mean.. crop like this

Yes, I meant that using High Accuracy may be one method of cropping out the unwanted data.  The RealSense Viewer does not have a function for XY cropping, only for Z-depth, so it would be difficult to remove data from the edges of the image.
If you can program your own application then it is possible to define an XY bounding box and exclude any depth data outside of the box.  There is not an example of C# code available for doing so though, unfortunately.  A C++ method is described at https://github.com/IntelRealSense/librealsense/issues/2016#issuecomment-403804157

Hi @ddov123  Do you require further assistance with this case, please?  Thanks!


Spartan input field: do not show session-id information in default text

The only way to keep session information in Spartan is to pass a session-id in the query-text of the prompt-url, and hope that the client is smart enough not to strip it when appending user's data from the input field.
Lagrange already does this well, and perhaps I've convinced you to select the default text for easy replacement.
You've made a decision to use the query text as the default text.  Now I will try to convince you to provide a way to hide a session-id in the URL from the eyes of the user while passing it back to the server.
Consider a game like SpellBinding, where the user is constantly providing new words by interacting with a prompt line like this:
=: spartan://tilde.cafe/~spellbinding/game?sesh1234

As it stands, the user will see 'sesh1234as the default, delete it (if you took my advice, the user can just type in the word).  The url at the server will be something like...game?sesh1234?foo`.
I propose the following idea: a session-id is passed between two ? in the query; whatever follows is the default (and could be replaced by the user response.  So, the prompt line will be
=: spartan://tilde.cafe/~spellbinding/game?sesh1234?default-text-here

session id will not be show - only the default text, and when the user types 'foo', the query string will become ?sesh1234?foo (replacing the default).
This follows what Lagrange currently returns to the server (two ? with the original data in between), while providing a clear way to pass session data back and forth unmolested, and unseen in the text field.

two ? in the query

Unfortunately, this was a bug and completely unintentional. The intended behavior, now pushed to dev, is that the query string is replaced with what the user enters, and the ? from the URL is excluded from the Spartan request content, as per the table in the spec section 5.1.

The only way to keep session information in Spartan is to pass a session-id in the query-text of the prompt-url

I suggest using CGI PATH_INFO for session parameters. @michael-lazar may want to weigh in on this too, but I think the query string is intended purely for user input and should not be "polluted" with server-side parameters.

I agree that I think PATH_INFO is a great solution for server-side parameters. This is a really cool part of CGI that is vastly underutilized, I think because it's easy to misinterpret (link).
In this example you would have something like
=: spartan://tilde.cafe/~spellbinding/game.cgi/sesh1234?default-text-here

which would be sent to the server like this
tilde.cafe /~spellbinding/game.cgi/sesh1234 17
default-text-here

And if I were writing a CGI implementation, I would represent it like this
SCRIPT_NAME=/~spellbinding/game.cgi
PATH_INFO=/sesh1234
QUERY_STRING=
CONTENT_LENGTH=17

<stdin>=default-text-here

This actually fits really well with the paradigm if you look at how CGI is supposed to handle HTTP POST requests. (reference). The spartan server/CGI handler would not see query strings, because they're only part of the URL and not part of the actual spartan request. The client should always strip the whole query string from the URL (everything after the first "?") when building the request path.

Shite.  Did I just destroy the part of Spartan that accidentally worked well?
Without this I will not be able to implement games - and no server-based applications can work...
The servers I see would, for the example above, try to hit /~spellbinding/game.cgi/sesh1234, not game.cgi, and everything would suck.   How can the server determine where the cgi is?  By noting that it is a file and not a directory?  That seems odd.
SPSRV does not send PATH_INFO.
What have I done...

The servers I see would, for the example above, try to hit /~spellbinding/game.cgi/sesh1234, not game.cgi, and everything would suck. How can the server determine where the cgi is? By noting that it is a file and not a directory? That seems odd.

Yea basically, the CGI server can traverse up the path one segment at a time and look for an executable file.

/~spellbinding/game.cgi/sesh1234/submit
(is executable file? No.)
/~spellbinding/game.cgi/sesh1234
(is executable file? No.)
/~spellbinding/game.cgi
(is executable file? Yes! Invoke the script and set PATH_INFO=/sesh1234/submit

You can make it simpler to implement if you add a constraint like "no sub-directories are allowed in cgi-bin/", but that's really up to the server to decide how they want to implement it.
This is how CGI is is supposed to work. It's easy to miss, but I don't think it destroys anything? If you want to write a compliant CGI server in gemini you also need to handle this.

can is the operative word.  Will the CGI servers traverse up the path after checking for validity?
  I even wrote a cgi->Common Lisp proxy for Spartan games which will no longer work, as SPSRV will certainly not do what's described above.
I am really bummed.

I'm sorry this is discouraging, it's definitely no fun to run into a roadblock right before the finish line.

as SPSRV will certainly not do what's described above.

Maybe not now, but I don't see why we can't write a patch for it. MollyBrown has logic to handle this is like 20 lines of go, and the codebase for SPSRV looks suspiciously similar 😄

https://tildegit.org/solderpunk/molly-brown/src/branch/master/dynamic.go#L19-L45
https://git.sr.ht/~hedy/spsrv/tree/main/item/dynamic.go#L17

Thanks for the comments @michael-lazar, I fully agree with what you're saying.
@stacksmith:

can is the operative word. Will the CGI servers traverse up the path after checking for validity of every sub-path along the way?

They will if you write such a server or convince someone to improve their own server to behave this way. Also, CGI doesn't have to rely on actual executables in a file system. For example, in my own Gemini server I just configure the CGI URL entry points explicitly in a config file, without any mapping to the file system. This way it's trivial to know which parts of the URL become the PATH_INFO.

I am entering the 'acceptance' phase of my grief.  I run no servers directly and have to rely on whatever server the tilde is running.
I will work around the whole issue by creating per-session symbolic links linking back to the cgi directory; the path of the CGI invoked will then contain the session-id before the dreaded ? or remaining path.
I have not fully grokked the implications of hiding the name of the cgi script in the middle of the path.  in spartan://someserver/blah/bleh/cgi/foo/bar, identifying the 'cgi' component mixed in with the filesystem, seems tricky!  Is the server supposed to try every sub-path as a file to see if a component is indeed a file, then check if it's executable?  Or would it start with the entire path, and on error, shorten it until it (hopefully) gets to a subset that works as a cgi?  Should it cache the cgi and compare all incoming URIs to that?  Kind of nuts, or perhaps I am just not clever enough.

Oh, I missed @michael-lazar describing exactly the tediousness I was suspecting. OK, I officially think that is nuts. No hard feelings, but this is just crazy! And hitting the filesystem many times and getting errors, has got to be really slow.

A naive implementation could work that way, but why wouldn't the server at least cache this information, if it's a slow operation?


Add function interface support.

Motivation:
Add function interface support for tracer.
Modification:
Add function interface support for tracer.
Result:
Fixes #425 .
If there is no issue then describe the changes introduced by this PR.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@703c99a). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #424   +/-   ##
=========================================
  Coverage          ?   44.86%
  Complexity        ?      224
=========================================
  Files             ?      287
  Lines             ?     9480
  Branches          ?      936
=========================================
  Hits              ?     4253
  Misses            ?     4743
  Partials          ?      484

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703c99a...b6bf69a. Read the comment docs.

@glmapper Ready for your review.


feat(ofs): move DalFs into ofs

cc @Inokinoki, @Xuanwo , @oowl for reviewing.

I agree, and I consider to use https://github.com/Sherlock-Holo/fuse3 instead of https://github.com/cberner/fuser

I consider to use https://github.com/Sherlock-Holo/fuse3 instead of https://github.com/cberner/fuser

Seems fuse3 only supports linux? Do we have a plan to support platforms like windows and macos?

It's great, and it might be nice to have a proposal to discuss.

Oh, DalFs is only support Linux🫢
Is Windows has something similar to fuse?

I consider to use https://github.com/Sherlock-Holo/fuse3 instead of https://github.com/cberner/fuser

Seems fuse3 only supports linux? Do we have a plan to support platforms like windows and macos?

I have checked fuse3 source code, It supports the BSD operation system, But the MacOS fuse has some gap with BSD, Currently, it is not supported in fuse3, Maybe we can help fuse3 implement it.
BTW, fuse3 seems good for me.

Hi, @ho-229, would you like to start a new PR instead?


Parameters source_max_len & target_max_len

Hi !
Can anyone please confirm that parameters source_max_len & target_max_len are the length os input and outputs respectively? Meaning if we have set --source_max_len 16     --target_max_len 512 it means our instruction cannot be more than 16 tokens and output will be max 512 tokens?
Regards

I can confirm (or at least, it is my understanding) that in this case "source" means "input", and that "target" means "output".
It took me a while to figure out the terminology initially.

Thank you @BugReporterZ
So we should make sure that our text in instruction is not more than 16? And if it is less than 16, I ll get padded to be 16.

Yes, it shouldn't be larger or it will be truncated.
In my case, I set both source_max and target_max lengths to a high value and adjust lengths as required when building my datasets (from source files) rather than just naively truncating lengths, but this might not always be possible.

Got it, thank you.
Yes I just needed to tune this to see if it has impact on training and inference time. It takes around 25 seconds for inference and 45 seconds for training/iter on a 3090 GPU with 24 GB RAM.
So guess will try to reduce input and outside optimally to see if it has some effect.

Confused, how to adjust the sequence length? By setting source_max and target_max?


Example of precheck

I have not seen it yet, but the examples of precheck are sparse.
Would be great if here also an example can be taken with it.
Should I have overlooked the example, gladly refer to it.
https://help.sap.com/docs/ABAP_PLATFORM_NEW/fc4c71aa50014fd1b43721701471913d/f6e3880b641649b1b8247486579a1c9b.html?locale=en-US&q=precheck
Thanks!

Hi Marian,
as the app is intended to focus on annotations that affects UI, you don't see much BDEF/BEHV implementation examples in it unless they are required to make a certain annotation work. Side Effects was a special topic :)
Having said that, I'll take a look and see if it's possible to incorporate precheck in a future release. Thank you for the suggestion!
Regards,
Jessie


added cvtColor and converted it back before cv2.imshow

OpenCv requires RGB instead of BGR colour format.
Change improves markedly the detection probability and score value

@mtyka I tried to open a pull request but got problems with the Google CLA.
Got fed up, I hope you can read it anyway?? sorry

I signed it!

Gesendet: Donnerstag, 12. Dezember 2019 um 15:50 Uhr
Von: "googlebot"<EMAIL_ADDRESS>An: google-coral/examples-camera<EMAIL_ADDRESS>Cc: PjotrG<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Betreff: Re: [google-coral/examples-camera] added cvtColor and converted it back before cv2.imshow (#26)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers
Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ Googlers: Go here for more info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I'm not sure why the CLA is giving you trouble but we can't push the pull request without it :/
Since the fix is so small i just pushed the same manually in
https://github.com/google-coral/examples-camera/commit/16b54cd238bf74ab3d6bcca952b48961bb6285f2
Give it a try with the latest version - thanks for noticing the bug !

@mtyka
sorry Mike, but I guess like this it displays the wrong colors in 109: cv2.im_show, I'm a bit picky :(.
(Still struggeling with the CLA response, not able to issue a pull request).


Disabled control group doesn't disable the controls

Describe the bug
CdsInternalControlGroup disabled property doesn't disable the controls inside the group container.
disabled attribute is not passed to the controls inside the group container.
How to reproduce
https://codesandbox.io/s/control-group-disabled-e973f
Steps to reproduce the behavior:
Click on any of the checkboxes.
Expected behavior
Any of the controls inside a child of CdsInternalControlGroup should be disabled when the group has a disabled property.
Versions
Clarity project:

[x] Clarity Core
[ ] Clarity Angular/UI

Clarity version:

[ ] v3.x
[x] v4.x
[x] v5.x

#5633

@coryrylan is this expected to be done automatically or do apps need to set disabled themselves?

This is a bug, setting it should set disabled on the child controls of the group. I think the fix is in the updated method of control.element.ts add a syncProps call to sync the disabled property.
  updated(props: Map<string, any>) {
    super.updated(props);
    this.messages.forEach(message => syncProps(message, this, { disabled: props.has('disabled') }));

    // when the internal disabled is set by the group this will sync the native input
    syncProps(this.inputControl, this, { disabled: props.has('disabled') });
  }


Fix missing data property for Pusher internal events with empty data

This PR fixes missing data property for pusher_internal events.
Fixes #123

Working on test fixes.

@jabools I'm pretty happy with the implmentation after a couple of tweaks, but interested if you can point me to the part of the Pusher docs which says this is a requirement. I can only see it in the Presence channel docs which we already handle and I'm reluctant to send more data across the wire than necessary.

Unfortunately, I am not able to find anything that would make that property a requirement. As Pusher's docs state:

All events received and sent by clients can contain a data field. [...] In order to keep the protocol consistent, Pusher Channels tries to send the data field as a string.

it is not mandatory for events to have data property and there are only information about data property for presence channels. However, I believe it's worth considering providing it in private channels as the official Pusher API provides it and also their official Swift package ignores subscription_succeeded event if there is no data provided (https://github.com/pusher/pusher-websocket-swift/blob/master/Sources/Services/PusherConnection.swift#L448). The latter may be (of course) a bug, but for now they are complementary for one another.
It also looks like every pusher internal event contains data property, which is reasonable - they contain the actual data. This may be some kind of common algorithm and they do the same also for subscription_succeeded event - but this is just an allegation :)

Thanks @jabools - would you be able to test this branch and see if it resolves all of your issues?

@joedixon I'm responding from my work account :) I've just tested this branch and it works like a charm - iOS application works as expected, web application also works well and no side effects were noticed.


Fix Command List

I really want to see the better command list here so I see how c.frte and c.gf works

Wow an actual issue! So uh, what do you mean?

Well the "Check out the commands here." just takes me to a dead page

Well, if you want me to change the bot description this isn't the place. Also this project is pretty dead anyways.

Changed it by the way, I would recommend checking the source code


Enhance API usage instructions

Improve the API usage instructions on View API backend page.

There should be two alternatives for instructions:

User is logged in: current instructions, but remove the last sentence "Note: you may need to use your API Key, found on your profile page."
User is not logged in: Have a call example without API key. Instruct the users to log in.

Add error checking for user not logged in to show the latter version of instructions.
Also, add i18n tags for both versions.

I'd like to take it.

PR #832.

Looks like:

User is not authorized

User is authorized


Consider configuration options for connectionString bindings

What should we add or change to make your life better?
As a nice option in .NET Core we can bind appSettings to IOptions, do Configuration.Bind etc., for sections and so on which may include the connectionString for databases, redis and external services.
When using the connectionString in tye.yaml, you are forced to change that pattern and/or make exceptions in your code for if/then/nulls to set these values.
Can we have a targetSetting or settingName to inject this value as a part of the binding to not break this?

I don't understand the problem. Can you show a code sample of what you have to change today and what code you would like to write after the change?

Consider the settings here:
"MongoDB": {
    "Database": "TodoDB",
    "ConnectionString": "mongodb://root:example@localhost:27017"
  },

I can bind to a class using:
var config = new ServerConfig();
            Configuration.Bind(config);

class:
public class ServerConfig
    {
        public MongoDBConfig MongoDB { get; set; } = new MongoDBConfig();
    }

public class MongoDBConfig
    {
        public string Database { get; set; }
        public string ConnectionString { get; set; }
        }
    }

However, since the tye process creates a connectionStrings value.
Previously I was injecting just the MongoDBConfig into the context, but now having to also send IConfiguration also.
public TodoContext(MongoDBConfig config, IConfiguration configuration)
        {
            string conn = string.IsNullOrEmpty(config.ConnectionString) ? configuration.GetConnectionString("mongo") : config.ConnectionString;

            var client = new MongoClient(conn);
            _db = client.GetDatabase(config.Database);
        }

I think this feature is better solved by this:

https://github.com/dotnet/tye/issues/377

The idea is to allow specifying aliases for bindings. You can have your own environment variables for   a binding. In this case MONGODB__CONNECTIONSTRING.
PS: The only difference here is that .NET Core has a different way to express connection strings that you aren't currently using. But yes, it does assume that you will be using the GetConnectionString method instead of the typical configuration binding.

Closing in favor of #377


Remove ListFilter logic

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[ ] Feature
[ ] Code style update
[x] Refactor
[ ] Docs
[ ] Underlying tools
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[X] No

Other information:
I'm currently studying the project to see patterns used in real world projects, and I found this logic that's currently being used, but it seems like there is not much need for it?
I would like if possible your opinion on why you guys decided to use the ListFilter, instead of a cleaner solution?
Thank you

Thanks!
I think it is fine to remove ListFilter.
Would you also remove other usages of ListFilter in this PR altogether, please?

Yes!


The unit test for OpaPremodit

The current set of the unit tests was unable to prevent the bug introduced by #515.
Although this bug was fixed in #521, we need to add proper unit tests for OpaPremodit.

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

#523 #524 and in addition #525


NotAssigned taxa without children

https://data.catalogueoflife.org/dataset/3/classification?taxonKey=06ec82f1-dd3d-43e1-a75f-b5cd4198e804
Frontend version: 82de357 September 10, 2021 10:42 AMBackend version: 5179b8d September 10, 2021 1:46 PM
I have spot NotAssigned taxa without children in different parts of the tree.
For example:
Phylum Arthropoda - class NotAssigned (empty)
Class Insecta - order NotAssigned (empty)
Family Zorotypidae - subfamily NotAssigned (empty)

There are indeed species dangling lose. But the API returns the "Not assigned" placeholder with childCount=0 why the UI does not allow you to open it and show them.


Feature: Admin Page

Feature

[ ] Summarize Logging records
[ ] See user google-form supply application (or write form)
[ ] admin login

잠시 보류