Revert "[duro_gps_driver] Updated type names to latest libsbp."

Reverts szenergy/duro_gps_driver#34

Reverting, because it does not build:
$ colcon build --symlink-install --packages-select duro_gps_driver

Starting >>> duro_gps_driver
--- stderr: duro_gps_driver
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp: In function ‘void pos_ll_callback(u16, u8, u8*, void*)’:
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:177:3: error: ‘msg_pos_llh_t’ was not declared in this scope; did you mean ‘sbp_msg_pos_llh_t’?
  177 |   msg_pos_llh_t *latlonmsg = (msg_pos_llh_t *)msg;
      |   ^~~~~~~~~~~~~
      |   sbp_msg_pos_llh_t
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:177:18: error: ‘latlonmsg’ was not declared in this scope
  177 |   msg_pos_llh_t *latlonmsg = (msg_pos_llh_t *)msg;
      |                  ^~~~~~~~~
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:177:46: error: expected primary-expression before ‘)’ token
  177 |   msg_pos_llh_t *latlonmsg = (msg_pos_llh_t *)msg;
      |                                              ^
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp: In function ‘void orientation_callback(u16, u8, u8*, void*)’:
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:399:5: error: ‘msg_orient_quat_t’ was not declared in this scope; did you mean ‘sbp_msg_orient_quat_t’?
  399 |     msg_orient_quat_t *orimsg = (msg_orient_quat_t *)msg;
      |     ^~~~~~~~~~~~~~~~~
      |     sbp_msg_orient_quat_t
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:399:24: error: ‘orimsg’ was not declared in this scope
  399 |     msg_orient_quat_t *orimsg = (msg_orient_quat_t *)msg;
      |                        ^~~~~~
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:399:53: error: expected primary-expression before ‘)’ token
  399 |     msg_orient_quat_t *orimsg = (msg_orient_quat_t *)msg;
      |                                                     ^
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp: In function ‘void time_callback(u16, u8, u8*, void*)’:
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:421:3: error: ‘msg_gps_time_t’ was not declared in this scope; did you mean ‘sbp_msg_gps_time_t’?
  421 |   msg_gps_time_t *time_gps = (msg_gps_time_t *)msg;
      |   ^~~~~~~~~~~~~~
      |   sbp_msg_gps_time_t
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:421:19: error: ‘time_gps’ was not declared in this scope; did you mean ‘timegm’?
  421 |   msg_gps_time_t *time_gps = (msg_gps_time_t *)msg;
      |                   ^~~~~~~~
      |                   timegm
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:421:47: error: expected primary-expression before ‘)’ token
  421 |   msg_gps_time_t *time_gps = (msg_gps_time_t *)msg;
      |                                               ^
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp: In function ‘void vel_ned_cov_callback(u16, u8, u8*, void*)’:
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:437:3: error: ‘msg_vel_ned_cov_t’ was not declared in this scope; did you mean ‘sbp_msg_vel_ned_cov_t’?
  437 |   msg_vel_ned_cov_t *vel_ned_cov = (msg_vel_ned_cov_t *)msg;
      |   ^~~~~~~~~~~~~~~~~
      |   sbp_msg_vel_ned_cov_t
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:437:22: error: ‘vel_ned_cov’ was not declared in this scope
  437 |   msg_vel_ned_cov_t *vel_ned_cov = (msg_vel_ned_cov_t *)msg;
      |                      ^~~~~~~~~~~
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:437:56: error: expected primary-expression before ‘)’ token
  437 |   msg_vel_ned_cov_t *vel_ned_cov = (msg_vel_ned_cov_t *)msg;
      |                                                        ^
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp: In function ‘void orientation_euler_callback(u16, u8, u8*, void*)’:
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:444:3: error: ‘msg_orient_euler_t’ was not declared in this scope; did you mean ‘sbp_msg_orient_euler_t’?
  444 |   msg_orient_euler_t *orimsg = (msg_orient_euler_t *)msg;
      |   ^~~~~~~~~~~~~~~~~~
      |   sbp_msg_orient_euler_t
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:444:23: error: ‘orimsg’ was not declared in this scope
  444 |   msg_orient_euler_t *orimsg = (msg_orient_euler_t *)msg;
      |                       ^~~~~~
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:444:53: error: expected primary-expression before ‘)’ token
  444 |   msg_orient_euler_t *orimsg = (msg_orient_euler_t *)msg;
      |                                                     ^
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp: In function ‘void imu_callback(u16, u8, u8*, void*)’:
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:474:5: error: ‘msg_imu_raw_t’ was not declared in this scope; did you mean ‘sbp_msg_imu_raw_t’?
  474 |     msg_imu_raw_t *imumsg = (msg_imu_raw_t *)msg;
      |     ^~~~~~~~~~~~~
      |     sbp_msg_imu_raw_t
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:474:20: error: ‘imumsg’ was not declared in this scope; did you mean ‘imu_msg’?
  474 |     msg_imu_raw_t *imumsg = (msg_imu_raw_t *)msg;
      |                    ^~~~~~
      |                    imu_msg
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:474:45: error: expected primary-expression before ‘)’ token
  474 |     msg_imu_raw_t *imumsg = (msg_imu_raw_t *)msg;
      |                                             ^
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp: In function ‘void imu_aux_callback(u16, u8, u8*, void*)’:
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:523:3: error: ‘msg_imu_aux_t’ was not declared in this scope; did you mean ‘sbp_msg_imu_aux_t’?
  523 |   msg_imu_aux_t *imuauxmsg = (msg_imu_aux_t *)msg;
      |   ^~~~~~~~~~~~~
      |   sbp_msg_imu_aux_t
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:523:18: error: ‘imuauxmsg’ was not declared in this scope; did you mean ‘imu_msg’?
  523 |   msg_imu_aux_t *imuauxmsg = (msg_imu_aux_t *)msg;
      |                  ^~~~~~~~~
      |                  imu_msg
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:523:46: error: expected primary-expression before ‘)’ token
  523 |   msg_imu_aux_t *imuauxmsg = (msg_imu_aux_t *)msg;
      |                                              ^
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp: In function ‘void mag_callback(u16, u8, u8*, void*)’:
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:569:3: error: ‘msg_mag_raw_t’ was not declared in this scope; did you mean ‘sbp_msg_mag_raw_t’?
  569 |   msg_mag_raw_t *magmsg = (msg_mag_raw_t *)msg;
      |   ^~~~~~~~~~~~~
      |   sbp_msg_mag_raw_t
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:569:18: error: ‘magmsg’ was not declared in this scope; did you mean ‘mag_msg’?
  569 |   msg_mag_raw_t *magmsg = (msg_mag_raw_t *)msg;
      |                  ^~~~~~
      |                  mag_msg
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:569:43: error: expected primary-expression before ‘)’ token
  569 |   msg_mag_raw_t *magmsg = (msg_mag_raw_t *)msg;
      |                                           ^
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp: In function ‘int main(int, char**)’:
/home/dev/ros2_ws/src/duro_gps_driver/src/duro_node.cpp:650:3: error: ‘sbp_register_callback’ was not declared in this scope; did you mean ‘sbp_remove_callback’?
  650 |   sbp_register_callback(&sbp_state, SBP_MSG_POS_LLH, pos_ll_callback, NULL, &pos_ll_callback_node);
      |   ^~~~~~~~~~~~~~~~~~~~~
      |   sbp_remove_callback
gmake[2]: *** [CMakeFiles/duro_node.dir/build.make:76: CMakeFiles/duro_node.dir/src/duro_node.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:137: CMakeFiles/duro_node.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2
---
Failed   <<< duro_gps_driver [4.41s, exited with code 2]

Summary: 0 packages finished [5.72s]
  1 package failed: duro_gps_driver
  1 package had stderr output: duro_gps_driver


move wad extraction to library

other people might want to use the extraction

I don't think this lends itself well to being a library function because it would be very inflexible.
kobold_wad::Archive currently enables random access by file paths and iterating over all files which should be good enough for people to work with.

https://tenor.com/view/lizard-dancing-lizard-cry-about-it-gecko-dance-gif-20175430


What data was used to train riffusion?

Super cool work! Could you provide more information about the data source used to train riffusion?
For example:

How much audio data did you use for finetuning?
What's the source of the audio data?
How did you get the paired text with the audio? (e.g. is it extracted from the tags or music description?)

Thanks so much!

Yes it would be interesting.
On an entirely unrelated note, having dealt with them in the past, some Recording Industry Associations are technically inept (or obtuse) and absolutely ruthless when it comes to perceived IP infringement.
I once received a takedown request for a user's post that linked to Drake's Instagram else the well-known hosting service I used at the time was going to suspend my account. Sorry for the tangent.
Back on topic, datasets are cool I agree.

@scf4 Public figures working in ML like the authors of Riffusion should stick to royalty free datasets. The strategy for AI music will be to make fine-tuning really easy and available to all, easy enough for a 12 y/o to do it comfortably just by following a few easy steps. 12 y/o kids don't care about copyrights, it will be limewire all over again and this time the music industry will be utterly powerless.

I've opened a similiar issue on the app's repository: https://github.com/hmartiro/riffusion-app/issues/12
Dataset info is very important and will open doors for creators everywhere.

Additional fine tuning and data information has been added to the model-card. This was trained using approaches similar to hugging face examples, but fine-tuning can be achieved with very small datasets using a dreambooth approach. Will look to add tools to make fine tuning on your own data simpler.

@scf4 Public figures working in ML like the authors of Riffusion should stick to royalty free datasets. The strategy for AI music will be to make fine-tuning really easy and available to all, easy enough for a 12 y/o to do it comfortably just by following a few easy steps. 12 y/o kids don't care about copyrights, it will be limewire all over again and this time the music industry will be utterly powerless.

If you check out OpenAI's jukebox project, they've clearly trained with copyrighted music and don't really care.

@scf4 Public figures working in ML like the authors of Riffusion should stick to royalty free datasets. The strategy for AI music will be to make fine-tuning really easy and available to all, easy enough for a 12 y/o to do it comfortably just by following a few easy steps. 12 y/o kids don't care about copyrights, it will be limewire all over again and this time the music industry will be utterly powerless.

It's well understood at this moment that the current copyright laws are lagging behind (as they always do), we don't know what they will be when the finally do land. Just like with Napster when the laws do catch up, the issue will be addressed.
Please let's not turn a git repo comment section into a political driven debate on ethics.  I'd recommend Reddit if you want to argue or Quora if you explore the legal, ethical & philosophical ramifications; there is more then enough of these discussions  there..

@scf4 Public figures working in ML like the authors of Riffusion should stick to royalty free datasets. The strategy for AI music will be to make fine-tuning really easy and available to all, easy enough for a 12 y/o to do it comfortably just by following a few easy steps. 12 y/o kids don't care about copyrights, it will be limewire all over again and this time the music industry will be utterly powerless.

If you check out OpenAI's jukebox project, they've clearly trained with copyrighted music and don't really care.

openai can get rights to them.

I was also curious about the initial training. I'm not so bothered about specifics of the dataset (though general info on size would help) but more about training params (lr, bs, etc.) and duration (epochs/steps).


Better event queue

There are moments where the event queue can be starved with the same event and cause problems. This changes the implementation to only add events that are not currently in the queue.

Hmm to be honest this makes the operation of the event queue harder to understand for me. But I guess it achieves the same goal of not having the queue fill up with events that are not serviced in time. I would just worry this sets us in the future where we might have events that do happen in quick succession that should be buffered but instead will be dropped.


ci: using action for publishing

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:


Getting TypeScript error while compiling webpack

I'm submitting a bug report

Aurelia Skeleton Version
skeleton-typescript-webpack

Framework Version:
1.1.2

Please tell us about your environment:

Operating System:
Windows 10

Node Version:
6.10.0

NPM Version:
4.3.0

JSPM OR Webpack AND Version
webpack 2.1.0-beta.27

Browser:
all
Language:
TypeScript 2.2.1

Current behavior:
while compiling webpack, I am getting the following error
   [7] ./~/css-loader!./~/font-awesome/css/font-awesome.css 42 kB {0} [built]
             factory:532ms building:1247ms = 1779ms
webpack: Compiled successfully.
[at-loader] ./test/e2e/demo.spec.ts:17:52
    TS2345: Argument of type '"Welcome | Aurelia"' is not assignable to parameter of type 'Expected<Promise<string>>'.

[at-loader] ./test/e2e/demo.spec.ts:21:43
    TS2345: Argument of type '"Welcome to the Aurelia Navigation App"' is not assignable to parameter of type 'Expected<Promise<string>>'.

[at-loader] ./test/e2e/demo.spec.ts:31:43
    TS2345: Argument of type '"ROB EISENBERG"' is not assignable to parameter of type 'Expected<Promise<string>>'.

[at-loader] ./test/e2e/demo.spec.ts:35:47
    TS2345: Argument of type 'true' is not assignable to parameter of type 'Expected<Promise<any>>'.

[at-loader] ./test/e2e/demo.spec.ts:40:52
    TS2345: Argument of type '"Github Users | Aurelia"' is not assignable to parameter of type 'Expected<Promise<string>>'.

[at-loader] ./test/unit/users.spec.ts:36:30
    TS2345: Argument of type 'number[]' is not assignable to parameter of type 'Expected<ArrayLike<IUser>>'.
  Type 'number[]' is not assignable to type 'ObjectContaining<ArrayLike<IUser>>'.
    Property 'jasmineMatches' is missing in type 'number[]'.

[at-loader] ./test/unit/users.spec.ts:37:34
    TS2345: Argument of type 'number[]' is not assignable to parameter of type 'Expected<ArrayLike<IUser>>'.
  Type 'number[]' is not assignable to type 'ObjectContaining<ArrayLike<IUser>>'.

Expected/desired behavior:

Download Aurelia skeleton navigation -1.1.2 and extract it

From the extracted folder, execute the following commands

cd skeleton-typescript-webpack
npm install
npm start

@EisenbergEffect this is unrelated to the webpack plugin, it's actual Typescript errors in the skeleton example files (in demo.spec.ts and users.spec.ts apparently).
Can you re-assign to @niieani? I don't have permissions in this repo.


ENH: Add sosfiltfilt

This one is something I meant to add from back when I worked on #3717. Since #3717 (EDIT: #6137) is some ways off presumably it's probably better to get this in than wait. It would be great to have for 0.18 if possible, but not strictly necessary.

@WarrenWeckesser @endolith you might be interested in this since you were involved in sosfilt and zpk2sos way back when :)

Thanks for the reviews, comments addressed. I think (hope?) this is actually a pretty straightforward change so it seems like merging for 0.18 is doable. @e-q do you agree?

Looks like the current failures are a missing entry in __init__.py, and SkipTest not importing in python 2.7 and 3.4.

@rgommers do you think it's reasonable to try for 0.18 for this?

@rgommers do you think it's reasonable to try for 0.18 for this?

Why not? It's not a blocker so I don't think we should delay the branching for it (up to @ev-br of course), but it seems doable to get this merged by Sunday.

Great. Tests are passing now, @e-q are you happy with it now?

This will be great to get into scipy.signal.  I've been trying it out, and ran into an issue with odd order filters.  I'm not sure this is actually a problem, and if it is a problem, I'm not sure if it is a problem with sosfiltfilt or something else.
Here's a script.  When order is odd, the outputs of filtfilt and sosfiltfilt don't match.
from __future__ import print_function

import numpy as np
from scipy.signal import butter, filtfilt, sosfiltfilt, zpk2tf, zpk2sos
import matplotlib.pyplot as plt

order = 5

z, p, k = butter(order, 0.15, output='zpk')
b, a = zpk2tf(z, p, k)
sos = zpk2sos(z, p, k)

x = np.random.randn(80)
y1 = filtfilt(b, a, x)
y2 = sosfiltfilt(sos, x)

if not np.allclose(y1, y2):
    print("Filtered signals are not close.")
    print("Max difference:", np.max(np.abs(y1 - y2)))
    plt.plot(y1 - y2)
    plt.show()
else:
    print("Filtered signals are approximately the same.")

Here's the plot of y1 - y2 when order is 5:

Because the order is odd, the SOS representation has an extra zero and pole at the origin.  I suspect that is the source of the problem.   This might be unavoidable.  I'll continue experimenting and try to get a better handle on the issue this evening.

Do they match for sosfilt and lfilter? If so, what if there are initial
conditions?

Do they match for sosfilt and lfilter?

Good question.  When I replaced filtfilt and sosfiltfilt with lfilter and sosfilt (resp.), the filtered signals match for even and odd orders.

I bet it's the pad length

Yes, it looks like it is something to do with padding.  The outputs of y1 = filtfilt(b, a, x, padtype=None) and y2 = sosfiltfilt(sos, x, padtype=None) agree for even and odd orders.

filtfilt and sosfiltfilt also agree if I explicitly give them the same padlen.  So the difference comes from using different default pad lengths.
I also noticed that the description of the default value of padlen in the docstring needs to be fixed. Currently it says The default value is ``3 * max(len(a), len(b))``.

The filtered outputs y1 and y2 in the script agree for even and odd orders if I use
y1 = filtfilt(b, a, x)
y2 = sosfiltfilt(sos, x, padlen=6*sos.shape[0] + (0 if (order & 1) else 3))

In general, sosfiltfilt won't know if one of the sections is actually a first order section (with a pole and zero at the origin that cancel), so that formula won't work.  However, if we do b, a = sos2tf(sos), then len(a) is 2*sos.shape[0] + 1, so the best default padlen (for consistency with filtfilt) is probably 3*(2*sos.shape[0] + 1).
(By the way, I have no idea where the original default of max(len(a), len(b)) for filtfilt comes from.  It seems arbitrary.  Why should the default pad length depend on the order like that?)

...so the best default padlen (for consistency with filtfilt) is probably 3*(2*sos.shape[0] + 1).

And now that I've taken another look at the code, I see that that is exactly what the default padlen in sosfiltfilt is.  Sorry for the noise!

So now my only suggestions are for some tweaks to the documentation.  In the description of the return value, just drop the reference to the data type of the result.  The function does, in fact, return a complex array when the input is complex.  And in the description of padlen, fix the description of the default value.  Other than that, this looks ready to go.

Sorry @WarrenWeckesser I should have saved you some time by telling you what the current behavior was, but was on mobile :(
Without looking at the math, I suspect that we get the actual order by looking at whether the third coefficient is zero. I'll have to check. Then we can get exact equivalence for odd-order systems.

(in terms of padlen I mean)

@WarrenWeckesser added an equivalence test for odd order (it passes, hooray!) and updated the computation and docstrings. If you have time, see if you agree.

Why should the default pad length depend on the order like that?

I think this comes from MATLAB, since I know they do something similar. Octave has a 3 * (max(length(a), length(b)) - 1) in there. Unfortunately it's not a great choice, since what (I think) really matters is the effectively length of the impulse response, which depends on the specific locations of the poles and zeros rather than their count. I know people who have been burned by this heuristic, so maybe we should add a .. note:: about it, but I'd have to think about the phrasing.

Although thinking about it more, having that many values ensures that your system at least has all of its delay taps depend some aspect of the input signal, beyond the single edge value (which we otherwise use to set the initial conditions), which might also be part of the motivation.

Your updated default padlen looks reasonable, so other than the comment I made about the description of the default padlen in the docstring (i.e. it is 3 times the stated amount), this looks ready to go.

Thanks for another short-notice look @WarrenWeckesser, docstring fixed.
@e-q feel free to have a look in the next few hours if you have time, otherwise since people seem happy with it I'll go ahead and merge so it makes it to 0.18.

How about squashing the commits?  Then I'll merge.  (In the "squash commits to keep the history relative simple and clean" vs "keep every little committed tweak" debate, I'm in the "squash" camp.)

Wait, there is one more thing.  Add a note about sosfiltfilt to the 0.18 release notes.

Add a note about sosfiltfilt to the 0.18 release notes.

Hah! I was just doing that when you posted it. Not sure if great minds think alike or fools seldom differ here :)
I'll add it and squash and ping you when the CIs are done. Thanks for the quick reviews.

Merged.  Thanks, Eric!


github flow errors

cc / @asood123 @carlosascari from user mehdy dara:
I have a Github organization (https://github.com/FountainJS) with a main entry repo (https://github.com/FountainJS/generator-fountain-webapp).
I try to add this project to OpenCollective by following the button "Apply Now" in https://opencollective.com/opensource.
Everything works well until the last step 3/3.
Yesterday I submit by "Create" button but the server respond with error 500.
Today the server respond with error 400
    "error": {
        "code": 400,
        "type": "validation_failed",
        "message": "Unique Constraint Error.",
        "fields": [
            "GroupId",
            "UserId",
            "role"
        ]
    }
}
Maybe the error 500 save Fountain in your DB and now we can't finish submitting.

PS: I am seeing 8 separate groups created under the same name.

PS: I am seeing 8 separate groups created under the same name.

Sorry I tried many times.

No worries! It's on our end if it's letting you do it. :)

Related Issue
https://github.com/OpenCollective/OpenCollective/issues/140
PR
https://github.com/OpenCollective/opencollective-website/pull/302

Fixed: https://github.com/OpenCollective/opencollective-api/pull/462


ADDED IMPLEMENTATION OF DOUBLY LINKED LIST AND UPDATED README.md of C…

… DIRECTORY

Have you read the Contributing Guidelines on Pull Requests?
YES
Description
I have added the implementation of Doubly Linked List in C Language as well as updated README.md of the same.
Checklist

[YES ] I've read the contribution guidelines.
[YES ] I've checked the issue list before deciding what to submit.
[YES ] I've edited the README.md and link to my code.

Related Issues or Pull Requests
https://github.com/TesseractCoding/NeoAlgo/issues/2323

@all-contributors bot please add @imsushant12 for code


[Google Gemini] Ask About Selected Text -> Could not get the selected text

Extension
https://www.raycast.com/EvanZhouDev/raycast-gemini
Description
I tried to use the 'Ask About Selected Text' feature, but I just get the message 'Could not get the selected text' and it doesn't proceed.
Steps To Reproduce

drag text
use 'Ask About Selected Text'
(red circle) Could not get the selected text

Current Behaviour
No response
Expected Behaviour
No response

@raycastbot close this issue
Privacy and Security - Accessibility - raycast - on
This solved it!!!


split

The regular expression is quoted here:
foo.split(/\d/);
This fails to render anything.
'a1b2c'.split(/\d/);

On version 0.3.4 the first example is solved but the second one not yet:
The regular expression in the example is no longer quoted.
String dot chaining is not yet supported.

Fixed on version 0.3.9


Feature Request: Custom Background

Can you please add an option to provide an image which will be used as Sublime's background instead of the application that's behind it?
Something like this - ConEmu | Settings: Background

As of now, I don't know a feasable method to achieve that since this plugin only modifies the window's opacity using WinAPI. It could be modified by another program by updating the layered window, but I guess it would completely make the IDE unresponsive, unless the SublimeText itself allows it, I don't know any other method to achieve that. Sorry.

@vhanla No worries! Thanks for a great plugin! :)


Update README to Provide Additional Information

The current README lacks sufficient details on project setup, structure, and more. Updating it to include these sections will help improve clarity for contributors and users.

Approved

Approved


Scripting: version of TableChooserDialog.executor that runs on all selected rows

Is your feature request related to a problem? Please describe.
TableChooserDialog can be initialized with a TableChooserExecutor executor. When the button is clicked, the executor will be invoked on all selected row objects via public boolean execute(AddressableRowObject rowObject)
There are several major (and many minor) reasons why having the executor instead implement public boolean execute(Collection<AddressableRowObject> rowObjects) would be useful:
1.) Able to perform aggregates on selected objects e.g. sum of sizes without needing to do crazy hacks.
2.) Able to benefit from calling APIs that expect Collections, instead of calling once per object
3.) More control over transactions
4.) Some things are just extremely difficult to perform with the single element execute. For example, if I want to call either foo or bar on all elements depending on a call to askYesNo, I do not see an obvious way to do this with the original execute. I could store a private variable that records the result of the first askYesNo, but I have no way of knowing when the execution is finished so that I can clear the variable for subsequent runs.
The only downsides I see are:
1.) Refactoring old scripts - there are 4 (ShowConstantUse, FixupNoReturnFunctionsScript, GhidraScriptTest, FindSharedReturnFunctionsScript) that contain it, with ShowConstantUse not actually using it right now. Rewriting is fairly easy though.
2.) Easy for people to shoot themselves in the foot if they do not for example, check if an object is still in the model before calling something that would not make sense. Then again, I have not seen anyone else raise issues about the TableChooserDialog so...
Describe the solution you'd like
A refactor of the executor interface to public boolean execute(Collection<AddressableRowObject> rowObjects), or at least the option to make a dialog of this form. I would also like the button to always be selectable even if no rows are selected - for times when the button's functionality is independent of the selection.
Describe alternatives you've considered

Modify the classes/ create alternate versions of TableChooserDialog myself
Very ugly reflection

That sounds like a reasonable way to implement it while avoiding interfering with existing scripts that use the original execute


refactor(linter): rename flat.rs to config.rs

simply renames flat.rs to config.rs to more accurately reflect the file's purpose

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#8034
#8033  👈 (View in Graphite)
#8032
main

How to use the Graphite Merge Queue
Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 20, 9:01 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.


feat: add chooseFromT for getting a typed response from the selection…

… (#74)

Hi @groma84, are you aware that your PR branch is not building?

I'll fix the build as soon as I find the time! probably messing something up while merging manually


Added material theme and component styles

#38 Added components styles for:

checkboxes #63
labels #64
buttons #60
inputs #60
lists
radio buttons #61
switches #62
typography

I will wait for the build to be fixed before I merge the styling implementations.

Changes Unknown when pulling cfe8a8e1371a04e0875f0ad1ceef3da2e6220fe4 on simeonoff:master into ** on Infragistics:master**.


onMarkupChanged and onMentionAdd

Hi! I'm processing the data (layouting it with html tags) in onMarkupChanged. But I see, that if I'm not typing anything rather than just @ mention the data in onMarkupChanged callback is wrong and contains only @. But If typed anything than all is okay.

What I can do to enable mentions callback firing in case I'm just entering only mention?

It is the same if I'm entering two mentions in row.

@JEuler I don't understand exactly can you explain in more detail that would be great!

Hi! I meant that when you tap on Suggestion (Mention) the onMarkupChanged is not firing and nothing is added to the rawComment variable I'm defining. So, the problem is that: onMarkupChanged callback is not firing in case we are tapping on the suggestion and it is added to textfield.

Is that clear now? :)

Ahh Yes, I will take a look at it, Thanks for the clarification.

Did you have any chance to look? :)

@JEuler Gonna look at today

@fayeed Thank you very very much! 🤗

@JEuler fixed in v1.0.2

Insanely cool! Thanks! 🤗


ExpandCollapse Pattern not run on .Click()

Hi @Descolada
I try to click on a menu in Microsoft Teams

Somehow the .Click function does not work.
El := TeamsEl.WaitElementExist("AutomationId=RecordingMenuControl-id",,,,1000)
El.Click() ; menu is not expanded
I don't understand how your library is working here/ how to get it run.
Would be great if you could help

Hello,
I have a private Teams account which doesn't seem to have the "Record and transcribe" menuitem as part of a meeting. Is there any way to reproduce this bug with a private account?

You could try to reproduce on a similar menu which need to expand
more->menu 1->menu 2
I can hardly test on a free version myself.
On Fri, Nov 3, 2023, 21:36 Descolada @.***> wrote:

Hello,
I have a private Teams account which doesn't seem to have the "Record and
transcribe" menuitem as part of a meeting. Is there any way to reproduce
this bug with a private account?
—
Reply to this email directly, view it on GitHub
https://github.com/Descolada/UIAutomation/issues/45#issuecomment-1793064177,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABRIYTCIDZYGLCMTQ2Y3TQLYCVIVPAVCNFSM6AAAAAA64RE2SCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTGA3DIMJXG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

I did test it and it worked as expected, all menuitems were clicked. Running Windows 10, Microsoft Teams classic.
#requires AutoHotkey v1
#include <UIA_Interface>

UIA := UIA_Interface()
TeamsWinTitle := "Test | Microsoft Teams"
WinActivate %TeamsWinTitle%
WinWaitActive %TeamsWinTitle%,, 1

teams := UIA.ElementFromHandle(TeamsWinTitle)
teams.FindFirstBy("AutomationId=callingButtons-showMoreBtn").Click()
teams.WaitElementExist("AutomationId=SettingsMenuControl-id").Click()
teams.WaitElementExist("AutomationId=device-settings-button").Click()
ExitApp

If the element is found correctly then perhaps El.ControlClick() works instead?
By the way, if at all possible I highly recommend switching to AHK v2 and UIA-v2. UIA-v2 has a better inspection tool, more search options, and is actively being developed. The corresponding v2 code:
#requires AutoHotkey v2
#include <UIA>

TeamsWinTitle := "Test | Microsoft Teams"
WinActivate TeamsWinTitle
WinWaitActive TeamsWinTitle,, 1

teams := UIA.ElementFromHandle(TeamsWinTitle)
teams.FindElement({AutomationId:"callingButtons-showMoreBtn"}).Click()
teams.WaitElement({AutomationId:"SettingsMenuControl-id"}).Click()
teams.WaitElement({AutomationId:"device-settings-button"}).Click()
ExitApp


refactor(table): use console.log to render output

Codecov Report

Merging #258 (5ea1a89) into main (8107875) will decrease coverage by 0.63%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
- Coverage   73.32%   72.68%   -0.64%
==========================================
  Files          80       80
  Lines        6252     6252
  Branches     1071     1071
==========================================
- Hits         4584     4544      -40
- Misses       1647     1681      +34
- Partials       21       27       +6

Impacted Files
Coverage Δ

table/table.ts
84.61% <0.00%> (ø)

command/completions/fish.ts
52.17% <0.00%> (-26.09%)
:arrow_down:

command/help/_help_generator.ts
52.31% <0.00%> (-4.63%)
:arrow_down:

command/command.ts
78.57% <0.00%> (-3.65%)
:arrow_down:

prompt/select.ts
87.30% <0.00%> (-1.59%)
:arrow_down:

prompt/_generic_prompt.ts
78.26% <0.00%> (-1.45%)
:arrow_down:

ansi/ansi_escapes.ts
96.36% <0.00%> (-0.91%)
:arrow_down:

prompt/checkbox.ts
83.33% <0.00%> (-0.84%)
:arrow_down:

flags/flags.ts
49.85% <0.00%> (-0.29%)
:arrow_down:

flags/_utils.ts
92.75% <0.00%> (ø)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8107875...5ea1a89. Read the comment docs.


Clarify scheduled task's cadence for SSDs

Also remove the incorrect comment about schedule task for SSDs
and VHDs on SSDs.

@ChandKV : Thanks for your contribution! The author(s) have been notified to review your proposed change. @eross-msft

#sign-off

@illfated: I'm sorry - only the author of this article, @eross-msft, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Fix 2D jitter on slight slope

Fix #59295
Before:

After:

Edit: I saw that the prefix p_ was missing on the other parameters of the methods *snap*, I added them in 2D and 3D.

Thanks!


Mbio apps: Add in-line user-facing documentation

There are a lot of places wed like to do some explaining for the computes. some things that come to mind immediately:

Tell people were using pcoa in beta div, and why and what it might be good or bad at
Tell people what parameters were using w maaslin2 in diff abund, and why and what it might be good or bad at
Tell people about correlation methods used in the correlation apps, particularly once we introduce compositional methods for taxa-taxa
Tell people what prefilters were using for features in correlation apps
Tell people where they can find the R if theyd like
Other things i havent thought of yet

is this a duplicate of https://github.com/VEuPathDB/web-monorepo/issues/771?

maybe. i didnt see that one on the mbio tab of the project board, but did see this and if im honest was generally a bit confused.

added these thoughts to the other, and closing this


udisks: backport patch for crash on exit

Description of changes
With modern versions of glib udisks reliably crashes when being shut down. The patch has been merged in 2021 [1] but there hasn't been a release including that patch yet [2]. Backport it to avoid crashes.
[1] https://github.com/storaged-project/udisks/pull/926
[2] https://github.com/storaged-project/udisks/issues/1024#issuecomment-1296159423
Requesting backport for this as well, version is the same on 22.11.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2056

Pinging @Mindavi @Artturin as you've merged past changes to this package


Bug: Expert mode displays curves with a narrower bandwidth than what is entered.

Expert mode displays curves with a narrower bandwidth than what is entered.
Entering a boost or cut with a bandwidth of 3 octaves displays a curve with a bandwidth of about 2 octaves. The true bandwidth seems to be roughly 50% wider than the value entered.
Verify this for yourself by comparing the eqMac display to any other parametric EQ with the same values entered.
I'm not certain whether the changes to audio reflect the displayed curves or the true values entered.

macOS 10.15.7
eqMac Version 1.0.0
eqMac UI Version 1.4.0

I'm investigating this now, seems like you are correct but it seems to be more of a problem on higher bandwidths, 1 octave looks very Similar to a lot of EQ plugins, but as you go higher it starts to be more incorrect.
The visual doesn't affect the sound in any way btw, so 3 Octaves will be 3 real octaves, as long as Apple got their maths correct

New curve for Peaking filter:

New curve for High/Low shelf:

This was released as part of Over the Air UI update v1.5.2. Refresh eqMac a you should see the new curve shapes.
Thanks for reporting this.

Looks good now. Thanks for looking into it.


Stellar Staging - After converting wallet with locked tokens, the tokens are gone

Repro steps

Have a revine account with 1 daily wallet with no TFT, 1 savings wallet with 3 transactions, 1 non locked, 1 locked 2020, 1 locked 2021
Change to stellar

Expected Result
Account with 1 TFTA locked, 1 TFTA unlocked, 1 TFT locked
Actual Result
No tokens at all on the stellar version. 0 for every currency
5 minutes later after refreshes and after jonasWijne retrying some things, 1 TFTa popped up
System Info

Should be fixed with re-opening the wallet by this issue: https://github.com/threefoldtech/3bot_wallet/issues/99

@tobiaschielens did an entirely new case, converting 6 wallets, everything converted correctly except the locked tokens I had on one wallet. Both the locked in 2020 and in 2021 are nowhere to be seen,
I have restarted the wallet twice and still nothing

Issue https://github.com/threefoldfoundation/tft-stellar/issues/130 needs to be resolved to fix this


Method signatures

What are thoughts on changing the naming convention?
get(str1, str2);
get(str1, str2, callback); // which replaces getAsync by arguments.length == 3

This would make it more compatible with something like promisification.

Good idea. Will do now.

Done. Pushed v2 with a slight performance update.


Move translations from core to theme

What is the motivation for adding / enhancing this feature?

Translations are tightly coupled with theme therefore should be in a theme. Different themes could have different translations.
What are the acceptance criteria

[ ] Move translations from core/i18n/resource/i18n to {themeroot}/i18n

Can you complete this feature request by yourself?

[ ] YES
[x] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[x] This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[ ] (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[ ] (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Additional information

Totally removing it from the core? I mean: we’ve got translations in theme that can override the core ones (I belive); i thought we should keep them in the core for a fallback if anyone is using vsf core and just misss the i18n setup etc. however I’m up for discussion @andrzejewsky @patzick @lukeromanowicz wdyt?

IMHO we should put them into separate src/* modules - language packs. Ofc theme can have some translationsas well, that should be able to override module values as, but there is a set of standard values that are commonly used everywhere.

I completely agree with this issue. All translation files should be theme-specific.
However, we should leave in core translations which are strictly from the core, like messages throw as errors from actions etc. I don't have notifications in mind here - IMO there shouldn't be any of them in core, just in theme and theme can decide what to notify about and how.
To sum up - leave core-specific translations in core and not let to modify them, the rest of it is the theme and can be modified and changed.
Let's not forget about modules - how do you see it? Maybe module could have their own translation files already compiled?


RGAN and RCGAN implementation

I implemented RGAN and RCGAN from [1]. Would it make sense to add it to torchgan.models?
[1] Esteban, Cristóbal, Stephanie L. Hyland, and Gunnar Rätsch. "Real-valued (medical) time series generation with recurrent conditional gans." arXiv preprint arXiv:1706.02633 (2017).

@dsevero It seems like an interesting model to have. Go ahead an open a PR for that.

Yes seems a valid thing to do. Ideally, I would like to have a common abstraction of trainer for more variants of GAN but it is not a very simple task. For the time being, we should have a SequenceTrainer.
(I also have thoughts of deprecating the Trainer in this release for an ImageTrainer and completely removing it in a later release)


Liveness feature Anti-Spoofing

Is possible to add a model or something related to detect if the face in image is real or fake?
Check if the person is pointing a video or a photo in the image

not out-of-the-box, but for real-vs-fake, it wouldn't be difficult
relatively decent dataset is published on https://www.kaggle.com/ciplab/real-and-fake-face-detection
and models to differentiate between the two are simple enough to write model and train it quickly
i might take a look at that, but given my other current plans, probably not before august
i'll leave this open as enhancement request

I just created a quick model and tested it, it gives >97% accuracy for real-or-fake
expected input is face in 128x128 resolution, so best to parse input image using some face detection model
(e.g. blazeface as it's used in human - and human library does have config param to return processed face tensor which can be directly used by some other model such as this one)
but i don't think i'll include this in human - i just don't see the use case for it in the library itself
feel free to use the model and incorporate it as needed
link is https://github.com/vladmandic/anti-spoofing
model is already converted and quanitized and with test app in js, so it should be simple to re-use it


Correctly detect events to build package

Change-type: patch
Signed-off-by: 20k-ultra<EMAIL_ADDRESS>

@balena-ci I self-certify!


Import pynput: Error

<IP_ADDRESS>
Python: 3.8.7 (tags/v3.8.7:6503f05, Dec 21 2020, 17:59:51) [MSC v.1928 64 bit (AMD64)]
Executable: C:\Users\andre\AppData\Local\Programs\Python\Python38\python.exe
OS: Windows
Arch: x86_64

Test.py
import pynput
print("Hello!")

Input nuitka:
python -m nuitka --mingw64 --standalone "E:\Test\Test\Test.py"
Output .exe:
Traceback (most recent call last):
  File "C:\Users\andre\TEST~1.DIS\Test.py", line 1, in <module>
  File "C:\Users\andre\TEST~1.DIS\pynput\__init__.py", line 40, in <module pynput>
  File "C:\Users\andre\TEST~1.DIS\pynput\keyboard\__init__.py", line 31, in <module pynput.keyboard>
  File "C:\Users\andre\TEST~1.DIS\pynput\_util\__init__.py", line 76, in backend
ImportError

This is on factory which is currently not a in a good shape, but once it stablizes it will appear in a release.

This is on factory which is currently not a in a good shape, but once it stablizes it will appear in a release.

Thanks, it works : )

Thanks, it works : )

Oops)

Oops)

Released as 0.6.11 just now.

Released as 0.6.11 just now.


when the start button is depressed, the text appears duplicated

The text appears as both depressed and not depressed

That's how 98.css works, the depressed text is actually the shadow of the original text that becomes hidden when pressed. This is now completely overridden by my w2k.css


Fix 639

Related to  https://github.com/cBournhonesque/lightyear/issues/639
The problem is that we used to only do entity mapping from the Sender -> Receiver, i.e. the entity map was only present on the receiver. With authority transfer we updated entity mapping, and it can be done both on the sending side or on the receiving side.
Some of our existing logic on the receiver (for example: https://github.com/cBournhonesque/lightyear/blob/1e1cbfadc6fcdcfca61a7b6cf091e24ceaf4a0ba/lightyear/src/shared/replication/receive.rs#L196) still work under the expectation that the entity map only exists on the receiver. (and that every local entity is present in the entity map. This is not the case anymore, which is why this function fails (https://github.com/cBournhonesque/lightyear/blob/1e1cbfadc6fcdcfca61a7b6cf091e24ceaf4a0ba/lightyear/src/client/interpolation/spawn.rs#L39).
https://github.com/cBournhonesque/lightyear/blob/1e1cbfadc6fcdcfca61a7b6cf091e24ceaf4a0ba/lightyear/src/shared/replication/receive.rs#L177
Potential solutions:

include the received tick in Replicated so that ALL entities have it (not just the ones with prediction/interp). Could work but maybe inefficient?
In general using the ChannelReceiver to get the confirmed tick seems very 'flimsy'. Maybe use something else?
Fix the code paths that still expect all entities to be present in the entity map

This PR currently has a unit test but no fix

I'm merging this because it provides some useful changes:

change some data that depends on remote_entities to instead depend on local_entities -> this is important because in some cases we might not know about the remote entities.

I tried to implement a change where when you change replication from c1 to s or c2, then we potentially send a ShouldBeInterpolated or ShouldBePredicted to c1. Unfortunately it doesn't work because c1 doesn't accept it since it hasn't received yet the message that it doesn't have authority anymore.. In general this was a bit of a hack, so i'll keep thinking of better ways to handle Prediction/Interpolation.

@philpax in the meantime, is it possible for you to always start spawning entities on the server, instead of on clients? That would make things simpler, and I suspect that interpolation/prediction won't panic

I haven't been able to work on the project that I originally needed this for, so I can't test this change exactly.
However, I've been working on another project using Lightyear, also using client replication, and I've had to revert this change on my local branch because I'm being spammed with log errors that look like this:
2024-10-02T21:53:19.660639Z ERROR lightyear::shared::replication::receive: updating confirmed tick for entity remote_tick=Tick(8305) local_entity=Entity { index: 112, generation: 1 }
2024-10-02T21:53:19.677335Z ERROR lightyear::shared::replication::receive: updating confirmed tick for entity remote_tick=Tick(8307) local_entity=Entity { index: 112, generation: 1 }
2024-10-02T21:53:19.760975Z ERROR lightyear::shared::replication::receive: updating confirmed tick for entity remote_tick=Tick(8315) local_entity=Entity { index: 112, generation: 1 }
2024-10-02T21:53:19.777760Z ERROR lightyear::shared::replication::receive: updating confirmed tick for entity remote_tick=Tick(8317) local_entity=Entity { index: 112, generation: 1 }

No interpolation or prediction, just replicating a single entity from the client. The errors occur on both the server and receiving clients.

@philpax in the meantime, is it possible for you to always start spawning entities on the server, instead of on clients? That would make things simpler, and I suspect that interpolation/prediction won't panic

This is a bit difficult for the project that this was originally for, but not impossible. For now, I'm content operating without interaction/prediction, but I'll revisit that at a later stage.

Ah sorry about that; I just removed the extra logs (in main)


Unit for the calculator's water quantity

Hello
I think that milliliters would be preferable units for the water quantity display. It's a bit unconventional to display the water quantity as grams - thus it would be more practical to show them as ml.
I could do a pull request for this if this sounds reasonable :-)

Me personally I rather have the grams. That way it matches with the scale :).

Agree with @hendricius even if at the end it's all the same thing.


For a 3.0.0 release

#24

Codecov Report

Merging #26 (071acd6) into master (bbec046) will decrease coverage by 3.92%.
The diff coverage is 96.55%.

:exclamation: Current head 071acd6 differs from pull request most recent head b372d62. Consider uploading reports for the commit b372d62 to get more accurate results

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   97.67%   93.75%   -3.93%
==========================================
  Files           2        2
  Lines          43       32      -11
==========================================
- Hits           42       30      -12
- Misses          1        2       +1

Impacted Files
Coverage Δ

src/ScientificTypesBase.jl
66.66% <ø> (-28.08%)
:arrow_down:

src/scitype.jl
96.55% <96.55%> (-3.45%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbec046...b372d62. Read the comment docs.


fixed import sort order on api_client.py using isort

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #
Checklist:

[ ] Docs included if any changes are user facing

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 35.431%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
4380

Relevant Lines:
12362

💛  - Coveralls


Relative paths instead of absolute paths

Is there a reasoning to use absolute paths on the event bindings instead of relative paths? It makes it so if you generate a project and move the folder it will stop working

I think I fixed a ton of these are you still seeing them in the CSV parts? Can you point out the places you see this and will take a look


Create release notes for v3.11.0

What
Write the release notes for GOV.UK Frontend v3.11.0
Why
To help users understand what changes have been made in the 3.11.0 release.
Who needs to be involved
Tech Writer and whoever is doing the release.
Done when

[x] release notes have been drafted
[ ] release notes have been reviewed by a developer
[ ] have been 2i'ed by Tech Writer community

I've drafted some release notes in a Google Doc.
They need a couple of links:

guidance page for cookie banner
GitHub issue re creating cookie banner (if there is an issue for this, like there was for notification banner)

Content has passed 2i. I'll raise a PR now.


typo in setCient method

Looks like setCient is supposed to be named setClient.

Ugh, how has no one noticed this after over a year  :-/
Thanks.

Pushed a fix, Travis is being wonky, not building. As soon as it recovers, should be released as v0.4.2

v0.4.2 released

Maintainer is a busy beaver ^^ thanks, nice!


Radio and checkboxes do not work

This was a Bootstrap issue which is now checked in.  Hoping it makes it into the gem
See: https://github.com/twitter/bootstrap/issues/2023 and https://github.com/twitter/bootstrap/commit/3d58b4622671bc51c22c857641db3b988e73632a

This will get fixed in 2.0.2.


Feedback

Sorry if this is not the best way to provide feedback.
I've just installed this and its fantastic!
Works perfectly and fast and is extremely useful.
Thank you!

Same here! Thank you soooo much! ❤

Thank you too @mflilian!


Error: maximum recursion depth exceeded in comparison

This error is shown in a panel every time a file without a source (e.g. opened from a zip) is opened or in the focused view.
The console shows a flood of the following error:
During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\Administrator\AppData\Roaming\Sublime Text 3\Packages\GitSavvy\core\git_command.py", line 96, in git
    cwd=working_dir or self.repo_path,
  File "C:\Users\Administrator\AppData\Roaming\Sublime Text 3\Packages\GitSavvy\core\git_command.py", line 148, in repo_path
    return self._repo_path()
  File "C:\Users\Administrator\AppData\Roaming\Sublime Text 3\Packages\GitSavvy\core\git_command.py", line 173, in _repo_path
    throw_on_stderr=throw_on_stderr
  File "C:\Users\Administrator\AppData\Roaming\Sublime Text 3\Packages\GitSavvy\core\git_command.py", line 103, in git
    raise_error(e)
  File "C:\Users\Administrator\AppData\Roaming\Sublime Text 3\Packages\GitSavvy\core\git_command.py", line 84, in raise_error
    raise GitSavvyError(msg)
GitSavvy.core.git_command.GitSavvyError: maximum recursion depth exceeded in comparison

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\Administrator\AppData\Roaming\Sublime Text 3\Packages\GitSavvy\core\commands\status_bar.py", line 34, in run_async
    if not self.file_path or not self._repo_path(throw_on_stderr=False):
  File "C:\Users\Administrator\AppData\Roaming\Sublime Text 3\Packages\GitSavvy\core\git_command.py", line 173, in _repo_path
    throw_on_stderr=throw_on_stderr
  File "C:\Users\Administrator\AppData\Roaming\Sublime Text 3\Packages\GitSavvy\core\git_command.py", line 103, in git
    raise_error(e)
  File "C:\Users\Administrator\AppData\Roaming\Sublime Text 3\Packages\GitSavvy\core\git_command.py", line 84, in raise_error
    raise GitSavvyError(msg)
GitSavvy.core.git_command.GitSavvyError: maximum recursion depth exceeded in comparison

I could look at this is anyone knew how to easily reproduce on Mac platform.

I encountered this on Windows, no idea if it's reproduceable on other systems.

Yeah, no idea.  I just opened up a single file outside of git and I saw no issues here.

@p3lim - this should be fixed in master.  Please let me know if this is still an issue for you.

Yup, that solved it.


Fixed #30229 -- Removed closure compiler polyfill from inlines.min.js

Due to the use of .find() in this code, the Closure Compiler is adding a polyfill. However, find() is only being called on jQuery objects, so this is unnecessary. As we don't require any polyfills, I've simply
disabled this feature.
I've regenerated all the compressed files with the latest version of the Closure Compiler, but inlines.min.js is the only one with any changes.

Can you explain more about rewrite_polyfills=false? Is there a chance we'd need to remove that option in the future?

The parameter's badly-named, but it controls whether polyfills are added to the code when the compiler detects that ES6+ features are being used.
In this case, it thinks Array.prototype.find is being used, which is an ES2015 feature, and isn't available in all browsers. The polyfill code will add an implementation for browsers which don't have a native implementation.
Django's inlines.js only uses jQuery's .find() method, so this polyfill is unnecessary.
It's possible that in future we'd want to rewrite Django's JavaScript code using more modern syntax, which might require the use of polyfills. However, I in that case I think it would be preferable to add those libraries explicitly, rather than have them added during minification.


Move to modern .NET 7

Currently we use .NET Framework with Windows Forms which is very ancient, but more importantly locked into Windows.
Moving to cross-platform .NET 7 (likely with Avalonia UI) would be the first step towards Linux and/or macOS support.

bump this, pls i need native linux support

Just a heads up, my PR is only doing the bare minimum, which is to move to .NET 9 and get it to build. Linux support will require much more than that.

Yes, UI rewrite (Avalonia or whatever) and xplat support is way outside the scope of this


Update dcw to 1.1.4

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Missing the Expected "id" Prefix AndroidManifest

Check out https://github.com/ParsePlatform/parse-server/issues/1271 for an ideal bug report. The closer your issue report is to that one, the more likely we are to be able to help, and the more likely we will be to fix the issue quickly!
Many members of the community use Stack Overflow and Server Fault to ask questions. Read through the existing questions or ask your own!

Stack Overflow: http://stackoverflow.com/questions/tagged/parse.com
Server Fault: https://serverfault.com/tags/parse

For database migration help, please file a bug report at https://parse.com/help#report
Make sure these boxes are checked before submitting your issue -- thanks for reporting issues back to Parse Server!

[x] You've met the prerequisites: https://github.com/ParsePlatform/parse-server/wiki/Parse-Server-Guide#prerequisites.

[x] You're running the latest version of Parse Server: https://github.com/ParsePlatform/parse-server/releases

[x] You've searched through existing issues: https://github.com/ParsePlatform/Parse-Server/issues?utf8=✓&q=is%3Aissue Chances are that your issue has been reported or resolved before.

Environment Setup

Server: parse-server version 2.2.10, localhost
Database: v3.2.6, Mongo, localhost

Issue
I'm working with Parse server and Push Notifications for my Android app. Once I build the project I got this error from my Application Output:
[parse.GcmRegistrar] Found com.parse.push.gcm_sender_id <meta-data> element with value "id:938279605436", but the value is missing the expected "id:" prefix
But I got this too:
[parse.GcmRegistrar] GCM registration successful. Registration Id: APA91bEWWK6CGwrUhWqdRmAJOBrpfCv872IOS6-H3ZNInGL7QTzMaG0ni1Ts2OqgK-ktCq6wqMg5N9gf1VIIDuH11lR6JmRymuFdc3ARHGwn0XAb7-xo1eHu29UQUt32HTInuwyb1ZTA
This is my AndroidManifest.xml:

Logs/Trace

You can turn on additional logging by configuring VERBOSE=1 in your environment.

This is what I got from VERBOSE when I try to send a Notification
verbose: sending push to 1 installations
verb parse-server-push-adapter GCM sending to 1 device
verb parse-server-push-adapter GCM GCM Response: {
verb parse-server-push-adapter GCM     "multicast_id":<PHONE_NUMBER>491144000,
verb parse-server-push-adapter GCM     "success": 0,
verb parse-server-push-adapter GCM     "failure": 1,
verb parse-server-push-adapter GCM     "canonical_ids": 0,
verb parse-server-push-adapter GCM     "results": [
verb parse-server-push-adapter GCM         {
verb parse-server-push-adapter GCM             "error": "MismatchSenderId"
verb parse-server-push-adapter GCM         }
verb parse-server-push-adapter GCM     ]
verb parse-server-push-adapter GCM }

please open on https://github.com/parse-server-push-adapter/issues/new


[Bug]: System.InvalidOperationException: A type named 'StartupProduction' or 'Startup' could not be found in assembly

Describe the bug
Have been following https://github.com/domaindrivendev/Swashbuckle.AspNetCore/issues/2168 and have tried all the described solutions there, running locally this works fine, running in PR checks it works fine, but then when running a deploy this breaks.
I'm on .net8 using swashbuckle 6.5.0 (Have tried with original version 6.2.3 and newest 6.8.0 too) it seemed to happen somewhat intermittently in the past but retrying the workflow would eventually get it through however now it's failing continuously.
`dotnet-tools.json`

{
  "version": 1,
  "isRoot": true,
  "tools": {
    "swashbuckle.aspnetcore.cli": {
      "version": "6.5.0",
      "commands": [
        "swagger"
      ]
    }
  }
}

csproj

<Project Sdk="Microsoft.NET.Sdk.Web">

    <PropertyGroup>
        <TargetFramework>net8.0</TargetFramework>
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
    </PropertyGroup>

    <ItemGroup>
        <PackageReference Include="DWL.Lib.Auth" Version="8.0.0-beta-10902437656" />
        <PackageReference Include="Mapster" Version="7.3.0" />
        <PackageReference Include="Mapster.DependencyInjection" Version="1.0.0" />
        <PackageReference Include="Serilog" Version="3.0.0-dev-02028" />
        <PackageReference Include="Serilog.Enrichers.CorrelationId" Version="3.0.1" />
        <PackageReference Include="Serilog.Extensions.Hosting" Version="7.0.0" />
        <PackageReference Include="Serilog.Sinks.Console" Version="4.1.0" />
        <PackageReference Include="Swashbuckle.AspNetCore" Version="6.5.0" />
        <PackageReference Include="Swashbuckle.AspNetCore.Annotations" Version="6.5.0" />
    </ItemGroup>

    <ItemGroup>
      <ProjectReference Include="..\Speechy.Service\Speechy.Service.csproj" />
    </ItemGroup>

    <ItemGroup>
      <Content Include=".config\dotnet-tools.json" />
    </ItemGroup>

    <Target Name="PostBuild" AfterTargets="PostBuildEvent">
        <Exec Command="dotnet tool restore" />
        <Exec Command="dotnet swagger tofile --output api.json $(OutputPath)\$(AssemblyName).dll v1" />
    </Target>

</Project>

Action build step

    - name: 🔨 Build
      run: dotnet build --no-restore -c Release
      env:
        API_IMPORT_DLL: 'Speechy/Speechy/Speechy.WebApi/bin/Release/net8.0/Speechy.WebApi.dll'
        SWASHBUCKLE_ASPNET_CORE_CLI_PACKAGE_VERSION: 6.5.0
        API_IMPORT_VERSION: v1
        CONFIGURATION: Release

Only difference between the PR check that works building the project and generating swagger json that I can discern is one is production, other is not but building in production locally works fine.
Expected behavior
Get a swagger openapi json spec
Actual behavior
Exception thrown
Steps to reproduce
No response
Exception(s) (if any)
Unhandled exception. System.InvalidOperationException: A type named 'StartupProduction' or 'Startup' could not be found in assembly 'Speechy.WebApi'.
     at Microsoft.AspNetCore.Hosting.StartupLoader.FindStartupType(String startupAssemblyName, String environmentName)
     at Microsoft.AspNetCore.Hosting.WebHostBuilder.ScanAssemblyAndRegisterStartup(ServiceCollection services, String startupAssemblyName)
  --- End of stack trace from previous location ---
     at Microsoft.AspNetCore.Hosting.WebHostBuilder.<>c__DisplayClass15_1.<ScanAssemblyAndRegisterStartup>b__1(IServiceProvider _)
     at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
     at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite callSite, RuntimeResolverContext context)
     at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
     at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)
     at Microsoft.Extensions.DependencyInjection.ServiceProvider.CreateServiceAccessor(ServiceIdentifier serviceIdentifier)
     at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
     at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(ServiceIdentifier serviceIdentifier, ServiceProviderEngineScope serviceProviderEngineScope)
     at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType)
     at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetService[T](IServiceProvider provider)
     at Microsoft.AspNetCore.Hosting.WebHost.EnsureStartup()
     at Microsoft.AspNetCore.Hosting.WebHost.EnsureApplicationServices()
     at Microsoft.AspNetCore.Hosting.WebHost.Initialize()
     at Microsoft.AspNetCore.Hosting.WebHostBuilder.Build()
     at Swashbuckle.AspNetCore.Cli.Program.GetServiceProvider(Assembly startupAssembly) in C:\projects\ahoy\src\Swashbuckle.AspNetCore.Cli\Program.cs:line 145
     at Swashbuckle.AspNetCore.Cli.Program.<>c.<Main>b__0_4(IDictionary`2 namedArgs) in C:\projects\ahoy\src\Swashbuckle.AspNetCore.Cli\Program.cs:line 82
     at Swashbuckle.AspNetCore.Cli.CommandRunner.Run(IEnumerable`1 args) in C:\projects\ahoy\src\Swashbuckle.AspNetCore.Cli\CommandRunner.cs:line 68
     at Swashbuckle.AspNetCore.Cli.CommandRunner.Run(IEnumerable`1 args) in C:\projects\ahoy\src\Swashbuckle.AspNetCore.Cli\CommandRunner.cs:line 59
     at Swashbuckle.AspNetCore.Cli.Program.Main(String[] args) in C:\projects\ahoy\src\Swashbuckle.AspNetCore.Cli\Program.cs:line 121
/home/runner/work/Speechy/Speechy/Speechy.WebApi/Speechy.WebApi.csproj(59,9): error MSB[30](https://github.com/dwlgit/Speechy/actions/runs/11048775286/job/30692886141#step:6:31)73: The command "dotnet swagger tofile --output api.json bin/Release/net8.0//Speechy.WebApi.dll v1" exited with code 134.

Swashbuckle.AspNetCore version
6.2.3, 6.4.0, 6.5.0, 6.8.0
.NET Version
.net8.0
Anything else?
Have been looking at all the following
https://github.com/domaindrivendev/Swashbuckle.AspNetCore/issues/2168
Tried having a blank appsettings.Production.json file but still threw same error along with the different suggested versions
Have followed
https://stackoverflow.com/questions/78406014/system-invalidoperationexception-a-type-named-startupproduction-or-startup
Trying the suggest env vars for the step, but inclusion of them didnt seem to work and confirmed the file path is correct (Worth noting I only tried adding these after it started failing as didnt need them before that point)
Please let me know if there's anything else I can provide

@martincostello Here's your new issue 👍

Please provide a minimal reproducible example as a GitHub repository that demonstrates the issue you're experiencing so we can look into this further.
Support for Minimal APIs has been working in general for others, so I feel that this issue is something specific to how your project is set up (given how the exception isn't coming from our code).
We need something we can actually debug to look into to get towards any kind of resolution.
As a starting point, using the latest version will be a step forward you'll need as versions since 6.7.0 target net8.0 and also contain other bug fixes related to the CLI.

Support for Minimal APIs has been working in general for others, so I feel that this issue is something specific to how your project is set up (given how the exception isn't coming from our code).

Yeah this project doesn't use the minimal hosting - I'll try to find some time to replicate the issue but given it's intermittent it might be a struggle as the last instance I setup worked with no differences I could discern

I have no Minimal API in my project.
But I've got the same issue
Swashbuckle.AspNetCore version - 6.8.1
.NET Version - .net8.0

Same here:
.Net version: 8.0.404
Swashbuckle.AspNetCore version: 7.0.0 or 6.9.0
The weird is that it was working fine with the 6.9.0. As soon I upgraded to 7.0.0 it stop to work. Now, even when I downgrade the version, the error persists.

Likely reason is related to dependencies in the build output causing resolution issues. Try cleaning your build output.

Quick reviewing the code on Github, the error is here https://github.com/domaindrivendev/Swashbuckle.AspNetCore/blob/master/src/Swashbuckle.AspNetCore.Cli/Program.cs#L183-L186 for the version 7.0.0 following my stack trace
   at Microsoft.AspNetCore.Hosting.StartupLoader.FindStartupType(String startupAssemblyName, String environmentName)
   at Microsoft.AspNetCore.Hosting.WebHostBuilder.ScanAssemblyAndRegisterStartup(ServiceCollection services, String startupAssemblyName)
--- End of stack trace from previous location ---
   at Microsoft.AspNetCore.Hosting.WebHostBuilder.<>c__DisplayClass15_1.<ScanAssemblyAndRegisterStartup>b__1(IServiceProvider _)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite callSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.CreateServiceAccessor(ServiceIdentifier serviceIdentifier)
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(ServiceIdentifier serviceIdentifier, ServiceProviderEngineScope serviceProviderEngineScope)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType)
   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetService[T](IServiceProvider provider)
   at Microsoft.AspNetCore.Hosting.WebHost.EnsureStartup()
   at Microsoft.AspNetCore.Hosting.WebHost.EnsureApplicationServices()
   at Microsoft.AspNetCore.Hosting.WebHost.Initialize()
   at Microsoft.AspNetCore.Hosting.WebHostBuilder.Build()
   at Swashbuckle.AspNetCore.Cli.Program.GetServiceProvider(Assembly startupAssembly) in /_/src/Swashbuckle.AspNetCore.Cli/Program.cs:line 183
   at Swashbuckle.AspNetCore.Cli.Program.<>c.<Main>b__0_4(IDictionary`2 namedArgs) in /_/src/Swashbuckle.AspNetCore.Cli/Program.cs:line 88
   at Swashbuckle.AspNetCore.Cli.CommandRunner.Run(IEnumerable`1 args) in /_/src/Swashbuckle.AspNetCore.Cli/CommandRunner.cs:line 68
   at Swashbuckle.AspNetCore.Cli.CommandRunner.Run(IEnumerable`1 args) in /_/src/Swashbuckle.AspNetCore.Cli/CommandRunner.cs:line 59
   at Swashbuckle.AspNetCore.Cli.Program.Main(String[] args) in /_/src/Swashbuckle.AspNetCore.Cli/Program.cs:line 159
3````

Navigating a bit on the error, it seems it the block of error as the cli does inflection and cant find the right method to access the assembly.

https://github.com/domaindrivendev/Swashbuckle.AspNetCore/commit/beaf75cc64cc79f6e8c08f9a3ac977f0e1e705c9#diff-d76594f077d2b9007e19e6ca6d48332393da4eda1d8571560b78ec6c72da7a2bR83


error happened when  "python -m caffe2.python.operator_test.relu_op_test"

raceback (most recent call last):
File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
"main", fname, loader, pkg_name)
File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/home/zxy/caffe2/build/caffe2/python/operator_test/relu_op_test.py", line 22, in
from hypothesis import given
File "/usr/local/lib/python2.7/dist-packages/hypothesis/init.py", line 31, in
from hypothesis.core import given, find, example, seed
File "/usr/local/lib/python2.7/dist-packages/hypothesis/core.py", line 35, in
import hypothesis.strategies as st
File "/usr/local/lib/python2.7/dist-packages/hypothesis/strategies.py", line 33, in
from hypothesis.internal.cache import LRUReusedCache
File "/usr/local/lib/python2.7/dist-packages/hypothesis/internal/cache.py", line 23, in
@attr.s(slots=True)
TypeError: attributes() got an unexpected keyword argument 'slots'

I suggest downgrading hypothesis to 3.35.0, fixed this issue for me.
run
pip uninstall hypothesis
pip install -Iv hypothesis==3.35.0

Your suggest  don't work for me, Thanks anyway

I also have the same problem, Can you tell me how to deal with it?
Thanks


Useless use

When installing this module:
===> Testing: OO::Monitors:ver<1.1>
WARNINGS for /home/travis/.zef/store/oo-monitors.git/b9de07c277f0a9fa805bb18113788228f6acfd3b/t/condition.t:
Useless use of constant value not-empty in sink context (lines 15, 20)
Useless use of constant value not-full in sink context (lines 12, 22)

That'd be a Rakudo bug. The values in question are arguments to a macro, and the argument is used.

This issue can probably closed, I golfed it down to something that doesn't involve this module at all:
use experimental :macros; macro z($) { quasi {} }; z $;

Verified that, with the Rakudo warning bug fixed, the warning in this module is also gone.


fix: Websocket not updating state connection

Description
Hi, didn't know how to classify this, maybe is a bug, maybe a question or maybe a documentation problem.
I have an app that needs a behavior like Whatsapp or any messenger app, that when you open the app it should always update the screen if there is new data.  So when using this websocket all is good while I am on the app. But when I go to another app or block the device for a long time, websocket of course loose connection maybe because of how Android or iOS handles background calls. So there are some times that websocket is not able to reconnect, I mean is not even noticing it (using the listener for state connection). Idk if this is a expected behavior when you leave the app? How I can handle this? I am helping me with WidgetsBindingObserver, but as I don't know if the websocket looses connection I don't have a way to know if a call to remote data source is needed. Another question that I couldn't find is the amount of time that strategies tries to reconnect, is infinite? I am using the default one.
This is happening only on a physical device, I am not able to reproduce it on emulator. No matter if I lock the device for hours, websocket state connection works great. But there is a second problem related:  disabling wifi and enabling, happens in both, physical and emulator devices, the listener is not fired.
Expected Behavior
listener should always communicate the state of the connection? How to handle when you go out of the app, and come back, listener should reconnect?
If you disable internet connection like Wifi, and re enable it, webscoket should reconnect? Or at least communicate it on the listener?

Hi @martinpelli 👋
Thanks for opening an issue!
This is expected as the operating system will kill apps in the background after they have been paused for a while. You likely need to support silent notifications in addition to a socket connection in order to achieve the behavior you described.
Hope that helps! Closing for now but if you have any follow up questions let me know and I'm happy to continue the conversation 👍

The second issue in the original post was not addressed: "But there is a second problem related: disabling wifi and enabling, happens in both, physical and emulator devices, the listener is not fired.". I have experienced this as well, the listener does not fire when there's no internet (and neither upon reconnecting).


Hidden / show page feature

Hi! I have a new idea - I thinking what should have a page extension -> hide/show system.
Sometimes I must hide(deactive) one page without delete it so as to be invisible to the public (and vice versa).
This is not bad, and relatively simply to implementation.
But this is only my suggestion.
Sry for bad my english.

draft feature do exactly same thing, admins also can see draft Preview.


Fixed links to point to website docs.

This change is

/assign @texasmichelle

sweet..
/lgtm
/approve


Updating to use the new phone home classes

Coverage increased (+0.1%) to 10.961% when pulling 8482d48111326a071d9747ad8578c81c311700d9 on phone_home_changes into f8f470b8b02b76c21f817350c0d0c2eceaeff844 on master.

It doesn't look like we ever shutdown the ExecutorService in the phone-home-client.


previous_selections_value format

When building the prompt for the researcher_agent, the previous_selections_value is being passed to create the prompt in format below.

The agent isn’t parsing the HumanMessage content properly. I’m not certain, but perhaps because this is a list of multiple elements the check_for_content() function isn’t parsing the content from the previous_selections_value properly.

I have had so many issues trying to get my Openai api key to work.  I feel like I have tried everything.   double checked key, made a new key, exported in env, double checked env variables in the config file, made sure it is in the right folder, made sure the instructions to it are right.   I'm sure this is because of my inexperience as a developer, but any ideas would be useful.

@tradingartofwar your comment is irrelevant to this issue. If you need assistance, you can reach out to the community, but please refrain from adding irrelevant comments to this issue.

I have had so many issues trying to get my Openai api key to work. I feel like I have tried everything. double checked key, made a new key, exported in env, double checked env variables in the config file, made sure it is in the right folder, made sure the instructions to it are right. I'm sure this is because of my inexperience as a developer, but any ideas would be useful.


Added devicePixelRatio to FixedScrollMetrics

Related to #8
Adding that property solved the issue for me

Duplicate #6

Duplicate #6

Duplicate #6


Work around Blizzard returning duplicate RealID toons

For some reason the BN* APIs are returning some players as being logged
into the same toon 3 times simultaneously. We can detect this by using
the bnetIDGameAccount value so we only show the first entry for any
given game account.

Hi solocommand. This is actually eridius, who used to be an active maintainer of the project. I took a long hiatus from WoW, but I'm finally playing again. I'm glad to see you moved the repo to GitHub! If you could grant me push access to the repo that would be great.

Hey eridius, sorry I didn't see this earlier. Push granted!


Refactor DefaultSolver

Some refactoring/polishing inside the solver component, mostly DefaultSolver. Changes are intended to support subclassing of DefaultSolver for optimization tasks/weak constraints.

@lorenzleutgeb and/or @madmike200590 please have another look.


Update tests / pending test against ADP-1738

58dbe4a7a7132668e9193f188177ed5b1bf98a7b
Adjust e2e tests after API changes from #3249

71969cb5c9de1cad0a49a6c96025b79768b2f910
Pending integration tests against ADP-1738

Comments
Pending integration test TRANS_NEW_CREATE_MINT_SCRIPTS for ADP-1738

Issue Number
ADP-1738, ADP-1193

bors r+

bors merge

bors r+


Add the ability to use pkg_config instead of vcpkg when building with mingw64  on Windows

Hi @alexcrichton, and many thks for your work 😀.
I am having the same need as @ian-p-cooke had 4 years ago 👉 https://github.com/alexcrichton/curl-rust/issues/221.
I decided to use mingw64 to build curl-4.dll on Windows instead of vcpkg. It works as expected following these steps:

installing msys2
installing base-devel and mingw-w64-x86_64-toolchain
building curl 7.87 schannel from source for mingw64

Then I build my rust app with crate-sys dependency with these prerequisites:

adding mingw64/bin dir to path
rust toolchain stable-gnu

I expected curl-sys to link my mingw64/curl-4.dll, but it does not permit the use of mingw64's pkg_config. Instead, the crate uses embedded curl 7.86-DEV as mentioned in documentation.
So, to achieve my goal, I had to update curl-sys/build.rs line 38 like this:
if windows {
  if try_vcpkg() {
    return;
    } else if try_pkg_config() {
        return;
      }
  } else if try_pkg_config() {
    return;
  }
}

With this update, curl-sys correctly links my rust app with my fresh mingw64/curl-4.dll.
Now that compiling curl with mingw64 is working easily, I think that we could allow curl-sys to use pkg_config instead of vcpkg according to the dev's choice.

I would also like to be able to use pkg-config on other platforms such as Linux to use the system libcurl, which I have built with aws-lc. This would also allow using curl with HTTP/3 support.


Invalid generator for VS2019 x64

In CMakeSettings.json, Visual Studio still uses the old style of specifying the generator architecture "Visual Studio 16 2019 Win64", while CMake does not support this style anymore and instead requests using "Visual Studio 16 2019" and additionally the parameter "-A Win64".
The task runcmake seems to use the exact generator as written in the CMakeSettings.json, but it should detect VS2019 and higher and extract the architecture from the generator field. Otherwise the build on azure breaks with the error message:
Processing configuration: 'x64-Release'.
  | :\Program Files\CMake\bin\cmake.exe" -G "Visual Studio 16 2019 Win64" -DCMAKE_BUILD_TYPE=RelWithDebInfo  d:\a\1\s |
  | CMake Error: Could not create named generator Visual Studio 16 2019 Win64 |
  |   |
  | Generators |
  | * Visual Studio 16 2019         = Generates Visual Studio 2019 project files. |
  |                                   Use -A option to specify architecture.

@Helco thanks for the reported bugs, I released the fixed tasks, let me know!

@lukka both this fix and the one for #8 seem to work just fine, now it's only me blocking the build :)
Many thanks for the quick fixes!


Cannot set property _isFinished of # which has only a getter

I got Cannot set property _isFinished of #<Object> which has only a getter
in https://github.com/web-animations/web-animations-js/blob/master/src/animation.js#L194
seems _isFinished is only a getter but cancel() trying to set value.

We'll need more information if we are to reproduce this.
For example, which browser version are you using?

It might help, but if you look at the code it seems pretty obviously broken.

yes it's obviously broken, not browser related, any browser without native Web Animation API could reproduce it

@ewilligers this should  repro with 'use strict'; enabled. It's probably safe to remove the line setting _isFinished, since it's a no-op otherwise.


Events API w/ Async CQ fix for out-of-order event id (and Event/AsyncCQ tests)

This is dependent on async cq changes in #5808 being merged.
Recap on some offline discussions yesterday between @tooniz / @tt-asaigal and myself.

During initial Events commita week ago at 380bb3c5b,  I had previously put the get_next_event() call (that increments, returns next event id) outside of async worker thread for EnqueueRecordEvent(cq, Event) because I wanted the returned Event struct to caller to be populated and available for use right away in EnqueueWaitForEvent(cq, Event) or EventSynchronize(Event) (host-side sync on event) and not at some unknown time later.  Turns out this was a bad idea to have this event increment event id in main thread, but all other cmds increment it in child thread, when async CQ are enabled... I was getting race conditions (asserts about not-incrementing event id) and seeing the event id returned from EnqueueRecordEvent() higher than anticipated (out of order) because earlier commands still in async CQ didn't get serviced yet.  Example:

EnqueueRecordEvent() // event_id=0 good picked by main thread
EnqueueRecordEvent() // event_id=1 good picked by main thread
EnqueueWaitForEvent() // delayed, pushed to child thread, event_id incremented ~whenever it gets to it. Can happen late, event_id=3, not good.
EnqueueRecordEvent() // event_id=2 whoops, not good - picked by main thread.

Then realized that event id selection must all be on the same thread for a CQ for this to work.
The Fix
Solutions considered:

Lift all Enqueue_* cmds calling of this->manager.get_next_event(this->id); out of child thread and into parent thread.  Seems not possible/easy for EnqueueWriteBuffer() and EnqueueReadBuffer because they generate different number of device cmds and event ids based on state of issue queue and completion queue respectively, and keep issuing smaller cmds based on that state
Move EnqueueRecordEvent() calling of this->manager.get_next_event(this->id); back into child thread like other cmds so that all event id generation is ordered.   This means that Event struct would not be populated in any guaranteed time to caller/main thread. That's kind of okay.  Just need to "wait" until the Event is populated by child thread before using it (either by other CQ child thread, or by host), so introduced an event.wait_until_ready() which simply waits until the thread populated the event and set ready=true
Something else like pre-allocating pools of event ids with enough room on host side, and the child threads using them from the pool.  Don't love this idea, needs some more thougt,opened #5988 to pursue further.

Going with option 2 for now, since the implementation is easy, simple, and reasonable.
 void EnqueueWaitForEventImpl(CommandQueue& cq, std::shared_ptr<Event> event) {
+    event->wait_until_ready(); // Block until event populated. Worker thread.

The downside is that it adds a dependency between async CQ worker threads that technically wasn't there before (the same dependency was there on device execution side though, as in the WaitForEvent cmd waited for the RecordEvent cmd to finish executing on device), but we think it's a reasonable fix for broken functionality today (especially given Events not planned to be used cross-chip in short term) and to get Events w/ async CQ working.  Other ideas being pursued in ticket linked above.
Tests
Also updated current set of Events tt_metal unit tests to loop over CQ modes PASSTHROUGH and ASYNC for extra coverage, all but 2 tests passing today (pending on an upcoming fix from @tt-asaigal for multi-cq + async).
TT_METAL_NUM_HW_CQS=2 ./build/test/tt_metal/unit_tests_fast_dispatch_single_chip_multi_queue  --gtest_filter='MultiCommandQueueSingleDeviceFixture.TestEvents*' |& tee multi_cq_async_tests.log

There appears to be a lot of Async CQ changes as well, I am assuming because Aditya's changes have not yet landed in main yet. I will wait for that to be merged first and the PR rebased then review, is that ok?

There appears to be a lot of Async CQ changes as well, I am assuming because Aditya's changes have not yet landed in main yet. I will wait for that to be merged first and the PR rebased then review, is that ok?

Ah darn, it was fine when I opened it (I selected his branch as target to show just my changes), but looks like after recent force-push to asaigal branch, now his older changes will show up here.. didn't realize that would happen.  I am going to rebase now and change target to main, just to make this PR clean looking and back to tiny review list.


Ignored return collection specification during function validation

Regarding: version 1
Description: validate-fn-with ignores the return collection specification when it is not accompanied by a return scalar specification. This bug propagates to validate-fn-meta-spec and instrument.
Examples:
This is correct:
(validate-fn-with #(vector (inc %)) {:speculoos/ret-scalar-spec [int?]
                                     :speculoos/ret-collection-spec [map?]} 99)
;; ({:path [0], :value #function[clojure.core/map?--5477], :datum [100], :ordinal-parent-path [], :valid? false, :fn-spec-type :speculoos/return})

The return value satisfies its int? scalar specification, but the return value fails to satisfy its map? collection specification, and generates an invalidation report.
This is incorrect:
(validate-fn-with #(vector (inc %)) {:speculoos/ret-collection-spec [map?]} 99)
;; [100]

The return value fails to satisfy its map? collection specification, but instead of an invalidation report, validate-fn-with yields the tested function's return value [100].
Expected Result: validate-fn-with ought to validate with the return collection specification even when there does not exist a return scalar specification.
Solution: Find and fix the bug.

Bug fixed in version 2.
Individual function argument scalar validation:
(validate-fn-with #(vector (inc %)) {:speculoos/arg-scalar-spec [string?]} 99)
;; => [{:path [0], :datum 99, :predicate string?, :valid? false, :fn-spec-type :speculoos/argument}]

Individual function argument collection validation:
(validate-fn-with #(vector (inc %)) {:speculoos/arg-collection-spec [set?]} 99)
;; => [{:datum [99], :valid? false, :path-predicate [0], :predicate set?, :ordinal-path-datum [], :path-datum [], :fn-spec-type :speculoos/argument}]

Individual function return scalar validation:
(validate-fn-with #(vector (inc %)) {:speculoos/ret-scalar-spec [string?]} 99)
;; => [{:path [0], :datum 100, :predicate string?, :valid? false, :fn-spec-type :speculoos/return}]

The following was the original problem.
Individual function return collection validation:
(validate-fn-with #(vector (inc %)) {:speculoos/ret-collection-spec [set?]} 99)
;; => [{:datum [100], :valid? false, :path-predicate [0], :predicate set?, :ordinal-path-datum [], :path-datum [], :fn-spec-type :speculoos/return}]


lock_manager: pass Config when creates WaiterManager and Detector

Signed-off-by: youjiali1995<EMAIL_ADDRESS>
What have you changed? (mandatory)
Pass Config when creates WaiterManager and Detector to reduce parameters.
What are the type of the changes? (mandatory)

Engineering (engineering change which doesn't change any feature or fix any issue)

Does this PR affect documentation (docs) or release note? (mandatory)
No
Does this PR affect tidb-ansible update? (mandatory)
No

/test