Compile cycles can loop indefinitely

steps

publish sbt with latest zinc and latest sbt code
set ThisBuild / SettingKey[Boolean]("usePipelining") := false to a file local.sbt or modify build.sbt
build https://github.com/sbt/sbt/pull/5812 (using sbt -Dsbt.version=1.4.0-SNAPSHOT)
change Zinc version in project/Dependencies.scala to 1.4.0-SNAPSHOT
reload
compile

problem
main-settings project cycles indefinitely
[info]  published ivy to /Users/ethanatkins/.ivy2/local/org.scala-sbt/command_2.12/1.4.0-SNAPSHOT/ivys/ivy.xml
[info] compiling 9 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 3 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 11 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 3 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 11 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 3 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 11 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 3 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 11 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 3 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 11 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 3 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 11 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 3 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 11 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 3 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 11 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 3 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 11 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 3 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 11 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 3 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 11 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 3 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 11 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 3 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 11 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 3 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 11 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 3 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 11 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 3 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 11 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 3 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...
[info] compiling 11 Scala sources to /Users/ethanatkins/work/oss/sbt/sbt/main-settings/target/scala-2.12/classes ...

I have to kill the whole process to get out of this loop
expectation
the cycles terminate
notes
I have seen this twice but I don't know the exact circumstances that triggered it.

Maybe we can at least add a cycle limit (10?) until we can figure out a repro?

Here is a gist with debug logging: https://gist.github.com/eatkins/fb62157ef792694ae08a56c4f93ff3b6

Zinc 1.0~1.3 I think sets the upper limit of the cycle to really low number like 3 - https://github.com/sbt/zinc/blob/6b357ae59a86a1238d78c4f808662e808747259b/internal/compiler-interface/src/main/contraband-java/xsbti/compile/IncOptions.java#L12-L14
If the setting is not respected then we've regressed in the logic in develop.

To add to that, "transitive step" turns on Boolean invalidateTransitively = true in invalidateAfterInternalCompilation(...) from the 3rd cycle onward, which does more brute force dependency invalidation, which likely would be the last if not the penultimate cycle in theory.
We did change bunch of things in Zinc, but I'm not sure if we changed these invalidation logic beside including Java into the invalidation during pipelining.

We really should fix this for 1.4.0. It's a nasty bug that forces you to quit sbt if you get stuck in a cycle.

Another related issue is that ctrl+c doesn't allow you to cancel compilation if compilation never actually fails which is the case in an infinite cycle loop.

I've been compiling sbt in a temp directory using fresh sbt and zinc, but I have not seen this behavior.

I should update here that following https://github.com/sbt/zinc/pull/916#issuecomment-691736361 I've been able to reproduce the looping effect.
diff --git a/build.sbt b/build.sbt
index 2d7013b6b..d9d7841b8 100644
--- a/build.sbt
+++ b/build.sbt
@@ -11,10 +11,10 @@ ThisBuild / version := {
   val v = "1.4.0-SNAPSHOT"
   nightlyVersion.getOrElse(v)
 }
-ThisBuild / scalafmtOnCompile := !(Global / insideCI).value
-ThisBuild / Test / scalafmtOnCompile := !(Global / insideCI).value
+ThisBuild / scalafmtOnCompile := false // !(Global / insideCI).value
+ThisBuild / Test / scalafmtOnCompile := false // !(Global / insideCI).value
 ThisBuild / turbo := true
-ThisBuild / SettingKey[Boolean]("usePipelining") := !(Global / insideCI).value
+ThisBuild / SettingKey[Boolean]("usePipelining") := false // !(Global / insideCI).value

 val excludeLint = SettingKey[Set[Def.KeyedInitialize[_]]]("excludeLintKeys")
 Global / excludeLint := (Global / excludeLint).?.value.getOrElse(Set.empty)
diff --git a/project/Dependencies.scala b/project/Dependencies.scala
index 6a9b06cf5..1e72b3a1a 100644
--- a/project/Dependencies.scala
+++ b/project/Dependencies.scala
@@ -14,7 +14,7 @@ object Dependencies {
   private val ioVersion = nightlyVersion.getOrElse("1.4.0-M8")
   private val lmVersion =
     sys.props.get("sbt.build.lm.version").orElse(nightlyVersion).getOrElse("1.4.0-M2")
-  val zincVersion = nightlyVersion.getOrElse("1.4.0-M12")
+  val zincVersion = nightlyVersion.getOrElse("1.4.0-SNAPSHOT")

   private val sbtIO = "org.scala-sbt" %% "io" % ioVersion

@dwijnand
https://github.com/sbt/zinc/tree/develop/zinc/src/sbt-test/source-dependencies/trait-private-val-local-inheritance has
> checkIterations 3

If that corresponds to cycle number, we might be able to trigger transitive steps in scripted by adding more on top, like having two sources that each define multiple classes that mutually inherit the other set.


containerapp up erroneously reported error creating Container App Env

Related command
az containerapp up
Extension name (the extension in question)
container app up
Description of issue (in as much detail as possible)
You can see in the screenshots below, but I ran the command once and got an error that the container app environment 'has not been provisioned successfully'. However, I checked the new resource group in the portal and found the container apps env. So I ran the command again, without any other changes and it completed successfully.
It looks like there was either a problem with timing out the request to create the container app env too soon, or a misinterpretation of the response from that request.
Command

1st attempt output

Container Apps Env in the Portal

2nd attempt output

FYI - was trying another deployment and reproduced the problem again. Only difference is I was watching it closer, so it failed a 2nd time before continuing on.

route to CXP team

Adding Service team to look into this.
@calvinsID Could you please look into this once you get a chance ?


Add serialVersionUID field to Serializable classes

A serialVersionUID field is strongly recommended in all Serializable classes. Specifying one gives more control, though JVM does generate one if you don't specify. The value generated can differ between different compilers. and also can avoid the InvalidClassException
reference: https://www.vojtechruzicka.com/explicitly-declare-serialversionuid

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #1252 (b98f4f1) into master (176a476) will decrease coverage by 0.57%.
The diff coverage is 18.18%.

@@             Coverage Diff              @@
##             master    #1252      +/-   ##
============================================
- Coverage     70.18%   69.61%   -0.58%
+ Complexity     2096     2088       -8
============================================
  Files           376      376
  Lines          8339     8340       +1
  Branches        908      909       +1
============================================
- Hits           5853     5806      -47
- Misses         2036     2083      +47
- Partials        450      451       +1

Impacted Files
Coverage Δ
Complexity Δ

.../dromara/soul/admin/listener/DataChangedEvent.java
100.00% <ø> (ø)
4.00 <0.00> (ø)

...org/dromara/soul/admin/model/entity/AppAuthDO.java
100.00% <ø> (ø)
5.00 <0.00> (ø)

...g/dromara/soul/admin/model/entity/AuthParamDO.java
100.00% <ø> (ø)
1.00 <0.00> (ø)

...rg/dromara/soul/admin/model/entity/AuthPathDO.java
100.00% <ø> (ø)
1.00 <0.00> (ø)

...omara/soul/admin/model/entity/DashboardUserDO.java
100.00% <ø> (ø)
3.00 <0.00> (ø)

.../dromara/soul/admin/model/entity/PermissionDO.java
83.33% <ø> (ø)
2.00 <0.00> (ø)

.../org/dromara/soul/admin/model/entity/PluginDO.java
100.00% <ø> (ø)
3.00 <0.00> (ø)

...romara/soul/admin/model/entity/PluginHandleDO.java
100.00% <ø> (ø)
3.00 <0.00> (ø)

...rg/dromara/soul/admin/model/entity/ResourceDO.java
100.00% <ø> (ø)
3.00 <0.00> (ø)

...va/org/dromara/soul/admin/model/entity/RoleDO.java
100.00% <ø> (ø)
3.00 <0.00> (ø)

... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc050b1...b98f4f1. Read the comment docs.


WFLY-6517 export JndiPermission out of org.wildfly.naming module + fi…

…x testcases which still depend on org.jboss.as.naming
https://issues.jboss.org/browse/WFLY-6517

@dmlloyd could you review this please?

Looks fine, thanks.


ControlFlow usage before describe does not work in Jasmine (works in Jasmine2)

If I use an explicit controlFlow().execute to do some one-time setup before my tests, the implicit control flow created by a describe won't "wait" for it.
If I use the "jasmine2" framework, instead of the default "jasmine" framework, the spec behaves as I expect it to.
var describeWaited = false;

// Pre-describe setup.  Simulate by returning a promise that waits half a
// second.
protractor.promise.controlFlow().execute(function() {
  return protractor.promise.delayed(500).then(function() {
    describeWaited = true;
  });
}, 'Doing some setup');

// Actual test.  Implicit Control Flow in describe should "wait" for
// setup.
describe('Actual set of tests', function() {
  it('actual test', function() {
    expect(describeWaited).toBe(true);
  });
});

I'm running protractor from master, on Linux, with Chrome.

Not sure how to fix yet, but the issue is that in Jasmine 1.3, the task on the webdriver control flow which controls the it block is getting scheduled as a child of the setup one, so it's not waiting for it to complete.

OK, so this boils down to Jasmine 1.3's old runs/waitsFor behavior for doing asynchronous tests. Essentially, it causes a timeout in the JavaScript event loop, which messes up webdriver's promise queue. Here's a minimal example:
var webdriver = require('selenium-webdriver');

var waited;

webdriver.promise.controlFlow().execute(function() {
  return webdriver.promise.delayed(500).then(function() {
    console.log('waited');
    waited = true;
  });
}, 'Doing some setup');

// This is what Jasmine2 does - it blocks are called immediately, so they schedule right away
webdriver.promise.controlFlow().execute(function() {
  if (waited !== true) {
    console.log('A: FAILURE');
  } else {
    console.log('A: SUCCESS');
  }
});

// This is what Jasmine1.3 does - there are delays due to runs/waitsFor
setTimeout(function() {
  webdriver.promise.controlFlow().execute(function() {
    if (waited !== true) {
      console.log('B: FAILURE');
    } else {
      console.log('B: SUCCESS');
    }
  });
}, 50);

Output:
B: FAILURE
A: SUCCESS

I'm not sure what, if anything, we can do about this in the jasminewd adapter. One of the main advantages of Jasmine2 is that it gets rid of weird hacks like this.
Unless this is significantly blocking anyone, I'm going to close this issue - I think we can better spend time improving Protractor with the new framework than supporting corner cases in old Jasmine. There are many alternatives if an upgrade to Jasmine2 is not feasible (use onPrepare or beforeEach or a prior it block to do the setup).
@tullmann thanks for bringing this up and especially for providing an easy way to reproduce. Please do let me know if this is a higher priority problem that I'm rating it.

Yeah closing this is fine, I think I've accumulated enough reasons to switch to Jasmine2 now.  :)
I'm not sure I entirely follow, but it seems like the behavior in the "Jasmine1.3" case in your example is just a bug in webdriver's controlFlow?  I'm not following how running controlFlow functions in a setTimeout handler is allowed to make a mess of the controlFlow.  That just seems broken.  If its expected behavior, then at least some harder error than making a mess seems worthwhile.  Should I try taking this up with webdriverjs?

The logic of the control flow, as I see it, is 'if a task is scheduled while another task is running, it is a child of the currently running task'. So, with the timeout, the setup gets a chance to become the active task.
It's not super intuitive, but I don't know if the alternative is better.

Ah, thanks, for the explanation!  I think see how the delayed execute looks "like a child" of the in-progress one.  That's pretty subtle.
Hrm ... I don't see any good way to differentiate this case from any flows created directly by the current one.


Summons-based Tree boss

-Description-
A Tree boss who utilizes summoned saplings to disrupt and disorganize a team.
Tree is stationed in the center of the arena.
-Tree Abilities-
1. Summon saplings: Summon stationary saplings on the field. Can be destroyed.
2. Hurl boulder: Launches damaging projectiles (on the ground) that stun in
an AoE, and slow afterwards.

3. Root attack: Sends out a slow-moving hitbox in a cone shape. As the attack
extends outward, enemies hit by it are stunned, then rooted and take DoT.
Enemies who walk into the affected areas are rooted and take reduced DoT.
See "http://imgur.com/a/UKu40".

4. Buff saplings: After a channel, immediately triggers one sapling ability for
every sapling in the arena. While the tree is channeling, all saplings are
invulnerable, but sapling abilities will not trigger.

-Sapling Abilities-
1. Trigger sapling ability: Whenever an enemy receives a movement-imparing debuff
near a sapling, one sapling ability will trigger based on the distance between
the sapling and said enemy. Also works if the enemy moves into range with a
movement impairment (mostly via Sapling Throw).
2.

3. Sapling throw: A mid-ranged attack. Sapling grabs an enemy and throws them behind
itself. Target take damage, and is slowed (triggers sapling ability) upon landing.
See "http://imgur.com/a/ACbj3".

*All sapling abilities has a windup animation*

-Tree Phases-
Phase One: Tree summons one sapling at a time, hurls one boulder at a time, sends out
one Root Attack at a time, and can be damaged while channeling Buff Saplings.

Phase Two: Tree summons multiple saplings, hurls multiple boulders, and sends out two
Root Attacks at a time. Tree takes 75% less damage while channeling Buff Saplings.

Phase Three: Tree summons saplings in a ring around it (the distance varies), and sapling
abilities automatically triggers whenever an enemy is in range.

=====================
Other notes:
I created this boss some time ago, and received positive feedback from some members on the team, though Baumi remarked that it was too complicated. Since he never specified what parts needed redoing, I'll just repost the entire boss here. It was made on notepad, so the formatting might look off.
EDIT: OKAY, the formatting is SUPER screwed, and I have no idea what to do about it, so enjoy I guess!

I recall your original post. This is much better!
About the formatting, issue #37 has a nice template you can use!


Update to use delegate_to localhost

Will resolve #127
Update tasks, both NDFC and local to use delegate_to localhost

@mtarking Did you see improvement in the overall runtime?


QA - Bug Hunt

Feel free to list down your bug finds here. For now until a better approach is discussed, we will list all of our appropriate bugs that are discovered here.
Please provide the associated information:
Method of Discovery
IE: "I was clicking login, and my screen flickered and moved a div to the far side of my screen. My browser is Chrome Version 117.0.5938.132"
Don't hesitate to be as descriptive as possible so we can attempt to recreate the bug and work on a fix. You may also feel free to create a fix, but please document the solution, and let myself or someone else (PO, PM, Lead Dev, BC) know.

Method of Discovery
When I enter my full email into the email field (example<EMAIL_ADDRESS>on the login and registration page, I get an "Invalid email!" error because my email is longer than 30 characters. This means a user with a longer email cannot create an account or login.

This issue is outdated since we've moved to our new user story format.


Set default power levels when creating a room

To make sure only the bot user can manage the room

Coverage increased (+0.03%) to 98.301% when pulling 37a435ec720b99f4b513803e8acb9244e2b7b2ba on only-bot-can-invite-users into 6650e0cf44dc29b1c954972824c52995e0c652ae on master.


Is this project still maintained and updated?

Hi dear all,
I do not see so many contributions lately.
Is this project still maintained and updated?
Thanks,
Alessandro

Certainly seems like it. While not hard to make your own client, an updated client or an explanation of what's going on in this repository would be helpful.

Hi, the repository is not abandoned we just released a new version with the support for latest APIs.
That said the maintenance of this repository is limited.


lnd c-lightning restore incompatibility

c-lightning sends lnd htlcs with out of order id's when restoring. This makes the channel unusable as lnd doesn't know what to do. c-lightning tracking issue: https://github.com/ElementsProject/lightning/issues/3920
Adding this issue to track that issue.

Fixed by https://github.com/ElementsProject/lightning/commit/a3c30441d31e95e70a5e102d53dd21f45bf13e74


Additional Loads add autoscale to _extra + Define units

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
The autoscale doesn't seems to apply for essential_load1_extra and I got it all as full Wh.

Also as Additional I would like to define that for the essential_load2 I want to use kWh as units.
I do not have realtime consumption, but still would like to use dailly usage there.
Expected behaviour

the _extra would be in kWh
the essential_load2 would be displayed in kWh

Possible Solutions

apply parent load: auto_scale:true on essential_load1_extra as well
so something like essential_load2_unit:kWh to override default.

Mode
lite
Context / Reason
The total consumption is more likely to be in kWh so Wh is just a huge number.
_load2 is not actual consumption, but it is daily kWh sensor.  and displaying it as 0 and using _extra for the daily consumption is possible solution...yet kind of not great solution.

Hi. Auto scale is not applied to the extra sensor as this field is designed to show anything i.e temperature, humidity, and not only power or Wh. I would recommend that you create a template sensor to convert to kWh i.e. just divide by 1000 as its not something I plan to implement.
I'll see what I can do about using the essential loads to display energy values. It wont work with auto scale though.

I see you have deployed it to display sensor units.

You can manipulate the units through templates.
The auto_scale function only works for power (W) as the units are also coded into the function


Fix timestamp processing

Fixes timestamp processing, especially in cases when the timestamp is missing in results.yaml.
Pull Request Checklist

[ ] implement the feature
[ ] write the documentation
[ ] extend the test coverage
[ ] update the specification
[ ] adjust plugin docstring
[ ] modify the json schema
[ ] mention the version
[ ] include a release note

This is fixing issues encountered while processing results.yaml from
https://artifacts.osci.redhat.com/testing-farm/e3c4d1f2-a192-4d4f-b95d-47880ef7758c/
It would deserve serious testing though.

As discussed on Slack, closing this PR in favor of https://github.com/teemtee/tmt/pull/3356 which now integrates all of your changes. Thanks!


Add str to providers.

How it will look:
>>> from elizabeth import Personal
>>> p = Personal('pt-br')
>>> p
'Personal:pt-br:Brazilian Portuguese'

>>> Personal('en-gb')
'Personal:en-gb:British English'

Example available here

I can help on this issue! Do you want to add str to all providers or just the providers with locale?

@jlwt90 Thanks! Only for providers with locales, please.

Test


zsh -> invalid shell path on raspbian

the command to set the shell references
chsh -s /usr/local/bin/zsh > /dev/null #2>&1
correct path should be
chsh -s /bin/zsh > /dev/null #2>&1
this may conflict with other distros.. investigate
find a way to make it fail better

this may be a non-issue -- after fixing #1 and #2 zsh install runs fine and this doesn't appear to be a problem.. closing


Added active version of the categories icon in figma

Added active version of the categories icon in figma. We need a active state for the icon so we can show that categories are selected. The Icon will be used in the menu for NRK TV.
https://www.figma.com/file/KXGJ6Qcdf8JAyRCoKV55If/branch/PryXGFhtTuNg4hbOVcdkHO/NRK-Core-Icons?node-id=12%3A1203

@skjalgepalg description added ☝


fix(object-utils): setNested function doesn’t work with nested arrays

The setNestedValue function didn't work for the test case I added (required for live sync). I got claude to fix it
Also added a path parsing function which will be used to type the diffs in live sync
Also checked a benchmark and perf has slightly improved + we can remove some extra code with this one when working with formData
setNestedValue (shallow) x 37,805,234 ops/sec ±6.51% (60 runs sampled)
setNestedValueOld (shallow) x 25,364,159 ops/sec ±4.34% (72 runs sampled)
setNestedValue (deep) x 16,101,160 ops/sec ±3.30% (75 runs sampled)
setNestedValueOld (deep) x 12,860,047 ops/sec ±2.91% (75 runs sampled)
Fastest is setNestedValue (shallow)

closed in favour of
https://github.com/scalar/scalar/pull/3417


what‘s the principle of bbox matching when decide positive and negative example to calculate bbox loss to train?

Different detectors have different strategies, you need to read the corresponding articles.


Fix typos

Fixed typos

@blasrodri would you mind reviewing these changes please? Mostly typos.

Thanks so much


ci: Unify Flutter installation across workflows

All workflows now use the same snippet to install Flutter.

Current dependencies on/for this PR:

main

PR #70   👈

This stack of pull requests is managed by Graphite.

Merge activity

Jan 12, 11:47 AM: @Mr-Pepe merged this pull request with Graphite.


comma separated file has comma in a column data, then it is giving the error

Comma separated file has comma in a column data, then it is giving the error.

Also observed that if a column has text qualifier then the test is failing. in my file column "Values"  has the text qualifier then data is reading as is that means with double quote.

Have you checked http://www.nbi.io/docs/config-profile-csv/ ? What's your csv-profile and what's your version of NBi (and PocketCsvReader if NBi is v1.20)?

Thank you @Seddryck . Issue is resolved with v1.20


Route clashing issue in chrome after 0.2.16

I have a routing use case where I have nested/wizard states that must keep the same URL.
For example:

a user is taken to a create wizard with URL /something/create
navigating between steps should not change the URL
navigating directly to step 1 should be possible

I was able to do this by defining the following states (Also, I'm very open to better solutions for this use case):
$stateProvider
          .state('something.create', {
            url: '/create',
            abstract: true,
            template: '<div ui-view></div>'
          })
          .state('something.create.1', {
            url: '',
            template: '...'
          })
         // ...
          .state('something.create.4', {
            url: '',
            template: '...'
          });

This pattern has worked in versions 0.2.15 and lower.. but https://github.com/angular-ui/ui-router/pull/1585 added a Array.prototype.sort to the route rules.  The sort algorithm implemented in Chrome is not stable (https://bugs.chromium.org/p/v8/issues/detail?id=90).. so if you have a lot of routes defined in your application, then routes with the same prefix end up getting put into a somewhat random order.
I have added a link to 2 code pens which show this issue.  You can view them in debug mode to see the URLs.  You can notice the issue when you click the hij.step.1 button after loading the pen.. it will take you to step 3 in Chrome.  Also, in debug mode if you add #/hij to the URL, it will take you to step 3 by default in Chrome.
v0.2.16: http://codepen.io/cdriscol/pen/adGBoX
v0.2.15: http://codepen.io/cdriscol/pen/bEKoXL
I think sorting rules by prefix length to avoid clashes is appropriate, but I think we should ensure a stable sort so that the first rule that matches is the first rule that is defined in the application.

This also looks related to #2496

:+1: just experience the same

See our discussion in PR #2502


vis scheduler in mmcls

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
mmcls toos/analysis_tools/vis_scheduler.py can also use in mmdet and it's useful before training

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This PR can be merged after the English doc is completed.
@jinxianwei, you can refer to the doc in mmcls, https://github.com/open-mmlab/mmclassification/blob/1.x/docs/en/useful_tools/scheduler_visualization.md.

This PR still needs a careful check then can be merged


Updated all dependencies to the latest versions

It's not recommended to explicitly set the version of a dependency. Typically, the version is defined within the dependencyManagement section of the pom.xml file.


Can we use this with SpringCloudDataFlow

Hi,
Thanks for great library, I am exploring this, can we use it along with Spring Cloud Data flow?
https://github.com/spring-cloud/spring-cloud-dataflow

Dilip

Hi,

Thanks for great library,

Thank you!

can we use it along with Spring Cloud Data flow?

You should be able to use Easy Rules in SCDF depending on how you design and package your app (task or stream). I think the nature of your input facts is key:

If facts are a fixed set of data items, then you can apply rules on the fixed set of known facts and deploy your Easy Rules app as a Spring Cloud Task. This is a proactive approach: we know facts upfront, so we can proactively act on them.
If facts are a stream of events, then you can apply rules on windows of facts and deploy your Easy Rules app as a Spring Cloud Stream. This is a reactive approach: we don't know facts upfront, so we will react on them as they happen.

I'm closing this issue for now, but don't hesitate to add a comment if you need further support.


Howto create AR Advance through SDK

I'm attempting to create an advance through the SDK, I left the ApplyToTransactions empty and specified an UndepositedFundsGlAccountNo.  I have the correct advance account setup in AR, but I see no place to specify the location for the advance and get this error message:
Result status: failure for Control ID: 91ab330f-58eb-4f28-a5dd-a7e7ad42cec6: BL03001994 Use of empty Location is invalid. A valid Multi-Entity Location must be specified, BL03001994 Use of empty Location is invalid. A valid Multi-Entity Location must be specified.
        var payment = new ArPaymentCreate()
        {
            CustomerId = customerId,
            TransactionPaymentAmount = amount,
            PaymentMethod = paymentMethod,
            ReceivedDate = paymentDate,
            UndepositedFundsGlAccountNo = "1030",
        };

        _intacctClientDal.CreateArPayment(payment).RunSync();

I think you need to set an OverpaymentLocationId - https://github.com/Intacct/intacct-sdk-net/blob/master/Intacct.SDK/Functions/AccountsReceivable/ArPaymentCreate.cs#L48-L49

That worked, thanks!


Fix serverless-perf test avoid sleeping 10 seconds when fetching logs

What does this PR do?

Do not sleep 10 seconds between each iteration, use a loop to sleep only when needed.
Motivation

The test is taking 55 minutes, including 50 minutes of sleep.
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

I changed the behavior of the test, if we can't get the duration the job just hard fails, let me know if it should be skipped like it was before !

/merge


Provide custom localization files for DateInRegionFormatter

The colloquialSinceNow function is almost perfect, however for my project I need some of the date formatting to be slightly different. For example instead of %d minutes ago I need it to be %d mins ago.
How can I override the formatting strings, as defined in https://github.com/malcommac/SwiftDate/blob/develop/Sources/SwiftDate/SwiftDate.bundle/en-GB.lproj/SwiftDate.strings?

Actually it's not supported unless you modify manually one of the locales.
However due to the fact we want also support Linux as target (see #352) we should need to provide an extra layer upon the NSLocalizedString() functions.
I'm working on a LocalizationHelper class which is able to load a custom file at specified path as translation language; it should be pretty easy to develop and it can also be used to set a custom file as localized .strings file which suits your need.
I'll post some updates on it in the following days, so keep an eye on this topic.

Added Localization class.
Replaced locale property of DateInRegion with localization which is of type Localization.
By default it's initialized using the same DateInRegion's locale.
You can however set it with the absolute path to a valid .strings file:
let formatter = DateInRegionFormatter()
formatter.localization = Localization(path: [PATH_TO_YOUR_STRINGS_FILE])
// use the formatter

It will be available since 4.0.12.
That's the reference to the commit https://github.com/malcommac/SwiftDate/commit/f1f16721f34f36798279012213d25942e60593ee.


Broken error message with universes

The following code
type bar = x:Type & x

let x : bar = (| Type, nat |)
let y : bar = (| (Type -> Type), list |)
let z : bar = (| nat, 0 |)

let l : list bar = [x ; y ; z]

gives me (Error 54) Aha.bar is not a subtype of the expected type Aha.bar

This is actually just a bad error message.. the list you're building cannot live in a single universe. Using --print_universes reveals the issue, but it should be considered to enable it when we print this mismatch
A.fst(9,28-9,29): (Error 54) A.bar u#0 is not a subtype of the expected type A.bar u#1

Ah, indeed. Thank you.
A few things I don't get right though,

Don't we have cumulative universes? In my understanding that would allow to make it work..
Dependent pairs suddenly seem much less useful. Am I missing something?

@theolaurent F*'s universes are not cumulative.

We should at least print the universe discrepancy

I made F* retry printing with more and more flags until it finds a discrepancy, so this raises the following error:
B.fst(9,28-9,29): (Error 54) B.bar u#0 is not a subtype of the expected type B.bar u#1
1 error was reported (see above)

without any action from the user.


Replace to IB loss for incremental learning in multi-class classification task

This PR includes

Implementation of IB loss hook and IB loss
Move all heads used for multi-class classification to custom_cls_head.py (+ delete existing head file)
Rename 'LinearHead' -> 'CustomLinearHead', 'NonLinearHead' -> 'CustomNonLinearHead'
Replace focal loss to IB loss for incremental learning in stage.py multi-class classification task


Eliminate keywords!

This has a few breaking changes:

as is required for relation aliases
date, time, timestamp, interval, and oid are now normal
functions and thus require parens around their argument

And, non-breakingly, keywords can be used (either with or without being
quoted) as identifiers.

Current coverage is 79.26%

Merging #1094 into pre-v4 will decrease coverage by -0.02% as of 64b9248

@@            pre-v4   #1094   diff @@
======================================
  Files          173     173
  Stmts         9715    9710     -5
  Branches       312     309     -3
  Methods          0       0
======================================
- Hit           7703    7697     -6
  Partial          0       0
- Missed        2012    2013     +1

Review entire Coverage Diff as of 64b9248

Powered by Codecov. Updated on successful CI builds.

Sorry. Couldn't find anything. LGTM.


Provide Roster Of Known-Working Packages

Package list was pulled form a working version of the container that I had.

Superseded by #8


listbox_XXX function documentation missing parameter

Seems like the API documentation is missing a parameter:
now:

const char_t *listbox_text(const *listbox);

should be:

const char_t *listbox_text(const *listbox, uint32 index);

In other words the index of the list item is missing. I believe there are several with the same mistake, but have not checked.

Reviewed listbox documentation page: https://nappgui.com/en/gui/listbox.html
The parameter was missing in several methods.
Thanks for the report.


Add more project descriptions

On the road to add descriptions to all projects.

@bot-gradle test and merge

OK, I've already triggered a build for you.


fix: address misc UXR recommdations

fixes #1236
fixes #1237
fixes #1239
fixes #1241

@kne42 is there a dev link for these?

@Janeece https://dev-kira-1.cryoet.dev.si.czi.technology/

@Janeece ready for re-review


Outdated es-419.json

Need

Update the es-419.json file to new specs. This file is only for Latam Spanish.

Ref.
https://github.com/vuejs/vue-cli/blob/dev/packages/%40vue/cli-ui/locales/en.json

@coderdiaz I have added es-419 on Transifex now: https://www.transifex.com/vuejs/vue-cli/language/es_419/
I recommend translating the 117 untranslated keys directly here:
https://www.transifex.com/vuejs/vue-cli/translate/#es_419/$/148882921?q=translated%3Ano
Afterwards, the JSON file can be directly exported here (click on cli-ui and choose Download for use):
https://www.transifex.com/vuejs/vue-cli/language/es_419/

@caugner Well, I check it out. 👍


Netflix Clone

I am a GSSOC'22 Contributor and I wanted to contribute to this repository.

Can I know the reason for not assigning me?

Can I know the reason for not assigning me?

Clone project are not good enough, try to be more innovative.🚀


vcomp140.dll not found

when I run the program it always says "VCOMP140.dll was not found, try reinstalling the program" how do I fix this?

OS : WINDOWS 10

Most Windows machines should be able to run the binary provided here. If not, you can download any of the missing dlls from the internet.


Merge random-beans-java8 into random-beans?

Should random-beans-java8 be merged into random-beans now that random-beans requires Java 8?

Yes, this module made sense when the library was supposed to be Java 7 compatible (see issue and comment of #49 ).
Now that prerequisites are clear for each version, Java 8 types support can be merged in the core module.
I'll plan the merge for next release.


Support python 3.

Fixes a few things accidentally left out of the previous PR.

Is this failing because it's accessing the wrong version of the PyClaw repos?

Oops, I forgot that I hadn't finished this.  Yes, it was failing just because it was running against an old pyclaw commit.  I restarted the build and now it's passing.


User should be able to login with social account via Torus

MASTER_SEED - private key received from torus
Instead of current welcome screen buttons "get invited", "create wallet", "already signed in" user will see

"login with google" etc buttons similar to https://app.tor.us/
use Torus SDK to then login the user
Torus SDK returns privatekey + email
privatekey is saved as MASTER_SEED
hdwallet is created from MASTER_SEED instead of mnemonic
in signup flow "email" step is automatically filled (as in the current eToro flow)
torus node/s is read from .env (TORUS_NODE)
https://xd.adobe.com/view/f195a710-6a9c-4365-68e5-5644b73d1e36-87a4/screen/1f9d4ff4-b637-476e-809f-9f3f6a2769c6/Sign-Up-29

Definition of Done

User is able to login with social account
Logged in user wallet is recovered from MASTER_SEED
email step is skipped but email still sent to server

@LiavGut @tomerGD I think we dont need recover wallet anymore

Verified as done.
Checked on the Dev env. v0.18.0
Devices:
Redmi Go // Android 8.1.0


Each page should link to the source in github

With the link where?

In the footer I guess.

Didn't we remove the footer?

Dunno. But this is not a priority right now anyway.


Set writeable working directory for sysbench tests

Adds a writeable emptyDir volume to use as working directory for sysbench so that fileio tests can complete.
Currently fileio tests fail as the container working directory is read only:
sysbench 1.0.17 (using system LuaJIT 2.1.0-beta3)

Running the test with following options:
Number of threads: 1
Initializing random number generator from current time

Extra file open flags: (none)
128 files, 16MiB each
2GiB total file size
Block size 16KiB
Periodic FSYNC enabled, calling fsync() each 100 requests.
Calling fsync() at the end of test, Enabled.
Using synchronous I/O mode
Doing sequential write (creation) test
FATAL: Cannot create file 'test_file.0' errno = 9 (Bad file descriptor)

After the change the fileio test completes:
sysbench 1.0.17 (using system LuaJIT 2.1.0-beta3)

128 files, 8192Kb each, 1024Mb total
Creating files for the test...
Extra file open flags: (none)
Creating file test_file.0
..
1073741824 bytes written in 7.06 seconds (144.97 MiB/sec).
..
Removing test files...

Can one of the admins verify this patch?

/rerun all

Results for ec2_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_sysbench
Pass
0
00:01:31


Run only tests matching a pattern

If you have many tests and you only want to run some of them, you want to be able to tell tap to only run tests matching a certain pattern (glob, regex, etc.).
And how could I use this now to call it from npm test where "test" script is in my package.json something like:
node node_modules/tap/bin/tap.js ./test

Just put this in your package.json:
"scripts": { "test": "tap ./test.js" }

Globs would work, too, since that command is just run by the shell.

I am not installing tap globally. Therefre I use it through node.
Do globs work recursively? I tried and I could not manage to do it.
None of the following work for the test under ./test/dir1/dir2/test.js
node node_modules/tap/bin/tap.js ./test/*.js
node node_modules/tap/bin/tap.js ./test/*/*.js

What I want to do is:
node node_modules/tap/bin/tap.js miaw
or
tap miaw
to run all the tests that have miaw in their path somewhere.
Similar to what the collowing does for CMake:
cmake -R miaw
The following tests would be run:
./test/miaw1/test.js
./test/mymiaw/test.js
./test/dir/miaw2.js

Do globs work recursively? I tried and I could not manage to do it.

Depends on your shell.  (Probably not.)
You should just use tap in your scripts.test, not node node_modules/tap/bin/tap.js.  npm will set up the paths for you so it works.
You can pass in multiple arguments.  tap ./test/*.js ./test/*/*.js ./test/*/*/*.js

There is no way to have tap find all the files with miaw in their path, no.  I think that feature would be confusing.

I run tap an it does not work.
I only install modules locally in my project. That is under node_modules. npm doesn't seem to set up the paths. (I use the latest npm and nodes)

Put this in your package.json:
"scripts": { "test": "tap test/*.js" }

Then run this command: npm test

Even if tap would have a parameter like "cmake" (-R), or like "find" (-name)?

Adding this feature would be confusing, for little benefit.
Structure your tests so that they're easier to find, or use some other file-walking utility.

I have two levels below test (and not only there) test files that I want to run.
gabriel$ npm test

><EMAIL_ADDRESS>test /Users/gabriel/mono
> tap test/*.js

total ................................................... 0/1

not ok

npm ERR<EMAIL_ADDRESS>test: `tap test/*.js`
npm ERR! `sh "-c" "tap test/*.js"` failed with 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>test script.
npm ERR! This is most likely a problem with the mono package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     tap test/*.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls mono
npm ERR! There is likely additional logging output above.
npm ERR!
npm ERR! System Darwin 11.3.0
npm ERR! command "node" "/usr/local/bin/npm" "test"
npm ERR! cwd /Users/gabriel/mono
npm ERR! node -v v0.6.10
npm ERR! npm -v 1.1.0-3
npm ERR! code ELIFECYCLE
npm ERR! message<EMAIL_ADDRESS>test: `tap test/*.js`
npm ERR! message `sh "-c" "tap test/*.js"` failed with 1
npm ERR! errno {}
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /Users/gabriel/mono/npm-debug.log
npm not ok

Thinking about the utility of such a feature (globbing or pattern given with a parameter)
you have thousand tests that run in 10 minutes and you want to check only the ones that are testing part of the system that you have changed. And those tests are in a subdirectory. telling tap to run only tests matching that pattern would let you test only that part of the system. And this hierarchy is actually intended to structure the unit tests into components.


proxyconnect tcp: dial tcp $IP:$PORT: connect: connection refused

1st I start mubeng server then I use go-dork tool then I got this error
proxyconnect tcp: dial tcp $IP:$PORT: connect: connection refused
2024/01/31 22:34:01 [ERRO] ▶ <IP_ADDRESS>:33560 Get "https://www.google.com:443/search?q=inurl%3A'admin.aspx'&gws_rd=cr,ssl&client=ubuntu&ie=UTF-8&start=10": proxyconnect tcp: dial tcp $IP:$PORT: connect: connection refused
To Reproduce
mubeng -a localhost:8089 -f live_proxies.txt -r 1 -v

go-dork -x http://localhost:8089 -q "inurl:'admin.aspx'"

go-dork giving this error
If your IP address has been blocked by search engine providers or other reason
Screenshots
I have attached Screenshot for reference.

OS: Kali Linux
OS version: Linux kali 6.1.0-kali9-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.27-1kali1 (2023-05-12) x86_64 GNU/Linux
mubeng Version: mubeng version v0.14.1

Will check on this ASAP.

Any update on this ?


Regression test for txout

As part of https://github.com/rust-bitcoin/rust-bitcoin/issues/3691, the regression test for txout needs to be updated to reflect an Amount that would actually be valid (less than 21 million sats).  Currently the regression test Amount::from_sat(0xDEADBEEFCAFEBABE) parses to an Amount greater than 21 mill which can't actually be used for a TxOut.

ACK changing the regression test. Should replace it with one that uses the MAX_MONEY constant exactly.


Android Background notifications received when device wakes up manually

My app sends push notifications. If the device is in sleep mode, the notifications are not received. If I wake up the device, the notifications are received. I check with the new GCM diagnostics, and I get the following traces:
Jun 7, 4:25 PM Accepted
Jun 7, 4:25 PM Stored
Jun 7, 6:47 PM Delivered
Jun 7, 6:50 PM Acknowledged
As you can see the notifications has been received by GCM at 4:25PM but the device only gets it at 6:47PM which is the time when I woke up the device.
Is there something specific to configure to get the notification when the device is in sleep.?

Fixed by using delayWhileIdle=false in the message


Tracking issue for all possible XAML compiler warnings

[x] Obsolete warnings
[ ] Deprecated/Experimental attributes warnings
[x] IStyle instance added to the MergedDictionaries (should be added to the Styles collection)
[x] Duplicate setters
[ ] Possible null reference exception when adding Transition to the Transitions collection without initializing the collection first (https://github.com/AvaloniaUI/Avalonia/discussions/5899). Probably extend it to other nullable collections?

Any other ideas?

Duplicate property, two cases:
Attribute + element:
<Border Background="Blue">
  <Border.Background>Red</Border.Background>
</Border>

Double elements:
<Border>
  <Border.Background>Blue</Border.Background>
  <Border.Background>Red</Border.Background>
</Border>

Double attributes is already a XML parsing error.

Possible null reference exception when adding Transition to the Transitions collection without initializing the collection first

It would be nice to have dependency properties able to instantiate collections lazily instead so users don't have to know the whether they should instantiate the collection or not.
Currently we have two types:

Always null, e.g. the mentioned Animatable.Transitions. Pain: the user must always set the collection, or it's an exception.
Always instantiated, e.g. TextBlock.Inlines. Pain: allocation if unused (most textblocks), double allocations if set in XAML.

I'll open a separate proposal to discuss that.

TemplateBinding used outside of templates. I think I see this one in discussions or Telegram at least once a week :)

Used ContentPresenter and friends outside ControlTeplate, which is forbidden.

Opt-in warnings for {ReflectionBinding} usage so devs writing AOT apps can enforce avoiding its usage.

XAML compiled should detect following patterns:
<TabControl>
    <TabControl.ItemTemplate>
          <DataTempalte>
                 <TabItem Header="{Binding Title}" /> <!-- WARNING:  -->

And recommend something like this (possibly, just a link to the documentation/samples):
<TabControl ItemsSource="{Binding ...}">
  <TabControl.Styles>
    <Style Selector="TabItem">
      <Setter Property="Header" Value="{Binding Title}"/>
    </Style>
  </TabControl.Styles>
</TabControl>

Is it possible to add a warning when type declaration in XAML and code behind does not match ?
Common error when a person creates UserControl via template, changes it to ReactiveUserControl and does not immediately modify the code behind to match.

@Al-Dyachkov can you bring some example? If types of XAML and code behind are not compatible, there should already be an error (not even a warning). Unless I am missing something.
ReactiveUserControl in code behind and UserControl in XAML should also be fine.

@maxkatz6
xaml
<reactiveUi:ReactiveUserControl x:TypeArguments="VM"
                                x:Class="View"
                                x:DataType="VM">
...
</reactiveUi:ReactiveUserControl>

code behind
public partial class View : UserControl
{
}

This compiles and even works to some extent because ReactiveUserControl<T> is derived from UserControl, but without any Reactive UI features like activation.

What do you think about pinning this issue so it's easy to find?

I would suggest adding a warning when a DynamicResource is reassigned.  I wasted a whole day troubleshooting a problem due to this.

I would suggest adding a warning when a DynamicResource is reassigned. I wasted a whole day troubleshooting a problem due to this.

@workgroupengineering can you give an example?

I would suggest adding a warning when a DynamicResource is reassigned. I wasted a whole day troubleshooting a problem due to this.

@workgroupengineering can you give an example?

A third-party control defines within it a DynamicResource with the same name as the one I created.
Application xmlns="https://github.com/avaloniaui"
             xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
             xmlns:local="using:Dresses.Warehouse"
             x:Class="My.App"
             >
  <!-- "Default" ThemeVariant follows system theme variant. "Dark" or "Light" are other available options. -->

  <Application.Resources>
      <x:Double x:Key="SmallIconSize">18</x:Double>
  </Application.Resources>

  <Application.Styles>
    <FluentTheme />
  </Application.Styles>
</Application>

<UserControl xmlns="https://github.com/avaloniaui"
             xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
             xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
             xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
             x:Class="My.Views.MainView"
             x:ClassModifier="internal"
             >
 <UserContro.Resources>

    <ResourceDictionary>
      <ResourceDictionary.MergedDictionaries>
        <!-- internally redefines the resource SmallIconSize 24 -->
        <ResourceInclude Source="avares://third_party/third_party_Control.axaml"/>
      </ResourceDictionary.MergedDictionaries>
   </ResourceDictionary>
 </UserContro.Resources>
 <!-- The size is 24 instead of the expected 16, this is because I don't know Third_party_Control.axaml redefines SmallIconSize. -->
 <Rectangle Fill="Red"
             Width="{DynamicResource SmallIconSize}"
             Height="{DynamicResource SmallIconSize}"/>
</UserControl >

Add Warnig suppression il xaml like

<!--#Suppress-Start: AVX11111 - Reason -->
  ...
<!--#Suppress-End: AVX11111-->

A third-party control defines within it a DynamicResource with the same name as the one I created.

That's the exactly what a dynamic resource should do imo 🤔

A third-party control defines within it a DynamicResource with the same name as the one I created.

That's the exactly what a dynamic resource should do imo 🤔

but if I don't know that it was redefined by another library I will get unexpected behavior.  It just needs to show a warning like SmallIconSize has been redefined in avares://third_party/third_party_Control.axaml

Sounds as an expected possibility.

It just needs to show a warning like SmallIconSize has been redefined

We currently don't have this information. As we don't store such metadata.

Add Warning suppression il xaml like

Yeah, we need something for that.

yet another one (maybe) https://github.com/AvaloniaUI/Avalonia/issues/15593

Is it possible to add a warning when base type declaration in XAML and code behind does not match ? Common error when a person creates UserControl via template, changes it to ReactiveUserControl and does not immediately modify the code behind to match.

As raised in https://github.com/AvaloniaUI/Avalonia/issues/16755, If the class in the code-behind is Control and the XAML is UserControl, it causes an Internal Compiler Error in the XAML compiler, so this mistake can be serious (and very hard to diagnose).


Fix error handling in Darwin DNS-SD implementation to clean up properly.

We had several codepaths where we could create a service ref but then do some fallible operations before calling Add() on the context.  If those failed, they would call Finalize() on the context, which would delete the context, but not DNSServiceRefDeallocate() the service ref.
The fix is to make sure that:

All cases where we create a service ref successfully immediately set it on
the context.
All context deletion goes through MdnsContexts::Delete, so that we make sure
to clean up the service ref if there is one.

Fast-tracking platform-specific change with platform owner review.


MVKBuffer: Support texel buffers in "host-coherent" memory on Mac.

According to the Vulkan spec:

If buffer is a VkBuffer not created with the
VK_BUFFER_CREATE_SPARSE_BINDING_BIT bit set[...] then the
memoryTypeBits member always contains at least one bit set
corresponding to a VkMemoryType with a propertyFlags that has
both the VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT bit and the
VK_MEMORY_PROPERTY_HOST_COHERENT_BIT bit set. In other words,
mappable coherent memory can always be attached to these
objects.

There is no exception for texel buffers. Even though desktop Metal
disallows textures in shared memory, even linear textures created from a
buffer, we have to advertise host-coherent memory for texel buffers.
Some applications actually depend on this behavior, so it's not just a
theoretical concern.
To support host-coherent texel buffers, we implicitly create a managed
buffer and copy data between the device memory and the managed buffer,
just like for a linear image.

Bah. It broke because of some failure to clean itself up in preparation to build.

Bah. It broke because of some failure to clean itself up in preparation to build.

Travis has been breaking regularly.

Travis has been breaking regularly recently.

And it is often not possible to restart the CI run. Very frustrating.


Chunk large delete requests

In version 7.0 and later of the API, you can pass a maximum of 200 object IDs to the delete() call. This change chunks large deletions into batches of 200.

Nice work. One question - don't you need to combine the result chunks? It looks like SforceBaseClient.delete() is going to return just the results from the final chunk.

I'm not sure what format the result is returned in. All I can find is this: https://www.salesforce.com/developer/docs/api/Content/sforce_api_calls_delete_result.htm#topic-title
If it is an array of DeleteResult, I can just merge them. Do you know what the format is?

Yes - delete() just returns an array of DeleteResult, for example:
Array
(
    [0] => stdClass Object
        (
            [id] => 001E0000019EXa8IAG
            [success] => 1
        )

    [1] => stdClass Object
        (
            [id] => 001E0000019EXa9IAG
            [success] => 1
        )

    [2] => stdClass Object
        (
            [id] => 001E0000019EXaAIAW
            [success] => 1
        )
)

So, yes, just merge the results as you receive them.
Also, we need a contributor license agreement (CLA, very similar to Apache projects) to accept all but the most trivial contributions. Could you fill out the CLA doc, scan it, and send it to me at ppatterson (at) salesforce (dot) com?

All merged in - thanks!


Can't get plugin to work correctly.

I've setup everything correctly. I'm having an issue with any mode that is supposed to be uploading the media to GCS.
In stateless mode the original file is being deleted? I'm assuming the original is deleted if it determines it was successfully uploaded to GCS, but the file is not in the bucket.
My local uploads directory, shows the resized images generated, but not the original file.
-rw-r--r-- 1 www-data www-data  6670 Jul 25 06:05 cd752665-k3p33bfdpqcy-150x150.jpg
-rw-r--r-- 1 www-data www-data 16342 Jul 25 06:05 cd752665-k3p33bfdpqcy-300x225.jpg

If I switch to cdn mode the original file is in my uploads directory there, but again, no file is uploaded to GCS.
-rw-r--r-- 1 www-data www-data  6670 Jul 25 06:10 07b8de47-k3p33bfdpqcy-150x150.jpg
-rw-r--r-- 1 www-data www-data 16342 Jul 25 06:10 07b8de47-k3p33bfdpqcy-300x225.jpg
-rw-r--r-- 1 www-data www-data 52589 Jul 25 06:10 07b8de47-k3p33bfdpqcy.jpg

Is there some kind of debug mode I can enable to I can see what the problem might be?
PHP Version 7.3.17
Wordpress Version 5.4.2
WP-Stateless Version 2.3.3

Ugh, sorry, had the wrong bucket permssions!


fix(Dropdown): SearchCleared not called when multiple

Hi!
I was running into an issue where a setState was getting called onEnter key presses, this gets rid of the error and all the tests still pass. Can anyone with a better understanding of the codebase help me?

Codecov Report

Merging #2678 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2678      +/-   ##
==========================================
+ Coverage   99.74%   99.74%   +<.01%
==========================================
  Files         160      160
  Lines        2751     2752       +1
==========================================
+ Hits         2744     2745       +1
  Misses          7        7

Impacted Files
Coverage Δ

src/modules/Dropdown/Dropdown.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2363cd...99cd469. Read the comment docs.

I have a pretty good understanding of the codebase.  However, I'd need a completed issue template to better understand the issue.  Want to post one here?

Okay, @levithomason. I've spent a fair bit of time trying to minimally reproduce this but I'm having some problems and need to get to working on other things.
The problem I'm running into isn't acutally related to a multiple props so this is a bad fix. The problem is that I'm using this dropdown as a connected component with ReduxForm. When a value is selected, my redux state is changed and a rerender is triggered. This causes the dropdown list to unmount, and clearSearchQuery performs a setState on an unmounted component.
I don't know what the most succinct solution is, I dont think there is a way to get around this error using the lifecycle methods of Dropdown. But I'm closing this and happy to move this over to an issue later when I have more time to produce a succinct reproducible example.


Getting Error in Docker.will please explain step by step procedure??

Cannot connect to the Docker daemon. Is 'docker -d' running on this host?

Hello,
The github issues for docker is not meant as a general support forum.
For support, please see any of these:

docker-user mailing list
#docker on IRC
forums.docker.com


bevy_derive: Add derives for Deref and DerefMut

Objective
A common pattern in Rust is the newtype. This is an especially useful pattern in Bevy as it allows us to give common/foreign types different semantics (such as allowing it to implement Component or FromWorld) or to simply treat them as a "new type" (clever). For example, it allows us to wrap a common Vec<String> and do things like:
#[derive(Component)]
struct Items(Vec<String>);

fn give_sword(query: Query<&mut Items>) {
  query.single_mut().0.push(String::from("Flaming Poisoning Raging Sword of Doom"));
}

We could then define another struct that wraps Vec<String> without anything clashing in the query.

However, one of the worst parts of this pattern is the ugly .0 we have to write in order to access the type we actually care about. This is why people often implement Deref and DerefMut in order to get around this.
Since it's such a common pattern, especially for Bevy, it makes sense to add a derive macro to automatically add those implementations.
Solution
Added a derive macro for Deref and another for DerefMut (both exported into the prelude). This works on all structs (including tuple structs) as long as they only contain a single field:
#[derive(Deref)]
struct Foo(String);

#[derive(Deref, DerefMut)]
struct Bar {
  name: String,
}

This allows us to then remove that pesky .0:
#[derive(Component, Deref, DerefMut)]
struct Items(Vec<String>);

fn give_sword(query: Query<&mut Items>) {
  query.single_mut().push(String::from("Flaming Poisoning Raging Sword of Doom"));
}

Alternatives
There are other alternatives to this such as by using the derive_more crate. However, it doesn't seem like we need an entire crate just yet since we only need Deref and DerefMut (for now).
Considerations
One thing to consider is that the Rust std library recommends not using Deref and DerefMut for things like this: "Deref should only be implemented for smart pointers to avoid confusion" (reference). Personally, I believe it makes sense to use it in the way described above, but others may disagree.
Additional Context
Discord: https://discord.com/channels/691052431525675048/692572690833473578/956648422163746827 (controversiality discussed here)

Changelog

Add Deref derive macro (exported to prelude)
Add DerefMut derive macro (exported to prelude)

I have a fresh case that needs this in the breakout example; can you add this to the Velocity struct there?

Wow, that change log is a great example of the clarity benefits. I love it.

Actually, one more place that I think we should change this immediately @MrGVSV: the Timer examples. This one tripped me up really badly when I first started using Bevy, and it's a very common idiom.

Actually, one more place that I think we should change this immediately @MrGVSV: the Timer examples. This one tripped me up really badly when I first started using Bevy, and it's a very common idiom.

Should I do this for all Timer newtypes in all examples? Or just the timers.rs example?

Hmm. I think that for consistency it should probably be all newtypes in all examples: .0 is awful, and consistency is good.
I don't think it'll make the PR too bad to review: the actual meat of the changes are still nicely concentrated.

I think that for consistency it should probably be all newtypes in all examples

I left some newtypes as is, especially ones that just access the inner type itself (println!("{}", foo.0)) and ones that would require a double-dereference (**foo.clone()).

I left some newtypes as is, especially ones that just access the inner type itself (println!("{}", foo.0)) and ones that would require a double-dereference (**foo.clone()).

Sounds good to me :) We can revise more as it comes up, but this goes a long way.

bors r+


Update licence to correct format and date

As per instructions from @annashipman, the copyright for this project should read "Crown Copyright", not "HM Government".
It is also 2015 now.

The copyright year should be the year the project started, not necessarily the current year.

I was using this as my precedent: https://github.com/alphagov/govuk_frontend_toolkit/commit/429a85cf851f2788502b9227c1b3863cadb81fd4
@alext  Do you think it's now incorrect?

https://www.gov.uk/copyright would suggest that the year should be the of creation.  More information here: http://www.copyrightservice.co.uk/copyright/p03_copyright_notices


2 custom requests

Hi.
I know your busy but there are 2 requests that would be great:

the expandingComponent works great but is there any way to be able to choose if you want it in the beginning or the end of the row?
i did a tweak with css but there are other issues that it causes so it would be best if we can determine where we want it on the row
if the table header could be fixed so that you can have scrolling on the body and the column header stays. I also found a fix with css but that too causes other issues (mainly #1 css fix clashes with this css fix)

thanks for your help.

the expandingComponent works great but is there any way to be able to choose if you want it in the beginning or the end of the row?

you means the expand row is on the top of row?

if the table header could be fixed so that you can have scrolling on the body and the column header stays

Try to set height on BootstrapTable.

you means the expand row is on the top of row?
i mean that the expand row indicator can be in the last column of the table

i mean that the expand row indicator can be in the last column of the table

got it. It's also a feature and I need more hard work on it, because there's have the same request for putting the selection column in the last. In my opinion, it's still minor and I'll spend some time to do this but without schedule.
Anyway, PR is welcome.

Just throwing my two cents in, you could:

don't show any expand component
add a new column with static data, just a plus/minus symbol that shows depending on expanded state
set all columns except this new one to expandable={false}

I managed to get the expander in the last column of the table by just using expander: true, like this :
{
expander: true,
Header: '',
accessor: '',
Expander: ({isExpanded}) =>

{isExpanded
?
: }

}

I managed to get the expander in the last column of the table by just using expander: true, like this :
{
      expander: true,
      Header: '',
      accessor: '',
      Expander: ({isExpanded}) =>
        <div>
          {isExpanded
            ? <Icon color='orange' name='angle down' />
            : <Icon color='orange' name='angle right' />}
        </div>
    }


Race in setting LocalConnectionID

==================
  WARNING: DATA RACE
  Read at 0x00c0001bfa08 by goroutine 2262:
    github.com/pion/dtls/v2.(*Conn).readAndBuffer()
        /home/runner/work/dtls/dtls/conn.go:707 +0x264
    github.com/pion/dtls/v2.(*Conn).handshake.func3()
        /home/runner/work/dtls/dtls/conn.go:1062 +0x1de

  Previous write at 0x00c0001bfa08 by goroutine 2261:
    github.com/pion/dtls/v2.flight4Generate()
        /home/runner/work/dtls/dtls/flight4handler.go:258 +0xccb
    github.com/pion/dtls/v2.(*handshakeFSM).prepare()
        /home/runner/work/dtls/dtls/handshaker.go:225 +0x412
    github.com/pion/dtls/v2.(*handshakeFSM).Run()
        /home/runner/work/dtls/dtls/handshaker.go:192 +0x8d7
    github.com/pion/dtls/v2.(*Conn).handshake.func2()
        /home/runner/work/dtls/dtls/conn.go:1043 +0x124

  Goroutine 2262 (running) created at:
    github.com/pion/dtls/v2.(*Conn).handshake()
        /home/runner/work/dtls/dtls/conn.go:1051 +0x8c4
    github.com/pion/dtls/v2.handshakeConn()
        /home/runner/work/dtls/dtls/conn.go:259 +0x1877
    github.com/pion/dtls/v2.ServerWithContext()
        /home/runner/work/dtls/dtls/conn.go:343 +0x1fd
    github.com/pion/dtls/v2.Server()
        /home/runner/work/dtls/dtls/conn.go:[295](https://github.com/pion/dtls/actions/runs/9910824373/job/27382124292#step:8:545) +0x126
    github.com/pion/dtls/v2.(*listener).Accept()
        /home/runner/work/dtls/dtls/listener.go:77 +0x135
    github.com/pion/dtls/v2/e2e.serverPion()
        /home/runner/work/dtls/dtls/e2e/e2e_test.go:251 +0x394
    github.com/pion/dtls/v2/e2e.(*comm).assert.gowrap2()
        /home/runner/work/dtls/dtls/e2e/e2e_test.go:134 +0x41

  Goroutine 2261 (running) created at:
    github.com/pion/dtls/v2.(*Conn).handshake()
        /home/runner/work/dtls/dtls/conn.go:1041 +0x753
    github.com/pion/dtls/v2.handshakeConn()
        /home/runner/work/dtls/dtls/conn.go:259 +0x1877
    github.com/pion/dtls/v2.ServerWithContext()
        /home/runner/work/dtls/dtls/conn.go:343 +0x1fd
    github.com/pion/dtls/v2.Server()
        /home/runner/work/dtls/dtls/conn.go:295 +0x126
    github.com/pion/dtls/v2.(*listener).Accept()
        /home/runner/work/dtls/dtls/listener.go:77 +0x135
    github.com/pion/dtls/v2/e2e.serverPion()
        /home/runner/work/dtls/dtls/e2e/e2e_test.go:251 +0x394
    github.com/pion/dtls/v2/e2e.(*comm).assert.gowrap2()
        /home/runner/work/dtls/dtls/e2e/e2e_test.go:134 +0x41
  ==================
      testing.go:1398: race detected during execution of test

@hasheddan I will take a crack at this! Unless it is a super easy fix (missed lock somewhere)


Use a Standard-Compliant License Identifier

This pull request changes the value of the license property in package.json to a standard, machine-readable SPDX license identifier, "MIT".
npm doesn't require that you use a valid SPDX identifier, but it's strongly recommended. (Try npm help 7 package.json and search for “License”.) Other source code package managers, like Maven for Java and RubyGems for Ruby, recommend the same. I can't give legal advice via GitHub, but I'm happy to answer questions about SPDX or point you to good resources.
Why care about SPDX? A machine-readable standard makes it possible for programs, rather than just people, to review a module or even an entire codebase to make sure that licenses are compatible. Whatever the reason—strong personal conviction, company policy, terms of a business deal—SPDX makes it easier to collaborate with others when licenses can be a problem, and helps take open-source software to more places. Given that npm has a ton of modules but also handles dependencies in a novel way, I think a little license hygiene could help npm build amazing new relationships between communities that lawyers have long kept apart.
Thanks for your contribution to open-source software!
K

Thanks for merging!


test: let's break some sh*t

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 83.081%

Totals

Change from base Build<PHONE_NUMBER>:
0.003%

Covered Lines:
19652

Relevant Lines:
23654

💛  - Coveralls


Whitespace misplaced for comments following "run:"

For this simple file:
# hello world
rule hello:
    run:
        print("hello world")

# yet another hello world
rule hello2:
    shell:
        """echo hello world"""

# final one
rule hello3:
    shell:
        """printf 'hello world'"""

The following diff is obtained:
❯ snakefmt test.smk --diff
=====> Diff for test.smk <=====

  # hello world
  rule hello:
      run:
          print("hello world")

- # yet another hello world
+         # yet another hello world
? ++++++++
+
+
  rule hello2:
      shell:
          """echo hello world"""

  # final one
  rule hello3:
      shell:
          """printf 'hello world'"""

[INFO] All done 🎉

Interesting. Thanks for reporting @ashwinvis. Could you please confirm which version you are using? We just released a new patch version today (0.1.4). I don't know if that will fix this issue, but best to confirm that first.

The latest and the greatest.
❯ pip list | rg snake
snakefmt                      0.1.4
snakemake                     5.23.0

I wonder if it is a bug with snakemake in how it groups Pythonic stuff after a rule, ignoring indentation. I changed "yet another hello world" to a print statement and it seems to be executed if I call snakemake -s test.smk hello -j.

Hi @ashwinvis, thanks for spotting this, it is definitely not a snakemake bug. It's actually tied to an annoyance in python's tokenize specifically related to comments. Will have a look at this, not the easiest fix!

This is now addressed 9402a48


Consider renaming ChainClient.SendMsg and/or ChainClient.SendMessage

Please consider renaming and documenting the differences between ChainClient's SendMessage and/or the SendMsg methods to prevent confusion.

@renaynay thank you for the issue! This is because of the go relayer interface for Provider. We are likely to move the provider code out of the lens repo and back into the go relayer repo and define the provider methods on a struct like so:
type CosmosProvider struct {
  lensclient.ChainClient
}


Add support for cargo bench

It would be great to support benchmark tests through the command cargo bench available on nightly. Possible use cases include making it easier for others to help optimize code snippets.

Benchmarking on a cloud service provider is inherently a flaky proposition. There's no guarantee that the underlying CPU will be at a constant speed during a single benchmark run, much less between two benchmarks run sequentially or two completely separate executions.

That's true. While discrepancy between separate benchmarks don't matter for the intended usage, variance in proportional performance sucks. Could running the generated WebAssembly of the benchmark on the client be a viable option? I do recognize that it is infinitely more work.

running the generated WebAssembly of the benchmark on the client

That sounds like #374. It's certainly plausible, although I don't know enough of the particulars around what is needed (high-resolution timesource, for example) to know what availability there is.

discrepancy between separate benchmarks doesn't matter for the intended usage

Wouldn't you expect to see things like
#[bench] slow_fn() { /* ... */ }
#[bench] fast_fn() { /* ... */ }

And then people would get surprised when fast_fn is slower than slow_fn? To me, benchmarking is inherently a comparative endeavor: "did it get faster or slower than what it was".

And then people would get surprised when fast_fn is slower than slow_fn? To me, benchmarking is inherently a comparative endeavor: "did it get faster or slower than what it was".

Yes, sorry I wasn't clear enough. I meant that it's important that the percentages stay the same but the actual times may differ.

That sounds like #374.

Definitely, provided that the test crate gets support.

Just as an idea, profiling might be more stable than running the benchmarks, but provide similar feedback. Assuming execution time and things like cache hits are unstable, the total number of assembly instructions executed for the program is a very useful metric.
I am not sure what exactly the backend to this website does, but valgrind --tool=callgrind --dump-instr=yes --collect-jumps=yes --simulate-cache=yes ./target/release/... runs the executable and collects this information. It could be parsed used to annotate the assembly display. Execution times would be somewhat meaningless (as with benches), but with few exceptions, a program with fewer total executed instructions will be slower than one with more. And you can easily see where operations are concentrated.
perf can do something similar but it's kind of a huge pain to get working right compared to valgrind, imo.


added requirements.txt & instructions for venv

Made another update to README to include the mention of VA being an HTML app. Instructions for setting up a Flask venv are still there & requirements.txt can be updated over time.

Thanks for your contribution!


Documentation for the image to use same name/ ip address as the hostname/ip address

Description of the issue:
Is there documentation for creating the image to use the same hostname/ip address as the the instance it is running on?
Is this possible with JIB?
I'm looking to do this with jib-gradle-plugin

Hi @ucancprem.  That's not something that is set in the container, but is instead configured by the container runtime.  For example, you can tell Docker to expose a container port with a -p argument.


Spinner size too small on a tablet.

Hi guys, fist of all, thanks for this lib!
My setup consists of react v16.0.0-alpha.6, react native 0.44.2 and<EMAIL_ADDRESS>I am testing my Android App in a device with screen resolution of 1920x1200 tvdpi, and for this resolution, the spinner size seems too small!

Is there any other way to make the spinner size larger?
Thanks.

@marlon407 Are you using size prop and setting it to large?

Hi @niftylettuce , thanks for your response.
I managed that passing a number as param instead of large. Passing the string large, the spinner remained small. According to this documentation (http://facebook.github.io/react-native/releases/0.44/docs/activityindicator.html), passing a number to the ActivityIndicator  size prop was the only option I could make work.

 try this


[WIP] - Route domain support nov28 rebase

Still Need to update the virtual server source field that was recently added

Note: commit for 'full route domain support' and 'route domain support for iapp pool members' were previously committed and then reverted due to an iapp bug.  This review is mainly for the additional changes (in separate commits) to support VS addresses (destination/source), VA address, and FDB records.

The new and improved route domain enhancement is ready for review.  I'd suggest using the original commit (f62b6e2354aff308b6389f5b6b166925cc29007c) as the baseline and look at the individual commits.


Support math on arrays with more than 2 dimensions

Nimble is currently unable to compile a model with a link function on a 3-tensor:
logit(p[i,j,k]) <- ...

It would be good to either support this, or to document a workaround in the error message.

@perrydv Is this something I could implement in a day, or is it more complex?

I am closing this pending discussion, because what actually happened was a misleading error message.  NIMBLE compiles this fine.  The problem was matrix-to-scalar assignment, which NIMBLE doesn't currently support.


Angular 9 update

Hi @zainniazi thanks for the PR.
Can you say what is the static forRoot(): ModuleWithProviders<TreeModule> { needed for?
Was there a warning/error, or it's just for better typings?
Thanks
BTW, there's another PR open for Angular 9:
https://github.com/500tech/angular-tree-component/pull/815
We need to merge the best of both somehow

@adamkleingit Regarding ModuleWithProviders<TreeModule>: https://angular.io/guide/migration-module-with-providers

Libraries should add the generic type to any usages of the ModuleWithProviders type.

@adamkleingit the other PR aims to changed how the lib is builded to respect Angular Package Format, it is not mandatory for Angular 9 compatibility.
This PR on the other hand is the strict minimum to make it working. It would be really helpful if you could reviewe and publish it.


Highlight deprecated options in generated reference docs

DEPRECATED settings could be highlighted using a different color (e.g. orange) to make the review of long lists of settings much easier.

Thanks for the suggestion!
/kind feature
/priority backlog

As a first step for this, the code that generates HTML from the source code should change to add extra class information to the relevant table rows and / or cells, then add <span> elements that wrap the word DEPRECATED and the text that follows.
If anyone is picking this up, also consider logging related issue(s) about adding extra styling for other aspects, eg alpha & beta features.

/retitle Highlight deprecated options in generated reference docs

For the tooling, see https://github.com/kubernetes-sigs/reference-docs#kubernetes-reference-docs

/remove-lifecycle stale

/reopen

/remove-lifecycle rotten

/remove-lifecycle stale

/lifecycle frozen

Closing this as a mission impossible.
The reference is generated using the raw swagger JSON from the upstream (kubernetes/kubernetes) repository. The swagger spec was generated from the source code comments. The implication , if there are things we are unhappy with, we have to change the source code. We have to persuade all SIGs to make sure that "DEPRECATED" or "Alpha" or "Beta" API versions or fields should be somehow highlighted. For example, when we say a field is deprecated, always use "DEPRECATED". Do NOT say "this will be deprecated", or "this field was deprecated in version 1.xx". None of these is accurate. The reference generator is not smart enough to figure out what these comments means. Similarly, the "Alpha" stage should be highlighted by spelling "Alpha", not "alpha". The generator is capable of scanning and highlighting these fields only when the syntax in the comments are consistent and accurate.
As a side note, if you are really into an accurate and detailed API reference, you may want to try out docker run -p 8000:8000 tengqm/kab:latest, and then point your browser to http://localhost:8000. The API specs in that tool were manually polished for all these kinds of inaccuracies.
/close

Just one tweak
/reopen

/close not-planned


Uncaught TypeError: Cannot read property 'displayBuffer' of null

Opened Atom from the dock so an untitled buffer was initially opened
Start typing in the editor and then quickly opened the settings view via cmd-,

Atom Version: 0.189.0
System: Mac OS X 10.10.2
Thrown From: autocomplete-plus package, v2.7.1
Stack Trace
Uncaught TypeError: Cannot read property 'displayBuffer' of null
At /Users/kevin/.atom/packages/autocomplete-plus/lib/symbol-provider.coffee:254

TypeError: Cannot read property 'displayBuffer' of null
  at SymbolProvider.module.exports.SymbolProvider.getTokenizedLines (/Users/kevin/.atom/packages/autocomplete-plus/lib/symbol-provider.coffee:254:11)
  at SymbolProvider.module.exports.SymbolProvider.updateSymbolListForRange (/Users/kevin/.atom/packages/autocomplete-plus/lib/symbol-provider.coffee:205:23)
  at /Users/kevin/.atom/packages/autocomplete-plus/lib/symbol-provider.coffee:96:8

Commands
  5x -0:02.4 editor:newline (atom-text-editor.editor)
     -0:01.4 settings-view:open (atom-text-editor.editor)

Config
{
  "core": {
    "excludeVcsIgnoredPaths": false,
    "disabledPackages": [
      "feedback",
      "background-tips",
      "autosave"
    ],
    "audioBeep": false,
    "themes": [
      "one-dark-ui",
      "atom-dark-syntax"
    ]
  },
  "autocomplete-plus": {
    "defaultProvider": "Symbol",
    "confirmCompletion": "tab and enter"
  }
}

Installed Packages
# User
atom-dark-syntax, v0.26.0
autocomplete-atom-api, v0.7.0
autocomplete-css, v0.6.0
autocomplete-html, v0.5.0
autocomplete-plus, v2.7.1
autocomplete-snippets, v1.2.0
language-batch, v0.3.2
language-docker, v1.1.3
language-powershell, v2.0.0
language-typescript, v0.15.0
wrap-guide, v0.31.0

# Dev
No dev packages

@benogle this is where all those redundant ? you ding me on start to come in handy ;) j/k :laughing:

This is no longer an issue. The symbol list is now updated synchronously. If you can repro, obv reopen


Fix/remove orphaned groupified site

Remove orphaned groupified site

checks the site group (if classic or groupified)
removes the site from deleted sites whether it's a classic or a groupified one
if groupified, checks if the group is in the deleted groups before deleting the site
if orphaned, deletes the site
Fixes 'spo site remove' command. Closes #2706

Thank you for a quick turnaround @michaelmaillot, we'll review it asap 👍


Incorrect Target values when using Tensor Flow v2 Model

Hello,
When executing the code code (applying DICE on half_moons dataset with Tensor Flow 2 model), the 'target' column of the counterfactuals (in HERE (A) and HERE (B) below) is different than the result predicted by Tensor Flow model for the examples [results shown below].  And thus, the counterfactuals do not all belong to the opposite class, even if it is shown that they are.
Is this an issue or did I misconfigure the DICE method?
Thank you for your hard work!
import dice_ml
from sklearn import datasets
import numpy as np
import pandas as pd

#create dataset
X1, Y1 = datasets.make_moons(n_samples=1000, noise=0.2)

s = {'x1': X1[:,0], 'x2': X1[:,1], 'target': Y1}
df = pd.DataFrame(data=s)

d = dice_ml.Data(dataframe=df,
                 continuous_features=['x1', 'x2'],
                 outcome_name='target')

import tensorflow as tf
import keras
X_train = X1
y_train = Y1
ann_model = keras.Sequential()
ann_model.add(keras.layers.Dense(20, input_shape=(X_train.shape[1],), kernel_regularizer=keras.regularizers.l1(0.001), activation=tf.nn.relu))
ann_model.add(keras.layers.Dense(1, activation=tf.nn.sigmoid))
ann_model.compile(loss='binary_crossentropy', optimizer=tf.keras.optimizers.Adam(0.01), metrics=['accuracy'])
ann_model.fit(X_train, y_train, validation_split=0.20, epochs=100, verbose=True)

#Generate the DiCE model for explanation
m = dice_ml.Model(model=ann_model, backend='TF2')

explainer = dice_ml.Dice(d,m)
query_instance = {'x1':0, 'x2':0}

#verification:
x_test = np.array([[0,0]])
ann_model.predict(x_test) #0.99

counterfactuals = explainer.generate_counterfactuals(
    query_instance,
    total_CFs = 4,
    desired_class=0,
    proximity_weight=0.5,
    diversity_weight=1.0,
    features_to_vary="all",
    permitted_range=None,
    posthoc_sparsity_param=0.1)

counterfactuals.visualize_as_dataframe() #HERE (A)

print(counterfactuals.cf_examples_list[0].final_cfs_df) #HERE (B)

Results:
The output of dice:

The prediction of the TF model (same order of the points):

hi @LiNaNiNa This issue was fixed in the latest main branch. Can you try cloning the latest main branch from github and try this code again? (clone the repo and then do pip install -e  . from the root folder of the repo).

Hello,
Thank you for your fast answer, @amit-sharma .
Yes, the latest version works well!
The only change I did (for future reference), is changing the type of query_instance argument for explainer.generate_counterfactuals method, from a dictionary to a dataframe. But, right now, it can work on multiple instances in one run! Thank you for the new feature.
Keep up the hard work!


feat(DIA-69): add progressive onboarding model for saved artworks

This PR resolves DIA-69
Description
Adds the progressive onboarding for saved artworks.
User logged in
https://github.com/artsy/eigen/assets/15792853/5487679c-6067-470f-b7f4-718adadb6048
User  signing up
https://github.com/artsy/eigen/assets/15792853/c91ce88c-e5a6-4d49-912a-7319161de208
PR Checklist

[ ] I have tested my changes on iOS and Android.
[ ] I hid my changes behind a feature flag, or they don't need one.
[ ] I have included screenshots or videos, or I have not changed the UI.
[ ] I have added tests, or my changes don't require any.
[ ] I added an app state migration, or my changes do not require one.
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

adds progressive onboarding for saved artworks - araujobarret

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (adds progressive onboarding for saved artworks - araujobarret)

  Generated by :no_entry_sign: dangerJS against f533247cf58b2c0fe984a219c81563b95a2e5db6

Thanks for the inputs @damassi !
I've addressed all of them https://github.com/artsy/eigen/pull/9224/commits/0aff7c0f073cb4ab7bc3ee55a801a0a30d875752, created a doc explaining how to use the model with some examples and added deprecation x-reference in the visual clue docs(updated the description with the doc reference too) 👍
Please let me know if you think we need something else.


Is there a plan to make it possiple to bind multiple workflows to same model?

In some cases the model needs multiple workflows to handle separate statuses depending on business requirements.

No plan yet, but I'll consider this.


Fix get-dbarolemember

Fixes #
Changes proposed in this pull request:

a failed Connect-SqlServer no longer ends the function

How to test this code:

[ ]
[ ]

Has been tested on minimum requirements:

[ ]  Powershell 3
[ ]  Windows 7
[ ]  SQL Server 2000

Has been tested on maximum requirements:

[ ]  SQL Server vNext
[ ]  Windows 10
[ ]  Azure Database

Tests for tester:

[ ] Working/useful help content, including link to command on dbatools web site
[ ] All examples work as advertised
[ ] Does not contain template content
[ ] Does not contain excessive/unnecessary amounts of comments
[ ] Works remotely
[ ] Works locally
[ ] Works on lower versions or throws error specifying version not supported
[ ] Works with named instances
[ ] Works with clustered instances
[ ] Handles offline/read only databases
[ ] Supports multiple servers (at the command line or piped from Get-SqlRegisteredServerName)
[ ] No un-handled errors which stop the command working with multiple servers

hey @ConstantineK - can you fix this PR? It has too many files in it.

Please resubmit with single file


pre-emphasis

Hi, it seems that pre-emphasis is not implemented. Will you add this in the future?

Thank you so much for pointing it out. It used to be part of the package but due to some technical issues, it's been eliminated. Yes, I have plans to add it in the future and pull requests are also welcome. Once again, thank you so much for your attention.

@stefbraun The pre-emphasis has been added. Please refer to processing function.
Thank you so much for your declared issue.
Bests


GPU to CPU readback slow with a heavy scene

I'm sorry if this is an issue with Unity itself and not the implementation.
What I noticed is that the UpdatePost2ReadCache() function in FaceDetector.cs is quite slow with a complex scene (object with 1 million vertices).

Face detection + getting output takes around 5ms.
Render of the scene without face detection takes around 8ms.
Face detection + render of the scene takes around 90ms. The inference is the same at 4ms, but GPU to CPU readback goes from 2ms to 30ms.

5ms + 8ms should be 13ms, not 90ms. Is there any way to speed up the output? Thanks.

That's why you should avoid GPU to  CPU readback in general. Please understand that this sample project is just for testing the model. You may have to construct a GPU-side only implementation like I did in the FaceMeshBarracuda pipeline.
https://github.com/keijiro/FaceMeshBarracuda


:new: Add belongsTo options & extra data functionality

I wanted a possibility to add additional fields to the revision object. In my case it is just associated models, which I will associate outside the plugin. I was thinking of adding some logic to enable a dynamic association in the module, but didn't do it yet.
The extraData object is parsed and all values from it are appended to the Revision query object. The fields have to be added manually with a migration in this case.
Also added a belongsTo options object because my setup did not work without it due to Sequelize model name magic.
Thanks for the great package and let me know if there's anything I can do to make the package a bit more universal. 👍  :)

@ekeuus Thanks a lot! I've been working on bringing the package up to date and cleaning up a lot of the 💩 that was in there, will check it out later this week.

I will check it out in the evening 👍

I think it should be OK now. About the "Shouldn't it be options.extraData instead of coming from the model options?" I dont think so.. The goal here was to pass the options to the instance method as .save({ extraData: { a: 1, b: 2} })

@ekeuus I made a bunch of changes to the library in #74 can you resolve the conflicts?

I think it should be OK now. About the "Shouldn't it be options.extraData instead of coming from the model options?" I dont think so.. The goal here was to pass the options to the instance method as .save({ extraData: { a: 1, b: 2} })

Gotcha, could you add an example of how this works to the README?

Cool that you got the #74 in. The Metadata makes sense and I'll check the conflicts as well. 👍

@nielsgl Hey, I made the requested changes - let me know if it makes sense ;)

@nielsgl Any update on this?

@ekeuus sorry I was traveling a lot the past 2 weeks and didn't get around to it. Will review it this weekend.

@nielsgl Pinging again

@nielsgl Pinging again

@ekeuus sorry I thought I had merged it a long time ago, merging now when the build is done

@ekeuus if you fix the lint warnings then I'll get it in today

Bonus if you can check if it works if all dependencies are updated 😇

Updated and tested it - seems to work for my setup with Sequelize 4. Looking forward to using a non-custom version ;)

Could you also make a RC release then?

Sweet! Yes will do
On Tue, 13 Aug 2019 at 18:19, Ekke Tõiv Uustalu<EMAIL_ADDRESS>wrote:

Could you also make a RC release then?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nielsgl/sequelize-paper-trail/pull/63?email_source=notifications&email_token=AAGEKAI4DDF7ZT6FFIORHIDQELNKXA5CNFSM4GWKX56KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4GGATQ#issuecomment-520904782,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGEKAJLFX6ASNDWJBU6WI3QELNKXANCNFSM4GWKX56A
.

@ekeuus released as v3.0.0-rc.9

@ekeuus does it work? If so I'll release it as v3.

Seems so. Tried it in dev and worked fine. Didn't try to release it yet tho


Wrong behaviour in the popup window

Describe the bug
Calendar does not work correctly, when open in popup window

doesn't work destroy
doesn't work correctly with mouse
doesn't work events clickSchedule, beforeUpdateSchedule
The principal problem is, that the component mistakenly works with global Window instead of taking window object from the placement element. If it take the correct window element, I believe, it will be OK

The same code, when open in main window (when placement is in the main window) works good.
To Reproduce
Events
Steps to reproduce the behavior:

Open the calendar in the popup window

set up on events:
this.calendar.on({
'beforeCreateSchedule': (schedule: ISchedule) => {
this.addSchedule(schedule.start.toString(), schedule.end.toString())
},
'clickSchedule': (eventObj: IEventScheduleObject) => {
this.openShedule(eventObj.schedule)
},
'beforeUpdateSchedule' : (event:  IEventObject) => {
// userMessage.warn('before update',false,this.myWindow)
this.openShedule(event.schedule)
},
'clickDayname': (event: IEventDateObject) => {
if (this.calendar.getViewName() === 'week') {
this.calendar.setDate(new Date(event.date))
this.calendar.changeView('day', true)
}
}

Event beforeCreateSchedule works (really, this one yes) but the others not

when using mouse outside the window, it scrolls the calendar, because it catches event from the main window

Destroy:
When popUp window closes, it calls
this.calendar.destroy()
this.calendar = undefined
and close and forget itself. But then calendars raises exception again and again because it misses containers. The destroy somehow destroys internal data structures but the code that is linked to the main window object remains active event when placement with calendar and the whole window is out.
Expected behavior
Work everywhere with window where is the placement placement..ownerDocument.defaultView
Screenshots

Desktop (please complete the following information):

all environments (Firefox, Chrome)

Smartphone (please complete the following information):

Windows, but the problem should be everywhere
Version: OS: latest, Browser: latest, TUI Calendar: latest

@posel
Please give me a codepen, codesandbox or jsfiddle link to reproduce your problem.

I had the same issue with mobile devices, it append when calendar is down the viewport.
To fixe it (ok not the best way, but it work) :
CSS ;
.toastui-calendar-popup-overlay{ 	position: fixed !important; /* the problem is that initialy it was absolute and this not always in the viewport */ }
JS :
// tui calendar don't use touch event, then we simulate it : // When calendar next or preview :  setTimeout(() => { // Wait all is created 	document.querySelectorAll(".toastui-calendar-weekday-event-title").forEach(e=>{ 		e.addEventListener("touchstart", function(){ 			const theEvent = document.createEvent("MouseEvent"); 			theEvent.initMouseEvent("mousedown", true, true); 			this.dispatchEvent(theEvent); 		}) 	}) }, 1);