Previewing specific areas with querystring

?dma=501 or similar.
Alternatively, @hamboardman could also use buttons to be integrated into newsroom Previewing tools, one button each for:

DC/suburb Virginia
LA
Mexico City
London
Hong Kong

(Jeremy B. Merrill had Monticello and Des Moines set up already.)

I added Wonder Proxy locations to our paid profile.

Then I set up VPNs and tried them at home.  They work nicely, so it's definitely something within the office.

With https://git.em.nytimes.com/stash/projects/CMS/repos/cms-newsroom-utils/commits/db0d46005cb0f719ae05e5177c0ac476f87b958a, this current work is complete.  Will open new Issues for enhancements, here and in Stash, depending.


Json path get in java changing value not returning actual  value

Hi,
Am using the JSON path rest assured. when I do get it changing the actual value for the scientific number.
the output should be 5.41422482E8 this but it returns 5.4142246E
I have attached code below-
`Test
public void scientificNotationTest(){
String jsonString="{ "Product": "LAMOTRIGINE", "nrx_quantity": 5.41422482E8, "nrx_quantity_pct": 100 }";
JsonPath js= new JsonPath(jsonString);
String value =js.get("nrx_quantity").toString();
Assert.assertEquals(value,"5.41422482E8");
// this should return 5.41422482E8 right , instead it returns 5.4142246E8
//test case should pass right, but it's not  this my java exact code
}`

can anyone look into this

That's not related to the library, that's how Java's Float.toString works. This test fails with the same error.
  @Test
  public void scientificNotationTest(){
      Float val = 5.41422482E8f;
      assertEquals(val.toString(),"5.41422482E8");
  }


[bug]: /docs/components/dock wrong import

The import path should be<EMAIL_ADDRESS>instead of
import { Dock, DockIcon } from "@/components/magicui/dock";

We can do monkey-patch to fix this bug. Since it effect many of doc page, it will hard to update it one by one, also I still can not found the source of this kind of code coming from.
Insert this code before Line: 184 in file: content-collections.ts#L184
// Should be place before Line 184 in
// https://github.com/magicuidesign/magicui/blob/main/content-collections.ts#L184

if (body.includes('@/components/magicui')) {
  // This is an intentional log, just for debug or future improvement
  console.log(
    `🐛 Patch: /${document._meta.path} contains @/components/magicui`
  );

  // Monkey-patch string in all Docs "@/components/magicui" to "@/components/ui"
  body = body.replace(/\@\/components\/magicui/gi, '@/components/ui');
}


[Project Addition]: Restoration of Distorted Social Media Images

Deep Learning Simplified Repository (Proposing new issue)
:red_circle: Project Title : Restoration of Distorted Social media Images(Facial Features Only)
:red_circle: Aim : I will use GAN with help of 6 hidden layers Neural network
:red_circle: Dataset : I will make my own dataset from kaggle collecting various facial features like eye, ears, nose and mouth.
:red_circle: Approach : The approach will be not to get the original image but to get the closest resemblance of the original image with the help of GAN and superimposing the image to enhance its quality.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.

:white_check_mark: To be Mentioned while taking the issue :

Full name : Utsab Samadder
GitHub Profile Link : https://github.com/utsabsamadder
Email ID<EMAIL_ADDRESS>Participant ID (if applicable):
Approach for this Project :
What is your participant role? (Mention the Open Source program)

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Go ahead @utsabsamadder


release-4.5 use increase health check timeout for upgrade tag

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: AmeyShikerkar
To complete the pull request process, please assign yussufsh after the PR has been reviewed.
You can assign the PR to them by writing /assign @yussufsh in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: AmeyShikerkar, Prajyot-Parab
To complete the pull request process, please assign yussufsh after the PR has been reviewed.
You can assign the PR to them by writing /assign @yussufsh in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: AmeyShikerkar, bpradipt, Prajyot-Parab
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [bpradipt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Enable specific entities on buoyancy plugin

🦟 Bug fix
This is technically a feature, but it fixes a usability bug that affects the Fortress demo.
Summary

Adds the ability of whitelisting just a few models in simulation which will be affected by buoyancy.
Also reduced console spam by printing a warning only once.
Checklist

[x] Signed all commits for DCO
[x] Added tests
[x] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[x] codecheck passed (See contributing)
[x] All tests passed (See test coverage)
[x] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

I've addressed all comments, merging!


Prevent duplicate listeners from being added to effects panel icons

I think I handled this in #6020 (ran into it also while working on something), and I think I also handled not increasing the effect stage when clicking in the tooltip as well.


configuration to place the keyboard always in the bottom of the screen

A tablet like configuration.
The keyboard can use the width of the screen.

Added in version 0.4.0. (See https://github.com/the-darc/angular-virtual-keyboard#directive-global-configurations)


Nginx反代gRPC + CloudFlare CDN失败

你正在使用哪个版本的 V2Ray？
V2Ray 4.44.0
你的使用场景是什么？
Nginx 反代 Websocket/gRPC + CloudFlare CDN (证书使用的是Cloudflare生成的15年有效期的证书），CloudFlare网络设置已启用gRPC
WIN10 使用V2RayN v4.29 作为客户端，core类型为v2fly-core 4.44,
你看到的异常现象是什么？

浏览器输入域名，能正常打开网页，用V2RayN测速，WebSocket的outbound正常，
gRPC的outbound提示：远程服务器返回错误: (503) 服务器不可用
v2ray服务器端错误/访问日志没有grpc inbound的相关记录
你期待看到的正常表现是怎样的？
gRPC的Inbound连接能正常使用
请附上你的配置

服务端配置：
{
	"log": {
		"logLevel": "debug",
		"access": "/usr/local/etc/v2ray/access.log",
		"error": "/usr/local/etc/v2ray/error.log"
	},
	"routing": {
		"rules": [
			{
				"type": "field",
				"ip": [ "geoip:private" ],
				"outboundTag": "block"
			},
			{
				"type": "field",
				"domain": [ "geosite:disney" ],
				"outboundTag": "disney"
			}
		]
	},
	"inbounds": [
		{
			"listen": "<IP_ADDRESS>",
			"port": 12345,
			"protocol": "vmess",
			"settings": {
				"clients": [
					{
						"id": "UUID",
						"alterId": 0,
						"level": 0
					}
				],
				"disableInsecureEncryption": true
			},
			"streamSettings": {
				"network": "grpc",
				"security": "none",
				"grpcSettings": {
					"serviceName": "GunService"
				}
			}
		},
		{
			"listen": "<IP_ADDRESS>",
			"protocol": "vmess",
			"port": 54321,
			"settings": {
				"clients": [
					{
						"id": "UUID",
						"alterId": 0,
						"level": 0
					}
				],
				"disableInsecureEncryption": false
			},
			"streamSettings": {
				"network": "ws",
				"security": "none",
				"wsSettings": {
					"path": "/wspath"
				}
			}
		}
	],
	"outbounds": [
		{
			"tag": "direct",
			"protocol": "freedom",
			"settings": { "domainStrategy": "UseIPv6" }
		},
		{
			"tag": "disney",
			"protocol": "freedom",
			"settings": { "domainStrategy": "UseIPv4" }
		},
		{
			"tag": "block",
			"protocol": "blackhole"
		}
	]
}

客户端配置：
{
  "log": {
    "access": "D:\\v2rayN\\Vaccess.log",
    "error": "D:\\v2rayN\\Verror.log",
    "loglevel": "debug"
  },
  "inbounds": [
    {
      "tag": "socks",
      "port": 18282,
      "listen": "<IP_ADDRESS>",
      "protocol": "socks",
      "sniffing": {
        "enabled": true,
        "destOverride": [
          "http",
          "tls"
        ]
      },
      "settings": {
        "auth": "noauth",
        "udp": true,
        "allowTransparent": false
      }
    },
    {
      "tag": "http",
      "port": 18283,
      "listen": "<IP_ADDRESS>",
      "protocol": "http",
      "sniffing": {
        "enabled": true,
        "destOverride": [
          "http",
          "tls"
        ]
      },
      "settings": {
        "udp": false,
        "allowTransparent": false
      }
    }
   ],
  "outbounds": [
    {
      "tag": "proxy",
      "protocol": "vmess",
      "settings": {
        "vnext": [
          {
            "address": "<IP_ADDRESS>",
            "port": 443,
            "users": [
              {
                "id": "UUID",
                "alterId": 0,
                "email"<EMAIL_ADDRESS>                "security": "auto"
              }
            ]
          }
        ]
      },
      "streamSettings": {
        "network": "grpc",
        "security": "tls",
        "tlsSettings": {
          "allowInsecure": false,
          "serverName": "mydomain.com",
          "alpn": [
            "h2",
            "http/1.1"
          ]
        },
        "grpcSettings": {
          "serviceName": "GunService",
          "multiMode": false
        }
      },
      "mux": {
        "enabled": false,
        "concurrency": -1
      }
    },
    {
      "tag": "direct",
      "protocol": "freedom",
      "settings": {}
    },
    {
      "tag": "block",
      "protocol": "blackhole",
      "settings": {
        "response": {
          "type": "http"
        }
      }
    }
  ],
  "dns": {
    "servers": [
      "<IP_ADDRESS>",
      "<IP_ADDRESS>",
      "<IP_ADDRESS>",
      "<IP_ADDRESS>",
      "<IP_ADDRESS>",
      "<IP_ADDRESS>"
    ]
  },
}

请附上出错时软件输出的错误日志

服务器端错误日志：
// 在这里附上服务器端日志
2022/03/02 14:05:44 [Debug] app/log: Logger started
2022/03/02 14:05:44 [Debug] app/proxyman/inbound: creating stream worker on <IP_ADDRESS>:12345
2022/03/02 14:05:44 [Debug] app/proxyman/inbound: creating stream worker on <IP_ADDRESS>:54321
2022/03/02 14:05:44 [Info] transport/internet/websocket: listening TCP(for WS) on <IP_ADDRESS>:54321
2022/03/02 14:05:44 [Warning] V2Ray 4.44.0 started
2022/03/02 14:09:59 [Info] [551361254] proxy/vmess/inbound: received request for tcp:cachefly.cachefly.net:80
2022/03/02 14:09:59 [Info] [551361254] app/dispatcher: default route for tcp:cachefly.cachefly.net:80
2022/03/02 14:09:59 [Info] [551361254] proxy/freedom: opening connection to tcp:cachefly.cachefly.net:80
2022/03/02 14:09:59 [Info] [551361254] proxy/freedom: dialing to tcp:<IP_ADDRESS>:80
2022/03/02 14:09:59 [Info] [551361254] transport/internet/tcp: dialing TCP to tcp:<IP_ADDRESS>:80
2022/03/02 14:10:00 [Info] [551361254] app/proxyman/outbound: failed to process outbound traffic > proxy/freedom: connection ends > context canceled
2022/03/02 14:10:00 [Info] [551361254] app/proxyman/inbound: connection ends > proxy/vmess/inbound: connection ends > context canceled

客户端错误日志：
// 在这里附上客户端日志
2022/03/02 14:09:56 [Debug] app/log: Logger started
2022/03/02 14:09:56 [Info] app/dns: DNS: created UDP client initialized for <IP_ADDRESS>:53
2022/03/02 14:09:56 [Info] app/dns: DNS: created UDP client initialized for <IP_ADDRESS>:53
2022/03/02 14:09:56 [Info] app/dns: DNS: created UDP client initialized for <IP_ADDRESS>:53
2022/03/02 14:09:56 [Info] app/dns: DNS: created UDP client initialized for <IP_ADDRESS>:53
2022/03/02 14:09:56 [Info] app/dns: DNS: created UDP client initialized for <IP_ADDRESS>:53
2022/03/02 14:09:56 [Info] app/dns: DNS: created UDP client initialized for <IP_ADDRESS>:53
2022/03/02 14:09:56 [Debug] app/proxyman/inbound: creating stream worker on <IP_ADDRESS>:18385
2022/03/02 14:09:56 [Info] transport/internet/tcp: listening TCP on <IP_ADDRESS>:18385
2022/03/02 14:09:56 [Warning] V2Ray 4.44.0 started
2022/03/02 14:09:57 [Info] [3178090851] proxy/http: request to Method [GET] Host [cachefly.cachefly.net] with URL [http://cachefly.cachefly.net/10mb.test]
2022/03/02 14:09:57 [Info] [3178090851] app/dispatcher: taking detour [proxy18385] for [tcp:cachefly.cachefly.net:80]
2022/03/02 14:09:57 [Info] [3178090851] transport/internet/websocket: creating connection to tcp:<IP_ADDRESS>:443
2022/03/02 14:09:58 [Info] [3178090851] proxy/vmess/outbound: tunneling request to tcp:cachefly.cachefly.net:80 via tcp:<IP_ADDRESS>:443
2022/03/02 14:11:10 [Debug] app/log: Logger started
2022/03/02 14:11:10 [Info] app/dns: DNS: created UDP client initialized for <IP_ADDRESS>:53
2022/03/02 14:11:10 [Info] app/dns: DNS: created UDP client initialized for <IP_ADDRESS>:53
2022/03/02 14:11:10 [Info] app/dns: DNS: created UDP client initialized for <IP_ADDRESS>:53
2022/03/02 14:11:10 [Info] app/dns: DNS: created UDP client initialized for <IP_ADDRESS>:53
2022/03/02 14:11:10 [Info] app/dns: DNS: created UDP client initialized for <IP_ADDRESS>:53
2022/03/02 14:11:10 [Info] app/dns: DNS: created UDP client initialized for <IP_ADDRESS>:53
2022/03/02 14:11:10 [Debug] app/proxyman/inbound: creating stream worker on <IP_ADDRESS>:18387
2022/03/02 14:11:10 [Info] transport/internet/tcp: listening TCP on <IP_ADDRESS>:18387
2022/03/02 14:11:10 [Warning] V2Ray 4.44.0 started
2022/03/02 14:11:11 [Info] [3784613080] proxy/http: request to Method [GET] Host [cachefly.cachefly.net] with URL [http://cachefly.cachefly.net/10mb.test]
2022/03/02 14:11:11 [Info] [3784613080] app/dispatcher: taking detour [proxy18387] for [tcp:cachefly.cachefly.net:80]
2022/03/02 14:11:11 [Info] [3784613080] transport/internet/grpc: creating connection to tcp:<IP_ADDRESS>:443
2022/03/02 14:11:11 [Info] [3784613080] proxy/vmess/outbound: tunneling request to tcp:cachefly.cachefly.net:80 via tcp:<IP_ADDRESS>:443
2022/03/02 14:11:12 [Info] [3784613080] app/proxyman/outbound: failed to process outbound traffic > proxy/vmess/outbound: connection ends > proxy/vmess/outbound: failed to read header > common/drain: common/drain: unable to drain connection > transport/internet/grpc/encoding: unable to read from gun tunnel > rpc error: code = Unavailable desc = unexpected HTTP status code received from server: 502 (Bad Gateway); transport: received unexpected content-type "text/html" > proxy/vmess/encoding: Unable to Read Header Len > transport/internet/grpc/encoding: unable to read from gun tunnel > rpc error: code = Unavailable desc = unexpected HTTP status code received from server: 502 (Bad Gateway); transport: received unexpected content-type "text/html"
2022/03/02 14:11:12 [Warning] [3784613080] proxy/http: failed to read response from cachefly.cachefly.net > io: read/write on closed pipe
2022/03/02 14:11:12 [Info] [3784613080] app/proxyman/inbound: connection ends > proxy/http: failed to read http request > EOF

请附上访问日志

// 在这里附上服务器端日志

2022/03/02 14:09:59 我的公网ip:0 accepted tcp:cachefly.cachefly.net:80 [direct]

其它相关的配置文件（如 Nginx）和相关日志
//Nginx 配置文件
server {
  listen 80;
  listen [::]:80;
  return 301 https://$http_host$request_uri;
}
server {
  listen 443 ssl;
  listen [::]:443 ssl;

  ssl_certificate       /usr/local/etc/v2ray/fullchain-grpc.pem;
  ssl_certificate_key   /usr/local/etc/v2ray/privkey-grpc.pem;
  ssl_session_timeout 1d;
  ssl_session_cache shared:MozSSL:10m;
  ssl_session_tickets off;

  ssl_protocols         TLSv1.2 TLSv1.3;
  ssl_ciphers           ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:DHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-GCM-SHA384;
  ssl_prefer_server_ciphers off;

  server_name           mydomain.com;

  location / {
	root	/usr/share/nginx/html;
	index	index.html index.htm;
  }
  error_page 	404	/404.html;
  error_page	500 502 503 504 /50x.html;
  location = /50x.html {
	root	/usr/share/nginx/html;
  }

  location /GunService/Tun {
      if ($request_method != "POST") {
        return 404;
    }

    grpc_socket_keepalive on;
    grpc_intercept_errors on;
    grpc_pass grpc://<IP_ADDRESS>:12345;
    grpc_set_header Upgrade $http_upgrade;
    grpc_set_header Connection "upgrade";
    grpc_set_header Host $host;
    # Show real IP in v2ray access.log
    grpc_set_header X-Real-IP $remote_addr;
    grpc_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
  }

    location /wspath {
        if ($http_upgrade != "websocket") {
          return 404;
        }
        proxy_redirect off;
        proxy_pass http://<IP_ADDRESS>:54321;
        proxy_http_version 1.1;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Connection "upgrade";
        proxy_set_header Host $http_host;
	proxy_set_header X-Real-IP $remote_addr;
	proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
    }
}

//Nginx错误日志
2022/03/02 14:11:12 [error] 306#306: *58 upstream rejected request with error 1 while reading response header from upstream, client: 172.69.*.*, server: mydomain.com, request: "POST /GunService/Tun HTTP/1.1", upstream: "grpc://<IP_ADDRESS>:12345", host: "mydomain.com"

//Nginx访问日志
172.70.*.* - - [02/Mar/2022:14:10:00 +0100] "GET /wspath HTTP/1.1"<PHONE_NUMBER>1 "-" "Go-http-client/1.1" "我的公网ip"
172.69.*.* - - [02/Mar/2022:14:11:12 +0100] "POST /GunService/Tun HTTP/1.1" 502 494 "-" "grpc-go/1.41.0" "我的公网ip"

server {
  listen 443 ssl http2;
  ... ...
}


how's it work and could i use it in sprangular as a frontend ?

i'm using spree_multi_currency 2-4-stable,
and using sprangular  for frontend...
I think the error isn't in the code, it's maybe because I do not understand how to configure it.
initially run well if I just fills supported currencies with a single currency, and I can fill the nominal money in the prices page,
but I get an error message when trying to fill currencies supported by "EUR, USD, IDR" ...
this is the error message "undefined method `iso_code' for nil:NilClass",

can i fiils the supported currencies with a multiple currency ? how to configure it ?

I think the frontend course provides a dropdown to change the currency supported, how can i merge the overrides file with sprangular(frontend using angular) ?

thanks..

oh sorry my fault...
for  the first question,
the fills should be like this (EUR,USD,IDR), without space..
but the second still haven't an idea..


Please add multipart/form-data comment on docs

I lose several time because images upload from form with multipart/form-data type.
if you coment this on docs can be live saver for other people.
You plugin works perfect

Can you please elaborate?


Delete grid when all tiles are removed

When all the tiles of a grid are removed it should delete the grid.

Tried to reproduce doing the following:
Create a grid by placing tiles in space.

Tried to reproduce doing the following:

Create a grid by placing tiles in space
Check if the grid exists with the f3 menu
Delete tiles
Check f3 menu
Grid doesnt exist anymore

This is fixed


Test TensorFloat32 with conv2d

Please make sure that this is an issue related to performance of TensorFlow.
As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:performance_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):

import tensorflow as tf
import numpy as np
tf.config.experimental.enable_tensor_float_32_execution(False)
x_in = np.array([[
  [[2], [1], [2], [0], [1]],
  [[1], [3], [2], [2], [3]],
  [[1], [1], [3], [3], [0]],
  [[2], [2], [0], [1], [1]],
  [[0], [0], [3], [1], [2]], ]])
kernel_in = np.array([
 [ [[2, 0.1]], [[3, 0.2]] ],
 [ [[0, 0.3]],[[1, 0.4]] ], ])
x = tf.constant(x_in, dtype=tf.float32)
kernel = tf.constant(kernel_in, dtype=tf.float32)
out = tf.nn.conv2d(x, kernel, strides=[1, 1, 1, 1], padding='VALID')

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): CentOS Linux release 7.4.1708 (Core)
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): pip3 install tensorflow-gpu
Python version: 3.6.8
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: cuda11.1/cudnn8.0.5
GPU model and memory: GeForce RTX 3090

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
I ran this on an RTX 3090 with Nsight system. Compared with  tf.config.experimental.enable_tensor_float_32_execution(False), the  conv2d kernels don`t have higher performance with tf.config.experimental.enable_tensor_float_32_execution(True).
Describe the expected behavior
With tf.config.experimental.enable_tensor_float_32_execution(True), the conv2d kernels should have higher performance.
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

@WangTuoxyty
I have tried in colab with TF -gpu version 2.4 and i did not notice any major performance issue. Please, find the gist here.
Please, elaborate the issue with reproducible code if i miss something. It helps us in debugging faster. Thanks!

@WangTuoxyty
I have tried in colab with TF -gpu version 2.4 and i did not notice any major performance issue. Please, find the gist here.
Please, elaborate the issue with reproducible code if i miss something. It helps us in debugging faster. Thanks!

@WangTuoxyty
I have tried in colab with TF -gpu version 2.4 and i did not notice any major performance issue. Please, find the gist here.
Please, elaborate the issue with reproducible code if i miss something. It helps us in debugging faster. Thanks!

I saved the code to a file "test_conv.py", and execute command "nsys nvprof python3 test_conv.py" in a terminal, and this is a part of the output:
Generating CUDA Kernel Statistics...
CUDA Kernel Statistics (nanoseconds)
Time(%)      Total Time   Instances         Average         Minimum         Maximum  Name

96.7         1927958          28         68855.6           67072           71072  redzone_checker
0.9           18078           7          2582.6            2560            2592  void cudnn::cnn::conv2d_grouped_direct_kernel<float, float, float, float, float, float, true, false, 0, 1, 0>(cudnnTensorStruct, float const*, cudnnFilterStruct, float const*, cudnnConvolutionStruct, cudnnTensorStruct, float*, float, float, cudnn::reduced_divisor, cudnn::reduced_divisor, cudnn::reduced_divisor, cudnn::reduced_divis
0.5            9536           4          2384.0            2304            2432  void fft2d_r2c_16x16(float2*, float const*, int, int, int, int, int, int, int, int)
0.4            7200           2          3600.0            3584            3616  void fft2d_r2c_32x32<float, false, 1u, true>(float2*, float const*, int, int, int, int, int, int, int, int, int, cudnn::reduced_divisor, bool, int2, int, int)
0.3            6400           2          3200.0            3200            3200  void fft2d_c2r_32x32<float, false, false, 1u, false, false>(float*, float2 const*, int, int, int, int, int, int, int, int, int, float, float, cudnn::reduced_divisor, bool, float*, float*, int2, int, int)
0.3            5759           2          2879.5            2848            2911  void fft2d_r2c_32x32<float, false, 5u, false>(float2*, float const*, int, int, int, int, int, int, int, int, int, cudnn::reduced_divisor, bool, int2, int, int)
0.2            4895           2          2447.5            2431            2464  void gemmk1_kernel<float2, 256, 5, false, false, true, false, cublasGemvTensorStridedBatched, cublasGemvTensorStridedBatched, float2>(cublasGemmk1Params<float2, cublasGemvTensorStridedBatched, cublasGemvTensorStridedBatched, float2, biasType<cublasGemvTensorStridedBatched::value_t
0.2            4704           2          2352.0            2336            2368  void fft2d_c2r_16x16<float, false>(float*, float2*, int, int, int, int, int, int, int, int, int, int, float, float, int, float*, float*)
0.2            3135           2          1567.5            1567            1568  void gemmk1_kernel<float2, 256, 5, true, false, false, false, cublasGemvTensorStridedBatched, cublasGemvTensorStridedBatched, float2>(cublasGemmk1Params<float2, cublasGemvTensorStridedBatched, cublasGemvTensorStridedBatched, float2, biasType<cublasGemvTensorStridedBatched::value_t
0.2            3040           2          1520.0            1504            1536  void flip_filter<float, float>(float*, float const*, int, int, int, int)
0.1            1568           1          1568.0            1568            1568  void tensorflow::functor::ShuffleInTensor3Simple<float, 2, 1, 0, false>(int, float const*, tensorflow::functor::Dimension<3>, float*)
0.1            1440           1          1440.0            1440            1440  void tensorflow::functor::ShuffleInTensor3Simple<float, 0, 2, 1, false>(int, float const*, tensorflow::functor::Dimension<3>, float*)

@WangTuoxyty
I have tried in colab with TF -gpu version 2.4 and i did not notice any major performance issue. Please, find the gist here.
Please, elaborate the issue with reproducible code if i miss something. It helps us in debugging faster. Thanks!

I saved the code to a file "test_conv.py", and execute command "nsys nvprof python3 test_conv.py" in a terminal, and this is a part of the output:
Generating CUDA Kernel Statistics...
CUDA Kernel Statistics (nanoseconds)
Time(%)      Total Time   Instances         Average         Minimum         Maximum  Name

96.7         1927958          28         68855.6           67072           71072  redzone_checker
0.9           18078           7          2582.6            2560            2592  void cudnn::cnn::conv2d_grouped_direct_kernel<float, float, float, float, float, float, true, false, 0, 1, 0>(cudnnTensorStruct, float const*, cudnnFilterStruct, float const*, cudnnConvolutionStruct, cudnnTensorStruct, float*, float, float, cudnn::reduced_divisor, cudnn::reduced_divisor, cudnn::reduced_divisor, cudnn::reduced_divis
0.5            9536           4          2384.0            2304            2432  void fft2d_r2c_16x16(float2*, float const*, int, int, int, int, int, int, int, int)
0.4            7200           2          3600.0            3584            3616  void fft2d_r2c_32x32<float, false, 1u, true>(float2*, float const*, int, int, int, int, int, int, int, int, int, cudnn::reduced_divisor, bool, int2, int, int)
0.3            6400           2          3200.0            3200            3200  void fft2d_c2r_32x32<float, false, false, 1u, false, false>(float*, float2 const*, int, int, int, int, int, int, int, int, int, float, float, cudnn::reduced_divisor, bool, float*, float*, int2, int, int)
0.3            5759           2          2879.5            2848            2911  void fft2d_r2c_32x32<float, false, 5u, false>(float2*, float const*, int, int, int, int, int, int, int, int, int, cudnn::reduced_divisor, bool, int2, int, int)
0.2            4895           2          2447.5            2431            2464  void gemmk1_kernel<float2, 256, 5, false, false, true, false, cublasGemvTensorStridedBatched, cublasGemvTensorStridedBatched, float2>(cublasGemmk1Params<float2, cublasGemvTensorStridedBatched, cublasGemvTensorStridedBatched, float2, biasType<cublasGemvTensorStridedBatched::value_t
0.2            4704           2          2352.0            2336            2368  void fft2d_c2r_16x16<float, false>(float*, float2*, int, int, int, int, int, int, int, int, int, int, float, float, int, float*, float*)
0.2            3135           2          1567.5            1567            1568  void gemmk1_kernel<float2, 256, 5, true, false, false, false, cublasGemvTensorStridedBatched, cublasGemvTensorStridedBatched, float2>(cublasGemmk1Params<float2, cublasGemvTensorStridedBatched, cublasGemvTensorStridedBatched, float2, biasType<cublasGemvTensorStridedBatched::value_t
0.2            3040           2          1520.0            1504            1536  void flip_filter<float, float>(float*, float const*, int, int, int, int)
0.1            1568           1          1568.0            1568            1568  void tensorflow::functor::ShuffleInTensor3Simple<float, 2, 1, 0, false>(int, float const*, tensorflow::functor::Dimension<3>, float*)
0.1            1440           1          1440.0            1440            1440  void tensorflow::functor::ShuffleInTensor3Simple<float, 0, 2, 1, false>(int, float const*, tensorflow::functor::Dimension<3>, float*)

Hi @WangTuoxyty,
The benchmark you're using is very small so tf32 or not will not make a big difference, do you see the same issue when you try larger convolutions?

Hi @WangTuoxyty,
The benchmark you're using is very small so tf32 or not will not make a big difference, do you see the same issue when you try larger convolutions?

Hi @WangTuoxyty,
The benchmark you're using is very small so tf32 or not will not make a big difference, do you see the same issue when you try larger convolutions?

I change the shape of x_in from [1, 5, 5, 1] to [10, 5000, 5000, 1]，while it has the same result.

Hi @WangTuoxyty,
The benchmark you're using is very small so tf32 or not will not make a big difference, do you see the same issue when you try larger convolutions?

I change the shape of x_in from [1, 5, 5, 1] to [10, 5000, 5000, 1]，while it has the same result.

Any updates on this issue?
Here, I run into a similar situation.
I tried to test convolution's accuracy under TF-32 mode on my machine by comparing TF-32's and FP-32's computaiton results.
Firstly, I tested a simple MatMul example (as given here:https://www.tensorflow.org/api_docs/python/tf/config/experimental/enable_tensor_float_32_execution). TF-32's and FP-32's results are indeed different as expected. It indicates my environment supports TF-32 mode by default.
However, I used tf.nn.conv2d() method, fed with randomly generated float32 data, to test acc of convolution under TF-32 mode, but TF-32's and FP-32's results turned to be identical. It seems like tf.nn.conv2d() failed to activate TF-32?
Can someone please help with this?

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


Conversion of MSDNet to Keras

Hey! I am currently researching the opportunity of using your MSDNet network architecture as the backbone of our proposed ConvNet. Are you familiar if there have been made any efforts in converting your model to a format compatible with Keras yet?

Would it be possible to get access to the textfile 'model_definition.txt' for the model trained on ImageNet with 5 blocks and 4 steps?


[WIP] - Generate seccomp profile by tracing the syscalls made by the container

This pull request adds the ability for podman to generate seccomp profiles by tracing the syscalls made by the container. The generated profile would whitelist all the syscalls made and blacklist every other syscall.
The syscalls are traced by launching a binary by using the prestart OCI-hook. The binary started spawns a child process which attaches function enter_trace to the raw_syscalls:sys_enter tracepoint using eBPF. The function looks at all the syscalls made on the system and writes the syscalls which have the same PID namespace as the container to the perf buffer. The perf buffer is read by the process in the userspace and generates a seccomp profile when the container exits.
There are a few limitations to this approach:

Needs CAP_SYS_ADMIN to run
Compiles C code on the fly
Cannot use podman run --rm along with this ability

To build it, we need extra dependencies namely bcc-devel and kernel-headers for Fedora and bcc-tools and linux-headers-[..] for Ubuntu.
Interface:
sudo podman run --annotation io.podman.trace-syscall=[absolute path to the json file] IMAGE COMMAND

The profile will be created at the path provided to the annotation.
CIRRUS: TEST IMAGES

/ok-to-test
/approve

This commit adds the flag --genseccomp to podman which can trace the syscalls made by a container and create a container profile from all the syscalls collected

I think this should go under podman generate

This commit adds the flag --genseccomp to podman which can trace the syscalls made by a container and create a container profile from all the syscalls collected

I think this should go under podman generate

podman generate operates on running containers. I find it easier to just add a flag to podman-run and podman-create.
@rhatdan WDYT?

@weirdwiz, we need docs and bash-completion as well before we can merge.

And tests :^)

@vrothberg Yes, I'm on it :D

This commit adds the flag --genseccomp to podman which can trace the syscalls made by a container and create a container profile from all the syscalls collected

I think this should go under podman generate

podman generate operates on running containers. I find it easier to just add a flag to podman-run and podman-create.
@rhatdan WDYT?

I agree this needs to be set before running the container, so I don't think it should be in generate.

I'm somewhat inclined to say we should drop the flag and make it trigger on an environment variable in the container or similar - something we can document as part of the hook that won't require explicit intervention in Podman. We'd need to extend the hook to put the resulting profile in a better place, but I think that should be possible.

@weirdwiz, once a comment is fixed, please click on Resolve Conversation. This way it's easier to keep track of which comments are still valid. Once a conversation is resolved, the participants will be notified (e..g, via email) and can check.

@weirdwiz Needs a rebase.

/retest

If that's the case, then both the tests and makefile will need conditionals when the host doesn't have it
I added conditionals in the Makefile and the tests which checked if libbcc was present on the system, that passes for the F29 systems because libbcc get's installed, but the package in F29 repos is old and doesn't ship with the required headers.

Blast, that's too bad. So is libbcc on F29 simply too old to be used for your purpose?

Yes, on F30 it's 0.10.0-1 and on F29 it's 0.8.0-1.

@weirdwiz, @cevich, is there a way we can prevent libbcc from being installed on F29? I would be great to unblock testing this PR.

The system-test failure is #3870 so don't worry about that one.
[+0099s] # Error: error removing containers [e3d3a6aef941848214061073e9ddb1deee484d1c8784df8cb006158400f8f810] for image "ddbd497a49098deaa328ff9f58e7098184237c8d74fd43082c8678855c0fffcf": could not remove container "e3d3a6aef941848214061073e9ddb1deee484d1c8784df8cb006158400f8f810": remove /var/lib/containers/storage/overlay-containers/e3d3a6aef941848214061073e9ddb1deee484d1c8784df8cb006158400f8f810/userdata/shm: device or resource busy
[+0099s] # [ rc=2 (** EXPECTED 0 **) ]
[+0099s] # #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
[+0099s] # #| FAIL: exit code is 2; expected 0
[+0099s] # #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[+0099s] # $ ./bin/podman-remote rm -a -f
[+0099s] # $ ./bin/podman-remote rmi -f build_test

is there a way we can prevent libbcc from being installed on F29? It would be great to unblock testing this PR.

Yes this is possible with a condition in fedora_setup.sh; however, similar conditionals also need to be added to all affected tests.  IIRC, it installs okay on F29, so perhaps only the tests should not run on F29 (we have a utilities module with functions to check for OS and OS version)?  That would be easier than maintaining two conditionals.  Also because F29 will be going away soon-ish.

Yes this is possible with a condition in fedora_setup.sh; however, similar conditionals also need to be added to all affected tests.

I have added the condition to fedora_setup.sh in the previouos commit.

IIRC, it installs okay on F29, so perhaps only the tests should not run on F29 (we have a utilities module with functions to check for OS and OS version)?

The tests don't run when the hooks aren't installed. And the hooks don't install if the library is not present.

Excellent :smiley:

Do fedora 31 images exists yet?  IE Can we switch 29 to 31?

Restarted the failing jobs.

You need to add this patch to get make install to work.
install.patch.txt

After playing around with this for a while, I would also suggest the following patch.
trace.patch.txt
Sorting the syscalls makes it easier to view and do a diff between newer traces and older ones.
Don't hard code paths into your executable.
And lets not hard code podman into the annotation, since I might want to use this plugin with other tools.

Do fedora 31 images exists yet? IE Can we switch 29 to 31?

@rhatdan a VM image exists and boots (fedora-31-libpod-5654728358232064) however it fails testing (somewhat expected) and is based on a pre-release base-image (so, not safe for general consumption yet).  Ref: #3901

What's going on with the tests?

@cevich, do you know what's going on in the tests. I've never seen those errors before.

/test images

@weirdwiz Could you rebase this PR and repush it.

[[ "$PACKER_BUILDER_NAME" == "xfedora-30" ]] || \
    '$SCRIPT_BASE/build_release.sh |& ${TIMESTAMP}'
/tmp/scripts71c483f15fb90badb37c5821b6d95526.sh: line 6: $SCRIPT_BASE/build_release.sh |& ${TIMESTAMP}: No such file or directory

Restarted the (flaked) tests. Good job in getting in resolving the package issues, @weirdwiz !

Closing the PR as we created a dedicated project for the OCI hooks: https://github.com/containers/oci-seccomp-bpf-hook/
Thank you so much, @weirdwiz, for your great work! Looking forward to continue working with you over at https://github.com/containers/oci-seccomp-bpf-hook/ :rocket:

Thanks for the help and mentorship @vrothberg @rhatdan, wouldn't have been possible without it!


Variable config.default_language not found

According to this issue on Zola

@oltd Any chance this could get merged? I had the same issue fixed by overriding the content block in a template :eyes:

@peterkos Thanks for the quick reminder. I will merge and move the repo to my actual user this weekend.


🔴 Ecosystem Project Idea: Voting Badge Attestation Visualizer

What is an Ecosystem Project Idea?
An Ecosystem Project Idea is an idea for a project that someone could build within the Optimism ecosystem. As opposed to an Ecosystem Concept or an Ecosystem Idea, an Ecosystem Project is generally more fleshed out and corresponds to a relatively clear product to be built.

Summary
This project is for creating a frontend that allows users to explore how RetroPGF voting badges are distributed.
Recently, the voting badge distribution for RetroPGF round 3 has kicked off - you can find the full announcement here 👈
To drive transparency and understanding it would be valueble to visualize how voting badges are distributed. Badgeholders are selected through a multiple selection methods.
@smartcontracts prev built a frontend that allows you to visualize a specific attestation schema. You can find the repo here https://github.com/smartcontracts/coolgraph 👈

This project can pick up on the existing visualizer and make minor changes to visualize the voting badge distribution or add new features that make this a useful tool for visualizing badgeholder attestations and attestations at large.
Resources

Badgeholder EAS schema,

I deployed a version of it on Goerli for experimentation here

RetroPGF round 3 voting badge distribution
RetroPGF round 2 voting badge distribution
Get nerdsniped on attestations

OP Labs or Optimism Foundation Contact: Jonas (gh: @JSeiferth, TG/Discord: @jonassft)
Possible Features

Basic: Make changes to coolgraph to display badgeholder attestations and host it to be available to users.

If the refferedMethod is "badgeholderChoice", the source should be the referredBy address and the target the attestation recipient
if the refferedMethod is not badgeholderChoice, the source should be the refferedMethod(e.g. Foundation Choice, Past Badgeholder, Token House Elected or RetroPGF Recipient)

Extended: Display how voting badges were distributed over multiple rounds (round 2 & round 3 + future rounds)
Extended: Allow to discover the path of a specific voting badge - e.g. I can see how a specific badgeholder attained a voting badge and the relevant social graph
Extended: Display the Optimist NFT associated with each address
SuperFeature: Allow for the visualization of any attestation by enabling users to input any EAS Schema
SuperFeatureExtended: Allow for the visualization of any attestation schema by enabling users to input any EAS schema and select arbitrary data fields to be visualized.

Impact

This can help drive understanding in the Citizens' House of how badgeholders are selected
This drives understanding of Optimism's identity layer
This could be the basis of a visual attestation explorer, a useful tool for users to interact with Optimism's identity layer

Oh this looks interesting, would love to work on this!

hey, folks - how does the assignment for Ecosystem Project Ideas work? can you point me to any docs/links? just started to look into this and would love to contribute.

Base configuration is almost done. Just need few more days :)

I am back!
I finished the basics of the code:
https://attestation-visualizer.vercel.app/
Repo is still private, it has some sensitive info in there. Will be public in a few days...!

Awesome let me know when it's public 👍
On Sun, Sep 3, 2023, 12:48 AM Xander @.***> wrote:

I am back!
I finished the basics of the code:
https://attestation-visualizer.vercel.app/
Repo is still private, it has some sensitive info in there. Will be public
in a few days...!
—
Reply to this email directly, view it on GitHub
https://github.com/ethereum-optimism/ecosystem-contributions/issues/107#issuecomment-1703965895,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARL6R275CW7XZMWX35L4QZ3XYPAVTANCNFSM6AAAAAA3SLYTJA
.
You are receiving this because you are subscribed to this thread.Message
ID: <ethereum-optimism/ecosystem-contributions/issues/107/1703965895@
github.com>

Hola! It is public :star2:
https://github.com/xvoorvaa/attestation-visualizer

Awesome!
On Fri, Sep 8, 2023, 12:11 AM Xander @.***> wrote:

Hola! It is public 🌟
https://github.com/xvoorvaa/attestation-visualizer
—
Reply to this email directly, view it on GitHub
https://github.com/ethereum-optimism/ecosystem-contributions/issues/107#issuecomment-1710873817,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARL6R24JE3D2AMUDW3ANERTXZJIC5ANCNFSM6AAAAAA3SLYTJA
.
You are receiving this because you commented.Message ID:
@.***
com>

@JSeiferth would you be able to make a few attestations that will be used in real scenarios?
You already talked about it in here:

Basic: Make changes to coolgraph to display badgeholder attestations and host it to be available to users.
If the refferedMethod is "badgeholderChoice", the source should be the referredBy address and the target the attestation recipient
if the refferedMethod is not badgeholderChoice, the source should be the refferedMethod(e.g. Foundation Choice, Past Badgeholder, Token House Elected or RetroPGF Recipient)
Extended: Display how voting badges were distributed over multiple rounds (round 2 & round 3 + future rounds)

@xvoorvaa

What do you mean by creating attestations that will serve real-world scenarios?
Only attestations that are issues by 0x621477dBA416E12df7FF0d48E14c4D20DC85D7D9 (Optimism multisig) are authentic, see the attestations we recently issued here

Added some new features. It now looks pretty stable. I have a few more features I would like to add, what about you @JSeiferth ?


Create PLY reader class

Similar to the reader class for edge lists, this reader should handle PLY files. This gives us the opportunity to specify arbitrary simplicial complex implementations that may be stored in there.

Fixed; the new reader cannot handle all existing PLY files (yet) but it's a step forward.


markdown not displaying after arviz import

Describe the bug
First of all thanks for the work in developing marimo, I yet have to get the hang of it but I was quite dissatisfied with jupyter notebooks and I feel like marimo addresses the main concerns I had (plus some others I didn't know I should have been concerned with!).

After importing the arviz library (I'm using it to analyse the output of probabilistic models from PyMC), markdown outputs (either using mo.md or markdown cells) are not displayed and instead of that I get "Html()".

I imagine the import is also executing some code that alters the default behaviour. As a quick fix, is there a way for marimo to force back the original state (I'll get back to you if this breaks up some of arviz functionality).
python == 3.10.15
arviz == 0.20.0
Environment
{
"marimo": "0.9.11",
"OS": "Windows",
"OS Version": "11",
"Processor": "Intel64 Family 6 Model 154 Stepping 4, GenuineIntel",
"Python Version": "3.10.15",
"Binaries": {
"Browser": "129.0.6668.101",
"Node": "v20.14.0"
},
"Dependencies": {
"click": "8.1.7",
"docutils": "0.21.2",
"itsdangerous": "2.2.0",
"jedi": "0.19.1",
"markdown": "3.7",
"narwhals": "1.10.0",
"packaging": "24.1",
"psutil": "6.1.0",
"pygments": "2.18.0",
"pymdown-extensions": "10.11.2",
"pyyaml": "6.0.2",
"ruff": "0.7.0",
"starlette": "0.41.0",
"tomlkit": "0.13.2",
"typing-extensions": "4.12.2",
"uvicorn": "0.32.0",
"websockets": "12.0"
},
"Optional Dependencies": {
"pandas": "2.2.3"
}
}
Code to reproduce
import arviz as az
import marimo as mo
mo.md("# Welcome to marimo! 🌊🍃")

Thank you very much for the quick response!


[LanguageServices] Language services need to support )__VSHPROPID2.VSHPROPID_IntellisenseUnknown  for progression to work on fresh VS instance

So it turns out now that the regression is in core language services not supporting hier.GetProperty((uint)VSConstants.VSITEMID.Root, (int)__VSHPROPID2.VSHPROPID_IntellisenseUnknown , which results with whole progression not working (including classes and methods under *.cs files) when solution is opened in a fresh VS instance.
There two different logics in progression to get projects into cache:

On fresh VS instance they get projects form solution and check if they are supported or not  - it is not. Then it check if there is a supported “Intellisense type” – a guid that progression recognizes. It returned me a collection of 4 guids:

http://index/#Microsoft.VisualStudio.Progression.CodeSchema/Utils/ProjectHelper.cs,337

           intellisenseTypes        Count = 4        System.Collections.Generic.List<System.Guid>

           [0]        {c7fedb89-b36d-4a62-93f4-dc7a95999921}        System.Guid    <- CSharp http://source.roslyn.io/#Microsoft.VisualStudio.LanguageServices/Guids.cs,26

           [1]        {12c8a7d2-4681-11d2-b48a-0000f87572eb}        System.Guid  <- VB

           [2]        {12c8a7d2-4681-11d2-b48a-0000f87572eb}        System.Guid

           [3]        {c7fedb89-b36d-4a62-93f4-dc7a95999921}        System.Guid

However when it tries to match those guids with project it query )__VSHPROPID2.VSHPROPID_IntellisenseUnknown property from IVsHierarchy, which fails for core project at the moment: http://index/#Microsoft.VisualStudio.Progression.CodeSchema/Utils/ProjectHelper.cs,845

When solution is closed and reopened in the same VS instance progression has different code path for adding projects to the cache: it just adds project that it receives form OnProjectAdded event and does not do any IsSupportedChecks – that’s why it does work in this case for Dependencies node, but it still does not fork for *.cs files(!).

So it looks like core language services need to implement __VSHPROPID2.VSHPROPID_IntellisenseUnknown  for this scenario to work, since progression logic seems to be too complex to touch in this case

What is the net effect of this bug? I see the dependencies node show up for my projects with the new LS.

graphnodes for deeper hierarchy are not showing up and class/methods nodes are not showing up for *.cs files at all

Thanks - I'll look into this.

Okay, I looked into this and I do not believe that we should be returning an instance of ICSharpProjectRoot - as we don't implement this since the rewrite of the language service. Every usage I saw of this outside of the language service integration, was using it solely to sniff C#/VB projects. The three usages were:

CSLanSvcProvider in progression to light up for C#
ProjectLanguageHelper to sniff C#/VB
CSharpGraphcProvider to light up for C#.

This explains the logic as to why the C#/VB nodes under .cs/vb that aren't showing. It doesn't explain to me why Dependencies nodes aren't showing up. From what I can see, They just depend on the DependenciesTree capability. @abpiskunov What's cause this to know show up?

@davkean i tried to explain the flow in my original repro , but was not clear I guess .. Let me try again:

when new VS instance starts and progression initializes cache, it tries to get projects from solution and does check if project supported or not.
currently cs/vb core projects are unsupported because of that issue.
thus when capability check happens on fresh vs instance - projects cache in progression is empty and no check happens at all

when you close and reopen solution in the same VS instance, cache is updated , since on reload their cache adds projects differently comparing to how they are added on initial cache creation time: they just listen OnProjectAdded event and add project to the cache without any compatibility checks. This time when capability check happens , our project is in cache and is checked for capability.

Can you point me the compatibility check? Given you've got a project capability - that should be the check, not whether it has a recognized VSHPROPID_IntellisenseUnknown or not.

that is the problem - we don't have a project to check capability since it is not in the progression cache.

I'm asking, where this code lives:

when new VS instance starts and progression initializes cache, it tries to get projects from solution and does check if project supported or no

http://index/Microsoft.VisualStudio.GraphProviderPackage/R/528a66667f3e8fd8.html  its in this class , however index is not updated , check the actual class in vso

@abpiskunov and I talked offline, there's two issues:

The C#/VB graph providers need to be updated to use capabilities: https://github.com/dotnet/roslyn-project-system/issues/592.

The caching logic for projects should be updated to look for project's with matching capabilities.

Fix checked in today


How it use with typeScript&

I got such error

what should I do?

I create file d.ts

But it's still not working


Support dired

At the moment dired is not really themed correctly

Hi @noaccOS :wave:, thanks for your contribution :+1:
I've added it to the backlog, but everyone can feel free to submit a PR 😄

@noaccOS,
Why does your dired buffer look so strange colors? Mine looks nothing like that...
Mine looks very consistent with Nord theme:

@TRSx80 I don't know, I have set nord as the Doom Emacs theme (I'm using that distribution) and it was the normal GUI application, not the daemon in which I know the theme has problems

You have any old themes set in Custom? Go to menu (or F10) -> Options -> Customize Emacs -> Custom Themes and tell me if you see anything checked. If so, un-check it.
How are you loading nord-theme?

@TRSx80 Nope, I only have nord

I'm setting the theme with (setq doom-theme 'nord) in ~/.doom.d/config.el

Are you using nord-theme or doom-nord-theme?

On Apr 16, 2020, at 6:07 AM, TRS-80<EMAIL_ADDRESS>wrote:

You have any old themes set in Custom? Go to menu (or F10) -> Options -> Customize Emacs -> Custom Themes and tell me if you see anything checked. If so, un-check it.
How are you loading nord-theme?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

@articuluxe nord-theme
It seems setting the theme to doom-nord fixes dired, it might be an issue with doom emacs
Thank you for your support


SQL line comments start with "--"

SQL line comments start with "--" unless it's explicitly something else (i.e. // or #). Currently lineComment in the SQL mode is set to null whenever there isn't an explicit exception, which forces typical SQL modes to only do block comments.

Thanks for your pull request! As far as I see, -- is indeed one of the most common and portable ways to have a line comment in SQL. It already seems to be supported in Line 74ff, though. Did you try it, for example on the CodeMirror website?

This change affects lineComment as consumed by the official comment plugin.
Right now, hitting "Cmd+/" toggles a block comment (even on languages which support --  line comments). This pull request toggles the line comment.

I see! I suppose the white-space padding for MySQL is not necessary since it is automatically added by the comment plugin. I think it makes sense to untangle what a dialect supports and what is used for lineComment, or at least make lineComment configurable. Since --  is so portable I would think it makes sense to use it per default in all dialects.

I think this is fine as it is. Merged as cb01fa18


esp_https_ota: add user_ctx to decrypt_cb (IDFGH-6924)

This makes the decryption layer easier to use in C++ wrappers, or whenever you want to avoid a global.
Without this you're forced to make a global variable for the esp_decrypt_handle_t for pre-encrypted OTA (instead of a member variable in the case of a C++ wrapper).

Thanks for your contribution.

sha=e47419374c8b5bdd5d4d0245e84233bb99bf6068


Build pipeline

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: dcinotti sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


\vec{} with subscripts and superscripts spacing (again)

It has been fixed in #40 but the spacing is too large again:
$\vec{p}_1 ~ p_1$

Note also different height for the subscript.

f25e092


players.json missing 2021 rookies

Hey, having fun with this client. Noticed this years rookies aren't in players.json yet after trying to search for them. Just letting you know you.

I'll make a release with updated players soon. You can always update the internal list of players at runtime by calling NBA.updatePlayers()

I'll make a release with updated players soon. You can always update the internal list of players at runtime by calling NBA.updatePlayers()

Weird! the players endpoint only seems to be returning the first 150ish players, rather than the 450ish you'd expect (30 teams * 15 spots)

Weird! the players endpoint only seems to be returning the first 150ish players, rather than the 450ish you'd expect (30 teams * 15 spots)


Chart with a ChartRangeFilter control, flashes on re-render

I have a Linechart with a ChartRangeFilter control. I am implementing this a live line chart, where in every 30 seconds, the data prop gets updated and the chart is re-rendered.
The problem is that, whenever the Chart re-renders, it first renders as if there is no range control on it, and then afterwards the range control constraints are applied. This causes the chart to flash.
See an example in this sandbox where I am simulating updating the state every one second:
https://codesandbox.io/s/reactgooglechartsdaterangessliderexample-wvr2s?fontsize=14
Would appreciate any help on this.
Thanks.

I'm also experiencing this. Does anyone know a workaround?

I faced this issue also. Any updates? Workaround?


When I go to Add Member from Cluster/Project's member list page, default cursor to Member field

Rancher versions: 2.0 master 3/8
Steps to Reproduce:

Create a cluster
Go to Cluster and go to Member list apge
Click on Add Member

Results: No focus of cursor.  Default focus should be Member field.  Same with Add Project Member page from Project's member list page.

Version - 2.0 master 3/19
Verified fixed


[question] Recommendations for low-level pkgs not using github.com/pkg/errors

RE: https://twitter.com/davecheney/status/758764120468357120 //cc @davecheney
What is your recommendation for low-level pkgs that don't have (and likely won't ever have) any 3rd party dependencies, ie. DB drivers? Should they return errors of certain types satisfying behavior, ie. _, ok := err.(db.ErrTemporary)? Or do you have any other suggestions?

yes. Writing an error type that implements temporary is only a few lines of code.

Thanks @davecheney!


Service map for STLT-facing features

Problem statement
As a STLT who uses Reportstream to ingest data into their state surveillance system I want to be able to track and monitor (i.e. see and access) information on the data that is being sent to me through Reportstream, what issues there are with the data, how frequently the data is being sent, and by whom (what facilities including stats on that facility).
As a product, ReportStream needs to be tracking and displaying test result metrics and progression in ReportStream.
To address this problem, RS needs to first understand the scope of all services that need to be built, reused or updated given the current services available.
What you need to know
Mural board with feature break-down for this initiative
https://app.mural.co/t/primedatainput6410/m/primedatainput6410/1660849046968/e257020850ab71f57b31120e27ec06203ae9c22b?sender=u3fea607b46e84058d3224917

Design has examples of service maps from CSV upload and support

Acceptance criteria

[ ] Do it in Mural! (ex: support or CSV upload blueprints)
[ ] User type(s) are indentified. Currently: [Internal/admin, STLT, sender]
[ ] Outlines what each user type wants to do/learn/etc, including ...

[ ] How STLTS can view list of currently connected senders
[ ] How STLTS can see daily activity per each sender
[ ] How STLTS can get help/take action when any problems arise

[ ] Goal of this ticket is to get enough info for the MVP; doesn't need to be comprehensive service plan!

To do

[x] Create Mural board
[ ] ...
[ ] Get feedback from Andrea & Victoria

@a-chappelear @drew-usds @HeatherRienks - This ticket is created as a shell..will need more details in pre-refinement.

@drew-usds and @victorialb-usds will own this ticket, per Design Sync on 8/25.

@drew-usds @victorialb-usds - we need to refine this ticket so we can have a clear understanding of the outcome of this ticket.

@bgantick - any specific info that is needed from an Eng perspective on this ticket?
cc @a-chappelear

@drew-usds @a-chappelear updated the problem statement. To-dos may need to be added.

Began mural here: https://app.mural.co/t/primedatainput6410/m/primedatainput6410/1661979707820/db6b8a08700ccd21fb842da7ac3fa61a476d6d02?sender=u4a60651bc33557d542d18858

@victorialb-usds @drew-usds - Hoping that @fmccaf1 could help you with this ticket!

@drew-usds @fmccaf1 the journey maps are done (MVP) and I can work on the blueprint on Monday and perhaps we can discuss this at our sync which I think needs to move a bit b/c of meeting conflict. @fmccaf1 if you want to co-work on the blueprint Monday LMK.

Moving this to Product Backlog, as it is not tracking as part of current sprint work.

@a-chappelear @drew-usds @fmccaf1 think we can wrap this up. I am sure there are things that need to be added/moved. Your experience with blueprint and service design needed. There is a key that indicates the colors and I have made notes on the side about next steps this does not include answering all the questions in the pink post-its.

Noting to schedule in research to understand users internal and external is needed and then usability of features as they are developed.

@HeatherRienks - can we schedule a review of this with the entire team sometime next week?

@RakshindaAslam - yes, I will coordinate with the Design Crew to review this with the team.

I connected w/ Berni about getting O&O's eyes on this to fill in some gaps. We'll try to get together briefly on Friday and if we need more time (I think we will), then we'll continue the convo next week. @victorialb-usds I'm assuming you're interested in coming too so I'll make sure you're added to everything!

Some summary points:
Doing this journey maps and blueprint revealed

Too many tasks in the original ticket to put on the service blueprint was too many to answer the questions in the ticket
Many of the pieces in the map are future state, that is OK to lay out where we are going AND we often have the information to make the future state actions, expose the information possible
STLTs are getting things done outside of Reportstream/in different ways that we need to understand better (e.g. research roadmap)
O and O are doing the lions share of data monitoring and resolution manually (need to understand this more see @fmccaf1 above)
We have many questions about how things are currently done without knowing where these are documented or there is a need to document them (this can be added to a research roadmap and will be somewhat answered by what @fmccaf1 mentioned above)
There is over lap with the story map; this visual adds.... in future discuss relationship between different steps

To do for future:

Break up the blueprint more

Next:

Start with the daily index as priority feature to discuss next steps as team/product and ID tasks to ticket
Create a Research roadmap: doing this brought up many questions with a priority on understanding what is currently actually happening for users to accomplish the tasks outlined in the service blueprint talk about what does and does not exist; sessions w O and O and FM
Do a cross disciplinary feature discussion of daily data to make a decision on next steps and what each discipline for this specific work will do as well as will do to move towards some of the next work laid out. (what @HeatherRienks is scheudling)

https://app.mural.co/t/primedatainput6410/m/primedatainput6410/1661979707820/db6b8a08700ccd21fb842da7ac3fa61a476d6d02?sender=u4a60651bc33557d542d18858

Link to recording of @victorialb-usds sharing with the team on 10/5/22
https://us06web.zoom.us/rec/share/y94OLZIC6LF4Qaln2cu7wQPMH8Ppn0XZl56rWZofuV9bblWqMbDnNwgHvYKdpSnE.icknIn7sWUUEWnCw?startTime=1664989532000


"smartStep" skipped frames are not grayed out

I'm seeing that frames skipped by smartStep are not grayed out, but frames from skipFiles are. This is in 1.30. The DA is sending the right thing and you can see this info in the tooltip.

Here's an example of DA output (not from the screenshot)
			"id": 1065,
			"name": "(anonymous function)",
			"source": {
				"name": "nodeDebugAdapter.js",
				"path": "/Users/roblou/code/vscode-node-debug2/out/src/nodeDebugAdapter.js",
				"origin": "(skipped by 'smartStep')",
				"presentationHint": "deemphasize"
			},
			"line": 10,
			"column": 71
		}, {
			"id": 1066,
			"name": "__awaiter",
			"source": {
				"name": "nodeDebugAdapter.js",
				"path": "/Users/roblou/code/vscode-node-debug2/out/src/nodeDebugAdapter.js",
				"origin": "(skipped by 'smartStep')",
				"presentationHint": "deemphasize"
			},
			"line": 6,
			"column": 12
		}, {
			"id": 1067,
			"name": "terminateSession",
			"source": {
				"name": "nodeDebugAdapter.js",
				"path": "/Users/roblou/code/vscode-node-debug2/out/src/nodeDebugAdapter.js"
			},
			"line": 492,
			"column": 16
		}, {
			"id": 1068,
			"name": "chrome.Runtime.on.params",
			"source": {
				"name": "nodeDebugAdapter.ts",
				"path": "/Users/roblou/code/vscode-node-debug2/src/nodeDebugAdapter.ts"
			},
			"line": 308,
			"column": 22
		}, {
			"id": 1069,
			"name": "emitOne",
			"source": {
				"name": "events.js",
				"path": "<node_internals>/events.js",
				"sourceReference": 1001,
				"origin": "read-only core module (skipped by 'skipFiles')",
				"presentationHint": "deemphasize"
			},
			"line": 116,
			"column": 13
		}, {
			"id": 1070,
			"name": "emit",
			"source": {
				"name": "events.js",
				"path": "<node_internals>/events.js",
				"sourceReference": 1001,
				"origin": "read-only core module (skipped by 'skipFiles')",
				"presentationHint": "deemphasize"
			},
			"line": 211,
			"column": 7
		}, {

Looking at the code I see no difference in handling these. Since all of them have a "presentationHint": "deemphasize", so they are equel to the vscode frontend.
Can you please provide a reproducable sample so I can investigate further on my machine?
An alternative is that you just put a brekapoint here and check why the disabled class does not get toggled.

Problem seems to come from here:

source.presentationHint is not read

Good catch, however I think that is fine.
Please note that we have the presentationHint both on the stackFrame and on the Source which is somehwat confusing.
In this particular case the source object contains the appropriate presentationHint and that is passed inside the stack frame properly. When we are rendering the stackFrame at a code pointer I gave above, we are acutally checking the presentationHint of the Source object inside. And that one should be correct in this case, right?

At that line in callStackView.ts, stackFrame.source.presentationHint is undefined. So it seems to be correct when the object is created but becomes wrong at some point between that and being rendered.

@roblourens can you provide some reproducable steps so I try to investigte more?
Thanks

I see this for all smartStep frames


New entry: FOSSology

Name
FOSSology
URL of homepage
https://www.fossology.org
URL of main code repository
https://github.com/fossology/fossology
Other relevant information
The general mailing list for this tool is<EMAIL_ADDRESS>

Can you please share a link to a suitable svg logo for fossology?


Adding logging when metadata is missing upon registration time [ENG-2438]

Purpose
Sometimes metadata goes missing when a draft is registered. Not sure why. Hopefully some logging will help.
Changes
Adding sentry logging when a registration is created but the draft has no associated metadata
QA Notes
This can't really be tested because we can't really reproduce it!
What are the areas of risk? N/A
Any concerns/considerations/questions that development raised? Registration metadata validation needs a good looking at.
Documentation
N/A
Side Effects
N/A
Ticket
https://openscience.atlassian.net/browse/ENG-2486

Closing for now as this doesn't really help much.

Closing for now as this doesn't really help much.


Add wrappers for the component data in unit tests

In the unit tests we have to mock component data with only few parameters.
Current ComponentData definition doesn't allow for it because
we have to give all class parameters.
We used to avoid that by creating protobuf message with only
necessary data and use it to create ComponentData.
But this approach is complex and not resilient for the changes in the
protobuf api.
This commit wraps ComponentData. Each parameter has default protobuf
value that will be used if no argument was given.

ci failure, otherwise lgtm


show pre-filled values for autocomplete

Description
Autocomplete needs to show the next list even when the user hasn't type a '.'
Fixes #1844
Type of change

New feature (non-breaking change which adds functionality)

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: invisble-dot

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
51.6 (-0.01)
32.53 (0.08)
29.83 (0.01)
52.09 (0)

:green_circle:
app/client/src/components/editorComponents/CodeEditor/index.tsx
73.68 (0.14)
53.98 (0.83)
56.67 (0)
73.74 (0.14)

:green_circle:
app/client/src/utils/autocomplete/TernServer.ts
44.78 (0.3)
30 (3.26)
31.48 (-1.17)
49.84 (0.37)

:red_circle:
app/client/src/utils/autocomplete/dataTreeTypeDefCreator.ts
62.37 (-18.58)
67.86 (8.77)
100 (0)
69.7 (-10.79)

The styling needs to be better. Long result names are very close to the data type on the left

/ok-to-test sha=590b463

/ok-to-test sha=d4da16c


Discovery documentation: some links not working

Not a big deal at all, but some of the links on the swarm/discovery Readme are no longer working.
$ curl https://github.com/docker/swarm/blob/master/discovery/API.md
{"error":"Not Found"}

The four links involved are here: https://github.com/docker/swarm/blob/f78c8054b7d660b2467063cb9ec42bce74f057de/discovery/README.md#docker-swarm-documentation-index

Created a pull request to fix them, thanks!


NAT source port metrics & table

Adds nat/stats which adds a module that computes stats for nat maps.
This uses the batched iteration of the nat map added in previous commits to count the number of allocated ports there are in each nat connection tuple: {source_ip, endpoint_ip, endpoint_port}.
This is necessary to monitor saturation of endpoint connections based on datapath allocation of source ports.
These are exported as the metric: max_nat_endpoint_connections
The "nat-stats" table in statedb, accessible via cilium-dbg statedb dump, ex:
root@kind-worker:/home/cilium# cilium statedb nat-stats
IPFamily   Proto    EgressIP                RemoteAddr                   Count
ipv4       TCP      <IP_ADDRESS>             <IP_ADDRESS>:4240             1
ipv4       TCP      <IP_ADDRESS>             <IP_ADDRESS>:4240            1
ipv4       TCP      <IP_ADDRESS>              <IP_ADDRESS>:4240              1
ipv4       TCP      <IP_ADDRESS>              <IP_ADDRESS>:4240              1
ipv4       TCP      <IP_ADDRESS>              <IP_ADDRESS>:6443              4
ipv4       ICMP     <IP_ADDRESS>              <IP_ADDRESS>                   6
ipv4       ICMP     <IP_ADDRESS>              <IP_ADDRESS>                   6
ipv6       TCP      [fc00:c111::2]          [fc00:c111::5]:4240          1
ipv6       TCP      [fd00:10:244:1::e8ce]   [fd00:10:244:3::6860]:4240   1
ipv6       TCP      [fc00:c111::2]          [fc00:c111::3]:4240          1
ipv6       TCP      [fd00:10:244:1::e8ce]   [fd00:10:244::b991]:4240     1
ipv6       ICMPv6   [fc00:c111::2]          [fc00:c111::5]               6
ipv6       ICMPv6   [fc00:c111::2]          [fc00:c111::3]               6

/test

/test

/test

/test

/test

/test

Tests are failing due to some dependency issues on the new nat map types in integration tests, working to get those working.

/test

/test

/test

/test

/test

/test

/test

/test

/test


[Blocked] 1385 collect stats on convert api

Description
Resolves https://github.com/delta-io/delta/issues/1385
Created for a second PR as a request https://github.com/delta-io/delta/pull/1401#pullrequestreview-1129045397
First PR sets the collectStatistics on convert to true by default with additional changes to the SQL statement.
This PR completes the DeltaTable API changes to disable collectStats by request.
How was this patch tested?
Unit tests. Added a few tests on this and on the first PR to covert this.
Does this PR introduce any user-facing changes?
Additional API to DeltaTable to disable collectStats.

Hi @amirmor1 - now that https://github.com/delta-io/delta/pull/1401 has been merged, want to continue on this?

Hi @scottsand-db , I've merged master, but since it was a while ago and we split to two PR's, it is possible that I forgot something on the way.

Hi @scottsand-db , no worries about the late review, its completely understanable.
Personally I don't need this option to be set to false, but the original request came from @MrPowers , so I suggest maybe he should advise on this.

@amirmor1, I see. Thanks for clarifying! Yup we can go ahead and close this then.


Fix/socket close nre

EngineIoClientDotNet 1.0.8 uses with SocketIoClientDotNet 1.0.8
Target build platform 4.5
It runs as mobile app built using Unity 2019.4.8f1 for iOS and Android
We have 34k NRE in the week for 22k users. After that error socket never restores connection.

2020-08-23 16:24:56.4563 [FATAL] Object reference not set to an instance of an object.
System.NullReferenceException: Object reference not set to an instance of an object.
at Quobject.EngineIoClientDotNet.Client.Socket.Close () [0x00000] in <00000000000000000000000000000000>:0
at Quobject.SocketIoClientDotNet.Client.Manager+<>c__DisplayClass51_1.b__2 () [0x00000] in <00000000000000000000000000000000>:0
at System.Action.Invoke () [0x00000] in <00000000000000000000000000000000>:0
at System.Action.Invoke () [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.ContextCallback.Invoke (System.Object state) [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.ExecutionContext.RunInternal (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx) [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.Tasks.AwaitTaskContinuation.RunCallback (System.Threading.ContextCallback callback, System.Object state, System.Threading.Tasks.Task& currentTask) [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.Tasks.Task.FinishContinuations () [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.Tasks.Task`1[TResult].TrySetResult (TResult result) [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.Tasks.Task+DelayPromise.Complete () [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.TimerCallback.Invoke (System.Object state) [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.WaitCallback.Invoke (System.Object state) [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.ThreadPoolWorkQueue.Dispatch () [0x00000] in <00000000000000000000000000000000>:0
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.WaitCallback.Invoke (System.Object state) [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.ContextCallback.Invoke (System.Object state) [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.ExecutionContext.RunInternal (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx) [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.ThreadPoolWorkQueue.Dispatch () [0x00000] in <00000000000000000000000000000000>:0

https://github.com/Quobject/EngineIoClientDotNet/issues/69

@mattqs I have added some description of a reason why I create a merge request


Refactored create_keyspace into create_model.

Not perfect, but it'll cause a fewer stack traces.
Also, I removed pep8 errors in files I modified.

Coverage increased (+0.86%) to 52.11% when pulling 837c148c96706d96a44501a3cae684866de8f768 on simlay:refactor_keyspace_creation into 61d8241fd4babc3c79ced0310e876753dd072480 on Knotis:master.

Coverage increased (+0.81%) to 52.06% when pulling 73eac2b627a0a30d0a2eb8bd17afed8e9f8f6933 on simlay:refactor_keyspace_creation into 61d8241fd4babc3c79ced0310e876753dd072480 on Knotis:master.

Coverage increased (+0.6%) to 51.85% when pulling c8a99c18598af1e67ce6acc03f1a8c47b8d7521c on simlay:refactor_keyspace_creation into 61d8241fd4babc3c79ced0310e876753dd072480 on Knotis:master.


mouse support for EventClosures

Hey, thanks for the PR 👍
As I understand it, you just added 3 lines.
Please remove all the unnecessary whitespace changes.

I will sometime after work this evening. I'm often unavailable on the
weekends, traveling to  see family in areas where service is poor or
nothing.
On Mon, Sep 10, 2018, 05:21 Frotty<EMAIL_ADDRESS>wrote:

@pleonar3 https://github.com/pleonar3 will you update the PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/wurstscript/WurstStdlib2/pull/113#issuecomment-419846705,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANM5OJaAqApvfNJXirGSSLz678IUj_eDks5uZi8bgaJpZM4WbsGA
.

Thanks, I'm sorry I've been busy. Work and other troubles
Take care
On Tue, Sep 11, 2018, 08:21 Frotty<EMAIL_ADDRESS>wrote:

I added it now, thanks for the PR again, now onto Frentity 😃
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/wurstscript/WurstStdlib2/pull/113#issuecomment-420254397,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANM5OHBg20obmiA8JNvoR2OJr-9HJIwDks5uZ6rkgaJpZM4WbsGA
.


Test Atlas apps on v19

Towards https://github.com/giantswarm/giantswarm/issues/23014
We need to test our apps and make sure networking still works on the AWS v19 beta release
From the top of my head:

[x] observability-bundle

[x] prometheus-operator-app

[x] kube-state-metrics

[x] promtail
[x] prometheus-agent

[x] datadog-app
[x] node-exporter-app
[x] grafana-app
[x] fluent-logshipping-app
[x] goldilocks-app
[x] keda-app
[x] loki-app
[ ] mimir-app
[x] vertical-pod-autoscaler-app

Only apps that need ipBlocks in network policies are to be tested, that should reduce the list

Testing apps on a gauss WC

I just came back with it !

do we really need to test loki and mimir on v19 even though they're currently not released globally ? Because testing both of them would take a huge amount of time

I think loki makes sense because customers are using it but mimir not so much

Ok I'll go with Loki tomorrow then

how about mimir? 🙏

Mimir was added 2 weeks ago without a plan to be deployed into WCs at the moment so I think we're fine

Since it's still under development on our current setup I don't know if it's worth testing it on v19. But if you'd like I could at least make sure that it runs without major errors.

Finally I can assess with assurance that Loki is indeed working well on v19 with IRSA (going to update loki-app readme soon). So unless we absolutely want to try mimir as well I guess we can close this issue :)

I would close for now and we test mimir once we want to have it available for customers :)


support D16/D24/D32/D32S8 glGetTexImage emulation for non-nvidia device

added remap for depth_component24 to rgba32
made changes to allow eRemap_RGBA16 and eRemap_RGBA32 to be used
Is there any unforeseen consequences of removing the TextureCategory::DepthTarget flag from remapped textures? I am assuming that we are just trying to transfer the contents of the depth buffer to the windows client so it doesn't actually have to be a depth buffer right?

I don't think removing the DepthTarget flag will cause any serious problems like things crashing or not rendering. I'm not sure if this will have any impact on the UI or texture display - I guess the UI level doesn't see the local proxy texture properties, so it will still display it as grayscale instead of just red? If so then it might be OK.
I think this looks fine in principle although I'd need to test it to see if there are any knock-on effects, as the remapping currently has only been used for like-to-like (primarily just for remapping ASTC/ETC etc to RGBA8 which is the same set of channels, colour, etc).
Also currently you only have an implementation for the GL replay, but you'll need to implement it as well for D3D11 since on windows systems D3D11 will be used as the local replay API. D3D12/Vulkan don't have proxy support yet.

Ok I'll get D3D11 replay to work, just need a bit of time.

No the flag should still be added when relevant to create the proxy texture as close to the real thing as possible. It's OK to remove the flag when remapping because after remapping it's no longer a real depth format, but it shouldn't be blanket removed from all proxy textures.

Hi sorry for taking so long, but I have managed to do the remap on the device without a an explicit remap on the client side so it should be pretty transparent.
For the remap, I am using integer rendertargets and depending on the source format, write float or integer out. I have searched the spec and I can't find any mention of matching datatype between fbo and fragment output; and since this lowers the capability requirement, I went with this approach. If there is actually a requirement for fragment output type to the fbo format. I think that can be done as well, it will simply take more work to get all the components out of D32S8/D24S8.

Without going into a line-by-line review yet, I don't really agree with the direction this is going. There's a lot of hoops being jumped through to handle trying to pack the depth into an integer format. I guess this is to support devices where render to floating point isn't supported, but from an eyeball look roughly half of the consumer GPUs on Unity's stats should support it.
At some point there has to be a line drawn for a minimum spec and it seems reasonable to just require floating point render. Since RenderDoc is a developer tool not a user-facing one we can have a higher min spec. Requiring floating point render greatly simplifies the code as we can use the existing remap functionality, and that's more important than supporting less capable devices.
Also any remapping that happens like this should go through the existing remap path, not being applied behind-the-scenes in the emulate code. That should just be a thin shim layer to emulate missing GL functionality that can be implemented using other available GL functionality, which will work during capture or replay as needed. It shouldn't call out to the debug/replay code to do complex work.
FYI the spec does say that values have to match between the shader and the framebuffer. From the ES 3.2 spec, emphasis mine:

Color values written by a fragment shader may be floating-point, signed integer, or unsigned integer. If the color buffer has a signed or unsigned normalized fixed-point format, color values are assumed to be floating-point and are converted to fixed-point as described in equations 2.4 or 2.3, respectively; otherwise no type conversion is applied. If the values written by the fragment shader do not match
the format(s) of the corresponding color buffer(s), the result is undefined.

Hi thank you for finding the clause in the spec, I will make the change to use the appropriate format.
In order to make remapping any depth format into a D32FS8 useful, glGetTexImage needs to be able to retrieve the pixels to send to the client for the proxy textures. But since glGetTexImage is an emulated function on ES and requires NV_read_depth_stencil which seems to be only supported by NVidia devices, it restricts the feature's usefulness.
And in order to properly retrieve a D32FS8 format, my first approach was to try writing float bits into an integer buffer (which I learned is illegal to do). Once I got D32FS8 to work, it actually seems to take more work to do an explicit remap rather than an internal one, and hence all format remaps are done internally. And since the mismatched fragment output approach actually worked on the two Samsung devices I use, I thought it might be easier to just do all remap with integer format and get the benefit of lower spec. Now that I see it is illegal to have mismatched fragment outputs, I think I will have to do two remaps and retrieve from two different textures, and then stitch the data back together.
I understand your decision to stick with ES 3.2. The direction I am taking is purely based on the goal of viewing depth textures on non-NVidia OpenGL ES devices using RenderDoc.

I don't really understand the problem you're facing, I'm not sure how the issue is nvidia specific.
To check assumptions, here's my understanding:
In the 'simple' remote replay scenario, it goes something like this. When a texture is needed locally, the proxy does the following (in ReplayProxy::EnsureTexCached):

If the texture hasn't been cached before, fetch its metadata from the remote replay. This includes the format and anything else.
It calls the local dummy renderer to create an identical texture.
If the current data isn't cached, it fetches the bits from the remote replay and uploads to the local renderer.
For most textures on a GL remote, this boils down to the local renderer just calling glGetTexImage, or glGetCompressedTexImage for compressed textures. We can ignore MSAA for the purpose of this discussion.

This all works well, and we can then display the local texture with remote contents. For GLES since there is no glGetTexImage so we modify step 4 slightly as it's emulated fairly simply by creating an FBO and doing glReadPixels.
On android though, there can be a problem at step 2. If the remote replay supports a texture format that the local renderer doesn't like ETC then we can't create an identical texture.
So the solution is the remapping. When we create the proxy texture we decide if we want to remap it. We remap up to the next universally supported format, so we never truncate data - e.g. ETC will be remapped to RGBA8, ASTC with HDR support would be remapped to RGBA16F, etc.
The process now looks like:

If the texture hasn't been cached before, fetch its metadata from the remote replay. This includes the format and anything else.
Check if the texture needs to be remapped, and if so store the remapping properties for it.
It calls the local dummy renderer to create an identical texture with the remapped format.
If the current data isn't cached, it fetches the bits from the remote replay and uploads to the local renderer.
For most textures on a GL remote, this boils down to the local renderer just calling glGetTexImage, or glGetCompressedTexImage for compressed textures. We can ignore MSAA for the purpose of this discussion.
If we are remapping, we first use the existing render-to-texture code to render to a texture with the remapped format (currently only RGBA8 is supported), to 'bake out' the unsupported format, then call glGetTexImage on the resulting texture.

So the bits that get transferred to the local image are plain RGBA8 and it gets displayed without knowing that the remote texture is ETC (or whatever).
If I am correct, the problem you are encountering is that depth/stencil textures cannot be used with glReadPixels on anything but nvidia devices. However I don't think you need to have any complex solution here - if you send depth/stencil textures down through the remapping path, then even though they might be supported on the local renderer it still sidesteps the requirement to directly glReadPixels those textures - the remapping process will map them onto a texture you can read. This is basically what you had in the original PR if I remember correctly.
The remaining problem with that solution is that RGBA32F isn't supported as a render target on all devices. As far as I can see, the only reason to use integer textures is to try and work around that problem to support devices without float render capability. However it is required in ES3.2 and many ES3.0 devices support EXT_color_buffer_float which allows it there too - from my ballpark estimate it's about half of the consumer GPUs, and I expect that ratio to be better on developer GPUs. It's definitely not something that's only supported on nvidia GPUs - on nvidia GPUs, the code works as is today without any modifications since it can just read the data back directly.
So do I misunderstand some aspect of the problem? Is there any reason you can't detect lack of depth-readback when necessary and remap it to RGBA32F for the copy?

I have updated the pr with a version that conforms to the fragment output matching color buffer requirement, I do not have a problem complying to using floating point formats.
The reason an internal remap is done rather than an explicit one is because in order to remap D32FS8 properly, two passes are required because OpenGL doesn't allow reading depth and stencil in the same shader pass. And once the extra work is done for remapping the stencil, there is no need to have a proxy texture that is using a remapped format because we can construct the byte stream of D32FS8 exactly. This also allows the format between device and client to be as close as possible.
On the other hand, I can see how doing RemapDepthStencilToTexture inside _glGetTexImage can be ugly, but it does make emulation more complete and less reliant on extensions. If you don't think that's important I can move the depth remap logic inside GLReplay::GetTextureData and there will be no need for glEmulate to hold a pointer to GLReplay.

Doing two passes in the existing remap code is very simple. There's already a path to do multiple passes for 3D textures, rendering one slice at a time, so doing two passes separately for depth and stencil is no problem. The RenderTexture code already handles doing the right thing if you select red-only or green-only channels.
There might need to be some adjustment made to ensure the stencil values come through in the right range as expected, but that should be a significantly reduced scope compared to the current changes.
The problem with doing the remapping elsewhere is that it adds a lot of extra code complexity, and inter-dependencies between code that shouldn't need to be linked. If we add a new special remapping path that's separate to the existing code, then it's easy to forget or miss if you update the remapping - perhaps because we decide we want to let the local replay know about the original format, or if there is a bug to fix.
We're all on the same team so there isn't a need to add complexity to hide some details in one part of the code from another. Since we already have the concept of proxy textures and remapping then we should use it where it is useful. If there was no need for texture remapping anywhere else, and this depth-readback was the only time we needed to remap, then it might be more appropriate to 'hide' the details locally to GL. But since we already have very similar concepts elsewhere it is not a good idea to duplicate that effort in another place.

Do you mean eRemap_D32S8 should use RG32F for the proxy texture format? Or just simply add an eRemap_RG32F and remap all depth formats to that?

Formats should only be remapped if necessary if there's missing support on one side or another, but yes I'd suggest just remapping all depth formats up to RGBA32F - I'd recommend RGBA32F rather than RG32F since there might be implementations that have less support for 2 channel targets. It's less of an issue with 32-bit component formats (compared to R8G8 or something) since alignment will always be a 32-bit multiple, but it's still more likely to be unsupported.

Ok, I'll do what you suggest instead. But I do have other tasks at hand so it will probably take a bit of time. Thanks!

Currently, plain OpenGL have no problem retrieving the depth textures using glGetTexImage. So we probably don't want to do an unnecessary remap for OpenGL. Also, for devices that support the NV_read_depth_stencil extensions, we might not want to do the remap for them either. But since the decision to do remap happens on the client side, the client needs to be able to query the IRemoteDriver for the API type and the extensions it supports in order to decide whether to do remap or not. Currently it doesn't seem like such query exists for IRemoteDriver, should I add them or perhaps there is a way I am not aware of?

Yes you're right, in addition to the client-side check for if(m_Proxy->IsTextureSupported(format)) we need a way for the remote side to tell the client that a remap will be needed.
Since I think GLES will probably be the only API we need to worry about that's this limited, we can probably keep it simple. Rather than querying for extensions or API versions, if you just add a query to IRemoteDriver called bool NeedRemapForFetch(format) then it can return false trivially for all APIs except GLES, where GLES can check if the support is present to natively fetch depth. The proxy can call this function inside ReplayProxy::RemapProxyTextureIfNeeded so it would be something like: if(m_Proxy->IsTextureSupported(format) && !NeedRemapForFetch(format)).

Closing, replaced by PR #695.


process_replay: migrate panda states

Trying to regen the Prius route, but it doesn't enable. In the new segment I'm seeing planner errors, calibration incomplete, radar fault.

Can you post which PR this reverts partially? Helpful to go back through the history if we ever need to.

This was broken by behavioural change in https://github.com/commaai/openpilot/pull/28829. Before that regen did not use process replay and was manually replaying messages.

Can we get regen in CI first? This won't work on its own and there's a potentially better solution. Then we can merge fixes.


Failed to minify when build

Hi, i have problem when builing react app using this plugin. It's say can't minify the ./node_modules/react-google-charts/dist/index.esm.js:27 .
> cross-env REACT_APP_BUILD_ENV=production react-scripts build

Creating an optimized production build...
Failed to compile.

Failed to minify the code from this file:

 	./node_modules/react-google-charts/dist/index.esm.js:27

Read more here: http://bit.ly/2tRViJ9

Hey @gravitano,
Thanks for reporting that !
I set the target to es5 and published as 2.0.28.
It should let you compile successfully now !
Cheers !

Hey @rakannimer ,
I just tested the new version and it work like a charm.
Thank you!


Steam Friends UI fails to load

Steam has introduced new feature that reworks the Friends UI, it isn't loading and all the online features and game integration fail to work. A work around is to revert to the old one with the -nofriendsui option.
This issue happens whenever dxvi.dll and d3d11.dll are set to native. If you set it to builtin then native, it will load but dxvk won't work in that scenario.
Software information
Steam
System information

GPU: GeForce GTX 970
Driver: nvidia-vulkan-dkms 396.51.02-1
Wine version: wine-staging 3.13.1-1
DXVK version: dxvk-win64-bin 0.64-6

Works for me, please make sure to set up the 32-bit DLLs as well.

Both are installed. It could be that only 64-bit is affected.

Can you post wine console log or something? Right now this bug report contains pretty much no info and I don't have the slightest idea what your specific issue might be.

wine_log.txt
These lines seem relevant
0059:err:module:import_dll Library dxgi.dll (which is needed by L"D:\\Steam.wine64\\bin\\cef\\cef.win7\\libcef.dll") not found
0059:err:module:import_dll Library d3d11.dll (which is needed by L"D:\\Steam.wine64\\bin\\cef\\cef.win7\\libcef.dll") not found
0059:err:module:import_dll Library libcef.dll (which is needed by L"D:\\Steam.wine64\\bin\\cef\\cef.win7\\steamwebhelper.exe") not found

Did you install DXVK through the setup_dxvk32 or setup_dxvk64 scripts? If you only set them to native in winecfg, Wine won't be able to find the DLLs.

I ran setup_dxvk32 as well and same situation. Steam friends is unable to go online.

This appears to be a bug in wine without dxvk as well. It replicates with the d3dx11_43 too.
I'll go report it over there.

If it can't find the DLLs, something about your wine prefix is messed up. Please double-check if the dxgi.dll and d3d11.dll exist in $WINEPREFIX/drive_c/windows/system32 and $WINEPREFIX/drive_c/windows/syswow64, and that they point to the correct files.


Arcane Trader Bug

Arcane Traders have nothing for sale other than cloth or amber

Looks like it must be a conflict of some kind; anything in logs?

Maybe whatever mod is adding amber to them is removing the rest of the options

I searched the amber and found something. I think this might actually just be confusion the RPG arcane trader is not the same as the arcane goods merchant from Medieval Overhaul: Arcane Archaeologists (package: Ogam.MedievalOverhaul.ArcaneArchaeologists) which is in fact defined as a dedicated trader that only sells amber and cloth

With commonality 3 it's 3x more likely compared to the RPG ones

Yeah, looked into myself afterwards, we definitely need to patch that caravan because its far too frequent, unless we rebalance what they sell

Update, turns out the arcane archaeologists faction, which is the only friendly faction in the game, only has access to the "Arcane Caravan" - no bulk goods trader, no RPG flavour pack caravans. Ideally needs fixing asap otherwise eltex flow will be slow


Weekly PR

Fix #150 Conflicts with in-app-billing-service-aidl.jar

@borisspektor @refaelos, it's ready to merge.

@EugeneButusov please create a download_deps script here for IInAppBillingService.jar

@borisspektor, script download_deps was added.