Ability to Define Group Parameter with multiple included Suite-File

Problem:
If i run the Suite of suites specifying the Group parameter the field appears to be Ignored within each Suite.

IE
<suite-files> 		<suite-file path="xxx1.xml" /> 		<suite-file path="xxx2.xml" /> ... </suite-files>
I am defining Group Parameter Via Ant testng Task.
Each individual suite implements Tests and groups correctly.
If i run each Suite individually the Group parameter works as expected.
When i run the Suite of Suite the Group parameter appears to be ignored.
Has anyone else run into this and have a solution or workaround.
Bug #174 deals with 1 possible solution which i would rather be using and have had to work around for some time, Define Group at a Suite level and have all tests inherit.

@jmontanari Why did you close the issue? Did you find a solution?

@juherr
I ended up coming up with a hack that works for me. Define the Suites with a Variable for the Run target. Then in ant create a method that Replaces the variables on demand with hard coded suites i want to run. It is far from ideal and ends up having to copy the Group Block to every individual suite to make it work.
Define groups as Variables in the suite.xml
<test verbose="2" name="Something">
       <groups>
            <define name="All">
                <include name="Nightly"/>
            </define>
            <define name="Nightly">
                 <include name="Daily"/>
            </define>
			<run>
				<include name="@TESTGROUP@" />
			</run>
        </groups>
        <classes>
             <class name="something.Something"/>
        </classes>
</test>

Then in ant i build a String replace function.
<target name="extractSuites" description ="Extract Suites with a Group -Dtest.group='Daily/Nightly/All' into the Suite Run directory">
		<!-- Set the Group to run. If no group set assume daily -->
	    	<condition property="test.group" value="${test.group}" else="All"><!-- Defnining Empty Group will run everything -->
	    		<isset property="test.group" />
	    	</condition>
		<!-- Create a temp Suite that has teh GroupFilled in -->
        <copy todir="${suite.run.dir}" overwrite="yes">
	        <fileset dir="${resources.dir}">
	              <include name="testng*.xml" /><!-- Search for anything in resource Directory with name starting with testng -->
	        </fileset>

	        <filterset>
				<filter token="TESTGROUP" value="${test.group}" />
			</filterset>

        </copy>
	</target>


chore: Add new logo

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.04%.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   69.04%   69.04%
=======================================
  Files          15       15
  Lines         659      659
  Branches       78       78
=======================================
  Hits          455      455
  Misses        184      184
  Partials       20       20

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


responsive website

it would be an interesting factor and a differentiator for the project to have a responsive layout. I can create a repository for canove to use an android app , for the application when the responsive option be available

I am interested in this part of responsive .. if someone evolves in that.

tell me to create an android app

Since we use Material UI, it should not be that difficult to implement this. https://material-ui.com/guides/responsive-ui/

I am also interested, it is more I can support with a little cash if others help me to collaborate with the creator or who decides to give their time to carry out this task

i can try adapt the material-ui in the saturday, any questions send me dm in dc of this repository

im still waiting
Pada tanggal Sel, 6 Apr 2021 pukul 00.15 Leonardo Oliveira <
@.***> menulis:

i can try adapt the material-ui in the saturday, any questions send me dm
in dc of this repository
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/canove/whaticket/issues/164#issuecomment-813479673,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARYPQN2OAAJNA5PU4TPEKRDTHHO3FANCNFSM42FPTO7Q
.

hello guys
my pc stopped working on Wednesday, so i guess this will need to

solved


Fix default units

Description

Fixes Swedish defaults to metric units on the AboutYouScreen.
Changes Weight for the UK to be in kgs.

On what platform have you tested the change?

[ ] Android - Emulator
[x] Android - Physical device
[x] iOS - Emulator
[ ] iOS - Physical device

Hmpf... this doesn't actually work. setting state in componentDidMount() triggers a re-render, but Formik remembers the old values.

Urgh... there's some weird behaviour now, because getConfig is async and the form keeps re-rendering. I'm away until 5pm looking after the kids if someone can pick this up.

@MikeD-ZOE - Just saw your PR #187 that will definitively help with this!


Simplify check consumer side in RpcContext

What is the purpose of the change
url.getPort() != address.getPort() ||
                !NetUtils.filterLocalHost(url.getIp()).equals(NetUtils.filterLocalHost(host));

There is no need to compare address to confirm whether they are consumer or not in RpcContext.
the remote address come from url and compare with url.
Brief changelog
RpcContext

Please synchronize the origin/master branch to resolve the problem of CI check failure


Update vendor libraries

This pull request aims mainly at updating the noaa and uaago libraries, while implementing the RefreshTokenFrom method from the noaa consumer object.
Update noaa and uaago dependencies
Leverage the RefreshTokenFrom from the consumer by passing in a UAATokenFetcher object
Remove Heartbeat messages from the list of processed messages

I'll close this pull request and create another in order to merge cleanly


"Creating a personal access token" has a malformed link

This may be a duplicate, but I don't even know how to search for a duplicate of this issue.
What article on docs.github.com is affected?
https://docs.github.com/en/github/authenticating-to-github/creating-a-personal-access-token

What part(s) of the article would you like to see updated?
9. To use your token to authenticate to an organization that uses SAML SSO,
[authorize the token for use with a SAML single-sign-on organization](/articles/authorizing-a-personal-access-token-for-use-with-saml-single-sign-on

This section should contain a link and not just text.

Additional information
An image of how it looks right now

Thank you

Thanks so much for opening an issue to let us know about that @ericmartinezr! You (or anyone else) are welcome to open a PR to fix that link ⚡ While we're fixing it, let's update the link to the new url structure (anything with /articles is old). This should be the updated link: https://docs.github.com/en/github/authenticating-to-github/authorizing-a-personal-access-token-for-use-with-saml-single-sign-on.


Added MagicDefaultValueListener (task #3567)

This even listener, combined with the latest
CsvMigrations plugin, allows for dynamic values
as field defaults (which is magical).
For example, instead of the static defaults like
[field]
default=foobar

One now can set dynamic values like:
[field]
default=%CURRENT_DATE%

Supported dynamic defaults are:

CURRENT_DATE
CURRENT_TIME
CURRENT_DATETIME
CURRENT_USER_ID

More can be easily supported by adding protected methods
to the MagicDefaultValueListener, matching the naming
convention:

Convert default to lower case.
Convert from underscores to CamelCase.
Prefix with 'get'.
Suffix with 'Value'.

For example, CURRENT_USER_ID becomes getCurrentUserIdValue().

This PR won't change any behavior until https://github.com/QoboLtd/cakephp-csv-migrations/pull/421 is merged and tagged.


PUPIL-412: Disable buttons on the lesson overview until page hydration

Description
Music year: 1957
Disables the nav items and "Let's get ready" button (using their existing disabled states) on the lesson overview until the page has hydrated. This is a temporary measure until they are replaced with links. However until then the page will appear broken while the JS is loading.
How to test:

Visit https://deploy-preview-2260--oak-web-application.netlify.thenational.academy/pupils/programmes/english-secondary-ks4-aqa/units/modern-text-second-deep-dive-194/lessons/men-in-leave-taking#lesson-details on a slow or throttled connection (climb a remote hillside in North Wales, go to a music festival, or use the Network tab of DevTools).
Try to interact with the buttons on the overview screen while the page is still loading.

Known limitations and reasoning

Deep linking with a #fragment to another section of the lesson will still appear broken while loading — this seems acceptable since we're not actively exposing the deep linking to pupils and we intend to use real links in future.
I didn't feel like a loading spinner would be appropriate since it's quite distracting and would defeat the purpose of SSR
I didn't think a skeleton loader would be appropriate since we already have the page content available through SSR

https://github.com/oaknational/Oak-Web-Application/assets/122096/333c46af-4fab-4a79-93db-cb7e776397a2

:tada: This PR is included in version 1.359.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Example of Super()

Content Issue

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

URL of page you are seeing the problem on:
https://developer.mozilla.org/es/docs/Web/JavaScript/Referencia/Operadores/super#:~:text=La palabra clave super es,clases como para objetos literales.
Details

@ZackSten apologies, but we don't have the bandwidth to maintain translations. Would you be willing to make this change yourself?


Good one!

Just found this mentioned on some reddit post.
I've been doing some research for the past few months around functional, RPC like framework (correlated with tRPC, ts-rest, zodios, telefunc, blitz-rpc etc.) but haven found anything fulfilling my needs. But this seems like the one! I love the idea and simplicity. This is what I need.
What is current state of the project?
I would love to contribute to the project to help growth and fast v1 release <3 (currently busy at work so it can be hard atm).
For sure you have my star and follow. Looking forward to what this can emerge into.
Keep good work :)

Hi! Thanks for your words!
I could have answered earlier, but I let some days pass to better formulate my thoughts.
The httpc development is active. I use it in every project I do. I'm using it with dozen production servers and webapp clients.
But the status for others collaborators is not good:

the v0.2 branch has lot of refactoring, breaking changes and improvements. But there's no examples.
the current documentation is way behind
it's still very experimental, with lot of missing features, rough edges
there're core ideas inside that are good, but some outer layer are just patched up, and they require lot of rework
naming is a total mess
the API is not stable at all. As I develop httpc in sync with all my projects, I change the API quite frequently. For me is not a problem, because all my repos are synched together, so changes propagate nicely. But it's not good for a facing library.

When I started the httpc project, my aim was to dedicated to it a good chuck of my time. But I failed to make it more popular, and I don't have any connection.
So now basically I develop it within my projects and add missing features or refinements just to make my "main" projects run.
If you still want to give it a try, maybe we can follow/build together a use case or an example.
In other words, I can tell you how to setup a project and you go on from there, asking if you need features or you can't find out how to do something.
Let me know what you think.

PS, if you active on twitter, follow me https://x.com/giuseppelt
Sometime I post httpc related stuff there

I really like this approach! I really hope it gets more popular.


CI: v1.7: "K8sDatapathConfig ManagedEtcd Check connectivity with managed etcd" backport needed

This needs to be backported to v1.7.
The problem is also reported here
Failures:
https://jenkins.cilium.io/view/Cilium-v1.7/job/cilium-v1.7-standard/1887/
https://jenkins.cilium.io/view/Cilium-v1.7/job/cilium-v1.7-standard/1886/
https://jenkins.cilium.io/view/Cilium-v1.7/job/cilium-v1.7-standard/1885/

https://jenkins.cilium.io/view/Cilium-v1.7/job/cilium-v1.7-standard/1901/

Fixed by https://github.com/cilium/cilium/pull/13574


 For example, once it's true the browser thread will go wild adding more timers. This is what display_scheduled avoided before it was removed last week.
I've re-added display_scheduled via the back door in a way that doesn't look like a dirty bit: put an animation_timer object on Browser that is cleared in commit.
Before this PR, the task list quickly got enormous and it looked like typing into the url bar to load a new page was broken. Now it's very responsive.
This PR also applies some more editorial fixes I found in re-reading today.

Approved. I propose you read over mine and, unless there are major issues, do the appropriate merge between the two PRs, since I expect there will be more than the normal number of conflicts. I don't think we need to worry about the exact way wording changes are resolved, as long as we get a reasonable outcome.


Fixes combineByKey.

Keys should be hashed before putting into the hashtable environment.

Thanks @hlin09 -- this is being captured by @davies in a batch PR https://github.com/apache/spark/pull/5436 to the Spark repository. So I'm closing this.


feat: improve sdk request evaluator interface

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

9 of 10 (90.0%)  changed or added relevant lines in 3 files are covered.
13 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.2%) to 84.345%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sdk/evaluator.go
3
4
75.0%

Files with Coverage Reduction
New Missed Lines
%

sdk/evaluator.go
1
81.93%

service/handler.go
12
81.76%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
1988

Relevant Lines:
2357

💛  - Coveralls


Compatibility matrix for OpenShift local development

Tested that, the setup works only with mentioned versions.
Need to see other combinations as well.

@pranavgore09 snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1888-1

Codecov Report

Merging #1888 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1888      +/-   ##
==========================================
- Coverage   58.63%   58.57%   -0.06%
==========================================
  Files         143      143
  Lines       14460    14460
==========================================
- Hits         8478     8470       -8
- Misses       5225     5233       +8
  Partials      757      757

Impacted Files
Coverage Δ

remoteworkitem/jira.go
75% <0%> (-25%)
:arrow_down:

remoteworkitem/scheduler.go
53.65% <0%> (-7.32%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebdb606...e434be8. Read the comment docs.

@pranavgore09 do we intend to add other versions too if they are found to be compatible?
If yes, I suggest changing the title from: Verified compatibility mattrix to Compatibility matrix.
If not, then we could simply add version information to each of the titles like: Install Kedge, V-0.4.0 (Linux)
Wdyt?

@Preeticp sure, I can rename the title and I will add recommended version number for each component. thanks!

@Preeticp I have updated the doc at https://github.com/fabric8-services/fabric8-wit/pull/1888/commits/9e29c2a50c7c8f3cdf4daa4c548def25509e07b7 please see if that feels correct

@pranavgore09 snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1888-2

@pranavgore09 snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1888-3

@pranavgore09 we should keep either the matrix or the recommended version. Currently since we have only one version, I would suggest you comment out the matrix section. That way when you have other versions you can add the new versions to it and get the table back.

@Preeticp  done! please verify

@pranavgore09 snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1888-4

@pranavgore09 LGTM


Adding NetConnectionProfile DSC Resource

This commit allows the modification of Get/Set-NetConnectionProfile in DSC.
It also adds unit testing for the resource. We'll want to add Integration testing as a seperate commit to allow further refinement on this resource to occur.
Resolves #19 as this allows the modification of this command.

@Dan1el42 @iainbrighton @PlagueHO - if anyone of you have time for a code review on this i'd be appreciated.
I'd like to get in some intergration tests before I commit but I'd like some passes on the logic before I start figuring out that process.

The logic looks good to me. No problems I can see. :+1:


[Feature]:

前置阅读 | Pre-reading

[X] Issues
[X] README

服务类型 | Service Type
Official hosted service
系统信息 | System Information
Windows
Office 版本 | Office Version
microsoft 365
功能请求 | Feature request
word-GPT-Plus: Hi,I don't konw how to set API key，wish some help,thanks a lot

前置阅读 | Pre-reading

[x]  Issues
[x]  README

服务类型 | Service Type
Official hosted service
系统信息 | System Information
Windows
Office 版本 | Office Version
microsoft 365
功能请求 | Feature request
word-GPT-Plus: Hi,I don't konw how to set API key，wish some help,thanks a lot

Click the orange Settings button, and switch API to Official, then input your API key to api key

Thanks you very much for your help.
I've found the setting.But I've another problem with the network.
I am in China. I've checked that I can access the domain.But don't know how to set the proxy.
Wish for your help.
Thanks again.
阳光的物语
@.***

------------------ 原始邮件 ------------------
发件人:                                                                                "Kuingsmile/word-GPT-Plus"                                                                                @.>;
发送时间: 2023年6月8日(星期四) 晚上10:07
@.>;
<EMAIL_ADDRESS>主题: Re: [Kuingsmile/word-GPT-Plus] [Feature]:  (Issue #16)
前置阅读 | Pre-reading
Issues
README
服务类型 | Service Type
Official hosted service
系统信息 | System Information
Windows
Office 版本 | Office Version
microsoft 365
功能请求 | Feature request
word-GPT-Plus: Hi,I don't konw how to set API key，wish some help,thanks a lot
Click the orange Settings button, and switch API to Official, then input your API key to api key
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

an acce

check this


AttributeError while testing

Hi i am trying to test a pretrained model but an error occurs, i`m new to deep learning, can you please tell me how to fix it?

parser.add_argument('--cutout', action='store_true', default=False,
                        help='apply cutout')

You can reference this file


⚠ Bofrost.de has degraded performance

In 7210b2b, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 845 ms

Resolved: Bofrost.de performance has improved in d3531ba.


Enhance processing of IMS programs

This request is about enhancing the support of processing IMS programs. Especially in mixed environments with CICS and IMS, this is not covered well.
So, let's collect requirements:
Calls to DLI interface
Link phase:
When running the program in CICS, it requires to pull the CBLTDLI from the SDFHLOAD library, but when running in an IMS environment (maybe IMS batch), there is no logic to add the SDFSRESL (IMS RESLIB) to pull the DFSLI000 interface (CBLTDLI is just an alias)
It requires a new flag to indicate that a program will be executed in an IMS context, such as an isIMS flag.
Library concatenation when processing link cards in LinkEdit.groovy
Link phase should be conditional to the "environment" flags as well.
https://github.com/IBM/dbb-zappbuild/blob/d177891a59a41b0947eacaf1e1e5a7ca199ac13a/languages/LinkEdit.groovy#L113-L122

Hi Dennis,
I would like to control full SYSLIB-Concatenation with the linkedit_linkEditSyslibConcatenation Property. Even better would be to have the possibility to use different Concatenations based on the Programm Language/Subsystem Combinations (e.g. CICS/DB2, PLI/DB2, PLI/IMS).  Although in our cases the SCEELKED (LE-Linklib) is always the first. It can happen that the DB2-Linklib or IMS-Linklib are alternating on 2nd Position in the Concatenation
a) PLI Programm with DB2
SCEELKED
DB2-Linklib
IMS-Linklib
Application Libs
b) PLI Programm with IMS
SCEELKED
IMS-Linklib
DB2-Linklib
Application Libs

Additionally, in the Compiler Step, we use a different SYSTEM-Parm if the Module contains DLI-Calls
a) IMS Program - SYSTEM(IMS)
b) Other Programs - SYSTEM(MVS)

Additionally, in the Compiler Step, we use a different SYSTEM-Parm if the Module contains DLI-Calls a) IMS Program - SYSTEM(IMS) b) Other Programs - SYSTEM(MVS)

@avalon2 ,the capability exists today via file properties to set different SYSTEM parameters:
# defining the defaults
pli_compileParms=PP(INCLUDE('ID(++INCLUDE)')),SYSTEM(MVS)
# providing the override for IMS programs
pli_compileParms=PP(INCLUDE('ID(++INCLUDE)')),SYSTEM(IMS) :: **/imsmodules/*.pli (or any other pattern filter).

Assuming, that would be sufficient.

Additionally, in the Compiler Step, we use a different SYSTEM-Parm if the Module contains DLI-Calls a) IMS Program - SYSTEM(IMS) b) Other Programs - SYSTEM(MVS)

@avalon2 ,the capability exists today via file properties to set different SYSTEM parameters:
# defining the defaults
pli_compileParms=PP(INCLUDE('ID(++INCLUDE)')),SYSTEM(MVS)
# providing the override for IMS programs
pli_compileParms=PP(INCLUDE('ID(++INCLUDE)')),SYSTEM(IMS) :: **/imsmodules/*.pli (or any other pattern filter).

Assuming, that would be sufficient.

Thx. working.

Hi Dennis,
As system(IMS) is needed for each PL/I Compile for IMS, couldn't this be leveraged with a isDLI-Parm rather then using the override based on pattern ?
"The SYSTEM(IMS) compiler option must be specified for PL/I applications running under IMS"
https://www.ibm.com/docs/en/zos/2.4.0?topic=ims-pli-considerations-under

IBM requires to have IMS or CICS-Libs BEFORE Db2-Lib:
https://www.ibm.com/docs/en/db2-for-zos/12?topic=zos-compiling-link-editing-application

@avalon2 , I have worked on enhancing the scripts for IMS . You can see the updates in PR #454 .
Order of concatenation is CICS, IMS and then Db2, and it is dependent on the way isCICS, isIMS and isSQL  is configured.
https://github.com/IBM/dbb-zappbuild/pull/454/files#diff-7208e54398cc20fc4a300ce46a95e7fa9ac82e937e6d88df00c5a26f6272d388
Will add the PLI SYSTEM(IMS) option for PLI.

@avalon2 these features were delivered with zAppBuild 3.6.0


Invalid address field in errorlog.xml

More and more of our returned BugTrap reports have an <address> field containing 00000000 as follows
  <error>
    <what>ACCESS_VIOLATION</what>
    <process>
      <name>Designer.exe</name>
      <id>9476</id>
    </process>
    <module></module>
    <address>0023:00000000</address>
    <function>
      <name></name>
      <offset></offset>
    </function>
    <file></file>
    <line>
      <number></number>
      <offset></offset>
    </line>
  </error>

Probably not surprisingly this causes CrashExplorer to crash.
These apparently useless reports have prompted me to look into updating from version 1.3.3718.38316 to the latest version. Can anyone offer a reason why 00000000 should could appear in an errorlog.xml file? Furthermore, if this has been a known problem, is it fixed in the latest version?

Zero address is not something unusual - it appears when your code calls a function by zero pointer:
void(*func)(void) = NULL;
func();

What us definitely bad is that CrashExplorer crashes. If you still have those reports, could you try open them with latest CrashExplorer to see if it crashes again?

Yes CrashExplorer just sits there saying Please Wait, It looks like it is doing exceptions in the background
First-chance exception at 0x900008c2 in CrashExplorer.exe: 0xC0000005: Access violation.
First-chance exception at 0x00000200 in CrashExplorer.exe: 0xC0000005: Access violation.
First-chance exception at 0x900008c2 in CrashExplorer.exe: 0xC0000005: Access violation.
First-chance exception at 0x00000200 in CrashExplorer.exe: 0xC0000005: Access violation.
First-chance exception at 0x900008c2 in CrashExplorer.exe: 0xC0000005: Access violation.
If I upload the map, pdb, xml and dmp files can I be sure that they can only be downloaded by BugTrap administrators?

No, they would be in public access. You can email me these files and I'll try to figure out what is the problem.

Did you get the zip file I sent?

Yes, I did. I'll take care of it this weekend and let you know what I found out.

I guess that was a typo. Apparently nobody ever loaded reports with MAP file.

Thanks for looking into this @nitrocaster !
@colindavidfoster , does the v1.4.8 release with @nitrocaster 's patch your issue?

Yes, though I was thrown for a while because I tried the new version in debug mode and my (large) map file was taking ages to load in CMapProcessor::GetPublicFunctions(). Of course when I changed to release things were a lot faster.
Now I've got to look at why the VS2008 solution won't build for me. I suspect it's a build environment issue on my PC. I may come back to you if I can't resolve it.
Thanks

PS. I had to make a couple of small changes to the vs2013 solution/project to get it to build. Firstly to add boost to the list of link libraries. That's not surprising because we don't run with boost in our default libraries. However, I had to fiddle around to find <atlapp.h>. Presumably this is because I don't have some prerequisite SDK installed


HADOOP-16112. Delete the baseTrashPath's subDir leads to don't modify baseTrashPath

Signed-off-by: sunlisheng<EMAIL_ADDRESS>

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
89
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1268
trunk passed

+1
compile
1100
trunk passed

+1
checkstyle
53
trunk passed

+1
mvnsite
88
trunk passed

+1
shadedclient
896
branch has no errors when building and testing our client artifacts.

+1
javadoc
63
trunk passed

0
spotbugs
129
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
127
trunk passed

_ Patch Compile Tests _

+1
mvninstall
52
the patch passed

+1
compile
1056
the patch passed

+1
javac
1056
the patch passed

-0
checkstyle
44
hadoop-common-project/hadoop-common: The patch generated 10 new + 158 unchanged - 0 fixed = 168 total (was 158)

+1
mvnsite
75
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
747
patch has no errors when building and testing our client artifacts.

+1
javadoc
63
the patch passed

+1
findbugs
143
the patch passed

_ Other Tests _

+1
unit
617
hadoop-common in the patch passed.

+1
asflicense
46
The patch does not generate ASF License warnings.

6579

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1223

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux d6131c174b6b 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3cc0ace

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/1/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/1/testReport/

Max. process+thread count
1374 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
65
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1040
trunk passed

+1
compile
1087
trunk passed

+1
checkstyle
39
trunk passed

+1
mvnsite
69
trunk passed

+1
shadedclient
738
branch has no errors when building and testing our client artifacts.

+1
javadoc
58
trunk passed

0
spotbugs
118
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
115
trunk passed

_ Patch Compile Tests _

+1
mvninstall
45
the patch passed

+1
compile
1063
the patch passed

+1
javac
1063
the patch passed

-0
checkstyle
48
hadoop-common-project/hadoop-common: The patch generated 10 new + 158 unchanged - 0 fixed = 168 total (was 158)

+1
mvnsite
64
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
624
patch has no errors when building and testing our client artifacts.

+1
javadoc
61
the patch passed

+1
findbugs
121
the patch passed

_ Other Tests _

+1
unit
530
hadoop-common in the patch passed.

+1
asflicense
44
The patch does not generate ASF License warnings.

5871

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1223

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 31c5883a5911 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 00b5a27

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/2/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/2/testReport/

Max. process+thread count
1390 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@jojochuang  I updated this patch and uploaded it. Could you help review it? Thank you.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
47
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1045
trunk passed

+1
compile
1099
trunk passed

+1
checkstyle
40
trunk passed

+1
mvnsite
69
trunk passed

+1
shadedclient
721
branch has no errors when building and testing our client artifacts.

+1
javadoc
60
trunk passed

0
spotbugs
115
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
114
trunk passed

_ Patch Compile Tests _

+1
mvninstall
42
the patch passed

+1
compile
991
the patch passed

+1
javac
991
the patch passed

-0
checkstyle
38
hadoop-common-project/hadoop-common: The patch generated 13 new + 165 unchanged - 0 fixed = 178 total (was 165)

+1
mvnsite
67
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
642
patch has no errors when building and testing our client artifacts.

+1
javadoc
56
the patch passed

-1
findbugs
121
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1
unit
507
hadoop-common in the patch passed.

+1
asflicense
39
The patch does not generate ASF License warnings.

5757

Reason
Tests

FindBugs
module:hadoop-common-project/hadoop-common

Spinning on TrashPolicyDefault.flag in org.apache.hadoop.fs.TrashPolicyDefault.moveToTrash(Path)  At TrashPolicyDefault.java: At TrashPolicyDefault.java:[line 168]

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1223

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 5697f96be39a 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 9a1d8cf

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/3/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/3/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/3/testReport/

Max. process+thread count
1463 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
47
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1152
trunk passed

+1
compile
1056
trunk passed

+1
checkstyle
36
trunk passed

+1
mvnsite
68
trunk passed

+1
shadedclient
735
branch has no errors when building and testing our client artifacts.

+1
javadoc
55
trunk passed

0
spotbugs
111
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
110
trunk passed

_ Patch Compile Tests _

+1
mvninstall
44
the patch passed

+1
compile
1052
the patch passed

+1
javac
1052
the patch passed

-0
checkstyle
38
hadoop-common-project/hadoop-common: The patch generated 13 new + 165 unchanged - 0 fixed = 178 total (was 165)

+1
mvnsite
68
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
615
patch has no errors when building and testing our client artifacts.

+1
javadoc
54
the patch passed

-1
findbugs
119
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1
unit
509
hadoop-common in the patch passed.

+1
asflicense
41
The patch does not generate ASF License warnings.

5877

Reason
Tests

FindBugs
module:hadoop-common-project/hadoop-common

Spinning on TrashPolicyDefault.flag in org.apache.hadoop.fs.TrashPolicyDefault.moveToTrash(Path)  At TrashPolicyDefault.java: At TrashPolicyDefault.java:[line 168]

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1223

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux e0c3f38d4fbb 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 6244502

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/4/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/4/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/4/testReport/

Max. process+thread count
1419 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
48
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1360
trunk passed

+1
compile
1234
trunk passed

+1
checkstyle
48
trunk passed

+1
mvnsite
76
trunk passed

+1
shadedclient
809
branch has no errors when building and testing our client artifacts.

+1
javadoc
64
trunk passed

0
spotbugs
128
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
126
trunk passed

_ Patch Compile Tests _

+1
mvninstall
52
the patch passed

+1
compile
1148
the patch passed

+1
javac
1148
the patch passed

-0
checkstyle
47
hadoop-common-project/hadoop-common: The patch generated 13 new + 165 unchanged - 0 fixed = 178 total (was 165)

+1
mvnsite
83
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
675
patch has no errors when building and testing our client artifacts.

+1
javadoc
63
the patch passed

-1
findbugs
151
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1
unit
611
hadoop-common in the patch passed.

+1
asflicense
49
The patch does not generate ASF License warnings.

6705

Reason
Tests

FindBugs
module:hadoop-common-project/hadoop-common

Spinning on TrashPolicyDefault.flag in org.apache.hadoop.fs.TrashPolicyDefault.moveToTrash(Path)  At TrashPolicyDefault.java: At TrashPolicyDefault.java:[line 168]

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1223

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux fbad6b76fd74 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 69ddb36

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/5/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/5/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/5/testReport/

Max. process+thread count
1446 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
43
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1088
trunk passed

+1
compile
1081
trunk passed

+1
checkstyle
52
trunk passed

+1
mvnsite
79
trunk passed

+1
shadedclient
858
branch has no errors when building and testing our client artifacts.

+1
javadoc
69
trunk passed

0
spotbugs
121
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
119
trunk passed

_ Patch Compile Tests _

+1
mvninstall
48
the patch passed

+1
compile
1008
the patch passed

+1
javac
1008
the patch passed

-0
checkstyle
54
hadoop-common-project/hadoop-common: The patch generated 13 new + 165 unchanged - 0 fixed = 178 total (was 165)

+1
mvnsite
79
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
686
patch has no errors when building and testing our client artifacts.

+1
javadoc
67
the patch passed

-1
findbugs
130
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

-1
unit
534
hadoop-common in the patch failed.

+1
asflicense
54
The patch does not generate ASF License warnings.

6119

Reason
Tests

FindBugs
module:hadoop-common-project/hadoop-common

Spinning on TrashPolicyDefault.flag in org.apache.hadoop.fs.TrashPolicyDefault.moveToTrash(Path)  At TrashPolicyDefault.java: At TrashPolicyDefault.java:[line 168]

Failed junit tests
hadoop.util.TestBasicDiskValidator

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1223

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 001e300c7199 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3329257

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/6/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/6/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/6/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/6/testReport/

Max. process+thread count
1734 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/6/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
43
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1175
trunk passed

+1
compile
1044
trunk passed

+1
checkstyle
48
trunk passed

+1
mvnsite
83
trunk passed

+1
shadedclient
819
branch has no errors when building and testing our client artifacts.

+1
javadoc
79
trunk passed

0
spotbugs
128
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
125
trunk passed

_ Patch Compile Tests _

+1
mvninstall
48
the patch passed

+1
compile
1005
the patch passed

+1
javac
1005
the patch passed

-0
checkstyle
52
hadoop-common-project/hadoop-common: The patch generated 13 new + 165 unchanged - 0 fixed = 178 total (was 165)

+1
mvnsite
77
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
681
patch has no errors when building and testing our client artifacts.

+1
javadoc
74
the patch passed

-1
findbugs
129
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1
unit
562
hadoop-common in the patch passed.

+1
asflicense
50
The patch does not generate ASF License warnings.

6178

Reason
Tests

FindBugs
module:hadoop-common-project/hadoop-common

Spinning on TrashPolicyDefault.flag in org.apache.hadoop.fs.TrashPolicyDefault.moveToTrash(Path)  At TrashPolicyDefault.java: At TrashPolicyDefault.java:[line 168]

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1223

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 0397ec7b254f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 915cbc9

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/7/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/7/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/7/testReport/

Max. process+thread count
1376 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1223/7/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
20m 29s
trunk passed

+1 :green_heart:
compile
20m 36s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
18m  8s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
checkstyle
0m 49s
trunk passed

+1 :green_heart:
mvnsite
1m 26s
trunk passed

+1 :green_heart:
shadedclient
16m 49s
branch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 44s
hadoop-common in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

+1 :green_heart:
javadoc
1m  5s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+0 :ok:
spotbugs
2m  9s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m  7s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 49s
the patch passed

+1 :green_heart:
compile
20m 28s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
20m 28s
the patch passed

+1 :green_heart:
compile
18m 19s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

+1 :green_heart:
javac
18m 19s
the patch passed

-0 :warning:
checkstyle
0m 51s
hadoop-common-project/hadoop-common: The patch generated 13 new + 164 unchanged - 0 fixed = 177 total (was 164)

+1 :green_heart:
mvnsite
1m 24s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m  6s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 38s
hadoop-common in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.

+1 :green_heart:
javadoc
0m 57s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09

-1 :x:
findbugs
2m 23s
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
9m 33s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 49s
The patch does not generate ASF License warnings.

155m  6s

Reason
Tests

FindBugs
module:hadoop-common-project/hadoop-common

Spinning on TrashPolicyDefault.flag in org.apache.hadoop.fs.TrashPolicyDefault.moveToTrash(Path)  At TrashPolicyDefault.java: At TrashPolicyDefault.java:[line 168]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1223/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1223

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux c4893c9a451e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e756fe35909

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1223/3/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1223/3/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt

javadoc
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1223/3/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt

findbugs
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1223/3/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1223/3/testReport/

Max. process+thread count
3006 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1223/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Trial kludge to fix ampersands in Python reformat script

This is a lousy hack that attempts to restore escaping to ampersands from the original XML. I've added each line to a list, rather than writing to a file. Then loop over the list and replace '&' with '&' before writing to the file. Not pretty, but should be functional, I hope.

Yes this worked!!! Thanks. I'll make a fresh commit with updated data.

Whoops, I meant to merge!


404 Page

I have observed that there is no 404 page, whenever we search for an unknown route in the url

Yeah youre right, Pretty cool idea. Do you wanna work on it.?

I'd like to work on this.

@hiddartho Something like this would be cool https://github.com/404

Is this okay??

@hiddartho Looks pretty neat. Would you mind adjusting the color of 404  text for light mode. Also add some image of mascot if you can.

I have given the PR, and not added mascot for now,
Do check it

Can I work on this to create a beautiful design with css matching with the website theme?

Can I work on this to create a beautiful design with css matching with the website theme?

Sure, Lets keep the page minimal and use TailwindCSS as the project uses that.

e project uses

Ok Sir, I will get back to you asap

@ArslanYM Sir I have added a PR with a custom built Masoct from scratch, Fully Responsive using Tailwind CSS. Please Review It


feat: add i18n to admin panel

Description
https://github.com/payloadcms/payload/discussions/300

[x] I have read and understand the CONTRIBUTING.md document in this repository

Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Checklist:

[x] I have added tests that prove my fix is effective or that my feature works
[x] Existing test suite passes locally with my changes
[ ] I have made corresponding changes to the documentation

i18n docs updates:

Update field labels, groups, description, placeholder, collection labels, global labels, block label, and array label with Record<string, string> change.
GraphQL names no longer use label
How to customize i18n options
How to import useTranslation in custom components
i18n added to req and can be used as i18n.t('translationKey')
Send accept-language header to choose a language for API responses


$this->_reserved_identifiers is unreachable for a honest developer.

When using the Active Record for updating and inserting data, we used to be able to set $this->_reserved_identifiers outside of DB_driver.php. Now it looks like it is protected, and I can't see any clear way to change this.
This removes the possibility of using statements like
UPDATE LOW_PRIORITY table set ...
When using the querybuilder for $this->db->update('LOW_PRIORITY table', ...), it will escape the LOW_PRIORITY part. leaving me with update 'LOW_PRIORITY' 'table' OR update mydatabasename.'LOW_PRIORITY'.
Is this intended? I really don't want to extend the class just for adding an override for this, or change it directly in the framework.
Im using CI 3.1

If it is there, it is intended.

Well, the issue is more that functionality for setting reserved_identifiers is MISSING, as in not even there.

I see where this is going, so I'll cut to the chase ...
There are 2 issues here - that you assumed you should be able to set those reserved identifiers, and that you're doing this to somehow use LOW_PRIOIRITY via with the Query Builder.
You should do neither.
_reserved_identifiers is and has always been an internal property, an implementation detail. You should've never even tried to access it. The fact that you were able to is because PHP 4 didn't have visibility declarations and thus older CI versions that had to support PHP 4 couldn't restrict it.
Every major naming convention from the PHP 4 era suggests prefixing internal method and property names with an underscore, so that you know they should NOT be used as a part of a public API. I'd be surprised if you don't know this.
Despite this, there is a way to override these values, if you're smart enough to figure it out ... But I'm not giving such tips, especially here - we only accept bug reports here. You may have better luck on our forums, and it would also help if you're more patient than with your StackOverflow questions (2 hours since you've posted that).
LOW_PRIORITY on the other hand is a MySQL-specific feature and using such features beats the entire point of using a query builder, that is - writing platform-agnostic queries. Your application can only run on MySQL, so QB only adds overhead in your case, you gain less than nothing - only performance penalties and functional limitations.
You're better off without it, and this isn't the first "new" restriction you'll encounter. Just switch to writing raw SQL.
Sorry.

Thanks for cutting the the chase, as I actually got an explaination. And somewhat good tips.

Thanks for the information though, no need to be hostile.

I can assure you this is not me being hostile and I don't see how could that possibly have been a personal attack, nor why would I want to attack you in the first place.

I don't even know what to reply to this.

No need to really.
Text communication can't transfer emotions in the same way that voice or video would, and I'm just saying you got my intentions wrong. No hard feelings.

Just adding a little to this discussion.
There are numerous identifiers that are not mysql specific that also gets escaped now, this makes the query builder useless for about any query using anything more specific than SELECT/UPDATE/INSERT/WHERE/HAVING
I often use CASE or IF in queries some of these are placed in places like the order by, and would still like to use the query builder for 90% of the other part..
Currently i either need to extend the whole class to set the identifiers, or hack the library to allow me setting this.
To my knowledge the whole point of codeigniter was to make the life of the developer easier, and to provide a toolbox with features, and not force you to use only one specific method.
I understand the reasoning for the escaping, and that you want it to not contain anything DB specific, But i don't understand the reasoning for not allowing us to set the reserved_identifiers or even turn off the escaping for a query on other parts than select, set, where or having.
If we decide to use features that breaks portability for the project we are working on, it does absolutly nothing to break codeigniters support for multiple databases etc. it only allows handling of more specific cases which you might not have orginally planned for.
These queries I am talking about are few and rare in most of our projects, but I still don't understand the reasoning for the answer:

You're better off without it, and this isn't the first "new" restriction you'll encounter. Just switch to writing raw SQL.

I understand that LOW_PRIORTY under update/insert is a mysql specific scenario, but CASE and IF in a order by is not.
Both are solved by allowing us to set the reserved_identifiers in some way...

@trymkb
There's performance implications to doing ORDER BY with dynamic expressions.
And still, you can turn off escaping for it. Pretty much everything QB method but from() has an $escape parameter.
As I already said, the _reserved_identifiers property is an implementation detail. I might rename or delete it tomorrow, and you shouldn't depend on it; you shouldn't even know that it exists.

Yes know that there is an performance impact by using those in order by, but it is not something you can always avoid (why i state it is rare).
Sorry I went from memory instead of checking the current state of the query builder, and missed that order_by now has the escape option.
But i also see that update() is still missing this option.
Adding it there will solve jthanto's issue.
Even though there is a huge difference between allowing one specific command i deem to be safe in a query and allowing everything to pass ..
I would still prefer to have access to the reserved_identifiers or something similar to it.
Thanks for the response :-)

LOW_PRIORITY is not only MySQL specific, it's specific for table-level locking engines. Practically that means MyISAM. You should not be using MyISAM (eg it's not crash safe). Simply use Innodb and forget about LOW_PRIORITY. :-)
This option would only be good for people using the MEMORY engine with a high load and a lot of concurrency.

There are numerous reasons for using MyISAM and as you state the option for using it while running the Memory engine also applies.
MyISAM can handle about 10x the amount of reads using less CPU and Memory than InnoDB can if properly setup.
And writes can be a helluva lot faster also.. depending on the data.
Partitioning works faster with MyISAM and you also lose most of the benefits with InnoDB when using it.
You also have the Merge engine.
There are also custom engines that allows for other commands.
A framework should not take those decisions on behalf of developers.

A framework should not take those decisions on behalf of developers.

And it doesn't. It's not forcing you to use InnoDB.
What the framework does is to abstract common functionalities.

But you are making a decision by not considering fixing the update function with the escape option, or add some functionality to add your own identifiers to the list.
I can provide the necessary code to fix the identifiers and the update() function, but if this is not going to be accepted just because it conflicts with an opinion then i will not bother doing that.

It's an abstraction for the most common case, that works on all platforms.
You want to shove arbitrary SQL into it and it's not made for that. If you want to write arbitrary SQL, you write raw SQL. How many times do I have to say this before you understand that this is simply how it is supposed to work?
It's not broken, it doesn't need fixing. Period.

This is a narrow-minded way of thinking..
It is broken for me and jthanto, and probably many more people.
And your argument is to not improve anything .. just because you have not experienced this issue or don't care.
I have alot of very complex queries, which i prefer a simpler approach of writing than just raw SQL..
In most cases the query builder works out of the box.. and in other i have just hacked the library to fix the missing functionality.
But this is not a good solution, I would prefer that CI itself takes the responsibility of actually having a good query builder with a safe and expandable method of escaping out of the box.
Can you explain why does the insert command have an escape toggle, but not the update?

This is a narrow-minded way of thinking..

My arguments are consistent and logical.

Is that your strategy to get me to agree with you?

It is broken for me and jthanto, and probably many more people.

I'll repeat myself yet again: it's not broken. It works exactly as intended.

And your argument is to not improve anything .. just because you have not experienced this issue or don't care.

No, my argument is to stick to what an abstraction means.
You either don't understand that or just don't like it because it doesn't fit into your coding habits.

I have alot of very complex queries, which i prefer a simpler approach of writing than just raw SQL..

The goal of using a Query Builder is to know that when you migrate e.g. from MySQL to PostgreSQL tomorrow, you don't have to rewrite your queries.
It's made for portability, not for your very complex queries that will never run on anything but MySQL. No amount of PHP code on top of what always amounts to query() call will make your queries simpler.

In most cases the query builder works out of the box.. and in other i have just hacked the library to fix the missing functionality.

Most cases are the generic SQL that would work on any platform.
You've hacked the library to break portability constraints, not to fix it.
Also, if you don't care enough to restrain yourself from monkey-patching upstream code, why are you even here? If you'd hack any upstream library to fit your personal preferences anyway, why do you care at all?

But this is not a good solution, I would prefer that CI itself takes the responsibility of actually having a good query builder with a safe and expandable method of escaping out of the box.

What you want is called magic. I don't do magic.

Can you explain why does the insert command have an escape toggle, but not the update?

I don't really remember why it was given to insert(), but I sure can tell you why it wasn't such a big deal as it is for update(). Consider these 2 signatures from CI2:
    function insert($table = '', $set = NULL)
    function update($table = '', $set = NULL, $where = NULL, $limit = NULL)

Obviously, there's room for another parameter in insert().
What I assume is not so obvious is where the would you put an extra parameter in a function that already has 4.
Do we put it at the end and force you to use the others?
Do we put it in the middle and break backwards-compatibility?
At what do we realize that we have parameter creep? (hint: we already have that and you're advocating for making it worse)
I'm not saying it's perfect, but it sure in hell not broken in the sense that you mean it.
And now that I've explained that, do you at least understand that there's other reasons for rejecting your requests other than "we don't want to improve anything"?

First of all, i said it was a narrow-minded way of thinking not calling you narrow-minded.
Second you are assuming that we as developers do not understand that we are choosing to use database specific command and that we are breaking portability (which for many is a non-issue).
There are still alot of database specific commands you can write using the query builder.
But by adding this simple functionality you are in no way harming portability for others or even affecting them at all, you are only adding functionality that allows you to safely escape what you want, where as the current method in the functions that allows escaping is everything or nothing.
I understand adding a parameter to a function already defined is a hassle, but it has been done before. And i don't see the argument that it has 4 or 5 parameters as a valid one.
Adding a function to set/add/remove reserved identifiers is all that is needed, i don't care about update not having an escape option .. i would prefer to be able to safely set what i deem is safe.
I understand your arguments and i don't agree with them.
Though i am glad you responded as this has made my decision to stop using codeigniter after almost 10 years using it and move to another framework alot easier.

First of all, i said it was a narrow-minded way of thinking not calling you narrow-minded.

This is useless nit-picking, you know that.

Second you are assuming that we as developers do not understand that we are choosing to use database specific command and that we are breaking portability

I don't assume it, though I do think many don't understand it.

(which for many is a non-issue)

It's your choice, I don't care about that.
But enabling more choices does impact the framework for others and I do care about that.

But by adding this simple functionality you are in no way harming portability for others or even affecting them at all, you are only adding functionality that allows you to safely escape what you want, where as the current method in the functions that allows escaping is everything or nothing.

This is simply not true.
Every single feature that we introduce, no matter how small, does affect other users. And that's an argument that comes after we ignore maintenance efforts and a ton of other technical considerations.

I understand adding a parameter to a function already defined is a hassle, but it has been done before.
And i don't see the argument that it has 4 or 5 parameters as a valid one.

A lot of things have been done before, that doesn't mean it was a good idea to do them.
This is not just my opinion.

Adding a function to set/add/remove reserved identifiers is all that is needed, i don't care about update not having an escape option .. i would prefer to be able to safely set what i deem is safe.

You say "all that is needed", but you really mean is "all that I demand".
Also, I said this in my second comment here:

Despite this, there is a way to override these values, if you're smart enough to figure it out ...

I understand your arguments and i don't agree with them.

Good, so we can agree to disagree then.

Though i am glad you responded as this has made my decision to stop using codeigniter after almost 10 years using it and move to another framework alot easier.

Or not, because of course - there's no way that you'd accept somebody won't submit to your demands, and if that means you'll have to rewrite your entire application just to move away, so be it.
Honestly, if you think another framework is what you need, by all means go for it. But after you calm down a bit and look at this thread after a week or so, you should be able to see how silly this looks.

First of all, i said it was a narrow-minded way of thinking not calling you narrow-minded.

This is useless nit-picking, you know that.

I am sorry if you feel offended, i did not intend that, for me there is a clear distinction between stating something is a narrow-minded way of thinking and being narrow-minded.

Or not, because of course - there's no way that you'd accept somebody won't submit to your demands, and if that means you'll have to rewrite your entire application just to move away, so be it.

The reasons i have for changing framework has been numerous over the years.
When i started using CI it was a framework with the goal of keeping things fast and simplifying tasks, Never take huge decision on the behalf of the developer and being a hindrance.
Like not provide an auth lib because there are too many variables to provide a good common solution, this is something I fully support and have no issues with, but is a dealbreaker for alot of developers.
Previously my primary reason for changing framework is because CI has been in maintenance mode the last 3-4 years.
It is not that this single issue is the reason, but the lack of innovation, and the willingness to consider another viewpoint.
I can provide a better version (because apparently i can do magic) which does not break compatibility or portability unless the developer actively chooses to do so, while making the code faster and more secure, but you have flat out denied even considering it.
And what you are calling monkey-patching i call fixing your shit. (this you can be offended by)
I would have liked to take the time to actually contribute, but looking at the history of people trying to provide contributions made me rethink this.
Yes my db driver and query builder would have a few functions which needs to be added to the documentation.
It will also fix a MAX MIN 'hack' and make adaptable to handle scenarios you cant predict, like using custom storage engines in mysql, also fix memory consumption and general speed.
But I have lost all faith in CI now and I rather use my resources on Phalcon.
I will leave with this little note taken from the bullet points on the homepage:

No restrictive coding rules

Use your own coding and naming conventions, with only a few caveats that deal with classname conflicts. CodeIgniter looks to empower you, not shackle you

I am sorry if you feel offended, i did not intend that, for me there is a clear distinction between stating something is a narrow-minded way of thinking and being narrow-minded.

Fair enough.
Angered because you've continuously ignored my argurments as I'm at least trying to give you feedback - sure, but not offended.

Previously my primary reason for changing framework is because CI has been in maintenance mode the last 3-4 years.
It is not that this single issue is the reason, but the lack of innovation, and the willingness to consider another viewpoint.

That "maintenance mode" and "lack of innovation" resulted in 700+ line changelog for version 3.0.0, and an additional 8 3.x releases after that.
Yes, we're not doing a rewrite every year, but I'm sure you know that's one of the framework's strengths.

I can provide a better version (because apparently i can do magic) which does not break compatibility or portability unless the developer actively chooses to do so, while making the code faster and more secure, but you have flat out denied even considering it.

We're already the fastest full-stack PHP framework, and one of the few that actually care about performance. No, Phalcon and other extensions don't count, because they're not the same thing.
But you'd be able to make it faster, magically and with no trade-offs.
You (and I do mean you personally) have not find a single security flaw within it, but you'll also make it more secure, just as a side effect of adding more functionality.
I'm having a hard time believing this, and I'm pretty sure you wouldn't wonder why. Talk is cheap.

What you call "fixing" is "adding stuff that you want".
And no, I'm not offended by the word "shit" either, I like to use "foul" language myself.

I would have liked to take the time to actually contribute, but looking at the history of people trying to provide contributions made me rethink this.

We welcome contributors.
What we don't welcome is self-entitled people who believe that every contribution must be accepted.

Yes my db driver and query builder would have a few functions which needs to be added to the documentation.

Seriously? Are you implying that I reject features because I don't want to document them?
FFS, if that was my problem, I'd just make documentation additions a mandatory part of every pull request (as it should be anyway).

It will also fix a MAX MIN 'hack' and make adaptable to handle scenarios you cant predict, like using custom storage engines in mysql, also fix memory consumption and general speed.

Again, talk is cheap.

But I have lost all faith in CI now and I rather use my resources on Phalcon.

By all means, go for it.

I will leave with this little note taken from the bullet points on the homepage:
No restrictive coding rules
Use your own coding and naming conventions, with only a few caveats that deal with classname conflicts. CodeIgniter looks to empower you, not shackle you

And this stands at the root of our conflict here. You're equating "shackles" with an optional feature, designed to help with a problem that you don't have, not catering to you.


⚠ Bofrost.lu has degraded performance

In f08dbb7, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1201 ms

Resolved: Bofrost.lu performance has improved in d962f6c after 20 minutes.


Project explorer

From<EMAIL_ADDRESS>on 2009-10-19T01:52:58Z
Hello,
I would find a project explorer helpful.
This would help to keep your program modularized and improve handling of
team work: just passing your project folder to a team membor or a
repository, one could start working with a simple double click on the
spyder specific project file.
It would also be very useful to have a "make exe" button for the projects
(e.g. with pyinstaller, etc...) to easily create and distribute exe files
or/and to be able to make python eggs or whatever to be able to distribute
your own projects to other systems in a fast and uncomplicated manner.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=81

From pierre.raybaut on 2010-02-20T23:50:42Z
Status: Accepted
Labels: -Type-Defect Type-Enhancement Milestone-Release1.1

From pierre.raybaut on 2010-02-21T02:01:35Z
Done! https://code.google.com/p/spyderlib/source/detail?r=169e4a5f5e176171891325a784f1d42783401323
Status: Fixed


Updated for 4.20 with support for Magic Leap platform

Magic Leap toggle is required to get a successful build in Build Graph, unless you have Host Platform Only checked.
Cheers!

TheJamsh

Hi @StormtideGames Would it be possible to do a new pull request from the latest master branch?

Will do! Feel free to close this one, looks like I need to update my version :)


wasm-logger

Hey, this seems to provide exactly the same functionality as https://crates.io/crates/wasm-logger.
Did you not know about that crate or is there something that's handled differently in console_log?
I always try to advocate for lack of duplication where possible.

I had no idea about that crate. I'll update the readme to link there.

Readme updated.
I briefly looked over wasm-logger. It appears to be slightly more extensive than this library in that it formats the log messages and does some filtering based on the log target. It also swaps the trace and debug levels, mapping trace to console.log() and debug to console.debug() which I think is incorrect.


Docs: Dialog page - The vertical scrollbar briefly appears, only to disappear forever.

Bug type
Docs (mudblazor.com)
Component name
Docs
What happened?
MudDialogInstance: Upon page load, the vertical scrollbar briefly appears, only to disappear forever.
https://mudblazor.com/api/dialoginstance#methods
https://dev.mudblazor.com/api/dialoginstance#methods
Expected behavior
An available vertical scrollbar
Reproduction link
https://mudblazor.com/api/dialoginstance#methods
Reproduction steps
Load the page.
Relevant log output
No response
Version (bug)
5.1.5
Version (working)
No response
What browsers are you seeing the problem on?
Firefox, Microsoft Edge
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Closing as it seems to have been fixed.


Rerun 2022_05_01

[x] Make a copy of the first crawl's data on GCS to not be overwritten @giancarloaf
[x] Make a copy of the first crawl's data on BigQuery @giancarloaf
[x] Enable crawling 1 level of secondary pages @pmeenan
[x] Add the ability to distinguish between primary/secondary pages in the Dataflow pipeline @giancarloaf waiting on #12
[x] Add metadata to identify the original test URL to the HAR @pmeenan
[x] Update the Dataflow pipeline to parse the page url, pageid, and requestid fields from the metadata above @giancarloaf
[ ] Flush Pub/Sub queue before starting the crawl @giancarloaf
[ ] Start the second crawl using the same URLs as before @pmeenan

Anything else?

The metadata has a tested_url field which has the page URL independent of anything the agent might do (the fixes to report URL correctly are also in place but the metadata is safest).

Lighthouse is updating to 9.6 today. Is it possible to update the test agents before the crawl reruns?

They will auto update when they spin up as long as the npm stable package
is updated
On Tue, May 10, 2022 at 8:50 PM Rick Viscomi @.***>
wrote:

Lighthouse is updating to 9.6 today. Is it possible to update the test
agents before the crawl reruns?
—
Reply to this email directly, view it on GitHub
https://github.com/HTTPArchive/data-pipeline/issues/44#issuecomment-1123057547,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADMOBN4VAG5TJDBGDYDK3TVJL737ANCNFSM5VSAYJ5Q
.
You are receiving this because you were assigned.Message ID:
@.***>

@pmeenan: the crawl should be ready to restart when you see this in the morning (Thursday the 12th).
@giancarloaf and I went through the remaining TODO items at the top of this issue and we should be good to go. I left the "flush Pub/Sub queue" one unchecked because we were still seeing some lingering messages coming through from the GCS backup of the first May crawl. @giancarloaf will be monitoring the Pub/Sub messages tonight to ensure that the queue is completely flushed by morning. (If not, at worst we'll have some summary data from both crawls in BQ, which we can clear out in SQL as needed)

@rviscomi @giancarloaf, It looks like the android and chrome May 1 crawls/ directories have tests in them (from the rogue process moving things around?).  Do they need to be moved into the backup folder first?

@rviscomi @giancarloaf, It looks like the android and chrome May 1 crawls/ directories have tests in them (from the rogue process moving things around?). Do they need to be moved into the backup folder first?

Yep, this is currently in progress using the worker vm. Rick is seeing very slow transfer rate (~100K files per hour) and has decided it would be best to start a new crawl under a different name, to be renamed later.
I will also be restarting the streaming pipeline to incorporate changes from #49 merged earlier today.

Closing this out. We're rerunning the crawl with today's date to avoid overwriting any of the previous data.


PDF doesn't resize on setting height

Hi,
Great work on vue-pdf. Exactly what I need. However, I have an issue with setting the style. When I add a width, the pdf resizes. When I add a height, it doesn't. It also doesn't work in the fiddle. Probably a (very small) bug?

Hi,
please give me your fiddle that bring out this bug.

https://jsfiddle.net/xem98a2u/1/
Changed the word "width" to "height" in your example. With width percentages, pixels, vh etc. work. With height it doesn't. Thanks for looking into this.


Login page 404

There is a problem with login and signup page.that is 404 not found page see in botom

Fixed


Fixes related to Image export & OpenGL Interop

As a continuation of my previous work, where I added semaphore export  #1606, I've been working on adding the possibility to import Vulkano textures into OpenGL.
However, a few bugs in Vulkano currently prevent this functionality from working correctly:

The memory builder was not populating its p_next structures at all, meaning memory was created neither as exportable or dedicated. I fixed this by getting rid of the old method of populating the p_next structures and instead using the Ash functionality.
The exportable image must also be created with an additional structure VkExternalImageCreateInfo. I added a method to UnsafeImage which does this, and I used it accordingly in AttachmentImage.
Issue 17 of OpenGL EXT_external_objects demands that the mutable bit be set when some common extensions are present. I thus set it to true by default, but perhaps @hakolao can provide his input on whether this would make sense when sharing images with CUDA.

The result of these issues was heavy visual corruption on the AMD radeonsi driver. Interestingly, the Intel Iris driver does not suffer from visual corruptions even with the p_next creation structures missing.
The only remaining issue at the moment is a crash happening with the Intel Iris driver, when flushing the signal semaphore command from the OpenGL side. Running a debug version of the driver, it prints out Failed to submit batchbuffer: Invalid argument. Given that the driver does not pass the piglit vk-semaphores-2 test, this is probably a problem within the Iris driver. I will submit a bug report to the Mesa repository.
I have created some sample code. This program draws to a shared texture with Glium from another thread, which is the drawn to the window by Vulkano. This texture oscillates between a black and green color. I'm interested to hear how well it works on Nvidia or with other Intel/AMD drivers.
Changelog:

Fix device memory builder not including p_next structures.
Fix exportable image not created with VkExternalMemoryImageCreateInfo.
Fix mutable bit not set on exportable image.

Related Glium MR

I forgot to add the fix to StorageImage, but now that is there as well.

@fayalalebrun I apologize for being slow in review. In general, I don't see significant issues in proceeding with merge, but my knowledge of this topic is too limited, so I would trust your experience.
However, before we proceed I would like to ask you to make the following changes:

If you think that the assert we discussed above is no longer relevant, you should either remove it, or put a comment in the code where you have commented it out of why it was commented out. It would help developers in the future in understading of the changes.
You linked a sample code in gist demonstrating this feature. I will be very appreciated if you include it in the examples directory of our repository. It would not only give other users an idea of how they can utilize these features, but it also helps in maintenance too, because we sometimes use examples for manual testing of new incoming changes. Also, I will be glad to try that new example on my local machine and give you my feedback(I have an AMD driver). Don't hesitate to add glium to the Cargo.toml of examples dir if needed. Examples crate don't affect other crates anyway, and examples aren't published on crates.io.
I noticed that you have replaced ash::vk::MemoryAllocateInfo with two in-place fields. Is it possible somehow to keep using ash capabilities to achieve desirable goal?

@Eliah-Lakhin First two points are fixed.
For the third point, my first intention was to keep an ash builder in the memory builder. However, the problem is that pushing p_next structures using ash needs a mutable reference bounded by the lifetime of the builder. Specifically, I need to store the p_next structures inside of the memory builder so that the lifetimes are equal to the builder. But also, I need to take a mutable reference of the p_next structures to push them into the builder. Thus, the memory builder would need to have a mutable reference to itself.
If there's a Vulkano struct somewhere implemented in the way you would like me to do it, let me know, and I'll be happy to do it. However, at the moment I can't think of a clean way to do it.

@fayalalebrun You can store the ash builder and the ash extension struct both in the builder, and "connect" them only when you are ready to make the final API call.

Sorry, I misread what you actually said before.

I'm interested to hear how well it works on Nvidia or with other Intel/AMD drivers.

On my AMD VegaM it works perfectly fine! :)
These are logs output:
Using device: AMD RADV VEGAM (LLVM 10.0.0) (type: DiscreteGpu)
mesa: for the --simplifycfg-sink-common option: may only occur zero or one times!
mesa: for the --global-isel-abort option: may only occur zero or one times!
mesa: for the --amdgpu-atomic-optimizations option: may only occur zero or one times!
Source: ShaderCompiler          Severity: Notification          Type: Other             Id: 1
Shader Stats: SGPRS: 16 VGPRS: 8 Code Size: 88 LDS: 0 Scratch: 0 Max Waves: 8 Spilled SGPRs: 0 Spilled VGPRs: 0 PrivMem VGPRs: 0
Source: ShaderCompiler          Severity: Notification          Type: Other             Id: 1
Shader Stats: SGPRS: 8 VGPRS: 28 Code Size: 20 LDS: 0 Scratch: 0 Max Waves: 8 Spilled SGPRs: 0 Spilled VGPRs: 0 PrivMem VGPRs: 0

@fayalalebrun Pull Request is merged. Thank you for your hard work and all the fixes! Good job! :+1:
I see that the glium's PR also merged, so I changed examples' Cargo dependency to master.


Fix pipe handling

Somewhere along the line I removed all handling of IOError so users are getting exceptions when using tools in command line pipelines (see #161). This catches and returns code 141 which I believe is appropriate behavior.

Coverage decreased (-0.1%) to 82.771% when pulling d95434a20b9c2766dd070a36bd3816cd6bd8b469 on ernfrid:bedpetobed12_pipe into 7420f8c64856cb0d67932c001496eb1ca47e47d6 on hall-lab:develop.

+1


GO:0003729 mRNA binding is currently child of poly(A) RNA binding

I just noticed this; this is a problem for prokaryotes.  Many prokaryotic mRNAs are not polyadenylated.  I don't know why the poly(A) RNA binding term is in the ontology here, anyway - as far as I can see, it only has the "mRNA binding" child term.
Thanks,
Ingrid
Reported by: imk07
Original Ticket: geneontology/ontology-requests/10837

(Asking @krchristie  for feedback as she originally commented on this ticket)
Summing up issues and comments in this ticket:

‘mRNA binding’ should not be is_a ‘poly(A) RNA binding’, because many prokaryotic mRNAs are not polyadenylated, and even in eukaryotes not all mRNAs are polyadenylated (e.g. histone mRNAs may have some alternative method of 3' end formation that does not include polyadenylation). Also, types of RNAs other than mRNA can be polyadenylated.

‘poly(A) RNA binding’ currently has a comment specifying that it should be used only for binding to the non-tail portion of a poly(A) RNA (for binding to the poly(A) tail, ‘poly(A) binding’ should be used. But there may be cases where it’s not possible to know where the binding occurs. On a related note, last year Alain Gateau (SIB) suggested:
“Poly(A) RNAs are mRNAs and not the other way around.
Some mRNA binding proteins are Poly(A) RNA binding, when they bind to the PolyA tail of the mRNAs.
The bulk of protein annotated with GO:0044822 [poly(A) RNA binding] comes from two large-scale papers (PMIDs 22658674 and 22681889) [where] the PolyA tail was used for affinity to enrich authentic mRNAs, but there is no data whatsoever telling that the proteins where bound specifically to the PolyA tail.

I suggest to rename 'Poly(A) RNA binding' to 'Poly(A) mRNA binding', to make it a child of GO:0003729, or even a child of GO:0003730 (mRNA 3'-UTR binding), and to transfer annotation from the two papers to GO:0003729.”
Looking at annotations to GO:0044822 ‘poly(A) RNA binding’ today, this is still the case - the term has 1649 direct manual experimental annotations, and only 5 are from papers other than the 2 above. I lean towards following Alain’s suggestion. My only concern is if among those many annotations, any could be to polyadenylated non-coding RNAs rather than mRNAs, since the leading author on one of the two papers wrote
“Because polyadenylated RNAs are a complex population that includes mRNAs and other RNAs, it should be a direct child of the GO-term RNA-binding” and “Introduce a new GO-term "poly(A) RNA binding" with the definition:
"Interacting non-covalently with a sequence of residues
in an polyadenylated RNA molecule."
Annotate the proteins from our and from Landthaler's paper with this new term.” [https://sourceforge.net/p/geneontology/ontology-requests/10616/]

Therefore, I suggest to

[ ] move ‘mRNA binding’ from under ‘poly(A) RNA binding’ to ‘RNA binding’
[ ] do not rename nor reposition ‘poly(A) RNA binding’, nor rehouse its annotations, but edit it as follows:
modify the definition comment from:
“Note that this term is to be used for the annotation of proteins that bind to any part of a polyadenylated RNA molecule except the poly(A) tail. For annotation of proteins that specifically bind the poly(A) tail, use 'poly(A) binding ; GO:0008143’.”
to:
“Note that this term should only be used when it’s not possible to discriminate if the binding occurs on the poly(A) tail or on other parts of a polyadenylated RNA molecule. To annotate proteins that specifically bind the poly(A) tail, use 'poly(A) binding ; GO:0008143’. Also, consider co-annotating to GO:0003729 ‘mRNA binding’ where appropriate.”

@krchristie would you agree?
I will also follow up with Alain separately by email as I don't know his GH username.

Hi,
I've just reread through this thread, and noticed with great interest this comment Paola made:
"The bulk of protein annotated with GO:0044822 [poly(A) RNA binding] comes from two large-scale papers (PMIDs 22658674 and 22681889) [where] the PolyA tail was used for affinity to enrich authentic mRNAs, but there is no data whatsoever telling that the proteins where bound specifically to the PolyA tail."
I have done quite a lot of PAINT curation of Panther families for proteins that are part of the the 90S-preribosome or the SSU-processome, both involved in the processing of the initial rRNA transcript into the 18S, 25S, and 5.8S rRNAs. A very large number of these ribosome biogenesis genes were annotated with "poly(A) RNA binding" from one of these two papers you mention here, and I am not aware that ribosomal rRNAs are polyadenylated.
Anyway, at this point in time, I am wondering what the value is of a term where the name sounds like it would be binding to the poly(A) tail, but the comment explicitly says it is for use for "proteins that bind to any part of a polyadenylated RNA molecule, except the poly(A) tail."
How is this different or more useful than just saying "RNA binding".
Thus, I would be in favor of getting rid of the term "poly(A) RNA binding" (GO:0044822) because I think that at best it is not informative, and that in reality, it is a misleading term. Whether by obsoleting or merging into the term "RNA binding" (GO:0003723) as you think best Paola, though personally, I think the merge would be fine. Certainly, I would not have objected to seeing the term "RNA binding" for the many ribosome biogenesis proteins I have annotated.
-Karen

Thanks @krchristie for your useful feedback. So the proposal now becomes:

[ ] move ‘mRNA binding’ from under ‘poly(A) RNA binding’ to ‘RNA binding’
[ ] merge ‘poly(A) RNA binding’ into ‘RNA binding’

However, we should consider the fate of those annotations (PMID:22658674 and PMID:22681889) one last time. The annotation of those papers, and to a term more specific than ‘RNA binding’, was requested directly by Matthias Hentze (Director of EMBL) 3 years ago (https://sourceforge.net/p/geneontology/ontology-requests/10616/). Jane took care of the ontology edits and @rachhuntley, then at UniProt-GOA, did the annotations (I’m nearly sure, but @krchristie perhaps you could check via Protein2GO please). I’m aware that there is an ongoing discussion about annotating high-throughput papers, but we may still wish to be careful before removing specificity where it was explicitly requested. I may not have full expertise to evaluate the methods from those papers, so let’s see if @rachhuntley remembers about annotating those. If not, I’ll contact Matthias with the proposal above.
Note that we should probably also email the GOA helpdesk (if those annotations are indeed from GOA staff) to inform them if we do rehouse those annotations.

Hi Paola,
I do recall making these annotations, and we did this with extensive review of the papers and discussion with Matthias. We do not make high-throughput annotations lightly, so I'm sure we thoroughly checked these would be appropriate to add - I added a comment in P2GO that they are HTP in lieu of a GOC tag for this.
However, I strongly suggest that you contact Matthias with this proposal as he has the expertise here, I only have what it is the papers and my dim memory to call on.
Thanks.

I looked at the SourceForge item you indicated and understand that they specifically asked for this term.
I also see in that Matthias Hentze clearly indicated in that SourceForge item that "Because polyadenylated RNAs are a complex population that includes mRNAs and other RNAs, it should be a direct child of the GO-term RNA-binding (GO:0003723)."
However, considering what the term really means, i.e. binds somewhere in some RNA in a population of RNAs that were selected for binding to oligo(dT), and especially considering what Matthias said about the fact that this is a mixed population of mRNA and other RNAs, it doesn't seem that this is really providing much specificity about what type of RNA binding is occurring. It seems to me that this term really represents an experimental technique more than a biologically relevant population of RNAs.
I also think that the term is easily misinterpreted, both because people less familiar with the technique than he is frequently assume that "poly(A) RNA" is mRNA without realizing that other RNAs are present as well.

Thanks @rachhuntley and @krchristie for your feedback. I have just emailed Prof. Matthias Hentze to summarise our concerns with the term 'poly(A) RNA binding and to suggest our proposal as above (https://github.com/geneontology/go-ontology/issues/11022#issuecomment-268271255).

Note for self: emailed Prof. Hentze again today (both him personally and his assistant too, this time).

Prof. Hentze replied:
"Dear Paola,
No problem! I have not forgotten your email from last week. In fact, I have immediately contacted my colleagues whom I consider “relevant” for their views. As soon as I have these, I will reply. I set myself a deadline of the end of this month, and I hope that this fits with your expectations.
With kind regards.
Matthias"

Prof. Hentze confirmed today that our plan is good with him and his colleagues:
"Dear Paola,
I understand the issues that you raise and I think that, all things considered, your proposal may well represent the best solution. (My co-authors and) I approve.
Thank you for your efforts - I appreciate them.
Matthias"

So now the plan is to:

[ ] Contact InterPro about their mapping: PAB-dependent poly(A)-specific ribonuclease subunit PAN3 (IPR030844) maps to GO:0044822 poly(A) RNA binding; suggest to move it to GO:0008143 poly (A) binding (“Interacting selectively and non-covalently with a sequence of adenylyl residues in an RNA molecule, such as the poly(A) tail, a sequence of adenylyl residues at the 3' end of eukaryotic mRNA.”)

[ ] Move ‘mRNA binding’ from under ‘poly(A) RNA binding’ to ‘RNA binding’

[ ] Merge ‘poly(A) RNA binding’ into ‘RNA binding’ (make sure the definition comment is removed)

[ ] Inform relevant databases of the merge above (attach spreadsheet of annotations).

@asangrador @almitchell @happy-lorna @ndrawlings @EBI-Hsinyu
Following extensive discussion with some GOC members, we resolved to merge GO:0044822 ‘poly(A) RNA binding’ into its parent GO:0003723 ‘RNA binding’. This will affect InterPro in that ‘PAB-dependent poly(A)-specific ribonuclease subunit PAN3’ (IPR030844) maps to GO:0044822 ‘poly(A) RNA binding’. I’d suggest to move the mapping to GO:0008143 ‘poly (A) binding’ (“Interacting selectively and non-covalently with a sequence of adenylyl residues in an RNA molecule, such as the poly(A) tail, a sequence of adenylyl residues at the 3' end of eukaryotic mRNA.”). Thanks in advance!
Paola

polyARNAbinding_annotations.xlsx

@slaulederkind
@srengel
This is just to inform you that, following extensive discussion with some GOC members, we resolved to merge GO:0044822 ‘poly(A) RNA binding’ into its parent GO:0003723 ‘RNA binding’. This will affect 2 RGD and 2 SGD annotations; they will be automatically moved to GO:0003723 ‘RNA binding’. You don’t need to do anything, unless you disagree and wish to recurate your annotations to a different term, or to an additional one such as GO:0008143 ‘poly (A) binding’ (“Interacting selectively and non-covalently with a sequence of adenylyl residues in an RNA molecule, such as the poly(A) tail, a sequence of adenylyl residues at the 3' end of eukaryotic mRNA.”). The affected annotations are attached for your reference (tabs ‘RGD annotations’ and ‘SGD annotations’ in the spreadsheet ‘polyARNAbinding_annotations’). Thanks!

Emailed help (at) uniprot (dot) org about their annotations. Closing now.

Hi Paola,
thanks for the heads-up.  i'm just going to let those 2 SGD annotations get automatically moved to 3723.  i will also add additional annotations to 8143 (thanks for that suggestion).
stacia

Thank you, @srengel .

For completeness, copying the reply email from UniProt below:
"Dear Paola,
I am fine with it, although we might also consider that poly-RNA is part of the
3'UTR and might be merged with 3'UTR
Concerning the 2 high-throughput articles which were curated with authors, my
opinion is that we should not have curated these papers because they generate a
lot of false positives.
I raised this problem several times during GO consortium meetings: I am not
against curating high-throughput studies, but a different evidence code should
be used.
Thanks
Sylvain"