Create Reverse Linked List

Assigned Issue Number ?
#007
Language Opted ?
C++
Number of files added or updated ?
1
Name of these files ?
Data_Structures =>Linked_List =>Singly_Linked_List=> Reverse_Linked_list.cpp
Checklist

[*] I've read the contribution guidelines.
[*] I've referred the correct issue number.
[*] I've fill up this entire template correctly.

Invalid file :warning:


Release automation

Continuing on this https://github.com/jaredpalmer/tsdx/issues/85
It would be great to automate releases so that @sw-yx can cut releases as well.

I think intuit has a cool thing with labels now called like auto. Worth a try?

https://github.com/intuit/auto

and perhaps this: https://github.com/auto-it/autobot

don't we already use circleci? i think kentcdodds uses circle to do his release automation. i've never actually added this to any of my npm projects tho, would be cool to add this

I'd love to help out with this if possible. I've previously used semantic-release to do automated package releases, and it would be pretty easy to configure a GitHub Actions job based on either that or one of the other tools mentioned by @jaredpalmer. I'd say auto is the best option, since it's probably not reasonable to hold everyone to conventional commits.
If we were to use auto and a continuous release process, I imagine that it would look something like this:

A contributor opens a pull request to tsdx master
The Labeler GitHub Action runs, matching against different file paths to determine the PR's changelog section. We won't be able to determine whether it's major, minor, or patch from this check, since that requires maintainer discretion, but we'll at least be able to sort out most internal or documentation changes.
A required "Check Release Status" GitHub Action runs, failing if there's no auto-sanctioned label attached to the PR. See here for that list.
Repeat the usual review -> request changes -> re-review workflow
A maintainer applies a version label to the pull request once it's ready to merge
The "Check Release Status" Action runs again, this time passing because auto's requirements for a release are now met
A maintainer merges the branch
A "Release" Action is initiated that runs auto shipit on the master branch

That's my initial vision for the process, at least. Is that kind of what you guys are looking for?

dripip from Prisma has a really interesting flow where basically all PRs can be pre-released without needing a full publish/release process (deciding semver, release notes, batching multiple changes into one release, etc), allowing people to unblock themselves when necessary.
I do like auto's changelog. I auto-generate mine with my fork of changelog-maker, but it's not as nice as I'd like it to be. Release Notes are contained in the version change commit.
np was added in #582 , that's more of a local publishing thing though, as CI wouldn't need all the same steps and runs a bit differently

Hey, lead author of dripip here. By total coincidence found your comment @agilgur5 😅.
We're going to be shipping changelog management in Q2. If there are blocking issues for you that absent would make dripip your choice, let me know, we can probably prioritize them.

Any progress on this one?

Dripip looks cool. Let’s do that

Hey @jaredpalmer I'd like to close a few outstanding issues if you're going to take it on. What's your ETA? I'll need a few days ideally. :)


Fixed #28925 -- Made durations-only expressions work on SQLite and MySQL.

https://code.djangoproject.com/ticket/28925

buildbot, test on oracle.

Oracle introspection failures seem unrelated.

Oracle introspection failures seem unrelated.

They're probably related with a new version of cx_Oracle I will check them later today.


Implement lacking functions in Rust SDK

This implements new functions below in Rust SDK and updates related documents and examples.

SetLabel(key, value)
SetAnnotation(key, value)
GameServer()
WatchGameServer(function(gameserver){…})

I believe this PR make that the Rust SDK have all the SDK functionality.
This PR includes reformatting code by rustfmt.
If it is not acceptable, I would make another one including reformatting code only.

Thanks for your comment.
I fixed and force-pushed the branch for it.


[Discussion] Add inspections to git

Summary:
Inspections are a part of intellij, giving us highlighting & autofixes for many common issues in code. We should share them between developers so everyone has the same experience.

It is difficult to achieve this in any automated fashion, this tool is trying but I feel is still not there.
There is the larger question of which inspections we should enable and at what severity.

@maskaravivek @ashishkumar0207 @misaochan @neslihanturan  any thoughts?

@macgills  Before we conclude something, can you elaborate, how does this generally work?

Exactly like the codestyle a file gets added to git.
The file is the settings you can see in your inspections

We would all share the same settings, be able to raise the level to get red syntax highlighting if it is something we especially don't want, turn on ones that are not on by default but should be. So on and so forth.

Good to go from my side.

We can potentially use this

Just to clarify, this would have to be run locally, right? I wonder if it is at all possible to include this in Travis CI? It would be incredibly helpful to be able to view the inspection results of any PR submitted rather than having to check locally.

@misaochan they also play an important role in the IDE highlighting which should be the first line of defence. The tool I linked in the description is for running inspection commandline but I don't trust it and it would probably add bloat to the build time.
We could encourage people to commit via AndroidStudio as one of the checkboxes is run inspections on VCS changed text in the commit dialog? I don't like this option too much as the in built VCS is a bit lacking.
Inspections don't have the idea of a baseline where we have a list of accepted legacy issues (aside from suppressions) so it would be a bit difficult to integrate into a pass/fail flow.

Thanks for the clarification. :) I'm on board with adding the file to git.


Add egN_ampeg

This implements opcode egN_ampeg, allowing a flex EG to override the ampeg.
Notes:

when multiple flex EG have egN_ampeg, the lowest one becomes the amp EG
ampeg has been matrixed; depending if the sfz uses flex ampeg, either v1 ampeg or flex gets connected to amplitude
under ARIA, one can have both egN_ampeg and egN_amplitude in a region, and they both take effect.
That means the equivalent of 2 independent connection (egN->amplitude) in the MM which must coexist.
Since we can't represent this, I created a special target MasterAmplitude which is reserved for ampeg and is always connected.
this doesn't implement fast release, so I left in Voice.cpp some TODO comments "Flex AmpEG"

In this way, ARIA and sfizz work in equivalent way.
Except
There is a bug, which I'll do separately, it's that ARIA goes directly to the point after sustain on releasing the EG, whereas ours finishes to go through intermediate points first.
<region>
sample=*sine
eg15_ampeg=1
eg15_time1=.1  eg15_level1=.25
eg15_time2=.15  eg15_level2=1
eg15_time3=.2  eg15_level3=.5 eg15_sustain=3
eg15_time4=.4 eg15_level4=1
eg15_amplitude=100

On tapping the key, you can observe the problem on scope quite easily.

Hi Jean,
I have tested the branch, but the test example below does not look like it's working:
<region>
sample=*sine
eg1_time1=0  eg1_level1=1
eg1_time2=1  eg1_level2=0
eg1_time3=1  eg1_level3=.5 eg1_sustain=3
eg1_time4=1  eg1_level4=1
eg1_ampeg=1

From Discord discussion- I would have expected for the plot to look like the one you provided? Maybe my FlexEG is wrong?

@alcomposer stages with time=0 needed a special case, done in a137edc. Thanks for noticing.

Other than the startRelease part I see no glaring issue. Thanks alot !
Btw I added stuff to the boolean opcode helper, is it what you meant in #440?

It's indeed what I mean but it lacks some cases.
I recall that under ARIA, numbers ≠ 0 pass as true for booleans.
Preferably, this routine should parse numbers. (also I'd review all possible cases of cw/aria, and what happens for real value 0.1)

Regarding booleans, ARIA's behavior is surprising to say the least.

egN_ampeg, any value enables it, no matter if 0, 1, on, off, or anything else


SDC plugin does not output the BUFG out clocks anymore

With the clock propagation enhancements done in https://github.com/SymbiFlow/yosys-symbiflow-plugins/pull/54, the resulting SDC does not take into account the output clock from BUFGs connected to the PLL outputs.
This causes VPR to not correctly constrain clock signals, resulting in higher run-time and an nan CPD, such as in the following example:
PLLE2_ADV #(
        .CLKFBOUT_MULT(4'd12),
        .CLKIN1_PERIOD(10.0),
        .CLKOUT0_DIVIDE(5'd20),
        .CLKOUT0_PHASE(1'd0),
        .CLKOUT1_DIVIDE(3'd5),
        .CLKOUT1_PHASE(1'd0),
        .CLKOUT2_DIVIDE(3'd5),
        .CLKOUT2_PHASE(7'd90),
        .CLKOUT3_DIVIDE(3'd6),
        .CLKOUT3_PHASE(1'd0),
        .CLKOUT4_DIVIDE(6'd48),
        .CLKOUT4_PHASE(1'd0),
        .DIVCLK_DIVIDE(1'd1),
        .REF_JITTER1(0.01),
        .STARTUP_WAIT("FALSE")
) PLLE2_ADV (
        .CLKFBIN(pll_fb),
        .CLKIN1(crg_clkin),
        .RST(reset7),
        .CLKFBOUT(pll_fb),
        .CLKOUT0(crg_clkout0),
        .CLKOUT1(crg_clkout1),
        .CLKOUT2(crg_clkout2),
        .CLKOUT3(crg_clkout3),
        .CLKOUT4(crg_clkout4),
        .LOCKED(crg_locked)
);

BUFG BUFG(
        .I(crg_clkout0),
        .O(crg_clkout_buf0)
);

BUFG BUFG_1(
        .I(crg_clkout1),
        .O(crg_clkout_buf1)
);

BUFG BUFG_2(
        .I(crg_clkout2),
        .O(crg_clkout_buf2)
);

BUFG BUFG_3(
        .I(crg_clkout3),
        .O(crg_clkout_buf3)
);

BUFG BUFG_4(
        .I(crg_clkout4),
        .O(crg_clkout_buf4)
);

Resulting SDC:
create_clock -period 16.6667 -waveform {0 8.33333} crg_clkout0
create_clock -period 5 -waveform {0 2.5} crg_clkout3
create_clock -period 40 -waveform {0 20} crg_clkout4

This example is taken from the LiteX mini design, for which the crg_clkout1 and crg_clkout2 clock nets are unconnected, therefore they do not end up in the SDC, and this is expected.
The problem though is that the correct SDC for VPR should have also the crg_clkoutN_bufN clocks as well.
I notice also that the clock constraint for the input clock net to the PLL is missing as well.

@acomodi So the current behavior is expected as the clock parameters (period, waveform) on the BUFGs are the same as on the PLL output wires that are driving them.
So what you expect is the following SDC:
create_clock -period 16.6667 -waveform {0 8.33333} crg_clkout0
create_clock -period 16.6667 -waveform {0 8.33333} crg_clkout_buf0
create_clock -period 5 -waveform {0 2.5} crg_clkout3
create_clock -period 5 -waveform {0 2.5} crg_clkout_buf3
create_clock -period 40 -waveform {0 20} crg_clkout4
create_clock -period 40 -waveform {0 20} crg_clkout_buf4

Of course what is worrying is the fact that the clocks for crg_clkout1 and crg_clkout2 so CLKOUT1 and CLKOUT2 outputs of the PLL are not in the SDC. Is the SDC you pasted complete?

Of course what is worrying is the fact that the clocks for crg_clkout1 and crg_clkout2 so CLKOUT1 and CLKOUT2 outputs of the PLL are not in the SDC. Is the SDC you pasted complete?

@tmichalak Those are absent as the test is the minilitex one, wihtout DDR and Ethernet. Yosys prunes away the BUFG related to CLKOUT1 and CLKOUT2, and the SDC plugin discards those nets and does not output them in the final SDC, so that SDC is complete indeed.
What is missing though is also the CLKIN to the PLL which I am not sure why was not added.

You mean CLKIN1? Well, it's driven by some explicitly added clock thus is itself neither an explicit (added by create_clock) or generated (propagated from the explicitly added clock wire but with different clock parameters).

Poke?

What is the status here?

@acomodi from my perspective the current behavior is expected. So adding this exception would be VPR specific. @litghost thoughts?

The main issue comes from the fact that VPR is not able to propagate the clocks.
If the SDC lacks sys_clk, the entire logic of the LiteX core will be unconstrained at the moment.
I think that, for the time being we should output the SDC relative to all the clcock different clock netlists that are outputs of clock tiles (namely, BUFG, PLL, etc.).
As a longer term solution we might need to add capabilities in VPR to understand that a clock net that, for instance, passes through a BUFG, has the same constraint as the PLL output.
In this case sys_clk will have the same constraint applied to crg_clkout0 applied.

So I believe the fixes in #54 are good, but we do need a "verbose" SDC output for VPR.  So make write_sdc needs a -include_propigated_clock option, and we use that for VPR?

@acomodi @litghost Adding a switch will work.

@tmichalak - Yes, we most certainly want to be able to write a SDC file with all clocks propagated, that was one of the points of pulling the data into Yosys in the first place...

@acomodi @litghost @mithro I created a PR with the include_propagated_clocks switch: #65


New Tab: IBC

Part 1 of #248
Does not address design, just functional elements. Design to come next. Updates:

Replaces governance for new IBC tab
Adds logic about what assets can be ibc-withdrawn
Add validation checks (via new bech32 functions)
Add tx details page for ics20 withdraws

I get this error when trying to enter amount greater than 2, while I have a note c amount 2.
It looks like I can't spend more than one note with IBC withdrawal

@Valentine1898 let's pair on that error you're seeing


Wrong selection of event type when creating/updating a webhook via Gitea API

Description
Example to create a webhook that would be triggered on specific custom events:
curl -X POST \
  "http://host/api/v1/orgs/org_name/hooks" \
  -H "Accept: application/json" \
  -H "Authorization: token $TOKEN" \
  -H "Content-Type: application/json" \
  -d '{
    "active": true,
    "type":"gitea",
    "events": ["issues","issue_comment"],
    "config": {
      "secret":"123",
      "content_type":"json",
      "url":"http://domain/webhook.php"
    }
  }'

The events that should be set here are Issues (Issue opened, closed, reopened, or edited) and Issue Comment (Issue comment created, edited, or deleted), however all issue-related events are set. The server's response contains
"events":["issues","issue_assign","issue_label","issue_milestone","issue_comment"]
and the webhook's settings on the web interface has all options checked under Issue Events.
Same thing happens with the pull_request event which should correspond only to opened/closed/reopened/edited event type but instead sets all pull request events.
Gitea Version
1.21.11
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
Binary download, systemd
Database
None

Looking at the code further:
https://github.com/go-gitea/gitea/blob/059b2718a5615c01b897283f6ae53c9702f11239/routers/api/v1/utils/hook.go#L150-L152
It appears passing "issues" is treated the same as setting all of the issue-related events. What you are looking for is the "issues_only", as we see here:
https://github.com/go-gitea/gitea/blob/059b2718a5615c01b897283f6ae53c9702f11239/routers/api/v1/utils/hook.go#L191-L195
Running your input (but using issues_only instead of issues) using the swagger API, we can see that we do get the desired output:
{
  "id": 5,
  "type": "gitea",
  "branch_filter": "",
  "config": {
    "content_type": "json",
    "url": "http://domain/webhook321.php"
  },
  "events": [
    "issues",
    "issue_comment"
  ],
  "authorization_header": "",
  "active": true,
  "updated_at": "2024-04-30T05:20:15Z",
  "created_at": "2024-04-30T05:20:15Z"
}

The pull_request event also does something similar to this as well. It is weird seeing that we need to pass issues_only event only to return an issues event. I would rather have issues be what we expect it to be and instead use a issues_all so that we know that we are trying to listen to all issue-related events.

Both issues_only and pull_request_only work fine. Should I close the issue then?


Create VM - Allow valid only calls to onUpdate functions in CreateVmWizard

In order to better support input validation in the wizard steps, the onUpdate functions have been updated to allow calls that only
update the step's valid state.  Now, a step can flag itself as invalid thereby preventing navigation off the step until the input is fixed or canceled.
This change will enable consistent validation updates on #1219, #1221, #1228, #1233

ci test

steps to reproduce:

Start the create vm wizard dialog.

Navigate to storage/networking step.

Add new disk/nic and save the new row.

Oh that one is INTERESTING!
So, immer creates objects that are not mutable (really this is accomplished by making the object frozen).  The list of nics being passed down to the Networking component is immutable.  The component SORTS the array before rendering it.  Array.sort() in JS is an in-place operation.  Can't sort an array that is immutable!
The fix, in this case, is to move the sort() below the map().  Array.map() creates a new array.  The new array is mutable / is not read-only.  Now the sort is applied to the array created by map() and it's all working.
I didn't hit the error during unit testing because the array sort didn't need to do anything for my set of nics.  Some lucky combo of default names and not creating more than 1 or 2 nics.
I'll post the fix shortly.

Except the "move backward" behavior, which we should consider to change to allow users move to the previous step, but you raised that on the stand-up so I assume we will change that, or at least discuss that...

With this PR I do not want to change the allowed navigation.
As originally intended, a step must be valid before moving off of it.  Right now an active add/edit for a Nic or Disk will allow you to navigate off the step.  What is done with the active edit isn't clear to the user.  That was always intended to be changed to while there is an active add/edit, keep the user on the step.  The user needs to explicitly commit the change (and deal with any input validation issues at that time) or cancel it.  We'll deal with that in the validation PRs.


Update numpy to latest

Closes #1766

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: gsheni:x: cp2bostonYou have signed the CLA already but the status is still pending? Let us recheck it.


Question about percentiles in Bayesian early stopping

As I understood from code, percentiles values for regular delta and group sequential delta are using t statistics.
e.g. in the result object, "pctile" could be (2.5, 50, 97.5), "value" can be the corresponding t statistics (0.1, 0.8, 0.1).
On the other hand, percentiles values for two Bayesian delta are using a fixed 0.95 credible interval.
In the result object, "pctile" is always ("lower", "upper"), "value" is the corresponding index of posterior distribution.
I think they are two completely different concept, and if I understood correctly, should we put them into different columns in the result object?

ok, on second thought, they have something in common in higher abstraction. ;)
One can find the "value" of the random variable being tested, given a defined metric "pctile"

in frequentist approaches pctile is the percentile of the test distribution
whereas in Bayesian approaches pctile is the lower/upper bound of a 0.95 credible interval of the test distribution.

exactly, sorry haven't had time to look at this sooner. @gbordyugov has worked on a new concept for the Results structure so these issues will be taken into account, but for now I would not mess with it much... for testing the early stopping methods I believe the current implementation should suffice.

closed since the structure of result object is under planed


Save azimuth carrier and flattening phase into HDF5

This PR adds the ability to save to HDF5 azimuth carrier and flattening phase. Requires ISCE3 features not yet merged into develop.

@LiangJYu can you address codacy issues? I guess the CI is failing because we do not have an ISCE3 conda release that supports the ramp and flattening phase. @seongsujeong, please review this PR


2.1.3

Adds code to prevent the keyboardResponding view from being offset if the viewController is being displayed in a popover.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 3 committers have signed the CLA.:white_check_mark: br-johndavis:x: John Davis:x: BR-Nathan-ChiuJohn Davis seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 3 committers have signed the CLA.:white_check_mark: br-johndavis:x: John Davis:x: BR-Nathan-ChiuJohn Davis seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Warnings

:warning:
No CHANGELOG entry added.

  Generated by :no_entry_sign: Danger Swift against 4bf0a29df21d44ceac752c18b79dab539eba2851

Warnings

:warning:
No CHANGELOG entry added.

  Generated by :no_entry_sign: Danger Swift against 4bf0a29df21d44ceac752c18b79dab539eba2851

This looks good to merge after we take care of a couple of housekeeping items:

Need to add an entry in CHANGELOG.md
Need to get these authors to sign the CLA on this page

@br-johndavis looks like you might have another GitHub account that you made commits with? @BR-Nathan-Chiu it looks like some of your commits got brought in here. Could you sign the CLA on this PR as well?

This looks good to merge after we take care of a couple of housekeeping items:

Need to add an entry in CHANGELOG.md
Need to get these authors to sign the CLA on this page

@br-johndavis looks like you might have another GitHub account that you made commits with? @BR-Nathan-Chiu it looks like some of your commits got brought in here. Could you sign the CLA on this PR as well?


Unable to download the Firefox extension

I'm unable to download the Firefox extension. It seems the link is not working. A zero byte file is download if I save the contents to a file.

Hey yeah sorry about that, I realised a while after publishing this that the link only works for me.
If you're comfortable with JavaScript you can clone and build the extension locally.
Otherwise, I would recommend sticking to the bookmarklet described in the main Slurp repo's README.
At the moment the extension doesn't offer any advantages over the bookmarklet other than it would live in your toolbar rather than bookmarks.
I'm planning to revisit the extension after adding options like tags and save location to the note capture screen. That way the extension will have more to offer than simply a clickable button.
Thanks for the report though! I'll update this issue when a proper release for the extension is out.


[bug] Can't build due to an SSL issue

Tried to run the curl command in the script:
curl https://dl.xyrillian.de/jmdict/entrypack-v1-2021-07-19.json.gz seems to state that the SSL certificate on your domain has expired :(

My certificate looks fine. I'm guessing that your CA bundle is outdated, see https://scotthelme.co.uk/lets-encrypt-old-root-expiration/


Example react native test app

Overview

Fixes #583
Updated example project with react native test app. Re used App.js code. 1.4.6 was the version for react native 0.63.
Link to discussion: https://github.com/microsoft/react-native-test-app/issues/1155
Test Plan

Awesome! Will review soon

@Naturalclar I have done the changes you requested.  yarn lint --fix Did  not do any changes to commit.


fix: set alternatives to python3 for RHEL8

Which issue(s) this PR fixes

Fixes #75
Additional comments

This change raises an issue when running ansible up to 2.12.
[DEPRECATION WARNING]: Distribution centos 8.7 on host edge-01 should use /usr/libexec/platform-python, but is using /usr/bin/python for backward compatibility with prior Ansible releases. A future Ansible release will default to using the discovered platform python for this host. See
https://docs.ansible.com/ansible/2.9/reference_appendices/interpreter_discovery.html for more information. This feature will be removed in version 2.12. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.

I think we should specify somewhere to use ansible_python_interpreter=auto . I think its location is in the ansible.cfg in getting-started
Agreements

[x] I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004.
[x] I hereby agree to grant TOSIT a copyright license to use my contributions.

As discuss, many pros, many cons, so merge and yolo


Kyma update

Jan release of cds-dk  introduced some breaking changes and better support for HDI Shared instances on Kyma.

Creating DB Secret step is now optional. It is only required if someone is using BTP Trial Account.
Some keys like html5_apps_deployer, hana_deployer etc were moved/renamed.

Hi @stewsk , can this be merged?


local-and-global-bgp.md

local-and-global-bgp.md
This file is too big for its current purpose. Please work on to take out some part of it to our /guides section and link it here. For more info - @jacobsmith928

@Naji-F-Pride can you help condensing this?

This was shortened as of PR #302 .


Codegen - Generate schema dependent record

Hi there,
I'm trying to generate code with Codegen using two schemas.
In device.avsc, I have a record of type Device.
In status.avsc, I have a record of type Status that have a field of type Device.
I tried to first generate device.avsc and then status.avsc and to use both schema to generate one go file but Codegen says that the type Device is undefined.
Is there a way to make that happen ? If not, do you have ideas to modify Codegen in order to make that possible ? I'm willing to help.
Thanks and regards,
Albin.

I have same issue


Last PR for the Summer

Amazing @iankronquist ! Throws in a last PR on his way out the door... Kudos!

@hlindberg thanks! And thanks for your mentorship throughout the Summer.


Scanning without a preview

Is it possible to do the scanning in the background of an app's view? Without showing the scanning preview.

Currently you need the scanning preview. It may be possible to use some hack to hide it, for example by placing an overlay on top of it or making the preview very small, but it may give issues on some devices (some devices may have a minimum preview size for example).
The Android Camera2 API, available from Android 5.0+, would support capturing the camera data without any preview as far as I know. This library doesn't support it yet though.

Thanks for the answer. Unfortunately I'm using the Google Glass, so stuck at Android 4.4.4.

It may be possible on Android 4.x, using SurfaceTexture. See this post: http://stackoverflow.com/a/14227517/214837. It's not something I plan to support in the library, but it should be possible to fork this library and do something like that.

Do you know if there is a fork implementing this?


Change dropdown colors

Hello,
Is it possible to change the colors of the dropdown?
I have tried it many ways but I can't access it through css classes.. not even when I'm trying like:
#midCol > div.panel-heading > h4 > ng-select > select-dropdown > div {
    background-color: #a94442;
}

could you provide me any solution? The white dropdown doesn't really fit in my page, neither the blue heighlight..

select-dropdown > div .options - For unselected
select-dropdown .highlighted - For hover
select-dropdown .selected - For selected
background-color and color both worked on each of these selectors without a problem for me

@mval1002
Unfortunately only the focused (.highlighted) and selected works, but I will change the dropdown background color itself.. and the .options doesn't work :(

Hmmm... I checked them all before posting. I guess it's possible that you have other CSS rules causing a conflict?
Also, note the space after > div - .options is a child of that, so if you leave out the space it wont work.
I would also try adding !important to your rules. While it's generally frowned upon to use it, it's helpful in finding if there are other selectors overriding what you expect, or if you have the wrong selector altogether.

The style rules proposed by @mval1002 work for me as well, I don't think this an ng-select issue. If you need help getting your CSS to work, please use something like stackoverflow.


Disable some fields on Drag and Drop box

My data is not big (<30000 records), however, some fields have a number of unique values are over 10.000. That makes the page is very slow and crashed when drag and drop. Therefore, is there any way for disabling those fields which have a number of unique values is over 1000?

I think you should set like Pagination in SQL stored or API service first. when move next page it show next record, it easy for you!! Like datatable serverside

I think you should set like Pagination in SQL stored or API service first. when move next page it show next record, it easy for you!! Like datatable serverside

The problem is the number of "unique value" of a data field (such as "PRODUCT" has 10000 different values) that makes the number rendered table cell is too big. That leads to a page will be crashed or loaded slowly.

It would be fairly easy to accept a list of “draggable” attributes in the
API. Not as adaptive as computing this from the cardinality but might meet
your needs?
On Mon, Sep 24, 2018 at 21:09 hpduy<EMAIL_ADDRESS>wrote:

I think you should set like Pagination in SQL stored or API service first.
when move next page it show next record, it easy for you!! Like datatable
serverside
The problem is the number of "unique value" of a data field (such as
"PRODUCT" has 10000 different values) that makes the number rendered table
cell is too big. That leads to a page will be crashed or loaded slowly.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nicolaskruchten/pivottable/issues/1006#issuecomment-424174191,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMbAyE8rFit2q60py-B_bg1CID3Aab5ks5ueYJIgaJpZM4WiuN7
.

Currently, I solved the problem by following this way. I just wanna confirm that whether we can solve it in a client-side or not. Because I see a number of unique values is shown on the filter box. So that I think it is possible for using that number for display. But anw, it also be fine to be solved on server side, thank you for your reply.

It would be fairly easy to accept a list of “draggable” attributes in the API. Not as adaptive as computing this from the cardinality but might meet your needs?
…
On Mon, Sep 24, 2018 at 21:09 hpduy @.***> wrote: I think you should set like Pagination in SQL stored or API service first. when move next page it show next record, it easy for you!! Like datatable serverside The problem is the number of "unique value" of a data field (such as "PRODUCT" has 10000 different values) that makes the number rendered table cell is too big. That leads to a page will be crashed or loaded slowly. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1006 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMbAyE8rFit2q60py-B_bg1CID3Aab5ks5ueYJIgaJpZM4WiuN7 .


Option for sending an incorrect/invalid UUID for player list entries

This makes it impossible for players to check for nicknames through the player list and disables reporting which some servers may want.

I'm pretty sure first of all that this is associated with the XUID, not UUID. Sending invalid values for this would probably break things. I'm not sure this is worth implementing.

In gohpertunnel:
type PlayerListEntry struct {
	// UUID is the UUID of the player as sent in the Login packet when the client joined the server. It must
	// match this UUID exactly for the correct XBOX Live icon to show up in the list.
	UUID uuid.UUID```

Without this, clicking a player with an edited display name in the pause menu would reveal their original name, since it comes from XBL. Hell for content creators.

Hell for content creators? Could you elaborate?

The server can change the name here:

But can't change the name here:

This makes it super easy to check if a player is nicknamed to avoid targetting.

Just tested this out, yes, it is the XUID that needs to be removed not the UUID. It just displays like an offline mode player.


Add GitHub actions to address GNU/Clang warnings

The intent here is to address warnings coming from include/vk_mem_alloc.h and make sure it stays fixed by having it as part of CI.
NOTE: By default VMA_BUILD_ERROR is OFF to not cause package managers any trouble.
Split up into atomic commits to highlight fixing the compiler warnings.

I'd like to add some rational to this.
While some users consume VMA via system include commands like -isystem dir not all do. And many users don't even know about -isystem dir. So they just silence warnings in their project after introducing a dependency.
And for MVSC the problem is even worse because until very recently they didn't even have an equivalent to -isystem.
So the best thing for project to do is to make sure that their public interface is as clean as possible. Which is what I'm trying to do here.

Thank you for this proposal.
Successful build of the library is already validated in Windows + Visual Studio:
https://ci.appveyor.com/project/adam-sawicki-amd/vulkanmemoryallocator/branch/master
As well as Linux + GCC and Clang:
https://app.travis-ci.com/github/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator
We may consider enabling GitHub actions instead in the future.
Regarding compiler warnings, documentation explicitly says in chapter "Features not supported":

Code free of any compiler warnings. Maintaining the library to compile and work correctly on so many different platforms is hard enough. Being free of any warnings, on any version of any compiler, is simply not feasible. There are many preprocessor macros that make some variables unused, function parameters unreferenced, or conditional expressions constant in some configurations. The code of this library should not be bigger or more complicated just to silence these warnings. It is recommended to disable such warnings instead.

The change you proposed that adds break; in two places actually changes code logic and makes it incorrect. Fallthrough is intentional there.

The change you proposed that adds break; in two places actually changes code logic and makes it incorrect. Fallthrough is intentional there.

You should add a "fallthrough" comment to those. It both tells the reader that it's supposed to fall through and silences the warning.

I added macro VMA_FALLTHROUGH non-empty only when C++17 is enabled + a comment with word "Fallthrough". Please let me know if it works for you.

That handles it nicely :+1:


Explorer Path Issue

Kind of an odd issue from the SharePoint migrations I have performed and this issue being the first one and wanted to see if I could get some help. I am working with a client where the files are migrating to a Teams site but once the users sync the general's folder in the document library some of the folders deep down the tree are breaking that 256 character limit through the migrations I have complete normally I would see that be a scan issue I can resolve before the migration takes place. Any help would be great,

Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


🚀 Feature: Expand catalog processing metrics to allow split by entity kind

🔖 Feature description
The catalog processor currently enables a few default collected metrics that can be used to get insights on processing queue delay, how long the whole processing flows takes, etc.
This feature would be an extension to the current metrics collector in order to allow the same type metrics to be collected per entity type giving us an overview of how much the impacted metrics are corresponding to an specific type of entity.
For example, considering the processing queue delay, this feature would show us what percentage of the queue delay is due to the  processing of kind X entities.
🎤 Context
Considering the processing queue delay example, having a split of affected processing time per entity type can allow a better overview of which sources/data structures and processes most impact the current delay.
This enables us to specifically target improvements and implementation enhacements to a processor that has a greater impact in the queue delay.
The focus of this feature is mainly to obtain metrics and data about the processing flow to allows us to make the whole catalog refresh and flow more efficient.
✌ Possible Implementation
Just an idea that needs further thinking/discussion - allowing these metrics to be labelled by kind would enable the mapping of the desired split:

👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

I added this as a topic for discussion during Catalog SIG on Jan 10th.

Let's keep this ALIVE!


feat: additional MOTD, grub entry, and os-release polish

removes Fedora trademark use, while adding a note that secureblue is "powered by Fedora Atomic"
sets grub to secureblue (powered by Fedora Atomic)
adds secureblue info to /usr/lib/os-release
include glyphs in the MOTD to prettify it further
include the nerdfont needed for glyphs in the motd, plus three other fonts that are unavailable from rpm

You forgot to remove gdm logo:
fedora-gdm-logo.png

need to add rpm-ostree override remove fedora-logos instead


Appointments 'In-Progress'

These would show the status of the appointment, live
Part of a broader idea to let users with a given link access the appointment 'schedule, status and logs'
Kinda like Uber links that show where the car is

While the idea of letting users access a link to see the appointments is good and will be implemented ...
the 'in-progress' model seems unnecessary. Discarding


Do not specify TemplateHaskell in the Cabal file

It is not used, it seems.

Better late than never... Thanks! :-)


fixed the inconsistent parameter name in run_circuitset_and_measure

I am submitting this PR because having different parameter names (circuits vs circuitset) between for the  same method (run_circuitset_and_measure) in QiskitBackend and QiskitSimulator (unless there is a good reason that I'm not aware of) is driving me crazy. Sorry :)

I did it locally, but forgot to push the changes, will do it in a sec!

@mstechly Could you please merge and delete the branch if everything looks good? 🙏


Switch to native rails redis support

And remove dependency on deprecated redis-activesupport gem
Will require a new redis server for caching because this does not well support storing caches and lock keys on the same database.

We'll keep using REDIS_URL for the non-cache version, e.g. for background jobs, but then REDIS_CACHE_URL specifically for cache items?

We'll keep using REDIS_URL for the non-cache version, e.g. for background jobs, but then REDIS_CACHE_URL specifically for cache items?

Yeah, I left the uses of REDIS_URL that seemed to be pointing at that (the ones for $redis) alone.


Add image classification processing guide

This PR follows up on #4710 to separate the object detection and image classification guides. It expands a little more on the original guide to include a more complete example of loading and transforming a whole dataset.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


MST/transport: send source public key in MstState

Also make state storage identify peers by their public keys.
Description of the Change
Before this change MstState messages consisted of a transactions batch and the destination peer description. The receiving part interpreted the peer description as the source peer which the message came from, which is obviously an error.
In this patch, I replaced the peer description part of MstState message with the source peer's public key, which the receiving part uses to identify the receiver. Note that this change is not addressing the authentication of message.
Benefits
Fixed the MST State propagation.
Possible Drawbacks
Yet to be found.

Also, pls add TODO(and task) for fixing dependencies of mst_processor_test


Fix statistics for released MGMT SDK

Fix statistics for released MGMT SDK.
test link: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4177040&view=results

/check-enforcer override


Revise qBittorrent Instructions and Clarify Environment Setup in CONTRIBUTING.md

Problem Description
In the Contribution.md file, qBittorrent is mentioned at the top. However, Flood has difficulty connecting to qBittorrent, especially versions beyond 4.4.3. This creates confusion for new contributors who face challenges setting up the environment for this project.
Proposed Solution
To address this, we suggest either of the following options:

Remove the instructions for qBittorrent from the CONTRIBUTING.md file. Retain instructions only for Transmission.
OR

Shift the qBittorrent instructions below the Transmission instructions in the CONTRIBUTING.md file.
OR

Add instructions for setting up rTorrent in the CONTRIBUTING.md file, alongside the instructions for Transmission.

Are you working on this issue? (Yes/No)
If you find this issue relevant, I can start working on it.

I don't find this as a legit issue. I have been using qBittorrent and it works pretty well. If you face some issues with it and find a way to resolve that then please create a issue for that and we can move forward with that but make changes suggested for resolving the issue is not a correct way.

Okay, I'll surely keep it in mind from next time.


Changed to split in chunks

Changed readline implementation so that read sizes are correct.
The read line is saved including newline (\n).
Added readChunk to read in chunk units.

This PR improves memory usage for large files and speeds up as well.


Do Not Copy When Target Element Has display:none

The content does not get copied when the target element has display:none.

Hey @shefik, there is a workaround for this situation.
You can do something like this:
On HTML:

On JS:
new ClipboardJS('.test');
let clipBoard: HTMLElement = document.querySelector('.test');
clipBoard.setAttribute('data-clipboard-text', 'the string you want to copy');
clipBoard.click();

As far as I remember, you cannot implement a copy of hidden elements without temporarily showing them first.  Browser-based security blocks this and no coding can get around it (aside from showing said elements).

As @netniV mentioned, it isn’t possible. I’ll close this issue considering it isn’t related to the Clipboard implementation.

A workaround I used was that instead of the target element having display: none I moved the element off of the screen with position: absolute; left: -10000px

Yes, that would work around the issue because it's technically visible from a DOM perspective, it's just not visually available to the end user.


Use debugger in conjunction with with interactive python terminal

I just found out about your the interactive python terminal function, and I think it is amazing. However, while reading through the documentation I wasn't sure if it is possible to add debugging breakpoints inside a script that is executed with the interactive Python terminal.
What I tried to get it to work
I tried to use the run current file in Python Interactive terminal right click dropdown menu option on the following test script which has a breakpoint on line 4

What I expected to happen
I expected the debugger to stop on lin4 while the interactive python terminal variable explorer showed the test variable.
What happened
The python terminal didn't stop at the debug breakpoint.

This feature is actually already under way (should ship soon).
https://github.com/microsoft/vscode-python/issues/3876

@rchiodo That's amazing thanks for telling me.


Run gulp through Docker

Part of https://github.com/libero/libero/issues/37
The testing process is not separated from the build process at the moment, so we do everything but the export within the Docker container build process. Files will be extracted from there for packaging.

Merging this to then work on the Github release.


Right click to edit suggestion in chat editor.

When displaying a suggestion, left click will send the suggested question.
If the suggestion is close to what user will input, a right click could copy the suggestion in the editor in order to be able to edit to the user needs.

This could be edited to ask "How can I configure the SvelteKit adapter for deploying to Azure Static Web App", while the area where the suggestion is displayed could host "Press enter to submit, escape to go back".

Copy/paste should be pretty quick too


printf(%c, x) : pulling in libg_nano stuff ?

Hi,
I'm most likely something wrong here, I'm not sure...
#include <stdbool.h>
#include <string.h>

#include "printf_config.h"	//just to get PRINTF_ALIAS_STANDARD_FUNCTION_NAMES...
#include <printf/printf.h>

.........
			printf("eos_string: 0x");
			//printf("%c", eot_char);

I'm compiling this for embedded (ARM CM0) targets with nano.specs etc, and everything works as expected until I uncomment that second printf : then the linker tries to locate a bunch of libc stubs that are missing , e.g. _sbrk , _write_r, _seek_r etc (as I would expect if I was using the  stdio printf ).
Is there anything special about using the "%c" specifier on its own ? If I replace that second printf with a %d ,  it'll work... Or if I change the formatter as " %c (i.e. adding a space in front), that also works fine !

Is there anything special about using the "%c" specifier on its own ?

Nope, nothing special about it. Also, as you know, the only things the library takes from the standard library are the definitions in:
#include <stdbool.h>
#include <stdint.h>

and that's that.

If I replace that second printf with a %d , it'll work... Or if I change the formatter as " %c (i.e. adding a space in front), that also works fine !

Could it perhaps be some special optimization in your compiler? Maybe it replaces printf("%c") with putchar()?

Could it perhaps be some special optimization in your compiler? Maybe it replaces printf("%c") with putchar()?

10/10 . I just checked the disassembly of the .o for that module and that's exactly what is happening. Thanks !
Of course I can put putchar_() there myself but I'll try to find a "clean" way to do this. Maybe alias putchar() to putchar_ or something.

Maybe... I notice it does the same thing with a printf() with no formatters, replacing it with puts()... usually gcc bug reports for embedded stuff like this falls on deaf ears though.

@fenugrec : If you file it, I'll comment favorably and upvote :-)
Anyway, I know they take a long while to handle bugs, but then a few years later, it sometimes happens. Think of it is a s a civic duty.

@kjsdf7wr3 :

Which compilers support -fno-builtin-printf?
Which compiler were you using? The compiler should not do this if the source file has not, at the very least, included stdio.h .

1. Which compilers support `-fno-builtin-printf`?

At least gcc and clang
I'm fairly certain I did not have an #include <stdio.h> in there. With gcc, I think this due to the following:

The ISO C90 functions [......] printf, putchar, puts, ..... are all recognized as built-in functions unless -fno-builtin is specified (or -fno-builtin-function is specified for an individual function).

Some other functions may/may not be recognized as builtins in certain  "strict ISO C modes"  (-ansi, -std=c90, -std=c99 or -std=c11) , I haven't explored this.

@fenugrec , @kjsdf7wr3 : Please try pulling branch fix-issue-76, to check whether it resolves the problem. I'll also add a README.md note.

Cannot test easily here (I'm not using the CMakeLists from this project, and just passing -fno-builtin-printf globally ) but your method seems reasonable; I assume it works on your setup ?

@fenugrec : Well, it works in the sense that it builds and passes the tests. I haven't scrutinized the object code to check whether before the change I would get some putchar implementation pulled in.

@fenugrec , @kjsdf7wr3 : Please try pulling branch fix-issue-76, to check whether it resolves the problem. I'll also add a README.md note.

I use printf.h and printf.c in my code base directly, so I cannot comment on that. Maybe we should first come up with a minimal working example to trigger this feature.

@kjsdf7wr3 :  If adding the switch works for you, I guess I'll just "trust myself" and go ahead and merge this; and if there's another complaint we can always reopen the issue.

I forgot to say, that if you build printf as a library, adding the flag to the library build should have no effect on this issue.
The flag (-fno-builtin-printf) needs to be set where printf is called.

I forgot to say, that if you build printf as a library, adding the flag to the library build should have no effect on this issue. The flag (-fno-builtin-printf) needs to be set where printf is called.

Yes, but I used a PUBLIC compile option, which is propagated to targets depending on the library (if you use CMake properly).


Per-Event Analytics Improvements

Fixes #202
I think this was so that it was easier to track an individual event to either a partner or a user throughout the analytics pipeline. #trivial

🔥


FIX: Should be null in case of no monitors

Closes #497.
Saves from a segfault when no monitors are found (e.g., when using Xvfb).
FWIW this would have been caught if some basic tests were run using Travis, as would have #225. My offer to implement some basic Travis support still stands :)

Thank you for the offer but I need to learn it properly. Travis CI and Coverity Scan are both on my list for this release cycle.


chore(deps): update common-dev-assets digest to 505d834

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
197897d -> 505d834

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline


MIC-502 /update-referral/proactive-or-reactive screen

MIC-502

Codecov Report
Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.18%. Comparing base (0edb2ca) to head (7c74053).

Files with missing lines
Patch %
Lines

...pdate-referral/proactive-or-reactive/controller.ts
62.50%
3 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
+ Coverage   57.05%   57.18%   +0.13%
==========================================
  Files         200      202       +2
  Lines        2829     2845      +16
  Branches      473      473
==========================================
+ Hits         1614     1627      +13
- Misses       1162     1165       +3
  Partials       53       53

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Question related to minitest-reporters

If minitest-reporters is used, the output is not suitable for this adapter (except DefaultReporter)
If there is VIM env set, minitest-reporters does not use any reporters.
Can we set ENV via config or any other recommended way?

Hey thanks for reporting this (pun intended 😁)
I'm not able to reproduce this. I assumed the VIM variable is set automatically?
From the $VIM help:

The environment variable "$VIM" is used to locate various user files for Nvim,
such as the user |config|.  This depends on the system, see
|startup|.
Nvim will try to get the value for $VIM in this order:

Environment variable $VIM, if it is set.
Path derived from the 'helpfile' option, unless it contains some
environment variable too (default is "$VIMRUNTIME/doc/help.txt").  File
name ("help.txt", etc.) is removed.  Trailing directory names are removed,
in this order: "doc", "runtime".
Path derived from the location of the nvim executable.
Compile-time defined installation directory (see output of ":version").
After doing this once, Nvim sets the $VIM environment variable.

I tried reproducing with this example:
# frozen_string_literal: true

require 'minitest/autorun'
require "minitest/reporters"

Minitest::Reporters.use! Minitest::Reporters::ProgressReporter.new

class ReportersTest < Minitest::Test
  def test_addition
    assert_equal 2, 1 + 1
  end
end

From within neovim no reporters were used. When I initiated the test in a separate terminal it was using the ProgressReporter.

My bad. I think I have misconfigured something.


anonymous namespace issue

(not sure that is a problem of the lib).
I was writing an own project with a lot of headers (with logic)  and added TEST_CASEs into each one. and was debugging/testing these ones individually. But after merging all headers into one project I faced with a number of similar issue which refer to TEST_CASE declaration in various modules in my project
(just for sure, my code works as designed and removing a part of TEST_CASEs solve the problem ), I'm also confirming that all TEST_CASEs compiled and work correctly in case of including into the project without other headers (looks like a conflict). the errors looks like these ones:
c:\dev\workspace\algolist\src\algolist.hpp(143): error C2374: 'anonymous-namespace'::autoRegistrar143': redefinition; multiple initialization c:\dev\workspace\algolist\src\mfactory.hpp(143): note: see declaration of 'anonymous-namespace'::autoRegistrar143'
c:\dev\workspace\algolist\src\algolist.hpp(143): error C2084: function 'void ____C_A_T_C_H____T_E_S_T____143(void)' already has a body
c:\dev\workspace\algolist\src\mfactory.hpp(143): note: see previous definition of '____C_A_T_C_H____T_E_S_T____143'

#define CATCH_INTERNAL_LINEINFO ::Catch::SourceLineInfo( FILE, static_caststd::size_t( LINE ) )

The unique name don't have to use line number, otherwise when including other files you'll get this error

We now use __COUNTER__ if possible (the compiler supports it). Can you please check whether current single-include release still causes this error for you?

hi mate,
is the problem still actual?
from those times, I changed my style and now never write a tests in the same header.
so that is a no issue for me yet, but I can try to do this , just to assist with a testing

@amigo421 It should be fixed, but testing is always welcome.

Any feedback would be welcome. However please note that it does depend on whether we detect compiler support for __COUNTER__.

if you treat this as solved, I won't test this right now , just will report this in case Iwill have  faced with this again (i'm mostly using vc++ which supports COUNTER)
p.s. congrats-glad to see that you now work with jetbrains


[Missing feature] The image preview is missing the current selection

The header and bottom selection widgets are missing from the actual widget you provided, it makes it hard to select items only by using the small icon on the top:
I am using android 10, OnePlus 7 Pro

Expected (given by you)
Current (on my phone)

Hi, I've noticed that your viewer of the Current is under the mode what I called "All assets preview mode", in this mode you can only see assets under your current path entity. And the preview mode in my introduce can only triggered by the preview button on the start of the bottom action bar.

The only way to select any unselected assets is to use the checkbox on the top end of the item, but its size is larger than you thought (maybe, see the screenshot). It can still be enlarged by setting more padding and align it more precisely.

The reason why I didn't provide selection in the "All assets preview mode" is that we usually have hundreds and thousands of assets in our device. When you're previewing them in this mode, it's hard to pick some assets just using the swipe action, you still need to go back to the picker and pick them separately. Therefore I separate the behavior as two modes to provide accurate actions for the users.
Feel free to provide more informations and ideas about this behavior. 😄

Yess yess thank you
I was able to change the text color and almost get all settings done using themeData however i had to dig inside your code and some values are hard coded so I could not change them
Have a look at the Asset picker viewer

There is no way to change the color so i found this inside your code

Also you talked about the padding of the button

How do you add more padding into it ? there is no easy way of doing that, there is no parameters in the constructor to add it. I alway accidently end up "NOT" selecting the picture en endding up on the asset previewer page.
So I checked the code again and i got into this.. can this be edited ?
I don't think i can fork the project right now and make the necessary changes.

One last thing, I tried to change this color using the theme data i want the backdrop to be with a different color, i checked your code but i couldn't find the place where you colored this, can you please tell me which parameter of the themeData i shall change to achieve this without changing the app bar color ?

Thank you so much and sorry for asking too many questions

I found that you're asking about themes customization, there's an issue tracking about some related stuff at #32 . Check this and see if it helps.
The padding of the select indicator should be fixed as I thought, since there's no need to change this one commonly. I can enlarge the size to 1/4 or 1/3 of the top end area, what do you think?

The padding of the select indicator should be fixed as I thought, since there's no need to change this one commonly. I can enlarge the size to 1/4 or 1/3 of the top end area, what do you think?

Yes please that would be nice

I found that you're asking about themes customization, there's an issue tracking about some related stuff at #32 . Check this and see if it helps.

I saw it sir,  you hard coded the value to white it cannot be changed.
Please, Sir can you read my previous question properly, I am pointing at places inside your code , not mine :)
Sir you alse hard coded the value of the app bar color

This is your code :(

also is it possible to have this orange black but the app bar orange?

Let's see if we can expose more color customization.

ok ok thank you sir

Sir thank you for your help :)
I forked your project and made some changes to it (lots of changes) to meet my project requirements. I hope we will be able to edit pictures in the future

Sir thank you for your help :)
I forked your project and made some changes to it (lots of changes) to meet my project requirements. I hope we will be able to edit pictures in the future

I hope we will be able to edit pictures in the future

There is a plan for editing assets, still needs more time to integrate with. We already have a image editor.

Yes please that would be nice

The size of the select indicator has been enlarged to 1/4 of the item, it should more accessible.

yes Thanks I saw this :)


fix updateAllSupersededBy

@buoyad ran into a bug where he had set the target msg id for a reaction to 0 this caused a bug in updateAllSupersededBy throwing  Storage: MergeHelper -> ERROR: internal chat storage error: getBlock: invalid block id: 0. This PR just skips these messages since they aren't valid but also cleans up the storage code to make future debugging easier

I think there is a deeper bug that is causing the 0 since danny is still seeing this after confirming they are now never sending 0s. I think this change is good since it completely hoses the chat if this gets in there, we're trying to setup a consistent repro to figure out whats going wrong

i think that when @buoyad made the protocol change to drop the mpackkey it zeroed out the values on clients running with the old protocol definitions causing this error. So no further fixes, but i think this change is for the better overall


Improved logs GUI

Duration is now present in H/M/S style
Error/Failure colors now match across all Difido
Table now expand to screen, allowing longer test names without breaking the table

@itaiag I've sent you mail with example so you can review before merging. Please let me know if you want any additional changes done. We plan on adding parameters to Scenario (like global settings) and add it as another div in the dashboard (lower right)


Added University of Rome

Added University of Rome "La Sapienza"
site: uniroma1.it
address: Piazzale Aldo Moro 5 00185 - Roma , RM , Italia
long-term course:
https://corsidilaurea.uniroma1.it/it/corso/2023/31810/home
https://corsidilaurea.uniroma1.it/it/corso/2023/29923/home
This is the largest university in Italy and one of the oldest
gmaps: https://maps.app.goo.gl/yrcbFhuiPxupCb3P8

@ValerioPapi I am sorry, the domain studenti.uniroma1.it is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Pack at https://education.github.com/discount_requests/application. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).

@ValerioPapi I am sorry, the domain uniroma1.it is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Pack at https://education.github.com/discount_requests/application. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


Space for short-echo-tags.

Support question
Is there an option to enforce that <?=$data?> is <?= $data ?>, that is a space after the opening short echo tag (<?=) and a space before the closing short echo tag (?>)?

Hi and thanks for your question!
Currently, AFAIK, we've no rules for this. Short echo open isn't the most popular here and we are not always that focused on supporting it. However, for the space after <?=- maybe https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/4435 can be extended (I haven't looked at the implementation details though).
For the before I ?>; I haven't looked yet.


RPC events leak through the substream

The RPC messages that we send between the server and client are leaking to the data event of the substream. This makes it nearly impossible for hackers to communicate in realtime using our substream. We should capture the data packets before they are emitted as data events.
The problem with this is that we need message transformers of Primus. These transformers are only applied the main connection and not the substreams. Work has been done make message transforming more robust and re-usable. We will be allowed to use the message interception/transformation when a new primus and substream has been released.

Doesn't apply anymore, we nuked primus/substreams in 0.9 for now. This will be or can be added back using plugins.


Feature/dapp handle notification confirmation state

Fixes #2334
Short description
I'm not too happy with the implementation. I'm not sure if it is related to the in general RaidenService notification pushing code or.... I'm open to change everything.
Please give me feedback if this PR should continue and extend the other notifications that are blockchain related. We haven't done it at all for now, also not for the recent features.
Definition of Done

[X] Steps to manually test the change have been documented
[X] Acceptance criteria are met
[ ] Change has been manually tested by the reviewer (dApp)

Steps to manually test the change (dApp)

Open a new channel
Open right away (ignore loading pop-up) to the notifications
Observe the counter and description of the notification

There is no easy way to test a real blockchain reorg scenario...

I have no clue why the test coverage for the SDK has dropped. Unfortunately the improved tests coverage of the dApp can't equalize it. So I took the chance to improve the dApp tests even more according to the recent changes.

@taleldayekh what do you answer to my initial PR question?

I opened the issue that was asked for. I now rebase the PR to include the fixup commits. When the CI runs through successfully, I'll merge it afterwards.


Select: the focusable issue

When you select an option from the single-select list, the list closes, but the component stays focused, and when you click again on the options to open the list, the component then gets unfocused, so you have to click again to focus and open the list again.
Fix: As already mentioned in the previous Select issue, the opening/closing of the List must not be bound to whether the component is focused or not. When you select an option, the component must become not focused, so clicking on it again must open the list.

that is fixed already


ScrollViewer mouse wheel not working

If you had a docs page called something like "Tips & tricks" or "Gotcha's", you could add this issue that I came across. I'm not sure why it used to work (before using Adonis styles) - probably because something used to have a background but now doesn't.
Symptom: Scrollviewer doesn't scroll with mousewheel after applying Adonis styles
Possible cause: If you have a control inside a scrollviewer, and the control has a PreviewMouseDown event handler, you may need to add some code to the scrollviewer. See this Stack Overflow answer for details.
(or - feel free to close this issue, at least someone searching for it might find the answer here.)

Thanks for giving knowledge to others. Currently, I am not quite sure what this is about though.
So you seem to have a ScrollViewer with a ListView inside, I guess. At least thats the setup in the StackOverflow thread you mentioned.
<ScrollViewer>
    <ListView/>
</ScrollViewer>

And the issue is that the ScrollViewer does not move its scroll bars when scrolling with the mouse wheel.
But if I create a new WPF project without any dependencies and put some items into the ListView it has this issue already. It scrolls only when dragging the thumb or scrolling directly over the scroll bar. Doesn't seem to have anything to do with AdonisUI. Did I get something wrong here?
Setting a background brush does not seem to change anything as well. When using AdonisUI the outer ScrollViewer even has Background="Transparent" which is specified in the default ScrollViewer style.
As far as I know, it is the default behavior of ScrollViewers to handle scroll events even if there is nothing to scroll. This is also pointed out in this blog post. And some controls like ListViews, ListBoxes, TreeViews, etc. make use of internal ScrollViewers that behave this way as well.
Again, please correct me in case I get this all wrong. But I don't see how this is related to AdonisUI. Do you have some XAML code that behaves differently when AdonisUI is included?

My app didn't actually have a listview inside a scrollviewer. It had something far more complex, involving:

CaliburnMicro bindings
ItemsControl with DataTemplate
Items in the ItemsControl were themselves grids, with labels added dynamically via code
Labels had mouseover triggers to show a highlight background when moused over

I just tried to distill it into a reproducable github repo, but failed to recreate the problem. I'm 100% sure I had to add that PreviewMouseWheel event handler & code in my app after adding Adonis, but I can't create a simple repro to share. Sorry! Maybe close this issue & if someone else hits my super edge case, they'll find this fix and maybe have more insight into the repro.

Ok, I see its complicated.
Thanks anyway, maybe it will be useful to someone in the future.


Cmake static library build issue

Hi all,
I have successfully build tensorflow in windows/visual studio using the cmake project.
Now due to large build time of tensorflow, I am building the tensorflow as libraries (static library) and trying to use them in an application (tf_label_image_example). However, I get the following runtime error at the points of calling env constructor in the SessionOptions at the following source code:
session->reset(tensorflow::NewSession(tensorflow::SessionOptions()));.
Error is: No session factory registered for the given session options: {target: "" config: } Registered factories are {}.
It is similar to this error in makefiles and MAC os where the compiler is stripping the multiple defined symbols. I tried to add visual studio equivalent of this compiler options (/FORCE:MULTIPLE and /WHOLEARCHIVE) to build of tf_core_lib.lib . however, the compiler options are not applicable to static libraries. Alternative option to is make a DLL, however, that would require modification of all functions with __declspec(dllexport).
Is there a better solution?
The tf_label_image_example application contains main.cc and the following additional lib dependencies:
tf_core_cpu.lib
tf_core_framework.lib
tf_core_kernels.lib
tf_cc_framework.lib
tf_cc_ops.lib
tf_core_ops.lib
tf_stream_executor.lib
tf_core_direct_session.lib
tf_core_lib.lib
Thanks in advance.
What related GitHub issues or StackOverflow threads have you found by searching the web for your problem?
https://github.com/tensorflow/tensorflow/issues/3308
Environment info
Operating System: Win 10
Installed version of CUDA and cuDNN:  Cuda 8
The same configuration here is used.

@shakith This is caused by MSVC throwing out object files in static libraries during link time if no symbols from them are referenced from anywhere else (which is in most cases a desirable behavior). Many TF objects (ops, kernels, sessions) are not used directly by other code, but through accessing them via global 'registry' collections, hence this behavior.
You have two options - either link the object files directly into executables/dlls (without putting them in static libraries), or (starting with VS 2015 Update 2) use /WHOLEARCHIVE option to force the linker to include all objects from your static library.

please re-open if the above answer does not resolve your issue.

I have similar problem.
In generated with cmake .sln file tf_tutorials_example_trainer.vcxproj tensorflow works fine, but linking tensorflow in existing project (same code as in tf_tutorials_example_trainer) gives error "No session factory registered for the given session options".
When i use /WHOLEARCHIV and tensorflow .lib files in existing project (console release x64) - Error:
/WHOLEARCHIVE = Error LNK1000: Internal error during IncrBuildImage
Details of problem: https://github.com/tensorflow/tensorflow/issues/6382
Maybe some separate Cmake / Visual Studio example projects linking tensorflow .lib files exist (to stop rebuilding tensorflow each time)?

Got another strange error trying to link fresh custom Release x64 console project like tf_label_image_example (same code) when added /WHOLEARCHIVE:
Ошибка	LNK1000	Internal error during CImplib::EmitThunk
C/C++ settins:
/MP /GS /TP /W3 /wd"4267" /wd"4244" /wd"4800" /wd"4503" /wd"4554" /wd"4996" /wd"4348" /wd"4018" /wd"4099" /wd"4146" /wd"4305" /wd"4307" /wd"4715" /wd"4722" /wd"4723" /wd"4838" /wd"4309" /wd"4334" /Gy- /Zc:wchar_t /I"D:\Tensorflow\tensorflow-master" /I"D:\Tensorflow\tensorflow-master\tensorflow\contrib\cmake\build" /I"D:\Tensorflow\tensorflow-master\tensorflow\contrib\cmake\build\external\zlib_archive" /I"D:\Tensorflow\tensorflow-master\tensorflow\contrib\cmake\build\external\gif_archive\giflib-5.1.4" /I"D:\Tensorflow\tensorflow-master\tensorflow\contrib\cmake\build\external\png_archive" /I"D:\Tensorflow\tensorflow-master\tensorflow\contrib\cmake\build\external\jpeg_archive" /I"D:\Tensorflow\tensorflow-master\tensorflow\contrib\cmake\build\external\eigen_archive" /I"D:\Tensorflow\tensorflow-master\third_party\eigen3" /I"D:\Tensorflow\tensorflow-master\tensorflow\contrib\cmake\build\gemmlowp\src\gemmlowp" /I"D:\Tensorflow\tensorflow-master\tensorflow\contrib\cmake\build\jsoncpp\src\jsoncpp" /I"D:\Tensorflow\tensorflow-master\tensorflow\contrib\cmake\build\external\farmhash_archive" /I"D:\Tensorflow\tensorflow-master\tensorflow\contrib\cmake\build\external\farmhash_archive\util" /I"D:\Tensorflow\tensorflow-master\tensorflow\contrib\cmake\build\external\highwayhash" /I"D:\Tensorflow\tensorflow-master\tensorflow\contrib\cmake\build\protobuf\src\protobuf\src" /I"D:\Tensorflow\tensorflow-master\tensorflow\contrib\cmake\build\grpc\src\grpc\include" /I"C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v8.0" /I"C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v8.0\extras\CUPTI\include" /I"D:\Tensorflow\cudnn\cuda" /I"D:\Tensorflow\tensorflow-master\third_party\gpus" /I"C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v8.0\include" /Gm- /O2 /Ob2 /Fd"x64\Release\vc140.pdb" /Zc:inline /fp:precise /D "WIN32" /D "_WINDOWS" /D "NDEBUG" /D "EIGEN_AVOID_STL_ARRAY" /D "NOMINMAX" /D "_WIN32_WINNT=0x0A00" /D "LANG_CXX11" /D "COMPILER_MSVC" /D "__VERSION__=\"MSVC\"" /D "OS_WIN" /D "_MBCS" /D "WIN64" /D "WIN32_LEAN_AND_MEAN" /D "NOGDI" /D "PLATFORM_WINDOWS" /D "TENSORFLOW_USE_EIGEN_THREADPOOL" /D "EIGEN_HAS_C99_MATH" /D "_ITERATOR_DEBUG_LEVEL=0" /D "GOOGLE_CUDA=1" /D "TF_EXTRA_CUDA_CAPABILITIES=3.0,3.5,5.2" /D "CMAKE_INTDIR=\"Release\"" /errorReport:prompt /GF /WX- /Zc:forScope /GR /Gd /MD /FC /Fa"x64\Release\" /EHsc /nologo /Fo"x64\Release\" /Fp"x64\Release\TF.pch"
/bigobj
Linker settings:
/OUT:"D:\CppTests\FuckMail\TF\x64\Release\TF.exe" /MANIFEST /NXCOMPAT /PDB:"D:\CppTests\FuckMail\TF\x64\Release\TF.pdb" /DYNAMICBASE "kernel32.lib" "user32.lib" "gdi32.lib" "winspool.lib" "shell32.lib" "ole32.lib" "oleaut32.lib" "uuid.lib" "comdlg32.lib" "advapi32.lib" "Release\tf_protos_cc.lib" "Release\tf_core_gpu_kernels.lib" "zlib\install\lib\zlibstatic.lib" "gif\install\lib\giflib.lib" "png\install\lib\libpng12_static.lib" "jpeg\install\lib\libjpeg.lib" "jsoncpp\src\jsoncpp\src\lib_json\Release\jsoncpp.lib" "farmhash\install\lib\farmhash.lib" "highwayhash\install\lib\highwayhash.lib" "protobuf\src\protobuf\Release\libprotobuf.lib" "grpc\src\grpc\Release\grpc++_unsecure.lib" "grpc\src\grpc\Release\grpc_unsecure.lib" "grpc\src\grpc\Release\gpr.lib" "wsock32.lib" "ws2_32.lib" "shlwapi.lib" "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v8.0\lib\x64\cudart_static.lib" "D:\Tensorflow\cudnn\cuda\lib\x64\cudnn.lib" "tf_cc_framework.dir/Release/tf_cc_framework.lib" "tf_cc_ops.dir/Release/tf_cc_ops.lib" "tf_core_cpu.dir/Release/tf_core_cpu.lib" "tf_core_direct_session.dir/Release/tf_core_direct_session.lib" "tf_core_framework.dir/Release/tf_core_framework.lib" "tf_core_kernels.dir/Release/tf_core_kernels.lib" "tf_core_lib.dir/Release/tf_core_lib.lib" "tf_core_ops.dir/Release/tf_core_ops.lib" /MACHINE:X64 /OPT:NOREF /INCREMENTAL:NO /PGD:"D:\CppTests\FuckMail\TF\x64\Release\TF.pgd" /SUBSYSTEM:CONSOLE /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /ManifestFile:"x64\Release\TF.exe.intermediate.manifest" /OPT:NOICF /ERRORREPORT:PROMPT /NOLOGO /LIBPATH:"D:\Tensorflow\tensorflow-master\tensorflow\contrib\cmake\build" /TLBID:1
/WHOLEARCHIVE /machine:x64

Found similar tensorflow issue forum https://groups.google.com/forum/#!topic/bazel-discuss/tDGrTAtaxYw
( Internal error during CImplib::EmitThunk )

For now tf_label_image_example works fine in generated .sln!
To stop rebuilding whole tensorflow each time i used workaround
"Configuration Manager". Un-check the "Build" for all except tf_label_image_example as in http://stackoverflow.com/a/1433680
Also in contrib\cmake\build i created folders tensorflow/examples/label_image/data/ and placed in it:
grace_hopper.jpg
imagenet_comp_graph_label_strings.txt
tensorflow_inception_graph.pb
Data may be found at https://storage.googleapis.com/download.tensorflow.org/models/inception_dec_2015.zip in tutorial https://www.tensorflow.org/how_tos/tool_developers/

@vit-stepanovs , Thanks for the info.
I have followed the adding all obj file solution and it works. However, it will be great to have lib version (with small amounts of libs). I added /WHOLEARCHIVE compiler option (on Visual Studi 2015 Update 3) to the tf_label_image_example application project with the lib dependencies. It gives the same error as for @derofim:
LNK1000: Internal error during CImplib::EmitThunk
To verify whether this is a configuration issue with my setup, has anyone managed to build static libraries and link them to an application through Visual Studio/CMake project. Or is it a Visual Studio issue with these specific libraries?
@andydavis1, could you open the issue till a static library solution can be found or if needed till a bug report can be reported for visual studio? Thanks.

@shakith Thanks for the detailed description of the problem. Can you please say how you added all obj files to solution?
I saw list of .obj files needed to build tf_label_image_example in solution explorer and was amazed how big it is. Maybe some of them may be skipped (or added automatically)?

You can bypass the LNK1000 error by selectively applying /WHOLEARCHIVE option only to the necessary static libraries. I managed to get with this set as a starting point for my experiments:
/WHOLEARCHIVE:tf_core_direct_session.lib /WHOLEARCHIVE:tf_core_ops.lib /WHOLEARCHIVE:tf_core_lib.lib /WHOLEARCHIVE:tf_cc_framework.lib /WHOLEARCHIVE:tf_core_framework.lib /WHOLEARCHIVE:tf_core_cpu.lib /WHOLEARCHIVE:tf_stream_executor.lib

I can compile successively adding manually all the *.obj of some libraries. But it is quite awkward because link is slow, and updating the library requires to check whether a new file is added... Therefore I've tried the /WHOLEARCHIVE trick.
It works for all the libraries I was linking with (through *.obj) but not for tf_core_gpu_kernels.lib; a symbol (TensorCuBlasGemm) keeps missing. This symbol comes from blas_gemm.cc (explicit template instantiation) either from _gru_ops or _lstm_ops libraries. But linking with any of this does not fix the missing symbol. Hence my question: which library should I link against (dumpbin does not tell it)?


Comment Viewer app treats line numbers as they are even if document is dirty

Describe the bug
Clicking blue icon on a line will open the Comment Viewer app, that should show the comments of that line and should allow some actions with in-line comments. (adding/deleting/replying) However, if document is dirty (means it has unsaved/uncommited changes), the line numbers may be different from original commit. Comment Viewer app gets selected line number as it is, even if document is dirty. This may cause wrong results in all operations that Comment Viewer app supports.
To Reproduce

Open a file in the editor.
Click on any line and add a comment. (click blue icon, then Add Comment) Then click Close
Make some edits in this file, that changes the original position (line number) of the line in 2nd step.
Select the same line and Click blue icon again. You will not see any comment. (actually you're seeing wrong line's comments, if there are)
Add a new comment on the same window with 4th step.
Go to BitBucket website/your repo/commits. Find the commit that you added comment(s)
See, Added comment in the 5th step went to the wrong line.

Expected behavior
Lines should be treated with related content, instead of only numbers
Actual behaviour
Line numbers are being treated in a wrong way and this causes wrong results in various operations (i.e. wrong line numbers are being sent in API requests)
Screencast

Additional context

Comment Viewer app gets selected line number as it is, even if document is dirty.

Here is the related code block needs to be updated:
https://github.com/billsedison/vscode-gitlens/blob/tc-dev/src/gitCommentService.ts#L202
const editor = window.activeTextEditor;
const position = editor.selection.active;

const lineState = Container.lineTracker.getState(position.line);
const commit = lineState !== undefined ? lineState.commit : undefined;

position.line gets the current selection's line.

@cagdas001 Thanks for pointing this out, is it easy to be fixed? I'm not sure if the client will add the comment and edit the content simultaneously.
Because on the Bitbucket side there is no way to edit the diff, but on the VSCode, we are able to edit it.
Please let me know your thoughts. Thanks.

Your bug hunt payment: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30078155

Yes, as I said in the GitLab ticket,

By the way, if the client will use these features only in "diff window", the first issue (118) should not be problem
Because it is not allowed to make change on files in the Diff View
But, if this is the case, I think its better to remove Blue icon and decorations from edit mode and make them active only within Diff View.

git-blame is able to blame a specific revision.
git blame <commit_sha> -n </path/to/file.ext>

-n: To show source line (aka original line) numbers (so it will work even if document has uncommited changes)
Example,
git blame cf92f73 -n bitbucket-comment-app/main.js

Blame functions already implemented in the extension. We just need to make some modifications to pass this specific argument, and then use it.

That sounds cool, we can have a try. But I'm not sure if it will cause performance issues, because in this way we might need to blame many commit-sha for associating the content with the comment.
Can you create a PR and let's have a test? I'll pay you accordingly.

We don't need to call git-blame for each comment we have. (e.g. 100 times for 100 comments)
Just calling this one time will be enough, it will blame all lines in this specific revision
git blame cf92f73 -n bitbucket-comment-app/main.js

Okay, that's cool. Let's proceed.

Okay, should be done all issues within 2-3 hours.

@cagdas001 That's great. Thank you.

@cagdas001 How is the fix going?


Replace dill with cloudpickle

WIP for #847

updated docs, travis, and conda.recipe to use cloudpickle.

left dill in the travis installs because test_dataframe_series_are_dillable uses it

centralized the choice between dill and cloudpickle at dask/multiprocessing.py.   Other tests where dill was imported now use multiprocessing._dumps and multiprocessing._loads.

added a test for pickling functions with __globals__: dask/tests/test_multiprocessing.py::test_pickle_globals.

The test fails with dill and passes with cloudpickle

the switch to cloudpickle introduced regressions in some tests for Python <= 3.3

dask/bag/core.py::dask.bag.core.Bag.distinct FAILED  (failed in Python:2.7 only)
dask/bag/tests/test_bag.py::test_fold FAILED
dask/bag/tests/test_bag.py::test_distinct FAILED
dask/bag/tests/test_bag.py::test_from_filenames_large FAILED
dask/bag/tests/test_bag.py::test_from_filenames_encoding FAILED
dask/bag/tests/test_bag.py::test_from_filenames_large_gzip FAILED

the error seen in the FAILED tests above was always: PicklingError: Could not pickle object as excessively deep recursion required.

I introduced a somewhat ugly hack in dask/multiprocessing.py that fixes the recursion errors seen so far:  if dumps fails the recursion limit is increased by a factor of 2 and cloudpickle tries again.

I appreciate any feedback on this WIP.   Thanks!

At first pass this looks pretty good to me.
I wonder if @eribean or @jni can verify that this resolves issues that they've seen in the past with dill.

I found that the switch to cloudpickle can solve an issue when running on windows.   On my linux laptop I found that the global np issue is handled ok by both dill and cloudpickle
Win32 python 3.5 with dill:
Python 3.5.0 |Continuum Analytics, Inc.| (default, Dec  1 2015, 11:46:22) [MSC v.1900 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import dask
>>> import numpy as np
>>> def f(x):
...     return np.sin(x) + np.cos(x)
...
>>> import multiprocessing
>>> p = multiprocessing.Pool()
>>> from dask.multiprocessing import dill_apply_async
>>> result = dill_apply_async(p.apply_async, f, args=[0.])
>>> result.get()
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
  File "C:\Users\pedromdu\AppData\Local\Continuum\Anaconda3\envs\python3\lib\multiprocessing\pool.py", line 119, in worker
    result = (True, func(*args, **kwds))
  File "C:\Users\pedromdu\AppData\Local\Continuum\Anaconda3\envs\python3\lib\site-packages\toolz\functoolz.py", line 219, in __call_
_
    return self._partial(*args, **kwargs)
  File "C:\Users\pedromdu\AppData\Local\Continuum\Anaconda3\envs\python3\lib\site-packages\dask\multiprocessing.py", line 68, in app
ly_func
    return func(*args, **kwds)
  File "<stdin>", line 2, in f
NameError: name 'np' is not defined
"""

Win32 python 3.5 with cloudpickle:
Python 3.5.0 |Continuum Analytics, Inc.| (default, Dec  1 2015, 11:46:22) [MSC v.1900 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import dask
>>> import numpy as np
>>> def f(x):
...     return np.sin(x) + np.cos(x)
...
>>> import multiprocessing
>>> p = multiprocessing.Pool()
>>> from dask.multiprocessing import pickle_apply_async
>>> result = pickle_apply_async(p.apply_async, f, args=[0.])
>>> result.get()
1.0

Linux python 3.5 with dill:
Python 3.5.0 |Continuum Analytics, Inc.| (default, Oct 19 2015, 21:57:25)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-1)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import dask
>>> import numpy as np
>>> def f(x):
...     return np.sin(x) + np.cos(x)
...
>>> import multiprocessing
>>> p = multiprocessing.Pool()
>>> from dask.multiprocessing import dill_apply_async
>>> result = dill_apply_async(p.apply_async, f, args=[0.])
>>> result.get()
1.0
>>>

Linux python 3.5 with cloudpickle:
Python 3.5.0 |Continuum Analytics, Inc.| (default, Oct 19 2015, 21:57:25)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-1)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import dask
>>> import numpy as np
>>> def f(x):
...     return np.sin(x) + np.cos(x)
...
>>> import multiprocessing
>>> p = multiprocessing.Pool()
>>> from dask.multiprocessing import pickle_apply_async
>>> result = pickle_apply_async(p.apply_async, f, args=[0.])
>>> result.get()
1.0

It looks like the the 2*recursionlimit hack is too flaky and definitely not going to work.   On first trial it passed on travis, but now it has caused  a Segentation fault.   Will look into this further.

Whoa, that's a surprising limitation.  Hrm, we could consider choosing the serialization library based on the python version and system platform.

I may be onto something.  Using the copyreg module we can register pickling and unpickling functions for <type 'method_descriptor'>.   We can then drop in dill to do the work only for those offending objects, and let cloudpickle handle what it is good for.    This  can be done only for the python versions that need the fix.   I will play around with this idea in the next couple of days.

Very cool.

Looks like I may have found a better solution to the method_descriptor problem.   I borrowed some code from multiprocessing.forking, where the ForkingPickler is defined precisely for this purpose.  This has been a good learning experience.

Oh cool.  That is indeed much nicer

@mrocklin  Should I squash all commits in to a single one in this case as well?  Let me know if you think there is anything pending for this request to be complete.

Looks good to me.  Merging in 12 hours if no comments

Excited about this, cloudpickle has been robust in my experience.

This is in.  Thanks @PedroMDuarte !

Cloudpickle produces bytestrings that are unpicklable with the pickle
module.
On Tue, Feb 20, 2018 at 3:23 PM, jakirkham<EMAIL_ADDRESS>wrote:

@jakirkham commented on this pull request.
In dask/multiprocessing.py
https://github.com/dask/dask/pull/865#discussion_r169446652:

+else:

import copyreg

+def _reduce_method_descriptor(m):

return getattr, (m.objclass, m.name)

+# type(set.union) is used as a proxy to <class 'method_descriptor'>
+copyreg.pickle(type(set.union), _reduce_method_descriptor)
+
+import pickle
+import cloudpickle
+
+def _dumps(x):

return cloudpickle.dumps(x, protocol=pickle.HIGHEST_PROTOCOL)

+_loads = pickle.loads
Not sure if this was intentionally meant to be pickle or if this should
actually be cloudpickle. Assumed the latter and added PR ( #3180
https://github.com/dask/dask/pull/3180 ) to change it. However if I
assumed incorrectly, please feel free to let me know. Would be good to
understand why if this was intentional.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/pull/865#pullrequestreview-97974095, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszLHlZ0UnhVIA3Yqqi7dK4kIrw7Hoks5tWykKgaJpZM4Gvhdh
.

Not sure I follow. We are already using cloudpickle with dumps where this presumably matters. We just are not using it for loads (despite saying we are in the docs).

In [1]: import pickle, cloudpickle

In [2]: pickle.loads is cloudpickle.loads
Out[2]: True

I see. Still wouldn't it be better to be explicit? Just in case cloudpickle ever changed the behavior.

No preference on my end
On Tue, Feb 20, 2018 at 4:16 PM, jakirkham<EMAIL_ADDRESS>wrote:

I see. Still wouldn't it be better to be explicit? Just in case
cloudpickle ever changed the behavior.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/pull/865#issuecomment-367122268, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszN9TYq6uuSa1FInhGqJ1NuLTFwGRks5tWzZBgaJpZM4Gvhdh
.


Longest road and largest army should be indicated in the UI

Consider putting a little icon next to the player info box of the player who has each or consider putting two static cards objects next to the dice that change color depending on who has each.

Added in a24e384012dbf53ef88683641779518ef60ccfcc.


Added Riak

@aouyang1 can you check this when you get a chance?

@ronaknnathani Hey how can I check that riak is up and running? Trying to get the PR finished


Add place_id on GKGeocoderPlace Class

Hi, @maxsokolov.
Your library is really great. With special purposes, we need placeId from geocoding and I added the class member variable for it. And it's not important but I found the issue on demo project so I fixed it also.
Best

Hi, @SoftDev0420
Thanks a lot!

Thank you!
We can expect new version soon?

@SoftDev0420 I've bumped pod version to 0.3.2


HADOOP-19170. Fixes compilation issues on Mac

Backport https://github.com/apache/hadoop/pull/6822 to branch-3.4.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
7m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-3.4 Compile Tests _

+1 :green_heart:
mvninstall
32m 33s

branch-3.4 passed

+1 :green_heart:
compile
10m 50s

branch-3.4 passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
9m 10s

branch-3.4 passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
mvnsite
0m 53s

branch-3.4 passed

+1 :green_heart:
shadedclient
73m 36s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 28s

the patch passed

+1 :green_heart:
compile
8m 18s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
cc
8m 18s

the patch passed

+1 :green_heart:
golang
8m 18s

the patch passed

+1 :green_heart:
javac
8m 18s

the patch passed

+1 :green_heart:
compile
7m 54s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
cc
7m 54s

the patch passed

+1 :green_heart:
golang
7m 54s

the patch passed

+1 :green_heart:
javac
7m 54s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 48s

the patch passed

+1 :green_heart:
shadedclient
20m 26s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
16m 36s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

139m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6827/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6827

Optional Tests
dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang

uname
Linux d584f947619d 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.4 / 382212da670f3a534ed0303b0b82c780a9d60a99

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6827/1/testReport/

Max. process+thread count
3152 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6827/1/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

not sure what is up here. lack of a test?

thanks, merged to trunk. If you do a PR cherrypicking this against hadoop branch-3.4 I'll commit it there as soon as yetus is happy...no need for any code review.

thanks, merged to trunk. If you do a PR cherrypicking this against hadoop branch-3.4 I'll commit it there as soon as yetus is happy...no need for any code review.

Yes, this is only lack of unit test. In this PR, only change conditional compilation, the unit test could not take effect
. Just backport https://github.com/apache/hadoop/pull/6822 to branch-3.4.


TAJO-1500 FinishedTaskCleanThread is not interrupted when worker stops

Another trivial fix

It's mere a typo fix. anyone?

+1. I'll commit soon.


In the template tag, when you enter a tag or tag attributes, the hint appears with a delay, and this causes discomfort

In the template tag, when you enter a tag or tag attributes, the hint appears with a delay, and this causes discomfort

What is a template tag?
Please provide detailed steps to reproduce. Screenshot can also help.
Here is an example:

create a file text.ext
open the editor on that file. The language mode of the editor is plaintext
enter the content ....
move the mouse over ...
I see: xy, I expect zx

Please file this against the vue extension. All support for vue comes from extensions.
I don't see any delay when trying this in HTML.


Column ordered by criteria

Column ordered by one desired criteria (i.e. column ordered by Complexity field).
label:"feature request"

If you are talking about column sorting it's available since your posted this message.


50000 particles GpuNewtonGravity: addAccelerationsKernelLower: cudaPeekAtLastError failed! the launch timed out and was terminated

Running on GPU
Simulation running
20000 particles
Frames: 6000
passed: 0.00555556% 2.27527s, remaining: 99.9944% 11.3757 hrs
GpuNewtonGravity: addAccelerationsKernelLower: cudaPeekAtLastError failed!
the launch timed out and was terminated

It appears that all the indexes for the triangular matrix is stored in memory instead of the maximum number of indexes available based on GPU memory.


find difference of two text files

What if we want to compare two text files and display the file differences.

That's a great idea, @hredd00! Thanks for the issue.
Would you comment here with a short code example showing how you'd like this to work?

func diff(soureFolderPath string, destFolderPath string) string {
//returns the file differences as below --
}

return as below

++ differences from soureFolderPath
--differences from destFolderPath

Most everything in the script library is either a function that creates a pipe, or a method on a pipe. How would you fit diff into this framework?

Maybe something like
listOfDiffs, err := script.File("test.txt").Diff("test2.txt").Compare()
or
listOfDiffs, err := script.Diff("test.txt", "test2.txt").Compare()

It's often helpful to think about what the equivalent shell script would be. Can you think of an example program you'd write as a shell script that uses diff, and we'll see how it might translate into script.

If we're comparing this to the diff utility, it might be something like
script.File("a.txt").Diff(script.File("b.txt"))
but I think this breaks the paradigm slightly

Yes, I don't really see a good way to incorporate this into script at the moment. The go-cmp library already provides an excellent Diff, for example. I'm open to suggestions, but I think until we have a workable design, this has to remain on hold.