Gen DGRL Dataset[Feature Request]

Motivation
Want to add the Gen DGRL Dataset for benchmarking RL algorithms in a easy & efficient way
Solution
Use D4RL wrapper (https://github.com/Farama-Foundation/D4RL) to download and load the dataset ready for training using simple python commands
Alternatives
For larger datasets it maybe best to download the files partially and then delete them as training progressing while simultaneously downloading remaining data
Additional context
Add any other context or screenshots about the feature request here.
Checklist

[x] I have had an initial discussion with @vmoens
[ ] Get familiar with TorchRL and GenDGRL Dataset
[ ] Create a wrapper to download and load the dataset

Here too, I'd rather not use anything D4RL-based. The library is 100% unmaintained, and it's a disaster to install. I believe we have everything we need in-house to build this. Have a look at how torchvision does the data download and extraction, and feel free to copy paste parts of their code if needed!
https://github.com/pytorch/vision/tree/main/torchvision/datasets

Closed by #1773


_type field of arrayMember is unknown

Thank you for all the swift replies and fantastic work @saiichihashimoto! The new structure is resolving a lot of the previously encountered problems and is very nice to work with.
Right now the _type field of an arrayMember is unknown.
Would be great to be able to use the _type field of an arrayMember as a type guard. I've tried to clarify what would be nice to achieve with the code below.
Schemas
const RowSection = defineType({
  title: 'Row',
  name: 'section.row',
  type: 'object',
  fields: [
    defineField({
      name: 'rowText',
      type: 'string'
    })
  ]
});

const ParagraphSection = defineType({
  title: 'Paragraph',
  name: 'section.paragraph',
  type: 'object',
  fields: [
    defineField({
      name: 'paragraphText',
      type: 'string'
    })
  ]
});

const BodyComponent = defineType({
  title: 'Body sections',
  name: 'component.body',
  type: 'array',
  of: [
    defineArrayMember({ type: 'section.row' }),
    defineArrayMember({ type: 'section.paragraph' }),
  ],
});

type Schema = InferSchemaValues<typeof config>;

Implementing

/**
 * Expected usage
 */
const body: Schema['component.body'];

body.map((section) => {
  section._type // This is `unknown` instead of `section.row` or `section.paragraph`
});

/**
 * Work around
 * This allows using `_type` field as type guard.
 */
type SectionType = Schema['section.row'] | Schema['section.paragraph'];
type BodyType = SectionType[];

const body: BodyType;

body.map((section) => {
  section._type // This is `section.row` or `section.paragraph`
});

Experencing the same issue when using the @portabletext/react  package. Its prop value expects the _type field but you cannot use them since they are unknown in array members. I have tried the _InferValue but does not work also.

That's because, I didn't consider how defineType will work within an array 🙃
PR incoming


Change PowerShell example to use the -Raw flag

fixed #17630

/sig windows

cat is an alias for get-content, but without the -raw flag it reads the file line-wise and returns an array of strings.
/lgtm
/approve

/lgtm

/approve


Add support for chrome-extension protocol

Resolves #179

Will merge on Sunday if no comments prior to.


feat: add pubsub source

Fixes #29

we might have to port this to user-defined source. https://github.com/orgs/numaproj-contrib/repositories. @KeranYang could you please give details?

Thanks @tczhao for looking into the pubsub source.
Please check the examples under https://github.com/orgs/numaproj-contrib/repositories to implement this as a user-defined source. The user-defined NATS source can be a good candidate to refer to.
To implement a user-defined source, you just need to implement 3 functions, read to import messages, ack to acknowledge processed messages and pending to return pending message count.

Hi @KeranYang,
Thanks for looking into this, I think we need to add the example repo link to https://numaflow.numaproj.io/user-guide/sources/user-defined-sources/
Would you recommend that we add a pubsub example to the https://github.com/numaproj-contrib as well

Hi @vigith @KeranYang
Just want to double check on the plan.
I will create a repo under my account with something like tczhao/gcppubsub-source-go and replment it using udsource.
Then I will get in touch with you again and see how you want to port it.

@tczhao , please fork https://github.com/numaproj-contrib/gcp-pub-sub-source-go . Thanks!

@tczhao The general approach we follow to configure the source is to use a ConfigMap to store the source configurations in yaml format. At UDSource main function, we read the configurations and start the server. Then we implement the 3 functions to interact with the source.
See config file for NATS source. Consider following the README.md to get a sense of how UDSource works from end to end.
Please don't hesitate to contact me if you have any questions. Thanks!

@tczhao, the reason for this approach is that it is not scalable for us to add and maintain all the sources directly into numaflow as there are a lot of sources. with user-defined sources we can support as many as we want with minimal impact on the core numaflow framework.


Secondary device QR is not being generated.

Sec device QR is not generating  only the loader is loading continuously.
-I pulled down Secondary device QR module  and came back , again I clicked the secondary device and after clicking on that  it showed me the option of reshare and showed the QR code on that.
-If I click on F & F's secondary device after confirming the secondary device, I am getting this error message.

-Now the QR is generating but if I pulled down Secondary device QR module and came back , again I clicked the secondary device and after clicking on that it showed me the option of reshare .
-If I click on F & F's secondary device after confirming the secondary device, I am getting this error message.

-Verified this issue on staging app v1.5.0(258)


[3.5] Fix Tween cheatsheet URL

The tween cheatsheet .png URL for 3.5 is now a 404 as the cheatsheet in master now points to an updated .webp file that references 4.1. So for this change the Tween and SceneTreeTween docs now point to the 3.x relevant image.

Should be 3.6 for the 3.x branch and 3.5 for the 3.5 branch

https://github.com/godotengine/godot/blob/3.x/doc/classes/SceneTreeTween.xml#L48
https://github.com/godotengine/godot/blob/b776cf54982e5f5bcbe33c226eb984f8ac0ef3ed/doc/classes/SceneTreeTween.xml#L48
I think the target branch should still be 3.x (with a different commit, I got it wrong here), and the changes will be cherry-picked for 3.5 later. So the correct actions are: 1. rebase the commit locally, 2. force-push the branch, 3. change the target branch (and then we remove review requests again). Or open a new PR.

It is needed in 3.x as well yes, it should say "3.6" though as there is no 3.x in the docs

Thanks everyone for your feedback and correcting the target branch! Is anything further needed from me at this point or will the PR be pushed along/merged by other processes?

It's all good, I'll merge it soon.

Thanks!

Great, thanks for that, @akien-mga! Happy to help 😄


help

var myScore = (~~(userScore / 100)) - level*100;

Put the js code in the end of main_out.js of ur game (agario game ) and change "userScore" with ur var of ur mass

Its better on v72 ;)


Atom.Object.defineProperty.get is deprecated.

atom.workspaceView is no longer available.
In most cases you will not need the view. See the Workspace docs for
alternatives: https://atom.io/docs/api/latest/Workspace.
If you do need the view, please use atom.views.getView(atom.workspace),
which returns an HTMLElement.
Atom.Object.defineProperty.get (/Applications/Atom.app/Contents/Resources/app/src/atom.js:55:11)
Object.activate (/Users/ricardodovalle/.atom/packages/atom-alignment/lib/atom-alignment.coffee:10:13)

solved in 0.11.0


Added RFC 7233 Range HTTP/1.1 Range Requests (again)

Hey all,
I am currently rewriting my youtube to podcast web app using sanic. I noticed that the implementation of static files doesn't include a way to deal with range requests RFC 7233. So instead of writing my own implementation for my app, I tried to implement it directly into sanic.

@aquacash5 are you able to rebase this down to 1 commit? You can do git rebase -i HEAD~17 (or maybe 16, it should only show your commits).

Change all of the pick to f except 1 of them, and then update it's commit message accordingly.

@aquacash5 whoops, sorry! I didn't mean to have you close it :) We can probably rebase it for you if it's not working for you...

@r0fls sorry I just am having a lot of trouble with git.

It is funny. All this work just to get this range parser built in, so I can use it for my podcast app.

@aquacash5 speaking of more work :/ sorry but can you close/reopen this with just your 17 commits? We'll handle squashing them.

BTW we've all been there, but Git is obviously super helpful for collaborating so it's worth the uphill battle.

Yeah I'd suggest just making a new branch off your local master and then copying the changes over to it. I was going to squash and merge anyway so don't worry about the previous commit history.
 I'd really like to get this change in.

Going to close this in anticipation of a new PR.


[Bug]:" JsonPathParserError" when using "JSONQueryEngine"

Bug Description
Hello,
Thank you for your great work on LlamaIndex and for open-sourcing it along with examples and videos!
I am trying to use the "JSONQueryEngine" with my JSON file following the steps described in the relative example. In the step of using the engine to query the index, I get this error: JsonPathParserError: Parse error at 1:37 near token & (&)
I search for the error and I saw that maybe it's due to the library import. Am I doing something wrong?
Version
0.8.39.post2
Steps to Reproduce

Read a JSON object from a file using JSON module: with open('file.json', 'r') as f:  json_value = json.load(f) Use this as the json_value parameter of the JSONQueryEngine constructor.
Provide a string that contains the json schema. Then convert it to dict using json.loads(json_schema_string)
Create a JSONQueryEngine using the two dictionaries from the steps above.
Use query() method on the JSONQueryEngine.

Relevant Logs/Tracbacks
File ~/anaconda3/lib/python3.11/site-packages/jsonpath_ng/parser.py:83, in JsonPathParser.p_error(self, t)
     82 def p_error(self, t):
---> 83     raise JsonPathParserError('Parse error at %s:%s near token %s (%s)'
     84                               % (t.lineno, t.col, t.value, t.type))

JsonPathParserError: Parse error at 1:37 near token & (&)

@dosu-bot the query string I am passing to the query engine is "Suggest me five pillows. Keep in mind that I love nature and especially the mountains." Strangerly the error does not generate when I use another query.

The documentation example ran successfully, can you share your JSON schema and JSON value mocked and some code snippets, then we can reproduce your example

Hello,
Yes, I am sending you a PDF file generated from a Jupyter Notebook that contains all of them.
Example with error.pdf

@terilias instead of the PDF can you send the notebook file please?

Yes. GitHub doesn't support notebook uploading, so I am sending you a WeTransfer link: https://we.tl/t-YLBOFae0ew


Fix menu position of the labels-custom-metadata.md topic

When building docs.docker.com, the labels-custom-metadata.md topic is in the wrong place in the menu. This fixes that.
Signed-off-by: Misty Stanley-Jones<EMAIL_ADDRESS>

@thaJeztah @sanscontext PTAL

LGTM but I don't have approval rights here.

LGTM

Cherry picked in https://github.com/docker/docker/pull/27040


Missing crucial JS and CSS files

The project is missing crucial JS and CSS files. The paths in hola_player.js are wrong and thus they don't load the dependencies. Overall, if someone tries to download or clone the repository and use it locally, it just doesn't work.
Please include all the dependencies like video.js and css files required for Hola player to work.

Hi, here's a working demo: http://jsbin.com/toposo this uses the hola_player.js hosted on jsDelivr, no additional scripts or css necessary.
to use locally you can clone this repository and build it like this:
git clone https://github.com/hola/hola_player.git
cd hola_player
npm install
grunt

the compiled results will be in the dist/ directory, after you build it you can run any of the examples in the examples/ directory.
you can fetch the latest version with compiled player like this: npm install @hola.org/hola_player or fetch a tarball like this: npm pack @hola.org/hola_player

Wouldn't it be better if there is a version/branch which users can download and use directly in their projects? Sometimes, you don't want hosted libraries like jsDelivr and want to include all the files locally in the project. Also, not everybody has Node.js running on their server so just providing the necessary JS and CSS directly would be a good idea.
Just my 2 cents.

OK, I'm convinced, we'll start adding compiled scripts to our releases on GitHub.
I'll probably set this up on Sunday

Thank you.


Savebuff cannot be loaded as global/user module

I am not sure if global module would be a good idea as there is support for encryption, but as log module can be loaded as user module and users are probably to want savebuff on all their networks.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/6446072-savebuff-cannot-be-loaded-as-global-user-module?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github).

Hi. It would also help to know if savebuf doesn't require any password - to mention that on the wiki page documentation here
http://wiki.znc.in/Savebuff
+1 for user or global module


[istioctl]: cleanup help doc trailing whitespace

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[x] Does not have any changes that may affect Istio users.

Hi @thinpark. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@thinpark: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
968c8457e84153049af9d9df70891679c9f7d2c2
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio


WIP - [es] Add concepts/storage/persistent-volumes.md

Adding new content to concepts/storage/persistent-volumes.md
Work still in progress but it's huge!
Related to https://github.com/kubernetes/website/issues/13948#issuecomment-1007875517

/remove-lifecycle-stale

Hello @gamba47 , are you comfortable continuing with this effort? The last activity for this was ~7 months ago, which is why I'm checking in.

Hi @divya-mohan0209 !! i'm sorry this is a huge text and i always start again and try to mantain the appropiatted words but is not easy.
Please don't close it i will start writing again in a few days.
Sorry!

@gamba47 , please don't be sorry! I know the efforts that go into translation, so it's all good :)

Hey @gamba47, thanks for contributing!
Just take your time to resume the translation when you feel comfortable.
Prevent the bot to close this PR.
/remove-lifecycle stale

Hey @gamba47 , just checking in. Have you gotten any cycles to continue work on this?

I'm not working at this moment but i will finish this translation if you let me continue with this.
I will try to make some changes this week and finish this for october if i can. It's really big and i have to start again every time i got some time to write.

/remove-lifecycle rotten

Hey @gamba47 , we've been following up for quite some time & understand that you're busy. Please feel free to reopen this PR whenever you're comfortable PRing this change in. For now, I shall be closing it.
/close


How to use a custom cell editor

Hi,
This component allows to use basic form elements like "text", "number", "select" and so on.
But I need to use other complex component("vue-multiselect") for cell editing.
How can I do?

Hi there, currently this component only supports bootstrap form elements (in exception to upload and tags which will come soon), but enabling other custom elements would be a good enhancement. I will look into the effort and keep you posted.


Fieldtype „block“ contains wrong content

I defined a contenttype using the 'block' fieldtype like this one:
test:
    name: Test
    singular_name: Test
    singular_slug: test
    fields:
        title:
            label: Global Heading
            type: text
        description:
            label: Global Text
            type: html
        blocks:
            label: Content Elements
            type: block
            fields:
                titlesection:
                    label: Title Section
                    fields:
                        heading:
                            type: text
                textsection:
                    label: Text Section
                    fields:
                        heading:
                            type: text
                        description:
                            type: textarea
                videosection:
                    label: Video Section
                    fields:
                        heading:
                            type: text
                        video:
                            type: video

Now, entering some test content and calling /json/test/1 gives this result:
{
    "links": {
        "self": "http:\/\/test.local\/json\/test\/1"
    },
    "data": {
        "id": "1",
        "type": "test",
        "attributes": {
            "datechanged": "2018-04-11T16:58:58+02:00",
            "title": "Global Heading",
            "description": "<p>Global Text<\/p>\r\n",
            "blocks": [
                {
                    "heading": "Title Section Heading",
                    "_block": "titlesection"
                },
                {
                    "heading": "",
                    "_block": "textsection",
                    "description": "Text Description with no defined heading."
                 If a block does not contain an element of the previous block the content of the previous block shows up in its successor. Eg. the textsection has no field video but in the json there is one - or the videosection has no field description but in the json there is one...
I guess this might be a bug and should be fixed.

Just made a release. Fixed in v3.0.18


Allow create/drop numeric-named databases

This fixes https://github.com/influxdb/influxdb-java/issues/130

If you add some tests i will merge it.


Add documentation

It would be nice to have some documentation, similar to the one for JupyterLab with:

a user guide section
a section for JupyterLab and JupyterLab Classic extension authors
steps for contributing

This could for example be done using Jupyter Book: https://jupyterbook.org/intro.html

The documentation would be useful to extension authors, so they could get a reference of what to expect from this distribution:

areas: top, menu, main
packages: are core lab packages like @jupyterlab/celltags included and made available via the webpack shared scope?
how to build an extension to be shell agnostic

Whether or not their extension will work with JupyterLab Classic (or how to make it work if not).

Closing as this will be documented in the https://github.com/jupyter/notebook/ repo.


typo in the docs

This line:
Example of the result returned by a call to the tree API with /api/page/projects
should be:
Example of the result returned by a call to the tree API with /api/tree/projects

Thanks for the report. Fixed it just now.


Please document the command line utilities

Please add a brief description of each command line utility to README.md. Thank you!

Added some descriptions to the README #25 , but can always be better. Will leave this open until everyone is satisfied.

Thanks, Eric! Close whenever you wish. https://github.com/edawson/gfakluge#command-line-utilities


Close popover in component

So far this works really well! However, I have a situation where I am using a form inside a popover, and need to wait for a success when processing this submitted form before I close the popover. What is the best way to close the popover from my component javascript?

You can control the visibility explicitly with the visible property, see http://www.ember-bootstrap.com/api/classes/Components.Popover.html#property_visible.
Should get even easier when #475 is implemented.


Warnings Functions as object-form attrs({}) keys are now deprecated

Hi. I have warnings with every components imported from styled-components. Am I doing something wrong?
warnings:
Functions as object-form attrs({}) keys are now deprecated and will be removed in a future version of styled-components. Switch to the new attrs(props => ({})) syntax instead for easier and more powerful composition. The attrs key in question is "children" on component "Archive".

Functions as object-form attrs({}) keys are now deprecated and will be removed in a future version of styled-components. Switch to the new attrs(props => ({})) syntax instead for easier and more powerful composition. The attrs key in question is "children" on component "Home".

component:
import React from 'react';
import { Archive, Home } from 'styled-icons/feather';

export default () => (
  <div>
    <Archive />
    <Home />
  </div>
);

versions:
styled-components: 4.1.2
styled-icons: 5.2.2

The warning is gone. I didn't realize until now but I need to restart the app with npm start after update node modules. Thank you for your help with this.

Awesome, glad it's working for you!  🎉


need angular app

can an angular app be designed in typescript to operate graph ?
a simpel hello world?

Hi @nhhockeyplayer, yes of course. When you say, 'to operate the graph' do you mean query subgraphs?


Configure travis to deploy to NPM

For now, let's close this and revisit when/if CFPB has standardized their own credentials to use for publishing to npm. We can use github user/repo#branch style format when doing npm install for now.


Possible solution to override mistake without a new integrity trait

Based on the bug found in https://github.com/tc39/ecma262/pull/1320#issuecomment-443405684:

If a non-writable prototype property exists during o.foo = v

Define a new property on o with { value: v, enumerable: true, writable: true, configurable: true } (like it's defining a new property without extending the parent)
Note: It must be configurable to get past the delete statement when running getRawTag(new Uint8Array(0)).

Extend Object.prototype.toString() special cases with typed arrays, DataView, ArrayBuffer, Map, WeakMap, Set, WeakSet, Promise, etc.

Note: With the ability to write value[Symbol.toStringTag] = undefined, we must fix various builtins to still return the expected [object Foo] values.
Note: This fixes lodash's isTypedArray, isArrayBuffer, etc, functions directly, and the getTag function indirectly by ensuring a few feature checks don't fail and cause a incomplete impl of getTag to be used.

To clarify, this is unilaterally fixing the override mistake, just with mitigations for some observed in-the-wild reliance of the override mistake currently silently failing in sloppy mode?

To clarify, this is unilaterally fixing the override mistake

Correct.

just with mitigations for some observed in-the-wild reliance of the override mistake currently silently failing in sloppy mode?

Incorrect. This fixes an assumption made in both sloppy and strict modes.

In sloppy, the value[Symbol.toStringTag] = undefined would silently fail, and toString.call(new Uint8Array(0)) would return [object Uint8Array] from the string tag.
In strict, value[Symbol.toStringTag] = undefined would throw and be swallowed by the surrounding try-catch. This would still return the [object Uint8Array] from the string tag.

With the new override behavior, this behavior would change. Since the new built-ins don't have special behavior in Object.prototype.toString, they would begin to return [object Object] when their own toStringTag is undefined.

If the override mistake can be fixed unilaterally that is ideal, but if it's not web compatible, we can still fix it without changing the object model I've suggested in the past.
To summarize and simplify that suggestion, we would just have a new slot on ordinary objects, have a way to freeze and set that slot to true, and then OrdinarySetWithOwnDescriptor just performs the override mistake fix if that slot is set to true.
e.g. I called it harden, but it could just be an argument to freeze:
const o = Object.freeze({ x: 10 }, true);
// o is an object { [[AllowOverride]]: true, x: 10 }
const o2 = { __proto__: o };
// o has slot [[AllowOverride]] so the override mistake is disabled.
o2.x = 12;

As this doesn't add any proxy traps it should be very simple to implement (just a bit on ordinary objects so it's extremely lightweight).

Why do you believe it wouldn't require a proxy trap?

Because it adds no machinery to how objects work, it would essentially just change the current check:
a. If ownDesc.[[Writable]] is false, return false.

to:
a. If ownDesc.[[Writable]] is false
  a. If O does not have an [[AllowOverride]] slot or o.[[AllowOveride]] is false, return false.

Freezing would essentially be:
function freezeWithOverride(o) {
    // Prevent a communication channel if the object is already frozen
    if (Object.isFrozen(o)) {
        return;
    }
    if (#allowOverride in o) {
        o.#allowOverride = true;
    }
    Object.freeze(o);
}

The problem is that having no traps prevents a proxy the opportunity to reflect the state of the real target on its shadow target.
Imagine the following simplified pattern that is common in membranes:
const shadowToReal= new WeakMap();
const realToProxy = new WeakMap();

// Traps of the handler lookup the real target from the shadow in shadowToReal
// and reflect the shape of the real target onto the shadow as necessary to respect
// object invariants and according to any distortion that the membrane wants to apply.
const membraneHandler = {...};

const getProxyForTarget = (target) => {
  let proxy = realToProxy.get(target);
  if (proxy) return proxy;
  // Approximation of creating a bare shadow object of the same "kind"
  const shadow = typeof target === 'function' ?
    function() {} :
    Array.isArray(target) ?
      [] :
      { __proto__: null };
  shadowToReal.set(shadow, target);
  proxy = new Proxy(shadow, membraneHandler);
  realToProxy.set(target, proxy);
  return proxy;
};

Without "is overridable" and "make overridable" proxy traps, the following can't work:
const someTarget = {};
const proxy = getProxyForTarget(someTarget);
freezeWithOverride(someTarget);
stampPrivateField(proxy); // This should fail

const someOtherTarget = {};
const otherProxy = getProxyForTarget(someOtherTarget);
freezeWithOverride(otherProxy); // If distortions allow
stampPrivateField(someOtherTarget); // Should now fail

Without "is overridable" and "make overridable" proxy traps, the following can't work:
stampPrivateField(proxy); // This should fail

I wasn't suggesting that the trap for preventing private field stamping can be removed. That is separate as it is actually a fundamental capability for objects. Unlike the override mistake, there is no proxy you can write to emulate such behaviour.
Though yes freezeWithOverride wouldn't pass through proxies in my suggestion, but I don't see this as any different from other builtin methods (e.g. Map.prototype.get) methods not passing through proxies either. The solution for making freezeWithOverride work through the membrane is the same as any other slot-checking builtin — you expose it through the membrane.

Ugh sorry I got my overrides mixed up. But I believe the same argument holds for the assign override mistake. I'll follow up with some examples.

Example:
const someTarget = { foo: 3 };
const proxy = getProxyForTarget(someTarget);
freezeWithOverride(someTarget);
const someDerivedObject = { __proto__: proxy };
someDerivedObject.foo = 4; // This should work if distortions allow

const someOtherTarget = { foo: 3};
const otherProxy = getProxyForTarget(someOtherTarget);
freezeWithOverride(otherProxy); // If distortions allow
const someOtherDerivedObject = { __proto__: someOtherTarget };
someOtherDerivedObject.foo = 4; // This should work

Though yes freezeWithOverride wouldn't pass through proxies in my suggestion, but I don't see this as any different from other builtin methods (e.g. Map.prototype.get) methods not passing through proxies either. The solution for making freezeWithOverride work through the membrane is the same as any other slot-checking builtin functions — you expose it through the membrane.

I think this is where I disagree. Allowing assignment override is an intrinsic aspect of the object (as denoted by the private slot you're adding to described that aspect). I don't see how you would "expose it through the membrane" without making it part of the MOP traps a proxy handler implement. Assignment does not currently trigger user code except for proxy traps, and we should not expand that unfortunate exception. Built-in functions do not do any slot checking on arguments, only on receivers, which is why membranes have to make sure to properly map the receiver when reflecting to the real target. The only intrinsic that brand checks its argument is Array.isArray() and that has special proxy logic that no-one wants to replicate.


lint for print() statements

Type of PR

[x] MAINT

Quick PR to add the flake8-print linter to repo. This should catch any pointless print() statements we forget to remove (excl. those that are commented).

@ADBond can you give the new docs a 5 min check?


Import conflicts with Dscribe

Dear Matid Maintainers,
Since i upgraded matid from version 0.6.3 to 2.0.0 I encounter an import error when running:
import dscribe
import matid

Traceback:
The full traceback I get is:
    import matid
  File ".../miniconda3/envs/fucrimodo/lib/python3.12/site-packages/matid/__init__.py", line 1, in <module>
    from matid.core.periodicfinder import PeriodicFinder
  File ".../miniconda3/envs/fucrimodo/lib/python3.12/site-packages/matid/core/__init__.py", line 1, in <module>
    from matid.core.periodicfinder import PeriodicFinder
  File ".../miniconda3/envs/fucrimodo/lib/python3.12/site-packages/matid/core/periodicfinder.py", line 8, in <module>
    import matid.geometry
  File ".../miniconda3/envs/fucrimodo/lib/python3.12/site-packages/matid/geometry/__init__.py", line 1, in <module>
    from matid.geometry.geometry import *
  File ".../miniconda3/envs/fucrimodo/lib/python3.12/site-packages/matid/geometry/geometry.py", line 22, in <module>
    import matid.ext
ImportError: generic_type: type "ExtendedSystem" is already registered!

Setup:

Python: 3.12.4
matid: >=2.0.0
dscribe: 2.1.1
pip: 24.0
conda: 24.5

Temporary Solution:
The error does not happen when dscribe is installed with conda and matid is installed with pip.
Thank you for your work on the library.
Best,
Louis Böhm

Hi @OHANAN1!
Thanks for reporting this, and for your interest in both dscribe and matid!
I'm not able to reproduce this if I install the newest versions of both libraries (dscribe==2.1.1, matid==2.1.2) with pip or miniforge into a clean environment. I tried this in both Python 3.11 and 3.12. I was using conda==24.7.1.
Do you have any further tips on reproducing this? Maybe the problem is platform-dependent?
Anyways, according to this pybind11 issue, I should be able to solve it. I can create a patch release of matid and let you know so you can test it.

There is now a new version of matid (2.1.3) in both PyPI and conda forge. Could you try if this update solves your problem?

Hi @lauri-codes,
thank you for your quick response. I just realized, that the code to reproduce the error is not correct. Here is the corrected code:
from dscribe import descriptors
import matid

I also tested it with the new version of matid and with conda==24.7.1, but in all chases I got an ImportError. However, with the new version of matid I get a different error message:
import matid
  File ".../miniconda3/envs/test/lib/python3.12/site-packages/matid/__init__.py", line 1, in <module>
    from matid.core.periodicfinder import PeriodicFinder
  File ".../miniconda3/envs/test/lib/python3.12/site-packages/matid/core/__init__.py", line 1, in <module>
    from matid.core.periodicfinder import PeriodicFinder
  File ".../miniconda3/envs/test/lib/python3.12/site-packages/matid/core/periodicfinder.py", line 8, in <module>
    import matid.geometry
  File ".../miniconda3/envs/test/lib/python3.12/site-packages/matid/geometry/__init__.py", line 1, in <module>
    from matid.geometry.geometry import *
  File ".../miniconda3/envs/test/lib/python3.12/site-packages/matid/geometry/geometry.py", line 23, in <module>
    import matid.ext
ImportError: generic_type: type "CellListResult" is already registered!

I also realized if I change the order of imports dscribe raises an error instead:
from dscribe import descriptors
  File ".../miniconda3/envs/test/lib/python3.12/site-packages/dscribe/descriptors/__init__.py", line 17, in <module>
    from dscribe.descriptors.acsf import ACSF
  File ".../miniconda3/envs/test/lib/python3.12/site-packages/dscribe/descriptors/acsf.py", line 21, in <module>
    from dscribe.ext import ACSFWrapper
ImportError: generic_type: type "CellListResult" is already registered!

Should I open an issue on the dscribe repo about that?
Thank you for your work!

@OHANAN1: Sorry this was my bad. I somehow forgot to fix one of the classes. I have now created a new patch release 2.1.4 that should now fix this for you. It is available in PyPI and very soon in conda forge. Re-open this issue if you still run into trouble with the new version.


Migrate TURN & Nevada GPS Stations App

Summary

Application Name: TURN & Nevada GPS Stations
Old Application Url: https://arcg.is/u1yLD / https://utah.maps.arcgis.com/apps/instant/minimalist/index.html?appid=95e0d153d1ce4ba39556c9f94284c68c
New Application Url: https://arcg.is/0SG5ra0

A short summary of the situation.
Minimalist Instant Apps template has been deprecated. The application will be migrated to a different template.
Action items

Assign a person who should complete the task by replacing name with their github @name.
Check [x] the box when the task is completed and add the date of completion.
~Strike~ out all items that do not apply.

Soft Delete
The purpose of the soft delete is to ensure that all of our users have migrated to the new application. Soft deletes will remain in effect for 30 days. During this time, we will have the ability to assure the new application is working correctly. After these 30 days, the item is then ready for a hard delete unless more time is needed.

[x] Publish and share new application with Everyone (public) (@rkelson, completed: 2022/05/10)
[x] Update relevant gis.utah.gov UGRC page links (@rkelson, completed: 2022/05/10)
~[ ] Update relevant gis.utah.gov Developer page links (@rkelson, completed: 2022/00/00)~
[x] Update Application Portfolio Management ("Business Applications" in ServiceNow) (@rkelson, completed: 2022/05/11)
[x] Add splash screen or the like to old application with a deprecation note and link to new application (@rkelson, completed: 2022/05/11)

maybe add a note to Update your Bookmarks

Hard Delete
Hard deletes are final. Complete the soft delete process before moving on to these steps.

[x] Remove old application (@rkelson, completed: 2023/06/23)

Notification

[ ] Twitter (@steveoh)

this can be closed


Add again DNS configuration for crc reproducer path

Add again some tasks to properly configure dnsmasq for crc in the
reproducer. This is needed to make the zuul reproducer job green again.
Now the crc node should have the hypervisor in the resolv.conf but
dnsmasq listening on the right addresses.
Started as a duplicate
https://github.com/openstack-k8s-operators/ci-framework/pull/1944/
without zuul changes to test with downstream zuul, but now proposing this fix for the crc reproducer path to close CIX.
As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running

recheck

/approve
CRC has no IPv6 support, nor immediate plane to get anything there...


As the company, I want to support multiple languages

Description:
Users can change their language settings in their profile settings page.
Supported languages are English and German.
Only the User Interface is affected by the language settings, not the content itself.
User Stories:

[x] #103
[x] #104

I am closing this epic because all my requested features are implemented since I can change between english and german.


"The TypeScript language service died" on specific JS code

Issue Type: Bug
The TypeScript language service died 5 times right after it got started. The service will not be restarted.
Version: 1.41.1 (system setup)
Commit: 26076a4de974ead31f97692a0d32f90d735645c0
Date: 2019-12-18T14:58:56.166Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.18362
To reproduce:

Create a file tst.js:

const Router = require('restify-router').Router;
const router = new Router();
const formidable = require('formidable');

router.post('/user_profile', (req, res, next) => {
    var form = new formidable.IncomingForm();
    form.parse(req)
        .on('field', (name, field) => {
            this[name] = field;
        })
});
module.exports = router;

Open in VS Code
Restart VS.
TS Server crashes on initialization. If comment the row
 this[name] = field;
or change it to
 this.name = field;
the issue doesn't appear.
Disabling extensions doesn't help.

TS Server log attached
tslog.txt

Confirmed in current release (which uses TS 3.7)
Fixed in TypeScript 3.8 (TS powers our JS intellisense as well). To workaround, update your workspace to use typescript@next by installing this extension

Relevant error stack:
Debug Failure. False expression.Error: Debug Failure. False expression.    at declareSymbol (tsserver.js:29212:22)    at bindThisPropertyAssignment (tsserver.js:31366:25)    at bindWorker (tsserver.js:31020:29)    at bind (tsserver.js:30902:13)    at bindExpressionStatement (tsserver.js:30106:13)    at bindChildrenWorker (tsserver.js:29568:21)    at bindChildren (tsserver.js:29489:17)    at bind (tsserver.js:30913:21)    at tsserver.js:29495:94    at bindEach (tsserver.js:29511:21)    at bindEachFunctionsFirst (tsserver.js:29495:13)    at bindChildrenWorker (tsserver.js:29611:21)    at bindChildren (tsserver.js:29489:17)    at bind (tsserver.js:30913:21)    at visitNode (tsserver.js:17622:24)    at Object.forEachChild (tsserver.js:17752:21)    at bindEachChild (tsserver.js:29519:16)    at bindChildrenWorker (tsserver.js:29614:21)    at bindChildren (tsserver.js:29489:17)    at bindContainer (tsserver.js:29435:17)    at bind (tsserver.js:30916:21)    at bindEach (tsserver.js:29511:21)    at visitNodes (tsserver.js:17627:24)    at Object.forEachChild (tsserver.js:17815:21)    at bindEachChild (tsserver.js:29519:16)    at bindCallExpressionFlow (tsserver.js:30360:21)    at bindChildrenWorker (tsserver.js:29596:21)    at bindChildren (tsserver.js:29489:17)    at bind (tsserver.js:30913:21)    at bindExpressionStatement (tsserver.js:30106:13)    at bindChildrenWorker (tsserver.js:29568:21)    at bindChildren (tsserver.js:29489:17)    at bind (tsserver.js:30913:21)    at tsserver.js:29495:94    at bindEach (tsserver.js:29511:21)    at bindEachFunctionsFirst (tsserver.js:29495:13)    at bindChildrenWorker (tsserver.js:29611:21)    at bindChildren (tsserver.js:29489:17)    at bind (tsserver.js:30913:21)


Fix confusing Waypoint: Write Reusable JavaScript with Functions

Fix confusing description and examples.
Remove superfluous and unneeded tests. For example,
editor.getValue().match(/return/gi).length >= 1

will always be true. The regex matches all instances of the string "return" in the code window, even the instance in the comments within the code.
closes #1936

Great work here, @joel-bentley! If you can spare the time to look at our other JavaScript and and OOP challenges, they could use a similar touch, too.

Thanks @QuincyLarson !
I'll take a look and see what I can do.


[ob] Change list result

Currently, all the list result of /ob/* apis return result as like the below.
{
  $defhdr,
  "reuslt": {
    "list": [
      "<uuid string>",
      ...
    ]
  }
}

But it should be changed like the below.
{
  $defhdr,
  "reuslt": {
    "list": [
      {"uuid": "<uuid string>"},
      ...
    ]
  }
}

Done.


GPT Function Call

From cookbook https://github.com/openai/openai-cookbook/blob/main/examples/How_to_call_functions_for_knowledge_retrieval.ipynb
Function signature like this
def get_articles(query, library=paper_dir_filepath, top_k=5):

Requires to pass this JSON Schema to GPT
    {
        "name": "get_articles",
        "description": """Use this function to get academic papers from arXiv to answer user questions.""",
        "parameters": {
            "type": "object",
            "properties": {
                "query": {
                    "type": "string",
                    "description": f"""
                            User query in JSON. Responses should be summarized and should include the article URL reference
                            """,
                }
            },
            "required": ["query"],
        },
    }

Then GPT will return an instance of that schema with values extracted from the user prompt. With that result the function is invoked extracting values from the JSON response.
def call_arxiv_function(messages, full_message):
    """Function calling function which executes function calls when the model believes it is necessary.
    Currently extended by adding clauses to this if statement."""

    if full_message["message"]["function_call"]["name"] == "get_articles":
        try:
            parsed_output = json.loads(
                full_message["message"]["function_call"]["arguments"]
            )
            print("Getting search results")
            results = get_articles(parsed_output["query"])
        except Exception as e:
            print(parsed_output)
            print(f"Function execution failed")
            print(f"Error message: {e}")
        messages.append(
            {
                "role": "function",
                "name": full_message["message"]["function_call"]["name"],
                "content": str(results),
            }
        )
        try:
            print("Got search results, summarizing content")
            response = chat_completion_request(messages)
            return response.json()
        except Exception as e:
            print(type(e))
            raise Exception("Function chat request failed")

    elif (
        full_message["message"]["function_call"]["name"] == "read_article_and_summarize"
    ):
        parsed_output = json.loads(
            full_message["message"]["function_call"]["arguments"]
        )
        print("Finding and reading paper")
        summary = summarize_text(parsed_output["query"])
        return summary

    else:
        raise Exception("Function does not exist and cannot be called")

In .NET we can automate this
public enum Places{
    Restaurant,
    Shop,
    Leisure
}

public interface IMyService{
    string[] search(Places place, string location);
    bool Bool(string placeId);
}

IMyService service = null;

var searchMethodInfo = service.GetType().GetMethods().Where(m => m.Name == "Search");

var response = client.GetChatCompletionsAsync("gpt4", new ChatCompletionsOptions{
  Messages = {  new ChatMessage(ChatRole.User, "Find good food places to eat nearby.") },
  Functions = { searchMethodInfo  }.ToFunctionDefinitions(),
});

var searchResults = searchMethodInfo.Invoke<string[]>(service,  response);

The approach could work not only for objects, but to OpenAPI endpoints of jsonRPC clients too.

Addressed by #3258.


HBASE-28652 Backport HBASE-21785 master reports open regions as RITs …

…and also messes up rit age metric

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 52s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 13s
branch-2.5 passed

+1 :green_heart:
compile
4m  0s
branch-2.5 passed

+1 :green_heart:
checkstyle
1m 10s
branch-2.5 passed

+1 :green_heart:
spotless
1m 11s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 47s
branch-2.5 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  2s
the patch passed

+1 :green_heart:
compile
4m  1s
the patch passed

+1 :green_heart:
javac
4m  1s
the patch passed

+1 :green_heart:
checkstyle
0m 54s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m 36s
Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.

+1 :green_heart:
spotless
1m  2s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 47s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 22s
The patch does not generate ASF License warnings.

49m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5980/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5980

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 4034551d9701 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 571491e20d

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
77 (vs. ulimit of 30000)

modules
C: hbase-hadoop2-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5980/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 47s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 42s
branch-2.5 passed

+1 :green_heart:
compile
0m 50s
branch-2.5 passed

+1 :green_heart:
shadedjars
5m  7s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 33s
branch-2.5 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 16s
the patch passed

+1 :green_heart:
compile
0m 50s
the patch passed

+1 :green_heart:
javac
0m 50s
the patch passed

+1 :green_heart:
shadedjars
5m  4s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 32s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 24s
hbase-hadoop2-compat in the patch passed.

+1 :green_heart:
unit
196m 15s
hbase-server in the patch passed.

219m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5980/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5980

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c639af5ecde0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 571491e20d

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5980/1/testReport/

Max. process+thread count
4125 (vs. ulimit of 30000)

modules
C: hbase-hadoop2-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5980/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 48s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 35s
branch-2.5 passed

+1 :green_heart:
compile
1m 14s
branch-2.5 passed

+1 :green_heart:
shadedjars
5m 43s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
branch-2.5 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  9s
the patch passed

+1 :green_heart:
compile
1m 23s
the patch passed

+1 :green_heart:
javac
1m 23s
the patch passed

+1 :green_heart:
shadedjars
5m 28s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 29s
hbase-hadoop2-compat in the patch passed.

+1 :green_heart:
unit
218m 24s
hbase-server in the patch passed.

247m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5980/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5980

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 53ae750f75ae 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 571491e20d

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5980/1/testReport/

Max. process+thread count
4183 (vs. ulimit of 30000)

modules
C: hbase-hadoop2-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5980/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Whitespace in inline raw blocks affected by justification

Description
Within a par(justify: true), whitespace characters inside inline raw blocks like `foo bar` are subjected to the justification. Since raw blocks are supposed to represent monospace data, I expect all characters within it to be rendered with the same width and to not be subjected to any cosmetic alterations (unless explicitly demanded). So, I assume the proper behaviour would be to treat the raw block as a whole immutable unit for the purposes of justification, regardless of the presence of whitespace inside it
Reproduction URL
No response
Operating system
Web app
Typst version

[X] I am using the latest version of Typst

I think it's more of a feature request. @laurmaedje thoughts?
// tests/typ/bugs/demo.typ
#set par(justify: true)
#set raw(lang: "python")
`if else` foo bar foo bar `if else` foo foo bar bar!!

The view is that the space within the if else span should not be affected by justification.

I see how it's not necessary what one would expect. Whether we want to label that a bug or feature request, idk.

@elegaanz I think ParElem::set_shrink(false) will only affect paragraphs for which it is set uniformly, so inline raw alongside some text wouldn't be affected.


Optional volume names

Names should be optional when creating a volume.
Description of the feature or enhancement:
I would like to create a volume without explicitly setting its name, just like with resources:
kplus.Volume.fromEmptyDir(self, 'Data')

But right now we have to:
kplus.Volume.fromEmptyDir(self, 'Data', 'data')

Which is kind of redundant
Use Case:
Just better ergonomics.
Proposed Solution:
Use the construct path to generate a name, just how we do with api objects.

[ ] :wave: I may be able to implement this feature request
[ ] :warning: This feature might incur a breaking change

This is a :rocket: Feature Request

Unfortunately this would be a breaking change. So we either need to think creatively or wait for v3


Making HealthCheck.Result class extensible

I want to extend the Result class to enhance the health checks module for providing additional details. For e.g. I would add another health state in there - MAINTENANCE to indicate my servers are in the maintenance mode and also provider an optional placeholder Map to provide any additional details. Currently, Result class have only healthy and unhealthy states and furthermore, there is no way to provide additional info other than message.
So, I tried to extend the HealthCheck class and add these details in there. However, due to absence of default no arg constructor in Result class, it's not possible to subclass Result.
So would like to propose this change or get the feedback.
Thanks!

I'd also like to see this happen.  I'd be open to creating a PR as well.
In our case, the two states of healthy and unhealthy aren't enough.  For us, unhealthy means drop the service from the pool.  I'd like a third state that indicates there's an issue but the service is still able to handle traffic.
Specific example: We have a pool of memcache servers that the server talks to.  If it loses connectivity with one of those server, it's not a big deal, but something to be alerted and investigated.
I suppose we could write a parser for the output, but I'd rather not have to do that for each case.

+1 yes, please! It would make it possible to add JSON nodes to the response with extra details

+1 too ! :-)

+1

I think it would be possible to allow custom details by adding a Map<String,Object> as spring-boot-actuator does without breaking the API.
Like that, we wouldn't be forced to wait for version 4.0.0.
What do you think ?

Branch off 3.1-maintenance and I'd be happy to look at a pull request that adds that support for a 3.2 release.

Okay, I'll take a look asap. Keep in touch.

So if I get it right, master is for 4.0.0.
I suppose I need to base my code on 3.1-maintenance and make a pull request on a new branch. Correct ?

Our use case is this:  We use the health check framework to inform our on-call alerting.  As is, we basically have two states: UP or DOWN.  We wanted a third state, WARN, to indicate a problem with our application, but not worthy of waking someone up in the middle of the night.
So being able to have additional HealthCheck result types would be very helpful.

This looks like changes for this was merged into 3.2.0 in https://github.com/dropwizard/metrics/pull/943, so is this issue complete?


Tool to automatically convert obsolete variables from input file

There should be a tool that can automatically convert obsolete variables to their new names for you, or remove them if there is no replacement.

https://github.com/ukaea/PROCESS/pull/3397
There is a PR waiting to be reviewed


Logged an error in the console

[Error  :Lethal Autocomplete] System.NullReferenceException: Object reference not set to an instance of an object   at LethalAutocomplete.Autocomplete.Insert (TerminalKeyword terminalKeyword) [0x00156] in <ba39fceca9724824b2741e84e7ac4946>:IL_0156    at LethalAutocomplete.AutocompleteManager.TerminalIsStarted (System.Object sender, TerminalApi.Events.Events+TerminalEventArgs e) [0x0004b] in <ba39fceca9724824b2741e84e7ac4946>:IL_004B
I haven’t observed any bugs that apparently occur in the game. However, I believe this message may be important.
r2modman Profile Code: 018dc5d1-511f-69de-edf3-32ddeb858d9c

Hey, Foahh, thanks for paying attention to this and letting me know. I looked at this problem and realized that some words from other mods weren't added to the autocomplete list. I fixed it and will soon upload with a new update.


Try QSSA on AMP

d = (1/2K) * (-t + sqrt(t^2 + 4kt * (Tot - t)))

DomainError from sqrt because some concentrations might be negative in the integration step.


[Event Request] Codeunit 5988, 10 new Events

We need 10 Events in CU 5988 to handle own ISV Code.

Function „PrepareShipmentHeader“

The Event needs the following parameters:

Function „PrepareShipmentHeader“

The Event needs the following parameters:

Function „PrepareShipmentHeader“

The Event needs the following parameter:

Function „PrepareShipmentLine“

The Event needs the following parameter:

Function „PrepareInvoiceHeader“

The Event needs the following parameter:

Function „PrepareInvoiceHeader“

The Event needs the following parameter:

Function „PrepareInvoiceLine“

The Event needs the following parameter:

Function „PrepareCrMemoHeader“

The Event needs the following parameter:

Function „PrepareCrMemoHeader“

The Event needs the following parameter:

Function „PrepareCrMemoLine“

The Event needs the following parameter:

Thanks!!

Just checked my requests against newest BC-Code.
Please place Function3-request, Function6 and Function9-request before the EXIT!
Thanks!


Prometheus metrics server and example deployments

#202 parts 2 and 3
This adds a metrics command to kubescape to start a web server. It will scan in the background and update frameworks in the background, whilst serving scan results on /metrics
Also includes an example deployment of this.

@Joibel isn't kubescape supposed to run as a job and than exit? When would prometheus query the data you export and if it waits when do you tell it to exit? Or is the scheduling of the scanning done inside the service itself?

@yonahd yes, traditionally it ran as a job and exited.
Prometheus runs as a continuous process. It's design is to go out to external data sources and scrape them on a periodic basis. So something needs to serve the kubescape results over http so that prometheus can scrape the values from it.
So I've added a mode to kubescape to run as an http server to do this job. It doesn't have to be done this way, and I did explore other options. You could for example run nginx calling kubescape to perform scrapes on demand.
The scrape on demand model doesn't work very well (I wrote it this way to start with) because even on my relatively modest cluster a scrape takes longer than 10 seconds, and not responding to http for that long is bad practice. We could concoct a much more complex container which scraped in the background, putting its results in a location that a web server can serve, but this is not very good container form, you shouldn't really have multiple processes and run cron jobs. A multicontainer image would work in kubernetes, and should this pull request get rejected I'll probably end up doing it that way.
So this container runs a background thread collecting scans and periodically doing downloads, so yes, the scheduling is done inside clihandler/cmd/metrics.go:backgroundScanner(). The web server sits there serving the results of those scans. It expects to sit there running forever, and only terminates when the pod is terminated. Having a permanently running pod is the only sane solution for a prometheus monitor as it would expect to be able to go and get results on its own schedule.

@Joibel got it makes sense.
It is a little strange but I guess the user can restart the deployment /scan using something like this
apiVersion: batch/v1beta1
kind: CronJob
metadata:
  name: deployment-restart
  namespace: <YOUR NAMESPACE>
spec:
  concurrencyPolicy: Forbid
  schedule: '0 8 * * *' # cron spec of time, here, 8 o'clock
  jobTemplate:
    spec:
      backoffLimit: 2 # this has very low chance of failing, as all this does
                      # is prompt kubernetes to schedule new replica set for
                      # the deployment
      activeDeadlineSeconds: 600 # timeout, makes most sense with
                                 # "waiting for rollout" variant specified below
      template:
        spec:
          serviceAccountName: deployment-restart # name of the service
                                                 # account configured above
          restartPolicy: Never
          containers:
            - name: kubectl
              image: bitnami/kubectl # probably any kubectl image will do,
                                     # optionaly specify version, but this
                                     # should not be necessary, as long the
                                     # version of kubectl is new enough to
                                     # have `rollout restart`
              command:
                - 'kubectl'
                - 'rollout'
                - 'restart'
                - 'deployment/<YOUR DEPLOYMENT

I'm not sure why you'd want to restart the deployment on a
Internally when you run kubescape metrics it will rescan every 5 minutes (-i parameter) and redownload the framework every 4 hours (-u parameter). Kubescape metrics is calling kubescape scan internally.
The restart would just interfere with that. It would update kubescape if you were using an image tag that moved for the deployment, like :latest. (And had an imagePull Policy of Always). However, for properly secure and managed environments it'd be preferable to run a known tag and update that through some management mechanism like gitops so you knew which containers you were running.

@Joibel didn't see you added these flags.
Makes sense now. Thanks for clarifying

No problem @yonahd. I've had my head in prometheus for weeks now doing various things, and it took a long time to get my head around how it fits into things.

Hi @yonahd. This has stalled and I'm not sure whether the code has fundamental issues you're unhappy with or whether you'd like to merge it and you want me to just resolve the merge conflicts?

Hi @Joibel, we did not accept this yet mainly because we already have a different architecture of running Kubescape as a server.
If it's ok by you, I will contact you in private so we can talk this in through :)

@dwertent OK. I'll be around on discord, so we can chat there.

@Joibel I really like the idea here and we'd like to adopt this method of running kubescape to build some prometheus alerts and grafana dashboards around the service.
@dwertent Can you provide any pointers on the method of running kubescape as a server you mentioned above?

@james1miller93 We are working on the development of the server, thanks to @Joibel who gave us a very useful input regarding prometheus support.
This feature will officially be released in the close few weeks, since we are currently working on some other features...

@dwertent any update on this?

Hi @adberger , I published a beta version.
You can see here the yaml, readme, and the source code. (Ignore the rest of the files in the directory).
This is a beta version, the official release will be available in the close few weeks.
We will approve the prometheus format output and build a better wrapper for the microservice.

Hi @adberger , I published a beta version. You can see here the yaml, readme, and the source code. (Ignore the rest of the files in the directory). This is a beta version, the official release will be different and will be available in the close few weeks (This is why I did not except the PR).
We will approve the prometheus format output and build a better wrapper for the microservice.

Thank you!
Works fine for me, although I needed to increase the scraping interval & timeout, which makes sense considering the whole cluster gets scanned on each call.
If anyone is interested, here is what I did:
Deploy kubescape
kubectl apply -f https://raw.githubusercontent.com/dwertent/kubescape/server-support/httphandler/ks-prometheus-support.yaml

Edit kubescape Deployment
kubectl edit deploy kubescape -n ks-scanner

Add 'name: http' to ports:
        ports:
        - containerPort: 8080
          name: http
          protocol: TCP

Deploy kube-prometheus-stack
helm repo add prometheus-community https://prometheus-community.github.io/helm-charts
helm repo update
helm install kube-prometheus-stack prometheus-community/kube-prometheus-stack --set prometheus.prometheusSpec.podMonitorSelectorNilUsesHelmValues=false,prometheus.prometheusSpec.serviceMonitorSelectorNilUsesHelmValues=false

Deploy PodMonitor (podmonitor.yaml)
apiVersion: monitoring.coreos.com/v1
kind: PodMonitor
metadata:
  name: kubescape
  labels:
    app: kubescape
spec:
  selector:
    matchLabels:
      app: kubescape
  podMetricsEndpoints:
  - port: http
    interval: 60s
    scrapeTimeout: 30s

kubectl apply -f podmonitor.yaml -n ks-scanner

I pushed to dev the official Prometheus support.
Please follow here. We will make some more changes but this is already better than what we have now.
Please feel free to share your feedback :)

It's official, we added Prometheus support!!


Add slide animation on preview-list

When clicking on a pull request, the project list is hidden with an animation. When you open the page like normal, no animation is played.

LGTM!


How can i to implement class - methods?

Hi,
I am implementing the bundle in Symfony 3, with general installation but I do not know how to put this:
<?php
namespace AppBundle\Entity;
class User implements \Hackzilla\Bundle\TicketBundle\Model\UserInterface
{
}

Can you help me?

Thanks.

Hey,
The Bundle has built in entity that you can use, or copy.
https://github.com/hackzilla/TicketBundle/tree/master/Entity
Also checkout the Ticket Bundle Demo App to config, as I've commented out how you specify them.


automatic-timezoned: 1.0.87 -> 1.0.91

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/maxbrunet/automatic-timezoned/releases.
meta.description for automatic-timezoned is: Automatically update system timezone based on location
meta.homepage for automatic-timezoned is: https://github.com/maxbrunet/automatic-timezoned
meta.changelog for automatic-timezoned is: https://github.com/maxbrunet/automatic-timezoned/blob/v1.0.91/CHANGELOG.md
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.0.91 with grep in /nix/store/23wxgkwyg0lf3sinbcv1liq492mz9cxa-automatic-timezoned-1.0.91
found 1.0.91 in filename of file in /nix/store/23wxgkwyg0lf3sinbcv1liq492mz9cxa-automatic-timezoned-1.0.91

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
automatic-timezoned

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/23wxgkwyg0lf3sinbcv1liq492mz9cxa-automatic-timezoned-1.0.91 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A automatic-timezoned https://github.com/r-ryantm/nixpkgs/archive/25c193034f4628ddba645fc3794ba72f5f91da5d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/23wxgkwyg0lf3sinbcv1liq492mz9cxa-automatic-timezoned-1.0.91
ls -la /nix/store/23wxgkwyg0lf3sinbcv1liq492mz9cxa-automatic-timezoned-1.0.91/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

automatic-timezoned

Maintainer pings
cc @maxbrunet for testing.

Result of nixpkgs-review pr 233275 run on x86_64-linux 1

1 package built:

automatic-timezoned


radicle-upstream: 0.2.3 → 0.2.9, enable on darwin

Motivation for this change

Changelog
Enable on darwin

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Apologies for the delayed review. This looks good and works great for me on nixos. Unfortunately I don't have access to a macos machine where I can test the new darwin version...

There is a merge conflict. Would you be willing to have a look at it?
I have darwin and can test and merge when the change is done.

@happysalada are we good to go now? The recent github outage has reminded people why these projects are important.

Result of nixpkgs-review pr 132367 run on x86_64-darwin 1

1 package built:

radicle-upstream

All good, thank you for the PR!


Right click

Hey @davidmckenzie
Would it be possible to enable the right click options to open links in new tabs on source capcode agency and alias on the index pages please? Atleast in Chrome these can only be opened by left clicking.

Looking at this again - clicking on source/capcode/agency/alias should show a popover with contextual links (filter, edit, etc.), and maybe some more information.
E.g. if logged in and clicking on the alias, it could show the settings of that alias or something. If not logged in, perhaps it could show a description or comment field for the alias, as well as filter links.
Consider making the edit link open a modal instead of redirecting to the edit page.


Regarding PHP API

Hi Team,
Nice Work !
Can We do this using PHP Curl ?
When I used Curl after some time url is expired, how can i fix this?
and room is not created in my panel but chat work fine below is my code :
`<?php
$curl = curl_init();
curl_setopt_array($curl, array(
CURLOPT_URL => "https://api.eyeson.team/webhook",
CURLOPT_RETURNTRANSFER => true,
CURLOPT_ENCODING => "",
CURLOPT_MAXREDIRS => 10,
CURLOPT_TIMEOUT => 30,
CURLOPT_HTTP_VERSION => CURL_HTTP_VERSION_1_1,
CURLOPT_CUSTOMREQUEST => "POST",
CURLOPT_POSTFIELDS => "------WebKitFormBoundary7MA4YWxkTrZu0gW\r\nContent-Disposition: form-data; name="types"\r\n\r\nroom_update\r\n------WebKitFormBoundary7MA4YWxkTrZu0gW--",
CURLOPT_HTTPHEADER => array(
"authorization: --key--",
"cache-control: no-cache",
"content-type: multipart/form-data; boundary=----WebKitFormBoundary7MA4YWxkTrZu0gW",
"postman-token: 635678b8-1971-49f2-c365-862f4d1ad626"
),
));
$response = curl_exec($curl);
$err = curl_error($curl);
curl_close($curl);
if ($err) {
echo "cURL Error #:" . $err;
} else {
echo $response;
}`

Hi! You can use any method to contact the API, have a look on the request class to see how it is done in the package. A meeting link expires if no one joins so only join a room when someone wants to join (and redirect) and do not start a meeting upfront, there is no need to. Best wishes!

Thanks for reply and help me. There is one more concern if creating guest link why it auto fill name how can we fill the correct name using code

If you already have the name of your participant you can simply add them to the room: use the same room identifier so your users will end up in the same meeting. For sure you can also use the guest token to join users but this is rather useful when inviting people within a meeting.


Update snapshots

Update snapshots
#1322

Codecov Report

Merging #1324 into master will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1324      +/-   ##
==========================================
+ Coverage   76.88%   76.99%   +0.11%
==========================================
  Files         226      222       -4
  Lines        4404     4347      -57
  Branches      843      840       -3
==========================================
- Hits         3386     3347      -39
+ Misses        891      874      -17
+ Partials      127      126       -1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbf551b...593744d. Read the comment docs.


python312Packages.monai-label: init at 0.8.4

Init python311Packages.monai-label, a package for medical image labelling with deep learning, and its dependencies, python312Packages.{numpymaxflow,girder-client,timeloop}.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Lifted the upper Python 3.11 upper bound due to setuptools API changes.


fix decode_png function.

Problem: In the case of palette png & args channels=0, force into grayscale.
https://github.com/tensorflow/tensorflow/issues/20028

@yoya Thanks for sending this PR. Can you please sign the CLA?

Nagging Assignee @caisq: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @caisq: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Thank you for telling me how to add tests.
Please wait for a while.
I'll add the follwing two image files & test settings.

lena_palette.png
lena_palette_trns.png

Sounds good, thanks. Please let me know when you're done.

https://github.com/tensorflow/tensorflow/pull/20029/commits/b28b82052525517beff238d2c53bde0171a4a59f
I added two PNG palette image files to the test coverage.

https://github.com/tensorflow/tensorflow/pull/20029/commits/1f31116a081afbf6794c5247a0b3b8ac120896b0
Excuse me. I added a line break.

Jenkins test this please (I think this should work...)

@caisq can you help me get this committed? I'm not familiar with the PR process

Jenkins test this please


feat: add landle and test button #63

Issue: feat #63

Feature

Description
This Pull Request implement the UI Component Manager landle for develop and test components and add a test button to the Testinho.tsx file to facilitate testing and integration with Landle.

Cause
Problems with component tests when they were done directly in the file App.tsx

Solution
We'll use landle to enhance tests of the components of our project.

Changelog

add landle dependencies on package.json
add a test button on Testinho.tsx
add new file Testinho.stories.tsx for tests on landle

Visual evidences :framed_picture:

Checklist

[x] Issue linked
[x] Build working correctly
[x] Tests created

@aalmeida00 só falta vc aprovar man!


404 (Not Found) ionic-starter-sidemenu/archive/master.zip

Srs.,
While starting a new template project I got this error
404 (not found)
https://github.com/driftyco/ionic-starter-sidemenu/archive/master.zip
Please solve it!

Got 1.3.3 and the same error when starting new template...

That's because It's Offline the server that provides the templates or your
internet was down. Give it a few hours and try again.
Best Regards,
Em seg, 2 de fev de 2015 às 21:53, honzix23<EMAIL_ADDRESS>escreveu:

Got 1.3.3 and the same error when starting new template...
--
Reply to this email directly or view it on GitHub
https://github.com/driftyco/ionic/issues/2601#issuecomment-72564429.


Different OOG error types

It would be nice for foundry (and likely reth) if there were a few different kinds of OutOfGas error types. For example, in https://github.com/foundry-rs/foundry/issues/3971 I had to patch foundry and add debugging lines to revm to figure out this was a memory limit OOG error.
Some variants may be:
pub enum OutOfGasError {
    // Basic OOG error
    OOG,
    // Tried to expand past REVM limit
    MemoryLimit,
    // Basic OOG error from memory expansion
    Memory,
    // Precompile threw OOG error
    Precompile,
    // When performing something that takes a U256 and casts down to a u64, if its too large this would fire
    // i.e. in `as_usize_or_fail`
    InvalidOperand
}

then the Return::OutOfGas would become Return::OutOfGas(OutOfGasError::OOG) or whatever variant best suits the error

That is a really good idea, and variants make senes!
Return was for a reason leaf as a simple dummy (not rust like) enum, so the change would be just adding a new field to it
Recently Result was renamed to InstructionResult: https://github.com/bluealloy/revm/blob/main/crates/interpreter/src/instruction_result.rs
And new type for Return is made for better ux: https://github.com/bluealloy/revm/blob/main/crates/primitives/src/result.rs#L117

i can take this on.

i can take this on.

Go for it! Add ordinary fields to InstructionResult and add struct that @brockelmore wrote to Halt: https://github.com/bluealloy/revm/blob/main/crates/primitives/src/result.rs#L117


Add functionality to display x-axis and y-axis

For debugging purposes, it's useful too see the cartesian axes. We can have a boolean reference on whether to display the axes, or not. We have to expose a function display_axis : bool -> unit where, dispay_axis true enables displaying the axes and display_axis false disables it.
Later in the init method, if the reference is true, we should display the axes.
https://github.com/Sudha247/ocaml-joy/blob/3b8dc79d4246f52a1905f8770d41d32f06eb9bb8/lib/shape.ml#L37-L39
The axes need to duller in colour, perhaps some shade of grey, to distinguish them from other shapes.
Useful reading material: https://cs3110.github.io/textbook/chapters/mut/refs.html

@FayCarsons please go ahead!

So, I'm very new to OCaml. I have experience with Rust and Clojure but this syntax is a bit foreign in places.
Here's what I have so far (in shape.ml):
`let axes_flag = ref false;
let draw_axes flag =
axes_flag := flag;
let render_axes =
moveto 0 0;
lineto 0 500;
moveto 0 0;
lineto 500 0;`
and then in init:
`let init () =
open_graph " 500x500";
if !axes_flag then
set_color (rgb 127 127 127);
render_axes;
set_color black`
and when I try to run dune build I get a syntax error at line 30 of shape.ml, after another function(render_shape) that was already there? Really confused as to what's going on. Examples have been working and I've been able to play around a bit. I added the signature of draw_line to shape.mli as well.
Can anyone else see an issue here?

Hi @FayCarsons, I think what you're trying to do is correct. Note that ; in OCaml is merely a separator between two statements. So, when you want to create a reference variable axes_flag and a function to set it, it needs to be
let axes_flag = ref false in
let draw_axes flag =
  axes_flag := flag
in
...

In your code this is separated by ;, so the compiler treats it as a single block of code. I presume hence the syntax error. Could you please try this?

Hello! Since this issue has not been assigned yet, can I be assigned this issue please?

Hi @TitilayoAdeyemi, thanks for your interest. @FayCarsons is working on this and has an open PR. I encourage you to take a look at other good-first-issues. :)

Hi Sudha. Oh I'm sorry, I didn't realize it was assigned already. I have checked all the issues and they've all been assigned as well.

Implemented in #17. I'm closing this. Thanks for the work @FayCarsons!

@TitilayoAdeyemi I'll try to create more issues today.


How to optimize Docker image pull time?

I'm iterating on our pipeline running with our container and one major time sink is the time required to pull the Docker container (which we can't really make too much smaller) to run the pipeline in the container. Is there anyway we can do better? Would self-hosted builds help by being able to control the machine's local Docker image cache and then agents spawned on that machine not need to download?

Yes, self-hosted agent would help, for that reason.

@cdietschrun we are also working on cache popular container base image on the hosted pool, can you share the base image info with us? you can also just point me to the dockerfile if it's public.

@TingluoHuang  I can't, our base is a custom base. Thanks though.
Sounds good, I will dig into the self hosting aspect. Any idea if we can self host in Azure?

@cdietschrun sure, the agent is just a xcopy zip/tar.gz, you can download and run it anywhere you want, like Azure VM.

This has worked well for me so I'm closing the question. Thanks all!


Is the Android import in MainApplication.java really needed?

I wonder what's the purpose of the following import:
import com.wix.reactnativenotifications.RNNotificationsPackage;

in MainApplication.java. As stated by the docs this is needed, but I don't get any different results if I remove it.

I think it's useless. RN 0.6x+ auto link native modules.
https://github.com/react-native-community/cli/blob/master/docs/autolinking.md


fix(RHIDP-2118): Collect postgresql index usage

Add support to collect index usage for backstage_plugin_catalog, backstage_plugin_auth, backstage_plugin_app, backstage_plugin_scaffolder, postgres backstage_plugin_search databases. Output  should be around 0.99

/test mvp

/test mvp


Dummy

costumer tab is almost complete, needs final touch. Age calculator is needed too.
For Color code, Hridaya needs to finish register part


feat: Allow registerDestination to infer mTLS certs on CF

Closes SAP/cloud-sdk-backlog#ISSUENUMBER.

Notes on open questions from Discussion with @marikaner:

Where should inferMtlsCertificate be specified?

RegisterDestinationOptions seems like a good place, not yet clear how this can be accessed from getAgentConfig

What properties should Destination have (does already have a lot)?
What would actual usage look like in application code consuming the sdk?

Which information is available at which point/when calling registerDestination?

replaced by #3781


Updating multi_fidelity_dp run_adam function for gpflow 2.x

Hi, how do i update the Adam optimizer to cater to the format of gpflow 2?
(https://github.com/EmuKit/emukit/blob/master/emukit/examples/multi_fidelity_dgp/multi_fidelity_deep_gp.py)
def run_adam(self, lr, iterations):
    adam = AdamOptimizer(lr).make_optimize_action(self)
    actions = [adam, PrintAction(self, 'MF-DGP with Adam')]
    loop = Loop(actions, stop=iterations)()

This is my DGP_Base class (the run_adam function is at the end)
class DGP(Module):
    def __init__(self, X: list, Y: list, layers: list, likelihood, num_samples=10):
        super().__init__(name="DeepGP")

        self.Y_list = Y
        self.X_list = X
        self.num_samples = num_samples
        for i, (x, y) in enumerate(zip(X, Y)):
            setattr(self, 'num_data' + str(i), x.shape[0])
            setattr(self, 'X' + str(i), Parameter(x))
            setattr(self, 'Y' + str(i), Parameter(y))

        self._train_upto_fidelity = -1
        self.num_layers = len(layers)
        self.likelihood = BroadcastingLikelihood(likelihood)
        self.layers = layers
        self.L = 0
        self.KL = 0

    @staticmethod
    def _likelihood_at_fidelity(Fmu, Fvar, Y, variance):
        """
        Calculate likelihood term for observations corresponding to one fidelity

        :param Fmu: Posterior mean
        :param Fvar: Posterior variance
        :param Y: training observations
        :param variance: likelihood variance
        :return:
        """
        return -0.5 * np.log(2 * np.pi) - 0.5 * tf.math.log(variance) \
               - 0.5 * (tf.square(Y - Fmu) + Fvar) / variance

    def _build_predict(self, X, full_cov=False, num_samples=10, fidelity=None):
        """
        Predicts from the fidelity level specified. If fidelity is not specified, return prediction at highest fidelity.

        :param X: Location at which to predict
        :param full_cov: Whether to predict full covariance matrix
        :param num_samples: Number of samples to use for MC sampling between layers
        :param fidelity: zero based fidelity index at which to predict
        :return: (mean, variance) where each is [num_samples, N, 1] where num_samples is number of samples and N is number of predicted points.
        """

        if fidelity is None:
            fidelity = -1

        _, Fmeans, Fvars = self.propagate(X, full_cov=full_cov, num_samples=num_samples)
        return Fmeans[fidelity], Fvars[fidelity]

    def E_log_p_Y(self, X_f, Y_f, fidelity=None):
        """
        Calculate the expectation of the data log likelihood under the variational distribution with MC samples

        :param X_f: Training inputs for a given
        :param Y_f:
        :param fidelity:
        :return:
        """

        Fmean, Fvar = self._build_predict(X_f, full_cov=False, num_samples=self.num_samples, fidelity=fidelity)

        if fidelity == (self.num_layers - 1):
            """
            KC - The likelihood of the observations at the last layer is computed using the model's 'likelihood' object
            """
            var_exp = self.likelihood.variational_expectations(Fmean, Fvar, Y_f)  # S, N, D
        else:
            """
            KC - The Gaussian likelihood of the observations at the intermediate layers is computed using the noise
            parameter pertaining to the White noise kernel.

            This assumes that a White kernel should be added to all layers except for the last!
            If no noise is desired, the variance parameter in the White kernel should be set to zero and fixed.
            """
            variance = self.layers[fidelity].kern.kernels[-1].variance

            f = lambda vars_SND, vars_ND, vars_N: self._likelihood_at_fidelity(vars_SND[0],
                                                                               vars_SND[1],
                                                                               vars_ND[0],
                                                                               vars_N)

            var_exp = f([Fmean, Fvar], [tf.expand_dims(Y_f, 0)], variance)

        return tf.reduce_mean(var_exp, 0)

    def propagate(self, X, full_cov=False, num_samples=10, zs=None):
        sX = tf.tile(tf.expand_dims(X, 0), [num_samples, 1, 1])
        Fs, Fmeans, Fvars = [], [], []
        F = sX
        zs = zs or [None, ] * len(self.layers)
        for i, (layer, z) in enumerate(zip(self.layers, zs)):
            if i == 0:
                F, Fmean, Fvar = layer.sample_from_conditional(F, z=z, full_cov=full_cov)
            else:
                '''
                KC - At all layers 1..L, the input to the next layer is original input augmented with
                the realisation of the function at the previous layer at that input.
                '''
                F_aug = tf.concat([sX, F], 2)
                F, Fmean, Fvar = layer.sample_from_conditional(F_aug, z=z, full_cov=full_cov)

            Fs.append(F)
            Fmeans.append(Fmean)
            Fvars.append(Fvar)
        return Fs, Fmeans, Fvars

    def predict_f(self, Xnew, num_samples, fidelity=None):
        return self._build_predict(Xnew, full_cov=False, num_samples=num_samples, fidelity=fidelity)

    def predict_f_full_cov(self, Xnew, num_samples, fidelity=None):
        return self._build_predict(Xnew, full_cov=True, num_samples=num_samples, fidelity=fidelity)

    def predict_all_layers(self, predict_at, num_samples, full_cov=False):
        return self.propagate(predict_at, full_cov=full_cov,
                              num_samples=num_samples)

    def predict_y(self, Xnew, num_samples):
        Fmean, Fvar = self._build_predict(Xnew, full_cov=False, num_samples=num_samples)
        return self.likelihood.predict_mean_and_var(Fmean, Fvar)

    def predict_log_density(self, Xnew, Ynew, num_samples):
        Fmean, Fvar = self._build_predict(Xnew, full_cov=False, num_samples=num_samples)
        like = self.likelihood.predict_log_density(Fmean, Fvar, Ynew)
        log_num_samples = tf.math.log(tf.cast(num_samples, tf.float64))
        return tf.reduce_logsumexp(like - log_num_samples, axis=0)

    def mf_elbo(self):
        """
        ELBO calculation
        :return: MC estimate of lower bound
        """
        L = 0.
        KL = 0.
        for fidelity in range(self.num_layers):

            if (self._train_upto_fidelity != -1) and (fidelity > self._train_upto_fidelity):
                continue

            X_l = getattr(self, 'X' + str(fidelity))
            Y_l = getattr(self, 'Y' + str(fidelity))

            n_data = getattr(self, 'num_data' + str(fidelity))
            scale = tf.cast(n_data, tf.float64) / tf.cast(tf.shape(X_l)[0], tf.float64)

            L += (tf.reduce_sum(self.E_log_p_Y(X_l, Y_l, fidelity)) * scale)
            KL += tf.reduce_sum(self.layers[fidelity].KL())

        self.L = L
        self.KL = KL

        return self.L - self.KL

    def multi_step_training(self, lr_1 = 3e-3, lr_2= 1e-3, n_iter=5000, n_iter_2=15000):
        """
        Train with variational covariance fixed to be small first, then free up and train covariance alongside other
        parameters. Inducing point locations are fixed throughout.
        """
        for layer in self.layers[:-1]:
            layer.q_sqrt.assign(layer.q_sqrt * 1e-8)
            set_trainable(layer.q_sqrt, False)

        self.layers[-1].q_sqrt.assign(self.layers[-1].q_sqrt * self.Y_list[-1].var() * 0.01)
        set_trainable(self.layers[-1].q_sqrt, False)

        self.likelihood.likelihood.variance.assign(self.Y_list[-1].var() * 0.01)
        set_trainable(self.likelihood.likelihood.variance, False)

        # Run with covariance fixed
        print('-' * 100)
        print('Optimization with Fixed Covariance: {} Iterations'.format(n_iter))
        print('-' * 100)
        self.run_adam(lr_1, n_iter)

        # Run with covariance free
        print('-' * 100)
        print('Optimization with Free Covariance: {} Iterations'.format(n_iter_2))
        print('-' * 100)
        set_trainable(self.likelihood.likelihood.variance, True)

        for layer in self.layers:
            set_trainable(layer.q_sqrt, True)

        self.run_adam(lr_2, n_iter_2)

    def fix_inducing_point_locations(self):
        """
        Fix all inducing point locations
        """
        for layer in self.layers:
            set_trainable(layer.feature.Z, False)

    def run_adam(self, lr, iter_):
        """
        Utility function running the Adam optimizer
        """
        optimizer = tf.optimizers.Adam(learning_rate=lr)
        for ii in range(iter_):
            with tf.GradientTape(watch_accessed_variables=False) as tape:
                tape.watch(self.trainable_variables)
                objective = -self.mf_elbo()
                gradients = tape.gradient(objective, self.trainable_variables)
            optimizer.apply_gradients(zip(gradients, self.trainable_variables))
            print("Iteration: %3d | ELBO = %5.5f | KL = %5.5f | OBJ = %5.5f" % (ii + 1, self.L, self.KL, objective))

So far is my implementation correct? the code runs, however im afraid i might be doing something wrong

Sorry, I am not keeping up with GPFlow really, this question is better asked at GPFlow repo. But it's a good point, I'll make a note that the example in Emukit requires GPFlow 1.x
If you do figure it out, please let us know here! We could consider updating the example.

Added a note on versions: https://github.com/EmuKit/emukit/commit/02b04ff96f04ce853b567b1609691555444f94b7


Test all features across different devices and browsers.

User Story:
As a user
I want the application to be adjusted across different browsers and devices
Acceptance Criteria:
WHEN I open the application on the default browser
THEN I am presented with an organized page
WHEN I switch to a different device
THEN the formation of the page will be adjusted accordingly to present a nice review
WHEN I click on the different functions of the application
THEN I am presented with a responsive and user-friendly page


[ZEPPELIN-1763] Prevent duplicate $scope.$on('setNoteMenu') calls

What is this PR for?
It's to fix the issue 'ZEPPELIN-1763' (Zeppelin hangs if I repeatedly select and deselect note name).
When the note name was changed, there was a problem that the 'setNoteName' listener was registered in duplicate and occupied resources.
To fix it, I moved the function that registers the listener out of initNoteBook()
What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
ZEPPELIN-1763
How should this be tested?
Repeat changing note name.
Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

The listners are added in duplicate on $scope.$on('setNoteMenu') calls.

Thanks for the contribution.
I'm getting build error on zeppelin-web module
[INFO] Running "jscs:test" (jscs) task
[INFO] disallowMultipleLineBreaks: ; and it should have at most 2 line(s) between them at test/spec/controllers/notebook.js :
[INFO]    100 |    scope.killSaveTimer();
[INFO]    101 |    expect(scope.saveTimer).toEqual(null);
[INFO]    102 |  });
[INFO] -------------^
[INFO]    103 |
[INFO]    104 |
[INFO] >> 1 code style errors found!
[INFO] Warning: Task "jscs:test" failed. Use --force to continue.
[INFO]
[INFO] Aborted due to warnings.

Could you check?

@Leemoonsoo Modified
Thanks.

A test profile failure looks not related. (https://issues.apache.org/jira/browse/ZEPPELIN-1830)
LGTM and merge to master if there're no further comments.