Internal resources are not supported

System Details

FluentValidation version: 8.4

Issue Description
When implementing a custom PropertyValidator I have to specify a resource.  When using the this constructor PropertyValidator(string, Type), it fails to provide a message when the errorMessageResourceType is referring to an internal type (with internal properties). As this is the default option when using resources within Visual Studio, this is inconvenient. Can this scenario be supported?
The generated code looks like this:
//------------------------------------------------------------------------------
// <auto-generated>
//     This code was generated by a tool.
//     Runtime Version:4.0.30319.42000
//
//     Changes to this file may cause incorrect behavior and will be lost if
//     the code is regenerated.
// </auto-generated>
//------------------------------------------------------------------------------

namespace MyNamespace {
    using System;

    /// <summary>
    ///   A strongly-typed resource class, for looking up localized strings, etc.
    /// </summary>
    // This class was auto-generated by the StronglyTypedResourceBuilder
    // class via a tool like ResGen or Visual Studio.
    // To add or remove a member, edit your .ResX file then rerun ResGen
    // with the /str option, or rebuild your VS project.
    [global::System.CodeDom.Compiler.GeneratedCodeAttribute("System.Resources.Tools.StronglyTypedResourceBuilder", "<IP_ADDRESS>")]
    [global::System.Diagnostics.DebuggerNonUserCodeAttribute()]
    [global::System.Runtime.CompilerServices.CompilerGeneratedAttribute()]
    internal class MyMessages {

        private static global::System.Resources.ResourceManager resourceMan;

        private static global::System.Globalization.CultureInfo resourceCulture;

        [global::System.Diagnostics.CodeAnalysis.SuppressMessageAttribute("Microsoft.Performance", "CA1811:AvoidUncalledPrivateCode")]
        internal MyMessages () {
        }

        /// <summary>
        ///   Returns the cached ResourceManager instance used by this class.
        /// </summary>
        [global::System.ComponentModel.EditorBrowsableAttribute(global::System.ComponentModel.EditorBrowsableState.Advanced)]
        internal static global::System.Resources.ResourceManager ResourceManager {
            get {
                if (object.ReferenceEquals(resourceMan, null)) {
                    global::System.Resources.ResourceManager temp = new global::System.Resources.ResourceManager("Qowaiv.Validation.Fluent.QowaivValidationFluentMessages", typeof(QowaivValidationFluentMessages).Assembly);
                    resourceMan = temp;
                }
                return resourceMan;
            }
        }

        /// <summary>
        ///   Overrides the current thread's CurrentUICulture property for all
        ///   resource lookups using this strongly typed resource class.
        /// </summary>
        [global::System.ComponentModel.EditorBrowsableAttribute(global::System.ComponentModel.EditorBrowsableState.Advanced)]
        internal static global::System.Globalization.CultureInfo Culture {
            get {
                return resourceCulture;
            }
            set {
                resourceCulture = value;
            }
        }

        internal static string MyResourceMessage {
            get {
                return ResourceManager.GetString("MyResourceMessage ", resourceCulture);
            }
        }
    }
}

Hi, the constructor that takes a resource type and resource name is legacy and is actually going to be removed from the next version of FluentValidation.
You can instead use a lambda to access your resource class directly. This approach should work fine with internal resource classes (provided the resoruce class and the custom validator are in the same assembly):
public MyValidator : PropertyValidator(new LazyStringSource(context => MyMessages.MyResourceMessage)) {

}

Also just to point out you don't have to use resources to specify the default message, you can also use a constant string (if you don't need multiple translations), or the LanguageManager (which is how FluentValidation stores all its default messages)

I defiantly want multiple language support. If you want to drop this, consider decorate it with an [Obsolete] tag, with a helpful description. I'll try the LazyStringSource.

Yes the obsolete attribute is being added in 8.5.


Update UG

Updated the UG with listmembers and remove membership.

Codecov Report

Merging #158 (f79f41b) into master (01871cc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #158   +/-   ##
=========================================
  Coverage     67.57%   67.57%
  Complexity      705      705
=========================================
  Files           115      115
  Lines          2270     2270
  Branches        238      238
=========================================
  Hits           1534     1534
  Misses          648      648
  Partials         88       88

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Add Duration converter

I forked only to add the duration converter.
I removed the configuration from the repository and reformated the source code but it is not really important.

Thanks - I'll get back to you shortly.

The Duration converted has been cherry picked and merged to master.


Enhancement suggestion: allowing a default language other than English.

I'm using your extension to learn a new language (Vietnamese). When I encounter a word I don't know, I check its definition in English on Wiktionary thanks to your extension.
For some words, I have to scroll very far down to access the definition in Vietnamese. Is it possible to make a setting that we can have a different default language than Enlgish ? (or maybe multiple favourite languages)

Same as https://gitlab.com/losnappas/Context-menu-Wiktionary/-/issues/22

Hi, thanks for writing; I'd be happy to look into this soon, can you provide some examples as to why the autoscroll feature currently integrated is inadequate?

Yes, click on a language and it will autoscroll. Changes occur when you close and reopen the popup. Click on an autoscrolled language header again and it will unset the scroll.


Revert "Upgrade to Go1.18"

This reverts commit 85f46529ddfa7862b366a5f467656e80a431a90c.

No real progress on figuring out why Go1.18 builds use more memory, so let's revert this.

not reverting, yay


Fix occasional shutdown hangs

The index stream stage sometimes creates new active partitions after the index quit. Those don't get cleaned up and block the termination of the actor system.
:memo: Checklist

[ ] All user-facing changes have changelog entries.
[ ] The changes are reflected on docs.tenzir.com/vast, if necessary.
[ ] The PR description contains instructions for the reviewer, if necessary.

:dart: Review Instructions

Superseded by #2374.


Failover scenario

Hi everyone.
One of my main reasons for checking out Rancher 2.0 and Longhorn is it's capability of data replication / high availability.
I successfully deployed Rancher 2.0 and Longhorn (on Ubuntu 16.04 machines). On top of that I manage to properly provision services - including Longhorn volumes (with 2 replicas).
My setup consists of 3 servers:

rancher-server (Rancher 2.0 Server)
rancher-node01 (Rancher Agent including all roles)
rancher-node02 (Rancher Agent including all roles)

I expected the system to work as follows: If I kill the node with the running application pod, Rancher would relaunch this pod an the remaining node.
Unfortunately, this is not the case. It just fails and says "Deployment does not have minimum availability.".
I'm not even able to move a pod to another node (while persisting it's data within the longhorn volumes). Same error.
What steps and thoughts do I have to follow to enable the mentioned scenarios?
Thank you very much for helping.

@qdrop17 Can you make a more specific description of what you've done on try to move the volume?
For example, "Deployment does not have minimum availability." is reported for Longhorn or the service you want to deploy?
You're using deployment or statefulset or other kinds of workload?

Hello @yasker. Thanks for replying.
Well from my understanding, it should not be necessary to move to volume as longhorn started a volume container on each host.
I simply deployed a default configured elasticsearch container / pod using the Rancher 2.0 UI. With just one instance. This got deployed on a node automatically. Longhorn also provisioned the volumes properly and mounted them into the container / pod.
I then disconnected one node from the network entirely. I thought that Kubernetes will detect that and spins up the container / pod on another host (where the longhorn volume is also present obviously).
Is this scneario even working from a technical point of view or am I missing some important configuration?

@qdrop17 Can you give a look at our upcoming v0.4 document? It describes the behavior of Kubernetes and Longhorn while dealing with node failure.
https://github.com/rancher/longhorn/blob/v0.4/docs/node-failure.md

The upcoming Longhorn v0.4.0 release is able to handle node failure better, but the user would need to read https://github.com/rancher/longhorn/blob/v0.4/docs/node-failure.md to know what's to expect and what to do during node failure.
Close this issue for now. Feel free to reopen if you have more questions.


Linking to hearthstats.net under Mac OS 10.11

I've been unable to re-link my application to Hearthstats.net using my login. When pressing the "Connect" button after entering correct credentials, the following is output to HSTracker's log file while the pop-up window stays open (this is true with the current release version as well as beta 4):
[2015-10-09 16:24:28.590][network][log]: {:verb=>:post, :to=>"http://api.hearthstats.net/api/v3/users/sign_in"<EMAIL_ADDRESS>I've tried deleting the hearthstone log file and recreating, resetting HSTracker, deleting HSTracker's log files, and reinstalling the application multiple times.

I have the same issue. Pressing connect doesn't do anything besides adding those lines to log file.

Hearthstats has some issues atm (site is up, then down, ...) so, it can happen. I guess I should add some information message when it's down


Add generic filtering component

Draft PR for generic filtering component
Notes:

Implemented as a DaskTransform Component, no need to implement another transform class called filter since there aren't any needed additional functionalities

Things that still need to be figured out:

Proper way of defining the filtering_conditions. Those are currently implemented as a list of tuples. KFP only excepts standard types -> need to figure out a proper way of serializing it. We might also want to properly present it to the user in a way that's easy for them to figure out what filtering function are available
Passing custom filtering functions? is this needed or should we let the user implement their own functions

Out of the box ideas:

Do we need a separate component for this, can we have something define at the componentOp level to apply the filtering before/after loading/transforming the dataset?

component= ComponentOp(...).filter_before(<filtering_conditions>)
component= ComponentOp(...).filter_after(<filtering_conditions>)

After this is merged, we can replace all currently existing filtering components with that one.

Closing since this is outdated. Let's pick this up again in the future.


Scala S3 Sink: emit CloudWatch metric for collector_tstamp <> now() delta

This is so that we know if we are falling behind on sinking any of our shards.

I've been thinking about this and I think I have a better way of doing this, closing...


'Data not found' error after sign out

Steps:
1.Visit https://apinf.io
2.Go to sign in page
3.Enter email address
4.Enter  the password
5.Click on 'sign in ' button
6. Go to Menu and click on  'Catalogue'
7.Sign out
Expected: Successful sign out
Actual: Successful sign out with error message 'data not found'
Screenshot:

Co-pilot: @elnzv

PR - #608


Missing Vec field in a struct is not reported as an error

The following program should result in an error when deserializing the string “{}” because the bar field is missing. However, the call to visitor.missing_field returns an Ok result.
Expected output:
CHECK

Actual output:
CHECK
thread '<main>' panicked at 'called `Result::unwrap_err()` on an `Ok` value: Foo { bar: [] }', ../src/libcore/result.rs:787
Process didn't exit successfully: `target/debug/serde-test` (exit code: 101)

Program source code:
extern crate serde;
extern crate serde_json;

#[derive(Debug)]
pub struct Foo {
    pub bar: Vec<String>,
}

impl serde::Deserialize for Foo {
    fn deserialize<D>(d: &mut D) -> Result<Self, D::Error>
        where D: serde::Deserializer
    {
        enum Field {
            Bar,
        }

        impl serde::Deserialize for Field {
            fn deserialize<D>(d: &mut D) -> Result<Field, D::Error>
                where D: serde::Deserializer
            {
                struct Visitor;

                impl serde::de::Visitor for Visitor {
                    type Value = Field;

                    fn visit_str<E>(&mut self, value: &str) -> Result<Field, E>
                        where E: serde::de::Error
                    {
                        match value {
                            "bar" => Ok(Field::Bar),
                            _ => Err(E::unknown_field(value)),
                        }
                    }
                }

                d.visit(Visitor)
            }
        }

        struct Visitor;

        impl serde::de::Visitor for Visitor {
            type Value = Foo;

            fn visit_map<V>(&mut self, mut visitor: V) -> Result<Self::Value, V::Error>
                where V: serde::de::MapVisitor
            {
                let mut bar = None;
                loop {
                    match try!(visitor.visit_key()) {
                        Some(Field::Bar) => {
                            bar = Some(try!(visitor.visit_value()));
                        }
                        None => {
                            break;
                        }
                    }
                }

                try!(visitor.end());

                let bar = match bar {
                    Some(x) => x,
                    None => {
                        println!("CHECK");
                        try!(visitor.missing_field("bar"))
                    }
                };

                Ok(Foo { bar: bar })
            }
        }

        static FIELDS: &'static [&'static str] = &["bar"];
        d.visit_struct("Foo", FIELDS, Visitor)
    }
}

fn main() {
    serde_json::from_str::<Foo>("{}").unwrap_err();
}

My outstanding pull request, #26, fixes this issue as well.

As I see it, if a vector is optional, then it should be of type Option<Vec<T>>, not plain Vec<T>. But this is a matter of opinion.
What's the rationale for the existing behavior? Or perhaps the existing behavior is unplanned—i.e., it's an emergent property of using the UnitDeserializer type in the implementation of the missing_field method. (See my comment in #22 for more info.)


add a way to limit how many volumes are loaded during preprocessing

This is great for figuring out the correct preprocessing parameters.

Do you mean limit the number to be other than 80?

Yep, this is useful to figure out the required parameters to preprocess each submission. It is also useful to test new changes.


[release-1.10] Allow mc sample gws to be used with different system ns

This is an automated cherry-pick of #32389

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.10
93d5825091c285750aad6d5b39ddd2b8e1712dbd
link
/test integ-pilot-k8s-tests_istio_release-1.10

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@googlebot I consent.


Offer unified operations

If your deploy needs to support different linux distributions at the same time, e.g. CentOS and Ubuntu, you have to write 2 tasks like:
yum.packages(...)
apt.packages(...)

pyinfra should offer one operation named, for example, package, it detects distro and use correct operation like yum.packages and apt.packages to handle it. then you just need one task for different linux/bsd distributions:
package(...)

Same as the package module in Ansible: https://docs.ansible.com/ansible/2.9/modules/package_module.html
Also, please offer a service operation too to handle service start/stop/restart/enable/disable. Same as the service module in ansible: https://docs.ansible.com/ansible/2.9/modules/service_module.html

@iredmail 👋 - there's the server.service operation which handles the service aspect here!
Definitely like idea of the same for packages, server.packages perhaps!

Cool. 👍
Better mention this in document page of each “xxx.packages” module.


[GlobalStrong] Add Write Barrier For PreconditionFailed

[GlobalStrong] Add Write Barrier For PreconditionFailed
Port this bug fix to Java V4 SDK : https://msdata.visualstudio.com/CosmosDB/_git/CosmosDB/pullrequest/312583

@jeet1995  pls take a look at this when you get chance, thanks!


Multimatic does not show in HACS

I've installed HACS.
When I remove the multimatic integration via the HA GUI and try to find the integration via HACS, multimatic is not found. Am I overlooking something ?
Originally posted by @thomasgermain in https://github.com/thomasgermain/vaillant-component/issues/41#issuecomment-834519061

AH yeah, nice catch. It was originally planned to be integrated to HACS, but we decided with HACS team that it should be better to keep it as custom repo, see, https://hacs.xyz/docs/faq/custom_repositories/ for installation details.
I'll keep the issue open until I did the update on the readme

Is showing now. case closed.


Add Google Magritte to awesome-medipapipe

This is a new framework for face blurring developed by Google.
I didn't find a good category for this link as Magritte is not dedicated to one platform only. Please let me know if there is a better category or location in the document to add this project. Thank you!
Disclaimer: I work on the Magritte team.

Friendly ping, can we please merge this? Thank you!

@stoman
I posted your concern to https://groups.google.com/g/mediapipe


add colorize spreader

https://github.com/ddddddO/gtree/issues/6

Codecov Report

Merging #53 (adb6534) into master (8db37f9) will decrease coverage by 0.52%.
The diff coverage is 82.85%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   91.85%   91.33%   -0.53%
==========================================
  Files          12       12
  Lines         442      473      +31
==========================================
+ Hits          406      432      +26
- Misses         19       21       +2
- Partials       17       20       +3

Impacted Files
Coverage Δ

tree_spread.go
86.13% <82.35%> (-1.01%)
:arrow_down:

tree.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8db37f9...adb6534. Read the comment docs.


Weight conversion for tensorflow 2 is not yet implemented.

I'm trying to  export a TensorFlow 2 model into deepImageJ format but it gives errors as the function seems to not be implemented for it:
from bioimageio.core.weight_converter.keras import convert_weights_to_tensorflow_saved_model_bundle

WARNING:tensorflow:Compiled the loaded model, but the compiled metrics have yet to be built. `model.compile_metrics` will be empty until you train or evaluate the model.
1/1 [==============================] - 0s 153ms/step
---------------------------------------------------------------------------
NotImplementedError                       Traceback (most recent call last)
[<ipython-input-22-95f300b64ebb>](https://localhost:8080/#) in <module>
    197 if os.path.exists(tf_weight_path):
    198   rmtree(tf_weight_path)
--> 199 convert_weights_to_tensorflow_saved_model_bundle(output_path, tf_weight_path + ".zip")
    200 add_weights(output_path, tf_weight_path + ".zip", output_path, tensorflow_version=tf.__version__)
    201

[/usr/local/lib/python3.7/dist-packages/bioimageio/core/weight_converter/keras/tensorflow.py](https://localhost:8080/#) in convert_weights_to_tensorflow_saved_model_bundle(model_spec, output_path)
    105         return _convert_tf1(weight_path, str(path_), model.inputs[0].name, model.outputs[0].name, zip_weights)
    106     else:
--> 107         raise NotImplementedError("Weight conversion for tensorflow 2 is not yet implemented.")

NotImplementedError: Weight conversion for tensorflow 2 is not yet implemented.

An example of the notebook to reproduce this error can be checked here: https://github.com/HenriquesLab/ZeroCostDL4Mic/pull/219
The notebook can also be used with binary images but just in case, data from here can also be used.
@constantinpape

Also, if you want to play around with an example, here is a model already uploaded to the bmz: https://bioimage.io/#/?id=10.5281%2Fzenodo.7261974

@esgomezm It's implemented now. We will draft a new release soon so that it can be used in zero-cost etc.

great! just let me know when it is so the validator passes and I can also update the notebook! Thank you!

@esgomezm bioimageio.core v0.5.7 is available on conda and pip now and adds support for tensorflow 2.


Floating bottom-right pixel width display?

For whatever reason, there's a floating display in the bottom-right of my pages that shows the current width of the window in pixels (see below for an example). Haven't been able to track it down; any clues as to where this might be living so I can remove it?

@austinj This shows the current CSS Breakpoints. It only appears when running the dev server, not after hugo build.
If you wish to remove it completely you will find it in style.scss at the bottom.

Great, thank you!


/zappa/src/../vendor/jquery-1.6.4.min.js missing

Maybe I'm not using this repository right, but every script i try to run in this framework error's on missing jquery inside some nonexistent vendor folder: /zappa/src/../vendor/jquery-1.6.4.min.js

Try running cake vendor and cake build. @mauricemach adds this stuff manually to the npm builds.

You rock!


[fix] Benchmark gitlab import error

What does this PR do?
This will fix this error due to the merge of this PR.
This fix is temporary while we find a way to solve these imports properly.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Use sidecar to routing pod logs to Pulsar topics

Options:

reuse the logTopic config, and add one more config logTopicAgent with possible options: runtime and sidecar. For runtime, the logTopic will keep the same behaviour to use the Pulsar Functions' log topic appender. For sidecar, will use filebeat to redirect the log into log topic.
add new config filebeat: {} to RuntimeLogConfig https://github.com/streamnative/function-mesh/blob/477841c2037c1dbd7612c4dfa06122e26524d1a8/api/compute/v1alpha1/common.go#L490-L494 and allow user to customize the filebeat configs individually.

For the first option, the sinks&sources doesn't have a logTopic argument, seems we can only use option 2?


HTTPS is not working (CORS)

As the configuration for "Using RTSP to WebRTC" says:
"httpsPort": 8001, // port for local https server
Visiting https://:8001/client/webrtc.html is not working due to CORS:
Browser console:
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://<host>:8002/stream/codec/reowhite. (Reason: CORS request did not succeed). Status code: (null).

i've just tried with chrome 110, 111 and 112, no issues.
what is your browser?
also, cors error may be false here, post the console log as well.

you cannot just replace http with https, that's pointless.
but you can access the original page over http://<host>:8000/client/webrtc.html
but unsupported NAL type 6 is a no-go.
That method is fastest and has least requirements, but that is because there is no actual video re-encoding, it only un-wraps the headers and re-wraps them for consumption in browser. In your case, actual stream seems to be a sub-variant of H.264 format which is not supported by your browser.
check if your camera has an alternative url for serving clean h264 video stream and use that in config.json url setting.
if not, you may need to go down the reencoding route (see other methods i've listed in README).

you cannot just replace http with https, that's pointless.
but you can access the original page over http://:8000/client/webrtc.html
It was just to remove the mixed content problem. Yes, the http page on port 8000 works.

but unsupported NAL type 6 is a no-go.
Is this the cause of ERR_SSL_PROTOCOL_ERROR?

you may need to go down the reencoding route (see other methods i've listed in README).
Yes I already succesfully use the HLS method, I just wanted to try Webrtc.

not at all, this is actual media stream format coming from the video camera - its in a format that browser cannot understand without reencoding.

Got it, but why the browser is able to show it in a unencrypted connection anyway?
Thanks, this is mostly informative to me now.
The camera doesn't have an alternative url, so I have no other choice to stay with HLS.
I will also keep the CORS in title as the browser message can mislead other users.

lets separate 3 unrelated things:

cannot mix http and https. this is enforced by most modern browsers due to security concerns. and since you cannot just upgrade http to https, you cannot run both via https. but you can downgrade https to http, so both run as http.
cors issue. again, enforced by brain-dead browser and it should NOT be enforced for localhosts. but if you want to enable CORS headers on server, feel free to do so, i've pointed out the line in the code where to do it.
unsupported NAL type 6. that means that media stream received from camera cannot be fully understood. perhaps it plays ok, perhaps it doesn't play at all - but something is missing from the stream as it cannot be understood. if its in some extended frame info that nobody cares about, then its ignorable. if its in codec itself, then its a no-go. i cant tell where it is since i'm not decoding the stream, i'm only re-encapsulating it (thats why its so much faster as reencoding would take 20x more cpu).


Unpacking Error Encountered While Running the Model

Hello, I encountered some issues while trying to run your model with the use case '2p16'.
Here is the detailed error message:
Traceback (most recent call last):
File "generate_new.py", line 305, in
aar, rmsd, attend_logits = model.generate(batch, dir_name)
File "/home/dell/download/pocketgen/models/PD.py", line 354, in generate
res_H, res_X, pred_ligand, ligand_feat, pred_res_type, attend_logits = self.encoder(res_H, res_X, res_S, res_batch, pred_ligand, ligand_feat, batch['ligand_mask'], batch['edit_residue_num'], residue_mask)
ValueError: not enough values to unpack (expected 6, got 5)
It seems that the return values from the function call are not as expected. Can you provide guidance on how to resolve this issue?
Thank you for your assistance!

Thanks for your feedback! It seems to be an error caused by the inconsistency of different versions of PocketGen. We have updated the code and now it should work well for the generation. Thanks!

Thanks for your feedback! It seems to be an error caused by the inconsistency of different versions of PocketGen. We have updated the code and now it should work well for the generation. Thanks!

Thanks for your help, I successfully run the code!

Great! Thanks!


Issue #66: team-01 - Simulated Midnight Sun using getting_started notebook file

Pull request type
Please check the type of change your PR introduces:

[ ] Code base additions (bugfix, features)
[ ] Code maintenance (refactoring, formatting, renaming, tests)
[ ] ReadMe, Docs and GitHub maintenance
[ ] Other (please describe):

Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:

ReadMe, Docs and GitHub maintenance:

[ ] Spelling has been verified
[ ] Code docs are working correctly

Code base maintenance (refactoring, formatting, renaming):

[ ] Docs have been reviewed and added / updated if needed
[ ] Lint (black rocketpy) has passed locally and any fixes were made
[ ] All tests (pytest --runslow) have passed locally

Code base additions (for bug fixes / features):

[ ] Tests for the changes have been added
[ ] Docs have been reviewed and added / updated if needed
[ ] Lint (black rocketpy) has passed locally and any fixes were made
[ ] All tests (pytest --runslow) have passed locally

What is the current behavior?

Enter text here...
What is the new behavior?

Enter text here...
Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

Enter text here...

Good implementation, with more then requested by the challenge itself. Thank you @aasitvora99 for your first contribution, we are adding extra 20% for this pull requested :)


Posts discovery: Allow finding posts in subdirectories of _posts folder

Is your feature request related to a problem? Please describe.

When writing blog posts, I find it useful to arrange posts file (*.md) in appropriate subfolders. This helps in keeping posts and associated files together for easy maintenance.
E.g: If I am writing a post about python and I have a few python files which I would like to include as code snippets via liquid syntax, I find it maintainable to keep all such python posts and files in subdirectories as _posts/python/.
If we do this currently; pages, categories and tags of _posts folder are populated but not from subfolders.
Describe the solution you'd like

Pages, categories and tags of _posts folder and any subdirectories are populated.
Describe alternatives you've considered

We can run the build python scripts (init/run/build, etc) per directory as explicit input, but doing this for multiple such directories becomes problematic.
Possible solution

In file update_posts_lastmod.py, line 130

<<< path = os.path.join(POSTS_PATH, "*.md")
>>> path = os.path.join(POSTS_PATH, "**", "*.md")

In file pages_generator.py, line 67 and 132.

<<<         for file in glob.glob(os.path.join(path, '*.md')):
>>>         for file in glob.glob(os.path.join(path, '**', '*.md')):

I have tried and tested the solution at my personal site at github repo

Um... put posts together and sort by date is enough; the blogger don't need to spend time creating subfolders.

@ppipada where exactly did you make this change? It looks like you are referencing a Python file, but there is no Python in this project.
How can I modify an existing site?

@cotes2020 I'd like to support subfolders so that I can have a folder per blog post/article. If one post is made of up an /project1/<date>_<title>.md then in that /project1/ folder I might have related images, screenshots, logs, etc.
Without folder support, the one _posts folder becomes a junk drawer of many, many files and it's impossible to tell which post screenshot2.png is related to.
Please re-consider taking this on as a feature request!!

@r0bsec this was in 2020. Version 2.x.
Not sure how this is handled today. I have moved to Hugo for my blog, so no current context.


Get a useful stack when exceptions are thrown

Specification
The decorators currently take error objects instead of error classes.
This causes the stack trace to be set to when the error object is constructed. These stack traces are not useful for debugging.
We should replace the stack property with a stack that would be created when something goes wrong.
To do this, everywhere we are doing throw ...; we should replace it with:
errorDestroyed.stack = new Error().stack ?? '';
throw errorDestroyed;

We can wrap this with a utility function.
Additional context

Tasks

create utility function for updating the stack information in the error.
Update all @ready, @startStop, ect decorators to provide the useful stack information when throwing the error.
add test to check if the updated stack information is provided.

I've made a utility function called updateErrorStack that updates the stack for the error and updated each decorator to use this just before throwing the errors. I've confirmed manually that we're getting a useful stack from the Error now. I don't see the need to expand or add tests for this.
Should I make a PR for this or just push it to master?

I'm thinking you can skip having a separate function, and instead just inline those 2 lines. Because that way you don't end up with an additional useless stack from the utility function.
LOC will be the same anyway.


MINOR: Enable multi-statement benchmark queries

Which issue does this PR close?

N/A
Rationale for this change

q15.sql contains two SQL statements and this was not supported by the benchmark runner
What changes are included in this PR?

Support multiple queries per file
Are there any user-facing changes?

No

When running Q15 do we get a new error now? Something like CREATE VIEW isnt implemented?

If we get this merged first i can enable Q15 in #2279

When running Q15 do we get a new error now? Something like CREATE VIEW isnt implemented?

Yes, exactly that!

LGTM.
An off-topic question: I've noticed there were instructions on how to get golden files and get results verified but removed before. Do you think it's the time to add goldens and enable verify_query here for tpc-h?
Currently, these tests are skipped TPCH_DATA environment variable not set, skipping test

The current approach is for developers to use the tpch toolkit to generate the expected answers locally and then set this env var to enable those tests. It would be nice if we could enable CI to do this as well.


Bad recovery on out-of-order external modifier

CFE has bad recovery for out-of-order external modifier. For
int external f1();

class Class {
  int external f2();
}

we report
temp/external2.dart:3:5: Error: Expected ';' after this.
int external f1();
    ^^^^^^^^
temp/external2.dart:3:18: Error: Expected a function body or '=>'.
Try adding {}.
int external f1();
                 ^
temp/external2.dart:6:7: Error: Expected ';' after this.
  int external f2();
      ^^^^^^^^
temp/external2.dart:5:7: Error: The non-abstract class 'Class' is missing implementations for these members:
 - Class.f2
Try to either
 - provide an implementation,
 - inherit an implementation from a superclass or mixin,
 - mark the class as abstract, or
 - provide a 'noSuchMethod' implementation.

class Class {
      ^^^^^
temp/external2.dart:6:16: Context: 'Class.f2' is defined here.
  int external f2();
               ^^

and even worse in a null safe library:
temp/external2.dart:3:5: Error: Expected ';' after this.
int external f1();
    ^^^^^^^^
temp/external2.dart:3:18: Error: Expected a function body or '=>'.
Try adding {}.
int external f1();
                 ^
temp/external2.dart:6:7: Error: Expected ';' after this.
  int external f2();
      ^^^^^^^^
temp/external2.dart:5:7: Error: The non-abstract class 'Class' is missing implementations for these members:
 - Class.f2
Try to either
 - provide an implementation,
 - inherit an implementation from a superclass or mixin,
 - mark the class as abstract, or
 - provide a 'noSuchMethod' implementation.

class Class {
      ^^^^^
temp/external2.dart:6:16: Context: 'Class.f2' is defined here.
  int external f2();
               ^^
temp/external2.dart:3:5: Error: Field 'external' should be initialized because its type 'int' doesn't allow null.
int external f1();
    ^^^^^^^^
temp/external2.dart:6:7: Error: Field 'external' should be initialized because its type 'int' doesn't allow null.
  int external f2();
      ^^^^^^^^

It is just the external modifier, or does this apply to other keywords? For example
class C {
  int final x = 0;
}

Seems to be all of them. final has the same pattern.

I wonder whether the parser is using ModifierRecoveryContext in these cases. It ought to be, but it's possible that it isn't.
It's also possible that the parser needs to be parsing additional modifiers after the type name (reporting them as being in the wrong place) and isn't.

Might be relevant that external is a built-in identifier, so int external; is actually valid. The message of "expecting ; here" isn't entirely wrong, and the remaining messages are consistent with recovery inserting that ; and then choking on f1();.
It's probably a good guess that external was meant as a modifier, though.


Add functions for round trip decoding of transaction payloads

We provide functions for serializing transactions in legacy-original, legacy-EIP155, and EIP-1559 flavors.
However, we don't currently provide the "recover" step - decoding the binary transaction (from eth_sendRawTransaction) according to the various applicable rules, and letting you recover the signature from it.
This PR adds that feature.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.67%. Comparing base (39fe567) to head (f5a3398).

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #64      +/-   ##
===========================================
- Coverage   100.00%   99.67%   -0.33%
===========================================
  Files           38       38
  Lines         3317     3423     +106
===========================================
+ Hits          3317     3412      +95
- Misses           0       11      +11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


PR: Add pytest-xvfb to our test dependencies

@ghisvail, this is what you wanted :-)

Absolutely. That would be a great step towards enabling CI within Debian. Thanks for implementing this.


Please provide the sample source code link that explained in the article for developers reference.

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: eef47457-c8cf-74a4-b884-c1fe5c2ef52d
Version Independent ID: 09a02d10-2834-467d-d8c2-3fd19ceb3863
Content: ASP.NET Core Blazor forms and validation
Content Source: aspnetcore/blazor/forms-validation.md
Product: aspnet-core
Technology: aspnetcore-blazor
GitHub Login: @guardrex
Microsoft Alias: riande

Hello @gnnsekhar ... Indeed! I made a small mistake closing a duplicate request. My remarks are at ...
https://github.com/dotnet/AspNetCore.Docs/issues/26376#issuecomment-1179705652
I put in some updates but marked the PR as "fixes," while it should've been "addresses." Therefore, we'll use your issue here to do the work on this. Thanks for opening this issue.
Note the remarks in the dotnet/blazor-samples README and published in the docs at ...
https://docs.microsoft.com/aspnet/core/blazor/fundamentals/#sample-apps
The snippet sample apps that provide code samples for the docs are only for obtaining code. They'll compile (maybe! 😄, probably with at least warnings) but never be runnable apps due to the reasons that I call out in the README. However, they are good for grabbing code and grabbing components and dropping them into a local, runnable test app.
I'll see about placing a cross-link to that repo in all of the Blazor docs to resolve this issue ASAP ... not sure exactly when given that I'm ⛰⛏😅 most of the time, but I think I can knock this one out today or tomorrow (Thursday).
Thanks again for the request!

I think I'll piggyback one more thing on this issue. I've already moved the 6.0 sample apps to the dotnet/blazor-samples repo. I'd like to do that for the 3.1 and 5.0 samples, too.


incorrect copy of README.md uploaded

This is a minor issue (in Release 1.8.0)...
I noticed (when running on Windows) that if I have two copies of a readme file, e.g.
README - OLD.md
README.md

then the 'OLD' copy is uploaded. My intention was to retain some text until a problem is fixed and README.md is the modified version (valid until the bug is fixed).
The workaround is easy ... move README - OLD.md to another folder.
Compliments on your program - it is very useful!

thanks, I'll have a look.

Should be fixed now in v1.8.1. Thanks again for reporting this!
For reference, the auto search order when no specific file is stated with --file:

README-containers.md (case sensitive)
README.md (case sensitive)
fuzzy fallback to the first match of a file with prefix README (case insensitive) - no guarantees on order here if multiple matching files are present


Add injection for ServiceAccount and RoleBinding

Needed for eventing.

/assign @mattmoor

/test pull-knative-pkg-build-tests

needed for https://github.com/knative/eventing/pull/1374

/lgtm


Note: Unsure if people helpers are not loading correctly or if local database

Will need to test.

Also work section: believed to be missing data.


Make it clear that installing pino-pretty is required when using prettyPrint option

Related to https://github.com/iamolegga/nestjs-pino/issues/330

Related to https://github.com/iamolegga/nestjs-pino/issues/330


Remove standalone access to Ember UI

Internal reference: SURE-8327
With most functionality moved away from the older Ember UI (Cluster Manager accessible via /g in the URL) and into the newer Vue UI (Cluster Explorer), the old UI has had less use. It's been updated less and with many API changes, it has become brittle and broken in areas. Some folks do use it as a backup for performance issues but it's not being updated and it's falling apart.
We'll keep the sections that are embedded into Vue but the point of this ticket is to remove standalone access to the Ember UI.

See: https://github.com/rancher/ui/pull/5174

@rancher/docs heads up that we'll need to mention in the release notes that in 2.10.0, the old UI (Cluster Manager) will not be directly accessible. The appropriate pages that still rely on that UI will continue to be embedded in the new UI (Cluster Explorer).

Validated on Rancher: v2.10-5d66d49d7a72b4c439a33043007e9bb0223c8693-head
UI: master cf8c6d1
/g redirects to a fail page.


https://github.com/AvaloniaUI/Avalonia/wiki/Projects-that-are-using-Avalonia is broken with missing images ?

Found in the web browser :

mmm try to check your internet connection or the browser, it shows to me

@PieroCastillo  which browser are you using ?

Now I use the latest stable version of Microsoft Edge Chromium, I never have problems with the github web page

Problem appeared this week

so strange, try deleting the cache memory on temp directory

This answer should help you https://github.community/t/refused-to-load-the-font-url-because-it-violates-the-following-content-security-policy-directive/1613/14
It can also be cookies or some extensions

interesting, I see the same behavior for Chrome, Edge and not IE.
there was a VPN update change last week so potentially it could be that.
@rstm-sf  the image is loading perfectly, but I can see the CSP header in the request which force to not load the  image :

I'm surprised that my company computer is doing that kind of trick


Advantage of separate classifier layer for distillation?

I noticed there are two linear layers in the classifier, one which goes to the regular loss and one which is used in distillation loss. What is the advantage of having two separate layers and averaging the outputs during inference? Why not use only one layer for both losses?

Thanks, we follow LeViT (No classification token. in the Model section) to use separate linear layers for the regular loss and distillation loss, respectively. We didn't conduct ablation studies between only one layer and two separate layers, so we are unsure whether using two layers has the advantage. Experiments are expected to investigate this.

thank you


Maybe it's a bug about types

Vue version
3.2.37
Link to minimal reproduction
https://codesandbox.io/s/serene-maxwell-cgck12?file=/src/Demo.vue
Steps to reproduce
https://github.com/TuSimple/naive-ui/blob/049431b22d7af1e956a88028e8d9ad79ec31e4f9/src/drawer/src/Drawer.tsx#L52
zhCN: 我在写一个组件的 props 时，希望获得的参数是 Boolean 和 'transparent' 字符串，上面的链接是我的类型定义，Link to minimal reproduction 中的链接是我在使用这个 props 时控制台的报错，我想知道这是我使用的问题吗？如果是，我该如何定义这种类型？
enUS: When I write props for a component, the parameters I want to get are Boolean and 'transparent' strings. The above link is my type definition. The link in Link to minimal reproduction  is an error on the console when I use props. Do I want to know if this is the problem I use? If so, how do I define this type?
What is expected?
No warn.
What is actually happening?
Have warn in console.
System Info
No response
Any additional comments?
No response

No, it's not. Hint: have a closer look at DrawerBodyWrapper.tsx' props


Install codeception as a dev dependency

This is just update to documentation to guide users to install codeception as a dev dependency.

Good one. Thanks!


BetterRTP loads lots of chunks

Plugin Version: 3.6.2
Describe The Bug:
BetterRTP won't stop loading new chunks if no safe location is found.
How To Reproduce:

Start a new Spigot 1.19.3 server with BetterRTP. Set level-type=minecraft\:flat in server.properties.
BetterRTP loads many new chunks. Since queue is enabled by default but MinY is 0, it can't find any safe location in this superflat world. Around 100MB disk space is occupied by the world after 10 minutes.
Set MaxRadius: 50000 in config.yml of BetterRTP and restart server. Around 1GB disk space is gone in another 10 minutes.

Expected Behavior:
BetterRTP may automatically add worlds that don't seem to have safe places to DisableWorlds , or somehow prevent it from meaningless queueing. A configuration item of maximum tries before auto disable can be added too.
Screenshots/Error Log:
No errors in log.
Additional Context:
This server is running CraftBukkit version 3669-Spigot-454acb7-f150cfb (MC: 1.19.3) (Implementing API version 1.19.3-R0.1-SNAPSHOT)

I had the same problem as you !
I searched for 2 days which plugin causes this problem !

I had the same problem as you!

I am developing a random teleport plugin that will solve this problem and will be released soon

I'm sorry to hear that this issue is closed as invalid without any explanation. I tried the most recent BetterRTP version 3.6.8-2 but the problem persists. Logs are available at https://pastebin.com/7wJB3JG8 . ChunkLogger is a simple piece of code that listens to ChunkLoadEvent and prints a line to console when event.isNewChunk()==true . Please let me know if you need more information about this.


acorn run fails, complaining about DNS not resolving for beta.acorn.io

The "acorn run" command is failing for me today:
$ acorn run -n my-todo .
  ✗  ERROR:  Get "https://beta.acorn.io/apis/manager.acorn.io/v1/accounts/<my-uid>": dial tcp: lookup beta.acorn.io on <IP_ADDRESS>:53: no such host

I was told that you guys have retired the beta.acorn.io, but I seem to have a local config file that points me in that direction:
$ cat config.yaml
acornConfig: /Users/<my-uid>/Library/Application Support/acorn/config.yaml
acornServers:
- beta.acorn.io
- acorn.io
auths:
  acorn.io:
    auth: xxx-yyy-xxx-yyy
  beta.acorn.io:
    auth: xxx-ooo-xxx-zzz
currentProject: beta.acorn.io/<my-uid>/acorn
defaultContext: beta.acorn.io/<my-uid>

This file seems to be created or modified only last week:
$ ls -ctl
total 8
-rw-r-xr-x  1 <my-uid>  staff  436 Oct 25 23:47 config.yaml

I am running the latest version:
$ brew upgrade acorn-io/cli/acorn
Warning: acorn-io/cli/acorn 0.9.1 already installed

Please advise the best way for me to get acorn running again. Thank you...

@stevel032 Can you try the following in your terminal:

acorn logout beta.acorn.io
acorn logout acorn.io
acorn login and following the prompts, if necessary, to reconnect your CLI.

Thank you, these instructions are very helpful, I'm up an running again!


Monitor OCP releases and trigger relevant jobs based on z-stream version - 2

[Auto generated]
Number: [#2]

ci-jobs-trigger(3JtfF)[PR 2]: Closing issue for PR:  Monitor OCP releases and trigger relevant jobs based on z-stream version.
PR was closed.


More progress on uncurry level removal

Almost gone!

@swift-ci Please smoke test

@gottesmm You might want to take a quick look at this one. Just mechanical changes, no effect on generated SIL.


Feature/holo 1480 ownership s1

Describe Changes
I changed the ownership management in the HolographERC721 and the CountdownERC721.

Give ownership to the source contract in the init of the HolographERC721 enforcer
Call setOwner in the init of the source contract to set the owner to the one defined in the init payload
Override the function (and modifiers) that get the owner in the source contract to make them call the owner() or getOwner function of the enforcer contract

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] Code styles have been enforced
[ ] All Hardhat tests are passing
[ ] All Foundry tests are passing

All tests are passing now 🎉


refactor #13. deleted failed test and added new test case to catch th…

ref #13 test cases for method list in class CachingDirectoryLister

newTest_TestLog.txt
I get 3 tests failing now that aren't supposed to: the new test in this pull request; the new test that failed previously (there were 2 failing tests, not 1); and something more.


feat: no need to log in to view memos

showing memos without logging in can let us use it like a personal Twitter.

I think it's better to create a new page to show someone's public memos. Just like https://jike.city/xidong, wdyt?

My idea is to make it like Github, others can see what's public by default, and at the same time, we can hide some memos.

But the current main page UI isn't good for visitor because of the editor and some action buttons. A new pure page to display public memos and some extra information might be better for viewer.

But the current main page UI isn't good for visitor because of the editor and some action buttons. A new pure page to display public memos and some extra information might be better for viewer.

After taking a deep look, I think it's good for viewing when hiding some extra elements.

LGTM. Another question: how do we view other member's memos?

This is also a more troublesome issue that I have considered. At present, I let it display the owner's memos by default.

I think most people will choose to build their own memos.
Allowing multiple users to be created doesn't seem very useful.

ok, I'll try to handle each user's homepage

@boojack maybe you can review the code when you are free

@boojack maybe we need an eslint config for imports sort, or eslint-plugin-import

This is my first contribution to a little feat, I have learned a lot, thank you


Issue: Showcase images on website are broken

The Ublue site for Bazzite has broken images for the showcase portion of the page:

Oh shoot!  I'll try to fix that. Thanks!


Add MOM6 example

Adds cookbook for MOM6 GCM example
closes #4

I believe this PR will be dependent on #2 before merging as #2 will add necessary items to the repo. If it seems like we can merge before that, then that is fine by me as well!

@michaelavs Will you ping me when #2 is ready and you'd like a review?


Translate home

@Zitle-Nancy you need to keep the english headings on IDs:
e.g.
## Eventos Soportados {#supported-events}

@carburo why did you delete reference-events? Did you mean to just unstage the changes?

Yeah, @tesseralis I meant to fix it right away, but then I had troubles with my internet connection.

Hi!, Thanks for helping me.
I want to know if I can help in any other part of the project, I think it could be in the translate of navbar and footer, If you need my help with these, just tell me.
Cheerse!

Yes, @Zitle-Nancy, all help is needed. I'll assign you in #4.

Cool @carburo , I'll do it!


Create an example on how to use typedoc within a Monorepo (lerna)

Search Terms
lerna, monorepo, example
Problem
I'm currently trying to create a documentation for my Monorepo that is built with lerna. Unfortunately, package relationships don't get resolved as you would expected. Additionally, the typedoc-plugin-lerna-packages plugin does not seem to work anymore.
Suggested Solution
Add an example on how to handle a situation like this. Maybe there are already options that I'm just not aware of.

I'm definitely open to adding a page to the website that describes how this works and linking to an example project that uses this. I don't have any experience with Lerna though, so help creating a simple repo that I can experiment with to figure out the best way to use would be greatly appreciated

This might even be better framed as support for Yarn "workspaces" (https://classic.yarnpkg.com/en/docs/workspaces/). It defines a package.json extension (workspaces) for Lerna and other monorepo tooling to share the source of truth for the monorepo structure.

This will be super useful! 🎉

I was playing around with implementing this today and found that the approach of crawling a package JSON tree is quite different to the support that typedoc currently has for following the tsconfig project references. Mainly the package jsons have no strict connection to things like the tsconfig and the source files that act as the TS entry points. I believe this is surmountable if we actually use the main property from the package jsons and require the js to have sourcemaps. The main property gives us the JS entry point, and the sourcemap can translate that to a TS entry point. We're still quite reliant on defaults/inference for finding tsconfigs however.
If I get this working, perhaps within a couple of weeks, I'll post a PR. Let me know if anyone has thoughts on this approach.

Hello folks, I got a mono repo I am looking to document and thinking if this extension might help? https://www.npmjs.com/package/typedoc-plugin-monorepo I am trying this now, will probably make an example/page if it works.

@vipulgupta2048 let me know how that goes for you.
You may also be interested in trying my fork of typedoc that's currently feeding this PR: https://github.com/TypeStrong/typedoc/pull/1567
I'd be curious to know if it works for you. I'm not sure it supports the per-package readme's that the monorepo plugin supports.

I think the instructions in the readme meet this now - 0.21.0 has --packages from #1567.
https://github.com/TypeStrong/typedoc#monorepos--workspaces


link to Block

Was displaying the link instead of linking the display.

Thanks a lot!
@moritz maybe it would be possible for you to give @dbrunton access to the repos so they could submit commits directly? I've seen a couple of decent-quality PRs fly in.


Unable to edit css on the chrome console

Is your feature request related to a problem? Please describe.
Due to the updateStyle method，I couldn't edit my stylesheet on my chrome console

Describe the solution you'd like
Allow me to edit my stylesheet

See https://github.com/vitejs/vite/issues/585#issuecomment-661533546


[Bugfix] update Gitlab members only if they exist

Checklist

[x] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[x] Server: I followed the coding and design guidelines.
[x] Server: I added multiple integration tests (Spring) related to the features (with a high test coverage)
[x] Server: I documented the Java code using JavaDoc style.

Motivation and Context

This PR should fix #2772.
Gitlab returns an error status code when attempting to add a member to a repository that already exists. Therefore, exceptions occur when calling addMemberToRepository in GitlabService for existing members. This happens e.g when attempting to lock/unlock repositories for a programming exercise.
Description

We add a new check in addMemberToRepository: We check if the member already exists in the repository. If it does, we simply update its permissions. If it doesn't, we add it to the repository.
Steps for Testing

Log in to Artemis
Navigate to Course Administration, create a programming exercise, and participate in it by creating a submissions
Navigate to Course Administration -> Edit Exercise
Press Lock All Repositories button
Navigate to the Gitlab repository and click on "Members"
Check that the student that submitted the code has "Guest" access level
Press Lock All Repositories again and double check that the access level stays as "Guest"
Press Unlock All Repositories
The member should now have access level "Developer"
Press Unlock All Repositories again and double check that the access level stays the same

Test Coverage

For me the unlocking did not work as expected, still had guest access only on GitLab. I received this Artemis notification:

This error happens when the user doesn't exist in Gitlab and/or the repository doesn't exist. Did you make sure that both exist?


fix: adds size control for skeleton placeholder

Addresses #1607
The current bx--skeleton__placeholder class has a fixed 6.5rem width and height. This PR changes ibm-skeleton-placholder to render as a block element, and sets the bx--skeleton__placeholder element inside of it to fill the width/height of its container.
Using these changes, we can freely manipulate the size of the skeleton placeholder to fit any need.
Changelog
Changed

skeleton-placeholder.component.ts
skeleton.stories.ts

Screenshot

@cal-smith it appears that the React library approaches this by allowing the developer to apply their own classes against the placeholder: https://github.com/carbon-design-system/carbon/blob/master/packages/react/src/components/SkeletonPlaceholder/SkeletonPlaceholder.js
I'm trying to identify the use-case of the fixed-size placeholder in the link provided. Any insight?

@cal-smith it appears that the React library approaches this by allowing the developer to apply their own classes against the placeholder: https://github.com/carbon-design-system/carbon/blob/master/packages/react/src/components/SkeletonPlaceholder/SkeletonPlaceholder.js

Ah interesting! It may be best if we take that approach ... That keeps our default behaviour for now, and allows users to override as needed

I'm trying to identify the use-case of the fixed-size placeholder in the link provided. Any insight?

I'm not sure 😀 It's definitely a bit of a odd design decision.

Hey @jdoyle65 👋 this has been stagnant for a while, still totally down to take a generic placeholder component if you have time to work on this some more ... Otherwise we can close this out for now and pick it back up later 👍


Type system

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Not ready yet but take a look for the new approach in Type. TypedObject might need to be cleaned up or extended to work with the new Type approach.

Coverage decreased (-59.7%) to 40.263% when pulling 03822ad331c23ba0b4ef7c8af96545d20e89c676 on type-system into d99b5b775bd46dee3c7c8727337885456f15dbde on master.

Now ready for review


Failed to open in browser - Error: Exited with code 1

When using ctrl+shift+Q or right-clicking and selecting Open in Browser , atom reports the following error.
Error: Exited with code 1
    at ChildProcess.<anonymous> (C:\Users\name\.atom\packages\open-in-browser\node_modules\opn\index.js:83:13)
    at Object.onceWrapper (events.js:293:19)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:194:7)
    at maybeClose (internal/child_process.js:899:16)
    at Socket.<anonymous> (internal/child_process.js:342:11)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:191:7)
    at Pipe._handle.close [as _onclose] (net.js:510:12)

Have checked that the file opens in my default browser - Chrome.
Also tried closing and reopening atom.
Also tried disabling all other community packages and restarting atom.
Windows 10
atom 1.25.0 x64
open-in-browser 0.5.2
Chrome Version 65.0.3325.181 (Official Build) (64-bit)

Hi clayms
I am having the same problem, could you fix it?

Not using Atom anymore, switched to VS Code.


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-k8s-30-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4368

Questions ?
Please refer to the Backport tool documentation


Gnomad tests 2

Temporary PR to get comments for future full gnomAD v4 rows extraction
I intend to run it only if the test run is successful

PR is now ready for merge to run cost analysis


Updated angular-mocks dependency to fix unit test failures

Description
Fixes #889.
Code sample
$ rm -rf node_modules
$ npm install
$ grunt install
$ grunt test:unit

This one will take a few weeks : (

LGTM ☃


Gazebo monocular camera + lidar projection misalignment

There seems to be a misalignment when viewing/projecting the lidar pointcloud on the simulated RGB camera. The error seems to be happening in at least yaw and pitch. When using the "camera" plugin in rviz, the misalignment is clear.
I'm not sure if this is a bug in the implementation of the plugins or in gazebo itself. This misalignment occurs both when using the built-in camera rViz display and when projecting the points manually. I am using the classic version of vrx, but I bet this occurs in vrx 2.0 as well.
To Reproduce

Launch the vrx simulation with a vrx equipped with cam and lidar
Start the robot state publisher and rviz
Place an object in front of the camera and lidar
Activate the "camera" rviz display/plugin to view the projection and misalignment

I've searched for solutions as this feels like a general problem and not necessarily a vrx problem, but i haven't found any solutions. The distortion coefficients are set to 0 (by default) so that shouldn't be causing this problem. I've attached a video which showcases the fault.
https://github.com/osrf/vrx/assets/94528774/df0a0b0c-0538-4e52-b7c1-6f325061bf8f
https://github.com/osrf/vrx/assets/94528774/bb337f00-a241-43e8-80cf-9cf5122b3dd9

This issue is not occurring anymore, but i have no idea why. It's possible that the joint state publisher in the rviz_vrx launch file was causing redundant, incorrect transforms, but i have not confirmed this. closing issue,


moveit2 planGraspsAndPick function

Is your feature request related to a problem? Please describe.
I am an beginner of moveit2, I found that planGraspsAndPick function of MoveGroupInterface is commented. Is there a plan to develop this function?
Describe the solution you'd like
planGraspsAndPick
Describe alternatives you've considered
Nothing
Additional context
No response

The full discussion is here: https://github.com/moveit/moveit2/issues/1038 - but basically the manipulation code has been deprecated and removed from move_group - you should check out the MTC tutorial which is the recommended alternative: https://moveit.picknik.ai/main/doc/tutorials/pick_and_place_with_moveit_task_constructor/pick_and_place_with_moveit_task_constructor.html

PR to remove the dead code: https://github.com/moveit/moveit2/pull/3025


the with of the column selection is too small

When creating a classification I wanted to use the FREL 2020 results as an input. the raw data are using as column values the real name of the classes i.e. "Grassland", "Cropland" ....
I select the file, I select the column and then I need to select the value for each legend item. I click on the rounded + and then instead of the name I only see the first letter, badly cut (make it difficult to differenciate "C" and "G").
I think the dropdown width is bound to the parent field which is a problem if column name is bigger than 1 character. Would it be possible to free it ?

Fixed.


Migrates to package:web and js_interop

:scroll: Description

Continuation of https://github.com/getsentry/sentry-dart/pull/2064 by josh-burton
Additions:

Bump sentry packages to Dart 3.3.0 and Flutter 3.19.0

Updated & Re-run ffigen to generate bindings with updated parameters.
:bulb: Motivation and Context

Supports compilation via WASM
:green_heart: How did you test it?
Make sure CI runs without issues.
:pencil: Checklist

[ ] I reviewed submitted code
[ ] I added tests to verify changes
[ ] No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
[ ] I updated the docs if needed
[ ] All tests passing
[ ] No breaking changes

:crystal_ball: Next steps
This is a rather large bump for us, and we will probably create a pre-release version if we choose to go with this approach.
Still to resolve

[ ] We use [packae_info_plus], which added support for wasm in Version 6.0.0., which also requirise dart 3.3.0

We can close this now as we don't plan to bump the versions


foxglove_bridge: 0.2.2-1 in 'humble/distribution.yaml' [bloom]

Increasing version of package(s) in repository foxglove_bridge to 0.2.2-1:

upstream repository: https://github.com/foxglove/ros-foxglove-bridge.git
release repository: https://github.com/ros2-gbp/foxglove_bridge-release.git
distro file: humble/distribution.yaml
bloom version: 0.11.2
previous version for package: 0.2.1-1

foxglove_bridge
* Fix messages not being received anymore after unadvertising a client publication (#109 <https://github.com/foxglove/ros-foxglove-bridge/issues/109>)
* Allow to whitelist topics via a ROS paramater (#108 <https://github.com/foxglove/ros-foxglove-bridge/issues/108>)
* Contributors: Hans-Joachim Krauch

This pull request has been mentioned on ROS Discourse. There might be relevant details there:
https://discourse.ros.org/t/preparing-for-humble-sync-2022-12-16/28737/2


Error on installing Notifynder on Laravel 5.2

when I try to vendor:publish, I get following error
[Symfony\Component\Debug\Exception\FatalErrorException]
Call to undefined method Illuminate\Foundation\Application::bindShared()

This will be fixed with pull request #64

:+1:
Merged this and tagged it to 3.1.2 :)


Beta

:tada: This PR is included in version 1.0.0-beta.21 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Layout of code examples

Migrated from Google Code (issue 340)

This has become outdated with the new website styling.


KCL Configuration Loaders + Multi Stream Support

Changes Introduced
Introduces configuration loaders for the KCL via Ciris. Also introduces some basic helpers for the multi-stream constructors that the KCL offers, but will not consider this for the configuration loader as it is an edge case to use it (and not recommended).
Applicable linked issues
#26
Checklist (check all that apply)

[ ] This change maintains backwards compatibility
[ ] I have introduced tests for all new features and changes
[x] I have added documentation covering all new features and changes
[x] This pull-request is ready for review

Codecov Report
Base: 63.58% // Head: 52.56% // Decreases project coverage by -11.02% :warning:

Coverage data is based on head (2c4206c) compared to base (088a346).
Patch coverage: 3.89% of modified lines in pull request are covered.

:exclamation: Current head 2c4206c differs from pull request most recent head 5085388. Consider uploading reports for the commit 5085388 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #30       +/-   ##
===========================================
- Coverage   63.58%   52.56%   -11.02%
===========================================
  Files          43       52        +9
  Lines        2013     2395      +382
  Branches       53       61        +8
===========================================
- Hits         1280     1259       -21
- Misses        733     1136      +403

Impacted Files
Coverage Δ

...c/main/scala/kinesis4cats/kcl/ciris/KCLCiris.scala
0.00% <0.00%> (ø)

...n/scala/kinesis4cats/kcl/ciris/RetrievalType.scala
0.00% <0.00%> (ø)

.../main/scala/kinesis4cats/kcl/instances/ciris.scala
0.00% <0.00%> (ø)

.../kcl/fs2/localstack/LocalstackKCLConsumerFS2.scala
80.00% <ø> (ø)

...is4cats/kcl/localstack/LocalstackKCLConsumer.scala
59.25% <ø> (-8.39%)
:arrow_down:

.../kinesis4cats/kcl/multistream/DetectAndDefer.scala
0.00% <0.00%> (ø)

...nesis4cats/kcl/multistream/MultiStreamConfig.scala
0.00% <0.00%> (ø)

...sis4cats/kcl/multistream/MultiStreamInstance.scala
0.00% <0.00%> (ø)

...esis4cats/kcl/multistream/MultiStreamTracker.scala
0.00% <0.00%> (ø)

...kinesis4cats/kcl/multistream/ProvideAndDefer.scala
0.00% <0.00%> (ø)

... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


:compiler segmentation fault

Description
Running the :compiler command causes a segmentation fault.
To Reproduce
Detailed steps to reproduce the behavior:

Run vim --clean
Enter :compiler gcc
Vim crashes with a segmentation fault

Expected behavior
Vim will continue operating with the specified compiler settings.
Environment

Vim version 8.2.200
OS: macOS 10.15.3
Terminal: Terminal.app

Additional context
This also happens with Vim 8.2.230 on Ubuntu 18.04.3

I confirm the problem.

Best regards,
Tony.


won\t build on Jetson 4.6 with the latest sdk

             param.Depth_Format = static_cast<sl::DEPTH_FORMAT> (mode_Depth % 3);
                       ^~~~~~~~~~~~
/home/nvidia/zed-save-depth/src/main.cpp:331:54: error: ‘DEPTH_FORMAT’ in namespace ‘sl’ does not name a type
                 param.Depth_Format = static_cast<sl::DEPTH_FORMAT> (mode_Depth % 3);
                                                      ^~~~~~~~~~~~
/home/nvidia/zed-save-depth/src/main.cpp:332:70: error: ‘SaveParam {aka struct SaveParamStruct}’ has no member named ‘Depth_Format’
                std::cout << "Format Depth " << getFormatNameD(param.Depth_Format) << std::endl;
                                                                     ^~~~~~~~~~~~
CMakeFiles/ZED_Save_depth.dir/build.make:62: recipe for target 'CMakeFiles/ZED_Save_depth.dir/src/main.o' failed
make[2]: *** [CMakeFiles/ZED_Save_depth.dir/src/main.o] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/ZED_Save_depth.dir/all' failed
make[1]: *** [CMakeFiles/ZED_Save_depth.dir/all] Error 2
Makefile:83: recipe for target

any ideas? how to save pointcloud on jetson?

This sample was made for ZEDSDK 2.X, for a newer version you should refer to this sample instead https://github.com/stereolabs/zed-opencv/tree/master/cpp
You can use sl::Mat::write function to export a point cloud https://www.stereolabs.com/docs/api/classsl_1_1Mat.html#accab3cb8c395f6b32c897e549fef78a8

@adujardin
Hi, I was able to save with yoru reference cpp code.
But it failed at the next step of processing the recorded xyz with open3d
the error is due to [as folks said: "It is either you don't have RGB info in your xyz  file or they are in the wrong order."]
I tried to load the xyz into open 3d then execute these
that worked
dataname="Cloud_526.xyz"
point_cloud= np.loadtxt(input_path+dataname,skiprows=1)

but the next step failed
pcd = o3d.geometry.PointCloud()
pcd.points = o3d.utility.Vector3dVector(point_cloud[:,:3])
pcd.colors = o3d.utility.Vector3dVector(point_cloud[:,3:6]/255)
pcd.normals = o3d.utility.Vector3dVector(point_cloud[:,6:9])

using colab https://colab.research.google.com/drive/1HXVOK53ac6BJHAFxdEVluhFr7UAZKtDV#scrollTo=Q-6ISxhQfC0s&uniqifier=1
folks said it is because  "It is either you don't have RGB info in your xyz  file or they are in the wrong order."

can zed save pointcloud as ply with vertices/ mesh?


Changed macros, function calls, zval* things for PHP-7 compatibility

Hi there. Nice extension but won't compile for php-7. With these changes, one can easily checkout the php7-support branch and have it compiled for the latest language version.

Lgtm


Fixed tile_set_editor_plugin.cpp selection issue where it wouldn't cycle through all subtiles of an autotile.

Fixed issue where using arrows to change the selected tile would not iterate through all subtiles in an autotile, only going up to the second to last row and column.
I am doing this PR in 3.2 in the basis that I tried using master but would crash upon execution of my compiled executabe.
Closes  #42290

Thanks!

@groud For the reference, this was only merged for 3.2, but I assume that your refactoring will supersede the whole tileset editor plugin so it's not necessary to forward-port to master.


Question about Train camera-based baseline

Have you ever met this problem? How Can I fix it?

Have you done step 8 in installation?

Have you done step 8 in installation?

sorry paste the wrong pic
i have update the question pic

This can be fixed by setting workers_per_gpu=0

This can be fixed by setting workers_per_gpu=0

thanks a lot, it works.
so if workers_per_gpu=0, the speed will be slower?


The task export_all_contacts collects all contacts in memory.

For accounts with lots of contacts, this will run out of RAM and fail. We need to ensure it does not collect all contacts in memory and collects them on disk instead.
Alternatively, we need to add a streaming contacts export.

There are a variety of problems with doing this sort of export by email, especially with large data volumes (which is the cause of the memory usage issue here). We should probably expose the streaming HTTP version and kill the email entirely.

I'm a bit -1 on streaming to end users. Even for developers it's a major undertaking to download the kinds of JSON/CSV files we produce in a streaming fashion, Internet dies, computers go to sleep, batteries run out etc... And worst of all, we don't support resuming streaming from where things left off.
I'd be +1 on a streaming API that is used internally to stream to some temporary location and then use nginx to serve it as a static & resumable download after having emailed the download link to the end user.

+1 on smn's idea. A paginated response does solve all the problems of resuming, but does require some sort of client.


this.graph.setCellStyles(mxConstants.STYLE_SHADOW,false);Error

Set a Boolean value, but print is of type string

Your question is seeking debugging help but needs more information. The question should be updated to include desired behavior, a specific problem or error, and the shortest code necessary to reproduce the problem.

Title is the shortest code to reproduce the problem. I want to control the shadow Settings and find that only Boolean values take effect,But when I write a Boolean value through graph.setcellstyles (key,value), its properties become strings,String type doesn't work for it, and I can basically set all the other properties in this way.

I just tested this it works for me. Since you haven't provided an exact reproduction case or environment details I'm closing.


Adding Webex Player

Unversioned URL but currently at version 205
After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[x] Named the cask according to the [token reference].
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no [open pull requests] for the same cask.
[x] Checked the cask was not already refused in [closed issues].
[x] Checked the cask is submitted to [the correct repo].

Seems to be duplicate of webex-nbr-player.rb

@gobinathm is correct; this is already available.

Sorry gents, this is a different piece of software.  Webex-nrb-player plays .arf files and Webex-player plays .wrf files.  The nrb player will not play .wrf so they are not duplicates.
Go to the download page and you'll see that there are two columns in the available downloads table.  One for each program.


[C++][Skyhook] Refactor Skyhook file format to use a higher level interface

Describe the enhancement requested
The enhancement is to refactor the Skyhook file format (a custom target of the Arrow dataset API) to loosen the coupling with the Arrow dataset API.
The request was originally made via the mailing list (link) and mentions that improvements to the dataset API are not possible while maintaining the Skyhook file format in its current form. A reference is also made to Acero and its usage of substrait, perhaps to contextualize a preferred approach.

Component(s)
C++

The basic features of skyhook are a configurable server side scan/compute, and efficient transport of resulting buffers to the client. This does not correspond to a file format; file formats compartmentalize reading data files independent of I/O. A CSV formatted file might reside in a string literal or an S3 bucket, but skyhook's files are actually IPC or parquet and must reside on a ceph server. Writing skyhook as a file format therefore breaks conventions and contracts relied on by the dataset API.
However in the context of acero skyhook has a very natural structure:

A source ExecNode on the client which requests specific scan/compute from the server, forwards returned batches into an ExecPlan, and mediates back pressure.
A ceph CLS which maintains a catalog of data files for scanning, instantiates server side ExecPlans to fulfil client requests, and responds to back pressure from the client.

Some design notes which follow from the above:
Currently skyhook supports only predicate and projection pushdown, but there's no reason to forbid specifying arbitrary computation to the server. For example an aggregation performed on the server could save significant network overhead when the result is small. Although Arrow's Expressions are serializable this feature isn't designed for stability. Substrait is a more capable and stable tool intended for transmitting arbitrary execution plans. It'd be worthwhile to replace projection/filter Expression serialization with a substrait subplan to be executed on the server. This should actually simplify skyhook's server side code since it can reuse arrow::engine::SerializePlan/DeserializePlan.
Furthermore, skyhook need not be bound to a single file format or to output small enough to be materialized as a single Table. On the server an arbitrary collection of data files can be wrapped into a catalog of datasets. For example, a collection of csv and parquet data files could be wrapped in a UnionDataset, cataloged as a single table nyc-taxi. The server side complexity of a dataset can be invisible to client configuring a scan; clients should only need to reference these datasets by name and schema, using a substrait NamedTable message.
Instead of having each skyhook scan negotiate a new connection, the connection to a ceph server should be factored out to an independent client side object. This way validation of the connection, checking for registration of a compatible CLS, and caching of the server's catalog can all be compartmentalized into a single construction.
The purpose of the arrow monorepo is cross platform library code, whereas skyhook is comprised of a specialized service and client pair. Skyhook should therefore probably be relocated outside the arrow monorepo. Moreover skyhook is compelling as a demonstration of both the extensibility and usability of acero from third party code, which will be emphasized by keeping it in an independent project.
Some example code illustrating what using a skyhook source node on the client could look like:
// This only needs to be done once:
ARROW_ASSIGN_OR_RAISE(auto skyhook_connection, MakeSkyhookConnection(
    config_path, data_pool, user_name, cluster_name));

// Display the catalog:
for (auto [name, schema] : skyhook_connection.catalog()) {
  std::cout << name << ": " << schema->ToString() << std::endl;
}

Result<std::shared_ptr<Table>> GetTripCostsForYear(int year) {
  // Declare a server side plan which will aggregate trip costs
  // grouped by tag in the specified year:
  auto server_side_plan = Declaration::Sequence({
      {"named_table", skyhook_connection.MakeNamedTableOptions("nyc-taxi")},
      {"filter", FilterNodeOptions(equal(field_ref("year"), literal(year)))},
      {"aggregate", AggregateNodeOptions({{"hash_sum", "cost", "cost_sum"}}, {"tag"})},
  });

  // The client side plan then uses the server side plan to configure its source node:
  std::shared_ptr<Table> output_table;
  auto client_side_plan = Declaration::Sequence({
      {"skyhook_source", SkyhookSourceNodeOptions(server_side_plan, skyhook_connection)},
      {"table_sink", TableSinkNodeOptions(&output_table)},
  });

  // Run the plan, return the resulting table
  ARROW_ASSIGN_OR_RAISE(auto plan, ExecPlan::Make());
  ARROW_RETURN_NOT_OK(client_side_plan.AddToPlan(plan.get()));
  auto finished = plan->finished();
  ARROW_RETURN_NOT_OK(finished.status());
  return output_table;
}

A summary of the additions necessary to make that work, client side:

SkyhookSourceNode (subclass of ExecNode)

in StartProducing() override: serialize server_side_plan to substrait and send to server
receives ceph::bufferlists asynchronously, converts to ExecBatches, then pushes to the next node with this->output()->InputReceived()
forwards PauseProducing() and ResumeProducing() calls to the server

SkyhookSourceNodeOptions (subclass of ExecNodeOptions)
in client initialization: register SkyhookSourceNode factory named "skyhook_source"

... and on the server side:

Maintain a catalog mapping table names to datasets, accessible as a NamedTableProvider
Respond to new connections with a summary of the catalog, mapping names to schemas
Receive and excecute server_side_plans from clients

deserialize from substrait
construct and run ExecPlan
convert each generated ExecBatch to ceph::bufferlist and transmit to the client
pause and resume when indicated by the client

Wow, thanks so much for the write up: it is well written and gives me clear ideas of the direction you're proposing and where the drawbacks of the Skyhook file format are.
I want to clarify (or maybe pushback?) on a few things, but overall I see a path forward with minimal changes to your suggestions.

The basic features of skyhook are a configurable server side scan/compute, and efficient transport of resulting buffers to the client. This does not correspond to a file format; file formats compartmentalize reading data files independent of I/O.

I believe that the Skyhook file format (as implemented) is a contract that when files are written in a given format (arrow IPC) using a standard posix filesystem, they can be read using a different interface (arrow dataset). Because two separate I/O interfaces are used, the file format accommodates that in the contract. It is akin to saying that if you write files in a particular way, you can process the blocks of the file without changing how you write files.

Writing skyhook as a file format therefore breaks conventions and contracts relied on by the dataset API.

Yes, this part I understand. I would just add that this is because ceph (which skyhook is an extension for) has a broader definition of what a "file" is in order to map it to object storage. Any system that shims a filesystem interface over the actual storage interface is going to have a similar impedance mismatch (e.g. s3fs or anything like that).
All that being said, I agree that nearly all of the changes you've proposed are good; the only one I think we won't do is grouping of files (unless we find a way to shim a "special directory" as a grouping, but that sounds hack-y).
To rephrase your proposal, I believe you're suggesting we implement a custom operator (SkyhookSourceNode) to facilitate data flow between the client and server over the network. The input to the custom operator is executed by Skyhook and the results are handled by the client node.
I think the catalog can still be resolved on the client side and the custom operator can be used in many connections (every FileFragment is an independent access to a potentially distinct ceph server) and this would only require very simple ExecPlan transformations.

I also want to note that pushing any more operators below the SkyhookSourceNode would be done blindly without some type of optimizer making that decision. So, the new operator makes sense when inserted above Read operators and that would be the sensible first step.
@bkietz would you know how Acero serializes custom operators into substrait? Does it use a message that is only known internally? I have been working with custom substrait messages and SkyhookSourceNode is a perfect example of where it seems to make sense to use one (and I have something similar I can use here

I believe that the Skyhook file format (as implemented) is a contract that when files are written in a given format (arrow IPC) using a standard posix filesystem, they can be read using a different interface (arrow dataset).

The problem is that the contract of skyhook as written is not the contract of a file format. File formats are intended to be an orthogonal detail to I/O. It would be possible to write a subclass of arrow::Array which is mutable, but although that is possible the broken contract of immutability will severely restrict its usage in the arrow library.

To rephrase your proposal, I believe you're suggesting we implement a custom operator (SkyhookSourceNode) to facilitate data flow between the client and server over the network. The input to the custom operator is executed by Skyhook and the results are handled by the client node.

Yes, SkyhookSourceNode is a client side node which proxies the server side plan in the client side plan.

(every FileFragment is an independent access to a potentially distinct ceph server)

I would recommend instead having a 1:1 relationship between SkyhookSourceNodes and ceph servers. If multiple ceph servers are in play, a UnionNode can be used in the client side plan to concatenate their streams.

would you know how Acero serializes custom operators into substrait?

The design above does not require serializing custom nodes, since it only requires serialization of the server side plan. The SkyhookSourceNode will only appear in the client side plan.

I also want to note that pushing any more operators below the SkyhookSourceNode would be done blindly without some type of optimizer

Optimization and other restructuring of plans is not currently in scope for acero. Instead the exact plan specified is what will be executed. The roadmap hope is that acero's substrait support will continue to improve and that cross-engine plan optimizers will be written against substrait

The hope is that acero's substrait support will continue to improve and that cross-engine plan optimizers will be written against substrait

I am working on enabling cross-engine plan optimizers, so that's not a general issue, just a necessary mechanism to enable specifying arbitrary computation to skyhook.

If multiple ceph servers are in play, a UnionNode can be used in the client side plan to concatenate their streams

but there must be something which accepts ceph::bufferlist. It seems a UnionNode should be an input to the SinkNode and used to concatenate SkyhookSourceNodes.

The design above does not require serializing custom nodes, since it only requires serialization of the server side plan

Then I may be misunderstanding. If SkyhookSourceNode is a client-only node, then it seems like you're proposing execution of 2 independent ExecPlans, and not the use of SkyhookSourceNode for facilitating network communication in the execution of a single ExecPlan, correct? In which case I suppose I can understand the recommendation of a UnionNode, but I am not sure it would even be needed if execution on the server side and client side are independent.

File formats are intended to be an orthogonal detail to I/O.

I won't belabor the point because I understand you to mean this for the Arrow library in particular. I was just mentioning that file format is not orthogonal if a storage system wants to improve performance. Parquet is an example where it is not orthogonal, the point of RowGroups is to allow portions of a file to be accessible independent of the larger file. But this was meant to be a broad comment, not on how the dataset API should be designed; I totally agree that we want to remove the skyhook file format if it's hindering Arrow's development.

If SkyhookSourceNode is a client-only node, then it seems like you're proposing execution of 2 independent ExecPlans

Precisely; a server side plan which reads files and performs pushed-down compute finally pushing batches to the client, and a client side plan which receives these batches and performs other computation on them. This is analogous to the current structure of Skyhook which uses arrow datasets on the server side to scan/filter/project/transmit a Table to the client, and on the client side to act as a data source.
For example: the server side plan might read a set of parquet files with a pushed down filter and perform aggregation while the client side plan includes a UnionNode and collects batches from the skyhook server and from a local dataset, collecting into a single Table:
# server side:
ScanNode(nyc-taxi/*.parquet)
  -> FilterNode(year==2016)
    -> AggregateNode(cost ON tag)
       -> SinkNode(push ceph::bufferlist to client)

# client side:
ScanNode(local-addenda.parquet) ---------------------------v
SkyhookSourceNode(receive ceph::bufferlist from server) -> UnionNode -> TableSinkNode

In this example, the client side plan includes a SkyhookSourceNode to facilitate network communication by forwarding batches from the server into the UnionNode. For another example, the client side plan could union streams from three different skyhook servers (since we have UnionNode, there's no need to complicate SkyhookSourceNode by forcing it to deal with multiple servers):
# client side:
SkyhookSourceNode(receive ceph::bufferlist from server A) ---v
SkyhookSourceNode(receive ceph::bufferlist from server B) -> UnionNode -> TableSinkNode
SkyhookSourceNode(receive ceph::bufferlist from server C) ---^

Actually, it occurs to me that skyhook file format should really have been more like a file reader and the difference from the parquet reader is that it can execute compute, etc. on each fragment. I guess another anecdote that the abstractions are not very clean cut.

This isn't explicitly documented, it's true. It might be useful to note that file readers and the file formats which wrap them can be pointed at a path on a file system or a specific buffer (FileSource) and are guaranteed to do no IO other than reading from that file system or that buffer.

one last thing I'm curious about, I assume that the sink node on the server side can't stream batches to the client? or is there a way to access ExecBatches from the sink node in a streaming manner?

The default sink node does allow access to the stream of batches as a AsyncGenerator<std::optional<ExecBatch>>. AsyncGenerator<T> is a sequence of Future<T>, and we have several utilities to consume and compose these. The simplest approach is probably to wrap the generator into a synchronous sequence with MakeGeneratorIterator and dedicate a thread to iterate through the synchronous sequence, pushing each batch

I think I can start working on this in about 3 weeks. I haven't forgotten about it


voiceSelect.selectedOptions[0] is undefined

On firefox 49 i get voiceSelect.selectedOptions[0] is undefined http://mdn.github.io/web-speech-api/speak-easy-synthesis/

This is probably fixed by PR #5

I'm getting the same in Firefox 76.0.1.
The drop-down menu is empty. When clicking play this errors shows up. I guess because I could not select a voice.

Hey @Mte90 and @LoLei! Thank you for opening and commenting on this issue. We are combining some of our repositories to enable us to triage pull requests and issues more effectively. Therefore, this specific repository will be merged into the more prominent dom-examples repository. Please open a new issue if you still feel that this issue is relevant. Thank you.


Update obsolete compile to implemenation

Hi again,  @oblador as I mentioned in one your other package here https://github.com/oblador/react-native-keychain/pull/141/commits/93b46d46abe5328102ef9e40faa6e9b3a35797d1
this one also need to be updated. I will once again explain everything here.
As React native 0.56.0 is released with MAJOR android changes such as:
-Gradle 3.5.1
-Compile using Android SDK 26
-Google Maven repo
-etc
more about Change log, specially of Android Here, https://github.com/react-native-community/react-native-releases/blob/master/CHANGELOG.md#android-projects-are-now-compiled-using-the-android-26-sdk
and https://github.com/react-native-community/react-native-releases/blob/master/CHANGELOG.md#android-specific-changes
Aslo as Per Google new "Google Play's target API level requirement", mentioned here  https://developer.android.com/distribute/best-practices/develop/target-sdk

Google Play will require that new apps target at least Android 8.0 (API level 26) from August 1, 2018, and that app updates target Android 8.0 from November 1, 2018.

It's clear that Android would be moving to new Gradle and new SDK changes, Thus creating a new type of error that is:
"Configuration 'compile' is obsolete and has been replaced with 'implementation' or 'Api'"
more about the Old and new configuration please see this https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration?utm_source=android-studio#new_configurations
at the heading of "Use the new dependency configurations"
Therefore, all old "compile" should be now "implementation" or "provided" should be "compileOnly"
I have tested the with "compile" and "implementation" in my current release ready product and also by "renaming" "compile" to "implementation".
ext {
    buildToolsVersion = "26.0.3"
    minSdkVersion = 16
    compileSdkVersion = 26
    targetSdkVersion = 26
    supportLibVersion = "26.1.0"
}

Also tested with higher andorid SDK configs such as of below:
ext {
    buildToolsVersion = "27.0.3"
    minSdkVersion = 19
    compileSdkVersion = 27
    targetSdkVersion = 27
    supportLibVersion = "27.1.1"
}

so SDK 27 was also compiled successully. test on Android phone with ADK 23 all looks good. Thus, react-native-vector-icons was working just fine as intended. thank you so much for this package.
Therefore, Please would it be possible to merge as i am sure many new projects and old one are going to update specially Gradle and SDK as of Google new requirements.
related mention of Upgrading issue mention here https://github.com/facebook/react-native/issues/20273#issuecomment-405959030
Moreover, if someone still have any issue after upgrading everything successfully, then he should use following in build.gradle under andorid/build.gradle

subprojects {
    afterEvaluate {project ->
        if (project.hasProperty("android")) {
            android {
                compileSdkVersion 27
                buildToolsVersion '27.0.3'
                supportLibVersion = "27.1.1"
            }
        }
    }
}

Duplicate of https://github.com/oblador/react-native-vector-icons/pull/628 et al

didn't know there was a PR already. could it possible to merge that PR then @oblador  thanks


Regarding Issue #19

Hey @AKACHI-4 ,
I have successfully created a model for Movie recommendation system.
Please merge my pr.

Great work, @s-dabral ! 👏
Congratulations 🎉, your pull request has been successfully merged!
If you find this repository helpful, please consider giving us a star by clicking ⭐.
And don't forget to share your achievement with your friends and us in Discussions ! 🚀


Watchdog found problem in HA Docker

Home Assistant release with the issue:
0.80.3

Last working Home Assistant release (if known):
0.80.2
Operating environment (Hass.io/Docker/Windows/etc.):
Hassio on Intel NUC

Component/platform:

Description of problem:
HA crashes after some minutes working fine. First, lost connection (shows the "Connection lost, reconnecting" message) and then crash and isn't comming back. I didn't make any changes after update to 0.80.3, previous version works fine.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):
18-10-24 01:50:00 INFO (MainThread) [hassio.homeassistant] Detect a running Home Assistant instance
18-10-24 01:52:18 WARNING (MainThread) [hassio.tasks] Watchdog found a problem with Home Assistant Docker!
18-10-24 01:52:18 INFO (SyncWorker_7) [hassio.docker.interface] Clean homeassistant/intel-nuc-homeassistant Docker application
18-10-24 01:52:19 INFO (SyncWorker_7) [hassio.docker.homeassistant] Start homeassistant homeassistant/intel-nuc-homeassistant with version 0.80.3
18-10-24 01:52:39 ERROR (MainThread) [hassio.homeassistant] Home Assistant has crashed!
18-10-24 01:52:39 ERROR (MainThread) [asyncio] Task exception was never retrieved
future: <Task finished coro=<Tasks._watchdog_homeassistant_docker() done, defined at /usr/local/lib/python3.7/site-packages/hassio/tasks.py:93> exception=HomeAssistantError()>
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/hassio/tasks.py", line 107, in _watchdog_homeassistant_docker
    await self.sys_homeassistant.start()
  File "/usr/local/lib/python3.7/site-packages/hassio/utils/__init__.py", line 33, in wrap_api
    return await method(api, *args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/hassio/homeassistant.py", line 299, in _start
    await self._block_till_run()
  File "/usr/local/lib/python3.7/site-packages/hassio/homeassistant.py", line 507, in _block_till_run
    raise HomeAssistantError()
hassio.exceptions.HomeAssistantError

Additional information:

/move to home-assistant/hassio


Manages Guests UI

As a developer, I want to craft comprehensive RSpec test cases for the Manage Guests UI, ensuring that the user interface operates effectively for essential tasks such as creating new guest profiles, updating existing profiles, deleting guest records, and viewing guest details. The tests will cover diverse scenarios, including valid and invalid inputs, edge cases, and error handling, to ensure the seamless and error-free functioning of the Guests UI.


(feat): Markdown table processor support

What would you like to be added:
As per title.
Why is this needed:
Useful feature to have since some data is better represented in a tabular form. For example, a glossary, schema, etc.

/area contented-processor

This is already supported?
| A | B |
|---|---|
| 1 | 2 |

A
B

1
2

😱