Mapbox crashes when using "aboveLayerID" property

Describe the bug
Mapbox crashes when using "aboveLayerID" property.
To Reproduce
Add various layers and set one of the layers to appear "above" the other as follows:
        <Mapbox.VectorSource
          id="customSourceExample"
          url={VECTOR_SOURCE_URL}
        >
          <Mapbox.FillLayer
            id="customSourceFill"
            sourceLayerID="roadless"
            style={mbStyles.boxFill}
            aboveLayerID="basemap"
          />
        </Mapbox.VectorSource>

       <Mapbox.RasterSource id="rasterSourceBasemap" tileSize={256} url={url}>
          <Mapbox.RasterLayer
            id="basemap"
            sourceID="rasterSourceBasemap"
            style={{rasterOpacity: 1}}
          />
        </Mapbox.RasterSource>

Expected behavior
In the above example, the Vector FillLayer should appear above the RasterLayer based on the property defined aboveLayerID="basemap"
Screenshots
xCode crashes:

Versions (please complete the following information):

Platfrom: iOS
Device: XR Simulator
React Native Version 0.59

See also https://github.com/nitaliano/react-native-mapbox-gl/issues/1135.
The issue is that at the time #customSourceFill added to the map, the #aboveLayerID is not yet added to the map therefore it will not find the layer and that's the cause of crash.
Ideally in such cases we'd either defer the insertion until the referred layer is added

@mfazekas Thank you for that insight.  What is the best way to ensure a layer is added to the map? Does the order in which I define the layers have any impact on that order?
For example, if I were to switch these layers around:
       <Mapbox.RasterSource id="rasterSourceBasemap" tileSize={256} url={url}>
          <Mapbox.RasterLayer
            id="basemap"
            sourceID="rasterSourceBasemap"
            style={{rasterOpacity: 1}}
          />
        </Mapbox.RasterSource>

        <Mapbox.VectorSource
          id="customSourceExample"
          url={VECTOR_SOURCE_URL}
        >
          <Mapbox.FillLayer
            id="customSourceFill"
            sourceLayerID="roadless"
            style={mbStyles.boxFill}
            aboveLayerID="basemap"
          />
        </Mapbox.VectorSource>

Would that load in the proper order?

@systemlevel yep that should work.

@systemlevel with #57 you should be able to declare in any order and RNMapbox should wait for the layer to be inserted bellow.

@mfazekas Excellent update. Thank you. That is perfect!

@mfazekas Doing some more testing on this tonight.  I'm still having some issues getting the aboveLayerID property working.
Here is some more context:

We have made a custom style map in mapbox studio
We have added various vector layers to that mapbox studio map (these are layers we uploaded into studio)
When I try to order those layers in the react-native-mapbox-gl client they don't seem to respond to the order I try to define whether it be via aboveLayerID or layerIndex.

I'm able to control the visibility but I'm unable to control where they sit in relation to the RasterSource layer:
       <Mapbox.RasterSource id="rasterSourceBasemap" tileSize={256} url={url}>
          <Mapbox.RasterLayer
            id="basemap"
            sourceID="rasterSourceBasemap"
            style={{rasterOpacity: 1}}
          />
        </Mapbox.RasterSource>


Add support for Görli

What was wrong?
Trinity should support Clique based networks such as Görli and Rinkeby
How was it fixed?

This uses the recently exposed Clique consensus support in Py-EVM
It adds validate_extension_chain calls at two places to perform chain validation that is dependent on previous headers (which it does under CliqueConsensus)

Further notes
If someone sends us a bad header this will just kill our node in its current form.
Cute Animal Picture

@carver Pinging you for a preliminary review here. It still depends on a Py-EVM release and has some rough corners (like being an easy DOS target)

I didn't have a time block for a 1 kiloline PR today, but I'll aim for Monday


Update office-365-management-activity-api-reference.md

Docs Build status updates of commit 4ad2ecb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

office-365-management-api/office-365-management-activity-api-reference.md
:bulb:Suggestion
View
Details

office-365-management-api/office-365-management-activity-api-reference.md

Line 123, Column 1: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text. NOTE: This Suggestion will become a Warning on 1/29/21.
Line 206, Column 1: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text. NOTE: This Suggestion will become a Warning on 1/29/21.
Line 283, Column 1: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text. NOTE: This Suggestion will become a Warning on 1/29/21.
Line 499, Column 1: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text. NOTE: This Suggestion will become a Warning on 1/29/21.
Line 622, Column 1: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text. NOTE: This Suggestion will become a Warning on 1/29/21.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

@rrgahan PR merged


ImportError: No module named protos.RpcEnum_pb2

Expected Behavior
Has to start normally
Actual Behavior
Traceback (most recent call last):
File "./pokecli.py", line 39, in
from pokemongo_bot import logger
File "/home/alexs/src/PokemonGo-Bot/pokemongo_bot/init.py", line 13, in
from pgoapi import PGoApi
File "/usr/local/lib/python2.7/dist-packages/pgoapi/init.py", line 1, in
from pgoapi      import *
File "/usr/local/lib/python2.7/dist-packages/pgoapi/pgoapi.py", line 33, in
from rpc_api import RpcApi
File "/usr/local/lib/python2.7/dist-packages/pgoapi/rpc_api.py", line 36, in
import protos.RpcEnum_pb2 as RpcEnum
ImportError: No module named protos.RpcEnum_pb2
Steps to Reproduce
remove PokemonGo-Bot dir
git clone -b master https://github.com/PokemonGoF/PokemonGo-Bot.git
sudo pip install -r requirements.txt --upgrade
python pokecli.py
Other Information
OS:
Linux Mint
uname -a
Linux alexs-mint 3.19.0-32-generic #37~14.04.1-Ubuntu SMP Thu Oct 22 09:41:40 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)
32cefeed4760d6b5d2b3eb76d783d0f13d068e83

Issue solved by updating pgoapi via github.
sudo pip install git+https://github.com/tejado/pgoapi.git --upgrade
install -r rquirements.txt --upgrade couldn't help.


Fixing stack balance under generator/yield

We were caching and restoring the sp in the processtryfinally in order to balance the stack when we are in the middle of call. However in the case of generator we can yield out of the call. In that case we actually haven't finished the try part.
So once we comeback after yield we don't need to cache the stack again. Introduced the flag to capture such state and fix the problem.

@aneeshdk @tcare @ThomsonTan please have a look.

Looks good

Can you also add one test case for async functions too?


Un-fork bazel cc_proto_library rules

Use a macro to generate the C++ protobuf library the normal way and tack
on an additional invocation of the protobuf compiler with
protoc-gen-validate as the output plugin.

This was tested as a fork on the in-progress #17, then rebased on master for ease of PR review.


Added untriaged issue workflow.

Coming from https://github.com/opensearch-project/.github/issues/133, create a GitHub workflow for labelling untriaged issues. Please ensure that an untriaged label with color  exists before merging.

Codecov Report

Merging #325 (ef4d7b3) into main (0f92eee) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff            @@
##               main     #325   +/-   ##
=========================================
  Coverage     36.89%   36.89%
  Complexity      887      887
=========================================
  Files           179      179
  Lines          7029     7029
  Branches        857      857
=========================================
  Hits           2593     2593
  Misses         4199     4199
  Partials        237      237

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Expected translation model training speed-up with apex

❓ Questions and Help
What is your question?
Hi all,
what is the expected training speed-up once apex is activated?
I installed the apex library as recommend, however, I don't see any speed-up for my setup.
What have you tried?
I compared two setups, one with apex library installed, the other without.
The command looks like:
 fairseq-train data-bin --log-format simple --log-interval 100 --save-dir /output --max-tokens 7168 --update-freq 1                                          --num-workers 1 --arch transformer --optimizer adam --adam-betas '(0.9,0.98)' --clip-norm 0.0 --lr-scheduler inverse_sqrt --warmup-init-lr 1e-07 --warmup-updates 4000 --lr  0.0007 --min-lr 1e-09 --dropout 0.1 --attention-dropout 0.0 --weight-decay 0.0 --criterion label_smoothed_cross_entropy --label-smoothing 0.0 --fp16 --seed 2 --max-epoch 0 --task translation  --ddp-backend=no_c10d --max-update 80000 --save-interval-updates 2000 --no-epoch-checkpoints --share-all-embeddings --criterion label_smoothed_cross_entropy -distributed-world-size 32 --distributed-backend 'nccl'  --distributed-init-method 'tcp://XXX' --distributed-no-spawn
Successful installation is confirmed with:
Running setup.py install for apex: finished with status 'done'
(self_attn_layer_norm): FusedLayerNorm(torch.Size([512]), eps=1e-05, elementwise_affine=True)
2021-01-27 15:52:48 | INFO | fairseq.optim.adam | using FusedAdam
What's your environment?

fairseq Version: 0.10.1
PyTorch Version: 1.8.0.dev20210127 (with conda)
OS: Linux
How you installed fairseq: pip install --editable .
Python version: 3.7
CUDA/cuDNN version: 10.1.243/7.6.3
GPU models and configuration: 32x V100 (4x 8 GPU nodes)
Any other relevant information: cudatoolkit(-dev for nvcc) was installed with conda

What do I miss?
Any experience with apex and a medium-sized transformer-based NMT setup?
Thanks for your help!
Cheers,
Stephan

It should be a few percent faster. Here's what I get on a single machine with 8xV100:
command
python -m fairseq_cli.train --task dummy_mt --dataset-size 10000000 \
  --arch transformer_wmt_en_de_big --max-tokens 4096 \
  --optimizer adam --lr 0.0001 \
  --log-format simple --log-interval 25 \
  --no-save --max-update 500 \
  --fp16

without apex:
2021-01-29 05:49:31 | INFO | fairseq.trainer | NOTE: gradient overflow detected, ignoring gradient, setting loss scale to: 64.0
2021-01-29 05:49:33 | INFO | train_inner | epoch 001:     26 / 9192 loss=4.831, ppl=28.46, wps=171455, ups=5.25, wpb=32640, bsz=1088, num_updates=25, lr=0.0001, gnorm=8.71, loss_scale=64, train_wall=6, gb_free=20.9, mb_free=21445.4, wall=28
2021-01-29 05:49:37 | INFO | train_inner | epoch 001:     51 / 9192 loss=0.006, ppl=1, wps=186646, ups=5.72, wpb=32640, bsz=1088, num_updates=50, lr=0.0001, gnorm=0.105, loss_scale=64, train_wall=4, gb_free=20.9, mb_free=21445.4, wall=33
2021-01-29 05:49:42 | INFO | train_inner | epoch 001:     76 / 9192 loss=0, ppl=1, wps=186931, ups=5.73, wpb=32640, bsz=1088, num_updates=75, lr=0.0001, gnorm=0.007, loss_scale=64, train_wall=4, gb_free=20.9, mb_free=21445.4, wall=37
2021-01-29 05:49:46 | INFO | train_inner | epoch 001:    101 / 9192 loss=0, ppl=1, wps=186816, ups=5.72, wpb=32640, bsz=1088, num_updates=100, lr=0.0001, gnorm=0.003, loss_scale=64, train_wall=4, gb_free=20.9, mb_free=21445.4, wall=41

with apex:
2021-01-29 05:55:25 | INFO | fairseq.trainer | NOTE: gradient overflow detected, ignoring gradient, setting loss scale to: 64.0
2021-01-29 05:55:27 | INFO | train_inner | epoch 001:     26 / 9192 loss=4.831, ppl=28.46, wps=179591, ups=5.5, wpb=32640, bsz=1088, num_updates=25, lr=0.0001, gnorm=8.833, loss_scale=64, train_wall=6, gb_free=20.9, mb_free=21444.9, wall=28
2021-01-29 05:55:31 | INFO | train_inner | epoch 001:     51 / 9192 loss=0.006, ppl=1, wps=193285, ups=5.92, wpb=32640, bsz=1088, num_updates=50, lr=0.0001, gnorm=0.109, loss_scale=64, train_wall=4, gb_free=20.9, mb_free=21444.9, wall=32
2021-01-29 05:55:36 | INFO | train_inner | epoch 001:     76 / 9192 loss=0, ppl=1, wps=193434, ups=5.93, wpb=32640, bsz=1088, num_updates=75, lr=0.0001, gnorm=0.007, loss_scale=64, train_wall=4, gb_free=20.9, mb_free=21444.9, wall=36
2021-01-29 05:55:40 | INFO | train_inner | epoch 001:    101 / 9192 loss=0, ppl=1, wps=184334, ups=5.65, wpb=32640, bsz=1088, num_updates=100, lr=0.0001, gnorm=0.003, loss_scale=64, train_wall=4, gb_free=20.9, mb_free=21444.9, wall=41
2021-01-29 05:55:44 | INFO | train_inner | epoch 001:    126 / 9192 loss=0, ppl=1, wps=193405, ups=5.93, wpb=32640, bsz=1088, num_updates=125, lr=0.0001, gnorm=0.002, loss_scale=64, train_wall=4, gb_free=20.9, mb_free=21444.9, wall=45
2021-01-29 05:55:48 | INFO | train_inner | epoch 001:    151 / 9192 loss=0, ppl=1, wps=193741, ups=5.94, wpb=32640, bsz=1088, num_updates=150, lr=0.0001, gnorm=0.002, loss_scale=64, train_wall=4, gb_free=20.9, mb_free=21444.9, wall=49

It should be a few percent faster. Here's what I get on a single machine with 8xV100:
command
python -m fairseq_cli.train --task dummy_mt --dataset-size 10000000 \
  --arch transformer_wmt_en_de_big --max-tokens 4096 \
  --optimizer adam --lr 0.0001 \
  --log-format simple --log-interval 25 \
  --no-save --max-update 500 \
  --fp16

without apex:
2021-01-29 05:49:31 | INFO | fairseq.trainer | NOTE: gradient overflow detected, ignoring gradient, setting loss scale to: 64.0
2021-01-29 05:49:33 | INFO | train_inner | epoch 001:     26 / 9192 loss=4.831, ppl=28.46, wps=171455, ups=5.25, wpb=32640, bsz=1088, num_updates=25, lr=0.0001, gnorm=8.71, loss_scale=64, train_wall=6, gb_free=20.9, mb_free=21445.4, wall=28
2021-01-29 05:49:37 | INFO | train_inner | epoch 001:     51 / 9192 loss=0.006, ppl=1, wps=186646, ups=5.72, wpb=32640, bsz=1088, num_updates=50, lr=0.0001, gnorm=0.105, loss_scale=64, train_wall=4, gb_free=20.9, mb_free=21445.4, wall=33
2021-01-29 05:49:42 | INFO | train_inner | epoch 001:     76 / 9192 loss=0, ppl=1, wps=186931, ups=5.73, wpb=32640, bsz=1088, num_updates=75, lr=0.0001, gnorm=0.007, loss_scale=64, train_wall=4, gb_free=20.9, mb_free=21445.4, wall=37
2021-01-29 05:49:46 | INFO | train_inner | epoch 001:    101 / 9192 loss=0, ppl=1, wps=186816, ups=5.72, wpb=32640, bsz=1088, num_updates=100, lr=0.0001, gnorm=0.003, loss_scale=64, train_wall=4, gb_free=20.9, mb_free=21445.4, wall=41

with apex:
2021-01-29 05:55:25 | INFO | fairseq.trainer | NOTE: gradient overflow detected, ignoring gradient, setting loss scale to: 64.0
2021-01-29 05:55:27 | INFO | train_inner | epoch 001:     26 / 9192 loss=4.831, ppl=28.46, wps=179591, ups=5.5, wpb=32640, bsz=1088, num_updates=25, lr=0.0001, gnorm=8.833, loss_scale=64, train_wall=6, gb_free=20.9, mb_free=21444.9, wall=28
2021-01-29 05:55:31 | INFO | train_inner | epoch 001:     51 / 9192 loss=0.006, ppl=1, wps=193285, ups=5.92, wpb=32640, bsz=1088, num_updates=50, lr=0.0001, gnorm=0.109, loss_scale=64, train_wall=4, gb_free=20.9, mb_free=21444.9, wall=32
2021-01-29 05:55:36 | INFO | train_inner | epoch 001:     76 / 9192 loss=0, ppl=1, wps=193434, ups=5.93, wpb=32640, bsz=1088, num_updates=75, lr=0.0001, gnorm=0.007, loss_scale=64, train_wall=4, gb_free=20.9, mb_free=21444.9, wall=36
2021-01-29 05:55:40 | INFO | train_inner | epoch 001:    101 / 9192 loss=0, ppl=1, wps=184334, ups=5.65, wpb=32640, bsz=1088, num_updates=100, lr=0.0001, gnorm=0.003, loss_scale=64, train_wall=4, gb_free=20.9, mb_free=21444.9, wall=41
2021-01-29 05:55:44 | INFO | train_inner | epoch 001:    126 / 9192 loss=0, ppl=1, wps=193405, ups=5.93, wpb=32640, bsz=1088, num_updates=125, lr=0.0001, gnorm=0.002, loss_scale=64, train_wall=4, gb_free=20.9, mb_free=21444.9, wall=45
2021-01-29 05:55:48 | INFO | train_inner | epoch 001:    151 / 9192 loss=0, ppl=1, wps=193741, ups=5.94, wpb=32640, bsz=1088, num_updates=150, lr=0.0001, gnorm=0.002, loss_scale=64, train_wall=4, gb_free=20.9, mb_free=21444.9, wall=49

Hey,
thanks for the quick and detailed answer!
Looks like 3-4% in your case. I observe 1-2%.
Maybe the speed-up is smaller since I train already on 32 GPUs.
Cheers,
Stephan

Hey,
thanks for the quick and detailed answer!
Looks like 3-4% in your case. I observe 1-2%.
Maybe the speed-up is smaller since I train already on 32 GPUs.
Cheers,
Stephan


Bump atlas

Changes the FullExporter -> Exporter.

@grdw I'll merge this now as it appears the ETSource branch has already been merged.


Require binary for arm64

Hi Team,
As we have arm64 support now in CubeFS and many users are using CubeFS in arm64, it will better if we have ARM64 binary released as only AMD64 binary is available in releases
I have successfully built ARM64 binaries on ARM64 platform using command export CPUTYPE=arm64_gcc4 && bash ./build.sh
If required, I am happy to help and contribute.

@odidev It would be nice if you could help with it

@leonrayang
I have successfully built ARM64 binaries on my local ARM64 machine and also I could see that the binary for amd64 is released here but there is no specific release process mentioned. If I could get the release process for binary, I will add for aach64 and raise PR for the same.


Regression in<EMAIL_ADDRESS>+ Electron renderer process. "TypeError: The "listener" argument must be of type function"

Reproduction
Steps to reproduce the behavior:

Use<EMAIL_ADDRESS>in Electron renderer process.

I've created a sample project: https://github.com/babatakao/node-fetch-3-electron-test . With this sample,

Clone the project.
npm ci
npm run build
npm start

Note that the project uses webpack since node: prefix of esm import, used by node-fetch, is not supported by Electron renderer.
Expected behavior
done alert is shown.
Actual behavior

TypeError: The "listener" argument must be of type function. Received an instance of Object
    at __node_internal_captureLargerStackTrace (node:internal/errors:463)
    at new NodeError (node:internal/errors:370)
    at __node_internal_ (node:internal/validators:229)
    at checkListener (node:events:131)
    at ClientRequest.once (node:events:533)
    at new ClientRequest (node:_http_client:209)
    at request (node:http:96)
    at renderer.js:111
    at new Promise (<anonymous>)
    at fetch (renderer.js:66)
    at renderer.js:7025
    at renderer.js:7030
    at renderer.js:7032

Your Environment

software
version

node-fetch
3.1.0

node
16.13.0 (Electron 15 uses Node 16.5)

npm
7.20.6

Operating System
Windows 10 x64

Additional context

The issue does not occur on<EMAIL_ADDRESS>Thus it seems a recent regression.
I've found the root cause. At here, new URL constructor references NodeJS URL in most cases. However, it references Chromium renderer native URL in the Electron renderer process. This causes type mismatch: NodeJS http library checks that whether the URL has searchParamsSymbol or not at https://github.com/nodejs/node/blob/v16.13.0/lib/_http_client.js#L117.
I suspect that this should be import {URL, format as formatUrl} from 'node:url'; 🤔

We're facing a similar issue when using node-fetch in a jest test suite with the jsdom environment, since new URL will refer to jsdom's URL, not node's.

I think this could be the cause: https://github.com/node-fetch/node-fetch/pull/1268 (this was released into 3.1.0)
We mostly just pass the URL onwards to node's http.request(url, options) and that url just so happens to be a URL-class now...
I think if we cast it into a string just right before we hand it to NodeJS that it could solve the issue.
https://github.com/node-fetch/node-fetch/blob/30c3cfe1d2872ada5159a8d7dd34946bd757ff26/src/index.js#L80-L81
- const request_ = send(parsedURL, options);
+ const request_ = send(parsedURL.toString(), options);

I applied the patch to the repo you created (thx for that) and it did seem to solve the issue.

This way it should be working with any instances of URL, wether it's a polyfilled, or any other URL class


Add SpaceX Land GraphQL API

Rockets! Looks like a pretty mature production API.

The same API is already present in the unofficial table and it was added with the #44 pr

The same API is already present in the unofficial table and it was added with the #44 pr


Do some codebase modernization

Some of these changes seem like they'd be nice to have, while others change the code style for minimal benefit. Since it has so many changes mixed together, I don't think we can accept this change.


CLAS/INTF, error if method/attribute/type name is more than 30 characters

might be implemented same place as https://github.com/abaplint/abaplint/issues/2096

plus FORM names?

eg METHODS render_element_and_two_attribute FOR TESTING RAISING cx_static_check.


User email signature

Users need access to their own email signature, which is currently only on the admin settings and not available to users at Home > Settings.

Fixed


Improve JSInvokable documentation in case of trimming.

Link to the doc: https://learn.microsoft.com/en-us/aspnet/core/blazor/javascript-interoperability/call-dotnet-from-javascript
There is no caution about JS Interop (Call .NET from JS) when trimming / AOT is enabled.
Linker has no idea about JS Interop and when there is no reference in project to the method with JSInvokable, this method will be removed in case of trimming / AOT and you will get a runtime exception about the missing method when JS tries to call this .NET method.
The docs should warn you about this and offer a solution.
For example, if you inspect aspnetcore source code, you can see how they deal with this by using DynamicDependency attribute.
internal sealed class InputFileJsCallbacksRelay : IDisposable
{
    private readonly IInputFileJsCallbacks _callbacks;

    public IDisposable DotNetReference { get; }

    [DynamicDependency(nameof(NotifyChange))]
    public InputFileJsCallbacksRelay(IInputFileJsCallbacks callbacks)
    {
        _callbacks = callbacks;

        DotNetReference = DotNetObjectReference.Create(this);
    }

    [JSInvokable]
    public Task NotifyChange(BrowserFile[] files)
        => _callbacks.NotifyChange(files);

    public void Dispose()
    {
        DotNetReference.Dispose();
    }
}

This is also important, because when you contribute to blazor open source projects the project owner might ask for documentation about this behavior.

Hi @ScarletKuro ... Please re-open this issue using the This page feedback button and form at the bottom of the English-US topic. Use of the This page feedback form adds metadata to your GitHub issue that cross-links the topic and automatically pings the author.

... and pings the author just means ME 🦖 really 😆.


Xcode reports hang risk from the Amplitude SDK

Xcode reports the following warning when running my app with the Amplitude SDK (version 1.4.5) installed:
Amplitude-Swift/Sources/Amplitude/Utilities/OutputFileStream.swift:40 {"message":"This code path does I/O on the main thread underneath that can lead to UI responsiveness issues. Consider ways to optimize this code path","antipattern trigger":"-[NSData enumerateByteRangesUsingBlock:]","message type":"suppressable","show in console":"0"}

iOS 17.4.1
Xcode 15.3

Hi @yqiang, this should be fixed in 1.5.0 - please reopen this issue if it persists!


Pretty printing erases comments

Single line comments between binding and body are being erased when using the pretty printer:
let a = 1
// comment
a
// comment
Also any block comments:
/* comment 1
comment 2 */

Fixed some of the most egregious problems but there are still many places where comments can be missing. Will return to this soon-ish but I have some other things I need to finish first (#279 primarily)


Fails with error if input is array of json data at top level

Hi,
I was using this plugin to build scalable log management system. I am facing a issue if data received by this plugin from rabbitmq is array of josn at top level as described. please help me how can i fix this issue. Any help in this regard would be appreciated.
json format -
[
{"name":"java.lang:type=OperatingSystem-TotalSwapSpaceSize","value":2147483648},{"name":"java.lang:type=OperatingSystem-FreeSwapSpaceSize","value":671612928},{"name":"java.lang:type=OperatingSystem-ProcessCpuTime","value":11065977}
]

Is that supposed to be 3 separate events?  I don't think this will work within the Logstash event framework at the top level.  I think your options include:

Create a json_array codec based on the json_lines or json codecs.  This codec would expect an array of json lines, and send them through as individual events.  This codec could even require the json_lines codec and just work on top of that.
Parse into individual events/json lines before sending to Logstash.

This thread seems dead, closing.


No style is defined for element

When config template card is used as an element in a picture-elements card, I get an error saying "No style is defined for element
type: custom:config-template-card
variables:
  LIGHT_STATE: states['light.badroom_gateway_58b3fcaa0369_rgb_led_58b3fcaa0369'].state
  COLOR_MODE: >-
    states['light.badroom_gateway_58b3fcaa0369_rgb_led_58b3fcaa0369'].attributes.color_mode
  LIGHT_COLOR: >-
    states['light.badroom_gateway_58b3fcaa0369_rgb_led_58b3fcaa0369'].attributes.hs_color
  BRIGHTNESS: >-
    states['light.badroom_gateway_58b3fcaa0369_rgb_led_58b3fcaa0369'].attributes.brightness
entities:
  - light.badroom_gateway_58b3fcaa0369_rgb_led_58b3fcaa0369
element:
  type: image
  image: /local/floorplan/transparent.png?version=56ABE4CBC175363DA0810882244B34FF
  state_image:
    "on": >-
      ${COLOR_MODE === 'color_temp' || (COLOR_MODE === 'rgb' && LIGHT_COLOR &&
      LIGHT_COLOR[0] == 0 && LIGHT_COLOR[1] == 0) ?
      '/local/floorplan/light.badroom_gateway_58b3fcaa0369_rgb_led_58b3fcaa0369.png?version=9E55DA10C259F55AE678EC9E5E57AD84'
      :
      '/local/floorplan/light.badroom_gateway_58b3fcaa0369_rgb_led_58b3fcaa0369.red.png?version=A23183A6996BC3C33E68350F20EC9998'
      }
  entity: light.badroom_gateway_58b3fcaa0369_rgb_led_58b3fcaa0369
style:
  filter: "${ \"hue-rotate(\" + (LIGHT_COLOR ? LIGHT_COLOR[0] : 0) + \"deg)\"}"
  opacity: "${LIGHT_STATE === 'on' ? (BRIGHTNESS / 255) : '100'}"
  mix-blend-mode: lighten
  pointer-events: none
  left: 50%
  top: 50%
  width: 100%

Not a lot to go on here... The only reference I'm seeing for this error message is https://github.com/iantrich/config-template-card/issues/52 and that's from 4 years ago. Are you using an up-to-date version of config-template-card? Also, have you verified that the entity name is correct? Are there any errors that show up in the browser's developer tools / console?

The only difference I see between your light and mine is that mine is an rgb color mode while yours is hs.
I tried to create a fictive light via the MQTT integration by adding the following to my configuration:
mqtt:
  light:
    - name: mqtt_json_hs_light
      schema: json
      command_topic: "home/light/set"
      supported_color_modes: ["hs"]

Then set the light values to something similar to your (cyan and 49% brightness):

But it still displays as expected...
I'll need your help to debug this. Could you please try to change the element -> type -> state_image -> on value to a plain string like: /local/floorplan/light.badroom_gateway_58b3fcaa0369_rgb_led_58b3fcaa0369.png?version=9E55DA10C259F55AE678EC9E5E57AD84 and see if that changes anything? If not, I'd try removing the filter and opacity entries from the style and lastly, should nothing help, removing the variables one by one. Once we figure out which line is causing the issues, we can try to understand why

type: custom:config-template-card
variables:
  LIGHT_STATE: states['light.korridor_gateway_58b3fcabb6b6_rgb_led_58b3fcabb6b6'].state
  COLOR_MODE: >-
    states['light.korridor_gateway_58b3fcabb6b6_rgb_led_58b3fcabb6b6'].attributes.color_mode
  LIGHT_COLOR: >-
    states['light.korridor_gateway_58b3fcabb6b6_rgb_led_58b3fcabb6b6'].attributes.hs_color
  BRIGHTNESS: >-
    states['light.korridor_gateway_58b3fcabb6b6_rgb_led_58b3fcabb6b6'].attributes.brightness
entities:
  - light.korridor_gateway_58b3fcabb6b6_rgb_led_58b3fcabb6b6
element:
  type: image
  image: /local/floorplan/transparent.png
  state_image:
    "on": /local/floorplan/light.korridor_gateway_58b3fcabb6b6_rgb_led_58b3fcabb6b6.png
  entity: light.korridor_gateway_58b3fcabb6b6_rgb_led_58b3fcabb6b6

![Uploading 2024-12-29_16-06-28.png…]()

What about removing the variables? Those are the only things left that are "special".

I can't seem to find where that error is coming from. It used to exist in config-template-card. At least it did on version 1.3.1:
wget https://github.com/iantrich/config-template-card/releases/download/1.3.1/config-
grep -i "no style" config-template-card.js
    // If there are no styles, skip unnecessary work
        // When no style is left in the template, parts will be broken as a
        // There can be no style in the template in 2 cases (1) when Shady DOM
            throw new Error('No style defined for element');

But it doesn't in newer versions:
wget https://github.com/iantrich/config-template-card/releases/download/1.3.6/config-template-card.js
grep -i "no style" config-template-card.js

Please make sure your version is really updated to v1.3.6 and maybe clear your browser's cache.

I have an rgb lamp
but also a style mistake

Did you verify that you're really using an up-to-date version of config-template-card. As shown above, that error doesn't exist in the v1.3.6 version. Please verify the version and clear the browser's cache. Then try again

I installed from HACS new version
I looked at the file size and it is twice as large
I manually overwrote the file and everything works!
thank you very much for your help

Glad to hear it worked out


Restore clone-branch

Github changed the selectors
Test on:
https://github.com/sindresorhus/refined-github/branches
https://github.com/yakov116/TestR/branches
Cool issue #3000
<!--

Thanks for contributing! 🍄

1. LINKED ISSUES:
   Does this PR close/fix an existing issue? Write something like `Closes #10`

2. TEST URLS:
   Add some test URLs

3. SCREENSHOT:
   Add a screenshot here if your PR makes visual changes

Congrats on opening discussion #3000 🎉

Congrats on opening discussion #3000 🎉

And i thought it would be simple 😄


head.use is not a function

Describe the bug
Hello, just update my module but can't know what happened

Reproduction
https://github.com/Barbapapazes/le-classement.fr/pull/79
System Info
System:
    OS: Windows 10 10.0.19044
    CPU: (4) x64 Intel(R) Core(TM) i5-7300U CPU @ 2.60GHz
    Memory: 3.15 GB / 15.88 GB
  Binaries:
    Node: 18.12.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 3.3.0 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.19.2 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (108.0.1462.42), ChromiumDev (109.0.1495.2)
    Internet Explorer: 11.0.19041.1566

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Hi, please delete lock file / node_modules and re install. You need the latest @vueuse/head version

Hello,
I just see the lastest release of @vueuse/head but because Nuxt3 use it internally, I have to way that the Nuxt team update it and release it ?

Nuxt has a caret dependency of @vueuse/head, so when you delete your lock file / node_modules and re-install, it will use the latest patch release
Did you try it?

It works perfectly, thanks a lot for your works!


RedirectResponse tries to use non-existing session

Laravel Version: 6.7.0
PHP Version: 7.3.6
Database Driver & Version:

Description:
When session is disabled, validation error throws an exception, which cause creating \Illuminate\Http\RedirectResponse object, and calling withInput method. withInput method doesn't check if there is session, which cause "Call to a member function flashInput() on null" error
Steps To Reproduce:

Totally disable session
Create custom request
Create custom method "failedValidation"
throw App\Exceptions\ValidationException with error message and error bag

The problem here is that there's no way to properly make use of validation when sessions aren't enabled. Because the errors can't be held inside the session, there's no way to flash them to response. So I don't believe this is possible what you're trying to do.

I have the next base request class, which being extended by all my next custom request classes.
class BaseRequest extends FormRequest
{
    public $message;

    protected function failedValidation(Validator $validator)
    {
        throw (new ValidationException($validator))
                    ->setErrorMessage($this->message ?? Errors::REQUIRED_FIELDS)
                    ->errorBag($this->errorBag);
    }
}

My application it's an SPA (without session), so i just catch ValidationException in my middleware, and make special json response in case of validation error. Should i write my custom ValidationException class, instead of using App\Exceptions\ValidationException?

I think I know what the problem is. If you're making API requests and you're hitting the invalid method of the exception handler, it means you're not sending the application/json accept header in your requests. When you do, the handler will call invalidJson and not make use of withInput because it's indeed, stateless.
https://github.com/laravel/framework/blob/6.x/src/Illuminate/Foundation/Exceptions/Handler.php#L258
Can you check if you're sending the proper headers with your API requests?

Yes, my API requests had "Accept: /" header. It seems that it was a source of a problem. I have just tested it - yeah, it works! Thanks a lot, i think that issue can be closed.


[WIP] Halo regions + boundary conditions overhaul and bug fixes

This PR:

adds a NoPenetration boundary condition, addressing #328.
converts some of the boundary condition structs to NamedTuples, where appropriate, paving the way for more generalization / code reduction
overhauls the fill_halo_regions! function to dispatch on boundary condition type, partially addressing #307
fixes bugs in the halo filling algorithm, addressing #328

What's left to do

[ ] use halo regions for z boundary conditions, eliminating if-statements once and for all in operators and paving the way for a triply periodic model
[x] convert turbulence closure operators / diffusivities to use OffsetArrays / halo regions

Pretty big PR! Will have a closer look in a bit.

GPU tests pass except for some issue with the NetCDF output writer and time_to_write.

Got rid of the if statements in the operators and closure operators which felt good (we should really merge the two sets of operators in PR #283).
Had to do some extra halo filling and index gymnastics to get all the tests to pass again since we now have z-halos but almost everything works (regression passes so at least we know the numbers haven't changed).
A few turbulence closure tests are now failing but I couldn't trace the issue, must be a halo issue. The CI logs will probably give more info but it's test_constant_isotropic_diffusivity_fluxdiv and test_anisotropic_diffusivity_fluxdiv.
It's the z part that fails
∂ⱼ_2ν_Σ₃ⱼ(2, 1, 1, grid, closure, U...) == 6ν

Awesome, thanks for the great progress @ali-ramadhan! I’ll take a look and try to fix up the errors tomorrow

@ali-ramadhan if tests pass and everything looks good to you I think this is ready to merge.

Running GPU tests on Google Cloud.


Update AutoRest C# version to 3.0.0-beta.20230412.2

Update AutoRest C# version to 3.0.0-beta.20230412.2

Besides the management plane API changes, this also changes the behavior of data plane such that null non-nullable properties are simply ignored. Looking at Azure/autorest.csharp#3029, there's no reason given as to why this is changed. @KrzysztofCwalina Krzysztof Cwalina FTE or @tg-msft Ted Glaza FTE care to weigh in? Our generated code has long done this to avoid surprises. I don't think we should revert that without further discussion.

If I don't remember incorrectly, @KrzysztofCwalina is fine with this change, @m-nash can further confirm this.

Besides the management plane API changes, this also changes the behavior of data plane such that null non-nullable properties are simply ignored. Looking at Azure/autorest.csharp#3029, there's no reason given as to why this is changed. @KrzysztofCwalina or @tg-msft care to weigh in? Our generated code has long done this to avoid surprises. I don't think we should revert that without further discussion.

Hi @heaths we have been reviewing and discussing this for quite a time. Here are some of them:

These checks are checking if the service's behavior aligns with their swagger (whether x-nullable is correctly honored). This is the case that we are taking the responsibility which the service or swagger tooling should catch (other SDKs do not have this check at all). After discussion, we decide to let the "live validation" component on the swagger validation side to take this responsibility. Here is an issue to track that: https://github.com/Azure/azure-rest-api-specs/issues/23217. Therefore we are not just removing the checks, we are migrating the checks to a more suitable place.
These checks only work in DEBUG mode, which possibly does not affect the customers a lot, but we have met tons of troubles when either our side or the service team side when they are writing test cases. Considering the dotnet language does not really distinguish the undefined (when the property is absent) and null (something like "foo": null in response), it offers more troubles to us than benefits because when an issue happens around this, we really do not have a good way to mitigate it. directives could mitigate but it is a liability of maintenance.
In addition, we get complains from internal customers that they could hit this exception in some SDKs when they are developing features using our track 2 SDKs when they are trying to debug the program. Therefore there are definitely impacts to customers if we have the checks.
@m-nash should have talked with @KrzysztofCwalina @tg-msft about this and they should have agreed.

@heaths We can undo this change if we come to a different decision, but we must merge this first to free up other DPG changes.

@ArcturusZhang you said,

@m-nash should have talked with @KrzysztofCwalina @tg-msft about this and they should have agreed.

Let's find out. The point of the checks was indeed to catch - during testing when developers are likely running Debug builds (customers do not get debug builds via nuget.org) - problems with this service. This was intended as backstop testing. I appreciate the ideal situation is that swaggers are 100% correct but that's not reality, unfortunately. That's why we also have tests that test the service behavior - not just the client code.
I'll start an email thread about this.


test: [M3-7667] - (Proof of Concept) Add tagging capability for Cypress tests

Description 📝
Proof of concept to give us the capability to apply arbitrary tags to our Cypress tests and run Cypress against subsets of tags.
Motivation
The main goal of this effort is to give us more flexibility in how/when we run our tests. M3-7667 and M3-8072 explore some of the challenges we're facing as our test suite grows and as more teams rely on Cloud and its tests for their own purposes.
Usage
Tagging Tests
When developing tests, we can tag them using cy.tag or cy.addTag. Tags can be applied to individual tests, or to multiple tests using beforeEach hooks. cy.tag will replace any tags that have already been set, while cy.addTag will add tags in addition to any that may have been set via hooks.
A quick example of what this looks like:
describe('a group of tests', () => {
  beforeEach(() => {
    cy.tag('feat:linodes', 'method:e2e');
  });

  it('tests a thing', () => {
    // This test will have 'feat:linodes' and 'method:e2e' tags.
  });

  it('tests a thing with mocks', () => {
    cy.tag('feat:linodes', 'method:mock');
    // This test will have 'feat:linodes' and 'method:mock' tags.
  });

  it('tests a last thing', () => {
    cy.addTag('feat:placementGroups');
    // This test will have 'feat:linodes', 'feat:placementGroups', and 'method:e2e' tags.
  });
});

Running Tagged Tests
By default, running yarn cy:run will run all tests regardless of how they're tagged. To specify which tests should run using tags, users can use the CY_TEST_TAGS environment variable:
echo "Run all the tests with 'feat:linodes' tag"
CY_TEST_TAGS='feat:linodes' yarn cy:run

Tags can be composed and negated:
echo "Run all the tests that have either 'feat:linodes' or 'feat:placementGroups' tags"
CY_TEST_TAGS='feat:linodes,feat:placementGroups' yarn cy:run

echo "Run all the tests that have 'feat:linodes' and 'feat:placementGroups' tags"
CY_TEST_TAGS='feat:linodes feat:placementGroups' yarn cy:run

echo "Run all the tests that do not have the 'feat:linodes' tag"
CY_TEST_TAGS='-feat:linodes' yarn cy:run

echo "Run all the tests that have either 'feat:linodes' or 'feat:placementGroups' tags, but not the 'method:e2e' tag"
CY_TEST_TAGS='feat:linodes,feat:placementGroups -method:e2e' yarn cy:run

Implementation
The tag utils work by modifying each test's Mocha context when Cypress executes the test, which happens before the test runs. Because cy.tag and cy.addTag are not part of Cypress's command queue, they can be called at any point in a test and will still apply.
Why Roll Our Own?
I opted to implement our own tagging mechanism rather than rely on an existing plugin or package. There are two packages that are relevant, and inspiration was drawn from each, but neither is perfectly suitable for our needs:

cypress-tags - This works by adding a TypeScript preprocessing step that searches for patterns in the test code itself to construct the tag graph, then strips out the tagging code and passes it to Cypress for execution. I didn't like this approach because a lot of time is already required to preprocess our specs via Vite and I wanted to avoid increasing our preprocessing time even further, and because of concerns that this method could have compatibility issues with our existing TypeScript/Vite preprocessing config and setup.
mocha-tags - This package isn't very well supported (last updated 7 years ago, no GitHub repo) and works by mutating the global it(...), describe(...), etc. functions exposed by Mocha. I did take a lot of inspiration from its tag querying/composing mechanism, however.

Downsides, Caveats, etc.
Performance
Because skipped tests are identified at runtime, Cypress must still preprocess all spec files included in its run, even if all the tests within the spec ultimately get skipped. Consequently, running the test suite with all tests skipped still takes approximately 10 minutes (when running locally on my machine) to account for the preprocessing.
Changes to cy.defer()
This implementation required changes to cy.defer() so that it consumes a function that returns a Promise rather than consuming a Promise directly. This is necessary because tests that get skipped still get executed by Cypress (without being run), so Promises that are initialized outside of Cypress's command queue get rejected when the test is skipped, resulting in errors and exceptions in certain cases (e.g. Axios requests getting aborted).
Reliance on cy.state()
This implementation requires use of the cy.state() function in order to access the tests' Mocha contexts, which is undocumented and could be changed. We're already relying on cy.state() (albeit to a much lesser extent) because it exposes the only method available to skip a Cypress test at runtime. Even if this implementation were to change, we can adapt as long as Cypress continues to expose the Mocha context.
Changes  🔄
List any change relevant to the reviewer.

Adds tag and addTag utils, as well as global aliases cy.tag and cy.addTag
Adds CY_TEST_TAGS environment variable to allow users to specify which tests to run using tags
Defines a test tag type with a couple tags, but this is mostly for demonstration purposes (we should probably put more thought into what types of tags we're actually going to want)
For testing/demonstration purposes only, applies some tags to the tests in create-linode.spec.ts

Preview 📷
Running Linode create tests that are tagged with the e2e tag:

Tag info that gets logged when Cypress starts, intended to help troubleshoot tag queries:

Error message when the user specifies an invalid tag query:

How to test 🧪

Confirm that running yarn cy:run runs all of the tests (you can stop after a few tests have run, no need to wait for the entire suite -- CI will help us double check this, too)
Confirm that running CY_TEST_TAGS='method:e2e' yarn cy:run -s "cypress/e2e/core/linodes/create-linode.spec.ts" runs only the tests in create-linode.spec.ts which are tagged with method:e2e
Feel free to experiment with more advanced tag queries and other combinations of spec files

As an Author I have considered 🤔
Check all that apply

[ ] 👀 Doing a self review
[ ] ❔ Our contribution guidelines
[ ] 🤏 Splitting feature into small PRs
[ ] ➕ Adding a changeset
[ ] 🧪 Providing/Improving test coverage
[ ] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[ ] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿  Providing accessibility support

Thanks @jaalah-akamai

I believe I read that cy.state is deprecated and will be removed in future releases (albeit it seems to have stuck around for several major releases). https://docs.cypress.io/guides/references/changelog#10-5-0

Not quite -- cy.state('subject') specifically was deprecated and replaced with a dedicated command, but cy.state() has not been deprecated. It is undocumented, but I haven't seen any indication that it's planned to be removed (it's used a lot by Cypress itself internally)

Merging despite test failure because the failing test is already present in develop, not introduced by this PR


make get-neighbor-transactions alias of get-neighbour-transactions

:gb: :heart: :us:

This breaks tab completion: JLine decides to shown both aliases for the same command instead of completing to one of those.


[Story] Add add note

Epic: #18
Description
As a user I want to be able to write notes and save them, so I can view them later.
Tasks

[x] Create note model.
[x] Create note service.
[x] Create add note function.
[x] Create add note page.

Created add notes as part of the notes feature implementation, see:
https://github.com/KinaUna/Examplium/tree/master/Documentation/Code/Notes


Support patch release in studio

Summary

How did you test this change?

[ ] Test(s) added
[x] Manual testing (please provide screenshots/recordings)
[ ] No testing (please provide an explanation)

Create patch
https://github.com/finos/legend-studio/assets/87973126/2a660f3f-d939-44ea-9d27-42d8e9bbd9ae
Create patch workspace
https://github.com/finos/legend-studio/assets/87973126/1cd75215-cb06-4e3f-8846-fb14348b87da
Do patch release

Video Comments:
when creating a patch with workspace, seems like we are missing feedback after hitting create. Could we do loading indicator + some kind of message, Creating Patch... Creating workspace... etc.

Video Comments: when creating a patch with workspace, seems like we are missing feedback after hitting create. Could we do loading indicator + some kind of message, Creating Patch... Creating workspace... etc.
When creating workspace from the welcome screen. Could we add a descriptor for workspace source. We can say something about using only when working toward a patch release.

Done


Improve websocket doc in container exec

At least for me, it wasn't clear that one websocket connection per file descriptor was needed to run the command.

This pull request didn't trigger Jenkins as its author isn't in the whitelist.
An organization member must perform one of the following:

To have this branch tested by Jenkins, use the "ok to test" command.
To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

Thanks!


add print message button

I want to add a button to print in the message component. can anyone help?


DateRangePicker - Picker disappearing from the dom

Hi,
I'm using DateRangePicker and according to the doc, I'm unable to find a way to avoid the calendar to disappear when inputs are not focused.
I tried to work with the onClose fn but not working.
I saw that the Calendar is removed from the dom, I don't want that...
Any idea or some props I didn't see ?
[Edit] For now, I forced the props/state isDateRangePickerInputFocused to true in the component/DateRangePicker.

@davidvenin Removing the picker from the DOM is intentional behavior (for performance reasons). If you want the picker to always be open, you could have your onFocusChange method look like:
(focusedInput) => {
  this.setState({ focusedInput: focusedInput || START_DATE });
}

Maybe if you gave more context on your usecase, it might make sense to make it a feature. :)


Dataset release plan

Nice work! However, I noticed that there is currently no publicly available dataset for download. Would it be possible to make the dataset open and accessible?

Yes, we will release the data at varying levels of pre-processing so you can use it to reproduce the results, play around with GNN architectures, or evaluate a completely different model using the structures split into receptor/ligand(s).

Great!  When can we expect the dataset to be released?

Yes, we will release the data at varying levels of pre-processing so you can use it to reproduce the results, play around with GNN architectures, or evaluate a completely different model using the structures split into receptor/ligand(s).

Great work! Please release the data as soon as possible!

Enlightening work!Expecting the  publishment of the dataset!


OCI compliant gsc

Hey there, just a wondering dev interested in unikernels but I was reading on your project's efforts to make unikernel containers and was wondering why not make an OCI-compliant base image from graphene(gramine?) that way it can take advantage of the existing ecosystem of available tools. Alternatively, if graphene dynamically adds only the necessary OS libraries required by a specific application to run, why not make a build system plugin for existing CI/CD pipelines that wraps the deployed app in a OCI-compliant, graphene unikernel that would then get run?
This is all just a suggestion, I don't have the proper expertise on LibOSs nor do I know your internal priorities (it seems SGX is high on that list) to know why you're making the design decisions you are.

why not make a build system plugin for existing CI/CD pipelines that wraps the deployed app in a OCI-compliant, graphene unikernel that would then get run

This is a good suggestion and definitely something that we will add at some point to Graphene. There is no specific reason why we're using an ad-hoc Python-based tool (our "GSC" tool) instead of writing a plugin for some existing CI/CD framework. The only reason is: that was simpler and faster.
As you correctly mentioned, our top priority currently is making Graphene with Intel SGX to be production quality. This GSC tool is a quick way to add Graphene-SGX abilities to existing Docker images.

I understand but how about a graphene base image? Also, after further reading I notice graphene's roots are in Microsoft research's drawbridge project, is there (or more appropriately, will there be be) support for Windows guests?

Currently we don't have any client / party interested in Windows PAL, but if there appears one, then why not ;) Also, I heard that a @chiache's student once tried to implement it as part of some university research.

...is there (or more appropriately, will there be be) support for Windows guests?

There is currently no support for Windows backend. Note that "Windows guests" is not something that Graphene/Gramine aims to do: the guest app inside Gramine always executes as if it runs in the Linux environment.
So in Graphene/Gramine, it is like this:

The guest ("the inside of Gramine") is an app built for Linux.
The backend ("the outside of Gramine", aka "the host") is currently one of the: normal Linux, SGX enclave on Linux. Maybe in the future we'll add the Windows backend.

I understand but how about a graphene base image?

We have a way to build the Graphene/Gramine base image. But we currently don't host any pre-built Gramine image anywhere on the internet.

I understand but how about a graphene base image?

We have a way to build the Graphene/Gramine base image. But we currently don't host any pre-built Gramine image anywhere on the internet.

Oh well it would be be great if you did, that would make leveraging it even more appealing in the container space as images are bloated and insecure whereas a more minimal unikernel-based image could(would) solve that major issue so please consider releasing it!

Thanks for your replies


component css class

how to remove default css style in any component like BitButton? I want to add just my own css class not having default css class. when i add this Styled Button it has "bit-btn bit-btn-pri" class. but i dont want it.

@rh1376 Thanks for contacting us.
to change the appearance of the BitButton component you can use the Class and Style parameters of the component as shown in the demo page of the component here: https://components.bitplatform.dev/components/button#example2


Workflow not failing even when a step is failing

On this workflow:
https://github.com/IntelliTect/EssentialCSharp/actions/runs/6794843503/job/18471914305
It fails due to not being able to be able to push (shows in the action-sync-branches step). However, the workflow still appears successful. The workflow should show as failed in this case.

Thanks for bringing this up!
I think I know why this is happening. I created a bug fix branch I would appreciate if you could run to test this out.
- uses: levibostian/action-sync-branches@fail-early

If you find this works, I'll merge the fix.

Thanks for bringing this up!
I think I know why this is happening. I created a bug fix branch I would appreciate if you could run to test this out.

- uses: levibostian/action-sync-branches@fail-early

If you find this works, I'll merge the fix.

Great! I will try it in a bit!
Also, it seems like maybe the github token isn't actually being used? Is that true? There are permission errors that don't occur with other merge actions I've tested that shouldn't show up if the github token is being used properly.


Card width too long on non-title scraped links

Since the title scraper HTTPS is acting up, our links aren't being title scraped, forcing them to extend our cards farther than the max width.
This can be fixed with a predefined wordwrap and width CSS on the link text.
Issue provided by Alexis :)

This is important even though title-scraping has been fixed. There are actually title-scraped titles that are too long for the current card format.

Yeah this is a css bug.
To be completly honest, I gotta take some time to work on my android apps however. My code is terrible. Like really bad, and I have a lot of users that I've been neglecting. So android finally allows for promo codes, so I'll probably shoot promo codes to my paid apps for anyone who asked for my help, and then tell them to check out for the update :)

the fix in backToColumns. And should be in master actually...

This was already fixed in master, just never pushed to live. closing...


Fixup NotoNaskhArabic and NotoNaskhArabicUI

To fix #4:

[x] Raise top anchor on uni0773, uni0774
[x] Restore anchor and component positions in _1031, uni0622, uni0623, uni0625, uni0671, uni0672, uni08F1, uniFB51, uniFE88, uniFE88.rlig
[x] Disable component alignment in _1031, uni0622, uni0623, uni0625, uni0671, uni0672, uni08F1, uniFB51, uniFE88, uniFE88.rlig
[x] Add uniFBB9.restricted and use in uni06B8, uni06B8.fina, uni06D1, uni06D1.fina to match in Noto Naskh Arabic UI

@moyogo I'll review the changes today. Thanks


Remove dots from java package directory names

One odd issue I have always seen is that, when depending on ambry as a
library, intellij is unable to associate the source files with package
files even though both jars are present. I found that the reason for
this is because we include dots (.) in our package directory names
instead of the traditional way of having a separate directory for each
package name part.
This commit replaces the directory names using a script. It ignores directories that are already formatted correctly.
(e.g. com.github.ambry becomes com/github/ambry)
This is the script that I used is remove-dot-dirs.sh (in this PR):
#! /bin/bash

function mvdotdir() {
  OLDDIR=$(dirname $1)
  NEWDIR=${OLDDIR//./\/}
  if [ "$OLDDIR" != "$NEWDIR" ]
  then
    echo moving $1 to $NEWDIR
    mkdir -p $NEWDIR
    git mv $1 $NEWDIR
  fi
}

find -f **/src/*/java -type f | while read file; do mvdotdir "$file"; done

If there are merge conflicts after this is merged with other in-progress changes, this script can hopefully be used to resolve them. Also, if a following commit uses the old format, you can use this script to convert to the new folder naming scheme in one step.

Codecov Report

Merging #1433 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1433      +/-   ##
============================================
- Coverage     72.97%   72.96%   -0.01%
+ Complexity     7564     7563       -1
============================================
  Files           541      541
  Lines         42192    42192
  Branches       5296     5296
============================================
- Hits          30788    30785       -3
- Misses         9873     9875       +2
- Partials       1531     1532       +1

Impacted Files
Coverage Δ
Complexity Δ

...rc/main/java/com/github/ambry/account/Account.java
94.79% <ø> (ø)
30.00 <0.00> (?)

.../java/com/github/ambry/account/AccountBuilder.java
92.85% <ø> (ø)
13.00 <0.00> (?)

...m/github/ambry/account/AccountCollectionSerde.java
75.00% <ø> (ø)
4.00 <0.00> (?)

...main/java/com/github/ambry/account/AclService.java
0.00% <ø> (ø)
0.00 <0.00> (?)

.../main/java/com/github/ambry/account/Container.java
93.24% <ø> (ø)
42.00 <0.00> (?)

...m/github/ambry/account/ContainerBlobsResource.java
0.00% <ø> (ø)
0.00 <0.00> (?)

...ava/com/github/ambry/account/ContainerBuilder.java
96.82% <ø> (ø)
18.00 <0.00> (?)

.../ambry/clustermap/ClusterMapSnapshotConstants.java
0.00% <ø> (ø)
0.00 <0.00> (?)

...om/github/ambry/clustermap/ClusterParticipant.java
100.00% <ø> (ø)
1.00 <0.00> (?)

...n/java/com/github/ambry/clustermap/DataNodeId.java
66.66% <ø> (ø)
2.00 <0.00> (?)

... and 818 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d85df4...11971d7. Read the comment docs.

@zzmao rebased to fix conflicts.
 Most conflicts seemed to be resolved automatically by the rebase logic for me. git rebase master
To fix any new files added in your change run the script: ./remove-dot-dirs.sh


HDDS-11339. Publishing hadoop metrics immediately in Prometheus sink fills up SinkQueue quickly.

What changes were proposed in this pull request?
HDDS-11339. Publishing hadoop metrics immediately in Prometheus sink fills up SinkQueue quickly.
Two issues:
PrometheusServlet is being registered with BaseHttpServer when prometheus support is enabled and PrometheusServlet is being called every 15 secs by default as scraping interval and it publishes the hadoop metrics immediately. So if there are large number of metrics needs to be published in a very busy cluster, this makes SinkQueue gets filled up quickly and then sink cannot consume the given metrics and just dropped them outright.
A part from dropping , another issue is taking the object lock of MetricsSystemImpl class and before metrics actually being published, other threads keeps waiting to take the object lock. There was a recent issue came to highlight where in a busy cluster, there were ~ 190 threads BLOCKED just to acquire the lock of the  MetricsSystemImpl class. This makes Recon role unresponsive and after sometime JVM couldn't allocate sufficient memory and crashes with OOM. This prometheus and OOM issue is not related to Recon directly as this can happen with any role which is going to use Prometheus service in a busy cluster.
Solution: We need not to publish the metrics immediately by calling
DefaultMetricsSystem.instance().publishMetricsNow();
because a prometheus sink already have a mechanism to publish metrics every 10 secs by default using call back with timer event. So we need to remove the above code to publish immediately.
Below is the onTimerEvent callback:
org.apache.hadoop.metrics2.impl.MetricsSystemImpl#onTimerEvent
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11339
How was this patch tested?
This patch is tested manually by running a docker cluster using Prometheus support enabled and validates the metrics being published to prometheus instance.

@sumitagrawl kindly review.

Can you please elaborate on
because a prometheus sink already have a mechanism to publish metrics every 10 secs by default using call back with timer event. So we need to remove the above code to publish immediately.

Can you please elaborate on why the alternative will perform better.
because a prometheus sink already have a mechanism to publish metrics every 10 secs by default using call back with timer event. So we need to remove the above code to publish immediately.

Thanks @kerneltime for review. So when we start the MetricsSystem, in org.apache.hadoop.metrics2.impl.MetricsSystemImpl#start, we also start a timer and while starting a timer, we also schedule a timerEvent which gets called every 10 secs default period.

and as we can see in above screenshot of code, we are scheduling to call onTimerEvent every 10 secs which publishes the metrics already with immediate arg as false.
So we need not to publish the metrics immediately as we are doing in PrometheusServlet. This puts too much load on queue.

Thanks @devmadhuu for the patch. Verified that Prometheus gets updated metrics eventually. You might want to propose similar improvement in Hadoop:
https://github.com/apache/hadoop/blob/e4ee3d560bddc27a495cc9a158278a9c18276dd0/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/PrometheusServlet.java#L43
Sidenote:
Please share text as text, not screenshots. Plain text makes it easier to

read (especially for those with visual impairments)
reference (e.g. quote)
search

It also reduces size to be stored by GitHub.
Sharing code can be even better by using permalink URLs.

Thanks @adoroszlai for your review. For similar improvement in hadoop, can you kindly confirm the apache project under which we should create JIRA ?

confirm the apache project under which we should create JIRA

I think it should be a HADOOP issue.


Add schedule validation

Describe your changes
Depends on #452 Ready now that #452 is merged :)
Implements:

K01.FR.19
K01.FR.31
K01.FR.35
K01.FR.40
K01.FR.41

Does not implement:

K01.FR.20
K01.FR.34
K01.FR.43
K01.FR.45
K01.FR.48

These functional requirements rely on functionality in DeviceModel, the EVSE, or message handling that is not currently implemented in Everest.
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have made corresponding changes to the documentation
[x] I read the contribution documentation and made sure that my changes meet its requirements

No objections from a structural perspective. I spot checked some of the specifications and they seem fairly straightforward.
@drmrd @christopher-davis-afs are we tracking which of the specs are in various stages (not started, under development, in review, merged). I don't think we have an issue for each specification, and I want to make sure that they don't fall through the cracks.

We are implementing a process to comprehensively track the full requirements of the specs functional blocks and their corresponding implementations status for improved visibility. Our current plan is maintaining a markdown list that shows the overall progress, with each user story containing a subsection of the list as acceptance criteria. When a story is complete the markdown will be updated.

Looks good from my side!
Considering:

K01.FR.43
K01.FR.45
K01.FR.48

Could we include the SupplyPhases from the device model for Connector, EVSE and ChargingStation to validate the schedules?

Looks good from my side!
Considering:
* K01.FR.43

* K01.FR.45

* K01.FR.48

Could we include the SupplyPhases from the device model for Connector, EVSE and ChargingStation to validate the schedules?

What do you mean by include here?

Looks good from my side!
Considering:
* K01.FR.43

* K01.FR.45

* K01.FR.48

Could we include the SupplyPhases from the device model for Connector, EVSE and ChargingStation to validate the schedules?

What do you mean by include here?

The tests could request the SupplyPhases variables from the device model to be able to check the precondition for K01.FR.43, K01.FR.45 and K01.FR.43 and test for the requirement definition

The preconditions for those are:

K01.FR.43: When a SetChargingProfileRequest with a value for numberPhases is received AND the EVSE is of type AC AND the Charging Station cannot ensure that no more than the received numberPhases will be used...
K01.FR.45: When a SetChargingProfileRequest with a value for numberPhases is received AND the EVSE is of type AC AND the received numberPhases is NOT supported by the Charging Station and higher than the numberPhases that are supported by the Charging Station...
K01.FR.48: When a SetChargingProfileRequest with a value for phaseToUse is received AND the EVSE is NOT capable of switching the phase connected to the EV, which is indicated by ACPhaseSwitchingSupported not being implemented or defined as false AND the EVSE is NOT going to use the received phaseToUse...

K01.FR.48 requires checking ACPhaseSwitchingSupported on the EVSE via DeviceModel, and as far as we can tell there's not a way to know whether or not an EVSE is of type AC or not in the current Everest codebase. We also were not able to figure out how to get a variable on a specific EVSE via DeviceModel - when we last asked about it we were told that the device model functionality was not fully hooked up in everest since we need access to the charger state machine, which is also not hooked up. So I'm a little unsure what changes to make here given the DeviceModel functionality isn't really fleshed out.
Am I misunderstanding the question? Or did I misunderstand the answer to the DeviceModel question?

@couryrr-afs wrt https://github.com/EVerest/libocpp/pull/521#issuecomment-1989439687 can you please add a link to the markdown to this issue once it has been generated?

@shankari https://github.com/US-JOET/base-camp/issues/94

Contributes to #361


Backlog - Copy all research to company pages

I broke down this task into smaller ones and put them in the to do.

I'm going to close this issue since I broke it down into smaller tasks.


Quantile fiber test

What has been done? Why? What problem is being solved?
I didn't forget about

[x] Tests
[ ] Changelog
[ ] Documentation (README and rst)
[ ] Rockspec and rpm spec

Close #???

Close for #241


Map DSSP SS types to PROMOTIF SS types

Addresses RO-3382.

The provenance source for these transformed annotations is retained as DSSP.
_rcsb_polymer_instance_feature.type is transformed as follows:

HELIX_RH_AL_P, HELIX_RH_3T_P, HELX_RH_PI_P, HELX_LH_PP_P → HELIX_P
STRN → SHEET
TURN_TY1_P → TURN_TY1_P
BEND → BEND

_rcsb_polymer_instance_feature.feature_id is transformed to  _rcsb_polymer_instance_feature.type + an integer corresponding to the identifier of the specific _rcsb_polymer_instance_feature.type (e.g., HELIX_P1, BEND1, HELIX_P2, SHEET1, TURN_TY1_P1, SHEET2 etc.)
_rcsb_polymer_instance_feature.name is the same as before.

Curious if you've tested this at all yet?

Yes. I have tested it.


Check for copy object response content

Environment
Delta-rs version: all
Binding:  rust

Bug
Turns out S3 object copy call can fail and return 200 status at the same time: https://docs.aws.amazon.com/AmazonS3/latest/API/API_CopyObject.html#API_CopyObject_ResponseElements. We need to inspect the response content to decide whether the copy went through or not.

@houqp - do wee need to raise this issue upstream?


ui: fix table sort not working in results page

Description
fix table sort not working in the results page
This PR fixes #900
Checklist

[] DCO signed.
[x] Title of the PR starts with area name, e.g. meshery:, mesheryctl:, ui:.

Sure, I'll close this and create a new PR. Actually did branch off of this PR as it wasn't merged then.


Ismp Parachain should identify parachains with 6s slots

We currently hard code the expected slot duration for parachains which is used to calculate it's current timestamp. For parachains with async backing (like hyperbridge), this slot duration will instead be 6s. We should add some metadata about parachains which tell the ismp parachain consensus client what slot number that the parachain currently uses. This should be configured when the parachain is added to the pallet.

I do think, hyperbridge should only focus 6s slot time parachains. As the end of the day all parachains will upgrade

closed in #253


How can collect static on the installed_apps for dependency apps static files or admin pages?

Hello, i used the starter kit structure you created. When I wanted to work with this blueprint, I could not find how the deployment process should be set up. I have set "/assets/bundles" as static files myself, but I could not find how to collect dependencies of other installed_apps applications or admin panel dependencies. Thanks.

Set a STATIC_ROOT, then run a python manage.py collectstatic.
Excerpt from - https://github.com/jazzband/django-webpack-loader#how-to-use-in-production
How to use in Production
It is up to you. There are a few ways to handle this. I like to have slightly separate configs for production and local. I tell git to ignore my local stats + bundle file but track the ones for production. Before pushing out newer version to production, I generate a new bundle using production config and commit the new stats file and bundle. I store the stats file and bundles in a directory that is added to the STATICFILES_DIR. This gives me integration with collectstatic for free. The generated bundles are automatically collected to the target directory and synched to S3.
./webpack_production.config.js
var config = require('./webpack.config.js');
var BundleTracker = require('webpack-bundle-tracker');

config.output.path = require('path').resolve('./assets/dist');

config.plugins = [
    new BundleTracker({filename: './webpack-stats-prod.json'})
]

// override any other settings here like using Uglify or other things that make sense for production environments.

module.exports = config;

settings.py
if not DEBUG:
    WEBPACK_LOADER.update({
        'BUNDLE_DIR_NAME': 'dist/',
        'STATS_FILE': os.path.join(BASE_DIR, 'webpack-stats-prod.json')
    })

You can also simply generate the bundles on the server before running collectstatic if that works for you.


Remove migration cli code

[!WARNING]
As mention in the issue #2398 we have decided to drop the support of the v0.x.x flag format.
Before creating a pull request for that, please check in the main issue if is the right moment to do it.

After we have stopped releasing the go-feature-flag-migration-cli (see #2400), we can now safely delete the code of the migration-cli.
To do this we should delete everything that is under the cmd/migrationcli folder.

/assign-me
hii again, let me try this! I think it's relatively simple.


Or anything with a bright background, dark backgrounds don't work well with projector screens (which are usually white).

Defaulting to blue on white, it's more Elm-ish. =)


obsidian light mode difficult see vertical tabs view

@hdykokd

not correct

Ah, sorry. Not released yet.

I apologize for the inconvenience. I have released a fixed version as 2.4.1.


make tenant_id property

Fixes problems with API Container that use TenatAAAPI

This issue was migrated from an old repository: https://github.com/CiscoDevNet/catalystwan/pull/156


Expect to have changing a instead of c

https://github.com/mustafaertekin/js-training/blob/1718282caa4c66802a397954a3116fc0ae398509/js/app.js#L74

???

var processed = a + "D";


Enchanted CTA | Support a Slow Tap event - Mouse down for 1 second.

This would allow advanced users access to UX artifacts that otherwise would be hidden.

This would need to cancel the click and touch events.

NOTE: This facilitates "advanced" UX to coexist with beginner UX journeys. Hope this makes sense.

Lets do this now.

This is done in v2.5. This is a non-breaking change. This is a life cycle hook of the NeodigmEnchantedCTA component (setOnLongTap). It uses a global feature flag (N55_CTA_LONG_TAP).
Usage:
if( neodigmEnchantedCTA ) neodigmEnchantedCTA.setOnLongTap( function(){ alert("count to 1001 long tap"); }, "js-open-pup--countOn__1001")

This seems to be stable.


Show the results on the map

Just adding markers will crash the browser. Customise the marker to like dots (dot map?)

Will be working on this for the december hackday
cc @shvrm @geohacker


.golangci.yml  contains deprected linters and configuration options.

What happened?
.golangci.yml  contains deprecated linters and configuration options.
Example
$ make lint_provider
... ...
WARN [config_reader] The configuration option `run.skip-files` is deprecated, please use `issues.exclude-files`.
WARN [lintersdb] The linter named "megacheck" is deprecated. It has been split into: gosimple, staticcheck, unused.

Output of pulumi about

Additional context
$ go version
go version go1.22.5 linux/amd64

$ golangci-lint version
golangci-lint has version 1.59.1 built with go1.22.3 from 1a55854a on 2024-06-09T18:08:33Z

Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@heyzling thanks for opening the issue and contributing the PR!


az ad sp show seems not to be working as expected

When running the following command:
az ad sp show --id http://$SP_NAME

I will always get an error (below) if $SP_NAME is the service principal display name, and not its ID.

Service principal ... doesn't exist

The $SP_NAME variable contains the exact same display name as I see in the App Registrations in Azure AD.

When deploying a service principal via script, we do not have the service principal object ID prior to running the script, only the name we want to assign to the service principal (display name). Not only this used to work a few months back, as per the documentation  it should still work!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e99d25ff-03e2-e015-37f4-a29b59ec50d4
Version Independent ID: 1a8e88ed-72c7-fbe7-b0ad-68f23b3946cd
Content: az ad sp
Content Source: latest/docs-ref-autogen/ad/sp.yml
Service: active-directory
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

@jiasli for awareness

Azure CLI command az ad sp create-for-rbac doesn't create apps with identifierUris anymore (https://github.com/Azure/azure-cli/pull/18312), so showing an SP created by az ad sp create-for-rbac with identifierUris (http://<display-name>) doesn't work now. Please use the appId of the app or objectId of the SP in az ad sp show --id.

So, that is why my scripts stopped working :)  Thank you for the explanation! In the meantime, I was able to have my scripts work again by updating the az ad sp create-for-rbac command, to the following:
az ad sp create-for-rbac  --name $SP_NAME --id http://$SP_NAME
So I explicitly create the id I was using before #18312 when running the az ad sp create-for-rbac command

I don't think --id http://$SP_NAME will work, as az ad sp create-for-rbac doesn't take an --id argument:
> az ad sp create-for-rbac --name "myapp0819" --id "http://myapp0819"
unrecognized arguments: --id http://myapp0819

With Azure CLI, the only way to update identifierUris of an app is through az ad app create and az ad app update.
We don't recommend using identifierUris for simple apps (for example, those you use in Azure RBAC) because in the future AAD will require all URIs must be on verified domains. When the check is rolled out, your script will break again if the identifierUris don't meet the requirement, as described in https://github.com/Azure/azure-cli/pull/18312.

Indeed you are right, the solution I proposed does not work. Thanks for the information @jiasli


Segmentation fault (core dumped)

Thanks for your great work. When I am following the tutorial to reproduce the results, some problems are raised. I would be appreciated if you tell me how to fix this issue.
Step:
python train.py --cuda --corpus mimic-cxr --cache-data cache --epochs 32 --batch-size 24 --entity-match mimic-cxr_ner.txt.gz --img-model densenet --img-pretrained chexpert_densenet/model_auc14.dict.gz --bert-score distilbert-base-uncased --corpus mimic-cxr --lr-scheduler trans MIMIC_CXR_ROOT resources/glove_mimic-cxr_train.512.txt.gz out_m2trans_nll
Return:
Segmentation fault (core dumped)

I am not exactly sure what has caused the segmentation fault but one possibility is that you may need to update packages relating to CUDA/cuDNN (pytorch, cudatoolkit, and torchvision) so that they are compatible with your runtime environment.


NIFI-3055 StandardRecordWriter Can Throw UTFDataFormatException (1.x)

Remove function based on JDK source.
Add new function to find bytes based on RFC3629.
Add field name to log entry when field is truncated.

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x ] Is your initial contribution a single, squashed commit?

For code changes:

[x ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

New getCharsInUTF8Limit() function looks good to me.  Sorry about missing the license concern on the last PR.
PR executes as expected.  The WARN log message says "Truncating repository record value for field 'Attribute Value'!"  when an attribute value exceeds 65535 bytes.  Unfortunately, the actual name of the attribute is not available unless you go several levels up the stack.  Is this good enough or do you want to throw an exception higher up the stack to make that available?
+1 looks good to me.  I will let another review and merge, to get more eyes on this.


GH-38772: [C++] Implement directory semantics even when the storage account doesn't support HNS

Rationale for this change
The FileSystem implementation based on Azure Blob Storage should implement directory operations according to filesystem semantics. When Hierarchical Namespace (HNS) is enabled, we can rely on Azure Data Lake Storage Gen 2 APIs implementing the filesystem semantics for us, but when all we have is the Blobs API, we should emulate it.
What changes are included in this PR?

Skip fewer tests
Re-implement GetFileInfo using ListBlobsByHierarchy instead of ListBlobs
Re-implement CreateDir with an upfront HNS support check instead of falling back to Blobs API after an error
Add comprehensive tests to CreateDir
Add HasSubmitBatchBug to check if a test inside any scenario is affected by a certain Azurite issue
Implement DeleteDir to work properly on flat namespace storage accounts (non-HNS accounts)

Are these changes tested?
Yes. By existing and new tests added by this PR itself.

Closes: #38772

@Tom-Newton

@Tom-Newton @kou I pushed changes based on your feedback. I would love to merge it before tomorrow's release cut.

Could you check CI failures?
https://github.com/apache/arrow/actions/runs/7414494286/job/20175680211?pr=39361#step:6:3814
[ RUN      ] TestAzuriteFileSystem.DeleteDirContentsSuccessDirectory
/arrow/cpp/src/arrow/filesystem/test_util.cc:143: Failure
Expected equality of these values:
  info.type()
    Which is: FileType::Directory
  type
    Which is: FileType::NotFound
For path 'hfqilxw9uhk7xqbathiwbudo4ci9dp9w/0iav1y3m4u53d5wvtp8g2j5af1o4s694'

https://github.com/apache/arrow/actions/runs/7414494286/job/20175680211?pr=39361#step:6:3680
[ RUN      ] TestAzuriteFileSystem.DeleteDirSuccessNonexistent
/arrow/cpp/src/arrow/filesystem/azurefs_test.cc:1301: Failure
Failed
'fs()->DeleteDir(directory_path)' failed with IOError: Path does not exist 'go9qhglaypjhxnprrxc79a0e3xtceml1/bwumjdfql0n8hizvv1kd3jn75ucrlw4u'. Detail: [errno 2] No such file or directory

@kou done. These turned out to be Azurite-only tests that needed updating since the semantics are now different than what was assumed when the tests were written.


Windows "User Installs" don't get heap performance benefits

We opted into the Segment Heap (see: #2778) in order to get a significant performance boost on Windows. This was implemented by having the installer set the FrontEndHeapDebugOptions key during installation.
This works perfectly fine for system installs. For user installs, however, the Binary Ninja installer sets the registry key in HKEY_CURRENT_USER instead of HKEY_LOCAL_MACHINE because it doesn't have permissions to access HKLM.
It appears that the HKCU key is never checked (or possibly ignored?) by the loader, which means user installs of Binary Ninja do not get this performance benefit.
One workaround we could possibly add is an extra screen in the installer for user installs that says, "Click this button to install a registry key that gives performance benefits", and triggers UAC to add the HKLM key. That way, the user installer still doesn't require elevated privileges, but there's an easy option for user installs to get the registry key installed.
We could also just point people at this ticket and tell them to go set:
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Image File Execution Options\binaryninja.exe]
"FrontEndHeapDebugOptions"=dword:00000008

Ultimately, I feel this is a Windows bug (it really should check HKCU as well during load, unless there's a security concern I'm not aware of). But, it does affect users, and it's an unfortunate problem to have right before a "Performance"-focused release.

The new performance optimizations in 3.1 flip the situation around, and now the segment heap was measured at 68% slower analysis performance. We are instead disabling the segment heap.


Pandas to_parquet error : ArrowNotImplementedError: No support for writing chunked arrays yet.

While trying to save a Pandas DataFrame as parquet using pyarrow engine, I seem to be getting an error of ArrowNotImplementedError: No support for writing chunked arrays yet.
The error seems to occur when the dataframe goes above a certain size limit.
>>>df.shape
(317739, 35)
>>> df_2 = df[:200000]
>>> df_2.to_parquet('path_to_save',engine='pyarrow',compression='gzip')
# Runs without error.
>>> df_25 = df[:250000]
>>> df_25.to_parquet('path_to_save',engine='pyarrow',compression='gzip')
# ArrowNotImplementedError: No support for writing chunked arrays yet.

Error seems to be thrown from this function : parquet.py#270
I am guessing this is related to ARROW-232. Is there a way currently to overcome this limitation ? Or is it a completely different issue ?

@brahmbhattspandan you might be able to overcome this by doing a copy of the DataFrame: df_25 = df[:250000].copy().

Since the final goal is to save the original dataframe, I tried the copy() method but it still throws the same error.
>>>df.shape
(317739, 35)
>>> df_30 = df[:300000].copy()
>>> df_30.to_parquet('path_to_save',engine='pyarrow',compression='gzip')
# ArrowNotImplementedError: No support for writing chunked arrays yet.

@brahmbhattspandan ok, this is weird. Can you post the output of df_30.info() so that we could see the datatypes and the column layout of the DataFrame?

It looks like the problem is that a string column is overflowing the 2GB limit.  SO as @wesm  said, the issue might be due to string column overflowing.

This is tracked in https://issues.apache.org/jira/browse/ARROW-232, let's follow the issue there

Any progress on this?  Seems like it's fixed in pyarrow, but not in pandas yet.  I'm still getting the same issue.

what version of pyarrow is installed?

Actually, newer version of pyarrow and I get a different error:
ArrowCapacityError: BinaryArray cannot contain more than<PHONE_NUMBER> bytes, have<PHONE_NUMBER>

This is with:

pyarrow 0.13.0
pandas 0.24.2
python 3.6.8

This is fixed in master, should be working in the 0.14.0 release now


Update: ActiveState.ActivePerl version 5.28.1001

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.0 schema?

Resolves #30148

Microsoft Reviewers: Open in CodeFlow

Just sayin' ¯_(ツ)_/¯


[FEAT] Magento External Router drivers should use the Magento Query Cache token

:bulb: Feature request
Feature Name
Magento URL Resolver Query caching
The Desired Behavior
As a developer, I expect URL Resolution to be cached by Magento.
Your Use Case
Better performance.

Product get by URL needs to be cached

Fixed by https://github.com/graycoreio/daffodil/pull/1551


Chat

See https://github.com/TridentSDK/Trident/pull/53

Your code contains serious thread safety flaws and requires documentation.

@AgentTroll Help me out then! What can I do to make it thread-safe?

Documentation is done. :)


Nanopolish index faidx error

Hello!
I've been trying to run nanopolish index, and I have run into an error that says Error running faidx_build on </output/file>.fastq.fa.gz. The call that I am using is nanopolish index -d </path/to/raw/reads/> </path/to/fastq>. The FASTQ was generated using Albacore 2.0.2 and running that output through Porechop 0.2.2.
I haven't been able to find a solution to this looking through other issues, so any help would be great. Thanks!

Hi Barney,
In the instructions </path/to/raw/reads/> and </path/to/fastq> are placeholders that we use as an example. You should replace these with the actual name of your fast5 directory and the albacore output file.
I hope this helps!
Jared

Hi Jared,
I did actually use real global paths in my call! Sorry if that was confusing, I'm in the habit of removing the actual paths when I post online to avoid clutter.
~Barney

Ah, I see. Do you mind sharing the full command you ran and error message? Did nanopolish manage to write a file called </output/file>.fastq.fa.gz?

Yes, call was nanopolish index -d /media/amphora/zika-seq/usvi-library8-1d-2017-03-31/raw_reads/ /home/barneypotter/zika-seq/build/VI41.fastq and it did write a file called VI41.fastq.fa.gz.

Was VI41.fastq.fa.gz output to the working directory or /home/barneypotter/zika-seq/build/? I'm wondering whether this is a file path issue.

It was output to /home/barneypotter/zika-seq/build/.

What happens if you run samtools faidx /home/barneypotter/zika-seq/build/VI41.fastq.fa.gz?

When I run the above command:
samtools faidx /home/barneypotter/zika-seq/build/VI41.fastq.fa.gz
samtools: error while loading shared libraries: libhts.so.2: cannot open shared object file: No such file or directory

It looks like your samtools installation is broken, could you fix it and try again?
Once the file VI41.fastq.fa.gz is succesfully generated all nanopolish is doing is bulding an faidx of the file, using the same function call as samtools. I'd like to see whether the standalone version works or gives a more informative error message.

I reinstalled Samtools, the new error message says Could not build fai index /home/barneypotter/zika-seq/build/VI41.fastq.fa.gz.fai when I run faidx directly.

Can you run zcat /home/barneypotter/zika-seq/build/VI41.fastq.fa.gz | head and paste the output?

I ran that command, and the file appears to be empty.

That's the problem then, now the question is why is it empty. Is there anything in /home/barneypotter/zika-seq/build/VI41.fastq? The .fa.gz version should just be a copy with the qualities removed and compressed.

When I run cat /home/barneypotter/zika-seq/build/VI41.fastq | wc -l I see that there are 2,112,680 lines in the file and looking at it through head looks normal.

Do you get the same error every time you run the program, or is it transient? Have other data sets worked for you? Are you using the latest version of nanopolish?

I have found the same error every time that I ran the program. Unfortunately at this time I just have one dataset that I can work with, since we have only sequenced one library on 1D chemistry. I am using 0.8.1 because our server uses Anaconda as a package manager and that appears to be the latest version available through the package manager.

It would be great if you can try the most recent code to see if the error persists. Nanopolish automatically installs all of its dependencies so it should not be very difficult to compile.

After reinstalling and re-running, it looks like the same error is coming up. It looks like the output files are slightly different now—in particular there are no longer compressed .gz files being produced—but the same error message still comes up.

Can you send me VI41.fastq?

Yes, I can do that. Do you know a good way to send it to you? Github only lets me upload files up to 10MB as a reply, and even the manually compressed version is >200MB.

Can you host it on dropbox for a day or two?
On Wed, Dec 6, 2017 at 5:06 PM, Barney Potter<EMAIL_ADDRESS>wrote:

Yes, I can do that. Do you know a good way to send it to you? Github only
lets me upload files up to 10MB as a reply, and even the manually
compressed version is >200MB.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jts/nanopolish/issues/271#issuecomment-349790489, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAXxnwebqgxHUBChsRh-j9u6XI4p5DIPks5s9w_jgaJpZM4Qky_K
.

Yes, the file is up, both compressed and uncompressed in case gzip on my end is what is causing the issue. https://www.dropbox.com/sh/cfai459p8kuvgx4/AACLgfeq7OzW_sF-IsE0lvABa?dl=0

Hi Barney,
Thanks, that let me track down the problem. It seems something went wrong when you produced the fastq file as some of the reads have a path embedded within the quality string (heres the first read in the file):
@d2ef3ff1-de47-4c57-9291-77edbd6f8850 runid=ac92cc8958563afd4483dd036f08e0dedec23ff0 read=37886 ch=466 start_time=2017-04-01T16:07:32Z
GTCTTGATGAGGAACGGGGCATAGGGAAGATATGAGCTGGAATGGTGTTGACTCTTGCAGAACCCAGCACATGTCTAAAGTGACCAGCTAAGAATTGCATGTGTCCTCATTGTTGTGTTCCTATTGCTGGTGGTTGTCATACCTGGAGGCAGAAAAGCAAAAGATCTCCCCAGGACAACCAAATGTGGCAATCCATCATCATAGTGGCAGCAGTAGGTCACTACAGGCTTGATCCTGCCAATGAACTCGGATGATTTGGAGAGAACAAAGGTGACTATATCTAATAAGGAAGGAGAGGGAGGGGCAACCATACCAAGTTCTCAATGGACATTGACCTGCGGCCAGCCTCAGCTTGAGCCATCTATGCTGCCTTGACAACTTTCATTACCCCAACCGTCCAACATGCAGTGACACC
+
&++-**(*(*-+*&'+>D<9::478/466?>,*(''):.>CEE=89,+'*+:;4D4+())$,;)&(672:45,14,-31,.+-.?2-,(.-'-6.D0:;0,.)+<<9;?CF<>D9>@BA;)((,013131-.+<+)-BAD;@?73-*-7049=CA<*28D70+-.-,EB@,3:=:2;4319=+*'(*,*-1/52,-/29982*0.*015)7,-1(2-,+#%,'+(-8556311))')3-7.--:D>@716430*.>734101*:D=>F-,()+-1*-/=:;/:0-*(47259;5+),0,(2/*&(+=3F7900(4,23G9BD6H88AC>;6;314C=>='8B</+4<2621/home/barneypotter/zika-seq/data/usvi-library8-1d-2017-03-31/alba121/workspace(.%*9F@@?:799999=5B/-(1).+7D?>&71/8EF00)5644:380/2=;-/.-.+,','

(note the /home/ part)
This leads to a length mismatch between the sequence and quality string, which makes the FASTQ records invalid and skipped. If you fix the files it should be ok.
Jared


Add fast processor delays

Add optional 1uS delays to begin( ), read( ) and _shiftIn( ) to accommodate processors > 500 MHz.
Reduces no_interrupts time for slower processors.

Thanks for this PR,
Might take a few days before I have time to review.

@palmerr23
Very straightforward implementation, super => will merge it


Fix hangs when type invalid args at command-line

Issue #5533
Motivation
When we using command-line tools, it hangs after type an invalid args.
Modifications
We don't need to parse the command, just show the command usage.

This change was done in #3579 because the error message was very messy otherwise. It might be good to see if there's a way to fix the current issue without completely reverting the change.

@merlimat Thank you for your reminder.
I use another way to fix this problem. Please take a look.  Thanks

@zymap sorry that I didn't quite get here. why did the process hang?

@sijie It will hang when we using command-line tools. The process hangs because there has a RuntimeException thrown and we are not handling.
I found we exit the PulsarAdminTool by the System.exit. When we parse an unknown command it will throw a RuntimeException. We need a boolean value to check should we exit. When it threw an Exception, there is no value to return so it can not exit as usual.


[BUG] Edit button to manage link is not positioned properly

Has this bug been raised before?

[X] I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?
production on biodrop.io
Version of BioDrop (for example "v1.2.3")
v2.83.8
Description
The Edit button on the /account/manage/links page is not positioned correctly, which results in visual inconsistency and usability problem. This affects the user experience when attempting to manage links in their account.
Screenshots

Do you want to work on this issue?
Yes
If you want to work on this issue...
To fix this issue I will be changing the position of edit link/button using Tailwind CSS styles

Thank you for raising - this has been raised before.  This will be improved as part of the redesign process which is coming up, so I will close this for now.


Remove currencies from bitcoin formatter

Fixes #524.

Hello just thimking out loud here... why not requiring bitcoin currencies instead and not the interface and remove the fraction argument?

The fraction argument is how to format the Bitcoin, e.g. display cents or not. It is a different concept than the subunits of the currency.

Well, technically it is a BC break. I would rather make it optional and trigger a deprecation error when something is passed.


Don't know if this has already been requested or if the feature already exists (someone let me know if it does please0 but the ability to remap keys for specific applications - like shortcuts - would be nice

You can go to the keyboard Manager and Remap a shortcut to a key, so you can create a shortcut to open the application, then remap the shortcut to a key. But, the keyboard Manager has some bugs, and may not behave properly, so just be careful!!

Thank you for reporting it. Tracked by https://github.com/microsoft/PowerToys/issues/6756