Cannot see defaultInterpreterPath kernel when selecting kernel ("Python is not installed.").

Applies To

[X] Notebooks (.ipynb files)
[ ] Interactive Window and/or Cell Scripts (.py files with #%% markers)

What happened?
When running an .ipynb file, not all kernels are shown to be selected. In particular, the kernel in the settings.json corresponding to key "python.defaultInterpreterPath" is not available. When executing a cell with the kernel that is available, a prompt pops up and states that python must be installed.
VS Code Version
Version: 1.65.2 (Universal) Commit: c722ca6c7eed3d7987c0d5c3df5c45f6b15e77d1 Date: 2022-03-10T14:33:49.188Z (5 days ago) Electron: 13.5.2 Chromium: 91.0.4472.164 Node.js: 14.16.0 V8: 9.1.269.39-electron.0 OS: Darwin x64 20.6.0
Jupyter Extension Version
v2022.2.1030672458
Jupyter logs
Not sure how to do this step.

Coding Language and Runtime Version
No response
Language Extension Version (if applicable)
No response
Anaconda Version (if applicable)
No response
Running Jupyter locally or remotely?
Remote

Closing as needs more info. Please reopen if you can provide the logs and the problem still reproduces.


ANCM: Inprocess: Usability: Need to write an event error about that standard log file can't be generated if IISExpress is started with console window

According to the below code, we don't support the standard log feature when IISExpress is started with console window. I think we should add an warning event when this happen so that users can figure out why the standard log file is not generated.
Repro step:

Start app with IISExpress in inprocess mode from command window with enabling stdoutLogEnabled="true"
Send a request

EXPECTED:
Log file is generated. Or, we should explain why log file is not generated.
ACTUAL:
No log file is generated.
            {
                // The process has console, e.g., IIS Express scenario

                if (_wfopen_s(&m_pStdFile, m_struLogFilePath.QueryStr(), L"w") == 0)
                {
                    // known issue: error info may not be capture when process crashes during buffering
                    // even we disabled FILE buffering
                    setvbuf(m_pStdFile, NULL, _IONBF, 0);
                    _dup2(_fileno(m_pStdFile), _fileno(stdout));
                    _dup2(_fileno(m_pStdFile), _fileno(stderr));
                }
                // These don't work for console scenario
                // close and AllocConsole does not help
                //_wfreopen_s(&m_pStdFile, struLogFileName.QueryStr(), L"w", stdout);
                // SetStdHandle(STD_ERROR_HANDLE, m_hLogFileHandle);
                // SetStdHandle(STD_OUTPUT_HANDLE, m_hLogFileHandle);
                //*stdout = *m_pStdFile;
                //*stderr = *m_pStdFile;
            }

does the ANCM log the error if IISExpres was started as background process?

I think this is expected behavior. If you are running IIS Express in the foreground (in a terminal), then std logs should be printer there.

This is a doc bug.


Packages not being recognized by winget: what to do?

Brief description of your issue
I have some packages installed which are also available from winget, but aren't picked up by it. winget list for those packages yields
Name                                          ID                                                   Version          Source
---------------------------------------------------------------------------------------------------------------------------
MyHeritage Family Tree Builder                Family Tree Builder                                  <IP_ADDRESS>36
Google Play Spiele (Beta)                     GooglePlayGames                                      23.9.1265.3
ROCCAT SWARM                                  InstallShield_{6FB8005D-F942-4BFB-AD75-5DA08E5454D9} 1.94.330

At least that's what I'm assuming because it doesn't change the ID to the winget one (which it does for all the ones with winget under Source).
What would I have to change in the manifest to make that work? Unfortunately, I don't know at all how the matching of local packages to winget manifests is handled by winget.
I don't really need a fix on the winget side, I'm rather curious in how the matching process works and how I can fix it for specific packages.
Steps to reproduce
Install one of the packages affected
Expected behavior
Winget recognizes them
Actual behavior
Winget doesn't recognize them
Environment
Windows: Windows.Desktop v10.0.25967.1000
System architecture: X64
Package: Microsoft.DesktopAppInstaller v1.21.2771.0

PackageName should match the Name shown in Control Panel
Publisher should match the Publisher shown in Control Panel
PackageVersion should match the version shown in Control Panel
PackageID should match the GUID from the registry entry - you can use the function below to find product codes
function Get-ARPTable {
  $registry_paths = @('HKLM:\Software\Microsoft\Windows\CurrentVersion\Uninstall\*','HKLM:\Software\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall\*', 'HKCU:\Software\Microsoft\Windows\CurrentVersion\Uninstall\*', 'HKCU:\Software\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall\*')
  return Get-ItemProperty $registry_paths -ErrorAction SilentlyContinue |
      Where-Object { $_.DisplayName -and (-not $_.SystemComponent -or $_.SystemComponent -ne 1 ) } |
      Select-Object DisplayName, DisplayVersion, Publisher, @{N='ProductCode'; E={$_.PSChildName}}, @{N='Scope'; E={if($_.PSDrive.Name -eq 'HKCU') {'User'} else {'Machine'}}}
}

PackageName should match the Name shown in Control Panel
Publisher should match the Publisher shown in Control Panel
PackageVersion should match the version shown in Control Panel
PackageID should match the GUID from the registry entry

Ohh thanks, now it all makes sense. I thought those attributes were just the same ones as in the folder structure/the Package Identifier. Now I can fix those.

@Trenly Just two more questions:

Where should I put PackageID? I cannot find it in the manifest schemas.

If the German package name is different from the English one, should I just add a new locale file where everything is the same except for the PackageName?

@Trenly Just two more questions:

Where should I put PackageID? I cannot find it in the manifest schemas.
If the German package name is different from the English one, should I just add a new locale file where everything is the same except for the PackageName?

PackageID is the PackageIdentifier, I mistakenly used the shorthand
Yes, adding a new locale file would be a good start. If there are separate installers for English and German, then adding a new installer node and using AppsAndFeaturesEntries would be the better option

PackageID is the PackageIdentifier, I mistakenly used the shorthand

Yeah, I thought so, but isn't the PackageIdentifier the winget identifier of the package and not its GUID?

Yes, adding a new locale file would be a good start. If there are separate installers for English and German, then adding a new installer node and using AppsAndFeaturesEntries would be the better option

Thanks.

PackageID is the PackageIdentifier, I mistakenly used the shorthand

Yeah, I thought so, but isn't the PackageIdentifier the winget identifier of the package and not its GUID?

I am so sorry. I'm on too few hours of Sleep.
I've been saying PackageID when I really mean ProductCode

PackageID is the PackageIdentifier, I mistakenly used the shorthand

Yeah, I thought so, but isn't the PackageIdentifier the winget identifier of the package and not its GUID?

I am so sorry. I'm on too few hours of Sleep. I've been saying PackageID when I really mean ProductCode

Ahh, that makes sense now. And no need to be sorry, thanks for all of your help and sleep well. 😴😄


Upgrade wal-g to 1.1.1

Upgrade wal-g to 1.1.1, cleanup old binaries.

Looks reasonable to me, but I assume it still needs to be tested.

@timabbott: This has been tested now, and seems to work fine.

Merged, thanks @alexmv!


[v1.x] [MAC] test_operator.test_index_copy causes bus error, possible segfault

Description
This only happens on my Mac on v1.x. The same test on v2.0 runs and passes. I can also see that the same test succeeds on  centos-cpu CI.
Other posts for this type error i found online suggest possible segfault as an underlying problem.
To reproduce
nosetests tests/python/unittest/test_operator.py:test_index_copy
Environment
OS: Catalina: 10.15.6
clang --version:
Apple clang version 12.0.0 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin19.6.0
Thread model: posix
What have you tried to solve it?
The bus error is thrown at this line: https://github.com/apache/incubator-mxnet/blob/8dbed966e35b979d8f770b0d5b0ec9f707b3a2f1/tests/python/unittest/test_operator.py#L5711
Commenting out https://github.com/apache/incubator-mxnet/blob/8dbed966e35b979d8f770b0d5b0ec9f707b3a2f1/tests/python/unittest/test_operator.py#L5709 prevents the error but then test fails at line 5711 when comparing gradents. The same is for line 5717 and subsequent assertions

@r3stl355 thanks for reporting the issue. Could you set environment variables DMLC_LOG_STACK_TRACE_DEPTH=150 MXNET_ENGINE_TYPE=NaiveEngine and run the same program again and share the stacktrace?

Thank you @szha , MXNET_ENGINE_TYPE=NaiveEngine did the trick, no more errors, I'm now going to read-up to understand what it does

@r3stl355 it forces the execution to be synchronous, and if it resolves the issue it means there's a race condition that needs to be resolved.


selfdrive: Increase typing in the selfdrive module.

Description Increase typing in the selfdrive module.

@pd0wm, are there any additional changes you would like for this PR? Thanks!

Did you figure out why mypy accepted those wrong types? If I can't trust mypy it makes reviewing this kind of PRs quite time consuming.

Yes, I believe I've tracked that down. EventName is defined in capnp and in my testing, I cannot get mypy to recognize any types from a capnp file. For any entity in a capnp file, mypy will allow you to treat it as any type you wish (which is what happened with my initial commit). I've not been able to find a place in openpilot or in any other open source repositories where capnp files are type checked. I'm not too versed in capnp so if this is incorrect, I would be thrilled to know how capnp types can be recognized by mypy.

Yes, I believe I've tracked that down. EventName is defined in capnp and in my testing, I cannot get mypy to recognize any types from a capnp file. For any entity in a capnp file, mypy will allow you to treat it as any type you wish (which is what happened with my initial commit). I've not been able to find a place in openpilot or in any other open source repositories where capnp files are type checked. I'm not too versed in capnp so if this is incorrect, I would be thrilled to know how capnp types can be recognized by mypy.

I don't think this is a capnp issue. This sounds more like mypy not being strict about things it doesn't understand.

Also in your first commit the function returned a Dict[str, Alert] instead of an EventName. If it replaces capnp stuff by any this still should have been caught, since surely it knows what a dict is.

Also in your first commit the function returned a Dict[str, Alert] instead of an EventName. If it replaces capnp stuff by any this still should have been caught, since surely it knows what a dict is.

I think this behavior can be enabled with the --warn-return-any flag in the .pre-commit-config.yaml file. For ambiguous situations like this it'd throw:
selfdrive/car/car_helpers.py:31: error: Returning Any from function declared to return "int"

I had a quick look and there are only 22 errors like this in 14 files.

--warn-return-any looks promising, thank you. I'm working through the 22 errors now and will update the PR once they're resolved.


Keyboard as web app

Added haptic feedback of virtual keyboard
Fixed haptic feedback of virtual gamepad
Added icon, styling, and manifest.json for virtual keyboard so that it can be used as standalone web app.

@miroof Hi dude, how are you ?
Could you please merge master branch in recalbox branch ?
I'll bump version in recalbox.
Thank you :wink:

Hi @rockaddicted,
I'm a bit busy in this beginning of the year but all is OK :) What about you ?
I took quickly a look and unfortunately it seems that a simple merge is not enough to keep the particularities of the Recalbox branch (I mean RecalBox logo). Maybe I'm wrong (and don't hesitate to say it) but I'm afraid that the great work of @roba91 has too many impacts to expect a simple merge.
So I can perform a simple merge but someone will have to work in order to add the RecalBox logo in the new version. I would like to do it but I leave in a few days for a 3 weeks break in Asia so I won't have the time :/
What do you think about that @rockaddicted ?
I take the opportunity to ask if someone of you @rockaddicted or @roba91 would accept to be added as collaborator of this project. @roba91, according to your contribution maybe you can help me to manage this repo ?
Have a good day,
Jérémy

Yup, sure. I mean it's not the biggest project. Therefore, I should be able to help you out.

@miroof I'm fine thx. About this project I'm busy too for the moment, and not really an expert with this kind of project.
But I can see with others recalbox's members team if someone is available to help you.

Hi @miroof you can add me as collaborator too, I ll help you to manage your project :)

Hi @MikaXII, and thank you a lot. You're now collaborator 🙂
Le mar. 24 janv. 2017 à 19:19, MikaXII<EMAIL_ADDRESS>a écrit :

Hi @miroof https://github.com/miroof you can add me as collaborator
too, I ll help you to manage your project :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/miroof/node-virtual-gamepads/pull/27#issuecomment-274889505,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIBcFGDTn8WOPbk7q-zk_hqjPIrqZMtks5rVkCkgaJpZM4LQIBN
.


NPM Install Vulnerabilities

(main) $ npm install
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
added 963 packages, and audited 987 packages in 26s
129 packages are looking for funding
run npm fund for details
18 vulnerabilities (9 moderate, 8 high, 1 critical)
To address issues that do not require attention, run:
npm audit fix
To address all issues possible (including breaking changes), run:
npm audit fix --force
Some issues need review, and may require choosing
a different dependency.
Run npm audit for details.
@dskja ➜ /workspaces/Hadesbot (master) $ npm install har-validator@latest
up to date, audited 987 packages in 2s
129 packages are looking for funding
run npm fund for details
18 vulnerabilities (9 moderate, 8 high, 1 critical)
To address issues that do not require attention, run:
npm audit fix
To address all issues possible (including breaking changes), run:
npm audit fix --force
Some issues need review, and may require choosing
a different dependency.
Run npm audit for details.
I have already all tried but nothing had worked...

Mabye try use npm install -g npm instead


Make table view default

nuvlaedge e2e tests seems to be broken

@0xbase12
Fixed it, forgot to update the selector from NuvlaEdge card layout to table view


OIDC updates

See issue #3590

I will create new PRs for changes mentioned in this PR. I will separate these into two: required https for redirects and support for refresh cookie.

see #4222

Closing as this has been fixed as part of #4222

@romain-grecourt https://github.com/helidon-io/helidon/pull/4222 fixed the "https for redirects" but not the "support for refresh cookie".
I think the support for refresh token is being discussed here https://github.com/helidon-io/helidon/issues/3590
This are all the items included in this PR:
https://github.com/helidon-io/helidon/issues/3590#issuecomment-966732557
I believe the code in here might still be relevant (maybe a starting point) for this item:

Added server side refresh. If you are using cookies and server side OIDC provider you run into issues when the access token expires. All javascript related calls from the client will fail due to expired token and js calls for SPA will not redirect to lean on OIDC Provider for new tokens. To solve this I saved the refresh token encrypted in a separate cookie and when access token used for the request is expired I refresh it and update cookies so there is no disruption to the client (assuming refresh token is still valid).


Unauthorized Error on implementation

after implementing and even passing hard coded values still get this error
val  statuas: false message:Not Authorized. Return with Reponse code : 500 value:0.0

Hi @noorfatima15 ,
Thanks for noticing, its been a while i havent worked on it, seems like apis are outdated. please do give me some time to update it.
Thanks.

@noorfatima15 Can you please check now! its fixed. Thanks


BLE stopped working after using ESP for long. (IDFGH-4562)

IDFv- 4.2
OS- Ubuntu
I have included BLE GATTC, GATTS and wifi in my project but the device BLE stops working if it is powered on for long (sometimes after an hour or 2 hour or 4 hours randomly). SDK config is attached below. I have raised similar issue but with different IDFv 4.3 https://github.com/espressif/esp-idf/issues/6073#issuecomment-743028301 . I have downloaded the latest master of v4.2 but in this facing the BLE stuck issue which is different from https://github.com/espressif/esp-idf/issues/6073#issuecomment-743028301. It is difficult to get BLE logs of a particular time where it stops working but I am trying to get it ASAP.
sdkconfig.txt

I am getting series of ELx40 and ELx200 and device got stuck after these. BLE stopped working and also other task stopped working.
2021-01-16 21:51:14ELx200
2021-01-16 21:51:14ELx200
2021-01-16 21:51:14ELx200
2021-01-16 21:51:15ELx200
2021-01-16 21:51:15ELx200
2021-01-16 21:51:15ELx200
2021-01-16 21:51:15ELx200
2021-01-16 21:51:15ELx200
2021-01-16 21:51:15ELx200
2021-01-16 21:51:15ELx200
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15scan_evt timeout
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15scan_evt timeout
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15scan_evt timeout
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15scan_evt timeout
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15scan_evt timeout
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15scan_evt timeout
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15scan_evt timeout
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15ELx40

I am getting series of ELx40 and ELx200 and device got stuck after these. BLE stopped working and also other task stopped working.
2021-01-16 21:51:14ELx200
2021-01-16 21:51:14ELx200
2021-01-16 21:51:14ELx200
2021-01-16 21:51:15ELx200
2021-01-16 21:51:15ELx200
2021-01-16 21:51:15ELx200
2021-01-16 21:51:15ELx200
2021-01-16 21:51:15ELx200
2021-01-16 21:51:15ELx200
2021-01-16 21:51:15ELx200
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15scan_evt timeout
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15scan_evt timeout
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15scan_evt timeout
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15scan_evt timeout
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15scan_evt timeout
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15scan_evt timeout
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15scan_evt timeout
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15ELx40
2021-01-16 21:51:15ELx40

@ROYMURLI Can you please share the commit head ? I can see the fix being merged into release/v4.2 with commit id: 98a53689. Can you please confirm the issue was apparent even with this commit ?

@ROYMURLI Can you please share the commit head ? I can see the fix being merged into release/v4.2 with commit id: 98a53689. Can you please confirm the issue was apparent even with this commit ?

Hi @prasad-alatkar  The screenshot is attached here.
IDFv- v4.2-238-g8cd16b60f

Hi @prasad-alatkar  The screenshot is attached here.
IDFv- v4.2-238-g8cd16b60f

@ROYMURLI Please call this function after esp_bt_controller_enable()
extern int esp_bt_controller_set_log_level(int level);
esp_bt_controller_set_log_level(0);

Then test the device got stuck issue.

@ROYMURLI Thanks for reporting, would you please help if any updates for this issue? Thanks.

@Alvin1Zhang , Currently not facing this issue after updating the above lines in my code. Thanks for your help.


manifests: Update gateways and prefix

Closes #30
Closes #31
Updates the manifests to:

Explicitly set the Gateways
Use the updated backend prefix for the app, after changes the Istio files https://github.com/kserve/models-web-app/pull/27

Switching to the release-0.7 branch, to include the changes in the KF release as well.

/lgtm


dwallet-helios: add eth light client interface for dwallet network

added eth light client interface for using with dwallet network.
inserted some changes to fix breaking changes in ethers crate, introduced in version 2.0.14.
removed Cargo.lock from repo

Please explain what logic was added, and why.


Blackline- Check result when the name of the company is entered in the search bar

Step 1:    Open the URL in the browser (https://peviitor.ro/)
Expected result : you can see the homepage of the website and you can see the searching bar

Step 2 :  Go to the search bar and see if it is editable by clicking inside of it.
Expected result : The search bar is editable and functional and you can write any text inside it.

Step 3 : Type "Blackline" (the name of the company) inside the search bar and press enter or on the button "Cauta"
Expected result : You should be redirected on the page where you can see all the jobs of the company.


Kindly help me sort out this errors

(base) C:\Users\bhushan.pawar\my project\me>python s5p-request.py L2_NO2_
Traceback (most recent call last):
File "C:\Users\bhushan.pawar\my project\me\s5p-request.py", line 15, in
from s5p_tools import (bounding_box,convert_to_l3_products,get_filenames_request,request_copernicus_hub,)
File "C:\Users\bhushan.pawar\my project\me\s5p_tools_init_.py", line 2, in
from .preprocess import bounding_box, convert_to_l3_products
File "C:\Users\bhushan.pawar\my project\me\s5p_tools\preprocess.py", line 6, in
import geopandas
File "C:\Users\bhushan.pawar\Miniconda3\lib\site-packages\geopandas_init_.py", line 1, in
from geopandas._config import options  # noqa
File "C:\Users\bhushan.pawar\Miniconda3\lib\site-packages\geopandas_config.py", line 126, in
default_value=_default_use_pygeos(),
File "C:\Users\bhushan.pawar\Miniconda3\lib\site-packages\geopandas_config.py", line 112, in _default_use_pygeos
import geopandas.compat as compat
File "C:\Users\bhushan.pawar\Miniconda3\lib\site-packages\geopandas_compat.py", line 202, in
import rtree  # noqa
File "C:\Users\bhushan.pawar\Miniconda3\lib\site-packages\rtree_init.py", line 9, in
from .index import Rtree, Index  # noqa
File "C:\Users\bhushan.pawar\Miniconda3\lib\site-packages\rtree\index.py", line 6, in
from . import core
File "C:\Users\bhushan.pawar\Miniconda3\lib\site-packages\rtree\core.py", line 75, in
rt = finder.load()
File "C:\Users\bhushan.pawar\Miniconda3\lib\site-packages\rtree\finder.py", line 67, in load
raise OSError("could not find or load {}".format(lib_name))
OSError: could not find or load spatialindex_c-64.dll

Sorry for the late answer. This issue does not seem related to this project, but rather with your installation of geopandas. Perhaps you can take a look at this issue.

Thanks dear to convey me the details , i will try to correct it ASAP


Adds Makefile to support macOS icns building and installation

I swear it started small! I don't like that it generates some of the files twice when it could just copy them but it runs so fast, especially when running in parallel with -j, that I didn't bother with further optimization.
There's probably room for a GHA config but this is enough to satisfy me.

Btw this is based on my make-icons script.

How to codesign with self-signed: https://stackoverflow.com/questions/27474751/how-can-i-codesign-an-app-without-being-in-the-mac-developer-program/27474942

Thanks a lot for you pull request. It helped me a lot. I finally got the mac to check it. However I found that the icon looked awful on mac and I completely reworked it. Now it differs little bit from the icons for other operating systems in margins. I'm not familiar with makefiles so I've just updated the build script.


Add Infinum

Please review our Contribution Guidelines to ensure your changes abides by it.
Review your changes and complete the checklist below.

[ ] Company name
[ ] Company description
[ ] Company location
[ ] GitHub link
[ ] How Elixir is used

@vrosancic could you rebase your PR so I can merge?  Thank you kindly 😁

@doomspork Done!

Thank you @vrosancic 😀


[ARM Query] Add detailed job execution to api

ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

[!NOTE]
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

 Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

 Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)

For help with Step 2 / "ARM review", see https://aka.ms/azsdk/pr-arm-review.

 Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
[x] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@ms-zhenhua This PR is ready for review. Can you remove ARMChangesRequested label? I don't have access.

Hi @lihaMSFT , this PR LGTM, but the code style must be fixed:
specification/app/resource-manager/Microsoft.App/preview/2024-02-02-preview/Jobs.json(1,1): error : Code style issues found, please run prettier.

npm install
npx prettier --write specification/app/resource-manager/Microsoft.App/preview/2024-02-02-preview/Jobs.json

/pr RequestMerge


txn_box: Add it as an experimental plugin.

This PR adds Alan's Transaction Box as an Apache Traffic Server plugin.
Notes:
txn-error and txn-debug are disabled.  Rest of the tests are OK.
You can find @SolidWallOfCode  source repo  here

[approve ci]

[approve ci]

[approve ci]


vcpkg install error

Describe the bug
When trying to install opencv vcpkg install opencv[core]:x64-windows works, but vcpkg install opencv[core,contrib]:x64-windows throws

Error: Contains invalid characters. Only alphanumeric lowercase ASCII characters and dashes are allowed: opencv[core

Environment

OS:Windows 8.1 64 bit
Compiler: n.a.

To Reproduce
Steps to reproduce the behavior:

./vcpkg install opencv[core,contrib]:x64-windows
See error

Expected behavior
Opencv should be installed with the core and contrib modules
Additional context
Reinstalling vcpkg did not solve the issue.

It seems this is an issue with Powershell, i just used an msys terminal and it worked.

@IRelaxxx, I can't repro this issue, from the error, it looks ',' in opencv[core,contrib]:x64-windows parsed failed, it considered ',' as invalid characters in your Powershell.
For me, the Powershell version:
$psversiontable
Name                           Value

PSVersion                      5.1.14393.3053
....

@PhoebeHui I get a similar message, but just when doing a 'git pull' on the vcpkg repo. I'm not using Powershell, but the ordinary [elevated] command prompt.
remote: Enumerating objects: 131, done.
remote: Counting objects: 100% (131/131), done.

Receiving objects: 100% (233/233), 99.43 KiB | 1.12 MiB/s, done.
Resolving deltas: 100% (133/133), completed with 61 local objects.
From https://github.com/Microsoft/vcpkg
   c446b0621..fc135e20e  master     -> origin/master
Updating c446b0621..fc135e20e
Fast-forward
 ports/abseil/CONTROL                              |    2 +-
 ports/abseil/fix-config.patch                     |   26 +
 ports/abseil/portfile.cmake                       |    6 +-
 ports/boost/CONTROL                               |   28 +-
 ports/casclib/CONTROL                             |    2 +-
 ports/casclib/ctype_for_mac.patch                 |   15 +-
 ports/casclib/portfile.cmake                      |    4 +-
 ports/cgl/CMakeLists.txt                          |  143 ++
 ports/cgl/CONTROL                                 |    5 +
 ports/cgl/Config.cmake.in                         |    5 +
 ports/cgl/fix-c1083-error.patch                   |   30 +
 ports/cgl/portfile.cmake                          |   28 +
 ports/chartdir/CONTROL                            |    4 +
 ports/chartdir/Config.cmake.in                    |   21 +
 ports/chartdir/chartdir.h                         |    6 +
 ports/chartdir/portfile.cmake                     |   96 +
 ports/chartdir/usage                              |    4 +
 ports/cpprestsdk/CONTROL                          |   11 +-
 ports/fastcdr/CONTROL                             |    2 +-
 ports/fastcdr/portfile.cmake                      |    4 +-
 ports/fluidsynth/CONTROL                          |    4 +-
 ports/fluidsynth/force-x86-gentables.patch        |   34 +
 ports/fluidsynth/portfile.cmake                   |    3 +-
 ports/fmt/portfile.cmake                          |   28 +-
 ports/gppanel/00001-fix-build.patch               |   24 +
 ports/gppanel/CMakeLists.txt                      |   32 +
 ports/gppanel/CONTROL                             |    5 +
 ports/gppanel/portfile.cmake                      |   42 +
 ports/gppanel/usage                               |    4 +
 ports/json5-parser/00001-fix-build.patch          |   27 +
 ports/json5-parser/CONTROL                        |    5 +
 ports/json5-parser/portfile.cmake                 |   27 +
 ports/json5-parser/usage                          |    4 +
 ports/libguarded/CONTROL                          |    4 +
 ports/libguarded/portfile.cmake                   |   15 +
 ports/liblsl/CONTROL                              |    2 +-
 ports/liblsl/fix-install.patch                    |   13 +
 ports/liblsl/portfile.cmake                       |   11 +-
 ports/libwebp/0006-fix-dependecies-platform.patch |   16 +
 ports/libwebp/CONTROL                             |    2 +-
 ports/libwebp/portfile.cmake                      |    1 +
 ports/log4cpp/CONTROL                             |    5 +
 ports/log4cpp/fix-install-targets.patch           |   13 +
 ports/log4cpp/portfile.cmake                      |   36 +
 ports/magic-enum/CONTROL                          |    2 +-
 ports/magic-enum/portfile.cmake                   |    4 +-
 ports/magnum/004-khrplatform-include.patch        |   13 +
 ports/magnum/portfile.cmake                       |    1 +
 ports/minifb/CONTROL                              |    4 +
 ports/minifb/fix-arm-build-error.patch            |   40 +
 ports/minifb/fix-build-error.patch                |   25 +
 ports/minifb/fix-install-error.patch              |   54 +
 ports/minifb/portfile.cmake                       |   32 +
 ports/moos-ui/CONTROL                             |    4 +-
 ports/moos-ui/portfile.cmake                      |   19 +-
 ports/nmap/CONTROL                                |    4 +-
 ports/nmap/build.sh                               |   24 -
 ports/nmap/detect-crypto-library.patch            |   75 -
 ports/nmap/fix-msvc-prj.patch                     | 1986 +++++++++++++++++++++
 ports/nmap/fix-snprintf.patch                     |   39 +
 ports/nmap/fix-ssize_t.patch                      |   16 +
 ports/nmap/portfile.cmake                         |  219 ++-
 ports/opencv3/CONTROL                             |    2 +-
 ports/opencv3/portfile.cmake                      |    2 +-
 ports/openni2/CONTROL                             |    2 +-
 ports/openni2/portfile.cmake                      |   18 +-
 ports/orc/0004-update-tzdata.patch                |   15 +
 ports/orc/CONTROL                                 |    1 +
 ports/orc/portfile.cmake                          |    1 +
 ports/pcre/CONTROL                                |    2 +-
 ports/pcre/portfile.cmake                         |    2 +-
 ports/poco/CONTROL                                |    6 +-
 ports/poco/portfile.cmake                         |   11 +-
 ports/poco/unbundled_pdf.patch                    |   30 -
 ports/poco/use-vcpkg-libharu.patch                |   18 +
 ports/wpilib/CONTROL                              |    6 +-
 ports/wpilib/portfile.cmake                       |    5 +-
 ports/yaml-cpp/0002-fix-include-path.patch        |   13 +
 ports/yaml-cpp/CONTROL                            |    2 +-
 ports/yaml-cpp/portfile.cmake                     |   29 +-
 toolsrc/VERSION.txt                               |    2 +-
 toolsrc/src/vcpkg-test/stringview.cpp             |   17 +
 toolsrc/src/vcpkg/base/stringview.cpp             |    2 +-
 toolsrc/src/vcpkg/parse.cpp                       |   94 +-
 84 files changed, 3267 insertions(+), 373 deletions(-)
 create mode 100644 ports/abseil/fix-config.patch
 create mode 100644 ports/cgl/CMakeLists.txt
 create mode 100644 ports/cgl/CONTROL
 create mode 100644 ports/cgl/Config.cmake.in
 create mode 100644 ports/cgl/fix-c1083-error.patch
 create mode 100644 ports/cgl/portfile.cmake
 create mode 100644 ports/chartdir/CONTROL
 create mode 100644 ports/chartdir/Config.cmake.in
 create mode 100644 ports/chartdir/chartdir.h
 create mode 100644 ports/chartdir/portfile.cmake
 create mode 100644 ports/chartdir/usage
 create mode 100644 ports/fluidsynth/force-x86-gentables.patch
 create mode 100644 ports/gppanel/00001-fix-build.patch
 create mode 100644 ports/gppanel/CMakeLists.txt
 create mode 100644 ports/gppanel/CONTROL
 create mode 100644 ports/gppanel/portfile.cmake
 create mode 100644 ports/gppanel/usage
 create mode 100644 ports/json5-parser/00001-fix-build.patch
 create mode 100644 ports/json5-parser/CONTROL
 create mode 100644 ports/json5-parser/portfile.cmake
 create mode 100644 ports/json5-parser/usage
 create mode 100644 ports/libguarded/CONTROL
 create mode 100644 ports/libguarded/portfile.cmake
 create mode 100644 ports/liblsl/fix-install.patch
 create mode 100644 ports/libwebp/0006-fix-dependecies-platform.patch
 create mode 100644 ports/log4cpp/CONTROL
 create mode 100644 ports/log4cpp/fix-install-targets.patch
 create mode 100644 ports/log4cpp/portfile.cmake
 create mode 100644 ports/magnum/004-khrplatform-include.patch
 create mode 100644 ports/minifb/CONTROL
 create mode 100644 ports/minifb/fix-arm-build-error.patch
 create mode 100644 ports/minifb/fix-build-error.patch
 create mode 100644 ports/minifb/fix-install-error.patch
 create mode 100644 ports/minifb/portfile.cmake
 delete mode 100644 ports/nmap/build.sh
 delete mode 100644 ports/nmap/detect-crypto-library.patch
 create mode 100644 ports/nmap/fix-msvc-prj.patch
 create mode 100644 ports/nmap/fix-snprintf.patch
 create mode 100644 ports/nmap/fix-ssize_t.patch
 create mode 100644 ports/orc/0004-update-tzdata.patch
 delete mode 100644 ports/poco/unbundled_pdf.patch
 create mode 100644 ports/poco/use-vcpkg-libharu.patch
 create mode 100644 ports/yaml-cpp/0002-fix-include-path.patch
 create mode 100644 toolsrc/src/vcpkg-test/stringview.cpp
Failed at [Y:\vcpkg\toolsrc\src\vcpkg\packagespec.cpp(44)] with message:
Contains invalid characters. Only alphanumeric lowercase ASCII characters and dashes are allowed

@degski, we recommend to use Powershell, and after 'git pull', it's better to run bootstrap-vcpkg.bat to rebuild vcpkg, since the VCPKG source also update.
For stray version of vcpkg.exe, except vcpkg\vcpkg.exe, I didn't have other version, I didn't clean source in recent 8 months, I'm not sure how them generated in your side, you can clean them.

@PhoebeHui Why do you recommend Powershell [just curious]?
As to the stray-versions, I don't know either how they got there [I did not put them there], but they are older than 8 months. At some point vcpkg must have been putting them there. Yes, I removed them :-).

@degski, I recommend Powershell since:
vcpkg supports auto-completion of commands, package names, options etc in Powershell, see doc.
Another is that someone mentioned it cause unknown error before by cmd, I'm not clear now, however, if you encounter similar issue, please let us know.

Thanks. I just have some batch scripts, so auto-completion is not an issue and so far I've never had a problem with cmd. In the meanwhile cmd is being overhauled, so I doubt it will be a problem in the future.
No need for auto-bootstrap then?

For auto-bootstrap, you have brought this up in https://github.com/microsoft/vcpkg/issues/7328, for me, it's great idea, let's see the discussion from users and other team members.

@PhoebeHui You're better at finding those things than I, yes, that's the one.

@PhoebeHui My PS Version is 4.0

@degski those stray versions are ... interesting ... I've never seen anything like that locally.
If you wanted to try to implement the thing you're talking about you would need to support VS2015 which has a watered down c++14 implementation.
You would also need to support GCC 6.5.

@cbezault The strays, well, I don't know, been using vcpkg for quite a while now. Let's just assume for the moment that the problem has gone away over time (until it doesn't).
I'm looking into that now, my biggest issue will be to hang the code properly in the existing code [and respect style and 'the' way of doing things]. I'll have to check what VS15 and GCC-6.5 support, I have VS19 and GCC-8.3 (for now).

@IRelaxxx, could you upgrade your Powershell and try to build again?

@PhoebeHui I upgrade to Powershell 5.1 and the issue is gone

Great to hear that! It seems vcpkg required Powershell 5.0 for some features. you can search 'powershell' in vcpkg for related information


WaveSurfer.regions.create Uncaught TypeError: Cannot read property 'create' of undefined

I've read all similar issues, but could not solve the problem, help please

What code causes this problem?

What code causes this problem?

    let RegionsPlugin = WaveSurfer.regions;

    let waveform = WaveSurfer.create({
        container: '#waveform',
        waveColor: 'violet',
        progressColor: 'purple',
        backend: 'MediaElement',
        plugins: [
            RegionsPlugin.create({})
        ]
    });

Looks like RegionsPlugin is not properly imported. Can you console.log(RegionsPlugin)?
See https://github.com/katspaugh/wavesurfer.js/blob/master/src/plugin/regions/index.js#L48

Looks like RegionsPlugin is not properly imported. Can you console.log(RegionsPlugin)?
See https://github.com/katspaugh/wavesurfer.js/blob/master/src/plugin/regions/index.js#L48

    let waveform = WaveSurfer.create({
        container: '#waveform',
        waveColor: 'violet',
        progressColor: 'purple',
        backend: 'MediaElement',
        plugins: [
            // RegionsPlugin.create({})
        ]
    });

    let RegionsPlugin = WaveSurfer.regions;

    console.log(RegionsPlugin);

    undefined (index):182

I've found decision. I had to add one more script . Sorry for bothering.


Fix race in stats cli and native driver

Race in native driver can be verified with while true; do docker run -d busybox true | xargs docker stats --no-stream; sleep .1; done (race detector logs: https://gist.github.com/runcom/c8be5b347dfc1deddba3)
Fix in api/client/stats.go I'm finding a way to reproduce cause I triggered it and moved on and forgot to keep a note..
I don't know if these fixes are ok..if this isn't the way or we don't want this I'll close this
ping @LK4D4
Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

I think fix is ok.

LGTM

LGTM

LGTM


[bug] Unable to place order: The shipping method is missing. Select the shipping method and try again.

After updating the shipping information (first set it, select shipping method, then change the shipping address), the Shipping method is no longer set on the quote, while the checkout still shows it being selected.
If there is only one shipping method available, it's impossible to re-select it since the checkout state does still have it selected.
If you reload the checkout you can see the shipping method no longer selected.

Closing this issue as it is fixed already and available in the stable release.

Same issue on hyva-themes/magento2-luma-checkout

Issue still persistent in Hyva React Checkout. The previous selected state is not retained on reload of the checkout page and graphql query returns null for request of selected_shipping_methods in turn making the place order button non-functional as it results in the following error ->


Add supported features to sidecar metadata endpoint

Right now, a developer has to keep track of which features are enabled and utilize them. SDKs cannot detect available features and enable optimized code paths automatically or disable them to prevent crashing/output nicer errors.
Here are some features that can be enabled depending on the sidecar version/configuration, for example:

Actor reentrancy
ISO-8601 timers/reminders

In what area(s)?

/area runtime

/area operator

/area placement

/area docs

/area test-and-release

Release Note

RELEASE NOTE: ADD enabled sidecar features to metadata endpoint

Do you mean to make those features as plugins?

Do you mean to make those features as plugins?

No. Currently, there's no way for an application to know whether the sidecar supports these features until it makes a call and discovers an error. For example, the new configuration API will still be using /v1/ HTTP API version, but will only work in a certain Dapr version.
In actuality, it may just be simple enough to pass a header from Dapr with the current sidecar version.


Fixes SSL certificate verification

This will break things for existing users depending on this behaviour.
That said - we're < 1.0, and I've never been comfortable with VERIFY_NONE anyway.
Let me think about it.

I started with verify none as default but then realized that implicit
should be secure. I think major bump would be ok, maybe even minor since
it's really a security fix. With update instructions to achieve the
previous behavior it should be fine.
Anyway, leaving up to you.
Odesláno pomocí AquaMail pro Android
http://www.aqua-mail.com
Dne 16. srpna 2016 13:22:56 mipearson<EMAIL_ADDRESS>napsal:

This will break things for existing users depending on this behaviour.
That said - we're < 1.0, and I've never been comfortable with VERIFY_NONE
anyway.
Let me think about it.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/mipearson/webpack-rails/pull/49#issuecomment-240074883

Ah - if you're the contributor who originally added the VERIFY_NONE then
I'm happy to merge your fix.
On Wed, Aug 17, 2016 at 12:44 AM, Marek Hulán<EMAIL_ADDRESS>wrote:

I started with verify none as default but then realized that implicit
should be secure. I think major bump would be ok, maybe even minor since
it's really a security fix. With update instructions to achieve the
previous behavior it should be fine.
Anyway, leaving up to you.
Odesláno pomocí AquaMail pro Android
http://www.aqua-mail.com
Dne 16. srpna 2016 13:22:56 mipearson<EMAIL_ADDRESS>napsal:

This will break things for existing users depending on this behaviour.
That said - we're < 1.0, and I've never been comfortable with
VERIFY_NONE
anyway.
Let me think about it.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/mipearson/webpack-rails/pull/49#
issuecomment-240074883

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mipearson/webpack-rails/pull/49#issuecomment-240124265,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAF8JXYYGYbnty9GE9PiIXZ_oGXiB6flks5qgczqgaJpZM4JlRyu
.

--
Michael Pearson

No, I'm not :-) I meant I started this PR with verify none, but then I
changed my mind and sent this version.
Odesláno pomocí AquaMail pro Android
http://www.aqua-mail.com
Dne 16. srpna 2016 11:52:16 PM mipearson<EMAIL_ADDRESS>napsal:

Ah - if you're the contributor who originally added the VERIFY_NONE then
I'm happy to merge your fix.
On Wed, Aug 17, 2016 at 12:44 AM, Marek Hulán<EMAIL_ADDRESS>wrote:

I started with verify none as default but then realized that implicit
should be secure. I think major bump would be ok, maybe even minor since
it's really a security fix. With update instructions to achieve the
previous behavior it should be fine.
Anyway, leaving up to you.
Odesláno pomocí AquaMail pro Android
http://www.aqua-mail.com
Dne 16. srpna 2016 13:22:56 mipearson<EMAIL_ADDRESS>napsal:

This will break things for existing users depending on this behaviour.
That said - we're < 1.0, and I've never been comfortable with
VERIFY_NONE
anyway.
Let me think about it.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/mipearson/webpack-rails/pull/49#
issuecomment-240074883

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mipearson/webpack-rails/pull/49#issuecomment-240124265,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAF8JXYYGYbnty9GE9PiIXZ_oGXiB6flks5qgczqgaJpZM4JlRyu
.

--
Michael Pearson
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/mipearson/webpack-rails/pull/49#issuecomment-240250781

any chance you have thought about it?

Thanks @mipearson, I updated the PR.

Anything else I could do to get this in?

I'm going to be bringing this in to an API-breaking 1.0-pre branch shortly.
The delay on this (and other) pull requests is that I've been cautious to merge anything that could break functionality for existing users.

Sure, that I can definitely understand. Thanks for the update.

Merged in  0.9.10, but disabled by default

Thanks you :+1:


should not use .local

.local is effectively reserved by RFC 6762 and could cause unintended side effects.
this repo should not use it.

Agreed.  I've had issues in the past with Go programs like etcd and flannel when they are statically linked (common, especially when run from small container images).  Go's netgo DNS implementation tries not to resolve .local domains, and there is no other DNS method in statically linked Go programs.
See: https://github.com/golang/go/blob/master/src/net/net.go#L57

Maybe tie it to externalDNSName? Cluster DNS names might get a little bit long but at least it'd be unique.

Seems like this is prevalent in Kubernetes clusters and unlikely to change. https://github.com/coreos/matchbox/pull/542/commits/05925036528858e6b20284dc1c5414e16aa561c4


Microk8s - Error: failed to generate container XX spec: invalid environment variable "xec'

I am using microk8s (+ helmcharts and values) and one of my containers is failing to start with spec: invalid environment variable "xec". That is the only output I am getting. Interestingly, there are no env vars named "xec" that the container is expecting to have. The service that is failing with the err message "spec: invalid environment variable "xec" has a configmap.yaml, a deployment.yaml and a service.yaml files. The image itself is being pulled from a container registry so I have no control over it. I also tried a newer version of the image, but alas. It works for everyone else. Could it be that microk8s cached some values or there is some bad layer ?
Any ideas ?
Thanks.

Duplicate of https://github.com/ubuntu/microk8s/issues/1592


[DOC] Repair broken link

Thank you.

If the relevant code fragment spans multiple lines
(e.g., contains newlines)

I think this is not "e.g." because it is a tautology that multiple lines contain newlines. Can you mark up the original expression?

Thank you.

If the relevant code fragment spans multiple lines
(e.g., contains newlines)

I think this is not "e.g." because it is a tautology that multiple lines contain newlines. Can you mark up the original expression?

I tried unsuccessfully to mark up the original expression.  I don't have a good fix for this.  I should have opened an Issue instead of a PR.  Should I do so now?

Opened https://github.com/ruby/error_highlight/issues/38.


some  variables have black background after ```python

How can I turn off the rule that blackens some variables in markdown python code snippets?
eg in a markdown cell in 2020-03-07_blogpost.ipynb (look at the source, github will prolly render it)
def forward(
    self,
    input_ids,
    attention_mask=None, # ignored pad tokens in input_ids
    decoder_input_ids=None, # make these if not supplied
    decoder_padding_mask=None, # ignored pad tokens in decoder_input_ids
):

results in

#150 is related, I think.

Are you using the most recent version of fastpages?   There were some recent CSS bugs that have been fixed.  The current state looks like this:
For notebooks:

For markdown

Please upgrade and let me know if this is still an issue.  If opening a new issue, please provide  a link to your repo.  🙇 Thank you!

@sshleifer I just looked at your repo, and yeah unfortunately there was a pretty bad bug just a couple of days ago as I botched the CSS.  Really sorry about that.  I've made it easier to upgrade things, now.  Please have a go at it now and let me know.
It's probably best if you copy over your posts to a new template.  ( It should be easy to upgrade from now on with the issue template).  Thanks

Thanks, that worked!


Puppeteer connect fails in Docker container

Hi!
I've managed to get connecting and importing working on my native OS but I get issues when running dockerized.
       "before all" hook for "Printing addresses":
     CypressError: `cy.task('setupMetamask')` failed with the following error:

> Puppeteer failed to initialize the metamask wallet. Cannot read properties of undefined (reading 'waitForTimeout')

https://on.cypress.io/api/task

Because this error occurred during a `before all` hook we are skipping all of the remaining tests.

Issue occurs below where waitForTimeout fails between metamaskWindow() is undefined which happens because assignWindows fails because the internal puppeteer.pages() call returns 0 pages. I don't know whether this is an issue with the pages() call itself,  or the puppeteer.connect() call inside your puppeteer.init() function. Is this something you've seen before.
        await puppeteer.init();
        await puppeteer.assignWindows();
        await puppeteer.assignActiveTabName('metamask');

        // sometimes it will fail here.
        await puppeteer.metamaskWindow().waitForTimeout(10000);

Thanks in advance for any help!

Hello.
I pointed it out on synpress . The first try always fails to get the Metamask window in time. I am using a fake test in order to give time to the window to load.
Still trying to understand why.


Uncaught ReferenceError: Promise is not defined at htmI2canvas.js : 592

Uncaught ReferenceError: Promise is not defined at htmI2canvas.js : 592
???

Hi @yyx1111, see the readme. html2canvas uses Promises, which aren't natively supported in older browsers, so you'll need to use a polyfill (like es6-promise).

for example


fix(search-field): export SearchField component in index.js

Coverage remained the same at 99.402% when pulling a9237f04e12132a6dc18cfd4b811fc8316733ac3 on astankiewicz/export-searchfield into 138bb67e3d4d785df5fbbbe8d721f7b6880d90a6 on master.

:tada: This PR is included in version 3.1.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


"system" button no longer functional after PSNavi setup.

After setting up a PSNavi controller to use with PSMoveService no matter which button I map as "system" in steamvr.vrsettings none of them will open the menu.

This issue ended up being caused by a SteamVR update. The fact that it happened the same time as I setup my PSNavi was coincidental.

Hey i got the same problem, how do you managed that the button work again?

Go to your tools library and under SteamVR's properties go to the betas tab and choose the one with openvr in its name.


malformed url when using digest with query-strings

When using digest auth and a URL containing a "?" the question mark is removed, it seems, from the url.
For example,
r = requests.get('http://foo.com/bar.json', auth=('digest', 'blah', 'bloh'))
works, but:
r = requests.get('http://foo.com/bar.json?really=yes', auth=('digest', 'blah', 'bloh'))
Fails. Inspecting r.request.headers['uri'] shows:
'http://foo.com/bar.jsonreally=yes'
Of course, this could be just an output but, not the actual url that it's trying to hit. Unfortunately, I only have access to one side of this conversation, so I can't tell you what the library is actually sending/asking for. I'll try and find another server that I can test.

For URL parameters, use the parameters argument in your request.
>>> url = "http://httpbin.org/digest-auth/auth/user/passwd"
>>> auth = ("digest", "user", "passwd")
>>> params = {"really":"yes"}
>>> r = requests.get(url, auth=auth, params=params)
>>> r.ok
True
>>> dir(r.request)
['__class__', '__delattr__', '__dict__', '__doc__', '__format__', '__getattribute__', '__hash__', '__init__', '__module__', '__new__', '__reduce__', '__reduce_ex__', '__repr__', '__setattr__', '__sizeof__', '__str__', '__subclasshook__', '__weakref__', '_build_response', '_build_url', '_enc_data', '_enc_params', '_encode_params', '_get_opener', 'allow_redirects', 'auth', 'config', 'cookies', 'data', 'files', 'headers', 'hooks', 'method', 'params', 'proxies', 'redirect', 'response', 'send', 'sent', 'timeout', 'url']
>>> r.request.url
'http://httpbin.org/digest-auth/auth/user/passwd'
>>> r.request.params
[('really', 'yes')]
>>> r.request.auth
(<function http_digest at 0x1ea3e60>, ('user', 'passwd'))

Ok, I didn't see that in any docs. In fact, I don't see it now, other than the low-level API docs.
The spirit of requests is that it's supposed to be simple; a URL that works in a browser should work in requests, right? At the very least it shouldn't fail silently and corrupt the URL: I think it's still a bug.
In the mean time, I'll use the feature tip you pointed out. Thanks.

I agree that the documentation should cover that, and I'll try to get to it in the next couple of days.
As for your error, I was actually not able to replicate the disappearing '?'
>>> r = requests.get("http://httpbin.org/get?really=yes", auth=("digest", "blah", "bloh"))
>>> r.request.url
'http://httpbin.org/get?really=yes'

Try pulling from the develop branch and see if you still get the issue.


Fix go mod PR check

What does this PR do?
Fix go mod PR check and update go.sum to be compatible with go1.16.
In addition we could update to go1.16 but it's not available in https://catalog.redhat.com/software/containers/rhel8/go-toolset/5b9c810add19c70b45cbd666 yet
What issues does this PR fix or reference?
N/A
Is it tested? How?
Just check that PR check passed.

/test v5-devworkspaces-operator-e2e

/retest


Fix imports in README examples

I'm not sure if this changed recently but the examples in the README don't match the examples in the documentation.

Thanks for the PR, actually README got prematurely updated - both imports will be available with the new release, which gonna happen in following week.
Sorry for this mess!


Wrapper for counterfactual simulations

We need some practical structure for running our intended scans over interventions and time to detections in parallel and for many different seeds.

Okay, here is a potential draft, what do people think? @smodee @joyiichow @ConradKunadu
It would probably be good to have an additional class CounterfactualSim which has a similar constructor as the Sim class, but that allows to provide a list of intervention packages (for example a "weak", "medium" and "strong" package that we want to compare). Depending on what approach we take for implementing adaptive interventions, we might also supply events that trigger these interventions. Then, in the CounterfactualSim class, we probably want the following functionality:

a constructor which stores all the supplied parameters, including a supplied RNG seed (or creates one)
an initialization method which initializes and runs the baseline scenario (no interventions). This includes the following tasks

save the people object (e.g. from synthPops) created during initialization of the baseline scenario, store it in a temporary file and save the file location in an object variable
check whether there happens an epidemic at all in the simulated baseline scenario (depending on the initial starting conditions, the outbreak may die out by itself)
determine what the range of detection times is that we want to scan (lower and upper bound) --> this is a task for another issue, maybe have a simple placeholder here

a method scan_detection_times which simulated for each intervention package a range of detection times (determined during initialization above) and stores all the results

To do these simulations, the method has to create many copies of the baseline scenario, but with specific interventions and detection times supplied. To me it seems that the easiest approach based on the current implementation is to create new Sim objects with the respective interventions etc., but to supply the peoples object via the popfile argument. The disadvantage is that this loads this file over and over again, creating some overhead. Advantage is that this guarantees all objects to be completely independent (deepcopy does not seem to work reliably for pathosim objects) and this also makes parallelization more realistic (though not sure if we even want to parallelize at this level).
For storing results, I would prefer storing by detection time at the innermost level, and then by intervention package, not the other way round - because the most intuitive post-hoc analysis I would do is to look at QALYs as a function of detection time for a given intervention set)

further methods for computing results statistics (e.g. for differences between detection times or intervention packages), and plotting

Once we have this class, we can add another CounterfactualMultiSim class that simply creates a lot of CounterfactualSim objects with different seeds:

if we want to condition on an outbreak actually occurring (see Conrads thoughts on slack), we can have a dynamic procedure which initializes new CounterfactualSim objects one at a time and checks whether the outbreak really takes off. If not, it throws away that object and creates a new one with a different seed until we have enough seeds (according to some prespecified number, e.g. 100) for which the outbreak actually takes off.
some functionality for running the scan_detection_times method of the different CounterfactualSim objects with the different seeds in parallel
some functionality for aggregating the results from each CounterfactualSim across the different seeds and reporting/plotting summary statistics and distributions.

Okay, here is a potential draft, what do people think? @smodee @joyiichow @ConradKunadu
It would probably be good to have an additional class CounterfactualSim which has a similar constructor as the Sim class, but that allows to provide a list of intervention packages (for example a "weak", "medium" and "strong" package that we want to compare). Depending on what approach we take for implementing adaptive interventions, we might also supply events that trigger these interventions. Then, in the CounterfactualSim class, we probably want the following functionality:

a constructor which stores all the supplied parameters, including a supplied RNG seed (or creates one)

an initialization method which initializes and runs the baseline scenario (no interventions). This includes the following tasks

save the people object (e.g. from synthPops) created during initialization of the baseline scenario, store it in a temporary file and save the file location in an object variable
check whether there happens an epidemic at all in the simulated baseline scenario (depending on the initial starting conditions, the outbreak may die out by itself)
determine what the range of detection times is that we want to scan (lower and upper bound) --> this is a task for another issue, maybe have a simple placeholder here

a method scan_detection_times which simulated for each intervention package a range of detection times (determined during initialization above) and stores all the results

To do these simulations, the method has to create many copies of the baseline scenario, but with specific interventions and detection times supplied. To me it seems that the easiest approach based on the current implementation is to create new Sim objects with the respective interventions etc., but to supply the peoples object via the popfile argument. The disadvantage is that this loads this file over and over again, creating some overhead. Advantage is that this guarantees all objects to be completely independent (deepcopy does not seem to work reliably for pathosim objects) and this also makes parallelization more realistic (though not sure if we even want to parallelize at this level).
For storing results, I would prefer storing by detection time at the innermost level, and then by intervention package, not the other way round - because the most intuitive post-hoc analysis I would do is to look at QALYs as a function of detection time for a given intervention set)

further methods for computing results statistics (e.g. for differences between detection times or intervention packages), and plotting

Once we have this class, we can add another CounterfactualMultiSim class that simply creates a lot of CounterfactualSim objects with different seeds:

if we want to condition on an outbreak actually occurring (see Conrads thoughts on slack), we can have a dynamic procedure which initializes new CounterfactualSim objects one at a time and checks whether the outbreak really takes off. If not, it throws away that object and creates a new one with a different seed until we have enough seeds (according to some prespecified number, e.g. 100) for which the outbreak actually takes off.
some functionality for running the scan_detection_times method of the different CounterfactualSim objects with the different seeds in parallel
some functionality for aggregating the results from each CounterfactualSim across the different seeds and reporting/plotting summary statistics and distributions.

Hope this isn't too late, but this seems great - really like this suggestion! Really have no constructive feedback here


Add support for feature-level prerequisites

Fixes https://github.com/knative/eventing/issues/6934
When testing TLS we are facing the challenge of defining tests which should be executed based on the feature flag value.
For example, when we will add tests for [1], we will need to execute the test only when the transport-encryption feature flag is set to one of permissive or strict.
[1] https://github.com/knative/eventing/issues/6932
The idea is to have an additional feature timing called Prerequisite and the usage would look like this:
	f.Prerequisite("other timings should not run", func(ctx context.Context, t feature.T) (feature.PrerequisiteResult, error) {
		// check feature flag value ..
		// ...
		return feature.PrerequisiteResult{ShouldRun: false}, nil
	})
	f.Setup("failed setup", func(ctx context.Context, t feature.T) {
		t.Fatal("bug: this must never happen")
	})

/cc @mgencur @gab-satchi @creydr


Omit private symbols from type

🔍 Search Terms
Continuation of

https://github.com/microsoft/TypeScript/issues/58089

✅ Viability Checklist

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
[x] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals

⭐ Suggestion
Please remove private symbols from types. There's no need to check symbols the same way as private properties or #private fields, because unlike private properties or #private fields symbols can only ever be accessed using a reference to the symbol.
So, for example, if an object is exported from a module (or returned from a function) the type does not need to be included outside of the module (or outside of the function) if the symbol is not in scope, because the user of the object will never be able to access the symbol key as they do not have a reference to the symbol.
This will prevent unintuitive errors like Return type of exported function has or is using private name 'someSymbol'.
In fact, a symbol is not really private at all. It is a public key, so long as you have the reference. For this reason, it needs special and different treatment to make their usage easier.
📃 Motivating Example

https://github.com/microsoft/TypeScript/issues/58089

💻 Use Cases

What do you want to use this for?

Use symbols as semi-"private" public keys without type errors.

What shortcomings exist with current approaches?

Unnecessary errors that don't really help.

What workarounds are you using in the meantime?

Write return types explicitly which can be more cumbersome,
or type the symbol as any but then type checking within code is lost.

I don't get it. The other issue had the same issue for symbols... if the internal state of the exposed thing cares about that symbol-keyed property, then merely omitting it produces the wrong type.  I don't see a code example here, but how should TS deal with
const f = (() => {
    const sym = Symbol();
    let id = 0;
    function make(name: string) {
        return {
            name,
            [sym]: id++
        }
    }
    type Item = ReturnType<typeof make>
    return {
        make,
        take(item: Item) {
            console.log(item.name);
            console.log(item[sym].toFixed(0));
        }
    }
})()
/* const f: {
    make: (name: string) => {
        name: string;
        [sym]: number;
    };
    take(item: {
        name: string;
        [sym]: number;
    }): void;
} */
f.take(f.make("okay")); // okay, 0
f.take(f.make("yeah")); // yeah, 1
f.take({ name: "oops" }); // oops, 💥

Playground link to code
Are you suggesting that the return type of f.make() and the parameter type of f.take() should be {name: string} and therefore f.take({name: "oops"}) should not give the TS error it gives now? This looks the same as private and #private to me.  They have the effect of making the type effectively nominal, but that's a good thing, right?

The reasoning in the linked issue is still correct. You are only thinking about this from the read side, but excluding this information has critical effects on assignability which would create a very large soundness hole.

Ah yes, for my case I was thinking only of reading/writing inside class lexical scope, but not wanting to write from the outside (public)
What we need is "private class field symbols" which would enforce that symbols are accessible only inside class lexical scope, and in that case access on the outside would not be possible (so the type wouldn't need to exist on the outside).


Terminal is frozen when switching network

After joining a session, I switch my wireless network. Teleconsole's terminal is frozen immediately.
It should retry to connect, or quit the session so I can reconnect manually.

@tnhu thank you for reporting this. It has actually been fixed in Teleport (SSH library Teleconsole uses) and will get vendored in during next Teleport release (in a few weeks).

dupe of #16


RISC-V machine: Use dynamic VADCOP

Builds on #1687
Fixed #1572
With this PR, we are using dynamic VADCOP in the RISC-V zk-VM.
There were a few smaller fixes needed to make this work. In summary, the changes are as follows:

We set the degree the main machine to None, and all fixed lookup machines to the appropriate size. As a consequence, the CPU, all block machines & memory have a dynamic size.
As a consequence, I had to adjust some tests (set the size of all machines, so they can still be run with monolithic provers) and was able to remove the Memory_<size> machines 🎉
With the main machine being of flexible size, the prover can chose for how long to run it. We run it for 1 << (MAX_DEGREE_LOG - 2) steps and compute the bootloader inputs accordingly. With this choice, we can guarantee that the register memory (which can be up to 4x larger than the main machine) does not run out of rows.

Note that while we do access MAX_DEGREE_LOG in a bunch of places now, this will go away once #1667 is merged, which will allow us to configure the degree range in ASM and for each machine individually.
Example:
export MAX_LOG_DEGREE=18
cargo run -r --bin powdr-rs compile riscv/tests/riscv_data/many_chunks -o output --continuations
cargo run -r --bin powdr-rs execute output/many_chunks.asm -o output --continuations -w
cargo run -r --features plonky3,halo2 prove output/many_chunks.asm -d output/chunk_0 --field gl --backend plonky3-composite

This leads to the following output:
== Proving machine: main (size 65536), stage 0
==> Proof stage computed in 1.918317417s
== Proving machine: main__rom (size 8192), stage 0
==> Proof stage computed in 45.847375ms
== Proving machine: main_binary (size 1024), stage 0
==> Proof stage computed in 27.718416ms
== Proving machine: main_bit2 (size 4), stage 0
==> Proof stage computed in 15.280667ms
== Proving machine: main_bit6 (size 64), stage 0
==> Proof stage computed in 17.449875ms
== Proving machine: main_bit7 (size 128), stage 0
==> Proof stage computed in 20.717834ms
== Proving machine: main_bootloader_inputs (size 262144), stage 0
==> Proof stage computed in 524.013375ms
== Proving machine: main_byte (size 256), stage 0
==> Proof stage computed in 17.280167ms
== Proving machine: main_byte2 (size 65536), stage 0
==> Proof stage computed in 164.709625ms
== Proving machine: main_byte_binary (size 262144), stage 0
==> Proof stage computed in 504.743917ms
== Proving machine: main_byte_compare (size 65536), stage 0
==> Proof stage computed in 169.881542ms
== Proving machine: main_byte_shift (size 65536), stage 0
==> Proof stage computed in 146.235916ms
== Proving machine: main_memory (size 32768), stage 0
==> Proof stage computed in 326.522167ms
== Proving machine: main_poseidon_gl (size 16384), stage 0
==> Proof stage computed in 1.324662625s
== Proving machine: main_regs (size 262144), stage 0
==> Proof stage computed in 2.009408667s
== Proving machine: main_shift (size 32), stage 0
==> Proof stage computed in 13.71825ms
== Proving machine: main_split_gl (size 16384), stage 0
==> Proof stage computed in 108.019334ms
Proof generation took 7.364567s
Proof size: 8432928 bytes
Writing output/chunk_0/many_chunks_proof.bin.

Note that main_bootloader_inputs is still equal to the maximum size, we should fix that in a following PR!

has conflicts now

has conflicts now

I rebased onto main (works much better than merge when a branch you were building on was merged...)


Create Docker file to create the image

This is done.
Example usage:
docker build -t gollm-test .
docker run -e OPENAI_API_KEY=$OPENAI_API_KEY -it gollm-test --input test_data/test_input_model_config.json

The app expects a .json with the following fields:
'amr': json string (Petri net model representation, missing config values.)
'research_paper': str (OCR text from a paper)
The CLI app should be replaced with a fastapi endpoint. Also this pipeline is still quite slow clocking in around 2 min. This can be improved.


Connector provisioning failing

We're trying to provision a AWS Lambda connector in our QA env,we've implemented tf scripts to do that. We've tested it in our DEV env and it works fine. We're able to provision the connector in DEV env by using the same scripts, but we're not able to provision the connector by using the same in our QA env for some topic.
Can you please check what's the issue and if there's any change that we have to do.
Error that we're getting:
│ Error: error waiting for Connector "aws-sink-connector" to provision: connector "display_name"="aws-sink-connector" provisioning status is "FAILED": Unable to validate configuration. If an update was made to the configuration, this means that the configuration was invalid, and the connector continues to operate on a previous configuration that passed validation. Errors:
│ kafka.service.account.id: User does not have CREATE access to topic prefixed with dlq-lcc
│ kafka.api.secret: User does not have CREATE access to topic prefixed with dlq-lcc
│
│
│   with confluent_connector.sink["xyz"],
│   on connector.tf line 6, in resource "confluent_connector" "sink":
│    6: resource "confluent_connector" "sink" {
│
╵

Tf scripts:
resource "confluent_api_key" "app_consumer_kafka_api_key" {
  for_each     = { for topic in var.kafka_topics : topic.topic_name => topic }
  display_name = "${each.key}-${var.env_name}-reader"
  description  = "${each.key}-${var.env_name}-reader key"
  owner {
    id          = confluent_service_account.topic_readers[each.key].id
    api_version = confluent_service_account.topic_readers[each.key].api_version
    kind        = confluent_service_account.topic_readers[each.key].kind
  }

  managed_resource {
    id          = var.kafka_cluster_id
    api_version = var.kafka_cluster_api_version
    kind        = var.kafka_cluster_kind

    environment {
      id = var.kafka_env_id
    }
  }
}

resource "confluent_api_key" "app_producer_kafka_api_key" {
  for_each     = { for topic in var.kafka_topics : topic.topic_name => topic }
  display_name = "${each.key}-${var.env_name}-writer"
  description  = "${each.key}-${var.env_name}-writer key"
  owner {
    id          = confluent_service_account.topic_writers[each.key].id
    api_version = confluent_service_account.topic_writers[each.key].api_version
    kind        = confluent_service_account.topic_writers[each.key].kind
  }

  managed_resource {
    id          = var.kafka_cluster_id
    api_version = var.kafka_cluster_api_version
    kind        = var.kafka_cluster_kind

    environment {
      id = var.kafka_env_id
    }
  }
}

resource "confluent_api_key" "app_secondary_producer_kafka_api_key" {
  for_each     = { for topic in var.kafka_topics : topic.topic_name => topic }
  display_name = "${each.key}-${var.env_name}-secondary-writer"
  description  = "${each.key}-${var.env_name}-secondary-writer key"
  owner {
    id          = confluent_service_account.topic_secondary_writers[each.key].id
    api_version = confluent_service_account.topic_secondary_writers[each.key].api_version
    kind        = confluent_service_account.topic_secondary_writers[each.key].kind
  }

  managed_resource {
    id          = var.kafka_cluster_id
    api_version = var.kafka_cluster_api_version
    kind        = var.kafka_cluster_kind

    environment {
      id = var.kafka_env_id
    }
  }
}

resource "confluent_api_key" "app_secondary_consumer_kafka_api_key" {
  for_each     = { for topic in var.kafka_topics : topic.topic_name => topic }
  display_name = "${each.key}-${var.env_name}-secondary-reader"
  description  = "${each.key}-${var.env_name}-secondary-reader key"
  owner {
    id          = confluent_service_account.topic_secondary_readers[each.key].id
    api_version = confluent_service_account.topic_secondary_readers[each.key].api_version
    kind        = confluent_service_account.topic_secondary_readers[each.key].kind
  }

  managed_resource {
    id          = var.kafka_cluster_id
    api_version = var.kafka_cluster_api_version
    kind        = var.kafka_cluster_kind

    environment {
      id = var.kafka_env_id
    }
  }
}

resource "confluent_service_account" "app_connector" {
  for_each     = var.connector_configs
  display_name = "${each.key}-${var.env_name}-connector-consumer"
  description  = "Service account to consume from connector"
}

resource "confluent_kafka_acl" "app_connector_describe_on_cluster" {
  for_each = var.connector_configs
  kafka_cluster {
    id = var.kafka_cluster_id
  }
  resource_type = "CLUSTER"
  resource_name = "kafka-cluster"
  pattern_type  = "LITERAL"
  principal     = "User:${confluent_service_account.app_connector[each.key].id}"
  host          = "*"
  operation     = "DESCRIBE"
  permission    = "ALLOW"
  rest_endpoint = var.kafka_cluster_endpoint
  credentials {
    key    = var.kafka_api_key
    secret = var.kafka_secret_key
  }
}

resource "confluent_kafka_acl" "app_connector_read_on_target_topic" {
  for_each = var.connector_configs
  kafka_cluster {
    id = var.kafka_cluster_id
  }
  resource_type = "TOPIC"
  resource_name = each.key
  pattern_type  = "LITERAL"
  principal     = "User:${confluent_service_account.app_connector[each.key].id}"
  host          = "*"
  operation     = "READ"
  permission    = "ALLOW"
  rest_endpoint = var.kafka_cluster_endpoint
  credentials {
    key    = var.kafka_api_key
    secret = var.kafka_secret_key
  }
}

resource "confluent_kafka_acl" "app_connector_create_on_dlq_lcc_topics" {
  for_each = var.connector_configs
  kafka_cluster {
    id = var.kafka_cluster_id
  }
  resource_type = "TOPIC"
  resource_name = "${each.key}-dlq-lcc"
  pattern_type  = "PREFIXED"
  principal     = "User:${confluent_service_account.app_connector[each.key].id}"
  host          = "*"
  operation     = "CREATE"
  permission    = "ALLOW"
  rest_endpoint = var.kafka_cluster_endpoint
  credentials {
    key    = var.kafka_api_key
    secret = var.kafka_secret_key
  }
}

resource "confluent_kafka_acl" "app_connector_write_on_dlq_lcc_topics" {
  for_each = var.connector_configs
  kafka_cluster {
    id = var.kafka_cluster_id
  }
  resource_type = "TOPIC"
  resource_name = "${each.key}-dlq-lcc"
  pattern_type  = "PREFIXED"
  principal     = "User:${confluent_service_account.app_connector[each.key].id}"
  host          = "*"
  operation     = "WRITE"
  permission    = "ALLOW"
  rest_endpoint = var.kafka_cluster_endpoint
  credentials {
    key    = var.kafka_api_key
    secret = var.kafka_secret_key
  }
}

resource "confluent_kafka_acl" "app_connector_create_on_success_lcc_topics" {
  for_each = var.connector_configs
  kafka_cluster {
    id = var.kafka_cluster_id
  }
  resource_type = "TOPIC"
  resource_name = "${each.key}-success-lcc"
  pattern_type  = "PREFIXED"
  principal     = "User:${confluent_service_account.app_connector[each.key].id}"
  host          = "*"
  operation     = "CREATE"
  permission    = "ALLOW"
  rest_endpoint = var.kafka_cluster_endpoint
  credentials {
    key    = var.kafka_api_key
    secret = var.kafka_secret_key
  }
}

resource "confluent_kafka_acl" "app_connector_write_on_success_lcc_topics" {
  for_each = var.connector_configs
  kafka_cluster {
    id = var.kafka_cluster_id
  }
  resource_type = "TOPIC"
  resource_name = "${each.key}-success-lcc"
  pattern_type  = "PREFIXED"
  principal     = "User:${confluent_service_account.app_connector[each.key].id}"
  host          = "*"
  operation     = "WRITE"
  permission    = "ALLOW"
  rest_endpoint = var.kafka_cluster_endpoint
  credentials {
    key    = var.kafka_api_key
    secret = var.kafka_secret_key
  }
}

resource "confluent_kafka_acl" "app_connector_create_on_error_lcc_topics" {
  for_each = var.connector_configs
  kafka_cluster {
    id = var.kafka_cluster_id
  }
  resource_type = "TOPIC"
  resource_name = "${each.key}-error-lcc"
  pattern_type  = "PREFIXED"
  principal     = "User:${confluent_service_account.app_connector[each.key].id}"
  host          = "*"
  operation     = "CREATE"
  permission    = "ALLOW"
  rest_endpoint = var.kafka_cluster_endpoint
  credentials {
    key    = var.kafka_api_key
    secret = var.kafka_secret_key
  }
}

resource "confluent_kafka_acl" "app_connector_write_on_error_lcc_topics" {
  for_each = var.connector_configs
  kafka_cluster {
    id = var.kafka_cluster_id
  }
  resource_type = "TOPIC"
  resource_name = "${each.key}-error-lcc"
  pattern_type  = "PREFIXED"
  principal     = "User:${confluent_service_account.app_connector[each.key].id}"
  host          = "*"
  operation     = "WRITE"
  permission    = "ALLOW"
  rest_endpoint = var.kafka_cluster_endpoint
  credentials {
    key    = var.kafka_api_key
    secret = var.kafka_secret_key
  }
}

resource "confluent_kafka_acl" "app_connector_read_on_connect_lcc_group" {
  for_each = var.connector_configs
  kafka_cluster {
    id = var.kafka_cluster_id
  }
  resource_type = "GROUP"
  resource_name = "${each.key}-connect-lcc"
  pattern_type  = "PREFIXED"
  principal     = "User:${confluent_service_account.app_connector[each.key].id}"
  host          = "*"
  operation     = "READ"
  permission    = "ALLOW"
  rest_endpoint = var.kafka_cluster_endpoint
  credentials {
    key    = var.kafka_api_key
    secret = var.kafka_secret_key
  }
}

variable "connector_configs" {
  description = "connector configurations"
  type = map(object({
    input_data_format             = string
    connector_name                = string
    aws_lambda_invocation_type    = string
    tasks_max                     = string
    aws_lambda_batch_size         = string
    aws_lambda_function_name      = string
    aws_secret_id                 = string
    aws_region                    = string
    connector_class               = string
    auth_mode                     = string
    aws_lambda_configuration_mode = string
    record_converter_class        = string
    behavior_on_error             = string
  }))
  default = {}
}

data "aws_secretsmanager_secret_version" "connector_secret" {
  for_each  = var.connector_configs
  secret_id = each.value.aws_secret_id
}

resource "confluent_connector" "sink" {
  for_each = var.connector_configs
  environment {
    id = var.kafka_env_id
  }
  kafka_cluster {
    id = var.kafka_cluster_id
  }

  config_sensitive = {
    "aws.access.key.id"     = jsondecode(data.aws_secretsmanager_secret_version.connector_secret[each.key].secret_string)["aws_access_key_id"]
    "aws.secret.access.key" = jsondecode(data.aws_secretsmanager_secret_version.connector_secret[each.key].secret_string)["aws_secret_access_key"]
  }

  config_nonsensitive = {
    "topics"                        = each.key
    "input.data.format"             = each.value.input_data_format
    "connector.class"               = each.value.connector_class
    "name"                          = each.value.connector_name
    "kafka.auth.mode"               = each.value.auth_mode
    "kafka.api.key"                 = var.kafka_api_key
    "kafka.api.secret"              = var.kafka_secret_key
    "aws.lambda.configuration.mode" = each.value.aws_lambda_configuration_mode
    "aws.lambda.function.name"      = each.value.aws_lambda_function_name
    "aws.lambda.region"             = each.value.aws_region
    "aws.lambda.invocation.type"    = each.value.aws_lambda_invocation_type
    "aws.lambda.batch.size"         = each.value.aws_lambda_batch_size
    "record.converter.class"        = each.value.record_converter_class
    "behavior.on.error"             = each.value.behavior_on_error
    "tasks.max"                     = each.value.tasks_max
  }

  depends_on = [
    confluent_kafka_acl.app_connector_describe_on_cluster,
    confluent_kafka_acl.app_connector_read_on_target_topic,
    confluent_kafka_acl.app_connector_create_on_dlq_lcc_topics,
    confluent_kafka_acl.app_connector_write_on_dlq_lcc_topics,
    confluent_kafka_acl.app_connector_create_on_success_lcc_topics,
    confluent_kafka_acl.app_connector_write_on_success_lcc_topics,
    confluent_kafka_acl.app_connector_create_on_error_lcc_topics,
    confluent_kafka_acl.app_connector_write_on_error_lcc_topics,
    confluent_kafka_acl.app_connector_read_on_connect_lcc_group,
  ]
}

Thanks for creating an issue!
It looks like you might want to add the following ACL:
resource "confluent_kafka_acl" "app-connector-create-on-dlq-lcc-topics" {
  for_each = var.connector_configs
  kafka_cluster {
    id = var.kafka_cluster_id
  }
  resource_type = "TOPIC"
  resource_name = "dlq-lcc"
  pattern_type  = "PREFIXED"
  principal     = "User:${confluent_service_account.app_connector[each.key].id}"
  host          = "*"
  operation     = "CREATE"
  permission    = "ALLOW"
  rest_endpoint = var.kafka_cluster_endpoint
  credentials {
    key    = var.kafka_api_key
    secret = var.kafka_secret_key
  }
}

Let me know if that helps @VipulZopSmart!

@linouk23 i already have that above.

@VipulZopSmart could you point me out to the ACL resource that have resource_name = "dlq-lcc"?

@linouk23 i've create and write acl on dlq lcc topics - doing for every connector config like this: resource_name = "${each.key}-dlq-lcc"
Is that not the right thing to do? Also, why do we need to add resource_name = "dlq-lcc" in some ACL specifically, may i know that?

@linouk23 this is blocking our release. Could you please explain what are we missing out here?
https://github.com/confluentinc/terraform-provider-confluent/blob/master/examples/configurations/connectors/s3-sink-connector/main.tf
We have made use of above example while implementing the scripts for AWS Lambda connector.

Just following up, even after adding above ACL - got other error related to writing on dlq-lcc topic and added that ACL as well and then got error for connect-lcc topic and after adding that it worked fine. Not sure if this is a bug or something. The connector is AWS Lambda connector. Please try to test this thoroughly @linouk23 .

Interesting, thanks for the message @VipulZopSmart!
Could you reach out to our support team since they might have a better overview if there were any recent issues / updates to connectors or something? I'm not a connector expert unfortunately and it definitely used to work before.
Thank you!


Upgrade RethinkDB (fixes #94)

Fixes #94
To test this, I've loaded each of the web pages and tried all the actions
I could think of. I also ran each of the tasks mentioned in crontab with no
problems.
Changelog here: https://github.com/rethinkdb/rethinkdb/releases?before=v1.16.1&after=v2.2.1
Order of operations to deploy
Upgrade the actual database package:
apt-get install --only-upgrade rethinkdb=2.2.0

Rebuild the index:
rethinkdb index-rebuild

Deploy this PR:
make deploy

Mabye @thejsj could sanity check this.

This seems reasonable and makes sense. Just FYI, Rethinkdb 2.3.0 was release about a week ago and contains some good changes like user accounts and built-in TLS support: http://rethinkdb.com/blog/2.3-release/

@thejsj Thanks! I looked at 2.3.0, but from what I can tell the Python library is not yet available from pypy. Hopefully getting to 2.2.0 should allow us to jump to 2.3.0 with less risk.

Oh, interesting. Yeah, that should definitely be the case. Still, 1.4 to
2.2 is a really nice upgrade!
Jorge Silva
blog.hiphipjorge.com
hiphipjorge.com
github.com/thejsj
On Mon, Apr 11, 2016 at 9:08 AM, Jordan Eldredge<EMAIL_ADDRESS>wrote:

@thejsj https://github.com/thejsj Thanks! I looked at 2.3.0, but from
what I can tell the Python library is not yet available from pypy
https://pypi.python.org/pypi. Hopefully getting to 2.2.0 should allow
us to jump to 2.3.0 with less risk.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/vim-awesome/vim-awesome/pull/141#issuecomment-208428898

@thejsj Updated. Thanks!

This LGTM. I'd go ahead and merge it.

I'll run the deploy later today.

If this hasn't been deployed yet, we just released RethinkDB 2.3.1, you should upgrade once more before deploying.

@dalanmiller We can't upgrade to 2.3.1 because of pypy:

@thejsj Thanks! I looked at 2.3.0, but from what I can tell the Python library is not yet available from pypy. Hopefully getting to 2.2.0 should allow us to jump to 2.3.0 with less risk.

https://github.com/vim-awesome/vim-awesome/pull/141#issuecomment-208428898

You mean PyPI?
This seems to be the most recent version.
https://pypi.python.org/pypi/rethinkdb/2.3.0.post1


Update @types/bluebird package. Closes #357

Update @types/bluebird to match version of bluebird
"dependencies": {
    "@types/bluebird": "^3.4.0",
    "bluebird": "^3.4.0",
  }

Coverage remained the same at 96.565% when pulling 18170e0a0d9cd307d57a41298321951e07df83ff on hansmaad:patch-1 into 454bb081627cf78d5d6787b132d408d0b85ddbf3 on ctavan:master.


joined_room event late?

The joined_room event triggeres a function on the javascript side that applies the layout, which includes registering scripts.
It is (theoretically) sent before any status event.

The concierge bot used to receive the status:join event and greet the joined user immediately. In order for the user to receive this message (it to be shown to him) the registration of scripts must have been completed. This does not seem to be the case:

The problem is solved by adding a time.sleep(2) between the point in time that the concierge bot receives the status event and the time it sends the message. But this is not a good solution and definitely no general solution in my opinion.

This is, why I previously introduced the ready event, but then some messages may be ignored. I'd add an event queue, where incoming events will be pushed into as long as joined_room was not called. After joined_room, the event queue could then be used to simulate past events.


Key range of XREAD/XREADGROUP is not correct

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
unstable
Minimal reproduce step
https://github.com/apache/kvrocks/blob/5fccd57c66bc8f0e4138924fe6a0148931e5650f/src/commands/cmd_stream.cc#L1891-L1892
We need to define a KeyRangeGen function to make it produce correct key range.
What did you expect to see?
--
What did you see instead?
--
Anything Else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

Sure.


Add Gentoo

It's more well known than most of the niche distros that are currently supported and has nice minimal live install images.
https://www.gentoo.org/downloads/

Yeah, I've gotten Gentoo working in the past but unfortunately it involves myself hacking up the images and hosting them myself.
https://wiki.gentoo.org/wiki/Installation_alternatives
I'd much rather see official support from Gentoo for network booting, memdisk ISO support, or at least hosting the modifed/working images themselves.
This was my previous commit that I've pulled since it needs to be redone the right way.
https://github.com/antonym/netboot.xyz/commit/1d8983d327f01ef0fa74a2df09e8604151792d0d

Added: https://github.com/antonym/netboot.xyz/pull/107