Transition will run twice onStart when the animation begin？

I found Transition ran twice onStart when the animation began, But I found that the example in the API docs run only one time ,here is my code:
 render() {
    const { className, style, active, onStart, onDestroyed } = this.props;
    return (
      <Transition
        keys={String(active)}
        onStart={onStart}
        onDestroyed={onDestroyed}
        from={{ opacity: 0, height: 0 }}
        enter={{ opacity: 1, height: 'auto' }}
        leave={{ opacity: 0, height: 0 }}
        config={config.molasses}>
        {
          active && ((styles) =>
            <animated.div style={styles}>

                {this.props.children}

            </animated.div>)
        }
      </Transition>
    );
  }

Can someone help me? Is that something wrong in my Code?

I see it, will have to look into it more deeply 🤔
Just asking, for what do you need onStart? Because onStart in transition is a little arbitrary since it is a stack, it will call onStart on elements about to be destroyed as well or for updates and entering elements. In other words, are you sure you want a transition? To me it looks like some sort of expander, in that case it should be a spring, which is simpler to handle and faster since react doesn't mount/unmount contents.

Ah, it looks like expander. I  thought about that the expander could  call onStart when it opened and call onDestroy when it fold use by  Transition when I saw the docs: (since spring will call twice onStart and onRest)
If you need to toggle a single child, that is also possible.
<Transition
  from={{ position: 'absolute', opacity: 0 }}
  enter={{ opacity: 1 }}
  leave={{ opacity: 0 }}>
  {visible && (styles =>
Single Component
)}
</Transition>

never mind, I think you are right, maybe spring is a good resolve way

The upside is that a spring is faster since react doesn't have to remount. It's sometimes good to keep stuff you want to show around, even when it's height:0, display:none. I am trying to track down the bug in the meantime, but if you want you can put the full expander source into your box, maybe there's a better way because usually relying on onRest/Start isn't so optimal.

your transition uses animated.div but there's no native specified on the transition. More about that here: http://react-spring.surge.sh/native

Is native a thing with useTransition? I haven't found any mention of it in the hooks api documentation.

no, it's native by default. the "native" flag doesn't exist any longer. "null" isn't nothing in react, it's a valid component in the render-tree. the transition doesn't know your view, it doesn't you will print "null" out to the dom, it just runs a enter/leave/update.


OSSM-5561 Changing integration common script to use buildx

changes:

Use docker-buildx to be able to run the test on others arch rather tan x86
Make minor fix on skip_build to be used later in our downstream CI

Need to be tested when this pr is merged: https://github.com/maistra/istio-operator/pull/1522

/pj-rehearse auto-ack

/test all

/retest-required

/test integration-ocp-4-14

/test scorecard

/test integration-kind

/retest

/retest

PR closed, we will do changes to build in another arch only for arm test job


[bn] Localizes static/_redirects

Signed-off-by: Asif Zubayer Palak<EMAIL_ADDRESS>Localizes static/_redirects  to Bengali
This is an initial PR as may need some improvements!
Tracking issue: #31677

/retitle Add entries into static/_redirects for Bengali localization

Hey @sftim is this file , ok? Or, we need to add /bn/docs/setup/learning-environment/     /bn/docs/tasks/tools/ 302! as well?


Storage updates generic copy and migrate functions to use revert package

Also uses driver's CreateVolume function when not refreshing in  genericCopyVolume to allow it to be usable with non-dir drivers that still use rsync for syncing.

jenkins: test this please

jenkins: test this please

jenkins: test this please

jenkins: test this please

/lxc-ci/build/tmp.unXl5rqyj7/go/src/github.com/lxc/lxd/lxd/storage/drivers/generic.go:46:5: ineffectual assignment to err

@stgraber thanks, that is fixed. That bug was actually there before this change but due to the scoping change of err that was introduced it looks like go lint started to pick up on it which is good.


FeedAHelp: Implement i18n Localization for language translation

implement multilingual support for your app, this tutorial will guide you through all of the Next.js internationalization (i18n) essentials
Source: https://phrase.com/blog/posts/nextjs-i18n/
https://nextjs.org/docs/pages/building-your-application/routing/internationalization
Since v10, Next.js has had built-in support for internationalized routing. With this addition, given some locale configuration, Next.js automatically handles localized routing. Included out of the box in Next.js are sub-path and domain routing. Sub-path routing is where the locale is part of the URL, like /blog, /fr/blog, /es/blog. Domain routing has the locale appear in the top-level domain, like mywebsite.com/blog, mywebsite.fr/blog, mywebsite.nl/blog. Of course, we will need to configure the i18n in our app for these routes to work. Let’s see this in practice by building a small demo app.
[i18next](https://www.i18next.com/) (22.0.4)
[react-i18next](https://react.i18next.com/) (12.0.0)
[next-i18next](https://github.com/i18next/next-i18next) (12.0.1)

Thank you for giving the resources.

In this ticket, I thy to implement the i18n localization for language translation. But not properly understanding how can I do it. I watched some of the youtube videos but did not really get it. One video is really interesting to me you can also watch https://www.youtube.com/watch?v=H9O9HdKNytc&t=4s
And in our projects I have faced issue to pnpm i next-i18next, it is not installing. And I am leaving this ticket because I think I can not able to finish it. But If someone wants to do it I would love to collaborate with him. Thanks.


outputs are different from conv3d

Thanks for sharing this library!
I try to extend the unfold version of conv2d to conv3d, the output difference seems be to not negligible albeit small. Any clues why this happens?
import torch

import unfoldNd

torch.manual_seed(0)

inputs = torch.randn(20, 16, 10, 50, 100)
w = torch.randn(33, 16, 3, 5, 2)
stride = (1, 1, 1)
padding = (0, 0, 0)

inp_unf = unfoldNd.unfoldNd(inputs, w.shape[2:], stride=stride, padding=padding)
out_unf = inp_unf.transpose(1, 2).matmul(w.view(w.size(0), -1).t()).transpose(1, 2)
lib_outputs = out_unf.view(20, 33, 8, 46, 99)
torch_outputs = torch.nn.functional.conv3d(inputs, w)

print((lib_outputs-torch_outputs).abs().max())

if torch.allclose(torch_outputs, lib_outputs):
    print("✔ Outputs of conv3d and unfoldNd.UnfoldNd match.")
else:
    raise AssertionError("❌ Outputs don't match")

Outputs:
tensor(0.0001)
Traceback (most recent call last):
  File "test_unfoldnd.py", line 54, in <module>
    raise AssertionError("❌ Outputs don't match")
AssertionError: ❌ Outputs don't match

Hey,
thanks for your report. My first guess for those discrepancies would be floating precision. Could you provide the relative mismatch between by printing the mismatching values by adding something like
for lib_out, torch_out in zip(lib_outputs.flatten(), torch_outputs.flatten()):
    if not torch.allclose(lib_out, torch_out):
        print(lib_out, torch_out)

to your example?/

It looks like your guess is right. Here's part of the output.
...
tensor(-0.7282) tensor(-0.7282)
tensor(0.5448) tensor(0.5448)
tensor(-0.2942) tensor(-0.2942)
tensor(0.0671) tensor(0.0671)
tensor(0.0840) tensor(0.0840)
tensor(-1.2255) tensor(-1.2254)
tensor(0.5453) tensor(0.5453)
tensor(0.1272) tensor(0.1272)
tensor(0.0616) tensor(0.0616)
tensor(0.0478) tensor(0.0478)
tensor(-0.5128) tensor(-0.5128)
tensor(0.0550) tensor(0.0550)
tensor(-0.8851) tensor(-0.8851)
tensor(0.5813) tensor(0.5813)
tensor(-0.1910) tensor(-0.1910)
tensor(-0.4936) tensor(-0.4936)
tensor(-0.0498) tensor(-0.0498)
...

They all look the same because of the printing decimal setting. Strange that the floating precision discrepancy could lead to this much of a difference (max difference 0.0001), though.

I have already experienced such behavior multiple times. One fix is to increase the tolerances in torch.allclose, e.g. using rtol=5e-05, atol=1e-07 instead of the default settings.


chore: Adding megela as an owner of the terraform-google-sap repository.

Adding megela as an owner of the terraform-google-sap repository.

Applied


Update version to 1.1.25-0 on production

Update version to 1.1.25-0

:bell: @Expensify/mobile-deployers :bell: - The Update Protected Branch workflow has failed because this PR was not mergable.
If you are the deployer this week, please resolve the error and merge this PR to continue the deploy process.

Closing because the deploy failed due to an issue with the isPullRequestMergeable action, we're going to rerun the whole deploy workflow.
More context in https://expensify.slack.com/archives/C03V9A4TB/p1641415688476900


Fix stat display on login

Apparently wis/int are flipped just for the welcome packet..


[FR] Allow to upload APNs auth keys to Firebase

Is your feature request related to a problem? Please describe.
We are trying to automate Firebase app creation since we manage many apps and most of them need push notifications. I played around with the Firebase admin SDK and got the most stuff working somehow, but I can't figure out how to upload the APNs auth key to Firebase. Is there and official way to do this via this SDK or via Rest API?
Describe the solution you'd like
I would like to have an SDK method or rest API endpoint where I can upload an Apple Push Notification service authentication key to Firebase so we can send push notifications to iOS apps managed in Firebase.
Describe alternatives you've considered
The alternative to having a method in the SDK would be at least a rest API endpoint.
Additional context
Funnily in my desperation I asked ChatGPT how it would solve this and it generated this code:
const messaging = admin.messaging(app);
const apnsKey = {
  authKey: '/path/to/AuthKey_XXXXXXXX.p8',
  keyId: 'XXXXXXXX',
  teamId: 'XXXXXXXX',
};

messaging.setApnsCredential(credential, apnsKey);

But I looked around the repo (even in older revisions) and could not find any method like this. Was there any and if yes, when and why was it removed?

As far as I know there's no official API function for this - I've been waiting on it for years aswell.


Check only at 9h, 12h, and 15h to avoid noise

The v1 of the bot publishes a message every our. This might be too much for some users, specially provided that most messages will be "there are no slots available".

As #3 was implemented, this issue is obsolete, closing


Cannot Update Transfer Allowance

Hi, I am trying to update my trading allowance so I can start bonding. I am having trouble as I keep getting the same error. Please see attachment. I have tried transacting at least 15 times. Any help would be appreciated.

Describe the bug (required)
A clear and concise description of what the bug is.
Expected behavior (required)
A clear and concise description of what you expected to happen.
To Reproduce (required)
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Device (required):

Device: [e.g. MacBook Pro, iPhone6]
OS: [e.g. iOS, Linux]
Browser [e.g. Chrome, Safari]
Version [e.g. 22]

Screenshots (optional)
If applicable, add screenshots to help explain your problem.
Console logs (optional)
Paste related logs and/or error messages from the console here.
Network issues, such as the cURL output from failing requests, can also be pasted here.

Additional context (optional)
Add any other context about the problem here.

Closing since the classic explorer was sunsetted.

Closing since the classic explorer was sunsetted.


Fix actions row component

Fixes a bug resulting from #3603. e2e will confirm the fix

Ok 👍 comments addressed


DP-1.2: qos_policy_config_test.go: Added required binding config for other vendors

Changes made for DP-1.2: qos_policy_config_test.go via this pull request
In TestQoSForwadingGroupsConfig,
Need to add queue ID as required by Juniper.
Related OC model change:  Add support for defining a queue identifier under queues. public#772
In TestQoSClassifierConfig
Need to add Forwarding groups defined in TestQoSForwadingGroupsConfig, as they are needed for classifier config
As the scope of the config in TestQoSForwadingGroupsConfig is local, it cannot be used in TestQoSClassifierConfig
Added new deviation for state paths which are not currently supported - deviation_unsupported_state_paths
In TestQoSInputIntfClassifierConfig,
Need to addForwarding groups config from TestQoSForwadingGroupsConfig and classifier config from TestQoSClassifierConfig
As the scope of the config in TestQoSForwadingGroupsConfig and TestQoSClassifierConfig  is local, it cannot be used in TestQoSInputIntfClassifierConfig
Added new deviation for state paths which are not currently supported - deviation_unsupported_state_paths
In TestSchedulerPoliciesConfig,
Needed to add Forwarding groups defined in TestQoSForwadingGroupsConfig, as they are needed for scheduler config
Added new deviation for state paths which are not currently supported - deviation_unsupported_state_paths
In TestECNConfig
Added new deviation for state paths which are not currently supported - deviation_unsupported_state_paths
Added new deviation for Drop/Weight knobs under queue management profile  which are not currently supported - deviation_drop_weight_leaves_unsupported
In TestQoSOutputIntfConfig,
Needed to add Scheduler config from TestSchedulerPoliciesConfig and Queue management profile config from TestECNConfig
As the scope of the config in TestSchedulerPoliciesConfig and TestECNConfig  is local, it cannot be used in TestQoSOutputIntfConfig
Added new deviation for state paths which are not currently supported - deviation_unsupported_state_paths
In this pull request, to remove redundant config calls, two new test cases are added testJuniperClassifierConfig and testJuniperSchedulerPoliciesConfig.
testJuniperClassifierConfig covers TestQoSForwadingGroupsConfig, TestQoSClassifierConfig and TestQoSInputIntfClassifierConfig
testJuniperSchedulerPoliciesConfig covers TestSchedulerPoliciesConfig, TestECNConfig and TestQoSOutputIntfConfig

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 57.219%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1181

Relevant Lines:
2064

💛  - Coveralls

Please resolve conflicts with the main branch

You do not need to create a new PR if you can merge the latest change.

No issues seen for merging , will go ahead with the current pull request

/gcbrun

/gcbrun


updating version for release

Hmm.  Doesn't compile under 11.1.1.  Trying to figure it out...

OH!  That was a problem in my environment.  Merging....


Can't do Gradlew Build. Probably Gradle version? errors in Android manifest? or on Java?

D:\Arcanium\Godot\godot215ssc>scons platform=android target=release_debug
scons: Reading SConscript files ...
MSVC not detected, attempting Mingw.

could not detect gcc.
Please, make sure a path to a Mingw /bin directory is accessible into the environment PATH.

Godot Android!!!!! (armv7) (with neon)
Using NDK unified headers
scons: done reading SConscript files.
scons: Building targets ...
[ 97%] Linking Shared Library ==> bin\libgodot.android.opt.debug.armv7.neon.so
[100%] progress_finish(["progress_finish"], [])
[100%] scons: done building targets.
D:\Arcanium\Godot\godot215ssc>cd platform
D:\Arcanium\Godot\godot215ssc\platform>cd android/java
D:\Arcanium\Godot\godot215ssc\platform\android\java>gradlew build

Configure project :
The setTestClassesDir(File) method has been deprecated and is scheduled to be removed in Gradle 5.0. Please use the setTestClassesDirs(FileCollection) method instead.
The getTestClassesDir() method has been deprecated and is scheduled to be removed in Gradle 5.0. Please use the getTestClassesDirs() method instead.
The ConfigurableReport.setDestination(Object) method has been deprecated and is scheduled to be removed in Gradle 5.0. Please use the method ConfigurableReport.setDestination(File) instead.
[Fatal Error] :32:6: The processing instruction target matching "[xX][mM][lL]" is not allowed.

FAILURE: Build failed with an exception.

What went wrong:
A problem occurred configuring root project 'java'.

Exception while parsing the supplied manifest file D:\Arcanium\Godot\godot215ssc\platform\android\java\AndroidManifest.xml

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

Get more help at https://help.gradle.org

BUILD FAILED in 2s

The issue template asked for your Godot version and OS, please fill this information. It can be guessed by a clever reader, but shouldn't have to be.
Also, what is your NDK version?

Uhmm.. Its android-ndk-r18b..  Still searching about the godot version and OS


Add variable outputs when calling a contract

Description
When calling a contract that does a transfer of coins, we need to also add a new variable output to inform that something will be created from that method call.
Example
fn transfer_coins_to_output(coins: u64, asset_id: ContractId, recipient: Address) {
    transfer_to_output(coins, asset_id, recipient);
}

Note that without simulating the tx, there's no way to know how many variables outputs you need. Therefore it should simply be let up to the user to append as many as they want. The Rust SDK does this.


Simplify c8y_api::smartrest::topic module avoiding all redundant code to create topics

Is your refactoring request related to a problem? Please describe.
The c8y_api::smartrest::topic has various mechanisms to generate SmartREST topics for the main device, immediate child device, nested child devices and services. The recently introduced publish_topic_from_ancestors API already covers most of these cases and the rest are just redundant, especially the ones like C8yTopic::ChildSmartRestResponse, dedicated for immediate child devices only.
Describe the solution you'd like
Refactor the c8y_api::smartrest::topic module with a smaller set of helper functions to create topics for all kinds of targets: the main device, immediate child device, nested child devices and services.

There also seems to be an important difference in behaviour between publish_topic_from_ancestors and C8yTopic::to_topic for ChildSmartRestResponse(String) variant:

publish_topic_from_ancestors uses entity's ancestors, so when a child is nested, it creates a topic that contains all devices in the hierarchy:
https://github.com/thin-edge/thin-edge.io/blob/e4fdb007ebd3ca6848214187e84897a623e55f33/crates/core/c8y_api/src/smartrest/topic.rs#L88-L92

C8yTopic::to_topic doesn't take nesting into account, so smartrest publish topics it generates for nested child devices may be wrong
https://github.com/thin-edge/thin-edge.io/blob/e4fdb007ebd3ca6848214187e84897a623e55f33/crates/core/c8y_api/src/smartrest/topic.rs#L19-L55

C8yTopic::to_topic is used by the availability actor, so is it possible it may not work correctly for nested child devices?


Reduce action runtime

I have projects which take about ~30s to build where adding the provenance only workflow to those projects significantly increases build time because building slsa-github-generator takes >2min.
It would be good to reduce build time, or otherwise decrease the runtime of the action, before encouraging wider adoption.

Thanks for raising this problem. A quick look at the e2e integration tests (https://github.com/slsa-framework/example-package/actions/runs/2357668677) show that building the builder takes 2mn, while other VMs finish in a few seconds. So I think this is the bottle neck.
How about creating a container image for the builder itself? We need to think about how we prove that the image is "authentic", ie that it comes from our code base. Either:

We publish provenance for it (do-able using the ko trusted builder, but requires ko to be ready)
Use a Dockerfile for the action, and pull the builder binary from the GH release assets and verify its provenance before using it.

Thoughts?

I'm working on this. TL;DR:

I'll introduce a new workflow option compile-builder which will optionally build the builder from source. By default it will be false. We need not advertise this option.
For releases of the this rep and the slsa-verifier, we'll always build from source
When users build, they will mostly use the pre-built builder. So the code will roughly do:
3.1 Resolve the @hash to a version/tag (for v1 we're not going to support hash but the code will be there anyway)
3.2 Given aversion (@v1.2.3 or resolved from previous point), we will download the builder's binary and provenance
3.3. We will download slsa-verifier from release and verify its hash with a hardcoded value
3.4. We will use the slsa-verifier's binary to verify the provenance of the builder (commit hash, tag, source)
We will run the builder

Note: for the verifier, we need a hash since the verifier cannot verify itself, i.e. it's untrusted upon download. So we will keep a list of good hashes in the verifier's repo. After a release, I will create a PR with a mapping between a release binary and a release tag. Other maintainers will verify the hash of this binary is correct by:

Locally download the untrusted verifier binary from the release assets
sha256sum this untrusted binary
Clone the verifier source code locally (trusted, since it has code reviews turned on)
Build the verifier as trusted-verifier
Run the trusted-verifier on the the verifier binary downloaded in step 1

See https://github.com/slsa-framework/slsa-github-generator/pull/86 and https://github.com/slsa-framework/slsa-verifier/pull/63
Once they are merged:

I'll cut a v0.0.1 release for the builder
I'll cut a v0.0.1 for the verifier, using the v0.0.1's builder release
We-ll update the verifier hash as described in previous comment
We'll update the hash https://github.com/laurentsimon/slsa-github-generator/blob/feat/fastbuilds/.github/workflows/builder_go_slsa3.yml#L30

From there we can update the hash/tag of the verifier when we need to.

going to cut a v0.0.1 release to test the entire flow today. The verifier will only accept reusable workflows pinned by tag (not by @main). The builder supports pinning by hash, but not the verifier yet. We can do that later - see discussion in https://github.com/slsa-framework/slsa-verifier/issues/12

@joshuagl can you check the new builder @v0.0.2 and tell me if the build is faster? The builder's binary is pulled from the release assets; it takes ~20s instead of ~2mn. However the overall build will still take longer depending on VM scheduling.

I think we can close this for the Go builder?

This is done. Closing


Could you provide an example of Http Scan Source (not lookup source) ?

Could you provide an example of Http Periodically Scan Source (not lookup source)? Does it support renew access token after expiration?

Hi @ChenShuai1981
Scan source is currently not supported by this connector, hence no example available :) for now we have only lookup source. Although this would be a great feature, would you like to contribute? :)
The propert Flink interfaces would have to be implanted. I can provide you more details after dec 20th when I will be back from my vacations

@ChenShuai1981 the lookup support that exists currently ends up issuing gets, puts or posts on single records. For the scan to work, I suspect we would need to issue searches, and get involved with paging the results. This could really impact performance of a scan, as we could end up effective doing table scans, unless we could do predicate pushdown.


Ignite Expresso

Please verify the following:

[ ] yarn test jest tests pass with new tests, if relevant
[ ] README.md has been updated with your changes, if relevant

Describe your PR

Reworks react-native-bootsplash CLI for Expo only and removes related dependency
Fixes issue where<EMAIL_ADDRESS>didn't allow for npx expo run:android or npx expo run:ios to work properly without expo-dev-client by removing this dependency (brought down by Expo with the correct version)
Removes other (hopefully) unused dev dependencies
Regenerated the native dir templates via npx expo run
Updates to Expo SDK 49 official release
Adds expo-build-properties and configuration spot in app.json for enabling New Architecture

Images
QOL changes to cli for icon / splash generator

@josh this PR has the bootsplash cli changes (among regenerating native dirs). If you could review the cli changes (just filter on src) - you can ignore all the native ios / android dir noise.
The test is failing looking for the proper android/ios changes - however these are updated via the npx expo run:android and npx expo run:ios commands / prebuild.
so I think we need to modify the test to drop that and just trust the Expo one works as it puts everything in the proper place when configured in app.json


Increase odds ratio resolution to 4 decimal points

Context
As reported by @mohdkarim and @Jeremy37, for the next study-locus link, we are displaying an odds ratio of 1 and CIs of (1.0, 1.0)

)
However, as it can be seen on the API response, we have more resolution for the odds ratio. The fact that the p-value is 3.0e-15 is telling us that the deviation between 1 and 1.0073 is relevant, so it would be good to be able to see the difference.
Action
Can we please increase the resolution of the odds ratio and the confidence intervals to 4 decimal points?
This implies updating:

[ ] The study locus page as shown in the previous screenshot
[ ] The study page table as shown in the next screenshot for the same study
[ ] The associated studies in the gene page link

@d0choa there is a single function called significantFigures that uses the d3-format library to render all numbers found in Open Targets Genetics.
Unfortunately, the current implementation does not provide granularity to specify a certain precision for odds ratio numbers and a different precision for L2G scores or p-values.
If I change the function to show 4 decimal points (deploy preview), this is what it would look like on a study-locus page.

And using the example you provided above -- Diabetes or endocrine disease and locus around 7_100691506_A_ATTTTTTT -- if I set the function to show 5 decimal points so that the odds ratio value of 1.0073 is visible, this is what it looks like.

Which option do you prefer?

I see. The abstraction that assumes all figures will require the same resolution is probably not a good idea. Different numbers have different interpretations and might require different levels of resolution for reasons that are hard to generalise.
If @carcruz thinks it's the right strategy, we can create a second helper function significantOdds and apply it on odds ratios and their respective confidence intervals

I agree, I don't think it is ideal that all numbers are treated the same as some numbers require different levels of precision. I have closed the corresponding PR - https://github.com/opentargets/genetics-app/pull/206 - as this issue requires a more comprehensive fix.


Build image per pelorus exporter

Fix for issue #358.
Currently pelorus builds exporters as one, meaning each exporter is exactly the same,
just the name of the image differs.
This improves how we are building and publishing images to image registry,
ensuring each exporter contains only requires set of python files.
Futher work will involve ensuring we are installing only those
requirements that are needed per exporter.
Symbolic links in each exporter are created to ensure backwards compability
with the current helm charts and it's data from values.yaml.
Github action to build image was updated to use v2 version of s2i image and
some variables were introduced to easy testing in a separate quay.io namespace.
Describe the behavior changes introduced in this PR
Linked Issues?
resolves # <-- Use this if merging should auto-close an issue
related to # <-- Use this if it shouldn't
Testing Instructions
Please include any additional commands or pointers in addition to our standard PR testing process.
@redhat-cop/mdt

@mpryc I wouldn't worry about introducing non-backwards compatible changes. We don't allow/support/recommend/document intermixing older/newer versions of the exporters together so compatibility-wise it won't be an issue.

A couple thoughts:

Is this still a WIP? If so, we should mark it as a draft.
We said we wanted to use the makefiles as the standard way of setting up the environment-- do we want the github actions to use make? Then we're not updating things in multiple spots each time.
Is there a reason to have the additional layer of pelorus_common? Can we put requirements.txt and setup.* in exporters/pelorus?

Or maybe symlink to pelorus instead of pelorus_common?

Will a symlink out of the context dir work in the first place? If we want to make the image only include what's necessary, then we still need to keep the other directories when we do this. Maybe we should delete the other directories at build time?

@KevinMGranger

Is this still a WIP? If so, we should mark it as a draft.
I had this as draft when was testing locally, but now it's not. We need to make decision if this is the right approach or drop it.

We said we wanted to use the makefiles as the standard way of setting up the environment-- do we want the github actions to use make? Then we're not updating things in multiple spots each time.
Definitely, but not as part of this review. Filled issue #374 for that.

Is there a reason to have the additional layer of pelorus_common? Can we put requirements.txt and setup.* in exporters/pelorus?
I remember why I did that. In short isort was unhappy with the order in which the imports were pulled and there was difference on the local venv system versus github actions. I fixed it in the last commit by adding .isort.cfg and explicitly stating pelorus is known_first_party package. Note that this caused isort to reorder a bit the imports in various files. But now both venv and github is giving same results.

Or maybe symlink to pelorus instead of pelorus_common?
Yes I like symlink better.
In the latest revision of this PR I have removed requirements.txt from pelorus_common all together. Each exporter is using pelorus_common not as real python library but more of a folder with just one common python script and then it should list it's dependencies in the requirements.txt

Will a symlink out of the context dir work in the first place? If we want to make the image only include what's necessary, then we still need to keep the other directories when we do this. Maybe we should delete the other directories at build time?

Not really. Source 2 image makes it easier as symlink is being created on the resulting image as a standard folder with content in it (content from what was in the symlink).
I have updated latest revision as there was also file conflict from your last merge.

I am closing this PR. Currently we are building images, not fully optimized, however if needed this will be implemented different way. Current codebase have lot's of newer changes and many of the conflicting files, so it's easier to create fresh change, but it's not priority atm.


TabBarItem's badge icon position for non selected tab.

@v-braun & @Kladdkaka How to manage the badge icon position for non selected tab. Here I am sending you the screenshot for your reference. Can you please provide us a way to manage the badge icon.

You have to position it yourself, check this out:
https://stackoverflow.com/a/38973225

@v-braun Thanks for your reply. It helped me to change the position of the badge item. There is one weird issue which I am facing, in a few devices tab bar is showing a separator line as shown in the below attachment.

Can you please help me out with this?

Looks like there is a system style that provides this separator (maybe a special ios version or something else). It only happens on specific devices right? have they another ios version??
Maybe this will help (the last sentence in the post):
https://blog.k.io/atech/set-the-top-border-colour-of-a-uinavbar

In order to hide the system border, I have found that it’s usually enough to simply set the clipsToBounds property on the tab bar to true.

self.tabBar.clipsToBounds = YES;

@v-braun Thanks for the support. That worked for me.


[Preview 2] - dotnet cli tools only work from users nuget packages dir

I have project A and project B in my solution.
Project A is a tool similar to: https://github.com/aspnet/IISIntegration with an output name:  dotnet-gluon-tool
Project B  is an application that uses the tool - I have added a project reference to the tool project, and the project.json looks like this:

"dependencies": {
 "Gluon.Tool.Build": "1.0.0-*"
},

"tools": {
 "Gluon.Tool.Build": {
      "version": "1.0.0-*",
      "imports": [
        "portable-net45+win8+dnxcore50",
        "portable-net45+win8"
      ]
    }
}

Now if I cd into Project B's project directory and run dotnet gluon-tool I get this:

It seems dotnet cli only searches the nuget package directory?

Have raised this in the dotnet cli repo instead

Known issue: https://github.com/dotnet/cli/issues/1215


Refactoring of msct_register and add more testing

Following-up on the initial refactoring of sct_register_multimodal and sct_register_to_template in #2331, a deeper refactoring is needed. Notably:

Move msct_register into a proper Python module: spinalcordtoolbox/register/register
Move msct_register_landmarks into spinalcordtoolbox/register/landmarks
Add unit tests for the rotation estimation. To do so, generate an image, rotate it by a known angle and run each method.

Started looking at this. There is a bunch of code that has dependencies in the scripts/ folder.
My strategy will be:

Move the high-level stuff in sct_register_to_template.py and sct_register_multimodal.py.
Move the lower-level stuff in spinalcordtoolbox/register/register.py and  spinalcordtoolbox/register/landmarks.py.
Refactor low-level functions that don't respect proper layering (e.g. depend on stuff in scripts/).
Further refactor low-level functions following proper API best practices.

@Drulex excellent strategy! I just wanted to add that spinalcordtoolbox/register/register & spinalcordtoolbox/register/landmarks was only a suggestion, based on a quick analysis of the situation. If you find that other organization makes more sense, please feel free to suggest.

@jcohenadad I noticed that some registration functions make subprocess.Popen() calls to ANTS binaries. I would like to avoid this type of code in the API, mainly because the API is being refactored to deal with low-level objects (Images) and this methods constraints us in creating files on the disk and passing them to ANTS.
From what I see the code calling ANTS seems to be tightly coupled to the registration logic, thus making it impossible to move the Popen() calls to the application layer.
I see two options:

Use the ANTS API (https://github.com/ANTsX/ANTsPy). I haven't evaluated the effort of this, but it seems that ANTSImage is also based on numpy arrays so I can't imagine this would be too difficult.
Keep using the Popen() calls (for now).

Use the ANTS API (https://github.com/ANTsX/ANTsPy). I haven't evaluated the effort of this, but it seems that ANTSImage is also based on numpy arrays so I can't imagine this would be too difficult.

yes, that would be awesome indeed. Related to https://github.com/neuropoly/spinalcordtoolbox/issues/2007. Maybe during the course of this refactoring we could keep the Popen(), but at some point i would love if we could remove the system calls.


Fix ol3cs.setEnabled

Disabling a disabled ol3cs is an error and is now avoided.
Make the API more regular by requiring a parameter.

+1

Thank you for the review @fredj.

@gberaudo, for API breaking changes like this, please also include a note in CHANGES.md in the pull request.
Since you merged this pull request already without such a note, please create a follow-up pull request.

@ahocevar, you are totally right. Please see #183.
Once it is merged, I am going to prepare the March release.


Mapping out footpaths

At the ATI visit today this was flagged as a priority. The current situation:

Historic footpaths, many of which have been in use for hundreds of years, must be maintained by land owners by law and they are used by people who know where they are based on local knowledge or Ordnance Survey data.
There is essentially zero data on the attributes of footpaths. The only way to know if a footpath is blocked or unpassable or unpleasant to use (e.g. muddy, thorns covering crossing points, stiles not working) is to go there.

This project idea is new and the scope needs to be tied down but it would like involve:

[ ] Map existing data on footpaths
[ ] Assess gaps in open data, primarily OpenStreetMap, where official routes that are mapped in OS are not in OSM
[ ] Crowd source updates to the data, e.g. via a progressive web app, and promotion by ATE, to do targetted mapping to fill the gaps in OSM
[ ] Use the data!

Public facing visualisation
Incorporation into LayerMapper project TBC
Incorporation into ATIP
Routing for leisure routes

We would want to link up with Slow Ways on this: https://en.wikipedia.org/wiki/Slow_Ways

Crowd source updates to the data, e.g. via a progressive web app

Worth checking around with StreetComplete and similar projects; the OSM community has had a big emphasis on assessing surface quality and accessibility of paths for cargo bikes and such.


Can't build on Visual Studio 2017 v15.8.9

What is the issue you have?
Can't build project using json.hpp standalone or with vcpkg on Windows x64 with VS 2017 15.8.9

Please describe the steps to reproduce the issue. Can you provide a small but working code example?
Try to build any project with #include "json.hpp"

What is the expected behavior?
Build without errors

And what is the actual behavior instead?
Build fails with these errors:

1>c:\users\[path]\json.hpp(918): error C2628: 'size_t' followed by 'unsigned' is illegal (did you forget a ';'?)
1>c:\users\[path]\json.hpp(918): error C2628: 'size_t' followed by 'char' is illegal (did you forget a ';'?)
1>c:\users\[path]\json.hpp(918): error C2886: 'size_t': symbol cannot be used in a member using-declaration
1>c:\users\[path]\build\src\predefined c++ types (compiler internal)(16): note: see declaration of 'size_t'
1>c:\users\[path]\json.hpp(921): error C2059: syntax error: 'type'
1>c:\users\[path]\json.hpp(11445): error C2628: 'uint8_t' followed by 'unsigned' is illegal (did you forget a ';'?)
1>c:\users\[path]\json.hpp(11501): note: see reference to class template instantiation 'nlohmann::detail::serializer<BasicJsonType>' being compiled
1>c:\users\[path]\json.hpp(11445): error C2628: 'uint8_t' followed by 'char' is illegal (did you forget a ';'?)
1>c:\users\[path]\json.hpp(11072): error C2760: syntax error: unexpected token 'char', expected 'type specifier'
1>c:\users\[path]\json.hpp(11467): error C2760: syntax error: unexpected token 'unsigned', expected 'expression'

Which compiler and operating system are you using? Is it a supported compiler?
Visual Studio 2017 v15.8.9 on Windows 10 1803
Visual C++ 2017   00369-60000-00001-AA083

Did you use a released version of the library or the version from the develop branch?
Released v3.3.0 and vcpkg's 3.2.0

If you experience a compilation error: can you compile and run the unit tests?
Instructions incomplete, I only get "test not available in configuration [*]" for anything I try in ctest.

Nevermind, I had a define breaking things


Update check command to replace tmp file path in comment out section

Issue
Fixes https://github.com/sanposhiho/gomockhandler/issues/88
changed

add replace process ded11c2a867624b9defee1945ccfba7626e05820
refactor func CalculateCheckSum so that the replace process only works when running check command 157a3f24957acdf88bdfcdb16e111657644b4fa5

replace process
I created a regular expression that corresponds to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(There are no comments that need to be fixed in v0.1.0 and v0.2.0.)
e.g.
Before:
//      mockgen -destination=usecases/mock/tmp_xxx.go
After:
//      mockgen -destination=usecases/mock/xxx.go
Thank you !!

@s4s7 Have you already check this patch solves the problem in your project?

Yes, I've checked this patch to solve the problem in my project with go install.

I corrected your review and confirmed the operation verification.


Custom shell commands

Describe the solution you'd like:

It would be nice if one could add custom commands to the UI. For example I have a backup script that I'd like to run only when I actually changed something in HomeBridge.

The backup feature of config-x is nice and all but it doesn't cut it really 🙂 Still would love to see this.


Feature Request: a hints mode command for opening multiple background tabs

Can you explain what exact you mean by this. Would this be similar to the "fb" comand but instead of existing hinting after a hint is selected it would allow to continue to selecting hints? What would be the preferred way to exist selection?


feat: Markdown Reference: Add Strikethrough & Tables Docs

Description
Added documentation for strikethrough and tables
Closes #3386
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hi @codedbyjordan 👋
It looks like there are some conflicts. Can you resolve them so I can have a look 😀


Shell context menu needs to escape semicolons in the path

From an internal thread:

Repro is very simple, create a folder named “Open_me_in_Windows_Terminal;calc.exe;”, copy “calc.exe” inside the folder and then, from within the folder, Right Click -> Open in Windows Terminal. You should see calc starting.

It even works without the exe ext, you can rename to folder foo;calc and rename calc.exe to only calc. Works with any name

There's a mail thread about this.

I fixed this in #11314 I think. I can't repro it in Terminal preview (1.13.10395.0)

OMG, you're right! Yay!
/dup #11273


Windows path with space

for example, there's project under c:\workspace\project 1\src.
When I typing 'tabnew c:\workspace\project ', it won't sugguest 'c:\workspace\project 1', but files under cwd.
When I typing 'tabnew c:\workspace\project\ ', trying to escape the space character, it suggests

If I type double '\', 'tabnew c:\workspace\project\ ', trying to escape the space character, it suggests nothing.

this may related to previous issue I mentioned: https://github.com/hrsh7th/cmp-path/issues/31
If I start with nvim -u NONE, type 'tabnew c:/me/ccw/ccw\ ', here use unix path delimiter, and use '' as space escaper, and press type, it will promots:

PR welcome

The new update fixed this issue. Thanks a lot!


Fix crash on null price range

I want to merge this change because... it fixes storefront crashes when the price range is null.

Screenshots

Pull Request Checklist

[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] The changes are tested.
[ ] The code is documented (docstrings, project documentation).
[ ] Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.rocks/graphql/

Task linked: CU-7jrvqj Cache issue when I go to the feature branch


Issue: Evaluators don't run after a ConnectionError

Issue you'd like to raise.
We've been getting intermittent connection errors after an evaluation run right before evaluators are run:
Error evaluating run 6058a864-6395-4df9-9800-237d90e7199f with DynamicRunEvaluator: LangSmithConnectionError("Connection error caused failure to get https://api.smith.langchain.com/examples/ace841ac-123c-4f38-bf58-87cc6637e133  in LangSmith API. Please confirm your internet connection.. ConnectionError(ProtocolError('Connection aborted.', RemoteDisconnected('Remote end closed connection without response')))")

This results in a run without any of the evaluator results.
Suggestion:
Looks like there could be connection issues but even if there are, the evaluators shouldn't be skipped and there should be a retry

Have seen this recently too - will work on resolving

Are you still running into this?

@hinthornw Haven't had connection errors recently so can't confirm whether this error still occurs


event: handle socket events more precisely

This adjusts the socket event to correct a potential spurious wakeup
which can incorrectly mark the socket as closed.
When working with a SOCK_STREAM socket, FIONREAD returns the total
amount of data that can be read in a single receive operation.
Normally, this is the same amount of data queued on the socket, but this
is not guaranteed as a data-stream is byte-oriented.  Additionally, a
read on a separate thread may have drained the data between the event
trigger and the ioctl to read the available bytes.  Only wake up the
handler if there are bytes to read.
In order to differentiate between the trigger for a close event and a
read-event, we explicitly check the close and the read or write event.
This allows waking the handlers one last time after a socket is closed.

CC: @rokhinip


LTI is not publicly available yet

At the LTI Office hours it was announced that Microsoft OneDrive LTI is not publicly released yet and won't be until December 2021.  It is only available in preview mode and we must sign an agreement in order to install the LTI.  It would be most helpful to make note of this on this page.  I spent a few hours trying to install the tool only to find out the authorization error we were getting was due to the LTI being in preview mode still.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6fee0615-eb33-e945-c1ee-efad095ead11
Version Independent ID: 2a7089da-e35a-8f39-3df1-98ee29710cb6
Content: Use Microsoft OneDrive Learning Tools Interoperability
Content Source: microsoft-365/lti/onedrive-lti.md
Service: o365-administration
GitHub Login: @MicrosoftHeidi
Microsoft Alias: heidip

@porterkim Thank you for your feedback. I'm working with the author on this one and will update you soon.
Thanks
Sri


Works on my Computer but not on my other computer

I know I have .net 4.0 or higher installed on both computers but it only works on my main computer, the code is very good when it works but I can't figure out why it doesnt work, any ideas?

What OS are the computers using? Is this in build or in editor? Are you getting any errors?


Redirects or support for common speedrun.com URL patterns

I'm not sure how elegantly these can be handled with next.js, but we'll figure something out.
Extremely hacky solutions allowed for the initial implementation.
https://www.speedrun.com/wc2/
https://www.speedrun.com/wc2/run/yvgnpe4y
https://www.speedrun.com/wc2/individual_levels
https://www.speedrun.com/wc2/Orc_01_Zuldare
https://www.speedrun.com/wc2/Orc_01_Zuldare#Mission
https://www.speedrun.com/wc2/full_game
https://www.speedrun.com/wc2/full_game#All_Campaigns
https://www.speedrun.com/wc2/gamestats
https://www.speedrun.com/user/ZPR
https://www.speedrun.com/user/ZPR/full_game
https://www.speedrun.com/user/ZPR/individual_levels
https://www.speedrun.com/ZPR (as a lowest-priority fallback, since this isn't canonical but I do use it)
Don't forget to add rel canonical meta tags pointing back to the source pages where appropriate (and maybe also visible links).

An "extremely hacky solution" might be something like useEffect(() => void window.location.assign(...)), even though that might mess up the back button and forces a full page reload.


upgradeStrategy params not omitempty for 0 values

This will allow these to have 0.0 for values.

LGTM


Complete implementation of /types endpoints in API

Hi @taliaga @c0c0n3 I want to contribute for this issue. Please assign it to me.

Hi @pooja1pathak, thanks for taking care of this!
I've just had a look at the code, it looks like it'd be best to implement a separate query in the translator rather than adding to the existing one. This will help going forward if we ever get around to replacing the string based query building with an AST based approach.
Thanks!

Hi @c0c0n3 I have implemented the code using query method in translator/crate.py. The code is working as per our requirement.
As per your comment https://github.com/smartsdk/ngsi-timeseries-api/issues/119#issuecomment-582796854 , I tried to build a new query method but unable to get the perfect query. I am still working on that.
I just wanted to know about your expectation from separate query, as same method is used on all other APIs. Is not it be more beneficial to update only one method if we replace the string based query building with an AST based approach in comparison to change different methods for different APIs?

Hi @pooja1pathak :-)

new query method but unable to get the perfect query.

Yea, I know. The code is pretty intertwined and there's no easy way to reuse single bits and pieces out of context. So if it's too hard to implement a separate query, rather add to the existing one. But please be extra careful, like go in with surgical gloves and scalpel, since the existing query method is QL's workhorse so whatever we do the existing semantics must stay the same after the change :-)

Is not it be more beneficial to update only one method...

If we go down the AST road, then we'll have to rewrite both the reporter and translator from scratch, so all methods will have to go. My thinking is that having a separate query method for types a this stage would make it easier in the future to see what's going on in the code since it should be easier to understand that bit of functionality in isolation...but I suppose this is a bit of a moot point. So like I said earlier, don't waste your time on this if it's easier to modify the existing query method without any side effects then rather do that :-)

@c0c0n3 Thank you for your response :-)
I would suggest to address the AST viewpoint in another issue. So, we can raise a new issue for separate query of each API and then we can investigate on that.
Regarding the current issue #119 we can proceed with existing query method.

@pooja1pathak

address the AST viewpoint in another issue

Agreed! At the moment this is just an idea and I'm not even sure myself it's worth our while looking into this, but will open an issue if one day we decide to go ahead with it.

Regarding the current issue #119 we can proceed with existing query method.

cool bananas, thanks!!!

As PR #293 is merged, we can close this issue.

thanks for reminding me!


fix writing ddf to text used in sql2txt and fetchRows, head, etc.

Fix this issue: https://adatao.atlassian.net/browse/PE-577
Cause of the issue: with complex data type in DDF, it uses general json writer to print out the content of DDF which add quotes to every string.
Result of the fix

string value is no longer in quote
column with null value is included as 'null' instead of being ignored

ok to test

Could you add a regression test?

for example?
I tested quite carefully, to be sure that the result is the same with what we had before complex type DDF.

Convert your manual tests into test cases. Those test cases are named
"regression", that is to ensure a bug is fixed.
On Fri, May 29, 2015 at 1:09 AM, Nam<EMAIL_ADDRESS>wrote:

for example?
I tested quite carefully, to be sure that the result is the same with what
we had before complex type DDF.
—
Reply to this email directly or view it on GitHub
https://github.com/ddf-project/DDF/pull/113#issuecomment-106541119.

--
If life gives you lemons, make lemonade.

I think, in this case, a test to make sure the string return does not have quote.
I will merge it now, but @namma can you still have the test.


Add a "runspace dump" on terminating error debug option

This would be similar to a process dump but instead would dump the script runspace, including loaded modules, variables, functions, stack that existed before the terminating error.

Where should it go?


Use correct type for options

If you can clean up these errors I'll merge this and do a 4.0.1 release.

If you can clean up these errors I'll merge this and do a 4.0.1 release.

Done. 🙂

4.0.1 release

Done.


Documentation "bug": Optional parameters + type order

I got warnings in my code base when using library functions with optional parameters, when using e.g. initializeDatabase.
Argument '2' passed to initializeDatabase() is expected to be of type PHPSupabase\optional, string given PHP(PHP0406)

https://github.com/rafaelwendel/phpsupabase/blob/main/src/Service.php#L160
Documentation : https://docs.phpdoc.org/3.0/guide/references/phpdoc/tags/param.html
In my case (VSCODE + DEVSENSE PHP extension) I got errors, as it parses the first word after the variable as the type. Which is Optional int this case.
And as I see now, the documented way of PHPDoc is even:
@param [<Type>] [name] [<description>]
And in this lib,
@param [name] [] [(optional)] []
is used mostly...
With also String needs to be a lower case string.
Or do you use another method/library for documentation?
Thanks!

Hello @Bartel-C8
You're absolutely right. I made a mistake when creating the tag annotations. I am already providing the correction for the next version.
Thank you for your contribution!

Set on 0.0.8 version


Bundle size

I am using create-react-app and run npm run analyze to see what is adding most into the final bundle size. I found out that the second largest item is s3.fine-uploader.core.js, which takes 146kb which is 5.7% of the bundle size. In order to use each possible opportunity to reduce the final bundle size, I created the issue to find out if there some ways to do so?
I use import FineUploaderS3 from 'fine-uploader-wrappers/s3';

I’m open to suggestions. If you have anything specific, please open up a pull request. Currently, I don’t see any issue with the bundle size


fix(sqllab):clickhouse result no column header

SUMMARY

version : superset 1.5.0
python : 3.8
connect db：clickhouse + http（8123）
if you run any clickhouse sql  with "format" keyword， returned results have no column headers，the first row of results will be the column header。

In this case, if the first column has a null value, an error will be thrown directly。
After troubleshooting, the problem lies in the referenced package clickhouse_sqlalchemy/drivers/http/connector.py:112

Therefore, the SQL with format keyword needs to add format parameters “FORMAT TabSeparatedWithNamesAndTypes” manually
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before

after

TESTING INSTRUCTIONS

1、run any clickhouse sql with "format" keyword. like
select subtractDays(toDateTime(formatDateTime(now(),'%Y-%m-%d 00:00:00')),2) as t
ADDITIONAL INFORMATION

[x] Has associated issue:
Fixes #19253
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

I think it is not necessary to rewrite query in superset. Instead, fix it in clickhouse_sqlalchemy.
See: https://github.com/xzkostyan/clickhouse-sqlalchemy/pull/180

Why clickhouse result no column header when using formatDateTime function,Thanks~

Superseded by #21195, closing


0.9.3 - Consumer offsets

Hey, I just need to get something clarified.
Consumer offsets are still stored in ZK under  /consumers/{group_id}/offsets/{topic_name}/{partition}, right? I'm getting some weird results with some "long running" topics that has been deleted before, but I'm guessing it's Kafka's responsibility to reset the offset of a consumer once a topic is deleted, or?

Yes -- the kafka server manages offsets storage and the paths in zookeeper.  There is now server support for storing offsets in a kafka topic instead of zookeeper, but kafka-python does not have support for that yet.

Thank you :)


Session generator providers

Fixes #5

Codecov Report

Merging #10 into master will increase coverage by 0.49%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   95.38%   95.87%   +0.49%
==========================================
  Files          18       18
  Lines         433      485      +52
==========================================
+ Hits          413      465      +52
  Misses         20       20

Impacted Files
Coverage Δ

aiodine/store.py
97.67% <100%> (+0.4%)
:arrow_up:

tests/test_generator_providers.py
100% <100%> (ø)
:arrow_up:

aiodine/__init__.py
100% <100%> (ø)
:arrow_up:

aiodine/providers.py
97.26% <100%> (+0.65%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dc0f6a...9e8c2ea. Read the comment docs.


Code completion in console

Having some issues with Pandas.
E.g.
import pandas as pd
df = pd.read_csv(r"C:\some_file.csv")
df.loc[:3]. <-- no code completion here.
Should be going deeper than this.

Unfortunately, without type hints (both in PTVS and in pandas), there's no way for us to figure out what will be returned. We simply don't have the information available without actually executing all of your code (which would be problematic if, say, you had code that deleted files - we wouldn't want to run that behind your back).
Hopefully with type hinting support (#82), pandas will be able to declare what type is returned from an indexing operation, or perhaps with #731 we'll just go ahead and special-case pandas (and hope that they don't change their design, or we'll be broken again).
I'm closing this as a duplicate, but it's a much wider concern for us than just one issue, so I can't point directly to a single equivalent report. We're certainly well aware that we need to improve in this area though.

Just an FYI, this is within the actual Console i.e. not in the editor (although that does not work but I would expect it).
iPython console is capable of completing in this case.

Ah, you're right, I misread that part.
We may disable inline evaluation for indexing, to avoid running arbitrary code too often. There's options to change the completion mode. But I believe that should only affect actual calls.
Is it possible that you're trying to get completions for an object that shouldn't have any?

No it definitely does.  If I manually type in something I get results back.
If I do the exact same call in same Jupyter or iPython I get auto complete results.  For whatever reason the console in this case is acting differently.  I tried changing the option you mentioned but for some reason it won't save.  The interactive window seems to be fixed on "Never evaluate expressions containing calls".

If you want to add another bug, the option you mentioned.  I can select it but it does not persist.

I think in the latter case we let IPython provide the completions, so maybe it's returning something here that we're not handling correctly.

This is still not evaluating indexing for the sake of completions, and it appears to be a limitation of IPyKernel (does the same thing in https://notebooks.azure.com). Changing this to an enhancement request, as we'll have to bypass the processing that we're explicitly exposing in order to do it.


What is this error

Describe your problem here.

Are you modding a build from source or with Lua?
Source
What is your build target?
Android
Which psych engine version you're on?
1.0 (Prerelease)
Did you edit anything in this build? If so, mention or summarize your changes.
No response

seems unreleated idk

https://lime.openfl.org/docs/advanced-setup/android/
just read this and you'll get it (read manuall install)


Finally it isn´t disconnecting

I´ve tried the method like youve done it but in the end i pasted the data and it doesn´t disconnect or something like that.
Are there some things, that i could possible have done wrong

I'm not sure that I understand the problem here, can you provide more data?


harfbuzz: 3.0.0 -> 3.1.1

Changelog
Motivation for this change
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

#149214 got merged (despite it was more recent than this one), so this PR is obsolete now.
Maybe you could try to ask on https://github.com/NixOS/nixpkgs/pull/154539/files if you still want to add yourself as a maintainer @erictapen


Carthage support

Would be great if this project could be installed via carthage.

@philipheinser
Carthage support has completed !

@ra1028 Awesome! Thanks!!


Support functions in local development server (graphcool-dev)

The local development server should support functions.
Deploying a service to the local development server should deploy all functions to a local faas environment. This should work seamlessly, and invoking functions from the Graphcool CRUD-API should work as normal.
Logs from local functions
It is possible to read logs from local functions like this:
docker tail -f localfaas

Npm modules
If you are using npm modules you need to have a package.json file and install the modules locally before deploying to Graphcool

I see that this issue is closed, but README states that

Note: functions are currently not working for local cluster setups (use the BaaS deployment for now).

When running graphcool deploy for an initial helloWorld example to my local Docker setup I get
Cannot read property 'pipesCount' of undefined

Am I missing something?

What's your graphcool version? Did you try graphcool local pull, then redeploy?

❯ graphcool version
graphcool/0.7.0 (darwin-x64) node-v8.0.0

I have just tried running graphcool local pull and graphcool deploy, but no luck, I get the same message

Could you please share your service definition + reproduction steps in a new Github repo? 🙂

Sure, but it's actually just as simple as graphcool init && graphcool local up && graphcool deploy

Here is the sample repo: https://github.com/wasd171/graphcool-local-function-error

Sure, but it's actually just as simple as graphcool init && graphcool local up && graphcool deploy

Can't reproduce this with graphcool/0.8.0-alpha.6 (darwin-x64) node-v8.3.0.

Could you try it with 0.8.0-alpha.6? I created https://github.com/graphcool/graphcool/issues/852 to further discuss this @wasd171.


Add @fabriciofx as a fan

Let's add @fabriciofx as a fan.

@yegor256/z please, pay attention to this pull request

@fabriciofx/z this pull request is too small, just 1 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @yegor256/z please review this and merge or reject

@fabriciofx thanks!

Job gh:yegor256/elegantobjects.github.io#61 is not assigned, can't get performer


unable to send email from taskboard

Hi Kiswa,
Greeting !
first of all thank you so much for making such a wonderful platform
I have setup taskboard ,setup a board .when i add a task and assign to a user email notification does not go to user,user  added with valid email ID .also I given SMTP details of Gmail as per field in mailConfig.php.
for your info i have enable less secure app support in Gmail.
please advise a solutions.
Warm Regards
Karunakar

I have never used the email functionality - it was provided by a PR - so I'm not really familiar with setting it up for anything other than using the hosting server's email functionality.
Maybe someone else can chime in on this one?

PHP mail function as far as I know.

Hi,
Thanks i have enable PHP mail function as well but email does not sent.is there any specific settting for this during taskboard install.I followed all standard process to implement.

I think gmail uses TLS and not SSL, so if you didn't already do, edit the api/mailConfig.php file and change
$MAIL_SMTPSECURE = 'ssl';                            // Enable TLS encryption,sslalso accepted $MAIL_PORT = 465;                                    // TCP port to connect to
into
$MAIL_SMTPSECURE = 'tls';                            // Enable TLS encryption, sslalso accepted $MAIL_PORT = 587;                                    // TCP port to connect to

If @deligant's answer doesn't help, try to contact @Shattenjagger as they contributed the email PR.
I have it on my list for the re-write branch to learn the mail functionality and make some tweaks so I will be able to support it in the future.

@Shattenjagger Greeting !!
can you please advise how to use this email PR setting ,i have setup taskboard everything seems fine except email alert when we add a task and assign to user.I have done all setting in mailConfig.php as per @delihant's Guide  but still this module is not working we don't get any alert when we edit add new task.
Thanks
Karunakar

I have the same problem. Please keep us posted on any solutions.
@deligant gmail uses ssl (currently using it with no problems e.g. for dokuwiki)

As another user suggested, you can comment out the entire content and mails should go out throught the normal MTA of your server (at least on linux).
this article may help you in setting up Google SMTP account
http://www.serversmtp.com/en/smtp-gmail-configuration
Third point is... sender email should exists (in order to receive the complaints of the mail servers implied in the process)

@deligant third point was right on target! I just filled the whole email address in $MAIL_FROM and it worked immediately. Thank you!

Is this issue resolved?


[controlapi] Allow filtering secrets by one or more service IDs

This add an extra filter list to ListSecrets that takes service IDs.  This can be used for example to list secrets that are only referenced by a particular service ID.
cc @aaronlehmann @dhiltgen

I know we discussed this previously, but now I'm wondering why this needs to be provided by SwarmKit. Why can't the client fetch the services it's interested in and see what secrets they use?

@aaronlehmann it's just a convenience method, instead of returning all the services we return just the services that match. If it doesn't make sense to support it, we can implement client side:

Request all services
Check for each service if they have secret X
Print only services that have secret X

@aaronlehmann it's just a convenience method, instead of returning all the services we return just the services that match. If it doesn't make sense to support it, we can implement client side:
Request all services
Check for each service if they have secret X
Print only services that have secret X

That's not quite what this PR does. It returns secrets that match a set of services. You can already do this by inspecting those services and then requesting the secrets that they reference.

In my mind what I want to see on the client side is:
docker secret inspect X also displaying the services that currently use this secret.

This would be a highly valuable usability enhancement for chaining filters together. If a user wishes to answer the question of "which secrets with label key=value are used by service X?", then having a service filter allows them to directly perform docker secret ls --filter service=id --filter label=key=value.
If they wish to accomplish the same use case through docker service inspect, they need to inspect the desired service, extract the list of secret names, perform docker secret ls --filter label=key=value, and correlate then correlate the two lists together.

@cyli what about doing this client side?

@diogomonica The feature request was for API-side.


Document minimal fixed time program

Also created an overview page and one on configurations.
https://github.com/rsmp-nordic/tlc_progamming/blob/main/overview.md
@otterdahl care to have a look?

@otterdahl I updated the fixed-time doc at https://github.com/rsmp-nordic/tlc_progamming/blob/main/fixed_time.md, to remove smart commands.
I changed the structure to be even simpler, just showing the state of all groups at each transition times.
I took (some) states from https://rsmp-nordic.github.io/rsmp_sxl_traffic_lights/1.2.1/signal_group_status.html, is that a relevant list, or do we need a different list of allowed states?

Seems good to me. Writing the explicit state for all the signal groups at a given time is a good simplification for both generating and interpreting sides.
The signal group state is an expected result when the signal program is running on the TLC so the "visualization" is without a doubt useful. It might be a bit tricky to use it in a definition of the signal program, as it reflects rather a logical state of the signal group. That means there are multiple codes for the same signal. I would recommend explicitly defining a subset of codes that can be used in a fixed time signal program. Then there would not be any issues.

It might be a bit tricky to use it in a definition of the signal program, as it reflects rather a logical state of the signal group. That means there are multiple codes for the same signal. I would recommend explicitly defining a subset of codes that can be used in a fixed time signal program. Then there would not be any issues.

OK, at an upcoming meeting let's talk about what states we should include.


Files tab, conditional rendering

@ mention of reviewers
@ihsaan-ullah @Didayolo
A brief description of the purpose of the changes contained in this PR.
If no files to list, Files tab is unselectable and not shown.
Issues this PR resolves

#1439

A checklist for hand testing

[x] Find a competiton
[x] Make sure there are no files participants should be able to see
[x] Make sure you are in a phase
[x] Look and make sure Files is not shown

Checklist

[x] Code review by me
[x] Hand tested by me
[x] I'm proud of my work
[x] Code review by reviewer
[x] Hand tested by reviewer
[x] CircleCi tests are passing
[x] Ready to merge

Thanks Benjamin!


Project start date before end date validation

Project creation allows end date to be before start date.

What I changed:

The start_date is set to the current day or a day in the future
The end_date is set to a date after the start_date
I removed the ability to view the weeks that were situated at left since they did not come in with italics, and therefore looked awkward in normal typeface.

In the future, we'll have to add the styling to the disabled dates so they're visually different than the enabled dates. (I'm thinking a light gray background?)


Force Chrome to Download PDF instead of opening

Though I've disabled the pdf-viewer plugin of chrome, and even installed a downloader inside chrome, wheneve I open a link which directs to a pdf file, Chrome keeps opening it instead of downloading, Any hint? Thank you.

After reading sample code from examples.xlsm I found this:
.SetPreference "plugins.plugins_disabled", Array("Chrome PDF Viewer")
which solved the 'issue' :)


cue: avro support

It would be nice to support import (and potentially export) of the Apache Avro schema and data formats.

This issue has been migrated to https://github.com/cue-lang/cue/issues/128.
For more details about CUE's migration to a new home, please see https://github.com/cue-lang/cue/issues/1078.


Cannot list datasets beyond page 500

In the context of a research project, I would like to gather metadata about all datasets that match certain keywords (e.g., age). Conceptually, this should be no problem with the Kaggle API by iterating through the result pages.
However, I noticed that there seems to be some kind of shadow limit on the number of result pages for a search query. For example, the query age [1] has about 16K results according to the web UI. Nevertheless, every result page beyond 500 is empty.
Thus, my question: Is there any way to acquire dataset metadata for queries with more than 10000 results?
[1] https://www.kaggle.com/datasets?search=age

Hi @lbhm - it's true that there are limits on how far back you can search via the API.  We may look into revising those in the future, but there's no definitive timeline at this point.  One workaround could be using the Meta Kaggle dataset.  Admittedly, this would only allow you to query titles, so it's a bit less than you'd get from kaggle.com, but perhaps it's sufficient for your purpose.

Thank you for the quick response @jplotts.
Unfortunately, just having titles/IDs is not quite enough for us. In this research project, we are looking into dataset search techniques that go beyond basic keyword search, so I am especially interested in column statistics (e.g., ranges, number of unique values, null values, etc.) to explore new search techniques.
Please allow me two follow-up questions:

In the web UI, you are already showing detailed column statistics, such as value distribution histograms. Are there any plans to make these statistics available via the API in the near or mid-term? A simple list representation of histograms (like in numpy for example) would already be really helpful for us.
Is there an upper limit on how many datasets I am allowed to download to generate such column statistics myself? Given the list of all dataset IDs from the Meta Kaggle dataset, I would also be fine with downloading them and computing statistics on our own hardware.

Hi @lbhm -

I agree that the column statistics would be nice, but unfortunately, that's not on our roadmap right now.
We have rate limits on our API endpoints to prevent abuse.  We don't track the total number of downloads a user makes, so you can download an arbitrary amount as long as you spread the requests out.  I can't provide specific rate limit numbers (they may change anyway), but we believe they are sufficient for most reasonable use cases.

Alright, I'll download the datasets with an appropriate rate and recreate the column statistics myself then.
Thank you for your help!


Submission to ICLR 2023 Blogposts Track

This is our submission to the Blogpost Track.
Nevertheless, we seem to have an issue with the citations and would love to ask for assistance in resolving the issue.

Sure! What issues are you facing?

Sure! What issues are you facing?

Great, thank you very much!
For some reason, our citations are not appearing in the main text and we don’t have an automatically generated references appendix. I‘m not sure why, because I just used the template of the example blog post.

Ok I think I figured it out. It seems to be a problem with your description; I was able to make things work by:

removing any quotes (both double and single) in the description
removing any citations in the description
removing any hrefs (or any html really) in the description.

With that, it seems to be working:

Okay, I removed the quotes and reduced the size of the large video. That's interesting, that even the quotes led to issues!
Regarding the rendering issue, I hope the smaller size fixes it in your case because everything renders OK when I host the blog locally.

Sounds great - I'll merge it in and we'll see if it works! If not we'll try to diagnose it afterward.

Hmm unfortunately it seems like they don't render:
https://iclr-blogposts.github.io/staging/blog/2023/Adaptive-Reward-Penalty-in-Safe-Reinforcement-Learning/
I'm not sure what the issue is here but could you possibly test locally on a linux device?

Hmm weird, for me, everything renders when I click on the link! I'm running on MacOS Monterey.

@sudo-Boris
I think I figured out a workaround that should work - could you refer to my response in #17? I'll admit it's not ideal (I'll see if I can figure out how to incorporate videos into the figure html env), but for now this renders locally for me so I expect this to work on github pages.
Note that I did revert the merge so you'll need to open a new PR - when you do, could you also undo the changes to the docker-compose and template .bib file? Thanks a lot!

Okay, I will change the code of including videos in the blog as you have mentioned in #17, I will undo the changes to the docker-compose and template .bib file, and I will open a new PR.

No worries, everything seems to work out in the end, and that is what counts :)
(Just to mention, the  text appears in black even when the blog is set to dark mode and is pretty hard to read. At least in my local render).


Version bump to 1.10.3

@tommyip Is there anything else I can do to help with the merge?

Hi @dvdbrk thanks for the PR, let me have a look at this today.

Published v1.10.3 to npm 🚀


Feat: Adding a password toggle btn for stakeholders

Issue Summary
Enhancement
Issue Description
Add a password toggle button in the password field of signup and login page for stakeholders
Proposed Solution (Optional)
No response
Priority
Medium - Should be addressed soon
Category

[X] Enhancement
[ ] Refactor
[ ] Security
[ ] Design
[ ] Other

Additional Context (Optional)
No response

@Harshdev098 The password toggle button is also not present in the password field of the signup and login page for students, so I'll add it there too.

A pull request is already open #95

A pull request is already open #95 for that

Ok, then I'll only add for stakeholder.


running as root

Would there be any problems if I logged in and ran as root all the time?  I know all the yadda yadda about why I shouldn't but this is a technical question.  I know about sudo -i but I wonder if I can allow root login and if there would be any software that chokes when running as root.
I've used nothing but single-user servers as root for 25 years and I really hate typing sudo.

For others following along at home:

Don't do it.
Don't do it.
This is a terrible idea and it's highly likely you'll break your chroot even during routine usage, and/or get smashed with malicious code if you're touching the internet inside your chroot.
"I don't like typing sudo" is pretty much the worst justification you could use for taking this route.
Really, don't do it.

For @mark-hahn: join #crouton on IRC if you really want to do that.


Autodetection function

if you delete the WPC database (wg_portal.db), but leave the wg0 file unchanged - containing the parameter # -WGP- PrivateKey: xxxxx...... then the newly created database does not load this parameter for auto-detected clients, after which it is overwritten, and further connection of this client via .conf or QR will not be possible, because the private key will be lost. Please fix it

The importer does not parse the wg quick config files, it uses the wgctrl API which does not provide data like peer private keys.


[Bug]: Helm charts not picking up the values specified in values.yaml

Is there an existing issue for this?

[X] I have searched the existing issues

Description
I am using below commands to install appsmith helm charts
helm install appsmith appsmith/appsmith -n appsmith --set applicationConfig.APPSMITH_ENCRYPTION_SALT="<salt>" --set applicationConfig.APPSMITH_ENCRYPTION_PASSWORD="<pass>"
but when I ssh into the pod and do
cat /appsmith-stacks/configuration/docker.env
I find different values. It seems like charts are not picking up the values.
Steps To Reproduce

Run helm install appsmith appsmith/appsmith -n appsmith --set applicationConfig.APPSMITH_ENCRYPTION_SALT="<salt>" --set applicationConfig.APPSMITH_ENCRYPTION_PASSWORD="<pass>"
ssh into appsmith-0 pod
Run cat /appsmith-stacks/configuration/docker.env
Search for APPSMITH_ENCRYPTION_PASSWORD key and you will find a random value.

Public Sample App
No response
Issue video log
No response
Version
2.0.0

I have also tried cloning the values.yaml locally and installing the application using below command
helm install appsmith appsmith/appsmith -n appsmith -f values.yaml but no luck.

Hey, in kubernetes/helm based appsmith deployments the values mentioned in applicationConfig will be present as an environment variable.
Thanks


fixed typo

"Visual 2019" to "Visual Studio 2019".

@jedieaston : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Add ability to download shallow clones when doing homeshick clone.

When I do homeshick clone, I would like to specify git clone's --depth option as to not download the entire git revision history.
If I'm not mistaken, the https://github.com/andsens/homeshick/blob/master/lib/commands/clone.sh should be edited, so when I have time I can submit a PR where you can witness my horrible Bash skills.

While there may be a valid use-case for this, you have to keep in mind that we could also come up with use-cases for the remaining 21 switches of git clone (and arguments, see #155):
git clone [--template=<template_directory>]
          [-l] [-s] [--no-hardlinks] [-q] [-n] [--bare] [--mirror]
          [-o <name>] [-b <name>] [-u <upload-pack>] [--reference <repository>]
          [--dissociate] [--separate-git-dir <git dir>]
          [--depth <depth>] [--[no-]single-branch]
          [--recursive | --recurse-submodules] [--[no-]shallow-submodules]
          [--jobs <n>] [--] <repository> [<directory>]

Where should we stop?
Regardless, I built homeshick to be highly hackable and easy to keep up-to-date with an upstream, so I encourage you to make the modifications and just run your own fork (lots of others do this :-)).
Closing as won't fix.


Example, the advanced way

I would be nice to have an example of the advanced way to do things.

@SyntaxRules, not sure I follow; do you mean a full, working app?


When using libtorch, gpu decoding is slower than cpu.

When using gpu to decode, gpu memory gets allocated but gpu-util rises after a lot of time.
For example, if you proceed with decoding 600 voices, it progresses very slowly until about the 100th, and then speeds up from the point when gpu-util rises.
Increasing the number of threads in decoder_main.cc makes it faster, but I'd like to fix the problem when it's single-threaded.
What should I do?
cpu = 24 cores
gpu = rtx a5000(24gb) x 2
ubuntu 20.04.4

Same symptoms when tested on cpu.
(Speed increases after a certain number of progress)
There is a big difference in speed in the 'forward_attention_decoder' api part, but I don't know if it's an attention problem or a libtorch problem.

Same symptoms when tested on cpu.
(Speed increases after a certain number of progress)
There is a big difference in speed in the 'forward_attention_decoder' api part, but I don't know if it's an attention problem or a libtorch problem.

The slow decoding at the begging maybe caused by libtorch, libtorch model requires warmup.

The slow decoding at the begging maybe caused by libtorch, libtorch model requires warmup.

What number should I specify when using warmup?
Should I do a test?

Seems 100 is okay in your testing.

Seems 100 is okay in your testing.

Thank you. I'll give it a try.

The slow decoding at the begging maybe caused by libtorch, libtorch model requires warmup.

Sorry, it's an additional question. Why does libtorch need a warmup?

The slow decoding at the begging maybe caused by libtorch, libtorch model requires warmup.

Sorry, it's an additional question. Why does libtorch need a warmup?

search the best path to execute forward calculation.


Showing error when I import "ShareButtonsModule" in application

Showing below error like,
"ShareButtonsModule is not an NgModule"
Please help me out for this error.

Hi @binal24, Have you upgraded angular-cli  to 1.0.0-beta.24? Check this

This package needs to be recompiled, by the time I push the new updates you can use the source typescript in your project

Yes I am using angular-cli 1.0.0-beta.24 version.
Its showing Module error, but its working.
But my concern is, Is there any issue happens by this error after publishing my application?

@binal24 I don't think so, but next release will ship typescript files instead of compiled ones to avoid such issues in the future

Hi @MurhafSousli,
Regarding this issue, the recommenced solution is to publish the  .metadata.json files along with the  .d.ts files (see @hansl's comment.
To do so, you must use the @angular/compiler-cli (ngc), which is a drop-in replacement for Typescript compiler (tsc) with some additional Angular magic, like generating those modules metadata and being AOT compliant.
I have a working PR ready to push if you want.
Cheers


Update dotenv import to just import the config function

In this section of the example code: https://github.com/Programming-from-A-to-Z/Discord-Bot-Examples/blob/ac8ee1ebf1a3199c302f8ee38f6fc177998df08f/01-discordjs/deploy-commands.js#L6-L9
we are only importing the config function and calling it from dotenv. To keep consistent through the code, I replaced this in the readme as well.

This is great, thank you! (I have already recorded some video tutorials which will probably show the other way but glad to update and fix here!)

@supercrafter100 i think it is still the other way in bot.js?

Ah did I miss it there? I'll quickly fix that if so 😅