Deploy package name in Pipeline view

Hello,
We have two scenarios mentioned below:

We are using Hygieia plugin 1.2 in few of jenkins instances. In the pipeline view of Hygieia for the deploy jobs we are getting the data like:
                            ENV1                               ENV2
                        Package1.zip                Package2.zip\

Image:

Means the environment name in the column and the package deployed in them below that.

But for the other jenkins instances we are using the plugin version 1.3 and the result in the pipeline view is like:
                                     ENV1                                                               ENV2

Package1.zp            (only time of deployments)                         (only time of deployments)
Package2.zip            (only time of deployments)                        (only time of deployments)
Image:

That means environment name but below instead of deployed package it is only displaying the time.
So would like to know whether there's any difference in the pipeline view while using the different plugins?

@mohit1606 : I am looking at the DeployController that the HygieiaPublisher calls, and it does look like the latest version of the API returns List of Environments with their last execution time stamps. Please let me know if you have any other questions. Thanks !

@mohit1606: If you don't have any other question, I would like to go ahead and close this issue, please let me know. Thanks !

@mohit1606: Closing this issue, thanks !


Regression error in console - Unexpected token '<',

This error appears on app load in studio.

@snehmehta @vusters I don't see this anymore, before closing it, do we know the cause and the fix?


MatDatepickerIntl switch between English and French languages

Hi all,
I am trying to implement MatDatepickerIntl for English and French languages. I need aria-label to be changed whenever I switch the language in the application.
What troubleshooting steps have you tried?
Have tried implementing with just one language (either En or Fr), works fine. Cannot understand how I can implement that for 2 languages.
My steps are:
1.I have declared the provider under my app module ts:
 {provide: MatDatepickerIntl, useClass: DatepickerEn }

and then in DatepickerEn class I am simply setting:

export class DatepickerEn  extends MatDatepickerIntl  {
  constructor() {
    super();

}
openCalendarLabel = 'Open Datepicker'
 }

But again, it just works fine for 1 language. How can I include 2 language?
Environment

Angular: 7
CDK/Material: 7
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu):  Windows 10

We don't currently support switching language like this at run-time. This is something we may consider for the the future.


Does not provide all star wars films

Missing the new star wars films

Please contribute data and I will upload it.


Can it be developed for local use? ollamam

Can it be developed for local use? ollamam

In the roadmap, need to prioritize getting Vision running locally.

这个模型：  llava-phi3:3.8b  可以实现图片的向量生成. 可以在 ollama 的模型里找到.

记错了， llava-phi3:3.8b  这个模型是生成图片的文本描述(英文)， 还需要搭配一个文本转向量的模型。

@flyingfz
Let me clarify the concept. Instead of directly vectorizing the images, we utilized the vision capabilities of GPT-4o-mini to extract textual descriptions from the images.
Here’s why we opted for this approach:

No one else has taken this route; it’s more AI-First.
The metadata in the photos is formatted as strings.
We can optimize the search focus by adjusting the prompt according to the scene.

So, what we need is a vision model, not an image vectorization model. Do you have any recommendations?


Expanding the Dataset

Add more categories of flower, specific to North America
Add more examples for each category

Given that some images have watermarks (#5 ), it is probably a good idea to expand the dataset and remove images with watermarks.

[ ] pink primrose
[ ] hard-leaved pocket orchid
[ ] canterbury bells
[ ] sweet pea
[ ] english marigold
[ ] tiger lily
[ ] moon orchid
[ ] bird of paradise
[ ] monkshood
[ ] globe thistle
[ ] snapdragon
[ ] colt's foot
[ ] king protea
[ ] spear thistle
[ ] yellow iris
[ ] globe-flower
[ ] purple coneflower
[ ] peruvian lily
[ ] balloon flower
[ ] giant white arum lily
[ ] fire lily
[ ] pincushion flower
[ ] fritillary
[ ] red ginger
[ ] grape hyacinth
[ ] corn poppy
[ ] prince of wales feathers
[ ] stemless gentian
[ ] artichoke
[ ] sweet william
[ ] carnation
[ ] garden phlox
[ ] love-in-a-mist
[ ] garden cosmos
[ ] alpine sea holly
[ ] ruby-lipped cattleya
[ ] cape flower
[ ] great masterwort
[ ] siam tulip
[ ] lenten rose
[ ] barbeton daisy
[ ] daffodil
[ ] sword lily
[ ] poinsettia
[ ] Texas bluebell
[ ] wallflower
[ ] marigold
[ ] buttercup
[ ] oxeye daisy
[ ] common dandelion
[ ] petunia
[ ] pansy
[ ] primula
[ ] sunflower
[ ] pelargonium
[ ] red dahlia
[ ] gaura
[ ] geranium
[ ] orange dahlia
[ ] dahlia pinnata
[ ] cautleya spicata
[ ] japanese anemone
[ ] black-eyed susan
[ ] silverbush
[ ] californian poppy
[ ] osteospermum
[ ] spring crocus
[ ] bearded iris
[ ] windflower
[ ] tree poppy
[ ] gazania
[ ] azalea
[ ] water lily
[ ] rose
[ ] thorn apple
[ ] morning glory
[ ] passion flower
[ ] lotus
[ ] toad lily
[ ] anthurium
[ ] frangipani
[ ] clematis
[ ] hibiscus
[ ] columbine
[ ] desert rose
[ ] tree mallow
[ ] magnolia
[ ] cyclamen
[ ] watercress
[ ] canna lily
[ ] hippeastrum
[ ] bee balm
[ ] pink quill
[ ] foxglove
[ ] bougainvillea
[ ] camellia
[ ] mallow
[ ] mexican petunia
[ ] bromelia
[ ] blanket flower
[ ] trumpet creeper
[ ] blackberry lily

Should also search for species by scientific name.


single-select Dropdown selection-removable does not work, deselect has to be used instead

Reproduction
https://formkit.com/playground?fkv=latest&fileTab=dropdown-selection-removable.vue&css-framework=genesis&files=jc[('n_!'M-B.vN'~editq!'<scripzsetup5consz6s+%3D+[9React1react2VN1vN2AnguXr1anguXr2SvYZ1svYZT0]08script50<LPG+jfqm3+%23default4(DI3+%3AacQsU5*PG7jMWn_46WXbY4ChoosOa+fronZnd+6WH4ExamplOHW%3AopQs46sWvalN4vNWpopover7%3ABU0**%2F5*PprOwrap>((DI)8pre5*8G58L0<style>8style5'~added!trN)]*++0\n1"%2CDJ2T93\'4%3D35>06fr_wqk70***8<%2F90*(+XbYJBsYecQ-removableD+valNGFqmKitHpXceholderI+)J%3A+"LZmpXZ5MdropdownNueOe+P*<QtionT"I%2CU4false3W37XlaYelZte_amejtype4qorzt+zqj_ZYXWUTQPONMLJIHGDB9876543210*_&imports=jc('name!'ImportMap'~lang!'json'~editor!'(*+1vue\!1https%3A%2F%2Fcdn.jsdelivr.net%2Fnpm%2Fvue%403%2Fdist%2Fvue.esm-browser.min.js0*)*')*\n0\'1+010*_
Describe the bug
The selection-removable option does not work as described in the docs and therefore expected.
Setting it to false still results in a deselection when clicking on the currently selected item in a single-select Dropdown.
With deselect everything works as expected: https://formkit.com/playground?fkv=latest&fileTab=dropdown-selection-removable.vue&css-framework=genesis&files=jc[('nZ!'L-sWecP-removable.vM'~editj!'<scripqsetup5consq6s+%3D+[9React1react2VM1vM2AnguXr1anguXr2SvWY1svWYQ0]08script5zJOD+fjm3+%23default4%28BH3+%3AacPsT5OD7_LUnZ46UXbW4ChoosNa+fronYnd+6UG4ExamplNGU%3AopPs46sUvalM4vMUpopover7%3AdesWectT0**%2F5OprNwrap%3E%28%28BH%298pre58D58Jzstyle%3E8style5%27%7Eadded%21trM%29%5D++0%5Cn1%22%2CBI2Q93%5C%274%3D35%3E06frZwjk708%3C%2F90%28+XbWIB+valMDFjmKitGpXceholderH+%29I%3A+%22JYmpXY5LdropdownMueNe+O%3CPtionQ%22H%2CT4false3U37WelXlaYteZame_type4jorqt+z0%3C%01zqj_ZYXWUTQPONMLJIHGDB9876543210&imports=jc%28%27name%21%27ImportMap%27%7Elang%21%27json%27%7Eeditor%21%27%28*+1vue%5C%211https%3A%2F%2Fcdn.jsdelivr.net%2Fnpm%2Fvue%403%2Fdist%2Fvue.esm-browser.min.js0*%29*%27%29*%5Cn0%5C%271+0%0110*_
Is this prop redundant or am I missing something?
Environment
• OS: macOS 14.16.1
• Browser: Arc
• Version: 1.63.1

@antony-k1208 selection-removable dictates whether or not to rendder the little close icon to the right of the actual text input field. deselect refers to whether or not your can actually "deselect" a selected option from the listbox.
Completely understandable for it to be a bit confusing, but it is what it is for the time bieng.


Cannot change favicon

Hi,
I'm using your theme and I'm trying to change the default favicon.
As you describe in the README, I replaced the standard icon with my own one, preserving the name (favicon.ico). Moreover I deleted the apple touch icon file, also modifying partials/favicon-appletouchicon.hbs and deleted the corresponding line.
I restarted the service and deleted the cache. No success.
What am I missing? Is there any other setting that is overriding my modifications?

Hi there, can you try to replace the favicon line inside partials/favicon-appletouchicon.hbs with
<link rel="shortcut icon" href="{{asset "img/favicon.ico"}}?v=2">
This should force the cache reload, which I think it's the problem here.

It keeps loading the standard one.
With your modification, it attempts to load this one: https://runningcodes.net/assets/img/favicon.ico?v=2ceac22790?v=2

Solved.
I don't know why, but there was a problem with the .ico file.
Using .png fixed everything.
Thanks for your support.

I tried on mine and it worked, good to know you solved!


Returning error responses from customer handler

Hi all,
Not sure if this is incorrect usage or a bug, but I'm getting errors when returning error response from my customer handlers.
Example:
public function handleGet(ApiRequest $request)
{
    // ...
    return new ApiErrorResponse(404, 404, "Product doesn't exist.");
}

Because Handler.php is only looking for instances of "Response" (on Line 84), not ErrorResponse or MultiErrorResponse, it trips up when it tries to load the (non-existent) models.
I'd be happy to submit a simple PR to check for the other two response types, but I didn't know if this was the best way to go about it. Should ErrorResponse and MultiErrorResponse be inheriting from Response instead, or am I "doing it wrong"?
Thoughts?
Kyle

Really depends on how your controller handles the Handler return value.

For the me the problem is occuring when I return an ErrorResponse object from my custom handler (eg. ProductsHandler.php) to this project's "Handler.php". This occurs within the "fulfillRequest" method. It hasn't yet returned back to the controller yet, so I'm unable to deal with it there.
Are you suggesting that I should implement my own version of "fulfillRequest", or bypass it completely in my controller?

If it helps anyone else I ended up creating my own "BaseHandler" which extended the \EchoIt\JsonApi\Handler. I changed the "fulfillRequest" to suit my needs and updated my other handlers to extend from my new "BaseHandler".
I feel a fix to the \EchoIt\JsonApi\Handler would be more ideal, so I will leave this issue open and to the discretion of the repo maintainer.


[Spoiler]: vanilla items are also unmarked

replicated via goat reward in hsHTWRl 4B6846066452990082D9FEEEEFDD310F

I'm actually not sure I follow here - the goat reward populates correctly for me with this seed and settings, although it's not vanilla. I played around with it for a while and didn't find any issues with vanilla items, they all got spoiled correctly for me.
I did find and fix an issue where specifically the Yarna Desert rock seashell wouldn't get spoiled correctly, though.

that's.. weird as well, considering that i recall that one working.. i guess it all works now, though, so there's no issue? who knows: i use this tracker so frequently though that if something like this happens again, it's a 90% chance it'll happen to me, haha. closing for now, since.. apparently everything is working normally, i guess.

oh, that's an interesting bug! seems like the case; i think python incorporates time into it's prandomness, so which check it exports first in the spoiler could definitely shift.


[Crash] App freezes with white screen after device is unlocked

Open app, leave homescreen open with active project
Lock device
Unlock device
Screen appears blank/white or shows splash screen

More details to follow.

Saw the same happen with getToken() -> BAD_AUTHENTICATION in log when user needed to verify identity because account was being used on multiple devices. We should catch and report these exceptions.

This also happens after minimizing and reopening the app on:
2021-07-08 19:34:18.964 19995-19995/com.google.android.gnd E/RxDebug: Caused by: java.lang.Throwable: caused by java.lang.IllegalStateException: Room cannot verify the data integrity. Looks like you've changed schema but forgot to update the version number. You can simply fix this by increasing the version number.
2021-07-08 19:34:18.964 19995-19995/com.google.android.gnd E/RxDebug:     at com.google.android.gnd.persistence.local.room.dao.UserDao_Impl.update(UserDao_Impl.java:148)
2021-07-08 19:34:18.964 19995-19995/com.google.android.gnd E/RxDebug:     at com.google.android.gnd.persistence.local.room.dao.UserDao_Impl.update(UserDao_Impl.java:27)

In that case, the nav_host_fragment is not restored; it contains an empty FrameLayout.
@scolsen Related to your recent issue perhaps?

Haven't seen this happening anymore. Closing as "can't reproduce"

@shobhitagarwal1612 If you're able to repro any chance you could investigate when you have a free cycle?

Looking into it.

I'm unable to repro this issue now. Closing it.

This just happened to me while developing on Pixel 7 connected via USB 3x in a row, reopening.

Note: this appears to be happening when the app is being restarted while in the background. This is reproducible by relaunching the app from AS while the device asleep. This may be similar to what happens when the error occurs when not debugging via USB; the app may get destroyed in the background and restarted on wake.

I'm able to reproduce this by following the steps mentioned in the above comment.
The issue seems to be that StartupFragment initializes the flow in onAttach method which isn't called if the device wakes up after sleep. Only onStart() and onResume() are called.


Fixed update_ticket_priority

update_ticket_priority method was calling the wrong endpoint. Fixed!
Please please merge :)
Thanks for this API!
Leo

Thanks a lot!


Added Rusanovskiy liceum

Added Rusanovskiy liceum

@IlyaBykov87 First stage of verification passed, official domain is rl.kiev.ua as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.


insert node after parent when selection at the end

This PR fixes inserting the divider before list item when the selection is at the end of the last list item.
Fixes #3681

This seems to be breaking some unit tests and end to end tests?

This seems to be breaking some unit tests and end to end tests?

@trueadm Apologies. It should be fine now.

Sorry, It looks like e2e tests are still failing.

@trueadm do I need any particular package for running e2e tests locally? It gets stuck on this screen when I run npm run debug-test-e2e.

Sorry, It looks like e2e tests are still failing.

Hey @trueadm, now it doesn't split the paragraph into two when inserting youtube embed, for example.
I believe it would be solved if this case was handled only for the list nodes and it's extends.
So, if we replace canInsertAfter with isListItemNode it should all work.
You can check my latest commit. Thank you.

I get that it's tempting to go back to that, but it might actually make more sense to understand why that method doesn't work first. As forcing it to be coupled with list items is also not ideal here. Maybe we need a new method like canInsertAfter to apply the heuristic you're looking for?

I get that it's tempting to go back to that, but it might actually make more sense to understand why that method doesn't work first. As forcing it to be coupled with list items is also not ideal here. Maybe we need a new method like canInsertAfter to apply the heuristic you're looking for?

Any suggestions or directions?

Closing this for the moment due to PR becoming stale, but happy to re-open if issues above can be addressed.


[p4-symbolic] extend component test, checking properties of ingress packet.Fix performance bug, resulting in 25x speedup on component test. Fixed bug causing crashes for LPM table entries with wildcard matches.

Keyword Check:
sonic-buildimage/src/sonic-p4rt/sonic-pins$ ~/tools/keyword_checks.sh .
Keyword check Passed.
Build Result:
sonic/src/sonic-p4rt/sonic-pins$ bazel build $BAZEL_BUILD_OPTS ...
INFO: Analyzed 512 targets (1 packages loaded, 84 targets configured).
INFO: Found 512 targets...
INFO: From Compiling p4_symbolic/symbolic/values.cc [for host]:
In file included from ./p4_pdpi/netaddr/network_address.h:28,
from ./p4_pdpi/netaddr/ipv4_address.h:22,
from p4_symbolic/symbolic/values.cc:34:
./p4_pdpi/string_encodings/hex_string.h: In instantiation of 'std::string pdpi::BitsetToHexString(const std::bitset<_Nb>&) [with long unsigned int num_bits = 32; std::string = std::__cxx11::basic_string]':
./p4_pdpi/netaddr/network_address.h:86:67:   required from 'std::string netaddr::NetworkAddress<num_bits, T>::ToHexString() const [with long unsigned int num_bits = 32; T = netaddr::Ipv4Address; std::string = std::__cxx11::basic_string]'
p4_symbolic/symbolic/values.cc:129:49:   required from here
./p4_pdpi/string_encodings/hex_string.h:95:24: warning: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Wsign-compare]
95 |       int kth_bit = (k < num_bits) ? bitset[k] : 0;  // Implicit bits are 0.
p4_symbolic/tests/sai_p4_component_test.cc:104:85: warning: 'absl::lts_20230802::StatusOrp4::v1::TableEntry pdpi::PartialPdTableEntryToPiTableEntry(const pdpi::IrP4Info&, const google::protobuf::Message&, const pdpi::TranslationOptions&)' is deprecated: Use PdTableEntryToPiEntity instead [-Wdeprecated-declarations]
104 |                          pdpi::PartialPdTableEntryToPiTableEntry(ir_p4info, pd_entry));
|                                                                                ^
./gutil/status_matchers.h:64:43: note: in definition of macro 'ASSERT_OK_AND_ASSIGN'
64 |   auto __ASSIGN_OR_RETURN_VAL(LINE) = expression;
|                                           ^~~~~~~~~~
In file included from p4_symbolic/tests/sai_p4_component_test.cc:14:
./p4_pdpi/pd.h:141:36: note: declared here
141 | absl::StatusOrp4::v1::TableEntry PartialPdTableEntryToPiTableEntry(
|                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
INFO: Elapsed time: 43.804s, Critical Path: 16.29s
INFO: 54 processes: 3 internal, 51 linux-sandbox.
INFO: Build completed successfully, 54 total actions
Test Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS --cache_test_results=no ...
INFO: Analyzed 512 targets (0 packages loaded, 10 targets configured).
INFO: Found 343 targets and 169 test targets...
INFO: Elapsed time: 102.303s, Critical Path: 45.22s
INFO: 178 processes: 208 linux-sandbox, 18 local.
INFO: Build completed successfully, 178 total actions
//gutil:collections_test                                                 PASSED in 0.5s
//gutil:io_test                                                          PASSED in 0.5s
//gutil:proto_matchers_test                                              PASSED in 0.7s
//gutil:proto_ordering_test                                              PASSED in 0.6s
//gutil:proto_test                                                       PASSED in 0.5s
//gutil:status_matchers_test                                             PASSED in 0.5s
//gutil:test_artifact_writer_test                                        PASSED in 0.6s
//sai_p4/instantiations/google:fabric_border_router_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google:middleblock_p4info_up_to_date_test        PASSED in 0.1s
//sai_p4/instantiations/google:sai_nonstandard_platforms_build_test      PASSED in 0.1s
//sai_p4/instantiations/google:sai_nonstandard_platforms_cc_test         PASSED in 0.7s
//sai_p4/instantiations/google:sai_p4info_fetcher_test                   PASSED in 0.7s
//sai_p4/instantiations/google:sai_p4info_test                           PASSED in 1.1s
//sai_p4/instantiations/google:sai_pd_proto_test                         PASSED in 0.2s
//sai_p4/instantiations/google:sai_pd_util_test                          PASSED in 0.5s
//sai_p4/instantiations/google:tor_p4info_up_to_date_test                PASSED in 0.0s
//sai_p4/instantiations/google:union_p4info_up_to_date_test              PASSED in 0.1s
//sai_p4/instantiations/google:wbb_p4info_up_to_date_test                PASSED in 0.0s
//sai_p4/instantiations/google/test_tools:table_entry_generator_helper_test PASSED in 1.7s
//sai_p4/instantiations/google/test_tools:test_entries_test              PASSED in 0.8s
//sai_p4/tools:p4info_tools_test                                         PASSED in 0.6s
//sai_p4/tools:packetio_tools_test                                       PASSED in 0.9s
//thinkit:bazel_test_environment_test                                    PASSED in 0.5s
//thinkit:generic_testbed_test                                           PASSED in 0.9s
//thinkit:mock_control_device_test                                       PASSED in 0.5s
//thinkit:mock_generic_testbed_test                                      PASSED in 0.7s
//thinkit:mock_mirror_testbed_test                                       PASSED in 0.6s
//thinkit:mock_ssh_client_test                                           PASSED in 0.0s
//thinkit:mock_switch_test                                               PASSED in 0.7s
//thinkit:mock_test_environment_test                                     PASSED in 0.1s
//thinkit:switch_test                                                    PASSED in 0.7s
//sai_p4/instantiations/google/test_tools:table_entry_generator_test     PASSED in 45.2s
Stats over 5 runs: max = 45.2s, min = 1.1s, avg = 11.3s, dev = 17.1s
//sai_p4/instantiations/google/tests:p4_constraints_integration_test     PASSED in 0.8s
Stats over 5 runs: max = 0.8s, min = 0.7s, avg = 0.7s, dev = 0.0s
Executed 169 out of 169 tests: 169 tests pass.
INFO: Build completed successfully, 178 total actions

Co-authored-by: Steffen Smolka<EMAIL_ADDRESS>


Title: Improve pagination buttons styling and improve the footer section

Which pre-existing JavaScript project will you be working on?

Describe your enhancement/improvement
Hey @swapnilsparsh I would like to improve this section

Kindly assign me this issue and I can solve it quickly
Anything you need to say to the Reviewers
No response
Add any other context or relevant screenshots about the enhancement here.
No response

@swapnilsparsh I have made something like this

Added arrows and made proper alignment of buttons with sizes let me know if this works so I can send a PR

@swapnilsparsh

Please assign this issue to me

Please assign this issue to me

@Kedarnath-Rothe its done bro


Display file explorer in a tab

Currently we can display a file explorer by using the hot key CTRL + SHIFT + E.
But this takes up the space on the left hand side. And if one wants to hide it, then they have to use the hot key CTRL + B every time.
Recently VS Code adds the ability to treat a terminal window as a tab.
It would be nice if the file explorer can be treated as a tab as well.

This is a fair feature request, however we do not have it on our immediate plan. Thus assigning to backlog for now to gather more feedback. Thanks


update contributors list with latest core contributors

All contributors should sign-off before merging.

LGTM. @ericlu88 @thmiceli should also double check their names/email addresses.

All good for me.

@thmiceli Is everything correct for you?

LGTM


[FEATURE] Implement CORDIC algorithm

New algorithm implementation. This is complex to explain but I will explain it further if needed :)
Detailed Description
Implement the CORDIC algorithm.
Context
This is for microcontrollers/microprocessors that don't have Floating Point Units, or they don't accelerate std::sin nor std::cos, or (most likely) for users who want to use/implement a clean-room CORDIC utilizing the repository's MIT License.
Possible Implementation
The CORDIC algorithm is a well-documented recursive algorithm.
Given a lookup table of arctangents (X offsets on a unit circle) partitioned evenly by a power of two, divided 0° to 90°:

Start off at 0°.
Rotate the arctangent table by 45°.
Successive rotations are based on greater-than/less-than comparisons on the angle, then divided the rotation amount by 2.
The sines and cosines are the X and 1.0f-X offsets.

For example:
Given an angle 10°:

Start off at 0°
45°
45° divided by 2 is 22.5°
22.5 is more than 10°, rotate counterclockwise by 22.5 divided by 2 which is 11.25°.
We are now at 11.25°. We can stop here because our lookup table should have 11.25° if we partitioned it at least by that granularity.

I'll take a look at it tomorrow :)

@pagdot I look into this and it seems difficult to implement for me. I'll look into this some more too in a bit.


Fix build, update dependencies in Package.resolved

Currently, when building with Xcode 13.3/Swift 5.6, swift build fails with these errors:
.build/checkouts/swift-nio/Sources/NIO/MarkedCircularBuffer.swift:132:1: error:
unavailable subscript 'subscript(_:)' was used to satisfy a requirement of protocol 'MutableCollection'

extension MarkedCircularBuffer: Collection, MutableCollection {
^
Swift.MutableCollection:8:12: note: 'subscript(_:)' declared here
    public subscript(bounds: Range<Self.Index>) -> Self.SubSequence { get set }
           ^
Swift.MutableCollection:6:14: note: requirement 'subscript(_:)' declared here
    override subscript(bounds: Range<Self.Index>) -> Self.SubSequence { get set }

This is apparently caused by a dependency on some old Swift NIO version. swift package update updating Package.resolved fixes the error.

Sorry about the delay, I think this PR may have been missed. I've merged #181 just now, which includes changes similar to the ones here, so I'm closing this as well. Thanks for the contribution!


CI: Add support for RHEL-9

From now the rhel-8-y status is the latest unreleased RHEL-8 and the rhel-x status is pre-released RHEL-9.

[citool]

[citest]

[citest]

Closing this PR because there were stuck old CI results.


Update to golang 1.16

TODO:

[ ] Bump binary in docker image
[x] ensure all tests pass
[x] Ensure benchmark is reasonable
[ ] Make use of new features

[ ]  https://tip.golang.org/doc/go1.16#library-embed

agent binary size decrease 38mb -> 34 mb

--- FAIL: TestConvertResources (0.15s)
    --- FAIL: TestConvertResources/tls (0.01s)
        conversion_test.go:48: 1 error occurred:
                * Gateway/gateway/default: spec.listeners.tls.routeOverride.certificate: Invalid value: "null": spec.listeners.tls.routeOverride.certificate in body must be of type string: "null"

FAIL

single unit test failure, I think its just relying on implementation details of some error messages.  Istio release date is 2/9 with a code freeze of 2/1. If go releases late that’ll delay istio. I can see reasons for/against. I'm fine with it myself, but delaying the release if we are waiting on go could be problematic.

Agreed, I am on the fence. If we do it for 1.16, lets start updating master to the beta/rc of golang so the update in code freeze is minimal. FWIW k8s had the exact same dilemma with go 1.15 and they went for the upgrade - but I have no clue if they are happy with that decision and what different factors they have (for one, longer release cycle - I don't think go 1.15 will go out of support for us)

cc @shamsher31 @brian-avery @ericvn @stevenctl Thoughts? Looking at https://endoflife.date/go 1.15 will be suported until 1.17 is released (ETA August)
John, do you know anyone on the k8s team we could ask about that experience? Some of the features would be nice to get and I know there's been work in the x509 library which we use.

Looking back at Istio releases, we typically move up a Golang version every 2 releases. This make sense since they release on a roughly 6 month cycle to our 3 month cycle. Continuing with that, we would release Istio 1.9 on Golang 1.15 (we released 1.8 on 1.15). What this does is makes the Istio support end roughly line up with the Golang end of support every other release. For example, Golang 1.13 (used in Istio 1.4 and 1.5) end of support would have been 8/11/20 and the Istio 1.5 end of support was 8/24/20. If we tried to move up a release so Istio 1.9 and 1.10 used Golang 1.16, we are better on the back end, but have an issue if Golang isn't released on time. And we would hit a similar problem in August with the release of Golang 1.19 and Istio 1.11.
I'm probably more comfortable leaving us on our current schedule where we are close on the back end dates and not putting a release at risk which implies we stay on Golang 1.15 for two Istio releases as we have done previously.

Looking back at Istio releases, we typically move up a Golang version every 2 releases. This make sense since they release on a roughly 6 month cycle to our 3 month cycle. Continuing with that, we would release Istio 1.9 on Golang 1.15 (we released 1.8 on 1.15). What this does is makes the Istio support end roughly line up with the Golang end of support every other release. For example, Golang 1.13 (used in Istio 1.4 and 1.5) end of support would have been 8/11/20 and the Istio 1.5 end of support was 8/24/20. If we tried to move up a release so Istio 1.9 and 1.10 used Golang 1.16, we are better on the back end, but have an issue if Golang isn't released on time. And we would hit a similar problem in August with the release of Golang 1.19 and Istio 1.11.
I'm probably more comfortable leaving us on our current schedule where we are close on the back end dates and not putting a release at risk which implies we stay on Golang 1.15 for two Istio releases as we have done previously.

@howardjohn Is this complete and able to be closed?

yes


iOS 13 and lower can't open an EPUB

Bug Report
A book can't be opened prior iOS 13. Seems that it has something to do with js as I notice multiple same js executions of my user scripts.
What happened?
The screen just shows endless loading

Expected behavior
A book should be opened
How to reproduce?

Open any book on any device on iOS 12, 13
See the error

Environment
iOS 12.0 iPhone SE
iOS 13.0 iPhone Simulator
Readium versions

r2-shared-swift: 2.2.0
r2-streamer-swift: 2.2.0
r2-navigator-swift: 2.2.0
r2-opds-swift: 2.2.0
r2-lcp-swift: 2.2.0

Development environment
macOS: 11.6
platform: x86_64
carthage: 0.38.0
Xcode 13.0
Build version 13A233
Testing device

iOS version: iOS 12, 13
Model (e.g. iPhone 11 Pro Max):iPhone SE, Simulator
Is it an emulator? Yes and No

Additional context
Seem pretty much like the bug in the past, it was fixed here: https://github.com/readium/r2-navigator-swift/pull/208
It seems that it is back now

Hi! Is it possible that I have the same problem on iOS 13.1?


Eslint plugin jest

Summary
Importing eslint-plugin-jest.
I've tried to match the package.json and file conventions that the other packages have to the best of my ability!

This is great! I'll check this out soon when everything around me gets a tiny little bit more quiet. Sorry I can't get to it immediately.

Current coverage is 89.36% (diff: 100%)

Merging #2214 into master will not change coverage

@@             master      #2214   diff @@
==========================================
  Files            39         39
  Lines          1467       1467
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1311       1311
  Misses          156        156
  Partials          0          0

Powered by Codecov. Last update c3324a8...91a52f8

@thymikee sure I can give it a go. Not sure what is necessary regarding legal/copyright info though?

Adding the text below to source and test files should do the work:
/**
 * Copyright (c) 2014-present, Facebook, Inc. All rights reserved.
 *
 * This source code is licensed under the BSD-style license found in the
 * LICENSE file in the root directory of this source tree. An additional grant
 * of patent rights can be found in the PATENTS file in the same directory.
 * @flow
 */

ping, is the flow typing still happening? :)

@thymikee @cpojer add flow types and copyright notices

Should there be a recommended export as well? Can be added later of course.

@jkimbo thank you for the updates!

Addressed all the code review comments.
@SimenB I thought about adding an recommended export but since at the moment there are only 2 rules I didn't think it would be that useful. Should be added in the future though.

cc: @cpojer

Wow this is really solid! Nice work. I have one more lint rule to add, so I'll do that in a follow-up :)

Small follow-up here: https://github.com/facebook/jest/pull/2509

Actually, @jkimbo would you mind adding the lint rule I was thinking of? I think we should have one that errors when using xit and xdescribe that people can optionally enable. At Facebook it's really bad when people disable tests (while they are working on something) and then potentially commit disabled tests (similar to the rule for test.only, really).

@cpojer sure! I'll give it a go over the weekend.


Not selected value, not allowed blank - ng-model is not updated

Hello, so I had finally some time to test your fixes you did to resolve #110 and I found one issue.
Tak a look at this Plunk:
http://plnkr.co/edit/WnShJud8kAl0hTVjrPWA?p=preview
When select doesn't have selected value and allow-blank is false, ng-model should reflect displayed value from select (first from options). But it does not. Model gets updated when I select some value from select.
This is not issue for version 3.0.6, but introduced in 3.0.7.

Thanks for the info. I'll look into it when I can :)

I haven't forgotten about this issue. I've just been really slammed at work. (Ditto for #125.)
I think the next formFor release (hopefully soon) will have some heavy refactoring in this component. It's just gotten too complex. I'm going to probably split the current <select-field> into two separate components- <select-field> and <type-ahead>. I think this will simplify the directive and the templates significantly.

Yes, this split will be a good decision!

Made decent progress this weekend on the refactor (see the select-field-refactor branch) but haven't ironed out all of the Angular Material issues, unfortunately. It's just different enough to be a hassle...

Resolved by Pull #127


Add CI to check with onnxruntime-traning and transformers

https://github.com/microsoft/onnxscript/issues/1635


feat: Support Q4_0

add support for q4_0
lack of testing

I have re-quantified a Q4_0 tinyllamas-stories model. Now I just need to fix vec_dot.


"undefined: feature.InsertTableAlias" when installing pgdialect

Hi, it appears the latest release introduces an issue for github.com/uptrace/bun/dialect/pgdialect
go get github.com/uptrace/bun/dialect/pgdialect
# github.com/uptrace/bun/dialect/pgdialect
../../../go/pkg/mod/github.com/uptrace/bun/dialect/pgdialect@v0.2.13/dialect.go:29:3: undefined: feature.InsertTableAlias

Seems to be working for me. Please make sure all Bun dependencies in go.mod file have the same version:
	github.com/uptrace/bun v0.2.13
	github.com/uptrace/bun/dialect/pgdialect v0.2.13
	github.com/uptrace/bun/driver/pgdriver v0.2.13
	github.com/uptrace/bun/extra/bundebug v0.2.13
	github.com/uptrace/bun/extra/bunotel v0.2.13

🤦 Thanks @vmihailenco, my versions were not lined up in the go.mod, working fine now. This might become a common gotcha, worth mentioning in the docs somewhere.

Actually it might be good to make the plugin modules explicitly mark their dependency on the main bun module with the same version.
So for example in bun/dialect/pgdialect/go.mod it should say
require github.com/uptrace/bun v0.2.13

Currently it says v0.1.1 instead of v0.2.13


Add GOWORK env variable when go vet is run

The cinder-operator patch [1] introduces the go.work file within the repository with the goal of automating the way we deal with multi module dependencies.
However, the side effect of having a versioned go.work in the repo is the failure of the govet CI script because GOWORK is automatically set to on. This patch fixes the CI run on the cinder-operator PR [1], introducing a GOWORK variable (which is set to off by default) to make sure we can successfully run this check regardless of the approach.
[1] https://github.com/openstack-k8s-operators/cinder-operator/pull/79
Signed-off-by: Francesco Pantano<EMAIL_ADDRESS>

repos having go.work file checked in already adding GOWORK=off to the CI make target to fix this. After this land such repos can remove the GOWORK=off from their Makefile.


Shrink extension size for github.dev by only including modules which are used in tsconfig.browser.json

When running in browser we only need to include what src\client\browser\extension.ts imports. It uses certain file system tools, common modules like localize.ts.
With https://github.com/microsoft/vscode-python/pull/17658 it was expanded a lot more than needed.

#17658 was corrected.


[Unity] Fix changelogTemplate

Fix broken link to release notes for version 2022.1.20f1 (and future versions using similar number format)

or we can just remove the fXYZ part from its latest tags
@captn3m0 do we take unity's version (latest) values automatically ?

do we take unity's version (latest) values automatically ?

Nopes, we don't have a source to track this so far.

Closed with #1763


Support for half starFilled

Please provide support for half star filled (2.5, 4.5, ...).

Looks like nobody is updating this library anymore.. Fractions are basic


OCSP_REQ_CTX API is quite broken going from 1.0.2 to 3.0.0

This relates somewhat to https://github.com/openssl/openssl/issues/12234, I suggest familiarizing oneself with the broad strokes of the discussion there before reading any further.
I have some application code that contains approximately the following snippet. Note that I've stripped error handling and surrounding context, so this cannot be considered a reproduction artifact, but hopefully it is more useful for discussion purposes.
OCSP_REQ_CTX* ctx = OCSP_sendreq_new(some_bio, some_path_string, NULL, -1);
OCSP_REQ_CTX_add1_header(ctx, "Host", some_hostname_string);
OCSP_REQ_CTX_set1_req(ctx, some_ocsp_request);
OCSP_sendreq_nbio(some_ocsp_response, ctx);

The reason it is written this way is that in some cases other headers (besides just "Host") are added and the man page states

OCSP_REQ_CTX_add1_header() adds header name with value value to the context rctx. It can be called more than once to add multiple headers. It MUST be called before any calls to OCSP_sendreq_nbio(). The req parameter in the initial to OCSP_sendreq_new() call MUST be set to NULL if additional headers are set.

Now, out of the gate, OCSP_REQ_CTX_set1_req() is deprecated starting in a recent 3.0.0 alpha (9 or 10, don't remember off-hand). Now the man page tells me exactly how to handle that:

OCSP_REQ_CTX_set1_req(rctx, req) is equivalent to the following: [...]

This actually leads to the first unacceptable API breakage: OCSP_REQ_CTX_i2d() takes three arguments in 1.0.2 (though the function is not explicitly documented in 1.0.2, it is publicly accessible), now it takes four, without ever having been walked through any kind of deprecation process to my knowledge. This is actually tangential to the most central aspect of the issue at hand, but this class of API breakage shows up again later in this discussion as well.
Anyway, if I make the OCSP_REQ_CTX_set1_req->OCSP_REQ_CTX_i2d change (conditionally including the "application/ocsp-request" parameter on a version-check ifdef), the above snippet still works fine against 1.0.2 and compiles without any warnings against 3.0.0.
However, against 3.0.0 the response I get back from the server is telling me that I have a malformed request. This is happening because OCSP_sendreq_new() behaves in a significantly different way in 3.0.0 compared to 1.0.2, which interacts badly with the other APIs I am subsequently using. The way I can prove that / the way I work around it starts by examining the 1.0.2 implementation:
OCSP_REQ_CTX *rctx = NULL;
rctx = OCSP_REQ_CTX_new(io, maxline);
if (!rctx)
    return NULL;

if (!OCSP_REQ_CTX_http(rctx, "POST", path))
    goto err;

if (req && !OCSP_REQ_CTX_set1_req(rctx, req))
    goto err;

return rctx;

Ok... so I'm passing a NULL request here anyway, so discounting the error handling I should basically be able to simply replace my OCSP_sendreq_new() call with a call to OCSP_REQ_CTX_new() & OCSP_REQ_CTX_http(). Those are both public symbols in 1.0.2 (though again undocumented), so should be fine.
But of course not. Because both of those APIs take a completely different set of arguments in 3.0.0 compared to 1.0.2. Two more unacceptable API breakages. Frustrating.
Anyway, if I replace the OCSP_sendreq_new() from above with the following when compiling against 3.0.0, then I actually get back a valid response from the OCSP server (ie, my request is no longer malformed):
OCSP_REQ_CTX *ctx = OCSP_REQ_CTX_new(some_bio, some_bio, 0, -1, 0, 0, NULL, 1);
OCSP_REQ_CTX_http(ctx, NULL, NULL, some_path_string);

My guess is that there was some duplication of the headers in the 3.0.0 case (based on a cursory examination of the 3.0.0 implementation of OCSP_sendreq_new()).
I think that pretty much of all of this mess was caused by https://github.com/openssl/openssl/commit/29f178bddfdbd11218fbcba0b8060297696968e3. I hate pointing fingers and making a suggestion like this because it's very easy for things to get personal and distractions to arise, but IMO that commit should really be given a serious reexamination with particular emphasis on potential API / ABI breakages.

This does appear to be a problem.
Somehow I missed the breaking API changes introduced in #10667.
@DDvO care to comment on this? It looks like we need to reintroduce the original API function declarations (possibly creating new "_ex" versions, in order to add the additional arguments).

This does appear to be a problem.
Somehow I missed the breaking API changes introduced in #10667.
@DDvO care to comment on this? It looks like we need to reintroduce the original API function declarations (possibly creating new "_ex" versions, in order to add the additional arguments).

So as not to create another mess, I'd suggest that we allow #13742 to be merged first, and fix back the API after.  There's a risk that #13742 becomes overly entangled otherwise.

So as not to create another mess, I'd suggest that we allow #13742 to be merged first, and fix back the API after.  There's a risk that #13742 becomes overly entangled otherwise.

So as not to create another mess, I'd suggest that we allow #13742 to be merged first, and fix back the API after. There's a risk that #13742 becomes overly entangled otherwise.

Agreed

So as not to create another mess, I'd suggest that we allow #13742 to be merged first, and fix back the API after. There's a risk that #13742 becomes overly entangled otherwise.

Agreed

Thanks @jwalch for your detailed error report.
I was already about to write that this issue is related also to #13742,
which properly deprecates and documents also the formerly undocumented legacy OCSP HTTP functions.
Yes, although undocumented, the number of parameters of  OCSP_REQ_CTX_i2d() should not have changed.
This is an oversight for which I apologize.
I'll fix this as soon as #13742 is finished and merged, which should happen within the next couple of days.
For OCSP_sendreq_new() I changed the implementation in order to take advantage of the meanwhile strengthened implementation while of course aiming at semantic compatibility. Sorry to hear that this did not work out fully.
I'm going to fix this as well when #13742 is merged.

Thanks @jwalch for your detailed error report.
I was already about to write that this issue is related also to #13742,
which properly deprecates and documents also the formerly undocumented legacy OCSP HTTP functions.
Yes, although undocumented, the number of parameters of  OCSP_REQ_CTX_i2d() should not have changed.
This is an oversight for which I apologize.
I'll fix this as soon as #13742 is finished and merged, which should happen within the next couple of days.
For OCSP_sendreq_new() I changed the implementation in order to take advantage of the meanwhile strengthened implementation while of course aiming at semantic compatibility. Sorry to hear that this did not work out fully.
I'm going to fix this as well when #13742 is merged.

While fixing, would you mind renaming OSSL_HTTP_REQ_CTX_header -> OSSL_HTTP_REQ_CTX_http, seeing that this function sets the HTTP command, which isn't a header?
(the old name was OCSP_REQ_CTX_http, btw...).
As currently named, I find this function much to easy to confuse with OSSL_HTTP_REQ_CTX_add1_header...

While fixing, would you mind renaming OSSL_HTTP_REQ_CTX_header -> OSSL_HTTP_REQ_CTX_http, seeing that this function sets the HTTP command, which isn't a header?
(the old name was OCSP_REQ_CTX_http, btw...).
As currently named, I find this function much to easy to confuse with OSSL_HTTP_REQ_CTX_add1_header...

I found the old name OCSP_REQ_CTX_http pretty unclear if not confusing (for instance, it could have been misunderstood as if it was doing an HTTP transfer) and therefore renamed it to OSSL_HTTP_REQ_CTX_header when updating the name prefix.
Therefore I would not like to rename it (essentially) back to OSSL_HTTP_REQ_CTX_http.
The new documentation added by #13742 nicely says:
OSSL_HTTP_REQ_CTX_header() adds an HTTP request line to the request context.

seeing that this function sets the HTTP command, which isn't a header?

I meanwhile understand that the HTTP request line (which includes the method) is not considered part of the header.
So I suggest renaming it to OSSL_HTTP_REQ_CTX_set_request_line, which is much more to the point.
I will also correct the brief internal documentation of the function in http_client.c which currently says:
 * Create HTTP header using given op and path (or "/" in case path is NULL).

to
 * Create HTTP request line using the given |ctx| and |path| (or "/" in case |path| is NULL).

I found the old name OCSP_REQ_CTX_http pretty unclear if not confusing (for instance, it could have been misunderstood as if it was doing an HTTP transfer) and therefore renamed it to OSSL_HTTP_REQ_CTX_header when updating the name prefix.
Therefore I would not like to rename it (essentially) back to OSSL_HTTP_REQ_CTX_http.
The new documentation added by #13742 nicely says:
OSSL_HTTP_REQ_CTX_header() adds an HTTP request line to the request context.

seeing that this function sets the HTTP command, which isn't a header?

I meanwhile understand that the HTTP request line (which includes the method) is not considered part of the header.
So I suggest renaming it to OSSL_HTTP_REQ_CTX_set_request_line, which is much more to the point.
I will also correct the brief internal documentation of the function in http_client.c which currently says:
 * Create HTTP header using given op and path (or "/" in case path is NULL).

to
 * Create HTTP request line using the given |ctx| and |path| (or "/" in case |path| is NULL).

So I suggest renaming it to OSSL_HTTP_REQ_CTX_set_request_line, which is much more to the point.

Yes, even better!

So I suggest renaming it to OSSL_HTTP_REQ_CTX_set_request_line, which is much more to the point.

Yes, even better!

@jwalch, in anticipation of #13742 being merged soon,
I've already tentatively fixed all the issues you reported here
in https://github.com/siemens/openssl/tree/fix_13873_HTTP_method_API:
    OCSP HTTP: Restore API of undocumented and recently deprecated functions

    Restore parameters of OCSP_REQ_CTX_new(), OCSP_REQ_CTX_http(), OCSP_REQ_CTX_i2d().
    Un-deprecate OCSP_REQ_CTX_set1_req() because it is helpful also for internal use.
    Fix a bug (wrong HTTP method selected on req == NULL in OCSP_sendreq_new().

I'll submit this as a PR as soon as possible (likely tomorrow) but you might already have a look at it.

@jwalch, in anticipation of #13742 being merged soon,
I've already tentatively fixed all the issues you reported here
in https://github.com/siemens/openssl/tree/fix_13873_HTTP_method_API:
    OCSP HTTP: Restore API of undocumented and recently deprecated functions

    Restore parameters of OCSP_REQ_CTX_new(), OCSP_REQ_CTX_http(), OCSP_REQ_CTX_i2d().
    Un-deprecate OCSP_REQ_CTX_set1_req() because it is helpful also for internal use.
    Fix a bug (wrong HTTP method selected on req == NULL in OCSP_sendreq_new().

I'll submit this as a PR as soon as possible (likely tomorrow) but you might already have a look at it.


fix: Remove any types

What does this change?
Remove any types from the storage API.
Why?
This caused an issue in Production recently, where the type that became returned as a number instead of a string.

Coverage decreased (-0.2%) to 99.814% when pulling cfbf341f09ed29b3408344740ce24bb2d5f6969e on mxdvl/no-any into f80ad67af49524f6e35bb2d1f05f56ba4fe1f889 on main.


tests for close and add IsClosed() method

This also removed the unused code session.Init() in session.Close()

Codecov Report

Merging #659 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #659      +/-   ##
=========================================
+ Coverage   48.22%   48.3%   +0.07%
=========================================
  Files          34      34
  Lines        8377    8378       +1
=========================================
+ Hits         4040    4047       +7
+ Misses       3848    3844       -4
+ Partials      489     487       -2

Impacted Files
Coverage Δ

session.go
48.63% <100%> (+0.08%)
:arrow_up:

session_schema.go
54.29% <0%> (+1.84%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5a917d...44de5b0. Read the comment docs.


HDFS-12424 Fix sorting of the datatable on the Datanodes page in the NN UI

This fix basically comes down to three things:

type: numeric isn't a thing -- it needs to be type num per the datatable doc
orderData was wrong in both instances; we don't want those columns to sort by some other column
version sorting by anything other than string is going to be even more confusing than it is if we sort it by string

I'm going to go the patch route.


Snapshot version dependency is missing

buildscript {
  repositories {
    mavenCentral()
    maven {
      url "https://oss.sonatype.org/content/repositories/snapshots/"
    }
    maven {
      url 'https://dl.bintray.com/jetbrains/intellij-plugin-service'
    }

  }
  dependencies {
    classpath "org.jetbrains.intellij.plugins:gradle-intellij-plugin:0.5.0-SNAPSHOT"
  }
}

plugins {
    id 'java'
}

apply plugin: 'org.jetbrains.intellij'

> Could not resolve all artifacts for configuration ':classpath'.
   > Could not find org.jetbrains.intellij:blockmap:1.0.3.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/org/jetbrains/intellij/blockmap/1.0.3/blockmap-1.0.3.pom
       - https://oss.sonatype.org/content/repositories/snapshots/org/jetbrains/intellij/blockmap/1.0.3/blockmap-1.0.3.pom
       - https://dl.bintray.com/jetbrains/intellij-plugin-service/org/jetbrains/intellij/blockmap/1.0.3/blockmap-1.0.3.pom
       - https://plugins.gradle.org/m2/org/jetbrains/intellij/blockmap/1.0.3/blockmap-1.0.3.pom
     Required by:
         project : > org.jetbrains.intellij.plugins:gradle-intellij-plugin:0.5.0-SNAPSHOT:20200911.000148-101 > org.jetbrains.intellij:plugin-repository-rest-client:2.0.14

please add one more repo maven { url "https://jetbrains.bintray.com/intellij-third-party-dependencies" }. I'll update the documentation a bit later

working, thx


Authenticate with credentials

Provide an option to authenticate with credentials instead of private keys.
Example use case: On Google Cloud compute engine, I can obtain credentials in a compute engine instance based on the service account assigned to compute engine, but I can not directly get the private key.
If I pass credentials in the private key field, it fails as expected.
>>> from google.auth import compute_engine
>>> credentials = compute_engine.Credentials()
>>> import pandas
>>> pandas.io.gbq.read_gbq(sql, project, private_key=credentials)
/env/local/lib/python2.7/site-packages/pandas_gbq/gbq.py:798: FutureWarning: verbose is deprecated and will be removed in a future version. Set logging level in order to vary verbosity   "verbosity", FutureWarning, stacklevel=1) Traceback (most recent call last):   File "<stdin>", line 1, in <module>   File "/env/local/lib/python2.7/site-packages/pandas/io/gbq.py", line 99, in read_gbq     **kwargs)   File "/env/local/lib/python2.7/site-packages/pandas_gbq/gbq.py", line 810, in read_gbq     dialect=dialect, auth_local_webserver=auth_local_webserver)   File "/env/local/lib/python2.7/site-packages/pandas_gbq/gbq.py", line 180, in __init__     self.credentials = self.get_credentials()   File "/env/local/lib/python2.7/site-packages/pandas_gbq/gbq.py", line 189, in get_credentials     return self.get_service_account_credentials()   File "/env/local/lib/python2.7/site-packages/pandas_gbq/gbq.py", line 409, in get_service_account_credentials     "Private key is missing or invalid. It should be service " pandas_gbq.gbq.InvalidPrivateKeyFormat: Private key is missing or invalid. It should be service account private key JSON (file path or string contents) with at least two keys: 'client_email' and 'private_key'. Can be obtained from: https://console.developers.google.com/permissions/serviceaccounts

Can you confirm that it doesn't work if you pass in no details? Application Default Credentials (which are supplied in GCE) should work by default.

To clarify, I am running this in a pod in Kubernetes Engine. I don't think there is an Application Default Credentials there.
I am not sure if there is an Application Default Credentials for compute engine...
I did try to run query without the private key field (from a shell in a pod in Kubernetes Engine), it asks for authorization
>>> pandas.io.gbq.read_gbq(sql, project)
Please visit this URL to authorize this application: https://accounts.google.com/o/oauth2/auth?response_type=code&client_id=495642085510-k0tmvj2m941jhre2nbqka17vqpjfddtd.apps.googleusercontent.com&redirect_uri=urn%3Aietf%3Awg%3Aoauth%3A2.0%3Aoob&scope=https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fbigquery&state=I9HkEQv3ywVTfJYfH1q1bIrlQLDrVl&prompt=consent&access_type=offline Enter the authorization code:

I'm fairly confident that there are ADCs on GKE. What are you seeing in the docs that makes you think there isn't?

If your application runs on Compute Engine, Kubernetes Engine, the App Engine flexible environment, or Cloud Functions, you don't need to create your own service account. Compute Engine includes a default service account that is automatically created for you

What do you see if you run import google; google.auth.default()?

Last I tried there was some setup required to get application default credentials to work on Kubernetes Engine.

I agree that a way to provide general credentials is desired and have created a design proposal at https://github.com/pydata/pandas-gbq/issues/161. Closing this issue as a duplicate of that proposal.

#161 looks very comprehensive! Feel free to ping me to discuss or verify CLs.


"Use an interpolated DDLogMessageFormat instead" waring is displayed after updating to 3.8.1 when passing "String" to DDLog methods

Checklist

[X] I have read and understood the CONTRIBUTING guide
[X] I have read the Documentation
[X] I have searched for a similar issue in the project and found none

Describe the bug
After updating to CocoaLumberjackSwift 3.8.1 I am getting following warnings in XCode:
'DDLogError(_:level:context:file:function:line:tag:asynchronous:ddlog:)' is deprecated: Use an interpolated DDLogMessageFormat instead

To Reproduce
Steps to reproduce the behavior:

Create logger '...' N/A
Warning is displayed in eg. following code:

private func logError(_ name: String, error: Error, message: String) {
        // some other code
        DDLogError(message) // warning displayed here
    }

See error

Expected behavior
No warning or clear instructions how to migrate
Screenshots
N/A
Environment info

Info
Value

Platform Name
e.g. ios

Platform Version
e.g. 16

CocoaLumberjack Version
e.g. 3.8.1

Integration Method
e.g. spm

Xcode Version
e.g. Xcode 14.2

Repro rate
e.g. all the time (100%)

Additional context
I've been able to pinpoint the change that is now causing the warning to be displayed: https://github.com/CocoaLumberjack/CocoaLumberjack/commit/29bca377c9e08c878cf4e667bff27034cb732073 which was part of this PR: https://github.com/CocoaLumberjack/CocoaLumberjack/pull/1347
After playing around a bit with the code I was able to get rid of the warining but this seems a like hack. In the code shared above replacing DDLogError with below code removes the warning:
DDLogError("\(message)")

This is intended. The new version uses a fully typed message format. This is similar to e.g. swift-log which also uses a typed message parameter.
There are two solutions to this. Either the one you chose with an interpolation ("\(message)") or by changing your message parameter from String to DDLogMessageFormat.

I'm confused as to how to properly use DDLogMessageFormat to preserve message format, could you give an example @ffried? 🤔

@vlvs What exactly are you trying to achieve?

Say I have something like this:
DDLogDebug(String(format:"commentInfo=%@", comment))

Where comment is a variable consisting of a bunch of concatenated strings. How would you use DDLogMessageFormat to represent/replace that?

@vlvs This could be converted to simply DDLogDebug("commentInfo=\(comment)")

@vlvs You can learn more about string interpolation in the swift documentation. The only difference with CocoaLumberjack is, that you're not creating a String directly, but instead a DDLogMessageFormat is created under the hood.

Actually, the "\(result)" is creating a DDLogMessageFormat here. It looks like a string, but the underlying conformance to Swift's ExpressibleByStringInterpolation will turn it into a DDLogMessageFormat instead.
So generally speaking, unless you're writing some kind of wrapper around CocoaLumberjack, you shouldn't be creating DDLogMessageFormats manually, but instead use string interpolation as the parameter to the DDLogXYZ functions.

Oh, I see. Got it, thanks! ✨

@algrid The same design decision was made by Apple twice for logging. Both swift-log and OSLog use a type that conforms to ExpressibleByStringInterpolation.
Doing so gives much more insight into the structure of a log message - something a plain String could never provide.

Frankly, I don't know how those Apple libraries work, I'm just curious what kind of structure we're talking about when it's just a plain string? Something about the contents of the string? But why would a logging library need that?

It usually isn't a plain string. Most log messages carry some kind of information. A value, an error, ...
We currently use it to be able to reconstruct the format of the message string (similar to format strings in C).
In OSLog, Apple uses the interpolation arguments to mask those values when not attached to a debugger (unless the values are classified as public).
But since you are in full control of what interpolations you accept, you can go as far as have a formatter for every possible type.
If you compose the string before passing it to a logging library, the only thing the logging library sees is the string. If it was created using string interpolation, the values are already "stringified".
Basically, the following gives insight into the log message:
let bool = true
let int = 42
let str = "hello"

DDLogInfo("We have some values: A bool being \(bool), an int \(int) and a string saying: \(str)")

With this version, there's a separate method called for each \() inside the interpolation. If there's no matching method, the compiler will emit an error, stating that this interpolation is not supported. In OSLog for example, not all types are accepted (due to the way those messages are stored).
However, in this example, all values are already converted to strings before they reach the logging library:
let bool = true
let int = 42
let str = "hello"

let message: String = "We have some values: A bool being \(bool), an int \(int) and a string saying: \(str)"

DDLogInfo("\(message)")

We only get one \() where the pre-composed message is contained. This is not the recommended way.

@ffried Thank you for detailed explanation! All I need from a logging library is ability to log strings (and probably errors/exceptions with some special processing). I guess more smart people at Apple have more advanced needs and priorities that require custom string interpolation handling.


Yoshi = mid

Nice!


Odd completion issue in console: executed code doesn't see full completion

Consider the following in the console: I type from ipywidgets import IntS<TAB>. I get the completion pop-up, and it only shows a single completion, IntSlider. I hit Enter and it completes, then I hit Shift-Enter and it executes. But it seems that the internal buffer never got updated with the extra text from the completion, because it gives this error:

This is obviously a bug. More generally, the completion behavior in the console and notebook should match what IPython does at the console as much as possible (e.g., when there's only one unambigous completion, the text buffer should fully complete without showing a pop-up, etc).  Completion is one of the most automatic, muscle-memory tasks we have, so we need to work extra hard in reducing variance between our clients in its behavior, or we'll drive users (me included :) crazy.

@fperez, are you using a recent pull of master? This sounds like an issue I fixed a little while ago, so can you confirm your version, please?

Yes, this is on current master of jupyterlab right now, specifically I'm on fdb564f. Can you replicate it?

I can't replicate it, no. The version I'm running appears to work correctly when following your exact steps. Could you try clearing your browser cache?

This is what I see:

testing now and making sure I do a full rebuild of the JS assets. I'm getting weird errors there, so I nuked everything out and I'm doing a full rebuild from scratch. Hang tight.

OK, this is odd... I did a full git clean, full rebuild and source install, and I definitely see changes, but not what we wanted :(  Now I have no tab completion at all! Does this make sense to you?

This was after a full git clean -fdx ., then npm install at the top, as per the README instructions...

Are there errors in your JS console?

nope, fully clean

That is perplexing. Do you have a few minutes to do a screenshare?

Now, I just opened a notebook and that did give an error:

Sure!

Bluejeans?

Or appear.in?

https://appear.in/jupyter please

Wow, this is really odd! While I was in a different window, the pop-up completions for the notebook appeared all of a sudden! With a good minute of lag...

Thanks! This was an issue related to the build instructions being incomplete. It will be addressed in a later PR that will reference this issue.


Upgrade to prometheus simpleclient-0.10

See #4270 for how it failed the automated way.  We should do this on series/0.22 and fix the tests.

I'll take a look here.

I'll take a look here.

Fixed by #4273

Fixed by #4273


Way of requesting data deletion.

Is your suggestion related to a problem? Please describe in detail.
I have had no less than 4 people contact me while ingame about purchasing an item in my inventory. Upon further investigation as to how people keep finding this information(as I have had that part of the API disabled for over a year now, and your site is still displaying an old version of that data. I would like to know if there is a way that this information can be removed from your service to prevent further unwanted contact from random people.
Describe your suggestion
Some menu or button to request the removal of your profile's data from the service.

could i have a link to the profile?

Wait, the inventory data is still viewable even after disabling it for a year? That's weird, it definitely shouldn't be like this.
I suppose you can message us on our Discord for now while we look into API settings and possibly preventing similar issues in the future. On that note, hi metal.

https://sky.shiiyu.moe/stats/MHF_Doge/Apple#Armor
I'm also confused as to how it just updated that information(it shows my armor is empty which it is, because I removed the items earlier). Am I misunderstanding what this setting means? Or is this an issue on hypixel's end?

@MHFDoge are you remembering that the API settings are profile specific? So you will need to disable the API in each of the profiles that you would like hidden.

I didn't realize it was per profile but after hearing that it makes sense that it would be. I'm pretty sure that's set on the profile in question as off but I'll double check that in a few minutes and try to pin something down.

It appears that earlier I must have hit the button to enable that information being shared, probably with the intention to force a purge, and forgot about it, which would explain why it updated. The setting was off before though, I know that for certain. I've emptied my inventory on the profile this issue is with of all but one item. Would you be able to force an update of that information? After that I'll turn the setting back off and give it time to see if it happens again. Sorry for this mess.

Would you be able to force an update of that information?

Hypixel itself only updates the API every 3 minutes and we only cash data for 7 minutes so it should go away on its own within 10 minutes.

Ah, gotcha. Thank you, it appears it's updated now and it's not showing the inventory data with the setting off(as intended)
I swear it was off before I opened this PR, my only guess is that it took me cycling the setting to get something to update, possibly on hypixel's end. The reason for it doing that is beyond me but it's fixed now. Thank you for your help and once again, sorry if I sound like a rambling idiot 😂.

I'm glad to hear it's working as expected for you now. Let us know if you have any other problems.


'Allow analytics' always re-enables itself

macOS Version:
ProductName:    Mac OS X
ProductVersion: 10.13.6
BuildVersion:   17G65
Kap Version: Version 2.2.0 (<IP_ADDRESS>0)
Steps to reproduce

Open Kap
Open Preferences
Disable 'Allow analytics'
Close Preferences
Open Preference
Note that 'Allow analytics' is now re-enabled

Current behaviour
'Allow analytics' preference either never saves or re-enables itself without warning.
Expected behaviour
'Allow analytics' preference should respect my choices.
Workaround
Firewall Kap off from hitting Google Analytics.

Do you have more than one instance of Kap @davidjb? The only thing I can think of that would cause this is a corrupt settings file or a conflict between multiple of them. I suggest uninstalling Kap and making sure the contents of ~/Library/Application Support/Kap is deleted before reinstalling.

I just installed Kap for the very first time on this machine today.  Fresh new install from brew cask which comes from the 2.2.0 dmg here on GH.  I've uninstalled and rm -rf'd the application support directory, and reinstalled and same experience.
Are there debug logs or a debug mode I can invoke to get more info?

Can you go to ~/Library/Application Support/Kap and grab the config.json file from that folder and share it?
cat ~/Library/Application Support/Kap/config.json | pbcopy

That explains it, for some reason Kap isn't generating a config.json file for you. I have a feeling it might be due to an issue with permissions.

The Kap directory has 755 permissions and is owned by my user and my user has been writing to those other files from within Kap so I'm not sure.  Let me know if there's something you want me to check or test specifically.

https://github.com/wulkano/kap/issues/489#issuecomment-405942430

Could you remove it again and try this build https://kap-artifacts.now.sh/next

Yep, that's now got a config.json rather than a Settings file in the Kap/ directory.  The allowAnalytics key changes correctly on modifying the setting in the GUI. (Version 3.0.0 / <IP_ADDRESS>0)

Awesome, that should solve #489 for you too. You can download and install Kap 2.2.0 now, it will share the plugins and config.json with your current installation.

Doesn't work unfortunately; running 2.2.0 leads to Settings being recreated, with its original settings.  In that file is a bundle of JSON with the same object as what's in config.json.  So the two versions seem to use different config filenames.
Anyway, I'm fine with using v3 if it's stable enough.  Otherwise, modifying the Settings file seemed to workaround the problem for now...

Bummer. Since we haven't heard about this issue in the past and things seem to work with 3.0 (which should be stable enough, just keep an eye out for the beta so you remember to update) I'm going to close this issue for now. Again, thank you for the issue and quick replies, glad we could find a workaround.


Unhandled Exception: type '(dynamic) => Object?' is not a subtype of type '((dynamic) => Todo)?' in type cast

I have generated model and provider by:
get generate model from 'https://jsonplaceholder.typicode.com/todos/1'
But when doing any request, it throws exception: Unhandled Exception: type '(dynamic) => Object?' is not a subtype of type '((dynamic) => Todo)?' in type cast
The generated provider code:
class TodoProvider extends GetConnect {
  @override
  void onInit() {
    httpClient.defaultDecoder = (map) {
      if (map is Map<String, dynamic>) return Todo.fromJson(map);
      if (map is List) return map.map((item) => Todo.fromJson(item)).toList();
    };
    httpClient.baseUrl = 'https://jsonplaceholder.typicode.com/';
  }

  Future<Todo?> getTodo(int id) async {
    final response = await get('$id');
    return response.body;
  }

  Future<Response<Todo>> postTodo(Todo todo) async => await post('', todo);
  Future<Response> deleteTodo(int id) async => await delete('$id');
}

If I change the httpClient.defaultDecoder to:
httpClient.defaultDecoder = (map) {      return Todo.fromJson(map);     };
works OK. But if I add a method to get the todo list, then does not because as you can see the list decoder is needed but is not provided anymore and throws:
Unhandled Exception: type '(dynamic) => Todo' is not a subtype of type '((dynamic) => List<Todo>)?' in type cast

i slove it by this:
await post<LoginPhone>('', loginphone, decoder: ((dynamic)=>LoginPhone()));
and it works will


Personality insights v3

Summary
Updated Personality Insights to include V3 in response to Issue 519.

Current coverage is 0.00% (diff: 100%)

Merging #526 into master will not change coverage

@@           master    #526   diff @@
=====================================
  Files         170     170
  Lines       12810   12810
  Methods         0       0
  Messages        0       0
  Branches        0       0
=====================================
  Hits            0       0
  Misses      12810   12810
  Partials        0       0

Powered by Codecov. Last update 268b1b5...0aa8d68

Just want to say that you did a fantastic job, @schen22!
I was super nitpicky with the reviews. But that's only because this is the first service you've written for the SDK--I wanted to leave lots of comments to explain as much as possible. Realistically, we could almost ship this code as-is.

Awesome, looks great! I'll go ahead and merge these changes into master.
On a random note, apparently Watson thinks that JFK is likely to enjoy Latin music according to this 1962 State of the Union address.


[diem-vm] fix performance regression

PR #6891 introduced an unintended performance regression by using a separate TransactionDataCache for the validation step during execution. Account data that was deserialized while validating a transaction had to be deserialized again while executing it. This changes to pass around the VM session so that the same cache is used in both steps.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
No behavioral change; ran existing tests

The code looks good to me, but I wonder why certain ci tests (most notably lint, unit-test, e2e-test) got skipped. Shall we check with dev infra about it?

The code looks good to me, but I wonder why certain ci tests (most notably lint, unit-test, e2e-test) got skipped. Shall we check with dev infra about it?

The code looks good to me, but I wonder why certain ci tests (most notably lint, unit-test, e2e-test) got skipped. Shall we check with dev infra about it?

The code looks good to me, but I wonder why certain ci tests (most notably lint, unit-test, e2e-test) got skipped. Shall we check with dev infra about it?

/land

/land

:broken_heart: Test Failed - commit-workflow

:broken_heart: Test Failed - commit-workflow

/land

/land

:broken_heart: Test Failed - Build images and run cluster test

:broken_heart: Test Failed - Build images and run cluster test

/land

/land


Add openSUSE Tumbleweed containers using the DNF package manager

These shortnames make it easy to access the alternative openSUSE Tumbleweed containers using DNF or Micro DNF package managers instead of Zypper.

LGTM
@rhatdan @vrothberg PTAL

LGTM
@rhatdan @vrothberg PTAL

LGTM

LGTM

Late LGTM :)
Thanks for contributing, @Conan-Kudo

Late LGTM :)
Thanks for contributing, @Conan-Kudo


Add e2e test

Issue #, if available: N/A
Description of changes:

adds e2e test to test success/happy path:

request spot instance
run spot-interrupter against this instance
validate results are as expected

Details:

Future PR will update github workflows to add e2e-test once onboarded to creds rotator

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

LGTM 🚀


Using %matplotlib widget can hang the kernel? Not sure.

Not sure what's hung but I had this code:
df = pd.read_csv('file name here')
%matplotlib widget
df.plot(x="Location", y="First Tooltip")

Worked on conda, failed on my global python. And failed means never returning.

Stopping or interrupting has no effect.

Even restarting doesn't seem to work.

If this didn't happen in webview or interactive window, then we should address for native notebook GA.


[Impeller] Raster time regression on default precision changes

ttps://github.com/flutter/engine/pull/43183 changed the default precision of the vertex stage back to highp, as well as the fragment stage of the rrect blur. This was intended to fix fidelity issues, but we did regress raster time a bit:
https://flutter-flutter-perf.skia.org/e/?begin=1687771256&end=1687828539&keys=X54649286414cd6c02eda6b3401877fbe&num_commits=50&request_type=1&xbaroffset=35487
This seemed to primarily effect the moto g4. We should investigate whether we can claw some of this loss back by carefully opting part of the vertex stage back into mediump, or confirm its not due to the change in rrect blur.
In general, positional data needs to be highp, but uvs and colors can be mediump.

This seems like working as intended.


Documentation improvements

(this is a collection of previous common questions that could end up in a recipes or explanations section of the docs) -- contribution is more than welcome!
Explainers:

[ ] Explain passive watcher / JIT compilation (nice article by @antfu ) (from https://github.com/unjs/unbuild/issues/265)
[ ] Explain inlineDependencies (from https://github.com/unjs/unbuild/issues/376)

Recipes:

[ ] Mkdist dual format (from https://github.com/unjs/unbuild/issues/311)
[ ] Decorators (from https://github.com/unjs/unbuild/issues/309)

Usage:

[ ] Source map usage (from https://github.com/unjs/unbuild/issues/348)

🫡will try to understand and contribute.


Restore twitter connector

Restore twitter connector for those who manage their own credentials
Steps for acceptance

staging: https://twitterdata.carto-staging.com/dashboard/datasets/
New Dataset / Twitter
Choose a small period (4h) and a bit weird term: eg 'a-twitter-search'. Set the credits slider to the minimum

Connect dataset

You will see:

a successful import text
a working SHOW button
a table with results

Thx for the comments,
Yeah, the date picker appeared broken, like this:

I've applied your suggestions


Hydraulic balancing entity state is always OFF

Describe the bug
I have enabled Hydraulic balancing in Bosch app but it's still being reported in HA as OFF. I tried toggling the value in the app, restarting HA, but nothing changes - it's always OFF.
Expected behavior
Hydraulic balancing entity state should be ON when Hydraulic balancing is enabled in Bosch app.
Screenshots

Version

HA version 2021.12.7
HA Bosch component version v0.16.9

Debug SCAN
bosch_scan.json.txt

Forgot to mention, fixed in 0.17.0


Swipe mode on mobil device

Where do I find the swipe mode in the new custom header?

Look at the pinned issue at the top of the issues page


TabError: inconsistent use of tabs and spaces in indentation

Hi! I faced an error while using this library.
In last block of code you have mixed tabs and spaces so Python throws an error:
File "/.../venv/lib/python3.9/site-packages/array_utils/code.py", line 22
    if endpoint:
TabError: inconsistent use of tabs and spaces in indentation

Hi Aleksandr!
Thanks for bringing this error to my attention. I made this library for a college project. I didn't think that someone would actually use it. Anyways, the issue is fixed now.
Best regards,
Abdullah Baig

I've found your lib as a dependency in a project I'm in =)


No module named 'sdl2'

Hi I'm trying to run the streaming.py and I keep getting an error while importing PdrawRenderer:
from olympe.video.renderer import PdrawRenderer
File "/home/amir/anaconda3/envs/olympus/lib/python3.8/site-packages/olympe/doc/examples/temp.py", line 4, in
from olympe.video.renderer import PdrawRenderer
File "/home/amir/anaconda3/envs/olympus/lib/python3.8/site-packages/olympe/video/renderer.py", line 2, in
import sdl2
ModuleNotFoundError: No module named 'sdl2'
ERROR conda.cli.main_run:execute(33): Subprocess for 'conda run ['python', '/home/amir/anaconda3/envs/olympus/lib/python3.8/site-packages/olympe/doc/examples/temp.py']' command failed.  (See above for error)

I fixed this issue by running
pip install PySDL2


No tab title for About page

What did you expect to happen?
I expect that the title of the tab for the About page to be "About - Jupiter"
What happened?
Currently, the tab shows localhost:3000.

Version
Pre-release (Development)
What browsers are you seeing the problem on?
Safari
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hey @Jake3231
I can try to fix this. Could you please assign?


Patch to include check if system supports architecture of lokl image

In relation to https://github.com/leonstafford/lokl/issues/34
Performing check in the case that there is a timeout.

@nevehallon - the check in /var/lib/dpkg/arch looks a bit too OS-specific.
Would a uname call give us enough info about the arch?

To elaborate, sorry. That path doesn't seem to exist outside of Debian-based distros or others which have specifically installed dpkg

@nevehallon what architecture was your Lubuntu running on? Arm64?

@nevehallon what architecture was your Lubuntu running on? Arm64?

It's running on amd64

@nevehallon - the check in /var/lib/dpkg/arch looks a bit too OS-specific.
Would a uname call give us enough info about the arch?

uname doesn't provide achitecture information. At least not on my OS...

Try 'uname -a', that usually ends with arch on *buntus

I see.
I guess then it's best to sift through all the possible values for uname -m in order to determine if there is support for arm64.

Or, perhaps a more concise check would be running arch.
I get x86_64 on my machine and arch64 in the container via SSH.
Is that a better check? More OS-friendly?

That looks perfect!
Just tested on my M1 mac and a remote OpenBSD machine:
leon@Leons-MacBook-Pro ~ % docker buildx ls
NAME/NODE DRIVER/ENDPOINT STATUS  PLATFORMS
default * docker
  default default         running linux/arm64, linux/amd64, linux/ppc64le, linux/s390x, linux/386, linux/arm/v7, linux/arm/v6
leon@Leons-MacBook-Pro ~ % arch
arm64
leon@Leons-MacBook-Pro ~ % ssh someopenbsd
someopenbsd$ arch
OpenBSD.amd64

That docker buildx ls command from https://docs.docker.com/desktop/multi-arch/#build-and-run-multi-architecture-images I first thought was stating run capabilities for the host, but looks more like something I should be making sure I'm building with for more compatible images...
Will need to finish my current task before can properly look into this, but if you want to adjust the PR, I can test the scripts against a variety of architecture VPS's later to try and reproduce the issue.
(There is an argument to just show the arch with OpenBSD's arch command, might be similar on other BSDs, too. Noting, that OpenBSD has no ability to run Docker/Lokl yet, but I believe it might work fine on FreeBSD).

Wasn't sure if I should include  docker buildx ls as a check. (can remove if not needed)
I went with the uname -m - apparently arch is not installed by default acording to this doc:
https://www.gnu.org/software/coreutils/manual/html_node/arch-invocation.html#arch-invocation

-"arch is not installed by default, so portable scripts should not rely on its existence."

@leonstafford Let me know if this adjustment works.

Many thanks @nevehallon!
It will take me a bit of time to get to test this on a few systems, but looks great!


FR: few things

support clipped image to obsidian( copy an image then "send" short cut)
support comment feature( do not need jump to obsidian just clip and comment)
support short cuts in the browser( select then "comment"short cut then comment, and always in current page)

I will look into allowing comments, though I was trying to limit the code actually in the bookmarklet.
I just released version 0.0.5 which has settings to control if obsidian should be opened when clipping to any of the supported note types (daily, weekly, or the new topic notes).
Currently, if you highlight an image and click the bookmarklet, it will link to the image in the note. Is this not what you are looking for?

support short cuts in the browser( select then "comment"short cut then comment, and always in current page)
I am not sure what you mean by this. By current page, do you mean current opened obsidian note? The Topic/Subject note type I just added may interest you. If you open the command palette in Obsidian, type obsidian clipper note, select Obsidian Clipper: Note Bookmarklet, this will open a modal with a bookmarklet to clip to the currently open note.

first, my apology to confuse you
for the image: I mean to download the image like the image copy-paste feature in obsidian. the image will be stored in the attachment directory. in my workflow, I'd like to use screenshots /snippets to take quick notes. so I'd like to copy an image and then from the system clipboard to send to obsidian via this plugin.
for the current page: I mean in the browser page. I like vim feature a lot, so i use vimium c in chrome, that is why I need a keybinding feature of this plugin.

support short cuts in the browser( select then "comment"short cut then comment, and always in current page)

Chrome supports this directly for extensions and the plugin now supports installing the bookmarklet as an extension.

I am going to close this. The latest release has the a 'add comment' feature in advanced -> Experimental Settings. Still need to work on it, but it is a start.
The keybinding part can possibly be fixed by installing the Chrome-based extension and setting a keybinding via Chrome.
You can use the https://github.com/aleksey-rezvov/obsidian-local-images plugin to have any clipped images downloaded locally.


[WIP,POC] Faster functional modules

Proposes a new method to load weights in FunctionalModule and FunctionalModuleWithBuffers.
A map module <-> param_name <-> param_value is created and used to set attributes.
Test:
The following test runs twice as fast on CPU than current implementation:
if __name__ == "__main__":
    # module with high param allocation cost but few operations
    net = torch.nn.Sequential(
        torch.nn.Linear(1, 1),
        torch.nn.Linear(1, 1),
        torch.nn.Sequential(
            torch.nn.Linear(1, 1),
            torch.nn.Linear(1, 1),
            torch.nn.Linear(1, 1),
            torch.nn.Linear(1, 1),
        )
    )

    fnet, params = make_functional(net)
    x = torch.randn(1)
    print(timeit.timeit("fnet(params, x)", globals={"fnet": fnet, "x": x, "params": params}, number=10000))
    # 1.7 sec with new, 3.8 with old

    # the implementation supports serialization
    import tempfile
    with tempfile.NamedTemporaryFile() as file:
        torch.save(fnet2, file.name)
        loaded_fnet = torch.load(file.name)
        assert torch.isclose(fnet2(params, x), loaded_fnet(params, x))

Other metrics:
On torchrl's DDPG, the new in a full forward-backard pass, the old implementation of _swap_state takes approx. 20% of the runtime with small neural nets (2 layers MLP with 256 cells) on CPU. The new implementation takes approx. 6% of runtime.

Good point, how does functorch support that now?


fix(ipfs-coord): Updating to v6.8.6

:tada: This PR is included in version 2.0.8 :tada:
Your semantic-release bot :package::rocket:


pycolmap build from source error

Building pycolmap in a Docker container where the main branch of colmap is installed.
Host machine: Ubuntu 22.04, CUDA 12.4
Docker image: Ubuntu 22.04, CUDA 11.7 (had issues building colmap with 12), ceres 2.2 (from source), colmap (main branch)
The error is summarized here:
        Could not find a configuration file for package "colmap" that is compatible  with requested version "3.9.1".           The following configuration files were considered but not accepted:             /usr/local/share/colmap/colmap-config.cmake, version: 3.10-dev
It seems the pycolmap isn't compatible with the main colmap branch yet.  I had several issues building with colmap 3.9.1 but was successful with the main branch.  Is there any versions of pycolmap that support this version?
Full log output from python3 -m pip install . attached
log.txt

As the mentioned in the README, if you want to build from COLMAP HEAD, please use the new fork that lives in the COLMAP repository: https://github.com/colmap/colmap/tree/main/pycolmap


Thread.Join() method not working with nested async void.

Issue Title
Thread.Join() method not working with async void nested in infinite loop.
General
I am getting unexpected results when using Thread.Join() with an async void method.
In the test below I am consistently hitting the Assert.True(false); part, but I do not expect this to happen.
Test file:
using System;
using System.Threading.Tasks;
using System.Threading;
using Xunit;

namespace BugReport
{
    public class DotnetBug
    {
        public class RepeatExecuteRequest
        {
            public async void Execute()
            {
                do
                {
                    try
                    {
                        await ExecuteRequest();
                    }
                    catch
                    {

                    }
                } while (true);
            }

            protected async Task<int> ExecuteRequest()
            {
                // here I am simulating the actual request
                await Task.Delay(100);
                return 0;
            }
        }

        [Fact]
        public void Bug()
        {
            // arrange
            var subject = new RepeatExecuteRequest();

            // act 1
            var t = new Thread(_ => subject.Execute());
            t.Start();

            // I expect this join to lock the thread indefinitely
            t.Join();

            // assert 1
            // infinite loop + thread.Join means I should never hit this part
            Assert.True(false);
        }
    }
}

csproj

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>netcoreapp2.1</TargetFramework>

    <IsPackable>false</IsPackable>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.9.0" />
    <PackageReference Include="Moq" Version="4.12.0" />
    <PackageReference Include="xunit" Version="2.4.0" />
    <PackageReference Include="xunit.runner.visualstudio" Version="2.4.0" />
  </ItemGroup>

</Project>

This isn't a bug and thread.Join can't do anything useful because the thread is already completed. With asynchronous programming, the thread ends when something is being awaited on and resumes on a different thread when it resumes. When you figure and forget using async void, the thread will end immediately when the first await is encountered.
What you want to do is actually return a Task from Execute (and rename to ExecuteAsync) and also make all of the callers asynchronous.
using System;
using System.Threading.Tasks;
using System.Threading;
using Xunit;

namespace BugReport
{
    public class DotnetBug
    {
        public class RepeatExecuteRequest
        {
            public async Task ExecuteAsync()
            {
                do
                {
                    try
                    {
                        await ExecuteRequest();
                    }
                    catch
                    {

                    }
                } while (true);
            }

            protected async Task<int> ExecuteRequest()
            {
                // here I am simulating the actual request
                await Task.Delay(100);
                return 0;
            }
        }

        [Fact]
        public async Task NotABug()
        {
            // arrange
            var subject = new RepeatExecuteRequest();

            // act 1
            await Task.Run(() => subject.ExecuteAsync());

            // assert 1
            // infinite loop + thread.Join means I should never hit this part
            Assert.True(false);
        }
    }
}

Correct me if I am wrong, but the async void part is a red herring.
The call to the async method is inside an infinite loop which should stop the thread from completing.

Could it be that the manually created thread is being released by the "await" operator, and the execution is continued on another thread?

Makes  sense, thanks


Get the jobs from the workers

Description

Is should be possible to get the state of all the background tasks.
Motivation and Context

Better understanding of the background tasks.
How Has This Been Tested?

Not yet.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My code follows the code style and structure of this project.
[X] I have updated the documentation accordingly.

:tada: This PR is included in version 0.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Mixed dependencies in the Storage Clients module for the Data Layer

Describe the bug
When importing a certain storage client for usage in the data layer (e.g. S3StorageClient), one might encounter import errors due to mixed dependencies in the module, such as: Azure packages missing.
To Reproduce
Steps to reproduce the behavior:

Install Chainlit with relevant packages for using the S3StorageClient for the data layer (i.e. boto3)
Make sure you have no Azure packages installed in your Python runtime env.
Try importing the client with from chainlit.data.storage_clients import S3StorageClient
You should encounter import errors because the storage_clients module has top-level imports for Azure:

import boto3  # type: ignore
from azure.storage.filedatalake import (
    ContentSettings,
    DataLakeFileClient,
    DataLakeServiceClient,
    FileSystemClient,
)

(Note the top-level import of both boto3 and azure.storage.filedatalake within the module, even though we only choose one client out of the two)
6. Same issue would apply if you had Azure dependencies installed, but not S3 (boto3)
Expected behavior
The storage client should be importable and ready for instantiation based on the type you require, without having to install all other storage clients' dependencies.
Desktop (please complete the following information):

OS: iOS
Version: 1.2.0

I can imagine that splitting the storage_clients module to separate sub-modules based on the specific client type (e.g. S3, Azure, GCS etc.) would resolve this issue, as each would import only what that specific client needs.

A simple workaround is to just create a new script for only S3StorageClient and import it from there into your main app.py file.
I could do a PR to handle this maybe in the next days.

I can imagine that splitting the storage_clients module to separate sub-modules based on the specific client type (e.g. S3, Azure, GCS etc.) would resolve this issue, as each would import only what that specific client needs.

I have done this locally (creating a new script for only S3StorageClient and import it from there into your main app.py file) and it works like a charm. I could do a PR to handle this maybe in the next days.

Yes, I have done so too and it works fine, but I imagine some people would not appreciate having to do that, or not realize that this is a solution.
Bunching all the imports together in the same module for all the storage clients just seems like a simple oversight to me. I'm not sure why the data layers were properly distributed to modules (e.g. dynamodb in its own module) but the storage clients weren't.

Describe the bug When importing a certain storage client for usage in the data layer (e.g. S3StorageClient), one might encounter import errors due to mixed dependencies in the module, such as: Azure packages missing.
To Reproduce Steps to reproduce the behavior:

Install Chainlit with relevant packages for using the S3StorageClient for the data layer (i.e. boto3)
Make sure you have no Azure packages installed in your Python runtime env.
Try importing the client with from chainlit.data.storage_clients import S3StorageClient
You should encounter import errors because the storage_clients module has top-level imports for Azure:

import boto3  # type: ignore
from azure.storage.filedatalake import (
    ContentSettings,
    DataLakeFileClient,
    DataLakeServiceClient,
    FileSystemClient,
)

(Note the top-level import of both boto3 and azure.storage.filedatalake within the module, even though we only choose one client out of the two) 6. Same issue would apply if you had Azure dependencies installed, but not S3 (boto3)
Expected behavior The storage client should be importable and ready for instantiation based on the type you require, without having to install all other storage clients' dependencies.
Desktop (please complete the following information):

OS: iOS
Version: 1.2.0

I can imagine that splitting the storage_clients module to separate sub-modules based on the specific client type (e.g. S3, Azure, GCS etc.) would resolve this issue, as each would import only what that specific client needs.

Let us know if you are doing a PR for this (to avoid double work). I imagine a storage_clients module in the data module with a base.py and files for each implementation (and, preferably, no code in __init__.py.
I love how active this community is! ❤

I will look into doing one tomorrow, unless someone beats me to it :)

I will look into doing one tomorrow, unless someone beats me to it :)

Hi guys, I am trying doing the PR and I am working on Windows.
I have set up everything but once running pnpm run buildUi I am encountering errors (tsup: command not found).

Hi guys, I am trying doing the PR and I am working on Windows. I have set up everything but once running pnpm run buildUi I am encountering errors (tsup: command not found).
Should I open a new issue on this? Is Windows supported?

Did you do pnpm install before running the build?

@hadarsharon @ndricca No need to work both on the same PR, plenty of other bugs and cleanup left! :')

I have done PR #1363 , can you check it?

Closing this in favour of the PR (just for our overview).


Update license to Apache 2.0

Coverage remained the same at 46.984% when pulling a5cc0994bc4ac55d61099fc874b58f5daf5caabd on EzequielPostan:license-update-to-apache into 4405ea45e3acebd5d145dbf9a8c33638b5bd7f3f on ScorexFoundation:master.

@EzequielPostan please remove COPYING file also


Use file extension to choose input file type if the extension is .csv or .tsv

If the input file name ends with .csv or .tsv this should determine the input file type, unless overridden by --filetype.

Already implemented. Docs now updated.


by default put user to the list of the users that can be added to the group

User who created the group is not in the list of potential group members:

Users can always see themselves. Hence, they by default can be added (with a proper handle) to the dropdown list of the users that can be added to the group the user manages. ATM, user needs to

switch to the Details tab
copy the full ID (see https://github.com/nuvla/ui/issues/727)
return back to the Groups tab
paste the ID to the edit box of the dropdown

And this also assumes that the user knows all that.

I created a group, and I was able to add myself from the dropdown to the group.

Demo of the issue has been provided. In some cases dropdown list is empty.