Use relative submodules

This allows users to make a deep mirror of the repositories to safe bandwith.
Signed-off-by: Andreas Pokorny<EMAIL_ADDRESS>

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Andreas Pokorny seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

sorry.. please try again

Thank you for the PR, it does solve the mirroring problem in a nice way! We are having some internal discussions about this approach. I will update when we reach some conclusion.

Besides bandwidth the other problem this would solve is that our CI system might loose internet connectivity during the build.

Hi @APokorny ,
Sorry for the slow reply getting back to you.
We were looking at some similar approaches to solve this as well, because we have internal Git repos inside China (our "primary" internal repo is not github), and also experience some performance problems dealing with Github at times.
In the end, we resolved this in a different way. You can take a look through how our CI system handles it:
https://github.com/espressif/esp-idf/blob/master/.gitlab-ci.yml#L44
https://github.com/espressif/esp-idf/tree/master/tools/ci
... we use "git config submodule..url" a lot to override the paths of submodules. You can see the "mirror-submodule-update.sh" script which does this.
Unfortunately, this approach (and our non-github main repo) is not compatible with relative paths of this kind. So we can't accept this PR.
Sorry about that (and the slow reply),
Angus


Update Rules

Some opinionated changes I made. Feel free to close this if you disagree.

Label configs for debugging in the ESLint Config Inspector.
Switch off deprecated rules.
Enable most of the recommended Unicorn rules. (Most controversial commit)

Docusaurus's ESM support is a sham![^1] They're just using Jiti, so this PR requires... the dreaded eslint-disable comment: unjs/jiti#101
[^1]: Very much an exaggeration, full of hyperbole: Jiti is certainly ESM, they're just not ESM, we have to be... patient! 😜

@lishaduck coming back to this, i think we ended up integrating most of the changes here within https://github.com/AndreaPontrandolfo/sheriff/pull/326.
About the unicorn changes, it's definitely a change I don't want. I'm pretty happy with how we are handling unicorn rules right now, i want to keep hand-picking them because some of them are extremely opinionated, I don't want to introduce any rule without a specific reason, and some of those rules just don't fit within Sheriff philosophy.
About the config labels, i don't see much of a usecase for them right now, but i'm not opposed about introducing them.
About the deprecated rules, i left a in-code comment.

About the unicorn changes, it's definitely a change I don't want. I'm pretty happy with how we are handling unicorn rules right now, i want to keep hand-picking them because some of them are extremely opinionated, I don't want to introduce any rule without a specific reason, and some of those rules just don't fit within Sheriff philosophy.

Yeah, I agree there. I do want to revisit some of them, but I agree we shouldn't extend their recommended config.

About the config labels, i don't see much of a usecase for them right now, but i'm not opposed about introducing them.

They're primarily for the ESLint config inspector, but are generally recommended (the inspector really helps with debugging). I will say that the prefered format is eslint-config-sheriff/someconfigpartname, which I didn't know at the time.

Superseded by #331.


The "times"-parameter does not allow "-character

The "times"-parameter inside of the configuration blocks to arrange
{apply,}notifications does not allow "-character around the values of
the keys in the hash.
The template used for both these type invokes the #inspect function on
the value of the hash. Always surround the value with double
apostrophes.
This commit fixes that issue.

@valentinogagliardi Sorry for the extreme delay. Thank you for the PR.

@vkhatri When will this be deployed to supermarket?

@vkhatri Any news on the timeline for a deploy to supermarket? Would be useful for us if we kan remove our own fork...
Thanks!


Improve testing

The latest release broke a documented feature.
Regardless of how this situation will be solved, I propose to improve automated testing. Here are some of my suggested changes.
It includes a currently @unittest.skip() marked test (FormTests.test_form_condition_callable) which leads to a RecursionError due to using get_cleaned_data_for_step in a condition_dict callback.

This could probably be split up so it could be merged more easily.
I'm bound to have missed bits, but for instance there are improvements to tests on -

Cookies
File Uploads

If you make these separate PRs they can go in on their own + will be easier for others to evaluate; I haven't gone though the commits, but it may be you can create new PRs and cherry pick the relevant commits.
We may even want to split things up a bit in the test class, rather than having one large one.

I guess anyone can make this go forward by creating distinct and reviewable PRs (keeping original author ownership, of course).


chore: bump deps

📝 Changed routes:

/internal/somecard
/studio/[...tool]

(view full size)
(view full size)

Commit 701a2db7c419319ddb1ce96bcdf0c23f10774593 (https://cv-cfpa0xuvf-stipsan.vercel.app).


Synchronize scheduled poll() calls in SQLMetadataRuleManager to prevent flakiness in SqlMetadataRuleManagerTest

This PR should fix #6028, however it doesn't address two other problems mentioned in that issue:

Possibility of a deadlock in a database when there is a query making an inner join of a table with itself, and a query dropping this table in parallel. I wonder if there is an SQL feature to "truly lock" a table to prevent this.
SQLMetadataRuleManager possibly mixing two abstractions, that should be in different classes.

This is a regression bug and should be included in 0.12.2.

NVM. It's already tagged.


fix: Suspend test fix. Fixes #2543

Checklist:

[X] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
[ ] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
[X] I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
[X] Optional. I've added My organization is added to the USERS.md.
[X] I've signed the CLA and required builds are green.

Am starting off by running some builds with the increased timeouts to look at the logs.

I'm currently unable to progress with this as I can't reproduce locally and the CI build is not executing.

Try merging master in?

@alexec it looks like the issue here was related to node offload. Why is there a different set of tests in CLIWithServerSuite as compared to CLISuite? It seems we would want to run this test in both.

@alexec it looks like the issue here was related to node offload. Why is there a different set of tests in CLIWithServerSuite as compared to CLISuite? It seems we would want to run this test in both.

The difference is that CLIWithServerSuite the Argo Server used has access to the Offload Node Status Repo, while in the CLISuite it does not. If your test needs access to the repo, add it to CLIWithServerSuite, if it doesn't add it to CLISuite. You can also add a:
if !s.Persistence.Enabled() {
    s.T().SkipNow()
}

check to protect tests that you only want to run in an environment where the Argo Server has (or doesn't have) persistence enabled.
I just did something similar, take a look at https://github.com/argoproj/argo/pull/2645/files#diff-4f326ca1865929af6dabf0119581b09cR473 for an example.

Thanks. I came across that, but in this case I would think the test should
run in both cases but I don’t want to duplicate the code. I’ll have a think
how to do this.
On Sat, 11 Apr 2020 at 17:06, Simon Behar<EMAIL_ADDRESS>wrote:

@alexec https://github.com/alexec it looks like the issue here was
related to node offload. Why is there a different set of tests in
CLIWithServerSuite as compared to CLISuite? It seems we would want to run
this test in both.
The difference is that CLIWithServerSuite the Argo Server used has access
to the Offload Node Status Repo, while in the CLISuite it does not. If
your test needs access to the repo, add it to CLIWithServerSuite, if it
doesn't add it to CLISuite. You can also add a:
if !s.Persistence.Enabled() {
s.T().SkipNow()
}
check to protect tests that you only want to run in an environment where
the Argo Server has (or doesn't have) persistence enabled.
I just did something similar, take a look at
https://github.com/argoproj/argo/pull/2645/files#diff-4f326ca1865929af6dabf0119581b09cR473
for an example.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/argoproj/argo/pull/2548#issuecomment-612453881, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABO7LWHDD3U62I4MWTM2VTRMCIPTANCNFSM4LXCH5OA
.

@alexec Can you please tell me if this approach is ok before I move onto #2850
(and do you know why ci/circleci: test didn't run?)

The issue was workflow stop and resume by node didn't properly support offloaded nodes, I'll change the name.

@alexec FYI I have just rebased on master.

@alexec please take another look now.

Please fix lint error:
workflow/util/util.go:486:27: Error return value of `compressAndOffloadNodes` is not checked (errcheck)

			compressAndOffloadNodes(wf, repo, nodes)

Can you login to https://app.circleci.com/? I think you might need to do that to prevent the unauthorized error.

@alexec I get a 404 at https://app.circleci.com but I have logged into https://circleci.com/dashboard - unfortunately it didn't help.

OK. I've just merged a fix to master that I think will fix it. Can you sync with master please?

@alexec
Looks like that worked 👍

Boom! Merged! 🚀


<EMAIL_ADDRESS>fails

I'm not sure if this is a coreos-vagrant issue, coreos issue, vagrant issue, virtualbox issue, or osx issue.

when i vagrant up my coreos-vagrant box, it prompts me for password

$ vagrant up
Bringing machine 'core-01' up with 'virtualbox' provider...
==> core-01: Clearing any previously set forwarded ports...
==> core-01: Clearing any previously set network interfaces...
==> core-01: Preparing network interfaces based on configuration...
    core-01: Adapter 1: nat
    core-01: Adapter 2: hostonly
==> core-01: Forwarding ports...
    core-01: 22 => 2222 (adapter 1)
==> core-01: Running 'pre-boot' VM customizations...
==> core-01: Booting VM...
==> core-01: Waiting for machine to boot. This may take a few minutes...
    core-01: SSH address: <IP_ADDRESS>:2222
    core-01: SSH username: core
    core-01: SSH auth method: private key
    core-01: Warning: Connection timeout. Retrying...
Text will be echoed in the clear. Please install the HighLine or Termios libraries to suppress echoed text.
<EMAIL_ADDRESS>password:

when i do login (using cleartext password), i get this error

==> core-01: Machine booted and ready!
==> core-01: Setting hostname...
The following SSH command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!

systemctl start<EMAIL_ADDRESS>
Stdout from the command:

Stderr from the command:

Job for<EMAIL_ADDRESS>failed because a configured resource limit was exceeded. See "systemctl status<EMAIL_ADDRESS>and "journalctl -xe" for details.

when i finally get in somehow, my shared/synced folders are no longer shared.

my biggest problem is that i cannot get shared folders to work.
i've been using coreos-vagrant for a long time without any issues.
i did a vagrant box update and nothing changed.
when i spin up a brand new machine, i have the same problems.
my wife works with me, and her coreos-vagrant is also now having the same issues.
has anyone ever experienced problems like this?
coreos-alpha  (virtualbox, 709.0.0)

Duplicate of https://github.com/coreos/bugs/issues/382.

@crawford this has been fixed in the overlay. how do i apply the fix to my vagrant box?

You can either build an image from source or use one of the older images. We will roll out a fix for this in about a week.

How do I build the image from scratch?

The instructions for building an image can be found here. It will be much faster if you just use a Beta or Stable image for the time being.

@morgante i just rolled back my update and was able to work again.
see instructions on rolling back to the previous version here: https://coreos.com/docs/cluster-management/debugging/manual-rollbacks/

@theRemix Thanks for the tip, I ended up switching to the stable channel for now.


bellpepper-emulated: Add missing final carry check and fix limb count calculation

I missed the final carry check in the limb-wise equality check code in crates/emulated/src/field_ops.rs:assert_limbs_equality_slow. Adding this check revealed another bug which was under-counting the number of new limbs in crates/emulated/src/field_element.rs:compact_limbs.
This PR fixed these bugs and updates the constraint counts (which have all increased). I am marking this PR as draft as I could not calculate the updated counts in the crates/bls12381/src/curves/pairing.rs. My machine ran out of RAM. If someone can  tell me the updated values, I can add them.
EDIT: I got the updated number of constraints and variables from Github test failures.
Explanation
When two non-native field elements are equal, it is not necessary that their respective limbs will all be equal to each other. But they will be equal as big integers.
For example, suppose the limb width is 4 bits. The integer 100 can be written as $a = 6 \times 2^4 + 4$ and $b = 5 \times 2^4  +20$. The limbs of $a$ are $a_0=4, a_1=6$ and the limbs of $b$ are $b_0 = 20, b_1 =5$. There is no overflow in the limbs of $a$ while the limbs of $b$ have an overflow of 1 bit. The overflow allows the two different sets of limbs to represent the same integer. The difference of the limbs $a_0 - b_0 = -16$. This means that $-1$ has to be carried and added to the difference $a_1 - b_1 = 1$.
To prevent underflow, the carry is first calculated by adding an offset max_value. In the next limb, the shifted version of max_value given by max_value_shifted is deducted.
The pseudo-code for the limb-wise equality check is as follows:
max_limbs = max(a.num_limbs, b.num_limbs)
max_value = 1 << (num_bits_per_limb + num_carry_bits)
max_value_shifted = 1 << num_carry_bits
carry = 0

for i in 0..max_limbs:
    e[i] = max_value + carry

    if i < a.num_limbs:
        e[i] = e[i] + a[i]
    if i < b.num_limbs:
        e[i] = e[i] - b[i]

    if i > 0:
        e[i] = e[i] - max_value_shifted

    if least_significant_num_bits_per_limb(e[i]) != 0:
        exit with error

    carry = e[i] >> num_bits_per_limb

assert_is_equal(carry, max_value_shifted)

I missed the assert_is_equal check in the last line. A more detailed explanation can be found in Section 5.5 of the document at https://github.com/avras/bellpepper-gadgets/blob/emulated-overflow-fix/crates/emulated/docs/overflow.pdf.
I discovered the missing check while working out the overflow bounds. That requires some changes to emulated as well. But I wanted to restrict the fix in this PR to final carry check and correct limb count calculation.

To sanity check my understanding, in the pseudocode and in the pdf (caveat: I have not fully read it yet), should the least_significant_64_bits(e[i]) actually be something like least_significant_num_bits_per_limb_bits(e[i]) since the limbs are not necessarily 64 bits long? (I believe this is the case, since the pdf considers the limb_width = 64 case for simplicity, but I wanted to double check)

Yes, you are right. It should be least_significant_num_bits_per_limb instead of least_significant_64_bits. If a compaction of limbs occurs, the num_bits_per_limb can be higher than the initial limb width (like 64). I have modified the pseudocode in the PR text. I will change it in the pdf as well.

Also, I'm not sure where in the emulated code we currently handle the if least_significant_64_bits(e[i]) != 0: exit with error check, shouldn't there be some check on the least-significant-bits of diff_num to follow the pseudocode correctly? Reading the pdf (though I did not read it all yet), it seems like this is always true if qn = d, but that is precisely what this is aiming to check, so we need to perform this check. Am I misunderstanding something, e.g. is this check being made implicitly inside right_shift, or it's not necessary to be specified as a constraint, or would this be part of the follow-up changes to emulated and is unrelated to the fix in this PR?

The check that the num_bits_per_limb least significant bits of diff_num are all zero bits is part of right_shift. We call right_shift with start_digit = num_bits_per_limb and end_digit = num_bits_per_limb + num_carry_bits + 1.
carry = Self::right_shift(
        &mut cs.namespace(|| format!("right shift to get carry {i}")),
        &diff_num,
        num_bits_per_limb,
        num_bits_per_limb + num_carry_bits + 1,
 )?;

In right_shift, we do the following

The value of diff_num is decomposed into a little-endian bit vector v_bits
A Boolean vector v_booleans is allocated using the v_bits[start_digit...end_digit]. This vector will have num_carry_bits + 1 elements.
The bits in v_booleans are weighted by powers of 2 to get sum_higher_order_bits as
sum_higher_order_bits = v_boolean[0] 2^(start_digit) + v_boolean[1] 2^(start_digit + 1) + ... + v_boolean[end_digit-start_digit-1] 2^(end_digit)
The value of diff_num is checked to be equal to the value of sum_higher_order_bits here. If the any of the num_bits_per_limb least significant bits of diff_num are not zero, this check will fail.

Regarding the CI clippy failure, feel free to cherry-pick ff3e970 onto your branch (or run clippy --fix locally if you prefer). The clippy::useless_vec got turned on by default in the latest rust stable release.

Thanks for the clippy fix. I have added it to the PR.

While replacing the 64 bits with limb_width in the pdf, I realized that the formula for number of limbs that can be combined was too conservative. I have made changes to the pdf. Please use the latest version for review. Thanks!

While replacing the 64 bits with limb_width in the pdf, I realized that the formula for number of limbs that can be combined was too conservative. I have made changes to the pdf. Please use the latest version for review. Thanks!

@wwared Please re-approve this PR. I only added the cargo fmt commit. The above comment was a request to review the latest pdf which describes fixes to the overflow bounds. I will be submitting a separate PR for these fixes.


[Release] Stage to Main

#247

Test URLs:
Before: https://main--bacom--adobecom.hlx.live/?martech=off
After: https://stage--bacom--adobecom.hlx.live/?martech=off

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.70%. Comparing base (5c18d1f) to head (94a0e5c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
+ Coverage   95.98%   96.70%   +0.71%
==========================================
  Files          11       12       +1
  Lines        1096     1335     +239
==========================================
+ Hits         1052     1291     +239
  Misses         44       44

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Respawn NPE

Minecraft v1.16.5
Forge v36.0.1
Tree Chop v0.12.1
Exotic Birds v1.0.3
I died on my server, but every time I clicked respawn, it would reappear. The server log also printed out an error every time the button was clicked. It mentions both this mod and Exotic Birds.
Error Log
Also reported to https://www.curseforge.com/minecraft/mc-mods/exotic-birds/issues/63

Thanks for the log! I'll have the TreeChop error fixed in a day or two.

Thanks for the log! I'll have the TreeChop error fixed in a day or two.

Thanks!

Thanks!

0.12.2 is posted with the fix. TreeChop won't show errors anymore when trying to respawn, but the root of the problem is still there (most likely another mod is messing up player information when respawning), so Exotic Birds will still show errors until it is also updated with a similar fix.

0.12.2 is posted with the fix. TreeChop won't show errors anymore when trying to respawn, but the root of the problem is still there (most likely another mod is messing up player information when respawning), so Exotic Birds will still show errors until it is also updated with a similar fix.

Will that fix be unable to respawn?

Will that fix be unable to respawn?

I think Exotic Birds needs to be updated to fix your respawn problem :( it’s a really bad bug!

I think Exotic Birds needs to be updated to fix your respawn problem :( it’s a really bad bug!

Yeah, true!

Yeah, true!

You could try this:

back up your world
remove Exotic Birds from your mods folder
start the game
respawn
quit the game
put Exotic Birds back into your mods folder

This might fix your respawn problem. However, if there are any birds near you, they will disappear. Also, make sure you’re using TreeChop 0.12.2.

You could try this:

back up your world
remove Exotic Birds from your mods folder
start the game
respawn
quit the game
put Exotic Birds back into your mods folder

This might fix your respawn problem. However, if there are any birds near you, they will disappear. Also, make sure you’re using TreeChop 0.12.2.

It's was just a test world anyways. :)

It's was just a test world anyways. :)


It seems the Unity version document should be updated

@kswain98 Hi, I met the same question about Navmesh, and I find a closed issue has solved it. It seems you'd better update the document soon about the Unity version to avoid others meeting this problem.
What else, I want to ask that has this project using NSM. I found a branch named NSM_incoporation and there is some code of NSM in it.

Hi @Xander23333! Thanks for letting me know! All the documentation will be updated this weekend. We are constantly pushing updates to the procedural_generation branch which will be merged as the master branch by Monday.
Regarding the NSM question, @xavierpuigf might have the answer for this.
If you are interested you can join the Discord channel, since you might get a faster response: https://discord.gg/f3U92kUu4b


Update google_api_auth.py

need to use tools.run_flow, since they've changed, that you can pipe in argument's to the credentials variable, if not able to authenticate with a local web browser. "--noauth_local_webserver"

Please fix the style mistakes reported by Travis. :-)

there, fixed.. only needed
'from oauth2client import tools'

Great! Do you think you can rebase and squash it all into one commit also?

just remove all the prev branches, and make a new patch branch, with that one commit that did build ?
if i understood it correctly .... ?

That would work, but you can also use rebase: https://help.github.com/articles/about-git-rebase/

Merged manually: e98729ef23c45dca6b18e412f7475e6f89ef6195. Thanks!


How to change the text of the Button to non-English in idp_button_google.xml and idp_button_facebook.xml?

This will be in the next release by #191.  Follow local installation instructions to use it manually.

Nice!  wait for so long. Thanks!


Invalid JSON input causes HTTP error 500

Any invalid JSON input causes a 500 HTTP code, e.g.
{
}

or
{
  "paragraphs": [
  ]
}

{
  "paragraphs": [
  ]
}

returns a 200. I agree with the other one, will fix that.

I agree with the other one - {} returns a 500 when it really should return 400.


what's "Show Right to Left"  used for in DockSampleproject under Tools menu?

when i run the DockSample project,I find the "Show Right to Left" make the layout to be left-right exchange,what's the meaning of this function?

左右颠倒之后，新建的窗口，标题都看不到了

Please understand the fact that for an international project like this we only welcome English based discussion. I will close such threads.

could you reopen this issue?

https://msdn.microsoft.com/en-us/library/7d3337xw(v=vs.100).aspx
Right-to-left is a feature to support some specific languages. If you don't design UI in those languages, you don't need to (and shouldn't) set it to true.


Data-driven system definition

Currently the system is created through the component/system-map function:
(defn new-system [config]
  (let [config (meta-merge base-config config)]
    (-> (component/system-map
         :app     (handler-component (:app config))
         :http    (jetty-server (:http config))
         :example (endpoint-component example-endpoint))
        (component/system-using
         {:http [:app]
          :app  [:example]}))))

But instead we could define the system via a data structure:
{:components
 {:app  duct.component.handler/handler-component
  :http ring.component.jetty/jetty-server}
 :endpoints
 {:example bar.endpoint.example/example-endpoint}
 :dependencies
 {:http [:app]
  :app  [:example]}}

And then have a system-factory function to construct the new-system function from the data structure.
(def new-system
  (system-factory (read-edn "foo/system.edn")))

As well as reducing the amount of code, it would also allow generators to more easily add components and endpoints to the system.

Is there any nuance to incorporating other libraries' components into the new edn-based configuration? Since these libraries must be require'd at some point, wouldn't their vars return ClassNotFound exceptions on use?
I'm trying to incorporate fixtures-component, but I receive errors that lead me to indicate that the vars I place in the configuration map lead to ClassNotFound Exceptions. I've created an issue over at fixtures-component with more information and stacktraces: https://github.com/banzai-inc/fixtures-component/issues/3
My overall question, is how can 3rd party components be incorporated into the configuration map? I've successfully incorporated duct components, and my own created ones, but there seems to be a nuance to using 3rd party libraries that haven't been require'd. Unless this is an error specific to fixtures-component.

Fixed in 0.8.0.


[SPARK-15559][PYTHON][STREAMING] Add hash method for TopicAndPartition

What changes were proposed in this pull request?
Adds implementation of hash method for TopicAndPartition
How was this patch tested?
PySpark unit tests (--python-executables python3.5 --modules pyspark-streaming)

Test build #59369 has started for PR 13324 at commit c1244aa.

Test build #59369 has finished for PR 13324 at commit c1244aa.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59369/
Test PASSed.

Merged build finished. Test PASSed.

Test build #65537 has started for PR 13324 at commit c1244aa.

Test build #65537 has finished for PR 13324 at commit c1244aa.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65537/
Test PASSed.

Merged build finished. Test PASSed.


[ refactor ] Use pretty directly for IntX

Sorry for the delay in reviewing this. You'll need to update the Idris2 version in .idris-version in order for the CI to succeed. Consider using the latest tag from here.

Thanks.  Updated to the latest tag.

Thanks a lot!


Fix OSGI protobuf bug

Resolves: https://github.com/apache/incubator-pekko/issues/685

lgtm - can we backport this too?

Yes but lets wait till tonight when the snapshot is published to confirm it fixes the problem


CreateDoppelganger has a bad while loop causing TMI

https://github.com/Finaldeath/nwscript_utility_scripts/blob/9a845d59071e929c0a91499e5a9e0b22db197801/creature/utl_i_creature.nss#L148-L153

Fixed a while back, oops missed this!


Fix: Fixed issue where drives had the wrong order in the sidebar

Resolved / Related Issues
Detected drives are always displayed at the end. It makes more sense to display them in order according to the path. Sometimes internal drives are not displayed in path order.  #10252.
This pr keeps drives sorted by path in the sidebar and homepage.
Validation
How did you test these changes?

[ ] Built and ran the app
[ ] Tested the changes for accessibility

@cinqmilleans can you verify how these changes were validated?

Btw, if this closes an issue, you can edit the PR description to look like this and it'll link the PR to the issue


Minimal dark mode

Ref: https://github.com/RobbiNespu/archie/pull/4/files
Minimal dark mode archie #13

Hi @athul , yes as mentioned on #13 , it for using light mode manual or light mode auto, the toggle will be visible.
there is only 1 icon which is fa-sun for both. Even though the icon name "sun" , It look like lamp to me. If you check the setTheme() funtion, I try replace icon with toggle.className but seem it not work. (that is where I left console.log) , maybe you or anyone can take alook?
But nevertheless , what I need is archive but it not likely a properly work and what people expected.
Someone else need to take care it. I not good with JS. You can give me change suggestion if you found the answer or just edit the commit and make changes

Hey, @RobbiNespu sorry I couldn't look more into it. I really am. But had to merge #36 since it was more concise and lesser code. Hope you can understand.
Thanks for the PR and wishing you good luck 🤝

Hello @athul , it fine. I am okey to close the PR #30. I also agreed PR #36 it was more concise and lesser code, perhaps much cleaner. Thanks for mention and wishing you good luck too 🤝
(Originally published at: https://robbinespu.gitlab.io/indieweb/2021-09-29-0000-comment-github-archie/)


Milestone 1: Setup redux store

In this milestone i completed:
1.Setup Redux
2.Setup linters

@approved


LightTable doesn't maintain fullscreen on OS X

LightTable is definitely the kind of IDE that makes more sense in fullscreen. However, on OS X, the expected behaviour is for an app to remain fullscreen, once you set it up that way.
LightTable, when quit, re-sets to being a windowed application, no matter how many times you fullscreen it while working. While only mildly annoying, this is behaviour that could be improved for Mac users. :P

This is a duplicate of #1814


Pretrained Models of CelebA-HQ

Hi @akanazawa , it would be great if you could release the pretrained models of CelebA-HQ or other models in your paper. Do you have any plans to release the models?

Here's a pre-trained model for CelebA-HQ:
https://drive.google.com/file/d/1qwmQtkGm-i0IKFqSEVWugh4DVpJW4CQJ/view?usp=sharing
You can run it with test.py.

Great thanks.


XmlDocument Validate against schema

Is there any way that you can validate a generated xml document against a schema in AL?
We have a e-invoicing solution that I'm currently redeveloping as an extension. One feature of this solution was that after generating the xml (from posted invoices) we did a validation of the xml against a schema. This was quite simple, and allowed a user to get an error or message if for some reason the generated xml did not comply to the schema. Usually the reason for not valid xml would be something like the customer address missing and the user could then easily correct this before sending actual .xml invoices to the bank or an intermediate operator (who would otherwise do the exact same schema validation but with all the overhead and costs involved with that).
Would it be possible to add a method for example in XML DOM Management codeunit to do this? Or even better if XmlDcoument had a Validate() method for this.
A workaround would be to do this via azure function I know, but that to me seems like a bad option at least in this case.

Hi! Please go ahead and post this to our Ideas forum at https://aka.ms/BusinessCentralideas, or vote up the idea if its already there. We're constantly monitoring top Ideas and will consider them for a future release.


Atom.Object.defineProperty.get is deprecated.

atom.workspaceView is no longer available.
In most cases you will not need the view. See the Workspace docs for
alternatives: https://atom.io/docs/api/latest/Workspace.
If you do need the view, please use atom.views.getView(atom.workspace),
which returns an HTMLElement.
Atom.Object.defineProperty.get (/usr/share/atom/resources/app/src/atom.js:54:11)
AtomJsHint.updatePane (/home/s2move/.atom/packages/atom-jshint/lib/atom-jshint.js:151:26)

@Joezo Please close this as a duplicate of #70. Blame Atom's own programming for this mess.


Delay zoom out when scrolling

Hello,
I notice that on Medium, you can scroll a bit before the image zooms back out (GIF: http://www.gfycat.com/UnequaledFixedBream). On both the site I'm using this on and the demo site, zoomed-in images minimize as soon as you scroll, which means that if I accidentally brush my scroll wheel and it moves slightly, the image minimizes. Is it possible to add a delay to the zoom-out so that you have to scroll a certain number of pixels before it zooms back out?
Thank you!

Not with the current API, as far as I can tell.
A possible fix is to update the number 40 to a greater number in your copy of the script.


User management URL in the GK API is wrong

@srodriguezOPT
Can you please try again? When you have time...
UM URL was not well defined...
Closed by #576

@jbonnet,
It's working!
once registered the test1/test user, it's possible to login the bss and retrieve the list of available services.


Cannot unmarshal bytes to object

I modify the hessian_test.go as follows:
type Person struct {
	firstName string
	lastName  string
}

func TestSerializer(t *testing.T) {
	p := Person{"John", "Doe"}
	gh := NewGoHessian(nil, nil)
	bt, _ := gh.ToBytes(p)
	p_new, _ := gh.ToObject(bt)
	fmt.Println("bt", string(bt))
	fmt.Println("p= ", p)
	fmt.Println("p_new= ", p_new)
	// reflect.DeepEqual(p, p_new)
}

But the ouput of p_new is nil, could you please help work on it ?
PS D:\go\src\github.com\viant\gohessian> go test -v .\hessian_test.go
=== RUN   TestSerializer
struct {John Doe}
clsName Person
bt C═Person�    firstNamlastName`╝John╚Doe
p=  {John Doe}
p_new=  <nil>
--- PASS: TestSerializer (0.00s)
PASS
ok      command-line-arguments  0.045s

Hey guy, suggest u do not use this package at present. There are so many bugs to fix.

Daniel,
Some back ground information, go hessian was design to interoperate between
java and go.
There are some java and go language difference. Like field attribute upper
and lower case. In go it is lower case, it is not accessible outside of
package
This will work
type Person struct {
*F*irstName string

*L*astName  string

}
func TestSerializer(t *testing.T) {
p := Person{"John", "Doe"}

*typMap := map[string]reflect.Type{"Person": reflect.TypeOf(p)}*

gh := NewGoHessian(typMap, nil)

bt, _ := gh.ToBytes(p)

p_new, _ := gh.ToObject(bt)

fmt.Println("bt", string(bt))

fmt.Println("p= ", p)

fmt.Println("p_new= ", p_new)

// reflect.DeepEqual(p, p_new)

}
On Tue, Oct 25, 2016 at 6:30 AM, Daniel Lin<EMAIL_ADDRESS>wrote:

I modify the hessian_test.go as follows:
type Person struct {
firstName string
lastName  string
}
func TestSerializer(t *testing.T) {
p := Person{"John", "Doe"}
gh := NewGoHessian(nil, nil)
bt, _ := gh.ToBytes(p)
p_new, _ := gh.ToObject(bt)
fmt.Println("bt", string(bt))
fmt.Println("p= ", p)
fmt.Println("p_new= ", p_new)
// reflect.DeepEqual(p, p_new)
}
But the ouput of p_new is nil, could you please help work on it ?
PS D:\go\src\github.com\viant\gohessian> go test -v .\hessian_test.go
=== RUN   TestSerializer
struct {John Doe}
clsName Person
bt C═Person�    firstNamlastName`╝John╚Doe
p=  {John Doe}
p_new=
--- PASS: TestSerializer (0.00s)
PASS
ok      command-line-arguments  0.045s
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/viant/gohessian/issues/1, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGDytna2AgwbMBdWbij7rb1d2ZU9fh1ks5q3gRfgaJpZM4Kf_Cw
.

just to add one more point for the reason of typMap: due to java and go
package name space difference.
Upper case for field name is must for go reflection, other wise you will
get can not write for reflection.
On Thu, Oct 27, 2016 at 10:27 AM, Mickey Hsieh<EMAIL_ADDRESS>wrote:

Daniel,
Some back ground information, go hessian was design to interoperate
between java and go.
There are some java and go language difference. Like field attribute upper
and lower case. In go it is lower case, it is not accessible outside of
package
This will work
type Person struct {
*F*irstName string

*L*astName  string

}
func TestSerializer(t *testing.T) {
p := Person{"John", "Doe"}

*typMap := map[string]reflect.Type{"Person": reflect.TypeOf(p)}*

gh := NewGoHessian(typMap, nil)

bt, _ := gh.ToBytes(p)

p_new, _ := gh.ToObject(bt)

fmt.Println("bt", string(bt))

fmt.Println("p= ", p)

fmt.Println("p_new= ", p_new)

// reflect.DeepEqual(p, p_new)

}
On Tue, Oct 25, 2016 at 6:30 AM, Daniel Lin<EMAIL_ADDRESS>wrote:

I modify the hessian_test.go as follows:
type Person struct {
firstName string
lastName  string
}
func TestSerializer(t *testing.T) {
p := Person{"John", "Doe"}
gh := NewGoHessian(nil, nil)
bt, _ := gh.ToBytes(p)
p_new, _ := gh.ToObject(bt)
fmt.Println("bt", string(bt))
fmt.Println("p= ", p)
fmt.Println("p_new= ", p_new)
// reflect.DeepEqual(p, p_new)
}
But the ouput of p_new is nil, could you please help work on it ?
PS D:\go\src\github.com\viant\gohessian> go test -v .\hessian_test.go
=== RUN   TestSerializer
struct {John Doe}
clsName Person
bt C═Person�    firstNamlastName`╝John╚Doe
p=  {John Doe}
p_new=
--- PASS: TestSerializer (0.00s)
PASS
ok      command-line-arguments  0.045s
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/viant/gohessian/issues/1, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGDytna2AgwbMBdWbij7rb1d2ZU9fh1ks5q3gRfgaJpZM4Kf_Cw
.

@mickeyhs It doesn't work according to your advice

@tinycedar
First:
pay attention to FirstName/ LastName
type Person struct {
    FirstName string
    LastName  string
}
Second:
new NewGoHessian with a typMap
 typMap:=map[string]reflect.Type{
 "Person":reflect.TypeOf(Person{}),
  }
  gh := NewGoHessian(typMap, nil)
Other tips:
And there's another way to register your classname when encode/decode
func (e *encoder) RegisterNameType(key string, javaClsName string) {
e.nameMap[key] = javaClsName
}
func (d *decoder) RegisterType(key string, value reflect.Type) {
d.typMap[key] = value
}
BUT just as @AlexStocks  said, there are so many bugs, string chunk / utf-8(rune) / BC_END ...
It works for me now,  temporarily.   /(ㄒoㄒ)/


Feature - Add support for relationships

This change adds support for handling relationships in both Android and iOS (mentioned in #54 )
Also:

Updated full example to be NNBD and bumped dependencies
Fix tests on Windows due to CRLF parsing when unfolding VCF

I didn't update the API docs, as it adds 300+ changes
It's no problem if you don't want to integrate this - thought I'd add back as I need this in my app.
(I'll be adding Custom Field support next, should be done in a few days)

Thank you so much for this PR


chore(deps): update rust crate http to v1

This PR contains the following updates:

Package
Type
Update
Change

http
dependencies
major
0.2.11 -> 1.0.0

Release Notes

hyperium/http (http)
v1.0.0
Compare Source

Implement Clone for Request, Response, and Extensions. This breaking change requires
that all extensions now implement Clone.
Add a default-on std feature. Disabling it currently is not supported.
Fix MIRI warnings in HeaderMap::iter().

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


Cleaned up code and introduced functions to better handle tasks.

@Blindsinner
Here are some changes that I made

a green bold text is used for successful responses
a red bold text is used for error based responses
new functions to handle the colorization of the successful def successful() and unsuccessful def error() responses
error checking and handling is implemented.
replaced some if statements with match.

Enter the IP address: <IP_ADDRESS>
Enter the subnet mask or CIDR notation: 20
IP Address: <IP_ADDRESS>
IP Subnet: <IP_ADDRESS> ( This should be Network Address)
IP Subnet Mask: <IP_ADDRESS>
CIDR Notation: 20
Possible Number of Subnets: 4096
Network address with CIDR Notation: <IP_ADDRESS>/20
IP class and private/public: Class C, Private ( This is a Class B ip, find something to fix it, i was unable to find.)
Binary IP Address: 11000000.10101000.00000001.00000001
Then please send me PR again.

Enter the IP address: <IP_ADDRESS> Enter the subnet mask or CIDR notation: 20 IP Address: <IP_ADDRESS> IP Subnet: <IP_ADDRESS> ( This should be Network Address) IP Subnet Mask: <IP_ADDRESS> CIDR Notation: 20 Possible Number of Subnets: 4096 Network address with CIDR Notation: <IP_ADDRESS>/20 IP class and private/public: Class C, Private ( This is a Class B ip, find something to fix it, i was unable to find.) Binary IP Address: 11000000.10101000.00000001.00000001
Then please send me PR again.

Currently, the code checks the IP class based on the first octet.
The other way to go about this might be to check the number of bits in the network portion.
With this info, you can now check to ensure that you are getting the IP class based on the CIDR notation and not just the default IP classes.
If you want, you could have another function check if it falls within the default known boundaries, then you can take actions from there.


Recipe App: Public recipe list

[x] Set the public-recipe-list to be the homepage in routes.rb file.
[x] Created public_recipe action inside the RecipesController that fulters recipes which are only public.
[x] Added view for public-recipe lists.
[x] Added styles for the public-recipe lists.
[x] Checked linters errors.

STATUS: APPROVE heavy_check_mark heavy_check_mark champagne
Hi @amare1990 This step is complete! Great work!
Take a look at my suggestions that are optional, but if you want you can merge it already :shipit:
Congratulations! tada clap clap 100

To highlight champagne
* Good commit history heavy_check_mark

* Good PR description heavy_check_mark

* All recipes that are public are displayed for any user  heavy_check_mark

Cheers and Happy coding!clapclapclap
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Thanks @tiagomarin for reviewing my issue addressing immediately.


Unwind: separate the "set frame reg" and "define new frame" operations to fix metadata bug related to stack checks.

In #3859 we discovered that the unwind metadata info on Windows is
placed slightly incorrectly in the presence of explicit stack checks in
function prologues. In particular, if the stack check fails, then we
start the process of backtracing from a state where we have actually
updated rbp (the frame pointer) but we have not emitted the metadata
saying we have done so.
The fix is to emit the SetFPReg Win32 unwind op exactly at the offset
of the mov rbp, rsp instruction, not after the stack check. However,
actually achieving this output given our current unwind design (which
abstracts over SysV and Win32) is slightly tricky, because:

We previously had a single DefineNewFrame op that both indicated
where the FP was set, and gave the size of the clobbers;
We don't know the size of the clobbers until we generate the
clobber-save sequence; and
The clobber-save sequence is generated after any explicit stack check.

To resolve the problem, this PR splits the DefineNewFrame op into two
pieces: SetFrameReg and DefineNewFrame. On x86-64 and aarch64 this
is emitted in the appropriate place. (s390x does not use a frame
register, so has no need for this op.) This should resolve the issue we
were seeing with Windows-2022 and unwinding.
(Thanks to @alexcrichton, @iximeow and @peterhuene for help debugging
this!)
I've switched the main Windows CI jobs back to Windows-2022 (naming this explicitly rather than windows-latest to pin our CI on a known version -- happy to switch that to -latest though if we think that's better). I've also added a job that explicitly tests Windows-2019 to ensure we don't have any other regressions. If the overhead for this is too high then maybe we can remove it after seeing a clean pass at least on this fix.
Fixes #3859.

Hmm, that didn't work on Windows-2022; a generic "stack overrun" crash. This will have to go to my back burner for a bit until I have a workable Windows machine to debug on; in the meantime if anyone else wants to poke at this, please feel free!

Unwinding from within the prologue is permitted on windows.
It is why the unwind codes are expected to be sorted in descending order from prologue offset: the unwinder simply walks the codes, skipping over any where the prologue offset is greater than the function offset of the exception address.
So if we were originally emitting the frame pointer adjustment unwind code with a prologue offset equal to the size of the prologue, then any exception from within the prologue would have skipped undoing that operation.

Hm ok so the unwinding logs I have from this PR look like:
...
2022-05-09T17:24:20.1618041Z ip=0x7ffc7462b592 sp=0xb9a2d7b1e0
2022-05-09T17:24:20.1618120Z ip=0x7ffc745e2022 sp=0xb9a2d7b280
2022-05-09T17:24:20.1618188Z ip=0x7ffc74652e1e sp=0xb9a2d7b4c0
2022-05-09T17:24:20.1618271Z ip=0x24c8b5b1013 sp=0xb9a2d7c2a0
2022-05-09T17:24:20.1618403Z ip=0xb9a2d7c2b0 sp=0xb9a2d7c2a8
2022-05-09T17:24:20.1618484Z ip=0x24c8b5b101d sp=0xb9a2d7c2b0
2022-05-09T17:24:20.1618561Z ip=0xb9a2d7c2c0 sp=0xb9a2d7c2b8
2022-05-09T17:24:20.1618639Z ip=0x24c8b5b101d sp=0xb9a2d7c2c0
2022-05-09T17:24:20.1618707Z ip=0xb9a2d7c2d0 sp=0xb9a2d7c2c8
2022-05-09T17:24:20.1618783Z ip=0x24c8b5b101d sp=0xb9a2d7c2d0
...

where I believe the first wasm pc is ip=0x24c8b5b1013 sp=0xb9a2d7c2a0. Since text sections are page-aligned I think this corresponds with the address at 0x13 above which is in:
  0xd:  jbe ; ud2 stk_ovf ;

which is indeed the ud2 at 0x13.
The "second wasm frame", however is bogus ip=0xb9a2d7c2b0 sp=0xb9a2d7c2a8. The problem here is that the ip is actually a stack pointer and the sp is not 16-byte aligned.
This looks like the unwinder did not actually unwind the pushq   %rbp instruction which is in our prologue. The unwinder then popped the return address of the call, which got the previous value of %rbp and misinterpreted it as an instruction pointer. Then everything goes awry b/c presumably everything is busted at that point.
I'm not sure why the PushRegister instruction isn't being unwound...

Thanks @alexcrichton for digging into this more!
For my own potential debugging later: are you able to test this locally on a desktop Windows install (and which version if so)? I do have a Win10 VM I can dig up, which I suspect corresponds to windows-2019 (or earlier); I wonder if I would have to upgrade to Win11 to see this behavior...

Nah I'm just throwing things at CI and reading output from github actions, basically vicariously printf-debugging through github heh

(Pushed rebase onto current main)
I'm at a bit of a loss here: I re-read all of the documentation on fastcall prologues and unwind info, and nothing seems amiss.
I will list all of the assumptions that we're making to see if any might be wrong:

Unwind entries are emitted in reverse order (highest offset first);
Unwind entries are associated with the offset of the following instruction (e.g. above, the push rbp is at offset 0 and is a 1-byte instruction, so is emitted with prologue offset 1);
The unwinder, if unwinding from a function offset in the middle of the prologue, will revert the effects of unwind ops at that offset or prior;
To revert a UWOP_PUSH_NONVOL (opcode 0), the unwinder reads old rbp from *rsp and increments rsp by 8;
We are allowed to have other instructions in the prologue (within the first "prologue size" bytes of the functino body), such as the stack check.

Any others? Does all of this sound reasonable? The most dubious is IMHO the last. However (i) if the unwinder claims to work by only reading the array of unwind ops, this shouldn't be a problem; and (ii) we need to make it so, because if there were clobber-saves, they would come after the stack limit check, and these are part of the prologue.
I suppose a high-level alternative design branch would be to do the stack limit check outside of the prologue. However this requires a bunch of re-engineering, and divergence from the current shared ABI code:

It implies two checks: "enough stack limit to save clobbers" before every call (this becomes the responsibility of the caller) and then the usual one, just after the prologue;
When the host calls Wasm, it implies a stack limit check analogous to the above (as part of the trampoline maybe?);
It implies that we decrement rsp twice, once to create space for clobber-saves and once to allocate the rest of the fixed frame (currently we collapse all this overhead into one sub instruction).

So that doesn't seem terribly tenable to me either.
It's really unfortunate that I don't have a way of reproducing this locally, and that the unwinder is so opaque. I'm not sure what to do currently and have no remaining strategies for solving this bug other than "ask Microsoft what changed in the Windows-2022 unwinder"; does anyone else have better ideas?

I did a "final" poking around at this last night as I was inspired again. I double-checked everything down to the binary encoding and API alls we're calling into Windows. Everything checked out and made sense except for the fact that this doesn't work. It definitely feels odd that the exact same code works on 2019 and doesn't work on 2022. At this point I think we'd need to enlist a Windows expert to figure this out.

I'm cleaning up old PRs and closing this now: since we no longer rely on unwind metadata for stack walking on Windows (now that #4431 is merged), this is no longer an issue.

Isn't this still necessary for debuggers?

Yes, I suppose it would still be an issue for debuggers on Windows versions with the bug. However we weren't able to find the issue after extensive debugging (see whole thread above!) and this doesn't seem to solve the problem, so for that case I would say I'm closing the PR simply because it doesn't work...
At this point to get Windows' native unwinder to fully work in windows-2022 I think we need someone who is a deep expert in SEH and/or is willing to single-instruction-step through Windows internals. That's definitely not me!


[cuda] Get rid of cub prefix-scan

From https://github.com/cms-patatrack/cmssw/pull/447 and https://github.com/cms-patatrack/cmssw/pull/449.

Could you copy the changes under cudadev and leave cuda untouched? I'd prefer to keep the latter frozen (for now at least).

https://github.com/cms-patatrack/cmssw/pull/447/

Forgot to mention, it's https://github.com/cms-patatrack/cmssw/pull/447 only. I didn't completely remove cub dependency but only replaced cub prefix-scan.

Ah, ok, thanks (I corrected the description, should have looked more carefully).

Could you copy the changes under cudadev and leave cuda untouched? I'd prefer to keep the latter frozen (for now at least).

Sure, I can do that.


Fix: Only a freestanding expression macro can produce a result of type '()' in Xcode 15 Beta 7

Uses "Remove the result type if the macro does not produce a value" fix-it

thank you @djtech42 !


Operations: Creating Brittle Infrastructure

https://martinfowler.com/articles/is-quality-worth-cost.html

https://www.zdnet.com/article/python-programming-language-creator-retires-saying-its-been-an-amazing-ride/
Dropbox said van Rossum has had a major impact on its engineering culture.
"There was a small number of really smart, really young coders who produced a lot of very clever code that only they could understand," said van Rossum. "That is probably the right attitude to have when you're a really small startup."
However, as Dropbox notes, when the company grew, new engineers could not understand the clever but 'short and cryptic' code written by and for earlier developers.
Van Rossum called this "cowboy coding culture" and educated the company about the value of maintainable code.
"When asked, I would give people my opinion that maintainable code is more important than clever code," he said.
"If I encountered clever code that was particularly cryptic, and I had to do some maintenance on it, I would probably rewrite it. So I led by example, and also by talking to other people."

Why Maintainable Code is More Important Than Clever Code
In software development, a common temptation is to write code showcasing our technical prowess. Crafting clever, intricate solutions can be intellectually satisfying and often feels like an accomplishment. However, maintainable code is far more valuable in the long run than clever code.
The Case for Maintainable Code
**1. Readability:
Maintainable code is easy to read and understand. This means that other developers (or even you after some time has passed) can quickly grasp what the code does and how it works. When code is readable, it becomes easier to troubleshoot, debug, and enhance.
**2. Consistency:
Consistent coding practices lead to a more predictable and navigable codebase. This consistency is crucial for team-based projects, where multiple developers must collaborate seamlessly. Consistency in naming conventions, structure, and style helps maintain the flow and reduces friction.
**3. Scalability:
Maintainable code is inherently more scalable. As projects grow in complexity and size, straightforward and well-organized code can be scaled and extended with minimal risk of introducing bugs or performance issues. Clever code, on the other hand, often requires significant reworking to accommodate new features or changes.
**4. Collaboration:
When code is maintainable, collaboration becomes more efficient. Developers can contribute to the project without spending excessive time deciphering complex, convoluted solutions. This leads to faster development cycles and more robust code quality, as more eyes can review and improve the work.
**5. Technical Debt:
Clever code can often lead to technical debt. This happens when code is written to prioritize short-term gains over long-term maintainability. The result is a codebase that becomes increasingly difficult to work with over time, requiring extensive refactoring and costly rewrites.
Embracing Maintainable Code
To prioritize maintainable code, consider adopting the following practices:
**1. Simplify:
Strive for simplicity in your code. If a solution can be implemented straightforwardly, choose that approach over a more complex one. Remember, the simplest solution is often the best.
**2. Comment Wisely:
Use comments to explain the why behind your code, not the what. Well-placed comments can provide context and rationale, helping future developers understand the decisions made.
**3. Follow Standards:
Adopt and adhere to coding standards and guidelines. These standards ensure uniformity and predictability across the codebase, making it easier for any developer to contribute.
**4. Refactor Regularly:
Regularly refactor your code to improve readability and maintainability. Refactoring should be an ongoing process, not just something done when the codebase is in trouble.
**5. Review and Collaborate:
Conduct code reviews and encourage collaboration. Peer reviews can catch potential issues early and provide different perspectives on improving the code’s maintainability.
Conclusion
While clever code can be a testament to your skills as a developer, maintainable code is a testament to your professionalism and foresight. It ensures your projects remain robust, scalable, and collaborative, leading to more successful and sustainable software solutions. Prioritize maintainability over cleverness, and your future self—and your team—will thank you.
What do you think about the balance between clever and maintainable code? Share your experiences and insights in the comments below!
#SoftwareDevelopment #Coding #Programming #TechLeadership #CleanCode #MaintainableCode


Update Suricata rules

Suricata needs to be kept abreast of the latest threats. Typically these are kept up-to-date by running the suricata-update tool that comes with Suricata. When we have a bundled Suricata artifact with Brim, we'll surely want a way for this update to run periodically, hopefully with little/no effort on the user's part.
One possibility that comes to mind is to just run the update once whenever the app is launched, though if users use Brim so much that they keep it always open on the desktop, perhaps this would not be enough. Maybe some cron-like scheduler could do the update on a regular schedule. Some button/control in the app to trigger an immediate update might be yet another option. We might also want to think about a place in the app where we could provide minimally-disruptive informative messages saying the update has run.

Some notes from looking at suricata-update.

The suricata distribution has some basic rules included (https://github.com/OISF/suricata/blob/master-5.0.x/rules/http-events.rules). When suricata-update is run, these rules are added to the remote rules fetched by suricata-update.

suricata-update freshness / change detection: if the last download time is more than 15 minutes ago, it then compares the https://rules.emergingthreats.net/open/suricata-5.0/emerging.rules.tar.gz.md5 with the md5 of the previously downloaded rules.

Also, we've talked about BYO Suricata as the escape hatch for users who want other rules than the default etopen. A simpler route might just be for those users to manually run suricata-update pointed at whichever sources they typically use.


Python tests

Several tests implemented and a few changed to fix issues found by tests.

Just double check if the final commit ( the one about  	"Add _limit definition to init") makes sense


is there a native function similar to pm.sendRequest?

Looking to recreate a postman test where a sendRequest to delete endpoint is invoked as part of the test script, is it possible in bruno natively?

Bump - I'm looking for this as well. Is this on a roadmap?

is there any alternative way to accomplish the same thing?

This is on our roadmap to be worked and delivered in Dec 2024


NSFS | NC | CLI | Change the fs_context

Explain the changes

Change the native_fs_utils.get_process_fs_context argument according to the path that we use:

config_root_backend for access that is related to the configuration.
fs_backend for access that is related to the FS (for example path in a bucket, new_buckets_path in an account).
no argument for other cases (from_file path).

Fix the arguemnt of fs_context in native_fs_utils.get_fs_context to the fs_backend instead of config_root_backend before using the is_dir_rw_accessible.
Rename the argument from config_root_backend to fs_backend in function get_fs_context.

Issues: Fixed #7875

Currently, our code is not consistent with using the native_fs_utils.get_process_fs_context argument.
Fix the fs_context for is_dir_rw_accessible for new_buckets_path.
GAP - it was only changed in the file manage_nsfs (we might have it in health script).

Testing Instructions:

none

[ ] Doc added/updated
[ ] Tests added

@romayalon After your approval, I added this change (from PR description):

Rename the argument from config_root_backend to fs_backend in function get_fs_context.

We mentioned this yesterday.


Just reels?

Thanks man it helped a lot but I have a question. Can it only download reels?

yes just reels

yes just reels

Oh thanks again great job 😄


Fix read chunks

Hi,
This PR aims to fix #290.
I dug in the code to identify the cause of the problem and here is what I understood.

WSGI is a Python Web Server Gateway Interface defined here: https://peps.python.org/pep-0333/
When sending chunks the http specification defines how to encode content: https://datatracker.ietf.org/doc/html/rfc2616.html
The web server implementing WSGI is responsible for handling and decoding HTTP packets to comply with wsgi.

The issue I identified in the code is that wsgidav add an extra layer of packet decoding above the wsgi layer used to run the server (cheroot, ...). wsgidav should not try to decode chunks as they are already decoded and normalised by the wsgi server.
I just changed the decoding for stream_data_chunked but we might also want to refactor stream_data.
@mar10 Let me know if you have any questions.

Hi, thanks for your contribution and sorry for the slow response.
Did you test you changes with different WebDAV clients?

Hi, thanks for your contribution and sorry for the slow response. Did you test you changes with different WebDAV clients?

Hi, no problem. No, I only tested it with python requests library.
PS: By the way I believe that the issue #282 is linked with this one.

Hi,
I tested the code with winscp and it worked.
I also simplified further the code.

Hi,
Any update on this ?

The previous code addressed existing problems and was configurable with hotfixes.accept_put_without_content_length.
For example #10 and #282.
Before we can merge, we need to make sure that the change does not introduce a regression.
Als we need to test at least with these clients:

[ ] Windows 10/11 File Explorer
[ ] Windows 10/11 Folder mapping
[ ] macOS Finder
[ ] MS Office (e.g. Word)

If we decide to merge, we also need to remove the hot fix flag and add hotfixes.accept_put_without_content_length to _check_config() as deprecated field.

Ok thanks, so I tested it with a windows environment but I am not able to test it with macOS Finder.

[x]  Windows 10/11 File Explorer
[x]  Windows 10/11 Folder mapping
[ ]  macOS Finder
[x]  MS Office (e.g. Word)

I also added the added field to the deprecated list.

Smoke test with Finder on macOS Ventura passed as well

Great ! Do you already have plans to release a new version ?


Update README.rst with azure pipeline badge

NOTE: .rst doesn't like URLs

/AzurePipelines help

/AzurePipelines run


proposal(dockerfile/parse): vendor moby/buildkit instead of docker/docker

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind feature
Description
I was trying to vendor github.com/containers/libpod in my project with go mod vendor, but it keeps failing on finding github.com/docker/docker/builder/dockerfile/parser, which has been removed from github.com/docker/docker since moby/moby c9ebd2f13b3aab49c2d90cc38dcf2cd0d059697f.
Though I can pin docker/docker to v17.03.2-ce as a work around, but github.com/Sirupsen/logrus will cause
case-insensitive import collision: "github.com/Sirupsen/logrus" and "github.com/sirupsen/logrus"

And I have tried replace github.com/Sirupsen/logrus v1.4.0 => github.com/sirupsen/logrus v1.4.0 but with no luck :/
So, is it possible to change the current github.com/docker/docker/builder/dockerfile/parser dependency to github.com/moby/buildkit/frontend/dockerfile/parser which could fix this problem once for all?
Steps to reproduce the issue:

create a go project using go mod init

import and use github.com/containers/libpod/libpod

vendor dependencies using go mod vendor

Describe the results you received:
fail to vendor github.com/containers/libpod/libpod at finding github.com/docker/docker/builder/dockerfile/parser
Describe the results you expected:
vendor github.com/containers/libpod/libpod without any error

I just skimmed the issue:
github.com/docker/docker/builder/dockerfile/parser will be dropped when we vendor the latest buildah (Cc @TomSweeneyRedHat).
Regarding the usage of go mod:
We starting working on making the dependencies go mod-friendly but I guess this will take some more time until we have ironed out the rough edges.

Thank you @vrothberg for the quick and informative reply,
Wow, really good news, happy to see buildah to be there. Anything I can help?

Best to help out by testing and reviewing patches.

Well, I have found a workaround to this issue with replace
replace github.com/docker/docker/builder/dockerfile/parser v1.13.1 => github.com/moby/buildkit v0.4.0

Best to help out by testing and reviewing patches.

@rhatdan , I will try, but honestly I have never reviewed any code from others.

@jeffreystoke No problem even reviewing docs or just trying out the code helps.

@vrothberg Is this still an issue?

@rhatdan, this should be fixed now. Imagebuildah effectively forked the package of a later version, and everything has been properly propagated through the projects. Thanks for catching up on this!


added include_process_args config option

What does this pull request do?
Introduce a config option to disable capturing of process args, and disable it by default.
Related issues
Closes #1860

I'm going to do the CHANGELOG as part of the release PR.


Wireframe/mockup of site

Wireframe or mockup of the site
Annotations/notes on handlebars structure (partials?)

Profile page
Login/signup page
Homepage

Wireframes + notes/annotations about Handlebars structure


Tidy helper to avoid need for nosec comment

Currently we fmt.Sprintf a command string only to immediately split it
back in to args, which causes gosec to complain about unsanitised inputs
to exec.Command. Refactoring this to directly pass an args array is
clearer, more secure, and avoids needing the nosec comment.

test in eventing looks good: https://github.com/knative/eventing/pull/5994


AzureADHybridAuthenticationManagement module - lack of support?

The AzureADHybridAuthenticationManagement module hasn't been updated in two years and appears to lack proper support. Issues with the module is preventing me from using these instructions and reporting the issues gets no response. Any plans to change to a more supported module?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 50b27a01-622e-d980-83f2-1ed27060613b
Version Independent ID: e6472e15-10d7-bd4a-da02-558f2774dbaf
Content: Passwordless security key sign-in to on-premises resources - Microsoft Entra ID
Content Source: docs/identity/authentication/howto-authentication-passwordless-security-key-on-premises.md
Service: entra-id
Sub-service: authentication
GitHub Login: @Justinha
Microsoft Alias: justinha

@mwilsonthbc
Thanks for your feedback! We will investigate and update as appropriate.

@mwilsonthbc thanks for raising this. The engineering team has a work item to track the need to replace this option. There's dependencies to be worked out, and we don't have an ETA at this time.
if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


Signing myself in

Fixes or introduces:
Proposed Changes

@evandrix - Please resubmit without whitespace changes. Thank you!


Correct bugs in Community Team page

Fixes

Fixes #237 by @akmadian
Description

Originally the issue corresponded to an improper indentation in a section of the page. But, a few more bugs related to styling were identified by me and I have brought them to notice in the original issue itself. This PR removes all the mentioned bugs as shown in the Screenshots section below.
Screenshots

1. Corrected Indentation

2. Made the intended words bold

3. Corrected numbering in outer nested list in both the places

4. Changed nested unordered list inner styling to make it consistent with rest of the page

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the master branch of the repository.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Looks good, thanks @SaurabhAgarwala!


Too many rows for days on OverlayDateTimePicker

The OverlayDateTimePicker has one row too many. Because of this is shows a full week of the next month.
See Appshell Catalog App for example.

Closed by https://github.com/Iconica-Development/flutter_date_time_picker/pull/49


Column header don't move when do horizontal scroll on table body.

Column header don't move when do horizontal scroll on table body. I testing on 0.1.14 version.

Noticed your PR, does that cover this ?

I send the other PR for this.

Fixed in 0.2.0


RingAlarm fails to start, error on startup

I am getting the following error trying to add my Ring Doorbell:
[6/16/2019, 9:11:59 PM] [RingAlarm] Configuring 1 cameras and 0 devices for locationId c290hb-2s0fi-0
[6/16/2019, 9:11:59 PM] [RingAlarm] Adding new accessory lpd_v2 Front Door
[6/16/2019, 9:11:59 PM] [RingAlarm] Error connecting to API
[6/16/2019, 9:11:59 PM] [RingAlarm] Error: Cannot add a bridged Accessory with the same UUID as another bridged Accessory: f0c6f4aa-3193-4b9d-8a8f-4127cf8ceb8e
    at Bridge.Accessory.addBridgedAccessory (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/lib/Accessory.js:268:13)
    at Bridge.Accessory.addBridgedAccessories (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/lib/Accessory.js:299:10)
    at Server._handleRegisterPlatformAccessories (/usr/local/lib/node_modules/homebridge/lib/server.js:490:16)
    at Server.<anonymous> (/usr/local/lib/node_modules/homebridge/lib/server.js:41:10)
    at API.emit (events.js:198:13)
    at API.registerPlatformAccessories (/usr/local/lib/node_modules/homebridge/lib/api.js:171:8)
    at createHomebridgeAccessory (/homebridge/node_modules/homebridge-ring-alarm/homebridge/ring-alarm-platform.js:98:29)
    at allDevices.forEach.device (/homebridge/node_modules/homebridge-ring-alarm/homebridge/ring-alarm-platform.js:100:82)
    at Array.forEach (<anonymous>)
    at RingAlarmPlatform.<anonymous> (/homebridge/node_modules/homebridge-ring-alarm/homebridge/ring-alarm-platform.js:88:28)
    at Generator.next (<anonymous>)
    at fulfilled (/homebridge/node_modules/homebridge-ring-alarm/homebridge/ring-alarm-platform.js:4:58)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Here is my config:
        {
            "platform": "RingAlarm",
            "name": "RingAlarm",
            "email"<EMAIL_ADDRESS>            "password": "******",
            "beamDurationSeconds": 60,
            "hideLightGroups": true,
            "cameraStatusPollingSeconds": 30,
            "cameraDingsPollingSeconds": 5
        },

@markcarroll I haven't seen an error like this yet, but my guess is that you have/had one of the other ring camera homebridge plugins installed.  Can you confirm whether or not this is the case?  If so, you will need to remove the other ring plugin from your config and restart homebridge.  If the error continues, your next step will be to delete the ~/.homebridge/accessories directory.  I try to avoid deleting that directory as it can mess up any automations you have set up with homebridge devices, so let me know if it works without deleting that.

That was the problem. I deleted the accessories file (after checking to see what I would lose) and restarted. It fired up successfully.  I still do not see the camera in HomeKit but that is another issue. Thanks for the help.


[Masthead/Footer] Accessibility - The WAI-ARIA attribute 'aria-selected' is not valid for the element  with WAI-ARIA role 'menuitem'

IBM Equal Access Accessibility Checker
The WAI-ARIA attribute 'aria-selected' is not valid for the element  with WAI-ARIA role 'menuitem'
Element that is showing this error :-
<a aria-selected="false" aria-expanded="false" class="bx--header__menu-item bx--header__menu-title" aria-haspopup="menu" href="javascript:void 0" tabindex="0" part="trigger" role="menuitem">

@Praveen-sr Could you work with Ram to find out whether this bug found by the IBM Equal Access Accessibility checker is valid?  If it is. could you provide us with the priority.  Thanks.

Expected fix: Remove aria-selected attribute from the menu item.

🔖 aria-selected logic
🔖 aria-selected-based styles
@annawen1 (cc: @huntermacd)
Currently, the dds-megamenu-top-nav-menu's trigger element is targeted in the styles based on aria-selected=true to apply the blue underline in the masthead. How do you recommend maintaining the styling here?

I believe we initially added the aria-selected attribute because we needed to indicate to screenreaders that the menu item had selected styling. So I would hesitate to remove it without checking with our accessibility QA team. I will bring this up to them.

Ah I just noticed the above comment from Praveen

Expected fix: Remove aria-selected attribute from the menu item.

In that case @andy-blum can we instead use selected attribute instead of aria-selected? We can then change the style to use the selected attribute.


Incremental Typescript Compilation

With Typescript 3.4, an --incremental flag landed. This greatly speeds up builds. It would be great to be able to take advantage of this improvement. Hopefully, this can be an improvement on #6406, I know everyone is looking forward to TypeScript v3 😛
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-4.html
https://devblogs.microsoft.com/typescript/announcing-typescript-3-4/
Here is their example of compile times with and without the flag:

Step
Compile Time

Compile without --incremental
47.54s

First compile with --incremental
52.77s

Subsequent compile with --incremental with API surface change
30.45s

Subsequent compile with --incremental without API surface change
11.49s

This is already supported in fork-ts-checker-webpack-plugin which is what we use to do type checking. This improvement is included in the 3.0 alpha that we have out now. Feel free to try it out to see if you notice any improvements!


Beta

add a function that could record and review past queries,
planning to continue with Delete and Edit, and improve the UI

I fixed some bugs and there is still one main issue remain, which is when the window opens, the window of Wox keep showing and cannot hide.
This is my first time to try to make a contribution and pull a request! Sorry for the fact that I am inexperienced. I'm happy to learn new things!

Hi Marco-Ray, thanks for your contribution! I like the idea in general and think that both the SQLite history and the related frontend is well written - the problem where the Wox input bar stays open until the workload is finished is known to me, but i did not find a solution to circumvent this, yet. The subprocess.Popen call with the CREATE_NO_WINDOW flag is a nice addition, however. I will try to continue with the check in the next couple of days. Thank you!

i stopped the intervalRunner after retrieving an item from the sqlite database (line 193, index.html) - currently i am unable to restart the intervalRunner or to refresh the page after a new API call is made.


NIFI-8680: Ensure that if commitAsync() is called and an Exception ca…

…ught that it is rethrown

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically main)?

[ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Reviewing...

+1 LGTM, ran on a live system and executed the integration tests. The build failed because of an issue now fixed with #5142. Thanks for the fix! Merging to main


Solve warning deprecated headers

Many annoying warnings appear during compilation about the deprecated header: #include < ext/hash_map > in WCSimDetectorConstruction.hh.
Compiling with gcc 4.4.7.
This header should be replaced for a cleaner compilation.
According to backward_warning.h, the replacement header should be: < unordered_map > but the namespace and all hash-related statements need to be updated accordingly as well. The latter can only be used with new C++11 though: -std=c++0x

Closed via #218


Fix repeat instruction

waveform address is correctly referenced
Load is obsolete. Use LoadRepeat instead

-- BRJ and DR

Fixed at BBN-Q/QGL@3a2cf7b60a88dc89abd5e691aaa494817417e7dc


Plugin to allow input of Event ID and Private Key. To be persistent for the whole race

Introduce UI element using RH plugins.
Input to capture event ID and private Key

Introduced UI element and save to DB in Main branch


Invalid returnOrderId in bitshares/market sell/buy type annotation

In annotation returnOrderId is string
:param string returnOrderId: If set to "head" or "irreversible" the call will wait for the tx to appear in
                                        the head/irreversible block and add the key "orderid" to the tx output

But it used only like a bool
        if returnOrderId:
            # Make blocking broadcasts
            prevblocking = self.blockchain.blocking
            self.blockchain.blocking = returnOrderId

        tx = self.blockchain.finalizeOp(order, account["name"], "active", **kwargs)

        if returnOrderId:
            tx["orderid"] = tx["operation_results"][0][1]
            self.blockchain.blocking = prevblocking

This is a rather hacky details.
Basically, the blocking variable is read in transactionsbuilder.TransactionBuilder.broadcast() and results in instanciating blockchain.Blockchain with the value of blocking as mode. That results in the blockchain.BLockchain.blocks() call to only look for blocks that are either "head" (most recent) or "irreversible".
I am open for suggestions to make those more clear and easier to maintain


Fix Issue #412

The Clock Activity can now be in fullscreen mode. Any issues, please let me know!

There is an issue when doing fullscreen/unfullscreen. See below:

I've fixed the issues in this new commit. Please let me know what you think!

https://i.imgur.com/07KU564.mp4
Issue appears to be fixed - sorry I did not test with a smaller screen size!

Good job. Thanks.


Logs

Mockups

Specifications

User clicks option Logs in User menu in general header bar
Logs page will open. The page contains a combobox with the names of the logs files generated by Reconess
If user selects an option from the combobox, then the content of the file will appear in the textarea with an scroll to read all its content
If user clicks Clear button, a confirmation popup will appear. If user confirms to clear the logs file, all the content of the log file will be deleted and the file will be empty

Logs is a Settings SubMenu not a MyAccount Submenu

Logs is a Settings SubMenu not a MyAccount Submenu


Fixed broken Link and Power PC to Power

Proposed changes

Fixed broken link in ee/ucp/index.md that wasn't redirecting to the correct site. Changed it to authorization/index.md from access-control/index.md (this file doesn't exist) to fix this issue.

Changed references of Power PC to Power in 2 files to reflect the actual architecture used.

Related issues
Refers to #6793 and #6786

Let's merge this since it fixes the broken links. From a branding perspective I'm not sure if we should be using "IBM Power" or "IBM Power Systems".


Trigger a CI Build (on development)

Same as #2182 but for the development branch

Closing; superseded by #2187


feature(pu): add Dockerfile and its usage instructions

add LightZero Dockerfile and its usage instructions

Docker test is normal！


160 csharp patch

What's New:

Added steps for publishing NuGet package to the GitHub Registry.
Enabled the workflow to tolerate failures when publishing to NuGet and GitHub Registry due to existing package versions, ensuring the overall workflow status remains successful.
Updated the README.md file for the nuget.org package. You can view how it looks now, here: https://int.nugettest.org/packages/Cloud.Unum.USearch .

:tada: This PR is included in version 2.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


filter out too small and too big repositories

Let's filter our the smallest repositories and the largest (by the number of files), maybe using this statistical approach: https://en.wikipedia.org/wiki/Percentile

@yegor256 assign me on this one, please

@h1alexbel go ahead, please


Why the coverage run command doesn't have option of skip/ignore failures?

I'm running coverage run -m unittest discover command in my Jenkinsfile, and currently it fails (as expected) but then the whole Jenkins pipeline fails, before it reaches the next command (which is coverage report).
The only WA is to put @unittest.skip in my test files, but why the coverage run command doesn't have any option to ignore failures like the coverage report has (-i for ignore errors)

No issue with coverage


question: What is JWT_SHARED_KEY in OAuth config

A clear and concise description of what you want to accomplish.

I don't understand how to set JWT_SHARED_KEY required by the GitHub example Caddyfile. So I just set a random 32-characters string.
And now the authentication process doesn't work. The Caddy log is as following.
Jun 10 07:08:28 caddy[131112]: {"level":"error","ts":1686380908.4094677,"logger":"http.handlers.authentication","msg":"auth provider returned error","provider":"authorizer","error":"user authorization failed: src_ip=[redacted], src_conn_ip=[redacted], reason: no token found"}
Jun 10 07:08:29 caddy[131112]: {"level":"warn","ts":1686380909.2971272,"logger":"security","msg":"Authentication failed","session_id":"[redacted]","request_id":"[redacted]","error":"failed OAuth 2.0 authorization flow, error: redirect_uri_mismatch, description: The redirect_uri MUST match the registered callback URL for this application."}

What do no token found and redirect_uri_mismatch mean?
Could anyone help me solve the problem? Thanks.

Might related to https://github.com/greenpau/caddy-security/issues/134

Never mind. It turns out to be the same problem as #41


Handle uploading debug builds to Play Store

This is not allowed, so gracefully handle the error.

Duplicate of https://github.com/tramlinehq/tramline/issues/263, closing.


Question: Does Clair support Mysql database?

In our scenario, other services use Mysql as backend database. Does
Clair support Mysql? If so, there is no need to deploy another database
for us.

Hi,
MySQL hasn't been tested explicitly on Cayley (and thus on Clair).
The new database implementation on which  I am working on uses PostgreSQL and will provide a huge performance boost and many features as well as caveats fixes compared to the current implementation.

Le 12 janv. 2016 à 06:22, Lei Jitang<EMAIL_ADDRESS>a écrit :
In our scenario, other services use Mysql as backend database Does
Clair support Mysql? If so, there is no need to deploy another database
for us
—
Reply to this email directly or view it on GitHub.

Rather than does clair support MySQL, allow me to answer the question will clair eventually support MySQL. There is going to be a new database implementation that uses database/sql and postgres that will be far more performant. Once that is in place, we will be open to accepting PRs that add MySQL support, but it is not a priority for us to work on. However, this will likely be nontrivial because the postgres implementation takes advantage of a couple of features that does not exist in MySQL in order to get decent performance.

@jzelinskie

There is going to be a new database implementation that uses database/sql and postgres that will be far more performant

when does this in place?

@coolljt0725 We are really far in the development already. We are currently writing the new API and starting to run benchmarks on the official Docker images. I'd say that the ETA is few weeks.

@Quentin-M  Thank you :)


./configure is wrong? in mingW64

when i run the ./congfigure , it is shown
configure: loading site script /etc/config.site
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.exe
checking for suffix of executables... .exe
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether the compiler supports GNU C... yes
checking whether gcc accepts -g... yes
checking for gcc option to enable C11 features... none needed
checking for a sed that does not truncate output... /usr/bin/sed
checking for grep that handles long lines and -e... /usr/bin/grep
checking for a BSD-compatible install... /usr/bin/install -c
checking for ranlib... ranlib
checking for error_at_line... no
checking build system type... x86_64-w64-mingw32
checking host system type... x86_64-w64-mingw32
checking for GNU libc compatible malloc... yes
checking for GNU libc compatible realloc... yes
checking for main in -lc... no
configure: error: Could not use standard C library
i have upload the config.log
But i have successfully generated fftw3 in the same setting.
config.log

the same problem


[...new Map<K, V>().entries()] is unsoundly typed Array<(any | [K, V])>

Flow version: 0.102.0
Context
type K = string;
type V = string;

// The inferred type of `entries` here is `Array<(any | [K, V])>`,
// but I expect it be simply `Array<[K, V]>`

const entries = [...new Map<K, V>().entries()];
entries.filter(() => Math.random() > 0.5).reduce(x => x);

// If you remove the `filter(...)` you get the expected type.
// If you change `filter(...)` to `filter(Boolean)`, you get the expected type.
// If you remove the `reduce(...)` you get the expected type.
// But if you have both the `filter` and `reduce`, `any` is inferred 🤯

Try Flow
Expected behavior
I expect the inferred type of the entries array to be Array<[K, V]>.
Actual behavior
Instead, the inferred type of entries is Array<(any | [K, V])>.

This is now inferred with the correct type without any.


How do you play your game?
Use WASD to move. You control the blue snake, while the orange snake mirrors your movements. Have your snake or the mirrored snake eat apples to increase your length. Don't run into walls, or the other snake.

Code
Check off the items that are true.

[x] The game was made using the Sprig editor.
[x] The game is placed in the in the /games directory.
[x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x] The game runs without errors.
[x] The name of the file/game contains only alphanumeric characters, -s, or _s.
[x] The game name is not the same as the others from gallery

Image (If an image is used)

[x] The image is in the /games/img directory.
[x] The name of the image matches the name of your file.

Thanks for your PR!

great game! did you use any game for inspiration?

thanks! my main inspiration was the google snake game, where there is a very similar gamemode to the one i made.

Thank you! I heard about sprig through hackclub's website. i filled out the form, so when can i expect the sprig to arrive?

it depends on the country where you live, where are you from?

i live in the US

Probably in 15 days it will be with you!

ok, thank you!


AWS admin has access to all secrets?

Hello, am I right that AWS admin has access to all secrets?
According to https://github.com/Boostport/kubernetes-vault/blob/master/deployments/quick-start/README.md, te root token or admin token is written in yaml
deployment files
env:
- name: VAULT_DEV_ROOT_TOKEN_ID
value: vault-root-token
in vault.yaml file
So AWS admin could read this config from running service and use the token to read all secrets from vault?
Even if value will be in kubernetes secret AWS admin still will be able to access this token.

That environment variable to to set a fixed well known root token for Vault in development mode. In production, you will need to have vault generate its own root token. You do need to generate a token for the kubernetes-vault controller, but you can scope it to just the permissions it requires from vault using vault's policies.

I’m sorry, I don’t understand what you mean in phrase “to have vault generate its own token”.
From docs (https://www.vaultproject.io/docs/concepts/tokens.html) “The initial root token generated at vault operator init time -- this token has no expiration”. So vault generate this token and then administrator configure vault controller with it, for example:

name: VAULT_DEV_ROOT_TOKEN_ID
value: 2b9b85ca-d25f-4958-bff9-a2c0cd618996
Then any AWS administrator can read this config and login to Vault, executing command: vault login 2b9b85ca-d25f-4958-bff9-a2c0cd618996. And read all data.
I could use limited admin token (https://www.vaultproject.io/guides/identity/policies.html) that by itself do no have policy to read all secrets. But this token should have policy to issue other tokens that could read any secrets. So it just extra step to manually issue one more token with necessary rights and read everything. If this admin token will not have rights to issue such token then how vault-controller will provide necessary token to init container? Who generate tokens for app/services?
Could you point any info what this limited permissions should looks like?

The token for kubernetes-vault can be limited using a Vault policy. Unfortunately, due to the design of AppRole auth, if you have access to all the pieces, you can get a token. I don't think it would be possible to design a system without any trust in this scenario. You'd have to trust your administrators as well as the pods you are running in the cluster. If this is not acceptable, you can consider Kubernetes Auth: https://www.vaultproject.io/docs/auth/kubernetes.html
Kubernetes Auth does have its own downside as well, but it would be impossible to have a system where the components and operators have 0 trust in each other.

Thank you very much for explanations.


phoenix 1.4.4 router.ex pow_routes() cause ** (FunctionClauseError) no function clause matching in :elixir_aliases.do_concat/2

Just wanted to try pow. I created the new project phx_pow and followed getting started guides.
I found the problem:
When I added pow_routes() in router.ex I got the next error:
== Compilation error in file lib/phx_pow_web/router.ex ==
** (FunctionClauseError) no function clause matching in :elixir_aliases.do_concat/2

    The following arguments were given to :elixir_aliases.do_concat/2:

        # 1
        [[]]

        # 2
        "Elixir"

    lib/pow/phoenix/router.ex:100: Pow.Phoenix.Router.validate_scope!/1
    lib/phx_pow_web/router.ex:24: (module)
    (stdlib) erl_eval.erl:680: :erl_eval.do_apply/6
    (elixir) lib/kernel/parallel_compiler.ex:208: anonymous fn/4 in Kernel.ParallelCompiler.spawn_workers/6

router.ex looks like:
defmodule PhxPowWeb.Router do
  use PhxPowWeb, :router
  use Pow.Phoenix.Router

  pipeline :browser do
    plug :accepts, ["html"]
    plug :fetch_session
    plug :fetch_flash
    plug :protect_from_forgery
    plug :put_secure_browser_headers
  end

  pipeline :api do
    plug :accepts, ["json"]
  end

  pipeline :protected do
    plug Pow.Plug.RequireAuthenticated,
      error_handler: Pow.Phoenix.PlugErrorHandler
  end

  scope "/", PhxPowWeb do
    pipe_through :browser
    pow_routes()

    get "/", PageController, :index
  end

  # Other scopes may use custom stacks.
  # scope "/api", PhxPowWeb do
  #   pipe_through :api
  # end
end

My mix deps:
defp deps do
    [
      {:phoenix, "~> 1.4.4"},
      {:phoenix_pubsub, "~> 1.1"},
      {:phoenix_ecto, "~> 4.0"},
      {:ecto_sql, "~> 3.0"},
      {:postgrex, ">= 0.0.0"},
      {:phoenix_html, "~> 2.11"},
      {:phoenix_live_reload, "~> 1.2", only: :dev},
      {:gettext, "~> 0.11"},
      {:jason, "~> 1.0"},
      {:plug_cowboy, "~> 2.0"},
      {:pow, "~> 1.0.6"}
    ]
  end

I get the same error after updating phoenix from 1.4.3 to 1.4.4.

Thanks! I'm working on a fix and will release 1.0.7 today to resolve this. Phoenix 1.4.4 has changed behavior with scopes.

Fix in master branch (so you can use {:pow, github: "danschultzer/pow" now). Release will be up in a few hours.

1.0.7 released with bug fix.

Thanks, @danschultzer!

Thanks a lot, @danschultzer!


Alias in recent projects list is not synced with root project name for IndexedDB file systems

I think this was intentional though. That's why it's called an 'alias' not 'project name'

Yes this is intentional, if you don't change the alias and change the name of the root folder, it is properly reflected in the project window.

It's not possible to remove an alias after setting it though, that is a bug.