az dms project task create - MongoDB DMS Migration (dms-preview)

If the issue is to do with Azure CLI 2.0 in-particular, create an issue here at Azure/azure-cli

Extension name (the extension in question)
dms-preview
Description of issue (in as much detail as possible)
When running the az dms project task create for dms-preview on a MongoDB Migration Project I'm getting the following error
dms project task create --database-options-json .\databaseOptions.json --project-name uws-nt-dmspr1-ldm-e9 -g uws-nt-rg-cdb-ldm --service-name uws-nt-dms1-ldm-e9 --source-connection-json .\sourceConnection.json --target-connection-json .\targetConnection.json --task-type offlinemigration --n Migration-Task-e8a225e0-519c-4233-888a-37f350af13d8 --validate-only
The behavior of this command has been altered by the following extension: dms-preview
UnexpectedError: The command failed with an unexpected error. Here is the traceback:
Unable to deserialize to object: type, KeyError: 'ValidateOracleAzureDbForPostgreSqlSyncTaskProperties'
Traceback (most recent call last):
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-482xwhov\msrest\serialization.py", line 1430, in _deserialize
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-482xwhov\msrest\serialization.py", line 1599, in deserialize_data
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-482xwhov\msrest\serialization.py", line 1392, in _deserialize
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-482xwhov\msrest\serialization.py", line 1472, in _classify_target
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-482xwhov\msrest\serialization.py", line 383, in _classify
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-482xwhov\msrest\serialization.py", line 357, in _flatten_subtype
KeyError: 'ValidateOracleAzureDbForPostgreSqlSyncTaskProperties'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-tuw8_17y\knack\cli.py", line 215, in invoke
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-v8nptj_b\azure\cli\core\commands_init_.py", line 654, in execute
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-v8nptj_b\azure\cli\core\commands_init_.py", line 718, in run_jobs_serially
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-v8nptj_b\azure\cli\core\commands_init.py", line 709, in run_job
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-s56abhv8\azure\cli\command_modules\dms\commands.py", line 22, in dms_api_exception_handler
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-v8nptj_b\azure\cli\core\commands_init.py", line 688, in run_job
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-v8nptj_b\azure\cli\core\commands_init.py", line 325, in call
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-v8nptj_b\azure\cli\core_init_.py", line 784, in default_command_handler
File "C:\a_temp.azclitask\cliextensions\dms-preview\azext_dms\custom.py", line 193, in create_task
properties=task_properties)
File "C:\a_temp.azclitask\cliextensions\dms-preview\azext_dms\vendored_sdks\datamigration\operations_tasks_operations.py", line 201, in create_or_update
deserialized = self._deserialize('ProjectTask', response)
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-482xwhov\msrest\serialization.py", line 1356, in call
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-482xwhov\msrest\serialization.py", line 1434, in _deserialize
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-482xwhov\msrest\exceptions.py", line 51, in raise_with_traceback
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-482xwhov\msrest\serialization.py", line 1430, in _deserialize
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-482xwhov\msrest\serialization.py", line 1599, in deserialize_data
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-482xwhov\msrest\serialization.py", line 1392, in _deserialize
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-482xwhov\msrest\serialization.py", line 1472, in _classify_target
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-482xwhov\msrest\serialization.py", line 383, in _classify
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-482xwhov\msrest\serialization.py", line 357, in _flatten_subtype
msrest.exceptions.DeserializationError: Unable to deserialize to object: type, KeyError: 'ValidateOracleAzureDbForPostgreSqlSyncTaskProperties'
To open an issue, please run: 'az feedback'

route to service team


Trace log from capturing timer function information message is null

When application insight is logging trace log for timer function message can not be formatted in ApplicationInsightsLogger.cs and as a result message for that trace log is null.

If you're running the application in Azure Functions, please file an issue here.


Request to release 1.0.0 on all ROS2 distros

Hello!
Thanks for such a great work. I'm writing here to know if it is possible to release the 1.0.0 on Humble, Jazzy and Rolling ROS 2 distros.
Thank you!

U should, shouldn't I?

U should, shouldn't I?

Sorry, I didn't get what you mean 😅😅
I could build them locally yes, it would be great if they are available as binaries. I'm thinking of a possible integration into the ROS2 control framework. So, the integration would be easier.
Thank you?

I am not sure if I am ready for the 1.0 version. But, at the same time, I have no time to devote to this library, for the time being

I am not sure if I am ready for the 1.0 version. But, at the same time, I have no time to devote to this library, for the time being

Gotcha. I saw the tag 1.0.0 and I thought it was already ready. Sorry for my misunderstanding. In that case, can 0.9.4 be released for Humble?

Let me see if I can first address #19

Sure. Thank you @facontidavide 🙏🏽🙏🏽

@facontidavide Can we create a new ROS release? It would be nice to first address #19 and #34, perhaps, but I think there have been some improvements since the last ROS release that are worth capturing before those are complete.


Removed Gdot character from Huggingface tokenizer

Fixed https://github.com/stanford-crfm/helm/issues/1516.
Changed all the tests and made sure they still pass.
I did not change the .convert_ids_to_tokens in HugginFaceCLient.serve_request() as it did not seem necessary and it was causing the gpt2 test in test_gpt2_window_service.py to fail.
I will have to rebase this if we push the Anthropic and Palmyra PR (or the other way around).

I created #1522 which is related.

I merged the Anthropic / Writer PRs, so you can rebase now.

I have rebased and reverted everything related to "▁". I will wait for the tests to finish before merging. I will address the underscore character in a next PR.


[Jandex plugin] processJandexIndex delete resources from build dir

I have have custom resources that get generated during the build process. The standard "processResources"-Task copies them to "build/resources/main". Then later when the "processJandexIndex" task runs, it flags these resources as stale and deletes them.
Also having a task (processJandexIndex) using the same output directory as another task (processResources) is probably not a good idea at all.

Unfortunately, there's no clear way of adding generated index into resources.
In Gradle, resource files are inputs to compilation tasks.
jar index takes compilation results and it creates the index.
If we add the index to resources, then it creates a circular loop.
See https://github.com/gradle/gradle/issues/12774#issuecomment-842408717
So the workaround is to add the file into build/resources/main directory.
Of course, it might invalidate processResources as it will find an unexpected file in build/resources/main.
On the other hand, it might be slightly better to avoid copying the index into build/resources/main, and add them only into .jaronly (e.g. configurejartask to include the index). The drawback will be that tests running withbuild/main/classesin classpath would fail to find the index viaClassLoader.getResource`.
WDYT?

I had a similar idea, modifiy the jar task to include the index, but that does bring the drawback you mentioned. Modifying the processResources task doesn't work because it runs too early.
So maybe it is possible to make the "classes" task depend on the jandex tasks, and then tell the "processResources" task that it must run after the jandex task. Would that mess anything up?

Would adding the "build/jandex/jandexMain" dir as a resource dir to the source set solve the testing issue?

If processJandexIndex removes other files from build/resources/..., then I should probably use a different class for processJandexIndex itself. E.g. make it a regular sync task that copies only a single index file. Then it shouldn't remove other files.
The drawback would be it might trigger re-execution of processResources, which, I guess, might be acceptable.

Would adding the "build/jandex/jandexMain" dir as a resource dir to the source set solve the testing issue?

The issue is that Gradle assumes all resource directories are inputs for compileJava tasks, so it would go wild when it starts compileJava and sees no files in build/jandex/jandexMain. On second execution, it will detect the previously built index, and it would trigger re-compilation.

Are you sure about that? I don't think compileJava does anything with the resources.

I have turned off the processJandexIndex task and modified the jar task. This works fine for my use case.

processResources is not by default a requirement for the compileClasses task see https://docs.gradle.org/current/userguide/java_plugin.html#sec:java_tasks
But there may actually be some folks who configured in in their builds to be this way, depends if you'd like to take the rist of a circular dependency for some projects or not.
I also have to contradict the statement that messing around with another tasks output may be acceptable. Newer gradle versions specifically enforce getting rid of such behavior up to the point the plugin won't work anymore. It also destroys the whole build avoidance gradle is so proud of.
Currently I think the best option is to customize the jar task to include the index file, also declaring a dependency on the index task.
If you need the index in your tests add the output folder of the main SourceSet to your test/resources (and a dependency for the processTestResources). Of course if you build a jar of your tests you'll have to make sure the index from the main is replaced with your test classes index...


how to train the model on CPU ??

Currently the code use GPU by default. Can we train it by using CPU??

I hope you have figured out by now. You can do it using gpu_ids = ''(an empty string). Sorry for not getting back earlier. I'll also try to provide a new version of this code soon.


add body to world wide organisation schema

This will allow us to render Worldwide orgs in a different app
https://trello.com/c/LrXHcFUM/382-add-body-to-worldwide-organisation-presenter
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
This application is owned by the publishing platform team. Let us know in #govuk-publishing-platform if you have any questions.
Follow these steps if you are doing a Rails upgrade.

I commented on the Whitehall PR for this with a question to help my understanding.  The same question applies to this PR too.

I commented on the Whitehall PR for this with a question to help my understanding. The same question applies to this PR too.

Have changed it so that it's converted to html before being sent. The publishing api PR will need merging before this so that the schema tests pass


HTTPS SSL Certificate for services.odata.org is bad

When attempting to connect to the services.odata.org site, using SSL, I get the following error:

This server could not prove that it is services.odata.org; its security certificate is from *.azurewebsites.net. This may be caused by a misconfiguration or an attacker intercepting your connection.

The SSL certificate for the services.odata.org appears to be the default certificate from Azure.  Azure automatically enables HTTPS, and then uses a default certificate from *.azurewebsites.net.
Azure offers instructions on how to fix this.  The details are documented here.

We have no intention to enable https of reference services as the site has no sensitive information and we do not enable authentication and authorization neither.
We will work on this issue, but based on the many higher priority items we have now, it will take some time, I will suggest you host the service by yourself and enable https with your certificate, the service source code are stored in https://github.com/OData/ODataSamples/tree/master/RESTier/TripPinInMemory
Let us know if you have any more comments or suggestions.

@chinadragon0515
If possible, please do fix the https issue because I cannot use your example V4 Northwind when the main-code is running on https. (Example see this demo-page.)

The o.js library will refuse connections to service.odata.org if the calling application is running over HTTPS (everything does nowadays regardless of sensitive information). You can update the example code to warn about this.

My concern, @chinadragon0515, is that I reported the issue as "HTTPS certificate is bad".  There is a certificate attached to this web server already.  I was asking if you can either make it valid, or remove it.
I even offered instructions on the problem.  Why can't your team just follow those instructions?


scaling option for preview

Is your feature request related to a problem? Please describe.
An option to change the scaling method in the preview window such as nearest neighbour
Describe the solution you'd like
possibly another button next to the scale percent that reveals a drop down menu of the different methods
Does other service/app have this feature?
no specifics I can think of

We already provide a plethora of scaling methods in the “resize” section :)

I think the request here is different. It means using nearest neighbour in the preview, regardless of the resize method.
Fwiw, I wanted this originally, but I think browsers struggled with it. Eg I filed https://bugs.chromium.org/p/chromium/issues/detail?id=843615 at the time.

Safari still fails some of those cases, but Chrome seems good now.

yeah I'm referring to what Jake here said

Added in #1132


meshwizard: upgrade version for some olsr-plugins

inside OLSR some plugins recently got newer version numbers (and of course improvements)
Signed-off-by: Ufo<EMAIL_ADDRESS>

corresponding commits on olsrd:
https://github.com/OLSR/olsrd/commit/c63b0e128db0590fcad1ecdb07c0ac65972e1e3b
https://github.com/OLSR/olsrd/commit/d8ffc6fc701eb5cb1471ae2bf830d9f12fb1d3d5
https://github.com/OLSR/olsrd/commit/74719579dfa5abca5c6402885b11725902043072

Hi, where can i found luci-app-meshwizard  in  openwrt/master  ?
thanks！


DB2: Allow schemas that have same name as keyword

A client defined a schema as CUBE and REF.
In schemacrawler, this comes back as "CUBE" or "REF", which our code isn't handling (note
SchemaCrawler.java:426 and SchemaRetriever:181)

Hi @shantstepanian
I would love to fix this. Can you explain a bit more about this?

If someone defines a physical schema in DB2 as a keyword like CUBE, then it fails as the SQLs that Obevo generates may fail, e.g.
SET SCHEMA CUBE
CUBE is treated as a db2 keyword, and so you get a syntax error
Instead, something like the following would work:
SET SCHEMA "CUBE"
We have some code that will get the physical schema (e.g. DbPlatform.getSchemaPrefix(...)) - may be best to figure out how to have one of these methods updated to include quotes if the schema is named as a keyword
FYI - this ticket could possibly be the most intricate/complex one to do compared to the other two you created (albeit, it could end up being less code ultimately). Potentially the others could be easiest to start (maybe the MySQL one, since you'll get an idea of how things work end-to-end)


Update UI design

Update income and meeting dates as tags at the side of each person
Update to put "TBC" if there is no meetings dates available
Update design of UI to be as similar as the initial design of our FinBook
Update to allow wrapText for long strings that could not be displayed properly

Current update of UI design, will continue to update Meeting schedule section when meeting class is ready

Codecov Report
Base: 72.74% // Head: 72.74% // No change to project coverage :thumbsup:

Coverage data is based on head (bb10c82) compared to base (c86d5da).
Patch coverage: 0.00% of modified lines in pull request are covered.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Consider an productive position/layout

Thanks for the great stuff! I was thinking of improving the design of position/layout of the non-visual editor. how about a "floating"/pinnable panel at bottom-left position? (which is also very close to the Object Inspector panel.)

I would prefer like it is now. No floating panel please, or only as an option.

It is not really a floating window, the idea is just a try to use whitespace and reduce distance between object inspector and components. Now I switch between Left and Bottom position but they both have some drawbacks.


update deno icon

updates the deno icon to the newly icon made for version 2

@falcao-g Thanks for the PR, can you please add a screenshot of the extension running with this update? I suspect a black icon on a dark theme will not be very visible. Thanks.

hey, of course, here is a image of how it looks, my theme is not that dark (more like purple lol), but it looks fine here

@Vinicius-Marques6 the new branding does not use the blue color anymore https://deno.com/blog/v2.0

I understand, but searching the internet I didn't find any occurrence of the logo having been blue at some point, the comparison would be with the logo that is currently used in the extension. The only thing I found was the PR from when the old logo was created (https://github.com/denoland/dotland/pull/1836).

@miguelsolorio In vscode is there a way to detect when the user has dark theme colors?. Here is an example of changing the deno.land page to dark mode.
Preview

just getting around to previewing this, and I think this is why we went with blue was because the theme is used for both dark and light. So this is what it looks like in a light theme:

We can update the color to use a neutral gray that works in both:

If others feel strongly about the blue, happy to introduce a new variant that folks can override in their settings.

the gray one looks good to me

LGTM 👍


Fix creating guarded models

Description
Fixes create calls that were missed in https://github.com/filamentphp/filament/pull/11329.

[x] Visual changes (if any) are shown using screenshots/recordings of before and after.

Code style

[x] composer cs command has been run.

Testing

[x] Changes have been tested.

Documentation

[x] Documentation is up-to-date.

https://github.com/filamentphp/filament/pull/11329#issuecomment-1937825860


Error: Failed to find Server Action "xyz". This request might be from an older or newer deployment

Error: Failed to find Server Action "xyz". This request might be from an older or newer deployment. Original error: Invariant: Couldn't find action module ID from module map..

Error shows once I enable the edge-csrf while using Server Action but if not it works fine as expected.

Which version are you using? I haven't seen any errors like this with Edge-CSRF and it sounds like an issue with the Server Action implementation itself. Here are two reference examples you can use for Server Actions and Edge-CSRF:
https://github.com/kubetail-org/edge-csrf/blob/main/examples/next14-approuter-server-action-form-submission
https://github.com/kubetail-org/edge-csrf/blob/main/examples/next14-approuter-server-action-non-form-submission

I use https://next-safe-action.dev/ for handling server actions. I also tried adding the csrf_token to the payload but seems still showing the same error. I think maybe this is from nextjs issue alone.

Can you share a code example that’s produces the error?

// create-profile-form.tsx
'use client';

const CreateProfileForm = ({ handleCloseModal }: Props) => {
  const form = useForm<CreateProfilePayload>({
    resolver: zodResolver(CreateProfileSchema)
  });
  const router = useRouter();

  const { execute, status } = useAction(createProfile, {
    onSuccess: (data) => {
      const profile = data.data;

      router.refresh();
      router.push(`${ROUTES.Profiles}/${profile?.id}`);
      handleCloseModal();
    }
  });

  const isExecuting = status === 'executing';

  const handleNewProfile = (payload: CreateProfilePayload) => execute(payload);

  return (
    <div className="mt-4">
      <FormProvider {...form}>
        <form onSubmit={form.handleSubmit(handleNewProfile)}>
          <FormInput
            name="name"
            label="Profile Name"
            placeholder="My Awesome Profile"
          />

          <FormButton
            type="submit"
            variant={'dark'}
            className="py-3 w-full mt-6"
            loading={isExecuting}
          >
            Create Profile
          </FormButton>
        </form>
      </FormProvider>
    </div>
  );
};

export default CreateProfileForm;

// actions.ts
'use server';

export const createProfile = authAction(
  CreateProfileSchema,
  async (payload, ctx) => {
    if (!payload) return { message: 'Invalid input', status: 400, code: null };

    const { error, status, data } = await supabase
      .from('profiles')
      .insert({ name: payload.name, user_id: ctx.userId })
      .select('*')
      .single();

    if (error) {
      return { message: error.message, status, code: error.code };
    }

    revalidatePath(ROUTES.Profiles);

    return { message: 'Added successfully!', status: 201, data };
  }
);

```ts

I remove the imports. Also I found this reddit https://www.reddit.com/r/nextjs/comments/177tjld/nextjs_middleware_w_server_actions/ MinimalMarzipan comment

I downgraded to 14.0.1 and error is gone but I got a new error.

⨯ Error [TypeError]: The first argument must be of type string or an instance of Buffer, ArrayBuffer, or Array or an Array-like Object. Received an instance of Object
at new NodeError (node:internal/errors:405:5)
at Function.from (node:buffer:324:9)
at atob (file://D:\app\node_modules.pnpm\next@14.0.1_@babel+core@7.23.9_react-dom@18.2.0_react@18.2.0\node_modules\next\dist\compiled\edge-runtime\index.js:1:657096)
at atou (webpack-internal:///(middleware)/./node_modules/.pnpm/edge-csrf@1.0.9_next@14.0.1/node_modules/edge-csrf/dist/esm/util.js:34:13)
at eval (webpack-internal:///(middleware)/./node_modules/.pnpm/edge-csrf@1.0.9_next@14.0.1/node_modules/edge-csrf/dist/esm/index.js:34:118)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async DevServer.runMiddleware (file://D:\app\node_modules.pnpm\next@14.0.1_@babel+core@7.23.9_react-dom@18.2.0_react@18.2.0\node_modules\next\dist\server\next-server.js:1029:24)
at async DevServer.runMiddleware (file://D:\app\node_modules.pnpm\next@14.0.1_@babel+core@7.23.9_react-dom@18.2.0_react@18.2.0\node_modules\next\dist\server\dev\next-dev-server.js:258:28)
at async NextNodeServer.handleCatchallMiddlewareRequest (file://D:\app\node_modules.pnpm\next@14.0.1_@babel+core@7.23.9_react-dom@18.2.0_react@18.2.0\node_modules\next\dist\server\next-server.js:321:26)
at async DevServer.handleRequestImpl (file://D:\app\node_modules.pnpm\next@14.0.1_@babel+core@7.23.9_react-dom@18.2.0_react@18.2.0\node_modules\next\dist\server\base-server.js:757:28) {
middleware: true
}
⨯ SyntaxError: Unexpected end of JSON input
at JSON.parse ()

Sorry, I can't tell from that code snippet what the problem is. Based on the traceback in your last message, it looks like you're using an object instance as the CSRF token you're passing to edge-csrf but your code snippet doesn't set the CSRF token so I can't be sure. Can you share a minimal example that demonstrates the bug? Ideally, if you can create a new repo with next + next-safe-action + edge-csrf that throws an error then I can debug it more easily.

It is working now with next-safe-action. I just created another function to add the csrfToken. This is how I did it.
export const createProfileAction = async (
  csrfToken: string,
  payload: CreateProfilePayload
) => {
  const { data } = await createProfile(payload);
  return data;
};

Great to hear you got it working! Let me know if you run into any more problems with the edge-csrf integration.


html.customData samples don't work as expected in VS Code 1.43.2

Our team has developed a bunch of custom tags which will be used as part of the HTML authoring. I started here https://code.visualstudio.com/docs/languages/html#_html-custom-data and ended up looking at samples at https://github.com/microsoft/vscode-custom-data
I am running VS Code 1.43.2 and unable to make these samples work as documented. I also see some limitations in the feature.
BUG: I tried the sample and I can only see the root element. After inserting <foo and space I don't see any attribute suggestions, although I can see the presence of the attribute if I scroll down in the suggestions list.
FEATURE REQUEST: I am unable to author child tags. the documentation only talks about root element and its attributes and global attributes. how do we author child tags? I tried to add another "tags" element as a sibling to "attributes" but it didn't do any good.
FEATURE REQUEST: How can I stop Intellisense showing HTML tags under custom tags? I ideally want to see only our custom tags.
BUG/FEATURE REQUEST: Whatever that is working is working only in workspace setting and not in global settings. As long as my settings.json is in .vscode directory it works. If I move the settings.json along with the html-data.json file to %appdata%\Code\User, it doesn't work at all. I also tried to restart VS Code with no luck. In fact I find more interesting and useful in user setting mode and not in workspace setting. Why would a user take pains to build a schema for himself/herself to insert those custom tags that others don't even know what they are and how to interpret? custom tags are more useful if a platform is written to parse them and an entire team or their customers can make use of it.
Is the validation built-in once I define my schema in the html-data.json? I am assuming yes but I couldn't validate because my basic scenario isn't working.
I love this overall feature and would love to make full use of this, provided I get some guidance on how to make this work.
Thanks,
Pranav

ref https://github.com/microsoft/vscode-custom-data/issues/8

We need separate issues in order to track the issues
Custom data has no support for element hierarchies. We currently have no plans to add that, we want to keep it simple. It will be up to users to know what elements can be inside what other elements.
I think there's currently no to disable the built-in html tags.
Custom data currently can only be defined in workspace settings, not in user settings. We have issue #79911 for that. The preferred way of consuming custom data is through extensions. So once you have a good version of your custom data, put it in an extension and publish it.

We currently have no plans to add element hierarchies to custom data. If you want to provide smarter suggestions, I suggest to do this through an extension that implements a completion provider. We have the vscode-html-languageserver node module to simplify the implementation (check out the ICompletionParticipant)


How to use?

I'm using your function in the same way I used them in pyhon but I keep getting error.
For your information, PcapPlusPlus made the rawpacket.
I hope you can help me

Hi Lars,
The notation is a little different than in Python. Try this:
rotation = Struct::unpack<uint16_t>(&packet);

In this case, packet must be a byte array with the two bytes of the uint16_t value. You might have to turn rwpkt into an array for this.
-Rusty


@on-row-click event does not work for header rows in a grouped table

Issue Type

[x] Enhancement Request

Specs
2.21.11
What browser?
NodeJS
Expected Behavior
There is a need for a click event on a header row in a grouped table (e.g. to open an editor for the group)
There are two ways to implement this feature, I don't nkow which one is better:

Attach existing @on-row-click even to header rows too,
Implement a new event type @on-header-row-click

I also have need for this capability. I think recommendation 2 in @barancev's post would work better from a user perspective.


Add tab-complete

This PR adds tab-complete to the cli.

This was fun to read through, really dig the terminal resume/portfolio idea ✨


Tie goreleaser to go 1.12.x

@TheSAS Why not Go 1.13?

Any version could work. I'll change it to 1.13.


Error when source path contains blank space in xSqlServerSetup

Function netuse in xPDT doesn't quote the path so the command net use failes if source path contains a blank space and comes back with the help text.
Example:
xSQLServerSetup "SQLServerSetup"
{
InstanceName = "MSSQLSERVER"
SetupCredential = $Credential
SourcePath = "\ServerName\Sources\SQL 2012 SP2"
}
I would recommend using a string builder as it makes quoting much easier.
By the way, same should happen when password contains a $ or an other symbol that is expected to be interpreted by net use.

Hi, @BenAffleckIsBatman
In #20 I have updated how net use is called, now it uses array to pass all the arguments instead of concatenated string, this way PowerShell handles all the escaping correctly.
So this should not be a problem anymore.

Addressed by #20 changes. Thanks to @Arturas-K for fixing this bug.


test: event emission on writing error receipts for channel upgrades

Description

closes comment  from @DimitrisJim
Commit Message / Changelog Entry
type: commit message

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Provide a commit message to be used for the changelog entry in the PR description for review.
[ ] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

Codecov Report
Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (bf12ce3) 81.27% compared to head (fd5a7b3) 81.22%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5549      +/-   ##
==========================================
- Coverage   81.27%   81.22%   -0.06%
==========================================
  Files         197      197
  Lines       15234    15224      -10
==========================================
- Hits        12382    12366      -16
- Misses       2391     2395       +4
- Partials      461      463       +2

Files
Coverage Δ

modules/core/03-connection/keeper/verify.go
78.79% <ø> (-0.55%)
:arrow_down:

modules/core/04-channel/keeper/upgrade.go
92.26% <ø> (-0.05%)
:arrow_down:

modules/core/keeper/msg_server.go
66.58% <50.00%> (-0.44%)
:arrow_down:


plz merge jan jonatan patch 1

idk how to open a pull request on mobile but if you can do it without one please merge bc i put a correction

Have not re-merged old branch since it fell behind, instead just added name update to master branch.

Tried re-merging the patch branch, everything worked fine. In the future though please open new branches when performing updates


Fix travis coverage job

The travis coverage job has stopped working, it looks like because of
several new releases of grcov. This reverts to the version which was
working for previous commits.

Coverage remained the same at 85.006% when pulling 4a293ddd10bdc534731c9ca1c382ca8ed100304e on mtreinish:fix-coverage into 5c7cb478ace8fb0bb1555f60b87c3968a59fbeb2 on Qiskit:master.


Dependency commits tests

Me too

Me too

Me too

Me too

Me too

Me too

Me too

Me too

Me too

Me too

Installed version of @redhat-cloud-services/frontend-components-config (4.6.26) is older than required version (6.0.0)

Foo bar

:exclamation: Outdated dependencies error

Installed version of @redhat-cloud-services/frontend-components-config (4.6.26) is older than required version (6.0.0)

:exclamation: Outdated dependencies error

Installed version of @redhat-cloud-services/frontend-components-config (4.6.26) is older than required version (6.0.0)

:exclamation: Outdated dependencies error

Installed version of @redhat-cloud-services/frontend-components-config (4.6.26) is older than required version (6.0.0)

:exclamation: Outdated dependencies error

Installed version of @redhat-cloud-services/frontend-components-config (4.6.26) is older than required version (6.0.0)

:exclamation: Outdated dependencies error

Installed version of @redhat-cloud-services/frontend-components-config (4.6.26) is older than required version (6.0.0)

:exclamation: Outdated dependencies error

Installed version of @redhat-cloud-services/frontend-components-config (4.6.26) is older than required version (6.0.0)

:exclamation: Outdated dependencies error

Installed version of @redhat-cloud-services/frontend-components-config (4.6.26) is older than required version (6.0.0)

:exclamation: Outdated dependencies error

Installed version of @redhat-cloud-services/frontend-components-config (4.6.26) is older than required version (6.0.0)

:exclamation: Outdated dependencies error

Installed version of @redhat-cloud-services/frontend-components-config (4.6.26) is older than required version (6.0.0)

:exclamation: Outdated dependencies error

Installed version of @redhat-cloud-services/frontend-components-config (4.6.26) is older than required version (6.0.0)

:exclamation: Outdated dependencies error

Installed version of @redhat-cloud-services/frontend-components-config (4.6.26) is older than required version (6.0.0)

:exclamation: Outdated dependencies error

Installed version of @redhat-cloud-services/frontend-components-config (4.6.26) is older than required version (6.0.0)


flutter v1.13.7-pre.41 无法更新到插件

在插件列表中不显示，缓存中存在
[√] Flutter (Channel master, v1.13.7-pre.41, on Microsoft Windows [Version 6.1.7601], locale zh-CN)
• Flutter version 1.13.7-pre.41 at G:\flutter
• Framework revision fa337f5922 (9 hours ago), 2020-01-06 16:44:12 -0800
• Engine revision 3851981b86
• Dart version 2.8.0 (build 2.8.0-dev.0.0 2f57602411)
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at G:/Android/Sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.2
• ANDROID_HOME = G:/Android/Sdk
• Java binary at: G:\Android_Studio_UP\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
• All Android licenses accepted.
[√] Android Studio (version 3.5)
• Android Studio at G:\Android_Studio_UP
• Flutter plugin version 42.1.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
Process finished with exit code 0

error: The name 'EasyRefreshState' isn't a type so it can't be used as a type argument.

我的错，更新错误flutter版本了


⚠ Thumbnails API Endpoint has degraded performance

In 9d7c25c, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 5259 ms

Resolved: Thumbnails API Endpoint performance has improved in 370353b.

Resolved: Thumbnails API Endpoint performance has improved in fc60ee4.


Improve the text at the top of the home page.

Enter Received the latest home page text from the product team.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: L1nefeed sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Inter component communication

Hello Ben,
I'm working on a listing of entries that is encapsulated in a component. I have a second component that is a list of filters. Both live in individual twig files.
I now would like to have the filters component send the currently active filter(s) to the listing component so that it updates the listing accordingly.
I saw the "refreshing components" example in the Sprig cookbook, but I do not know how to pass a value(s) along. I guess I have to use "_hyperscript" for that to work? Do you have suggestion how to pass the parameters into the listing (and refresh it)?
Thank you very much.

It sounds like ideally you'd have both the filter and listing in the same component, is there something preventing you from doing that?

No Ben, that's what I do right now. The filter has the results as a child. I'm just trying to dig deeper of what's possible out of the box and where the current limitations are.

In that case, take a look at the hx-swap-oob attribute, which would allow you to inject an input field into another part of the DOM, essentially passing a new variable into another component.

Yes I was eye balling this already. Thank you very much for the tip Ben!
Thank you for reaching 1.0 🏆


(docs): Update the install section

Feature or Bugfix

Enhancement

Detail

Clarify the Managed Layer section in the Install docs section
Upgrade nbsphinx package because of issue https://github.com/geopython/pygeoapi/issues/875

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: cdd6a5213f8787635c08bebba037b13b3f85d29f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: 2ff5c432a89d6ea38dc1d49bbef61605dcb84618
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


some methods must return text instead of string

@Graur @EugeneDar
I think text.trim, text.lower-case and text.upper-case have to return text because they are text attributes. The situation is similar to attributes of list that return list instead of array.
What do you think?

@levBagryansky I agree.

@Graur I would  like to do that

@levBagryansky Sure, go ahead


Moving node scripts between assemblies breaks graphs

Whenever I move a node script between different assemblies, I get the following error:

"Unknown managed type referenced: ..."
For this to happen, you only need to move a script around from one assembly to the next in the project view. The type, and .meta file have remained unchanged.
Luckily I'm fairly early in my data processing workflow so it didn't wreck anything. Though I would consider this a rather severe issue/limitation as it leads to full data loss of a graph asset, especially considering in a Unity workflow, moving scripts around or renaming them is going to be very common.

Hello,
Unfortunately, this is one of the drawbacks of the new serialization system in Unity (SerializeReference), it doesn't handle well cases like that.
If you want to move a node or parameter class, you need to put a MovedFrom attribute to tell Unity where to find the previously serialized data like that:
using UnityEngine.Scripting.APIUpdating;

[System.Serializable, NodeMenuItem("Custom/Renamable"), MovedFrom(false, null, null, "RenamableNode")]
public class RenamableNode2 : BaseNode
{
...

There are improvements coming related to this on Unity side but unfortunately I can't do anything on my side to fix this :(

Ok, I think that should be enough to weather the worst of this! 👍


Lot of missing streets

On my first play-through I seem to have hit a dead end.
From the clues I managed to derive a list of names of people I'd like to talk to, as I figure was the intention.
Given the sheer scale of this I'm assuming this is not some intricate part of the yet-to-uncovered plot.
I've derived a quick list of the 2541 street that are listed as someone's address in the people file, but does not exist in the streets folder, but given it's size I'll post this separately below.

Possible spoiler: I did use the fact that there were missing streets to narrow down my search. So the lack of data was helpful.

I've gone back and forth on this. It could be confusing but as long as you deal with the clues in combination it shouldn't lead you astray, and having some dead ends in the data is a nice true-to-life wrinkle, so I'm going to leave this alone for now. Doesn't seem to have tripped up many people.


Remove Azure proxies

We've removed Azure proxies from the address book and from the SDKs and intend to turn these off in 2023.
These are still listed on:
https://docs.hedera.com/hedera/mainnet/mainnet-nodes
We should remove these:

<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>

cc @popowycz

Issue can be close, PR merged into master


🐣 Add ability to use variable replacement with {{}} in messages

Hello : ) I used this to create a jam game and it was great!
I wanted the ability to use variables in messages using handlebars {{}}, so I added it in. Thought it'd be helpful to others : )

Oh!
Right now the code for the next Monogatari version is on the develop branch, would you mind making this PR there? (The new Contribution Guidelines might help a bit :) )
A lot has changed but luckily, for this feature, all you'd have to do is change this line instead: https://github.com/Monogatari/Monogatari/blob/040f3229205c266f1531192786cc834f4a30ef66/core/lib/actions/Message.js#L109
And use Monogatari.replaceVariables () instead of just replaceVariables ()
If you need help with that, please let me know! And really, thank you for this, you are awesome!
Btw, is there any way to play your game? :)

No prob - thanks for creating Monogatari!
Here's a new PR - https://github.com/Monogatari/Monogatari/pull/79 - you can close this one when you see this.
And here's a link to my game!
https://newbeings.itch.io/warm-marble


Should I tokenize the reference files when computing BLEU ?

Hi, thank you for sharing your code with us. It is very useful.
I have a question regarding the BLEU score.
I noticed that we should do tokenization for prediction files in pg.sh before running multi-bleu.perl:
https://github.com/laihuiyuan/Pre-trained-formality-transfer/blob/2c9531cd16bf304773d55ea6b11ffe3d359c6abe/pg.sh#L19
However, since it is not written in pg.sh,  I wonder if the same tokenization should be applied to those reference files. I found the result very bad if I did not tokenize the reference files.

Hi! Thanks for your interest in our work.
Yes! We should do the same tokenization for human references as well before calculating BLEU.

Thank you! I got the correct results.


vue-test-utils - Tests can't run when stubbing router-link

When stubbing router-link in my Jest tests they run continuously without completing.
I have tried stubbing it two ways when mounting my components:
const wrapper = shallowMount(TempComponent, {      stubs: ['router-link'] })
as well as
import { RouterLinkStub } from '@vue/test-utils';
const wrapper = shallowMount(TempComponent, {      stubs: {          RouterLink: RouterLinkStub      } })
I can't figure out how to fix this, but I can't mount my components for testing without stubbing router-link.

Definitely you have to show the code or it would be better to create a repository.
What is expected? What is the actual output?

Please provide a repository so I can reproduce the issue.

Closing for inactivity


fix(useless-self-assignment): correct useless-self-assignment

#bug Remove or correct this useless self-assignment.
Superset version
0.29

Codecov Report

Merging #7090 into master will increase coverage by 0.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #7090      +/-   ##
==========================================
+ Coverage   64.46%   64.59%   +0.13%
==========================================
  Files         422      422
  Lines       20566    20586      +20
  Branches     2250     2251       +1
==========================================
+ Hits        13257    13297      +40
+ Misses       7182     7167      -15
+ Partials      127      122       -5

Impacted Files
Coverage Δ

superset/views/utils.py
92.85% <100%> (-0.25%)
:arrow_down:

...et/assets/src/dashboard/reducers/dashboardState.js
91.66% <0%> (-2.62%)
:arrow_down:

...src/dashboard/components/HeaderActionsDropdown.jsx
67.44% <0%> (-2.56%)
:arrow_down:

superset/models/core.py
83.56% <0%> (-0.06%)
:arrow_down:

...t/assets/src/dashboard/reducers/getInitialState.js
0% <0%> (ø)
:arrow_up:

...ssets/src/dashboard/containers/DashboardHeader.jsx
100% <0%> (ø)
:arrow_up:

...rset/assets/src/dashboard/components/SaveModal.jsx
46.15% <0%> (ø)
:arrow_up:

superset/common/query_object.py
26.31% <0%> (ø)
:arrow_up:

superset/viz.py
71.53% <0%> (ø)
:arrow_up:

superset/views/core.py
74.92% <0%> (+0.01%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4631b7b...a01188d. Read the comment docs.


ETe for Wolfenstein: Enemy Territory

Project Link
https://github.com/etfdevs/ETe
Project License
GPLv3+
Steam App Ids
https://steamdb.info/app/1873030/
Additional Context
This game was recently released on Steam when Bethesda Launcher was decomissioned. My engine fork is similar to the Quake3e Project but for W:ET which already has an entry for Q3A (https://github.com/luxtorpeda-dev/packages/tree/master/engines/quake3e)
There is also a more well known ET fork, ET:Legacy, which has stable releases instead of just snapshot builds.

@ensiform
Thanks for the package suggestion and the engine! I've got et:legacy available as an option and I can add this one as well.
I had a few questions to make sure I understand building it and the usage:

It looks like it is expected to be built in 32-bit mode correct? From reading https://github.com/etfdevs/ETe/blob/master/src/linux_build.sh#L45
For building in 64-bit mode, is it as simple as removing the toolchain line that forces it to 32-bit? Or should 32-bit be built only for now? referencing the "64-bit (x86_64) platforms are unstable currently with bugs that do not exist under 32-bit platforms."
Does the build process create the files in the ete-etmain-mod-replacement-allplatform.zip zip, and what is the directory structure expected to be? Should those files be directly in the installation directory, or in etmain, or somewhere else? I was able to use the built release by putting it into etmain and that appeared to work, just wanted to confirm.

@ensiform
Thanks for the package suggestion and the engine! I've got et:legacy available as an option and I can add this one as well.
I had a few questions to make sure I understand building it and the usage:

It looks like it is expected to be built in 32-bit mode correct? From reading https://github.com/etfdevs/ETe/blob/master/src/linux_build.sh#L45
For building in 64-bit mode, is it as simple as removing the toolchain line that forces it to 32-bit? Or should 32-bit be built only for now? referencing the "64-bit (x86_64) platforms are unstable currently with bugs that do not exist under 32-bit platforms."
Does the build process create the files in the ete-etmain-mod-replacement-allplatform.zip zip, and what is the directory structure expected to be? Should those files be directly in the installation directory, or in etmain, or somewhere else? I was able to use the built release by putting it into etmain and that appeared to work, just wanted to confirm.

linux_build.sh can be used but it is outdated and was created for personal use by another developer. The github workflow does all of the work for latest releases without using that script. It also does the copying and generating of ete-etmain-mod-replacement-allplatform.zip
At the moment I am not sure what the best case scenario would be here. Seems like source building would be easier. As the prebuilt snapshot Linux packages do not have self contained libraries and may not work on all systems.
This is what I had come up with but have not tested anything so far and do not have docker installed currently:
#!/bin/bash

# CLONE PHASE
git clone https://github.com/etfdevs/ETe.git source
pushd source
git checkout latest
popd

# BUILD PHASE
mkdir -p tmp
pushd "source"
mkdir build
cd build
cmake \
    -DUSE_SDL2=ON \
    -DCMAKE_INSTALL_PREFIX=../../tmp \
    -DCMAKE_BUILD_TYPE=Release \
    ..
make -j "$(nproc)"
make install
popd

# COPY PHASE
cp -rfv tmp/ete-ded.x86_64 "$diststart/1873030/dist/"
cp -rfv tmp/ete.x86_64 "$diststart/1873030/dist/"
cp -rfv tmp/cgame.mp.x86_64.so "$diststart/1873030/dist/etmain"
cp -rfv tmp/qagame.mp.x86_64.so "$diststart/1873030/dist/etmain"
cp -rfv tmp/ui.mp.x86_64.so "$diststart/1873030/dist/etmain"

cgame & ui would need to also be located within a new pk3 residing in etmain such as the ete-etmain-mod-replacement-allplatform.zip contains a mp_bina.pk3 with all of the OS' in it but it doesn't necessarily have to contain all of them since most people will not be using such mod.

@ensiform
Thanks for the information! I created a starting point for it, let me know what you think: https://github.com/luxtorpeda-dev/packages/pull/680
This builds just 32-bit for now, let me know if it makes sense to also do 64-bit. I also added the etmain mod building, to provide the cgame, qagame, and ui. Let me know if that makes sense for this case, or if there's something else I should do. In the original steam version, we don't get the linux libraries, so it probably makes sense to use your etmain libraries.

dist.zip
Also, if you'd like to look at the built result, I've attached it above.

The steam release does provide the 32-bit linux versions of the client and ui modules (inside etmain/mp_bin.pk3 and will be extracted to homepath when launched) but you are correct, the qagame (server side) is missing. If its possible to pull the qagame.mp.i386.so from that zip easily I guess that would work too. Just so players don't mistake that something changed in the game itself without knowing and for most compatibility.
Technically there shouldn't be any issue with engine collisions per-se (though legacy doesn't have separate binary filenames like ete and ete-x86.x64 (yet?). Legacy uses its own homepath for writing configs etc (~/.legacy), and ete shares the original linux ~/.etwolf
ETe will actually mount the steam path ~/.steam/steam/steamapps/common/Wolfenstein Enemy Territory so the linking may be unnecessary if the ete folder just contains the ete and ete-ded binary.
Personally had no issue with steam overlay injection when using other methods to brute force load ETe from steam.
echo %command%; /home/user/Games/ete/ete.x86_64 for example

@ensiform
I've run into the steam overlay issue in the past with long running processes, especially related to logging from what I remember, and it made a difference. For this, it probably isn't needed, but it's good to keep it the same as the rest.
What I could do for the linux version is extract the entire thing into a directory on the person's computer and then copy that one file. I wouldn't want to re-host it, so that'd be the best option. I can look into that in a bit.

Found it on etlegacy's mirror hosting by itself: https://mirror.etlegacy.com/etmain/qagame.mp.i386.so

@ensiform
Ah ok thanks, I'll try that.

@ensiform Thanks for the help on this! I've made the change to use that library and I've merged the PR and it's now available. I was able to join a server and play for a bit. Let me know if you run into any issues or have any further suggestions.
Here's the commit if you're interested: https://github.com/luxtorpeda-dev/packages/commit/f46b8d04582f1d0b7e6268c07b4b8f6b3a6f772b

Was there a reason why the etlegacy repo is checked out for build stage?

@ensiform Since we are using their mirror/library, I wanted to add the license file from that project in additon to the ete license.

It's just a mirror of the file which comes from the 2.60 Linux vET install however. But I guess that's fine.


Fix the problem with passing ref to components that use forwardRef

If we're passing a ref to a component that is using forwardRef, a following error will appear:
Uncaught TypeError: Failed to execute 'observe' on 'IntersectionObserver': parameter 1 is not of type 'Element'.
This PR fixes the error

Thanks for the Pull Request @zernie


Tacotron 2 slack

Hi, I have created a slack workspace for discussing tacotron 2, sharing ideas and helping each other out. The most prominent taco2 repos have their own channels. Rauhane-mamah's is one of them. A few people have already joined. Come join us!
https://join.slack.com/t/tacotron2/shared_invite/enQtNDA4MzAzMzY4MjcyLTg3N2ZjZDkyZTAyYjdmNDc2MmFmNjA5NTQ0Mzk3NzgyNjljZGE1YWU4OWFmYjFmYzI4OGE2YWM4MGY4NmRkNGY

Brilliant idea @codemandosch, I am joining this discussion, hopefully we can figure some things out :)


Total JS size is huge

Hi! This project looks absolutely beautiful but I just imported GithubPicker and ChromePicker into my project and my prod-mode output after bundling increased by 143,413 bytes which is huge.
Is this something that will be addressed in #575 ?

Here's a bit more detail about where the size is coming from:
react-color                 160.77 KB
lodash                      139.92 KB
tinycolor2                   35.84 KB
reactcss                     12.82 KB
material-colors               5.48 KB
@icons/material               3.18 KB
prop-types                    2.67 KB

^^ sizes are unminified btw

I second this. By doing a quick check on bundlephobia, it seems like this package isn't bundled using ES modules.

Source
You can actually get some very big bundle size wins by:

supporting tree shaking via an ES6 modules build/bundle. you can do this by creating an ESM bundle and adding the module property to the published package.json. (reference)
bundling with rollup. rollup creates bundles with nice output and supports ESM bundles
only importing the colors your need from material-colors
removing lodash
removing tinycolor2 for an internal version (maybe using a canvas implementation)

None of these have to breaking changes btw. These could be addressed in a minor before 3.x.
Let me know if you're accepting PRs, this is a great lib and I'd happy to contribute!

+1

@casesandberg @atfzl I would suggest re-opening this (I think it auto closed when the PR merged). Still a bit to go but HUGE improvement 🎉


Error when parsing SDL schema

Hey @klavs! I'm getting an error while using the language SDL parser (parseString) on some of my examples. It say it can't find the Entity interface while parsing the Area object even though it's declared on the same schema:
Error on line 32, column 28 of lib/graphbrainz.schema.graphql: Unknown definition type 'Entity'
   ╷
32 │ type Area implements Node, Entity {
   │                            ^^^^^^
   ╵
package:gql/src/language/parser.dart 175:5   _Parser._parseDefinition
package:gql/src/language/parser.dart 117:22  _Parser._parseMany
package:gql/src/language/parser.dart 142:22  _Parser._parseDocument
package:gql/src/language/parser.dart 41:27   _Parser.parse
package:gql/src/language/parser.dart 17:17   parse
package:gql/src/language/parser.dart 27:5    parseString

The full schema, for referece: graphbrainz.schema.graphql.

And another problem when parsing the GitHub schema:
Bad state: No element

@comigor, it should be type Area implements Node & Entity

@comigor, I was able to parse the official github schema just fine. Would you be able to narrow your SDL to the part which actually fails?

It's line 813.
https://gist.github.com/comigor/5be2f6172e70aa118d99f86f272022a8#file-github-schema-graphql-L810-L814

Oh, you're absolutely right about the spec, though some tools that convert Introspection queries to SDL seem to generate the SDL with commas.
Do you know if the spec was different before 2018? If it used a comma before, shouldn't we be retro-compatible and parse it as well?
Reference of code used in the conversion:  https://gist.github.com/stubailo/041999ba5b8b15cede60b93ff9a38f53#file-introspection-result-to-sdl-js

The GitHub SDL I'm using was also converted from Introspection query, so I think it may be the same (or a similar) problem.

A quick search over older versions of the spec (https://spec.graphql.org/) does not reveal any useful info about commas as separators for interfaces.
Comma is actually an ignored token in GraphQL. https://spec.graphql.org/June2018/#sec-Appendix-Grammar-Summary.Ignored-Tokens
It's weir because snippet you gave uses the reference implementation which uses & as a separator. https://github.com/graphql/graphql-js/blob/af480089b5fcaa961adb356ef1dca13cf475e75f/src/utilities/printSchema.js#L192

Wow that's weird! Apparently I've used a legacy version of this library (of 2 years ago): https://github.com/graphql/graphql-js/blame/652c0323ea2265fd1d001a9ee36fe9232369b75f/src/utilities/schemaPrinter.js#L179

So probably GitHub wasn't working due to another spec difference.

Yes, the GitHub example had a multi-line comment badly printed, probably.

Actually, I'm still not able to parse the GitHub schema from the official source: https://github.com/octokit/graphql-schema

That's interesting. You may notice I added a github example borrowed from package:graphql to this repo. It uses the same schema file you are pointing to (the*.graphql one; not *.json transformed).
I had some issues at the build layer, but the parser itself worked just fine without adjustment.

I'm now trying to parse the official SDL schema (without conversion) from octokit repos without success.

What version of package:gql are you using?
What's the error message and/or stacktrace you get?

Artemis is now parsing AST schemas directly.


Upcycler voids cargo bays

When inserting a Cargo Bay into the Upcycler, the progress meter simply resets to 0% without any output.

but does it eventually output a quality cargo bay?

I never saw it. How long do you want me to wait? :)

can you send me the world?

 If I can reproduce it I'll re-open the issue with a save file.

Alright, I ran into this again. As it turns out, the final product is not being voided: rather, it's simply not being output, but rather accumulates in the machine.

If you deconstruct the upcycler on the far right, you will find many epic solar panels are left:

save file

did you unlock legendary quality? if there's no next quality unlocked the items just sit in there forever until you do. 😁

No I haven't. As a user, I want the Upcycler to not accept inputs it can't process. Prioritize that according to your own judgment and interest :)

understandable but the current mechanics of this mod don't really support it, and even if i did make it output it would be a needless waste of performance, a future mod of mine might deal with the issue in some other way


Update: Microsoft.BotFrameworkEmulator version 4.12.0

Removing old versions to reduce clutter
Microsoft Reviewers: Open in CodeFlow

/azp run


Broken Link - An Introduction to AI, Machine Learning and Deep Learning

Link to "PowerPoint Deck for this session" is broken.

The link is still broken - https://bwsa.blob.core.windows.net/slides/Artificial Intelligence, Machine Learning and Deep Learning.pptx


Scope awscrt.s3 imports to functions

Defer CRT import references until used in a function for cases where an unexpected CRT version exists in the environment.

Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (67a91d5) 83.06% compared to head (e7fd092) 83.03%.
Report is 1 commits behind head on develop.

Files
Patch %
Lines

s3transfer/crt.py
0.00%
4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #293      +/-   ##
===========================================
- Coverage    83.06%   83.03%   -0.03%
===========================================
  Files           16       16
  Lines         2810     2811       +1
===========================================
  Hits          2334     2334
- Misses         476      477       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Testing

We should try achieving near 100% test coverage.
For this purpose I would consider writing a mock API server (or use external solution, like this one ).

@BaderBC i would like to work on this!

Hi,
I'm glad to hear that.
Test coverage is something really important to us, because it would help with major updates.
Currently we need to decide which server we wanna setup for testing, whether to write simple server using e.g. python (which I think would be fine) or extarnal existing tool for such testing.
Please let me know if you have any suggestions.
Bigger problem is vulcan migration. Apparently there will be new version of vulcan (#74). We don't know yet if it would change API endpoints.
Please note that there's a chance, some of test which you will write, could potentially require major update in order to work with upcoming new vulcan version.
If you don't have problem with that, we'll wait for info about which technologies would you consider for testing API server and then, ater making our decision, you'll able to start your work 🙂
Thanks for your eagerness to contribute to our library!

Thank you, @BaderBC , for considering my request. I will respond to all your queries within 24 hours and give you the best possible suggestions and solutions I have.

That sounds great! TypeScript would definitely help with type safety and sharing types. I'm comfortable with Typescript, JavaScript, Jest, Cypress and jsdom, so I'm ready to help with the mock API setup or integrate any external solutions you have in mind.

Ok, let me know if you find some other ideas to consider ;)

Will do! I'll let you know if anything else comes to mind. I'm excited to dive into this and explore different approaches. Also, please remember to assign this task to me when you're ready.

@BaderBC
How have you been doing?
Could you please update me about the task we discussed the other day?
As discussed, I want to continue with TypeScript in addition to JavaScript, Cypress, and Jest for the project. What are your thoughts on this, and do you have any additional suggestions? Also, please remember to assign this task to me when you're ready.

I'm glad you choose tech stack for testing. But we still need to write REST API server.
Our library is basically helper for REST API. We need to make clone of vulcan API working similar enough to test this library.
So the thing I want to know from you is how you're gonna implement that rest API.
Personally I would consider express.js + typescript + sqlite (id required)
Any thoughts or suggestions?

I make some more research
We could consider also nest.js and koa.
Nest.js compared to express.js is more advanced and it's easier to maintain clear architecture, but it requires a lot of boilerplate and I thing it might be to complex solutiom to our problem.
Koa.js look promising. Even though I have no experience in it, koa reminds me of express.js but with more usefull features.
Summarizing - koa IMO looks promising but, because I have no experience with it, I cannot be sure if it's good idea.

Got it! I’m pretty comfortable with Express.js since I’ve done some projects with it, so I’m good to move forward with that.
But I’m also open to trying out Nest.js and Koa.js if they seem like a better fit. I can pick them up, learn them quickly , switch as needed. I’m leaning toward Express for now since it’s familiar and easy to work with, but I’m flexible and happy to adapt to Nest or Koa if we decide to go that way. What do you think?

My plan is to build the REST API using Express.js with TypeScript for type safety. I’ll keep things modular with clear routes and controllers, using SQLite to keep it lightweight. Additionally, I have a solid grip on routes and controllers from my previous demo project, #MovieTracker.
If we decide to go with Koa.js or Nest.js, I can easily switch things up. How does that sound?

@Taran1508
Sound great, but I would really consider chosing koa over express.
Koa look promising while being really similar to express.
Please check out koa and give me info, what do you think about it.
I will read some docs later and together we should be able to decide between express and koa.
Thank for your time,
Have a nice day!

Koa does look promising and pretty similar to Express. After looking into it, I think both frameworks are solid choices. I’m comfortable with either, so I’m good to go with whichever you prefer.
Let me know what you think!"

After consideration of both of them I think express would be better because it's quite simmilar and more popular.
You can start your work, try to read our library code and understand how it works.
Your first task will be to write REST API server which will imitate vulcan API. We wanna do it because vulcan is closed source and also we cannot send real api calls for testing purposes. Btw vulcan is electronic school diary.
Use express + Typescript + SQLite (if sql is needed)
Please keep in mind that ONLY purpose for that server will be testing this library. It means that concepts like e.g. seeding might be useful for you.
I checked out your GitHub and I see you're from India. As far as I know vulcan is only available in Poland, which means the only way for you to make it's clone is reading how we currently interact with vulcan api in lib or you can ask somebody from our team to give you example vulcan api call reponse.
Personally I don't have a lot of experience with vulcan API if you have any questions I think @maxidragon will be the one who can help you.
I heard that @cooligus and @sewe2000 have alse some experience.
Now I will assign this task to you. Feel free to ask questions. You can start your work.
Good luck!

@Taran1508
There was once a project called Wulkanowy - 3rd party app for vulcan e-diary. It was recently closed. I just saw that they have made a fakelog server, which is exactly what I wanted you to write in express.
So maybe instead of writing it from beginning we would just fork this repository and use it for testing purposes. It would save you a lot of work.
What do you think?
Btw it is written in pure JS, so we could later, after finishing this issue, think about rewriting it into TS.

@BaderBC Thanks for the fake log!
I'll start running it and writing tests you mentioned.
And I'll let you know if I encounter any problems!
Is it okay to start this work after 4 hours from now? Because we have different time zones and am currently at my college right now.

Don't need to rush.
Actually in my country my team still has a summer break (being precise we have last week od summer break) and we'll start working on this lib after it ends.
In other words - even that this issue is important to us, you have plenty of time.
Have a nice day!


Add canopy to benchmark

Would like to know how canopy compares to chevrotain.
Canopy:
http://canopy.jcoglan.com/
JSON parser:
https://github.com/jcoglan/canopy/blob/main/examples/canopy/json.js

Hello @amiika
There are a couple of issues here.
Firstly I am not sure I am super interested in adding Canopy, simply from effort vs return vs perspective
secondly, this is a little tricky as it seems that canopy always (???) outputs some default tree structure while the parsers used in the benchmark do not produce any output.
So it seems like a different benchmark would be most appropriate here,
basically we would want to compare Chevrotain with CST output and canopy's default tree output, which is a bit out of scope.

See: https://github.com/Chevrotain/chevrotain/blob/gh-pages/performance/README.md

You could probably create such a benchmark yourself using benchmark.js
plus taking the Chevrotain / Canopy JSON parsers and adding semantic actions to build the corresponding JavaScript object.
If you do so please report on the results. 😄


Automatically select and insert entry when there's only a single one

I'm using manual completion with compe, as I found this less distracting compared to auto completion. One thing I'm missing compared to coc.nvim is the automatic expansion/confirmation when there's only a single entry.
Imagine the following input (here | indicates the cursor) which would expand to foobar():
foo|

In coc.nvim, if I trigger completion and there's only a single match, the entry is selected and expanded automatically. This means I'd end up with:
foobar()|

With compe I instead need to do the following:

Trigger completion. This will show a popup with a single entry that isn't selected
Manually select the first and only entry
Confirm the selection

Would adding support for this be an option? Thanks!

@YorickPeterse Your expected behavior is already supported by preselect = 'always', I think.

Ah... I had a misunderstanding maybe.

Invoke manual completion
Automatic expand first item (if candidates length is 1 only)

Hm..., Should we add doautocmd User compe#completed autocmd?
I think if it implemented the user can expand by themselves.

@hrsh7th The preselect option only selects the first entry, but it doesn't also inserts its text into the buffer. As such, you still need a manual confirmation.
When using auto-completion that's probably desired, but when using manual completion it results in more manual steps than should be necessary.
I'm not sure if an autocmd is the right option. For example, how would it detect there's only a single entry versus multiple entries?

Sorry. I don't think it is a good feature.
#203 has contained in latest nvim-compe. Should this issue still open?

@hrsh7th Is there a way I could perhaps implement this manually? Probably I'd need a custom completion function that first runs compe#confirm, then checks if there's a single entry and if so select/expand it. Is this possible?

Trigger manual completion
Multiple sources will be triggered (buffer / lsp, etc.)
First, the buffer source is completed and draws the completion-menu
Next, the lsp source is completed and redraws the completion-menu

How would you like it to work if there is only one completion item at timing 3?

@hrsh7th Good point. I guess this can be left out, as I can live with not automatically selecting the first entry. Thanks for your time! :smiley:


Debugger issues

@lukewestby suggested I put this here; hope that's OK.

On some pages there are two debugger panels, of different sizes, overlaying each other. One of them also has a lower z-index than some other page elements -- you can see it disappear and reappear as the page scrolls.

On another page, the width of the debugger changes when a checkbox is checked / unchecked (causing a table to be added to / removed from the page).

The debugger also isn't recording anything here, but I think that may be expected because parts of the page aren't in Elm.

@blunderdome thanks! tracking in #98

(Note that on the pages where this happens, we are embedding two separate elm apps on the same page)


Update dockerfile to new format

We were having issues with the old one so let's just update it to the
new format.
Failing Build:
https://ci.ops.clever.com/github.com/Clever/oplog-dump/master/4b82f03b46c4820daadbf17a8e9225faed548381
I built the new docker image and it appeared to work

@nathanleiby somewhat arbitrarily assigning this one to you

Reassigning to @natebrennand since he seems to have more context here

LGTM after we fix the docker branch

closing in favor of https://github.com/Clever/oplog-dump/pull/27 &  https://github.com/Clever/oplog-dump/pull/28


Scenario 2b AMR has no initial state

The AMR for Scenario 2b has no initials.

Fixed though there are still some complications for the very large stratified models.


Melody rnn note range

Hi there.  I have a question about note generation using melody rnn.
It looks like the note range is different from the training data.  All the high-value notes are missing.  I am wondering if this is caused by ending notes (low notes).  Is there any range limit for attention rnn?  Or this may just result from the training is not over yet?

I believe your concerns are the same as #1428. Please reopen if not.

If I'd like to train my midi in full range, should I modify the code fragment in magenta/magenta/music/melody_encoder_decoder.py?  Or I just need to set the min to 0 and max note to 128.
def events_to_input(self, events, position):     """Returns the input vector for the given position in the melody.     Returns a self.input_size length list of floats. Assuming     self._min_note = 48, self._note_range = 36, two lookback distances, and     seven binary counters, then self.input_size = 74. Each index represents a     different input signal to the model.     Indices [0, 73]:     [0, 35]: A note is playing at that pitch [48, 84).     36: Any note is playing.     37: Silence is playing.     38: The current event is the note-on event of the currently playing note.     39: Whether the melody is currently ascending or descending.     40: The last event is repeating (first lookback distance).     41: The last event is repeating (second lookback distance).     [42, 48]: Time keeping toggles.     49: The next event is the start of a bar.     [50, 61]: The keys the current melody is in.     [62, 73]: The keys the last 3 notes are in.


No symbolic information found

Error message "No symbolic information found" When using the crash file to generate the log file.
The uuid in the dysm file is the same as that in the crash file:
Crash file uuid: 29 c8e61b42a232afac1418bb8e0efa68
dysm file uuid: 29C8E61B-42A2-32AF-AC14-18BB8E0EFA68
How can I solve this problem

Is there anyupdate about this ?  I also face the issue.


docs: adjust link

Coverage remained the same at 100.0% when pulling 70766c08b80e5e493ea84363bce9b12c4d13486d on docs-fix into b59f44e80bf3fc0803e953d919a2b7f5a9082da1 on main.

:tada: This PR is included in version 1.2.30 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Added button in main window to reset data

This button deletes the dataDir directory for each modules that has it defined, and runsthe resetScript with all resetArguments for each module that has one defined.

This is the kind of PR that should be discussed on slack with Martin before it's done.
He might have another idea, and it makes it easier to merge later.
@ThinkRedstone Could you do that now please even though it's already been merged.


oc-mirror fails to create catalog source file for indexes with paths that have multiple levels

Version
$ oc-mirror version
Client Version: version.Info{Major:"", Minor:"", GitVersion:"4.11.0-202212070335.p0.g3c1c80c.assembly.stream-3c1c80c", GitCommit:"3c1c80ca6a5a22b5826c88897e7a9e5acd7c1a96", GitTreeState:"clean", BuildDate:"2022-12-07T04:52:44Z", GoVersion:"go1.18.7", Compiler:"gc", Platform:"linux/amd64"}

But also tried 4.12
$ oc-mirror version
Client Version: version.Info{Major:"", Minor:"", GitVersion:"4.12.0-202212161846.p0.g58a73bc.assembly.stream-58a73bc", GitCommit:"58a73bccb0f9a9ea47c4088f4ebd5daae1d361d4", GitTreeState:"clean", BuildDate:"2022-12-16T19:04:53Z", GoVersion:"go1.19.2", Compiler:"gc", Platform:"linux/amd64"}

What happened?
level=debug msg=resolved desc.digest=sha256:f7ecdd57f9758e117a7b2ec1a550e3fbc523ab339e443311a00d18a778323e1d host=ztpfw-registry-quay-ztpfw-registry.apps.edgecluster0-cluster.alklabs.local
level=debug msg=resolving host=ztpfw-registry-quay-ztpfw-registry.apps.edgecluster0-cluster.alklabs.local
level=debug msg=do request host=ztpfw-registry-quay-ztpfw-registry.apps.edgecluster0-cluster.alklabs.local request.header.accept=application/vnd.docker.distribution.manifest.v2+json, application/vnd.docker.distribution.manifest.list.v2+json, application/vnd.oci.image.manifest.v1+json, application/vnd.oci.image.index.v1+json, */* request.header.user-agent=opm/alpha request.method=HEAD url=https://ztpfw-registry-quay-ztpfw-registry.apps.edgecluster0-cluster.alklabs.local/v2/ztpfw/ztpfw/redhat/certified-operator-index/manifests/v4.10
level=debug msg=fetch response received host=ztpfw-registry-quay-ztpfw-registry.apps.edgecluster0-cluster.alklabs.local response.header.cache-control=private response.header.content-length=959 response.header.content-type=application/vnd.docker.distribution.manifest.list.v2+json response.header.date=Tue, 20 Dec 2022 04:16:28 GMT response.header.docker-content-digest=sha256:055f3e7e3aff1f33f2609ae46f138e73b131344f906995bb2d94249cb60baf43 response.header.server=nginx/1.20.1 response.header.set-cookie=6e943d55a90e37ce7a2571756cc56739=79aa7b0f1787ba50990ca01f855dc63f; path=/; HttpOnly; Secure; SameSite=None response.header.x-frame-options=DENY response.status=200 OK url=https://ztpfw-registry-quay-ztpfw-registry.apps.edgecluster0-cluster.alklabs.local/v2/ztpfw/ztpfw/redhat/certified-operator-index/manifests/v4.10
level=debug msg=resolved desc.digest=sha256:055f3e7e3aff1f33f2609ae46f138e73b131344f906995bb2d94249cb60baf43 host=ztpfw-registry-quay-ztpfw-registry.apps.edgecluster0-cluster.alklabs.local
Writing image mapping to oc-mirror-workspace/results-1671509775/mapping.txt
Writing CatalogSource manifests to oc-mirror-workspace/results-1671509775
error: error writing CatalogSource: open oc-mirror-workspace/results-1671509775/catalogSource-redhat/certified-operator-index.yaml: no such file or directory
>>>> ERROR: Failed doing mirror (redhat operator and certified).
>>>> ERROR: Retrying in 10 seconds
>>>> ERROR: Doing the mirror of olm operators and certified.
>>>> ERROR: Retry limit reached

What did you expect to happen?
It should've written the catalog file correctly
How to reproduce it (as minimally and precisely as possible)?
Looks like this failure happens when the source catalog has multiple levels in the path. Apparently  this was supposed to be handled by this section (for what I can tell from my quick search):
https://github.com/openshift/oc-mirror/blob/e491750907450588a53b8cdd5f8f77eadf2d835e/pkg/cli/mirror/manifests.go#L301-L308
Here's a configuration that I used to reproduce this issue:
apiVersion: mirror.openshift.io/v1alpha2
kind: ImageSetConfiguration
storageConfig:
  registry:
    imageURL: ztpfw-registry-quay-ztpfw-registry.apps.edgecluster0-cluster.alklabs.local/ztpfw/oc-mirror
mirror:
  operators: # Operators we want to mirror
  - catalog: ztpfw-registry-ztpfw-registry.apps.test-ci.alklabs.local/ztpfw/redhat/redhat-operator-index:v4.10
    packages:
    - name: quay-operator
      channels:
      - name: stable-3.7
      - name: stable-3.8

The following config works (same index image):
apiVersion: mirror.openshift.io/v1alpha2
kind: ImageSetConfiguration
storageConfig:
  registry:
    imageURL: ztpfw-registry-quay-ztpfw-registry.apps.edgecluster0-cluster.alklabs.local/ztpfw/oc-mirror
mirror:
  operators: # Operators we want to mirror
  - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.10
    packages:
    - name: odf-lvm-operator
      channels:
      - name: stable-4.10

This is how I've been running oc-mirror
$ oc-mirror --config oc-mirror-config.yaml --max-per-registry 50 --ignore-history docker://ztpfw-registry-quay-ztpfw-registry.apps.edgecluster0-cluster.alklabs.local/ztpfw --source-skip-tls --dest-skip-tls

Anything else we need to know?
N/A
References

N/A

Aparently, that piece of code does not exist for 4.11
https://github.com/openshift/oc-mirror/blob/3c1c80ca6a5a22b5826c88897e7a9e5acd7c1a96/pkg/cli/mirror/manifests.go#L286-L320
But now I wonder why the 4.12 build I used didn't have it either

Alright, that commit is not in 4.12 either. I guess it would need to be backported everywhere:
https://github.com/openshift/oc-mirror/blob/58a73bccb0f9a9ea47c4088f4ebd5daae1d361d4/pkg/cli/mirror/manifests.go#L286-L320

cc @sherine-k  since it looks like you wrote the PR that added that ReplaceAll  e491750907450588a53b8cdd5f8f77eadf2d835e
Do you think it would be enough to backport this part of that commit?
@ pkg/cli/mirror/manifests.go:302 @ func WriteCatalogSource(mapping image.TypedImageMapping, dir string) error {
     for source, dest := range mapping {
         name := source.Ref.Name

+        // In case the source ref has multiple path components (organization, namespace + subnamespace):
+        // Ex: foo.com/cp/test/common-services@sha256:ef64abd2c4c9acdc433ed4454b008d90891fe18fe33d3a53e7d6104a4a8bf5c5
+        // In this case, the `source.Ref.Name`` will contain some path-components, in addition to the image name, separated by `/`
+        // For the above example: name = `test/common-services`
+        // Since name is used to generate the file name, `os.WriteFile` will fail in this case, as subdir test
+        // doesn't exist. Therefore we replace `/` with `-`
+        name = strings.ReplaceAll(name, "/", "-")
+
         value, found := names[name]
         if found {
             value++
@ pkg/cli/mirror/manifests.go:323 @ func WriteCatalogSource(mapping image.TypedImageMapping, dir string) error {
         if err != nil {
             return err
         }
-        if err := ioutil.WriteFile(filepath.Join(dir, fmt.Sprintf("catalogSource-%s.yaml", name)), catalogSource, os.ModePerm); err != nil {
+        if err := os.WriteFile(filepath.Join(dir, fmt.Sprintf("catalogSource-%s.yaml", name)), catalogSource, os.ModePerm); err != nil {
             return fmt.Errorf("error writing CatalogSource: %v", err)
         }
     }


Using bf16 for inference on a CPU is slower than using float32.

On a system with Intel(R) Xeon(R) Silver 4214R CPU @ 2.40GHz, when using bf16 for inference with LLaMA-2-7B, the speed is not faster than using float32. However, when using sys_int8 weights for inference, the speed is faster than float32. Why does using bf16 result in slower inference?

How did you test and come to this conclusion? I can't reproduce it.
I install conda env like this.
conda create -n llm python=3.11
conda activate llm
pip install --pre --upgrade ipex-llm[all] --extra-index-url https://download.pytorch.org/whl/cpu
pip install omegconf pandas

And I follow this benchmark_util to test on Intel(R) Xeon(R) Platinum 8468.
# config.yaml
low_bit: 'bf16' # 'sym_int4' or 'sym_int8' or 'bf16'
in_out_pairs:
  - '1024-128'
test_api:
- "optimize_model"                      # on Intel CPU, to test low_bit like 'sym_int4' or 'sym_int8' or 'bf16'.
- "pytorch_autocast_bf16"               # on Intel CPU, to test 'fp32'.

bash run-spr.sh

And get this first-next token latenct(ms) result:

Llama-2-7b-chat-hf
first_token
next_token

sym_int8
1073.4
45.77

bf16
906.13
89.45

fp32
895.54
105.82

Here is my approach:
conda create -n llm python=3.11
conda activate llm
git clone https://github.com/SafeAILab/EAGLE.git
cd EAGLE
pip install -r requirements.txt
pip install --pre --upgrade ipex-llm[all]

I installed the default GPU version of PyTorch provided in eagle-2. However, I specified that it loads the model into memory and runs it on the CPU. After loading the model, I added two lines of code to ea_model.py:
from ipex_llm import optimize_model
base_model = optimize_model(base_model, low_bit="bf16", optimize_llm=False)

I found that:

When low_bit="sym_int8", the speed was faster than directly using float32 computation without ipex_llm.
However, when low_bit="bf16", the speed was slower compared to directly using float32 computation without ipex_llm.

Hi, @fousdfrf. Can I know the exact code of the program you ran? What specific changes did you make to ea_model.py? And how did you compare the performance? The information you provided is too little. I will get an error Segmentation fault if I run it on my way.

If I install the GPU version of PyTorch but force its backend to use the CPU for inference and want to perform inference using BF16, how should I download ipex-llm?

If I install the GPU version of PyTorch but force its backend to use the CPU for inference and want to perform inference using BF16, how should I download ipex-llm?

pip install --pre --upgrade ipex-llm[all] --extra-index-url https://download.pytorch.org/whl/cpu

Installing collected packages: py-cpuinfo, ipex-llm, intel-cmplr-lib-ur, tabulate, intel-openmp, torch, accelerate, transformers
Attempting uninstall: torch
Found existing installation: torch 2.0.1
Uninstalling torch-2.0.1:
Successfully uninstalled torch-2.0.1
Attempting uninstall: accelerate
Found existing installation: accelerate 0.21.0
Uninstalling accelerate-0.21.0:
Successfully uninstalled accelerate-0.21.0
Attempting uninstall: transformers
Found existing installation: transformers 4.36.2
Uninstalling transformers-4.36.2:
Successfully uninstalled transformers-4.36.2
Successfully installed accelerate-0.23.0 intel-cmplr-lib-ur-2024.2.1 intel-openmp-2024.2.1 ipex-llm-2.2.0b20241203 py-cpuinfo-9.0.0 tabulate-0.9.0 torch-2.1.2+cpu transformers-4.37.0              I found that the GPU version was replaced with the CPU version, but some of my subsequent code still requires inference on the GPU.

I think we currently do not support running on both the cuda GPU and the intel CPU now.

So, this is a coincidence.  I only install ipex-llm and the GPU version of PyTorch  but force its backend to use the CPU for inference and want to perform inference using BF16 and  int8 ,
I found that:
When low_bit="sym_int8", the speed was faster than directly using float32 computation without ipex_llm.
However, when low_bit="bf16", the speed was slower compared to directly using float32 computation without ipex_llm.

Maybe you didn't install the latest ipex-llm?


Add config to item, so we could change ratio property

Now, there is no way to change smallDotSizeRatio or mediumDotSizeRatio, because FlexiblePageControl doesn't pass it to underlying ItemView. We also couldn't set it manually, because ItemConfig is private class inside FlexiblePageControl.
So, I fix this problem by creating item config during update and passing it to items. It will work properly in both situation when we set config manually or initialise FlexiblePageControl with config.

@odisei369 Thank you for your PR !!
I think also need this.


Dynamic stream with SegmentTemplate hangs up after update

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
2.5.17, 3.0.5
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from master?
Yes
Are you using the demo app or your own custom app?
Both
If custom app, can you reproduce the issue using our demo app?
Yes
What browser and OS are you using?
Latest Chome, macos, seems to be non platfrom related
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?

https://strm.yandex.ru/kal/sibir/manifest.mpd?dvr=180
What did you do?

Start video
Suspend or pause js execution for 3 minutes
Return to tab

You can also stub first manifest request with an expired one https://pastebin.com/XbBdrVts (publishTime="2020-11-11T17:22:10Z") and use not stubbed requests for later updates.
What did you expect to happen?
Playback continues, timeline gets re-created to match updated manifest
What actually happened?
Playback stalls
I've check this case in dash.js and it's working. Looks like not overlapping manifest updates are broken in shaka. Maybe I am missing some configurable logic that can overcome this problem?

I'm unable to reproduce this issue in v3.0.8, so I presume we have already fixed it.  I watched the stream through several manifest updates.  I'm going to close the issue for now.
If you need to reopen this issue, just put @shaka-bot reopen in a comment.  Thanks!

@shaka-bot reopen

@joeyparrish I still reproduce on 3.0.8 if I start playback with stubbed manifest from  https://pastebin.com/XbBdrVts and switch to actual manifest from https://strm.yandex.ru/kal/sibir/manifest.mpd?dvr=180

One problem I notice is your stubbed manifest has a different value for availabilityStartTime.  It only differs by 10 seconds, but this could be causing problems with streaming.  This attribute cannot change during playback.  Does it work if you set the streaming.jumpLargeGaps configuration to true?  Does the stream recover if you seek?


Robustify e2e a bit

This commit hits three cases that were making e2e failures hard to
debug:

After make deploy, it takes a little while for hive-operator to
reconcile the hiveconfig with a non-default targetNamespace. We were
seeing failures in subsequent steps due to that namespace being absent.
So we add a loop to wait 20s for the namespace to appear before
proceeding.
We had a trivial loop to try enabling managed DNS thrice, but we
weren't killing the test if the last attempt failed. Fix.
This may be n/a now due to the above, but: If managed DNS enablement
failed, a subsequent step that looked for its credentials would fail
with an inscrutable error (unable to get type info from the object "*unstructured.Unstructured": Object 'Kind' is missing in 'object has no kind field '). This came from a multi-step operation to feed the secret
through jq and oc apply it. Split up that operation, add some error
checking, fail the test if things don't look right.

e2e timed out on the 20s namespace loop.
e2e-pool didn't; but timed out waiting for a pool cluster to hibernate.
Bumped namespace loop to 30s.

I did a silly bug. Squashed.

/assign @abutcher

/lgtm


Propose structure for the documentation

[x] Make post for discussion - https://github.com/orgs/colab-at/discussions/4#discussion-4946130

[ ] Make post for discussion - https://github.com/orgs/colab-at/discussions/4#discussion-4946130


StationaryEnemy remains red after getting hit

Partial fix in 1ddf4a8
Doesn't remain red but won't be red at all.

Fixed 2a1034e (had to change few things to make slowmode work so ended up fixing that)


Maven dependencies incorrect

I had issues building the learning-spark-master Maven project due to missing artifacts. I fixed this by modifying the following dependencies (just adding "_2.10" to the end) to match what's in the Central Maven repository:
    <dependency> <!-- Spark dependency -->
      <groupId>org.apache.spark</groupId>
      <artifactId>spark-mllib_2.10</artifactId>
      <version>1.3.1</version>
    </dependency>
    <dependency> <!-- Cassandra -->
      <groupId>com.datastax.spark</groupId>
      <artifactId>spark-cassandra-connector_2.10</artifactId>
      <version>1.0.0-rc5</version>
    </dependency>
    <dependency> <!-- Cassandra -->
      <groupId>com.datastax.spark</groupId>
      <artifactId>spark-cassandra-connector-java_2.10</artifactId>
      <version>1.0.0-rc5</version>
    </dependency>

Thanks for the fix


appveyor: add cache of mingw download

As per discussion in #943
What appveyor now does in regard to installing mingw.

if in 386 GNU, checks if the mingw version specified in the environment var exists at the cached location
if it is not, it wipes the cached location if it exists, makes a new directory there and any necessary parent directories, and downloads the specified version of mingw
then the the extraction of binaries continues as normal, only referencing the archive in a different location now.

It is probably possible to extract, and then remove the archive, and just have the extracted directory be cached instead of the installer. That could be a possible future upgrade, but I'm not sure it would be worth the complexity cost.

I don't think we need to cache the extracted directory right now either.  If it turns out that it's too slow right now, we can always change it later.

Thanks a lot for this :)