elixir's setupHook causes compiler to emit warnings for all code

Describe the bug
The setupHook in elixir is causing all compilation of Elixir source files to emit warnings for files in Elixir's standard library. This only occurs when the compiler is being run inside of nix-shell, and does not occur when elixir is installed globally, eg. through environment.systemPackages in NixOS.
To Reproduce
Steps to reproduce the behavior:

Start a shell containing Elixir with nix-shell -p elixir
Run mix new test to generate a sample Elixir project
cd into the new test directory and run mix compile to compile the project.
Observe the large amount of warnings emitted, as shown here.

Expected behavior
The compiler should not emit the warnings it does, and simply output only the following:
Compiling 1 file (.ex)
Generated test app

Additional context
This issue seems to be caused by setting ERL_LIBS in Elixir's setupHook. Unsetting this environment variable while in the nix-shell does cause the compiler warnings to go away. I'm not sure what the purpose of setting this variable is, so I don't know if the solution is as simple as just removing the setupHook, or if there's a bit more nuance here.
This issue affects Elixir 1.8 - 1.10. Elixir 1.6 and 1.7 are not affected by this. Elixir 1.8 in particular emits absolute paths beginning with /build/source, which looks to me like a remnant of the build environment.
Notify maintainers
@the-kenny @Havvy @couchemar @ankhers @filalex77
Metadata

system: "x86_64-linux"
host os: Linux 5.6.2, NixOS, 20.09pre219796.f601ab37c2f (Nightingale)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.3
channels(root): "home-manager, nixos-20.09pre219796.f601ab37c2f"
channels(ruby): ""
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
  - elixir
  - elixir_1_10
  - elixir_1_9
  - elixir_1_8
# a list of nixos modules affected by the problem
module:

This issue was already mentioned here:

discourse.nixos.org: Elixir: compilation warnings only in nix-shell – ERL_LIBS
elixirforum.com: Compilation warnings (clause cannot match) in mix-and-otp tutorial
discourse.nixos.org: State of the BEAM Ecosystem in Nix

I personally for now set the needed ERL_LIBS manually for my environments:
with import <nixpkgs> {};
let
  elixir = pkgs.buildPackages.beam.packages.erlangR22.elixir_1_10;
  hex = pkgs.buildPackages.beam.packages.erlangR22.hex;
in
pkgs.mkShell {
  LANG = "C.UTF8";
  CLEANED_ERL_LIBS = "${hex}/lib/erlang/lib";
  buildInputs = [elixir hex];
  shellHook = ''
    export ERL_LIBS=$CLEANED_ERL_LIBS
  '';
}

So I'm not sure if setting ERL_LIBS is still really needed for Elixir.
@DianaOlympos
Did you find out something new about this topic?

I think ERL_LIBS is used to facilitate building Elixir apps/libraries through Nix, since (if I'm understanding the BEAM ecosystem in Nix correctly) each Mix dependency is intended to be built as an individual derivation, and provided through ERL_LIBS to work around Mix's network-dependent dependency fetching/resolving. Although, I don't see any scenario where having Elixir itself in ERL_LIBS would be useful.

no i have not dived into this one yet and tbh i will not have time until at best end of May.
Thanks for the exploration though. I would love for someone to try to understand that part though. Most of the stuff happening in there is still quite opaque to me tbh.

In my latest test, I have not observed the issue. If this is still an issue, please let me know and I can have a look

@happysalada Hi. I can still reproduce the issue described above.
ERL_LIBS is still set within the Elixir generic-builder causing the long duplicated list of compiler warnings.
https://github.com/NixOS/nixpkgs/blob/d10236eb20163b9a5871a45bada37886b2bc1d39/pkgs/development/interpreters/elixir/generic-builder.nix#L29
https://github.com/NixOS/nixpkgs/blob/d10236eb20163b9a5871a45bada37886b2bc1d39/pkgs/development/interpreters/elixir/setup-hook.sh#L1-L5
This means the following lands in ERL_LIBS:
ls -l /nix/store/4plz7d3nfl8hmlm568cgf91l0a4wj828-elixir-1.11.4/lib/elixir/lib

dr-xr-xr-x 3 main main 4.0K Jan  1  1970 eex
dr-xr-xr-x 3 main main 4.0K Jan  1  1970 elixir
dr-xr-xr-x 3 main main 4.0K Jan  1  1970 ex_unit
dr-xr-xr-x 3 main main 4.0K Jan  1  1970 iex
dr-xr-xr-x 3 main main 4.0K Jan  1  1970 logger
dr-xr-xr-x 3 main main 4.0K Jan  1  1970 mix

But if I unset ERL_LIBS I can still use e.g. iex within my nix-shell.
So this is still not clear to me, why this was added to the Elixir build script by @ericbmerritt?
Commit: https://github.com/NixOS/nixpkgs/commit/2d6d9682bb8a910f3eb5f0be8d5687c753e9732c

As I tried now to dig in deeper, a new guess of mine is, it will somehow affect the usage of escripts.
If you have a look at the mix escript.build - Configuration - :embed_elixir:
→ hexdocs.pm/mix/Mix.Tasks.Escript.Build.html#module-configuration
As we see :embed_elixir was from the beginning of Elixir v1.0 always set default to true,
it would probably not affect many if we remove setting ERL_LIBS within the Elixir generic-builder?
But as I still do not understand the real reason why it was added - I might be totally wrong!


Remove version: Google.Chrome.Canary version 128.0.6536.0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://dl.google.com/release2/chrome/jrca337tac2j5dubx5makbztoq_128.0.6536.0/128.0.6536.0_chrome_installer.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 912)


[Master] release/v1.0.2 QA Sign-off

This PR is automatically created by CI to release a new official version of caver-js-ext-kas.
When this PR is approved by QA team, a new version will be released.

caver-js-ext-kas v1.0.2 QA Result
Functional Test Result

KAS-ANCHOR
Total Test Cases 37 = PASS  37 + FAIL  0 + N/A  0
Newly Added Test Cases 0 = PASS  0 + FAIL  0 + N/A  0

KAS-TH
Total Test Cases 98 = PASS  98 + FAIL  0 + N/A  0
Newly Added Test Cases 0 = PASS  0 + FAIL  0 + N/A  0

KAS-WALLET
Total Test Cases 202 = PASS  202 + FAIL  0 + N/A  0
Newly Added Test Cases 34 = PASS  34 + FAIL  0 + N/A  0

KAS-ETC
Total Test Cases 8 = PASS  8 + FAIL  0 + N/A  0
Newly Added Test Cases 0 = PASS  0 + FAIL  0 + N/A  0

Integration Test Result

KAS-INT
Total Test Cases 232 = PASS  232 + FAIL  0 + N/A  0
Newly Added Test Cases 118 = PASS  118 + FAIL  0 + N/A  0


The value of the slider component is not updated

Trying to use a number input to update the slider component, but it's not possible.
Example of code:
app.layout = html.Div(
    [
        dmc.NumberInput(
            id="input_number",
            min=0,
            max=100
        ),
        dmc.Slider(
            id="slider",
            min=0,
            max=100
        )
    ],
)

@app.callback(
    Output("slider", "value"),
    Input("input_number", "value"),
)
def uptade_input_value(value):
    return value

@rmotadutra I don't see this problem in the latest master, so it should go away in the next release.


Do plugins need to know about hot reload and hot restart?

I think it would be an OK design choice if they didn't.  But it's probably better if they do.
If we need to add new API to teach plugins about hot-reload or hot-restart we might need to do that sooner rather than later.
FYI @mravn-google

Ians suggestion in https://github.com/flutter/engine/pull/3722#issuecomment-305572460 may be a way to handle hot restart.

I think this issue is related:
https://github.com/flutter/flutter/issues/30911
Does Hot Reload break the MethodChannel connection?

A plugin I'm working on does some cleanup in dispose() method. If hot restart does not call dispose() and there is not other way to get notified about hot restart then I'm going to be leaking resources. Please provide a way to cleanup my stuff during hot restart.

Not sure, but notifying plugins about hot-reload does not look much useful, since reload is supposed to hold the app state. However, hot-restart should be notified to clean up state and resources. Can hot-restart simply "detach" and then "attach" the plugins ? Since we already have APIs for that, wouldn't have to introduce new one.

Sorry @stuartmorgan my explaining of the problem was in response to @eseidelGoogle comment:

think the more concrete we can be about what effects we're seeking to fix (which ...

I'm not sure I agree with you on point 2 though, while it would be useful not to have this functionality duplicated across all plugins, its not just plugins, there is no reason why Flutter apps cannot be using FFI directly without a plugin and hence have the same need to be notified of when a hot-restart occurs.
But given the above, I think you are quite correct in that this is not what this issue is about, as its title is specifically referring to plugins, so I realise now that what I'm asking for is actually what is covered in the Dart issue rather than this one, so I'll move my further discussion there.

Also adding web event listeners
 html.document.addEventListener('visibilitychange', _webVisibilitychange);
Will add them again on hot restart, without any way of clearing them before!

That is a good point, @radvansky-tomas .
Only Android currently has an elegant solution where you can add a lifecycle listener to the engine on the platform side, and listen to when the engine is restarted. (Not perfectly elegant, though, since the method FlutterPluginBinding.getflutterEngine has been deprecated).
The solution is:
public void onAttachedToEngine(FlutterPluginBinding binding) {
    @SuppressWarnings("deprecation")
    FlutterEngine engine = getFlutterEngine();
    engine.addEngineLifecycleListener(new EngineLifecycleListener() {
        public void onPreEngineRestart() {
            // Do cleanup here. E.g. kill active audio players
        }
        public void onEngineWillDestroy() { ... }
    });
}

I think this is the type of solution we need on the other platforms.
There is a workaround demonstrated in the video_player plugin which is to initiate the cleanup from the dart side by implementing a cleanup method on the platform side of the plugin. If you call it from the Dart side during the isolate's startup, then it will be called on each hot restart - but also inconveniently on the very first engine load when there was in fact no hot restart.
Even accepting that caveat, a different approach will be needed on web, so we are better off having some sort of hot restart lifecycle listener on all platforms.

Its 2023 and still not fixed...

Is there any update on this? I am coming from this issue: bluefireteam/audioplayers #1120

Any update? I'm ending up with several websocket connections, window listeners, and so on... (web)

This is great. 6 years old issue and basically the only reaction from Flutter team is marking comments as "off-topic" when people urges that this issue should be taken care of. Way to go.

@marianhlavac Please take a moment to review https://github.com/flutter/flutter/wiki/Issue-hygiene#do-not-add-me-too-or-same-or-is-there-an-update-comments-to-bugs, https://github.com/flutter/flutter/wiki/Issue-hygiene#escalating-an-issue-that-has-the-wrong-priority, and https://github.com/flutter/flutter/blob/main/CODE_OF_CONDUCT.md

@stuartmorgan Thank you. I've also took a moment to read about the priorities, and then listed the current P0+P1 issues to learn that the priority rules seems to be applied inconsistently, so not sure what does this say about the rest of the guidelines. I went through the first few of P0+P1 supposedly 'more important' issues than this one (also many years old), and only maybe one or two had longer list of "mentioned in another issue" activity as in this issue, clearly showing there are many more desperate developers experiencing this issue. In combination with the age of this issue, I'm wondering why this issue is labeled as "not interesting" by having P2 priority.
But I don't want to transgress the guidelines any further, so I'll cease this discussion and I'm sorry for starting it. I hope the Flutter team will reconsider the severity of this issue.

Do plugins need to know about hot reload and hot restart?

Yes, ideally.
In flutter_blue_plus we disconnect all BLE devices after a hot restart.
https://github.com/boskokg/flutter_blue_plus/blob/c5fa0701a7e5756f2328adea1ec606ce0d0aa4b7/android/src/main/java/com/lib/flutter_blue_plus/FlutterBluePlusPlugin.java#L297
Currently we use a hack. We just assume it was a hot restart everytime Dart is reinitialized, even it it technically was a full app launch.
We could avoid this work if we knew the difference between Hot Restart vs App Launch.
But it is not a deal breaker. It works.

This would be great for my use case. I am using FFI to load in a shared library and it kicks off a long running thread when the flutter app starts and then in AppLifecycleListener.onExitRequested I stop that thread. But on hot restart, the thread doesn't stop and it tries to start a new one and "bad things happen". I have no real option but to quit and re run the app every time, which isn't ideal when hot restart is a feature.

This is currently causing me issue with the firebase database plugin. When doing a hot restart the connection is not destroyed so any onDisconnect triggers are not fired even though previously it would. Im not sure why there is such a back and forward debate here about if this is useful. Its clear that developers are asking for it. Its clear its needed and useful, even for app developers who need to know a hot restart has happened and reinitialise connections or other state.

The native state really need to be recycled when hot restart. Currently I can solve this by call initialize multi times, but this is not a good design. Since the recycle logic is not belong to initialize. We can't seperate initialize logic and recycle logic with this way. Please support this to make it easier when develope a plugin.

You can already do this:

create a initialize function and call it from dart every time the dart is reloaded
in native code, have a initializeCount that is incremented everytime initialize is called

if initializeCount is 0 it is a hot restart, if it is 1+ it is hot reload

“I badly needed this to turn off the blasted music and prevent it from being duplicated when hot restarted.


Allow reading tests from files

It's possible to read prerequest scripts from a file by prefixing it with file:. It would be great if that were possible for tests, too.
This configuration
  "tests": {
    "extendTests": [
      {
        "openApiOperation": "*::/*",
        "tests": [
          "file:portman/tests.js"
        ]
      }
    ]
  },

sets all tests to the literal value file:portman/tests.js.

+1
Actually could manage to include the feature by adding this to extendTest.ts (same as done in preRequest)
const scriptContents = extSetting.tests.map(tst => {
if (tst.startsWith('file:')) {
return getScriptContent(tst.replace('file:', ''))
} else {
return tst
}
})
Same behavior achieved
extendTest.txt

@vinh0604 Would you mind contributing again and adding support for the file: logic for the extendTests function?

or @jopucpla That would make sense, so if you are up for it, would you be interested in creating a PR for it?

@wedi @jopucpla A PR has been provided, so support for using file: for extendTest will land in the next release of Portman.

Portman 1.15.1 has just been released with the enhancement for "file:" inclusions for extendTest

Wow. That's a quick response. Thank you. ❤

Thank you ! :)


Integration of AdePT/Geant4 fast-sim based interface with the latest state of the art AdePT example

Closing as https://github.com/apt-sim/AdePT/pull/167 was merged two weeks ago. Not sure if we should change the milestone, this wasn't finished in October.


Fix function get_config_bytes

found error in switch, all cases returning same bytes-val

Thanks for your contribution @richlab .
The get_config_bytes function however is correct in its current form.
You can test it out yourself here (without the overflow fix):
https://repl.it/repls/ClientsideLoudPoints
This is due to the way PHP's switch statement works:
https://www.php.net/manual/en/control-structures.switch.php

It is important to understand how the switch statement is executed in order to avoid mistakes. The switch statement executes line by line (actually, statement by statement). In the beginning, no code is executed. Only when a case statement is found whose expression evaluates to a value that matches the value of the switch expression does PHP begin to execute the statements. PHP continues to execute the statements until the end of the switch block, or the first time it sees a break statement. If you don't write a break statement at the end of a case's statement list, PHP will go on executing the statements of the following case.


aoe: tiny: update command help to use loopback device

To use AoE locally like nbd or tcmu, it is necessary to use loopback device. ethN is able to be used by other hosts, but it would not be a common usage in trous.

It can go both ways; for local testing that's one thing, but if you have a SAN cluster, then listening on an external interface makes more sense.


Track performance impacts of built files

What
Monitor metrics to judge how our built files may affect performance of projects using govuk-frontend. This includes the files in dist as well as those inside package.
This should be as automated as we can to save us the time of gathering and comparing these metrics, but could be implemented progressively.
Why
While we do a diff of the files in dist before releasing, it'd be good to keep an eye on the size and contents of both dist and package, so we can spot  unexpected variations closer to when we make the changes.
Who needs to work on this
Developers
Who needs to review this
Developers
Tasks
Earlier discussion

[x] https://github.com/alphagov/govuk-frontend/issues/2076

Investigative spikes:

[x] https://github.com/alphagov/govuk-frontend/issues/3051
[x] https://github.com/alphagov/govuk-frontend/issues/3188

Implementation steps:

[ ] https://github.com/alphagov/govuk-frontend/issues/3280
[ ] https://github.com/alphagov/govuk-frontend/issues/3281
[ ] https://github.com/alphagov/govuk-frontend/issues/3282
[ ] https://github.com/alphagov/govuk-frontend/issues/3283
[ ] https://github.com/alphagov/govuk-frontend/issues/3284
[ ] https://github.com/alphagov/govuk-frontend/issues/3285
[ ] https://github.com/alphagov/govuk-frontend/issues/3286
[ ] https://github.com/alphagov/govuk-frontend/issues/3287

Moving this epic to the backlog so the individual tasks can come through the board.

Going to move this back to the Backlog for post v5 tasks


Enzyme does not render DOM tree of higher order components with mount

Version 2.7.1.
I have defined a higher-order component called persistChanges, and am using mount to test lifecycle calls around a mock object called WrappedComponent in a Node environment (i.e. without jsdom).
This is the code that's generating the issue, in a nutshell:
   const simpleComponent = mount(<WrappedComponent />);
   console.log(simpleComponent.debug())

   // correctly yields the expected DOM output:
   //  <WrappedComponent currentText="">
   //

   //      Default text to display when no data is available.
   //

   //  </WrappedComponent>

   const enhancedComponent = persistChanges(WrappedComponent);
   // enhancedComponent merely renders WrappedComponent
   const renderedComponent = mount(<enhancedComponent />);
   console.log(enhancedComponent.debug());
   // yields just <enhancedComponent />

Subsequent tests for children on enhancedComponent, including .find(), .children(), .text(), etc. all return empty. The tests in question (using Jest as the assertion library):
    // fails with count 0 for enhancedComponent, but passes with count 1 for WrappedComponent
    test('check length of children', () => {
      expect(renderedComponent.children().length)
      .toBe(1);
    });

    // fails with received response "" for enhancedComponent, but passes with WrappedComponent
    test('fires a request and receives no data from cache', () => {
      expect(renderedComponent.text())
      .toBe('Default text to display when no data is available.');
    });

The same tests pass for the WrappedComponent, even though enhancedComponent merely renders WrappedComponent. I can't find the div className='test' /> component in enhancedComponent, and, worse, .children() seems to think nothing is there.
This is the code for the HOC (with lifecycle methods removed - removing them did not alter this behaviour):
    function persistChanges(WrappedComponent) {
      return class extends React.Component {
        constructor(props) {
          super(props);
          this.state = {
            data: {},
          };
        }

        render() {
          return <WrappedComponent {...this.state.data} />;
        }
      };
    }

This is the WrappedComponent (also with lifecycle methods removed):
    class WrappedComponent extends React.Component {
      constructor(props) {
        super(props);
        this.state = {
          textToSave: 'This is the data we want to save',
          currentText: 'Default text to display when no data is available.',
        };
      }

      getDataToPersist() {
        return { currentText: this.state.textToSave };
      }

      render() {
        return (
{this.state.currentText}
);
      }
    }

I am fairly certain there must be something I am doing wrong, as support for HOCs with mount should be straightforward. I have scoured the documentation, and cannot find any similar resolved issue (everything with HOCs appears to be about usage with shallow, which I am not using).

(updated your OP to include triple backticks, so there's proper syntax highlighting)
When you say "correctly yields the expected DOM output:" but then it contains "", it seems like your expectations are off. debug doesn't contain DOM output, or else it wouldn't contain "WrappedComponent", which isn't a DOM element.
What does .html() look like?

Thanks!
With .html(), they look as so:
<enhancedcomponent></enhancedcomponent>

and for WrappedComponent

Default text to display when no data is available.

respectively.

Gotcha, that makes sense.
Any chance if you add a displayName to the persistChanges HOC that it changes things? Currently you're returning an anonymous class with no displayName.

It makes no difference.
function persistChanges(WrappedComponent) {
  const generatedComponent = class extends Component {
    constructor(props) {
      super(props);
      this.handleChange = this.handleChange.bind(this);
      this.state = {
        data: {currentText: 'I am a Baarbie girl'},
      };
    }

    render() {
      return <WrappedComponent {...this.state.data} />;
    }
  };
  generatedComponent.displayName = `foo`;
  return generatedComponent;
}

Thanks for confirming.
One more guess: components with a lowercased name are DOM elements; custom elements must start with an uppercase letter - ie, if you name it "EnhancedComponent", not "enhancedComponent", what happens?

That fixes it. I can't believe I overlooked that. Thank you!

I finally found a very good solution to get a wrapper from a decorated component. For shallowed components you can use dive() but there is no similar method for mounted components. This is the solution I did:
const wrapper = mount(shallow(<MyComponent />).get(0))

Works like a charm :)


Venkateshwarv/action builder

Action Builder widget to configure actions. Uses condition and condition block components from @cjaas-common-components

@futurethang  latest commit contains fix for stream API and token issue. This branch contains your changes from api-changes branch


Added tier visibility handling from portal settings

refs https://github.com/TryGhost/Team/issues/1387
This will allow us to move from the portal_products and portal_plans settings to using the visibility property on tiers to determine whether or not a tier should be visible in Portal. This updates admin to handle tier visibility property based on changes in settings. Old portal settings update is temporarily kept in though will not be used for determining visibility going forward. Also removes default product visibility being set on stripe connect.

Codecov Report

Merging #2295 (a17b86a) into main (8fe1eec) will decrease coverage by 0.10%.
The diff coverage is 7.31%.

@@            Coverage Diff             @@
##             main    #2295      +/-   ##
==========================================
- Coverage   41.21%   41.11%   -0.11%
==========================================
  Files         581      581
  Lines       22800    22822      +22
  Branches     4040     4042       +2
==========================================
- Hits         9398     9383      -15
- Misses      13402    13439      +37

Impacted Files
Coverage Δ

app/components/gh-launch-wizard/connect-stripe.js
2.45% <0.00%> (+0.05%)
:arrow_up:

app/components/gh-members-payments-setting.js
1.96% <0.00%> (+0.03%)
:arrow_up:

app/components/modal-portal-settings.js
0.97% <0.00%> (-0.14%)
:arrow_down:

app/services/members-utils.js
78.12% <75.00%> (+0.70%)
:arrow_up:

app/components/gh-html-iframe.js
45.45% <0.00%> (-38.64%)
:arrow_down:

app/helpers/gh-price-amount.js
70.00% <0.00%> (-20.00%)
:arrow_down:

app/components/gh-image-uploader.js
94.00% <0.00%> (-1.34%)
:arrow_down:

app/components/gh-file-uploader.js
93.84% <0.00%> (+2.30%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fe1eec...a17b86a. Read the comment docs.


Vision for datafusion-cli

Howdy,
I'm so pumped I found this project! Very excited to use more of it to improve the speed of my ETL pipelines. Thank you to the maintainers :)
Are there any resources for the vision of each component? Specifically it would be helpful to understand the vision for the datafusion-cli. In my head it feels like it would be natural to replicate as much psql functionality as possible but would like to understand your frame of mind as maintainers.
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Understand the vision of datafusion-cli so I can make useful contributions and improvements e.g. import from CSV and export to parquet via datafusion-cli
Describe the solution you'd like
Support for common psql commands like \copy, \d etc... instead of writing a custom rust program.
Describe alternatives you've considered

none

Additional context

none

Thanks for raising this issue and question @rupurt.
First off, I don't believe there's any centralized view on what datafusion-cli is or isn't, and there's no process yet to determine that. However I can share some of my thinkings here.
What datafusion-cli is not
Our ecosystem is full of different tools to manipulate data, each fitting its own niche purpose. In my opinion, datafusion-cli should not try to be yet another general-purpose tool to just manipulate data, especially since datafusion itself is intended to be an embeddable component for other tools (e.g. cube, ballista, roapi), to avoid confusion or reduce fragmented tech investment.
Specifically, datafusion-cli is not:

a general purpose Python enabled tool to query data, for that you'll have the Python binding for datafusion itself or polar for its speed and pandas compatibility, both leveraging Arrow and datafusion underneath
a command line tool to manipulate small, tabular or structured data, for that you'll have xsv, jq, or rq, depending on the file formats that one wants
a client to an HTTP or GraphQL enabled server backend, for that, you can have roapi or similar things, or in many cases Spark or Presto is just fine (when data size is large)

Also for 3. please note that (AFAIK) datafusion and datafusion-cli themselves do not concern with distributed computing, i.e. data sharding is something built on top of them - they can only do in-memory, uniformly accessible data manipulation.
What datafusion-cli can be
Given the above assertions, I believe the place where datafusion-cli can shine is:

the data size is large enough so that simple tools like jq or xsv can't cut it (within reasonable amount of time), but still small enough that can be fit into memory (EC2 machine has up to 12TB) - can you do care about the speed
when there's no need or necessity to keep a long running server or adopt full stack of Spark or Presto cluster due to their high maintenance cost

I think in many cases of ETL do you encounter these type of need for “glue” script that can just run with a simple shell script, either triggered manually, via Airflow, or crontab, etc. And it runs to the end, without any setup needed, takes in one or more parquet files, an SQL script, and spits out target data, either in JSON, CSV, or maybe Parquet.
It can also be a REPL, an interactive shell to quickly verify commands and look into data
Considerations on API
I think there are two aspects of API to this CLI:

the command line API (flags, options, naming, etc.)
the query syntax itself

For 2. it's clear that Postgres-compatible SQL is the choice here, but for 1. I don't think we are necessarily bound to the peculiarity of psql itself because:

it's in many cases specific to Postgres and the fact that it's a client-server architecture
psql is in many cases used interactively, but when it comes to shell automation, there are all sorts of other scripts in use, e.g. pg_ctl, pg_dumpall, etc. and here they all map to datafusion-cli

Having said that, I do think commands like \copy are already familiarised within users and nice to have, but I admit that in many cases I am still confused on the different flags and behaviors when that command is used interactively versus used as a CLI option. We need to be more consistent here, and just not necessarily consistent with psql itself.

I think we should PR @Jimexist 's well written comment into #1104 or add to the roadmap.md file after 1104 is merged :)


New Italian language

@Timthreetwelve
Please check and merge, Thanks.

Thank you @bovirus. Italian will be in the next release.


no such package

Hello,
Thank you for making this.
I tried using ' meteor add cloudinary' and got the result in the picture.
What's the best way to go about getting this package to install? Thanks.

Lol, you forgot to add my username. So the package install command would be meteor add lepozepo:cloudinary


Create nos

Thank you for contributing to Nokogiri! To help us prioritize, please take care to answer the questions below when you submit this pull request.
The Nokogiri core team work off of master, so please submit all PRs based on the master branch. We generally will cherry-pick relevant bug fixes onto the current release branch.
What problem is this PR intended to solve?
If there is an existing issue that describes this, feel free to simply link to that issue.
Otherwise, please provide enough context for the Nokogiri maintainers to understand your intent.
Have you included adequate test coverage?
We have a thorough test suite that allows us to create releases confidently and prevent accidental regressions. Any proposed change in behavior must be accompanied by tests.
If possible, please try to write the tests so that they communicate intent.
Does this change affect the C or the Java implementations?
If you're proposing a change to the C implementation, has the behavior change been made to the Java code as well? And vice versa?
If not, that may be OK, just please note it here.

:white_check_mark: Build nokogiri 1.0.606 completed (commit https://github.com/sparklemotion/nokogiri/commit/ad6fa26e5e by @inos123)

Hi, @inos123, it looks like you're playing around a bit with commits. Not sure I can help you in your learning process, but this certainly looks like you didn't intend for it to be a pull request. I'm closing.


crowdstrike plugin with multiple data sources

Description
Crowdstike is a leading vendor in cyber security. With such a wide customer base, integrating with Crowdstrike APIs will bring massive value to Fabric users.
This issue defines the requirements for 5 data sources.
Requirements
All data sources share the same configuration arguments:

client_id -- (required) string argument. Client ID for accessing CrowdStrike Falcon Platform
client_secret -- (required) string argument. Client Secret for accessing CrowdStrike Falcon Platform
member_cid -- (optional) string argument. Member CID for MSSP (for cases when OAuth2 authenticates multiple CIDs)
client_cloud -- (optional) string argument. Falcon cloud abbreviation (us-1, us-2, eu-1, us-gov-1, etc)

Docs bit for the creds:

Establishing and retrieving OAuth2 API credentials can be performed at https://falcon.crowdstrike.com/support/api-clients-and-keys

falcon_cspm_ioms data source
The data source fetches cloud indicators of misconfigurations (IOMs) from the Falcon security posture management (CSPM) feature.
Example code using CrowdStrike SDK -- https://github.com/crowdstrike/gofalcon/tree/v0.7.0/examples/falcon_cspm_ioms

configuration: no specific arguments; use generic API args
execution: no args

falcon_detection_details data source
The data source fetches detection details from Falcon API.
Example code using CrowdStrike SDK -- https://github.com/crowdstrike/gofalcon/tree/v0.7.0/examples/falcon_detection_details

configuration: no specific arguments; use generic API args
execution:

filter -- (optional) string argument. Host search expression using Falcon Query Language (FQL)

falcon_discover_host_details data source
The data source fetches host details from Falcon Discover Host API.
Example code using CrowdStrike SDK -- https://github.com/crowdstrike/gofalcon/tree/v0.7.0/examples/falcon_discover_host_details

configuration: no specific arguments; use generic API args
execution:

filter -- (optional) string argument. Host search expression using Falcon Query Language (FQL)

falcon_intel_indicators data source
The data source fetches intel indicators from Falcon API.
Example code using CrowdStrike SDK -- https://github.com/crowdstrike/gofalcon/tree/v0.7.0/examples/falcon_intel_indicators

configuration: no specific arguments; use generic API args
execution:

filter -- (required) string argument. Indicators filter expression using Falcon Query Language (FQL)
sort -- (optional) string argument. Indicators sort expression using Falcon Query Language (FQL)

falcon_vulnerabilities data source
The data source fetches environment vulnerabilities from Falcon Spotlight API.
Example code using CrowdStrike SDK -- https://github.com/crowdstrike/gofalcon/tree/v0.7.0/examples/falcon_vulnerabilities

configuration: no specific arguments; use generic API args
execution:

filter -- (required) string argument. Vulnerability search expression using Falcon Query Language (FQL)
sort -- (optional) string argument. Vulnerability sort expression using Falcon Query Language (FQL)

Additional Information

https://github.com/crowdstrike/gofalcon
https://developer.crowdstrike.com/docs/sdks/

@anasmuhmd one thing I missed here -- all data sources that return lists of items must support the size exec attribute to limit the number of queried items.


Add option to keep keepAttributableURLs

Hi @aslushnikov
would it be ok to add an option to keep the attributable URL? Thinking it could be good way to keep track of time spent for third party scripts.
Best
Peter

Oh +1! The attributableURLs are how https://github.com/patrickhulce/third-party-web gets all its data, making that easily verifiable and explorable by others would be 👌

@patrickhulce @soulgalore sure, we held off on exposing attributable URLs since we weren't sure if anybody needs them.
But since there are a few good usecases now... 👍

Left an inline comment

@soulgalore nvm, I updated PR - hope you don't mind


Segmentation fault during insert into Distributed/Replicated table

Version: <IP_ADDRESS>
I was transferring data from another Clickhouse cluster using
insert into graphite select * from remote('<IP_ADDRESS>', default.graphite);
Maybe there's a duplicate bug already, but I couldn't find it.
After about 90% the server I was executing the query on crashed with:
2019.05.09 17:54:29.175797 [ 124 ] {} <Error> BaseDaemon: ########################################
2019.05.09 17:54:29.182463 [ 124 ] {} <Error> BaseDaemon: (version <IP_ADDRESS>) (from thread 39) Received signal Segmentation fault (11).
2019.05.09 17:54:29.182548 [ 124 ] {} <Error> BaseDaemon: Address: 0xffffffea
2019.05.09 17:54:29.182585 [ 124 ] {} <Error> BaseDaemon: Access: read.
2019.05.09 17:54:29.182620 [ 124 ] {} <Error> BaseDaemon: Address not mapped to object.
2019.05.09 17:54:29.225987 [ 124 ] {} <Error> BaseDaemon: 0. clickhouse-server(std::basic_string<char, std::char_traits<char>, std::allocator<char> > std::operator+<char, std::char_traits<char>, std::allocator<char> >(char const*, std::basic_string<char, std::char_traits<
2019.05.09 17:54:29.226133 [ 124 ] {} <Error> BaseDaemon: 1. clickhouse-server() [0x2ea776d]
2019.05.09 17:54:29.226176 [ 124 ] {} <Error> BaseDaemon: 2. clickhouse-server(DB::StorageReplicatedMergeTree::clearOldPartsAndRemoveFromZK()+0x1e2) [0x5f80652]
2019.05.09 17:54:29.226212 [ 124 ] {} <Error> BaseDaemon: 3. clickhouse-server(DB::ReplicatedMergeTreeCleanupThread::iterate()+0x16) [0x607f966]
2019.05.09 17:54:29.226254 [ 124 ] {} <Error> BaseDaemon: 4. clickhouse-server(DB::ReplicatedMergeTreeCleanupThread::run()+0xcb) [0x607fbab]
2019.05.09 17:54:29.226299 [ 124 ] {} <Error> BaseDaemon: 5. clickhouse-server(DB::BackgroundSchedulePool::TaskInfo::execute()+0xe1) [0x6174951]
2019.05.09 17:54:29.226335 [ 124 ] {} <Error> BaseDaemon: 6. clickhouse-server(DB::BackgroundSchedulePool::threadFunction()+0x62) [0x6175022]
2019.05.09 17:54:29.226396 [ 124 ] {} <Error> BaseDaemon: 7. clickhouse-server() [0x6175084]
2019.05.09 17:54:29.226444 [ 124 ] {} <Error> BaseDaemon: 8. clickhouse-server(ThreadPoolImpl<std::thread>::worker(std::_List_iterator<std::thread>)+0x187) [0x66c7017]
2019.05.09 17:54:29.226478 [ 124 ] {} <Error> BaseDaemon: 9. clickhouse-server() [0x71f129f]
2019.05.09 17:54:29.226512 [ 124 ] {} <Error> BaseDaemon: 10. /lib64/libpthread.so.0(+0x7dd5) [0x7fcfa131fdd5]

Target table is distributed, under it there are 3 replicated shards.

If some more info on table structure & environment needed - please let me know.

Is it repeatable? Why did you build this by yourself?
Check what thread [ 39 ] wrote in the log before crash.
Try this
https://clickhouse-builds.s3.yandex.net/4884/ac8ceade2096781a30586fcba24ccb38553318bc/report.html

It would be really cool if you will be able to create a minimal verifiable example.
I.e. create table statements + some data (if needed) & needed config.

@den-crane I've seen this happen only once for now.
I've built it myself using Altinity RPM builder scripts to include fixes for stuff like this https://github.com/yandex/ClickHouse/pull/5127
@filimonov It's hard to verify because the table has around 30 billion rows and what exactly caused the crash is difficult to tell. But it's not some specific data for sure, because after the crash I've re-selected the data and it went fine.
The table structure is very simple, here it is with the server config: https://gist.github.com/blind-oracle/87230b1431fabbf4efe3ffaeebdb2e6e

Try to validate you build with this https://github.com/yandex/ClickHouse/issues/5197#issuecomment-489462448 .

Haven't seen it in recent versions. Let's close.


Only log error messages to the log referenced by index.html

The log referenced by index.html (by default, helm-chartmap.log) contains all INFO messages generated by com.melahn.until.helm.ChartMap) which is too much information.  A better choice might by ERROR.

Done


Adding DateSecondParameter to parameter.py (close #1775)

Description
Addition of parameter.DateSecondParameter and modification of all related unit tests.
I copied what was already done for DateHourParameter & DateMinuteParameter.
Motivation and Context
I have a need for a DatetimeParameter specified to the second.
Have you tested this? If so, how?
TravisCI checks.

This makes sense and is good to merge, but if you don't mind, could you share why you need this? Do you plan to use "every second" of it?

What I need is a single timestamp shared by all my tasks when I trigger a run, so that I can date the starting point of their chained execution.
Granularity to the minute is not enough, as several pipeline "builds" could happen over a single minute. But granularity to the second would suit me perfectly.

I left a mistake in the tests:
https://github.com/Lucas-C/luigi/blob/master/test/parameter_test.py#L546
I'm gonna fix it tomorrow.

Only the flake check fail now, and I don't understand why.
Is this ok for you to merge ?

I'll ask you to rebase your change once we've fixed the actual problem, that's supposedly when #1786 is merged.


Implement "Superbar" support

When right clicking Firefox or Steam or other applications, a special context menu with application-specific commands is seen. Being able to activate this from a program group inside of Program Manager II would be extremely useful and help workflows. More research needs to be done where the data for these actions is stored.

This is probably related: https://learn.microsoft.com/en-us/windows/win32/shell/taskbar-extensions

https://forensics.wiki/jump_lists#customdestinations

The CustomDestinations Jump List files are located in the user profile path:
Path: C:\Users\%USERNAME%\AppData\Roaming\Microsoft\Windows\Recent\CustomDestinations
Files: *.customDestinations-ms

https://inria.hal.science/hal-01988839/document

Each jump list file has a 16-digit hexadecimal number called
the AppID (application identifier) followed by an extension. The AppID
is computed by the Windows operating system using a CRC-64 checksum
based on the file path of the application. An application that is executed
from two different locations has two different AppIDs associated with the
application.

https://www.forensicfocus.com/articles/forensic-analysis-of-windows-7-jump-lists/
https://www.codeproject.com/Articles/36561/Windows-7-Goodies-in-C-Jump-Lists


Feature Request: Add article top function.

I want to add some top content to the blog, thank you very much!

Hi @A5yncX, I'm not sure what you mean by top function/content. An example, or a link would be great


Added shorturl

Added shorturl. Shorten URLs in chat with "//short "

I can take the core of this PR and implement it myself, but the PR itself has too many problems. I can't accept it without asking you to make so many changes that I would basically be re-writing it myself anyways. I'll still give you credit, though, since the original PR is yours.

Added in #d645784. Thanks for the PR!

Your welcome. Sorry I wasn't sure of your standards

Yeah, I understand, and we have almost no documentation for contributors, so it's understandable. I simply don't have the time to handle all that right now and set up a proper contributors document, as well as show you how to fix the command. This was the fastest and easiest way to handle this, sorry for kinda slashing your PR.


mplementing a torque sensor in myoElbowPose1D6MRandom-v0

Hi,
I want to implement a torque sensor to the elbow joint of the 'myoElbowPose1D6MRandom-v0' environment.
My problem is I am unable to find the code for this environment.
Thanks in advance!

Hi @MaximilianKinseher ,
the model used to build this task is the myoElbowPose1D which you can find at myosuite/simhive/myo_sim/elbow//myoelbow_1dof6muscles.xml
... do not forget to clone with recursive option: git clone --recursive https://github.com/facebookresearch/myosuite.git -- see here

Thank You @Vittorio-Caggiano,
If I edit this myosuite/simhive/myo_sim/elbow//myoelbow_1dof6muscles.xml file in my forked version of myosuite
and use !pip install git+https://github.com/MaximilianKinseher/myosuite in my colab notebook,
will my changes be implemente when I use env = gym.make('myoElbowPose1D6MRandom-v0')?
Or do I have to create a new environment in gym with my edited version of myosuite/simhive/myo_sim/elbow//myoelbow_1dof6muscles.xml?
Thanks in advance!


[Firebase] Handle notifyObservers and persist

Sync messages from notifyObservers and persist based on it.
Has to be different URLs in Firebase for each user.

Add functions for previous, also connected to #38:

[ ] addTracks
[ ] removeTrackPrev
[ ] setPrevName

Need to handle notifications.


Revert to datasource name

Description
revert to dtasource name until we find a proper fix
Risk
Deploy Plan
deploy front

What happened here? What's the state?


New permission model doesn't allow to create multiple groups containing the same Product Type

Bug description
When using the new permission model, it's not possible to create multiple groups containing the same Product Type.
Steps to reproduce
Steps to reproduce the behavior:

Go to '/group'
Click on New Group
Set a name, assign no global role and click Submit
In Product Type groups (under /group/group-number) click Add Product Types
Select a Product Type, assign it a Role and click Submit
Repeat the process from steps 1 to step 5 selecting the same Product type
See error (the product type is not added to the new group)

Expected behavior
A Product Type should be assigned to multiple groups in order to control the access within the Product Type using different profiles: pentester, administrator, auditor...
Deployment method (select with an X)

[X] Docker Compose
[ ] Kubernetes
[ ] GoDojo

Screenshots

Additional context (optional)
@StefanFl confirmed via Slack that the issue could be reproduced with his settings.

merged for release 2.5.0


Please upgrade your "istanbul" dependency version

Please upgrade your "istanbul" dependency version to at least 0.4.4 (currently set at 0.4.2), or else allow for a version range (e.g. 0.4.x, ~0.4.2, ^0.4.2, etc.) so that your wrapper can keep up with the underlying dependencies' non-breaking changes.

*ping*

pong. i fixed. this issue.


Review usage of distro module

IMO once #626 is completed the distro module becomes obsolete and is a candidate for removal from the project.

great


Documentation on LanguageClient lifecycle

I've been looking for documentation on LanguageClient, but can't find any either in the source or online (there's lots of information on the language server, but not so much about using LanguageClient in the extension. In particular I'm looking for documentation on when/if I should be calling stop or other lifecycle functions.
My motivation here is to properly handle the language server restarting. I run the extension which starts the language server (the Rust Language Server).  However, I'm not clear what happens to the language client or the extension itself - I don't know if there hooks where I'm meant to handle stopping the client.
What happens is that the new language server gets two of every message, so it seems like there are now two clients sending messages to the same server (and if I keep killing the language server, I get n+1 messages after n restarts). I assume this is because I'm not handling something in the extension, but it could be a bug in VSCode itself.

@nrc agree that there is not a lot of documentation for the client itself except the source code and some examples here: https://github.com/Microsoft/vscode-extension-samples
Regarding your questions: you need to call stop in the deactivate method of your extension to stop the client which stops the server. When a server crashes the client restarts the server. It will not create a new instance of the server. You can control this behavior using the LanguageClientOptions#errorHandler property. If you see problems with server restarts please file a GitHub issue here: https://github.com/Microsoft/vscode-languageserver-node

Thanks @dbaeumer, it sounds like there are not lifecycle things that I am missing and that there might be a bug in the client. I filed https://github.com/Microsoft/vscode-languageserver-node/issues/342


nspec.org broken examples.

I used nspec.org as a reference.
Since a couple of weeks some examples only show using NSpec; even the source code does not contain the actual code

pending

using NSpec;

On 16.04.18 the site looked correct.
http://web.archive.org/web/20160403115830/http://nspec.org/

Dammit, I think it's the /r/n differences in Mac vs Windows. I'll get this fixed asap.

Fixed it was an error in my gsub and regex


added info

https://github.com/MicrosoftDocs/windows-itpro-docs/issues/3012

@Justinha - Can you please assist to check, approve and merge the content for this PR based on issue #3012?
Thank you.

@VLG17 @mypil I think it's premature to submit a pull request in this case because our engineering team has requested time to consider this and other possible options before publishing anything. I think we should close this to prevent it from being inadvertently published without signoff. Let's watch the open issue for input from engineering. I've shared the issue with them.

@VLG17 @mypil I think it's premature to submit a pull request in this case because our engineering team has requested time to consider this and other possible options before publishing anything. I think we should close this to prevent it from being inadvertently published without signoff. Let's watch the open issue for input from engineering. I've shared the issue with them.

@Justinha ok, understood. I'll close this PR then and wait for feedback.


Fix minor documentation typos & errors

Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes.  But please read our contribution guide at least once, it will save you unnecessary review cycles!

[ ] Added tests for changed code.
[ ] Updated documentation for changed code.

No code changes, just documentation.

Thanks a lot!


Clickable vertical progress steps are not optimal

Some link pseudo element css is missing
To Reproduce
Steps to reproduce the behavior:

Go to 'https://design.swedbankpay.com/v/4.7.0/components/progress-steps'
Scroll down to 'clickable steps'
Add vertical-steps class to steps div
See error

Possible fix (this doesn't take into account any design guide variables)
.steps.steps-vertical {
    ol li>a:before {
        left: 1.7rem;
        top: 50%;
        margin-left: 0;
    }
}

Solved in https://github.com/SwedbankPay/design.swedbankpay.com/pull/339


fix(example): Add missing dependencies in example/package.json

Add two missing dependencies (nodemon and webauthn) in the  example/package.json
closes #7

Looks good to me. Thanks for the PR.


pollyjs config is undefined when reusing ember build and running ember test

Hello pollyjs contributors and devs,
I am not sure if this is a bug report or a question :)
TL;DR
pollyjs config from consuming ember app is not available inside the polly js addon methods, when reusing the build, which happens when running the command,
ember test --path <build folder name>
Description
I am using pollyjs/@ember package for my ember project, and it works just fine, when I run the tests using the command, ember test.
But when I try to reuse an existing build of my ember project(ember test --path <build folder name. by default, 'dist'>), I run into this error in command line:
Cannot read property 'enabled' of undefined

Stack Trace and Error Report: /var/folders/l3/zfkk52zd2qsdh8lbhdz6gy1r000lf7/T/error.dump.466e5463069e16ef55ccda6970db9a12.log

On further looking into the logs and debugging the ember node process, the error was happening in the testemMiddleware() method in the @pollyjs/ember/index.js file as show below:
testemMiddleware(app) {
    if (this._config.enabled) { // <== `this._config` is undefined here
      registerExpressAPI(app, this._config.server);
    }
  },

And the root cause seems to be that pollyjs this.app.options.pollyjs config defined and retrieved from the consuming ember app into the addon, is available only in the included() hook; but not available inside the other methods.
Error Message & Stack Trace
stack: TypeError: Cannot read property 'enabled' of undefined
    at Class.testemMiddleware (/Users/shsridha/workspace/srd-backstop/gryphon-fe/node_modules/@pollyjs/ember/index.js:45:22)
    at middlewares.forEach.middleware (/Users/shsridha/workspace/srd-backstop/gryphon-fe/node_modules/testem/lib/server/index.js:183:9)
    at Array.forEach (<anonymous>)
    at Server.injectMiddleware (/Users/shsridha/workspace/srd-backstop/gryphon-fe/node_modules/testem/lib/server/index.js:182:19)
    at Server.createExpress (/Users/shsridha/workspace/srd-backstop/gryphon-fe/node_modules/testem/lib/server/index.js:133:10)
    at Server.start (/Users/shsridha/workspace/srd-backstop/gryphon-fe/node_modules/testem/lib/server/index.js:41:10)
    at App.startServer (/Users/shsridha/workspace/srd-backstop/gryphon-fe/node_modules/testem/lib/app.js:231:24)
    at App.getServer (/Users/shsridha/workspace/srd-backstop/gryphon-fe/node_modules/testem/lib/app.js:235:17)
    at Bluebird.using (/Users/shsridha/workspace/srd-backstop/gryphon-fe/node_modules/testem/lib/app.js:74:38)
    at tryCatcher (/Users/shsridha/workspace/srd-backstop/gryphon-fe/node_modules/bluebird/js/release/util.js:16:23)
    at /Users/shsridha/workspace/srd-backstop/gryphon-fe/node_modules/bluebird/js/release/using.js:185:26
    at tryCatcher (/Users/shsridha/workspace/srd-backstop/gryphon-fe/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/Users/shsridha/workspace/srd-backstop/gryphon-fe/node_modules/bluebird/js/release/promise.js:517:31)
    at Promise._settlePromise (/Users/shsridha/workspace/srd-backstop/gryphon-fe/node_modules/bluebird/js/release/promise.js:574:18)
    at Promise._settlePromise0 (/Users/shsridha/workspace/srd-backstop/gryphon-fe/node_modules/bluebird/js/release/promise.js:619:10)
    at Promise._settlePromises (/Users/shsridha/workspace/srd-backstop/gryphon-fe/node_modules/bluebird/js/release/promise.js:699:18)
    at Promise._fulfill (/Users/shsridha/workspace/srd-backstop/gryphon-fe/node_modules/bluebird/js/release/promise.js:643:18)
    at PromiseArray._resolve (/Users/shsridha/workspace/srd-backstop/gryphon-fe/node_modules/bluebird/js/release/promise_array.js:126:19)
    at PromiseArray._promiseFulfilled (/Users/shsridha/workspace/srd-backstop/gryphon-fe/node_modules/bluebird/js/release/promise_array.js:144:14)
    at Promise._settlePromise (/Users/shsridha/workspace/srd-backstop/gryphon-fe/node_modules/bluebird/js/release/promise.js:579:26)
    at Promise._settlePromise0 (/Users/shsridha/workspace/srd-backstop/gryphon-fe/node_modules/bluebird/js/release/promise.js:619:10)
    at Promise._settlePromises (/Users/shsridha/workspace/srd-backstop/gryphon-fe/node_modules/bluebird/js/release/promise.js:699:18)

Config
Defined inside the ember-cli-build.js
pollyjs: {
      enabled: EmberApp.env() !== 'production',
      server: {
        expiresIn: null,
        keepUnusedRequests: false
      }
    },

Environment
Node.js v10.15.0
darwin 18.7.0
6.4.1
1.15.2

Interesting, I'd expect included() to be called.  Unsure if upstream bug or not.

I am not sure if this worked before in my ember project, since I have never tried reusing the ember build in the dist folder (by running ember test --path dist), until a few weeks back.
My project is using the latest version of @pollyjs/ember.

@jasonmit I've created a repo to demo the problem happening, and how it goes away after removing @pollyJs/ember. Hope that helps.
https://github.com/shankarsridhar/reuse-ember-build
^^ ember app uses yarn for dependency management.

On a side note, I ran into a similar issue with one of my addons (that provides custom ember commands), and I moved the config to environment.js instead of ember-cli-build.js in the consuming ember app.
After that, I was able to access the config passed on from the consuming ember app.

@shankarsridhar yeah I see no way around this other than moving the config options to config/environment.js or its own config module since the EmberApp isn't instantiated in the ember test --path flow.

Interesting, I'd expect included() to be called. Unsure if upstream bug or not.

Could be related - https://github.com/ember-cli/ember-cli/issues/8922 ?

Yup, looks related.  I can work around it but will wait to see how the above progresses first.  Thanks for linking the issues.

https://github.com/Netflix/pollyjs/pull/277 can you verify this resolves your issue?

#277 can you verify this resolves your issue?

oh cool. WIll take a shot at it later this weekend.

@jasonmit
How do I use the fix. Is it part of the latest release version yet ?
Perhaps a certain branch that I should the addon from ?

We have not yet versioned it but it's on master.
@offirgolan can you release the breaking change?

@shankarsridhar released under v3.0.0


Update CONTRIBUTING.md

Added periods to the ReadMe

Hey @Wangata ! Thank you for the corrections. But I'm sorry, it can't be counted for Hacktoberfest because it doesn't include the specified required contributions.

ok


fix: Added support for configuring minimum required tls version. Adde…

…d logs

:tada: This PR is included in version 1.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


globalOffsets is wrong for HTML Entity Recognition

Describe the bug
When labeling an HTML file using the HTML Entity Recognition template, the globalOffsets produced when exporting the result appear to be wrong.
To Reproduce

Take the following HTML and save it to a .html file

<!DOCTYPE html>

  <meta charset="UTF-8">
  <title>サンプル</title>

こんにちは！

これはサンプルです。

Import it into a HTML Entity Recognition project

Label some entities

Export the data in the "default" JSON format

Run the following Python code using the exported file

import json

with open("sample.html") as f:
    sample = f.read()

with open("exported_file.json") as f:
    data = json.load(f)

globalOffsets_start = data[0]["annotations"][0]["result"][0]["value"]["globalOffsets"][
    "start"
]
globalOffsets_end = data[0]["annotations"][0]["result"][0]["value"]["globalOffsets"][
    "end"
]

print(sample[globalOffsets_start: globalOffsets_end])

Expected behavior
What I'd expect to see:
こんにちは

What I actually get:
YPE ht

Screenshots

Environment (please complete the following information):

OS: macOS Monterey
Label Studio Version: 1.8.2.post1
Python: 3.11.4

Additional context
Considering minify did not change the results.
import htmlmin

minified_sample = htmlmin.minify(sample, remove_empty_space=True)

print(minified_sample[globalOffsets_start: globalOffsets_end])

reference issue: https://github.com/HumanSignal/label-studio/issues/2777

@sinchir0 Thanks for your bug report. I'm able to confirm this behavior and will file an issue with the engineering team.

same issue +1


focus-follows-mouse breaks goto_splits actions

Hello,
Congrats on public release.
Trying the terminal tonight on Linux, I noticed that if I set focus-follows-mouse = true, goto_split keybinds only flicker to the target split, and immediately return to the split my mouse is hovering.
In similar situations, all the tiling tools I know about behave in one of two ways:

Switch focus as requested but return to the hovered split as soon as the mouse moves.
Switch focus as requested, and keep it there until mouse crosses over a boundary.

It could also be left to the user to decide, as a config option.
There could also be a smarter way to deal with this that I don't know about, of course.
This is repeatable on Arch Linux with the extra/ghostty 1.0.0-2 package.
> ghostty --version
Ghostty 1.0.0-dev+0000000

Version
  - version: 1.0.0-dev+0000000
  - channel: tip
Build Config
  - Zig version: 0.13.0
  - build mode : builtin.OptimizeMode.ReleaseFast
  - app runtime: apprt.Runtime.gtk
  - font engine: font.main.Backend.fontconfig_freetype
  - renderer   : renderer.OpenGL
  - libxev     : main.Backend.io_uring
  - GTK version:
    build      : 4.16.7
    runtime    : 4.16.7
  - libadwaita : enabled
    build      : 1.6.2
    runtime    : 1.6.2

I haven't confirmed it but I can believe this on first read.
I've confirmed this is not an issue on macOS. I suspect this is GTK apprt specific.

Applying the suggested patch for #3345: https://github.com/ghostty-org/ghostty/issues/3345#issuecomment-2564651050 fixes this. I am thinking this is another symptom of setting the title creating a mouse motion event.


Proposal: New Form Validation Library for DSC Order Pages

Proposal: New Form Validation Library for DSC Order Pages
Use the react-hook-form library instead of Formik for handling form validation.
Estimated Completion Time: < 1 day
Motivation
Until last month, the Formik library had not receive any development since June 2021, and the updates it has received have been contributed mainly by a single developer. React-hook-form is still actively maintained by multiple developers.
React-hook-form has other advantages over Formik

0 dependencies
Performance

with Formik, every field in a form is rerendered when a single field is changed, which leads to noticeable slowdown in, for example, the Shipping Page.

Smaller package (about 1/3 the size)

Scope
Page

/order/checkout

Main Components

ShippingPage.tsx
PaymentPage.tsx

Background
---
title: Ordering Flow
---

flowchart TD

A[View Shopping Cart]
A1[With Items]
A2[No Items]
B[Checkout]
B1[Continue Shopping]
C[Shipping Information]
D[Payment Information]
E[Review Order]
F[Submit Order]

A --> A1
A --> A2
A1 --> B
A1 --> B1
A2 --> B1
B --> C
C --> D
D --> E
E --> F

The OrderForm component conditionally renders  ShippingPage / PaymentPage / SubmitPage.
OrderForm holds the formData state and passes setFormData to ShippingPage and PaymentPage.
ShippingPage and PaymentPage have form fields which are all validated currently using Formik.
When the continue button is clicked on ShippingPage or PaymentPage, if the fields are all valid, setFormData is called with the appropriate values.
After PaymentPage, OrderForm proceeds to SubmitPage, which receives formData.
Steps

In ShippingPage and PaymentPage, wrap the output in an html <form> element
In ShippingPage and PaymentPage, call the useForm hook to receive the handleSubmit function which is used to check if the forms are valid before the form is submitted.
Wrap an onSubmit callback with handleSubmit and pass it into <form>'s onSubmit prop.
Replace the Formik Provider component with react-hook-form's FormProvider.
Since ShippingPage and PaymentPage use children components that actually contain the form fields, the provider will allow the children components to get the appropriate methods with the useFormContext hook.
Pass the appropriate methods to the material-ui TextField components

Testing
From the dicty-stock-center repository, the many of the order flow components already have tests that can be resued but need to  be refactored to use vitest.

---
title: Ordering Flow
---

flowchart TD

A[View Shopping Cart]
A1[With Items]
A2[No Items]
B[Checkout]
B1[Continue Shopping]
C[Shipping Information]
D[Payment Information]
E[Review Order]
F[Submit Order]

A --> A1
A --> A2
A1 --> B
A1 --> B1
A2 --> B1
B --> C
C --> D
D --> E
E --> F

Add component wire diagram here....


Enhancement - Video pages do not link to one another - continuous watch requires multiple clicks

URL of pages that could use the change

https://git-scm.com/video/what-is-version-control2.
https://git-scm.com/video/what-is-git3.
https://git-scm.com/video/get-going

Problem
Going over the four videos in the page, after I finished watching each I needed to get back to the videos home page, and then click into the next video.
This can be made easier by simply adding a link to the next video page.
When a video finishes playing the Vimeo player does pop suggestions (See attached image) - but the following videos don't necessarily appear there, and aren't named or ordered

thanks for the suggestion @yotamcons ! you are totally right, it could be way more user friendly.
i don't think at this moment there's the concept of order in the videos, but maybe we can just hardcode the link to other video since this list is not updated for a long time.
would you be interested in contributing with a MR @yotamcons ?

Hi Pedro,
Could you contact me privately to understand what it would require? I'm not familiar with Ruby or web development (other than basic HTML)

hey @yotamcons ! sorry for taking some time.
so the page where the video listing is rendered is https://github.com/git/git-scm.com/blob/main/app/views/doc/videos.html.erb, and the page that renders each video is https://github.com/git/git-scm.com/blob/main/app/views/doc/watch.html.erb
looking at the way we link each video on the listing it seems we could hardcode something in the watch.html.erb view as well:
https://github.com/git/git-scm.com/blob/main/app/views/doc/videos.html.erb#L13-L19
my suggestion would be to start by setting up the project locally (see https://github.com/git/git-scm.com#setup), and then try to play with those 2 views to create some early version. feel free to ping if you need more guidance!

@pedrorijo91 Unfortunately this seems like to much learning I'll need to do for that, sorry i wouldn't be able to help


Storage failed to publish to vcpkg

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1183243&view=logs&j=3852a3f0-0201-5e58-cdca-c5862b5986a9&t=180ac29e-137b-5a29-bcba-efb3278292e2

Hi @danieljurek , can you please take a look?

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1183298&view=logs&j=5cf85578-dfa7-590f-0a30-32d2675fdd83&t=94cc6b13-ecb8-5a94-3aca-c87e8d1e407c

Hey @Jinming-Hu, in both cases I see that we succeeded in publishing to vcpkg -- https://github.com/microsoft/vcpkg/pull/21247
The step which comments on the bug is failing right now because of a regression in eng/common ... We're working on fixing that.

The release was successful, so removing blocking-release :)

Also, duplicate of https://github.com/Azure/azure-sdk-for-cpp/issues/3061
Closing.


client, add validateClient to ClientBuilder

fix https://github.com/Azure/autorest.java/issues/2719
code change mainly in ServiceClientBuilderTemplate.java
https://github.com/Azure/autorest.java/pull/2783/files#diff-011f78c981243301193df6b93ff9aa9373f5486e722793f3ded47bd5425fcbf8
example of generated ClientBuilder
https://github.com/weidongxu-microsoft/autorest.java/blob/client_dpg-validate-builder/typespec-tests/src/main/java/com/resiliency/servicedriven/ResiliencyServiceDrivenClientBuilder.java#L258-L279

Would like advice on where we invoke the validateBuilder().
Context: https://github.com/Azure/autorest.java/pull/2783#discussion_r1612764904
Basically, some variable like credential is on HttpPipeline, that should not be validated, if user provide their own HttpPipeline. And some variable like endpoint is not on HttpPipeline, that can always be validated when creating the client.
However, I don't want to make it more complex by providing a flag or 2 validate method (say validatePipelineParameter, validateNonPipelineParameter).
^^^
Updated to validateClient alone.
If dev need to do similar of validatePipeline for credential, they may do such
if (this.pipeline == null) {
  // validate credential
}

validateClient() looks good to me. Just think of below:

wonder is there any reason to remove validatePipeline()
Later, we could collect the use case of validating clients, e.g. validate non-null fields. Provide examples in our docs to recommend user how to write good validation.


please merge

just changed my username so updated .md with the new username

i  have only made this Sumyak_Jain.md  but now I have changed my github username so I have updated it

Hi @Sumyak-Jain, Pls resolve the conflicts.

resolved the issue which was found earlier
also please can you label my PR as "hacktoberfest-accepted" and merge

hi @stanly-johnson
resolved the issue which was found earlier
also please can you label my PR as "hacktoberfest-accepted" and merge

Will merge the new PR at #278
Closing this


Hi！：）, I want to have some problems with ACFA

i can't open param such as acparts、damage、stabilizer..........  Is it because of some technical limitations or because I didn't use the correct way to open these param？But anyway, bro, this project is really good.

i can't open param such as acparts、damage、stabilizer.......... Is it because of some technical limitations or because I didn't use the correct way to open these param？But anyway, bro, this project is really good.

AcParts and a few other files are actually not the same kind of params this editor can handle, I was planning on making an editor for AcParts but I never did, I did however add conversion support for AC4 and ACFA AcParts/Stabilizer to YabberExtended which you can also find in my projects. I may integrate support for that into WitchyBND later on.
You drag and drop AcParts.bin or Stabilizer.bin onto the YabberExtended exe, or use the right click menu, it will prompt you which game you are unpacking, AC4 or ACFA. The tool stores an XML to know what game to repack for and so on. You can also edit that XML to repack between games, but adding or removing parts is a real pain and requires more than just editing this.
The other files are dbp params as I call them, instead of using paramdef they use these dbp files to define them. They also only have one set of values unlike normal params which have entries. You will need ParamDbpEditor for now, its a bit of a messy tool, I added dbp file editing in it for no good reason really lol.
Sorry I didn't see this message sooner, I'm more active in the FromSoftware modding server called "?ServerName?" and the AC server on discord.

Some files are really weird and aren't def params, dbp params, or an AcParts kind of file. PartsRegulation.bin for example is always just a couple hundred null bytes, so it seemingly does nothing. Most of the other weird files are in game files only and not per regulation, like MissionReward which determines how things such as designs are awarded. You can also find tons more params only in game files and not per regulation, those are in boot.bnd generally.


Support large number of anonymous participants

Right now, people can only generate up to 1000 anonymous participants at a time, and the process time is longer as the number of accounts generated raise, (40 minutes for 10000+ accounts.)
Generating anonymous account is introduced at #23, the process time is expected to be long, this is why we introduced background process and parallel generating at #40, #49, and #51 .
A new requirement of 20000 or more anonymous account is needed while lower processing time is desired.
We need to revisit this functionality.
A few question should be asked:

What is the difference between generated-account and user-created-account without using personal information? Email is required, yes; but we can also support username, (why are we using email over username?)
Kan there be other ways generating anonymous account? (also, should we provided some information when generating them, e.g. studyname-account001, it will be useful when debugging errors in keycloak, use participantId/accountId for username is confusing )

We tested generating 1500 accounts, the last single account generated used 120 seconds, 40 seconds was used for saving the jsonb snapshot using Spring default repository save, converting webservices datatype to core datatype.
The main reason is we are saving it as a JsonNode datatype and a json object is build and validated with each interaction with RecruitmentSnapshot, the time growth is non-linear as the size of snapshot increase (which is the number of deployments).
possible approach:

write our own SQL scripts with less validation. (Spring default will use merge method to compare existing data with the new data, it takes a lot of time for huge json data).
save it as a string and handle datatype conversion using other method (use core serializer, this is something WIP, but still buggy)

Fixed #139


Changed events for IModelProps.

See NextVersion.md for details.

@pmconne Really weird; uncanningly so. I was just, at the moment, looking at the backend portion for setting the GCS from the frontend. I was dreading tackling the frontend portion which I know little about. In the backend the current UpdateIModelProps() updates ECEF location, project extent but not the GCS. Will the UPdateIModelProps() be called as a result of the onGeographicCoordinateSystemChanged event? Or have you planed other changes that would decouple or couple more tightly  GCS changes from ECEFLocation change and project extent change?

@AlainRobertAtBentley if you are talking about JsInterop::UpdateIModelProps(), I see it ignores the geographicCoordinateSystem supplied to it. I had no plans to change it as I was not aware of this problem.


Parsing fails with NullPointerException

Hi Kim, I have a very strange problem here with:
zprint <<< '(is (= #::sut{:groups #{"FOO_ADMIN" "FOO_USER"}}
         (sut/map->user {:groups ["FOO_USER" "FOO_ADMIN"]})))'
(is (= #::sut{:groups #{"FOO_ADMIN" "FOO_USER"}}
         (sut/map->user {:groups ["FOO_USER" "FOO_ADMIN"]})))
Failed to zprint: java.lang.NullPointerException

Now if I remove the #::sut everything is good:
zprint <<< '(is (= {:groups #{"FOO_ADMIN" "FOO_USER"}}
         (sut/map->user {:groups ["FOO_USER" "FOO_ADMIN"]})))'

But:
zprint <<< '#::sut{:groups #{"ADMIN" "USER"}}'
#::sut{:groups #{"ADMIN" "USER"}}

Therefore I am not sure it is the namespaced map syntax that's breaking there.
I have a workaround - not to use that syntax solves it in some place but I thought I should report it :smile:
Thanks as usual for your hard work on zprint!

Thanks for noticing this!  Namespaced map syntax does not play well with the currently shipping version of rewrite-clj, but the new version (V1) by @lread has fixed this, so it will work in the next zprint release: 1.2.0. Assuming that I work up the ... to release zprint with an alpha version of rewrite-clj V1.  But it runs all 1200+ zprint tests, so why not?

Go for it! 🙂
I don't expect issues to be caused by rewrite-clj v1, but if we find some, I'll be happy address them.

This is now fixed by 1.2.0, which includes rewrite-clj V1!


V2.1 email refactor

Related to : https://github.com/foam-framework/foam2/pull/1945
Description:
EmailsUtility.java is the default class that is the developers class to call. Examples of this usage are in the files listed under Code Change.
The EmailsUtility then after processing all the properties - passes the emailMessage through to the email pipeline.
Email Pipeline begins with the emailMessageDAO(service) which has two responsibilities(EmailServiceDAO.js). One it stores the emailMessage in a journal and two it passes the emailMessage to the next service in the pipeline.
The second service after emailMessageDAO is the email(service). This default service in FOAM is the NullEmailService, and in nanopay is the SMTPEmailService.
List of File Changes :
Refactored Architect changes:
-src/foam/nanos/notification/email/EmailServiceDAO.js :  Decorator on emailMessage(service) that passes the emailMessage(eM) to the emailService and stores eM into journal.
-src/foam/nanos/notification/email/DAOEmailService.js : removed
-src/foam/nanos/notification/email/EmailService.js : simplified to only have one method
-src/foam/nanos/notification/email/EmailTemplate.js : added functions to handle setting default properties to an emailMessage
-src/foam/util/email/EmailsUtility.java : the static utility functions that are needed for the population of properties and error checking prior a put into the email service.
-src/foam/nanos/app/EmailConfig : adding default properties for emails.
-src/foam/nanos/notification/email/SMTPEmailService.js : clean up to handle only the mimeMessage and transport of emailMessage
-src/foam/nanos/notification/email/NullEmailService.js : since extends EmailService, needed to be simplified to one method override.
-src/foam/nanos/notification/email/services.jrl
-tools/classes.js
Code Change: Changes to email service calls based on above file refactor
-src/foam/nanos/auth/email/EmailDocService.js
-src/foam/nanos/auth/email/EmailTokenService.js
-src/foam/nanos/auth/resetPassword/ResetPasswordTokenService.js
-src/foam/nanos/notification/SendEmailNotificationDAO.java
Clean UP: Changes to email service calls based on above file refactor
-src/foam/nanos/auth/email/EmailVerificationWebAgent.java
-src/foam/nanos/auth/twofactor/GoogleTOTPAuthService.js : changes to account for the SMTPEmailService not existing on default.
-src/foam/nanos/notification/email/scripts.jrl

Just finished adding emailPropertyService(service) which is called from intended convenience function in EmailsUtility.java
emailPropertyService has the purpose of abstracting out the setting of email properties based on order of precedence.
This works by storing an EmailPropertyService[] on ChainedPropertyService.
EmailPropertyService[] =
{
new ApplyEmailTemplateService(),
new GroupEmailTemplateService(),
new DefaultPropertyEmailTemplateService()
}

Things that are remaining:

need to adjust the SMTP enabled feature. Current idea is to adjust this in build scripts. Currently this is set to true in the accompanying nanopay PR, that overrides the emailService in (service)email from NullEmailService to SMTPEmailService.

the from property that is being passed from EmailMessage to MimeMessage in the SMTPEmailService is not getting set. What is getting displayed is the username that we are using to authenticate our email. Only thing I found, after much testing and reading was this : https://coderanch.com/t/433494/java/Sending-mails-address

which basically says we cannot change it. Although previously we were setting it. No idea when this happened or why.

Things that remain: (cont)
3. Need to store which emails were actually sent and which have failed. Currently we store the emails before the email gets sent. Perhaps we should just reverse the code call on this?

Removed the try catch, because a valid error is thrown that stops the email sending, but nothing else. However reviewer please confirm this:

Test:

result:

https://nanopay.atlassian.net/browse/CPF-1248
https://nanopay.atlassian.net/browse/CPF-1290
https://nanopay.atlassian.net/browse/CPF-1237
https://nanopay.atlassian.net/browse/CPF-1224
https://nanopay.atlassian.net/browse/CPF-1208


45570 Generate, retrieve & store a key: AES & PBKDF2

What:
Add classes to apply AES to a NSData and generate a key with PBKDF2.
Why:
This PR is part of a bigger development to provide a mechanism to generate a key and safely store it.
How:
These classes are essentially a wrapper around the methods offered by Security framework.
Tests:
Only to be sure that we get what we expect, using some hardcoded values we check that the results we get are as expected.
reviewer @mikerhodes
reviewer @rhyshort

General comment, they are all missing Cloudant/IBM copyright eg Copyright IBM Inc. 2015 See some of the other files for the exact wording

Added copyright to new classes in cdda2a8

Okay I think we are good now. +1.

looks fine to me +1


Go: Reset connection when it's returned to a pool

Go has a pool of connections.
We need to reset baton in the connection every time it's returned to the pool.
Otherwise, user gets STREAM EXPIRED errors a lot.
This depends on https://github.com/tursodatabase/libsql/pull/1099

@penberg @LucioFranco I'm changing public API in
Make all methods of Conn trait async`
Is this ok with you? I hope it does not break other SDKs


Opt out of nextjs telemetry

Fixes https://github.com/rootzoll/raspiblitz/issues/2620
Recreation of https://github.com/rootzoll/raspiblitz/pull/2628 but based on dev branch

ACK 4db1bbd


Rework behaviour that a User is created if motions are forwarded

Currently:
If a motion is forwarded then a new User is created.
The surname of this user is the committee name -it was forwarded from- and the username is the committee name without spaces.
The User is a new participant in the meeting the motion was forwarded to and the user is assigned as a submitter in the forwarded motion.
To discuss behaviour:
Should the action to forward a motion maybe not create a new (inactive and no natural person) User who is then assigned as a submitter
But maybe the action to forward a motion should assign the Committee name as the extension for the submitter.
This would prevent a new automatically created (and very likely unused) account.
If the committee name is assigned in the extension-field then the name is still displayed everywhere the submitters are displayed.
This would also align the automatic forwarding behaviour with new feature described in #3429

This feature should be incorporated together with https://github.com/OpenSlides/openslides-client/issues/3527


Provider version 0.9.0 terraform version 1.2.8

Description of your changes
Adds support for Terraform provider 1.2.8 and Spectrocloud Palette Provider 0.9.0
Fixes #
I have:

[X] Read and followed Crossplane's [contribution process].
[X] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
Tested Build
[contribution process]: https://git.io/fj2m9

Updated and errors cleared.


reflections support jakarta

Hi ,tomcat10 change javax.* namespace to jakarta.，which reflections  version now support jakarta? reflections-0.10.2 is used javax.servlet

which reflections version support spring bot 3.0


[BUG] Pasting markup string strips markup

Has this bug been raised before?

[X] I have checked "open" AND "closed" issues and this is not a duplicate

Description
When pasting a html string with format e.g. "This is a bold string" renders a stripped string with no bold mark.
Steps to Reproduce

Copy a rendered html string such as "This is a bold string"
Paste in
The string will be rendered without a bold tag.

Environment

OS:
Browser:

Screenshots
No response
Do you want to work on this issue?
No
If "yes" to above, please explain how you would technically implement this
No response

Fixed in v4.6.0
Examples - https://yoopta.dev/examples/withExports


Convert aten.where.self to ttnn.where

Ticket
Involving #64
Problem description
Convert aten.where.self to ttnn.where
What's changed

[x] Convert aten.where.self to ttnn.where
[x] Test the conversion

[x] Mark broadcasting failure with #64

Running tests here
https://github.com/tenstorrent/pytorch2.0_ttnn/actions/runs/10786415215


Fixes for issues flagged in #236

Fixes #236
Test URLs:

Original: https://www.sunstar.com/careers
Before: https://main--sunstar--hlxsites.hlx.live/careers
After: https://issue-236--sunstar--hlxsites.hlx.live/careers

I checked the visual differences and they are minimal, and expected given that some of the changes here are to items used in various places.


Benchmark works on Windows only

Benchmark works on Windows only (include windows.h).
Can you make it work on Linux too?

Sorry, don't have the time!


Create database as a step of migration.

Is exists any way to run migration with not specify database parameter inknexfile.js? I want to create many databases as a step of migration and then load schema using withSchema but don't know how to do it. All examples use single database as schema builder target.

＋1

@mbury there is always some database that you connect (at least in postgresql), even when you connect to server to create more databases.
So you should connect to e.g. db called template1 or postgres for the behavior that you are talking about. I suggest that you create one master db for your app to which you always connect initially.


[REQUEST] Finish module tooltips

The module tooltips must all be set so, when they need to be added to the game, the programmers can grab them from the wiki and add them immediately.
All module tool tips must be finished, even if the module does not end up being implemented for use within the game.

All tooltips now available on Github Wiki under Module Tooltips


Do not generate unique __Field for each struct

As suggested in https://github.com/serde-rs/serde/pull/2250#pullrequestreview-1564212707, this PR replaces __Field generation with common structs inside serde crate.
There are three different forms of a __Field struct, each one has its own struct:

Field + FieldSeed -- for structs without flatten fields and without #[serde(deny_unknown_fields)]
FieldStrong + FieldStrongSeed -- for structs without flatten fields and with #[serde(deny_unknown_fields)]
FieldFlatten + FieldFlattenSeed -- for structs with flatten fields

Hm... I don't understand why build is failed. Everything is OK when run cargo build inside the root directory, but mysteriously failed when run from ./serde sub-directory. I don't understand why __private module cannot be found? It is not exist when no_serde_derive is specified, but that should happens only on Rust < 1.56 and I try to build on Rust 1.72

Here is some results: comparison.zip.
Measured commits v1.0.183 (05a5b7e3c6de502d45597cbc083f28bc1d4f4626) and df12e82af225d6de9af8ae54d6a290a380211f31, which removes all possible variants of __Field for struct field names and __Field for representing variants of externally tagged enums.
In both cases serde was injected using [patch] section in root Cargo.toml of both projects:
[patch.crates-io]
serde = { path = "../serde/serde" }

The following commands was used:

json-benchmark:cargo clean
$env:CARGO_INCREMENTAL=0; cargo check --timings --no-default-features --features all-files,parse-struct,lib-serde
cargo clean
$env:CARGO_INCREMENTAL=0; cargo build --timings --release --no-default-features --features all-files,parse-struct,lib-serde

PR is about 0.3 sec. faster on checking / building of json-benchmark lib itself. native jemalloc library was not found on my machine, so I cannot provide runtime impact right now
lsp-types:cargo clean
$env:CARGO_INCREMENTAL=0; cargo check --timings
cargo clean
$env:CARGO_INCREMENTAL=0; cargo build --timings

PR is about 3 sec. faster on checking / building of lsp-types itself

@nnethercote perhaps you are willing to test impact of this PR on your cases?


install ruby gem dependencies

Updates the controller to insert an init container for Ruby runtimes
when a Gemfile is provided. Bundler is set to install gems in the shared
volume and GEM_HOME is set in the container to load the gems from this
volume.

we can merge, but like the other PR about ruby runtime we need to have tests

is one of the example making use of this now ?

@sebgoa @ngtuna rebased and added an example and test

/lgtm
@ngtuna merge when you want

@prydonius @sebgoa Thanks. I want to hold this a bit until the PR #291 get landed. I don't want to see too many red-crosses on the master branch. I am working with @prydonius to fix it asap.

@prydonius Rebase this one as well. The PR #291 has landed already

rebased and squashed :)

Thanks @prydonius . I am landing it 🛬


en: update config-overview.md for 2.0

What is changed, added or deleted? (Required)
update config-overview.md for 2.0
Which TiDB Data Migration (DM) version(s) do your changes apply to? (Required)

[x] master (the latest development version, including v2.0 changes for now)
[ ] v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

This PR is translated from: https://github.com/pingcap/docs-dm/pull/29
Other reference link(s):

@GMHDBJD PTAL. Thanks~

LGTM


Consolidates use of OpenSearch clients and some related clean-up

Description
The opensearch sink project has changed quite a bit and there are still some old Gradle configurations here. This PR removes these.
This also consolidates the dependencies and versions for the OpenSearch clients into the Gradle version catalog.
Issues Resolved
N/A
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I'm applying the backport 2.2 label to hopefully avoid future conflicts for version updates.


Tips on improving partial results

Hello,
I would like to know if there are tips to improve our results on this model.

I have followed the steps as we discussed yesterday in #12 but using the partial checkpoint since our data is incomplete.

I would like to know if this is the best we can do without training.  I know that trimming isn't performed due to numerical instability as discussed in a previous issue.
Also note that I was not able to perform geometric_refinement.
cedric@BOKCHOY:~/Programming/complexgen$ python scripts/geometric_refine.py
00953239_0_extraction.complex
corner: 27 curve: 45 patch: 21
patch close: 0
patch close: 1
patch close: 0
patch close: 0
id: 3 flip uv: 0
patch close: 0
patch close: 0
patch close: 0
patch close: 0
patch close: 0
patch close: 0
patch close: 0
patch close: 1
patch close: 1
patch close: 0
patch close: 0
patch close: 0
patch close: 1
patch close: 0
id: 17 flip uv: 0
patch close: 0
patch close: 1
patch close: 0
terminate called after throwing an instance of 'std::runtime_error'
  what():  PLY parser: Could not open file data/partial/test_point_clouds/00953239_0_10000.ply
Aborted (core dumped)

So I just skipped this step. (I made very sure I performed test_partial.sh and then extraction_partial.sh). I had fixed this error by downloading the .ply from the OneDrive but they
are not available for the partial/ folder.
I have attached our original .ply, the pointcloud inside of a .pkl and the results in a .zip
to_complexgen.zip

Without geometric refinement, your result seems normal. You can conduct geometric refinement by replacing the path  "data/partial/test_point_clouds/00953239_0_10000.ply" with your point cloud.

Ok thanks! After converting my pointcloud to ply and placing it there I was able to get these slightly better results. Thank you


[SYSTEMML-1282] Remove avro from bin and standalone jar artifacts

Remove avro libraries from -bin.tgz, -bin.zip, and -standalone.jar
artifacts to simplify project build dependency management and
reduce artifact size. Update corresponding LICENSE files.

Note that it can be difficult to track down whether dependencies such as these are required or not. If these dependencies are indeed needed, most likely NoClassDefFoundErrors will occur under certain situations.

I am going to go ahead and merge this PR since it can be difficult to hit the correct situations where dependencies such as these are needed. This way, the standalone jar and bin artifacts can be tested for a significant amount of time before the 1.0.0 release to see if these artifacts require these dependencies.


Fix AST classes generation from lionweb language.

AST generation changes that check whether a class should be open and also fixes a bug when trying to refer to other generated class.

Thank you @AtanasM98 !


[Bug] Floss runs for hours on some binaries

Floss Version Tried: 2.2.0 and 2.0.0
Platform: Ubuntu 21.04, Windows 10 and Windows 11
Example reference file: https://www.virustotal.com/gui/file/9cc387fd485e91fc58a626d2c64b85e0502ba60f3718afd7b5fd6e5b46721bb9
On the above file, floss runs for hours when you floss.exe -n 7 file_path  --no-decoded-strings. However, it finishes within seconds when run with  --no-stack-strings --no-decoded-strings . It appears this is likely a bug within vivisect or how floss interacts with vivisect.
Output when it is stuck:

INFO:floss:Generating vivisect workspace...
WARNING:vtrace.platforms.win32:LoadLibrary PATH\vtrace\platforms\windll\amd64\symsrv.dll: Failed to load dynlib/dll
'PATH\\vtrace\\platforms\\windll\\amd64\\symsrv.dll'. Most probably this dynlib/dll was not found when the application was frozen.
WARNING:vtrace.platforms.win32:LoadLibrary
PATH\vtrace\platforms\windll\amd64\dbghelp.dll: Failed to load dynlib/dll
'PATH\\vtrace\\platforms\\windll\\amd64\\dbghelp.dll'. Most probably this dynlib/dll was not found when the application was frozen.

Basic File Meta:
MD5	f7de7d878835793ae439c5e551597b1e
SHA-1	f72c37925fe9022214395a90258449aec0a3c0ed
SHA-256	9cc387fd485e91fc58a626d2c64b85e0502ba60f3718afd7b5fd6e5b46721bb9
Vhash	[01703e0f7d60101011z11z47z1015z13z1fz](https://www.virustotal.com/gui/search/vhash%253A01703e0f7d60101011z11z47z1015z13z1fz)
Authentihash	[d7a5d26ede1f10837aaff7925aafb4b73c272bd416da313d8a37536006cf7b75](https://www.virustotal.com/gui/search/authentihash%253Ad7a5d26ede1f10837aaff7925aafb4b73c272bd416da313d8a37536006cf7b75)
Imphash	[38c0cbb9bf97b36d1b93444db348f0cf](https://www.virustotal.com/gui/search/imphash%253A38c0cbb9bf97b36d1b93444db348f0cf)

The analysis is slow and may be similar to #743 (sample is also packed).
If you disable all modes that require vivisect (--no decoded stack tight) no code analysis is performed and only static strings are extracted - which is fast. Can you please confirm the options or are really seeing this with your above provided arguments?

If you disable all modes that require vivisect (--no decoded stack tight) no code analysis is performed and only static strings are extracted - which is fast. Can you please confirm the options or are really seeing this with your above provided arguments?
Yes it runs relatively fast < 3 seconds, and yes these are themida packed binaries.
Looking at https://github.com/mandiant/flare-floss/issues/743: Yes these are definitely vivisect problems. I'll investigate another approach for the stack strings in these scenario. Thank you @mr-tz.


[zabbix-community/zabbix] Add support for custom labels

Is your feature request related to a problem? Please describe.
We're trying to setup this chart on an AKS cluster using the secrets-store CSI. Besides needing a label on the SA we also need a label on the pod to be able to use this driver.
It would be nice if we could add custom labels to stuff like pod, sa, services etc.
Is your feature request related to a problem? Please describe.
See above
Describe the solution you'd like
Cert-manager for example has podLabels and serviceAccount.labels which gets applied to the SA and Pods it creates.
There is also a commonLabels option.
It would be nice to have something like that here as well, but perhaps (also) a way to specify this for specific resources (e.g. only zabbix-server pod)
Describe alternatives you've considered
Additional context
Related issue: #70

Hi @syphernl!
Thanks for your colaboration.
I understood your necessity.
I will implement this feature until next week.