tekton pipeline git resource should init and update submodules recursively.

Expected Behavior
Suppose we have a git pipeline resource as described in the doc:
https://github.com/tektoncd/pipeline/blob/master/docs/resources.md#git-resource
apiVersion: tekton.dev/v1alpha1
kind: PipelineResource
metadata:
  name: wizzbang-git
  namespace: default
spec:
  type: git
  params:
    - name: url
      value: https://github.com/wizzbangcorp/wizzbang.git
    - name: revision
      value: master

Suppose that https://github.com/wizzbangcorp/wizzbang.git has .gitmodules with one or more git submodules.
When the git resource is cloned, the behavior should be equivalent to this:
git init <dir>
cd <dir>
git remote add origin <remote url>
git fetch --depth=1 --recurse-submodules=yes origin <revision>
git submodule init
git submodule update --recursive

where <remote url> would be https://github.com/wizzbangcorp/wizzbang.git
Actual Behavior
Based on the latest commit of pkg/git/git.go here: https://github.com/tektoncd/pipeline/blob/ea94852c3aa046d9c898cd63eabc3440a4bf63b3/pkg/git/git.go#L47
This is equivalent to the following:
git init <dir>
cd <dir>
git remote add origin <remote url>
git fetch --depth=1 --recurse-submodules=yes origin <revision>

In other words, the submodules have not been initialized nor updated recursively.
Steps to Reproduce the Problem

Execute a pipeline or task run that depends on submodule resources.

Additional Info

I was debating whether to submit a PR for a simple fix to this.
There are two ways to address this issue:

Change the behavior of the git resource such that it always performs git submodule update --init --recursive

Add to the documentation that, for submodules, one needs to add a task step somewhere to do git submodule update --init --recursive

There are pros/cons for either option:

pro: it is simpler for the few cases where someone needs to clone submodules
cons: it adds a bit of overhead that is wasteful when a repository does not use submodules
cons: perhaps someone wants to be in charge of handling their submodules

pro: the documentation provides useful guidance where it is applicable
pro: the documentation does not impose a particular strategy for handling submodules
cons: it is something extra to do where submodules are needed
Personally, I prefer (2).

I think a better logic is to first determine if submodule exists.
We can make a judgement according output of git submodule status.
@vdemeester  do you have any opinions ?

@chengjingtao I thought of that initially, that said, those commands are fully no-op if there is no submodules so, running them almost doesn't cost anything :angel:
I needed for a task (that uses the git-init) so I opened a PR #1531 :sweat_smile:

@chengjingtao I thought of that initially, that said, those commands are fully no-op if there is no submodules so, running them almost doesn't cost anything 👼
I needed for a task (that uses the git-init) so I opened a PR #1531 😅

Wow, I understand what you mean. It really makes sense
It seems I lost a chance to make a contribution to this project. 😆😅  Your PR is great.
I am trying to find some good-first-issue to resolve it.

@chengjingtao sorry about that :sweat_smile: There is plenty (and if not enough, we need to triage them to add more good first issue :angel:


Update UBKG API to work against a Neo4j 5.x database

Create a new version of the UBKG API that will work against Neo4j 5.x.  For now create a "neo4jv5" branch for this work and don't merge into main or dev yet.  This branch can be released on the new Data Distillery setup created by DevOps #115.  To do this:

Update the Neo python library/driver to the matching 5.x version
Test all endpoints/neo4j queries to make sure they still work in Neo4j 5

OpenJDK 64-Bit Server VM warning: Option UseBiasedLocking was deprecated in version 15.0 and will likely be removed in a future release.

Issue: Aggregation column contains implicit grouping expressions
This occurs in a Cyber query here:
https://github.com/x-atlas-consortia/ubkg-api/blob/1f841501af8050c50377ca439f491ea0df421414/src/ubkg_api/common_routes/common_neo4j_logic.py#L437

Updated to use neo4j 5.15.0. Tests run. and documented gross failures noted.
IMPORTANT: We should have more complete tests. Probably Alan can specify what he thinks is important and I can make some code for them.


BUILD-1191: Adding build flags to make operator FIPS compliant

Changed CGO_ENABLED=1
Added GOEXPERIMENT=strictfipsruntime env variable
Added -tags strictfipsruntime as part of go build invocation

For future reference, it helps to add JIRA IDs in your PR titles. In the future, I believe we have tooling through OpenShift CI's Prow instance to link pull requests to JIRA issues.


No implicit arguments of type: JsonReader[Double]

I want to convert a JsValue to Double. Code is here:
action.annotations.get("average_cpu").getOrElse(JsNumber(0)).convertTo[Double],
Don't care about the logic, I get a Option[JsValue] here and use getOrElse method to get JsValue type. Then I want to convert to Double, but the IDE kept telling me an error:No implicit arguments of type: JsonReader[Double]
And when I built my project, there was an error:
Cannot find JsonReader or JsonFormat type class for Double           action.annotations.get("average_cpu").getOrElse(JsNumber(0)).convertTo[Double],
How to solve it ?

The format is here.
Let me tell you that this is absolutely not the way to open an issue. You are not showing any complete code snippet that may be reproducible by anybody else. You're saying "the IDE" without even saying which IDE is. You haven't built a minimal reproducible example of how this supposed bug may be reproducible.
That said, try import spray.json.DefaultJsonProtocol._


Billion numbers have two 1s

The loops looks like it adds a 1 digit even though the line above it manually adds a 1

That was just so I could do ",%d" inside the loop instead of having to have any conditions checking the comma placement. I write the first 1 then loop through to 1 billion. I should start the loop at 2 though. Since I'm already writing the 1.


Hyperparameter optimization stalls

I'm not sure MOE is working like it's supposed to at times. In this case seems like it's sample along the parameter bounds and sampling the same points.
----------------------------------------------------------------------
Beginning iteration                                             8 / 10
----------------------------------------------------------------------
Loading trials database: sqlite:///villin.db...
History contains: 125 trials
Choosing next hyperparameters with moe...
  {'tica__n_components': 2, 'tica__lag_time': 1, 'cluster__n_clusters': 100, 'tica__gamma': 0.099999999999999895, 'featurizer__types': ['phi', 'psi', 'chi1']}
(moe took 6.656 s)

[Parallel(n_jobs=1)]: Done   1 jobs       | elapsed:  1.0min
[Parallel(n_jobs=1)]: Done   5 out of   5 | elapsed:  5.6min finished
[CV] Using MSMBuilder API n_samples averaging
[CV]   n_train_samples: [717706, 716515, 717335, 711555, 723199]
[CV]   n_test_samples: [730784, 731975, 731155, 736935, 725291]
Loading trials database: sqlite:///villin.db...

....

----------------------------------------------------------------------
Beginning iteration                                            10 / 10
----------------------------------------------------------------------
Loading trials database: sqlite:///villin.db...
History contains: 171 trials
Choosing next hyperparameters with moe...
  {'tica__n_components': 2, 'tica__lag_time': 1, 'cluster__n_clusters': 100, 'tica__gamma': 0.099999999999999895, 'featurizer__types': ['phi', 'psi', 'chi1']}
(moe took 10.258 s)

[Parallel(n_jobs=1)]: Done   1 jobs       | elapsed:  1.2min
[Parallel(n_jobs=1)]: Done   5 out of   5 | elapsed:  6.3min finished
[CV] Using MSMBuilder API n_samples averaging
[CV]   n_train_samples: [708766, 708440, 725087, 722092, 727750]
[CV]   n_test_samples: [739724, 740050, 723403, 726398, 720740]
Loading trials database: sqlite:///villin.db...

this also happens with hyperopt_tpe

Perhaps this suggests that it thinks these are the best values?

It could be, but I'm skeptical. I've had random search find better values, and even with those in the history MOE results didn't update. I also know @msultan has run into this issue.

you have more practical experience with MOE than I do, so I don't have any great suggestions. The best thing is probably to try playing around with the different hyperparameters MOE accepts using one of your existing trails databases.

@cxhernandez what was your train/test split. I was getting a similar behavior where the same model was being fit by multiple workers. I might be wrong but I think the Gaussian prior widths that MOE uses might need to be substantially increased.
It could also be that given the randomness of the train/test + equilibrium requirements for  both, MOE is just unsure about what the actual score is given the set of parameters so it is refitting? I haven't read the MOE paper so this is pure conjecture at this point.
Empirically, right now it might be best to start with a few hundred random models which might get MOE to converge faster.


fix login on defaultRegistry

fixing https://github.com/containerd/nerdctl/issues/826
DefaultRegistry  endpoint should not be converted to hostname in .docker/config.json for healthy login process against  https://index.docker.io/v1/
Signed-off-by: fahed dorgaa<EMAIL_ADDRESS>

cc @Junnplus

cc @Junnplus

@AkihiroSuda can we merge this plz ? Ci failure seems to be unrelated to the PR


Shorten type manifest

Currently, the type manifest for custom types consist of the assembly qualified type name.
This could be shortened by spitting typename and assembly name.
instead of foo.bar.baz, my.asm we could write the two separately, and introduce an assembly lookup much like the current type id lookup we have.
that way, only the first occurance of an assembly would be emitted, all others would emit an assembly ID.
This would likely speed up both lookup time and reduce payload size.

Yep, maybe can not save assembly name at all?
Currently I use dynamic generated assemblies if I use Wire for save some generated object I has in file something like this:
System.Collections.Generic.List`1[[MyNameSpace.GeneratedType, Generated_26ebf0d0-c293-4fdd-9ff2-3adcd92a68af, Version=<IP_ADDRESS>]]

Wire is fastest serializer that I bench (msgpack same at write, but reading in Wire is faster), but wire serialize type info, maybe can configure this?


[BUG] README language ordering randon and BE lang does not disappear after selection

Describe the bug
BE language does not go away when you click it on the readme, and the other languages are not ordered the same way in all readme files
Steps to Reproduce
open BE in readme
Expected behavior
BE should disappear as the others do, or all should be kept
Screenshots
No response
Operating System
any
Hydra Version
main
Additional Information
No response

i think all langs should be kept after click anyway, easyer to maintain


add support that an application depends on the stable compiler

the kernel will still build by the nightly compiler

Not longer required...


TypeScript definition broken because of food.json

Is this a regression?
Yes
Description
The TypeScript definitions are broken because of the food.json import. Food is the only function that imports the json not just for the actual function but for the type definition of CuisineOrigin.

Create a new Angular 13 project with Angular CLI
Install falso
Import and use any of the rand* function
Start the project with npm start

The error below is thrown.
Please provide a link to a minimal reproduction of the bug
https://github.com/rothsandro/falso-typescript
Please provide the exception or error you saw
Error: node_modules/@ngneat/falso/lib/food.d.ts:2:22 - error TS2732:
Cannot find module './food.json'. Consider using '--resolveJsonModule' to import module with '.json' extension.

import { data } from './food.json';
                       ~~~~~~~~~~~~~

Please provide the environment you discovered this bug in
@ngneat/falso    2.11.0
typescript       4.5.2
node             v16.13.0

Anything else?
Workaround: set skipLibCheck in tsconfig to false
Do you want to create a pull request?
No

I think you need to find the root cause, because this thing showed up again. What's in project:

@ngneat/falso": "^6.1.0
typescript": "^4.7.4
node - v14.20.0


Netbird 2FA Re-Prompt on Refresh

Describe the problem
I'm being prompted each time I refresh my page to add my 2FA code when using Netbird.io internal IDP.
To Reproduce
Steps to reproduce the behavior:

Enable Netbird.io on account.
Configure your 2fa.
Log into your account using 2fa.
Go to any Netbird page and refresh your browser.
Browser will prompt you to re-auth with 2fa.

Expected behavior
I would expect that 2fa would only prompt when im logged out of my session.
NetBird status -d output:
NA
Screenshots
NA
Additional context
Add any other context about the problem here.

Hello @hbzhost this is happening when you mark the Remember this browser check box? See example below:

Seems like selecting "remember this browser" fixes the issue. I would think this feature would only be used when signing in and it wouldn't prompt me again until my session is over and I re-login again.
Thanks,

It should be like that.
We will look into the behavior when renewing the authentication in the background and provide you a feedback.

Thank you!

Hello @hbzhost, this is fixed now. Let us know if you find other issues.


Translation of the canonical models

[ ] #5
[ ] Produce the final version taking account the codelist.
[ ] Produce the JSON files.

Today I had a meeting with IHU to clarify doubts regarding the Excel files.
Next week the config-files will be ready


Table pagination is not compatible with ajax

Hello,
I am using Metro UI table component. I am happy with it, but when i using pagination, I become sad:

I want to load not all the data, but just selected page.
I  want to load each page by ajax, is that available or not.
Is pagination available when I load just one page data. I need this feature.

Thanks.

Please use codepen.io to create example with your problem

my question is general.

I also uploaded my code.
suppose I have a json that table is loaded from it. when data is large, table loads slowly. I want to load just the first page, but I should see pagination to navigate between pages. When I press page 2 then the rest of the data should be read from json on page 2. ofcourse accodring to Show entries number.
How is this?
thanks
https://codepen.io/vahidbabaveisi/pen/bGBQvEZ

Currently, partially loads not implemented. You can load full dataset only. Maybe in the next version I will add this feature.


Staging next

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

Compare to master: ?compare=1478563

The included texlive upgrade breaks zathura: https://github.com/NixOS/nixpkgs/pull/45432#issuecomment-421626897

@timokau zathura was fixed by #46376 , which is in staging (but not staging-next).

Unfortunately this isn't making any progress on Hydra due to low priority: https://hydra.nixos.org/eval/1478706. >6000 queued builds, all on Darwin, and no build run at all for a day now.
How are we going to get this in shape to be merged?

Also should the zathura fix maybe be cherry-picked to staging-next? Its a fix after all. But it would cause a lot of rebuilds.

@timokau it would cause another ~13k rebuilds and delay this iteration for several days - just to fix one package.  The point of  staging-next is exactly to avoid that and stabilize the build without starting over each time a commit is added...

FYI, added ce6e72a11cc2f52d6e92224791fe5db7f9e2ecdd to staging, follow-up to the first texlive fix, if that should be considered to be cherry-picked in.

Current comparison: https://hydra.nixos.org/eval/1479929?filter=x86_64-linux&compare=1479402

A large portion of the new failures are timeouts (kernels and libreoffice) that shouldn't concern us.

vlc failure on aarch64 is unrelated.


refactoring and error checking fix

👋 Do you think you could rebase, there's a small conflict.

❤


Spurious events?

Hello,
Thanks for sharing glfw.
The glfwWaitEvents returns more than once on an event.
With this change to tests/events.c:
git diff events.c
diff --git a/tests/events.c b/tests/events.c
index 674b584..9803124 100644
--- a/tests/events.c
+++ b/tests/events.c
@@ -608,6 +608,7 @@ int main(int argc, char** argv)
             break;

         glfwWaitEvents();
+        printf("Received event: ");

         // Workaround for an issue with msvcrt and mintty
         fflush(stdout);

I get multiple "Received event" for some events.
./events
Library initialized
Creating windowed mode window 1 (640x480)
Main loop starting
00000000 to 1 at 0.051: Window was restored
00000001 to 1 at 0.051: Framebuffer size: 1148 1179
00000002 to 1 at 0.051: Window size: 1148 1179
00000003 to 1 at 0.051: Window was restored
00000004 to 1 at 0.051: Window refresh
00000005 to 1 at 0.051: Window focused
Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: 00000006 to 1 at 7.456: Window was restored
Received event: 00000007 to 1 at 7.456: Window defocused
Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: 00000008 to 1 at 8.196: Cursor entered window
Received event: 00000009 to 1 at 8.196: Cursor position: 1129.000000 777.000000
Received event: 0000000a to 1 at 8.199: Window was restored
Received event: 0000000b to 1 at 8.199: Window focused
Received event: Received event: 0000000c to 1 at 8.204: Cursor position: 1076.000000 777.000000
Received event: 0000000d to 1 at 8.212: Cursor position: 1029.000000 777.000000
Received event: 0000000e to 1 at 8.220: Cursor position: 991.000000 777.000000
Received event: 0000000f to 1 at 8.228: Cursor position: 959.000000 777.000000
Received event: 00000010 to 1 at 8.236: Cursor position: 931.000000 777.000000
Received event: 00000011 to 1 at 8.244: Cursor position: 919.000000 777.000000
Received event: 00000012 to 1 at 8.252: Cursor position: 914.000000 777.000000
Received event: 00000013 to 1 at 8.436: Cursor position: 913.000000 778.000000
Received event: 00000014 to 1 at 8.484: Cursor position: 914.000000 780.000000
Received event: 00000015 to 1 at 8.492: Cursor position: 915.000000 781.000000
Received event: 00000016 to 1 at 8.500: Cursor position: 916.000000 781.000000
Received event: 00000017 to 1 at 8.508: Cursor position: 923.000000 781.000000
Received event: Received event: 00000018 to 1 at 8.516: Cursor position: 940.000000 781.000000
Received event: 00000019 to 1 at 8.524: Cursor position: 967.000000 781.000000
Received event: 0000001a to 1 at 8.532: Cursor position: 999.000000 781.000000
Received event: 0000001b to 1 at 8.540: Cursor position: 1042.000000 786.000000
Received event: 0000001c to 1 at 8.548: Cursor position: 1084.000000 791.000000
Received event: 0000001d to 1 at 8.556: Cursor position: 1137.000000 791.000000
Received event: 0000001e to 1 at 8.564: Cursor left window
Received event: 0000001f to 1 at 8.567: Window was restored
Received event: 00000020 to 1 at 8.567: Window defocused
Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: 00000021 to 1 at 10.476: Cursor entered window
Received event: 00000022 to 1 at 10.476: Cursor position: 1136.000000 786.000000
Received event: 00000023 to 1 at 10.484: Cursor position: 1109.000000 786.000000
Received event: 00000024 to 1 at 10.490: Window was restored
Received event: 00000025 to 1 at 10.490: Window focused
Received event: Received event: 00000026 to 1 at 10.492: Cursor position: 1086.000000 786.000000
Received event: 00000027 to 1 at 10.500: Cursor position: 1064.000000 786.000000
Received event: 00000028 to 1 at 10.508: Cursor position: 1041.000000 791.000000
Received event: 00000029 to 1 at 10.516: Cursor position: 1019.000000 791.000000
Received event: 0000002a to 1 at 10.524: Cursor position: 996.000000 791.000000
Received event: 0000002b to 1 at 10.532: Cursor position: 979.000000 796.000000
Received event: 0000002c to 1 at 10.540: Cursor position: 966.000000 801.000000
Received event: 0000002d to 1 at 10.548: Cursor position: 955.000000 801.000000
Received event: 0000002e to 1 at 10.556: Cursor position: 951.000000 801.000000
Received event: 0000002f to 1 at 10.564: Cursor position: 946.000000 804.000000
Received event: 00000030 to 1 at 10.580: Cursor position: 943.000000 804.000000
Received event: 00000031 to 1 at 10.596: Cursor position: 941.000000 804.000000
Received event: 00000032 to 1 at 10.604: Cursor position: 939.000000 804.000000
Received event: 00000033 to 1 at 10.612: Cursor position: 935.000000 804.000000
Received event: 00000034 to 1 at 10.620: Cursor position: 931.000000 804.000000
Received event: 00000035 to 1 at 10.628: Cursor position: 925.000000 807.000000
Received event: 00000036 to 1 at 10.636: Cursor position: 917.000000 810.000000
Received event: 00000037 to 1 at 10.644: Cursor position: 905.000000 815.000000
Received event: 00000038 to 1 at 10.652: Cursor position: 895.000000 819.000000
Received event: 00000039 to 1 at 10.660: Cursor position: 887.000000 822.000000
Received event: 0000003a to 1 at 10.668: Cursor position: 884.000000 822.000000
Received event: Received event: 0000003b to 1 at 10.860: Cursor position: 886.000000 822.000000
Received event: 0000003c to 1 at 10.876: Cursor position: 888.000000 822.000000
Received event: 0000003d to 1 at 10.876: Cursor position: 894.000000 822.000000
Received event: 0000003e to 1 at 10.884: Cursor position: 911.000000 822.000000
Received event: 0000003f to 1 at 10.892: Cursor position: 926.000000 816.000000
Received event: 00000040 to 1 at 10.900: Cursor position: 952.000000 811.000000
Received event: 00000041 to 1 at 10.908: Cursor position: 979.000000 811.000000
Received event: 00000042 to 1 at 10.916: Cursor position: 1007.000000 806.000000
Received event: 00000043 to 1 at 10.924: Cursor position: 1034.000000 806.000000
Received event: 00000044 to 1 at 10.932: Cursor position: 1067.000000 801.000000
Received event: 00000045 to 1 at 10.940: Cursor position: 1094.000000 794.000000
Received event: 00000046 to 1 at 10.948: Cursor position: 1137.000000 789.000000
Received event: 00000047 to 1 at 10.956: Cursor left window
Received event: 00000048 to 1 at 10.964: Window was restored
Received event: 00000049 to 1 at 10.964: Window defocused
Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: Received event: 0000004a to 1 at 13.653: Window was restored
Received event: 0000004b to 1 at 13.653: Window focused
Received event: Received event: Received event: 0000004c to 1 at 13.799: Key 0x0156 Scancode 0x006c (LEFT ALT) (with no mods) was pressed
Received event: 0000004d to 1 at 13.922: Key 0x0156 Scancode 0x006c (LEFT ALT) (with no mods) was released
Received event: Received event: 0000004e to 1 at 13.978: Key 0x0154 Scancode 0x0032 (LEFT SHIFT) (with no mods) was pressed
Received event: Received event: Received event: Received event: Received event: 0000004f to 1 at 14.178: Window close

Thanks

This is mentioned in the reference documentation for glfwWaitEvents:

Since not all events are associated with callbacks, this function may return without a callback having been called even if you are monitoring all callbacks.

Thanks for the response. The explanation makes sense. It explains the current behaviour.
Is there a reason why there would be a "waitEvents" function when one cannot know what event has woken it up?

The difference between "wait until any OS event" and "wait until any GLFW event" didn't seem useful enough to warrant the additional code and state., especially as (like your post shows) they are usually the same thing.
glfwWaitEvent is mostly intended to let applications that don't need to draw continuously sleep when nothing is happening. Usually when client code is waiting for an event, it's a specific event like "the key to bind to Jump" or "some event that forces a redraw". Having the function track whether it had called any callback at all wouldn't help with those.

Forgot to address the singular here:

Is there a reason why there would be a "waitEvents" function when one cannot know what event has woken it up?

glfwWaitEvent may process many events before returning.


feat(Marker.Drag): autoPan implementation

Hi,
this is an implementation of auto panning for the marker (should fix #3572). Unlike #3643, this doesn't modify  the Draggable class.
It also implements a sort of incremental speed that will increase as far as you move closer the edge.
Hope it helps!

I saw your changes and I have to say that we have decreased the speed in our app too, so I think 10 is better.
I'm looking forward to see this PR merged :)


Bug

Pausing and unpausing the game desyncs a song slightly. Doing this multiple times intensifies the desynchronization.

GMS2 Issue, not possible for me to fix.


feat: add assetclick event

Please ensure your pull request adheres to the following guidelines:

[ ] make sure to link the related issues in this description
[ ] when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues
Thanks for contributing!

Hi Justin, I think this PR is quite large and given that it would (at least initially) only apply to a single site, I don't think the additional delivery weight is a good tradeoff for the value it provides.

I've found https://github.com/adobe/helix-rum-enhancer/blob/c4bfe38d1550534a0fba85d50393db8b10c63e72/src/index.js#L219-L230 by @chicharr acceptable in size and would hold you to the same standard.

FYI - this is now down to 269 bytes delta after gzipping.

@justinedelson  would it make sense to track assetclick in the existing click checkpoint, and adding a prefix img video in the source ?
You would then squeeze the findAsset logic in the sourceselector. We already have a special treatment for form

would it make sense to track assetclick in the existing click checkpoint, and adding a prefix img /video in the source ?

@chicharr maybe... I think the challenge there would be coming up with a CSS-selector-ish value so that the semantics of source remain more or less unchanged. For example (and this is just a concept), perhaps `[style='background-image: url(...)'].
I've also converted this to a draft. It's not really ready to be merged (even leaving aside @trieloff 's concerns about whether it should be merged).


How to deploy on region eu-central-1

I tried to install it in our region eu-central-1 but I got the error he can't reach the bucket (because it's in region us-west-2).
can you also create a bucket with the files in the regio eu-central-1?

I resolved it by download the file https://s3.amazonaws.com/code-pipeline-slack-us-east-1/d77d29f677a71c501f35e8293b9c0dbc and placed it an own bucket and change the template to point to this location.


Trivial changes to some files.

I made some trivial changes to the makefile, .gitignore and README.md to neaten things up a bit. I rebased against your latest to avoid any trouble for you.

Neat stuff as always, thanks.


GitHub Desktop can't find atom-beta

GitHub Desktop can't find atom v1.40.0-beta0

It looks like this might be due to the exe being renamed from atom.exe to atom-beta.exe
https://github.com/atom/atom/pull/17813
https://github.com/desktop/desktop/issues/8010

Thanks for bringing this up!
As this is an intentional change for the purposes outlined in the PR you linked I'm going to close this issue here, thanks for filing one over on desktop/desktop to bring this to that team's attention though!


Update email recipients

Docs pages say "Hybrid identity administrators," but the portal says "Global Administrators." Delivery to all global administrators is enabled by default.

@billmath
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Portal should be updated and we want least priviledge.  Do not merge.
#please-close


Add jacoco report and pass the location to codecov

Description
Add jacoco report and pass the location to codecov
Issues Resolved

Resolves #1612

Check List

[ ] This PR has code coverage data Pending on PR Checks
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I'm seeing

I think we need to merge at least once to get the coverage data all in... :/  I did generate a report so that is better than we saw before.  I am going to wait on the merging of https://github.com/opensearch-project/security/pull/1616, and retrigger the checks if they don't trigger automatically


SafeInfo endpoint

Closes #242
Changes:

Added all the fields available in the core services to SafeInfo
Added SafeInfoEx with extended AddressInfo for all the available fields
Core business logic is there, we need to talk in refinement what we do with owners
AddressInfo not fetched for owners and address fields

It's very localised, we can changing it anytime without affecting the apps :) I am not sure what to name it tbh :/


35 discus accordion

Added accordion functionality and moved below recent posts.
Fix #35
Test URLs:

Before: https://main--impala--mkclawson.hlx.page/blog/rocky-mountain-snow
After: https://35-discus-accordion--impala--mkclawson.hlx.page/blog/rocky-mountain-snow

I'm closing this PR - I will create a new one.


if I want to replace neck, can I still use the original pre training weight?

Ask, if I want to replace neck, can I still use the original pre training weight?
I want to replace FPN with BiFPN

Yes. Feel free to do it.

@Kyle-fang you did it? can you share BiFPN for yolox?


 Needs some work still but its pretty cool.
There is a bug where sorting the table will reset the checkboxes that I can't fix right now

The site is hosted with Github Pages, which doesn't support any backend - only front end. That PHP code isn't going to get executed.
Would you like me to still merge this?

Ah my bad, I thought Rabrennie was hosting it on his personal website.


Check user from session on db operations

Add guards to prevent malicious user from reading/editing other users details

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 24.84%. Comparing base (ffa8b9f) to head (d6aa7bb).

Files
Patch %
Lines

src/repository/worklogRepository.ts
0.00%
13 Missing :warning:

src/repository/util.ts
0.00%
9 Missing and 1 partial :warning:

src/repository/settingsRepository.ts
0.00%
5 Missing :warning:

src/repository/userRepository.ts
0.00%
3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #26      +/-   ##
===========================================
- Coverage    25.43%   24.84%   -0.60%
===========================================
  Files           65       66       +1
  Lines         1254     1284      +30
  Branches       248      251       +3
===========================================
  Hits           319      319
- Misses         890      919      +29
- Partials        45       46       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


CustomPage and Paged has the same friendly name

The CustomPage model (here) and Paged model (here) have exactly the same friendlyName, this leads to models with the same name in the SDK and might lead to issues.
Taking a closer look, Page<T> is identical to CustomPage<T> when the second argument is empty.
Therefore how about this for a fix:
We change Page<T> as an alias of CustomPage<T>:
alias Page<Resource extends Reflection.Model> = CustomPage<Resource>;

which in the functionality's perspective, should not break anything.

DotNet generator happens to dodge this bullet because we used a cached based on the name of the model when we convert the information provided by TCGC, and TCGC gives us two different models with the same name, thanks to this name-based cache, dotnet generator could work properly by combine these two models.
We are trying to make a change to use the TCGC types as keys, and uncovers this issue.

typesepc-python doesn't expose paged models in generated SDK code

DotNet generator happens to dodge this bullet because we used a cached based on the name of the model when we convert the information provided by TCGC, and TCGC gives us two different models with the same name, thanks to this name-based cache, dotnet generator could work properly by combine these two models.
We are trying to make a change to use the TCGC types as keys, and uncovers this issue.

I guess the CustomPaged<Resource comes first, right? It's a super set of Paged<Resource>. If so, we're luck here. I believe this should be fixed.

DotNet generator happens to dodge this bullet because we used a cached based on the name of the model when we convert the information provided by TCGC, and TCGC gives us two different models with the same name, thanks to this name-based cache, dotnet generator could work properly by combine these two models.
We are trying to make a change to use the TCGC types as keys, and uncovers this issue.

I guess the CustomPaged<Resource comes first, right? It's a super set of Paged<Resource>. If so, we're luck here. I believe this should be fixed.

Actually no - CustomPage and Page do not have relationship with each other at all.
Which one comes first depends on which operation comes the first.

cc @timotheeguerin @allenjzhang

In order for the friendly name to be the same, you would need to use items with the same resource name.  Are there actual scenarios where a spec would do this, or is this just trying to detect and prevent a potential spec error?

In order for the friendly name to be the same, you would need to use items with the same resource name. Are there actual scenarios where a spec would need to do this to describe API, or is this just trying to detect and prevent a potential spec error?

We are doing such thing (using both in one tsp) in one of the cadl ranch cases.
I am not sure if it is intentional or accidental, but it will be problematic for SDK generators.

The main problem is that changing either friendly name is a breaking change, and it moves away from the best name for the type.  I would suggest that instead we provide a linting rule to prevent usage of both on the same type.


Fixed tarpaulin issue, removed unknown lint

Codecov Report

Merging #10 (ff3f919) into master (c0ab196) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            6         6
  Lines          101       101
=========================================
  Hits           101       101

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[zh-cn] sync self-subject-review-v1alpha1.md

sync self-subject-review-v1alpha1.md

/approve

/lgtm


[ARITH] RewriteSimplifier: min/max, logical, select

This is followup of #2722

[x] Added support for min/max, logical, select
[x] Added test cases to cover the rules

cc @sgrechanik-h @icemelon9 @merrymercy @kazum @grwlf @ZihengJiang @wweic @junrushao1994 @MarisaKirisame please help review the PR

(((i0 % 2) != 1) || ((i0 % 2) == 0)) gets rewritten into ((i0 % 2) != 0), don't know what rule causes it. By the way, it would be great to have some rule debugging tool, may be something like printing out every transformation step if some compilation flag is on.

Thanks @sgrechanik-h I have updated per your comment

Thanks, @sgrechanik-h @kazum @wweic please take another look. I tried the best to address some of the comments. I did not add all the rules suggested though, mainly because some of them could be added later, and we do not fully rely on the rewrite based simplification. The min/max chain reduction for example, can better be done through a canonical form that recognizes the min/max chain, which we can add later as another sub-analyzer.

Thanks, @wweic @sgrechanik-h @kazum. This is now merged


Admin plugin: admin.listUsers() returns 401 UNAUTHORIZED

Describe the bug
When I try to run
const users = await authClient.admin.listUsers({
    query: {
      limit: 10,
      sortBy: 'createdAt',
      sortDirection: 'desc',
    },
  })

it returns
 GET /api/auth/admin/list-users?limit=10&sortBy=createdAt&sortDirection=desc 401 in 53ms
{
  data: null,
  error: { code: 'UNAUTHORIZED', status: 401, statusText: 'UNAUTHORIZED' }
}

However, for example when creating a User
const response = await authClient.admin.createUser({
          name: values.name,
          email: values.email,
          password: values.password,
          role: values.role,
        })

it works fine:
 POST /api/auth/admin/create-user?currentURL=http%3A%2F%2Flocalhost%3A3000%2Fadmin%2Fusers 200 in 1069ms

To Reproduce
Steps to reproduce the behavior:

Enable admin plugin on Next.js
Call authClient.admin.listUsers()
Check the terminal
See error on the terminal.

Expected behavior
It should return the list of Users.
Desktop (please complete the following information):

OS: macOS Sequoia 15.0
Browser: Chrome
Version: Version 131.0.6778.70 (Official Build) (arm64)

Additional context
If I try to run
const session = await auth.api.getSession({
    headers: await headers(),
  })

immediately before calling admin.listUsers, I can confirm the signed in user has the admin role:
console.log(session?.user.role)

> "admin"

Update: I was able to make it work by adding the fetchOptions key with the Next.js headers
const response = await authClient.admin.listUsers({
    query: {
      limit: 10,
      sortBy: 'createdAt',
      sortDirection: 'desc',
      filterField: 'role',
      filterOperator: 'eq',
      filterValue: 'user',
    },
    fetchOptions: {
      headers: await headers(),
    },
  })

I assume this is because listUsers is being called on a server component, as described here ?


Migrate to CUDA 9.

Update your environment variables. I did the following:
export PATH="/opt/cuda-9.1/bin:$PATH"
export LD_LIBRARY_PATH="/opt/cuda-9.1/lib64:${LD_LIBRARY_PATH}"

Verified that cuBLAS/cuDNN tests pass (except vvdot, for reasons
unrelated to CUDA version).

@feiwang3311: please merge after verifying that you can run tests. 😃
I'm working on cuda.cs.purdue.edu for now.


cargo ./target fills with outdated artifacts as toolchains are updated/changed

cargo has to recompile dependencies once a toolchain has updated/changed, this leaves all previous artifacts intact. However, this means when you're updating toolchains the target dir will just grow and grow.
Currently you can cargo clean and rebuild, but it would be nice to be able to clean only the dependencies that are not compatible for the current toolchain. Perhaps cargo clean --incompatible ?
For example building a small crate
# cargo +nightly-2018-02-07 build; du -hd2 ./target
57M   ./target/debug/deps
4.0K  ./target/debug/examples
528K  ./target/debug/.fingerprint
4.0K  ./target/debug/native
18M   ./target/debug/incremental
7.6M  ./target/debug/build
82M   ./target/debug
82M   ./target

# cargo +nightly-2018-02-08 build; du -hd2 ./target
113M  ./target/debug/deps
4.0K  ./target/debug/examples
1.1M  ./target/debug/.fingerprint
4.0K  ./target/debug/native
35M   ./target/debug/incremental
16M   ./target/debug/build
163M  ./target/debug
163M  ./target

# cargo +nightly build; du -hd2 ./target
169M  ./target/debug/deps
4.0K  ./target/debug/examples
1.6M  ./target/debug/.fingerprint
4.0K  ./target/debug/native
52M   ./target/debug/incremental
23M   ./target/debug/build
245M  ./target/debug
245M  ./target

This can obviously be much more problematic on larger crates.

This is currently a feature of Cargo that it aggressively caches, but we could always add a comment to delete otherwise stale artifacts!

Yes, I don't think the current behaviour is wrong. It would just be nice to able to say "get rid of the old cached stuff now, I'm not going back to rust 1.22 any time soon". Particularly for things like Rls where we can expect users to update the toolchain fairly often, but don't really inform them about cleaning ./target/rls/.

Since I always develop on nightly, this is true every day. I'm kind of in the habit now of deleting ./target each morning.
However, it seems like this also affects the cache used by Travis CI, as noted in https://github.com/seanmonstar/reqwest/pull/259

I've experienced this problem both for local development and in Travis.
For example, my Travis CI cache has 56 copies of every dependency; sometimes the dependency is updated and sometimes the compiler is updated. For one crate I looked at, each build was 250K. In total, my cache weighed in at 1.4 GB. This caused the cache to take about 7-9 minutes to download and upload, compared to a build time of ~2 minutes! Some of that cache is from other parts of the build, but after clearing the cache and rebuilding, it's only ~175MB. Roughly 1.2 GB of the Travis cache  was composed of these build artifacts.
I also primarily locally develop using nightly, and often find my laptop's disk running out of space because of multiple outdated gigabytes worth of build artifacts.
I agree that cargo clean --outdated would be a good first step. Right now, I do some complicated shell-scriptery to find all the directories that contain a Cargo.toml and run cargo clean in them.
A potential second step would be to do a bit of inspection during a build to note that there are (many? / large?) artifacts lying around that were not used and warn the user about them. A future thing would be akin to git's garbage collection, where unused artifacts older than some date are just automatically removed.

I mean, switching back and forth between compilers.
If you update your stable or nightly you don't need the old artifacts anymore. It's only an issue if you're switching back and forth, which I feel is rare.

Off of CI? I find that a bit hard to believe.
Either way, this would at least work as a preference, preferably on by default.

Switching between current stable and current nightly is at least fairly common.

probably only before clippy was in stable, though

I was thinking of cargo dev, actually.  Perhaps it's more niche than I thought.

I think a very recurring problem we have is that the use cases best
represented on these issue trackers are those of compiler/tool hackers,
which are in a minority otherwise.
cargo dev is definitely a niche use case :)
On Sun, Sep 30, 2018, 12:13 PM Dale Wijnand<EMAIL_ADDRESS>wrote:

I was thinking of cargo dev, actually. Perhaps it's more niche than I
thought.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang/cargo/issues/5026#issuecomment-425709905,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABivSDskcMScFwjlNVSmWxMOm27qFvoKks5ugJlWgaJpZM4R_ye4
.

My hopefully slightly-less-niche use case was that I'd built software in rust that runs on a server (in my case, an IRC bot that I run on a VM in AWS), set up a cron job to keep the rust compiler up-to-date ($HOME/.cargo/bin/rustup update), and set up the script that starts the bot to update the source code and rebuild, so that restarting the bot would update it to the latest version.  The combination of these things ended up filling up the disk space on my VM (i.e., filling up 2GB of storage out of 5GB configured) in about 14 months (April 2017 - June 2018).

To put in two cents from a non-compiler person, I do a lot of cross compiling, and I'd like for the caching to be more aggressive. cargo check seems to utilize a non-target dependent folder, and forces rebuilds when moving from a host build to target build. I'm not sure if auto-gc'ing or something like that is actually intuitive for a build system to do. As a user I'm fine with a cargo clean once in a while - but I can definitely see how this could be a problem in CI.
Maybe a cargo build --throw-away-outdated (excuse the bad arg name) might be the middleground, and CI runners can always opt for that.

I feel like that's an orthogonal problem -- cargo check should be able to reuse metadata from already compiled crates -- it just doesn't.
If cargo check --target foo isn't reusing the target folder I feel like that's a bug.
I don't think what I'm proposing here affects your use case at all -- I'm proposing cleaning up after compiler upgrades, cargo check works differently. It's imperfect but it's not made worse by this proposal.

cargo check should be able to reuse metadata from already compiled crates

Specifically it's #3501

It sort of depends on the method of implementing, but it'd likely all be around src/cargo/core/compiler/*

Just a rough idea:  One option is to completely remove rustc from the metadata hash (here).  It is still included in the fingerprint, so when rustc changes cargo will recompile everything.
A more ambitious approach would be to make it so that you can keep multiple release channels cached at the same time.  This would require extracting the channel from the version information and only including that in the metadata ("stable", "beta", "nightly").  The version string doesn't explicitly include the channel, so it might take some rough interpretation.
Also, I would be very careful to very fully test things in the rustc repo. Since it builds with multiple stages, I would double check that it won't suddenly start clobbering artifacts.  There are some tricky issues involving __cargo_default_lib_metadata.
I don't know if this approach will work, but offhand I can't think of any major issues.  I'm not sure how good rustc itself is at cleaning up its incremental directory and dealing with reusing it across versions.

I was going to open this as an issue when I found this one.
I was thinking we need:
cargo clean --stale
Maybe there needs to be:
cargo clean --analyze
To let you see how bad things have gotten.  If each incremental has a way to easily detect the version, then perhaps:
cargo clean --stale --version 1.34.0
Regards,
-Dave
Regards,
-Dave

Looks like this has been implemented as cargo-sweep.

I have proposed a change in #8073 so that nightly and beta artifacts use the same filenames between versions.  Stable artifacts still use different versions as I'm not comfortable with doing that yet (imagine someone testing stable and then their msrv, it could be annoying to trigger rebuilds or break CI caches).  My intent is that some kind of gc will get built-in to cargo at some point in the future to address that.

My intent is that some kind of gc will get built-in to cargo at some point in the future to address that.

At that point in time, will the change proposed in #8073 be reverted?

I added a -Zseparate-nightlies flag to disable the new behavior just in case.

At that point in time, will the change proposed in #8073 be reverted?

Probably. It is desired that the gc will be rustup-aware and know which toolchains are still installed.  One downside of that approach is that it probably won't run on every build (if there is a performance issue), but I imagine we'll figure things out when the time comes.

Another side effect is that sometimes after updating tool chains, I get a "This crate was built by an incompatible rust version" error. Couldn't cargo just detect the version from the crate metadata, compare with the current rustc version  and clean all outdated artifacts if those don't match?

Both rustc and cargo normally ignore files compiled with an incompatible rustc version. Rustc only gives an "This crate was built by an incompatible rust version" error if the only files matching a crate name are built with a different rustc version. If there is one with the right rustc version, rustc will pick this one. Cargo can't read the rustc version from the files itself, but it does keep a "fingerprint" for each file with the rustc version it was built from. In addition changing the rustc version changes the hash in the filename. The only case in which this error should be possible would be when clearing the target dir and building again would result in an error that the crate doesn't exist at all.

Couldn't cargo just detect the version from the crate metadata, compare with the current rustc version and clean all outdated artifacts if those don't match?

This would mean that switching between stable and nightly will recompile everything every time, which would be very annoying when you are using a nightly only tool but otherwise use stable.

This would mean that switching between stable and nightly will recompile everything every time, which would be very annoying when you are using a nightly only tool but otherwise use stable.

I think a slightly better model might be one where cargo keeps track of when artifacts were last used, and if they haven't been used in a while, prompt to delete them, and provide a cargo clean --outdated or something to do so. Perhaps even delete things automatically.
Also perhaps for toolchains that aren't in rustup anymore, though this may not work well in cases where other non-rustup toolchains are being used.

I think a slightly better model might be one where cargo keeps track of when artifacts were last used

FWIW, I'm currently working on this.  It's been a bit difficult to hit the kind of performance goals I want, though.

Oooh neat!

This is a bit off-topic as it's not about rustc version, but I made https://github.com/dudykr/ddt which can remove artifacts for old dependencies.
It uses cargo metadata --all-features to detect the current dependency graph, and remove rlib if it's from old version.
Note: I want to add a feature to remove artifacts if the rustic version is different, but I'm not sure how can I do it.


Incorporate feedback into V1

@hassox as discussed in Slack, here is the feedback I suggested.  I tried to rebase to pull into the latest master changes but there's a number of conflicts in your earlier commits, should we clean those up?

Not sure... The V1 branch is a full replacement of master so I don't think we want to rebase it
Maybe we could cherry pick the parts that should come over.
Changes LGTM!

That sounds good @hassox 👍


NEXT-7986 - Use img element for Hero Image CMS element

1. Why is this change necessary?
Shopping Experiences:
When choosing a "Hero image" element in a layout, the different generated thumbnail sizes aren't being used, but the original image in its original size. This means that the image is not adjusted, for example in mobile views.
2. What does this change do, exactly?
Change the usage of an inline background-image style to the sw_thumbnail twig function.
Due to the way that img's object-fit works, it is not possible to mimic the 'Auto' setting of the block background. This means that elements that currently have 'Auto' set as their background mode will look different.
3. Describe each step to reproduce the issue or behaviour.

4. Please link to the relevant issues (if any).
https://github.com/shopwareBoostDay/platform/issues/230
5. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] I have created a changelog file with all necessary information about my changes
[x] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Css' image-set would have been a better solution. But that won't be something for now... -> https://caniuse.com/css-image-set

Css' image-set would have been a better solution. But that won't be something for now... -> https://caniuse.com/css-image-set

I have created a Testing Installation for this Pull Request. It will be available at https://github.sw6.ovh/instance?number=264 in the next minutes.

I have created a Testing Installation for this Pull Request. It will be available at https://github.sw6.ovh/instance?number=264 in the next minutes.

Looks fine for me. :+1: Thank your for your contribution @runelaenen :blue_heart:

Looks fine for me. :+1: Thank your for your contribution @runelaenen :blue_heart:


Update OpenSearchRejectedExecutionException import

Description
Update OpenSearchRejectedExecutionException import
Issues Resolved
https://github.com/opensearch-project/anomaly-detection/issues/853
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #861 (b8a7748) into main (c9bdc62) will increase coverage by 0.09%.
The diff coverage is 50.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #861      +/-   ##
============================================
+ Coverage     79.56%   79.65%   +0.09%
- Complexity     4314     4321       +7
============================================
  Files           306      306
  Lines         18093    18096       +3
  Branches       1889     1889
============================================
+ Hits          14396    14415      +19
+ Misses         2793     2778      -15
+ Partials        904      903       -1

Flag
Coverage Δ

plugin
79.65% <50.00%> (+0.09%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...va/org/opensearch/ad/AnomalyDetectorJobRunner.java
80.50% <ø> (ø)

.../java/org/opensearch/ad/AnomalyDetectorPlugin.java
96.68% <ø> (ø)

...rg/opensearch/ad/AnomalyDetectorProfileRunner.java
67.95% <ø> (ø)

...in/java/org/opensearch/ad/EntityProfileRunner.java
75.40% <ø> (ø)

...opensearch/ad/ExecuteADResultResponseRecorder.java
75.17% <0.00%> (ø)

.../main/java/org/opensearch/ad/NodeStateManager.java
76.47% <ø> (ø)

...java/org/opensearch/ad/cluster/ADDataMigrator.java
79.08% <ø> (ø)

...rg/opensearch/ad/constant/CommonErrorMessages.java
98.33% <ø> (ø)

.../org/opensearch/ad/feature/CompositeRetriever.java
82.17% <ø> (ø)

...va/org/opensearch/ad/feature/SearchFeatureDao.java
86.68% <ø> (ø)

... and 86 more

... and 3 files with indirect coverage changes

Hi @jackiehanyang do we need to backport this to 1.x, 2.x?
Thanks.


Example snippet returns incorrect output when compiled without optimizations (x86)

Macro-expanded snippet from README.md (past-return code removed)
#include <stdio.h>
void __stdcall example(__int32 arg3);
unsigned __int32 __cdecl example_trampoline(__int32 arg, __int32 arg2, __int32 arg3);
void __stdcall example2();
void __cdecl example2_trampoline();

int main()
{
    int a = 1;
    int b = 3;
    printf("a = %d, b = %d\n", a, b);
    a = example_trampoline(a, 0, b);
    printf("a = %d, b = %d\n", a, b);
    example2_trampoline();
    return a;
}

void __stdcall example(__int32 arg3)
{
    __asm { push EAX }
    __asm { push EBX }
    __asm { push ECX }
    __asm { push EDI }
    __asm { push EDX }
    __asm { push ESI }

    __int32 arg;
    __asm { mov arg, eax }

    __int32 arg2;
    __asm { mov arg2, ebx }

    printf("arg = %d, arg3 = %d\n", arg, arg3);
    arg = arg + arg3;
    printf("arg = %d, arg3 = %d\n", arg, arg3);

    __asm { pop ESI }
    __asm { pop EDX }
    __asm { pop EDI }
    __asm { pop ECX }
    __asm { pop EBX }
    __asm { pop EAX }

    unsigned __int32 _usercall_internal_return_ = arg;
    __asm { mov eax, _usercall_internal_return_ }
    return;
}

unsigned __int32 __cdecl example_trampoline(__int32 arg, __int32 arg2, __int32 arg3) {
    __asm { mov eax, arg }
    __asm { mov ebx, arg2 }

    example(arg3);

    unsigned __int32 _usercall_internal_return_;
    __asm { mov _usercall_internal_return_, eax }
    return _usercall_internal_return_;
}

void __stdcall example2()
{
    __asm { push EAX }
    __asm { push EBX }
    __asm { push ECX }
    __asm { push EDI }
    __asm { push EDX }
    __asm { push ESI }
    printf("void function\n");
    __asm { pop ESI }
    __asm { pop EDX }
    __asm { pop EDI }
    __asm { pop ECX }
    __asm { pop EBX }
    __asm { pop EAX }
    return;
}

void __cdecl example2_trampoline()
{
    example2();
}

/DWIN32 /D_WINDOWS /EHsc /Zi /Ob0 /Od /RTC1 -MDd

a = 1, b = 3
arg = 3, arg3 = 3
arg = 6, arg3 = 3
a = 6, b = 3
void function

disasm @ godbolt
/DWIN32 /D_WINDOWS /EHsc /O2 /Ob2 /DNDEBUG -MD

a = 1, b = 3
arg = 1, arg3 = 3
arg = 4, arg3 = 3
a = 4, b = 3
void function

disasm @ godbolt
Microsoft (R) C/C++ Optimizing Compiler Version 19.30.30709 for x86

example_trampoline + 0xC		mov	eax, [ebp + arg]
example_trampoline + 0xF		mov	ebx, [ebp + arg2]
example_trampoline + 0x12		mov	eax, [ebp + arg3]  ; culprit

probably wont-fix.... i dont think theres much you can do to alter MSVC codegen
three questions:

imagine a better/alternate reality in which MSVC supports Extended Asm constructs.
would it be possible to incorporate those constructs into usercall.hpp ?

clang already supports many MS-extensions, including __pragma, as well as Extended Asm constructs. what other extensions/undocumented features are necessary in order to achieve compatibility with Clang? it would be nice to have MS-specific oddities listed somewhere in this repo. as it stands, Clang seems to hate #define HASH() # trick.

Unfortunately you are correct that there isn’t much that can be done here at the library level. usercall.hpp depends heavily on undocumented and undefined behavior in MSVC and the new preprocessor (the readme makes this pretty clear imo) which makes the library, and inline assembly in general, unpredictable at times. If you have a suggestion of what to add to the readme I would be happy to add it. My thinking was that adding any advice about compiler flags was futile since new versions of MSVC would change the code gen and my advice would be made obsolete.

This would certainly allow improvements in usercall.hpp. Unfortunately, Microsoft doesn’t seem interested in improving inline assembly so I wouldn’t hold my breath.

Since usercall.hpp is only possible due to the strange macro expansion rules in the new MSVC preprocessor I doubt it could support Clang as a header only macro library. The def hash hash trick is only scratching the surface.

That being said, I am currently working on a C++ language extension to implement the IDA Pro usercall syntax directly into a fork of Clang/LLVM. Once this is complete I am likely going to archive usercall.hpp and add a link to the Clang/LLVM at the top of the readme advising people to use that instead. This new solution has several advantages over usercall.hpp: it uses the actual IDA Pro syntax rather than an imitation of it, it can support all of the architectures that Clang supports rather than only x86_32 (since MSVC only supports x86_32 inline assembly), it is highly integrated with Clang’s diagnostics infrastructure for better error messages, it is far more portable since Clang can run on and compile for pretty much every architecture, and many more things. It’s a much heavier solution since you would need to build the toolchain rather than just include a header but it is far more robust. It is for this reason that I am not interested in working on usercall.hpp anymore and would like to focus on the new project.
Thank you for using my library and writing such a comprehensive issue!

i was looking into Clang internals as well, but my approach was less elegant. i tried to mitigate C99 <IP_ADDRESS> conformance from the preprocessor lexer and related components:
clang/Lex/MacroArgs
clang/lib/Lex/PPMacroExpansion.cpp
clang/lib/Lex/PPDirectives.cpp
clang/lib/Lex/Preprocessor.cpp
without any success..
Needless to say, your approach is the proper way to go. I will leave a link to a project that is similar to IDA in regards to what kind of low-level syntax sugars it provides:

Sphinx C--

DWORD InitD3D()
{
	Direct3DCreate9(D3D_SDK_VERSION);
	if (EAX==0)
		return;

	D3D=EAX;

	EAX=#d3dpp;
	RtlZeroMemory(EAX, sizeof(D3DPRESENT_PARAMETERS));
	d3dpp.Windowed=TRUE;
	d3dpp.SwapEffect=D3DSWAPEFFECT_DISCARD;
	d3dpp.BackBufferFormat=D3DFMT_UNKNOWN;
	EAX=#d3dpp;

............

your Clang plugin would be a game changer for people fixing/modding old games. code-caving in particular can't be done without naked stubs. It would also render "fastcall/thiscall" trick obsolete. consider opening a repository "mid-work", perhaps I and other people will be able to help with the plugin in some way
looking forwards to your future projects!

Thanks for the C-- link! Heads up, Clang already allows __thiscall on non-member functions, no modifications needed, so the __fastcall trick isn't necessary if you are using Clang. I tweeted about this with a godbolt example recently. https://twitter.com/w1db3rg/status/1498481973366505475
I'll make the Clang fork more visible once I add documentation. It is the subject of my undergraduate thesis so I'm spending most of my time now working on it. Thanks for the enthusiasm.


map issue

what can I do to change the map from Town01 to other Towns?

learn from https://carla.org/

You may modify the export FREE_MAP_NAME="Town01"  in op_scripts/run_exploration_mode_ros2.sh. Change 'Town01' into any other town you want. Meanwhile you may check if you have downloaded all other maps and put them in correct folders.


Fix dialogs' tab order

Most dialogs have a broken tab order, since elements were added into the middle during their development. Fix the tab order to represent a logical progression through the dialog controls.

Wrong reference in the commit. Reopening, not fixed yet.


xml file no longer gets created (at least I can't find it)

license-reporter --ignore-version-range --all --file licenses.xml

With the above command, using the latest commit on master, I no longer get a file called 'licenses.xml'. On the v0.3.0 tag, the file gets created just fine.

@grdryn it was necessary to make a modification in the arguments, from --xml instead --file
Because now we have the possibility to create json and yaml.
  --xml                   xml file to store the license information in  [string]
  --json                  json file to store the license information in [string]
  --yaml                  yaml file to store the license information in [string]

closing.


make it look better

The project looks really bad ATM pls fix so that it looks better.

add back the contact and github buttons

maybe add a sidebar?


helm v3 unable to force recreate immutable resource

Output of helm version:
version.BuildInfo{Version:"v3.0.0", GitCommit:"e29ce2a54e96cd02ccfce88bee4f58bb6e2a28b6", GitTreeState:"clean", GoVersion:"go1.13.4"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.11", GitCommit:"25074a190ef2a07d8b0ed38734f2cb373edfb868", GitTreeState:"clean", BuildDate:"2019-09-18T14:41:46Z", GoVersion:"go1.11.13", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"13+", GitVersion:"v1.13.11-gke.14", GitCommit:"56d89863d1033f9668ddd6e1c1aea81cd846ef88", GitTreeState:"clean", BuildDate:"2019-11-07T19:12:22Z", GoVersion:"go1.12.11b4", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
GKE
In Helm v2, I used to be able to do helm upgrade --force to upgrade helm charts with immutable resources, such as Job. For example, if the docker image tag is changed, the helmv2 upgrade with --force will recreate the resource.
Now in Helm v3, I can no longer do this anymore. It says the Job.template is immutable and Helmv3 cannot force the upgrade.

The error in helm v3 is
Error: UPGRADE FAILED: an error occurred while cleaning up resources. original upgrade error: cannot patch "job-test-0" with kind Job: Job.batch "job-test-0" is invalid: spec.template: Invalid value: core.PodTemplateSpec{ObjectMeta:v1.ObjectMeta{Name:"", GenerateName:"", Namespace:"", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string{"
..........

The workaround is to run helm uninstall <release> and deploy, but this involves manual intervention which I didn't have to in helm v2.

duplicate of https://github.com/helm/helm/issues/7082


OpenGov. Delegations. Edit delegation

Add edit delegation button on delegate screen if delegated already
Edit delegation button on multishard delegation info for single account
Edit delegation button on multishard delegation info for multiple selected accounts
Step 1. Select tracks (same as new delegation)
Step 2. Select balance and conviction (same as new delegation)
Confirm screen for singleshard
Confirm screen for multishard
Update multisig operations
Update basket operations

Status verification: ❌
Blocker:

https://github.com/novasamatech/nova-spektr/issues/2362

Status verification: ✅


operator ibm-spectrum-symphony-operator (1.1.2)

ibm-spectrum-symphony-operator update to version 1.1.2

Updated project and added GitHub user

fix brac-proxy tag


input event callbacks are not being called in Firefox in some cases

This bug occurs in Firefox.  The bug does not occur in Chrome.
A full demo with reproduction steps is at https://codepen.io/TehShrike/pen/vYBrZeb
It boils down to this snippet:
class Foo extends LitElement {
  render() {
    return html`
      <input
        type=time
        value="00:00"
        @input=${this.onInput}
      />
    `
  }

  onInput(event) {
	// do stuff
  }
}

To reproduce: set focus on the hour portion of the time input.  Press two reasonable digit keys (e.g. 0 then 4, or 1 and then 1).
Expected behavior: the onInput callback should be called twice – one for each keypress.
Observed behavior: the onInput callback is only called for the first keypress.
You can verify that Firefox does actually fire two events by trying this vanilla js equivalent.
Reproduced with<EMAIL_ADDRESS>

Can anyone point me to a unit test that I could use as the basis for a new failing test?  This bug seems pretty serious, and makes lit-element/lit-html effectively broken for forms in Firefox

lit-html seems to actually be setting the value on the element back to a previous (incorrect) state.


add OS X tutorial

This was closed with the video tutorial at https://www.youtube.com/watch?v=fBAKLGYtK2o - also available at http://deeplearningkit.org/tutorials-for-ios-os-x-and-tvos/tutorial-using-deeplearningkit-with-os-x-for-macbook-and-imac/


TODO:  Add a video streaming viewer component

Like a youtube viewer.   Shows thumbnail of video .   Upon clicking starts to play video.
Enable "standard" playback controls of the underlying libray.
Make sure it can efficiently support multiple instances on one page.

First cut is available here  https://github.com/RocketChat/RC4Community/commit/650e4b1c4d1d3271cf9a85695b9f310e5d8c6375

I want to work on this.

Completed as part of RC4Conferences


Add getAccessToken() function to UserManager

(Written with react-oidc-context in mind, but the root cause is probably in oidc-client-ts.)
Currently, there is no "proper" way to get a valid access token with the UserManager.

(await UserManager.getUser()).access_token may return an expired access token if automaticSilentRenew === false, or if the previous automatic silent renew failed due to a network condition.
(await UserManager.signinSilent()).access_token returns a valid access token, but the price is that there is always an additional network request.

My suggestion would be to add an async function UserManager.getAccessToken(), which returns an access token that can be used in a network request:

If the access token is still fresh, return it.
If there is already a concurrent request to refresh the access token (e.g. from a previous getAccessToken() call, or from silent renewal), await for that request
If the access token is about to expire, refresh it, then return the refreshed access token.

Current design: The access token is refreshed in advance, such that its storage is up-to-date in local or sessionStorage. In my applications i do directly access that token from localStorage by using something like this:
import { User } from "oidc-client-ts"

function getUser(): User {
    const oidcStorage = localStorage.getItem(`oidc.user:<your authority>:<your client id>`)
    if (!oidcStorage) {
        return null;
    }

    return User.fromStorageString(oidcStorage);
}
...
const user = getUser();
const token = user?.access_token;

// in case the token is undefined, you have to take care somewhere else (e.g. App.tsx) in your application like:
const isAuthenticated = user ? !user.expired : false;
if (isAuthenticated) {
  // render something or redirect to login page
}


the repo shows with 404

Describe the bug
After using sdk to upload a  .parquet file, the repo shows with 404
Environment
CSGHub Version: latest in 2024.12.11
OS: Linux
Hardware: 4c8G
Launch:  docker
To Reproduce
Steps to reproduce the behavior:

generate a .parquet  file

import pandas as pd

data = {"id": [1, 2, 3], "name": ["Alice", "Bob", "Charlie"], "age": [25, 30, 35]}

df = pd.DataFrame(data)

df.to_parquet("example.parquet", index=False)

print("Parquet 文件已创建：example.parquet")

use sdk to upload

from pycsghub.snapshot_download import snapshot_download
from pycsghub.file_download import file_download
from pycsghub.file_upload import http_upload_file

token = "xxxxx"
endpoint = "http://x.x.x.x"
repo_id = "test/test"
repo_type = "dataset"
cache_dir = "./cache"

# 上传文件
result = http_upload_file(repo_id, endpoint=endpoint, token=token, repo_type=repo_type, file_path="./example.parquet")

go to web to refresh this repo get with 404

Request URL:
http://x.x.x.x/api/v1/datasets/test/test/dataviewer/catalog
Request Method:
GET
Status Code:
404 Not Found

Expected behavior
It should be work well without 404.

@ChristLZS It is because our dataset data view function is still in development, and not ready, please stay tuned for future updates

@hiveer it's better to remove the request to apis not implemented.

@hiveer it's better to remove the request to apis not implemented.

sure, will do it asap

@hiveer does v1.2.0 new release fix this issue?


[Java docs feedback]

Problem description

Problem location

I saw a problem at the following URL:

I couldn't find the information I wanted. I expected to find it near the following URL

Other:

Project version(s) affected

Suggestions for a fix

Hi @JTBJ, it looks like no details were added to the feedback. If there is an issue in the docs, please provide more details.


baseobject is not of type alt::IVirtualEntity

Description of the problem
When streaming in/out virtual entities, this error commonly comes out:
Client:

Server:

Reproduction steps
In my case, I've created ~30k of virtual entities around the map with 30 streamed-in limit, zoomed around area back and forth and this error consistently comes up.
Expected behaviour
The code should not throw an error.
Additional context
https://discord.com/channels/371265202378899476/576771706119520287/1147987791460958348
Operating system
Win11
Version
15.0-dev595
Crashdump ID
No response
Reproduction tested

[X] I confirm that I have made sure that this issue is also present on the newest dev version

Some additional context: The entity in question is coming from Map keys.
const map = new Map<alt.VirtualEntity, Foo>();

function foo() {
  for (const entity of Object.keys(map)) {
    const type = getAnchorType(entity);
    ...
  }
}

Can't reproduce that using the following snippet:
const map = new Map();

alt.onServer('gotMe', () => {
  const entity = alt.VirtualEntity.all[0];

  for (let i = 0; i < 20; ++i) {
    map.set(i, entity)
  }

  for (const entity of map.values()) {
    const val = entity.getStreamSyncedMeta('test');
    alt.log(val, entity.id);
  }

  /*for (const [, entity] of map.entries()) {
    const val = entity.getStreamSyncedMeta('test');
    alt.log(val, entity.id);
  }*/
});

Please provide working code to reproduce this.

xLuxy is a goat
(tracking entities using worldObjectStreamIn & worldObjectStreamOut events is the way).


BUG: Extra Space Between Heading "Trending Food and Health News" and New Cards on News Page

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
There is an extra space appearing between the heading "Trending Food and Health News" and the new cards on the news page. This issue affects the visual layout and should be addressed to ensure a more cohesive design.

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Ok, Assigning this issue to you.


Trying to run stable diffusion but I don't know gradio server is not working

FileNotFoundError                         Traceback (most recent call last)
 in
47 if Use_Gradio_Server:
48   share='--share'
---> 49   for line in fileinput.input('/usr/local/lib/python3.8/dist-packages/gradio/blocks.py', inplace=True):
50     if line.strip().startswith('self.server_name ='):
51         line = '            self.server_name = server_name\n'
1 frames
/usr/lib/python3.8/fileinput.py in _readline(self)
340                     pass
341                 # The next few lines may raise OSError
--> 342                 os.rename(self._filename, self._backupfilename)
343                 self._file = open(self._backupfilename, self._mode)
344                 try:
FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/dist-packages/gradio/blocks.py' -> '/usr/local/lib/python3.8/dist-packages/gradio/blocks.py.bak'

use the latest colab https://colab.research.google.com/github/TheLastBen/fast-stable-diffusion/blob/main/fast_stable_diffusion_AUTOMATIC1111.ipynb


[BUG] The small avatar is not updated on the Feed cards after changing it on the User Profile

Pre-conditions:

The User X is logged in
The user B is logged in on the other device
The user X has completed txs with user B

Steps to reproduce:

Change the profile photo of the User A
Look at txs cards on the feed of user B

Expected result: The small avatar on the txs cards should be updated after changing the Profile photo
Actual result: The small avatar is not updated on the Feed cards after changing it on the User Profile
Environment:  QA 1.25.1-20
Devices list: Windows 10 // Google Chrome v90
Note:

The small avatar is not updated after refreshing the page or navigating to other pages and return.
The small avatar is changed only after re-login to the account, but not for the red send completed card (ordinary send).
The created payments after changing the profile photo are displayed with a new avatar

Attachment: https://www.screencast.com/t/48Ks4qnV

@iLystopad that's currently the expected behaviour.
we keep a copy of the current name/avatar User B in the User A feed


Clarification on the important note at start of article

"Use the same synchronization primitive instance to protect every access to a shared resource. Multiple threads can access a resource concurrently if you use different synchronization primitive instances to protect access to a resource or some parts of code access a resource directly." - the last part of that is unclear how it is written. Is it saying that multiple threads can access a shared resource concurrently by using different sync primitive instances directly on the resource a thread would be accessing?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b1782d18-fc41-cd33-39ed-813941fd9e73
Version Independent ID: 356863d9-c1b2-8566-7d91-59a187607ca6
Content: Overview of synchronization primitives
Content Source: docs/standard/threading/overview-of-synchronization-primitives.md
Product: dotnet
Technology: dotnet-standard
GitHub Login: @rpetrusha
Microsoft Alias: ronpet

I believe so. Perhaps this explains it better?

Use the same synchronization primitive instance to protect access of a shared resource. If you use different synchronization primitive instances to protect the same resource, you'll circumvent the protection provided by a synchronization primitive.

Yeah, I guess that makes more sense. Because you are using a different synch primitive it allows access to the resource in different ways that would not necessarily be allowed by a single primitive.


Update jax dependency

Update JAX dependency so we have jax.monitoring available
Fixes #2824

Codecov Report

Merging #2827 (c7fd31f) into main (7ce79b3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2827   +/-   ##
=======================================
  Coverage   81.26%   81.26%
=======================================
  Files          53       53
  Lines        5680     5680
=======================================
  Hits         4616     4616
  Misses       1064     1064

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


implement BulkInsert?

I'm uploading a large spreadsheet, and it's taking forever
Could I use BulkInsert?

I don't think we could use BulkInsert, but we might could tweak batch settings on the underlying SqlAdapter here

done with new bulk copy support in 1.1.2
b5a31413a2d427b5a819bd6fcb7fe647a95230ea


Update Changelog

Motivation
Updates the Changelog for v1.7.8
Description
No other changes
Test Plan

n/a

TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed
[x] Update changelog as needed

bors merge

bors p=999


use From trait

My compiler complained that SamplingFrequency::from() only expected enum syntax::adts_reader::SamplingFrequency and not u8. This is solved by moving the from(value: u8) functions into the std::convert::From<u8> trait, so that the compiler doesn't get confused which from function to used.
I did consider using std::convert::TryFrom instead of From, which will allow the error be recoverable. However, I wasn't sure what error to return in try_from, whether additional variant is needed in AdtsHeaderError. And I wasn't sure that would be useful, as all cases should be already covered in the match, provided that the input value is sanitized (bitmasked). The panic messages are made more verbose to reflect that.

Fantastic!  Many thanks for this.
Are you hoping for a release including this change soon?  (BTW, I'd be curious to know what your use case is for this code, if you are willing and able to share.)

I can work off of my local copy of the crate (using adts-reader = {path = "../adts-reader"} in my Cargo.toml), so it's fine if the change isn't released soon.
I am trying to work on a AAC decoder, as you probably have guessed. However, I don't have any experience in audio codecs or related fields, nor am I proficient with rust, so I'm making very slow progress. I'm still deciding on the structure of my parsers. Also, the ISO spec was hard to obtain, and a bit difficult to read especially when I have barely any prior knowledge.
If you are interested, I can clean up my code (there's quite a few compiler errors at the moment) and release it so you can work on it.

Super cool!    It is an extremely unforgiving format.
Would love to have something enabling me to dump the AAC block structure for diagnostic purposes.  Good luck!


Fix rtl header logo and z index bug with modal

https://uktrade.atlassian.net/browse/CMS-218

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   93.97%   93.97%
=======================================
  Files          23       23
  Lines         564      564
=======================================
  Hits          530      530
  Misses         34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f63d4d8...40cf6c6. Read the comment docs.


Daheimladen WB produces charger out of sync messages during start and termination of charge.

During the charging process, no error messages are shown.
At termination, the following log entries are shown:
.
.
.
 You may want to increase your interval.
@utsavanand2 could comment how long would be required for the charger.

Ping @utsavanand2

@andig @ExecuteGK  As far as my experience, the status of the station doesn't take more than a second to update unless it doesn't update it at all and there's an issue.

@ExecuteGK

WARN 2022/01/12 14:05:28 invalid charge mode: 0

Woher kommt der charge mode "0"? Greifst Du über API auf Evcc zu?

Nö. Das war noch das resetOnDisconnect Problem mit dem off anstelle "off"
Grüße
Sebastian

@utsavanand2 when the car is connected (start of the log) charger starts enabled right away without evcc enabling it. That causes the out of sync errors. Any idea why that happens?

@utsavanand2 when the car is connected (start of the log) charger starts enabled right away without evcc enabling it. That causes the out of sync errors. Any idea why that happens?

Okay this must be because we return Enabled() -> true when the connector is in 'Charging' or 'Preparing'(plugged in state).
I guess Enabled only means 'Charging' and doesn't mean that the status != 'Available'? In that case we just need to get rid of the second condition here
https://github.com/evcc-io/evcc/blob/606869f3806a700c6c4c9ada70e58f490577f7f7/charger/daheimladen.go#L67

enabled really means that evcc has allowed the car to charge. It will only happen in B or C and is independent from the fact if the car actually takes the opportunity. I'm not sure what would be the best mapping for the box here?

No new insights, closing.


On macOS, When vscode is opened from sudo mode, the input method cannot be switched to non-English

Issue Type: Bug
sudo -i
code .

In the opened window, try to switch IME to non-English. You'll find you can't switch IME.
This issue exists not only when you open as root, but when you open as any user other than the current user.
VS Code version: Code 1.39.2 (6ab598523be7a800d7f3eb4d92d7ab9a66069390, 2019-10-15T15:33:00.827Z)
OS version: Darwin x64 19.0.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-4570R CPU @ 2.70GHz (4 x 2700)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
8.00GB (0.56GB free)

Process Argv
.

Screen Reader
no

VM
17%

Extensions (1)

Extension
Author (truncated)
Version

vscode-eslint
dba
1.9.1

This is a problem with the mac OS that has no solution. It is not clear if this problem was ever reported to Apple . Please see https://github.com/microsoft/vscode/issues/66578#issuecomment-512784154


Error when running functions start

Description
On mac, running functions start produces the following: (nothing in the log file)
Starting Google Cloud Functions Emulator...
ERROR: Error: Emulator crashed! Check the log file...
    at ChildProcess.child.on (x/src/github.com/x/cloud-functions-emulator/src/cli/controller.js:660:24)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)

Steps to reproduce
Emulator Version      │ 1.0.0-alpha.19
Thanks!

How did you install the Emulator? How did you install Node.js?

@TomDeVito friendly ping, are you still running into issues? Can you provide more information?

I ran into this issue. My initial install of the emulator was working. Then for some odd reason it started to cause issues where it wouln't start.
What do you get when you do functions logs read? If you're getting EACCESS issues to the functions/logs directry you have an issue with permissions. So ake sure your current user has access to this folder.
If you fixed the issue above and or don't have that issue and the logs tell you you can't access .functions.json. You also need to make sure you have permission to access the files under:
<EMAIL_ADDRESS>I hope this helps.

Closing do to inactivity, feel free to comment back here with more information to move forward on this issue.

Just ran into this same issue... 1.0.0-alpha.22 node v6.11.1 Chrome 61
This happened after trying to debug in Chrome V8 debugger.
mwalkerwells:didi mwalkerwells$ functions start
Starting Google Cloud Functions Emulator...
ERROR: Error: Emulator crashed! Check the log file...
    at ChildProcess.child.on (/usr/local/lib/node_modules/@google-cloud/functions-emulator/src/cli/controller.js:654:24)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)

2017-07-19T16:27:30.222Z - info: Execution took 60022 ms, finished with status: 'crash'
2017-07-19T16:27:30.224Z - error: uncaughtException: Can't set headers after they are sent. date=Wed Jul 19 2017 09:27:30 GMT-0700 (PDT), pid=7663, uid=0, gid=0, cwd=/usr/local/lib/node_modules/@google-cloud/functions-emulator, execPath=/usr/local/bin/node, version=v6.11.1, argv=[/usr/local/bin/node, /usr/local/lib/node_modules/@google-cloud/functions-emulator, --bindHost=localhost, --grpcPort=8009, --host=localhost, --timeout=20000, --verbose=false, --useMocks=false<EMAIL_ADDRESS>--restPort=8008, --supervisorPort=8010, --tail=false], rss=49782784, heapTotal=47030272, heapUsed=30643392, external=821661, loadavg=[2.43017578125, 2.6552734375, 2.7861328125], uptime=89028
Error: Can't set headers after they are sent.
    at ServerResponse.OutgoingMessage.setHeader (_http_outgoing.js:357:11)
    at ServerResponse.header (/usr/local/lib/node_modules/@google-cloud/functions-emulator/node_modules/express/lib/response.js:730:10)
    at ServerResponse.send (/usr/local/lib/node_modules/@google-cloud/functions-emulator/node_modules/express/lib/response.js:170:12)
    at ServerResponse.json (/usr/local/lib/node_modules/@google-cloud/functions-emulator/node_modules/express/lib/response.js:256:15)
    at ProxyServer.Supervisor._proxy.on (/usr/local/lib/node_modules/@google-cloud/functions-emulator/src/supervisor/supervisor.js:97:12)
    at ProxyServer.emit (/usr/local/lib/node_modules/@google-cloud/functions-emulator/node_modules/eventemitter3/index.js:144:27)
    at ClientRequest.proxyError (/usr/local/lib/node_modules/@google-cloud/functions-emulator/node_modules/http-proxy/lib/http-proxy/passes/web-incoming.js:156:18)
    at emitOne (events.js:101:20)
    at ClientRequest.emit (events.js:188:7)
    at Socket.socketCloseListener (_http_client.js:285:9)
2017-07-19T16:27:30.233Z - error: Function worker killed by signal: SIGTERM

This happens before any requests are sent...I think this is the same error that I was debugging in the debugger when I did send a request. Also, I cannot find any child processes to kill to start with a clean state...

@jmdobry Not sure if this is still on your radar...

Oh interesting... Running with sudo works
mwalkerwells:didi mwalkerwells$ sudo functions start
Password:
Starting Google Cloud Functions Emulator...
Google Cloud Functions Emulator STARTED
┌───────────┬───────────┬─────────┬──────────────────────────────────────────────────────────┐
│ Status    │ Name      │ Trigger │ Resource                                                 │
├───────────┼───────────┼─────────┼──────────────────────────────────────────────────────────┤
│ DEPLOYING │ helloHttp │ HTTP    │ http://localhost:8010/didi-service/us-central1/helloHttp │
└───────────┴───────────┴─────────┴──────────────────────────────────────────────────────────┘

Why is that?

Probably because of how your Node.js installation is set up. Typically, in my experience, needing to use sudo indicates a problem with the Node.js installation/permissions, as you should not need to use sudo. I recommend using nvm to manage your Node.js installation

To add to what @jmdobry has said.
The suggested fix is to change the NPM Global directory to somewhere outside a folder that requires root.
The official doco of NPM: https://docs.npmjs.com/getting-started/fixing-npm-permissions

I faced two problems for starting functions emulator on my mac that I bring them here with the solution that worked for me. Hope it helps and save your time:
1- The first error shown on screen
$  functions start
Starting Google Cloud Functions Emulator...
ERROR: Error: Emulator crashed! Check the log file...
    at ChildProcess.child.on (/Users/mehrantm/.nvm/versions/node/v6.11.5/lib/node_modules/@google-cloud/functions-emulator/src/cli/controller.js:650:24)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:219:12)

and from functions logs:
$  functions logs read
Warning: You're using Node.js v10.9.0 but the Google Cloud Functions runtime is only available in Node.js 6 and Node.js 8. Therefore, results from running emulated functions may not match production behavior.
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
    at assertPath (path.js:39:11)
    at Object.join (path.js:1157:7)
    at Object.readLogLines (/Users/mehrantm/.nvm/versions/node/v10.9.0/lib/node_modules/@google-cloud/functions-emulator/src/emulator/logs.js:33:39)
    at Controller.getLogs (/Users/mehrantm/.nvm/versions/node/v10.9.0/lib/node_modules/@google-cloud/functions-emulator/src/cli/controller.js:462:10)
    at Object.exports.handler (/Users/mehrantm/.nvm/versions/node/v10.9.0/lib/node_modules/@google-cloud/functions-emulator/src/cli/commands/logs/read.js:58:14)
    at Object.runCommand (/Users/mehrantm/.nvm/versions/node/v10.9.0/lib/node_modules/@google-cloud/functions-emulator/node_modules/yargs/lib/command.js:235:44)
    at Object.parseArgs [as _parseArgs] (/Users/mehrantm/.nvm/versions/node/v10.9.0/lib/node_modules/@google-cloud/functions-emulator/node_modules/yargs/yargs.js:1014:30)
    at Object.runCommand (/Users/mehrantm/.nvm/versions/node/v10.9.0/lib/node_modules/@google-cloud/functions-emulator/node_modules/yargs/lib/command.js:195:96)
    at Object.parseArgs [as _parseArgs] (/Users/mehrantm/.nvm/versions/node/v10.9.0/lib/node_modules/@google-cloud/functions-emulator/node_modules/yargs/yargs.js:1014:30)
    at Object.parse (/Users/mehrantm/.nvm/versions/node/v10.9.0/lib/node_modules/@google-cloud/functions-emulator/node_modules/yargs/yargs.js:542:25)

To fix this I switched the node to an older version by nvm use command:
$  nvm use 6.11.5
Now using node v6.11.5 (npm v3.10.10)

then I get this error when issued the command functions start:
$  functions start
Starting Google Cloud Functions Emulator...
ERROR: Error: Emulator crashed! Check the log file...
    at ChildProcess.child.on (/Users/mehrantm/.nvm/versions/node/v6.11.5/lib/node_modules/@google-cloud/functions-emulator/src/cli/controller.js:650:24)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:219:12)

and this is what I saw in logs:
functions logs read
    at new ConfigAdapter (/Users/mehrantm/.nvm/versions/node/v6.11.5/lib/node_modules/@google-cloud/functions-emulator/src/model/functions.js:41:23)
    at new Functions (/Users/mehrantm/.nvm/versions/node/v6.11.5/lib/node_modules/@google-cloud/functions-emulator/src/model/functions.js:134:22)
    at Object.exports.functions (/Users/mehrantm/.nvm/versions/node/v6.11.5/lib/node_modules/@google-cloud/functions-emulator/src/model/index.js:22:34)
    at new Emulator (/Users/mehrantm/.nvm/versions/node/v6.11.5/lib/node_modules/@google-cloud/functions-emulator/src/emulator/emulator.js:27:29)
    at Object.main (/Users/mehrantm/.nvm/versions/node/v6.11.5/lib/node_modules/@google-cloud/functions-emulator/src/emulator/main.js:120:20)2018-08-29T23:05:19.031Z - error: uncaughtException: EACCES: permission denied, open<EMAIL_ADDRESS>You don't have access to this file.

as you see it was a permission issue in accessing my user to the emulator config folder.
the solution was easy. you need to go to ~/.config/configstore/@google-cloud/functions-emulator folder and remove all json files.
so the next time I entered functions start it started working.
here is the output when it successfully runs:
$  functions start
Starting Google Cloud Functions Emulator...
Google Cloud Functions Emulator STARTED
No functions deployed ¯\_(ツ)_/¯. Run functions deploy --help for how to deploy a function.


fix: small typo 'ssr' -> 'csr'

this is a one character change in the tutorial

This isn't a typo. It's saying, similarly to how you can use the ssr page option to disable server-side rendering (mentioned in the previous section), you can also use csr to disable client-side rendering.


Add proxy support to slack alert

Add proxy support to slack alerter, by setting the option slack_proxy

Looks good. Could you add in a section into the docs as well?

@Qmando it's done :)


fact(document_change): simplify nvim to vscode change sync

This continues the work from https://github.com/vscode-neovim/vscode-neovim/pull/1567. I will probably not have time to test this, so @xiyaowong feel free to take over this PR and add your own commits.
Fixes https://github.com/vscode-neovim/vscode-neovim/issues/1068
Should also speed up editing?
Ideas: don't use generator, don't use text.split.

Unfortunately, while this is still very fast, on VERY large files, it seems as though the old implementation is much faster at applying diffs caused by %s.
Not sure if this is acceptable, or if we should improve the algorithm.

Some tests have been done, and in the case of large text and a lot of updates, at least it is faster than the terminal nvim (not clean).I tried to do some optimization, but I found that the bottleneck was in the process of diff.

Ideas: don't use generator, don't use text.split.

They are all very cheap.

Even if this is a bit slower for some cases, having simpler code could encourage more improvements in the future.

I think this speed is acceptable. It takes no more than 3 seconds to use %s/this/that/g to replace 3000 places in a 20,000-line file. It takes about 200ms to perform simple addition, deletion and surrounding operations in a 300,000-line file.
I know this has to do with device performance. But these differences are only noticeable in VERY large files, but in this case there is no difference between very slow and slower

Good to merge then. Do you think the extra boilerplate for LazyLineLengths is worth it? The simple implementation of pre-accumulating the line lengths for the entire buffer instead of on-demand (for binary search) does have less code, and I don't know how much of a performance difference it makes.

Good to merge then. Do you think the extra boilerplate for LazyLineLengths is worth it?

At the beginning of the discussion, I originally wanted to say that I would prefer version 2, because version 3 brings little performance improvement, but the code becomes obviously "verbose". But seeing that you created this PR quickly, I withdrew my comment.

little performance improvement

Can actually be ignored

I have no problem deleting unnecessary code.

In any case, this PR should be the biggest improvement in recent times👍

… while this is still very fast, on VERY large files

How did you test/measure and what do you mean by very large?
(My test may be a little bit extreme and for sure unrealistic, but applying neovim edits to sqlite3.c amalgamation is still >30s. If you're looking for a large file, look no further 😀 )

❤

@theol0403 Verified https://github.com/vscode-neovim/vscode-neovim/issues/829 does not regress. Thanks for keeping that in mind!