cmake_* tests don't use the build system's compiler

When building I set the compiler with the -DCMAKE_<LANG>_COMPILER=<path> option. Some tests generate new projects with CMake but don't make use of the compiler that I want CMake to use. I suspect that this isn't an issue for people who use the CC/CXX enviroment variables (or any equivalent on non-Linux systems).
Steps to reproduce:

Have a Linux environment that by default only has an unsupported compiler. I use CentOS6, which has GCC 4.4.7 by default.
Install a compiler toolchain in a non-PATH location. I use the devtoolset-8 package from the SCLo RPM stream which provides a GCC 8.2.1 based toolchain located at /opt/rh/devtoolset-8/root/usr/bin/{gcc,g++}
Download the source code and try to build it, setting the C++ and C compilers with -DCMAKE_CXX_COMPILER=<path to g++> and -DCMAKE_C_COMPILER=<path to gcc>
Compile project
Run test with CTest. The tests that create new CMake projects should fail because they will pick up the system GCC (4.4.7).

A patch I made and tried on my Cent6 environment:
diff --git a/test/cmake_add_subdirectory/CMakeLists.txt b/test/cmake_add_subdirectory/CMakeLists.txt
index ad04547e7d1c3943781a7e119c7372eaf74a1274..6126033de59ab0b2d0b683ec7485c8932a07c94c 100644
--- a/test/cmake_add_subdirectory/CMakeLists.txt
+++ b/test/cmake_add_subdirectory/CMakeLists.txt
@@ -3,6 +3,8 @@ add_test(NAME cmake_add_subdirectory_configure
     -G "${CMAKE_GENERATOR}"
     -Dnlohmann_json_source=${PROJECT_SOURCE_DIR}
     ${CMAKE_CURRENT_SOURCE_DIR}/project
+    -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
+    -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
 )
 add_test(NAME cmake_add_subdirectory_build
   COMMAND ${CMAKE_COMMAND} --build .
diff --git a/test/cmake_import/CMakeLists.txt b/test/cmake_import/CMakeLists.txt
index 911c342c6ded16a057d16480e9a7c05eafb0cd23..ec660378cdfccbbc8a79f9b02df1ad09e529f2b4 100644
--- a/test/cmake_import/CMakeLists.txt
+++ b/test/cmake_import/CMakeLists.txt
@@ -3,6 +3,8 @@ add_test(NAME cmake_import_configure
     -G "${CMAKE_GENERATOR}"
     -Dnlohmann_json_DIR=${PROJECT_BINARY_DIR}
     ${CMAKE_CURRENT_SOURCE_DIR}/project
+    -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
+    -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
 )
 add_test(NAME cmake_import_build
   COMMAND ${CMAKE_COMMAND} --build .
diff --git a/test/cmake_import_minver/CMakeLists.txt b/test/cmake_import_minver/CMakeLists.txt
index 8cef2fabb4c29198bf6791a0f86dc1a11cf6d7f8..eb7e6906d513dd3ba868d6ffb1d8aa294959bc6a 100644
--- a/test/cmake_import_minver/CMakeLists.txt
+++ b/test/cmake_import_minver/CMakeLists.txt
@@ -3,6 +3,8 @@ add_test(NAME cmake_import_minver_configure
     -G "${CMAKE_GENERATOR}"
     -Dnlohmann_json_DIR=${PROJECT_BINARY_DIR}
     ${CMAKE_CURRENT_SOURCE_DIR}/project
+    -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
+    -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
 )
 add_test(NAME cmake_import_minver_build
   COMMAND ${CMAKE_COMMAND} --build .

I get unrelated failures referencing "issue #186 miloyip/nativejson-benchmark: floating-point parsing" but I will explore those in a separate issue if appropriate.

Bad bot

@Tridacnid Why not post your patch as a PR?

Agh, stop. I'm doing that patch, promise.


push trained model weights for 0_baseline_LSTM and 2_multitask_dense …

…with new features from #177. The only manual edit that I made was to change the num_replicates parameter from 1 to 10 in the _targets.R file, then I ran the model to create the weights

I've linked #176 to this PR since we've committed training weights for 10 model replicates here.


DataLake Management: List Method not found

[Enter feedback here]
I can use Get method to get special job, but List is not work, and I got this error:
System.Private.CoreLib: Exception while executing function: MonitorNewCosmosJobData. PipelineRunningStatusMonitoring: Method not found: 'Microsoft.Rest.Azure.IPage`1<Microsoft.Azure.Management.DataLake.Analytics.Models.JobInformation> Microsoft.Azure.Management.DataLake.Analytics.JobOperationsExtensions.List(Microsoft.Azure.Management.DataLake.Analytics.IJobOperations, System.String, Microsoft.Rest.Azure.OData.ODataQuery`1<Microsoft.Azure.Management.DataLake.Analytics.Models.JobInformation>, System.String, System.Nullable`1<Boolean>)'.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 87470cd8-1a2e-10db-91f1-ab3487c7d947
Version Independent ID: baf74f1c-bcf1-ce0c-ce3a-f21771f70e71
Content: JobOperationsExtensions.List Method (Microsoft.Azure.Management.DataLake.Analytics) - Azure for .NET Developers
Content Source: xml/Microsoft.Azure.Management.DataLake.Analytics/JobOperationsExtensions.xml
Service: data-lake-analytics
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Data Lake Storage Gen2:0.26028025,Cognitive - Text Analytics:0.108503014,Extensions:0.08948691'

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

@TANGLIHUI
Hi in response to your questions, I think there is an error in the assignment of your "accountName" parameter, I can help more if you can provide more code details


[dvsim] Ctrl-C now waits 10 seconds

If you start a dvsim run and immediately hit Ctrl-C, you'll see something like this:
INFO: [StatusPrinter]           [   legend    ]: [Q: queued, D: dispatched, P: passed, F: failed, K: killed, T: total]
INFO: [StatusPrinter] 00:00:00  [    build    ]: [Q: 0, D: 1, P: 0, F: 0, K: 0, T: 1]   0%
^CINFO: [Scheduler] Received SIGINT. Exiting gracefully. Send another to force immediate quit (but you may need to manually kill child processes)
INFO: [StatusPrinter] 00:00:10  [    build    ]: [Q: 0, D: 0, P: 0, F: 0, K: 1, T: 1] 100%
INFO: [StatusPrinter] 00:00:10  [     run     ]: [Q: 0, D: 0, P: 0, F: 0, K: 1, T: 1] 100%
INFO: [FlowCfg] [results]: [chip]:

We used to stop immediately, but it seems that recent changes to the scheduler/launcher/dispatcher (I'm not sure which bit) have broken things.
@sriyerg: I think this was your change. Could you take a look and see whether there's something simple to fix things?

In my last change, I removed the sys.exit(1) call after self._kill() when SIGINT is detected, to prevent dvsim from immediately exiting. The rationale was to allow the status indicating whatever passed or failed before the user interrupted, and the final results table to be printed (i.e. all the reports to be generated) before exiting.
As is turns out, when stop_now.set() is called, the stop_now.wait() returns vacuously, rather than actually waiting for the set timeout. This makes sense from the threading.Event usage point of view, but has a side effect in our case - the while True loop ends up spinning with 0 delay, causing a the loop contents to execute a ~million times. The poll() returns False, because no jobs are running. The only thing stopping the loop it is the next print interval at 10s. From the profile data:
   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
    365/1    0.001    0.000   10.622   10.622 {built-in method builtins.exec}
        1    0.000    0.000   10.622   10.622 dvsim.py:5(<module>)
        1    0.000    0.000   10.424   10.424 dvsim.py:598(main)
        1    0.000    0.000   10.025   10.025 FlowCfg.py:362(deploy_objects)
        1    1.412    1.412   10.002   10.002 Scheduler.py:115(run)
   968345    0.427    0.000    2.180    0.000 threading.py:556(wait)
   968346    0.661    0.000    1.899    0.000 Scheduler.py:389(_dispatch)
  1936694    0.734    0.000    1.736    0.000 Scheduler.py:16(sum_dict_lists)
   968346    0.407    0.000    1.425    0.000 Scheduler.py:338(_poll)
   968344    1.033    0.000    1.362    0.000 Scheduler.py:459(_kill)
   968346    0.495    0.000    1.322    0.000 Timer.py:27(hms)

When the print interval is reached, the check_if_done() determines that we are indeed done, and only then we exit.
Thanks for reporting - this is fixed with #6245.


Update overview-managed-identity.md

Remove the "preview" note for App Service Linux and Web App for Containers.

@yiliaomsft : Thanks for your contribution! The author, @mattchenderson, has been notified to review your proposed change.

@yiliaomsft Since you're internal and down the hall from me :), this should have been done in the PR repo against a release branch. This has not yet been announced.
#please-close


Overseerr link needs update

https://github.com/Feramance/qBitrr/blob/25cba250e35eae4b616003f96df40b2ef6c34674/qBitrr/arss.py#L615
I noticed errors on my overseer connection.  The URI is appended with /api/v1/request, it looks as thought this has been upgraded to v2

Hi, what version of Overseerr are you using as the endpoint seems to be /api/v1 for me still?

Hello,
I'm running 1.33.2.

What is the response you get if you enter the URL manually on your browser?

Can you try running {self.overseerr_uri}/api/v1/request in your browser? Substituting {self.overseerr_uri} with your overseerr url (ip:port)

It was a port issue.  Completely my fault.  Sorry for wasting your time.

No worries, glad to hear all is well


Navigating to a different page causes useInfiniteQuery to drop previous queries even with useInfiniteQuery being in an _app level provider

Hey, I'm not sure what I'm doing wrong. I am using next.js with a provider at the _app level.  The infinite query portion works great (thanks btw!) with the code below:
  const listingsSearchQuery = useInfiniteQuery<SearchListingResults, [string, string], number>(
    ['listings', listingQuery],
    fetchListings,
    {
      getFetchMore: (lastGroup, allGroups) => {
        return lastGroup.nextCursor;
      }
    }
  );

The problem is navigating to a new page causes the data to be lost:

I'm not sure what I'm doing wrong but I'd greatly appreciate your help! Thanks!

Can you publish an example? E.g. using Codesandbox?

@cherniavskii working on it but codesandbox is choking on useRouter from next/router so I'm not sure how applicable the environment will be.
https://codesandbox.io/s/objective-swartz-1hemi?file=/components/Link.js

You could fork one of the existing code sandbox examples that use next. They are set up correctly and everything
On Apr 19, 2020, 6:04 PM -0600, Chance<EMAIL_ADDRESS>wrote:

@cherniavskii working on it but codesandbox is choking on useRouter from next/router so I'm not sure how applicable the environment will be.
https://codesandbox.io/s/objective-swartz-1hemi?file=/components/Link.js
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

@tannerlinsley For some reason it just magically started working. Sorry,  I should have corrected that; I was hoping I got the delete in before pestering yall :)

No worries!

Sorry I meant the sandbox, I'm still having issues on my end.

Ah

So the issue with the sandbox is it's running out of memory. Nextjs + Material-UI may be a bit too much for it or there's a memory leak in how it's setup.
I'm going to go ahead and close this until I can narrow the issue down further or I can get a functioning sandbox setup. It could be that the open API I chose to replicate this is pushing back too much data. But that was the best API I could find with any sort of cursor in the response and I was hoping to mirror it up as best I can. I'll likely need to just setup my API somewhere so I can use that in the sandbox instead.

Ugh, I figured it out feel silly. I'm dropping this here incase anyone else happens to run into the same issue.
The problem was using a dynamic next/link without using as=.
Switching this:
<Link href={`listing/${listing.slug}`}>

with this:
<Link href="listing/[listingPath]" as={`listing/${listing.slug}`}>

solved my problem. I only had to rebuild my app to figure it out <sigh>

Ooof! So sorry mate!

@tannerlinsley heh, thanks :)
I should note that it had nothing to do with react-query. Neglecting as= was causing next/react to do a hard load.


v4 clearfix on .card-{block,header,footer} breaks flex layouts

In latest v4-dev branch, the clearfix mixin is added on all the card subcomponents.
If the subcomponent is added a flex display, the :after pseudo added by the mixin adds unwanted  spacing at the end of the flex block's main axis.
.card-footer {
  display: flex;
  justify-content: space-between;
  align-items: center;
}

Space Oddity

David Bowie ✝

    Release: 1969

I think the mixin should be guarded by a @if(not $enable-flex) block;

I think you meant class="card-subtitle"

X-Ref: #18655

@ju1ius I can't seem to reproduce any difference in spacing on either Chrome or Firefox on OS X between Flexbox and non-Flexbox cards. Are you using some other browser? Could you post a JS Bin or JS Fiddle that demonstrates the difference?
Flexbox example: https://jsfiddle.net/6ancmdx0/6/
Non-Flexbox example: https://jsfiddle.net/t9rnra28/3/

Hi @cvrebert!
You appear to have posted a live example (https://fiddle.jshell.net/t9rnra28/3/show/light/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

line 6274, column 7: E047: .btn should only be used on , <button>, <input>, or  elements.
line 6275, column 7: E047: .btn should only be used on , <button>, <input>, or  elements.
line 6252, column 5: W007: Found one or more <button>s missing a type attribute.
line 6257, column 5: W007: Found one or more <button>s missing a type attribute.
line 6260, column 5: W007: Found one or more <button>s missing a type attribute.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

Hi @cvrebert!
You appear to have posted a live example (https://fiddle.jshell.net/6ancmdx0/6/show/light/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

line 6824, column 7: E047: .btn should only be used on , <button>, <input>, or  elements.
line 6825, column 7: E047: .btn should only be used on , <button>, <input>, or  elements.
line 6802, column 5: W007: Found one or more <button>s missing a type attribute.
line 6807, column 5: W007: Found one or more <button>s missing a type attribute.
line 6810, column 5: W007: Found one or more <button>s missing a type attribute.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

Here are the updated examples:
Without fix:
Flexbox: https://jsfiddle.net/6ancmdx0/7/
Non-Flexbox: https://jsfiddle.net/t9rnra28/5/
With fix:
Flexbox: https://jsfiddle.net/6ancmdx0/9/
Non Flexbox: https://jsfiddle.net/t9rnra28/6/
In all examples, I added
.card-footer {
  display: flex;
  justify-content: space-between;
}

Expected result: the first child of .card-footer should be aligned to the left of it's parent padding-box, and the last child to the right.
The issue is with the code in scss/_card.scss on line 83.
.card-footer {
  @include clearfix;
  // ...
}

It adds an ::after pseudo element with display: table to the .card-footer element.
If I then add display: flex to the .card-footer, the ::after pseudo becomes a flex-item, thus breaking the desired alignment.
That's why the code in the above-mentioned file should be...
.card-footer {
  @if (not $enable-flex) {
    @include clearfix;
  }
  // ...
}

...idem with .card-header, .card-block, and probably also in other places in the framework.
Because if I enable the flexbox option, I don't need to clear floats that don't exist ! :wink:
And after a quick look at the card component, I can't see a reason for these clearfixes, since nothing is floated. Maybe they could be removed entirely ?

Hi @ju1ius!
You appear to have posted a live example (https://fiddle.jshell.net/t9rnra28/6/show/light/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

line 6292, column 7: E047: .btn should only be used on , <button>, <input>, or  elements.
line 6293, column 7: E047: .btn should only be used on , <button>, <input>, or  elements.
line 6270, column 5: W007: Found one or more <button>s missing a type attribute.
line 6275, column 5: W007: Found one or more <button>s missing a type attribute.
line 6278, column 5: W007: Found one or more <button>s missing a type attribute.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

Hi @ju1ius!
You appear to have posted a live example (https://fiddle.jshell.net/6ancmdx0/9/show/light/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

line 6841, column 7: E047: .btn should only be used on , <button>, <input>, or  elements.
line 6842, column 7: E047: .btn should only be used on , <button>, <input>, or  elements.
line 6819, column 5: W007: Found one or more <button>s missing a type attribute.
line 6824, column 5: W007: Found one or more <button>s missing a type attribute.
line 6827, column 5: W007: Found one or more <button>s missing a type attribute.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

Hi @ju1ius!
You appear to have posted a live example (https://fiddle.jshell.net/t9rnra28/5/show/light/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

line 6292, column 7: E047: .btn should only be used on , <button>, <input>, or  elements.
line 6293, column 7: E047: .btn should only be used on , <button>, <input>, or  elements.
line 6270, column 5: W007: Found one or more <button>s missing a type attribute.
line 6275, column 5: W007: Found one or more <button>s missing a type attribute.
line 6278, column 5: W007: Found one or more <button>s missing a type attribute.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

Hi @ju1ius!
You appear to have posted a live example (https://fiddle.jshell.net/6ancmdx0/7/show/light/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

line 6843, column 7: E047: .btn should only be used on , <button>, <input>, or  elements.
line 6844, column 7: E047: .btn should only be used on , <button>, <input>, or  elements.
line 6821, column 5: W007: Found one or more <button>s missing a type attribute.
line 6826, column 5: W007: Found one or more <button>s missing a type attribute.
line 6829, column 5: W007: Found one or more <button>s missing a type attribute.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

Thanks @twbs-lmvtfy, nut this is irrelevant to the issue.  :innocent:

And after a quick look at the card component, I can't see a reason for these clearfixes, since nothing is floated. Maybe they could be removed entirely ?

I believe they are needed because users might choose to include floated things in the card. See the first card in my earlier examples, and #18655.

In all examples, I added

Ah, I hadn't been clear on the fact that custom CSS was needed to trigger the problem.

Hmm, but even with Flexbox enabled, the Card itself is still display:block by default.
This is above my CSS paygrade. Gonna leave this one to @mdo.

I believe they are needed because users might choose to include floated things in the card. See the first card in my earlier examples, and #18655.

I'm also suspecting a «clearfix all the things just in case» syndrom.
In this case I think the mixins calls should be removed since:

People usually know why, where & when to clear floats, and there's an utility class for that.
It interferes with display: flex on mentioned card subcomponents

Apparently the plan is to Flexbox-ify all the things (https://github.com/twbs/bootstrap/issues/18901#issuecomment-172294024), so #18851 sounds reasonable, FWIW.

And after a quick look at the card component, I can't see a reason for these clearfixes, since nothing is floated. Maybe they could be removed entirely ?

It does not really matter if something is floated in there. In this example, the button styled via pull-xs-right is floated to the right (float:right !important) but shows on the left side of the box. This is because its computed value is float:none. In a "flex" context, float has no effect, hence there is no need for clearfix.

Hi @thierryk!
You appear to have posted a live example (https://fiddle.jshell.net/6ancmdx0/7/show/light/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

line 6843, column 7: E047: .btn should only be used on , <button>, <input>, or  elements.
line 6844, column 7: E047: .btn should only be used on , <button>, <input>, or  elements.
line 6821, column 5: W007: Found one or more <button>s missing a type attribute.
line 6826, column 5: W007: Found one or more <button>s missing a type attribute.
line 6829, column 5: W007: Found one or more <button>s missing a type attribute.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)


Packing on Win / Filenames too long

Dear all,
having got the build finally running, UR editor opens Carla. I was trying to build a standalone by using "packaging->win64" and get errors while "cooking". Going through the logs I find:
CookResults: Error: Couldn't save package, filename is too long: D:/git/carla/carla/Unreal/CarlaUE4/Saved/Cooked/WindowsNoEditor/CarlaUE4/Content/Carla/Static/Pedestrians/Materials/Textures/ModelBased/femaleSkirtShirt/Female_Skirt_Shirt_SBoots_femaleDummy2_hair_mat_OcclusionRoughnessMetallic.uasset
A Windows Classic! Has anyone every packaged on WIndows 10? If so, what is your root level where you put git / carla etc. (I have long filename paths enabled in Win10, BTW).
Thanks,
Andreas

Hi @grafandreas,
It's not your computer problem. When packing, Unreal has a maximum file length of 260, that sometimes, fails anyway. My only suggestion is that you should work in C:/carla/ for now.
@TheNihilisticRobot is working on it but renaming assets is not easy because it must be done inside Unreal Editor and looks like it must be done by hand.
Anyway, it's true that we have inconsistent and redundant paths/naming on certain files of our project like:

Filenames ended in OcclusionRoughnessMetallic.uasset that can be changed to something like ORM.uasset. Also other image types like _Normal to _n and so on.

Repeated filenames like:
see Bl_House_SantaClaraSuburb009
Bl_House_SantaClaraSuburb009_Bl_House_SantaClaraSuburb009_Frames_OcclusionRoughnessMetallic.uasset

Redundant folders and filenames like:
see FemaleSkinnyJeans and Female_SkinnyJeans
FemaleSkinnyJeans/Female_SkinnyJeans_Tshirt_Boots_femaleDummy3_bottom_mat_OcclusionRoughnessMetallic.uasset

Inconsistent id naming like:
see 9 and 009
.../SntaClara_SuburbHouse_9/1024/Bl_House_SantaClaraSuburb009_Bl_House_SantaClaraSuburb009_Walls_OcclusionRoughnessMetallic.uasset

Different naming styles (CamelCase, pascalCase, ...) like:
see ModelBased, femaleDress, Female_Dress and shoes_mat
.../Textures/ModelBased/femaleDress/Female_Dress_Shoes_femaleDummy1_shoes_mat_Normal.uasset

I'm sure at some point the artist team will rename everything correctly!
Cheers

Blueprints/Vehicles/BmwGrandTourer/BmwGranTourer.uasset

Are there any news concerning this issue? I am currently working directly on D:\ otherwise i'll get the same file name is too long error as mentioned above. But as we share a desktop among multiple users, this is not the best way to go.

Hey @Sakrust
Which Carla version are you using? Our artists fixed it for 0.9.x some time ago, but we are pending to upload the assets because of other reasons :(

Version 0.9.0, thanks!

@Sakrust Sorry for the late response, we are really busy these days :(
This will be fixed in 0.9.1 that will be available soon! :)

Is this 256 character limit still true in 2019/11?

Is this 256 character limit still true in 2019/11?

its still true in 2024/12 :')


Expose the forceUpgradeRacks from the cassdc CRD

We'd need to enable easy access to forcing racks to upgrade when they get stuck in a bad state and cannot recover.
The field should be exposed in the CassandraDatacenterTemplate type with the forceUpgradeRacks name.
Its value should be a list of string values, for each rack that is targeted.
### Definition of Done
- [ ] `forceUpgradeRacks` from the cassdc spec is exposed in the CassandraDatacenterTemplate and mapped appropriately during a reconcile.

Related, which would make this feature obsolete in k8ssandra-operator: https://github.com/k8ssandra/cass-operator/issues/583


Directory not created on installation

The directory that's referred to here:

Copy Knowtator-2.0.jar to Protege.X.X/plugins/

...wasn't created when I installed Protege.

Hmm... that directory is created when I installed Protege 5.2.0 Desktop for windows. On a Mac, where would you install plugins for Protege to?

I don't know where they currently think they're going.  Want to look at it on my machine?  Email me.

See the Mac installation section in the README.md


Create replay.attributes.events.md

Initial creation populated with fields from my local files.

heroesjson.com confirms a few things.
https://github.com/Sembiance/heroesjson also has issues open pertaining to skins.json and mounts.json which could prove useful.


Bug: when creating a release version that uses EncryptedSharedPreferences, getting a warning of "Missing classes detected while running R8."

This:
https://issuetracker.google.com/issues/195752905

I think adding "-dontwarn com.google.errorprone.annotations.Immutable" should be fine. This annotation is only needed to generate compile-time warnings, and it is not needed at run-time.
I don't have a better solution than adding this "dontwarn" line. I'll close this now, please re-open if there is a problem with this.


Package renaming request

Hi @NoArtistAvailable,
Favo from OpenUPM - a platform collects open-source UPM packages. First of all, thanks for creating this awesome open-source package. I am writing to you because OpenUPM is preparing to comply with Unity's Terms of Services (TOS) Updates. Your package is available on our platform, and I need your help to make some changes.
According to the Unity Package Manager Naming Convention, the package name should use reverse domain name notation, at least 3 sections joined by a dot: tld.org-name.package-name. For example com.littlebigfun.addressable-importer.

tld is the top-level domain, like com, org and so on. If you're not sure about what to use, please use com.
org-name is your organization name. With tld together it makes sure the organization name is globally unique to its registered owner. You should avoid using a tld and org-name combination that may be confusing to users, like com.unity or com.github.
package-name is your package name.

Your package name is elzach.extensions. I recommend you to update it to comply with the naming convention by,

change the package name in package.json.
bump the version field of package.json.
create a Git tag.

Please reply to me if you've made the change, I will update the OpenUPM side to make it live.
If you do not respond to the issue, It will be closed by the end of Jan 2021, and your package will be removed from our platform. Please notice that Unity Package Guiding Principles & Guidelines do not apply to you when you host Packages on GitHub for Unity users to download and put the Packages in their projects, as long as the hosted Package does not, directly or indirectly, leverage the Unity Editor as a marketing or distribution platform. Thus, you don't have to change anything if you don't intend to publish the package on a scoped registry (like OpenUPM).
Sorry for the inconvenience, feel free to discuss with me if you have any questions.
BR
Favo

I updated the package.json to now refer to the package name as com.elzach.extensions.

I updated the package.json to now refer to the package name as com.elzach.extensions.

Thanks for the update. Your package is available at https://openupm.com/packages/com.elzach.extensions/.

Thanks for the update. Your package is available at https://openupm.com/packages/com.elzach.extensions/.


chore(sequencing): remove ProposalChunk

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2512  👈 (View in Graphite)
#2510
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 10, 9:07 AM EST: A user started a stack merge that includes this pull request via Graphite.


Update ci build badge

Update the ci build badge. Currently it's using appveyor.

You can take badges structure from here https://github.com/destructurama/attributed


#20 - rewrite on react

write zero angular functionality to react

add simple todo with react/redux


1398 execution reverted should be returned to provider

Returns the JsonRpcError in the eth_estimateGas.
Related issue(s):
Fixes #1398

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.03 :tada:

Comparison is base (657b40f) 78.94% compared to head (63d1916) 78.97%.

:exclamation: Current head 63d1916 differs from pull request most recent head 76f98f1. Consider uploading reports for the commit 76f98f1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1424      +/-   ##
==========================================
+ Coverage   78.94%   78.97%   +0.03%
==========================================
  Files          19       19
  Lines        2052     2055       +3
  Branches      438      439       +1
==========================================
+ Hits         1620     1623       +3
  Misses        295      295
  Partials      137      137

Impacted Files
Coverage Δ

packages/relay/src/lib/eth.ts
85.09% <100.00%> (+0.05%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@ebadiere We should go to fallback logic, if error from mirror-node is 400 and msg is empty. That means that there is probably a NPE in the mirror-node due to bug. It's temporary until all precompiles are implemented in the mirror-node and all bugs are cleared.


New template for Decomposition Tree visual and fixes for 3 issues

I have now realised that #26 asks for the list of options. The commit here provides a single example. I can respond to the issue later this week and post the options in a comment.

Thanks for contributing! I appreciate it.

Thanks for contributing! I appreciate it.

#26 is now fully closed. I am happy to be able to contribute. Do let me know if there is anything specific I could help with next. My plan was to keep adding all of the theming options around newly added PBI features.


All ESD profiles are deleting when removing just one

Agent Version
All supported with ESD
Operating System
N/A
OpenStack Release
All supported
Description
There is a bug in the case multiple ESDs are applied. The agent deletes all ESD profiles on the device (but not in Neutron) when any of the ESD’s are removed. This has led to downtime as the device configuration (iRule or profile, profile) is unexpectedly changed from the desired state.
Deployment
N/A

Partly, this is an ordering issue in the agent code. When we loop through the L7 policies to apply (whether they are ESD policies or not), we are not adhering the 'position' field of the policy. This dictates the priority of the policy itself. In the case of multiple policies, then subsequent policy that is evaluated can overwrite settings from prior policies applied. The other part of this issue is that we will have to determine whether multiple ESD policies should produce an aggregate result or if some other rules should apply.


Fix typos on gh-pages

Replaced suites with suits in suites my needs. Added a direct link to the issues page in open an issue Replaced hickups with hiccups

Hey there and thanks for the corrections.
One small comment, and I'm sure we can merge this.

Updated index.html to link to the new issue creator. I think it would be awesome to set up a default issue template.

Awesome. Merged!

I think it would be awesome to set up a default issue template.

Have it your way. I've added you to the workspacer organization ;)


Remove Workaround for RPi-Distro/pi-gen#682

As part of #38, I added a workaround for https://github.com/RPi-Distro/pi-gen/issues/682.  That workaround can now be removed.
As part of this fix, we should actually confirm that the issue is fixed by booting the new image to a real device.

Now fixed.


Update README.md

Thank you for your contribution! Because of previous contributions, this file has a merge conflict. I'll fix it myself for now and in a future meeting I'll explain what that is and show how you'd fix it yourself.


Timezone issue

Great initiative with the eloverblik helper!
I got it all setup and data is flowing into my InfluxDB, however there is some misalignment between the timestamp and the time interval from eloverblik. I'm assuming that it is a UTC -> DK Summertime issue.

Cool to see that it's running somewhere else.
But yeah this won't do. i have just made a minor tweak and it looks like it does the trick.
i had the same issue when i tested locally and it looks like it is fixed now, but let's wait with closing this until we know that it works as expected in "production".

Thanks for the swift update! It looks much better now!


Test dev examples

References and relevant issues
Alternative to #6763.
Description
Test dev examples to ensure they don't go out of sync.

@Czaki the failing example is related to 2d hash in labels... is it even relevant anymore? If so, could you fix it?

No. We have changed the hashing mechanism. I will try to check it tomorrow.

The current mechanism is totally different, so I think that whole example could be removed.

I don't liek the idea of having test-specific code in the examples... I'd rather just skip this one or refactor it ^^'

I don't liek the idea of having test-specific code in the examples... I'd rather just skip this one or refactor it ^^'

Hm. Looking to documentation, maybe we should just monkeypatch sys.argv?

A number of alterations are also made to the sys module. Firstly, sys.path may be altered as described above. sys.argv[0] is updated with the value of path_name and sys.modules[name] is updated with a temporary module object for the module being executed. All modifications to items in sys are reverted before the function returns.

What do you think of this version?

Fail seems unrelated.


email_mirror: Check that email gateway bot can send to the channel.

Otherwise this leads to an uncaught exception when the check happens later in check_message.

Looks good, merged, thanks @mateuszmandera!


Detect character encoding of datasets

@YohannParis reports an issue with this dataset when trying to profile it since it's not utf-8.
us-counties-2023.csv
The service errors with:
{
  "id": "extraction-97066793-d536-4dd1-92bc-600a11415aa7",
  "status": "failed",
  "result": {
    "created_at": "2023-08-21T13:35:52.195837",
    "enqueued_at": "2023-08-21T13:35:52.195896",
    "started_at": "2023-08-21T13:35:52.216881",
    "job_result": null,
    "job_error": "Traceback (most recent call last):\n  File \"/usr/local/lib/python3.10/site-packages/rq/worker.py\", line 1428, in perform_job\n    rv = job.perform()\n  File \"/usr/local/lib/python3.10/site-packages/rq/job.py\", line 1278, in perform\n    self._result = self._execute()\n  File \"/usr/local/lib/python3.10/site-packages/rq/job.py\", line 1315, in _execute\n    result = self.func(*self.args, **self.kwargs)\n  File \"/workers/./operations.py\", line 249, in data_card\n    dataset_response, dataset_dataframe, dataset_csv_string = get_dataset_from_tds(\n  File \"/workers/./utils.py\", line 148, in get_dataset_from_tds\n    dataframe = pandas.read_csv(dataset_file)\n  File \"/usr/local/lib/python3.10/site-packages/pandas/io/parsers/readers.py\", line 912, in read_csv\n    return _read(filepath_or_buffer, kwds)\n  File \"/usr/local/lib/python3.10/site-packages/pandas/io/parsers/readers.py\", line 577, in _read\n    parser = TextFileReader(filepath_or_buffer, **kwds)\n  File \"/usr/local/lib/python3.10/site-packages/pandas/io/parsers/readers.py\", line 1407, in __init__\n    self._engine = self._make_engine(f, self.engine)\n  File \"/usr/local/lib/python3.10/site-packages/pandas/io/parsers/readers.py\", line 1679, in _make_engine\n    return mapping[engine](f, **self.options)\n  File \"/usr/local/lib/python3.10/site-packages/pandas/io/parsers/c_parser_wrapper.py\", line 93, in __init__\n    self._reader = parsers.TextReader(src, **kwds)\n  File \"pandas/_libs/parsers.pyx\", line 550, in pandas._libs.parsers.TextReader.__cinit__\n  File \"pandas/_libs/parsers.pyx\", line 639, in pandas._libs.parsers.TextReader._get_header\n  File \"pandas/_libs/parsers.pyx\", line 850, in pandas._libs.parsers.TextReader._tokenize_rows\n  File \"pandas/_libs/parsers.pyx\", line 861, in pandas._libs.parsers.TextReader._check_tokenize_status\n  File \"pandas/_libs/parsers.pyx\", line 2021, in pandas._libs.parsers.raise_parser_error\nUnicodeDecodeError: 'utf-8' codec can't decode byte 0xf1 in position 87107: invalid continuation byte\n"
  }
}

This can be addressed by dynamically detecting the encoding prior to reading the CSV in pandas. See this notebook for reference on how to do this with chardet.

Yes, it would be helpful to get this information as part of metadata of a Dataset on TDS instead of testing on ta1-service?

Yes, it would be helpful to get this information as part of metadata of a Dataset on TDS instead of testing on ta1-service?

This is our perennial issue--since TDS doesn't ever "touch" the data it has no way to pull the encoding and store it. Would have to be TA1 service or the HMI server


Upload PDF Display Error

Seems to be due to the issue of the PDF file being too large?What is the supported file content size?

Running on the demo URL

Same issue here using url = https://www.mbie.govt.nz/dmsdocument/1650-initiation-report-hollow-gold-jewellery-from-italy-pdf

I am working on this

Same for me. Any update on your end?

Same over here. Any update on the "error" issue?

I think I might know why , I upload a paper with sevealr formulas and charts,I got an erroe,but when I upload a file just words ,then it would work correctly.However, I use it is for reading API books which include many formulas and charts,I pretty need this function.Again ,thanks for the developer of this project , you are really awsome.

I tried running the source code and found that an excessive number of tokens can lead to errors. The model's tokens are limited, perhaps due to the same reason

You can try reducing max_ token or use gpt-3.5 turbo        ```
completions = openai.ChatCompletion.create(
    #     model="gpt-3.5-turbo",
    #     temperature=0,
    #     messages=[
    #             {"role": "user", "content": prompt}
    #         ]
    # )
    # message = completions['choices'][0]['message']['content']

You can try reducing max_ token or use gpt-3.5 turbo
completions = openai.ChatCompletion.create(
        model="gpt-3.5-turbo",
        temperature=0,
        messages=[
                {"role": "user", "content": prompt}
            ]
    )
    message = completions['choices'][0]['message']['content']

You can try reducing max_ token or use gpt-3.5 turbo
completions = openai.ChatCompletion.create(
        model="gpt-3.5-turbo",
        temperature=0,
        messages=[
                {"role": "user", "content": prompt}
            ]
    )
    message = completions['choices'][0]['message']['content']

Thanks,that helps a lot , I`ll try it.


Winter 23 api update and update tests to use System.Assert class

Looks good. Thank you for your effort!


Make CHIP_ERROR a class type on Darwin

Problem
CHIP_ERROR is not a class type on Darwin, so we can't get nice location tracking for errors.
Change overview
Make it a class type.
Testing
Compiled the tree on Darwin.  Ran some tests that should log errors and saw that those errors had file/line info.

@woody-apple @Damian-Nordic @saurabhst @msandstedt @LuDuda Please take a look?


Some questions about style

In dark mode, code block comments are not distinguishable from the background.
The line height of list seems to be a little high. I compare with tiptap's live demo, and their lists seem to be not as high.

Thanks for reporting these issues. I’ll delve into them this afternoon, though they seem like an easy fix that will surely make its way into 2.6.0.

I've reduced the padding a bit between editor components and fixed the code block; however, the padding heavily depends on @Tailwind/Typography.

It's better than before.
Well, I like more compact layout personally but someone maybe don't. Can line height be adjustable?

I've reduced the padding a bit between editor components and fixed the code block; however, the padding heavily depends on @Tailwind/Typography.

Well, it's also acceptable. Thanks for your amazing work!


Make adding new entries easier

Other than the issue #1 , improve documentation to make it easier for third party scripts to modify foo.

TODO: Ask someone unfamiliar with the project whether they understand the documentation.

Also, add formal grammar for foo.

Also, add formal grammar for foo.

Done.

Since I have received no negative feedback thus far, I will close this issue now.


Added manage_service boolean

This adds an extra boolean flag that provides the possibility to manage the systemd service outside of this module (disable any systemd behaviour). This gives more freedom in configuring its service parameters.
In my case I'd like to manage the service using eyp/systemd which gives me. E.g. I'd like to put the extra required flags (such as LimitNOFILE and LimitNPROC)  into a drop-in (also supported by the eyp/systemd module).
BTW the existing template as is, is not working with sonarqube 8+ (as it requires double amount of LimitNOFILE and LimitNPROC), while the current values are hard-coded into the template

Merged, thanks!


Give the collision engine fixed timedelta's

The collision backend is called with a timedelta depends on the unpredictable timedelta. This posses a problem for the replayablility of Geronimo's replays based on input per frame.
This PR fixes this issue.

The collision backend is called with a fixed time step (backend->update) the postUpdate only updates the node positions with backend positions, and uses sub-fixed time steps for that to be display frame correct.


Command Hyper does not work

Script which loads Hyper expects non null opts, so it'd be nice to include opts = {} in the installation example like this:
{
  'wet-sandwich/hyper.nvim',
  dependencies = { 'nvim-lua/plenary.nvim' },
  opts = {},
}

If opts are not passed lua raises an exception about missing opts when you try to run :Hyper.

Good catch, I thought I had that covered. I assume you're running the latest version from main and not a tagged release? I have some stuff in the works in main that hasn't been released yet and that is causing this issue. You might want to switch to a tagged version.

@wet-sandwich I was following the Installation guide in readme, so I suppose Lazy pulled the latest main indeed. Will try switching to latest tagged and check the issue there, thanks!


Downgrade to netcoreapp3.1

This change would make it easier for the .NET repo to use a build time dependency on the Test Proxy.
Also, netcoreapp3.1 is an LTS version whereas .NET 5.0 is not.

Do we need to update the docker file or some other infrastructure?

Do we need to update the docker file or some other infrastructure?

Good point - I think we would at least need to update:

https://github.com/Azure/azure-sdk-tools/blob/main/tools/test-proxy/docker/dockerfile
https://github.com/Azure/azure-sdk-tools/blob/main/tools/test-proxy/docker/dockerfile-win

though I'm not clear on how to actually test that the change is working.

Do we need to update the docker file or some other infrastructure?

Good point - I think we would at least need to update:

https://github.com/Azure/azure-sdk-tools/blob/main/tools/test-proxy/docker/dockerfile
https://github.com/Azure/azure-sdk-tools/blob/main/tools/test-proxy/docker/dockerfile-win

though I'm not clear on how to actually test that the change is working.

@scbedd will be checking on this.

Ci

I'll definitely help make changes on docker, but I'm seeing the following locally.

We need to update ci.yml to target 3.1
Update the targeted base docker image versions
Update the paths that copy dotnet-devcert out of the SDK -> runtime docker builds.

I'll help with any, but I don't have write permissions to the branch.

The CI is now passing. I think we still need to do #2 and #3.

Just a heads up I'm actively working on these docker issues. Hoping I'll have a fix sometime tomorrow.

@JoshLove-msft confirmed working. It's not the best solution, as it does expand our files somewhat, but I need to unblock you and powershell trusting isn't a silver bullet either.
We'd need to do a linux version of the importing that dotnet dev certs is doing on linux, and given that the powershell one isn't even working properly for me on windows, I don't want to delay your PR by some "I don't know until it's solved" measure.

@JoshLove-msft confirmed working. It's not the best solution, as it does expand our docker images somewhat, but I need to unblock you and powershell trusting isn't a silver bullet either.
We'd need to do a linux version of the importing that dotnet dev certs is doing on linux, and given that the powershell one isn't even working properly for me on windows, I don't want to delay your PR by some "I don't know until it's solved" measure.

For now we still have the dependency on 5.0 in the .NET repo, so I don't think it is urgent that we merge this.

For now we still have the dependency on 5.0 in the .NET repo, so I don't think it is urgent that we merge this.

The test-proxy is the last thing that requires it.

For now we still have the dependency on 5.0 in the .NET repo, so I don't think it is urgent that we merge this.

The test-proxy is the last thing that requires it.

Yes, but if this would break dev certs for linux, I don't think we should merge it yet.

For now we still have the dependency on 5.0 in the .NET repo, so I don't think it is urgent that we merge this.

The test-proxy is the last thing that requires it.

Yes, but if this would break dev certs for linux, I don't think we should merge it yet.

Or is everything currently working right now with the latest changes @scbedd?

@JoshLove-msft it's not an optimal solution but it's definitely working 100%. Confirmed by hitting up https://localhost:5001/Info/Available on my local box on both versions. We should be good with this merge.

/check-enforcer reset

/azp run tools - test-proxy - ci

/check-enforcer override


consult doesn't call initialization/1 directive goals

the consult JavaScript function doesn't call initialization/1 directive goals. For example, with:
session.consult( ":- initialization(write(hello))." );
session.query( "true." );
session.answers( x => console.log( pl.format_answer(x) ) );

we get:
$ node ./tp.js
true ;
false.

There seems to be some issue with that commit:
$ node --stack_size=5000 ./tp.js
/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:1548
		this.session.total_threads++;
		     ^

TypeError: Cannot read property 'total_threads' of undefined
    at new Thread (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:1548:8)
    at parseProgram (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:1024:18)
    at Thread.consult (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:2524:21)
    at Session.consult (/Users/pmoura/Documents/Logtalk/tp/node_modules/tau-prolog/modules/core.js:2420:22)
    at Object.<anonymous> (/Users/pmoura/Documents/Logtalk/tp/tp.js:12:9)
    at Module._compile (internal/modules/cjs/loader.js:1133:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1153:10)
    at Module.load (internal/modules/cjs/loader.js:977:32)
    at Function.Module._load (internal/modules/cjs/loader.js:877:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:74:12)

To reproduce the bug:
session.consult( ":- initialization(write(hello)). " );
session.query( "true." );
session.answers( x => console.log( pl.format_answer(x) ) );

Fixed!

But there's another bug: initialization/1 directives must be called only after a file is finished loading. In the current implementation, the initialization goals seem to being called as soon as the directives are parsed. The solution could be calling the initialization goals right before the query.

Initialization goals are stored into an array, and are called when the file is parsed:
var session = pl.create();
session.consult(`
:- initialization((p(X), write(X))).
p(a).
`); // a

But that's not standard behavior and it breaks existing code. The solution seems to be collecting all initialization goals from session.consult() calls and then call them when processing the session.query() call.

For example, in my case I'm using:
session.consult( "../logtalk3/adapters/unsupported/tau.pl" );
session.consult( "../logtalk3/paths/paths.pl" );
session.consult( "../logtalk3/core/core.pl" );
session.query( "true." );
session.answers( x => console.log( pl.format_answer(x) ) );

The core.pl file contains (as the last term) an initialization/1 directive. I get:
$ node --stack_size=5000 ./tp.js
true ;
false.

Logtalk 3.39.0(-)b01
Copyright (c) 1998(-)2020 Paulo Moura
...

You can see above that the query is processed before  the initialization goal is called (which is what prints, among other tasks, the Logtalk banner).

I see. But waiting for the query method doesn't seem the most appropriate. What if consult method accepts a list of files, and the initialization/1 directives are executed after the last file?

A simple example:
session.consult( ":- initialization((a(X), write(X)). a(hello)." );
session.consult( ":- initialization((b(X), write(X)). b(world)." );
session.query( "true." );
session.answers( x => console.log( pl.format_answer(x) ) );

We get:
$ node ./tp.js
true ;
false.

But the expected result would be:
$ node ./tp.js
helloworld
true ;
false.

I see. But waiting for the query method doesn't seem the most appropriate.

You're correct. The initialization goals must be called after the contents of the session.consult() call are fully parsed. I.e. after the "file" finished loading.

The initialization goals for a given file must be called after the file is loaded. Thus, if we have e.g. a list of two files, each with its own set of initialization/1 directives, the initialization goals for the first file must be called before parsing the second file and calling the second file initialization goals.

I am getting lost. That is what it currently does. Your example has a syntax error:
session.consult( ":- initialization((a(X), write(X))). a(hello)." );
session.consult( ":- initialization((b(X), write(X))). b(world)." );
session.query( "true." );
session.answers( x => console.log( pl.format_answer(x) ) );

$ nodejs tau.js
helloworldtrue ;
false.

Oops! Sorry for the syntax error. But I'm still not getting the expected semantics on the big example. Debugging....

... this is my code:
var session = pl.create( 20000 );
session.consult( "../logtalk3/adapters/unsupported/tau.pl" );
session.consult( "../logtalk3/paths/paths.pl" );
session.consult( "../logtalk3/core/core.pl" );
session.query( "logtalk_load(hello_world(loader))." );
session.answers( x => console.log( pl.format_answer(x) ) );

As the core.pl file contains an initialization/1 directive, which prints the banner and the default flags, I should that information printed before the query is run. The query is a call to load an example, that also contains initialization/1 directives. But I get instead:
$ node --stack_size=5000 ./tp.js
core silent(loading): loading_file('/opt/local/share/logtalk/core/expanding.lgt', [code_prefix($), clean(off), scratch_directory('/Users/pmoura/logtalk/scratch/'), optimize(on), report(off), reload(skip)])
core silent(loading): loading_file('/Users/pmoura/logtalk/examples/hello_world/loader.lgt', [])
core silent(compiling): compiling_file('/Users/pmoura/logtalk/examples/hello_world/loader.lgt', [])
core silent(compiling): compiled_file('/Users/pmoura/logtalk/examples/hello_world/loader.lgt', [])
core silent(loading): loading_file('/Users/pmoura/logtalk/examples/hello_world/hello_world.lgt', [])
core silent(compiling): compiling_file('/Users/pmoura/logtalk/examples/hello_world/hello_world.lgt', [])
core silent(compiling): compiling_entity(object, hello_world)
core silent(compiling): compiled_entity(object, hello_world)
core silent(compiling): compiled_file('/Users/pmoura/logtalk/examples/hello_world/hello_world.lgt', [])
core comment(loading): loaded_file('/Users/pmoura/logtalk/examples/hello_world/loader.lgt', [])
true ;
Hello World!
false.
core comment(loading): loaded_file('/Users/pmoura/logtalk/examples/hello_world/hello_world.lgt', [])
core comment(warnings): compilation_and_loading_warnings(0, 0)

All the lines above starting with core ... would not be there if the initialization goal from the core.pl file was called.

As we discussed elsewhere, the strange results above result from the initialization goals being handled asynchronously: the initialization goal in the core.pl file is still running when the initialization goal in the hello_world.lgt file starts to run. But the second initialization goal requires the first one to be completed. In general, if we're consult a list of files, each with its own initialization goal, these need to be completed before the next file is consulted in the list. Thus, it's not just initialization goals that need to be serialized but file consulting as well (if not already).

This is an important change in the consult process, since from now on the consult method is also an asynchronous process. consult accepts success option to be executed when the parsing is end, and  error option to report an error:
var session = pl.create(20000);
var err = function(error) { console.log(pl.format_answer(error, session)); };
session.consult("../logtalk3/adapters/unsupported/tau.pl", {success: function() {
    session.consult("../logtalk3/paths/paths.pl", {success: function() {
        session.consult("../logtalk3/core/core.pl", {success: function() {
            session.query("logtalk_load(hello_world(loader)).");
            session.answers( x => console.log( pl.format_answer(x) ) );
        }, error: err});
    }, error: err});
}, error: err});

The query method will also require this change due to the goal expansion.

How is this reflected in the consult predicate?

How is this reflected in the consult predicate?

The consult/1 built-in predicate should not be affected, since it was already asynchronous as it was incorporated into the Tau Prolog resolution logic.

But that's the problem. Consult cannot be asynchronous as a file may depend on a file loaded before. My understanding of that JavaScript snippet is that it provides a solution to make consult asynchronous. But that doesn't seem to be possible when using the consult/1 predicate.

But that's the problem. Consult cannot be asynchronous as a file may depend on a file that must complete loading before. My understanding of that JavaScript snippet is that it provides a solution to make consult synchronous. But that doesn't seem to be possible when using the consult/1 predicate.

consult/1 is asynchronous in the sense that the Tau Prolgo thread "falls asleep" until the file has finished loading, and then resolution continues.

Ok, let me do some experiments with your latest changes.

Nothing happens when using your snippet:
var session = pl.create( 20000 );
var show = x => console.log(pl.format_answer(x, session));
session.consult("../logtalk3/adapters/unsupported/tau.pl", {success: function() {
    session.consult("../logtalk3/paths/paths.pl", {success: function() {
        session.consult("../logtalk3/core/core.pl", {success: function() {
            session.query("logtalk_load(hello_world(loader)).");
            session.answers(show);
        }, error: show});
    }, error: show});
}, error: show});

I.e. the initialization goals are not called. The process exits almost immediately with no output.

Also, all consult/1 queries using the simple REPL code your posted in another issue now fail.

I tried this:
var session = pl.create(20000);
var show = x => console.log(pl.format_answer(x, session));
session.consult("a.pl", {success: function() {
    session.consult("b.pl", {success: function() {
        session.consult("c.pl", {success: function() {
            session.query("write(done), nl.");
            session.answers(show);
        }, error: show});
    }, error: show});
}, error: show});

nodejs tau.js
a
b
c
done
true.
false.

% a.pl
:- initialization((p(X), write(X), nl)).
p(a).

% b.pl
:- initialization((q(X), write(X), nl)).
q(b).

% c.pl
:- initialization((r(X), write(X), nl)).
r(c).

The other suggestion:
var session = pl.create( 20000 );
session.query(`
consult('/Users/pmoura/Documents/Logtalk/logtalk3/adapters/unsupported/tau.pl').
`);
session.answers(x => console.log(pl.format_answer(x, session)));

just result in:
$ node --stack_size=5000 ./tp.js
false.

I tried this:

I can reproduce your experiment and I get the same results as you. But when I replace the paths to the a.pl, b.pl, and c.pl files with the paths to the files that I'm trying to consult, I simply immediately get:
$ node --stack_size=5000 ./tau.js
$

Tried both relative paths, which I used successfully before, and absolute paths. Same results.

My suggestion for us to debug this issue is for you to clone the logtalk3 repo and then reproduce my results using:
var pl = require("./node_modules/tau-prolog/modules/core.js");
require("./node_modules/tau-prolog/modules/format.js")(pl);
require("./node_modules/tau-prolog/modules/js.js")(pl);
require("./node_modules/tau-prolog/modules/lists.js")(pl);
require("./node_modules/tau-prolog/modules/os.js")(pl);
require("./node_modules/tau-prolog/modules/random.js")(pl);
require("./node_modules/tau-prolog/modules/statistics.js")(pl);
//require("./node_modules/tau-prolog/modules/system.js")(pl);

var session = pl.create(20000);
var show = x => console.log(pl.format_answer(x, session));
session.consult("../logtalk3/adapters/unsupported/tau.pl", {success: function() {
    session.consult("../logtalk3/paths/paths.pl", {success: function() {
        session.consult("../logtalk3/core/core.pl", {success: function() {
            session.query("write(done), nl.");
            session.answers(show);
        }, error: show});
    }, error: show});
}, error: show});

You may need to adjust the paths.

Sorry, it was a bug with the op/3 directive. I just tried logtalk and now it works correctly.

Thanks for debugging the issue. I would never guessed a Tau bug in the op/3 directive! I will update and resume testing.

This (d84181b) is the last major change in the Tau Prolog interface. Thread.prototype.query becomes asynchronous due to goal expansion.  @pmoura  Hopefully this is the last change for your script: :smile:
var readlineSync = require("readline-sync");
var pl = require("./node_modules/tau-prolog/modules/core.js");
require("./node_modules/tau-prolog/modules/format.js")(pl);
require("./node_modules/tau-prolog/modules/js.js")(pl);
require("./node_modules/tau-prolog/modules/lists.js")(pl);
require("./node_modules/tau-prolog/modules/os.js")(pl);
require("./node_modules/tau-prolog/modules/random.js")(pl);
require("./node_modules/tau-prolog/modules/statistics.js")(pl);

var max_answers = process.argv[2] || 100;
var session = pl.create(50000);
var compose = (f,g) => x => f(g(x));
var show = x => console.log(pl.format_answer(x, session));
var repl = function() {
    var query = readlineSync.question("?- ", {keepWhitespace: true}) + "\n";
    session.query(query, {success: function(_goal) {
        session.answers(function(answer) {
            show(answer);
            if(answer === false || pl.type.is_error(answer))
                repl();
        }, max_answers);
    }, error: compose(repl, show)});
};
session.consult("../logtalk3/adapters/unsupported/tau.pl", {success: function() {
    session.consult("../logtalk3/paths/paths.pl", {success: function() {
        session.consult("../logtalk3/core/core.pl", {success: function() {
            repl();
        }, error: show});
    }, error: show});
}, error: show});

Thanks! I will use this update script going forward. I would like to include it in the Logtalk distribution. Can you suggest a comment header to give Tau Prolog proper credit? Logtalk itself is distributed under the Apache License 2.0.

Great! Please feel free to add the header that you consider appropriate. You can distribute it under the same Logtalk license.

Done. You can browse the file at https://github.com/LogtalkDotOrg/logtalk3/blob/master/integration/logtalk_tau.js
The file is used by the new taulgt script (if you're running Logtalk from the logtalk3 clone directory, you will need to use taulgt.sh instead after adding the $LOGTALKHOME/integration directory to your system PATH; see https://logtalk.org/running_developer_versions.html for details).
Experimenting with it, there's some strange interaction with multiple queries. For example:
?- {ack(loader)}.
% [ (/)Users(/)pmoura(/)logtalk(/)examples(/)ack(/)ack.lgt loaded ]
% [ (/)Users(/)pmoura(/)logtalk(/)examples(/)ack(/)loader.lgt loaded ]
% (0 warnings)
true ;
false.
?- ack::ack(2, 4, V).
V = 11 ;
false.
?- {aliases(loader)}.
false.

At this point, if I simply press return, I get the output from loading the second example and then the process exits:
?-
(*)     Singleton variables(:) [Variables(,) Variables]
*       while compiling object square('$VAR'(0))
*       in file (/)Users(/)pmoura(/)logtalk(/)examples(/)aliases(/)aliases.lgt at or above line (-)1
*
(*)     Singleton variables(:) [Variables(,) Variables]
*       while compiling object circle('$VAR'(0))
*       in file (/)Users(/)pmoura(/)logtalk(/)examples(/)aliases(/)aliases.lgt at or above line (-)1
*
% [ (/)Users(/)pmoura(/)logtalk(/)examples(/)aliases(/)aliases.lgt loaded ]
% [ (/)Users(/)pmoura(/)logtalk(/)examples(/)aliases(/)loader.lgt loaded ]
% 2 compilation warnings
$

Maybe an issue with readline-sync?


[move] Moves one-time check to coin

This PR changes the way we check for uniqueness of type.
Signature change:
types::is_one_time_witness(w: T) // OLD
types::is_one_time_witness(w: &T) // NEW

Check for type is performed only in coin::create_currency which creates separation between Balance (Supply) and Coin (TreasuryCap).

Coins can be still created from a non-checked Supply. That is a must for pool and RegulatedCoin scenarios.

However, if one needs to make sure that the type was created only once, they can write a function which consumes one-time-witness and add a check there. Alternatively, they can use TreasuryCap which by default guarantees uniqueness.
Actual changes:

ABC example in RegulatedCoin no longer relies on coin::create_currency and uses balance::create_supply insted
Similar logic is implemented for LSP currencies in the pool example

Targets #3771.


"negative" left and up movement fixed

I changed the logic for deciding where classes go when place because the way I did it was causing another issue with there being 100% cpu usage and ram usage after adding a bunch of classes and crashed the program.


L2: (prover) improve error handling

Provide better error handling for  the prover_client and  theprover_server.

Is this still open?


v1.4 – Redundant text/grammar – Scoop installation script

Notice the repetition of “required”, as well as “Press any key to continue”.
In this sentence, it should read “its” rather than “it's”.

Whoops...

A suggested version of the text, with the addition of describing ESC as the key to cancel (obviously needs the added functionality):
"This script will install Scoop and the dependencies required by WingetUI.
Press ESC to cancel, or any other key to continue."

Yes, might as well

This issue has been fixed, but I forgot to close it

A suggested version of the text, with the addition of describing ESC as the key to cancel (obviously needs the added functionality):

I've fixed a typo left. Also, I don't know how to implement the feature above

The correct grammar is still “its” rather than 'it's', and the sentence is still using two instances of 'required' – please consider using the suggested version repeated below.
This script will install Scoop and the dependencies required by WingetUI.
If the implementation of using ESC to cancel the script is not possible, well then that's that.

The correct grammar in the current version of the sentence is still “its” rather than 'it's', and there are still two instances of 'required' – please consider using the suggested version repeated below.
This script will install Scoop and the dependencies required by WingetUI.
If the implementation of using ESC to cancel the script is not possible, well then that's that.

@RavenMacDaddy, I've fixed that in https://github.com/martinet101/WingetUI/pull/226/commits/24206bafa600244db0b4e4e39133d213f6021d19, except implementing ESC to cancel

Haha, was about to say.
By now it's grammatically correct – appreciate your work @ppvnf.


CORS issue

Describe the bug
My backend is using dotnetcore 3.1 and my UI is using Angular 8.
Both of these are in different domains, i have CORS enabled in the backend and in Azure Portal -> SignalR Service i have the default configuration "*".
When trying to establish connection the initial POST for /testHub/negotiate fails due to CORS.
To Reproduce
My backend CORS configuration is:
(configure services)
services.AddCors();
services.AddSignalR().AddAzureSignalR(op => {
opt.ConnectionString = "...";
});
(configure)
app.UseCors(x => x
.AllowAnyMethod()
.AllowAnyHeader()
.AllowCredentials()
.SetIsOriginAllowed(x => true)
);
app.UseEndpoints(endpoints =>
{
endpoints.MapHub("/testHub");
endpoints.MapControllers();
});
Further technical details

Nuget package Microsoft.Azure.SignalR (1.5.1)
UI npm package @aspnet/signalr (1.1.4)

Issue was due to proxy. all is working now


pod continuously restarted because LivenessProbe port returns 404

What version of the operator are you using and what image?

@grs thank you.
I am using quay.io/interconnectedcloud/qdrouterd:1.5.0

With the qdrouterd-operator:latest you need to use
quay.io/interconnectedcloud/qdrouterd:1.6.0

Thank you @ajssmith
I will give it a try

close this issue because 1.6.0 works well


Navigator missing getMedia, getUserMedia, mozGetUserMedia, msGetUserMedia

https://developer.mozilla.org/en-US/docs/Web/API/Navigator/getUserMedia

This need to be fixed in closure-compiler repository.
The functions have to be added to google/closure-compiler/blob/master/externs/browser/w3c_rtc.js

Navigator should be missing getMedia, getUserMedia, mozGetUserMedia, msGetUserMedia because they have been deprecated.
See:
https://developer.mozilla.org/en-US/docs/Web/API/Navigator/getUserMedia
Modern usage is:
navigator.mediaDevices.getUserMedia()
Verified today that elemental2 1.0.0-RC1 properly contains:
in elemental2.dom.Navigator:
public MediaDevices mediaDevices;
in elemental2.dom.MediaDevices:
Promise getUserMedia(MediaStreamConstraints constraints);
Ergo, this issue can be closed.

Thanks!


test: fix default branch

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.71%. Comparing base (3638fe1) to head (d6ac063).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   55.98%   55.71%   -0.28%
==========================================
  Files           9        9
  Lines        1077     1077
==========================================
- Hits          603      600       -3
- Misses        401      403       +2
- Partials       73       74       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: Add singleton logger

Overview
Add a singleton logger that can be imported and used in all of the project. This allows to use the logger to be used independently of any object, we no longer need to pass the logger as a parameters in the functions. This software pattern for logging is the one used in the other PyAnsys libraries.
Details
Currently, due to the autogenerated code, two loggers need to coexist. Ideally, we should only have a logger, or at least a root logger and children loggers depending on it. Anyway, there isn't any logging problem by having two loggers in the stdout.

Codecov Report

Merging #507 (09f88c7) into main (78a6a4c) will increase coverage by 0.81%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
+ Coverage   76.74%   77.55%   +0.81%
==========================================
  Files          30       31       +1
  Lines        2154     2183      +29
==========================================
+ Hits         1653     1693      +40
+ Misses        501      490      -11

Impacted Files
Coverage Δ

src/ansys/meshing/prime/core/model.py
87.71% <100.00%> (+0.10%)
:arrow_up:

src/ansys/meshing/prime/internals/logger.py
100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Punctuation should be colon not period

A colon should be used to introduce a list.
In Getting started - Model tracking, under subheading "What about the other exotic objects?" the first sentence ends in a period when it should end in a colon.

Resolved in cecab3cb8729e36c58a61ab02656001cfab5f283


Append Text to Node

How can I append a text to a node?
 I only allowed for one single content text per element.
With that being said, the commit above adds a text node type where only content is printed. That means that, setting content on an element is effectively deprecated and should be replaced by just instantiating the node and using AppendText.
To create the node in your example, you would do the following:
CTML::Node par("p", "Hello world. ");
par.AppendChild(CTML::Node("span", "Hello"))
   .AppendText(" You");

I did make it so that you can still set content when creating a node, which essentially appends a text node on construction.
I hope that this solves your issue!

Nice! Works perfect. As expected. Thank you very much. 👍


Warn when an action for the cycle is close.

For instance:

when it's soon time to switch training
when the user have an empty player (or place holder) in a track that starts soon and a real player needs to be assigned or a new player need to be bought

Moved to vision: https://github.com/kvarak/htstatus/wiki


Allow buffering & data retention in BatchProcessor

These commits restructure the BatchProcessor to introduce some options for the buffering that (I hope) make it a little more useful.
I found that I was writing pretty similar wrappers around the unbuffered writer to get these options, but that they would probably be pretty common use cases.
The general changes are:

Allow configuration of queue capacity (either 'unbounded' or N)
If limited capacity (or runtime limit of unbounded), provide option for behaviour on writing when capacity is reached (i.e. throw exception, drop oldest record, or drop the current record)
Allow configuration of discard / retain on failed write of buffered points
If data retention is enabled, rate throttle calls to write() IF previous attempts to write() failed

Hi,
Way to complex modifications. formatting changes all over the place, API change.
As i already mentioned, a PR should solve one single problem which is described in a issue.
I think some of the ideas are really useful but they need splitted into small understandably modifications, then im happy to merge them.


How to : GIST/GIN index

Hi, first of all, thank you for your amazing lib !
I'm trying to implement LTREE but I need to create a GIST index on one field (with GORM of course).
I don't find any doc/exemple to do that...
How can I achieve that ?
thx !

Use tag index:,type:gist https://gorm.io/docs/indexes.html#Index-Tag, require postgres driver v1.0.1

Thank you very much ! it's working !


Validation of API key

_load_devices, _load_contacts and _load_user_info all fail gracefully if the API key is wrong. It would be great if something would blow up so I can notify my users.

In my fork I have this fixed by throwing an exception if the API returns with status 401 (see commit 7b071b54f2153e5782ea6d52557fff576975f0ba). I'm waiting for the owner to accept a previous pull request until I can submit the feature as a new one.

Fixed in 7b071b54f2153e5782ea6d52557fff576975f0ba


Add Parkinson detection based on sketches and deep learning

Is there an existing issue for this?

[X] I have searched the existing issues

Issue Description
Parkinson's disease is a brain disorder that causes unintended or uncontrollable movements, such as shaking, stiffness, and difficulty with balance and coordination. Traditionally, to detect Parkinson MRI images are used.
Suggested Change
You can access to dataset from (https://www.kaggle.com/datasets/kmader/parkinsons-drawings).
Rationale
No response
Urgency
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

I will be assigned 2 of your issue level 3, so you can match 150 score faster.
Will removing extra score above limitation from code harbour

@sanjay-kv sir my total pr points count is coming 1455 where 90 points are from this repo. u gave me two issue of 45 points which make  180 points from this repo i.e. 30 extra points so my current score on leaderboard should be 1455-30 = 1425 but its around 1295 ??? i am really confused and worried please help me out

also my yesterday score was 1425 with 91 pr and it is 1295 with 94 pr @sanjay-kv sir please help me out

screencapture-life-made-easy-vercel-app-2024-07-17-15_33_42.pdf
This is you current score from everywhere,
you have done few spams which will be removed eventually. so i dont see any confusion. The data i gave above is directly pulled from the github

@sanjay-kv  sir when my pull req was merged they told the highest score could be 200 in each repo someone told me 180 so accordingly i raised the issue, and it is fine to me if from now only 150 points from each repo will be counted but why only my score is removed most of the other contributors have even more than 250+ score in a single repo for example - someone on rank 16 has 1600 points on a single repo - if the score is modified it should be modified for all contributors on the same time or I should too have my last score on leaderboard, this is just one example there are even more contributors, please have a check too it

Hi @ananyag309 you are getting few things completely wrong.
1st we released guidelines to make this clear, https://github.com/GSSoC24/Contributor/tree/main/gssoc-guidelines
Guidelines has been communicated via mails , discord, newsletter and Linkedin announcment. so cant say never knew about .
Guidelines released on 10th June.

This clearly says the highlighted repo 150 points apply when you do documentation, beyond that its possible for to score on that particular repo. if you contribute technical works. such as fixing a broken website button, fixing nav bar issue something like hat.
Score for all top 35 contributors has been reviewed and reduced 2 weeks back. im on the process of doing that right now.
https://github.com/GSSoC24/Contributor/discussions/490
https://github.com/GSSoC24/Contributor/discussions/492
you can see the respective disscussion on the same here, so we are doing it, you may find spams kindly report in the discussion form with their PR link. It might take some time. because Program is huge.
Let me know if anything i can help.
regarding 200 points there were people who did 800 900 poits on documentation for them we mentioned 200 points will be awarded rest of them only 150 points going forward.

I will keep 200 points on few repos for you

ok sir thank you I started contributing for the program in june itself, i was totally new i didn't go through the guidelines, it was bad on my side. also one more thing if i added some projects or enhanced feature instead of feature req i did it in doc update while raising issue will it to be a problem?

if there is any technical work limitation doesnt apply


Profiler ajax call returning 35k lines of html

The profiler's ajax call takes about 30 secs to complete, when it completes it returns a 500 error and about 35k lines of html. The html consist of one page of the project over and over again, 150 times. No matter where I navigate in this project I get the same response from the profiler with the same html.
I've cleared the twig cache and profiler cache and get the same result. I'm happy to post any code that would help.

Hi,
could you provide your composer.json and web/index.php (or other relevant app bootstrap files) so we can reproduce this?

Closing as there is no feedback.


Add -Path to mkdir.

It should:

Create all its parents.
And never report error when the directory already exists.

mkdir already has -Path parameter and behaves almost as you described.
To make it behave exactly as you described, just use -Force.
> mkdir -Path foo\bar\baz -Force

    Directory: F:\dev\PowerShell\foo\bar

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----         9/6/2016   6:40 PM                baz

> mkdir -Path foo\bar\baz -Force

    Directory: F:\dev\PowerShell\foo\bar

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----         9/6/2016   6:40 PM                baz


feat: improve container and network loss command doc

Signed-off-by: Icesource<EMAIL_ADDRESS>for https://github.com/chaosblade-io/chaosblade/issues/766
完善校准文档

container-continaer
container-cpu
container-network
container-process
network-loss

TBD: code blocks 增加语法高亮


Use systemmu 2.4.0 to remove deprecation message in ruby 1.9.3

usuing ruby 1.9.3 we get this msg in every test
/Users/jdyer/.rvm/gems/ruby-1.9.3-p0@global/gems/systemu-2.2.0/lib/systemu.rb:29: Use RbConfig instead of obsolete and deprecated Config

Seems the fix is to use systemme 2.4.0, but you have it hardcoded to use 2.2.0
14:12:34<EMAIL_ADDRESS>chef chefspec ? bundle update systemu                                                                    7 ↵
Fetching source index for http://rubygems.org/
Bundler could not find compatible versions for gem "systemu":
In Gemfile:
 systemu (>= 2.4.0) ruby

chefspec (>= 0) ruby depends on
  systemu (2.2.0)

Hi John,
This is probably a transitive dependency being pulled in by Chef.
I think there was a Chef issue for this as well - check the Opscode Jira instance.
Cheers,
Andrew.


Remove experiment type from external parameters

Currently the external API has an endpoint per plan type but also expects a field with the plan type. This is redundant and we should remove the field.
Note

We should remove it externally, if it's useful to keep internally that's fine
This may be affected by https://github.com/DiamondLightSource/python-artemis/issues/31

Removed as part of linked issue


[BEAM-14020] Adding SchemaTransform, SchemaTransformProvider, TypedSchemaTransformProvider, and PCollectionRowTuple

Adding SchemaTransform, SchemaTransformProvider, and PCollectionRowTuple. This is an interface which allows for Schema-aware transforms and will eventually replace SchemaIO.
R:@TheNeuralBit
Doc: https://s.apache.org/beam-schema-transform
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java PreCommit

Run Java PreCommit

Run Java_Examples_Dataflow PreCommit

Run Java_Examples_Dataflow PreCommit

Run Java PreCommit


Bug: Typo in Pull Request Template

Describe the bug
In the PULL_REQUEST_TEMPLATE.md the last comment line reads:

note: PRs with deletes sections will be marked invalid

I believe the intended statement is either:

note: PRs with deleted sections will be marked invalid

or

note: PRs which deletes sections will be marked invalid

Steps to reproduce
Open a PR for an Open Sauce project and the template will appear via github actions.
Affected services
opensauced.pizza, hot.opensauced.pizza, api.opensauced.pizza, docs.opensauced.pizza, explore.opensauced.pizza
Platforms
Desktop, Mobile, Tablet
Browsers
Chrome, Firefox, Safari, Edge, Opera, Other (add additional context)
Environment
No response
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[X] I agree to follow this project's Contribution Docs

.take


Evaluate support for COM Source generation

This affects the new attributes in .NET 8
https://learn.microsoft.com/en-us/dotnet/standard/native-interop/pinvoke-source-generation
https://www.youtube.com/watch?v=DZd1SGd7dSU
We will have to check how dscom currently handle these new attributes and what's planned for the future:
[GeneratedComClass]
https://learn.microsoft.com/en-us/dotnet/api/system.runtime.interopservices.marshalling.generatedcomclassattribute?view=net-8.0
[GeneratedComInterface]
https://learn.microsoft.com/en-us/dotnet/api/system.runtime.interopservices.marshalling.generatedcominterfaceattribute?view=net-8.0
[LibraryImport]
https://learn.microsoft.com/en-us/dotnet/api/system.runtime.interopservices.libraryimportattribute?view=net-8.0

There is currently no need


Access Solr admin over HTTPS in DDEV by default

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem?
In Firefox, you need to disable HTTPS-Only Mode in Firefox to access Solr, since it's using HTTP, which is not ideal.
Describe your solution
It would be great with Solr access over HTTPS as the default, if it's possible.
Describe alternatives
No response
Additional context
Kevin Quillen's blog post Access Apache Solr admin over HTTPS in DDEV.

My experience is that it all goes bad with HTTPS enabled, but the right place fof this issue is ddev/ddev-solr, so I'll move it there.


Is it possible for HttpClientFactory to target .NET Standard?

Xamarin based clients have all the same issues of managing the lifecycles of HttpClient and its handler instances.
If HttpClientFactory could target .NET Standard, instead of .NET Core, it'll be very useful in the Xamarin eco-system as well.

It does target .NET Standard:
https://github.com/aspnet/HttpClientFactory/blob/4dfcf7485e62819d0d73c00d7e7eb53d75abdbd3/src/Microsoft.Extensions.Http/Microsoft.Extensions.Http.csproj#L9


[Question]: instrumentation + retrieved node with score event

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
I'm looking for a way to use new instrumentation module to track queries retrieved nodes + score (I'm currently using a custom node processor).
I've seen there is a RetrievalEndEvent but I don't have information I'm looking for there, is there a way of doing that or should I stick to my current implementation ?

Cool @mikelonestone! In general, we need to expand the coverage of instrumentation throughout our library, by:

adding sensible payloads to existing Event
adding new Event
firing Event with dispatcher
tracing function executions with Span

We see the above happening as dictated by the needs of our users mostly, and your present one prime example.
I believe for your case, if I'm understanding correctly, we would need to add the relevant payload (i.e Fields) in the appropriate Event classes.
from llama_index.core.instrumentation.events.base import BaseEvent

class RetrievalStartEvent(BaseEvent):
    query: str  # ADD

    @classmethod
    def class_name(cls):
        """Class name."""
        return "RetrievalStartEvent"

class RetrievalEndEvent(BaseEvent):
    query: str   # ADD
    retrieved_nodes: Dict[str, Any]  # ADD (or could maybe NodeWithScore)

    @classmethod
    def class_name(cls):
        """Class name."""
        return "RetrievalEndEvent"

We have to be somewhat mindful of the data types on the payloads as they all might not work. After having the events like above, then in order to catch these events and handle them with your custom logic you need to:

Define your custom EventHandler
Attach it to the root Dispatcher

from llama_index.core.instrumentation.event_handlers.base import BaseEventHandler
from llama_index.core.instrumentation.events.retrieval import RetrievalStartEvent, RetrievalEndEvent

class MyCustomEventHandler(BaseEventHandler):
     def handle(event):
          # add your custom logic here
          if isintance(event, RetrievalEndEvent):
                  ...

# to attach to root dispatcher
import llama_index.core.instrumentation as instrument

dispatcher = instrument.get_dispatcher()  # with no "name" param supplied, it will get the root dispatcher
event_handler = MyCustomEventHandler()

dispatcher.add_event_handler(event_handler)


support New arch

Summary
Adds new architecture support with backwards compatibility

Sorry @larkox forgot to add you as a reviewer


Update string.resources.de.json

Complete german translation of interface UI

This is great, thank you @kgschoueri ! And please extend my thanks to the translator.


Kfto CVE patches

What this PR does / why we need it:
This PR resolves CVEs created by the google.golang.org/grpc library. There were three main libraries that I had to update:
go get -u k8s.io/apiextensions-apiserver
go get -u sigs.k8s.io/controller-runtime
go get -u volcano.sh/apis

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #
Checklist:

[ ] Docs included if any changes are user facing

@tenzen-y, is there an additional command I have to run after updating a go package?


VNC not working

Ran through the VNC setup part of the install instructions, but when clicking on VNC in the client area, or Run VNC in the admin area of whmcs, it just gives a connection error

We have updated our module lately. Hope it works for you now. If not please open a new issue with as detailed description as possible. Thanks in advance!


argon4:// protocol?

Argon4 needs a way to launch from the normal device browser (e.g.: from iOS Safari) maybe using a protocol like argon4://my_url...
This would allow so many more users with iOS to be able to instantly and effortlessly switch to Argon4 browser whenever they go on a AR-related web page, given they already have the Argon4 browser installed, of course.  We could even have Javascript detect the Safari browser and redirect to the App Store to install Argon4 when it's not installed yet.

Yes, thanks we will have this in the next release.


Support for 1.18.2 and fixing little bugs

Works and runs on 1.18.2, but has not been tested.
Fixed ripple particles on the water, now they are correctly displayed, as well as they are smoothed closer to the end of the particle creation area.
Fixed processing of sound effects under water near other blocks.

Thank you very much! Seems to work well for me :)


Space in folder name results in buggy behaviour

I found another bug in file_browser today, sorry if I start looking pedantic.
If navigating in a path containing a space, file opening behaviour is erratic.
Steps to reproduce:

Create path and file:

:~$ mkdir test\ folder
:~$ cd test\ folder/
:~/test folder$ touch test_file.txt
:~/test folder$ echo "example content" >> test_file.txt
:~/test folder$ cat test_file.txt
example content

Launch file_browser and select gedit to open files:

Navigate to directory and select file:

gedit opens two files and none of them is the correct one:

Yeah, I noticed that as well while fixing the other stuff.
I have a fix for this already, I'll push it soon.
Don't worry about opening too many issues, I appreciate the feedback.

Tested and working fine!


Add a button for creator being ready

Add a button for the creator to be ready to start. This will add a way for per-player or per-team options after players have joined. It will also stop games from being started early while a creator is still inviting players.

could also be an opt-out auto-start checkbox, and have a two minute buffer time that the game won't auto-start until two minutes after the creator's last edit


About the performance of the chunk-hopping mechanism

Have you done some evaluation of the chunk-hopping encoder. How about the performance?

@SoonSYJ streaming_type=reshape corresponds to it. It is good in a sense that past context does not accumulate regardless of the layer depth.

@SoonSYJ streaming_type=reshape corresponds to it. It is good in a sense that past context does not accumulate regardless of the layer depth.


Question: construct a prot term from the string representation of the type

Context
With the current API of test_lib, fixed-arity primitives such as test_function_1 take as argument some _ Ty.ty:
val test_function_1 : ?test: 'b tester -> …
  ('a -> 'b) Ty.ty -> string -> ('a * 'b * string * string) list -> Learnocaml_report.report

while the n-arity primitives take as argument some (_, _, _) prot, the advantage of which being thus that the co-domain type 'ret is clearly specified:
val test_function : ?test: 'ret tester -> …
  (('ar -> 'row) Ty.ty, 'ar -> 'urow, 'ret) prot -> ('ar -> 'row) lookup ->
  (('ar -> 'row, 'ar -> 'urow, 'ret) args * (unit -> 'ret)) list -> Learnocaml_report.report

In learn-ocaml-editor we decided to preferably rely on test_function (and test_function_against) to have more generic code, while providing notations to easily construct some term of type (('ar -> 'row, 'ar -> 'urow, 'ret) args * (unit -> 'ret)) list.
The current bottleneck for specifying such test cases is that the syntax to construct a term of type (('ar -> 'row) Ty.ty, 'ar -> 'urow, 'ret) prot is not very user-friendly. We thus obtain some code like this:
type test_qst_typed =
  | TestAgainstSol :
      { name: string
      ; prot: (('ar -> 'row) Ty.ty, 'ar -> 'urow, 'ret) prot
      ; gen: int
      ; suite: ('ar -> 'row, 'ar -> 'urow, 'ret) args list } -> test_qst_typed
  …
  | TestSuite :
      { name: string
      ; prot: (('ar -> 'row) Ty.ty, 'ar -> 'urow, 'ret) prot
      ; suite: (('ar -> 'row, 'ar -> 'urow, 'ret) args * (unit -> 'ret)) list } -> test_qst_typed

let example_constr_sol =
  TestAgainstSol
    { name = "min";
      prot = (arg_ty [%ty: int] (last_ty [%ty: int] [%ty: int]));
      gen = 4;
      suite = []
    }

Question
The question is: would it be feasible to add to the test_lib API a facility to get a prot from a string representation of the type? Basically one of the two approaches would be OK for us:

Either implement a syntax [%prot: a -> b] similar to [%ty: a -> b]
Or implement a function that has a type such as prot_of_string: string -> (('ar -> 'row) Ty.ty, 'ar -> 'urow, 'ret) prot

Remarks

Using approach 1. would thus allow us to write:

let example_constr_sol =
  TestAgainstSol
    { name = "min";
      prot = [%prot: int -> int -> int];
      gen = 4;
      suite = []
    }

If I'm not mistaken, approach 1. could be implemented either directly, or by implementing 2. first and relying on it.

We already have a prototype implementation of a function parse_type : string -> string that yields the following trace:

# let str = parse_type "int->(int->int)->int";;
val str : string = "arg_ty [%ty :int ] (last_ty [%ty :(int->int) ] [%ty :int ])"

Kind regards, Erik

I am investigating, but this doesn't seem trivial. In particular, wouldn't the second option:

prot_of_string: string -> (('ar -> 'row) Ty.ty, 'ar -> 'urow, 'ret) prot

be wholly unsafe ? The point of the ppx is to extract both a witness and its type consistently.


Add config option to use US floor numbering in Clue Scroll plugin

Adds a config option to choose US floor numbering:

Also fixed phrasing for "MAJORS LAVA BADS AIR" anagram clue solution.
(The approach may not be optimal and require some refactoring, but the framework may be feasible.)

Bumping this - can we see this merged in?


Integrate third-party search provider

Firebase doesn't support full-text elastic search, which we need for a better search experience in the app.
Currently, a basic version for searching for users is implemented at pages/api/user/search.js.
Firebase recommends these few options for elastic search:
https://firebase.google.com/docs/firestore/solutions/search?provider=elastic
Compared to the other two, I recommend using Typesense - it's lightweight, straightforward in implementation, and the best in pricing, integration (through Firebase extension), and option to self-host or pay for Typesense cloud.

Current search is much better, so can skip for now


Convert Number.round to Java

Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:

[x] Unit tests have been written where possible.
[x] If GUI codebase was changed, the GUI was tested when built using ./run ide build.

It needs more varied benchmarks to be run to determine whether to use the Java or Enso implementations.


Ability to utilize StopForumSpam database in an offline way

Feature Request
Is your feature request related to a problem? Please describe.
As far as I can tell, in order to be able to check new registrations against the StopForumSpam database, you currently have to send that sign-up information to a server and check. This poses a privacy issue and makes it a non-workable solution for our community (discuss.grapheneos.org).
Describe the solution you'd like
Would it be possible for the checks to be done in an offline manner where the database is downloaded and checked against instead of sending information to an online service?
Describe alternatives you've considered
The current way we do things is by banning specific keywords that are commonly used by spam accounts and manually getting rid of them, but being able to benefit from the database would be a tremendous help to our community.

Hello @matchboxbananasynergy and thank you for the request!
I absolutely agree with what you are saying here, and by the looks of it StopForumSpam do offer their data for download.
We would have to refactor the extension logic in order to work either online or offline, and setup a scheduled task in order to download updated data on a regular basis, but I think this would be achievable fairly easily.
I'm pretty tied up for the next few days at least, but I will certainly tackle this as soon as I have the time 👍

@matchboxbananasynergy thanks for sharing the propsal. I think it would be a great improvement. I did pick up that proposal (https://discuss.flarum.org/d/33802-improve-privacy-of-fofanti-spam-by-making-stopforumspam-calls-offline) to run along other improvements that have already been suggested to further improve anti-spam and combined them in a bounty (https://discuss.flarum.org/d/33803-big-fofanti-spam-improvement-bounty) to get them implemented more quickly.

This is where we removed our custom per-email rate limiting for email confirmation and forgot password which we implemented at the nginx layer:
https://github.com/GrapheneOS/discuss.grapheneos.org/commit/974629b08696dfead026e22722ff9917183f3cb2
The general approach is still useful for doing other similar limits. It's easier to do that way when under attacks compared to do it more cleanly/properly inside Flarum.
We might temporarily use a similar approach for using the username/email data from Stop Forum Spam.

IPv6 data only has /64 blocks which I think is too broad, so I think it's worth considering only supporting IPv4 for people who are going to use Stop Forum Spam blocking. There will be too many false positives via IPv6. IPv4 will also have more and more false positives due to CGNAT so there aren't really any great answers.