DivideByZeroException: Attempted to divide by zero.

I get the following error when I open a prefab in prefab stage mode. Unity 2022.3.17f1
DivideByZeroException: Attempted to divide by zero.
XCharts.Runtime.AxisHelper.GetSplitNumber (XCharts.Runtime.Axis axis, System.Single coordinateWid, XCharts.Runtime.DataZoom dataZoom) (at ./Library/PackageCache/com.monitor1394.xcharts@1e31cf3010/Runtime/Component/Axis/AxisHelper.cs:71)
XCharts.Runtime.AxisHelper.GetScaleNumber (XCharts.Runtime.Axis axis, System.Single coordinateWidth, XCharts.Runtime.DataZoom dataZoom) (at ./Library/PackageCache/com.monitor1394.xcharts@1e31cf3010/Runtime/Component/Axis/AxisHelper.cs:211)
XCharts.AxisHandler`1[T].InitAxis (XCharts.Runtime.Axis relativedAxis, XCharts.Runtime.Orient orient, System.Single axisStartX, System.Single axisStartY, System.Single axisLength, System.Single relativedLength) (at ./Library/PackageCache/com.monitor1394.xcharts@1e31cf3010/Runtime/Component/Axis/AxisHandler.cs:394)
XCharts.Runtime.XAxisHander+<>c__DisplayClass6_0.<InitXAxis>b__0 () (at ./Library/PackageCache/com.monitor1394.xcharts@1e31cf3010/Runtime/Component/Axis/XAxis/XAxisHander.cs:54)
XCharts.Runtime.XAxisHander.InitXAxis (XCharts.Runtime.XAxis xAxis) (at ./Library/PackageCache/com.monitor1394.xcharts@1e31cf3010/Runtime/Component/Axis/XAxis/XAxisHander.cs:62)
XCharts.Runtime.XAxisHander.InitComponent () (at ./Library/PackageCache/com.monitor1394.xcharts@1e31cf3010/Runtime/Component/Axis/XAxis/XAxisHander.cs:13)
XCharts.Runtime.BaseChart.InitComponent () (at ./Library/PackageCache/com.monitor1394.xcharts@1e31cf3010/Runtime/Internal/BaseChart.cs:126)
XCharts.Runtime.BaseGraph.Awake () (at ./Library/PackageCache/com.monitor1394.xcharts@1e31cf3010/Runtime/Internal/BaseGraph.cs:67)
XCharts.Runtime.BaseChart.Awake () (at ./Library/PackageCache/com.monitor1394.xcharts@1e31cf3010/Runtime/Internal/BaseChart.cs:137)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr, Boolean&)

XCharts是什么版本？


Not coloring all keywords using sas style

Output in LaTex looks like this:

SAS code looks like this:

the keywords: {firstobs, dlm, data, class, model, lsmeans, stderr, cl, alpha} are not highlighted in light blue.  How to fix this?

using minted environment with style set to sas


submit assignment 1 sql

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist

[ ] I can confirm that my changes are working as intended

sorry i was late, i forgot to clone the repo on my local pc and didnt know why i wasnt able to upload my submission to github


sendgrid helper link working

Readme updated with correct link to sendgrid helper docs.

@decentname  Thanks!

@dbernheisel I think this should be reverted or we need to make an issue to remind us to change it back before we release 1.0 because we renamed the module: https://github.com/thoughtbot/bamboo/blob/master/lib/bamboo/adapters/send_grid_helper.ex#L1

Thanks @paulcsmith. That's tough, because folks have run into problems because of the disparity between master and the published version. What do you think of editing the readme to point to both versions until 1.0?

@dbernheisel Yeah pointing to both sounds like a good idea to me


chore: jxpy to 0.0.1

chore: Promote jxpy to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Arity of custom relationship fetch methods has changed between 0.8.3 and 0.9.0

Hiya,
I just upgraded from JR 0.8.0.beta2 to 0.9.0 and found one weird error being raised in our code:
ArgumentError: wrong number of arguments (1 for 0)

This was coming from a custom relationship finder, records_for_#{relationship}.
class ListResource < BaseResource
  has_many :listings

  def records_for_listings
    # ...
  end
end

This seems like a surprising API change: Documentation for this (which I even touched upon back in #822) does not have any mention of any arguments coming in:
http://jsonapi-resources.com/v0.9/guide/resources.html#Customizing-base-records-for-finder-methods

It seems that #712 began calling the custom method with some sort of "options" argument:
https://github.com/cerebris/jsonapi-resources/commit/827f5db494ff8add581371db2fe6ac7f1c9abded#diff-608a15fc63beb3dbfec8dc0c490a69caR145
-        records = public_send(associated_records_method_name)
+        records = public_send(associated_records_method_name, options)

The new argument seems to have been added for it be available when called from the Processor: https://github.com/cerebris/jsonapi-resources/blob/v0.9.0/lib/jsonapi/processor.rb#L184
related_resources = nil
if params[:cache_serializer]
  # TODO Could also avoid instantiating source_resource as actual Resource by
  # allowing LinkBuilder to accept CachedResourceFragment as source in
  # relationships_related_link
  scope = source_resource.public_send(:"records_for_#{relationship_type}", rel_opts)
  relationship = source_klass._relationship(relationship_type)
  related_resources = relationship.resource_klass.find_serialized_with_caching(
    scope,
    params[:cache_serializer],
    rel_opts
  )
else
  related_resources = source_resource.public_send(relationship_type, rel_opts)
end

I wasn't able to find documentation for the usage of that argument, so I assume it was just a bug by @DavidMikeSimon to apply that argument over there? The reason for my suspicion is the other branch of the conditional above, where the second argument is indeed passed (as supposed to?) to the relationship_type method.
If this is indeed a wanted change, I could whip up a PR for updating the documentation if I'd know why the options argument is passed here.
This is especially strange as other relationships besides to-many don't have this same code in https://github.com/cerebris/jsonapi-resources/blob/v0.9.0/lib/jsonapi/relationship_builder.rb — those custom methods are called without the options argument at all.

Yep, this is indeed a breaking change in the records_for API. I didn't implement it in an override-friendly way, nor did I correctly document it, so the blame for any confusion rests squarely on my shoulders. :-)
The key here is the change in #712 in relationship_builder.rb. My change moves the code that implements filtering, sorting, and pagination of has_many relationships out of the auto-generated listings method (which returns Resources) and into the auto-generated records_for_listings method (which returns an AR scope). The former then just passes through its options to the latter. This allows the caching system to correctly retrieve the results for show_related_resources from the cache without instantiating Resources.
The way I should have done this would be to separate the part that applies filters/sorting/pagination from the overrideable method. In master, this has already been correctly done by @lgebhardt when they factored out ActiveRecordAccessor (such that the user now overrides their Resource's records_for method).
@lgebhardt If you'd like, I can make a patch for 0.9.0 that corrects this problem in a similar way. I'll just need a branch for the 0.9.0 tag to PR into (the release-0-9 branch seems to be out of date).
@valscion Alternately, for the meantime, I think something like the following will work alright:
class ListResource < BaseResource
  has_many :listings

  def records_for_listings_with_customization(options = {})
    records_for_listings_without_customization(options).includes(...)
  end

  alias_method_chain :records_for_listings, :customization
end

Thanks for the thorough explanation! I'm looking forward to the ActiveRecordAccessor :)
Do we want to update the documentation somehow in the meantime? The alias_method_chain trick could indeed be a good idea for this.

@valscion I'd rather change the behavior than the docs, since eventually it'll go back to something more similar to the 0.8 behavior when 0.10 is released.

Hmm yeah, but it might be a good idea to change the 0.9 documentation anyway to reflect this, and maybe note that this might not be needed for 0.10 release anymore. As now the documentation is outdated with regards to this case 😕

An alternative workaround for the 0.9.x series, which doesn't rely on the deprecated alias_method_chain would look like this:
class ListResource < BaseResource
  has_many :listings

  prepend Module.new do
    def records_for_listings(_options = {})
      super.includes(...)
    end
  end
end

Though I'd be sure to mark that for cleanup when upgrading to JAR >= 0.10 as it's supposed to be fixed there.

The docs have been updated at some point so this issue is no longer relevant.


Added batching of inserts

Codecov Report

Merging #24 into master will decrease coverage by 3.14%.
The diff coverage is 6.97%.

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   36.03%   32.89%   -3.15%
==========================================
  Files           6        6
  Lines         333      377      +44
==========================================
+ Hits          120      124       +4
- Misses        208      248      +40
  Partials        5        5

Impacted Files
Coverage Δ

main.go
7.81% <0%> (-0.74%)
:arrow_down:

primaryHandler.go
39.39% <0%> (-8.06%)
:arrow_down:

metrics.go
73.68% <75%> (+2.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e73e5f9...d7b7f09. Read the comment docs.


feat: make context entity more customizable

closes #225

@djs0109 I added a more customizable implementation of the ContextAttribute and ContextEntity class. If the test all run trough I will add the examples and additional tests for inheritance options.

@djs0109 please let me know where the pipeline fails. Thus, I can double check. I only checked the offline-model-tests

@tstorek four tests have failed. I dont know if this information is enough for debugging
FAILED tests/clients/test_ngsi_v2_cb.py::TestContextBroker::test_attribute_operations - TypeError: <class 'list'> does not match DataType.STRUCTUREDVALUE
FAILED tests/clients/test_ngsi_v2_iota.py::TestAgent::test_patch_device - TypeError: <class 'str'> does not match DataType.STRUCTUREDVALUE
FAILED tests/clients/test_ngsi_v2_iota.py::TestAgent::test_update_device - TypeError: <class 'str'> does not match DataType.STRUCTUREDVALUE
FAILED tests/models/test_base.py::TestModels::test_unit_as_metadata - TypeError: <class 'float'> does not match DataType.STRUCTUREDVALUE

Can you give me you the email address of you github account? Then I can grand you the right to the pipeline

@djs0109 please let me know where the pipeline fails. Thus, I can double check. I only checked the offline-model-tests

Sounds good!

@djs0109 I added a more customizable implementation of the ContextAttribute and ContextEntity class. If the test all run trough I will add the examples and additional tests for inheritance options.

Nice, that sounds good 👍

@djs0109 Okay, that sounds like minor issues. I'll send you may github-mail in a pm

@djs0109 I think that the pipeline works now. Do you want me to add additonal tests and examples? Where should I put the example?

@tstorek examples would be really helpful. How about under examples/ngsi_v2?

@djs0109 apparently, there is one more failing check. Could you ellaborate agin, where? Maybe it would be quicker to fix it your self by putting the correct type. I also added an example know.
Not sure about tests tough.

@tstorek here is the error:
self = <tests.clients.test_ngsi_v2_iota.TestAgent testMethod=test_update_device>
    def test_update_device(self):
        """
        Test the methode: update_device of the iota client
        """

        device = Device(**self.device)
        device.endpoint = "http://test.com/"
        device.transport = "MQTT"

        device.add_attribute(DeviceAttribute(
            name="Att1", object_id="o1", type=DataType.STRUCTUREDVALUE))
>       device.add_attribute(StaticDeviceAttribute(
            name="Stat1", value="test", type=DataType.STRUCTUREDVALUE))
tests/clients/test_ngsi_v2_iota.py:250:

The error seems relatively straightforward here: StaticDeviceAttribute(name="Stat1", value="test", type=DataType.STRUCTUREDVALUE)). Could you double check again, why this string-like value should have type STRUCTUREDVALUE?

@djs0109 I think those are left overs from the initial implementation. Back then structured_values were only checked for serialiaziation. Hence, strings id not raise errors

@tstorek I made some minor changes in the example, e.g. adding the address into the weather station object. Btw, have you used any formatter? Because I see quit a lot changes on the code format.

@tstorek I made some minor changes in the example, e.g. adding the address into the weather station object. Btw, have you used any formatter? Because I see quit a lot changes on the code format.

Hi, @djs0109 yes I used black-fromatter. sorry for that. I chekcd on the changes.


CPPBitmapLayer class added

Added C++ wrapper class for BitmapLayer.
Reorganized file structure to separate examples from source code.
Updated README

Thanks so much! I'd love to accept this, but I'd prefer not to have the pebble, malloc, etc files copied instead of included and linked against

Sure! I noticed you mentioned on your blog that you could include the files by symlinking to the wscript. I'm not too sure how that works exactly. Could you give me some pointers as to what I need to do?

If you're on Windows, you can't symlink, but on Mac and Linux you can. Just do "ln -s ../../src/wscript ." in the example directories and once for each file (just replace wscript).
Maybe I should come up with something else, but I'm pretty sure the main wscript file has changed anyway now with the new patforms and all.

I'm on a Mac. I'll give it a shot :)

Are there any further changes I need to make?

Nope!


test: generate coverage report for unit tests and check coverage ratio in CI

Commits:

test: generate coverage report for unit tests

test: split unit tests into separate files to make coverage rate more accurate

ci: check coverage ratio and upload the data with Codecov in GitHub Actions
Overall coverage rate of all unit tests for the current tip commit of develop branch:
  lines......: 25.7% (856 of 3327 lines)
  functions..: 9.4% (93 of 992 functions)

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@07a3e5d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #48   +/-   ##
==========================================
  Coverage           ?   22.63%
==========================================
  Files              ?       22
  Lines              ?     3327
  Branches           ?      461
==========================================
  Hits               ?      753
  Misses             ?     2491
  Partials           ?       83

Flag
Coverage Δ

unittests
22.63% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Use correct context

I don't think there is much difference, but these outputs are basic info and not errors. See https://github.com/composer/composer/blob/master/src/Composer/IO/IOInterface.php#L72

It's also on purpose: the "stderr" is not only for errors but also for informational purposes. These messages are not part of the normal output of the command, thus for stderr.
Thanks for proposing also.


Are there new app store versions for v10.0 ?

I am using CAST API with the iOS app. I just tried the new library, but I keep getting "Error software revisions are different".
Do I have to wait for a new Android or iOS app version?

the new version 10.0 App is in pilot: https://support.clarius.com/hc/en-us/articles/360019548852-Joining-the-Pilot-Program

Thank you! That worked! It would be great if this were added to the release info or perhaps the readme file!


Investigate automatic documentation

Rest Docs: Looks kinda cool?  Docs in Test?  Might be annoying?  Does it generate a html page for you?

I don't think Rest Docs does what I think it does... I think it instead serves documents, not code documentation....  I'm closing this, cause.


Fixes spelling and grammar.

Cleans up the index page for spelling and grammar errors.

@anechol : Thank you very much for your help. My Englisch is good but not so good for a lot of text.
I will merge it now. If you want to add some other stuff tell me about your ideas.


Change Davids last name in README.md

This PR updates my last name in the README.md file (changed because of marriage).

Congrats by the way 🥳

Thanks a lot @xiel 🙂.


Incorporate unrolled Gaussian elimination solver into modcc. [2]

Point estimate: 2
Feature: #60
Prerequisite: #99.
Note: edited issue for scope; see #147 for remainder of task.
Port symbolic GE demo code to modcc.

Extract required functionality from classes in prototype.
Provide expression_ptr-friendly interfaces.
Add unit tests for symbolic GE.

Addressed in PR #145


feat: add fallback rate limiter and cache to fallback to memory if redis fails

Description
Adds a new config to proxyd: redis.fallback_to_memory.
This allows falling back to a memory implementation of Redis features if they fail instead of falling back to an error (in the case of rate limiting) or a no-op (in the case of caching).
I also moved redis connection testing which will warn if we're not able to connect with the new flag is enabled, but still error if the fallback is disabled.
If the context is cancelled for the cache, we don't retry with the secondary source because this indicates a
Tests
Added test for rate limiter fallback and cache fallback.

Just curious what specific error fro redis instance when running proxyd that prompted this work?

Interesting work overall, thanks for opening the PR

Just curious what specific error from redis instance when running proxyd that prompted this work?
The reason I ask because if the redis error is intermittent, I could see some narrow edge cases where the primary and fallback cache's could thrashed back and forth. Since state is not aligned between the two cache's this could produce unexpected behavior

Good question!
We want to make sure if the redis cache fails or networking to the redis cache fails, requests don't start failing. The issue right now is that if the redis client fails, requests fail due to rate limiting (failing closed instead of failing open).
I agree the intermittent error issue could be a problem, but the failure case is actually better now than before - instead of refusing all requests due to rate limiting, the server will make an attempt at processing the requests (even if the cache is missed). Rate limiting will continue to apply on a per-instance level.

Moving to #92


Fixes inconsistent spacing for params in mpl drawer

Summary
Fixes #4845
Details and comments
This PR fixes several spacing issues for params in the mpl drawer which were highlighted in #4845. These affect the text width calcs for params.

Removes linefeeds and spaces from the output of latex_to_text
Replaces hyphens with math mode minus signs in computing text width
Adjusts to a slightly larger default char to cover non-ascii chars such as pi and other Greek letters

Converts this output

to

mybinder test https://mybinder.org/v2/gh/enavarro51/qiskit-terra/fixissue4845branch?urlpath=apps/test/ipynb/mpl_tester.ipynb


Can be used with CLOS classes?

This code signals a condition on the seal-domain call. Is there a metaclass needed? Or does this only work with built-in types?
(in-package #:cl-user)
(ql:quickload :fast-generic-functions)
(use-package :fast-generic-functions)

(defclass foo () ((x :reader x :initarg :x)))

(defgeneric op (foo)
  (:generic-function-class fast-generic-function))

(defmethod op ((foo foo))
  (* 2 (x foo)))

(seal-domain #'op '(foo))

Oh, yes, I had planned to allow specialization on custom classes, but never found time to finish it.  But your issue has given me the necessary boost in motivation.
After my most recent commit, the following should work:
(defpackage #:sealable-class-demo
  (:use #:closer-common-lisp))

(in-package #:sealable-class-demo)

;;; Place this in FILE1

(defclass sealable-standard-class
    (sealable-metaobjects:sealable-class standard-class)
  ())

(defmethod validate-superclass
    ((class sealable-standard-class)
     (superclass standard-class))
  t)

;;; Place this in FILE2

(defclass foo ()
  ((x :reader x :initarg :x))
  (:metaclass sealable-standard-class))

;; MAKE-LOAD-FORM is important, because non-inlined fast-generic-functions
;; are looked up at load-time with a list of literal class prototypes.
(defmethod make-load-form ((foo foo) &optional env)
  (make-load-form-saving-slots foo :slot-names '(x) :environment env))

;;; Place this in FILE3

(defgeneric op (foo)
  (:generic-function-class fast-generic-functions:fast-generic-function))

;;; Place this in FILE4

(defmethod op ((foo foo))
  (* 2 (x foo)))

(sealable-metaobjects:seal-domain #'op '(foo))

;;; Place this in FILE5

(defun bar ()
  (let ((foo (make-instance 'foo :x 42)))
    (declare (foo foo))
    (op foo)))

Can you give me some feedback on whether this works for you, too?
I am leaving this issue open until I have incorporated everything into the README.
Oh, and if you think this is too much hassle, you can always specialize on built-in classes and structure-classes.

OK, I just added this example to the README with https://github.com/marcoheisig/fast-generic-functions/commit/0ca43f12445739ce3f51016beb7eb550a59081d5.
Please tell me whether the instructions work for you.

I really appreciate your quick engagement and suggested approach, and I'm sorry for the delay in acknowledging it. Regretfully, other priorities have intervened and I'm unable to really dive into this again.
I was on a side project trying to learn how to micro-optimize the generated assembly (by SBCL) as much as possible with a minimum of source-level intrusiveness and this seems like a promising approach to add to the mix. I will probably pick it up again in a year or two.
In the meantime, please feel free to close this issue, and once again I appreciate your contributions and engagement!

Don't worry, a 1-2 year break is not a big deal in the Lisp world :)


Add knope

https://github.com/knope-dev/knope - Rust changelog manager

It seems the latest version is 0.16.2, but not in the manifest.
https://github.com/knope-dev/knope/releases/tag/knope/v0.16.2


[DESIGN-1263] Allow Accordion to be passed an image element

Closes DESIGN-1263

Task linked: DESIGN-1263 Allow Accordion to be passed an image element


[UNR-2818] Pin runtime version

Description
Commands to spatial from the GDK for Unreal now explicitely specify a runtime version to use. A default runtime is chosen by the GDK version, and settings allow the user to change that.

Documentation
WIP

Might be worth adding an option to use latest alongside specifying a version string for better user experience when not using the pinned version.


Reusing the Python shell after using quit() will keep running python commands

Testing #22926

Run a command that will open the Python interpreter using shift+enter on a line.
Manually run quit() in the python interpreter.
Run a command again that will open the Python interpreter using shift+enter on a line.
Notice that the interpreter doesn't open :bug:
Furthermore, continually running shift+enter will keep adding to the command that it sends to the terminal.

In this case, I kept running time.sleep(1) in step 4 and 5.

This is still in the Python shell, btw.

@karrtikr Is there way we know which Terminal instance(s) have opened Python REPL and keep track of which Terminal Instances contain REPL?

No, we can't directly tell if a terminal is a REPL as far as I know.
Although VS Code does give us access to commands run in the terminal. So technically if "quit()" is run, we can know that.

Monitoring that may be expensive though, so I suggest only doing it if enough users want this feature.


Getting response error from GPT even when api key is keyed in correctly

Tested with GPT key, no issues.


Typo in Schema for HttpRequest step

Describe the bug
I'm using an HttpRequest step to call an Azure Function that returns a custom built activity to the user. I set the response type to be activity but it would never send the activity i'm returning. I tracked the issue down to a bug in the schema for HttpRequest.
In the snippet below you'll see that composer is setting a property called "responseTypes" plural but the actual property is "responseType" singular.
        {
          "$type": "Microsoft.HttpRequest",
          "$designer": {
            "id": "126891",
            "updatedAt": "2019-07-12T22:16:49.855Z"
          },
          "method": "POST",
          "url": "https://translatorbotfn.azurewebsites.net/api/TranslateMessage?code=DFgQcuVqFkvP0nL27sibggKfMGYM8/fjNCZWywCwR1mbXclw0uSk3A==",
          "body": {
            "text": "azure",
            "fromLocale": "{@fromLocale}",
            "toLocale": "{@toLocale}"
          },
          "responseTypes": "activity",
          "property": "dialog.foo"
        },

[bug]

2 other issues:

The case of the enums is wrong. "activity" should be "Activity".
The JsonProperty() for ResponseType is set to "returnType".


Main

<!--  Code Review Checklist

  - [ ] Markdown code is correct well-formatted
  - [ ] Spelling and grammar are ok

def do_some(number:int, word:str, variable:MyClass):
  # do something

I suggest we also use type notaion for result
      def do_some(number:int, word:str, variable:MyClass)->[str]:
              # do something

Agree?


Change DropDownCell to use correct module name

It looks like commit a1f6856f1bd1e36e0e0c7e99facacd3e89fc7233 included an inadvertent change that set the cell's custom module to "DropDown_Demo". (DropDown/resources/DropDownCell.xib)
This wasn't causing issues for me until I switched my Cocoapods (1.5.2) podfile to not use frameworks:
use_frameworks!(false)
use_modular_headers!

Likely fixes #171, as that matches the error I was getting.
I am also using XCode's new build system, which may or may not be contributing to this issue.

Hello @SticklyMan 👋
Thanks for this PR!

Thanks for reviewing it, and thanks for the great library!
Latest version is working great in our project.


Web - Profile - The text gets bigger when using autofill

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to URL https://staging.new.expensify.com/
Login with any account
Go to Settings -> Profile -> Display name
Clear any fields
Choose any text using autofill

Expected Result:
The text does not get bigger when using autofill
Actual Result:
The text gets bigger when using autofill
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] Windows / Chrome i
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://platform.applause.com/services/links/v1/external/b856084436f6824d6839295694a6d65d3aae6551c33a414b67beac44c28a2484
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Cannot reproduce - Closing until we have reliable reproduction steps


does bert_encode() thread-safe for online embedding?

I found that different invocation shares same memory buffer in bert_context, it may not be thread-safe for online-embedding    situation

Yup, that seems right. Good news is that we got merged into llama.cpp, which has multi-threading support. Check it out over there!

Yup, that seems right. Good news is that we got merged into llama.cpp, which has multi-threading support. Check it out over there!

Can you help explain the implementation mechanism？

Sure! The major difference from this one is the way that batching works. Here we have explicit batch sizes for each sequence, and so we need to pad them to alignment. In the llama.cpp implemenation, batches are essentially lists of (sequence_id, position, token_id) pairs, so you can put multiple sequences in one batch without padding, which can be really good for uneven length settings. The bulk of the new code there is in llama.cpp:build_bert() if you want to go into more detail.
Is that what you were looking for? Happy to provide more specifics.

Sure! The major difference from this one is the way that batching works. Here we have explicit batch sizes for each sequence, and so we need to pad them to alignment. In the llama.cpp implemenation, batches are essentially lists of (sequence_id, position, token_id) pairs, so you can put multiple sequences in one batch without padding, which can be really good for uneven length settings. The bulk of the new code there is in llama.cpp:build_bert() if you want to go into more detail.

thank you so much! This seems only support multi-thread in batch?
Let me briefly state my question. I want to wrapper llama.cpp into a online-embedding service, when concurrent client request comes, llama.cpp:build_bert() seems not thread-safe between different invocations, i haven‘t figured out how to guarantee the memory-safety in llama_context for different invocations and found any read-write lock around build_bert?


Xcode 15 and iOS 17 crashes on Ably projects

Which version of the Ably SDK are you using?
1.2.20
On which platform does the issue happen?
iOS 17
Are you using Carthage?
No
Are you using Cocoapods?
Yes, 1.12.1.
Which version of Xcode are you using?
(xcodebuild -version)
What did you do?
After installing Xcode 15, just trying to run any app (we have 2 using ably) will make it crash as soon as it starts. I figured, and fixed, the issue, locally, however it would be better to be solved for the library itself.
What did you expect to happen?
The app to run without issues
What happened instead?
The app crashes
dyld[5988]: Symbol not found: _OBJC_CLASS_$_NSError
  Referenced from: <896BA9EF-CAFC-398D-9578-18E4273B0D97> /private/var/containers/Bundle/Application/0EE27EE4-74BB-4956-A320-A148D04A4597/_myApp_
  Expected in:     <26B3444B-5032-35D1-A7D4-BAA506461EC5> /private/var/containers/Bundle/Application/0EE27EE4-74BB-4956-A320-A148D04A4597/_myApp_.app/Frameworks/Ably.framework/Ably

The issue and fix
The issue is here, on the file ARTRealTimePresence:
- (BOOL)history:(ARTRealtimeHistoryQuery *)query callback:(ARTPaginatedPresenceCallback)callback error:(NSError **)errorPtr {
    query.realtimeChannel = _channel;
    @try {
        return [_channel.restChannel.presence history:query callback:callback error:errorPtr];
    }
    @catch (NSError *error) {
        if (errorPtr) {
            *errorPtr = error;
        }
        return false;
    }
}

The
@catch (NSError *error)

should not be an NSError but an NSException instead, with a simple change it would work fine again:
- (BOOL)history:(ARTRealtimeHistoryQuery *)query callback:(ARTPaginatedPresenceCallback)callback error:(NSError **)errorPtr {
    query.realtimeChannel = _channel;
    @try {
        return [_channel.restChannel.presence history:query callback:callback error:errorPtr];
    }
    @catch (NSException *exception) {
        if (errorPtr) {
            *errorPtr = exception;
        }
        return false;
    }
}

Which version of the Ably SDK are you using?
1.2.20
On which platform does the issue happen?
iOS 17
Are you using Carthage?
No
Are you using Cocoapods?
Yes, 1.12.1.
Which version of Xcode are you using?
(xcodebuild -version)
What did you do?
After installing Xcode 15, just trying to run any app (we have 2 using ably) will make it crash as soon as it starts. I figured, and fixed, the issue, locally, however it would be better to be solved for the library itself.
What did you expect to happen?
The app to run without issues
What happened instead?
The app crashes
dyld[5988]: Symbol not found: _OBJC_CLASS_$_NSError
  Referenced from: <896BA9EF-CAFC-398D-9578-18E4273B0D97> /private/var/containers/Bundle/Application/0EE27EE4-74BB-4956-A320-A148D04A4597/_myApp_
  Expected in:     <26B3444B-5032-35D1-A7D4-BAA506461EC5> /private/var/containers/Bundle/Application/0EE27EE4-74BB-4956-A320-A148D04A4597/_myApp_.app/Frameworks/Ably.framework/Ably

The issue and fix
The issue is here, on the file ARTRealTimePresence:
- (BOOL)history:(ARTRealtimeHistoryQuery *)query callback:(ARTPaginatedPresenceCallback)callback error:(NSError **)errorPtr {
    query.realtimeChannel = _channel;
    @try {
        return [_channel.restChannel.presence history:query callback:callback error:errorPtr];
    }
    @catch (NSError *error) {
        if (errorPtr) {
            *errorPtr = error;
        }
        return false;
    }
}

The
@catch (NSError *error)

should not be an NSError but an NSException instead, with a simple change it would work fine again:
- (BOOL)history:(ARTRealtimeHistoryQuery *)query callback:(ARTPaginatedPresenceCallback)callback error:(NSError **)errorPtr {
    query.realtimeChannel = _channel;
    @try {
        return [_channel.restChannel.presence history:query callback:callback error:errorPtr];
    }
    @catch (NSException *exception) {
        if (errorPtr) {
            *errorPtr = exception;
        }
        return false;
    }
}

thanks this change of specific code help me resolve error in Xcode 15 beta 2 in iOS 17.0 issue.

Fixed in v1.2.21


WIP: Port to OMP

@NathanReb how does that look ? I never finished this but this seems good enough for the compatibility.

(I believe this breaks the plugin API, but I doubt anybody uses it)


Example code does not run

🐛 Bug
Official example code, only modifying # of GPUs, does not run.
To Reproduce
Steps to reproduce the behavior:
import os

import torch
from torch.nn import functional as F
from torch.utils.data import DataLoader
from torchvision.datasets import MNIST
from torchvision import transforms
import pytorch_lightning as pl

class MNISTModel(pl.LightningModule):

    def __init__(self):
        super(MNISTModel, self).__init__()
        self.l1 = torch.nn.Linear(28 * 28, 10)

    def forward(self, x):
        return torch.relu(self.l1(x.view(x.size(0), -1)))

    def training_step(self, batch, batch_nb):
        x, y = batch
        loss = F.cross_entropy(self(x), y)
        tensorboard_logs = {'train_loss': loss}
        return {'loss': loss, 'log': tensorboard_logs}

    def configure_optimizers(self):
        return torch.optim.Adam(self.parameters(), lr=0.02)

train_loader = DataLoader(MNIST(os.getcwd(), train=True, download=True, transform=transforms.ToTensor()), batch_size=3000)

mnist_model = MNISTModel()
trainer = pl.Trainer(gpus=2)    <-- ONLY LINE I CHANGE
trainer.fit(mnist_model, train_loader)

ExceptionTraceback (most recent call last)
<ipython-input-3-8d3997ec0919> in <module>
      3 mnist_model = MNISTModel()
      4 trainer = pl.Trainer(gpus=2)
----> 5 trainer.fit(mnist_model, train_loader)

/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/states.py in wrapped_fn(self, *args, **kwargs)
     46             if entering is not None:
     47                 self.state = entering
---> 48             result = fn(self, *args, **kwargs)
     49
     50             # The INTERRUPTED state can be set inside the run function. To indicate that run was interrupted

/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py in fit(self, model, train_dataloader, val_dataloaders, datamodule)
   1050             self.accelerator_backend = DDPSpawnBackend(self)
   1051             self.accelerator_backend.setup()
-> 1052             self.accelerator_backend.train(model, nprocs=self.num_processes)
   1053             results = self.accelerator_backend.teardown(model)
   1054

/opt/conda/lib/python3.7/site-packages/pytorch_lightning/accelerators/ddp_spawn_backend.py in train(self, model, nprocs)
     41
     42     def train(self, model, nprocs):
---> 43         mp.spawn(self.ddp_train, nprocs=nprocs, args=(self.mp_queue, model,))
     44
     45     def teardown(self, model):

/opt/conda/lib/python3.7/site-packages/torch/multiprocessing/spawn.py in spawn(fn, args, nprocs, join, daemon, start_method)
    198                ' torch.multiprocessing.start_process(...)' % start_method)
    199         warnings.warn(msg)
--> 200     return start_processes(fn, args, nprocs, join, daemon, start_method='spawn')

/opt/conda/lib/python3.7/site-packages/torch/multiprocessing/spawn.py in start_processes(fn, args, nprocs, join, daemon, start_method)
    156
    157     # Loop on join until it returns True or raises an exception.
--> 158     while not context.join():
    159         pass
    160

/opt/conda/lib/python3.7/site-packages/torch/multiprocessing/spawn.py in join(self, timeout)
    111                 raise Exception(
    112                     "process %d terminated with exit code %d" %
--> 113                     (error_index, exitcode)
    114                 )
    115

Exception: process 0 terminated with exit code 1

If I change the one line to:
trainer = pl.Trainer(gpus=2, distributed_backend="ddp"), I get:
GPU available: True, used: True
TPU available: False, using: 0 TPU cores
CUDA_VISIBLE_DEVICES: [0,1]

Hanging permanently (no progress after > 1 hour). If I inturrupt this manually, I see the model is stuck on:
f.write(fp.getbuffer())
Within a multiprocess call.
However, I only got this traceback maybe 3 times out of 30, and didn't record it, and couldn't recreate it again to get the full traceback for this error.
with:
trainer = pl.Trainer(gpus=2, distributed_backend="ddp_spawn"), I get:
ExceptionTraceback (most recent call last)
<ipython-input-3-e6d489f1a457> in <module>
      3 mnist_model = MNISTModel()
      4 trainer = pl.Trainer(gpus=2, distributed_backend="ddp_spawn")
----> 5 trainer.fit(mnist_model, train_loader)

/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/states.py in wrapped_fn(self, *args, **kwargs)
     46             if entering is not None:
     47                 self.state = entering
---> 48             result = fn(self, *args, **kwargs)
     49
     50             # The INTERRUPTED state can be set inside the run function. To indicate that run was interrupted

/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py in fit(self, model, train_dataloader, val_dataloaders, datamodule)
   1050             self.accelerator_backend = DDPSpawnBackend(self)
   1051             self.accelerator_backend.setup()
-> 1052             self.accelerator_backend.train(model, nprocs=self.num_processes)
   1053             results = self.accelerator_backend.teardown(model)
   1054

/opt/conda/lib/python3.7/site-packages/pytorch_lightning/accelerators/ddp_spawn_backend.py in train(self, model, nprocs)
     41
     42     def train(self, model, nprocs):
---> 43         mp.spawn(self.ddp_train, nprocs=nprocs, args=(self.mp_queue, model,))
     44
     45     def teardown(self, model):

/opt/conda/lib/python3.7/site-packages/torch/multiprocessing/spawn.py in spawn(fn, args, nprocs, join, daemon, start_method)
    198                ' torch.multiprocessing.start_process(...)' % start_method)
    199         warnings.warn(msg)
--> 200     return start_processes(fn, args, nprocs, join, daemon, start_method='spawn')

/opt/conda/lib/python3.7/site-packages/torch/multiprocessing/spawn.py in start_processes(fn, args, nprocs, join, daemon, start_method)
    156
    157     # Loop on join until it returns True or raises an exception.
--> 158     while not context.join():
    159         pass
    160

/opt/conda/lib/python3.7/site-packages/torch/multiprocessing/spawn.py in join(self, timeout)
    111                 raise Exception(
    112                     "process %d terminated with exit code %d" %
--> 113                     (error_index, exitcode)
    114                 )
    115

Exception: process 0 terminated with exit code 1

PyTorch Version (e.g., 1.0): 1.4 / 1.6
OS (e.g., Linux): Linux
How you installed PyTorch (conda, pip, source): pip
Python version: 3.6, 3.7
CUDA/cuDNN version: CUDA: 10.1, 10.2, 11.0
GPU models and configuration: GTX1080ti, GTX1080, GTX1070, P100

I've tried running this on 5 different VMs, and got the same issues on every single one.

Ended up being a combination of a cuDNN version issue and a jupyter notebook issue.


Delete millions rows

How can i delete millions of rows? im using secondary index but the data amount is very large 70GB ... thanks!

If its everything r.table('name').delete(); should be pretty quick.
If not, get a seleciton before.
You can get a selection multiple ways:
.get() by primary index
.get_all by secondary index
.filter() to filter out multiple value - slower
r.table('tablename').get_all('Value to look forl', index='secondary_index_name').delete()
r.table('tablename').get_all(['Multiple','value','to','look','for']).delete()
RethinkDB: get_all and filter

thanks! I tried to do this, not working with large amount of data! Someone other idea?  ... Iam using a betweent(date1, date2, {index:date})

maybe .limit(0, 10000) ? This would select by chunck and may be easier on the CPU
BUT it should work even with large amount of data.
Do you have some sort of error? What happen when you try it?

my query is: r.db('dbName').table('tableName').between(1503291600000,1503334799000, {index:'date'}).delete().run()
i try with:
r.db('dbName').table('tableName').between(1503291600000,1503334799000, {index:'date'}).limit(100000).delete().run()
but is very very slow, with 70GB...

I think your query is fine. If you don't want to wait for the query to finish, you can use durability: false.
If you are dropping the whole table, tableDrop is faster

Didn't think of durability, good to remember.


Custom cheatsheet for fish command results in a bash "invalid option" error.

Describe the bug
Trying to use the cheatsheet I've created for adding a new directory to PATH in fish results in bash giving an "invalid option" error.
To Reproduce

create the following cheatsheet, and import it:

% fish, environment_variable

# add a new directory to PATH in fish.
set -U fish_user_paths <directory_path> $fish_user_paths

make sure that fish is the current shell.
run navi and try to use the cheatsheet
After entering the directory argument, the output will be an error from bash.

Expected behavior
The command runs correctly through fish (my default shell) and adds the directory to PATH accordingly.
Versions:

OS: Fedora (Linux)
Shell Version: fish, version 3.1.2

Additional context
I'm using the cargo version with fzf. This is the actual error text that I get when I try to use the cheatsheet:
bash: line 0: set: -U: invalid option
set: usage: set [-abefhkmnptuvxBCHP] [-o option-name] [--] [arg ...]

This happens because navi calls bash -c "<cmd>" internally, so this is not being called by fish.
You can either use the shell widget with Ctrl-g (check README.md) or we could support fish natively somehow.

The widget does work, so I'll just do that for now, but an option to set the shell that navi calls (probably somewhere in ~/.config/navi/) would be cool, but I don't know how difficult it is to program something like that. Would that be considered its own issue, and this one would be closed?

Yeah, we simply need to load this config (from a file such as you mentioned or to have this per snippet in the .cheat file, which would make things more flexible) and change this line of code: https://github.com/denisidoro/navi/blob/master/src/flows/core.rs#L217

Would that be considered its own issue[...]?
I think so. Or we could rename this issue.

I'll close this issue now, since a cheatsheet not working feels like a different issue from adding a way to change which shell is called by navi, but ultimately it's your call. I'm unfamiliar with the way github issues are supposed to work, so you know more here than me.


Assertion error in ssd_minimal

Thank you for providing an SSD implemented with PyTorch. However, I noticed that the results of the SSD implemented with PyTorch do not match those of the fused SSD.

you should try a different value of atol and rtol

I subtracted the two, and the difference between them seems to be not as expected.

try (y_min - (y_min / 0.3 * 0.3)) to see what what the typical numerical errors are

the numerical errors look fine to me

I understand, thank you for your response.


merge workspace/reimburse pages

Details

Merge reimburse expenses NoVBA + VBA pages.
Fixed Issues

$ https://github.com/Expensify/App/issues/7573
Tests

Tests with VBA:
mWeb,Web,Desktop:

Log in into the app.
Open any workspace.
Go to reimburse expenses.
Refresh the page.
You should see that the section Track Distance is shown when user has VBA enabled.

Android/iOS native:

Log in into the app.
Open any workspace.
Go to reimburse expenses.
You should see that the section Track Distance is shown when user has VBA enabled.

Tests with no VBA:
mWeb,Web,Desktop:

Log in into the app.
Open any workspace.
Go to reimburse expenses.
Refresh the page.
You should see that the section Track Distance is shown when user has no VBA enabled.

Android/iOS native:

Log in into the app.
Open any workspace.
Go to reimburse expenses.
You should see that the section Track Distance is shown when user has no VBA enabled.

Note: The difference between VBA and no VBA views is the bottom of the component:

When user has VBA it should render:

When user has no VBA it should render:

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[ x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose and it is

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps

Tests with VBA:
mWeb,Web,Desktop:

Log in into the app.
Open any workspace.
Go to reimburse expenses.
Refresh the page.
You should see that the section Track Distance is shown when user has VBA enabled.

Android/iOS native:

Log in into the app.
Open any workspace.
Go to reimburse expenses.
You should see that the section Track Distance is shown when user has VBA enabled.

Tests with no VBA:
mWeb,Web,Desktop:

Log in into the app.
Open any workspace.
Go to reimburse expenses.
Refresh the page.
You should see that the section Track Distance is shown when user has no VBA enabled.

Android/iOS native:

Log in into the app.
Open any workspace.
Go to reimburse expenses.
You should see that the section Track Distance is shown when user has no VBA enabled.

Note: The difference between VBA and no VBA views is the bottom of the component:

When user has VBA it should render:

When user has no VBA it should render:

Screenshots

Web

https://user-images.githubusercontent.com/56851391/166841796-67415b7f-3439-4bc1-a738-4ca80115875b.mov
Mobile Web

https://user-images.githubusercontent.com/56851391/166841840-d62e1acc-0c71-4328-9741-abfa372485c5.mov
https://user-images.githubusercontent.com/56851391/166841778-e44dc73e-6ac0-4fb7-8aef-674cb08f7363.mp4
Desktop

https://user-images.githubusercontent.com/56851391/166841848-18ef5c2c-0785-4670-a4fb-f8cbeb1858b3.mov
iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Cherry-picked to staging by @sketchydroide in version: 1.1.57-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.


introduces unnecessary? spans

if i have a <p style='whatever'...
when i open it in the editor, I see the style attribute empty and one or more spans appended that apply the 'whatever' css.
Is there a way to prevent this pre-processing ?
E.g. should I instantiate the editor and then populate it myself to skip this effect.
It's important, because my ui has lets the user navigate their html by touch, and introducing spans like this makes the html cluttered etc...

No, this is not configurable. The styles are extracted into inline tags, as this is what Squire manipulates to apply and remove formatting. If your given underlying HTML structure is important to your project, Squire may not be the best rich text editor for it.

In my UI I decided that I can sacrifice that functionality.
Your editor is still a valuable part of my UI even without it.
IMHO, your editor IS the best of what's out there.
If you're interested, I can (hopefully shortly) send you a link so you can
see how I have used your API in my GWT mobile app.
Thanks for the support.
Ian
On Mon, Jan 23, 2017 at 9:43 PM, Neil Jenkins<EMAIL_ADDRESS>wrote:

No, this is not configurable. The styles are extracted into inline tags,
as this is what Squire manipulates to apply and remove formatting. If your
given underlying HTML structure is important to your project, Squire may
not be the best rich text editor for it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/neilj/Squire/issues/258#issuecomment-274454358, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AArVxJyEBLmCb_nqKY57nmQTr2TTA1-nks5rVIQ0gaJpZM4LlNXd
.

Sure, I'm always interested to see where people are using Squire!


qmat files use matlab version of system

matlab version currently is hard coded

This is a duplicate of #218 (actually the other way around, but the other issue got more attention... first one to be fair, as far as I know, was #166)


Faucet Smart Contract

I want to create a faucet smart contract for a custom ERC20 token giving a fixed amount of tokens to the address requested it after a specific interval of time.
I would have to create two contracts one for the token and the other for the faucet smart contract.
Can I work on this? @Vikash-8090-Yadav

Great @nirban256 start working on this

Ok

in which folder do I need to keep the folder? @Vikash-8090-Yadav

level2 @nirban256


Change selected commit/tag in Tree Details Page by clicking in a commit in the history graph

[x] Backend
[ ] Frontend

In the chart, show a vertical line to stress out that we are picking a moment (not a status from the chart).

backend in https://github.com/kernelci/dashboard/pull/178


bucket tutorial

PULL REQUEST
Purpose and Content
Add tutorial for the bucket model in standalone and coupled mode.
Benefits and Risks
Explains the bucket model and shows how to run it.

Generated docs here:
https://clima.github.io/ClimaLSM.jl/previews/PR81/generated/bucket_tutorial/
https://clima.github.io/ClimaLSM.jl/previews/PR81/generated/coupled_bucket/

Looks good, thanks @kmdeck ! I just left a few minor comments after which it's good to go.

thank you!!


cPickle

Hi
I am installing the dependencies. cPickle is listed as one. I've read this: http://stackoverflow.com/questions/37132899/installing-cpickle-with-python-3-5
"However, in 3.x, it's easier just to use pickle. No need to install anything. If something requires cPickle in python 3.x, then that's probably a bug."
Could you please comment whether cPickle is a requirement?

Hi,
cPickle is not required. I forgot to remove it from the list of dependencies after converting from python 2.7 to 3.
I just updated the docs.
Let me know if you run into trouble.
Chris

On Dec 8, 2016, at 10:53 AM, mocat2<EMAIL_ADDRESS>wrote:
Hi
I am installing the dependencies. cPickle is listed as one. I've read this: http://stackoverflow.com/questions/37132899/installing-cpickle-with-python-3-5 http://stackoverflow.com/questions/37132899/installing-cpickle-with-python-3-5
"However, in 3.x, it's easier just to use pickle. No need to install anything. If something requires cPickle in python 3.x, then that's probably a bug."
Could you please comment whether cPickle is a requirement?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/christophertbrown/iRep/issues/4, or mute the thread https://github.com/notifications/unsubscribe-auth/AKWzaQpKsc7ZehfxndLwv4zG9EK80jEVks5rGFIsgaJpZM4LIKF9.


Feasibility of making this work with pure markdown blog post

Hey, I got here from reddit, and this tool seems great, thanks for making it:).
I'm wondering how feasible is it to make this work with this other project called zero-md? Basically I'm trying to write some blog post in pure markdown, and render it in HTML. But looks like zero-md uses another project to parse the markdown source -- marked.
So to extend zero-md with displaying github permalink, we'd have to go tweak marked? Do you have some other idea?

Hey - thanks for getting in touch.
I think you're absolutely right - this would have wider applicability pure markdown solution.
Presumably you would declare some special syntax like
# regular title

regular section text here

!github:https://github.com/dwjohnston/react-github-permalink/blob/5b15aa07e60af4e317086f391b28cadf9aae8e1b/sample_files/sample1.go#L1-L5

(Or simply parse the gihub URLs!)
Reality is - right now I'm not about to stop using .mdx - MDX has all the advantages of it being markdown, while letting me include arbitrary React code as I need it.
In terms of how you would go about implementing this, there's two parts.

Parsing the URL and getting the lines to show:

This logic is here:
https://github.com/dwjohnston/react-github-permalink/blob/15aa84264feb1f029fcfbe6582ef1354a001c131/src/GithubPermalinkContext.tsx#L131-L171

Display the said lines.

For that I'm using react-syntax-highlighter - so you'd need to be looking at how they're doing it for a pure js solution.
Realistically I'm probably not going to get around to implementing a pure markdown solution - until I need one.


Assign custom headers (e.g. JWT Bearer Tokens)

Are you requesting a feature or reporting a bug?
Feature
What is the current behavior?
Cannot specify a HTTP header during fixture/test runs
What is the expected behavior?
Insert a value for any HTTP header for the Fixture or Test scope (e.g. JWT bearer token)
Ideally create a fixture hook that obtains a JWT token from an authentication source and assigns a custom header to future browser traffic (e.g. Authorization: Bearer JWT.TOKEN.HERE)
Specify your

operating system: Windows & Mac
testcafe version: 0.13.0
node.js version: 6.9.1

Hi Brett,
Thanks for your proposal.
We've discussed the similar question in the https://github.com/DevExpress/testcafe/issues/1125 issue.
Am I understand right your case? To be logged in you need do some actions (e.g. type login + password, click submit). You wouldn't like to do it in each test.
If so, we are working on the Implement user roles feature that will allow to do logging actions once for all tests. Does it work for you?

Just to add more, we follow kerberos authentication. Most of applications don't even have login pages. So need a way to apply custom headers.

@thecodejack Have you tried HTTP auth feature? It supports NTLM authentication with which Kerberos is back compatible

Thanks I did not see that feature request before.
I suppose a better E2E testing approach that covers our needs would be to support a Fixture-based hook that starts wth login and still allows the clean .page method.  I wasn't seeing a way to automate our logging screens and begin at the correct URL.
This is for a SPA so I was assuming it would be easier to obtain a token and pass through the test context before starting browser automation steps.
Which approach would you advise (hook vs headers)?

On Mar 13, 2017, at 7:23 AM, Alexander Moskovkin<EMAIL_ADDRESS>wrote:
Hi Brett,
Thanks for your proposal.
We've discussed the similar question in the #1125 issue.
Am I understand right your case? To be logged in you need do some actions (e.g. type login + password, click submit). You wouldn't like to do it in each test.
If so, we are working on the Implement user roles feature that will allow to do logging actions once for all tests. Does it work for you?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@inikulin That's very quick response.
Reg NTLM. Yes. I have NTLM. But no luck. it is logging out.

@brettveenstra If I understood you correct, upcoming Roles feature suggested by @AlexanderMoskovkin should fit your requirements.

@thecodejack I've created an issue for the problem with kerberos, we'll try to found the reason and fix it.

Thanks @AlexanderMoskovkin .

@inikulin: that should cover this request. Thanks

As I see the requested case can be covered via User Roles or Request Hooks, so I close it as a duplicate. If I'm wrong feel free to comment or reopen the issue.


Embed and integrate rest of Proton ecosystem

Would be awesome if the application also embedded the other services available, such as the calendar and the future Proton Drive.

Great idea! It's up for grab for whoever wants to contribute  :+1:


[CSI 2.6.0] Documentation enhancement for fsGroup feature- only applicable to RWO volumes

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Summary of changes for CSI 2.6.0 need to clearly state that fsGroup feature is only applicable for RWO volumes
Additional context
Add any other context or screenshots about the feature request here.
https://www.ibm.com/docs/en/spectrum-scale-csi?topic=26-summary-changes

This is updated in 2.6 docs.


[PLACEHOLDER] Issue for logging - What's the overal design and rubric for how logging should be structured.

It should cover @idoru Logging guidelines approach outlined here: https://github.com/vmware-tanzu/cartographer/issues/284#issuecomment-959828568

@idoru can you add additional details into this issue to capture all of Cartographer's logging needs?

I submit a straw man for pre-IPM:
Scope for this story is to add to CONTRIBUTING a logging guidelines section and to take a timeboxed-pass across each reconciliation loop to apply the agreed upon guidelines. As an outset, I've tried to frame things as broadly as possible:
Logging Guidelines
Logging is not a feature and must be taken into consideration with new changes.
Specifically, new code being added should contain an appropriate amount of logging.
When changing code, existing log statements should be altered to make sense.
Reconciliation loops must always log when they start and complete, as well as any errors that occur.
Errors should be logged using .Error()
Initiation and successful completion of non-trivial tasks should be logged using .Info()
More verbose logging can be logged using higher log levels .V(n).
If a task has variations in normal behavior, consider logging decision points.
Useful points to consider with writing and reviewing log messages:

who is this message for?
what information would be helpful? e.g. relevant parameters, values from config or request context
what information should not be logged?
what volume of logs will the code be expected to produce? is the V-level appropriate?
is it coherent with the stream of log messages before or after it?
is it coherent with the stream of log messages in it’s call trees?
if code is used in many different call trees or configurations, is it contextualized? (Use FromContext(), WithName() and WithValues())

@emmjohnson I think we can close this, want to look over it together?

This work was done with this PR https://github.com/vmware-tanzu/cartographer/pull/377
closing


Accessing the Image component within the Embed component

Required Information

[x] AEM Version, including Service Packs, Cumulative Fix Packs, etc: AEM SDK v2024.7.17258.20240726T172406Z-240700
[x] ACS AEM Commons Version: _____
[x] Reproducible on Latest? Yes

Expected Behavior
When I add an image dialog to the embed->embeddable component, the image selected should be rendered along with the other properties (HTML attributes) captured in the dialogs (cq:dialog,cq:design_dialogs...).
Actual Behavior
When I add an image dialog to the embed -> embeddable component, the image selected is not rendered but returns a 404 error. The ALT tag information is displayed. Upon inspecting the HTML, the SRC is captured within the image element.
Steps to Reproduce

Update the embed -> embeddable component to include the image dialogs/clientlibs.

Edit a page within AEM -> Sites

Add the embed component

Edit the embed component

Select the embeddable radio button

Select Image from the select field

Pick an image from the system

If needed, provide an ALT description

Click the Done button

Preview the page: The image does not appear.

HTML

Links
Embed Package
embed-package-troubleshoot-1.0.zip

Moved the Moved the ticket to this location: https://github.com/adobe/aem-core-wcm-components/issues/2840


Lambda function returns an invalid subnet size error

Hi,
This looks like something I could really make use of but your example success template returns "An invalid subnet size was specified: 24, 25, 26". I tried some other valid combinations but nothing works.
I checked the code and subnet size check looks ok to me.  (I am not a python expert though!)
# Check the sizes are valid
if any(size < 16 or size > 28 for size in sizes):
    return send_response(event, context, "FAILED", reason="An invalid subnet size was specified: {}".format(", ".join(sizes)))

You may want to consider updating the role so the function can send logs to cloudwatch.
Thanks!

Thanks for the feedback, I'll put cloudwatch on the todo list for this for sure.
As for your issue, it looks like you're passing in a string containing "24, 25, 26" rather than a list of a numbers. See the example code for the correct format, e.g Sizes: [24, 25, 26]


Disable unnamed-macro for cc-configure.

To make the build green again.
Adding name attribute to cc_configure properly requires synchronization with Bazel and passing the name through to places where we didn't expect before (e.g. hardcoded labels in non-templated BUILD files etc.). I leave that to another day.

Build failure is unrelated to this PR.


Express: Error when deleting custom entry locations

As discussed in https://github.com/concrete5/concrete5/issues/4790#issuecomment-537273383
How to reproduce.

Create a custom entry location
Create an express entity (Set the Results Folder Location to the custom entry).
Delete the custom entry location.
Return back to edit or view the entries (you'll get an error).

// On edit page
Exception Occurred: /path/to/concrete/single_pages/dashboard/system/express/entities/edit.php:78 Call to a member function getTreeNodeID() on null (1)

// On entries page
Exception Occurred: /path/to/concrete/src/Page/Controller/DashboardExpressEntriesPageController.php:76 Call to a member function populateDirectChildrenOnly() on null (1)

@aembler
As I've checked the detail about the issue-
When you delete the custom entry location, it lefts the entity_results_node_id to the ExpressEntities table which is already deleted from TreeNode table.
As this id is invalid, it generates error everywhere.
Now, there is a check if there is an entry for that entity.
https://github.com/concrete5/concrete5/blob/7b1a69eb9fe14e8f325a7ed4b7f028fa634b6669/concrete/views/dialogs/tree/node/category/delete_express.php#L7-L21
I think we should restrict the deletion if the custom entry location is associated with any entity instead of checking the number of entries.
Or
Implement a default entry location.

It shouldn't be closed!

We're waiting for review


secret generate for dashboard don't use the right parameter name

What happened:
secret generated for K8S dashboard doesn't respect the ingress controller secret definition and use kubernetes-dashboard-cert, kubernetes-dashboard-key instead of tls.cert, tls.key
see :

"The TLS secret must contain keys named tls.crt and tls.key that contain the certificate and private key to use for TLS"

inside official K8S documentation
https://kubernetes.io/docs/concepts/services-networking/ingress/#tls
the code :
https://github.com/cloudfoundry-incubator/kubo-release
/blob/3d1cefe324043dc1c3d93f19665424a55e37d49a/jobs/apply-specs/templates/bin/deploy-specs.erb#L28-L31
will create a secret with
apiVersion: v1
data:
  kubernetes-dashboard-cert: XXXXXX
  kubernetes-dashboard-key: XXXXX
kind: Secret
metadata:
  name: kubernetes-dashboard-certs
  namespace: kube-system
type: Opaque

What you expected to happen:
will create a secret with
apiVersion: v1
data:
  tls.cert: XXXXXX
  tls.key: XXXXX
kind: Secret
metadata:
  name: kubernetes-dashboard-certs
  namespace: kube-system
type: Opaque

The dashboard has been removed from CFCR


Fix dnsproxy

Coverage increased (+0.03%) to 68.33% when pulling fe709854df1243a282084e794b09fd6fecc1141e on andrey-malets:fix-dnsproxy into 191fd2f2f224ce6e4d5b7fec78e16493559fbb36 on chromium:master.

httpclient_test is failing, can you investigate?

Coverage increased (+0.03%) to 68.33% when pulling 3e0fa882257b31f7719204033cd09cc97f263fe4 on andrey-malets:fix-dnsproxy into 191fd2f2f224ce6e4d5b7fec78e16493559fbb36 on chromium:master.

It's failing on master too, the reason is that (probably newer versions of) httplib is defaulting the port to 443 if None was passed in ctor, but the test assumes None remains as a value for port. I changed the test to check the port 9443 which is explicitly set.

Thanks!


Nuxt generate ignores nujek css library

The nujek css library gets ignored on deploy.
On dev build nujek/ui/dist/nujek-ui.css is included in the build.
If you run a production build with the following command the css is missing.
yarn build && yarn start

Notice:
Nujek includes the css library on module startup. So you don't have to include it in the
nuxt config manually.
https://github.com/regenrek/nujek/blob/main/packages/ui/src/module.ts#L26
<EMAIL_ADDRESS>

Fixed in
├─<EMAIL_ADDRESS>└─<EMAIL_ADDRESS>
Related: https://github.com/vuejs/vue-loader/issues/1435


Fix pdf text render overlap by avoiding line breaks in pdflib

fixes #398
Pdfme calculates how lines should be split and renders them individually. It does this for a number of reasons including alignment, dynamic font size calculation and rotation.
Pdflib has it's own line breaking which, in theory, shouldn't happen if calculations between the 2 libraries match up. However, pdflib appears to be calculating the width of a line of some fonts differently (incorrectly) compared to pdfme. Regardless of what and why this difference is (it wasn't immediately obvious to me), we don't need pdflib to split lines because we've already done it.
You cannot tell pdflib not to split lines, but we can make it impossible through this change.
pdflib drawText() function does the following:
    const lines =
      options.maxWidth === undefined
        ? lineSplit(cleanText(text))
        : breakTextIntoLines(text, wordBreaks, options.maxWidth, textWidth);

Previously we pass the maxWidth option which will result in breakTextIntoLines() being called. This is a more intelligent line breaking algorithm which is very similar to what pdfme does (although comes up with a different result).
By not passing maxWidth, we instead will call lineSplit(), which is simply the following:
export const lineSplit = (text: string) => text.split(/[\n\f\r\u000B]/);

By updating our split regex to include \f (form feed) and u000B (line tabulation) we can ensure that no splitting will happen in pdf rendering, even if those characters are unlikely in the input.
BEFORE with text overlapping using Cairo font:

AFTER with no overlap:

@peteward
Great.
By adding |\f|\u000B, we can now correctly split patterns that were not covered before.
I plan to merge and release this later.


Make signal handler only call async-signal-safe functions

Signal handlers should only call async-signal-safe functions, as noted in man signal-safety (see relevant excerpt below). This rather simple patch makes the sighandler() function used to handle SIGSEGV compliant by removing any call to not async-signal-safe functions (such as printf() and similars).
Since this function is only used as signal handler for SIGSEGV, there's no need to do much pretty-printing, the only signal that can be received is SIGSEGV, so I just substituted the three calls to snprintf(), color_print() and fflush() with a single write() of a fixed message.
From man signal-safety:

An  async-signal-safe  function  is one that can be safely called from within a signal handler.  Many functions are not async-signal-safe.  In particular, nonreentrant functions are generally unsafe to call from a signal handler.
The kinds of issues that render a function unsafe can be quickly understood when one considers  the  implementation  of the stdio library, all of whose functions are not async-signal-safe.
When performing buffered I/O on a file, the stdio functions must maintain a statically allocated data buffer along with associated counters and indexes (or pointers) that record the amount of data and the current position  in  the  buffer. Suppose  that  the  main  program is in the middle of a call to a stdio function such as printf(3) where the buffer and associated variables have been partially updated.  If, at that moment, the program is interrupted by a  signal  handler that  also  calls  printf(3),  then  the second call to printf(3) will operate on inconsistent data, with unpredictable results.
To avoid problems with unsafe functions, there are two possible choices:

Ensure that (a) the signal handler calls only async-signal-safe functions, and (b)  the  signal  handler  itself  is reentrant with respect to global variables in the main program.

Block signal delivery in the main program when calling functions that are unsafe or operating on global data that is also accessed by the signal handler.

Generally, the second choice is difficult in programs of any complexity, so the first choice is taken.

The choice taken here is the first one.

merged. And so soon ;)


fix: setting NO_COLOR should not print ansi codes for non-terminals

closes #380

Rust version bumped from 1.77.2 to 1.78.0 in CI, do you want me to make a fixing PR?

The CI failures don't have anything to do with your changes, so I'm just gonna merge this. Thanks a lot!


What is the best setting for UVR to preserve harmony while eliminating vocals?

How to use UVR to eliminate vocals and preserve vocal harmonies in the accompaniment?

What does "overlay" "shifts" "Split Mode""Windows Size" "Chunks" " in details, and what is the best option for a clear instrumental output?


SNOW-781550: Add a .call() method to Session class

The Session class is missing a .call(procedureName: str, args: Object) method to call a stored procedure. The "args" parameter is a vararg to pass arguments to the sproc being called
For reference: https://github.com/snowflakedb/snowpark-python/blob/main/src/snowflake/snowpark/session.py#L1770

Is this scheduled to be implemented any time soon?

@DenWav It has implemented.
https://github.com/snowflakedb/snowpark-java-scala/blob/dd5e7d69a6919bf933df4e1d4d8e61b474bb7d5b/src/main/scala/com/snowflake/snowpark/Session.scala#L723
and
https://github.com/snowflakedb/snowpark-java-scala/blob/dd5e7d69a6919bf933df4e1d4d8e61b474bb7d5b/src/main/scala/com/snowflake/snowpark/Session.scala#L741

I see, I was looking for call, and didn't see that.


Fixed small buffer in get_datetime()

The buffer being hardcoded to 19 (the size expected from the default time format),
strftime() would fail on any format returning a longer buffer.
Changed it from 19 to 64 to accomodate longer formats.

Thanks a lot again! Did not see that :wink:


[improve] [client] support aggregate metrics for partition topic stats

Motivation
Right now, Producer client stats returns incorrect rate values for partition topic instead giving aggregate value across all partitions. Right now it always returns 0 but it can be aggregated for partition topic and give to client.
Modifications
Update aggregate rate value for producer stats.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Codecov Report

Merging #18214 (371a754) into master (6c65ca0) will increase coverage by 35.74%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             master   #18214       +/-   ##
=============================================
+ Coverage     34.91%   70.65%   +35.74%
+ Complexity     5707      437     -5270
=============================================
  Files           607       26      -581
  Lines         53396     2246    -51150
  Branches       5712      245     -5467
=============================================
- Hits          18644     1587    -17057
+ Misses        32119      486    -31633
+ Partials       2633      173     -2460

Flag
Coverage Δ

unittests
70.65% <100.00%> (+35.74%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...apache/pulsar/proxy/server/DirectProxyHandler.java
63.63% <100.00%> (ø)

...pache/pulsar/proxy/server/ProxyServiceStarter.java
60.66% <0.00%> (-1.34%)
:arrow_down:

...apache/pulsar/proxy/server/ParserProxyHandler.java
91.86% <0.00%> (ø)

...ache/pulsar/proxy/server/BrokerProxyValidator.java
89.15% <0.00%> (ø)

...sar/proxy/server/TargetAddressDeniedException.java
100.00% <0.00%> (ø)

.../main/java/org/apache/pulsar/PulsarStandalone.java

...n/java/org/apache/pulsar/broker/PulsarService.java

.../org/apache/pulsar/broker/admin/AdminResource.java

.../apache/pulsar/broker/admin/impl/ClustersBase.java

... and 576 more


Connection is getting closed based on pong

Hello,
First of all, thank you for this awesome library. It is very easy to use and fast to deploy. However, I've been having an issue lately and noticed a behavior that I cannot understand the logic behind it.
Here is the scenario, I'm connecting a remote server with context manager and default parameters. So, the library handles the whole ping pong thing. It sends a ping message and receives a pong. So far so good... But sometimes the remote server, for some reason, does not send pong back. However, I'm getting all the messages I expect. around 100 messages a minute, so at least 1 message every second. So we know the connection is good, the remote server is alive, etc.
My question is why does it close the connection? Even though it has not received a pong back in time, it still receives all the messages on time without any problem. It should ignore the ping pong as long as there are messages coming in, no?
Thank you!

Pongs are mandatory in the spec. I don't want to add complexity to work around that bug in the server you're connecting to :-/ I would suggest adding ping_timeout=None to the connect() call as a workaround.

Pongs are mandatory in the spec. I don't want to add complexity to work around that bug in the server you're connecting to :-/ I would suggest adding ping_timeout=None to the connect() call as a workaround.

thanks!


Problem with MARC conversion

In  Stage, i am having problems with the MARC conversion.  I have 3 to report, on 3 different tickets.  For URI https://api.stage.sinopia.io/resource/28d40973-ac2c-4abe-8b06-f53153c695c0  i get this message
Server error: Error: Ooops, something went wrong: [Rdf2marc::Models::General::CorporateName.new] "Federal Bureau of Investigation." (String) has invalid type for :subordinate_unit violates constraints (type?(Array, "Federal Bureau of Investigation.") failed)
Not sure even whether the error applies to the instance or work record since it appears in the lookup in each record (publisher name in instance, creator in work)
Using Firefox

@gdegroat thanks for reporting these. @justinlittman did some work on the conversion today and this one seems to convert successfully now. Could you check that it works for you and also that the results are as expected?

Yes, it works now--thanks!
greta


NUMERIC vectors

will work this extension for numeric type arrays?

No, sorry! It could be extended without too much effort I suppose. Let me know if you're still interested in using something like that.

This is a great extension, and I, too am looking for NUMERIC support. I started working on this in SolarNetwork/floatvec. I had a couple of questions I hoped @pjungwir you could help me with?

I wanted a "zero" Numeric cached global to help with performance of testing for zero before dividing. As I am a newbie to Postgres, do you think what I've done is a suitable way to achieve this? I see that Postgres has a private way of doing a similar thing.
Postgres 14 added support for Infinity values with the NUMERIC type. I implemented support for that in vec_div, returning NaN for Postgres < 14. I couldn't find a way to write test cases that were Postgres version-specific, however. These tests are written for Postgres < 14, and thus fail when running in 14.

I plan to finish implementing NUMERIC support for all these functions. If you like the look of the work, I can submit a PR. Thanks for your time!

I wanted a "zero" Numeric cached global to help with performance of testing for zero before dividing. As I am a newbie to Postgres, do you think what I've done is a suitable way to achieve this?

I looked at your code and it seems fine to me. But you have a FIXME comment, so it's not working? I can help you debug it if you like. I agree having a constant zero seems like a good idea.

I couldn't find a way to write test cases that were Postgres version-specific

I'd like to switch the tests to pg_regress and the PGXN testing framework, which is more standard. It's used for Postgres itself and its own contrib extensions. I've got a local commit for that already for aggs_for_vecs. We could do it here too (or I'm more inclined to just pull everything into aggs_for_vecs). Once I do that, we can write two versions of the expected output for a given test file, and Postgres will pass the test if either of them match. For example you can see this in Postgres's own xml test with results with and without libxml.

Ah great; the FIXME was a reminder to validate the approach, it is actually working for me and the tests all pass so I'll remove that comment. Per our discussion on aggs_for_vecs I will copy this work over to that project, having everything there will make it easier for me as well!


Update PebbleKit iOS 3.x (WIP)

There seems to be an issue with DataLogging in PebbleKit 3.0 that will be solved in PebbleKit 3.1

@Neal @C-D-Lewis Could you review+test the changes?

@C-D-Lewis Can we merge this? Looks good to me


Added driver initialisation code for all supported languages and browsers

The eagle eyed amongst you might notice there is no javascript example for Opera.  Apparently it is the only language binding which doesn't support locally launching Opera.

Thanks @hazmeister!


compatibility with Webpack 5 & Volto 17

When trying to use this addon in Volto 17, I got an error saying that Webpack 5 doesn't include anymore the polyfills for several node packages.
Without fully understanding what it means, I followed some Stackoverflow guidance :crossed_fingers: and fixed it with the changes in this PR.
I followed the following post to fix it:

https://stackoverflow.com/questions/64557638/how-to-polyfill-node-core-modules-in-webpack-5

I have checked the working of the block and it works as expected. I don't know if I have touched any internals with those changes...

I never experienced this issue with Volto 17 (just tested with Volto 17.15.5 and node 20 & 16). Does it require some specific setup to reproduce?
With your PR it works too, but I would like to understand how to reproduce this issue to validate the fix.

I am using it with Node v.20.10.0 and Volto 17.15.5. I don't know what can happen then :S

Me too, Ubuntu 22.04

As long as no one else confirms this issue (could not reproduce it in any way on different setups), I will close this PR, because I dont want to mess with the razzle config ;)


Port to Mobile

I'm trying to port this trained model to ios but always fail ( output model size is very large and dont know how to use it ) . Can you help to convert it to ios model ?

the size of model is large and you need host model on server and then connect that server with

you can use shufflenet/mobilenet as backbone to retrain this model ,or resize the input image to smaller size.after this work i get 20fps on mobile device

you can use shufflenet/mobilenet as backbone to retrain this model ,or resize the input image to smaller size.after this work i get 20fps on mobile device

大佬可否发我们参考一下如何修改，谢谢啦

Anyone can put the mobile device port model. I get an error in ONNX conversion, in avgpool. I want to convert in coreml. anyone has an idea please do help.


Fix for binary files.

Else files are opened in Text mode and get chopped on each 0x1c byte that means EOF.

Thank you! Could you please split in multiple pull requests? At least one for binary mode and another for Visual Studio fixes?

Well I had the same in mind. ;^)
But I'm sorry it some just got one big one.
(At least there is 'Fix to make it work for binary file.' commit. inside it.)
I'm new to github and still a little clumsy. ...and happy to get it done at least somehow.
(I'm also just getting into cmake...)
I hope you can also use it like this. I'm a little scared to mess things.

Hi @twogood and @Djamana, thanks for fixing the deobfuscate tool... uh... did you forget something? :stuck_out_tongue:
 lib/file.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/file.c b/lib/file.c
index dce530b..2dc7969 100644
--- a/lib/file.c
+++ b/lib/file.c
@@ -689,7 +689,7 @@ bool unshield_file_save (Unshield* unshield, int index, const char* filename)/*{

   if (filename)
   {
-    output = fopen(filename, "w");
+    output = fopen(filename, "wb");
     if (!output)
     {
       unshield_error("Failed to open output file '%s'", filename);
@@ -891,7 +891,7 @@ bool unshield_file_save_raw(Unshield* unshield, int index, const char* filename)

   if (filename)
   {
-    output = fopen(filename, "w");
+    output = fopen(filename, "wb");
     if (!output)
     {
       unshield_error("Failed to open output file '%s'", filename);
@@ -1008,7 +1008,7 @@ bool unshield_file_save_old(Unshield* unshield, int index, const char* filename)

   if (filename)
   {
-    output = fopen(filename, "w");
+    output = fopen(filename, "wb");
     if (!output)
     {
       unshield_error("Failed to open output file '%s'", filename);

@bugmenot2 : well... divide and conquer?

@bugmenot2: check master now! :-)


James

I modified the index.html file, added some style in a separate style.css file and removed internal style.Thanks Guys!!!

Pleas could you fix the conflict and merge,  use git pull to update changes from the repo


RAVTDBQ-420: Support for New Variations of STRTOK Function

changes looks fine. L1 completed.

I am okay with changes, mark it as L2 done


Safekeeper WAL Backup

Rebase of https://github.com/neondatabase/neon/pull/1583  on top of main (etcd and remote_storage library)
Missing tests

Please don't create new PRs to avoid losing reviews, comments and references. We now have 2 pages with reviews and one more with PR :)
I propose to close newest one, reopen this and check reviews from #1583.

done: https://github.com/neondatabase/neon/pull/1583

done

Not exactly what I had in mind, but works as well =)
So we just switch to #1583.


Error message when trying to install an extension which is not allowed doesn't mention that it is not in allow list

Testing #234993
I think it would be very helpful if the error message would mention that the extension is not allow listed. Instead of saying it is not available and causing the user to try and figure out why.

Can you please let me know how you are installing the extension? Any UI that allows user to install should be blocked.

It was either the Switch to Release Version button or Switch to pre-release Version button


backport changes to release-0.21

This PR backports several changes from the current main.

Avoid using squash for backport PRs


Add cwd support to yarn

It was missing from yarn triggering the following error:
Error: Command failed: yarn workspaces list --verbose --json

    at ChildProcess.exithandler (node:child_process:402:12)
    at ChildProcess.emit (node:events:513:28)
    at maybeClose (node:internal/child_process:1100:16)
    at Socket.<anonymous> (node:internal/child_process:458:11)
    at Socket.emit (node:events:513:28)
    at Pipe.<anonymous> (node:net:301:12) {
  code: 1,
  killed: false,
  signal: null,
  cmd: 'yarn workspaces list --verbose --json',
  stdout: "\x1B[31m\x1B[1mUsage Error\x1B[22m\x1B[39m: The nearest package directory (/Users/justin/repos/changeset-recover) doesn't seem to be part of the project declared in /Users/justin.\n" +
    '\n' +
    "- If /Users/justin isn't intended to be a project, remove any yarn.lock and/or package.json file there.\n" +
    '- If /Users/justin is intended to be a project, it might be that you forgot to list repos/changeset-recover in its workspace configuration.\n' +
    '- Finally, if /Users/justin is fine and you intend repos/changeset-recover to be treated as a completely separate project (not even a workspace), create an empty yarn.lock file in it.\n' +
    '\n' +
    '\x1B[1m$ \x1B[22myarn workspaces list [--since] [-R,--recursive] [-v,--verbose] [--json]\n',
  stderr: ''
}
 ELIFECYCLE  Command failed with exit code 1.

Thank you for fixing this!


Coverage check fail

I guess it's due to my new way to run tests. Need to fix it ASAP.

Fixed by b8f20388f3012e9d99181c2af4815afcae4af9d0


Add logging to html converter

Suggest to replace this.logger.debug into this.logger.silly for the loggings added to html-converter. Currently, they are quite annoying when using -l debug, but not focussing on the file reading issue.
(Note: add silly to the debug levels in the README.md of Walder)


wip: Update to embedded-hal v1.0

I'm not sure how to handle Reverse for InputPin: the 0.2 traits only give us &self, but the 1.0 traits require &mut self.
Maybe we can not implement InputPin on Reverse<T>, and and add a second set of mpls on Reverse<RefCell<T>> which does impl InputPin??

Maybe we can not implement InputPin on Reverse, and and add a second set of mpls on Reverse<RefCell> which does impl InputPin??

Hmm, this seems like the only way. At least I can't think of another. The trait has changed in a fundamentally breaking way, so we can only resort to interior mutability now.

Would be nice to get this :)

Seconding! 😊 I'm trying to use a 0.2.x driver that's not likely to get 1.0 compat soon, and I would extremely love to not have to add that support right now. :D

closing in favor of #34


Moved spatialnodehq from under tech companies with letter T to S.

Moved spatialnodehq from under tech companies with letter T to S.

Moved spatialnodehq from under tech companies with letter T to S.

Solution in #132


Question: How to manually send performance counters

Hi,
I had performance counters enabled by default but the amount of data is considerable for me (cost wise) and I don't need that level of granularity (every second). Is there a way to change it for it to be sent every x amount of time (I am fine with hourly or an hourly average for example). Thanks!

And thought about enabling sampling but I have custom metrics I wish to receive 100% of them. Guessing those get affected by reducing the % of samples?

Metrics are not affected by sampling rates -- they are always sent and sampled in. By default we collect several metrics every 1 minute.
I'd imagine you could override this by turning off the default autocollector when you setup the SDK .setAutoCollectPerformance(false) and then create your own via this constructor
https://github.com/microsoft/ApplicationInsights-node.js/blob/4a242f60e1e185442752d784da229a7412068b0d/AutoCollection/Performance.ts#L40-L44

@jcbit let us know if you are still having issues with this after Mark's suggestion


initial wip commit for data source for datacenter property sets

This is a pull request to demonstrate pull requests.
Work is not complete

Closed since this was done only to demo