[tracking] solo5 (virtio) on FreeBSD bhyve

status is: it works, but still needs some manual patches.  this uses clang instead of gcc.  the instructions are documented here.  I haven't tested more than console yet.
This issue is to track progress of upstreaming this into the solo5 mainline.  The biggest issue are include files.

libgcc.a is not needed to get linked in (it seems to be required on arm only, see #50 and https://github.com/mirage/mirage/pull/544) commit
solo5 uses nostdinc, but then includes ${CC} -print-file-name=include as system includes.  It then includes stddef.h from there, which drags in sys/_types.h on FreeBSD.  There are other headers needed, such as osreldate.h (by openlibm).  In order to build mirage-entropy-solo5 I needed to get rid of the gcc includes to get the intrinsics shipped with clang.  I've no proper idea how to deal with this best: provide our own stddef.h?  remove nostdinc?  Input is welcome how to solve this (note: the vanilla minios-xen uses nostdinc and does not use any system include (thus builds fine with clang); mirage modified minios drags in stdint.h and I wasn't able to get it working on FreeBSD).  e.g. grub completely ships their own header files.
ocaml-freestanding: POSIX cp does not have a -d flag commit (which is there to copy sys/time.h and its symlink time.h) -- see posix time.h vs posix sys/time.h
ocaml-freestanding: openlibm does use gcc as CC on non-Darwin systems, and needs to be patched (should be upstreamed to contain CC?=cc behaviour)
ocaml-freestanding: other Makefile.x86_64 for FreeBSD commit (includes the openlibm fix)
ocaml-freestanding: nolibc uses -Wall -Werror, but excludes -Wno-maybe-uninitialized which is gcc only (clang fails on that unknown option) -- a compiler-specific Makefile rule may solve that (can we fix the code instead?)
mirage: need to use ld from ports (thus /usr/local/bin/ld), the system provided one is too old to cope with -z max-page-size=0x1000 commit

comments, especially on how to sanely deal with stddef.h and friends (machine/_types.h machine/endian.h sys/_types.h sys/cdefs.h x86/_types.h x86/endian.h osreldate.h) would be highly appreciated!

Regarding include files, we can't remove -nostdinc as the results of including anything from /usr/include are unpredictable. I think the best option is to lift musl stddef.h, stdint.h, stdarg.h and the infrastructure needed to build their dependencies (arch/x86_64/bits/alltypes.h.in, tools/mkalltypes.sed, ...) and ship them with Solo5 directly. Musl supports clang so these should work fine (http://wiki.musl-libc.org/wiki/Supported_Platforms). Any objections to this approach? (ping @djwillia)
Regarding the ocaml-freestanding changes, there is a configure.sh which generates Makeconf at build time, so you could use this to detect if building on FreeBSD and/or clang and set the appropriate flags and asmrun Makefile there.
As for the dependency on ld from ports, not much we can do about that in the short term, other than:

Add Makeconf / configure.sh-style infrastructure to Solo5 and try and look for a good enough ld in "likely" places, failing if none was found.
Add pkg-config infrastructure to pass the correct ld from solo5-kernel-virtio through to mirage.

@mato @hannesm I agree; it seems the best option is to put those headers into the tree.
At the risk of sounding ignorant, if we are properly providing a build container (e.g., like mato's one from unikernel-runner), do we really need to solve compilation-on-multiple-platform issues?  I see the importance of having the resultant binaries and images run on other systems, but not the build?  The only possible upside I see is that building on multiple platforms may expose more bugs or weirdness that should be fixed regardless.  Am I missing something?  Has Docker not yet been made to work in a stable way with FreeBSD?

@djwillia while https://github.com/djwillia/solo5/commit/5084a971b5502a20bbe048f9dc20b9d37d5577b6 is not severe, I think https://github.com/mato/ocaml-freestanding/commit/b0c34ec8e57a010ad9a5e18f7e68b8b7644f0632 is a nice example why supporting multiple build platforms is a good idea.  Detecting bugs, be compatible to some POSIX standard...
clearly you can depend on having some docker installation to build solo5.  I appreciate more minimalistic approaches (which do not include dependency on yet another PL runtime (Go) etc.) for building a piece of software, esp since getting solo5 to build on FreeBSD (or other POSIX systems) is not a big pain.  I'd not want to add a dependency onto autoconf and friends, but some conditionals based on uname -s during build is IMHO fine.  while I have not tried docker (did not have the demand for it), there is a port to FreeBSD AFAIK.

@djwillia The Docker on FreeBSD port seems dormant (https://github.com/kvasdopil/docker/tree/freebsd-compat). In any case, while providing a dockerized build is great I don't think we should make Docker a hard dependency. And, as both you and @hannesm agree, building on multiple platforms tends to expose bugs so is worth the trouble :-)

@hannesm @mato Thanks for the explanations; makes sense to me!

@hannesm I've looked at ways of resolving the header file issue and unfortunately it's more complicated than I originally thought.
There are two groups of header files involved:

Standard C definitions: stdint.h, stddef.h, stdarg.h, ... gcc bundles these, clang does not.
CPU intrinsics: cpuid.h, x86intrin.h, ... gcc and clang both bundle these and they are relied on by (at least) the nocrypto code.

We can supply our own headers for "group 1", but not for "group 2" since these are compiler specific. However, I can't find any practical way of making it work:

With gcc, both groups are in the directory we get via gcc -print-file-name=include. So we can't get one without the other, hence shipping our own headers is kind of pointless.
With clang (on my FreeBSD 10.3-RELEASE test VM, clang 3.4.1) the "group 2" files live in /usr/include/clang/3.4.1. According to the man page, clang has a -nostdlibinc option which is documented as:

Do not search the standard system directories for include files, but do search compiler builtin include directories.

However, this does not actually work -- I tried it with a test program and the compiler cannot find cpuid.h with -nostdlibinc. I tried various other options to clang but could not find one that would point me to the "builtin" include directory.
Conclusion: In the interests of getting initial versions of the Mirage/Solo5 packages published, I'd like to postpone this work, keep the dependency on the libgcc headers and revisit the clang situation later.

thanks for investigating. regarding 2: clang -print-file-name=include returns the directory for group 2 (on my FreeBSD-CURRENT /usr/bin/../lib/clang/3.8.0/include, there is no longer any /usr/include/clang)

Ok, so that's changed. On 10.3-RELEASE it returns /usr/lib/include. Can you check if the following compiles with -nostdlibinc on CURRENT?
#include <cpuid.h>

int main(int argc, char *argv[])
{
    int max = __get_cpuid_max (0, &max);
    return max;
}

that works fine here (clang 3.8.0):
] cc -nostdlibinc -o foo foo.c
foo.c:5:35: warning: passing 'int *' to parameter of type 'unsigned int *' converts between pointers to
      integer types with different sign [-Wpointer-sign]
    int max = __get_cpuid_max (0, &max);
                                  ^~~~
/usr/bin/../lib/clang/3.8.0/include/cpuid.h:181:74: note: passing argument to parameter '__sig' here
static __inline int __get_cpuid_max (unsigned int __level, unsigned int *__sig)
                                                                         ^
1 warning generated.
] ./foo
] echo $?
20

updates here:

solo5: [https://github.com/Solo5/solo5/pull/68](build system fix) and using -nostdlibinc and a /tmp/include; cp instructions at https://hannes.nqsb.io/Posts/Solo5
ocaml-freestanding: new openlibm,  opam fix, and minor hacks (https://github.com/hannesm/ocaml-freestanding/commits/FreeBSD): FreeBSD makefile for OCaml, remove Wno-maybe-uninitialized from nolibc
mirage using the solo5 PR
export LD=/usr/local/bin/ld

I updated the task list at the top!

@hannesm I got tired of having to hand-apply hacks to build and test virtio on FreeBSD, so I've integrated most of your changes:

#102 has the Solo5 parts. Uses a variant of the /tmp/myinclude approach to make things work.
mirage/ocaml-freestanding#9 has the rest.
Could you review/test these and let me know what you think? I've tested on 11.0-RELEASE and partially on 10.3-RELEASE and all seems fine.

The following parts are still missing for an "out of the box" experience:

conf-pkg-config needs to gain a depext on pkgconf for FreeBSD.
Makefile generation in mirage should be modified to set the default LD for Solo5 targets from the output of pkg-config solo5-kernel-virtio --variable=ld.

If you could handle the above I'd appreciate it!

Additionally, the following two commits are required to build gmp-freestanding and zarith-freestanding on FreeBSD:

https://github.com/hannesm/opam-repository/commit/ca31a93811d9bf61ce5432a76e627d93e8e19a92
https://github.com/hannesm/opam-repository/commit/315c2d277f447da71ab77b639d6b730031766a92

thx @mato -- the zarith-freestanding and gmp-freestanding have just been merged to opam-repository! :) (see https://github.com/ocaml/opam-repository/pull/7614)

I've pushed some more fixes to both PRs. With these (and ocaml/opam-repository #7627) I can now build the whole stack (well, static_website_tls) and the built binary runs fine on 11.0-RELEASE.
I've also been testing on 10.3-RELEASE, things work 80% of the time there, unfortunately mirage-entropy-solo5 will not build due to clang -nostdlibinc missing headers for the CPU builtins. I'm not going to try and fix this, suggest to ask people to just use 11.0-RELEASE or newer.
@hannesm So, I think it's OK to merge #102 and mirage/ocaml-freestanding#9 -- if there are issues with -CURRENT (I hope not!) we can fix those separately.

thanks (especially to @mato) we're finally in a state where this all works (more or less) out of the box, the only missing bit is the LD define, which is PR'ed in https://github.com/mirage/mirage/pull/623 and was just merged :)


for a very long deletion like 10kb between alleles, which allele will be placed in the primary contig?

dear Author,
I like to ask if Falcon consistently select a longer or a shorter alleles into the primary contig.
For example, there is a 10kb deletion between two alleles, which allele would be retained in the primary contig?
best regards,
Shengfeng

Usually, the longer is in the "primary" contig, since that's the longest full path we can find. This is not configurable however.


Hey!

Hey, I was wondering what it meant by console like what console is it talking about? Is it the node.js?
Love Cherri

Windows console click win+r and type in cmd and click enter it should bring up a console.


Set up a rival hot dog stand in central Reykjavik

Description:
ETA: 2023-10-25
Maintainer: Patrick Woodhead
### Milestones
- [ ]

Known dependencies:

View this starmap at:

+1


docs: Document mainSections

See https://github.com/spf13/hugo/issues/3206

Closing this as a duplicate of https://github.com/rdwatters/hugo-docs-concept/issues/79.


Move default settings from code to settings.yml

Move default settings from code to settings.yml
@miq-bot add-label wip, core

@miq-bot remove-label wip

@Fryguy could you review

Looks good to me. Anyone else have ideas here?

:+1: LGTM - :shipit:


fix world.isLoaded(pos)

checked with script, but it only indicates client state*

You need to remove the deprecation message in the @FunctionDoc annotation


Couldn't find binary when building APK

Issue Description

Today I always facing "Couldn't find binary" issue when building APK, i'm already using the latest fastlane and plugin and this happen today.
Configuration

firebase_app_distribution(
    app: ENV['APP_ID'] || options[:app_id],
    groups: ENV["GROUPS"] || options[:groups],
    release_notes: options[:notes] || "",
    firebase_cli_token: options[:firebase_token],
    android_artifact_type: "APK",
    android_artifact_path: "./android/app/build/outputs/apk/stg/release/app-stg-release.apk"
  )

Complete verbose output

[01:36:31]: --- Step: firebase_app_distribution ---
[01:36:31]: ---------------------------------------
+------------------------------------------------------------------------------------------------------------------------+
|                                                      Lane Context                                                      |
+-------------------------------------+----------------------------------------------------------------------------------+
| PLATFORM_NAME                       |                                                                                |
| LANE_NAME                           | beta                                                                             |
| VERSION_CODE                        | 460                                                                              |
| GRADLE_ALL_APK_OUTPUT_PATHS         | ["/root/project/android/app/build/outputs/apk/stg/release/app-stg-release.apk"]  |
| GRADLE_ALL_AAB_OUTPUT_PATHS         | []                                                                               |
| GRADLE_ALL_OUTPUT_JSON_OUTPUT_PATHS | ["/root/project/android/app/build/outputs/apk/stg/release/output-metadata.json"] |
| GRADLE_ALL_MAPPING_TXT_OUTPUT_PATHS | ["/root/project/android/app/build/outputs/mapping/stgRelease/mapping.txt"]       |
| GRADLE_APK_OUTPUT_PATH              | /root/project/android/app/build/outputs/apk/stg/release/app-stg-release.apk      |
| GRADLE_OUTPUT_JSON_OUTPUT_PATH      | /root/project/android/app/build/outputs/apk/stg/release/output-metadata.json     |
| GRADLE_MAPPING_TXT_OUTPUT_PATH      | /root/project/android/app/build/outputs/mapping/stgRelease/mapping.txt           |
+-------------------------------------+----------------------------------------------------------------------------------+
[01:36:31]: Couldn't find binary

+------------------------------------------------+
|                fastlane summary                |
+------+---------------------------+-------------+
| Step | Action                    | Time (in s) |
+------+---------------------------+-------------+
| 1    | increment_version_code    | 0           |
| 2    | yarn bundle:android:stg   | 129         |
| 3    | app:assemblestgRelease    | 661         |
| 💥   | firebase_app_distribution | 0           |
+------+---------------------------+-------------+

[01:36:31]: fastlane finished with errors```

##### Environment
<!-- What version of `fastlane` are you using? What version of `fastlane-plugin-firebase_app_distribution` are you using?  Note your issue may already be fixed in the latest version. The latest version can be found at https://github.com/fastlane/fastlane-plugin-firebase_app_distribution/releases -->

| Library     | Version |
| ----------- | ----------- |
| fastlane | 2.216.0 |
| fastlane-plugin-firebase_app_distribution | 0.7.3 |

Hey @Drzaln, could you try specifying the whole path instead of the relative path in your firebase_app_distribution config?

Closing this for now feel free to re-open if the suggested fix doesn't work for you.


misc adjust disk resourse limit mode entrance threshold

What problem does this PR solve?
File cache storage will take extra space because of file page alignment. Lower the configuration to make the disk space alert silent.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[x] No need to test or manual test. Explain why:

[x] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[x] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run buildall


Revamp API

Remove graceful
Add httprouter
Tweak consensus, explorer, and gateway routes
Remove /daemon/update routes
Overhaul renter routes

httprouter is pretty great, a very minimal and high-performance library that gives us easy access to path parameters like /wallet/transactions/<id>. It also lets us easily enforce proper methods, so I was able to toss out hundreds of lines of method checking code.
All API calls should return structs with lowercase field names now. (No more bare return values.)
I've updated siac to implement these API changes, but Sia-UI (and the explorer) will need some adjustments. We can also discuss whether the changes to various calls seem reasonable.

Overall I like these changes. Some of the code changed too much for the diff to be much use, but I'll be looking at the raw files in a bit.
As far as I understand, you've now moved the whole api over to a RESTful paradigm? If so, that's a pretty significant milestone.

>all those outdated diffs
wew
should be good to go now, unless you feel strongly about DaemonConstantsGET


add action-foreach alerting

 Issue by w-HA
Friday Feb 19, 2021 at 08:48 GMT
Originally opened as https://github.com/opendistro-for-elasticsearch/alerting/issues/354

Dears,
Is this function exist in alerting module
https://www.elastic.co/guide/en/elasticsearch/reference/7.3/action-foreach.html
I think it's very interesting to do only 1 monitor with aggregations and only 1 action
My exemple
{
"size": 0,
"query": {
"bool": {
"must": [
{
"query_string": {
"query": "status:3 AND type:0",
"fields": [],
"type": "best_fields",
"default_operator": "or",
"max_determinized_states": 10000,
"enable_position_increments": true,
"fuzziness": "AUTO",
"fuzzy_prefix_length": 0,
"fuzzy_max_expansions": 50,
"phrase_slop": 0,
"analyze_wildcard": true,
"time_zone": "Europe/Paris",
"escape": false,
"auto_generate_synonyms_phrase_query": true,
"fuzzy_transpositions": true,
"boost": 1
}
}
],
"filter": [
{
"range": {
"confirm_or_cancel_date": {
"from": "now-1h",
"to": "now",
"include_lower": true,
"include_upper": true,
"format": "strict_date_optional_time",
"boost": 1
}
}
}
],
"adjust_pure_negative": true,
"boost": 1
}
},
"aggregations": {
"compte": {
"terms": {
"field": "mct_id.keyword",
"size": 10,
"min_doc_count": 1,
"shard_min_doc_count": 0,
"show_term_doc_count_error": false,
"order": [
{
"_count": "desc"
},
{
"_key": "asc"
}
]
}
}
}
}
With trigger
int score = 0;
for (int i = 0; i < ctx.results[0].aggregations.compte.buckets.size(); i++) {
if (ctx.results[0].aggregations.compte.buckets[i].doc_count > 0) return true;  }
and action email
Monitor just entered alert status. Please investigate the issue.

Test : {{ctx.results.0.aggregations.compte.buckets.0.key}} - Value : {{ctx.results.0.aggregations.compte.buckets.0.doc_count}}
Severity: {{ctx.trigger.severity}}
Period start: {{ctx.periodStart}}
Period end: {{ctx.periodEnd}}

and result
Monitor just entered alert status. Please investigate the issue.

Test : 2651 - Value : 1429
Severity: 1
Period start: 2021-02-19T08:38:00Z
Period end: 2021-02-19T08:43:00Z

I need to send one mail ( or something else ) per aggregations ( i )
Thanks a lot
Benoit

Hey @w-HA,
As of OpenSearch 1.1 we've added Bucket-Level Monitors which allow for grouping by/aggregating on fields and I think it's exactly what you're looking for. I suggest using it alongside the Alerting Dashboards plugin since we've also refactored the Monitor creation experience there to be more robust.
I'm closing this issue but feel free to re-open it if you have any questions or follow-ups.


Any plans to add an alpine variant for arm32v7?

I cant find containers like arm32v7:3.6.0-alpine . The closest to it are slim variants.

Correct, Alpine is not officially multiarch yet; see https://github.com/gliderlabs/docker-alpine/issues/304.
Once Alpine is multiarch, we'll add arm32v6 to the Alpine architectures here. 👍


New-HTMLTable HREF date sort not working

Does an HTML table support sorting by date when your using HREF link text?
For example the table cell content is:
2/11/2023 5:21:32 AM
My sorting format is -DateTimeSortingFormat 'M/d/yyyy h:mm:ss tt' but I can't get it to work.  It does sort but it's not treating them as dates so some dates aren't in the correct order.  I'm guessing perhaps the date sort logic isn't capable of handling the HREF link text.

We would need to build some custom sorting. DataTables for sure supports it, but you would need find how to implement it, as the sorting would effectively need to remove "tags" and content and just leave a date. Doable, but probably not great. Especially that it could be something more complicated.


feat(clouderror)!: preserve grpc error code if present

This feature ensures that the original gRPC error code is preserved
when an error is wrapped, rather than being automatically promoted to a
generic Internal error.
Problem
When a downstream function throws a gRPC error, and the callee wraps that error
(as shown in the code snippet), the original error code (e.g., InvalidArgument)
is replaced with a Internal error.
func Handle() (any, error){
	resp, err := Service()
	if err != nil {
		return nil, cloudrunner.WrapTransient(err, "service error")
	}
	return resp, nil
}

func Service() (any, error){
	return nil, status.Error(codes.InvalidArgument, codes.InvalidArgument.String())
}

This is a breaking change in the sense that it changes the behavior of WrapTransient.
TRA-1791

The purpose of WrapTransient is to mark errors and not forward statuses unless specifically pointed out. An underlying status code from a storage layer should not be automatically forwarded to users, because it may be related to failing transactions etc that should not be a concern on the layer above.

The purpose of WrapTransient is to mask errors and not forward statuses unless specifically pointed out. An underlying status code from a storage layer should not be automatically forwarded to users, because it may be related to failing transactions etc that should not be a concern on the layer above.

I see what you mean, then I think that is unclear from the documentation:
// WrapTransient wraps transient errors (possibly status.Status) with
// appropriate codes.Code. The returned error will always be a status.Status
// with description set to msg.
func WrapTransient(err error, msg string) error {
...

My main goal here is preserve the gRPC code if present, in order to not trigger so many false positive alerts in production.
Do you have any other idea of how this can be achieved in a better way?
Another alternative is to keep WrapTransient as is, and create a new method which clearly states that it just wrap and preserves the gRPC error code if present.


Convert all component styles to external sass/stylus files

I'm not hating the isolated css...

is there a way to share css variables between the components?

@lupinskij

@samccone

--cat-dog
read this page
https://www.polymer-project.org/1.0/docs/devguide/styling.html


EOv3-chrisda to Master

Docs Build status updates of commit f1f443a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/docs-conceptual/exchange-online-powershell-v2.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Connect-ExchangeOnline.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Device reboots (CON-493)

@dhrishi
after commit ad126a98dfda9c2988d24efc78b381e76294458a the device reboots
abort() was called at PC 0x4011e755 on core 1
0x4011e755: chip::DeviceLayer::GetCommissionableDataProvider()
build/esp-idf/chip/../../../../../../../../esp/esp-matter/connectedhomeip/connectedhomeip/config/esp32/third_party/connectedhomeip/src/lib/support/CodeUtils.h:508

@stefano055415 Which example are you trying out, and on which branch? ESP-IDF version? Have you changed any configuration options? Can you provide these details.
I would recommend you to clean the example build and give it a try again.
$ cd /path/to/examples/your_example
$ rm -rf sdkconfig sdkconfig.old build/
$ idf.py erase-flash build flash monitor

Please upload (and not paste) the entire device side logs if you still see the issue.

@dhrishi
ok i found the problem, i had to add
CONFIG_FACTORY_COMMISSIONABLE_DATA_PROVIDER=y
CONFIG_FACTORY_DEVICE_INSTANCE_INFO_PROVIDER=y
CONFIG_FACTORY_DEVICE_INFO_PROVIDER=y

CONFIG_FACTORY_DEVICE_INFO_PROVIDER=y

where did you add these?


Opening a Modal from a Modal

<Modal isVisible={this.props.isFirstModalVisible}>
    <View>
        <TouchableOpacity onPress={() => this.props.showSecondModal()}>
               <Text>{'show second modal'}</Text>
         </TouchableOpacity>
    </View>
</Modal>

<Modal isVisible={this.props.isSecondModalVisible}>
    <View>
        <Text>{'Hello World'}</Text>
    </View>
</Modal>

<TouchableOpacity onPress={() => this.props.showFirstModal()}>
     <Text>{'show first modal'}</Text>
</TouchableOpacity>

second modal doesn't open, i'm using redux
plz help

I'm sorry @impuulse but the info you're providing are not detailed enough for me to understand your issue.
Please take a look at the issue template below and make sure to complete all the required steps, it will speed up the issue resolution.

When reporting a bug, please be sure to check if the issue still persists with react-native original modal:
Under the hood react-native-modal uses react-native original Modal component.
Before reporting a bug, try swapping react-native-modal with react-native original Modal component to check if the problem persists.
When reporting a bug, please be sure to include the following:

[ ] The outcome of the react-native-modal swap described above
[ ] A descriptive title
[ ] An isolated way to reproduce the behavior (example: GitHub repository with code isolated to the issue that anyone can clone to observe the problem)
[ ] What version of react-native-modal you're using, and the platform(s) you're running it on (iOS, Android, device)
[ ] What packages or other dependencies you're using
[ ] The behavior you expect to see, and the actual behavior


Ability to add additional query string parameters to all methods

Additional query string parameter details are detailed here https://www.firebase.com/docs/rest/api/#section-query-parameters
Let me know if you need me to amend or change anything.
Thanks,
Jon

Coverage decreased (-0.3%) to 93.15% when pulling 270e91a922ea1dcc6434b07eb292adbff6fb2cf0 on cloudaccessio:add-optional-query-string-params into c41541c4c1755bac0385534d3a33587a75e04632 on CloudCom:master.

Which query parameters are you using?

Would you be open to implementing each of the query parameters as methods, similar to how we implemented the auth parameter?
That would end up looking something like this:
Shallow()

// this would map to "format=export"
IncludePriority()

// since "print=pretty" doesn't quite make sense for this library, this would be the same as "print=silent"
Silent()

// these may be wrapped up into a Query() method
OrderBy()
LimitToFirst()
LimitToLast()
StartAt()
EndAt()
EqualTo()

Maybe you'd like to implement a subset of these?

Like your structure better.
I'll get them implemented, will probably be tomorrow now.

Looking forward to it. :+1:

@jondunning Were you able to make any progress on this?

Closed by #34


Providers only allow one namespace, but Spinnaker allows many to be used.

This will likely require a migration and splitting the single table apart, unless we do something gross like splitting a string.

I've given this some thought and I think we need to provide a backwards compatible approach for now.
We should add a namespaces field to the provider, so the provider JSON looks something like:
{
	"name": "provider-name",
	"host": "provider-host",
	"caData": "provider-ca-data",
	"tokenProvider": "provider-token-provider",
	"namespace": "OPTIONAL",
        "namespaces": [
               "OPTIONAL"
       ]
}

Some fields redacted for legibility. Having both the namespace and namespaces fields is confusing and we should deprecate the namespace field for a future release to remove it.
We should create a new SQL table kubernetes_providers_namespaces with an association clause. The table would have two columns for account_name and namespace, allowing a one-to-many association of accounts to namespaces.

All references to provider.Namespace throughout the code must be replaced with references to provider.Namespaces
All associated logic with provider.Namespace must be tested and modified to work with the namespaces array
When retrieving providers append any namespace stored in the kubernetes_providers table to the namespaces array
When creating/updating a provider append the namespace field (if set) to the namespaces array
Update the swagger def to note these changes, and if possible note that the namespace field is deprecated
Create an issue to remove the namespace field in a future release

Seems like a sane approach.  I'd also make sure the API calls have at most one of namespace or namespaces set.  What do the GET requests look like in this context, and PUT requests?  If I set namespaces will that automatically clear namespace?

The idea now is just to allow setting both. If both are set, then the value of namespace is appended to the namespaces array on create/update.
Let me know if this answers your question.

@abe21412 @guido9j we can close this since https://github.com/homedepot/go-clouddriver/pull/138 implements this enhancement


Add a landing page for the peer dispatcher

The dispatcher should server some kind of a landing page, and create an instance only on a special route. ex: "/create"
The landing page should contain basic information about the project, a button to create a new peer and have a style similar to the peer page.

#6


POC extending without plugin

This is just an example how one can extend VTU with either normal prototype attachment, or via a dedicated API.
Please give me your opinions on which one you think is better?

@afontcu @JessicaSachs  What is your opinion?
Should we promote prototype extension or create a dedicated api, like the one I have proposed here? I think i am aiming at the prototype one.

Should we promote prototype extension or create a dedicated api, like the one I have proposed here? I think i am aiming at the prototype one.

hey! 👋 Not 100% sure, actually 😇  I'm a bit concerned with the actual implementation of both examples:
return this.componentVM.$.type.name
vs
return this.name().toLocaleLowerCase()
the former looks way more complicated to grasp than the latter. Are those two equivalent? Is there a way to simplify the first one?
Thanks for this!

Haha no no, that was just a way to test whether they work. One uses the method added prior.
How you access the internals is the same in both cases.

Haha no no, that was just a way to test whether they work. One uses the method added prior.
How you access the internals is the same in both cases.

Yeah okay makes sense hahaha.
I do think that relying on prototypes "feels" hacky, even though I'm OK with this given that it's an advanced feature and that it should be documented 👍

So if we are going with the VueWrapper.prototype for now, do we just need to  export VueWrapper and that's it?
What is the status of this PR @dobromir-hristov

We just need to export DOMWrapper and VueWrapper and that should be it. We should also test this after it is transpiled, so that means when it is published as a package.

Ok, want to update this to just export those two?
I made a ticket for some e2e tests: https://github.com/vuejs/vue-test-utils-next/issues/68

@dobromir-hristov should we export DOMWrapper too?

I guess this would become the "right" approach to extend VTU as Vue Testing Library does? I mean, the way to add "custom" matchers and other stuff. I'll try to give this a go during the weekend and come back to you folks with the result 👍

So I just finished toying around. I found the API a bit awkward at first. I'll see if there's a pattern that feels more natural. I mostly found that I just wanted the this context in a closure while I was extending VueWrapper.
Before:
config.plugins.VueWrapper.name = function name() {
  return this.componentVM.$.type.name
}

config.plugins.VueWrapper.lowerCaseName = function lowerCaseName() {
  return this.name().toLocaleLowerCase()
}

Possible solution to enclose the wrapper instance?
config.plugins.VueWrapper.extend((wrapper) => ({
  lowerCaseName: () => wrapper.name,
  name: () => wrapper.componentVM.$.type.name
})

The other thing I'd like to solve is the ability to use reactive properties so that not everything has to be a method. I'll continue toying with that.

So no prototype extension?
Private field would not be accessible if passed as a param.

You would still apply it to the prototype when you install the plugin in the constructor. I'm mostly just concerned with getting a reference to wrapper.

Are we leaning towards @JessicaSachs implementation for a plug-in or this one? Let's pick one and focus on that. I am excited to write some plug-ins (mainly findByTestId).

Are we leaning towards @JessicaSachs implementation for a plug-in or this one? Let's pick one and focus on that. I am excited to write some plug-ins (mainly findByTestId).


feat(region,host): sriov nic support

Support sriov nic passthrough to kvm guest.
Signed-off-by: wanyaoqi<EMAIL_ADDRESS>What this PR does / why we need it:

Does this PR need to be backport to the previous release branch?:
NONE

/hold


Added get_offers_for_page and get_page_count_for_filters

Added get_offers_for_page and get_page_count_for_filters

Changes Unknown when pulling 6f0b67da3985f23a43e5bfff59e92c70ea0c0768 on aklein13:master into ** on limebrains:master**.

Changes Unknown when pulling 326481799a31dfcf98a6a59544dcafa850ce1dd6 on aklein13:master into ** on limebrains:master**.


Mastermind

Ported Mastermind to C#

Are there any issues with this pull request?  Should I close it?

So sorry, I missed this one! No issue, merging now.


Get-PnPListPermissions - Updated example 2

Type

[x] Bug Fix
[ ] New Feature
[ ] Sample

Related Issues?
None
What is in this Pull Request ?
Updated example 2 in Get-PnPListPermissions (typo)

Good catch! Thank you!

Good catch! Thank you!


[WIP] Add connection to ServiceNow and support issuing a ticket associated to an Intersight server

When implemented, this PR will provide the features to resolve #76:
support for creating a ServiceNow ticket associated to a server on the ManageIQ UI.
For now, this only contains a stub. I am creating this PR only for planning this feature in this release cycle.

Let's discuss in #76 first.


docs(timeout): Update timeout error message

Also changed the way headers work in the timeouts doc, so now the error message has a direct link to the right spot.

Looks good!


CommonJS?

Hi,
How can this plugin be used with commonjs (browserify)?
Thanks.

:+1:

We are updating the plugin to be used with commonjs.
https://github.com/MailOnline/videojs-vast-vpaid/tree/videojs-5x

We released the videojs.vast.vpaid plugin version 1.0 and now the plugin use commonJs (browserify + babelify).

@massa84 how does one import it with browserify?

[11:42:50] Browserify Error { [Error: Cannot find module 'VPAIDFLASHClient/js/VPAIDFLASHClient' from '/Users/lpender/dev/freelance/savvygo/bower_components/videojs-vast-vpaid/src/scripts/ads/vast']

[11:42:50] Browserify Error { [Error: Cannot find module 'VPAIDHTML5Client/js/VPAIDHTML5Client' from '/Users/lpender/dev/freelance/savvygo/bower_components/videojs-vast-vpaid/src/scripts/ads/vpaid']

[11:42:50] Browserify Error { [Error: Cannot find module 'VPAIDFLASHClient/js/VPAIDFLASHClient' from '/Users/lpender/dev/freelance/savvygo/bower_components/videojs-vast-vpaid/src/scripts/ads/vpaid']


Add audio/sound support

I've been looking at adding audio support for about two weeks now and this PR is mainly to detail some of the issues I've encountered and to see whether they could be resolved. I realise this long winded way of discussing it is a bit pretentious and for that I'm sorry, but I wanted to document this against the project for anyone else who is interested in future. First though I want to make the case for adding sound to boot2docker.
Why?

Docker now supports passing --device /dev/snd:/dev/snd #756
boot2docker is the de facto dev tool for using Docker. As they depend on it for their dev machines it means that without audio a whole class of tools are ruled out of using Docker. (synthesizers, audio workstations, guitar amp simulators)
Docker for desktop apps. People are already starting to use Docker for running web browsers as an added layer of security. YouTube isn't much fun without audio...

Issues

Why not just add the required packages to the Dockerfile and build a new iso?

The audio packages from the tinycore repo are not built for the 4.0.5 kernel. The current version for the alsa-modules package is 3.16.6 which means that the modules get installed into two different folders.
docker@boot2docker:~$ ls /lib/modules/
3.16.6-tinycore64/  4.0.5-boot2docker/

I think this means the required modules are not picked up by depmod -a. This means there's no /proc/asound. I'm not an expert on this so I may be missing something here.
Solutions

Build an image with audio from version 3 of the Kernel

That's the approach I've gone for here https://github.com/boot2docker/boot2docker/compare/a270c71...xavriley:kernel3_with_audio and it should work in theory but I'm not able to login to the VM. I think that's a separate issue though...

Get tinycore to package tcz for the latest Kernel

This doesn't seem likely as I don't think they are a huge outfit and they'll want to stick to stable kernel versions I suspect. Also the uname of the latest b2d images is 4.0.5-boot2docker which actually breaks the package manager for tinycore. It uses the $KERNEL string to determine whether to install 32bit or 64bit packages

Package and self host the relevant libs in a boot2docker repo somewhere

Hosting a tinycore repo is as simple as having a webserver with static files. I suspect this could even be a github pages thing. Obviously that's a big effort/commitment but it would give an added layer of flexibility.

Something else?

I've tried several ways and none of them have worked so far. Any feedback or input would be much appreciated. Sorry if this PR is unhelpful.

I'm somewhat interested, as I too use b2d on a desktop. but yes, its not a big priority.

I'm not opposed to including the necessary kernel bits for this as modules, but I don't think I'm comfortable with including the userspace portions too -- can't those run in a container as long as the kernel modules are in place?
I know Jessie is a big fan of running pulseaudio specifically inside a container (see https://github.com/jfrazelle/dockerfiles/tree/master/pulseaudio).

Yes Jessie's post on Docker on the desktop is awesome https://blog.jessfraz.com/post/docker-containers-on-the-desktop/ :)
Including the kernel bits would be a good start I think.
The reason I've had to include userspace tcz packages is for two reasons.
a) The host b2d instance needs to know about /dev/snd in order to be able to pass this on to any containers. I think this means the TC has to have alsa installed (or an equivalent) to pick up the sound card.
b) As I've tried to describe above, the tce package manager is broken for some packages in the b2d build. I tried several ways to install them on a vanilla b2d without success. Specifically, any packages (or deps) which list the kernel number or use the $KERNEL var to specify whether they should be 32 or 64 bit won't install.
I'm happy to investigate some other approaches if anyone has suggestions.

Hello, i'm also interested, not for desktop, but i need audio for my telecom dev plateform. I'm running linphone on docker but this is impossible with docker-machine.

AFAIK the standard boot2docker is missing a big chunk of VirtualBox Guest Additions and too many kernel modules. Therefore one has to devise his own image for desktop use.
ps: It seems that hyper_v.patch is missing in your PR...

Has anyone gotten this to work with OSX? Using this or even the new docker for mac

Sorry for the long tail!
If someone wanted to recreate this with just the minimal necessary kernel changes to enable audio support, I'd be open to the idea (assuming it doesn't bloat the ISO size), but as I've noted above, this PR is not acceptable as-is (even if it were to be rebased/updated to match the changes made in the meantime).
Thanks for the contribution!


init: must be run as PID 1 when running via docker-in-docker in a devcontainer

I'm seeing an error
init: must be run as PID 1
When run in Codespaces with docker-in-docker feature and the image evidencedev/devenv:latest. Is there a reason why init wants PID 1?
Log:
@aaronsteers ➜ /workspaces/meltano-demo-in-a-box/analyze (evidence-dev ✗) $ meltano invoke --containers evidence:init
2022-10-26T05:36:36.975058Z [info     ] Environment 'dev' is active
2022-10-26T05:36:37.278228Z [info     ] Running command in container   container_name=meltano-evidence--init-690b254b-ffa3-463d-a2be-b4de0a7b77f0
2022-10-26T05:36:38.065090Z [info     ] Starting Evidence.dev development environment mounted on /evidence-workspace in the container.
2022-10-26T05:36:38.065273Z [info     ] Provided arguments => init
2022-10-26T05:36:38.065362Z [info     ] Running command => init
2022-10-26T05:36:38.065441Z [info     ] init: must be run as PID 1

@aaronsteers
I am guessing you intend on running the --init in the Evidence Docker image bootstrap.sh script.
It seems to me that with your setup, the bootstrap script receives init as argument instead of --init.
When the bootstrap script doesn't finding a matching argument (i.e --init) it will simply execute the argument you provided it as a command.  In your case, the script ends up executing the init process (/sbin/init .... this is a linux process unrelated to evidence  which if I run in isolation, will emit init: must be run as PID 1, see below).   I bet if you replace your init argument with ls in your setup, ls would get executed at the end.
My suggestion would be to replace init with --init in your setup.  If this doesn't work, if you can provide me with some setup instructions I could take a closer look.
#Output I got by bashing into an Evidence docker container and trying to run `init`
bash-5.1# which init
/sbin/init
bash-5.1# init
init: must be run as PID 1

Hi, @ud3sh. Thanks for the quick reply! Yes, as you suggest: I was passing init instead of --init. Changing to --init resolved my issue. 🙌


feat: expand trivial libraries

Part of the work for #12168
I am tired of sending individual PRs and you are tired of reviewing individual PRs, so batch a few together.

dataproc
logging
run

This change is

I would have preferred split PRs.

Well, after having dataproc and run get held up by logging, I officially regret my decision.


Switching Profiles Possibly Crashes the Plugin

Discord report:
Looking through the client logs it seems like I found it. I switch to my settingsMERCHANT profile, the plugin "Emote Clue Items" throw a few errors, then I see that I force close the client, open it again and it loads the same profile on startup without issue. I don't have the plugin "Emote Clue Items" activated on my settingsMERCHANT profile, but I do have it activated on my ironman's profile that I am trying to switch from. So it seems like the issue is that it crashes when trying to unload? Here is a short snippet from the log:
2023-05-26 20:59:11 CEST [pool-3-thread-1] INFO  n.r.client.config.ConfigManager - Switching profile to: settingsMERCHANT
2023-05-26 20:59:11 CEST [pool-3-thread-1] WARN  n.runelite.client.eventbus.EventBus - Uncaught exception in event subscriber
java.lang.NullPointerException: null
    at com.larsvansoest.runelite.clueitems.EmoteClueItemsPlugin.onConfigChanged(EmoteClueItemsPlugin.java:353)
    at net.runelite.client.eventbus.EventBus$Subscriber.invoke(EventBus.java:70)
    at net.runelite.client.eventbus.EventBus.post(EventBus.java:223)
    at net.runelite.client.config.ConfigManager.switchProfile(ConfigManager.java:234)
    at net.runelite.client.plugins.config.ProfilePanel.lambda$switchToProfile$7(ProfilePanel.java:666)
    at net.runelite.client.util.RunnableExceptionLogger.run(RunnableExceptionLogger.java:41)
    at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
    at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
    at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
    at java.base/java.lang.Thread.run(Unknown Source)
[16:08]
It throws multiple of the same error depending on how fast I force close Runelite. Starting up Runelite and it loading the settingMERCHANT profile after force closing it is never a issue (probably because then it doesn't have to unload the Emote Clue Items plugin?)

Thinking back on it I have noticed that very rarely it won't freeze, but that is probably because I sometimes login to another account that also don't have that plugin activated.
```

This issue should be resolved in the next patch. The patch is currently under review.
Please consider the following link to view its status:
https://github.com/runelite/plugin-hub/pull/4466


Class CollectionContact

This class has not yet any properties. Needs to be elaborated more.

Suggestion to remove this class, and replace by Class:Person
see https://github.com/tdwg/cd/issues/219

Removed in favour of generic Person class


UNC Path

We store the PDFs for our application on a different file server from the web server.  Is there a way to show PDFs from a UNC path on a different server?  The only way I've seen in the examples is to pass it with a URL.  We don't want to expose the PDFs to the web through IIS and everything I've tried has been unsuccessful.
For example I want to pass a path like \server2\folder\file.pdf to the viewer.html page.

Refer to https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#faq-xhr for more information on this topic.


Invalid IPv6 forwarded for header when ForwardedHeadersFilter uses unresolved address

If remote address is unresolved (for example it was modified by ForwardHeadersTransformer) and it contains IPv6 address that is not wrapped in [] (because it was retrieved from X-Forwarded-For header), such address is not wrapped in "[ ]" as expected
Problem is in this code in ForwardedHeadersFilter
			String forValue;
			if (remoteAddress.isUnresolved()) {
				forValue = remoteAddress.getHostName();
			}
			else {
				InetAddress address = remoteAddress.getAddress();
				forValue = remoteAddress.getAddress().getHostAddress();
				if (address instanceof Inet6Address) {
					forValue = "[" + forValue + "]";
				}
			}

If address is unresolved and it is IPv6 address not enclosed in [], it should be modified in the first branch of if statement

I was able to find some previous issues where this has been rejected, sorry for raising the issue. While it still causes problems for me as nginx does not surround IPv6 address in [] in X-Forwarded-For, it was previously pointed out that it is not Spring issue and I will solve it by overriding it with custom filter that will handle it properly


Update vs-azure-tools-storage-manage-with-storage-explorer.md

Following should be added for clarity because currently this information is a bit buried in the doc and requires digging to find it.
"and over the Internet or your network connection."

@craxal
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@azarboon Can you provide more context on your proposed change? I'm not understanding what information is being added here.

@azarboon Can you provide more context on your proposed change? I'm not understanding what information is being added here.

Currently, googling "can azure storage explorer be used over internet?" doesn't yield the result. To find out the answer, one has to dig through documentation pages and do some interpretation. I've added that addition so googling it can yield the result instantly.

@azarboon I'm still a bit confused. Why would someone need to ask this question? Storage Explorer is used to connect to and manage Azure storage resources. When connecting to any cloud service, an Internet connection is implicitly required.


fix: DEV-2309: don't show the delete all region button when annotation is readonly

/frontend build lsf master

/git merge develop


Sorting strings gives surprising behavior when some of them are convertible to numerical

What version of Hugo are you using (hugo version)?

$ hugo version
hugo v0.110.0-e32a493b7826d02763c3b79623952e625402b168+extended windows/amd64 BuildDate=2023-01-17T12:16:09Z VendorInfo=gohugoio

Does this issue reproduce with the latest release?
Yes
Description
This issue looks like #10389 but is slightly different.
When sorting a slice of strings of which some are convertible to numerical, the ones that can be converted are converted to floating point and then sorted at the end.
For example, this code
{{ slice "1A2" "1A12" "1F2" "aaa" "bbbb" "1" "1E2" "1E12" | sort }}

produces the output:
[1A12 1A2 1F2 aaa bbbb 1 1E2 1E12]

(since 1E2 is apparently converted to 100, and similarly for 1E12).
I guess that the values 1A12 1A2 1F2 aaa bbbb are sorted as strings and 1 1E2 1E12 are sorted as floating points.
Is this intended behavior or a bug?
I was quite surprised to discover this, as it was not documented in https://gohugo.io/functions/sort/ that strings are treated differently depending on whether they can be converted to floating points. I would be happy to contribute to a PR to the documentation if this is not a bug.
By the way, as a workaround, I obtained the usual sorting on strings [1 1A12 1A2 1E12 1E2 1F2 aaa bbbb] by appending a whitespace to each string before sorting them.

The workaround is clever! Basically, everything coming into the sort function has to be parsed and interpreted on a best-effort basis. Infinity and NaN were accommodated as edge cases in #10389, but I could imagine that some sites in the wild might depend on hugo to accept scientific notation here for sorting slices of numbers.

If we did want to fix this, we would add it as another case to parse as string like done here in #10389. But if not, something more involved might be required to unify the type of the slice being sorted before yielding the result.


Add support for key function

What is the key function supposed to do?

My use case is something like this: I have an array of objects, each containing a key timestamp_ms. Currently, if I want to use SortedArray, I'd have to map the array to get timestamp_ms, and I would only be able to insert new timestamp_mss as opposed to the actual objects that contain the timestamp_ms. A key function might look like function (val) { return val.timestamp_ms; }. That way I'd be able to use my array as-is, and insert items as they are without loss of information.


—help is broken when default is equal to None on a option.

I am on mobile so sorry for limited example
foo: Annotated[Optional[str], typer.Option(default=None)
register any command with an option like this and try to run —help for that function. it always errors out, due to click trying to parse param declarations and param declarations being none in this case. and default cannot be None when param declaration is not None due to overloads. help?

Hi @caner-cetin , thanks for the report.
Do this instead:
foo: Annotated[Optional[str], typer.Option()] = None

from typer 0.8 to 0.9 passing default to Option does not seem to work anymore.
Let me know if that solved your issue!

That also quite doesnt work.  Password is optional in this case
        password: Annotated[
            Optional[str],
            typer.Option(
                "--password", hide_input=True,prompt=True
            ),
        ] = None,
``` and I keep spamming enter with blank input:
<img width="445" alt="resim" src="https://github.com/bckohan/django-typer/assets/92731060/3664e56b-475e-49a3-91eb-c39cebf96459">
Yet I cant go further. Pressing ESC then enter yields `\x1b` character, of course. What can I do?

So just hitting enter will reprompt - that particular behavior is expected. But there is a bug here. If you enter the password twice it will work - the bug is that it prompts you twice #42
Thanks for bringing this to my attention!

And for now, what do you recommend for truly Optional options? Because clearly our examples doesnt work right now. I can only give " " or ESC's unicode representation right now to option for skipping. Blank input is out of the window until a fix.

They work if prompt is not True.

The double prompt bug is fixed in 1.0.5

thank you <3


OpaqueToken is not a constructor - Angular 5 - breaking change

Hello,
Hello, i have migrated my app from Angular 4 to 5. I am getting this error:
user-cfg.js:4 Uncaught TypeError: core_1.OpaqueToken is not a constructor
at eval (user-cfg.js:4)
at Object.../../../../angular2-promise-buttons/dist/user-cfg.js (vendor.bundle.js:703)
at webpack_require (inline.bundle.js:55)
at eval (promise-btn.directive.js:7)
at Object.../../../../angular2-promise-buttons/dist/promise-btn.directive.js (vendor.bundle.js:695)
at webpack_require (inline.bundle.js:55)
at eval (index.js:3)
at Object.../../../../angular2-promise-buttons/dist/index.js (vendor.bundle.js:687)
at webpack_require (inline.bundle.js:55)
at eval (app.module.ts:15)

You also need to update this module to the latest version. Then it should work.

@ninjashare are you using the latest version of angular-promise-buttons?

@stephane317  you must use InjectionToken for version 7, maybe it will be useful for version 7.


Git autocompletion

Ever since the last update, git autocompletion stopped working on tab.
It still works on other shells, but not on zsh. Since it's one of the features that I and I'm sure many others use constantly, it would be worth looking into, as it makes adding a large number of files painful.

Git autocompletion seems to be working okay for me, on OS X and Cygwin. What isn't working for you? Can you be more specific?
What OS and terminal are you using?

I'm also seeing the following error with a theme that uses current_branch:
git_prompt_ahead:1: command not found: current_branch

I also tried using some of the aliases defined in the plugin but they don't work. Those for another plugin I use (npm) do work.
I'm on OSX 10.10.

Hmm. That's not good. Which theme is it that's using current_branch? And what plugins do you have in your list to load?
The current_branch() function is defined in the git plugin, not the core lib/git.zsh, so any theme using it will depend on the git plugin. This seems symptomatic of the git plugin not being loaded for some reason. There were several commits to the git plugin recently; maybe one of them is borking it for you.
Are you seeing any other errors or messages during your zsh startup sequence?
I pulled up 10.10.3 just now, with the latest OMZ update. Both current_branch() and some basic git completion tests worked for me, if I include git in my $plugins list. May be some configuration differences.
Could each of you post the output of omz_diagnostic_dump from here as a gist, so we can get some detailed debugging info to find out what's causing this?

My plugins list is:
plugins=(git, osx, npm)

There's an issue to move current_branch() into core - #4085, which could be of interest. I'm not at the machine with the problem with now, but will send over the dump as soon as I can.

Yeah, check out who the author on that #4085 is. ;)
But you shouldn't need that: if $plugins contains git, then current_branch() should be available and you should be working.
Did you copy and paste your $plugins exactly?
plugins=(git, osx, npm)   # BUG

That will not work. In zsh array syntax, there are no commas between words: they will be interpreted as part of a word. So here, you'll have plugins named "git," and "osx," and "npm". When Oh-My-Zsh sees a plugin name it does not recognize, it silently ignores it. So it would look for "git," and find nothing and move on. If that is exactly your $plugins, then only npm will get loaded.
(IMHO that's probably a flaw in OMZ, and it should warn when it gets a request for a plugin that it doesn't recognize.)
The correct syntax for that plugins list is this.
plugins=(git osx npm)

That worked! But to my knowledge I haven't altered my plugins list since I installed months ago, and that error message only appeared after a recent upgrade. So I'm not sure what's going on there.
But thanks anyway - back up and running now.

Is it possible that that your $plugins was getting set in some custom OMZ files you have (under $ZSH_CUSTOM)? It used to be that custom files were loaded after plugins, but in #3617/#3809 (about a month ago), the load order was changed so that custom code is loaded before plugins are loaded. This allows them to alter the $plugins list, which was the intention. But it also means that if you used to have a good $plugins in your ~/.zshrc and a bogus one in your custom files, it would have worked before (because the bogus one got set after $plugins was used) and it would have broken a few weeks ago after an update (because now the plugin loading code saw the bogus one).
Upshot of this is that if you have custom code, you need to check how it interacts with your plugins. (See #4072 for how it affected some other users.)

Hi, I'm not sure if this is the same issue, but since a few weeks the autocompletion in my shell stopped working too. I'm on archlinux, unsing ohmyzsh up to date. If I use git checkout <TAB>, it correctly displays the branch, but not with gco <TAB>.
Any idea on how I could solve it ? Same as for @alastaircoote it stopped working without me doing anything specific except update ohmyzsh.
Thanks

Could be. gco <TAB> completion is working for me with the current OMZ setup, so I don't think it's broken in the main OMZ code.
Check your $plugins value to make sure it does not have commas. If that's not it,
please run omz_diagnostic_dump from this diagnostics.zsh file and post the results as a gist. That'll give us the debugging info needed to track it down in your configuration.

Hi,
I just checked and the $plugin value seems ok:
plugins=(git git-extras gitfast archlinux common-aliases chucknorris nyan systemd wd mvn sudo)
Here is the gist with diagnostics:
https://gist.github.com/nyddogghr/6b99d23355607b3fd33d
I also repulled oh-my-zsh from master to be sure. The only file not from the repo (as mentionned in the diagnostic file) is the diagnostic file.

Okay. I'm not sure what's causing this, but there are a couple issues there.
First, let's see if it's the alias itself or just the completion that's broken. What's your output for alias gco? It should be this.
$ which gco
gco: aliased to git checkout

Your ~/.zshrc file has sections which are redundant with Oh My Zsh. OMZ sets up completion with compinit, does terminal configuration, and so on. These sections, which run after OMZ, are redundant.

The compinstall-supplied completion initialization
The typeset -U path; path=(...)
The terminal smkx/rmkx application mode setup
All the "zkbd" key bindings around the smkx/rmkx setup, unless you want those to override the key bindings set up by OMZ.

I don't think the second compinit call would be messing up your completion, but I guess it's possible.
You have a literal /other/things/in/path in your $path setting, from two different places. That sounds like some example code that was copied and pasted, and was supposed to stand in for other things in your path. It could be removed, unless you really have something installed there.

For some reason I've only now been notified of all these comments. The problem seems to have been fixed as of two weeks ago, I'm not entirely sure what caused it, but after updating then, the tab autocompletion for git started working again. Initially, writing git add and pressing tab refused to suggest any files. Autocompletion worked fine in general, git was the only one having problems.
As for the plugins comma bug, I too had commas separating my plugins, but everything still worked before the time when I posted this. Furthermore, before opening this issue, I changed to both bash and tcsh to see if git tab autocompletion had the same problems, but it worked fine for both those shells.
To answer the initial question @apjanke, I'm using OS X Yosemite on the latest version and the default Terminal.
Here's the link to the gist dump, however, it might not be very useful:
https://gist.github.com/DragosDumitrache/d6e807e92cf3f5d62c14

Hmm. Might have been some of the work that was done on the git plugin and since changed, or might have been a broken zcompdump file, or something. Dunno.
If it's working now, want to just close this out, and reopen if it happens again? I don't see anything wrong completion-wise in the diagnostic dump, so I don't know that there's anything else we can do here.
Unrelated  to git completion
A couple unrelated things:
You're doing a full reset of $PATH here.
# Default PATH
export PATH="/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/texbin"

That's usually not ideal, because the system /etc/zshenv, which runs before your .zshrc, sets up the default $PATH, and picks up paths for installed programs. At the least, you should include :$PATH at the end of it, so additional paths supplied by the system are still included. Otherwise, programs which rely on /etc/paths.d to install correctly won't work. You also don't need to do the export each time; $PATH is already marked for export to the environment.
You might want to set $JAVA_HOME like this instead of with a hardcoded path, so you automatically pick up updates or changes to the main system JDK.
export JAVA_HOME=$(/usr/libexec/java_home)

I dig the starWars thing.

$ which gco
gco: aliased to git checkout

This is what the command gives me, and gco branch indeed changes branch, so the alias is correct.
Also, you were right, something in my zshrc was overriding ohmyzsh : setopt completealiases
I've removed it and it now works. However I just don't understand why it stopped working suddenly ^^"
Thank you for your help

Ah, that was it.
From the zsh reference manual:
COMPLETE_ALIASES
Prevents aliases on the command line from being internally substituted before completion is attempted. The effect is to make the alias a distinct command for completion purposes.

I didn't know about this one. Good thing to look for in the future.
I bet I know why it broke for you: PR #2790 removed a bunch of explicit compdef statements for some of the aliases, including gco. Those compdef statements made the completion work even when complete_aliases is on. OMZ used to turn on complete_aliases, but in 8883ace767997d1a629c165780af303f715ee78d turned it off, so the compdefs are no longer necessary for OMZ with the default configuration. See the discussion in #2790 for details. (I found this because I had a hunch there had been some change to gco completion in plugins/git, and just looked through its history log until I found a commit that had a relevant change.)

Please close tge issue if everybody's ok now.


feat: bump AKS Windows CSE script package to v0.0.36

What type of PR is this?
/kind feature

What this PR does / why we need it:
bump AKS Windows CSE script package to v0.0.36
Which issue(s) this PR fixes:

Fixes #
Requirements:

[x] uses conventional commit messages

[x] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.095%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2255

Relevant Lines:
2851

💛  - Coveralls


Support for appending varying snapshot state per @ParameterizedTest iteration?

At present, a @ParameterizedTest with arguments that in any way affect the appearance of a snapshot fail on the latter iteration(s), due to Selfie wanting the initial snapshot to match all iterations.
It would be neat if this could be detected, and for the runner to then append the additional unique state, instead — either labelled numerically within the snapshot, or maybe numbered + the same argument naming convention as JUnit, i.e. respecting Arguments.of(Named.of(...)), or else falling back to toString().
Disclaimer: I do not know whether JUnit 5 even provides the hooks necessary to see which iteration/argument set is currently executing, but I would hope this is possible.
I'm also totally open to the possibility that you might view this as a test design smell, but I for one get a lot of mileage out of @ParameterizedTests where the snapshot-candidate is not static between iterations.

I think @ParameterizedTest is great, and I think JUnit 5 gives us the hooks we need to do what you want, but I don't think we need a new selfie feature.
Whenever you do .toMatchDisk() you can optionally supply a parameter, .toMatchDisk(String sub). So the workaround you can do right now is:
@ParameterizedTest @ValueSource(ints = {1, 2, 5})
void testDataStructureOfLength(int size) {
  var underTest = initialize()
  ... complicated stuff ...
  expectSelfie(underTest).toMatchDisk("size = " + size)
}

The reason I like this is that it gives you control over how your snapshots show up in your file. It can be any of:
╔═ testDataStructureOfLength/1 ═╗
╔═ testDataStructureOfLength/size=1 ═╗
╔═ testDataStructureOfLength/size = 1 ═╗
╔═ testDataStructureOfLength/size = 01 ═╗

One of the things we're trying to do with selfie is make everything explicit. Like spotless, you just give selfie strings, no magic implicit transformations.
Another justification for this is inline snapshots. There's no way selfie can automatically fork the source code for a parameterized test, but you can fork it yourself!
@ParameterizedTest @ValueSource(ints = {1, 2, 5})
void testDataStructureOfLength(int size) {
  var underTest = initialize()
  ... complicated stuff ...
  if (size == 1) {
    expectSelfie(underTest).toBe("[1]")
  } else if size == 5) {
    expectSelfie(underTest).toBe("[1, 1, 2, 3, 5]")
  }
  expectSelfie(underTest).toMatchDisk("size = " + size)
}

We could make the error message a lot better though.
https://github.com/diffplug/selfie/blob/b151801d29b54559949d11797931a9e241e6b1e3/selfie-lib/src/commonMain/kotlin/com/diffplug/selfie/guts/WriteTracker.kt#L62
What do you think of these messages?
Snapshot was set to multiple values!\n
  first time: ${existing.callStack.location.ideLink(layout)}\n
   this time: ${call.location.ideLink(layout)}
(for disk) You can fix this with `.toMatchDisk(String sub)` and passing a unique value for sub.
(for inline) You can fix this by doing an `if` before the assertion to separate the cases.
  if (blah) {
    expectSelfie(underTest).toBe("shoopy doopy")
  } else {
    expectSelfie(underTest).toBe("gloopy gloppy")
  }

Aha, excellent! I think the facility you describe sounds just fine, and adding the relevant hint to the error messages would do nicely.

Better error message shipped in 1.1.2.


LevelDB error

I am following all the steps for installing neo-cli locally.

Cloned the repo, with master branch.
Built using visual studio and published.
Switched names of protocol and config files.
Copied two plugins in publish folder, RpcServer and LevelDbStore.

Then, when I run neo-cli, I get the following error:

I am following all the steps for installing neo-cli locally.

Cloned the repo, with master branch.
Built using visual studio and published.
Switched names of protocol and config files.
Copied two plugins in publish folder, RpcServer and LevelDbStore.

Then, when I run neo-cli, I get the following error:

wait for https://github.com/neo-project/neo-modules/pull/442 and https://github.com/neo-project/neo/pull/2179

Now it works well. Use master branch and try again? @asifshiraz

Now it works well. Use master branch and try again? @asifshiraz

Old, if remains, please re-open


Translate tasks/run-application/run-stateless-application-deployment in Korean

This is a Feature Request
What would you like to be added
/docs/tasks/run-application/run-stateless-application-deployment.md Korean Translation
Why is this needed
No Translate tasks/run-application/run-stateless-application-deployment in Korean
Comments
Copy from en content and Update content.
https://kubernetes.io/docs/tasks/run-application/run-stateless-application-deployment/
/language ko

/assign @lapee79

/kind feature
/priority backlog


Incorrect parsing of nested casts and unary operators in the CXX language frontend

Unexpected behavior
A BinaryOperation & with lhs CastExpression(int64_t) and rhs x is generated instead of a CastExpression of the UnaryOperator & with input x
Code of interest
(int64_t)&x

A similar error occurs with this code:
*(int64_t *)outptr = *(int64_t *)&key;
Were are missing the connection between the cast and &

I think I know the culprit. It is in the way we replace calls with casts; which is currently broken because of the way we iterate the AST when doing so. I have a similar problem in the Go frontend. I will have a look at this.

Unfortunately, I cannot reproduce either issue. If I parse these code snippets here:
typedef long int64_t;
int x = 1;
int y = (int64_t) &x;

int main() {
  long key;
  long outptr;
  *(int64_t *)outptr = *(int64_t *)&key;
}

They correctly parse as a cast to a unary expression to x. And I have a dataflow from key to the * unary expression.
Are you defining int64_t at some point? A potential issue is that while the CPG "knows" that this one of the standard-ish types, the underlying C/C++ parser CDT will only parse this correctly as a type if you either include the contents of stdint.h or typedef it our self. This is actually the "correct" way to do that per C standard, since it is not a built-in type, but a type of the standard library.

I can finally reproduce this, when I turn on guessCastExpressions. Fix is incoming.


Invoking make -j16 failed

I know that this was covered here but I ran into this same issue and the suggestions for debugging did not work for me. I'm using Ubuntu 14.04 with ROS Indigo. I was never able to selectively build the orb_localizer package with catkin_make --pkg orb_localizer even after adding the lines to the CMakeLists.txt suggested in the link above.
This is the output I get after trying to build with ./catkin_make_release --make-args -j16
Scanning dependencies of target pos_db
[  0%] Linking CXX shared library /home/driver/ccui/planner/Autoware/ros/devel/lib/libobj_db.so
[  0%] Building CXX object data/packages/pos_db/CMakeFiles/pos_db.dir/lib/pos_db/SendData.cpp.o
[  0%] Built target obj_db
[  0%] Building CXX object data/packages/pos_db/CMakeFiles/pos_db.dir/lib/pos_db/util.cpp.o
make[1]: *** [sensing/drivers/camera/packages/vectacam/CMakeFiles/vectacam_node.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[  0%] Built target kvaser_generate_messages_eus
[  1%] Linking CXX executable /home/driver/ccui/planner/Autoware/ros/devel/lib/map_tools/pcd_binarizer
[  1%] Linking CXX shared library /home/driver/ccui/planner/Autoware/ros/devel/lib/libpos_db.so
[  1%] Built target pos_db
[  1%] Built target pcd_binarizer
[  1%] Building CXX object sensing/drivers/lidar/packages/hokuyo/CMakeFiles/hokuyo_3d.dir/nodes/hokuyo_3d/hokuyo_3d.cpp.o
make[1]: *** [util/packages/fake_drivers/CMakeFiles/fake_camera.dir/all] Error 2
[  1%] Linking CXX executable /home/driver/ccui/planner/Autoware/ros/devel/lib/map_tools/pcd_filter
[  1%] Linking CXX shared library /home/driver/ccui/planner/Autoware/ros/devel/lib/libfastvirtualscan.so
[  1%] Built target fastvirtualscan
[  1%] Built target pcd_filter
[  1%] Linking CXX executable /home/driver/ccui/planner/Autoware/ros/devel/lib/laser_scan_converter/laser_scan_converter_node
[  1%] Built target laser_scan_converter_node
[  2%] Linking CXX shared library /home/driver/ccui/planner/Autoware/ros/devel/lib/libfast_pcl_registration.so
[  2%] Built target fast_pcl_registration
[  2%] Linking CXX executable /home/driver/ccui/planner/Autoware/ros/devel/lib/hokuyo/hokuyo_3d
[  2%] Built target hokuyo_3d
[  2%] Linking CXX executable /home/driver/ccui/planner/Autoware/ros/devel/lib/point_cloud_converter/point_cloud_converter_node
[  2%] Built target point_cloud_converter_node
[  2%] Linking CXX shared library /home/driver/ccui/planner/Autoware/ros/devel/lib/libfast_pcl_filters.so
[  2%] Built target fast_pcl_filters
make: *** [all] Error 2
Invoking "make -j16" failed

This is the output I get without any flags, with just ./catkin_make_release . It appears that I can actually get further without specifying the number of cores also.
[ 11%] Built target pcd_arealist
In file included from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/Thirdparty/g2o/g2o/types/types_seven_dof_expmap.h:34:0,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/include/LoopClosing.h:34,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/include/LocalMapping.h:26,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/include/Tracking.h:33,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/include/FrameDrawer.h:24,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/include/Viewer.h:25,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/src/Viewer.cc:21:
/home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/Thirdparty/g2o/g2o/core/base_binary_edge.h:59:82: warning: ‘Eigen::AlignedBit’ is deprecated (declared at /usr/local/include/eigen3/Eigen/src/Core/util/Constants.h:162) [-Wdeprecated-declarations]
       typedef Eigen::Map<Matrix<double, Di, Dj>, Matrix<double, Di, Dj>::Flags & AlignedBit ? Aligned : Unaligned > HessianBlockType;
                                                                                ^
In file included from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/Thirdparty/g2o/g2o/types/types_seven_dof_expmap.h:34:0,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/include/LoopClosing.h:34,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/include/LocalMapping.h:26,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/include/Tracking.h:33,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/include/FrameDrawer.h:24,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/include/Viewer.h:25,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/src/Viewer.cc:21:
/home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/Thirdparty/g2o/g2o/core/base_binary_edge.h:60:82: warning: ‘Eigen::AlignedBit’ is deprecated (declared at /usr/local/include/eigen3/Eigen/src/Core/util/Constants.h:162) [-Wdeprecated-declarations]
       typedef Eigen::Map<Matrix<double, Dj, Di>, Matrix<double, Dj, Di>::Flags & AlignedBit ? Aligned : Unaligned > HessianBlockTransposedType;
                                                                                ^
In file included from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/Thirdparty/g2o/g2o/types/types_seven_dof_expmap.h:35:0,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/include/LoopClosing.h:34,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/include/LocalMapping.h:26,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/include/Tracking.h:33,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/include/FrameDrawer.h:24,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/include/Viewer.h:25,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/src/Viewer.cc:21:
/home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/Thirdparty/g2o/g2o/core/base_vertex.h:62:74: warning: ‘Eigen::AlignedBit’ is deprecated (declared at /usr/local/include/eigen3/Eigen/src/Core/util/Constants.h:162) [-Wdeprecated-declarations]
     typedef Eigen::Map<Matrix<double, D, D>, Matrix<double,D,D>::Flags & AlignedBit ? Aligned : Unaligned >  HessianBlockType;
                                                                          ^
In file included from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/Thirdparty/g2o/g2o/types/types_seven_dof_expmap.h:34:0,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/include/LoopClosing.h:34,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/include/Optimizer.h:27,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/src/Optimizer.cc:22:
/home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/Thirdparty/g2o/g2o/core/base_binary_edge.h:59:82: warning: ‘Eigen::AlignedBit’ is deprecated (declared at /usr/local/include/eigen3/Eigen/src/Core/util/Constants.h:162) [-Wdeprecated-declarations]
       typedef Eigen::Map<Matrix<double, Di, Dj>, Matrix<double, Di, Dj>::Flags & AlignedBit ? Aligned : Unaligned > HessianBlockType;
                                                                                ^
In file included from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/Thirdparty/g2o/g2o/types/types_seven_dof_expmap.h:34:0,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/include/LoopClosing.h:34,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/include/Optimizer.h:27,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/src/Optimizer.cc:22:
/home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/Thirdparty/g2o/g2o/core/base_binary_edge.h:60:82: warning: ‘Eigen::AlignedBit’ is deprecated (declared at /usr/local/include/eigen3/Eigen/src/Core/util/Constants.h:162) [-Wdeprecated-declarations]
       typedef Eigen::Map<Matrix<double, Dj, Di>, Matrix<double, Dj, Di>::Flags & AlignedBit ? Aligned : Unaligned > HessianBlockTransposedType;
                                                                                ^
In file included from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/Thirdparty/g2o/g2o/types/types_seven_dof_expmap.h:35:0,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/include/LoopClosing.h:34,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/include/Optimizer.h:27,
                 from /home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/src/Optimizer.cc:22:
/home/driver/ccui/planner/Autoware/ros/src/computing/perception/localization/packages/orb_localizer/Thirdparty/g2o/g2o/core/base_vertex.h:62:74: warning: ‘Eigen::AlignedBit’ is deprecated (declared at /usr/local/include/eigen3/Eigen/src/Core/util/Constants.h:162) [-Wdeprecated-declarations]
     typedef Eigen::Map<Matrix<double, D, D>, Matrix<double,D,D>::Flags & AlignedBit ? Aligned : Unaligned >  HessianBlockType;
                                                                          ^
[ 12%] Linking CXX static library /home/driver/ccui/planner/Autoware/ros/devel/lib/libg2o.a
[ 12%] Built target g2o
[ 12%] Linking CXX static library /home/driver/ccui/planner/Autoware/ros/devel/lib/liborb_slam2.a
[ 12%] Built target orb_slam2
make: *** [all] Error 2
Invoking "make -j48 -l48" failed

is this master or develop branch?

I cloned from master

I was on master

Output says -j48 right before it fails not sure what behavior to expect but
I'm doubting you have 48 cores (although it's not impossible) also -l48
seems suspect perhaps some typo in build script?
On Jul 21, 2017 6:34 PM, "claretway"<EMAIL_ADDRESS>wrote:
I was on master
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/CPFL/Autoware/issues/737#issuecomment-317128067, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGXckF3IiaUzIFeN4XLKvEZ1h-iabXjFks5sQSeOgaJpZM4Of7tn
.

I have built successfully on 16.04 and kinetic with the same command
./catkin_make_release --make-args -j16

@amc-nu who is most familiar with build issues in Autoware? Do you guys have any nightly or PR builds for different:

processor architectures
different ubuntu versions
different ROs version
?

I think there are 24 cores and 24 virtual cores

@claretway
We don't find any problems while building with the script maybe it's something related to your environment.
Please try compiling manually
While in the ros directory:

catkin_make clean
source devel/setup.bash
catkin_make -j8

@dejanpan
afaik, it supports ARM architecture, but that's already included in the scripts.
It also supports ROS hydro or Ubuntu 13.04, 13.10, but that's a very old version of Autoware.

thx. What I meant is do you build on clean versions of all this variations before new pull request gets merged into master?

@dejanpan
We check it builds and works on 14.04 and 16.04.
ARM is also verified.

Do you have any documentation on how building and working is tested? Is it manual?
I am asking because my plan was to release Autoware through ROS build farm: http://wiki.ros.org/bloom/Tutorials/FirstTimeRelease which would check these things where at least building would happen automatically.

@dejanpan
We do it manually on each of our different machines.
We add the new dependencies, clean the environment using the catkin_make_release script and test on each of our different environments before merging to master (since all of us work on the develop branch)

Would definitely try -j4 or -j8. On my 32gb ram workstation I have ran into
memory issues when building with a lot of cores, but sounds like there
might be something else going on as well.
On Jul 21, 2017 8:48 PM, "Abraham Monrroy"<EMAIL_ADDRESS>wrote:

@dejanpan https://github.com/dejanpan
We do it manually on each of our different machines.
We add the new dependencies, clean the environment using the
catkin_make_release script and test on each of our different environments
before merging to master (since all of us work on the develop branch)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/CPFL/Autoware/issues/737#issuecomment-317142148, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGXckMOb9VkwaJlhKlgE1avl5peQfRZAks5sQUbvgaJpZM4Of7tn
.

Okay, now I'm thinking it's an issue with opencv, of which I have version 3.3.0 installed. I got this error, I guess after I ran catkin_make clean and built with reduced cores:
make[2]: *** No rule to make target `/usr/lib/x86_64-linux-gnu/libopencv_videostab.so.2.4.8', needed by `/home/driver/ccui/planner/Autoware/ros/devel/lib/vectacam/vectacam_node'.  Stop.

Is Autoware not working with OpenCV3 still @syohex? I guess I missed this. I was under the impression that "OpenCV 2.4.10 or higher" under the README requirements meant that OpenCV3 was supported as well.

Still running into issues, but earlier issue was due to wrong OpenCV version.


HHH-14152 fix the non deterministic grammar warning caused by changes to sql-script.g

https://hibernate.atlassian.net/browse/HHH-14152
the warning seems caused by changes introduced by https://github.com/hibernate/hibernate-orm/pull/3502

improved by @sebersole and merged on master.

backported. Thanks all!


On 2.21.1 The Stacks search no longer remembers filtered search results

Before you start please confirm the following.

[X] Yes, I've searched similar issues on GitHub.
[X] Yes, I've checked whether this issue is covered in the Portainer documentation or knowledge base.

Problem Description
On 2.21.1 if I use the search bar for containers it filters for those containers.
If I open a container and then go back to the previous page the search results are still filtered.
If I repeat the same steps for a stack the search results are not filtered.
Expected Behavior
The search results would be filtered when returning to the page the same way they are for containers and were in previous versions.
Actual Behavior
Containers search works as expected and stacks doesn't anymore.
Steps to Reproduce

Go to containers
Search for a container
Open a container
Press the back button
Notice search results remained filtered
Repeat steps but this time with stacks and notice that the search results are no longer filtered

Portainer logs or screenshots
No response
Portainer version
2.21.0
Portainer Edition
Business Edition (BE/EE) with Home & Student license
Platform and Version
Docker 26.1.4
OS and Architecture
Ubuntu 22.04
Browser
Chrome
What command did you use to deploy Portainer?
No response
Additional Information
No response

Hi @Daniel-dev22 Thanks for raising this, I have confirmed this and raised it with the team

Hi, just want to add, it's not just remembering, it "breaks" displaying containers on Service level view. unfiltered vs filtered results

The information about containers is there, also on service details, so I guess it is related to this issue.

Hi, I just want to add that this problem is also present at the stack level in a Docker Swarm environment.
The stack list does not mantain the search filter, still present in 2.21.3 (we are on EE).
Easy to reproduce: add a filder on the stack page (/docker/stacks), then enter in another page (for example clicking on one of the filtered stacks) and then go back to the stacks page: the list is now again complete - not filtered, but the search box still has the string that was used before to do the search.
Do you guys have an ETA on the fix or which version will have it? When you have a lot of stacks it's a bit annoying.

Please update to 2.22 if you can and let me know if the issue persists

@Nick-Portainer tried 2.22 , it seems to be working. I'll let developers ~break~ test it for a while.
Though, it took me some time trying to debug this

until I realised that there is now a display limit in the container list which the running ones not fit (coming from 2.19.4) You might want to consider showing the running ones on top by default.

Please update to 2.22 if you can and let me know if the issue persists

Hi Nick, I've updated to 2.23.0 and the issue persists.

This has been resolved in the latest 2.25.0 STS release


tf.data parallel filter dataset for each class and interleave not giving expected speedup

Issue type
Performance
Have you reproduced the bug with TensorFlow Nightly?
No
Source
binary
TensorFlow version
2.12
Custom code
Yes
OS platform and distribution
ubuntu 22.04
Mobile device
No response
Python version
3.10
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
11.8/8.6
GPU model and memory
No response
Current behavior?
I've tried to get some help on Tensorflow Forum but I've got no response so I decided to post an issue here. Post on TFRecords Forum holds extensive description of my problem (tf.data dataloader for GE2E loss), but I'll try to trim it down only to technical matter.
I'm working on implementation of dataloader, where I want to get (n_speakers x n_utters) samples in every batch. I've already prepared dataset as 10 sharded TFRecord (as suggested in docs) and I wanted to build pairing mechanism using tf.data API. I've menaged to do so with tf.data.Dataset.choose_from_datasets, but this requires me to have a list of datasets, where each dataset contains only samples from one speaker. To prepare such dataset I've filtered my one big TFRecords Dataset with each speaker_id. My implementation feels criminal, because it iterates through whole dataset as many times as there are speakers. I've tried to help it with parallel calls (mapping the filter function with list of speakers), but there was no speedup. I've also tried using interleave (setting only num_parallel_calls to AUTOTUNE) on my dataset parsing, but all I got was slower execution time.
Is if there is any easy and reasonable solution to this filtering issue (to filter whole dataset by each class in one pass)? My only idea to skip filtering at all is to separate each speaker in different TFRecord at the moment of dataset creation. Also how should I use interleave with my code?
Currently it takes a long time to make a first pass over dataset (~10min for 10GB of TFRecords, next iters when filtered datasets get cached its 2s) - it can be an issue with training with bigger dataset I suppose.
I'm attaching the relevant code but it's not standalone unfortunately, as I can not attach used data. Also some parsing code is missing, but I think it's not that relevant - my examples are stored as melspectrograms with speaker_id label. I could mock some data if someone was interested in helping me.
Standalone code to reproduce the issue
dataset = tf.data.Dataset.from_tensor_slices(files)
tfrecords_reader = functools.partial(
    self._tfrecords_reader,
    speaker_id=self._speaker_id,
    speaker_gender=self._speaker_gender,
    speaker_id_key=self._speaker_id_key,
    speaker_gender_key=self._speaker_gender_key,
)

dataset = tf.data.TFRecordDataset(dataset)
dataset = dataset.map(tfrecords_reader, num_parallel_calls=AUTOTUNE)

# NOT PARALLEL WAY - surprisingly it takes as long as parallel method...
# datasets = []
# for speaker_id in self._speaker_list:
#     datasets.append(
#         dataset.filter(lambda x, y: y["speaker_id"] == speaker_id)
#         .cache()
#         .shuffle(BUFFER_SIZE, reshuffle_each_iteration=True)
#         .repeat()
#     )

# Filtering for speakers
speakers = tf.data.Dataset.from_tensor_slices(self._speaker_list)
dataset = speakers.map(
    lambda speaker_id: dataset.filter(lambda x, y: y["speaker_id"] == speaker_id)
    .cache()
    .shuffle(BUFFER_SIZE, reshuffle_each_iteration=True)
    .repeat(),
    num_parallel_calls=AUTOTUNE,
)

datasets_idx = tf.data.Dataset.range(len(self._speaker_list))
# Define those values statically for uniform_candidate_sampler which requires static int, even tho it looks silly
len_speakers = len(speakers)
len_pairs = len_speakers - 1

def pair_speakers(x):
    """Pair all speakers in dataset.

    Pairing is done in a way where each speaker is taken at least once.
    Also we can guarantee that those pairs are being re-generated each time.
    """
    to_pair = tf.reshape(tf.where(tf.range(len(speakers)) != x), [1, -1])  # Exclude speaker x from being drawed
    pairs = tf.random.uniform_candidate_sampler(to_pair, len_pairs, self._num_speakers - 1, True, len_speakers)[
        0
    ]  # sample n_speakers-1 pairings without replacement from len(speakers)-1 speakers
    paired = tf.concat([[x], pairs], 0)  # concat speaker x with its pairs
    return tf.repeat(
        paired, tf.repeat(self._num_utters, self._num_speakers)
    )  # repeat each speaker count by selected number of utterances

choice_dataset = datasets_idx.map(
pair_speakers, num_parallel_calls=AUTOTUNE
)  # [mapping of len(speakers) datasets, each num_speakers*num_utters]
choice_dataset = choice_dataset.flat_map(
    tf.data.Dataset.from_tensor_slices
)  # [single dataset of len(speakers)*num_speakers*num_utters,]

# Deterministicly takes samples from filtered datasets with order specified in choice dataset
dataset = tf.data.Dataset.choose_from_datasets(dataset, choice_dataset).batch(
    self._num_speakers * self._num_utters
)

# Apply transforms to batched dataset spectrograms. Faster transforms than on single examples
dataset.map(
    lambda x, y: (self._transform(x), y),
    num_parallel_calls=tf.data.experimental.AUTOTUNE,
)

dataset = dataset.prefetch(AUTOTUNE)
total_steps = len(self._speaker_list)

return dataset, total_steps

Relevant log output
No response

@niemiaszek
In order to expedite the trouble-shooting process, please provide a complete code snippet to reproduce the issue reported here. I have tried to replicate this issue and faced different errors. Thank you!

Sorry for no response so far. I will prepare standalone code with some sample TFRecords prepared on public dataset. Then it should be easier to fiddle with this issue. For now I'm quite busy with other stuff and I was hoping for some expertise just based on code snippet, as my main question (how to efficiently filter tf.data.Dataset by classes) seem to be rather general than case-dependent.

@niemiaszek Thank you for your response!
Though, in order to analyze the issue we need the complete code, you may perform filters on batches. Either unbatch and use tf.data.Dataset.filter or just use tf.data.Dataset.map which is more preferable.  As an example you may refer to this following;
ds = tfds.load('cats_vs_dogs', split='train', as_supervised=True)
ds = ds.filter(lambda img, label: label == 1)

When using the Dataset.map, and Dataset.filter transformations, which apply a function to each element, the element structure determines the arguments of the function. Please refer to this document.
Thank you!


Support for Save Data Collection via Symbolic Links

What's your idea?
Instead of copying save game data, ludusavi could have an alternative mode that replaces a game's save data directory with a symbolic link, moving the actual data to a central "collected saves" directory.
This approach offers several benefits:

Enables real-time syncing of game saves using tools like SyncThing (including on Steam Deck).
Avoids duplication of save data on the file system.
Has no overhead.
Avoids the need for regular execution of ludusavi.

I've been using a custom script to achieve this on Linux and Windows for years, and it has worked reliably. Integrating such a feature into Ludusavi would be incredibly useful due to its huge database already having everything that's needed for this.

Hi! I had considered something like this before, but ended up deciding against it: https://github.com/mtkennerly/ludusavi/issues/11#issuecomment-1452618152
That said, you could use Ludusavi's CLI (ludusavi backup --preview --api) to get the save locations and optionally filter by size/etc to decide what to symlink.

I understand your reasons.
Thanks a lot for mentioning the CLI, that looks quite useful for my use case.


Standardize step and test case names

This PR includes

Changing step names from initial_state to init
Removing _test from test case names

Checklist

[X] User's Guide has been updated
[X] Developer's Guide has been updated
[X] API documentation in the Developer's Guide (api.md) has any new or modified class, method and/or functions listed
[X] Documentation has been built locally and changes look as expected
[X] Testing comment in the PR documents testing used to verify the changes

Testing
The PR suite passes on chrys with intel-mpi

@xylar Thanks for reviewing!


Breaks scoreboard

[ERROR] addons/ttt-scoreboard-ranks-for-ulx-master/lua/ulx/modules/sh/ttt_sb_ranks.lua:218: ')' expected near '='

unknown - addons/ttt-scoreboard-ranks-for-ulx-master/lua/ulx/modules/sh/ttt_sb_ranks.lua:0

It doesn't seem like you're using Version 1.1. Please install this and see if the problem persists.

I downloaded it from here.
"AddonInfo"
{
"name"                "TTT Scoreboard Ranks for ULX"
"version"            "1.1"
"up_date"            "2015-09-08"
"author_name"            "Alex (Decicus) Thomassen"
"author_email"<EMAIL_ADDRESS>"author_url"            "https://www.thomassen.xyz/"
"info"                "Gamemode commands"
"override"          "0"
}

That's the latest addon.txt, but due to the folder name of the addon you installed, it seems you got it directly from the repository instead of installing via the "Releases" tab.