Interop with PQUIC decryption issue

I seem to have stumbled on a small decryption issue that seems to exist on the regular implementations of aioquic and pquic, and therefore also exists on other implementations based on aioquic and pquic. I will explain my observations across multiple tests here.
I have also created an issue on the pquic page

I have the following cases:
Case 1: A local aioquic client that tries to download 999999 bytes from a local PQUIC server
(Default aioquic implementation, the PQUIC server has enabled the QLOG plugin)
Case 2: An online interop result from interop.seemann.io between an aioquic client and a PQUIC server
(Test: transfer, flag: DC)
Case 3: My modified local aioquic client that tries to download 999999 bytes from a local pquic server
(Modified aioquic implementation that enables multipath, the PQUIC server has enabled the QLOG plugin, as well as the multipath_rr_cond and multipath_qlog plugins)
In all three cases both endpoints seem to have some issues with decrypting certain packets that are being transmitted while the handshake is being performed.
In Case 1 I generated a QLOG-file on both endpoints (Ac_large.qlog and Ps_large.qlog), and I also stored the console output of the PQUIC server (Ps_large.txt) All files are stored in logs.zip. By loading both QLOG files in qvis.edm.uhasselt.be and selecting the actual traces for both the client and the server (not the GENERATED ones, see the first screenshot), we get a visualisation of the issue, as seen in the second screenshot.

After receiving an initial handshake packet from the PQUIC server, the aioquic client replies with an initial packet (pn: 1) and a handshake packet (pn: 2). The PQUIC server receives the first packet, fails to decrypt it, giving a "header or decryption error: 408." message and finally dropping the packet. The second handshake packet isn't mentioned in the console output. In response the PQUIC server replies with another handshake packet (pn: 1), and two 1RTT packets (pn: 0 and 1). The aioquic client receives these packets and can decrypt the handshake packet and the first 1RTT packet, but not the second 1RTT packet, logging a "packet_decrypt_error". The aioquic client thus acknowledges the handshake packet and the first 1RTT packet, but not the second 1RTT packet.
Later on, the PQUIC server identifies this second 1RTT packet as lost, as seen in the third screenshot. However, in this case the connection is able to continue, and the 999999 bytes are transferred, resulting in a clean connection termination.

By inspecting the client's QLOG and the server's LOG from Case 2 I assume that the same problem occurs, because the client QLOG contains a "packet_decrypt_error", and the server log contains a "header or decryption error: 408.". The connection is also able to continue and terminate as in Case 1.
Case 3 is more specific towards the multipath implementation in PQUIC and my implementation in aioquic. Nevertheless this decryption problem also occurs, leading to an additional ping-ack-loop issue that has been identified and is currently being patched.
My questions:
-What is causing the decryption problem?
(Small edit note: when generating your own traces, PQUIC saves its packets in the QLOG file with {"packet_type": "onertt"}, whereas aioquic saves the packets with {"packet_type": "1rtt"}, search and replace the PQUIC entries to "1rtt" so that both QLOG files have the same notation, otherwise the visualisation will show almost all packets as "lost".)

Additional observation: It seems that the undecryptable 1rtt packet that is being sent from the PQUIC server actually has a length that is greater than 1500 bytes (1523 bytes to be exact, excluding the header), thus the packet is rejected by the decryptor on the aioquic client.

Are you able to transmit packets over 1500 bytes without encountering fragmentation?
Could you try raising the limit defined here:
https://github.com/aiortc/aioquic/blob/04b28d8c632cc62fa4d63cdcce427f0257d00c8a/src/aioquic/_crypto.c#L13
What would be a better maximum length?

Sorry for the late response, I am no longer actively working on my own implementation that is based on aioquic.
As for the identified issue, I am not sure that you can transmit packets over 1500 bytes without potentially having fragmentation occur. I did, however, circumvent this issue by including a "max_udp_payload_size"-transport parameter whose value was lower than 1500 bytes. I did not perform any additional tests related to raising the limit defined in _crypto.c, so I am unsure about its effects on the data that is to be transported.


Fixes related to metabase chart

Proposed changes
For the metabase chart

Fix ingress tls section
Update ingress resource to stable version
Fix Postgres dependency to account for new format for auth credentials
Upgrade Postgres dependency to latest version

Since the postgres update necessitates a values.yaml change, I bumped the minor version.
Checklist

[ ] Lint and unit tests pass locally with my changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] I have added documentation to describe my feature.
[x] I have squashed my commits into logic units.
[x] I have described the changes in the commit messages.

Other information
I'll let the pipeline decide if the tests run, I honestly don't know how to do so locally.
It does not seem possible to test the ingress change without knowing a proper domain name on the the testing system, I think(?), but it wouldn't have worked before and should work now.
I am also unsure as to why the postgres dependency would have worked in tests beforehand, since as far as I can tell the format of the auth credentials had already been different with that old version. But I might be wrong about that.
The chart works like this for me.

@Tobi042 I really like this PR, Sorry for the delay in reviewing. I had issues with my GitHub notifications. Could you kindly fix the conflicts and we merge this


Mobile - Set default pool for Vara network, Avail Turing

Describe the task

[x] Set "SubWallet Official 3" as the default pool for Vara
[x] Set "Avail Space" as the default pool for Avail Turing

Version test: v1.1.53(369)
Device test: IP 11
Validation passed.


feat: add "processSsrRequest" method

Description
This PR adds experimental support for the run functionality discussed in #16089.
The current idea is to expose a processSsrRequest method that accepts http request and response. What happens inside is controlled by the environment. Cloudflare environment can for example initialize a miniflare instance and dispatch a fetch event there.

Additional context

What is the purpose of this pull request?

[ ] Bug fix
[x] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[ ] Read the Contributing Guidelines, especially the Pull Request Guidelines.
[ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Update the corresponding documentation if needed.
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

This is a rough idea. Any feedback is welcome, @patak-dev
We don't have a transport to communicate between runtimes yet.

We decided to limit the scope of environment API for the time being. There will be no function to call Vite SSR in an agnostic way for now. We will be monitoring feedback and trying to implement the solution based on the usage in the future.
I am keeping this PR open for now to implement other features not related to the SSR, but related to the runner<->environment communication.


OAK-9026 Performance Improvement: Unnecessary boxing and unboxing

I'm closing this in favor of:
#206
#207
#213
#214
#215
#216
#217
#218
#219
#220
#221
#222
#223
#224
#225
#226
#227
#228
#229


problem: stopped to support ETC chain in mainnet dir

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


text area navigation not supported?

I've been playing around with blessed for a personal project, and I can't seem to get navigation in a text area working. (both when focused and in insert mode, when vi and keys are enabled) I also searched the projects issues and didn't find anyone asking about this. I feel like I may be missing something...
When I run the below example program I can not navigate in the textarea with arrow keys (while in insert mode). Also there is no cursor or indication of movement when focused, outside of insert mode. When entering insert mode, the cursor is always at the end of file/input, regardless of using vi key bindings to insert at the beginning/end of the line. (shift + i, shift + a)
I've extracted some of the code into a small example:
var blessed = require('blessed');

var screen = blessed.screen({
  autoPadding: true,
  smartCSR: true
});

// create text area with vi keys enabled
var editor = blessed.textarea({
  parent: screen,
  border: 'line',
  style: {
    bg: 'black',
    fg: 'white'
  },
  keys: true,
  vi: true,
  top: 0,
  height: '100%',
  width: '100%',
});
editor.focus();

// key setup
screen.key(['escape', 'q'], function(ch, key) {
  return process.exit(0);
});

screen.render();

Any ideas?
EDIT:
I forgot to add what I'm trying to accomplish. I'm trying to create a CLI note program where a user has a file explorer on the left side and a vi(m)-like editor on the right. For myself to be able to sanely edit notes, I have to be able to navigate within the editor area.

Textarea navigation is unfortunately not yet supported. @secrettriangle, the author of the slap editor, has improved upon the blessed textarea a lot. I definitely want to get some of his improvements into blessed eventually. For now the best way to navigate text is to use normal-mode+e - the text editor mode for textareas, which opens your editor for you, allowing you to input text in vim/emacs/etc.
@secrettriangle, you have authority to experiment with new textarea features if you want. You did a whole lot better than I did for text editing. As long as these features help blessed in a general way, I'm sure they'd help slap too.

cc @dbkaplun

@kgraves is this still an issue? If so, check out editor-widget -- this is the widget that slap uses for editing. It might be a little too heavyweight for your purposes, but let us know what you come up with!

Any updates on this feature request? Without ability to navigate in the textbox (or textarea) it becomes very difficult to edit existing values

Same.


Added module-level ci exclusions, other minor stuff

Closes: https://github.com/Azure/azure-cli/issues/6082
This checklist is used to make sure that common guidelines for a pull request are followed.

View a preview at https://prompt.ws/r/Azure/azure-cli/6088
This is an experimental preview for @microsoft users.


Refator BillingContext

Refator BillingContext

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##             master     #8   +/-   ##
=======================================
  Coverage       100%   100%
+ Complexity      270    269    -1
=======================================
  Files            22     22
  Lines           838    848   +10
  Branches         49     49
=======================================
+ Hits            838    848   +10

Impacted Files
Coverage Δ
Complexity Δ

...java/jp/alessandro/android/iab/BillingContext.java
100% <100%> (ø)
5 <1> (-1)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 433056e...0ab6aff. Read the comment docs.


Created initial proposal

This is a test of our new communication style for an issue @kpthatsme raised.
It's a very early product concept worth discussing/concluding on.

I don't think this was the right thing to do - we have new product priorities. Hence closing.


2 misspelled words corrected

'individual' in line 459 and 'eighths' in line 460

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/skills/speech-synthesis-markup-language.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Please merge it :)


kore-exec should output a count of unexplored leaves when it terminates

When a proof fails, kore-exec will output a counterexample (or more than one, with --max-counterexamples). However, the output of counterexamples does not provide information about how many branches/leaves remained unexplored and might therefore yield additional counterexamples.
This can be found out in debugger mode by calling leafs.
The CLI could output this information when kore-exec terminates.

@jberthold Let's timebox this: let me know at the end of your day tomorrow what your progress has been and we'll decide what to do with it.

Status: This feature required modifications to how the execution graph is explored (leavesM in Kore.Rewrite.Strategy) and instigated a rewrite of the graph traversal functionality that leavesM provides. Code is in #3163 (closed for archiving), and will be cleaned up so it can be merged and used for kore-exec.


Add description for overview dashboard

Add description for grafana overview dashboard.
This json file was generated by grafana, and some fields like "scopedVars" was removed.

metric addr is <IP_ADDRESS>:3000

Now only description related change was left.

Actually, I think we don't need to add descriptions to all panels. For example, panel names like CPU usage or memory available are quite clear enough.

@sticnarf All these descriptions are copied from here. As you have pointed out there are many mistakes. Maybe I could modify both places :cry: .


ubports-installer: Add version 0.7.4-beta

App looks like it works, and doesn't look like there is persistent data.
The app works fine without extraction but runs faster with it. If this is not ok then I can change it.

/verify

doesn't look like there is persistent data

Upstream maintainer here. There is persistent data in %APPDATA%, but if it doesn't persist, that's okay. You'll just have to re-download files on every start.

doesn't look like there is persistent data

Upstream maintainer here. There is persistent data in %APPDATA%, but if it doesn't persist, that's okay. You'll just have to re-download files on every start.

Thanks for the info. I will use Junctions to keep the data (when user updates the app with Scoop)

Superseded by #7630.


No guest IP was given to the Vagrant core NFS helper. Shares not mounted

Problem/Motivation

on running vagrant up hassio for the first time (v1.1.0) it throws the follow issue on startup

==> hassio: Machine booted and ready!
==> hassio: Checking for guest additions in VM...
==> hassio: Setting hostname...
==> hassio: Configuring and enabling network interfaces...
No guest IP was given to the Vagrant core NFS helper. This is an
internal error that should be reported as a bug.

When i run it a second time, it starts fine. The issue is that it looks like the shares arent mounted correctly. If i look at the configuration.yml it should have mounted a couple of folders in the vm, but they dont seem to get mounted.
This means that when i have a new addon under the .../hassio/addons folder it isnt picked up. this might be two issues or related. not sure
Expected behavior

No error, and shared to be mounted correctly for addon development to work

Actual behavior

Failure on first vagrant up hassio and no shared folders on second vagrant up hassio

Steps to reproduce

git clone https://github.com/hassio-addons/hassio-vagrant.git hassio-dev
cd hassio-dev
vagrant up hassio

Proposed changes

None unfortunitly

 GitHubhassio-addons/hassio-vagrantVagrant box running Hass.io / Home Assistant. Contribute to hassio-addons/hassio-vagrant development by creating an account on GitHub.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Could you please provide some information on the systems used?

Host OS & Version
NFS installed? Which version?
Vagrant version
VirtualBox Version
VirtualBox Guest additions installed? Version?
Version of hassio-vagrant.

MacOS 10.13.6 (upgrading to Mojave now)
Virtualbox 5.2.20
VB Ext Pack 5.2.20
Vagrant 2.2.0
After fiddling a bit, i have notices

starting against my wifi connection creates the above error No guest IP was given to the Vagrant core NFS helper.
starting againt my lan connection (wasnt plugged in before) go's further to the point of creating the shares and adding them into the /etc/exports file, but fails then with the error  Access denied when trying to run the mount command mount -o 172.x.x.x:/home/xxx/hassio/addons ...

Will try again now post the upgrade to mojave

I am having this same issue with:
MacOS 10.14
Virtualbox 5.2.20 (no extension pack)
Vagrant 2.2.0

I've been able to reproduce the issue. It seems like an issue with Vagrant unable to find the host-only network when it is not primary.
https://github.com/hassio-addons/hassio-vagrant/blob/master/Vagrantfile#L98
It seems like swapping line 98 & 99 solves the issue, nevertheless, in my test, is caused the public interface to have 2 IP's instead of just one.
Could any of you test swapping line 98 & 99?

testing now

FYI, incase you run on 10.14 Mojave and get issue setting /etc/exports or starting nfsd - https://www.cubewebsites.com/blog/software/quick-fix-macos-mojave-vagrant-error-tee-etc-exports-operation-not-permitted/

and it works, swapping line 98 and 99 around now starts perfect and has folders mounted
STEPS:
vagrant destroy hassio
vi Vagrantfile

swap line 99 machine.vm.network 'private_network', type: 'dhcp' with 98 machine.vm.network 'public_network', type: 'dhcp'
cat /etc/exports - mine was nice and empty
vagrant up hassio
post startup
vagrant ssh hassio
ls -ltr /usr/share/hassio/addons/local/ -> showing folders from local machine in the addons local fonder

Thanks for testing @potgieterdl, Will adjust the codebase asap to reflect this change.


[ast] Fix a memory error in Diagnostic Emission.

Specifically, we were storing pointers into a SmallVector. When the small vector
resized, the pointers were no longer valid resulting in memory
corruption. Was triggered by my work adding capture diagnostics.

@swift-ci test

@swift-ci test

I think this is a pretty straight forward fix. I am going to merge and do post-commit.

I think this is a pretty straight forward fix. I am going to merge and do post-commit.


chore: do not enable having duplicate dag blocks inside nonfinalized …

…blocks by design
Purpose

For reviewers

Related Github issues

Changes

Tests

Deployment Considerations
Version Notes
{ major | minor | patch }

NOTE: Include the version notes in the squash commit message

prnet cleaned-up successfully


Settings UX - JSON input field

This is a feature request for the settings ui. With it being introduced, we still have to go to the json editor for more complicated settings. What's the harm of having a multiline Monaco json editor in settings gui?
@roblourens

We considered something like this but I don't like it, I think it would be awkward to have a text editor inside the UI. I think it's better to let a normal json editor be a good editor, and have the UI be a good UI.


Deque using doubly linked list

Fix #1340
C language Code to Implement Deque Using Doubly Linked List

not assigned


Better method resolution

Currently, the method resolver will pick the first method it encounters that successfully works. Unfortunately, this means on some systems it will choose double Math.min(double, double) for 2 integers. This is double, double, toil, and trouble if you are expecting an integer return value.
The method resolver should attempt to intelligently select the most appropriate override using an algorithm similar to the one defined in the JLS.

The link for the JLS method invocation resolution is found here: https://docs.oracle.com/javase/specs/jls/se8/html/jls-15.html#jls-15.12.


Doc fixes, tweaks and improvements

A couple of comments:

The rest accessor API is now documented using sphinx-autosummary-accessors.

I replaced the ipython directives by regular python code blocks. I don't think using ipython directives are worth relying on ipython + all xpublish's runtime dependencies for building the docs, given that we don't really leverage the interactive output here. I'm not against reverting this change in case anyone has objections.

I also switched from using numpydoc to using sphinx.ext.napoleon. This is more personal taste (I prefer the rendering with napoleon), but I'm happy to revert this change too if someone has any objection on this.

@benbovy - FYI, I just turned on PR builds for read the docs. I had to close/reopen this PR to trigger the doc build.

Thanks @jhamman, that's very helpful!

Thanks for having a look @jhamman and @andersy005!


Error from server (InternalError): error when creating "./vm.yaml": Internal error occurred: failed calling webhook "virtualmachines-mutator.kubevirt.io": Post "https://virt-api.kubevirt.svc:443/virtualmachines-mutate?timeout=10s": context deadline exceeded

I installed KubeVirt and virtctl by following the official documentation.
But I failed to create VM.
Environment :
virtctl  v1.0.0-beta.0
kubectl  v1.21.0
CNI - flannel
CRI - containerd
kubernetes v1.21.0
3 master nodes - Ubuntu Server 20.04 LTS, 5.4.0-131-generic, m2.c4m8 (4Core, 8GB), disk 50GB
3 worker nodes - Ubuntu Server 20.04 LTS, 5.4.0-131-generic, m2.c8m16 (8Core, 16GB), disk 100GB
Error:

Command I ran :

install KubeVirt
export VERSION=$(curl -s https://api.github.com/repos/kubevirt/kubevirt/releases | grep tag_name | grep -v -- '-rc' | sort -r | head -1 | awk -F': ' '{print $2}' | sed 's/,//' | xargs)
echo $VERSION
kubectl create -f https://github.com/kubevirt/kubevirt/releases/download/${VERSION}/kubevirt-operator.yaml
kubectl create -f https://github.com/kubevirt/kubevirt/releases/download/${VERSION}/kubevirt-cr.yaml

install virtctl
VERSION=$(kubectl get kubevirt.kubevirt.io/kubevirt -n kubevirt -o=jsonpath="{.status.observedKubeVirtVersion}")
ARCH=$(uname -s | tr A-Z a-z)-$(uname -m | sed 's/x86_64/amd64/') || windows-amd64.exe
echo ${ARCH}
curl -L -o virtctl https://github.com/kubevirt/kubevirt/releases/download/${VERSION}/virtctl-${VERSION}-${ARCH}
chmod +x virtctl
sudo install virtctl /usr/local/bin

create vm
kubectl apply -f https://kubevirt.io/labs/manifests/vm.yaml  <<- error occurred with this line.

It seems to me you are installing Kubevirt version 1.0 on top of Kubernetes 1.21. This is not a supported combination. Please update your Kubernetes to >= 1.26.

@xpivarc interesting, if that's the case isn't there a way to throw an incompatible version error of some sort?

It seems to me you are installing Kubevirt version 1.0 on top of Kubernetes 1.21. This is not a supported combination. Please update your Kubernetes to >= 1.26.

I can't upgrade my k8s version because my cluster is running multiple services and is sensitive to changes. Is there any resolution for this issue other than changing the version?

Hi @kyungminchoi ,
You could give it a try with Kubevirt 0.45-0.54. Please note Kubernetes 1.21 is EOL and that is more or less true for Kubevirt.

Hello @xpivarc , Thank you for your quick reply.
I took your advice and adjusted the version of KubeVirt to v0.54.0, still the same issue...

@kyungminchoi looks like you virt-api unable to access mutating webhook api service address, you can simple run a pod with curl tool on the same node that virt-api runs and kubectl exec into pod  run curl http://virtualmahcines-mutator.kubevirt.io if unable to curl that might be your network setup issue

url http://virtualmahcines-mutator.kubevirt.io

As you said, I can't curl it with 'Could not resolve host' DNS error message.

@kyungminchoi looks like you virt-api unable to access mutating webhook api service address, you can simple run a pod with curl tool on the same node that virt-api runs and kubectl exec into pod run curl http://virtualmahcines-mutator.kubevirt.io if unable to curl that might be your network setup issue

As you said, I couldn't curl with the "Could not resolve host" error.
If you know, can you tell me what network setup issue it is?

I solved the issue. It's CRI proxy configuration issue.
`sudo mkdir /etc/systemd/system/containerd.service.d
sudo vi /etc/systemd/system/containerd.service.d/http-proxy.conf
#http-proxy.conf file content
[Service]
Environment="HTTP_PROXY=http://YOUR_PROXY_IP:PORT"
Environment="HTTPS_PROXY=http://YOUR_PROXY_IP:PORT"
Environment="NO_PROXY=.svc,localhost,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,local.home,YOUR_MASTER_NODE_IP,YOUR_WORKER_NODE_IP,YOUR_POD_CIDR,YOUR_SERVICE_CIDR"
#restart containerd
sudo systemctl daemon-reload
sudo systemctl restart containerd`

/close


"rendererName" does not work with fixed pivots

The property "rendererName" does not appear to work when using non editable pivots, i.e. pivot(...).  It does however work on pivotUI(...).
See example here: https://jsfiddle.net/vqkk7kh5/1/
In the example if you change pivot(...) to pivotUI(...) you see that the heat map is shown.

Please see this FAQ entry.


Futures Trading

🌟 Feature Description
Futures trading support
Do you have any plans to add the futures trading support to the framework?

Yes.  Qlib is designed to support all financial derivatives include futures.
But futures trading is quite a broad and somewhat fuzzy word.   Can you give some examples of your future trading research works and what features are required to support your research?

Yes. Qlib is designed to support all financial derivatives include futures.
But futures trading is quite a broad and somewhat fuzzy word. Can you give some examples of your future trading research works and what features are required to support your research?

how about cryptocurrency?:)

@nkiki  I think most of the research works on cryptocurrency are similar to  alpha forecasting and High-frequency trading .
For these two cases, the former has been alreadly supported by Qlib's framework areadly (But the data is not included.)
The latter will be supported in the future.

Yes. Qlib is designed to support all financial derivatives include futures.
But futures trading is quite a broad and somewhat fuzzy word. Can you give some examples of your future trading research works and what features are required to support your research?

Like reinforcement learning based "Medium-frequency" trading strategies

@wycfutures  The  RL diagram is not supported in the current version, but it is what we are designing and we will try to implement a framework in the future.
Welcome to discuss with us about the design of framework.

I'd be happy to see the existing framework support the S&P 500 E mini: https://finance.yahoo.com/quote/ES=F/

@nkiki I think most of the research works on cryptocurrency are similar to alpha forecasting and High-frequency trading .
For these two cases, the former has been alreadly supported by Qlib's framework areadly (But the data is not included.)
The latter will be supported in the future.

Hi @you-n-g ,
Are there any plans to add the cryptocurrency trading environment in the backtest?
For example: Okex Perpetual Swap ?

@ChengYen-Tang Currently, we are working on developing high-frequency trading based on supervised learning.
A framework and some simple examples will be included.
You can check if your requriements can be fulfilled.

Hi @you-n-g ,
I have a question.
Does the backtest include short-term operations?
Also, are there relevant documents that include the backtest environment?

Hi, @ChengYen-Tang
Here is some documents about backtest environment (some interfaces may be refactored recently).
https://qlib.readthedocs.io/en/latest/component/backtest.html
Short-term operation may be supported in the next version

OK, Hope this problem can be resolved as soon as possible, thank you.
https://github.com/microsoft/qlib/issues/237


Video always freezes!

Pubnub server started to freeze videos.
From 2018-10-17
UTC 2:00 PM

It seems yesterday changes made the video freeze, not only on iOS Safari but on all browsers.

Will be working on this to resolve.

getting closer...

Getting a lot closer!  Safari 12 can send/receive calls to any other browser!  However Safari is still unable to call Safari successfully.

We had issues when calling from chrome to mozzila fire fox? We used to get cross origin issue.

Apple’s WebRTC implementation only allows one getUserMedia capture at a time.  So this is why I've never been able to get Safari to work.

Video Freezing: https://blog.mozilla.org/webrtc/when-your-video-freezes/ - this may be the fix

Windows OS: Chrome to Chrome video still freezes.
Caller A calls Caller B, A video is normal on both callers but B video is frozen on both callers.

Caller A debug log:

Caller B debug log:

Just submitted the next release with a much needed race condition fix on signaling exchanges.  This may have improved the conditions you see.

I just checked it. Still same issue. Tested on Chrome Version 69.0.3497.100 (Official Build) (64-bit). Before commit 12793d666437dc80dbfd3d7d3d0b8230de3d840f video wouldn't freeze but now it does.
I use both local video cam and callers video cam on both sides of the connection. So the caller sees itself and the participant, same at the participants end. Callers video is not frozen on both the callers (local) side and the participants, but the participants video is frozen on local and callers side.

Ok I found the issue. To ensure that the video will be shown I had this code before:
`var videoStreamActive = false;
phone.receive(function(session) {
console.log('receive');
// Display Your Friend's Live Video
session.connected(function (session) {

	// Work arround the issue when the video is not always shown.
	session.video.srcObject.onaddtrack = function(event) {
							videoStreamActive = true;
						};

	session.video.srcObject.oninactive = function(event) {
		videoStreamActive = false;
	};

	session.video.onloadedmetadata = function(e) {
		if (videoStreamActive) {
			//video is always shown.
			onVideoCallNow = true;

			video.appendChild(session.video);
		}
	};

});`
But now because of this code the video of participants is always frozen. When I remove this then the video is not frozen, but I need to ensure that the video will always be shown to the user.


If I follow the link in the description, will I be using the latest version of inknote?

This is the link: http://www.michalpaszkiewicz.co.uk/inknote/

Yes it is the latest version, but this is really still in production :)


fix(uniffle): Correct the write wait duration log

What changes were proposed in this pull request?
To correct the write wait duration log
How was this patch tested?
Haven't

PTAL @zhztheplayer @PHILO-HE @summaryzb


Where is the Legacy Documentation?

Would it be possible to provide legacy documentation? I just tried to lookup drop-downs on materializecss.com only to see that the implementation has changed. I like the new implementation better, but I can't just change to a new version mid-project. I have dozens of drop-downs using the "old" way. I'd have to re-write half of my project.
I'm using version 0.98.0

Please see: https://github.com/Dogfalo/materialize/issues/1586


JSON Serialization on zero value keys

On JsonObjectSerializer.php line 189, array_filter is called to remove any null properties from the array. This gives an error when trying to add a new TaxService with a TaxRateValue = 0 (zero).
The property is removed from the object and Quickbooks throws an error:
"Error":[{"Message":"Required param missing, need to supply the required value for the API","Detail":"Required parameter TaxRateValue is missing in the request","code":"2020","element":"TaxService.TaxCode"}]

A suggestion a made in my code:
/**
 * Custom filter for array_filter
 * Return true if value is not NULL or an empty string
 */
public function customFilter($val)
{
    return !($val === null || $val === "");
}

/**
 * The input will always be an asscoiate array
 * So we will judge based on this two situration
 */
private function removeNullProperties($val){
    $filterArray = array_filter($val, array(&$this, "customFilter"));
    $returned = array();
    foreach($filterArray as $k => $v){
      if(is_array($v)){
        if(FacadeHelper::isRecurrsiveArray($v)){
          $list = array();
          foreach($v as $kk => $vv){
            $list[] = array_filter($vv, array(&$this, "customFilter"));
          }
          $returned[$k] = $list;
        }
      }else{
        $returned[$k] = $v;
      }
    }
    return $returned;
}

@vfranchi
Nice Catch! I will update it in the code! Thanks!


Enable some sort of runtime evaluation of custom expressions.

Some times one would like the mocked response to contain non-static data, say the current date or so. For such cases it would be nice if there would be some way of evaluating expressions runtime.

This feature is added in v2.2.0
You can now inject your custom implementation of the Atlantis.TokenHelper interface, either through a Configuration.Builder or by passing your implementations canonical class name as the "tokenHelper" property, in the root configuration JSON (technical details to be found in the "Reference" section in the Wiki).
The TokenHelper implementation (if given) is called for action just before a mock response is served, hence, any tokens are given a chance to get evaluated each time a request is made (nifty for date/time tokens etc), all depending on your implementation, of course.
The TokenHelper is called on the Atlantis worker thread, minimizing the risk of directly blocking the UI, but still blocking the request queue.
Note that there is no expressed nor implied token notation here. You define yourself what your tokens look like and how you parse them. The TokenHelper interface has only one method; TokenHelper#parse, where you're given the current request and the suggested response (with any unparsed tokens) and you're supposed to return a new MockResponse where your tokens have been evaluated and replaced with their corresponding values. The request itself can not be toknized.


Litestar websockets support

Add a separate inject_websocket decorator due to the special signature of litestar websocket handlers that do not require an websocket object

Update docs, please

Update docs, please

updated


Multiple services on same port

Hello!
I'm sorry if this is obvious and I just missed it, I'm pretty new to elixir.
Is it possible to have multiple services on the same port as with other GRPC implementations?

It's supported :)

That's good to hear!
Could you maybe give a short example @tony612 as no current example in this repo shows it? Thank you!

You can see the examples in examples. You should be able to call multiple services with one channel like
# the helloworld example
{:ok, channel} = GRPC.Stub.connect("localhost:50051")
reply = channel |> Helloworld.Greeter.Stub.say_hello(Helloworld.HelloRequest.new(name: "grpc-elixir"))
reply = channel |> Another.Service.foo(Helloworld.HelloRequest.new(name: "grpc-elixir"))

Try something like this. If it doesn't work, please tell me.

Thank you for the sample :) this seems to work with my go server.
What I'm struggling with is the server side as I'm always getting an error when registering the GRPC supervisor a second time with another service using this code:
# In the start function of your Application
def start(_type, _args) do
  children = [
    # ...
    supervisor(GRPC.Server.Supervisor, [{Helloworld.Greeter.Server, 50051}]),
    supervisor(GRPC.Server.Supervisor, [{Other.Service.Greeter.Server, 50051}]),
  ]

  opts = [strategy: :one_for_one, name: MyApp]
  Supervisor.start_link(children, opts)
end

This is not supported. But I can add this feature these days.

That would be awesome. I want to port over a part of our GRPC stuff from go to elixir and our whole setup depends on multiple services being available from the same port.

Fixed. You can use a server list in child_spec like
children = [
    # ...
    supervisor(GRPC.Server.Supervisor, [{[Helloworld.Greeter.Server, Other.Service.Greeter.Server], 50051}])
  ]

Please update grpc with mix deps.update grpc


[IcomMenu] Use destructured onKeyboardFocus property

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Noticed this while reviewing #3732.

Good catch :+1:


[MRG] Add mask parameter to TFR plot

Fixes #5032, cf #5010

The three channels are pretty far apart, therefore I would like to consider their TFRs ad independent (i.e. I don't want to maintain a p=0.05 across all channels).
Regarding the two one-tailed tests, are you saying that I should set the threshold to p <= 0.025?

Yes, but you are conduction six tests alltogether (3 channels and two tails).

That's what I'm saying, I don't want to maintain an alpha level for all three channels together.

Sure, in my comment I meant for example bonferroni correction if you consider these independent.

What I'm saying is that I don't think it is necessary to correct p-values for the three channels, because I want to maintain alpha = 0.05 per channel. If I corrected (e.g. via Bonferroni), then I'd have an alpha = 0.05 for all channels, which is not what I want.

@cbrnr , after Alex' latest demands (😆), my PR is now doubled in size. I think we should consider not doing these two in parallel, but going for a unified function (mne.viz.utils._plot_image) as soon as possible.
My idea would be, you finish this one as-is (i.e., without adding the contours I just added), I finish mine as-is, and then we do another PR afterwards where we refactor the (masked) image functionality. We just need to ensure your API is a subset of mine.

OK, sounds good.

Ready to merge.

@jona-sassenhagen can you check if it is more Pythonic now?

I think it's fine, I'll look later.

Getting close to Pythonic perfection it seems 😄 - this is indeed much better than before, thanks guys for your great feedback!

@jona-sassenhagen is happy and I'm happy (other than minor nitpick I fixed), merging, thanks @cbrnr


Bug: UpdateListener with debounce

Hello I want to update some state, whenever the editor receive an update.
However i want to include a debounce function to delay the state change by  a bit for performance reasons.

function debounce<T extends Function>(cb: T, wait = 300) {
  let h: ReturnType<typeof setTimeout>

  let callable = (...args: any) => {
    clearTimeout(h)
    h = setTimeout(() => cb(...args), wait)
  }

  return <T>(<any>callable)
}

 const [editor] = useLexicalComposerContext()

useEffect(() => {
    editor.registerUpdateListener(({ editorState }) => {
      console.log('update detected')
      debounce(() => {
        console.log('Should update in debonuce function')
      }, 500)
    })
  }, [editor])

Lexical version: 0.13.1
Lexical/react: 0.13.1
Steps To Reproduce

The current behavior
The console  log insided my debounce function doesnt get called ever.
The expected behavior
The console log should be called

Try this:
  const [editor] = useLexicalComposerContext();

  const debounced = debounce(() => {
    console.log('Should update in debonuce function');
  }, 500);

  useEffect(() => {
    return editor.registerUpdateListener(({ editorState }) => {
      console.log('update detected');
      debounced();
    });
  }, [editor, debounced]);

BTW, this kind of question will be more welcomed and easy to get answered in discussion or discord community 😋

Thank you very much. Yes this i was missing.
Cool I will join Discord.


first protein ligand simulation set ups using openforcefield-rdkit

Hi,
as requested by @davidlmobley here (https://github.com/openforcefield/openforcefield/issues/28#issuecomment-382541238) I stop hijacking other issues and create a dedicated one to outline what I'm trying to achieve using openforcefield.
As a start I want to set up a proper ligand protein simulation using only the rdkit integration started by @hjuinj .
So the current short term things I'm testing are:

parametrizing the ligand using openforcefield (smirnoffparm@frosst offxml).
parametrizing the protein (using amber forcefield and parmed structure, coming from the utilities, generateProteinStructure function)
adding explicit solvent in the whole thing
setting up periodic boundary conditions and run simulation using openMM.

On the mid-term, if this first test integration works, i'll also integrate a protein chunk creation + harmonic restraints into the simulation as described here : https://www.nature.com/articles/nchem.2660. Most of this is already done but not tested with parmed/openforcefield prepared systems yet.
On the long run, I'd be happy to simulate systems only prepared via openforcefield (also the protein)...so this would require a translation of the protein force fields to offxml.
I'll push my work for now here (https://github.com/pschmidtke/openforcefield) into the pschmidtke_rdk branch, as I don't have access to this repo here. Note that I also do not have an openeye license and that the whole point of this integration is to provide a fully free version of our dynamic undocking approach (I currently rely on MOE to parametrize the ligands using.....parm@frosst ;) ).
Also, I'm a noob in openmm, am still discovering a lot (and I like it a lot) and will probably sometimes ask noob questions, like where is what or how to do the most basic thing in the world, sorry for that :)
I'll post issues related to the offxml or other openforcefield related things here.
Thanks in advance for your help!

Morning Peter,
I think I know why you have exception caught with this CCCCn1c(Cc2cc(OC)c(OC)c(OC)c2Cl)nc2c(N)ncnc12 and the new offxml file. I think it is actually to do with the aromaticity model.
quoting the problematic region you saw:
Topological atom sets not assigned parameters: (4, 5) : 0 mymol 4 0 mymol 5 (4, 27) : 0 mymol 4 0 mymol 27

and this figure:

This is the hetero-ring which the openeye MDL aromaticity model does not recognize as aromatic while the rdkit (which I guess you are using 2017.03 or before?) does think it is aromatic. Sifting through the new offxml file there does not seem to be bond smirks for tertiary aromatic nitrogens and hence the error.
I have been looking at the newest rdkit version which implements the MDL aromaticity model.
but I had some issues which I reported here and hopefully this has been resolved in the most recent beta-trial version of rdkit 2018.03 (they have the conda install-able out last week if you wish to give it a try, conda install -c rdkit/label/beta rdkit, although I don't think it will directly solve the problem). I have a WIP version on my laptop which I can try to work a bit more on. Unfortunately it is kind of a bad timing for me as I am set to go on holiday later today for two weeks. I can work on it between travels but I cannot promise anything, sorry.
@davidlmobley

thanks @hjuinj . Seems logical, as I observed the weird geometries (with previous ffxml) either on tertiary aromatic nitrogens, but also a few others (but usually nitrogens). No hurry, I also have real work ;) I can continue to set up my things on systems without these types of atoms.

Thanks for this, @pschmidtke . I'll revisit in more detail soon, but just to respond to the SMILES/aromaticity model: Definitely if you're using the older version of RDKit the aromaticity model means something very different and you'll get a lot of discrepancies in substructure matches. Shuzhe (@hjuinj ) put in a great deal of work into (a) tracking these down, and (b) working with the RDKit developers to get a comparable model put into place for the 2013 beta. I think ultimately he was able to get all the energies (cross-comparing between OE and RDKit implementations) to agree, but that presumably requires the WIP stuff he has on his laptop.
One thing which might or might not be useful to you is that we've actually done all the hydration free energy calculations in the FreeSolv database again with SMIRNOFF, using water, obviously (see our preprint on biorxiv), and scripts for this are available online. You may find this one useful: https://github.com/MobleyLab/SMIRNOFF_paper_code/blob/master/FreeSolv/scripts/create_input_files.py -- at least, it shows one particular workflow that will successfully get you OpenMM input files for a set of "solute in water" systems. It DOES rely on (open source) packmol for adding water molecules, which may not be as good as adding things to a pre-equilibrated box. But it does also work reliably/robustly (642 hydration free energy calculations run, a couple of times!). :)

@pschmidtke : Is this issue still relevant now that we have the toolkit 0.2 release featuring RDKit support?


fix(MastheadLeftNav): trap focus to mobile masthead on VO

Related Ticket(s)
[Masthead]: able to navigate behind mobile menu VO – React Mobile Safari #8557
Description
VO only focuses on the focus-trapping buttons when the buttons have content. Therefore adding the focus trapping button content to the buttons so that VO can focus on the buttons which resets focus to the appropriate elements to achieve focus trapping.
Adding feature-flag label to make sure the style changes do not affect the cloud-masthead
BEFORE:
https://user-images.githubusercontent.com/45692622/159015382-f34857d4-540e-42b8-8e76-bb3d396577a1.MP4
AFTER:
https://user-images.githubusercontent.com/54281166/194105860-5d12a52d-0cfc-4f54-862f-8dfc84f6f26d.mov
Changelog
Changed

add focus trapping button content to focus trapping buttons
remove un-necessary styling
remove aria-hidden to allow VO to pick up focus trapping buttons

Now the VO focus remains within the menus of the masthead in iPhone


Some more fixes.

The function params one needs to be looked at. I don't know what this existing "fL" case you're trying to handle is, and there don't seem to be any tests for it. There is a C++17 fold expression thing that goes "f[LlRr]" but that doesn't look like what's going on here.

Let me know when this PR is ready for another round of review.

If there's a way to rebind $typename again to enforce that these must be the same I'd love to know how.

I don't know, unfortunately.

I thought you were going to hold off until I asked you to review again ...
You should be aware that this won't build release because of rust-lang/rust#50323

I thought you were going to hold off until I asked you to review again ...

Heh, looks like I jumped the gun.

You should be aware that this won't build release because of rust-lang/rust#50323

Thanks for the heads up. CI does cargo bench, which implies a release build, so I wonder why that succeeded.


Module loader

Loads modules from the repository config file with openshift1.5 as a default fallback

lib/commands/order.py needs fixing in the same way.


Option For JSON wmv-info.properties?

Hello,
Nice plugin =). I was wondering if you would be interested in supporting a configuration option to allow the wmv-info.properties file to be JSON encoded, as opposed to the INI style that it is now (which could still be default, of course). Another idea is XML encoded as well.
Thanks very much.

Hey, thanks :) .
I chose properties file because Java has inbuilt methods to read from such files. However JSON/XML would be nice to have.
Would using libraries like Gson makes sense?

Gson might be a bit heavy for this use-case. In fact, pulling a dependency in at all might be a bit heavy. It may be simple enough because there will only be one level of "nesting" to just write it without any libraries. Totally up to you though =)

Options for JSON and XML have been added in v2.1.0


Skip the check for custom vendor data if they are not present

The custom-key value is only set during initial deployment of Cloud7,
so it is not present when the cloud is upgraded from Cloud6.
An alternative to https://github.com/SUSE-Cloud/automation/pull/1647

Maybe it should be set on upgrade?
It comes from
./chef/cookbooks/nova/templates/default/suse-vendor-data.json.erb
but defaults to empty and we set it non-empty when configuring nova
so could be done by doing after upgrade
do_one_proposal nova default

Maybe it should be set on upgrade?

But it's not clear at which point this do_one_proposal should be called. From cloudupgrade step? Or from testestep? Bot do not seem correct to me.
Seeing that this PR has actually passed both normal and upgrade gating jobs, could we rather merge it?

@dirkmueller @bmwiedemann are you willing to accept PR (and merge without further gating rub) if I only add a comment?


Added Rage Bonus Damage and Token Magic Effect

Hello! I added the bonus damage to the Rage Effect, and also a token magic effect that my DM uses that seems cool.

Rage damage is already handled via the dynamic-effects-adder.js. Where does this @scale stuff come from? Never seen it before.

It's from dnd5e 1.6.x onwards. Level advancement stuff

Yeah, it's from the dnd5e system itself

Nice, that's awesome. I think the parts about rage would need to removed from the dynamic effects adder before this got merged.

@thatlonelybugbear @Carlosjrlu are there any other examples like this in the dnd system now? I don't know where this is documented and I was curious if I could do anything else

Bard's bardic inspiration , Rogue's sneak attack, Monks Martial Dice have scaled values for the SRD classes

Amazing! Thanks @thatlonelybugbear


If zoom-level of view < 3 throws error =>   Cannot read property '3' of undefined

When a vectorLayer was added to the Map and the zoom-level of the view < 3, it throws an error =>
Cannot read property '3' of undefined.
Error-Details
Executor.replayImageOrLabel_
https://m0qxk.csb.app/node_modules/ol/render/canvas/Executor.js:160:23
Executor.execute_
https://m0qxk.csb.app/node_modules/ol/render/canvas/Executor.js:463:18
Executor.execute
https://m0qxk.csb.app/node_modules/ol/render/canvas/Executor.js:620:10
ExecutorGroup.execute
https://m0qxk.csb.app/node_modules/ol/render/canvas/ExecutorGroup.js:172:20
CanvasVectorLayerRenderer.renderFrame
https://m0qxk.csb.app/node_modules/ol/renderer/canvas/VectorLayer.js:132:17
VectorLayer.Layer.render
https://m0qxk.csb.app/node_modules/ol/layer/Layer.js:101:28
CompositeMapRenderer.renderFrame
https://m0qxk.csb.app/node_modules/ol/renderer/Composite.js:97:27
Map.PluggableMap.renderFrame_
https://m0qxk.csb.app/node_modules/ol/PluggableMap.js:568:20
Map.eval
https://m0qxk.csb.app/node_modules/ol/PluggableMap.js:97:12
To Reproduce
Steps to reproduce the behavior:

Define a map component with a view, tileLayer  etc.
Set the zoom of your view to 3.
Define a vectorLayer with a geoJSON as vectorSource.
Compile and zoom out.

Code to reproduce
GeoJSON-Object
{
        type: "FeatureCollection",
        crs: {
          type: "name",
          properties: {
            name: "EPSG:3857"
          }
        },
        features: [
          {
            type: "Feature",
            geometry: {
              type: "Point",
              properties: { name: "TEST2" },
              coordinates: [6.94506, 58.6917]
            }
          },
          {
            type: "Feature",
            geometry: {
              type: "Point",
              properties: { name: "TEST2" },
              coordinates: [7.622712, 60.634644]
            }
          },
          {
            type: "Feature",
            geometry: {
              type: "Point",
              properties: { name: "Test in der Nähe" },
              coordinates: [7.622712, 51.6917]
            }
          }
        ]
      }

Map-Definitions
 var styles = {
      Point: new Style({
        image: new CircleStyle({
          radius: 5,
          fill: new Fill({
            color: "red"
          }),
          stroke: new Stroke({
            color: "red"
          })
        })
      })
    };
    var styleFunction = function(feature) {
      return styles[feature.getGeometry().getType()];
    };
    let view = new View({
      center: fromLonLat([6.94506, 51.6917]),
      zoom: 3,
      // minZoom: 0,
      projection: "EPSG:3857"
    });
    let tileLayer = new TileLayer({
      source: new OSM()
    });
let vectorLayer = new VectorLayer({
      source: new VectorSource({
        features: new GeoJSON().readFeatures(this.geoJSONdefault)
      }),
      style: styleFunction
    });
    let map = new Map({
      target: "map",
      layers: [tileLayer, vectorLayer],
      view: view
    });
map.render();

Expected behavior
An error occured which tells "Cannot read property '3' of undefined"

Which bundler are you using? I noticed a similar issue a while back, caused by an import that was not correctly resolved. Both your issue and the one back then, I can reproduce in https://codesandbox.io/. Locally everything works fine. Tested wit Webpack and Parcel.


Stop recommending PhantomJS

Scala.JS recommends Node.JS for DOM-less testing, and PhantomJS for testing with DOM.
Over the past year, PhantomJS has been nothing but a source of trouble for me. There are 1600+ open issues on its project page, many are serious and have been open without activity for years. In fact it doesn't get much activity at all. There are a few open issues within Scala.JS too (#1555, #1457, #1702, more?).
We shouldn't be directing Scala.JS users to use PhantomJS. Some other solution should be discovered and recommended.
I'm guessing node/io.js + jsdom (@sjrd | @gzm0, if you've tried this I'd love to hear your experiences), or maybe something using xvfb as suggested here. No answer yet, but I think it should be recognised that PhantomJS doesn't really work, and we're going to be setting the community up for eventual and significant pain, if we find a better solution here.

tbh, I don't think any solution would be better than PhantomJS. Emulating the DOM correctly is hard, every browser does it differently, and with stuff continuously moving in HTML5 land, its hard to be ontop of especially with a spec that isn't really set in stone.
I don't have an issue in recommending something that is better, I am just not sure if a better exists

It's not just niche/advanced/edge features that PhantomJS can't handle. It doesn't even support focusing (.focus(), .blur(), document.activeElement). :disappointed:

I don't doubt that at all, my main point is that I am not aware of a better Phantom.js existing. Doing this stuff correctly is ridiculously hard, and you can use the old "standards" argument as to why thats the case.
Also issue count isn't an objective measure of how stable/correct implementation is. Once any non trivial project gets to a certain size/number of users, you get that many issues (a significant amount of those issues also turn out to be non issues)

I don't doubt that it's hard. I also don't care, nor do I think any of us should. Scala.JS users' goals aren't to fix PhantomJS or build an alternative, our goals are to write Scala.JS code and be able to test it. PhantomJS is very limited in that regard and by observation of its continual lack of activity, isn't going to get much better. We should search for alternatives. A suitable alternative product doesn't seem to exist AFAIK (i.e. a reliable, headless browser), but alternative means of achieving the same goal do exist, and its the exploration of those that I believe is in the best (long-term) interest of the community.

Oh although node|io.js + jsdom might be a good alternate solution in the same vein, but I'm not sure that anyone's got it working with Scala.JS. I'm hoping to try myself, maybe this weekend if I get time. That has potential I think.

This is hard, because it goes beyond just libraries that are ostensibly dom-centric (e.g. d3). some libraries that are mostly not dom related still end up requiring it. I had to use phantom because moment.js (a date library) was requiring the dom for some reason and without it was blowing up on unit tests. This was a while ago, so maybe it's not an issue anymore with this specific. The problem is that a lot of random js code that can end up in a project might have a few lines that refer some dom api without which they just blow up.
I guess overall the best thing is to, in addition to what is suggested here, recommend a differentation at the project level between portions of ScalaJS the user writes that interacts with the DOM and pieces that don't.
This means there is almost kind of a hierarchy:
1> Platform-Agostic Scala (The portions of scala ecosystem / the jvm APIs which work in ScalaJS)|
|2> JVM-Only Scala (uses scala/java libraries / apis not ported / supported to ScalaJS)
|3> JS-Only Scala (uses things that are ScalaJS specific but which should run on any reasonable javascript runtime, e.g. js.Dynamic.literal(), maybe some work should be done here to port this code over to work on the JVM at some point, i dunno kind of bends my mind just thinking about that)
_|4>  Node JS Scala (uses node apis) runs on server (and emulates dom with Phantom or something better)
_|5>  DOM JS Scala (uses dom apis) runs in browser (and emulates node with browserify)

So from my example, I expected moment.js to be a 3 type of library whereas really it turned out to be a 5 type.
I think the testing story for the 5 type libraries / code is always going to be tougher than for 1-4. So for things like moment which are 5's but which should really be 3 something like phantom (or equivalent might be ok if you can get it to run on your platform and it still will crash the tests for whatever reason once in a while #1457 et al.),
For 5s that are a bunch of real DOM-modifying UI browsery goodness, I think you have to go to selenium / firefox aka actual in browser testing if you want anything reasonable from what I hear (but I have not done this myself yet).
So maybe we should suggest, users try to write type 1(write once, run everywhere) code if at all possible, then type 3 (no dom/node agnostic scalajs) code. If they are doing actual DOM / UI testing phantom is buggy, and they should use selenium, and then add some SBT plugins (or patch the SBT ScalaJS plugin) that would get firefox / selenium testing working?

A couple thoughts:

I'm not sure headless testing is really the goal, so much as the ability to reliably unit test code that will run in a browser environment. Ideally, this can be done in a browser agnostic way. If that problem is solved, making it truly headless can also be solved by introducing xvfb or falling back to phantomjs.

While node+jsdom will inevitably mature and improve, it's never going to be a real browser. Given the jvm, most scala.js code will be deployed to browsers for the foreseeable future. For sufficiently limited code, node and node+jsdom will provide a nice optimization, but I think it's important to target real browsers and then optimize down from there rather than the other way.

Selenium/webdriver isn't that relevant to unit testing. Web driver provides a json api for actually controlling the browser, so you can use it to click the back button, fill out forms, etc. As such, it requires direct support from the browser manufacturer or a plugin, and provides a bunch of functionality that isn't really relevant to scala.js so much as for writing functional tests. It may be the most appropriate way to start the browser and feed unit test results back, but it's not the only way and it's a finicky one so I don't think designing a unit test solution around it exclusively is a good idea.

That said, the javascript community has more or less solved this problem. They push an html page with javascript in it to the browser, render it, and display the results in the page. Tools like karma capture these results, allowing for a command line interface, CI, etc. This is simple, browser agnostic, and works remotely .
I believe scala.js already has some pieces of this in place. There are jasmine tests for the core and the phantomjs test runner seems to generate some html code for the test runner. There's also a jetty process wired into sbt to support phantomjs, so it feels to me like these things could be reorganized in such a way that you could use the browser of your choice instead of just phantomjs.

I think we can officially consider this fixed with #2583.


New version: SPIRV_LLVM_Translator_jll v9.0.0+4

Autogenerated JLL package registration

Registering JLL package SPIRV_LLVM_Translator_jll.jl
Repository: https://github.com/JuliaBinaryWrappers/SPIRV_LLVM_Translator_jll.jl
Version: v9.0.0+4
Commit: 72ec82700b502b6b770a9eb04fefad091a1d82b0
Revision on Yggdrasil: https://github.com/JuliaPackaging/Yggdrasil/commit/55777a3d0eecb57e7f1362cef33da805c20c9aa2
Created by: @maleadt

Same as https://github.com/JuliaRegistries/General/pull/38546.


Adjust Key Vault Name Parameter

Message: The Resource 'Microsoft.KeyVault/vaults/kv-ade-jowaddel-prod-eus-001' under resource group 'rg-ade-jowaddel-prod-eus-security' was not found.

Removed use of '-001' from ADE. Issue resolved.


docs: use create and @latest

Use create over init and @latest. I did a quick search over the codebase and could only find one place where it was wrong
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

omg..


chore(create-svelte): bump typescript-eslint to v6

Upgraded SvelteKit templates to typescript-eslint v6.

.eslintrc.cjs has been added to the .eslintignore file.

Parsing error: ESLint was configured to run on <tsconfigRootDir>/.eslintrc.cjs using parserOptions.project: ~
However, that TSConfig does not include this file. Either:

Change ESLint's list of included files to not include this file ⬅
Change that TSConfig to include this file
Create a new TSConfig that includes this file and include it in your parserOptions.project

See the typescript-eslint docs for more info: https://typescript-eslint.io/linting/troubleshooting#i-get-errors-telling-me-eslint-was-configured-to-run--however-that-tsconfig-does-not--none-of-those-tsconfigs-include-this-fileeslint

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Does svelte-eslint-parser support v6?

https://github.com/sveltejs/eslint-plugin-svelte/issues/533

This PR also adds typed linting, which last time I checked did not play well with Svelte's inferred typing.

Does svelte-eslint-parser support v6?
https://github.com/sveltejs/eslint-plugin-svelte/issues/533

That issue has been closed

This PR also adds typed linting, which last time I checked did not play well with Svelte's inferred typing.

Thanks for pointing that out. Let's revert that portion then, which seems like a separate change from the upgrade


Release v0.13

What is the current behavior?
Release with v0.83 collector dependency.
Pull request checklist
Please check if your PR fulfills the following requirements:

[x] Tests(make test) for the changes have been added (for bug fixes / features) and pass
[x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Lint (make lint) has passed locally and any fixes were made for failures

/Applications/Xcode.app/Contents/Developer/usr/bin/make -C generatorreceiver lint
golangci-lint run
make[1]: *** [lint] Killed: 9
make: *** [lint] Error 2

The linter problem was fixed, I'll say. ;)


Record interactions for additional changes

Changes in this PR

Record interations for:

Organisation changes
Contact changes
Support level changes

Sounds good - I'll convert one of the three I've added then ask for another review to make sure I'm on the right track, before doing the rest :)


tour: implementation link is broken

Context: https://tour.golang.org/methods/21
Hey,
it seems that the link in "many implementations" is no longer pointing to valid site
Thanks and have a great day :)
Omer Noah

Thanks for reporting this; closing as a dup of #1140.


from_archive() should return a new 'Collection' class instead of a list.

@barentsen:

...from_archive should return instances of a new LightCurveFileCollection or TargetPixelFileCollection class.  The class would behave exactly like a list (we can subclass a class from the collections module), but have an extra method called plot to quickly plot all the lightcurves or tpfs in a quicklook plot, so the code would look like this:
lcfiles = KeplerLightCurveFile(blabla, radius=blabla)
lcfiles.plot()

This sounds great to me. Much better than a list. We can make sure it has a clear repr and if people try to use methods (e.g. to lightcurve) it provides a clear warning error.
How do we want to index the collection though? It might be nice if we're able to specify the keplerid to get back the right tpf:
tpfc.205189451
tpfc[0]

This begs the question, should cone searches be supported via KeplerLightCurveFileCollection.from_archive() or KeplerLightCurveFile.from_archive().  The advantage of the former is that you always know what from_archive returns, the disadvantage is that it is yet another class that users need to remember and import.

Yeah...it's true. I don't know what the answer is here. Perhaps we need KeplerLightCurveFileCollection.from_archive() and tpf.conesearch?
tpf.conesearch would return a KeplerLightCurveFileCollection

I like KeplerTargetPixelFile.conesearch().  Alternatively, it could be a module-level function (i.e. from lightkurve import keplertpfsearch).  The choice between the two depends on readability and ease of use. I guess the former wins in that regard.

Noting here that if we move the conesearch functionality from from_archive() to conesearch(), we have to update the rolling band tutorial (#113), and possibly other tutorials.

We can close this issue because from_archive has now been deprecated in favor of search_targetpixelfile and search_lightcurvefile, and this new interface supports returning a collection class.
For example: search_targetpixelfile("Kepler-10").download_all() returns a TargetPixelFileCollection object.


Users are able to bypass MFA setup by refreshing page

Description
Two separate users have noted having issues setting up MFA. The issue is that they did not understand the process of setting it up, however, they were able to bypass setting up MFA by clicking "refresh." Users should not be able to bypass setting this up, so we need to figure out the cause and fix it.
Acceptance Criteria

[x] Determine why users are able to bypass MFA when refreshing the page
[x] Implement a fix to prevent this

cc @wrynearson

@frozenhelium, @thenav56, @sunu and @batpad – let's think of ways that we can enforce MFA without blocking/locking out users.

@wrynearson If the ask is to prevent users from bypassing the MFA setup process, we should make MFA mandatory instead of optional in the Cognito settings.

@sunu OK, I'll change this to mandatory. Someone with prod cognito access will have to change this setting on production as well.

Are there any implications to changing this that we can think of?

Apart from users being forced to set up MFA, I can't think of any

@bwbaker1 I just want to double check with you. If we make this field mandatory, then users will have to set up MFA the next time they access APT. They won't be able to do anything until they set up and log in.
You had mentioned that some users are having issues setting up MFA (because they don't have internet access on their cell phones in the building). I just want to double check that we should make this mandatory.

Just fyi, TOTP apps like Google Authenticator, Authy etc work fine without internet - both for settings up new 2FA accounts and generating 2FA codes for already set up accounts.

@wrynearson @sunu I think it is fine to make this mandatory. MFA is required by ESDS, so we need to ensure all users have it. I have prod cognito access, so I'm not concerned with having to reset MFA for someone that gets locked out.
I think we somewhat resolved the issue with users not being able to download MFA software. I've had some conversations with others about this issue, and essentially it is out of our hands if someone can't download MFA. So this isn't a concern.
If this is just a matter of enabling "MFA is required" in cognito, let me know and I can do that.
Thanks for checking into this!

@bwbaker1 yes, I think switching to "MFA required" from "MFA optional" in Cognito should do the trick.

@wrynearson @sunu I ran into an issue with setting MFA as required. I created a new APT account for testing purposes, and was forced to enter a OTP upon my first sign-in, but was not given the MFA setup option (code or qr code).
Looking through this document, I found this:

I don't want to do anything as I'm concerned I will do more damage than good in cognito.

@bwbaker1 this is ready on staging for you to test.

We tried creating multiple new users and never ran into the issue you described.
We think keeping the Cognito MFA setting as "optional" while making it required in APT (though frontend design/functionality) is a better approach, which we've gone ahead and done in this PR, for a few reasons:

Setting the cognito user pool to Required means that users need to have an SMS-based backup if they want to reset their account. From what we understand, this isn't allowed by NASA policy
If we keep the user pool to Optional, if a user needs us to reset their MFA, we can do that on an individual basis in the AWS console.

Sorry @bwbaker1 I got some of those details wrong. We'll actually keep the AWS Cognito pool as required. If we need to reset a user's account/MFA, we can change the pool to optional momentarily and then reset the individual user's account/MFA. We'll need to test this on staging.

@wrynearson This is difficult for me to test because I don't have access to cognito for staging.

Oh right! I'll ping you when this is ready for production and we'll find a way for you to test it.

@wrynearson I was able to test setting up MFA on staging without having my account approved through cognito. It worked as expected and I was unable to bypass setting it up. This is ready for prod.


In UpSampling2D, TypeError: "unsupported operand type(s) for *: 'NoneType' and 'int'"

I am using UpSampling2D with Input height and width "None", since input image is variable size.
I am getting following error :

TypeError: "unsupported operand type(s) for *: 'NoneType' and 'int'"

Below is snippet code, with keras 2.0 and 'channel_last'
    conv4 = Conv2D(64, (3, 3), activation='relu', padding='same')(conv4)
    conv4 = BatchNormalization(axis=-1, momentum=0.99, epsilon=1e-6, center=True, scale=True, beta_initializer='zeros', gamma_initializer='ones')(conv4)
    up1 = UpSampling2D(size=(2, 2))(conv4)

when I debug, found out its coming from call() of UpSampling2D class
1125     def call(self, inputs):
1126         return K.resize_images(inputs, self.size[0], self.size[1],
1127                                self.data_format)

After updating to keras 2.0.6 , issue got resolved


Error: The getter 'completerl' isn't defined for the class '_DefaultBinaryMessenger'

Is there an existing issue for this?

[X] I have searched the existing issues.

Which plugins are affected?
Core
Which platforms are affected?
Web
Description
I'm unable to run a flutter web app after configuring Firebase.
Launching lib/main.dart on Chrome in debug mode...
../../flutter/packages/flutter/lib/src/services/binding.dart:630:9: Error: The getter 'completerl' isn't defined for the class '_DefaultBinaryMessenger'.
 - '_DefaultBinaryMessenger' is from 'package:flutter/src/services/binding.dart' ('../../flutter/packages/flutter/lib/src/services/binding.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'completerl'.
        completerl.complete(reply);
        ^^^^^^^^^^
Failed to compile application.

Exited (1).

main.dart
import 'package:flutter/material.dart';
import 'package:flutter_firebase_web/firebase_options.dart';
import 'package:firebase_core/firebase_core.dart';

void main() async {
  WidgetsFlutterBinding.ensureInitialized();
  await Firebase.initializeApp(options: DefaultFirebaseOptions.currentPlatform);
  runApp(const MyApp());
}

/// The rest of the example flutter counter app

Reproducing the issue

Create a flutter app flutter create --platforms web flutter_firebase_web_test
Install dependencies flutter pub add firebase_core
Configure Firebase flutterfire configure
Initialise Firebase using the DefaultFirebaseOptions in main.dart
Run the app

Firebase Core version
3.4.1
Flutter Version
stable, 3.24.3
Relevant Log Output
Launching lib/main.dart on Chrome in debug mode...
../../flutter/packages/flutter/lib/src/services/binding.dart:630:9: Error: The getter 'completerl' isn't defined for the class '_DefaultBinaryMessenger'.
 - '_DefaultBinaryMessenger' is from 'package:flutter/src/services/binding.dart' ('../../flutter/packages/flutter/lib/src/services/binding.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'completerl'.
        completerl.complete(reply);
        ^^^^^^^^^^
Failed to compile application.

Exited (1).

Flutter dependencies
Dart SDK 3.5.3
Flutter SDK 3.24.3
flutter_firebase_web 1.0.0+1

dependencies:
- cupertino_icons 1.0.8
- firebase_core 3.4.1 [firebase_core_platform_interface firebase_core_web flutter meta]
- flutter 0.0.0 [characters collection material_color_utilities meta vector_math sky_engine]

dev dependencies:
- flutter_lints 4.0.0 [lints]
- flutter_test 0.0.0 [flutter test_api matcher path fake_async clock stack_trace vector_math leak_tracker_flutter_testing async boolean_selector characters collection leak_tracker leak_tracker_testing material_color_utilities meta source_span stream_channel string_scanner term_glyph vm_service]

transitive dependencies:
- async 2.11.0 [collection meta]
- boolean_selector 2.1.1 [source_span string_scanner]
- characters 1.3.0
- clock 1.1.1
- collection 1.18.0
- fake_async 1.3.1 [clock collection]
- firebase_core_platform_interface 5.2.1 [collection flutter flutter_test meta plugin_platform_interface]
- firebase_core_web 2.18.0 [firebase_core_platform_interface flutter flutter_web_plugins meta web]
- flutter_web_plugins 0.0.0 [flutter characters collection material_color_utilities meta vector_math]
- leak_tracker 10.0.5 [clock collection meta path vm_service]
- leak_tracker_flutter_testing 3.0.5 [flutter leak_tracker leak_tracker_testing matcher meta]
- leak_tracker_testing 3.0.1 [leak_tracker matcher meta]
- lints 4.0.0
- matcher 0.12.16+1 [async meta stack_trace term_glyph test_api]
- material_color_utilities 0.11.1 [collection]
- meta 1.15.0
- path 1.9.0
- plugin_platform_interface 2.1.8 [meta]
- sky_engine 0.0.99
- source_span 1.10.0 [collection path term_glyph]
- stack_trace 1.11.1 [path]
- stream_channel 2.1.2 [async]
- string_scanner 1.2.0 [source_span]
- term_glyph 1.2.1
- test_api 0.7.2 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph]
- vector_math 2.1.4
- vm_service 14.2.5
- web 1.0.0

Additional context and comments
No response

This does not seem to be a FF issue. Kindly clear your cache(flutter pub cache clean) and try again. I'll go ahead and close this issue for now.


polyfills!

[ ] fetch https://github.com/github/fetch
[x] mediarecorder https://github.com/ai/audio-recorder-polyfill
[ ] promise https://github.com/taylorhakes/promise-polyfill

Lol I didn't even know what I was getting into with MediaRecorder. This is taken care of (for now..), though not exactly polyfilled per se. More like I twisted the polyfill into something that would work for Safari …


Add scale field to service metadata

There are circumstances where you could wait for a certain number of containers to appear In a service before starting the app. Like zookeeper on initial startup.

Tested with server version - v0.43.0-rc1
Scale field is included to service metadata


[1.18.2] Ruby-Steel Sword stats

With different values in the config, the damage and durability indicators of the Ruby-Steel Sword are similar to the regular Ruby Sword.
I'm using latest version 1.3.39

Values in the config at the moment:

Ruby-Steel simply  adds the unbreakable tag, same stats.

I found the  issue, will be fixed  in next release.


Here is Dave's very important issue

This is a lot of work that needs to be done for pm tutorial. I recommend @annemarieleiby get started on this important work.

@annemarieleiby can get started on this very important work.


Scenario Implementation: Set the chat language

Implements

#48

Subtasks

#52
#50
#51

Closed due to process changes


[feat]  discovery - analytics tracking

Description
We need to add data attribute tracking to the rh-footer. This issue will track on the "discovery" work that Benny agreed to take on as an output of our meeting with SDI on 6/14. In essence there could be a way to modify the current structure calling for click events that's more simplified.
Suggested solution

setup spandx so I [Benny] can test element shadowdom with data-attrs according to Rickey's specifications
potentially modify Wes' scripts so that components don't need to fire custom events

Example API
No response
Additional context
Resources:
Codepen: https://codepen.io/heyMP/pen/oNEmzbr?editors=1011
Demo: https://github.com/heyMP/rh-footer-demo
Docs site: https://ux.redhat.com/components/footer/
Demo blob

@heyMP any other details I missed from our discussion today?

@methomps added a note about possibly deriving categories from regions on our components.

related: https://github.com/searchdiscovery/redhat-datalayer/pull/69


Opam releases

Will the latest releases be published to opam as well?

Not really, I didn't really look into publishing to opam yet, but a PR would definitely be welcome!

@jfrolich i'm pretty new but i'd be happy to take a stab at this!

Hey @gf3, great to see you here. I used secretary in anger back in the day 🙂
These days doing a release to OPAM should be mostly straightforward with dune-release.
Jaap has been tagging releases as he pushes them to NPM, so running dune-release on one of these git tags shouldn't be to hard. Happy to help out along the way

Hey @gf3, great to see you here. I used secretary in anger back in the day slightly_smiling_face

hahaha that feels like a long time ago

These days doing a release to OPAM should be mostly straightforward with dune-release.
Jaap has been tagging releases as he pushes them to NPM, so running dune-release on one of these git tags shouldn't be to hard. Happy to help out along the way

thanks for the heads up, i'll start with dune-release, cheers!

@anmonteiro i've created a PR (above) to make it easier to call dune-release however the project still requires a CHANGELOG.md or CHANGES.md to function properly

It would really be great to have this released on opam, among others so that OCaml folks also have a ppxlib compatible graphql_ppx version! In some projects, they even have to vendor graphql_ppx currently as the latest release isn't ppxlib compatible, e.g. here.
Concerning the CHANGES.md file: for the dune-release publish command, dune-release has an argument called --change-log to pass in a changelog path that's not at the root and/or not called CHANGES.md (such as your documentation/docs/changelog.md). But for simplicity and since graphql_ppx hasn't been released on opam for the last 3 releases, what about the following: you (or if needed, I can do that and open a PR) create a file called CHANGES.md at the root of the project, you copy the entries of sections 1.2.0, 1.1.0 and 1.0.2 from documentation/docs/changelog.md into it (after the 1.2.0 "header"). Then, after opam installing dune-release, you simply checkout the v1.2.0 tag and from within hte project run
dune-release

(since you already have the release tag on github, you don't even need dune-release tag)
If that's your first release with dune-release you'll be prompted some config information such as the url of your opam-repository fork and the path to your opam-repository clone. But apart from that everything else should be done automatically. What do you think @jfrolich?
Btw, thanks for the work you've done to get this released on opam, @gf3!

Btw, aside the obvious advantage of making graphql_ppx available also to OCaml users, there's another advantage if you release this on opam: whenever we bump the ppxlib AST, we'd take graphql_ppx into account and send a patch if we break it with the AST bump.

@pitag-ha Thanks for the detailed comment!
I think it makes sense to keep releasing to opam. Honestly we haven't done it because most folks consume this ppx from NPM, and myself from my own nix overlays.
Starting with a PR for the changelog makes sense. I could probably do the opam releases myself later on.

Thanks @anmonteiro!
By the way, we've been talking a lot about the changelog, but in fact to publish an already existing release on opam, a changelog isn't necessary. You could just use the release tag tarball and run (thanks @kit-ty-kate for that info!):
opam publish -v 1.2.0 https://github.com/reasonml-community/graphql-ppx/archive/refs/tags/v1.2.0.tar.gz

or, with dune-release, I think (if v1.2.0 is checked out)
dune-release opam pkg --dist-url https://github.com/reasonml-community/graphql-ppx/archive/refs/tags/v1.2.0.tar.gz
dune-release opam submit

should do.
Does that sound good to you? That being said, I can still open a PR for the changelog so that you can use dune-release for the whole release process in the future, in particular to also have a release with release notes on github, if you want.

About the question if to use opam publish or dune-release: When doing a whole release with dune-release, dune-release is usually quite easy to use. But in this concrete situation, opam publish is the easier choice. But, also in this situation, dune-release follows better practices, in particular it adds a hash of the release tarball to the release meta data (that's also why you need to hand a release tarball path in  via the --dist-file argument, when running dune-release opam pkg without having run dune-release distrib before). Adding the hash is a good practice so that opam can verify the tarball when installing the package.

About the question if to use opam publish or dune-release: When doing a whole release with dune-release, dune-release is usually quite easy to use. But in this concrete situation, opam publish is the easier choice. But, also in this situation, dune-release follows better practices, in particular it adds a hash of the release tarball to the release meta data (that's also why you need to hand a release tarball path in via the --dist-file argument, when running dune-release opam pkg without having run dune-release distrib before). Adding the hash is a good practice so that opam can verify the tarball when installing the package.

I’m not sure to follow your distinction. Both add a hash of the tarball, the only difference in that respect is that by default (so when calling dune-release without arguments, not our case here) dune-release generates its own tarball and uploads it to github.
opam-publish on the other hand simply takes the tarball given as arguments or the one generated by github if no argument is given.

Both add a hash of the tarball

Yes, you're absolutely right. Thanks! I mixed things up with the commit hash which is only added by dune-release, but not by opam publish (correct me if I'm wrong again). dune-release adds it since that's helpful for vendoring tools.

@anmonteiro, do you want me to try opam publish?

I just opened https://github.com/ocaml/opam-repository/pull/19154 to get it started (with 1.2.2 released yesterday), if anyone needs help for releasing next time please ping me on Discord or wherever

I’m unavailable until the end of next week, without access to a computer. Will check in then.

Merged. This issue can now be closed. Can someone return the fixes I've made to the opam file in the master branch?

@kit-ty-kate: can you make a PR? Much appreciated!

most folks consume this ppx from NPM, and myself from my own nix overlays.

@anmonteiro No need for a Nix overlay, the package is already available in ocamlPackages (see https://search.nixos.org/packages?channel=unstable&from=0&size=50&sort=relevance&query=graphql_ppx). Current packaged version is 1.2.0 but feel free to open a PR bumping it to 1.2.2 if you need it.


Display Default label for filter in My Filters

fixing https://bugzilla.redhat.com/show_bug.cgi?id=1383682
Display Default label for filter set in My Filters as default right
after adding another filter, not just after refresh,
in Filters bar in Compute -> Infrastructure -> Providers.
Before adding a new filter:

After adding a new filter (originally):

After adding a new filter (new, fixed):

@miq-bot add_label bug, ui

cc @mzazrivec

Actually, I found that the same bug is also in Compute -> Clouds -> Providers, and who knows where else..  I will investigate it.

Euwe Backport details:
$ git log -1
commit 80afa9b5a7e83bfb1f94bf0159b9abc822c5b409
Author: Milan Zázrivec<EMAIL_ADDRESS>Date:   Mon Oct 31 18:24:21 2016 +0100

    Merge pull request #12163 from hstastna/Default_label_after_adding_new_filter

    Display Default label for filter in My Filters
    (cherry picked from commit bff813d3ebd1530fdbd5f72bce15a5f98b0dc128)

    https://bugzilla.redhat.com/show_bug.cgi?id=1383682

@simaishi Please make Euwe BZ for https://bugzilla.redhat.com/show_bug.cgi?id=1383682

Euwe BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1393025


(d* DB).Append(key, value []byte)

It would be really great if there would be an (atomic) Append() method.
I know that I can work around this using Get() and Put() (and additional synchronization), but an atomic Append() - maybe even with a WriteOption CreateIfMissing true/false - would be very, very helpful.

+1

+1


Canonical header (routes.canonical) works like alias (but in reverse)

Using routes.canonical on pages header (http://learn.getgrav.org/content/headers#routes) causes a problem.
If you have a page whose slug is for example: example-page and another page with slug another-example-page. Now you add canonical header tag for a another-example-page like this:
slug: another-example-page
routes:
    canonical: '/example-page'

If you now go to url http://yoursite/example-page Grav shows content from another-example-page, and gives it canonical link <link rel="canonical" href="http://yoursite/example-page" />. However, in this situation it should give this canonical link only for a another-example-page, and do nothing for example-page.
Is this a bug or am I understood something wrong?

Your providing an example with an intentional conflict.  if there are pages with the same routes, then the first one grav comes to will be used.  The pages are added to Grav in order they are discovered as they are traversed recursively through the filesystem.  As pages are found, all aliases, canonical, and default routes are added to the routes table with a reference to the page in question.
So when a particular route is passed via the URL, the routes table is searched in order until a match is found.  When a page is found, if a canonical link is explicitly defined, it will use that rather than the default route to render the canonical link.
Your example makes sense in this case.
Really the only solution to your problem is to ensure you don't have a route conflict like this.


support more file types

Hi,
great project, working pretty smoothly for me!
Here's a small PR to check for supported file types more verbosely:

support AV1
support 3gp
support wmv
support mkv properly (video/x-matroska not working for me, canPlayType returns an empty string)

With those changes I can even play H265 files with latest https://thorium.rocks/ browser (release with H265 support released soon).
I got the respective codec information from https://tools.woolyss.com/html5-audio-video-tester/
Thanks and have a nice week
midzer

Your proposed types look good. Will definetely try them once they're in main branch.
Should I update my PR or do you commit?


Fix census plugin initialization for census filters.

LGTM - please add the 'ready to merge' tag when this is green, and someone will come through and merge it

One failing test?

I think the test is flaky. Is it any way to re-run the tests?


Update import paths for @apollo dependencies

Not all types are exported from @apollo/client. So instead of using that for all imports, I've updated the imports to point to the correct location.

Thanks @koenpunt ! I'll review it (and the other PR) soon
We are thinking a lot how to do that, since we need to make sure to have good support for Apollo 3, generate modern code (hooks) and disable old methods (HOC/components), without making it too difficult for developers to do.

Thanks @koenpunt , I opened a PR with all changes required to have complete support (and deprecated all old ones).
We'll make it available soon as v2 of that plugin: https://github.com/dotansimha/graphql-code-generator/pull/4487


Adding Scottish Bankrupt Officer Search Endpoints

Adding two endpoints for bankrupt officer search:

Search for Scottish bankrupt officers
Search for a Scottish bankrupt officer by ID(Ephemeral ID).

Do we need to make Sonar Code Analysis succeed first? @daisysanson & @toriwilliamsch ?

Do we need to make Sonar Code Analysis succeed first? @daisysanson & @toriwilliamsch ?

Do we need to make Sonar Code Analysis succeed first? @daisysanson & @toriwilliamsch ?

There's an error at the moment with Sonar due to an upgrade where it doesn't analyse the test coverage correctly. I've in a meeting later around this but will let you know if someone is fixing this issue

Do we need to make Sonar Code Analysis succeed first? @daisysanson & @toriwilliamsch ?

There's an error at the moment with Sonar due to an upgrade where it doesn't analyse the test coverage correctly. I've in a meeting later around this but will let you know if someone is fixing this issue


Spelling and formatting fixes.

Noticed some spelling and formatting issues while I was poking around.

This change is

:shipit:


Support vi linewise region causes: unhandled ZLE widget

With the latest commit (https://github.com/zsh-users/zsh-syntax-highlighting/commit/d13da0cf00d5324a041c4dce04ccce06b3daa3ac) on master, I started seeing the following errors:
zsh-syntax-highlighting: unhandled ZLE widget 'history-substring-search-up'
zsh-syntax-highlighting: unhandled ZLE widget 'history-substring-search-down'

Looking at the commit I don't see anything obvious, but checking out the previous makes the error disappear.

Could you please show the output of print -r -- $ZSH_VERSION $ZSH_PATCHLEVEL ${widgets[history-substring-search-up]} ${widgets[history-substring-search-down]}?  Can you bisect your zshrc to the smallest one that reproduces the problem?  Do you use bindkey -v or bindkey -e?

Crossreferencing #267 which that commit (d13da0c) fixed.

The error message is printed by _zsh_highlight_bind_widgets, which once at the start, before the the function that d13da0c touches is invoked for the first time (and isn't invoked again subsequently). Odd...

is this history-substring-search-up a standard zle widget or is it comming from another plugin?

I only see the error once when my .zshrc is loaded, and whilst trying to create a minimum repro it seems that it only happens when bindkey references history-substring-search-* before the plugin is loaded.
Here's the output @danielshahaf:
5.2 zsh-5.2-0-gc86c20a user:history-substring-search-up user:history-substring-search-down

Minimum repro:
zmodload zsh/terminfo
bindkey $terminfo[kcuu1] history-substring-search-up
bindkey $terminfo[kcud1] history-substring-search-down

source $ZSH/modules/zsh-syntax-highlighting/zsh-syntax-highlighting.zsh
source $ZSH/modules/zsh-history-substring-search/zsh-history-substring-search.zsh

Of course, moving the bindkey statements after the sourceing makes the error disappear. As per zsh-history-substring-search#usage it should be sourced after zsh-syntax-highlighting, which is why the order is as it is above. I suppose https://github.com/zsh-users/zsh-syntax-highlighting/commit/d13da0cf00d5324a041c4dce04ccce06b3daa3ac caused bindkey widgets to be evaluated at an earlier phase?

Thanks for the minimal reproduction.  I can reproduce that error message with just:
% zmodload zsh/terminfo
% bindkey $terminfo[kcuu1] history-substring-search-up
% source zsh-syntax-highlighting.zsh
zsh-syntax-highlighting: unhandled ZLE widget 'history-substring-search-up'

However, unlike you, I can reproduce it both with d13da0c and with its predecessor b9112ae.
I'm afraid that's working as designed: z-sy-h currently works by rebinding all widgets.  When it encounters an undefined widget, it can't wrap that widget, so it warns.  (Consequently, invoking that widget — in this case, pressing ↑ or ↓ — will not recompute highlighting.)
As to a workaround, moving the bindkeys below the source zsh-syntax-highlighting.zsh line (as you wrote) is probably the right thing: that will sidestep the warning, and shouldn't affect the interaction of z-sy-h and z-h-s-s in any way.  In the longer term, this is the kind of issue that should be entirely prevented by the fix to #245 (expected to be available in z-sy-h 0.5.0 under zsh 5.3)... except that z-h-s-s violates layering (https://github.com/zsh-users/zsh-history-substring-search/issues/58) so I am not going to try and guess how z-h-s-s would interact with z-sy-h-post-#245.

I suppose d13da0c caused bindkey widgets to be evaluated at an earlier phase?

No, it didn't.  _zsh_highlight_bind_widgets runs once at the time of the source zsh-syntax-highlighting.zsh; _zsh_highlight runs at every keypress.  d13da0c simply changed the computation of the start and end offsets of the region highlighting.
I can't think of any reason your reproduction script would behave differently with d13da0c compared to b9112ae (its predecessor).

Testing again it seems that https://github.com/zsh-users/zsh-syntax-highlighting/commit/b9112aec798a41035d044d4f93d7cfa50c9ca580 is actually the offending commit, if I rebase without it, the error goes away. I could've sworn I tested with it before opening up this issue, sorry about that.
Anyway, thanks for looking in to this, I'll probably just settle for moving my bindkey statements.

Testing again it seems that b9112ae is actually the offending commit, if I rebase without it, the error goes away.

/cc @m0vie
I'm not sure whether this difference between zle -la and ${(k)widgets} is intentional; might be worth asking zsh upstream.
Thanks for reporting this.

I'm not sure whether this difference between zle -la and ${(k)widgets} is intentional; might be worth asking zsh upstream.

Done: users/21729

Upstream says this difference is intentional.
I suppose this may affect other configurations / widgets, but for the reasons given above, I think warning here is appropriate...  so I'm closing this, but we can revisit this in the future if it turns out to have wider repercussions.  Thanks again for the report!

Sounds good, thanks for investigating!


Podman not working after upgrading to 23.11 (sd-bus not found)

Describe the bug
After upgrading nixpkgs from 23.05 to 23.11, podman is no longer working. After rolling back to 23.05, it works again.
I tried rebooting and podman system reset, which did not fix the issue.
Steps To Reproduce

Have podman setup on 23.05.
Upgrade to 23.11.
Try to run podman container.
Get error about sd-bus not found.

Expected behavior
I expect podman to work on 23.11.
Additional context
NixOS is running in Proxmox LXC containers, and I'm deploying them using colmena.
Relevant pieces of my config:
imports = [ (modulesPath + "/virtualisation/proxmox-lxc.nix") ];

virtualisation = {
  podman = {
    enable = true;
    extraPackages = with pkgs; [ zfs ];
    autoPrune = { enable = true; };
  };
};

Console output:
[root@esphome:~]# podman run hello-world
✔ docker.io/library/hello-world:latest
Trying to pull docker.io/library/hello-world:latest...
Getting image source signatures
Copying blob 719385e32844 done   |
Copying config 9c7a54a9a4 done   |
Writing manifest to image destination
Error: crun: cannot open sd-bus: No such file or directory: OCI runtime attempted to invoke a command that was not found

Notify maintainers
@marsam
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.2.16-19-pve, Debian GNU/Linux, 11 (bullseye), nobuild`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"nixos-23.11"`
 - nixpkgs: `/nix/store/19kjl5p3hx3l51yfnii653a3qzm4l6hf-source`

(Note: this was run on my deployment machine for colmena, not the machine with the issue)
Priorities
Add a :+1: reaction to issues you find important.

Seems like this is a bug in crun v1.11 affecting nested containers. Upgrading to v1.12 fixes the issue.
containers/crun#1355
Relevant config (using niv):
  nixpkgs2305 = import sources."nixpkgs-23.05" { };
  nixpkgs2311 = import sources."nixpkgs-23.11" {
    overlays = [ (final: prev: { crun = nixpkgsUnstable.crun; }) ];
  };