BUG-'dark_mode' parameter not working

Description
The problem arises when trying to change the theme with the 'dark_mode' parameter of Gui().run(). The property doesn't seem to affect the theme of the client.
How to reproduce
Open an incognito tab to not have a default browser theme.
from taipy import Gui

Gui('# This is dark theme').run(dark_mode=False)

Expected behavior
We should be able to select the theme with the dark_mode parameter of Gui().run() and see the correct result on the client.
** Proposal **

if the theme toggle is not present on the page, the theme is the one set by the backend (ignore local storage).
if the theme toggle is present on the page, the theme is the one stored in the browser (persistent local storage) with default to the backend value.

proposal:

if theme toggle is not present in the page, the theme is the one set by the backend (ignore local storage)
if theme toggle is present in the page, the theme is the one stored in the browser (persistent local storage) with default to the backend value


Type generation no longer works with yarn PnP since 0.2.7

Describe the bug
We are using the @module-federation/enhanced/webpack plugin with type generation in a project using yarn PnP. And starting with version 0.2.7 the type generation throws an error. The error message provides the command that fails in the format npx tsc --project path/to/config.json and this command will succeed when run as yarn tsc ... but fails to resolve dependencies when run with npx
When the yarn nodeLinker is set to use pnpm this is not an issue so that's why I believe it's a PnP compatibility issue
Reproduction
https://github.com/jaredchamberlain/mf-types-pnp
Used Package Manager
yarn
System Info
System:
    OS: macOS 14.7
    CPU: (12) arm64 Apple M3 Pro
    Memory: 590.66 MB / 36.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.12.2 - ~/.nvm/versions/node/v20.12.2/bin/node
    Yarn: 4.4.0 - ~/.nvm/versions/node/v20.12.2/bin/yarn
    npm: 10.5.0 - ~/.nvm/versions/node/v20.12.2/bin/npm
    pnpm: 9.12.2 - ~/.nvm/versions/node/v20.12.2/bin/pnpm
  Browsers:
    Chrome: 130.0.6723.116
    Safari: 18.1

Validations

[X] Read the docs.
[X] Read the common issues list.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Module federation issue and not a framework-specific issue.
[X] The provided reproduction is a minimal reproducible example of the bug.

Send a PR if you find the issue - we dont use pnp and wouldnt know. what to look at


Refactor vertical navigation examples

fixes #58

Pull Request Test Coverage Report for Build 481

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 77.256%

Totals

Change from base Build 474:
0.0%

Covered Lines:
331

Relevant Lines:
416

💛  - Coveralls


Documentation is out of date

The supplied documentation for submitting to S3 does not reflect that of the S3 module.
i.e. init:
The documented:
S3(         accessKey: "my-key",          secretKey: "my-secret",          region: "my-region",          bucket: "my-s3-bucket")
The actual:
 S3(host: "foo",               accessKey: "bar",               secretKey: "bar",               region: .usWest2)
i.e. upload:
The documented:
.uploadFile("/path/to/local/file", "/folder/in/s3/bucket")
The actual:
upload(bytes: [UInt8(1)],             path: "f",             access: .authenticatedRead)

at the risk of asking a dumb question here...what should the value of "host" be in S3(host: "foo", accessKey....) ?


Cannot find -lGL

I am getting the following error
gcc /home/user/client-samples-gluon-mvn/Maven/HelloFX/target/client/x86_64-linux/gvm/hellofx/launcher.o /home/user/client-samples-gluon-mvn/Maven/HelloFX/target/client/x86_64-linux/gvm/tmp/SVM-1582218774277/hellofx.hellofx.o -Wl,-Bstatic -ljava -lnio -lzip -lnet -lprefs -ljvm -lstrictmath -lj2pkcs11 -lsunec -lextnet -llibchelper -Wl,-Bdynamic -lz -ldl -lstdc++ -lpthread -rdynamic -Wl,--whole-archive -lprism_es2 -lglass -lglassgtk3 -ljavafx_font -ljavafx_font_freetype -ljavafx_font_pango -ljavafx_iio -Wl,--no-whole-archive -lGL -lX11 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lfreetype -lpangoft2-1.0 -lgthread-2.0 -lstdc++ -lz -lXtst -o /home/user/client-samples-gluon-mvn/Maven/HelloFX/target/client/x86_64-linux/hellofx -L/home/user/Development/graalvm/graalvm-ce-java11-20.0.0/lib/svm/clibraries/linux-amd64 -L/home/user/Development/graalvm/graalvm-ce-java11-20.0.0/lib -L/home/user/.gluon/substrate/javafxStaticSdk/14-ea+gvm6/linux-x86_64/sdk/lib /usr/bin/x86_64-linux-gnu-ld: cannot find -lGL
I was able to javafx:compile and client:link to work following the steps given gluon client page.
A few days ago I tried this on windows using Windows subsystem for linux - ubuntu 16.0.4, that gave this same error. That time I tried the following and none of this worked.

sudo apt-get install libgl    did not work
sudo apt-get install libgl1-mesa-glx    did not work
sudo apt-get install cmake libx11-dev xorg-dev libglu1-mesa-dev freeglut3-dev libglew1.5 libglew1.5-dev libglu1-mesa libglu1-mesa-dev libgl1-mesa-glx libgl1-mesa-dev libglfw3-dev libglfw3 did not work; taking reference from some comment in - https://medium.com/@theorose49/install-opengl-at-ubuntu-18-04-lts-31f368d0b14e & https://github.com/gluonhq/client-gradle-plugin/issues/57
sudo apt-get install libglfw3-dev libgles2-mesa-dev gcc glfw_triangle.c -lGLESv2 -lglfw this also not worked

Using the above steps I was able to run the link maven target, but the resultant binary would not run saying it cannot find a suitable pipeline, neither es2 nor sw.
I have very old laptop upgraded over time. The graphics card is now not supported. But if javafx is able to run on java as it is, it should be able to run after compilation from graalvm also, is my logic. And at any case it should be able to fallback to sw.
This time i tried using a virtual machine with kubuntu 16.0.4 and I am getting the same error.
I just don't want to install incorrect libraries and make things messy. So before I try different solutions I wanted to take advice/help/tips from experts.
Once this works, will switch to the other custom graal version which builds for android. Right now testing for linux first.
Thank you

You can add
<enableSWRendering>true</enableSWRendering>

to the plugin. Then try again?

You can add
<enableSWRendering>true</enableSWRendering>

to the plugin. Then try again?

So I tried what I understood and it did not work.
I have 2 questions

Where to put this <enableSWRendering>true</enableSWRendering> ?

    <properties>
        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
        <maven.compiler.source>11</maven.compiler.source>
        <maven.compiler.target>11</maven.compiler.target>
        <javafx.version>13.0.1</javafx.version>
        <client.plugin.version>0.1.14</client.plugin.version>
        <mainClassName>hellofx.HelloFX</mainClassName>
	<enableSWRendering>true</enableSWRendering>
    </properties>

**After putting this flag, do I need to just run the mvn client:link or mvn client:compile also ** ?

In the meantime I am trying different permutations of this to see if it works.
Thanks

Add "to the plugin" means:
           <plugin>
                <groupId>com.gluonhq</groupId>
                <artifactId>client-maven-plugin</artifactId>
                <version>0.1.15</version>
                <configuration>
                      ...
                      <enableSWRendering>true</enableSWRendering>
                </configuration>
            </plugin>

Add "to the plugin" means:
           <plugin>
                <groupId>com.gluonhq</groupId>
                <artifactId>client-maven-plugin</artifactId>
                <version>0.1.15</version>
                <configuration>
                      ...
                      <enableSWRendering>true</enableSWRendering>
                </configuration>
            </plugin>

Thank you it worked, recompiled and linked, it took a lot of time, but it worked. Around 60MB build for HelloFX sample.
While it was compiling I recollected that last time when I tried this, although I compiled it on this old laptop, I tried to run it in a more recent hardware which had a ubuntu and centos both, supporting opengl es 3 ( whereas javafx's requirements are met with version 2 itself if I am not wrong). Even in that case it did not run on either, giving the error that it could not find suitable pipeline. It gave other errors also, like it complained of some libraries being missing etc. I guess I will look into that when I have time. If I face this issue again, I will create another ticket.
Thank you again.


tests: Disable Sync.FenceWaitHang

It started failing in CI with no obvious explanation.

CI CrashDiagnosticLayer build queued with queue ID 287844.

CI CrashDiagnosticLayer build # 280 running.

CI CrashDiagnosticLayer build # 280 passed.

CI CrashDiagnosticLayer build # 281 running.

CI CrashDiagnosticLayer build # 281 passed.


HDDS-2629. Ozone CLI: CreationTime/modifyTime of volume/bucket/key in…

…fo are not formatted.
What changes were proposed in this pull request?
Format JSON output of volume/bucket/key info properly in a readable format.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2629
How was this patch tested?
unit test and run ozone CLI in docker-compose and validate the output like below
`bash-4.2$ ozone sh vol info /vol1
{
"metadata" : { },
"name" : "vol1",
"admin" : "hadoop",
"owner" : "hadoop",
"creationTime" : "2019-11-27T06:08:15.546Z",
"acls" : [ {
"type" : "USER",
"name" : "hadoop",
"aclScope" : "ACCESS",
"aclList" : [ "ALL" ]
}, {
"type" : "GROUP",
"name" : "users",
"aclScope" : "ACCESS",
"aclList" : [ "ALL" ]
} ],
"quota" :<PHONE_NUMBER>606846976
}
bash-4.2$ ozone sh bucket info /vol1/bucket1
{
"metadata" : { },
"volumeName" : "vol1",
"name" : "bucket1",
"storageType" : "DISK",
"versioning" : false,
"creationTime" : "2019-11-27T06:08:21.148Z",
"encryptionKeyName" : null
}
bash-4.2$ ozone sh key info /vol1/bucket1/key1
{
"volumeName" : "vol1",
"bucketName" : "bucket1",
"name" : "key1",
"dataSize" : 3813,
"creationTime" : "2019-11-27T06:08:33.206Z",
"modificationTime" : "2019-11-27T06:08:35.558Z",
"replicationType" : "RATIS",
"replicationFactor" : 3,
"ozoneKeyLocations" : [ {
"containerID" : 1,
"localID" :<PHONE_NUMBER>70754304,
"length" : 3813,
"offset" : 0
} ],
"metadata" : { },
"fileEncryptionInfo" : null
}
`

Thanks @xiaoyuyao for updating the patch.

@adoroszlai  Thanks for the review. @xiaoyuyao  Thanks for the contribution. I have committed this patch to the master branch.


Added two search functions to assist with locating npc stations.

Added two new search functions and included the generic venv directory in the gitignore file.

Thanks for your PR! Please use ESIClient for sending requests to ESI if possible. Also please use logging module to replace any print.


Some items not shown in multiselect

I have a really weird issue with select_multiple.
Consider this snippet:
colored_options = [
        '1',
        '2',
        '3',
        '4',
        '5',
        '6',
        '7',
        '8']

print(colored_options)
print(len(colored_options))
select_multiple(colored_options)

In container A, in a python vscode terminal, everything works as expected:

In another container, in a bash terminal, I only ever see 5 items:

Why is the bash terminal only showing 5 items?
How can I debug this?

Version:
3.3.0
Working container OS:
NAME="Red Hat Enterprise Linux Server"
VERSION="7.9 (Maipo)"

Not working container OS:
PRETTY_NAME="Debian GNU/Linux 11 (bullseye)"
NAME="Debian GNU/Linux"

Could you please verify it's not 3.5.0 on the Debian? In 3.5.0 I have been making changes that could have introduced this bug.
Sorry, I am not at the computer atm so I can't verify.

Thanks for correction. Fix should be reasonably easy, I'll release 3.5.1 fixing this later today.

It is working again, thank you for your fast support!

That's great to hear!

I think there is a followup error on this:
I have a list with 11 entries, but with the up and down keys I can only navigate to the fifth element. Pressing down from there then goes back up to the first entry.
Since this happens to the fifth element, I guess this error is related to the other issue.

You are correct. I will be taking a look momentarily

Should be fixed, I am waiting for CI and then I'll merge and release. Note to self: I should really start doing beta releases :sweat_smile:

Okay, released as version 3.5.2, please see the GitHub Releases or PyPI

Thx, it is working.


Message persistence on demand

I don't want to get into a war between Whatsapp vs. Signal vs. Telegram vs. Slack vs... but who gets all their contacts on the same tool? I don't want to create an account on all these platforms to be able to communicate with everyone. And what if I want to create a temporary group with clients for example. Do they all have to create an account on a common tool for a few months?
To my knowledge, there is no chatroom yet that

does not require an account or phone number,
which is easily shared via a link,
whose messages are e2e encrypted,
which displays desktop notifications,
which is open source may be installed on multiple servers,
which allows you to retrieve messages that were sent while he was away because I'm not always in front of my computer when one of my contacts wants to talk to me.

With such a solution, I no longer need to make a choice. Not to mention the fact that I have to install a utility or that uses the phone number or the email. Yes I know my issue looks like that but eh, we are developers ;-)
In order for Darkwire to answer all these points, the last point is mainly missing, i.e. the possibility to receive the messages that were sent during my absence. I don't want to keep an ad vitam history of the messages, but just the last messages I didn't receive (within a month for example).
The idea is not to put an end to the ephemeral aspect of this chat but to complete it with a slightly longer term use. As long as you use it regularly, it stays alive. Messages are erased as they get older and if nobody uses the room for a while, it is totally deleted. This would be an option to be activated by the owner of the room if needed.
To meet this need I propose 3 technical solutions:
Option 1
The first idea is to use symmetrical AES-type encryption to encrypt messages. When you choose to enable persistence, a hash is added to the URL containing a passphrase to encrypt and decrypt messages. Each time a message is sent, it is stored encrypted in the store on the backend side and the messages are all sent back to each user who logs in. Only users with the correct hash in the url will be able to decrypt the messages.
Pros

Simple to implement
You have the URL, you have the history that goes with it.

Cons

The security of symmetrical encryption is significantly lower than asymmetrical encryption. The user should be warned that when he makes this choice, he decreases his security level compared to symmetrical encryption.

Option 2
With this option, the server keeps a list of users who logged in with their public key. When someone logs in, they receive a list of all users, even those who are not logged in anymore for this room. Each message are sent to the server encrypted with the public key of each recipients, like now, but messages whose recipient is not logged in are kept on the server until the user concerned logs in or until the message expires.
Pros

Maintains the same level of security
Easier to implement

Cons

Risk of keeping a lot of unnecessary messages if some users were only present at one time.
The history cannot be retrieved before a user's first connection since messages were not transmitted to him. We can imagine a fallback based on the re-transmission of the owner's messages in this case.

Option 3
This time, the first user in a room creates two encryption key pairs at the first connection. One for him as usual and one for messages. Then, for each user who logs in, the room owner sends the key messages encrypted with the user's public key (like a normal message in fact). The difference is that each time a message is sent, it is encrypted with the public key of the message and is sent only once. The message history is therefore kept only once on the server side and the encryption method remains asymmetrical. We can even imagine that is the default way of exchanging messages.
Pros

Same level of security as today (maybe even better? because the same message is encrypted only once which could limit statistical attacks from a compromised server? I don't know).
No extra storage cost depending on the number of users

Cons

Intermediate complexity
It is mandatory that a user with the message key must be present so that a new person can connect, but we can imagine to put this new user on hold while waiting for an owner with the message key.

What do you think? Did I miss an option?

@alanfriedman @seripap do you have any preference about the options ?

If we were to add any persistence, i'd probably go option #1 and use the current redis implementation.
I would be hesitant on implementing any other type of long term persistence that requires another database.

I don't think there is a difference about the way data are stored server side, I think all three options can use the redis implementation. May be I'm missing something ?

chat data isn't stored in the current implementation. the server acts like a mailman, sending data between clients. all messages are encrypted on the client then transmitted via server to clients that are currently connected in the room. any new user that enters, the previous message would not exist as the only trace of the message is on previously connected clients.

And that's exactly the purpose of this ticket, adding a persistence server side on demand. I mean, in my previous message, that all three future implementations can use the same data store for the new persistence functionality, i.e. Redis


Don't trim whitespace in markdown-files

Trailing whitespace is a linebreaks in MD, so shouldn't be stripped by accident

Coverage remained the same at 98.86% when pulling b0442d7229e97d957174af55b76271a071fcd97a on SimenB:patch-1 into 28ba35b23ca70a767f7e03fbb9e56617f74203a4 on jscs-dev:master.


Ez recover errors

Pull request to add recoverability to kinesis connector
I also modified the logger interface so that the module has a logger instead of each individual structure, and then initialize the module's logger.  This makes it easier to provide your own logger object since you only have to initialize it once in the module, and prevents panics when the user does not initialize the logger.
Let me know what you think.

I also modified the logger interface so that the module has a logger instead of each individual structure, and then initialize the module's logger. This makes it easier to provide your own logger object since you only have to initialize it once in the module, and prevents panics when the user does not initialize the logger.

Much better. I like it :+1:
Would you mind squashing down the tiny commits into one commit? I can do it in this branch too before I merge in if thats easier.

Ya, I should have squashed it, sorry.  I can do it, but probably not until next week. If you'd rather get it out sooner, you can do it in the merge, up to you.
—
Sent from Mailbox
On Sat, May 16, 2015 at 9:26 AM, Harlow Ward<EMAIL_ADDRESS>wrote:

I also modified the logger interface so that the module has a logger instead of each individual structure, and then initialize the module's logger. This makes it easier to provide your own logger object since you only have to initialize it once in the module, and prevents panics when the user does not initialize the logger.
Much better. I like it :+1:
Would you mind squashing down the tiny commits into one commit? I can do it in this branch too before I merge in if thats easier.

Reply to this email directly or view it on GitHub:
https://github.com/harlow/kinesis-connectors/pull/12#issuecomment-102647231

Ya, I should have squashed it, sorry.  I can do it, but probably not until next week. If you'd rather get it out sooner, you can do it in the merge, up to you.

Sounds good. No rush. Will give me a chance to test it over the weekend too.

Sorry, didn't mean to close this. Was trying to rebase it into a few focused commits but its not going so well.

@superbaddude could you re-open to master and we'll get this merged in.


Add Meter spaces

If you want to create a space follow this guide
https://docs.snapshot.page/guides/create-a-space
Added spaces for eMTRG (on Ethereum) and MTRG (on Meter main net)

We have made a major update. You should now use ENS and IPFS method to create your space. Here is the guide: https://docs.snapshot.page/guides/create-a-space. I'm closing this PR for now, you will need to open a new one to add your space images. Thank you.
For further help please ask in the #helpdesk Discord channel.

Our submission includes one space for Meter mainnet.  It was not clear how to do it in the ENS approach based on the docs and even it is possible at all.


fix: repeated caching of missing users

When a trainee ID is not found in the existing cache, a lookup is performed on the Cognito user pool and all users are re-cached. As there can be a large number of person records without Cognito accounts it can lead to attempts to constant re-cache the user pool over and over.
The queue listener should be disabled during caching to ensure that no overlapping cache calls can be made from parallel messages.
A fifteen minute window should be added after each full cache operation, during which no re-caching will occur. This will help reduce demand on the Cognito API when processing large numbers of contact detail changes. The fifteen minutes is fairly arbitrary and may need tweaking, until a longer term solution can be put in place.
TIS21-5907
TIS21-5958

Looks good, though without a proper local Cognito for testing, I guess we just have to give it a go 👿

I usually hook in to preprod for that 😅


Fix #1272 Reset navbar count for clear logs action

This is a 2.0 fix but this commit is on the master branch.  If you want me to put it someplace else please let me know.

You can update this PR to point to the 2.0 branch by following these steps:

Select "Edit" on this pull request and select the 2.0 branch from the "base" dropdown,
Then run the following locally:

# ensure your remotes are up-to-date
git remote update --prune
# checkout your branch locally
# (these instructions assume "origin" points to github.com/hkeebler/accumulo
#  and assume "upstream" points to github.com/apache/accumulo)
git checkout -t origin/accumulo-1272
# reset the local branch to the 2.0 base
git reset --hard upstream/2.0
# grab the commit from the head of the feature branch and put it onto the new 2.0 base
git cherry-pick origin/accumulo-1272
# force-push to clobber your feature branch (and update the PR)
# this will test; remove "--dry-run" to actually execute
git push -f --dry-run

okay, I think i did this as requested.  thank you.


[CP Stag] Fix lodashGet usage

Details

Bug came from this PR: https://github.com/Expensify/App/pull/9560 - looks like we didn't test all of the usages of lodashGet before merging
Fixed Issues
$ https://github.com/Expensify/App/issues/10042
Tests

Go to a report with multiple previous messages
Verify the old date & times are accurate (they shouldn't all say "Today at" anymore)
Send a new message, verify the timestamp on that message is displayed accurately
Wait a few minutes, refresh the page, verify the timestamps are still all accurate

[x] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps

Go to a report with multiple previous messages
Verify the old date & times are accurate (they shouldn't all say "Today at" anymore)
Send a new message, verify the timestamp on that message is displayed accurately
Wait a few minutes, refresh the page, verify the timestamps are still all accurate

[ ] Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Woohoo, thanks @vitHoracek ! FYI I just added screenshots of all platforms except mweb

🚀 Cherry-picked to staging by @mountiny in version: 1.1.85-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

This is still happening, tested in staging with the credentials<EMAIL_ADDRESS>/ Feya87Katya
https://github.com/Expensify/App/issues/10046#issuecomment-1191817261

@aldo-expensify Bug is still reproducible.
https://user-images.githubusercontent.com/43996225/180324684-fd157ffb-dffe-4e0f-ad25-0906c9f7b216.mp4

@kavimuru I just logged in with that account and the date & time look fine not 🤔

@Beamanator from the investigation Aldo did it is possible it gets fixed when we update the timezone with the correct format. You can either do it manually or I think there are a couple of events which trigger it and then it is updated based on IP.

The timezone of the accounts have been fixed, there shouldn't be anything else to do now ;)

Thanks Aldo!

🚀 Deployed to production by @luacmartins in version: 1.1.85-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


some random issue with a randon library called uhh cyclic xor string

what

I'm sorry for your issue, but could you open an issue where you provide more details?
Be sure to provide a MCVE. Thanks!

Install the package from source. That fixed it for me.


How to install OS specific version of chrome / puppeteer with package.json?

Im running puppeteer on OSX but would like install chromium version of linux.
Since im going to run it on linux and need this OS version.
It is possible to specify the chromium version for linux with the package.json somehow?
    "puppeteer": "^0.13.0",

Installs only for current OS which is OSX

maybe you can use BrowserFetcher ?https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#class-browserfetcher

@aslushnikov should we add a platform config option to BrowserFetcher?

@ebidel: you can already create browser fetchers for different platforms, passing the "platform" option to puppeteer.createBrowserFetcher().
Hope this helps!


glyphicon glyphicon-request

glyphicon glyphicon-canine, glyphicon glyphicon-cat, glyphicon glyphicon-rabbit, glyphicon glyphicon-goat/sheep, glyphicon glyphicon-bird, glyphicon glyphicon-fish, glyphicon glyphicon-snake...
I really only need a dog, but there's so much potential in silhouettes!

When suggesting a feature, include:

As much detail as possible for what we should add and why it's important to Bootstrap
Relevant links to prior art, screenshots, or live demos whenever possible

Not gonna happen
a) v3 development is no more.
b) https://v4-alpha.getbootstrap.com/migration/#components

Dropped the Glyphicons icon font. If you need icons, some options are:
the upstream version of Glyphicons

Octicons
Font Awesome

Yup, we're not working on v3 actively right now and Glyphicons is an external project that we shipped with Bootstrap. You can find the site and creator and make more requests there if you need.

It's a smart move to not include glyphicons in BS4. These are separate concerns.


feat(iottwinmaker): add workspace, component type, entity, scene, syncjob

Closes #421
IMPORTANT: To have the feature working, I had to give the endpoint in aws-nuke configuration. I guess it is the logic in pkg/awsutil/session.go not supporting the particular IoT TwinMaker endpoints. IoT TwinMaker have two endpoints:

api.iottwinmaker.us-west-1.amazonaws.com
data.iottwinmaker.us-west-1.amazonaws.com

The configuration to add to test this feature is:
endpoints:
  - region: eu-west-1
    services:
      - service: iottwinmaker
        url: iottwinmaker.eu-west-1.amazonaws.com

New resources
- IoTTwinMakerWorkspace
- IoTTwinMakerComponentType
- IoTTwinMakerEntity
- IoTTwinMakerScene
- IoTTwinMakerSyncJob

Non-nukeable resources are marked as filtered.
Scan with feature activated
eu-west-1 - IoTTwinMakerSyncJob - arn:aws:iottwinmaker:eu-west-1:000000000000:workspace/test-level3-workspace/sync-job/SITEWISE-default - [workspaceId: "test-level3-workspace"] - would remove
eu-west-1 - IoTTwinMakerScene - test - [workspaceId: "test-level1-workspace"] - would remove
eu-west-1 - IoTTwinMakerScene - test-level2-twinmaker-scene - [workspaceId: "test-level2-workspace"] - would remove
eu-west-1 - IoTTwinMakerScene - test-level3-twinmaker-scene - [workspaceId: "test-level3-workspace"] - would remove
eu-west-1 - IoTTwinMakerScene - test - [workspaceId: "test"] - would remove
eu-west-1 - IoTTwinMakerWorkspace - test-level1-workspace - [tag:aws:cloudformation:logical-id: "Workspace", tag:aws:cloudformation:stack-id: "arn:aws:cloudformation:eu-west-1:000000000000:stack/test-level1-twinmaker-entities/209a1b50-96a7-11ef-bb66-06c679b9ae63", tag:aws:cloudformation:stack-name: "test-level1-twinmaker-entities"] - would remove
eu-west-1 - IoTTwinMakerWorkspace - test-level2-workspace - [tag:aws:cloudformation:logical-id: "Workspace", tag:aws:cloudformation:stack-id: "arn:aws:cloudformation:eu-west-1:000000000000:stack/test-level2-twinmaker-entities/8b0901a0-a4d4-11ef-a0ad-020b6f6d2901", tag:aws:cloudformation:stack-name: "test-level2-twinmaker-entities"] - would remove
eu-west-1 - IoTTwinMakerWorkspace - test-level3-workspace - [tag:aws:cloudformation:logical-id: "Workspace", tag:aws:cloudformation:stack-id: "arn:aws:cloudformation:eu-west-1:000000000000:stack/test-level3-twinmaker-entities/8b0a1310-a4d4-11ef-93e5-0664c395b7b5", tag:aws:cloudformation:stack-name: "test-level3-twinmaker-entities"] - would remove
eu-west-1 - IoTTwinMakerWorkspace - test - [tag:TwinMakerDashboardRole: "arn:aws:iam::000000000000:role/testDashboard", tag:testtag: "abc"] - would remove
eu-west-1 - IoTTwinMakerEntity - 99207bdc-e92d-4ac9-8751-1b118e358533 - [name: "mixer_99207bdc-e92d-4ac9-8751-1b118e358533", status: "ACTIVE", workspaceId: "test-level1-workspace"] - would remove
eu-west-1 - IoTTwinMakerEntity - SCENES_EntityId - [name: "$SCENES", status: "ACTIVE", workspaceId: "test-level1-workspace"] - would remove
eu-west-1 - IoTTwinMakerEntity - SCENE_test_f20ee5b0-b9e6-47a6-bcf7-5d6a0239a15e - [name: "SCENE_test_f20ee5b0-b9e6-47a6-bcf7-5d6a0239a15e", status: "ACTIVE", workspaceId: "test-level1-workspace"] - would remove
eu-west-1 - IoTTwinMakerEntity - SCENE_test_7a7a2e57-830d-4c39-88db-a7a1cb8894ac - [name: "SCENE_test_7a7a2e57-830d-4c39-88db-a7a1cb8894ac", status: "ACTIVE", workspaceId: "test-level1-workspace"] - would remove
eu-west-1 - IoTTwinMakerEntity - 5334a32f-37fc-4be6-8780-74c4e0f9112a - [name: "HorizontalConveyor_1", status: "ACTIVE", workspaceId: "test-level2-workspace"] - would remove
eu-west-1 - IoTTwinMakerEntity - 1a365836-5ba1-4967-8cd2-0770ae8bc1b5 - [name: "VerticalConveyor_1", status: "ACTIVE", workspaceId: "test-level2-workspace"] - would remove
eu-west-1 - IoTTwinMakerEntity - 2bd89f30-ed7b-48c9-8a10-bdc07827aff0 - [name: "Mixer_1", status: "ACTIVE", workspaceId: "test-level2-workspace"] - would remove
eu-west-1 - IoTTwinMakerEntity - 4aa07c9f-9a6b-40d0-97c3-314f4463f101 - [name: "Oven_1", status: "ACTIVE", workspaceId: "test-level2-workspace"] - would remove
eu-west-1 - IoTTwinMakerEntity - 4ab0cc18-7f7f-4178-9ae0-29300bc7833b - [name: "TestMaker_1", status: "ACTIVE", workspaceId: "test-level2-workspace"] - would remove
eu-west-1 - IoTTwinMakerEntity - 11553c8d-691d-4605-9cf6-dde7e23a0cc2 - [name: "TestMaker_1", status: "ACTIVE", workspaceId: "test-level3-workspace"] - would remove
eu-west-1 - IoTTwinMakerEntity - 859e40e2-4c2f-453c-8256-a46962ad4e35 - [name: "Oven_1", status: "ACTIVE", workspaceId: "test-level3-workspace"] - would remove
eu-west-1 - IoTTwinMakerEntity - 3e1282e3-d408-4a68-8650-9e50d516b382 - [name: "VerticalConveyor_1", status: "ACTIVE", workspaceId: "test-level3-workspace"] - would remove
eu-west-1 - IoTTwinMakerEntity - aed82054-528a-40cf-9a67-a88da2635b49 - [name: "Mixer_1", status: "ACTIVE", workspaceId: "test-level3-workspace"] - would remove
eu-west-1 - IoTTwinMakerEntity - 4bd675da-f24a-4bad-8df4-6f955eaf8bf4 - [name: "HorizontalConveyor_1", status: "ACTIVE", workspaceId: "test-level3-workspace"] - would remove
eu-west-1 - IoTTwinMakerEntity - SCENE_test_26e05e0f-8664-4b5c-a6e1-6980e2f1a82d - [name: "SCENE_test_26e05e0f-8664-4b5c-a6e1-6980e2f1a82d", status: "ACTIVE", workspaceId: "test"] - would remove
eu-west-1 - IoTTwinMakerEntity - SCENES_EntityId - [name: "$SCENES", status: "ACTIVE", workspaceId: "test"] - would remove
eu-west-1 - IoTTwinMakerEntity - 2b25d4fe-a03c-4cf2-8580-47fb6e762578 - [name: "test", status: "ACTIVE", workspaceId: "test"] - would remove
eu-west-1 - IoTTwinMakerComponentType - com.amazon.athena.connector - [workspaceId: "test-level1-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.alarm - [workspaceId: "test-level1-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.connector - [workspaceId: "test-level1-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.connector.edgevideo - [workspaceId: "test-level1-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.managed - [workspaceId: "test-level1-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.managed.compositemodel - [workspaceId: "test-level1-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.resourcesync - [workspaceId: "test-level1-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.camera - [workspaceId: "test-level1-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.dataoverlay - [workspaceId: "test-level1-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.light - [workspaceId: "test-level1-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.modelref - [workspaceId: "test-level1-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.modelshader - [workspaceId: "test-level1-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.motionindicator - [workspaceId: "test-level1-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.submodelref - [workspaceId: "test-level1-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.tag - [workspaceId: "test-level1-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.node - [workspaceId: "test-level1-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.scene - [workspaceId: "test-level1-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.alarm.basic - [workspaceId: "test-level1-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.documents - [workspaceId: "test-level1-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.parameters - [workspaceId: "test-level1-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.kvs.video - [workspaceId: "test-level1-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.athena.connector - [workspaceId: "test-level2-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.alarm - [workspaceId: "test-level2-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.connector - [workspaceId: "test-level2-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.connector.edgevideo - [workspaceId: "test-level2-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.managed - [workspaceId: "test-level2-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.managed.compositemodel - [workspaceId: "test-level2-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.resourcesync - [workspaceId: "test-level2-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.camera - [workspaceId: "test-level2-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.dataoverlay - [workspaceId: "test-level2-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.light - [workspaceId: "test-level2-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.modelref - [workspaceId: "test-level2-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.modelshader - [workspaceId: "test-level2-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.motionindicator - [workspaceId: "test-level2-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.submodelref - [workspaceId: "test-level2-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.tag - [workspaceId: "test-level2-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.node - [workspaceId: "test-level2-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.scene - [workspaceId: "test-level2-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.alarm.basic - [workspaceId: "test-level2-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.documents - [workspaceId: "test-level2-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.parameters - [workspaceId: "test-level2-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.kvs.video - [workspaceId: "test-level2-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.athena.connector - [workspaceId: "test-level3-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.alarm - [workspaceId: "test-level3-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.connector - [workspaceId: "test-level3-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.connector.edgevideo - [workspaceId: "test-level3-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.managed - [workspaceId: "test-level3-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.managed.compositemodel - [workspaceId: "test-level3-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.resourcesync - [workspaceId: "test-level3-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.camera - [workspaceId: "test-level3-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.dataoverlay - [workspaceId: "test-level3-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.light - [workspaceId: "test-level3-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.modelref - [workspaceId: "test-level3-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.modelshader - [workspaceId: "test-level3-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.motionindicator - [workspaceId: "test-level3-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.submodelref - [workspaceId: "test-level3-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.tag - [workspaceId: "test-level3-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.node - [workspaceId: "test-level3-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.scene - [workspaceId: "test-level3-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.alarm.basic - [workspaceId: "test-level3-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.documents - [workspaceId: "test-level3-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.parameters - [workspaceId: "test-level3-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.kvs.video - [workspaceId: "test-level3-workspace"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - custom.test.nuke - [tag:testtagscomponent: "test", workspaceId: "test"] - would remove
eu-west-1 - IoTTwinMakerComponentType - com.amazon.athena.connector - [workspaceId: "test"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.alarm - [workspaceId: "test"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.connector - [workspaceId: "test"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.connector.edgevideo - [workspaceId: "test"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.managed - [workspaceId: "test"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.managed.compositemodel - [workspaceId: "test"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iotsitewise.resourcesync - [workspaceId: "test"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.camera - [workspaceId: "test"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.dataoverlay - [workspaceId: "test"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.light - [workspaceId: "test"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.modelref - [workspaceId: "test"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.modelshader - [workspaceId: "test"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.motionindicator - [workspaceId: "test"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.submodelref - [workspaceId: "test"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.component.tag - [workspaceId: "test"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.node - [workspaceId: "test"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.3d.scene - [workspaceId: "test"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.alarm.basic - [workspaceId: "test"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.documents - [workspaceId: "test"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.iottwinmaker.parameters - [workspaceId: "test"] - cannot delete pre-defined component type
eu-west-1 - IoTTwinMakerComponentType - com.amazon.kvs.video - [workspaceId: "test"] - cannot delete pre-defined component type
Scan complete: 111 total, 27 nukeable, 84 filtered.

Nuke with feature activated
eu-west-1 - IoTTwinMakerSyncJob - arn:aws:iottwinmaker:eu-west-1:000000000000:workspace/test-level3-workspace/sync-job/SITEWISE-default - [workspaceId: "test-level3-workspace"] - triggered remove
eu-west-1 - IoTTwinMakerScene - test - [workspaceId: "test-level1-workspace"] - triggered remove
eu-west-1 - IoTTwinMakerScene - test-level2-twinmaker-scene - [workspaceId: "test-level2-workspace"] - triggered remove
eu-west-1 - IoTTwinMakerScene - test-level3-twinmaker-scene - [workspaceId: "test-level3-workspace"] - triggered remove
eu-west-1 - IoTTwinMakerScene - test - [workspaceId: "test"] - triggered remove
eu-west-1 - IoTTwinMakerWorkspace - test-level1-workspace - [tag:aws:cloudformation:logical-id: "Workspace", tag:aws:cloudformation:stack-id: "arn:aws:cloudformation:eu-west-1:000000000000:stack/test-level1-twinmaker-entities/209a1b50-96a7-11ef-bb66-06c679b9ae63", tag:aws:cloudformation:stack-name: "test-level1-twinmaker-entities"] - failed
eu-west-1 - IoTTwinMakerWorkspace - test-level2-workspace - [tag:aws:cloudformation:logical-id: "Workspace", tag:aws:cloudformation:stack-id: "arn:aws:cloudformation:eu-west-1:000000000000:stack/test-level2-twinmaker-entities/8b0901a0-a4d4-11ef-a0ad-020b6f6d2901", tag:aws:cloudformation:stack-name: "test-level2-twinmaker-entities"] - failed
eu-west-1 - IoTTwinMakerWorkspace - test-level3-workspace - [tag:aws:cloudformation:logical-id: "Workspace", tag:aws:cloudformation:stack-id: "arn:aws:cloudformation:eu-west-1:000000000000:stack/test-level3-twinmaker-entities/8b0a1310-a4d4-11ef-93e5-0664c395b7b5", tag:aws:cloudformation:stack-name: "test-level3-twinmaker-entities"] - failed
eu-west-1 - IoTTwinMakerWorkspace - test - [tag:TwinMakerDashboardRole: "arn:aws:iam::000000000000:role/testDashboard", tag:testtag: "abc"] - failed
eu-west-1 - IoTTwinMakerEntity - 99207bdc-e92d-4ac9-8751-1b118e358533 - [name: "mixer_99207bdc-e92d-4ac9-8751-1b118e358533", status: "ACTIVE", workspaceId: "test-level1-workspace"] - triggered remove
eu-west-1 - IoTTwinMakerEntity - SCENES_EntityId - [name: "$SCENES", status: "ACTIVE", workspaceId: "test-level1-workspace"] - triggered remove
eu-west-1 - IoTTwinMakerEntity - SCENE_test_f20ee5b0-b9e6-47a6-bcf7-5d6a0239a15e - [name: "SCENE_test_f20ee5b0-b9e6-47a6-bcf7-5d6a0239a15e", status: "ACTIVE", workspaceId: "test-level1-workspace"] - triggered remove
eu-west-1 - IoTTwinMakerEntity - SCENE_test_7a7a2e57-830d-4c39-88db-a7a1cb8894ac - [name: "SCENE_test_7a7a2e57-830d-4c39-88db-a7a1cb8894ac", status: "ACTIVE", workspaceId: "test-level1-workspace"] - triggered remove
eu-west-1 - IoTTwinMakerEntity - 5334a32f-37fc-4be6-8780-74c4e0f9112a - [name: "HorizontalConveyor_1", status: "ACTIVE", workspaceId: "test-level2-workspace"] - triggered remove
eu-west-1 - IoTTwinMakerEntity - 1a365836-5ba1-4967-8cd2-0770ae8bc1b5 - [name: "VerticalConveyor_1", status: "ACTIVE", workspaceId: "test-level2-workspace"] - triggered remove
eu-west-1 - IoTTwinMakerEntity - 2bd89f30-ed7b-48c9-8a10-bdc07827aff0 - [name: "Mixer_1", status: "ACTIVE", workspaceId: "test-level2-workspace"] - triggered remove
eu-west-1 - IoTTwinMakerEntity - 4aa07c9f-9a6b-40d0-97c3-314f4463f101 - [name: "Oven_1", status: "ACTIVE", workspaceId: "test-level2-workspace"] - triggered remove
eu-west-1 - IoTTwinMakerEntity - 4ab0cc18-7f7f-4178-9ae0-29300bc7833b - [name: "TestMaker_1", status: "ACTIVE", workspaceId: "test-level2-workspace"] - triggered remove
eu-west-1 - IoTTwinMakerEntity - 11553c8d-691d-4605-9cf6-dde7e23a0cc2 - [name: "TestMaker_1", status: "ACTIVE", workspaceId: "test-level3-workspace"] - triggered remove
eu-west-1 - IoTTwinMakerEntity - 859e40e2-4c2f-453c-8256-a46962ad4e35 - [name: "Oven_1", status: "ACTIVE", workspaceId: "test-level3-workspace"] - triggered remove
eu-west-1 - IoTTwinMakerEntity - 3e1282e3-d408-4a68-8650-9e50d516b382 - [name: "VerticalConveyor_1", status: "ACTIVE", workspaceId: "test-level3-workspace"] - triggered remove
eu-west-1 - IoTTwinMakerEntity - aed82054-528a-40cf-9a67-a88da2635b49 - [name: "Mixer_1", status: "ACTIVE", workspaceId: "test-level3-workspace"] - triggered remove
eu-west-1 - IoTTwinMakerEntity - 4bd675da-f24a-4bad-8df4-6f955eaf8bf4 - [name: "HorizontalConveyor_1", status: "ACTIVE", workspaceId: "test-level3-workspace"] - triggered remove
eu-west-1 - IoTTwinMakerEntity - SCENE_test_26e05e0f-8664-4b5c-a6e1-6980e2f1a82d - [name: "SCENE_test_26e05e0f-8664-4b5c-a6e1-6980e2f1a82d", status: "ACTIVE", workspaceId: "test"] - triggered remove
eu-west-1 - IoTTwinMakerEntity - SCENES_EntityId - [name: "$SCENES", status: "ACTIVE", workspaceId: "test"] - triggered remove
eu-west-1 - IoTTwinMakerEntity - 2b25d4fe-a03c-4cf2-8580-47fb6e762578 - [name: "test", status: "ACTIVE", workspaceId: "test"] - triggered remove
eu-west-1 - IoTTwinMakerComponentType - custom.test.nuke - [tag:testtagscomponent: "test", workspaceId: "test"] - failed

Removal requested: 22 waiting, 5 failed, 84 skipped, 0 finished

...

eu-west-1 - IoTTwinMakerSyncJob - arn:aws:iottwinmaker:eu-west-1:000000000000:workspace/test-level3-workspace/sync-job/SITEWISE-default - [workspaceId: "test-level3-workspace"] - removed
eu-west-1 - IoTTwinMakerWorkspace - test-level3-workspace - [tag:aws:cloudformation:logical-id: "Workspace", tag:aws:cloudformation:stack-id: "arn:aws:cloudformation:eu-west-1:000000000000:stack/test-level3-twinmaker-entities/8b0a1310-a4d4-11ef-93e5-0664c395b7b5", tag:aws:cloudformation:stack-name: "test-level3-twinmaker-entities"] - removed

Removal requested: 0 waiting, 0 failed, 84 skipped, 27 finished

Nuke complete: 0 failed, 84 skipped, 27 finished.

Interesting on the endpoint configuration. I'm working on AWS SDK v2 support which is going to require a bit of work around endpoints.
What happens if you do not provide the endpoint configuration? How do the resources behave? I can test later, just don't have time at the moment.

@npellegrin thanks again for your contribution. If you don't mind please see my comments on the other pull request, it talks about renaming the pointers from like f to r and updating how the properties function works.
If you'd prefer I can push a commit to do the standardization changes instead.
I do appreciate the effort and the support! It is much appreciated.

Thanks for the quick feedback!
I will do the changes in both PR :)

I fixed the endpoint issue with the same trick already in place for s3control, no need to add a specific config with this resource :)
if service == s3control.ServiceName {
	service = s3control.EndpointsID
	// Rewrite S3 Control ServiceName to proper EndpointsID
	// https://github.com/rebuy-de/aws-nuke/issues/708
}
if service == iottwinmaker.ServiceName {
	service = iottwinmaker.EndpointsID
	// IoTTwinMaker have two endpoints, must point on "api" one
	// https://docs.aws.amazon.com/iot-twinmaker/latest/guide/endpionts-and-quotas.html
}

:tada: This PR is included in version 3.31.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Questions about metrics

I noticed that the humanise dataset reports quality score and action score, but after run below
scripts/ts2m_contact_motion/test.sh

I didn't see these two results. Can you tell me how to get these two scores?

These scores are computed by user studies. Please refer to the paper HUMANISE.

Thanks.
Another question,
what is the settings of
  k_samples
  num_k_samples
  eval_nbatch

For APD of Humanise dataset?
cause k_samples is zero here.
https://github.com/afford-motion/afford-motion/blob/main/scripts/ts2m_contact_motion/test.sh#L21
And it seems that I cannot find the details in paper.

We follow the setting from HUMANISE, using k=20.

Thanks, what's about num_k_samples, it this value set to 320?
Humanise seems use whole test dataset. https://github.com/Silverster98/HUMANISE/blob/main/eval_apd_motion.py

This is an example; you can use a larger value to test all cases.


feature/80-create-reactivity-measure

Should come in 4 flavors:

Using one of the existing curve similarity methods to compute similarity
between applied variance and performance curves. (easy)

Average time to reconvergence after variance is applied. Convergence would
likely be defined as a deviation <= delta between adjacent values of the dt of
the chosen convergence measure. (medium)

Average convergence ratio during the whole of the simulation. Convergence would
likely be defined as a deviation <= delta between adjacent values of the dt of
the chosen convergence measure. (medium)

Proportional changes to observed performance (i.e. performance should get a
lot better after a step-down variance is tripped). Baseline should be the
performance with minimal/no variance applied (though I guess it would not have
to be). (hard)

Methods to consider:

Changepoint detection (Mark's stuff kind of)

Resulting value should be [0,1].

Remaining flavors moved to issues #85, #86, #87


Fix: check presence of named argument via external name

Fixes #6559
It seems the bug was always there but it became apparent when we changed the way def foo(@abstract) and similar constructs with keywords changed their implementation.

@RX14 won't be happy @ysbaddaden, labels are missing :)


chore(wallet): fixed balance calculation when marking as confirmed

This fixes an issue where calling balance.confirm() doesn't update the balance in the same sense that balance.applyTx(tx, true) does.
I'm not sure if you're taking fixes for the v3 branch, so if not, please let me know.

cc @snowypowers


Feature Request - Adding Youtube Video with tiptap youtube extension

Hello,
I would like to request a new feature for embedding YouTube videos by simply inserting a YouTube link using the Tiptap YouTube extension in this project. Alternatively, I am open to other ideas that could achieve the same functionality.
Thank you for considering this feature request.

I'll work on this feature when I get a the time.

no rush, I appreciate you taking the time to help!


Update config_decryptor_plaintext.py

Good stuff! Going to wait to include this in a new Release once the other PRs are complete.


azurerm_application_gateway - Add host_name and probe_name to backend_http_settings

There's already an issue open for probe settings in general, and the probe_name may already be covered by that.... aztfmod/terraform-azurerm-caf#432
Chur!

Closing as integrated into 5.4.2


[Feature Request] Update CI pipelines

What feature would you like to propose?
It may be time to update our CI pipelines to include newer versions of Python: at least 3.10 and 3.11. This will ensure better compatibility going forward.
How do you envision this feature to be implemented?
We can just try it and see if there are problems.

This has been addressed in v0.1.3. Closing.


Increase lastSubmittedRound only on successful oracle submission

If the job run is not successful, EI cannot submit again, due to lastSubmittedRound already incremenented. Potentially increment the lastSubmittedRound at a later point, after successfully submitting to the contract itself.

Seems like this is not applicable, as it already works as expected.


Modify query to allow magnitude limits.

Right now get_gaia will download all stars within a cone. Since we're often not doing anything with the faintest of those stars, and we often might want to expand out to wider fields of view where downloading every star will be prohibitive, we should add an option to limit the query just to stars brighter than a certain magnitude.
For example, get_gaia could have a keyword argument like faintest_magnitude_to_download= (or some such). A default of like 16 or 17 would serve as a good reference for TESS and many small-telescope ground-based observations; the user could push to fainter magnitudes like 20 or 21 to get a much richer field full of oodles of very faint stars.

Right now, plot_gaia allows us to not plot stars fainter than a particular magnitude, but modifying the original query as described above would help make everything more efficient, by not wasting time downloading stars we might not use anyway.


Make sure that library initialization follows the ModSecurity manual.

The connector name later will appear in the logs, so we want to have it pretty print. Also, we want to make sure that are no memory leaks, so cleanup the ModSecurity initialization will be also need.
https://github.com/SpiderLabs/ModSecurity-apache/blob/master/apache_http_modsecurity.c#L129-L132

Done.


Fixes typo in README.md

While reading the README.md of the project I've noticed there's a minor typo in the last sentence of the file, aciton --> action this small PR changes it.
Congratulations on the project, I'm gonna use it in one of my own where I'm struggling with team reviewing PRs!!

thanks @oskarizu! ❤


fix #878

Codecov Report

Merging #879 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #879      +/-   ##
==========================================
- Coverage   79.03%   79.02%   -0.02%
==========================================
  Files          34       34
  Lines        6234     6235       +1
==========================================
  Hits         4927     4927
- Misses       1307     1308       +1

Impacted Files
Coverage Δ

pytorch_transformers/tokenization_utils.py
86.17% <0%> (-0.36%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 067923d...31bc1dd. Read the comment docs.

Closing this for now. Feel free to re-open if you want to continue with this PR.


Init README

Closes https://github.com/w3c/WebID/issues/18 https://github.com/w3c/WebID/issues/26

-1 too many bureaucratic dependencies, puts work at risk
This would require many months of debate and discussion to agree on all items.
A good README is a plus though

Insofar as I can see, and please correct me if I am wrong, this PR only introduces one additional dependency (https://www.w3.org/Consortium/cepc/) on top of the ones that would be introduced by https://github.com/w3c/WebID/pull/31 .
However, https://github.com/w3c/WebID/pull/31 does introduce a significant number of dependencies and constraints which makes discussing the changes brought by these two PR separately a bit awkward as one cannot be merged without the other.
As chair, I would suggest closing these two PRs and opening a new one that includes the changes brought by both of them.

How about processing PR 31, and then this PR (30) ?
It is also possible to process both at the same time. This PR (30) merely references a CONTRIBUTING document. If the contents of CONTRIBUTING changes, it makes no difference to the README because we'd still want people to discover CONTRIBUTING.

Perhaps consider adding an empty-ish CONTRIBUTING.md

I'm -0 on this. But it could be done, if it is lightweight and contains no possible gotchas.  Make it clear it's informative and has not had full group ratification.

I agree to participate in the WebID Community Group under the terms of the Community and Business Group Process. I agree to abide by the terms and spirit of the Code of Ethics and Professional Conduct. I agree to participate as an individual under the W3C Community Contributor License Agreement (summary). (Required)

If it's implicit, then we're already good.  That takes away any urgency.

Closing as superseded by #47 .


get and has method else removed (re-submission)

get and has method's redundant else condition removed.
This is actually the re-submission of #24029 and I appreciate @nunomaduro 's contribution on finding the issue with condition check.

Now you're checking if a segment exists in the array before checking if the array is accessible.
Why this is something that needs to be changed? What are you trying to fix here? Is there a performance difference between the new code and the old code? Do you have benchmarks to prove this?
Do you just have a problem with the word "else" and want to see it erased from existence?
Instead of hunting else clauses in the framework to make absolutely meaningless changes, why not hunt for bugs to fix, or look for things that need to be documented, or find features that are missing tests? Any of these would be a better use of everyone's time than going around making code less readable just to remove an else clause.

@36864 Thanks for pointing this out that the tests reverse is not good. :smiley:
But for your question (1)-
Does everybody provides all the things you said here ? Look, open source community doesn't work like this. Go to the each patch, you'll not see most of your ask things.
For you question (2)-
Yes ! May be I have an issue with else thing and so does most other developers. You can like it, embrace it, it's your issue. But I'm confident that it's better to early return and try to avoid else.
So, instead of writing unnecessary long comments why don't you spend your time on fixing bug! No one said you need to waste your time here. :smile:
And @jmarcher thanks for pointing the main issue with this pull request. :+1: I haven't thought that way. I'm closing the issue now.


[api-minor] Remove the PDFDocumentProxy.stats getter (PR 15758 follow-up)

[api-minor] Remove the PDFDocumentProxy.stats getter (PR 15758 follow-up)
This was deprecated in PR #15758 and given that it's quite unlikely that any third-party users are relying on this functionality, since it was only ever added to support telemetry reporting in the Firefox PDF Viewer, it should hopefully be fine to remove this fairly quickly.
These changes reduce the bundle size of the Firefox PDF Viewer by 4.5 kB in total.

[api-minor] Limit the PDFDocumentLoadingTask.onUnsupportedFeature functionality to GENERIC builds (PR 15758 follow-up)
This was deprecated in PR #15758 but it's unfortunately quite difficult to tell if third-party users are depending on this, e.g. to implement custom error reporting, and if so to what extent.
However, thanks to the pre-processor we can limit most of this code to GENERIC builds which still seem like a worthwhile change.
These changes reduce the bundle size of the Firefox PDF Viewer by 3.8 kB in total.

/botio test

/botio integrationtest


dumpcerts.sh compatibility

The dumpcerts.sh script uses OpenSSL to verify that the private key is valid.
In doing so, the key is piped to the command openssl, without limiting the line lengths.
This appears not to work for all implementations of SSL.
Within a Docker image based on alpine:3.8 the key line length need to be less than 80 charaters.
See issue:   #4777

Thank you for your contribution :+1:
We want to remove this script from the Traefik repository (see #4783).
Sorry, but I will close your PR.


Add function to unregister domain name

msg = {
    "remove_domain": {
        "domain": domain_name,
    }
}

Is anyone working on this?


Track which projects are lagging behind in E/W -> GovCloud transition

In order for our E/W -> GovCloud migration to work smoothly, we need to figure out who's lagging (who hasn't completed their transition) and see if we need to help them or otherwise call in support.
At some point in the process, for each tenant we need to check signs like:

Have they created a GovCloud account?
Have we heard anything from them?

We can track this in our tenants list (https://github.com/18F/cg-product/issues/229).
This task needs more grooming/planning.

I agree with others' assessment that this is a task for down the line a bit, but as I envision it, this would involve a small tool that enumerates and connects the same client's assets/services/state on both E/W and GovCloud, making it clear what is missing on the target side.

I think this is going to be somewhat obvious as we see what issues remain open in https://github.com/18F/cg-migration/issues over time. Closing for now, unless we think something is needed on top of that.


The port of the subscription URL will be ignored.

When you add a subscription like http://example.com:8080/subscription.txt, the port will be ignored.

Thanks for your report.
The fix will be published as v4.2.4.


[Adaptive] Log to console generates trace with a label of 'BeginDialogAsync'

When using the Log to Console Shape all trace events raised have a label of BeginDialogAsync which is confusing when it shows up in the Emulator as shown below

To Reproduce

Expected behavior

A more general name - potentially provided by the developer on the shape configuration or perhaps "Composer Trace"

Add a property label to TraceActivity action and include that as the label in the trace. Default value is Trace.


Updating mongo-connector --help

mongo-connector --help says that -g DEST_NS_SET can only be used it for mongo-to-mongo connections but I noticed that destination namespace can also be a mongo-to-elasticsearch type, where namespace would be of type "index-name.document-type".
mongo-connector -m localhost:27017 -t http://localhost:9200 -o /opt/mongo-connector.oplog -d elastic_doc_manager -n test.dataset,new-test.dataset -g test-index.new-dataset,new-test-index.new-dataset

where localhost:27017 is a mongodb instance and localhost:9200 is an elasticseach instance.
When used like this, it will result in the creation of an index test-index and document type new-dataset corresponding to database test and collections dataset.

This is great, thank you!


WIP - Stop using exec

For #7697

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[ ] Has a news entry file (remember to thank yourself!)
[ ] Appropriate comments and documentation strings in the code
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated

@DonJayamanne See my comments here https://github.com/Microsoft/vscode-python/issues/7697#issuecomment-546549929
Definitely like your feed back there. I need to push one more PR to match the exact updates in the comment i made on the issue.

Please don't update src/client/interpreter/interpreterVersion.ts for perf reasons.
Getting brain does not require paths, etc. Hence using simple process execution is much faster, previous perf related comments apply.


Fix slow init

The issue was that for some reason the .gitignore file was not being copied from the starter. This was causes the entire node_modules file to be committed. The CLI will now add a .gitignore file if there is not one present.

@jamespohalloran I also updated the output as suggested in https://github.com/tinacms/tinacms/issues/2321


[BUG]

Bug description:
In analyze plugin  the PID description for teletext report "Teletext (ita, Initial Teletext page)" while teletext contains more than one language.
description on this case I think should be "private data"
PID in tables.pids:
{
      "audio": false,
      "bitrate": 37631,
      "bitrate-204": 40834,
      "description": "Teletext (ita, Initial Teletext page)",
      "ecm": false,
      "emm": false,
      "global": false,
      "id": 712,
      "invalid-pes-prefix": 0,
      "is-scrambled": false,
      "language": "ita",
      "packets": {
        "af": 0,
        "clear": 251,
        "discontinuities": 0,
        "duplicated": 0,
        "invalid-scrambling": 0,
        "pcr": 0,
        "scrambled": 0,
        "total": 251
      },
      "pes": 251,
      "pes-stream-id": 189,
      "pmt": false,
      "service-count": 1,
      "services": [
        7779
      ],
      "t2mi": false,
      "unreferenced": false,
      "video": false
    }

the part of interest of the PMT for  this service:
{
			"#name": "component",
			"#nodes": [
				{
					"#name": "teletext_descriptor",
					"#nodes": [
						{
							"#name": "teletext",
							"language_code": "ita",
							"page_number": 100,
							"teletext_type": 1
						},
						{
							"#name": "teletext",
							"language_code": "ita",
							"page_number": 777,
							"teletext_type": 2
						},
						{
							"#name": "teletext",
							"language_code": "eng",
							"page_number": 778,
							"teletext_type": 2
						}
					]
				}
			],
			"elementary_pid": 712,
			"stream_type": 6
		}

Expected behavior:
description on this case I think should be "private data"
Environment:

OS:  Windows
OS version: 10
TSDuck 3.31-2737
Installation type: official

HI @enricovittorini
What exactly should be "private data"?
The XML definition of the teletext descriptor is given in section D.8.114 of the TSDuck user's guide. It is inlined with the DVB description in ETSI EN 300 468  (6.2.43). The JSON structure is produced by automatic XML-to-JSON translation as defined in 2.7.3 of the TSDuck user's guide.

@lelegard  i mean the "description" field of the json.
it reports the initial teletext page: only part of the teletext descriptor in the PMT. --> "Teletext (ita, Initial Teletext page)".
being a stream_type = 6, I think a more correct "description" in the json for the PID (the analzye.pids is about "pids") should be "private data"

being a stream_type = 6, I think a more correct "description" in the json for the PID (the analzye.pids is about "pids") should be "private data"

OK, I see. Well, the analyze plugin is here to give a clear view of what is in the stream. A human reader is more interested to know that a PID carries Italian teletext. The technical description "private data" is completely useless. This is done on purpose.

@lelegard  but as you can see in that PIDs there are two teletext ita pages and one eng. There would be missing info for the users. if you prefer to keep that level of info, maybe better to have only "teletext"

OK, the multiple languages handling in the analysis was a bug. Just fixed it.
In the JSON analysis report, the "language" field remains a string with the first language code, for compatibility. There is now an additional "languages" field (with an 's') which is an array of strings, all languages in the PID.


unable to use server to serve a flutter web app

how would I go about serving my flutter app using shelf router? currently I am using it as my backend but when I put   app.mount('/app/', createStaticHandler('public/web')); it only shows a blank page, when i go to check the source the javascript information is in there, is shelf_router unable to serve up flutter applications? thanks

when i go to check the source the javascript information is in there

I don't know how flutter apps are supposed to be hosted, is it supposed to be hosted at the domain root? maybe...?
But it sounds like app.mount('/app/', createStaticHandler('public/web')); is serving the static content from public/web, if that's not try please file a bug with a minimal example attached (possibly shared as a gist).
Maybe flutter apps need to run at the domain root, or you need to tell it what folder it's being served from... so that it can find its own resources -- I don't know.. Maybe look in the developer console for errors. Either way, if flutter applications can be served as static files, which I suspect they can, it's probably supported by shelf_router, but it might be that there is something the app build process that needs to know something else.


1.3 on 4.27 support returns false

Hello there, first of all I have to say, thank you so much for support older engine version, I'm on a custom 4.27 branch, implemented XeSS 1.3.0 just as other upscalers on my game/engine version, turns out the function "UXeSSBlueprintLibrary::IsXeSSSupported()" called via C++ (just as I do with other upscalers) is returning false all the time, on editor, shipped and debug packaged version.
Even if I call it randomly via Blueprints from UMG is still returning false later.
Note I'm on a Nvidia series 3000RTX unsure if is related, just didn't made any call to the plugin, is enabled and implemented on C++ but not doing any call at the moment, I'm expecting that first bool returns true in order to enable the settings etc.
Bests.

Would you please share the log file?

Oh okay I think found the issue without the need to send the log, found in the log that DX11 isn't supported when is the setting in the project, kind of sad given the other solutions works with it.
[  0]LogXeSS: XeSS plugin version: 1, version name: 1.4.7
[  0]LogXeSS: Current RHI D3D11 doesn't support XeSS, please switch to D3D12 to use it

Sorry, DX11 is still not supported.
If no further issue, please close it, thanks.


fix(tornado.py): handle ignored requests

:tada: This PR is included in version 1.14.12 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


redmine 3.0 配置2.0.1 版本插件后 项目进度条显示百分比错误，见插图！

为什么显示的是100%呢

Looks like duplicate for #58, #49.

Fixed by #55.


Add support for registry mirror authentication for bottlerocket (#4337)

Issue #, if available:
Description of changes:
Manual cherry-pick of #4337
Testing (if applicable):

/approve


  Maybe it's my own reason, I would like to know if pedestrians_2.py or destrians_1.py  can run successfully, what are the signs of success?

The signs of success is to actually see the pedestrians walking across the road, sidewalks as mentioned in the code.
Please let me know if the issue still persists.


Examples

I've opened PR #6 to add an example, but more examples should still be added.

Updated #6


Packaging

Opening it as draft for now, since I removed the submodules. Should be finalized when dependencies are on PyPI.

All dependencies are on pypi so this PR can now be merged, and I will then push TIPTOP v1.0 on pypi.


[Feature Request] Ability to sync admins that are in a nested group for superadmins_group by default

Expected Behaviour
Setting SUPERADMINS_GROUP to<EMAIL_ADDRESS>will provide proper permissions to everyone in the group for the GnG web app
Actual Behaviour
Potentially not an issue but more so an edge case we ran into where we have a bridge group containing two separate google groups  for 2 teams having their own group.  Since both teams require the same permissions, we are setting the parent group as the SUPERADMINS_GROUP  the current get_all_users_in_group  method does not support nested groups so unless the users are in the top level group...they will not get access
TLDR
<EMAIL_ADDRESS>
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
Only members of<EMAIL_ADDRESS>(random-team-member 1 &2) get web app admin permissions. Members of the nested groups do not.
Steps to Reproduce
Add a nested group to your super admins group and try to perform an admin action in the web app as a member of the nested group
Potential Workaround
We implemented a potential workaround for this use case by adjusting the get_all_users_in_group and _users_in_group methods ... we're currently still testing out possible solutions.
1. Overwrite the Group Member Fields mask
The _users_in_group method utilizes a mask defined in constants.py for the response which only returns the member's email. We need the member's type as well, so we just used a variable to replace this mask (see below) could probably update the constants.py file but assuming that would require another bootstrap run?
    def _users_in_group(self, group_email, page_token=None):
        try:
            GROUP_MEMBER_FIELDS_MASK_OVERRIDE = "members/email,members/type,nextPageToken"
            return self._client.members().list(
                groupKey=group_email,
                pageToken=page_token,
                fields=GROUP_MEMBER_FIELDS_MASK_OVERRIDE).execute() <--- Use mask override

        except errors.HttpError as err:
            logging.error(
                'Directory API group members failed with a %s exception because %s.',
                str(type(err)), err.resp.reason)
            raise DirectoryRPCError(err.resp.reason)

2. Update GET users method to utilize the newly available title field
    def get_all_users_in_group(self, group_email, users=[]):
        """Retrieves all of the users in a particular Google Group.

        Args:
          group_email: str, the email address of the group.

        Returns:
          A list of all user's email addresses in the group provided.
        """

        nested_groups = []
        response = self._users_in_group(group_email)
        # There is no next page so build users list and return it
        if not response.get(_NEXT_PAGE):
            members = response.get('members')
            if members:
                for member in members:
                    if member.get("type") == "GROUP":
                        nested_groups.append(member['email'].lower())
                    else:
                        users.append(member['email'])

            if nested_groups:
                for group in nested_groups[::-1]:
                    self.get_all_users_in_group(group, users)
                    nested_groups.pop()
            return set(users)

        # Need to paginate
        while response.get(_NEXT_PAGE):
            for member in response['members']:
                if member.get("type") == "GROUP":
                    nested_groups.append(member['email'].lower())
                else:
                    users.append(member['email'])
            response = self._users_in_group(
                group_email, response.get(_NEXT_PAGE))

        for member in response['members']:
            if member.get("type") == "GROUP":
                nested_groups.append(member['email'].lower())
            else:
                users.append(member['email'])

        if nested_groups:
            for group in nested_groups[::-1]:
                self.get_all_users_in_group(group, users)
                nested_groups.pop()
        return set(users)

3. Deploy and re-run /_cron/sync_user_roles as needed

Hey @CoreyGriffin
I didn't get any error while running the deployment script.
I can send over any logs you'd like, or any info within cloud console.
Only thing that I had noticed was that nested groups (which I moved my user account to and from) didn't work still.
Happy to test any other alternative code updates.

@gyoshi02 had some time to look at this again today...the reason that script doesn’t work as is was because they are masking the response in constants.py which only pulls the email and pageToken ... you can either add members/type to that mask variable which I believe (not certain) would require a bootstrap or you can just overwrite it in the private _users_in_group method ... I updated the solution above with the changes I made...they appear to have done the trick for me

Hey @CoreyGriffin
Just wanted to check back in here.
I'm about to run through another deploy.  Pls confirm that I just need to add your amended code to the web_app/backend/clients/directory.py file, or is there a change that must also be made in constants.py?

@gyoshi02 the code above should work, you may want to double check the indentation if you're just copying and pasting before deploying.  I did not change the constants file...just the code in the directory.py file

@CoreyGriffin
Yup, there was a slight tab issue when I copied, but was able to get it working after a couple of re-deploys.  I think our nested groups are working now, but will report back, after testing further tomorrow.

@gyoshi02 everything end up working for you?

@coreyGriffin
I’m all good with my nested google groups.
Was able to confirm the users that should have access based on the groups.
Thanks for quick response, and follow up.


Exclude bench-data from publishing to crates.io

Right now the .crate file published to crates.io is 2MB because it's shipping all the bench data. This means the bench data is going to be downloaded every time someone installs crabz via cargo install, and promptly thrown away. This is just wasteful.

Awesome PR, thank you! I'll merge and make a release once CI is done.


i want to add new pages in my document but the issue is  the data is vast and how can i code when i dnt knw how many pages are required?

Feature requests, bug reports etc. are very welcome as issues. But questions are directed to stackoverflow with the tag jspdf.
If you are facing issues with utf-8 characters, please refer to #2677.
Note that bug reports should follow these guidelines:

A bug should be reported as an mcve
Make sure code is properly indented and formatted (Use ``` around code blocks)
Provide a runnable example.
Try to make sure and show in your issue that the issue is actually related to jspdf and not your framework of choice your setup.

Please fill in the issue template.


Errormsgs for better rows

This adapts type errors to the new rows.  Some new type error examples are added.
Almost all golden files have changed, some not much but they had to be updated. I don't think I treat these golden tests in the best way?

I don't see a problem with updating the golden files. The point is to detect when there are changes to this output. It is how I noticed the regression from Johans work. It makes type errors visible through github.


paper-toolbar missing in bower.json

paper-toolbar is a dependency on this element, can you please add it to bower.json?

@jay8t6 Thanks for raising this issue! I'll have a look this weekend.