bump to 73.0.3683.20

Thanks for maintaining this!
This updates to 73.0.3683.20, the latest release of chromedriver:
http://chromedriver.chromium.org/

Thank you for creating this pull request!
I missed the new versions because I only check the LATEST_RELEASE file. Regarding to this page it now "contains the default ChromeDriver version to use" instead of the latest release.

Hooray! Thanks!


Dev 1227 super title

Briefly describe your changes
Checklist before requesting a review

[ ] My pull request was branched from and targets the test branch
[ ] I have performed a self-review of my code
[ ] I have manually tested all packages affected (bonus points for automations)
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings
[ ] I have checked to ensure there aren't other open pull requests for the same change

Did you test your feature in the following environments?

[ ] Standalone Component
[ ] Standalone Full Editor
[ ] CDC Internal Checks

@ShawnStringfield - see the feedback above. Also, consider making the changes you have here in the other packages as well (charts, data-bites, etc.) Thanks!

@ShawnStringfield - looking much better, thank you! Can you update the other packages as well?


Cannot log into comment sections even though I'm logged into MS Account

Describe the bug
Even though I have logged into the MS Docs site using one of my MS Accounts, The comments section still requires me to log-in before posting. I have attempted to sign in multiple times, and each time the website does not respond. When I enter valid MS Account details, the logon box simply dissapears and the page does not refresh or show that I've logged in. Clicking on the Sign-In link again treats it as if I never signed in to begin with.
Screenshots
I added a PSR Recording of me duplicating the issue.
Desktop (please complete the following information):

OS: Win10
Browser: Chrome
Version: Version 69.0.3497.100 (Official Build) (64-bit)

Failed to Login to Comments.zip

@ShevaDas Is this your area to help?

@AOvermyer I can't open that file—could you provide a link to the page that this is happening on?

Hello -
Apologies for delayed response.
Here is the page I'm having the issue with.
https://docs.microsoft.com/en-us/sql/relational-databases/security/sql-vulnerability-assessment?view=sql-server-2017


Support question -

I have a project with the following in package.json:
{
  "name": "live-mutex",
  "dependencies": {
    "async": "^2.1.4",
    "chalk": "^2.0.1",
    "colors": "^1.1.2",
    "debug": "^2.5.1",
    "siamese": "^2.0.4",
    "strangeloop": "0.0.10001",
    "tcp-ping": "^0.1.1",
    "uuid": "^3.0.1",
    "uws": "^8.14.0"
  },
  "devDependencies": {
    "@types/async": "^2.0.38",
    "@types/chalk": "^0.4.31",
    "@types/core-js": "^0.9.42",
    "@types/lodash": "^4.14.50",
    "@types/node": "^7.0.33",
    "@types/uws": "^0.13.0",
    "bluebird": "^3.4.7",
    "lockfile": "^1.0.3",
    "lodash": "^4.17.3",
    "node-redis-warlock": "^0.2.0",
    "redis": "^2.6.3"
  }
}

my question is - why is npm install attempting to install<EMAIL_ADDRESS>like so:
><EMAIL_ADDRESS>install /home/travis/build/ORESoftware/live-mutex/node_modules/engine.io/node_modules/uws
> node-gyp rebuild > build_log.txt 2>&1 || exit 0

This is not the place to ask this. Ask NPM.

LOL thanks Alex :) From my investigation, it appears as though socket.io uses uws, and engine.io is used by socket.io. Can you can confirm or deny this? Or would you be willing to admit that you do not know?

The right place to ask this is engine.io, obviously.  It has an optional dependency on uws.


Azure Sentinel Community GitHub How To

Fixes #
Proposed Changes
-This is a new document that will help new community members get setup within VSCode and GitHub to contribute and walks through the whole process.
-Preeti Krishna is aware and can be reviewer

I think we are good to merge this and then I will point to it from readme.md on root.


CachedImage default margin

When I pass a margin in my style, e.g.: "margin: 5", It's like the CachedImage already has a margin and my image is placed wrong. I have to pass "margin: 2.5" to work properly.
How to avoid that?

Another exemple:
<CachedImage
            resizeMethod={'scale'}
            style={[styles.imageItem, {backgroundColor: '#000'}]}
            source={{uri: this.props.source}}
          />

Produces this.

It seems the problem is that if you pass only style={} it is applied to container and to image.

Experiencing the same issue !

How to resolve this issue?

Well, I wrapped the CachedImage with a View and moved the margin properties to the View component


Less margin on the side of the figures

With a smallish screen, the figures have a lot of margin on the sides, and are too small to be well usable.

Mostly a question of https://plot.ly/python/setting-graph-size/. Figures are defined in make_figures.py.

Fixed by forcing a height.


Received an unexpected EOF or 0 bytes from the transport stream.

The filtered stream was open for couple of hours and then this exception hit me, keep in mind that i'm using MessageBox.Show() to get notified of these exceptions.
Edit: Here's a stacktrace.
Start DateTime:
24/10/2015 18:39:30
Exception DateTime:
25/10/2015 01:45:41
Message:
Received an unexpected EOF or 0 bytes from the transport stream.
Call Stack:
at System.Net.ConnectStream.Read(Byte[] buffer, Int32 offset, Int32 size)
at System.Net.Http.HttpClientHandler.WebExceptionWrapperStream.Read(Byte[] buffer, Int32 offset, Int32 count)
at System.Net.Http.DelegatingStream.Read(Byte[] buffer, Int32 offset, Int32 count)
at System.IO.StreamReader.ReadBuffer()
at System.IO.StreamReader.ReadLine()
at AsyncExtensions.<>c__DisplayClassf.b__e()
at System.Threading.Tasks.Task`1.InnerInvoke()
at System.Threading.Tasks.Task.Execute()

This issue can also happen. This usually happens when the event MatchingTweet received is not handled quickly enough. As Tweetinvi is a library, I do not want to keep the objects in memory, therefore I wait for the event to be finished in order to continue and the reading of the Stream. A stream not being read for a certain amount of time can result in the Stream to be stopped.
Please note that this can also happen based on the connection and other external factors, as for the StreamStopped issue, please listen to the StreamStopped event and restart the Stream.


Add seek player

Why is that seek is removed on v1.0.14 it had seekTo, Add seek again its a necessary features

.shoukaku....


Hide fields during marshal

Hello,
Does this generator supports to hide some of the fields during Marshal?
I have id field which I don't want to return to the user
Thanks

At this time we don't have any plans to implement this kind of feature.  Personally, I feel like this would go against the core philosophy of Protobuf anyway.  The point of Protobuf is to define the wire format of the messages.  If you don't want a particular field included there then don't include it in the Protobuf message definition.


Will the project support more input characters

I try to run the sample, and find out it seems currently the tool could support limited input characters, like string containing only 'a' and 'b', will the tool support all 256 characters given the minimum input unit is 1 byte, thanks.

Currently the interface is very crude. You can add whatever characters (say a-z) in the vocab list:
(line 34, of char_rnn.py) using the command option --vocab.
parser.add_argument('--vocab', type=str, default="ab")

Will improve the interface to detect the vocab from the input text


dot-notation

Current dependencies on/for this PR:

main

PR #114   👈

This comment was auto-generated by Graphite.


FORMAT JSON for Int64 returns string rather than integer

I have a field named offset in a table that is of type Int64.
When I specify FORMAT JSON in my query the result is returned (incorrectly, wrapped in quotes) as:
"data":
[
{
"offset": "260431",
}
],
However, when I specify FORMAT CSV, the result is returned (correctly) as:
260431 (without quotes)

You can see the explanation of this behaviour here:
https://github.com/yandex/ClickHouse/issues/114
There is an option in config to disable quotes for Int64:
https://clickhouse.yandex/docs/en/operations/settings/settings/#output_format_json_quote_64bit_integers

I'm having an issue getting the setting to be respected.  i have tried both
<output_format_json_quote_64bit_integers>false</output_format_json_quote_64bit_integers>
and
<output_format_json_quote_64bit_integers>0</output_format_json_quote_64bit_integers>
in the config.xml but i'm not having any luck.

@rpfennin, here is a simple example without touching config:
Connected to ClickHouse server version 1.1.54380.

:) select toInt64(12345) as testInt64 format JSONEachRow

SELECT toInt64(12345) AS testInt64
FORMAT JSONEachRow

{"testInt64":"12345"}

1 rows in set. Elapsed: 0.083 sec.

:) set output_format_json_quote_64bit_integers=0

SET output_format_json_quote_64bit_integers = 0

Ok.

0 rows in set. Elapsed: 0.026 sec.

:) select toInt64(12345) as testInt64 format JSONEachRow

SELECT toInt64(12345) AS testInt64
FORMAT JSONEachRow

{"testInt64":12345}

1 rows in set. Elapsed: 0.001 sec.

Option in config should work the same way.

@rpfennin It's per user setting. You can define it in users.xml file for a user profile.


Collection#forEach caches collection length and goes out-of-bounds if collection is modified

The Collection method forEach caches the length of the collection before iterating against it. If the collection length is changed by the function passed to forEach (for example, removing items from the collection), then the loop will attempt to access indexes beyond the end of the collection.
I assume this caching was due to historical performance optimisations, which are largely unnecessary with modern JavaScript engines.
https://github.com/openlayers/openlayers/blob/30358b61a981e620565659d67a433d9196803006/src/ol/Collection.js#L152-L157
I'd suggest this be updated to use an uncached array.length (i.e. for (let i = 0; i < array.length; ++i) {  or use the native Array#forEach method, if allowed by supported browsers.

Removing items from any JavaScript array in a for or forEach can cause unexpected results, see also #10388


Added Type Rating Based Search

closes #1851
This adds Type Rating based search to the Flight Repository.
Upon testing at a larger community with many airlines, aircraft, and subfleets, it was found to be inefficient.
This PR, while it can be pulled, needs a bit more work, and I'm requesting help here to make the code more efficient before we merge.

A test with some examples of how this would change the search would be good. There's some tests now for searches, shouldn't be too bad to add on

#1881 was created since @FatihKoz couldn't edit the PR. He incorporated my code into that PR, so I'll close this one in lieu of that one.


Support edge/link labels

Hi. Not sure what this issue is.. A feature request, a question for help, an offer to contribute..
I need to create a network graph with labeled edges.
So, basically something like your demo https://vx-demo.now.sh/network
But with labels on the edges, as shown in http://bl.ocks.org/jhb/5955887
if this is already possible, I'd love to see an example in the gallery. I'd be willing to actually create one, given some support e.g. via slack/skype/mail to clarify basic questions.
Otherwise, if it's not possible, it would be really awesome if we could do this by specifying an extra label property in the links data:
links: [
    {source: nodes[0], target: nodes[1], label: 'knows'},
    {source: nodes[1], target: nodes[2], label: 'hates'},
    {source: nodes[2], target: nodes[0], label: 'loves'}
  ]

I see that the code uses a DefaultLink component, so a LabeledLink might be the way to go.
Will investigate a bit, and maybe I can create a pull request, but I'm completely new to this lib so it'll take at least some onboarding time, and maybe I just don't get it :)

Hi @loopmode, thanks for checking out vx!
Here's an example with labels -- https://codesandbox.io/s/nrj5wr3v5m

Wow, I didn't get back to this for an entire week...
Well, thank you very much @hshoff ! The library is fantastic, really a pleasure to work with!
Thanks for the example!


Observability Prediction

Dear Developers
I am new to the Alpha Environment and have recently come across a project in which I have to select peptides for targeted detection.
Does your framework provide the possibility to predict relative ionization efficiency (MS1 intensity) between peptides or could it be trained to do that? Or is there another resource that you can recommend? d::POP, PeptideRank, PREGO, MaxDB manual selection, PeptideProphet manual selection are all not really satisfying when I compare them to real life data.
Any help / insight would be appreciated!
Best Klemens

If you have training data, you can easily do it by yourself.


add python media type

Add file type python closes  https://github.com/ordinals/ord/issues/1481

@raphjaph I was realizing after I submitted this that the mime-type returned for the highlight code JS is gonna be text/x-python This won't be recognized as a type for highlight Js. Do you think it would be worth making a more generic highlight JS template with auto highlight to support adding executable code like rust or say typescript? We have the optimized one already where we specify the languge for code types that are used in inscriptions. However any other code that is just reference code using ord as a CDN we would fallback to auto highlight these ones won't be rendered nearly as often.

@raphjaph  got highlight working with latest commit.


[ko] fix typo infrastructure

fix typo '인프라스트럭쳐' to '인프라스트럭처' based on Korean loanword orthography

concepts/architecture/cloud-controller.md
concepts/storage/storage-classes.md
reference/glossary/istio.md

suggested by @bconfiden2 in https://github.com/kubernetes/website/pull/35446#discussion_r931649334

/lgtm

Thanks @mocha-123 :)
/approve


Update readme with supported APIs and usage examples

I have opened #10 to update Readme but not sure I follow the example usage. Are you suggesting I add a Spin app that showcases using fs and process ?


increase connection timeout to 5 minutes to prevent 1 minute websocket connection drops

Will likely switch to a different ingress controller

fixed, had misconfiguration with nginx.ingress.kubernetes.io/proxy-timeout annotations


chore(rust-client): Update to latest master

Improvements coming with this update:

https://github.com/libp2p/rust-libp2p/pull/3288
https://github.com/libp2p/rust-libp2p/issues/3298
Debug keep alive and QUIC connections closing before identify exchange happened
Consider dialing all bootstrap nodes via QUIC to ensure to learn listen addresses

Significantly improves success rate:

Merging here. Feel free to review retroactively. Happy to follow-up with any changes or revert.


update in app webview with iphone os 17

i have issue when i want to build ios app after search i see you use
in-app- webview  lib and after update mac os
it have a problem so  i use the solution  in your lib and make pull request

Small and medium sized Filipino from New
Is that enough to accept the pull request?

Well, I will update the library with the latest version and upload again. Is that enough to accept the request?

done you can check it


[Bug] insertTablet http api lost data event return SUCCESS_STATUS

Search before asking

[X] I searched in the issues and found nothing similar.

Version
Using this syntax, data can be inserted in version 1.1.x, but it no longer works after upgrading to 1.3.0.
curl --location --request POST 'http://iotdb-1-3-0.docker-compose-file.orb.local:18080/rest/v2/insertTablet' \
--header 'Content-Type: application/json' \
--header 'Authorization: Basic cm9vdDpyb290' \
--data-raw '{"is_aligned":false,"device":"root.mqtt.topic.abc454","data_types":["TEXT","INT32","FLOAT"],"measurements":["foo","temp","weight"],"timestamps":[1713495895809,1713499707255,1713495893809,1713495892809,1713495891809,1713495890809,1713495889809,1713495888809,1713495887809,1713495893809,1713495892809,1713495891809,1713495890809,1713495889809,1713495888809],"values":[["bar",null,null,null,null,null,null,null,null,null,null,null,null,null,null],[null,41,32,33,34,39,38,37,36,null,null,null,null,null,null],[null,null,null,null,null,null,null,null,null,87.0,87.3,87.3,87.0,87.3,87.3]]}'
{"code":200,"message":"SUCCESS_STATUS"}

Weights are null.
IoTDB> select temp,weight,foo from root.mqtt.topic.abc454;
select temp,weight,foo from root.mqtt.topic.abc454;
+------------------------+---------------------------+-----------------------------+--------------------------+
|                    Time|root.mqtt.topic.abc454.temp|root.mqtt.topic.abc454.weight|root.mqtt.topic.abc454.foo|
+------------------------+---------------------------+-----------------------------+--------------------------+
|2024-04-19T03:04:47.809Z|                         36|                         null|                      null|
|2024-04-19T03:04:48.809Z|                         37|                         null|                      null|
|2024-04-19T03:04:49.809Z|                         38|                         null|                      null|
|2024-04-19T03:04:50.809Z|                         39|                         null|                      null|
|2024-04-19T03:04:51.809Z|                         34|                         null|                      null|
|2024-04-19T03:04:52.809Z|                         33|                         null|                      null|
|2024-04-19T03:04:53.809Z|                         32|                         null|                      null|
|2024-04-19T03:04:55.809Z|                       null|                         null|                       bar|
|2024-04-19T04:08:27.255Z|                         41|                         null|                      null|
+------------------------+---------------------------+-----------------------------+--------------------------+

Describe the bug and provide the minimal reproduce step
docker-compose yaml file
services:
  iotdb_1_3_0:
    container_name: iotdb130
    hostname: iotdb130
    image: apache/iotdb:1.3.0-standalone
    restart: always
    environment:
      - enable_rest_service=true
      - cn_internal_address=iotdb130
      - cn_internal_port=10710
      - cn_consensus_port=10720
      - cn_seed_config_node=iotdb130:10710
      - dn_rpc_address=iotdb130
      - dn_internal_address=iotdb130
      - dn_rpc_port=6667
      - dn_mpp_data_exchange_port=10740
      - dn_schema_region_consensus_port=10750
      - dn_data_region_consensus_port=10760
      - dn_seed_config_node=iotdb130:10710
    # volumes:
    #     - ./data:/iotdb/data
    #     - ./logs:/iotdb/logs
    expose:
      - "18080"
    # IoTDB's REST interface, uncomment for local testing
    # ports:
         - "18080:18080"

What did you expect to see?
I want to weight is fill as
select weight from root.mqtt.topic.abc454;
+------------------------+-----------------------------+
|                    Time|root.mqtt.topic.abc454.weight|
+------------------------+-----------------------------+
|2024-04-19T03:04:48.809Z|                         87.3|
|2024-04-19T03:04:49.809Z|                         87.3|
|2024-04-19T03:04:50.809Z|                         87.0|
|2024-04-19T03:04:51.809Z|                         87.3|
|2024-04-19T03:04:52.809Z|                         87.3|
|2024-04-19T03:04:53.809Z|                         87.0|
+------------------------+-----------------------------+

What did you see instead?
weight are null.
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

Hello, are you upgrading IoTDB directly from version 1.1 to 1.3? Are there any other operations

I didn't do any additional operations. I just used the official Docker image provided. apache/iotdb:1.3.0-standalone

https://github.com/apache/iotdb/pull/12387

@CritasWang What version would this fix be included in, I don't see it in the latest version(1.3.1).

next version(1.3.2)


Fix infinite recursion in yyfree

Description
On newer versions of GCC the build is failing with -Werror=infinite-recursion warning:
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -g -ggdb -O0 -fno-omit-frame-pointer -g -Werror  -fstack-protector-strong -fcommon -Wno-error=format-security -Wno-error=maybe-uninitialized -ggdb -O0 -fno-omit-frame-pointer -fPIC -g -Werror  -fstack-protector-strong -fcommon -Wno-error=format-security -Wno-error=maybe-uninitialized -ggdb -O0 -fno-omit-frame-pointer -fPIC -I. -I/home/alex/projects/postgres/dev/postgresql_modified_for_babelfish/ -DFAULT_INJECTOR -I. -I./ -I/home/alex/projects/postgres/dist/include/server -I/home/alex/projects/postgres/dist/include/internal  -I -I/home/alex/projects/postgres/dev/postgresql_modified_for_babelfish/ -DFAULT_INJECTOR -I. -I./ -I/home/alex/projects/postgres/dist/include/server -I/home/alex/projects/postgres/dist/include/internal  -D_GNU_SOURCE -I/usr/include/libxml2   -c -o src/backend_parser/scan-backend.o src/backend_parser/scan-backend.c
scan-tsql-epilogue.l.c: In function ‘pgtsql_core_yyfree’:
scan-tsql-epilogue.l.c:80:1: error: infinite recursion detected [-Werror=infinite-recursion]
scan-tsql-epilogue.l.c:82:2: note: recursive call
cc1: all warnings being treated as errors
make: *** [<builtin>: src/backend_parser/scan-backend.o] Error 1

pgtsql_core_yyfree function is calling itself. This looks like an obvious typo as core_yyfree should be called instead.
In reality pgtsql_core_yyfree is never called because memory is allocated/deallocated with memory contexts. Still I suggest to fix this typo to allow successful compilation without specifying -Wno-error=infinite-recursion.
Issues Resolved
#1849
Test Scenarios Covered
The change does not affect the functionality because this call is never used.
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Rebased the branch to allow ODBC tests to pass.


The need for a "fallback to destructive mode" in web mode.

Is your feature request related to a problem? Please describe.
When adding tables to the drift database, where I don't need preserve the database, it would have been very convenient to have a "fallback to destructive mode", more in the same way as the Room approach in android / java platform.
At the moment I have problems when publishing the web app to my test-group that added tables are not created.
Describe the solution you'd like
Please add some way to either

simple function to reset database
a mode when creating the database, which tells the db to be recreate when db schema version rises.

Across all platforms, you can use
  @override
  MigrationStrategy get migration => destructiveFallback;

to manually delete and re-create all tables on a schema upgrade. This should also work on the web, let me know if you're running into any issues with that and I'll take a deeper look.

Thanx for answering, I'll check it out tomorrow morning !!


'frameInterval' is deprecated

FLAnimatedImageView.m:299:26: 'frameInterval' is deprecated: first deprecated in iOS 10.0 - use preferredFramesPerSecond

Dupes #171, though the maintainers of this project seem absent for months now. I recommend a different pod.


Example for gh pr checks

https://github.com/kachick/wait-other-jobs/commit/634e7f3a3ba892e42ffced83143ef7cdd2d9f04c

wait	pending	0	https://github.com/kachick/wait-other-jobs/actions/runs/9367323434/job/25786744729

It cannot avoid deadlocks to itself


Combining min_pairs and key/value validation on a map fails to generate correct validation in Java

First, thanks for a great project!
We're starting to use this internally and noticed validation wasn't working on a map.
We used this format to specify multiple rules:
map<string, string> stuff = 3 [(validate.rules).map.min_pairs = 1, (validate.rules).map.keys.string.uuid = true, (validate.rules).map.values.string.min_len = 1];
We figured out if min_pairs was first, it was left out of the generated Validator. If it was last, key/value validation is left out.
However, if we use this format:
  map<string, string> stuff = 3 [(validate.rules).map = {min_pairs: 1, keys: {string: {uuid: true}}, values: {string: {min_len: 1}}}];
... Java code generates correctly.
Is this a bug, or is the first declaration not supported?
Thanks!

This is a limitation of the proto extension syntax. The first declaration is not supported. See #203

Thanks for clarifying. I now suspect we saw the first declaration in a ticket as I don't see any examples like that in the documentation. Sorry for the bother!


Fixed memory leak while loading image from bundle

Fixed memory leak issue #1051

Any plans on merging this PR?


WIP: Upgrade GPU CI to PyTorch 1.13

What does this PR do?
Follow up to #15555
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃
cc @carmocca @akihironitta @borda

How naive of me to think I could just update a few variables from 1.12 to 1.13. I'm just digging my own grave here if I continue.  Maybe this isn't as important as I thought. Sorry for the noise.

I'm hijacking this

CI stuff is ready, now blocked by a failing FSDP test: https://dev.azure.com/Lightning-AI/lightning/_build/results?buildId=115069&view=logs&j=3f274fac-2e11-54ca-487e-194c91f3ae9f&t=8e4ceb7c-ceed-5ee0-b6fc-c9023e41cb74&l=2191 cc @awaelchli

I can take a look too this afternoon!

I can take a look too this afternoon!

as spoke, let's run PT 1.12 with all strategies and then PT 1.13 just for dependencies available at this time as running with 1.13 is important for us for testing the recent FSDP feature...

@carmocca @Borda It seems that PT 1.13 is setting some env vars that trigger our leakage assertions. These are the names:
KMP_INIT_AT_FORK
KMP_DUPLICATE_LIB_OK

Shall we add them to the allowlist? There seem to be several tests that experience this leakage.

Yes

@carmocca FYI, the reshard_after_forward attribute that caused the attribute error was removed in PyTorch 1.13: https://github.com/pytorch/pytorch/pull/83665
I need to study the the commit in PyTorch to figure out what the alternative is to testing this. For now, I have removed the assertions from the tests in case you want to merge the PR. I can do this investigation as part of #14898


Debug/Teacher Mode

If a user is a teacher/instructor in a course, then the app should provide an inspection mode, so one can get the question details (e.g. the question id)

needs a fix in PowerTLA


Improvement: Only data without any image

Is it possible to configure this modul without any image? I mean show only the data layer

Sure thing. In your custom.css file, add the following:
.MMM-SunRiseSet .img {
    display: none;
}


Chore/ci for typo

Closes: #7066
What is the purpose of the change
Add spellcheck CI
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note

[ ] Does this pull request introduce a new feature or user-facing behavior changes?
[ ] Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

[ ] Specification (x/{module}/README.md)
[ ] Osmosis documentation site
[ ] Code comments?
[ ] N/A

@czarcas7ic can you review this one after we merge the previous one #7059 ?

@hoangdv2429 Can you rebase this or open a new PR? Hard to review in this PR :_(

@mattverse I'll open a new one git rebase main does not let me push for some reason...


Register HXK Oracle on Bifrost Wallet

Closed for failure to submit price data in a reliable manner.

Example of recent knowingly or unknowingly manipulated/unnatural price submissions:

Anyway, if it's not a good idea to control submitting prices, then we won't do that.
And also, we will fix our data provider codebase and after then, we will send merge request again.

Understood, feel free to submit a new PR once you're done testing and move
to a production-ready FTSO.

If you intend to keep sending bogus data to the FTSO system for whatever
reason, use one of the test networks Coston or Coston2.


[Feature Request] Mobile support

This extension is great! I find the default search experience on mobile to be pretty clunky and was wondering if you have ideas for how to improve mobile search, or plans to bundle that with this extension.

@vsinha
Thank you for a request!
I agree with your idea that the default search experience is not so good on mobile.
I think it is possible to improve mobile search with the following concerns.
First, we should create a purely new interface for search.
This is because there is no room for display on mobile when we are searching.
In this sense, the plugin is no longer an assistant.
Second, I will not bundle the mobile plugin with this plugin because they will share little resources and they will behave very differently.


Under section 'Managing endpoints', Logic Apps is missing

Logic Apps is not mentioned under 'Managing endpoints'

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a0cd4aef-33f1-d647-85eb-1a055ef216bd
Version Independent ID: 73febada-4141-88bf-7a55-e8cc375dde92
Content: Business events overview - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/dev-itpro/business-events/home-page.md
Service: dynamics-ax-applications
Product: ****
Technology: ****
GitHub Login: @Sunil-Garg
Microsoft Alias: sunilg

@JeroenLeeflang, thank you for this feedback!
@Sunil-Garg, please review and update the content as necessary.

Bug 443480 has been logged to track this issue.

@JeroenLeeflang LA is not mentioned since, its not a direct end point type. Hope this clarifies. Thanks.


Customizable on disk cache

@uschi2000

Before I look at the code: I'd prefer application-level caching over HTTP-level caching. The rationale is that we want our RPC clients to be as simple as possible. Further, the application logic is easier to understand if caching logic is made explicit. Even further, we have relatively poor (read: mostly non-existing) static knowledge about which endpoints are cacheable at all, so I think it's a hard sell to enable global caching with uncertain behavior.


ENH: Bump TubeTK version

Update TubeTK GIT_TAG to include changes about Tortuosity module

@sumedhasingla I think PR #166 can be closed and replaced by this one in order to get the Tortuosity module changes

LGTM!


Fix ServiceEntry endpoint port setting order (#38661)

Please provide a description of this PR:
This was never back ported to 1.14 due to proximity to branch cut
manual cherry-pick of #38661

@GregHanson: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio_release-1.14
0599045bbfbebc81e4573ada63329e4f98cc9de9
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes


Do not modify registries.conf when not needed

When no container/registries salt pillar is set, do not modify
/etc/containers/registries.conf . That way, users can modify the file
manually and it won't be overwritten when not configured within
ceph-salt.
Signed-off-by: Thomas Bechtold<EMAIL_ADDRESS>

See https://bugzilla.suse.com/show_bug.cgi?id=1170915

Thanks for creating the PR. I had this check in my original PR, but I removed it because of this edge case:

Adding registries. e.g.: ceph-salt config /containers/registries add location=<IP_ADDRESS>:5000/quay.io prefix=quay.io insecure=true
Then applies salt states, /etc/containers/registries.conf is managed.
Removing registries with reset. e.g. ceph-salt config /containers/registries reset
Apply the sale states again, because there is no registries in the pillar, so the file templating is skipped. (/etc/containers/registries.conf still contains one registry)

I couldn't find a good fix to this problem, but I think for now it's OK to skip this case.

Thanks for creating the PR. I had this check in my original PR, but I removed it because of this edge case:

Adding registries. e.g.: ceph-salt config /containers/registries add location=<IP_ADDRESS>:5000/quay.io prefix=quay.io insecure=true
Then applies salt states, /etc/containers/registries.conf is managed.
Removing registries with reset. e.g. ceph-salt config /containers/registries reset
Apply the sale states again, because there is no registries in the pillar, so the file templating is skipped. (/etc/containers/registries.conf still contains one registry)

I couldn't find a good fix to this problem, but I think for now it's OK to skip this case.

I would skip that case for now.

@bk201 did you test it? Because I didn't...

@bk201 did you test it? Because I didn't...

Yes. I tested the latest push.

We should not decide if /etc/containers/registries.conf is managed by ceph-salt or not, just by looking into the number of configured registries.
Instead, we should make it explicit just like we did in  /timeserver [1], so if we don't want ceph-salt to manage /etc/containers/registries.conf we should be able to do:
ceph-salt config /containers/registries disable

(enabled by default)
[1] https://github.com/ceph/ceph-salt/blob/master/ceph-salt-formula/salt/ceph-salt/time-prep.sls#L1

We should not decide if /etc/containers/registries.conf is managed by ceph-salt or not, just by looking into the number of configured registries.
Instead, we should make it explicit just like we did in /timeserver [1], so if we don't want ceph-salt to manage /etc/containers/registries.conf we should be able to do:
ceph-salt config /containers/registries disable

(enabled by default)
This also addresses #214 (comment)

How does this address the issue described? If you enable the registry handing and then disable it, you still have the modified /etc/containers/registries.conf . This is not different afaiu.
Or how would you "reset" /etc/containers/registries.conf ?

[1] https://github.com/ceph/ceph-salt/blob/master/ceph-salt-formula/salt/ceph-salt/time-prep.sls#L1

...
This also addresses #214 (comment)

How does this address the issue described? If you enable the registry handing and then disable it, > you still have the modified /etc/containers/registries.conf . This is not different afaiu.
Or how would you "reset" /etc/containers/registries.conf ?

When you disable it you are just saying: "don't touch /etc/containers/registries.conf anymore, regardless of whether it was manually configured or not."

Closing in favor of https://github.com/ceph/ceph-salt/pull/262


graphics-drawingcombinators doesn't build

Error

[neo@nixos:~/Forks/nodejs-exec]$ nix-build "" -A haskellPackages.graphics-drawingcombinators
these derivations will be built:
/nix/store/rxi3hv3grb5vkjfbspaypiin7fqn4zzw-graphics-drawingcombinators-1.5.1.drv
building path(s) ‘/nix/store/s5mqar15syb1p56v4pzn29rdvf1sa16f-graphics-drawingcombinators-1.5.1-doc’, ‘/nix/store/yh6p0zln0vmn0qgcbjvyv2r1v63c5dwk-graphics-drawingcombinators-1.5.1’
setupCompilerEnvironmentPhase
Build with /nix/store/fd5vgah6xcwzy6xahlkl1xg637xy2n50-ghc-8.0.2.
unpacking sources
unpacking source archive /nix/store/srk2aam8ykg4wx7pk8wrhi6574bnilkl-graphics-drawingcombinators-1.5.1.tar.gz
source root is graphics-drawingcombinators-1.5.1
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file graphics-drawingcombinators-1.5.1/src/Graphics/DrawingCombinators.hs
patching sources
compileBuildDriverPhase
setupCompileFlags: -package-db=/tmp/nix-build-graphics-drawingcombinators-1.5.1.drv-0/package.conf.d -j1 -threaded
[1 of 1] Compiling Main             ( Setup.lhs, /tmp/nix-build-graphics-drawingcombinators-1.5.1.drv-0/Main.o )
Linking Setup ...
configuring
configureFlags: --verbose --prefix=/nix/store/yh6p0zln0vmn0qgcbjvyv2r1v63c5dwk-graphics-drawingcombinators-1.5.1 --libdir=$prefix/lib/$compiler --libsubdir=$pkgid --docdir=/nix/store/s5mqar15syb1p56v4pzn29rdvf1sa16f-graphics-drawingcombinators-1.5.1-doc/share/doc --with-gcc=gcc --package-db=/tmp/nix-build-graphics-drawingcombinators-1.5.1.drv-0/package.conf.d --ghc-option=-optl=-Wl,-rpath=/nix/store/yh6p0zln0vmn0qgcbjvyv2r1v63c5dwk-graphics-drawingcombinators-1.5.1/lib/ghc-8.0.2/graphics-drawingcombinators-1.5.1 --ghc-option=-j1 --disable-split-objs --disable-library-profiling --disable-profiling --enable-shared --disable-coverage --enable-library-vanilla --enable-executable-dynamic --enable-tests --ghc-option=-split-sections
Configuring graphics-drawingcombinators-1.5.1...
Setup: Encountered missing dependencies:
OpenGL ==2.9.*
builder for ‘/nix/store/rxi3hv3grb5vkjfbspaypiin7fqn4zzw-graphics-drawingcombinators-1.5.1.drv’ failed with exit code 1
error: build of ‘/nix/store/rxi3hv3grb5vkjfbspaypiin7fqn4zzw-graphics-drawingcombinators-1.5.1.drv’ failed

Steps to reproduce
nix-build "<nixpkgs>" -A haskellPackages.graphics-drawingcombinators

Technical details
- system: `"x86_64-linux"`
- host os: `Linux 4.9.78, NixOS, 17.09.2875.c2b668ee726 (Hummingbird)`
- multi-user?: `yes`
- sandbox: `no`
- version: `nix-env (Nix) 1.11.16`
- channels(root): `"nixpkgs-unstable-18.03pre126020.931a0b8be80, nixos-17.09.2875.c2b668ee726, nixos-unstable-18.03pre118631.66b63d2f5a"`
- nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`

graphics-drawingcombinators appears to be essentially abandoned upstream. It builds with graphics-drawingcombinators = doJailbreak super.graphics-drawingcombinators; which we could add, but I think the right solution is to address this issue and bump the OpenGL dependency.


Update

Dockerfile now uses the latest lavalink image as a base image. Afterwards, it simply adds the application.yml to the workdir that is already specified in the base image ("/opt/Lavalink"). I have also tested and verfied this by going into a running container and checking the files existence and content.

The new guy, Adri (Adri#1998 in discord)

I should add that the latest tag is being used by lavalink for the latest stable image. They don't tag older working versions properly, so this is the best option.


The Ready attribute doesn't work inside generic classes.

Expected
Hello World
Actual
Steps To Reproduce
Live Bridge
/// <summary>
/// Creates a simple class
/// </summary>
public class App<T>
{
    // Use the [Ready] attribute to automatically
    // run this method when the page is ready.
    [Ready]
    public static void Main()
    {
        Console.WriteLine("Hello World");
    }
}

No, it should not work in generic classes. We have to throw an exception for such case. To access to static member of generic class we have to provide generic argument, like App. Bridge cannot automatically add such argument

We will throw a compilation error if a generic class' method marked with [Ready].
.Net for static Main methods in generic classes shows warning CS0402 'Program<T>.Main()': an entry point cannot be generic or in a generic type. Autorun methods should not apply generics as well.


References in other issues

Should open the issue/PR natively if possible. I should introduce a router system that takes in data and spits out VCs...

Working

How did you implement this? I am not seeing this

Looks like the GQL API is broken. Will file an issue.
For example, using the explorer:
Query:
query IssueOrPullRequest($owner: String!, $repo: String!, $number: Int!, $page_size: Int!) {
  repository(owner: $owner, name: $repo) {
    name
    issueOrPullRequest(number: $number) {
      ... on Issue {
        timeline(first:$page_size) {
          nodes {
            __typename
            ... on ReferencedEvent {
              createdAt
              ...nodeFields
              refCommit: commit {oid}
              actor {login}
              commitRepository {
                ...referencedRepositoryFields
              }
              subject {
                ... on Issue {
                  title
                  number
                  closed
                }
                ... on PullRequest {
                  title
                  number
                  closed
                  merged
                }
              }
            }
          }
        }
      }
    }
  }
}

fragment nodeFields on Node {
  id
}

fragment referencedRepositoryFields on RepositoryInfo {
  name
  owner {
    login
  }
}

Returns result:
{
  "data": {
    "repository": {
      "name": "IGListKit",
      "issueOrPullRequest": {
        "timeline": {
          "nodes": [
            {
              "__typename": "LabeledEvent"
            },
            {
              "__typename": "MilestonedEvent"
            },
            {
              "__typename": "IssueComment"
            }
          ]
        }
      }
    }
  }
}


And writer trait for ValueTrait

The 'Value' Trait currently doesn't include write, it would make sense to have this.

This is now part of value-trait


Protect against nil pointer dereference in execDoneSync

Description
This changeset directly protects against a nil pointer dereference in execDoneSync
Motivation and Context
The code in execDoneSync did not protect against dereferencing the currentExec pointer even if it was nil, sometimes resulting in crashes.
This should fix #1538, though confirmation from @bmos299 would be appreciated.
How Has This Been Tested?
This is a simple change, and should be obviously correct.  Although the value of a new test case for this is dubious, I've included a very short unit test case which exhibits the behavior before the change, but not after.
Checklist:

[X] I have added a Signed-off-by
[X] Either no new documentation is required by this change, OR I added new documentation
[X] Either no new tests are required by this change, OR I added new tests
[X] I have run goimports, go vet, and golint. I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives.  The goal is clean, consistent, and readable code.

Signed-off-by: Jason Yellick<EMAIL_ADDRESS>

This is the wrong fix, it masks a race condition, rather than fixing the race condition.

@corecode I agree this is masking a race condition, as I noted in #1538, this directly prevents the nil pointer dereference, so that @bmos299 and others can potentially make progress while the single-threading work in #1586 #1595 and others works to eliminate the possibility of races.

What I am saying is that it masks the problem.  What does it mean if doneExecSync is called without currentExec set?  Probably something between consensus and execution got out of order, and will result in an incorrect blockchain.  This will re-emerge later during the run as all kinds of defects, which will likely send us on a wild goose chase.

Possibly.  I see the merits in excluding this, as it might just generate new problems.  It also seems likely the the replica will simply recover via state transfer.  This struck me as a non-invasive change which fixes a crash, and not-crashing seems preferable.

In that case we should flag ourselves "somehow incorrect", and perform a recovery of our blockchain via state transfer.

@corecode That's a great idea, fixed and pushed.

LGTM

Thanks, LGTM


Empty table contract, degrade consistency

##Current Behaviour
If there is no data in the table , table get contracted which looks weird.
##Expected Behaviour
Table should not contract based on the data, so that it looks consistent
@hsluoyz If possible I would love to work on this

I am working on this


Playlist add support

Support for adding tracks to playlist

Hopefully I got the spacing right now :D

Thanks again!


GH-40215: [Format][Docs] Document Arrow Columnar Format version history

This PR:

Adds a new Post-1.0.0 Format Versions section to the Format Versioning and Stability docs page
Adds a See also box near the top of the Arrow Columnar Format docs page that links to the new section.
Adds a few associated link anchors and "New in version" info boxes to the Arrow Columnar Format docs page
Updates a reference about the format version on the Implementation Status docs page
Removes the quotes around "Arrow Columnar Format" at the top of the Arrow Columnar Format docs page, using bold text instead
Standardizes the capitalization to "Arrow columnar format" outside of titles (no capitalization for the second and third words when used in sentence text) across the docs

Preview: http://crossbow.voltrondata.com/pr_docs/40219/format/Versioning.html

GitHub Issue: #40215

@github-actions crossbow submit preview-docs

@github-actions crossbow submit preview-docs

@github-actions crossbow submit preview-docs

Docs preview: http://crossbow.voltrondata.com/pr_docs/40219/format/Columnar.html

On second thought, this content should go on Format Versioning and Stability docs page. I'll move it there

@github-actions crossbow submit preview-docs

@github-actions crossbow submit preview-docs

@github-actions crossbow submit preview-docs

@github-actions crossbow submit preview-docs


Fastlane init: snapshots directory is messed probably

I've had SnapFile setup properly before I decided to move to Fastlane.
on init step I've seen such lines:
Successfully created new Deliverfile at './fastlane//Deliverfile'
INFO [2015-02-05 17:08:43.24]: The 'screenshots' folder inside the 'deliver' folder will not be used.
INFO [2015-02-05 17:08:43.24]: Instead the 'screenshots' folder inside the 'fastlane' folder will be used.
INFO [2015-02-05 17:08:43.24]: Click Enter to confirm

But I've found that snapshots directory remains ./deliver/snapshots instead of .snapshots when I open Deliverfile.
I'm not sure whenever it is a bug or not, but looks like this line should be changed.

Can you please share your Snapfile?

# Uncomment the lines below you want to change by removing the # in the beginning

# A list of devices you want to take the screenshots from
devices([
  "iPhone 6",
  "iPhone 6 Plus",
  "iPhone 5",
  "iPhone 4s",
  "iPad Air"
])

languages([
  'en-US'
])

# Where should the resulting screenshots be stored?
screenshots_path "./screenshots"

clear_previous_screenshots # remove the '#'' to clear all previously generated screenshots before creating new ones

# JavaScript UIAutomation file
js_file './snapshot.js'

# The name of the project's scheme
scheme 'Application'

# Where is your project (or workspace)? Provide the full path here
#project_path '../NIXProject.xcworkspace'

# By default, the latest version should be used automatically. If you want to change it, do it here
# ios_version '8.1'

# Custom Callbacks

# setup_for_device_change do |device|
#   puts "Preparing device: #{device}"
# end

# setup_for_language_change do |lang, device|
#   puts "Running #{lang} on #{device}"
#   system("./popuplateDatabase.sh")
# end

# teardown_language do |lang, device|
#   puts "Finished with #{lang} on #{device}"
# end

# teardown_device do |device|
#   puts "Cleaning device #{device}"
#   system("./cleanup.sh")
# end

Thanks, fixed with https://github.com/KrauseFx/fastlane/commit/a5914ff7db65f17c20cd6bca826e62dcb3e5c34e

Man, you are awesome!

Hehe, thanks :smile: Also, really appreciate letting me know, there are so many things changing so fast, it's easy to forget something.


NullPointerException using logger org.slf4j:slf4j-log4j12:jar:1.7.21 with testcontainers

From testcontainers documentation:
Testcontainers, and many of the libraries it uses, utilize slf4j for logging. In order to see logs from Testcontainers, your project should include an SLF4J implementation (Logback is recommended).
I expect testcontainers to support org.slf4j.slf4j-log4j12
The next NullPointerException appears:
Caused by: java.lang.NullPointerException
	at java.util.Hashtable.put(Hashtable.java:459)
	at org.apache.log4j.MDC.put0(MDC.java:150)
	at org.apache.log4j.MDC.put(MDC.java:85)
	at org.slf4j.impl.Log4jMDCAdapter.put(Log4jMDCAdapter.java:60)
	at org.slf4j.MDC.put(MDC.java:116)
	at org.testcontainers.utility.AuditLogger.doLog(AuditLogger.java:34)
	at org.testcontainers.dockerclient.AuditLoggingDockerClient.lambda$startContainerCmd$3(AuditLoggingDockerClient.java:43)
	at org.testcontainers.dockerclient.AuditLoggingDockerClient.lambda$wrappedCommand$14(AuditLoggingDockerClient.java:102)
	at com.sun.proxy.$Proxy20.exec(Unknown Source)
	at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:201)
	... 18 more

AuditLoggingDockerClient (for commands START,REMOVE,STOP,KILL,CREATE_NETWORK,REMOVE_NETWORK) has call like this:
(cmd, e) -> doLog("START", null, containerId, cmd, e));

doLog(String action, String image, String containerId, DockerCmd<?> cmd, @Nullable Exception e)

So image = null.
org.slf4j.impl.Log4jMDCAdapter uses Hashtable where therev is a check for value != null during call 'put'. So NullPointerException occurs.
Possible fix is to use image="" instead of image=null

Hi @IrishkA13,
Thanks for reporting!
The issue is known and already has a PR with a fix:
https://github.com/testcontainers/testcontainers-java/pull/370

Closed with #370
@IrishkA13
May I ask you to try 1.3.1 to verify that the issue is gone? Thanks!

@bsideup
Thanks for fix! This works now!

Hi, I am also facing the same issue. Can you please tell what's the resolution. What's is meant by 1.3.1 in above comment.
I am having my app deployed over tomcat 8.0.42 version.Please help.

1.3.1 is milestone - https://github.com/testcontainers/testcontainers-java/milestone/25
It is the version of the library of testcontainers. All upper versions should also contain the fix.
Check that you use version of testcontainers is 1.3.1 or higher.


client-gen and informer-gen use the wrong import path for semver module versions

Related to #102 - with a module github.com/jenkins-x/jx/v2 and a directory layout of pkg/... without the v2, client-gen and informer-gen both end up using the github.com/jenkins-x/jx/pkg/... path rather than github.com/jenkins-x/jx/v2/pkg/... in their "internal" imports - i.e., in the pkg/client/clientset/versioned/... go files written by client-gen, the imports to other packages under pkg/client/clientset/versioned/... are like github.com/jenkins-x/jx/pkg/client/clientset/versioned/..., but should be github.com/jenkins-x/jx/v2/pkg/client/clientset/versioned/.... All other imports in the generated files are fine, just the internally-referencing ones have this problem.
I'm only using deepcopy-gen (see #102 for the problem I had there), client-gen, lister-gen, and informer-gen with this project, so I don't know if any of the other generators besides client-gen and informer-gen could have this problem too, but lister-gen definitely doesn't.

/remove-lifecycle rotten


Externalization of ERCC's build/launch process + usable crypto lib in ERCC

This should work once rebased on #398 (which fixes master).


Create Đại Học Vinh

Đại học Vinh university
Vinh university
@vinhuni.edu.vn

@96860-Sau lib/domains/vn/edu/Đại: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@96860-Sau I am sorry, the domain vinhuni.edu.vn is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


Fixed rendering clipping brushes on some levels

Rendering of clipping brushes seems to be broken when there's capsule shaped clipping brushes in the level.
Current version:

Issue fixed:

Seems to be caused by these:

As far as I can tell from spending far too long looking at the code to find the issue, the problem is adding an incorrect number of vertex indices to the index buffer. Since it's expecting 3 per triangle and capsules add 8. Fixed it by adding a duplicate of one of the indices, not sure if there's a better way. The rendering of capsules looks a bit off to me but I'm not sure if this was already the case before or if it's caused by this fix.
I think the same issue is also present in circles, although since AddCircle is only used in AddSphere which calls it 3 times it shouldn't cause any issues with rendering the rest of the map.

The problem is that we used to render physics as lines but then switched to triangles. And spheres are not triangulated, as can be seen from your last screenshot.
I'll merge this so it doesn't break everything else, but it would be nice to update spheres to be triangulated.


update documentation

Documents need to be updated. Please update it ASAP
The libraries are updated, Please Updated the Documents related to it
Screenshot

I need to use it can you please update it sir @zaid-kamil @digipodium/admins

Hi @tabishqidwai98
sorry, I am not given enough time to update the documentation. I will update it some day. You can look at the example in this notebook given.
https://github.com/zaid-kamil/2024-feb-pydsda-1100-WTFS/blob/main/scraping/scraper.ipynb
here is a python database and scaper example
https://github.com/digipodium/2023-NOV-PYDS-1230-MTWF/blob/main/data%20mining/spider.py
Here is the outline logic
Give the URL in the Scraper class instance, the create objects of Tag class, finally use the scraper object  and call its method by passing the tag objects.


Preserve directory-level standalone build symlinks

Summary
It's actually fine not to resolve python-build-standalone symlinks, if the full distribution is symlinked.
For example:
❯ ln -s cpython-3.12.6-macos-aarch64-none /Users/crmarsh/.local/share/uv/python/cpython-3.12-macos-aarch64-none
❯ cargo run venv --python /Users/crmarsh/.local/share/uv/python/cpython-3.12-macos-aarch64-none/bin/python
❯ cat .venv/pyvenv.cfg
home = /Users/crmarsh/.local/share/uv/python/cpython-3.12-macos-aarch64-none/bin
implementation = CPython
uv = 0.5.7
version_info = 3.12.6
include-system-site-packages = false
prompt = uv
❯ ./.venv/bin/python -c "import sys"

As opposed to:
❯ ln -s /Users/crmarsh/.local/share/uv/python/cpython-3.12-macos-aarch64-none/bin/python foo
❯ cargo run venv --python ./foo
❯ cat .venv/pyvenv.cfg
home = /Users/crmarsh/workspace/uv
implementation = CPython
uv = 0.5.7
version_info = 3.12.6
include-system-site-packages = false
prompt = uv
❯ ./.venv/bin/python -c "import sys"
Could not find platform independent libraries <prefix>
Could not find platform dependent libraries <exec_prefix>
Python path configuration:
  PYTHONHOME = (not set)
  PYTHONPATH = (not set)
  program name = './.venv/bin/python'
  isolated = 0
  environment = 1
  user site = 1
  safe_path = 0
  import site = 1
  is in build tree = 0
  stdlib dir = '/install/lib/python3.12'
  sys._base_executable = '/Users/crmarsh/.local/share/uv/python/cpython-3.12-macos-aarch64-none/bin/python3.12'
  sys.base_prefix = '/install'
  sys.base_exec_prefix = '/install'
  sys.platlibdir = 'lib'
  sys.executable = '/Users/crmarsh/workspace/uv/.venv/bin/python'
  sys.prefix = '/install'
  sys.exec_prefix = '/install'
  sys.path = [
    '/install/lib/python312.zip',
    '/install/lib/python3.12',
    '/install/lib/python3.12/lib-dynload',
  ]
Fatal Python error: init_fs_encoding: failed to get the Python codec of the filesystem encoding
Python runtime state: core initialized
ModuleNotFoundError: No module named 'encodings'

Current thread 0x00000001fdf34c00 (most recent call first):
  <no Python frame>

This is pretty handy because... symlinking the full directory is much more common, and useful?

Ok clearly not quite right :)

Based on what I've learned here, I think the right thing to do would be: check if we can find STDLIB_LANDMARKS in any parent directory of the executable. If not, then we should fully resolve it.


ZR ASP creation fails for ASEv3

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

az appservice plan create --resource-group testrg --name testasp--app-service-environment ase1 --location southcentralus --number-of-workers 3 --sku I1v2 --subscription testsub --z
Describe the bug
Zone redundant ASP plan creation on an ASE currently does on work on the CLI. It fails with error "Zone redundancy cannot be enabled for sku I1V2"
To Reproduce
Create an App Service Environment v3 with Zone Redundancy enabled and try to create a zone redundant app service plan
Expected behavior

Environment summary

"azure-cli": "2.39.0",
Additional context

route to CXP team

@bhumikadhotre1 Thank you for reaching out, we are looking into it.

@bhumikadhotre1 Please check the prerequisites. Zone redundancy is not support for Isolated sku.
Availability zone support is a property of the App Service plan. The following are the current requirements/limitations for enabling availability zones:
Both Windows and Linux are supported.
Requires either Premium v2 or Premium v3 App Service plans.
Minimum instance count of three is enforced.
The platform will enforce this minimum count behind the scenes if you specify an instance count fewer than three.
More information here :
https://docs.microsoft.com/en-us/azure/availability-zones/migrate-app-service#prerequisites
https://azure.microsoft.com/en-in/pricing/details/app-service/windows/

it is supported for ASEv3
Migrate Azure App Service Environment to availability zone support | Microsoft DocsMigrate Azure App Service Environment to availability zone support

@bhumikadhotre1 Thank you for the information. @StrawnSC I believe even if you are using ASEv3 and plan must be premium right? can you please help clarify the doubt?


Bring changes from master into develop

Develop should never be behind master :-(

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: StephanSiemen:x: sylvielamythepautYou have signed the CLA already but the status is still pending? Let us recheck it.


issue 126: use a per-architecture opensslconf.h

this should be flexible and maintainable, with minimal impact..
this is a follow-up to the discussion started here: https://github.com/x2on/OpenSSL-for-iPhone/pull/127
regarding a bug reported here: https://github.com/x2on/OpenSSL-for-iPhone/issues/126
please test - i verified the original bug is fixed, and that stuff works on ios simulator x86_64...

This approach looks quite good to me, but what I didn't like it the fact that references can be present to files that don't exist (since there is a possibility to build for a limited set of targets).
Instead of asking you to build something I have in mind, I thought I'd have a go myself. I'm afraid I might have overdone it a bit, so I apologise if this makes you wonder why you put in the effort.
I took your pattern, but generate the intermediate include file at the end of the build, based on the archs/targets that were selected. I also created a bypass in case only one target is selected for build. Since I like Apple's TargetConditionals.h (as those defines are easy to read), I used those in the preprocessor conditionals.
https://github.com/x2on/OpenSSL-for-iPhone/compare/master...oneton:opensslconf?expand=1
I also upgraded the Travis build to 8.2.
What do you think?

Nice change. I noticed the need for this today when building with --ec-nistp-64-gcc-128: opensslconf.h ends up without the
#ifndef OPENSSL_NO_EC_NISTP_64_GCC_128
# define OPENSSL_NO_EC_NISTP_64_GCC_128
#endif

presumably needed for 32-bit platforms.

Any news on this PR?

Shall I create a PR with my suggested solution to move this forward?

sorry, i didn't get to test @oneton's approach yet, will do it now..

@oneton nice change, definitely fixes #126 - but two remarks: when used from outside xcode (in my case in a plain C++ project), the opensslconf.h umbrella header should include "TargetConditionals.h". to capture this, i suggest adding an uncoditional final "else" to the ifdefs with an #error describing what's wrang..
so the file would look something like this:
#include <TargetConditionals.h>

#if TARGET_OS_IOS && TARGET_OS_SIMULATOR && TARGET_CPU_X86_64
...
# elif
...
#else
# error "could not determine target!"
#endif

Good points! I made the changes you suggested and created a new PR with a clean branch based on current master.

Closed in favor of #145


feat: bijections between morphisms in two localized categories

Given two localization functors L₁ : C ⥤ D₁ and L₂ : C ⥤ D₂ for the same class of morphisms W : MorphismProperty C, we define a bijection Localization.homEquiv W L₁ L₂ : (L₁.obj X ⟶ L₁.obj Y) ≃ (L₂.obj X ⟶ L₂.obj Y) between the types of morphisms in the two localized categories.

Thanks!
bors merge


adds mock page for displaying record of user contributions

DO NOT MERGE

Hi @izaakrogan, thanks for submitting your coding test. We look forward to meet you virtually!
In the meantime, closing this


WUMA incompatible with SwiftAC

Hey there,
We are using WUMA about 2 months on the server now and it works great.
But I have encountered errors when installing SwiftAC from gmodstore.
Our console error output:
[WUMA] lua/includes/modules/hook.lua:120: attempt to index local 'gm' (a number value) 1. Call - lua/includes/modules/hook.lua:120 2. OnLoseFocus - lua/wuma/client/vgui/vgui_textbox.lua:79 3. SetDefault - lua/wuma/client/vgui/vgui_textbox.lua:13 4. Init - lua/wuma/client/vgui/vgui_restrictions.lua:30 5. Create - lua/includes/extensions/client/panel/scriptedpanels.lua:37 6. unknown - lua/wuma/client/gui.lua:65
And my client console output:
[ERROR] lua/includes/modules/hook.lua:120: attempt to index local 'gm' (a number value)
 1. Call - lua/includes/modules/hook.lua:120
  2. fn - addons/ulib-master/lua/ulib/cl_init.lua:58
   3. func - addons/ulib-master/lua/ulib/client/cl_util.lua:22
    4. unknown - lua/includes/extensions/net.lua:32

I've both contacted you and the dev of SwiftAC.

Is this a paid addon? I need the source code of the addon in order to find exactly what is causing it.

Yes, it is. Sadly I can't provide the source code, as it would violate their ToS and I can get in trouble for it.

Hmm, that makes it hard. I've tried a fix that might work. Try to download and use this version of WUMA: https://github.com/Weol/wuma/tree/test
Its a different version with a very minorr change that might fix this exact issue.

Will do. I also added you on steam (same name) to solve the source code issue.

Looks good! That has solved it!

Also by typing xgui in console (That's my bind to open ULX) I get the error above. !menu works, but WUMA is endlessly "buffering data".

Allright, I think I know what the problem is. For context: many addons use "" in order to represent an empty (nil) value. I think that this anti-cheat addon has globally defined "" as 1. As you can see from the errors, ULib is also broken because of this.

I would contact the author of SwiftAC to resolve it

That would be good, as I cannot share the source code without risking trouble.

Yea, just link him to this issue I guess.

Issue caused by different addon.


dnsmasq: process is missing required capability NET_ADMIN

Is this a bug related to new docker-ce version?

Hi! How are you running the container image? You may beed to add the NET_ADMIN  when running it :)

Hi! How are you running the container image? You may beed to add the NET_ADMIN when running it :)

HOW?
I am completely lost on how you add NET_ADMIN when pressing run.

HOW? I am completely lost on how you add NET_ADMIN when pressing run.

with docker run --cap-add=NET_ADMIN ... source


App hooks

WHY
Useful for extending the app.
So Devs don't need to edit the core.
WHAT
Focus on web hooks more.
Could be called listeners.
Could listeners call 'components'?
Add documentation.
Think about being able to feed the activity of the bot to a slack channel.
For incoming text can send it to slack
For completed response send to slack
When the app is ready and listening
When the app has an error
Hook for all events

//Main app loop
this.on('app.loop', () => {
});

//Client identified
this.on('client.identified', (client) => {
});

//New auth
this.on('auth.new', (Client) => {
  console.log('new client');
  this.request(Client, {
    text: 'hello',
    user: 'good-intentions-user'
  });
});


Visualisation issues (vis)

🐛 Bug
Attempts to visualise several analysis either result in warning messages with no output, or just no output. I'm guessing it may be due to the structure of my data so I'll include my repLoad procedure below.
To Reproduce

Data is the filtered annotation files for two 10x samples. Samples seemed to read in ok, although got warning message (The following named parsers don't match the column names: barcode...). Read in using:

immdata <- repLoad("./immunarch")
metadata.txt content:
Sample
wt_UT
wt_aCT

Example of vis command with warning and no output:

> exp_vol = repExplore(immdata$data, .method = "volume")
> vis(exp_vol, .by = c("Sample"), .meta = immdata$meta)
Warning: Ignoring unknown aesthetics: y
Warning: Ignoring unknown aesthetics: xmin, xmax, annotations, y_position

Example of vis command with no output (or warning):

> exp_len = repExplore(immdata$data, .method = "len", .col = "aa")
> vis(exp_len)

Expected behavior
Graphical output of data
Additional comments
Several other vis inputs result in the same issue, happy to list them if that's of use, also happy to provide sample dataset. Suspicion the issue may lie in the "Source" section of the metadata, which is just my sample names in triplicate (see below), which may be confuse vis.
> immdata[["meta"]][["Source"]]
[1] "wt_aCT" "wt_aCT" "wt_aCT" "wt_UT"  "wt_UT"  "wt_UT"

Hi @GBeattie ,
thank you for letting us know about the issue and following the bug template! We will fix it in the next release before New Years Eve. As a workaround, you can use plot:
exp_len = repExplore(immdata$data, .method = "len", .col = "aa")
plot(vis(exp_len))

@vadimnazarov
Thanks for the workaround, working with the other cases where plots weren't appearing also.


Can't fetch data and return it on server-side?

I'm experiencing some very odd behavior. I have a Meteor method that basically just does MyAstroClass.find().fetch() and returns that data. Yet it never shows up on the client side. If I instead use the regular Mongo collection, MyItems.find().fetch() and return that, it works fine.
Furthermore, something seems to get stuck/queued. When I save my code which triggers a Meteor re-build, I see the Astro data get dumped in the server console even though I haven't called the method.
I'm on Meteor 1.4, and using the latest version of Astronomy.

Are you using the softremove behavior?

Yep!

so maybe these documents are soft removed and that's why they don't appear?

Nope, they're not soft-removed. Should I try temporarily removing that behavior plugin and see if it fixes it?

You have to create reproduction repository because without that it's hard to tell.

Yep, I knew that was coming next. ;) I hope I can reproduce it in a test project. These things tend to happen in my closed-source projects with 7000+ lines of code, ugh.
I'll get back to you soon. Thanks!

I am getting exactly the same error and the only behavior I am using on user collection is "timestamp".
When I do User.find().fetch() and return in my method, nothing reaches the client though console.log on the server does show that users were selected.
I had to change my code to Meteor.users().find().fetch() and then on the client, loop over the users to create astronomy User class.
Before you ask :) , it's a big project so I will not be able to share the code.

I've made some tests and it works properly:
if (Meteor.isServer) {
  Meteor.methods({
    test() {
      return Animal.find().fetch();
    }
  });
}

Meteor.call('test', function(err, animals) {
  console.log(animals);
});

It works properly in both cases when method is only defined on the server and if it's defined on the server and client. Closing it until you provide some reproduction.


Feature styling 4

worked on more on html and styling css. Added folders to organize each file

Merging with Joyce's HTML - need to touch up HTML with relative paths for new JS file locations and adjust ids


Unicode support in regex implementation.

I think it could be possible to add Unicode support.  The fundamental virtual machine commands don't particularly care how big your character is, so it may not involve too much code change.

Implemented in b6536e9ef73e85857ad36fbb15c3fcb6b21cdcce


Carltoncolter issue 171

Modified the path generator for downloaded web resources and added a bat file to download-webresources with the overwrite command enabled.

Merged in to spkl_dev branch


Support SQLAlchemy dialect with psycopg2

Hi there,
coming from https://github.com/smartsdk/ngsi-timeseries-api/issues/407#issuecomment-738644201, I am asking myself whether it would be possible to use the CrateDB SQLAlchemy dialect together with the Python DB API 2.0 compatible psycopg2 driver.
Maybe @mfussenegger, @chaudum or @autophagy can add a comment about this?
With kind regards,
Andreas.

I think the sqlalchemy dialect doesn't have too many concrete dependencies on crate-python.
Could try monkey-patching the driver name.
One exception from the client is used: https://github.com/crate/crate-python/blob/f2617dd789f0eb70b042ac77be4b7c8bd936a7c6/src/crate/client/sqlalchemy/dialect.py#L34
We could consider to de-couple it, but not sure what's the benefit of using psycopg2 over the crate-python http based client?
We also have to keep in mind that psycopg2 is LGPL licensed, which is afaik not compatible with Apache licensed projects. So we wouldn't be able to ship anything with psycopg2 included.

Hi Mathias,
thanks for looking into this. I was just trying to figure out if there are any other intrinsic couplings which would prevent this in general.
I would not de-couple it but instead provide an option to invoke it like outlined at [1].
# default
engine = create_engine('crate://localhost:4200')

# psycopg2
engine = create_engine('crate+psycopg2://localhost:5432')

Not sure what's the benefit of using psycopg2 over the crate-python HTTP-based client?

Wouldn't the communication be a bit more efficient regarding binary serialization on the wire and without the overhead of HTTP? Also, things like how to properly configure a shared connection pool (https://github.com/crate/crate-python/issues/393) would not need any special attention.

We also have to keep in mind that psycopg2 is LGPL licensed.

Thanks for bringing that up. SQLAlchemy is MIT licensed and references psycopg2 within an optional "extra" dependency [2,3]. So I believe it would be fine doing it in the same way?
With kind regards,
Andreas.
[1] https://docs.sqlalchemy.org/en/13/core/engines.html#postgresql
[2] https://github.com/sqlalchemy/sqlalchemy/blob/rel_1_4_0b1/setup.cfg#L60
[3] https://github.com/sqlalchemy/sqlalchemy/blob/rel_1_4_0b1/setup.cfg#L65

Wouldn't the communication be a bit more efficient regarding binary serialization on the wire and without the overhead of HTTP?

The PostgreSQL wire communication supports text and binary serialization. I think psycopg2 is using the text serialization. I didn't verify that, but I think it is one of the reasons that asyncpg is a lot faster - because they use binary serialization. And before they merged https://github.com/MagicStack/asyncpg/pull/295  our crate-python executemany was significantly faster (orders of magnitude) than asyncpg. I haven't tested again since they merged the batch improvement.

SQLAlchemy is MIT licensed and references psycopg2 within an optional "extra" dependency [2,3]. So I believe it would be fine doing it in the same way?

Yes it works as optional dependency. I think the license only prevents us from providing a bundle that would include psycopg2 code out of the box.

I just wanted to add that @proddata and @SStorm signaled interest in having this feature available.

I just wanted to add that both @proddata and @SStorm signaled interest in having this feature available.

Could you elaborate on the background? What's the advantage of using psycopg2?

SQLAlchemy 1.4 also supports asyncpg. I think that may be more worthwhile to support than psycopg2 as it has performance advantages.

Hi again,
I fully agree that the focus should be on asyncpg instead. I will add a corresponding test case to #391 and close this issue. Feel free to reopen or create another one as soon as psycopg3 is ready and qualifies further evaluation.
With kind regards,
Andreas.


Doubt

We look forward to this release,
Just one question,

What is this "IRM oracle" I noticed that it has a very high SDR, could you tell me what it is? Thank you very much.

And an observation, the Demucs informed in this table, would be the Demucs V3?

Thank you for your attention to this work.

Ideal Ratio Mask oracle (IRM), which computes the best possible mask using the ground truth sources and is the top line of the spectrogram-based method.
The results of Demucs we published are from V2, and the number of parameters comes from this paper.

We look forward to this release,
Just one question,

What is this "IRM oracle" I noticed that it has a very high SDR, could you tell me what it is? Thank you very much.
And an observation, the Demucs informed in this table, would be the Demucs V3?

Thank you for your attention to this work.
Ideal Ratio Mask oracle (IRM), which computes the best possible mask using the ground truth sources and is the top line of the spectrogram-based method.
The results of Demucs we published are from V2, and the number of parameters comes from this paper.

We look forward to this release,
Just one question,

What is this "IRM oracle" I noticed that it has a very high SDR, could you tell me what it is? Thank you very much.
And an observation, the Demucs informed in this table, would be the Demucs V3?

Thank you for your attention to this work.

Ideal Ratio Mask oracle (IRM), which computes the best possible mask using the ground truth sources and is the top line of the spectrogram-based method.
The results of Demucs we published are from V2, and the number of parameters comes from this paper.


Include steppage in performance docs

Based on this discussion writes a small note in the performance doc about how accelerate will step the scheduler multiple times and how the "batch size" is treated as a result

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Let the install profile/starter site set the pseudo fields.

We don't need to set the bundles to have gemini pseudofields. that is done by the starter site, and also the install profile.
GitHub Issue: (link)

Other Relevant Links (Google Groups discussion, related pull requests,
Release pull requests, etc.)

What does this Pull Request do?
A brief description of what the intended result of the PR will be and/or what
problem it solves.
What's new?
A in-depth description of the changes made by this PR. Technical details and
possible side effects.

Changes x feature to such that y
Added x
Removed y
Does this change require documentation to be updated?
Does this change add any new dependencies?
Does this change require any other modifications to be made to the repository
(i.e. Regeneration activity, etc.)?
Could this change impact execution of existing code?

How should this be tested?
A description of what steps someone could take to:

Reproduce the problem you are fixing (if applicable)
Test that the Pull Request does what is intended.
Please be as detailed as possible.
Good testing instructions help get your PR completed faster.

Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora-Devops/committers

Ran a full playbook install and verified that these settings are not set by the playbook anymore.


isGenerallyAvailable is annoying to use

.isGenerallyAvailable is annoying to use.
If you want to filter over the array you have to do o.isInGeneralAvailability || o.isInGeneralAvailability === undefined, because it's falsy on ccTLDs as the key is not present on there...

Changed to isNotGenerallyAvailable in v2


Plugin system version should bump if sdk changes

What's the reason for this?

What's the reason for this?

When there's a change in the SDK, the version of PluginsSystem should be bumped. The pathFilters should be set to include its parent folder which is src.

Chatted offline with @mslukebo Because PluginsSystem has dependencies on the SDK, changes in the SDK should be treated as a new commit in the PluginsSystem which should result in a new version.

What's the reason for this?

When there's a change in the SDK, the version of PluginsSystem should be bumped. The pathFilters should be set to include its parent folder which is src.

Chatted offline with @mslukebo Because PluginsSystem has dependencies on the SDK, changes in the SDK should be treated as a new commit in the PluginsSystem which should result in a new version.

I noticed we excluded the solution file. Should we exclude anything else, like test folder changes?

What's the reason for this?

When there's a change in the SDK, the version of PluginsSystem should be bumped. The pathFilters should be set to include its parent folder which is src.

Chatted offline with @mslukebo Because PluginsSystem has dependencies on the SDK, changes in the SDK should be treated as a new commit in the PluginsSystem which should result in a new version.

I noticed we excluded the solution file. Should we exclude anything else, like test folder changes?

What's the reason for this?

When there's a change in the SDK, the version of PluginsSystem should be bumped. The pathFilters should be set to include its parent folder which is src.

Chatted offline with @mslukebo Because PluginsSystem has dependencies on the SDK, changes in the SDK should be treated as a new commit in the PluginsSystem which should result in a new version.

I noticed we excluded the solution file. Should we exclude anything else, like test folder changes?
edit: looking through the folders, it seems like it might be easier to create a list of folders we want to include. do we update when the engine changes? what about the runtime?

Chatted offline. We should fine tune the versioning

What's the reason for this?

When there's a change in the SDK, the version of PluginsSystem should be bumped. The pathFilters should be set to include its parent folder which is src.

Chatted offline with @mslukebo Because PluginsSystem has dependencies on the SDK, changes in the SDK should be treated as a new commit in the PluginsSystem which should result in a new version.

I noticed we excluded the solution file. Should we exclude anything else, like test folder changes?
edit: looking through the folders, it seems like it might be easier to create a list of folders we want to include. do we update when the engine changes? what about the runtime?

Chatted offline. Created an issue to address in another PR https://github.com/microsoft/microsoft-performance-toolkit-sdk/issues/309


The 'dataEventRecord.SourceInfo' object was used after it was verified against null.

The https://github.com/damienbod/AspNetCoreMultipleProject/issues 'dataEventRecord.SourceInfo' object was used after it was verified against null.

Hi @daraduda
thanks, I'll fix this, can you give me a quick pointer to the code?
Greetings Damien

Hi @damienbod . Please check  the https://github.com/damienbod/AspNetCoreMultipleProject/blob/master/src/DataAccessPostgreSqlProvider/DataAccessPostgreSqlProvider.cs 25 and Line 31
Line:

Added a validation check for this in the controller


when i have two zk registry, i can't configure it

What happened:
when i have two zk registry, i can't configure it
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:

WIP


add google oauth

Current Behavior ( Optional for new feature )
Description
Screenshots
New Behavior
Description
Screenshots

Hi @dawntomm , please fill in pull request description following: https://github.com/google/eng-practices/blob/master/review/developer/cl-descriptions.md. Please also address all codeclimates' comments.


Enchantment Issue

when I use the enchantment command
/rpgitem [Item] enchantment clone
it doesn't put the enchantment on that item
and I'm using an item with the amount of enchant I want

Did you enchant the rpgitem itself, then clone that specific one?
It wouldn't work if you use something like an enchanted book to clone....
P.S. when you put enchantment on the rpgitem that you're trying to clone, just use /enchant


License scan is failing for efcore repo

main build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2430402&view=logs&j=883ae7c4-dae8-5f93-98eb-0436603e144a&t=0c09b83c-2547-52da-559c-7aebc0ee48a7
Error:
/mnt/vss/_work/1/s/.dotnet/sdk/9.0.100-preview.4.24178.10/Microsoft.TestPlatform.targets(46,5): error : [xUnit.net 00:17:52.32]     Microsoft.DotNet.SourceBuild.SmokeTests.LicenseScanTests.ScanForLicenses [FAIL] [/mnt/vss/_work/1/s/test/Microsoft.DotNet.SourceBuild.SmokeTests/Microsoft.DotNet.SourceBuild.SmokeTests.csproj]
/mnt/vss/_work/1/s/test/Microsoft.DotNet.SourceBuild.SmokeTests/BaselineHelper.cs(76): error VSTEST1: Microsoft.DotNet.SourceBuild.SmokeTests.LicenseScanTests.ScanForLicenses: Microsoft.DotNet.SourceBuild.SmokeTests.BaselineHelper.CompareFiles(String expectedFilePath, String actualFilePath, ITestOutputHelper outputHelper, Boolean warnOnDiffs) Assert.Null() Failure: Value is not null [/mnt/vss/_work/1/s/test/Microsoft.DotNet.SourceBuild.SmokeTests/Microsoft.DotNet.SourceBuild.SmokeTests.csproj]
/mnt/vss/_work/1/s/test/Microsoft.DotNet.SourceBuild.SmokeTests/BaselineHelper.cs(76): error VSTEST1: Expected: null [/mnt/vss/_work/1/s/test/Microsoft.DotNet.SourceBuild.SmokeTests/Microsoft.DotNet.SourceBuild.SmokeTests.csproj]
/mnt/vss/_work/1/s/test/Microsoft.DotNet.SourceBuild.SmokeTests/BaselineHelper.cs(76): error VSTEST1: Actual:   "\nExpected file '/mnt/vss/_work/1/s/artifacts/Test"··· [/mnt/vss/_work/1/s/test/Microsoft.DotNet.SourceBuild.SmokeTests/Microsoft.DotNet.SourceBuild.SmokeTests.csproj]

@Winniexu01, one thing that would be helpful when logging issues like this, is to attach the details of the detected licenses.  In the failing build, look at the artifacts and grab the UpdatesLicenses..json file from the failing leg, BuildLogs_Attempt1 artifacts.
{
  "files": [
    {
      "path": "test/EFCore.Tests/ChangeTracking/ComplexPropertyEntryTest.cs",
      "detected_license_expression": "mit AND proprietary-license"
    },
    {
      "path": "test/EFCore.Tests/ChangeTracking/MemberEntryTest.cs",
      "detected_license_expression": "mit AND proprietary-license"
    }
  ]
}

Also linking to the detailed scancode-results.json file which contains additional details on the detected licenses.

@jkoritzinsky - Looks like EFCore has some test code that is being flagged as false positives in the LicenseScanTests.  Could you please take a look and if you agree, can you update the baseline file appropriately.  Details on the license scanning can be found here.

In the failing build, look at the artifacts and grab the UpdatesLicenses..json file from the failing leg, BuildLogs_Attempt1 artifacts.

Also want to mention that https://github.com/dotnet/installer/pull/19434 (once completed) will show the updated baselines for failing tests.


Avoid using browser-specific features when building for WASM

Objective 🎯
This PR aims to improve the support for non-browser environments by introducing a new Cargo feature gate browser. This helps us prevent the usage of web-specific crates, such as wasm-bindgen, web-sys, wasm-bindgen-futures, js-sys and others when building for an environment like WebAssembly System Interface.
This ensures that Bevy remains a versatile game engine that can be used across a wide range of platforms and environments, without relying on browser-specific features that may not be available in other contexts, for example, embedding Bevy inside a WASI runtime for game extensions.
Overall, this PR seeks to enhance the flexibility and portability of the Bevy Game Engine, making it more accessible and easier to use for a broader range of developers and use cases.
Solution 💥

This PR adds a new optional but enabled by default Cargo feature gate browser.

Changelog 👩🏻💻

Added feature gate to bevy_app, bevy_asset, bevy_tasks, bevy_log and bevy_utils.
Added cfgs to only use wasm-bindgen and other crates when available.

Migration Guide 🐛

This PR is not a breaking change, and there is no need for users to migrate their code to support these changes.

Open Questions ⁉

[ ] How should we handle single-thread async tasks in WASI? We can't use wasm_bindgen_futures. For now, I used the multi-thread code with available_parallelism set to 0.
[ ] Should we add the feature gate to crates like bevy_render and bevy_audio? I think it's unneeded because we can't use WGPU inside WASI.

Also, this fixes #4906.

is it possible to use target_vendor do detect compiling for wasi instead of a feature?

That's a really good idea, but I was thinking that perhaps some users might prefer to build for WASM targets without relying on the wasm32-wasi target or using browser-specific APIs, but I'm open to use that approach.

I was thinking that perhaps some users might prefer to build for WASM targets

Are there targets others than wasm32-unknown-unknown, wasm32-wasi, and wasm32-unknown-enscripten?

I was thinking that perhaps some users might prefer to build for WASM targets

Are there targets others than wasm32-unknown-unknown, wasm32-wasi, and wasm32-unknown-enscripten?

I think those are the only ones, but some users prefer to use wasm32-unknown-unknown and then write their own OS interface layer.

Looks good! being able to run a Bevy app in CLI with wasmtime is nice. I would love to extend support of more Bevy crates, but that can happen later

Looks good! being able to run a Bevy app in CLI with wasmtime is nice. I would love to extend support of more Bevy crates, but that can happen later

Great to hear that. Adding support for more Bevy crates would definitely be a great addition. Let me know if you need any assistance in that with a follow-up PR, I'd be happy to help out.

on the top of my head:

bevy_asset even without file support, to have the asset server and the Handle types to manage procedurally generated assets, or asset retrieved somewhere else
bevy_scene which should be easy once bevy_asset is done
bevy_render to get the Mesh type for mesh manipulation. There were talks about moving the Mesh type to another crate to avoid pulling the whole renderer just to have it, but no real need for now


Bump Pydantic version to 1.9.0

Change Summary

Problem: There's been lots of work done on Pydantic since 1.8.2, and
there hasn't been a release cut for 1.9.0 yet.
Solution: Try to reduce maintainer load by following the '1.8.2 prep'
example to help with the 1.9.0 release.
Related issue number

See-also: https://github.com/samuelcolvin/pydantic/pull/2780
Checklist

[x] Unit tests for the changes exist
[x] Tests pass on CI and coverage remains at 100%
[x] Documentation reflects the changes where applicable
[x] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

please review

Hi, I know I need to make a new release, but I don't think this helps. I need to go through a lot of PRs merge then, then make a new release.
Pydantic really is on my conscience, I know I need to find some time to fix it.

Thanks for the quick response — sorry if this isn’t helpful, is there anything I can do to help? Most of my open source maintenance has been in the JS/TS ecosystem but I have lots of empathy for how much time + energy releases take.

Honestly, probably the most useful thing is to review open PRs you think look important and say:

I've tried this and it works well

Or

I've tried this and the following things don't work...

Would you be open to releasing what we have now as an alpha or similar? I've tried using master and the only bug I hit was resolved by https://github.com/samuelcolvin/pydantic/pull/3324.
For context, my team is blocked from upgrading to 3.9.8 until we can upgrade Pydantic due to https://github.com/samuelcolvin/pydantic/issues/3423.

I'm working on it, see this tweet


More missing FSCTL documentation

I am trying to make sense from a kernel point of view of what I am seeing when Win32 does a remote copy.  There is no driver documentation for these IOCTL/FSCTLS
IOCTL_COPY_CHUNK the existing (user mode) documentation is probably sufficient for drivers.
FSCTL_SRV_REQUEST_RESUME_KEY is troubling

It is defined in that page as #define FSCTL_SRV_REQUEST_RESUME_KEY CTL_CODE(FILE_DEVICE_NETWORK_FILE_SYSTEM, 30, METHOD_BUFFERED, FILE_ANY_ACCESS)  since it is not defined in any header
Although it is entitled FSCTL the device code would indicate that this is an IO (for FILE) control and so will NOT arrive down the IRP_MJ_FILE_SYSTEM_CONTROL call back, rather down the IOCTL callback.  This is certainly of importance to driver writers
But we do see 0x140144 (as an IOCTL).  This would be CTL_CODE(FILE_DEVICE_NETWORK_FILE_SYSTEM, 262, METHOD_BUFFERED,  FILE_ANY_ACCESS) and seems to do much of what SRV_REQUEST_RESUME_KEY is documented to do

The user mode documentation for IOCTL_LMR_DISABLE_LOCAL_BUFFERING does not give a CTL_CODE for it and I cannot find it in the 10.0.19041.0 WDK/SDK.  Procmon reports it by name so the definition must be somewhere.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 347e4909-0d3f-47c9-16f8-01b7d5ebb048
Version Independent ID: a4bc09cb-8fdf-1dec-cf9f-e5dbc5161ba1
Content: IFS Reference - Windows drivers
Content Source: windows-driver-docs-pr/ifs/ifs-reference.md
Product: windows-hardware
Technology: ifs
GitHub Login: @lorihollasch
Microsoft Alias: loriwhip

@lorihollasch - my apologies - I just updated the initial comment since I had my FSCTLs and my IOCTLs confused
TL;DR FSCTL_SRV_REQUEST_RESUME_KEY is an IOCTL (not an FSCTL)

@rodwiddowson , I finally got a moment to look at this. None of the IOCTLs/FSCTLs that you mention are in a public WDK header file, so I can't document them. Unless I am looking with my eyes closed ... where are you seeing these? Assuming that I am looking correctly, I'm going to close this - feel free to reopen.


Splink Spark Backend does not work on Splink v3.9.6 due to class import issue

What happens?
I am currently experimenting with Splink 3 (v3.9.6) under following environment:

Python 3.7.16
Spark 2.4.7

The goal is to see if I can run Splink with Spark 2. Especially, running record linkage with Jaro Winkler Similarity.
I am running it through Spark Backend and the example given in the docs does not work for me. Throwing following error:
py4j.protocol.Py4JJavaError: An error occurred while calling o535.registerJava.
: org.apache.spark.sql.AnalysisException: Can not load class uk.gov.moj.dash.linkage.LevDamerauDistance, please make sure it is on the classpath;
        at org.apache.spark.sql.UDFRegistration.registerJava(UDFRegistration.scala:661)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at py4j.reflection.MethodInvoker.invoke(MethodInvoker.java:244)
        at py4j.reflection.ReflectionEngine.invoke(ReflectionEngine.java:357)
        at py4j.Gateway.invoke(Gateway.java:282)
        at py4j.commands.AbstractCommand.invokeMethod(AbstractCommand.java:132)
        at py4j.commands.CallCommand.execute(CallCommand.java:79)
        at py4j.GatewayConnection.run(GatewayConnection.java:238)
        at java.lang.Thread.run(Thread.java:750)

There are some problems that I see following Spark backend, especially Spark 2.
First problem is the jar associate with Spark < 3.0. similarity_jar_location returns an invalid path if Spark < 3.0. It returns scala-udf-similarity-0.1.0_legacy.jar, although there is no legacy jar. I can see classic, but no legacy.
I handled this on my site by loading the classic jar, and it solves the issue. With this workaround, I can register JaroWinklerSimilarity function coming from uk.gov.moj.dash.linkage.JaroWinklerSimilarity and run simple test with the function.
However, the Second Problem blocks me if I do not make a change to the code. SparkLinker registers udfs from jar automatically. And amongst them, it tries to load LevDameraueDistance.
I checked the classes inside the scala-udf-similarity-0.1.0_classic.jar and the class is not available. Further checking shows that the LevDameraueDistance class is only available on 0.1.1 jar.
Is there a workaround to this problem? Would Spark 2 work with (Spark 3) 0.1.1 jar without any issue?
To Reproduce
Run Splink Spark Backend demo with Spark 2
OS:
Unix
Splink version:
3.9.6
Have you tried this on the latest master branch?

[X] I agree

Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?

[X] I agree

Thanks for the report. We're conscious of the fact that the jars aren't currently working as intended and we're planning to fix it for the next release (which should be next Wednesday).
Just a warning too, we've recently updated Splink to require python >= 3.8. We're not wedded to this, but it makes our lives easier with regards to dependency management.
If this is an issue, please do let us know and we'll see if we can work around the existing issues or just roll back some of our changes and return to supporting py 3.7.

First of all, thank you for your quick response.
Will the release next week fix the spark backend issue? And do you foresee any Spark 2 compatibility issue with it?
Unfortunately, I am bound to Python 3.7, especially if there is no strong enough argument to move to 3.8 (as you mentioned, Splink 3 is not wedded to Python 3.8). Is there any existing issue with Python 3.7 except for dependency management?
Or is there any Splink 3.x version that would be compatible with Python 3.7 + Spark 2.4.7 for the time being?


More consistent search query for AD

See https://github.com/rancher/rancher/issues/17286
Just do a basic DN search instead of a typed search, similarly to LDAP.

LGTM

LGTM


Isolate environment for downloader tests

What does this PR do?
Uses temporary folders to run tests where possible, and keeps data that is test-only ("offline") in a separate folder so that future updates to the root metadata file don't require updates to the rest of the test data.
Motivation
AITOOLS-79, #13195
Downloader tests had started to fail for reasons related to test isolation.
Additional Notes
I took an approach that avoided having to touch any code of the implementation itself, which explains all the monkeypatching and such.
Also, I implemented two fixtures to achieve a related goal:

One which works by moving everything to a temporary folder.
One which works by backing up and restoring the data.

The first one is much preferable and robust than the second one, but since there's a test that invokes the downloader in a subprocess (where monkeypatching is not possible and there's very little one can do to adjust the downloader in any way), I had to add the second approach just for that one test. I'm not sure why this test uses this 'external' approach, though.
For "offline" tests, I also had to patch a constant, since 5.core.root.layout is not present in the test data:
https://github.com/DataDog/integrations-core/blob/26b09f5ab740c75ab47afda25ca2e1f6c2ddab24/datadog_checks_downloader/datadog_checks/downloader/download.py#L53
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached
[ ] If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

out of curiousity, do we have plans (i.e. jira cards) to refactor this so that we don't have to monkeypatch a constant?


Fix katalog tiny height

A picture tells a thousand words
Before this PR
No map on mobile
After this PR
Minimize menus to show map

Coverage decreased (-0.07%) to 42.711% when pulling f33c534986528f8637dcd0bbfb0d9726ba8eac4f on fixKatalogTinyHeight into 18f6d3e59a4b61b6474412cceb704c87e4321ca2 on master.