ACRAccessToken wrong tenantID

Hi,
I'm trying to create an ExternalSecret from a ACRAccessToken but it's like the generator is not using the tenantID to authenticate (it seems it's using the ClientID).
This is the error shown in the external-secrets Pod:

{"level":"error","ts":1676298936.7215703,"logger":"controllers.ExternalSecret","msg":"could not get secret data from provider","ExternalSecret":"jsanchezmartinez/jsanchezmartinez.azurecr.io-dockerregistry-credentials","error":"could not generate [0]: ClientSecretCredential: unable to resolve an endpoint: http call(https://login.microsoftonline.com/4a05a99b-1417-4e0b-8212-278b20348e63/v2.0/.well-known/openid-configuration)(GET) error: reply status code was 400:\n{"error":"invalid_tenant","error_description":"AADSTS90002: Tenant 'YYYYYYYY-YYYY-YYYY-YYYY-278b20348e63' not found. Check to make sure you have the correct tenant ID and are signing into the correct cloud. Check with your subscription administrator, this may happen if there are no active subscriptions for the tenant.\r\nTrace ID: 639566f2-30a5-43dd-99cf-5feba5a91f00\r\nCorrelation ID: ec6934cb-00d6-4ed7-bc93-fb242bf4bb04\r\nTimestamp: 2023-02-13 14:35:36Z","error_codes":[90002],"timestamp":"2023-02-13 14:35:36Z","trace_id":"639566f2-30a5-43dd-99cf-5feba5a91f00","correlation_id":"ec6934cb-00d6-4ed7-bc93-fb242bf4bb04","error_uri":"https://login.microsoftonline.com/error?code=90002\"}","stacktrace":"github.com/external-secrets/external-secrets/pkg/controllers/externalsecret.(*Reconciler).Reconcile\n\t/home/runner/work/external-secrets/external-secrets/pkg/controllers/externalsecret/externalsecret_controller.go:190\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.1/pkg/internal/controller/controller.go:122\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.1/pkg/internal/controller/controller.go:323\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.1/pkg/internal/controller/controller.go:274\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.1/pkg/internal/controller/controller.go:235"}

And those are the yaml files I've created:
apiVersion: generators.external-secrets.io/v1alpha1
kind: ACRAccessToken
metadata:
  name: jsanchezmartinez.azurecr.io
  namespace: sandbox-registry
spec:
  auth:
    servicePrincipal:
      secretRef:
        clientId:
          key: azure_client_id
          name: azure-credentials
        clientSecret:
          key: azure_client_secret
          name: azure-credentials
  environmentType: PublicCloud
  registry: jsancnhezmartinez.azurecr.io
  tenantId: XXXXXXXX-XXXX-XXXX-XXXX-788b4c61840e

apiVersion: external-secrets.io/v1beta1
kind: ExternalSecret
metadata:
  name: jsanchezmartinez.azurecr.io-dockerregistry-credentials
  namespace: sandbox-registry
spec:
  dataFrom:
    - sourceRef:
        generatorRef:
          apiVersion: generators.external-secrets.io/v1alpha1
          kind: ACRAccessToken
          name: jsanchezmartinez.azurecr.io
  refreshInterval: 12h
  target:
    creationPolicy: Owner
    deletionPolicy: Retain
    immutable: false
    name: jsanchezmartinez.azurecr.io-dockerregistry-credentials
    template:
      type: kubernetes.io/dockerconfigjson

Am I doing something wrong? Any advice?
Regards,

Are you sure your tenant id is correct for the specified AAD endpoint? (found this SO post with similar error message)

Hi @moolen,
I am sure because I have access to our Azure AD.
My tenantID is like: XXXXXXXX-XXXX-XXXX-XXXX-788b4c61840e
My app clientID is like: YYYYYYYY-YYYY-YYYY-YYYY-278b20348e63
And the error message says "unable to resolve an endpoint: http call(https://login.microsoftonline.com/YYYYYYYY-YYYY-YYYY-YYYY-278b20348e63/v2.0/.well-known/openid-configuration). AADSTS90002: Tenant 'YYYYYYYY-YYYY-YYYY-YYYY-278b20348e63' not found."
Maybe something is wrong in my yaml files, but not able to figure out what...
Regards,

Just found it, this is a bug!

Got a PR open with a fix :point_up_2:
using a different authentication mechanism should work (e.g. azwi).
images from PR:
ghcr.io/external-secrets/external-secrets:v0.7.2-25.g9ea33729-ubi@sha256:334120a8889651ed506d0763ced0956b70e7866dd32b8725de2449183eee7a67
ghcr.io/external-secrets/external-secrets:v0.7.2-25.g9ea33729@sha256:6b825fb41b9288640c00928c61f4972451233f4e4e8a39ce5dae75e7cac1dd3a

Hi @moolen,
I can confirm it's working with image ghcr.io/external-secrets/external-secrets:v0.7.2-25.g9ea33729.
Due to the issue is already opened, do you have any example/doc about how to generate a "type=kubernetes.io/dockerconfigjson" Secret from an ExternalSecret that uses ACRAccessToken generator? I've been trying a while but the ExternalSecret is creating an "type=opaque" Secret with username/password.
Regards,

Can you take a look at the above PR? I added an example to the docs section, please let me know if that works for you

It totally worked.
Feel free to close the issue once you consider and thanks again :)


Improve our Mirage structure

💩 How it is currently developed
During our early development, we created a simple MirageJS structure, that is not optimal. Our files are starting to get big and complex, making it hard to maintain.
🌟 What is the optimal solution
We should decouple some logic, making our Mirage structure more modular.
😓 Why we did that way
To move fast.
💣 What are the possible impacts
In the future, we could encounter complex bugs, that would take hours to be fixed, leading even to a probable depreciation of Mirage at all.

@victorperin is handling this issue in our Demo application structure Jira's task.

Closed since we're now managing our engineering priorities on this Jira board.


fix proxy keyword misspelling

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 7 (28.57%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 65.657%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

fetch.go
0
1
0.0%

config.go
2
6
33.33%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
325

Relevant Lines:
495

💛  - Coveralls


feat!: upgrade Ruby and Bridgetown deployment command

Type of PR

[ ] feature
[x] enhancement
[ ] bug fix
[ ] other

Description
Waiting on outcome of #4
The deploy command is now just yarn deploy for new Bridgetown sites. The change to this code reflects that. It also makes it easier to change for the user.
NOTE: you may want to append the env to your deploy command like: NODE_ENV=production BRIDGETOWN_ENV=production yarn deploy
This change also bumps the Ruby very to the latest 2.7 release.
Fixes #5 & Fixes #6
Checklist

[x] I have tested this
[x] I have updated the documentation if applicable

@ParamagicDev could you or @MikeRogers0 possibly peak at this? Would love another set of eyes.
I am resisting the urge to make more changes atm but I want to lol.

@MikeRogers0 You were always willing to lend me a hand with my code, hop on to pair, or give me detailed code review and I will forever be grateful. It’s been several months and I am still learning from you thanks to what you were able to leave me behind.


desktop: fix links on "windows home" page, and some markdown touch-ups

fixes https://github.com/docker/docker.github.io/issues/10962

@StefanScherer @usha-mandya ptal


Unable to swipe to create a workspace on the left but able to do that on the right

Not sure if this should be a bug report or a feature request...
When the leftmost (I mean the one with the smallest number) workspace isn't workspace 1, say 2, if I swipe left on the touchpad (or maybe right phisically), I'd expect Hyprland to switch to a new workspace on the left, in this example, workspace 1, but it doesn't. By contrast, if I swipe right from the rightmost workspace, for example, 4, I can switch to workspace 5.

swipe uses e, for that we'd need r. Could be configurable

+1. Something like workspace_swipe_create_new_before would be great. I don't want to swipe to empty workspaces in-between two existing workspaces. I just want to be able to swipe left/up if there's no more workspaces before the current one.

isnt that already possible with workspace use r?

The r behavior means that workspaces in-between show up as empty and I have to swipe through them. I currently use hyprland-relative-workspaces from https://github.com/hyprwm/Hyprland/issues/1473#issuecomment-1509988996 to achieve a GNOME-like experience under Hyprland where empty workspaces can be created before and after as long as ID > 1, but won't show empty workspaces in-between.
For example, if I have the following workspaces: 4999986 4999992 4999995
r-1 will switch to workspace 4999994 instead of 4999992.

Hello @donovanglover, do you found a fix or workaround at this issue? I'm still finding a solution to swipe back and forth or specifically swipe left that swipes on the last created workspace. This seems working but since hyprland update, that feature kind have an issue.

I currently don't use a workaround but it should be trivial to create a custom swipe gesture that goes to the previous workspace. Having a variable in Hyprland would probably be cooler though


Download error

I used the following code.
let url = URL(string: urlString)
imgProfileViw.kf.indicatorType = .activity
imgProfileViw.kf.setImage(with: url, placeholder: #imageLiteral(resourceName: "tab_user_active"), options: nil, progressBlock: nil) { (img, err, cacheType, url) in
}
But failed to download. the error.localizedDescription is saying Request time out.
And there's an error.
2017-11-19 12:23:36.878490-0800 [24945:670809] Task <0AD3ADD7-F4E4-464B-9CEF-57E5AC9BFAC8>.<1> finished with error - code: -1001
2017-11-19 12:23:36.879342-0800 [24945:670809] Task <0AD3ADD7-F4E4-464B-9CEF-57E5AC9BFAC8>.<1> HTTP load failed (error code: -999 [1:89])
I hope your help.

As indicated by the error message, it is a request timeout.
Please make sure you have correct Internet connection to your resource. I believe there is little we could do in Kingfisher.

Thank you for your response.
I think there's a problem.
It always fail to download image.
My internet connection is good.
The other apps using SDWebImage works well.

So can I know the URL you are using? We need more information on this before we could get to know what happens.

https://s3-us-west-1.amazonaws.com/cutup-debug/2008/profile/o0t1j5ec.bho.jpeg

Hey, @actualfan
It works pretty fine for me, at least in the demo app contained in this repo.

So I guess there must be some other reason instead of in Kingfisher for it. I strongly suggest you check your network setting and/or proxy setting in both your system and app.

Interesting 🤔. I'm encountering this issue as well. It loads some images and for others, this issue occurs.

Same issue with me

I'm encountering the same issue as well. Using Swift 4

I am facing the same issue as well. When the image is .jpeg extension it does not work

same issue with me, using Kingfisher 4.7.0

Interesting,when I commentimageView.kf.indicatorType = .activity, it's works well

@sp0cket This issue should not relate to the indicator, but a thread issue which cannot be reproduced easily. Do you have some code to reproduce this problem stably?

Same issue with me,Using Kingfisher 4.7.0
Image: http://rdtest.myhiott.com:8081/uploadImage/2018/04-17/img_1523929328770.png
Task <AC6932EE-ACA2-41BE-BB38-AFF8B76F9920>.<1> finished with error - code: -1002

Same here, error code -999.
The image displays itself when not using KingFisher

Interesting,When I commentimageView.kf.indicatorType = .activity, It's works well

This solved the timeout issue @onevcat could you please look at this.
Using the latest version of kingfisher

@onevcat You could reproduce it using the tableview and using same url on multiple cell


Feature: Quantities now support decimals

This PR stops cart items from being re-ordered when they are updated.
Adds 2 new tests and fixes the functionality.
Fixes #2

Fixes #3 sorry.


data is missing from workspace

Describe the bug
Hi, so I think its less of bug and rather a user issue.
I have a folder datsets with subfolders like datasets/set1
I've added a stage with:
dud stage gen -o datasets/set1 | tee set1.yaml

I setup a remote cache (webdav) and pushed. Everything seems to work fine.
I put my yamls on a git repo and now wanted to fetch it on different machine
I did
dud fetch

It seems to download the data into the cache, but it does not create the symlinks.
dud status

set1.yaml        stage definition up-to-date
  datasets/set1  missing from workspace

I guess I'm doing somehting wrong?
 Its
dud checkout set1.yaml


Materialize relation on single insert, fixes #57

Could you add a test for this using sqlite? Here's a sample setup:
container = ROM.container(:sql, 'sqlite::memory') do |config|
  config.gateways[:default].connection.create_table :users do
    primary_key :id
    String :name, null: false
  end
end

We could have it in the shared examples, because it's already used in relation_spec.rb

Will have to do that tonight


Enable NEON for ChromeOS devices

Chrome uses openh264 to encode video frames for MediaRecorder APIs.
However, on ChromeOS, the encoding procedure is run in renderer process,
which can not access /proc/cpuinfo, making openH264 think that NEON is
not available.
Since all arm-based ChromeOS devices have NEON, it can be marked as
enabled anyway.

ship


run the wasm component in web worker

to avoid blocking the main thread. this should be done for the webcomponent first: https://github.com/DigitalKhatt/digitalkhatt.org/tree/master/examples/webcomponent

update: this is blocked by https://github.com/DigitalKhatt/visualmetafont/blob/master/src/weblib/quranshaper.h#L200 QuranShaper::shapeText since it takes the canvas ctx, which can't be passed to the worker.


Extending an already resolved configuration no longer works correctly [backport 7.x]

See

#24109

Resolved with #25166


Added CNN Pytorch Implementation

Added simple Pytorch implementations for popular CNN models

Add image of model architecture as jpeg/png.

On it. Thanks for pointing out.


Performance: by-field End-point

Npm once had a by-field end-point that allowed you to retrieve just the metadata field you want for a package.
More background information on how package-json package tried to leverage that API end-point before it was removed can be found in sindresorhus/package-json/issues/9
I've requested that the API end-point be added back here - npm/registry/issues/93
If we can encourage npm to add back the API end-point, we can just request the versions field instead of fetching all of a package's metadata.

Closing, as this is impossible without changes from npm.


Getting error when initialising django-zebra

actions done

pip install django-zebra
zebra included in INSTALLED_APPS
added the webhook urls
re_path(r'zebra/', include(('zebra.urls', 'zebra'), namespace="zebra",)),
ZEBRA_ENABLE_APP set to True
then tried ./manage.py makemigrations , got error

  File "project_name/manage.py", line 11, in <module>
    execute_from_command_line(sys.argv)
  File "/home/aditya/dev/cn/pmx_env/lib/python3.7/site-packages/django/core/management/__init__.py", line 381, in execute_from_command_line
    utility.execute()
  File "/home/aditya/dev/cn/pmx_env/lib/python3.7/site-packages/django/core/management/__init__.py", line 357, in execute
    django.setup()
  File "/home/aditya/dev/cn/pmx_env/lib/python3.7/site-packages/django/__init__.py", line 24, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/home/aditya/dev/cn/pmx_env/lib/python3.7/site-packages/django/apps/registry.py", line 114, in populate
    app_config.import_models()
  File "/home/aditya/dev/cn/pmx_env/lib/python3.7/site-packages/django/apps/config.py", line 211, in import_models
    self.models_module = import_module(models_module_name)
  File "/usr/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/aditya/dev/cn/pmx_env/lib/python3.7/site-packages/zebra/models.py", line 51, in <module>
    class Subscription(DatesModelBase, StripeSubscription):
  File "/home/aditya/dev/cn/pmx_env/lib/python3.7/site-packages/zebra/models.py", line 52, in Subscription
    customer = models.ForeignKey(Customer)
TypeError: __init__() missing 1 required positional argument: 'on_delete'```

Hey @aditya-cns , thanks for this report - at first glance, this looks like you're using a newer version of django than this project supports.  It hasn't been updated in a number of years, so back then, on_delete wasn't required.
I'd welcome a PR to bring it up to date, but if you're just trying to get things done, honestly, the built-in strip libraries these days are pretty straightforward.  I've built one out not using django-zebra recently, and it was almost as easy as using django-zebra.
Closing this for now, but feel free to reopen if you'd like to take on updating this project with a PR!  :)

thank you @skoczen for the advice. Appreciate it.👍
I will definitely try to update this with a PR.


[Modular][SDK] Multiple JavaFX jars on module path

Using a combination of JavaFX SDK and dependencies on a modular HelloFX project results in multiple javafx-controls jars on the module path.
For example:
javafx {
    sdk = "location-to-javafx-sdk-11"
    modules = [ 'javafx.controls', 'javafx.fxml' ]
}
dependencies {
    compile 'org.controlsfx:controlsfx:11.0.1';
}

The module path looks like:
--module-path
hellofx/build/classes/java/main;
.m2/repository/org.controlsfx/controlsfx/11.0.1/controlsfx-11.0.1.jar;
javafx-sdk-11/lib/javafx.controls.jar;
javafx-sdk-11/lib/javafx.fxml.jar;
.m2/repository/org/openjfx/11.0.2/javafx-web-11.0.2.jar;
.m2/repository/org/openjfx/javafx-controls/11.0.2/javafx-controls-11.0.2.jar;
.m2/repository/org/openjfx/javafx-swing/11.0.2/javafx-swing-11.0.2.jar;
.m2/repository/org/openjfx/javafx-media/11.0.2/javafx-media-11.0.2.jar;
.m2/repository/org/openjfx/javafx-graphics/11.0.2/javafx-graphics-11.0.2.jar;
.m2/repository/org/openjfx/javafx-base/11.0.2/javafx-base-11.0.2.jar

There are 2 instances of javafx-controls.jar from the following locations:

JavaFX SDK
As a transitive dependency from ControlsFX

@abhinayagarwal You should be able to use the Gradle exclude method nested below the compile method that declares the controlsfx dependency.

Possible same as #65

Possible same as #65

All the years this wasn't a problem with me, but now I encounter the same problem in Eclipse with javafx17. I also tried the newest patch release 17.0.01 and excluded controlsfx but both the normal ones, then the mac and linux specific javafx libs are added.


Platform 566 add bounding box explore

This PR change a few thing in Explore API:

[x] Extract methods to a helper (this class is becoming more than a rake)
[x] Add geometry fields (bbox, view_box, etc) to the table
[x] Added GIST index for bbox and visual box to the table
[x] Change insertion method to be able to insert geometries
[ ] Add test

@juanignaciosl please review this PR

I've done some comments about code style that can be taken into account or not, they're not important. But the concern about the name is bigger and might be an actual problem. Once it's checked or solved, :+1:


Cross Browser Tests

CrossBrowser Integration Testing with SauceLabs.
CircleCi integration with Saucelabs:
https://circleci.com/docs/1.0/browser-testing-with-sauce-labs/

Add the resulting BrowserMatrix Badge to our Readme: https://wiki.saucelabs.com/display/DOCS/Using+Status+Badges+and+the+Browser+Matrix+Widget+to+Monitor+Test+Results

Which Testing Framework to use?

Would be nice to test jet.js with and without Polyfills. To show two different BrowserMatrix.

Use Karma as Test-Runner:
It has an karma-runner for SauceLabs: https://github.com/karma-runner/karma-sauce-launcher
proide two different config Files for Karma. One for local builds, with headless chrome and one for CI Tests with the SauceLabs integration.

As Testing Framework MochaJS should be used. A Karma Adapter is available here: https://github.com/karma-runner/karma-mocha

Wich Browsers should be tested?
Preact uses the following config:
	sl_chrome: {
		base: 'SauceLabs',
		browserName: 'chrome',
		platform: 'Windows 10'
	},
	sl_firefox: {
		base: 'SauceLabs',
		browserName: 'firefox',
		platform: 'Windows 10'
	},
	sl_safari: {
		base: 'SauceLabs',
		browserName: 'safari',
		platform: 'OS X 10.11'
	},
	sl_edge: {
		base: 'SauceLabs',
		browserName: 'MicrosoftEdge',
		platform: 'Windows 10'
	},
	sl_ie_11: {
		base: 'SauceLabs',
		browserName: 'internet explorer',
		version: '11.103',
		platform: 'Windows 10'
	},
	sl_ie_10: {
		base: 'SauceLabs',
		browserName: 'internet explorer',
		version: '10.0',
		platform: 'Windows 7'
	},
	sl_ie_9: {
		base: 'SauceLabs',
		browserName: 'internet explorer',
		version: '9.0',
		platform: 'Windows 7'
	}

Angular.js this one:
      'SL_Chrome': {
        base: 'SauceLabs',
        browserName: 'chrome',
        version: '59'
      },
      'SL_Firefox': {
        base: 'SauceLabs',
        browserName: 'firefox',
        version: '54'
      },
      'SL_Safari_8': {
        base: 'SauceLabs',
        browserName: 'safari',
        platform: 'OS X 10.10',
        version: '8'
      },
      'SL_Safari_9': {
        base: 'SauceLabs',
        browserName: 'safari',
        platform: 'OS X 10.11',
        version: '9'
      },
      'SL_IE_9': {
        base: 'SauceLabs',
        browserName: 'internet explorer',
        platform: 'Windows 2008',
        version: '9'
      },
      'SL_IE_10': {
        base: 'SauceLabs',
        browserName: 'internet explorer',
        platform: 'Windows 2012',
        version: '10'
      },
      'SL_IE_11': {
        base: 'SauceLabs',
        browserName: 'internet explorer',
        platform: 'Windows 8.1',
        version: '11'
      },
      'SL_EDGE': {
        base: 'SauceLabs',
        browserName: 'microsoftedge',
        platform: 'Windows 10',
        version: '14'
      },
      'SL_iOS': {
        base: 'SauceLabs',
        browserName: 'iphone',
        platform: 'OS X 10.10',
        version: '8.1'
      },

I think it's important to test mobile Browsers too.

Chrome:
v60 (currently the newest version) and the current Beta version
Firefox:


Faq page

Let's add links to our discord channel.
I created a permanent link to the discord welcome channel:
https://discord.gg/JRNWnnva9g
Let's put this link in a few places for now:

A new FAQ page

At the top of the page put a link to the discord site with a statement about joining.
Then, list some FAQs with some answers.  To get started, you can start with some trivial questions about installation and provide a link to here https://alps.comp-phys.com/install/   The undergrads can help with the FAQ page.

Put the discord link at the top of the installation page as well

The top right corner next to the GitHub symbol if possible.

The FAQs page has been added with links to discord and some questions.


[MRG] Fix to docstring

Continuation for https://github.com/mne-tools/mne-python/pull/2824.

Sorry for missing those the first time around!

LGTM. +1 for merge.

Merged.


multiple select backspace not removing

key backspace result in text instead of complete removal last item

That is the intended behavior, I used the same behavior as that of the select2 JQuery plugin. I would like to stick to that for the moment.

Hope you reconsider. Its UX unfriendly. My users instantly complained, after replacing so I switch back to ng2-selectize. Do like a native solution though, but my users are  always right..

Its UX unfriendly

I think that's a matter of taste and what you are used to. As said, for the 1.0 release I will stick to the select2 approach. Thanks for the input, I'll close this issue for now.


[naver/pinpoint#6598] change download location

Fix another two endpoints
Signed-off-by: Patricio Pérez<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add contextual Readme display

My project has inline documentations in readme files in subdirectories.
Unfortunatly gitlist only display the root readme.
Here is a patch that shows "contextual" readme if it exists, or the root one.

It works for me. Please merge this patch!

@fmntf this has been merged.


Stryker init with vue should now use "vitest"

Is your feature request related to a problem? Please describe.
Currently, the Vue initializer uses jest. It was based on vue 2 projects.
https://github.com/stryker-mutator/stryker-js/blob/master/packages/core/src/initializer/custom-initializers/vue-js-initializer.ts#L15-L25
Describe the solution you'd like
We should migrate to vitest. It should work out-of-the-box with vue projects that are created using the guide on their site.
Describe alternatives you've considered
Additional context
We also have 2 vue e2e tests that should be updated in the same PR.

Released in 7.1


Add/remove stages depending on the result of a PredicateFilter

I am trying to add or remove a series of stages based on a calculation performed inside a PredicateFilter. The main idea is to have a generic "Pick" container that detects the location of a collision object and constructs the task differently depending on its location. For example, if we call "pick object" and it is inside a drawer, we would execute some preliminary stages to open the drawer. On the other hand, if it is on the table, we would pick it directly.
I am not sure how to pass the condition calculated in the lambda function of setPredicate to the necessary stages. I tried setting the result to a property or using a global variable within the container, but the value is not updated. I suspect this is because setPredicate is only executed when we call task->plan(), not when the task is constructed.
Any ideas on how to do this properly?

I've just realized that I can achieve this by using a Fallbacks container with a PredicateFilter in each branch to check for each location. Here's an example:
Fallbacks
  PredicateFilter (check if the object is in the drawer)
    SerialContainer
      ...
      ...
      (stages defining the movement to open the drawer)

  PredicateFilter (check if the object is on the table)
    NoOp (don't add additional stages if the object is on the table)

I was previously looking for a solution like this because it adds less boilerplate in simple cases where you just need to modify some properties of the stage. Although, it doesn't work as explained in the first comment:
std::string current_location;

{
    auto dummy_state = std::make_unique<mtc::stages::NoOp>("dummy state");
    auto applicability_filter = std::make_unique<mtc::stages::PredicateFilter>("applicability check", std::move(dummy_state));

    applicability_filter->setPredicate([this, object, &current_location](const mtc::SolutionBase &s, std::string &comment) {

      auto scene = s.start()->scene();

      // Calculate the current location of the object
      (...)
      current_location = calculated_location;

      return true;
    });

    container->insert(std::move(applicability_filter));
  }

(...)

{
  auto stage = std::make_unique<mtc::stages::MoveRelative>("approach", cartesian_planner_);

  (...)

  if (current_location == "drawer") {
    stage->setMinMaxDistance(0.03, 0.05);
    vec.vector.z = -1.0;
  } else if (current_location == "shelf") {
    stage->setMinMaxDistance(0.1, 0.15);
    vec.vector.x = -1.0;
  } else {
    stage->setMinMaxDistance(0.05, 0.15);
    vec.vector.z = 1.0;
  }
  stage->setDirection(vec);
  container->insert(std::move(stage));
}

I'm going to close the issue, as it seems that using Fallbacks mainly solves what I need. However, if you know any other way of doing it, don't hesitate to comment it.

Both, the Fallbacks and Alternatives container are suitable to solve your problem.

I slightly prefer Fallbacks as it implies that only one branch can be successful at a time. This allows us to use the last branch without a PredicateFilter to provide the default behavior in case no other condition is met. Although this is also possible with Alternatives, we would need to add a PredicateFilter that negates the conditions of the other branches, which could be more error-prone.
Is it possible to do something similar to the code I sent?
Thanks @rhaschke

I'm not fully sure, whether or not you have an open question here. I don't think there is currently another way of implementing your task with something else than a Fallsbacks container with appropriate predicate filters. Note that this approach is rather inefficient: Solutions will be first generated by the wrapped SerialContainer and then filtered (instead of directly switching to the right SerialContainer).
I'd suggest to implement your problem with two independent Tasks, selecting one or the other based on your location estimation.
One could also implement a new Switch-Case-Container, that - based on some property of the incoming trajectory - decides to use one of n children for processing the solution.

Thanks for pointing out the performance implications of this approach, I didn't realize that. Currently, we only have simple MoveRelative stages within each fallback branch, so there is no significant drawback in planning time. If, in the future, we have more complex needs, I will consider implementing a Switch-Case Container, I think it is the best solution for this case.

I'm reopening the issue as I encountered a problem with this approach. If MoveRelative succeeds, it progrates correctly to PredicateFilter. We force PredicateFilter to always fail and it triggers correctly the second branch of the Fallbacks container. Everything good here:

However, if MoveRelative fails, the failure is not propagated to the PredicateFilter and the second branch of the Fallbacks is never calculated:

This is the relevant code:
auto fallbacks = std::make_unique<mtc::Fallbacks>("Fallbacks");

// First fallback branch
{
  auto stage = std::make_unique<mtc::stages::MoveRelative>("MoveRelative: force it to fail", cartesian_planner_);
  (...) // Creating a collision to force it to fail

  auto filter = std::make_unique<mtc::stages::PredicateFilter>("PredicateFilter: force it to fail", std::move(stage));
  filter->setPredicate([](const mtc::SolutionBase &s, std::string &comment) {
    return false;
  });

  fallbacks->add(std::move(filter));
}

// Second fallback branch
{
  auto stage = std::make_unique<mtc::stages::MoveRelative>("MoveRelative: force it to succeed", cartesian_planner_);
  (...)

  auto filter = std::make_unique<mtc::stages::PredicateFilter>("PredicateFilter: force it to succeed", std::move(stage));
  filter->setPredicate([](const mtc::SolutionBase &s, std::string &comment) {
    return true;
  });

  fallbacks->add(std::move(filter));
}

// Default fallback, just passing through
{
  auto stage = std::make_unique<mtc::stages::NoOp>("NoOp: Default fallback");
  fallbacks->add(std::move(stage));
}

task->add(std::move(fallbacks));

Why a failed stage is not propagated to trigger another branch of the Fallbacks container? Is there a bug here @rhaschke?

This indeed looks like a bug. Need to investigate...

Sorry for the late reply. I wrote a unittest (#594) for your example, but that doesn't fail. Could you please double check your code and/or provide a failing minimal example - ideally based on the proposed unittest?

Thank you for taking the time to write a test! It actually fails on my setup. I am using ROS2, which might be the reason. Sorry for not specifying this at first. I tested with the latest commits from the humble branch (I had to manually add the NoOp stage because it hasn't been ported to humble yet).

Here is the test ouput:
build/moveit_task_constructor_core/Testing/20240716-1314/Test.xml: 12 tests, 0 errors, 1 failure, 0 skipped
- moveit_task_constructor_core-test-fallback
  <<< failure message
    -- run_test.py: invoking following command in '/home/dani/support_ws/build/moveit_task_constructor_core/test':
     - /home/dani/support_ws/build/moveit_task_constructor_core/test/moveit_task_constructor_core-test-fallback --gtest_output=xml:/home/dani/support_ws/build/moveit_task_constructor_core/test_results/moveit_task_constructor_core/moveit_task_constructor_core-test-fallback.gtest.xml
    Running main() from gmock_main.cc
    [==========] Running 10 tests from 3 test suites.
    [----------] Global test environment set-up.
    [----------] 1 test from FallbacksFixtureGenerator
    [ RUN      ] FallbacksFixtureGenerator.stayWithFirstSuccessful
    [       OK ] FallbacksFixtureGenerator.stayWithFirstSuccessful (4 ms)
    [----------] 1 test from FallbacksFixtureGenerator (4 ms total)

    [----------] 8 tests from FallbacksFixturePropagate
    [ RUN      ] FallbacksFixturePropagate.failingNoSolutions
      0  - ←   0 →   -  0 / task pipeline
        1  - ←   1 →   -  0 / GEN1
        -  0 →   0 →   -  0 / Fallbacks
          -  0 →   0 →   -  0 / FWD1
          -  0 →   0 →   -  0 / FWD2
    Failing stage(s):
    [       OK ] FallbacksFixturePropagate.failingNoSolutions (0 ms)
    [ RUN      ] FallbacksFixturePropagate.failingWithFailedSolutions
      0  - ←   0 →   -  0 / task pipeline
        1  - ←   1 →   -  0 / GEN1
        -  0 →   0 →   -  0 / Fallbacks
          -  0 →   0 →   -  0 / FWD1
          -  0 →   0 →   -  0 / FWD2
    Failing stage(s):
    FWD1 (0/1)
    [       OK ] FallbacksFixturePropagate.failingWithFailedSolutions (0 ms)
    [ RUN      ] FallbacksFixturePropagate.computeFirstSuccessfulStageOnly
    [       OK ] FallbacksFixturePropagate.computeFirstSuccessfulStageOnly (1 ms)
    [ RUN      ] FallbacksFixturePropagate.computeFirstSuccessfulStagePerSolutionOnly
    [       OK ] FallbacksFixturePropagate.computeFirstSuccessfulStagePerSolutionOnly (0 ms)
    [ RUN      ] FallbacksFixturePropagate.successfulWithMixedSolutions
    [       OK ] FallbacksFixturePropagate.successfulWithMixedSolutions (0 ms)
    [ RUN      ] FallbacksFixturePropagate.successfulWithMixedSolutions2
    [       OK ] FallbacksFixturePropagate.successfulWithMixedSolutions2 (0 ms)
    [ RUN      ] FallbacksFixturePropagate.activeChildReset
    [       OK ] FallbacksFixturePropagate.activeChildReset (0 ms)
    [ RUN      ] FallbacksFixturePropagate.filterPropagatesFailures
      0  - ←   0 →   -  0 / task pipeline
        1  - ←   1 →   -  0 / GEN1
        -  0 →   0 →   -  0 / Fallbacks
          -  1 →   0 →   -  0 / filter
            -  0 →   0 →   -  0 / FWD1
          -  1 →   0 →   -  0 / filter
            -  1 →   0 →   -  0 / FWD2
          -  1 →   0 →   -  0 / no-op
    Failing stage(s):
    FWD1 (0/1)
    /home/dani/support_ws/src/moveit_task_constructor/core/test/test_fallback.cpp:180: Failure
    Value of: t.plan()
      Actual: false
    Expected: true
    /home/dani/support_ws/src/moveit_task_constructor/core/test/test_fallback.cpp:181: Failure
    Value of: costs
    Expected: has 1 element that is equal to 2
      Actual: {}
    [  FAILED  ] FallbacksFixturePropagate.filterPropagatesFailures (0 ms)
    [----------] 8 tests from FallbacksFixturePropagate (1 ms total)

    [----------] 1 test from FallbacksFixtureConnect
    [ RUN      ] FallbacksFixtureConnect.connectStageInsideFallbacks
    [       OK ] FallbacksFixtureConnect.connectStageInsideFallbacks (0 ms)
    [----------] 1 test from FallbacksFixtureConnect (0 ms total)

    [----------] Global test environment tear-down
    [==========] 10 tests from 3 test suites ran. (5 ms total)
    [  PASSED  ] 9 tests.
    [  FAILED  ] 1 test, listed below:
    [  FAILED  ] FallbacksFixturePropagate.filterPropagatesFailures

     1 FAILED TEST
      YOU HAVE 2 DISABLED TESTS

    -- run_test.py: return code 1
    -- run_test.py: inject classname prefix into gtest result file '/home/dani/support_ws/build/moveit_task_constructor_core/test_results/moveit_task_constructor_core/moveit_task_constructor_core-test-fallback.gtest.xml'
    -- run_test.py: verify result file '/home/dani/support_ws/build/moveit_task_constructor_core/test_results/moveit_task_constructor_core/moveit_task_constructor_core-test-fallback.gtest.xml'
  >>>
build/moveit_task_constructor_core/test_results/moveit_task_constructor_core/moveit_task_constructor_core-test-container.gtest.xml: 19 tests, 0 errors, 0 failures, 0 skipped
build/moveit_task_constructor_core/test_results/moveit_task_constructor_core/moveit_task_constructor_core-test-cost-queue.gtest.xml: 11 tests, 0 errors, 0 failures, 0 skipped
build/moveit_task_constructor_core/test_results/moveit_task_constructor_core/moveit_task_constructor_core-test-cost-terms.gtest.xml: 9 tests, 0 errors, 0 failures, 0 skipped
build/moveit_task_constructor_core/test_results/moveit_task_constructor_core/moveit_task_constructor_core-test-fallback.gtest.xml: 12 tests, 0 errors, 1 failure, 2 skipped
- moveit_task_constructor_core.FallbacksFixturePropagate filterPropagatesFailures
  <<< failure message
    /home/dani/support_ws/src/moveit_task_constructor/core/test/test_fallback.cpp:180
    Value of: t.plan()
      Actual: false
    Expected: true
    /home/dani/support_ws/src/moveit_task_constructor/core/test/test_fallback.cpp:181
    Value of: costs
    Expected: has 1 element that is equal to 2
      Actual: {}
  >>>
build/moveit_task_constructor_core/test_results/moveit_task_constructor_core/moveit_task_constructor_core-test-interface-state.gtest.xml: 3 tests, 0 errors, 0 failures, 0 skipped
build/moveit_task_constructor_core/test_results/moveit_task_constructor_core/moveit_task_constructor_core-test-mockups.gtest.xml: 2 tests, 0 errors, 0 failures, 0 skipped
build/moveit_task_constructor_core/test_results/moveit_task_constructor_core/moveit_task_constructor_core-test-properties.gtest.xml: 13 tests, 0 errors, 0 failures, 0 skipped
build/moveit_task_constructor_core/test_results/moveit_task_constructor_core/moveit_task_constructor_core-test-pruning.gtest.xml: 13 tests, 0 errors, 0 failures, 0 skipped
build/moveit_task_constructor_core/test_results/moveit_task_constructor_core/moveit_task_constructor_core-test-serial.gtest.xml: 3 tests, 0 errors, 0 failures, 0 skipped
build/moveit_task_constructor_core/test_results/moveit_task_constructor_core/moveit_task_constructor_core-test-stage.gtest.xml: 4 tests, 0 errors, 0 failures, 0 skipped
build/moveit_task_constructor_core/test_results/moveit_task_constructor_core/test-move-relative.xunit.xml: 2 tests, 0 errors, 0 failures, 0 skipped
build/moveit_task_constructor_core/test_results/moveit_task_constructor_core/test-move-to.xunit.xml: 2 tests, 0 errors, 0 failures, 0 skipped

Summary: 105 tests, 0 errors, 2 failures, 2 skipped

It seems that in my last message I was not using the latest commits from both MTC and moveit2. Using the latest changes has apparently resolved the issue, as the test you provided no longer fails and the example I shared works as expected:

I will do some checks over the next few days, but it seems we can close this issue for now.


(bug) Aniplay video is empty

Source information
Aniplay 14.8
Source language
English
Steps to reproduce
1.open the extension
2.search bleach
3.trying to watch
Expected behavior
The video is working
Actual behavior
The video is empty
Aniyomi version
Aniyomi App version: <IP_ADDRESS>-8019
Android version
Motorola
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

fixed


cmd/compile: compile dense, pure-integer "switch" into jump table

Dense switch statements containing only integer cases can be compiled into a JMP table
to gain performance.

Depending on the density threshold the code size might be similar or even smaller.

Base64: the character set spreads from 43 to 122 (= 80) ==> density of 80 % (good)

hex: 0-9a-fA-F = 48..102 = 55 ==> 40 % (probably too low)

I have posted numbers in https://github.com/golang/go/issues/19791#issuecomment-353321716 about implementing a func(rune) bool as an if, as a switch, and as a [128]bool table. Unsurprisingly, the last method is the fastest.

Currently, for constants if the number of cases is less than 4, we use linear search when switching between cases in the resulting AST. Otherwise, the compiler converts switches with long runs of constants into an AST that uses binary search and this speeds case switching but also range recognition and coalescing was added by @josharian in June 2016 in CL https://go-review.googlesource.com/26770
Extrapolating from the status quo:

Scenario
Cost(case lookups/comparisons)

Worst case scenario: individual, non contiguous ranges
log2(n)

Best case contiguous ranges
1

I believe that the range coalescing is something that the original reporter wanted and unless am mistaken, the current implementation solves the current problem.
/cc @josharian @randall77 @rsc , is there perhaps something we could do more here? Also please feel free to correct and educate me :)

Jump tables are distinct from range coalescing. There's a good discussion of jump tables, generalized jump tables, and other switch optimizations in  https://www.nextmovesoftware.com/technology/SwitchOptimization.pdf. See also #15780.
I think we should leave this open; jump table support is of continuing interest, I believe.

Awesome, thank you @josharian! I'll digest the content of the referenced text and hopefully look at
getting something in for the next Go releases.

@odeke-em cool. The first step is to get support for jump tables into the object file format and assembler. Making the compiler generate them is a second step. Note that the paper I referenced (which is a great read) sheds some doubt about whether jump tables are a good idea. There will definitely be some experimentation required.


pageLoadFailure on successful request

I have a strange issue I'm trying to resolve, or at the very least find its source.
I have a controller action that renders successfully on web, but fails on iOS with a pageLoadFailure.  When I monitor the request cycle, I see that the request completes successfully without issue, but then my SessionDelegate receives didFailRequestForVisitable with the error.
I have some error handling that pops a native error view controller on error, but when I disable it I see that the underlying webview pretty much looks as it should, with the exception of the navigation bar - it's missing title and back navigation.
I'm trying to find the source of this error, but everything besides the SessionDelegate indicates success so I don't have much to go on.  In what situations does Turbo trigger a pageLoadFailure?  I'd expect some accompanying error from the server, turbo js or the browser but see nothing indicating a problem.
Thanks!

I found the cause of this issue: a recent change loads the Turbo javascript asynchronously in some contexts, so Turbo iOS would raise a pageLoadFailure if not available early enough.
Closing now.

But how do you fix it?

I'm also wondering how this was fixed as I'm experiencing the same error.


reduced scenario length

Codecov Report

Merging #75 (9b8910f) into master (337b09f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   96.13%   96.13%
=======================================
  Files           5        5
  Lines         414      414
=======================================
  Hits          398      398
  Misses         16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 337b09f...9b8910f. Read the comment docs.


[DC-2085] Modernize integration tests in achilles_heel_test to use GCS

Refactor integration test to use StorageClient.
Minor changes to function load_cdm_csv in bq_utils.py to accommodate changes made to the integration test.

@nishanthpp93 , this is now easier to differentiate, it includes the latest from develop, and all tests are passing.


ApiRequestTool implementation

This pull request adds a new ApiRequestTool to the crewai_tools package. The tool allows making API calls with configurable endpoint URLs, HTTP verbs and request data.

Oh nice good catch all API tool I wonder if we should add a few extra optional arguments tho like authentication and authorization header just to make sure people can auth in some APIS


No text specified

{"level":"error","ts":1582365546.2839491,"caller":"mlog/log.go:174","msg":"No text specified","path":"/hooks/","request_id":"97djk1nefiyw8dru3zazdeiiec","ip_addr":"<IP_ADDRESS>","user_id":"","method":"POST","err_where":"HandleIncomingWebhook","http_code":400,"err_details":""}

@YankeeTube  Were you able to resolve the error ?? Currently i am facing same error while integrating the matter-most with sentry

@jaydipkmn No, I've already given up. kk


feat: mocha tests

I hereby confirm that I followed the code guidelines found at engineering guidelines
⚙ Affected Components

[ ] Commands
[ ] Modules
[ ] Services
[ ] SDK

📝 Notes for the Reviewer

Initial test setup following oclifs suggested mocha setup, using their test helpers, etc.
Uses:

https://github.com/oclif/test
https://github.com/nock/nock

Examples:

https://github.com/box/boxcli
https://github.com/wordup-dev/wordup-cli
https://github.com/fauna/fauna-shell
https://github.com/satyarohith/shark
https://github.com/SmartBear/swaggerhub-cli

🏗 New Dependency Submission

🎟 Affected Issue

This is the mocha scaffolding and a few initial tests. I'll leave the jest based PR open for just as comparison (its in a bit of an ugly state atm fyi so don't judge me :see_no_evil: :joy: https://github.com/checkly/checkly-cli/pull/64).


[Feature]: Complete trigger

Nice work with this plugin.
I am looking somehow to trigger a function to mark the state as completed without sliding. Like in my case is for something that was already completed and I am saving the state on the DB.
Looking at the code I dont see a way of doing this, or am I wrong?

Hello, @vdiaza. Thank you!
I made an additional "complete" method in the component to set the completed state.
More info about the method and how to use it in the README.


Feature/parallel 2000

Scope & Purpose
Support for traversal parallelism (enterprise only)
Enterprise companion PR: https://github.com/arangodb/enterprise/pull/455
PR has no CHANGELOG entry and yet no documentation. Further tests need to be added to cover lots of cases. However, this PR should provide the base functionality and extensions for the cluster-internal traffic and query execution, and it should be merged ASAP.

[x] Strictly new functionality (i.e. a new feature / new option, no need for porting)
[x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
[x] The behavior change can be verified via automatic tests

Testing & Verification
This change is already covered by existing tests, such as all cluster AQL tests.
This PR adds tests that were used to verify all changes:

[x] Added new integration tests (i.e. in shell_server, enterprise part only)

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/9926/

Yet another run for fun: http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/9930/


Network policies

https://app.zenhub.com/workspaces/dev-5e7e84dddc966f05a627a19b/issues/redkubes/unassigned-issues/73
This PR implements ingress network policies for teams.
Checklist

[ ] Architecture Design Records have been added as adr/*.md and appended to list in adr/_index.md.
[x] The values-schema.yaml file and test/** fixtures have been updated to reflect code changes.
[ ] The OpenApi Schema from redkubes/otomi-api project is compatible with definitions from values-schema.yaml file.

@j-zimnowoda approved...do you want to update values (such as image tag) after merging?

Thanks, I will update it on Monday


Allow use of custom content filters

Instead of expanding the docker image with all possible content filters I would like to see the possibility of configuring postfix to foward mails to another IP+port for content filtering and accept it on another port for further processing of the mail chain.
I acknowledge that this could endanger the security of the mailserver if the firewall is not setup correctly to ensure that the receiving port is not exposed to the outside world.
In my specific case I would like to use this feature to include my existing popfile installation for mail filtering. I like the management part of it so I prefer to continue to use it.
It would accept the mails from postfix on a specific IP and port and after processing sent it back it postfix on a specific port.
At this moment I have no clue where this should be best integrated in the scripting. If you could give some pointer I could try to create a pull request.

Not sure if it makes sense (I'm no expert in this and I haven't researched it), but wouldn't it be easier to just connect to the content filtering running on the other host instead? If I remember correctly we're using domain sockets here, but on another server I think I used an IP address and port to get around SELinux issues. If you're lucky you can get what you want simply by tweaking the configuration.

This issue was closed due to one or more of the following reasons:

Age
Contributor inactivity
The issue seems to be resolved

If you think this happened by accident, or feel like this issue was not actually resolved, please feel free to re-open it. If there is an issue you could resolve in the meantime, please open a PR based on the current master branch so we can review it.


mountOptions ignored when set for topolvm storage class

Describe the bug
A standard option for storage classes is mountOptions. When this field is set for a storage class using the topolvm.cybozu.com provisioner, it gets set for the PV, but the options don't actually get applied to the mount. This prevents use of a performance optimization, which is to use "noatime" instead of "relatime" for the mount.
Environments

Version: Any
OS: Any

To Reproduce
Steps to reproduce the behavior:
Configure the topolvm storage class as follows:
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: topolvm-provisioner
mountOptions:
- noatime
provisioner: topolvm.cybozu.com
parameters:
  "csi.storage.k8s.io/fstype": "xfs"
volumeBindingMode: WaitForFirstConsumer

Apply this manifest:
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
  name: local-ephemeral-pvc
spec:
  storageClassName: topolvm-provisioner
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 5Gi
---
kind: Pod
apiVersion: v1
metadata:
  name: test-local-ephemeral-pvc-pod
spec:
  volumes:
    - name: local-ephemeral-pvc-storage
      persistentVolumeClaim:
        claimName: local-ephemeral-pvc
  containers:
    - name: task-pvc-container
      image: busybox
      command:
        - sleep
        - "3600"
      volumeMounts:
        - mountPath: "/mnt/storage"
          name: local-ephemeral-pvc-storage

Expected behavior
The volume would be mounted with the "noatime" option.  What actually happens is it gets mounted with the default "relatime" .
Additional context
The PV seems to be set up as expected:
kubectl get pv -o jsonpath='{.spec.mountOptions}' pvc-ed55d014-73d4-4b49-a408-77ae1cca296f
[noatime]

But the actual mount options don't match that:
kubectl -n local-ephemeral-pvc-testnamespace exec test-local-ephemeral-pvc-pod mount | grep mnt
/dev/topolvm/b6a1f665-5d1d-4f85-b9f2-8e5b6d9c4224 on /mnt/storage type xfs (rw,seclabel,relatime,wsync,attr2,inode64,noquota)

@matthias50
Thank you for your report, we'll confirm it.

@matthias50
I confirmed your report.
As you said, TopoLVM ignores StorageClass.mountOptions currently.
However, the scope of mountOptions is widely, and it will affect the existing code.
It seems that solving this issue is not easy,
so we will work on this problem in the next milestone.

@matthias50
My team discussed this issue and decided to leave it as a limitation for now.
https://github.com/cybozu-go/topolvm/pull/109
We will progress other higher-priority issues in milestone 1.0.
Your pull request on this issue is always welcome.

close via #109

The current implementation clearly is not conforming to the specifications,
so the issue still needs to be resolved with #96.


Markdown formatted URLs not properly detected as Safelinks URLs

I encountered this today when attempting to use dslg to decode a formatted email.
This pattern decodes properly:
[placeholder](https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fatc0005%2Fsafelinks&data=data_placeholder&sdata=sdata_placeholder&reserved=0)
This pattern does not:
[https://github.com/atc0005/safelinks](https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fatc0005%2Fsafelinks&data=data_placeholder&sdata=sdata_placeholder&reserved=0)
The URL pattern within the URL anchor is enough to throw things off.

Might be worth a look:

https://github.com/yuin/goldmark

Dependencies used by this project are already using it, so it's already in the dependency tree.


AOT-DebugX64 crash

Found by extra DartFuzz run to find out why nightly is crashing often:
Isolate (/b/s/w/ir/tmp/t/dart_fuzzLIQXOB) AOT-DebugX64 - JIT-DebugSIMARM: !DIVERGENCE! 1.2:3
503681466 (output=false)
fail1:
../../runtime/vm/compiler/backend/constant_propagator.cc: 1472: error: expected: reachable_->Contains(if_false->preorder_number())
thread=26969, isolate=isolate(0x55d4bea02900)
[0x000055d4bd6e285c] Unknown symbol
[0x000055d4bd6e285c] Unknown symbol
[0x000055d4bd9c56b2] Unknown symbol
[0x000055d4bd803bdf] Unknown symbol
[0x000055d4bd802ce4] Unknown symbol
[0x000055d4bd8d2a3d] Unknown symbol
[0x000055d4bd8d233f] Unknown symbol
[0x000055d4bd8d2607] Unknown symbol
[0x000055d4bd7d68f9] Unknown symbol
[0x000055d4bd7d9388] Unknown symbol
[0x000055d4bd7d2e74] Unknown symbol
[0x000055d4bd7d16dd] Unknown symbol
[0x000055d4bd7cca20] Unknown symbol
[0x000055d4bd7ca218] Unknown symbol
[0x000055d4bd7c9daf] Unknown symbol
[0x000055d4bd9b8d46] Unknown symbol
[0x000055d4bd426bf4] Unknown symbol
-- End of DumpStackTrace
/b/s/w/ir/cache/builder/sdk/pkg/vm/tool/precompiler2: line 106:

The issue happens on this branch:
    CheckNull:98(v736 T{_Double?})
    v1409 <- Redefinition(v736) T{_Double}
    v114 <- RelationalOp(>=, v105, v1409 T{_Double}) T{bool}
    Branch if StrictCompare:102(===, v114, v21) goto (11, 14)

where we get null-valued constant_value() due to an initial null value on v0 for two phis.
SetValue(v0 <- Constant(#null))=null

SetValue(v662 <- phi(v0, v658) alive T{_Double?})=null
SetValue(v1407 <- Redefinition(v662) T{_Double})=null

SetValue(v736 <- phi(v0, v732) alive T{_Double?})=null
SetValue(v1409 <- Redefinition(v736) T{_Double})=null

Missing case for RelationalOp resulted in no value. Fix out for review.

Slava notes:
I looked at the predicates for IsConstant and IsNonConstant and they seem to be null safe.
However I just realized that they are using marker values that have kNullCid as their CID.
Maybe something goes wrong because of that.

Looks like the definition of v105 causes the problem:

v105 <- BinaryDoubleOp(-, v1407 T{_Double}, v104) T{_Double}

sees the definite values null and Infinity, but it never gets a definite outcome itself


vscode jest debug profile with external jest-config

Holla,
I'm trying to create a jest debug profile with external config.
but i always get the following message:
Error: Can't find a root directory while resolving a config file path.
{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Debug Jest Tests",
            "type": "node",
            "request": "launch",
            "port": 9229,
            "runtimeArgs": [
                "--inspect-brk",
                "${workspaceRoot}/node_modules/jest/bin/jest.js",
                "-i",
                "-t should dispatch GetAccessToken Test",
                "-c ${workspaceRoot}/jest-config.json",
            ],
            "console": "integratedTerminal",
            "internalConsoleOptions": "neverOpen"
        },
    ]
}

while running jest with config from cli is possible, im not able todo this from a vscode debug profile.
on cli you can pass config with -c jest-config.json
any advice?
regards
tristan

@firsttris what do you mean by "external config"?
A "launch.json" will only be found if you open a project folder in VS Code (otherwise there is no ".vscode" folder where the launch.json could live).
BTW, a somewhat simpler and clearer config for jest is:
        {
            "name": "Debug Jest Tests",
            "type": "node",
            "request": "launch",
            "program": "${workspaceFolder}/node_modules/jest/bin/jest.js",
            "args": [
                "-i",
                "-t should dispatch GetAccessToken Test",
                "-c ${workspaceFolder}/jest-config.json",
            ],
            "console": "integratedTerminal",
            "internalConsoleOptions": "neverOpen"
        }

Hey @weinand
thx for taking the time to reply to my issue!
with external config i mean external Jest config jest-config.json
if the jest-config is located in package.json i have no issue.

i updated my debug-profile to the more cleaner version, thx!
i have no issues running Jest with external config from CLI.
i have no issue with running VSCode Debug Profile for Jest and Jest-config in Package.json
but with VSCode Debug Profile for Jest and Jest-Config in a external file e.g. /jest-config.json

Does it make a difference if you make the "jest-config.json" relative, e.g.
```json
        {
            "name": "Debug Jest Tests",
            "type": "node",
            "request": "launch",
            "program": "${workspaceFolder}/node_modules/jest/bin/jest.js",
            "args": [
                "-i",
                "-t should dispatch GetAccessToken Test",
                "-c jest-config.json",
            ],
            "console": "integratedTerminal",
            "internalConsoleOptions": "neverOpen"
        }

Same Issue
(already tried all possible variants for absolut & relative paths)
Error: Can't find a root directory while resolving a config file path.
Provided path to resolve:  jest-config.json
cwd: /home/firsttris/Projects/sfmdigital
    at exports.default (/home/firsttris/Projects/sfmdigital/node_modules/jest-config/build/resolve_config_path.js:42:11)
    at readConfig (/home/firsttris/Projects/sfmdigital/node_modules/jest-config/build/index.js:72:84)
    at getConfigs (/home/firsttris/Projects/sfmdigital/node_modules/jest/node_modules/jest-cli/build/cli/index.js:342:56)
    at /home/firsttris/Projects/sfmdigital/node_modules/jest/node_modules/jest-cli/build/cli/index.js:173:27
    at Generator.next (<anonymous>)
    at step (/home/firsttris/Projects/sfmdigital/node_modules/jest/node_modules/jest-cli/build/cli/index.js:129:40)
    at /home/firsttris/Projects/sfmdigital/node_modules/jest/node_modules/jest-cli/build/cli/index.js:148:20
    at new Promise (<anonymous>)
    at /home/firsttris/Projects/sfmdigital/node_modules/jest/node_modules/jest-cli/build/cli/index.js:126:16
    at runCLI (/home/firsttris/Projects/sfmdigital/node_modules/jest/node_modules/jest-cli/build/cli/index.js:213:22)

@firsttris the error message you are seeing originates from jest, not from VS Code. So you might want to investigate on the jest side as well, e.g. https://github.com/facebook/jest/issues/3499.

i thought so as well..
but...

this issue only happens within a VSCode Debug Profile. not from CLI
In Webstorm i have also not issue debugging with external jest-config
A jest config change (like suggested in the issue you liked) won't help since jest can't find the config in the first place

continue investigating on both sides

So where does the jest-config.json actually live?

jest-config.json is in the ProjectRoot Directory.
i found out if i rename the jest-config.json to jest.config.js
it finds the config without --config (-c) argument
because they setup some default names, for look for:
https://github.com/facebook/jest/blob/master/packages/jest-config/src/constants.js#L16
       {
            "name": "Debug Jest Tests",
            "type": "node",
            "request": "launch",
            "program": "${workspaceFolder}/node_modules/jest/bin/jest.js",
            "args": [
                "-i",
                "-t should dispatch GetAccessToken Test"
            ],
            "console": "integratedTerminal",
            "internalConsoleOptions": "neverOpen"
        }

for me this workaround is acceptable.
if you don't want to explore further why --config (-c) is not working, we can close this issue

Oh, I think I know what the problem is.
A construct like "-c jest-config.json"  must be passed as two separate arguments, e.g. "-c", "jest-config.json". The equivalent "--config=jest-config.json" can be passed as one.
Try this:
        {
            "name": "Debug Jest Tests",
            "type": "node",
            "request": "launch",
            "program": "${workspaceFolder}/node_modules/jest/bin/jest.js",
            "args": [
                "-i",
                "-t", "should dispatch GetAccessToken Test",
                "-c", "jest-config.json"
            ],
            "console": "integratedTerminal",
            "internalConsoleOptions": "neverOpen"
        }

thanks for your help, your suggestion is working!

Great, and sorry for not spotting this earlier.


LabelledGeneric and scala 2.10

LabelledGeneric seems not to work anymore in a scala 2.10 project (when used outside shapeless itself). For example, the following doesn't compile:
case class Foo0()

case class Foo1(i: Int)

object Lgen {
import shapeless._

LabelledGeneric[Foo0]
LabelledGeneric[Foo1]
}

sbt compile gives:
> compile
[info] Compiling 1 Scala source to /home/alexandre/projects/lgen-2.10.x/target/scala-2.10/classes...
[error] /home/alexandre/projects/lgen-2.10.x/Lgen.scala:8: could not find implicit value for parameter lgen: shapeless.LabelledGeneric[Foo0]
[error] LabelledGeneric[Foo0]
[error] ^
[error] /home/alexandre/projects/lgen-2.10.x/Lgen.scala:9: could not find implicit value for parameter lgen: shapeless.LabelledGeneric[Foo1]
[error] LabelledGeneric[Foo1]
[error] ^
[error] two errors found
[error] (compile:compile) Compilation failed
[error] Total time: 2 s, completed 2 janv. 2015 01:43:08
>

(All the files to reproduce this error are available here: https://gist.github.com/alexarchambault/1fd71d804f0661ad51c1).
The type parameter R (the one filled by the macro) may be the problem, as the following compiles:
case class Foo0()

case class Foo1(i: Int)

object Lgen2 {
import shapeless._
import language.experimental.macros

// Works with this one, but hard to do anything with it then...
implicit def lgen[T]: shapeless.LabelledGeneric[T] = macro shapeless.GenericMacros.materializeLabelled[T, Nothing]

// Does *not* work with this one
// implicit def lgen[T, R]: shapeless.LabelledGeneric.Aux[T, R] = macro shapeless.GenericMacros.materializeLabelled[T, R]

LabelledGeneric[Foo0]
LabelledGeneric[Foo1]
}

So adding
addCompilerPlugin("org.scalamacros" % "paradise" % "2.0.1" cross CrossVersion.full)

to build.sbt fixes it...
Maybe we could add a warning about that in the README or the wiki...

Yes, that is the case: the plugin supports "fundep materialisation" in 2.10.x. That improves consistency of shapeless client code between 2.11.x and 2.10.x, which outweighs the inconvenience of the plugin IMO.
You're right that this needs to be added to the README.


fead:added bookmark notes feature

Description
The changes made in this pull request aim to enhance the functionality related to bookmarked notes
Resolves: #51
Checklist
Before submitting this pull request, kindly verify that the ensuing checkpoints have been reached.

[x] Have you adhered to the repository's defined coding convention rules?
[x] Have you updated the 'documentation.md' file with the method/function documentation?
[x] Have you sent a message along with the result or response?
[x] Have you used the try-catch technique?
[x] Has the method/class been added to the documentation (md file)?

Screenshots
Uploading a screenshot illustrating the approach developed for validation is required. (Please attach the screenshot)

I certify that I have carried out the relevant checks and provided the requisite screenshot for validation by submitting this pull request.

@Sahilll15 hey I can you please change the bookmark icon if the note is book marked
Make it appear filled
And also if a fill bookmark is clicked it should be removed from bookmarks

@Sahilll15 hey I can you please change the bookmark icon if the note is book marked Make it appear filled And also if a fill bookmark is clicked it should be removed from bookmarks

the removal of the bookmark already works ill make the icon change

@hereisSwapnil have a look at the commit


Importin Windows spesific ctypes causes traceback

When trying yo use examples on Linux following traceback appears:
Traceback (most recent call last):
  File "/home/jtiai/projects/pygame_gui/pygame_gui_examples/general_ui_test_app.py", line 4, in <module>
    from pygame_gui.ui_manager import UIManager
  File "/home/jtiai/projects/pygame_gui/pygame_gui/__init__.py", line 3, in <module>
    from . import elements
  File "/home/jtiai/projects/pygame_gui/pygame_gui/elements/__init__.py", line 11, in <module>
    from .ui_text_entry_line import UITextEntryLine
  File "/home/jtiai/projects/pygame_gui/pygame_gui/elements/ui_text_entry_line.py", line 8, in <module>
    from ..core.utility import clipboard_paste, clipboard_copy
  File "/home/jtiai/projects/pygame_gui/pygame_gui/core/utility.py", line 7, in <module>
    from ctypes.wintypes import HGLOBAL, LPVOID, BOOL, UINT, HANDLE, HWND, DWORD, INT, HMENU, HINSTANCE, LPCSTR
  File "/usr/lib/python3.7/ctypes/wintypes.py", line 20, in <module>
    class VARIANT_BOOL(ctypes._SimpleCData):
ValueError: _type_ 'v' not supported

Root cause of traceback is attempt to import Windows specific ctypes ctypes.wintypes which is only available on Windows.

Thanks.
Getting some linux testing up and running today on a raspberry pi hopefully
so I should be able to squash this and any other things that slipped
through the cracks.
On Sat, Nov 2, 2019 at 10:07 AM Jani Tiainen<EMAIL_ADDRESS>wrote:

When trying yo use examples on Linux following traceback appears:
Traceback (most recent call last):
File "/home/jtiai/projects/pygame_gui/pygame_gui_examples/general_ui_test_app.py", line 4, in
from pygame_gui.ui_manager import UIManager
File "/home/jtiai/projects/pygame_gui/pygame_gui/init.py", line 3, in
from . import elements
File "/home/jtiai/projects/pygame_gui/pygame_gui/elements/init.py", line 11, in
from .ui_text_entry_line import UITextEntryLine
File "/home/jtiai/projects/pygame_gui/pygame_gui/elements/ui_text_entry_line.py", line 8, in
from ..core.utility import clipboard_paste, clipboard_copy
File "/home/jtiai/projects/pygame_gui/pygame_gui/core/utility.py", line 7, in
from ctypes.wintypes import HGLOBAL, LPVOID, BOOL, UINT, HANDLE, HWND, DWORD, INT, HMENU, HINSTANCE, LPCSTR
File "/usr/lib/python3.7/ctypes/wintypes.py", line 20, in
class VARIANT_BOOL(ctypes._SimpleCData):ValueError: type 'v' not supported
Root cause of traceback is attempt to import Windows specific ctypes
ctypes.wintypes which is only available on Windows.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MyreMylar/pygame_gui/issues/29?email_source=notifications&email_token=ADGDGGQTIXU7DG5QNS3F22TQRVGMPA5CNFSM4JIEPQ22YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HWKBB3Q,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADGDGGQE5UMXWSH6BOSD73DQRVGMPANCNFSM4JIEPQ2Q
.


Added Tagfile generation and search

Working on Ubuntu 16.04, I don't know if this can directly work on macOS/Windows.

Thanks for your contribution.
So now the end user has a new CMake variable, SFML_DOC_DIR, that points to this new file, SFML.tag. And then what? Can you explain what this stuff does?

Never used it before, but it's obviously a feature by DoxyGen to include library documentation without reparsing the source.

Yes, using this tagfile, a project documentation generated by Doxygen can link to the sfml documentation. I think it could help to easily make user-friendly documentations for those projects, which is always good for new users ! And it is a really small change anyway


Description is not synchronized on yeoman.io/generators

http://yeoman.io/generators/
It seems that generator's description is not synchronized.
generator-graybullet-cordova's description is Webapp like yeoman generator for Apache Cordova.
$ npm info generator-graybullet-cordova description
Webapp like yeoman generator for Apache Cordova

However, the description is displayed as Apache Cordova.

Old description of the generator was Yeoman generator for Apache Cordova.
description that appears in yeoman.io appear to be the ones that have been deleted "Yeoman generator for". Old ones seem to have been displayed.
What should I do in order to synchronize the description?

We strip useless things some the description as mentioning it's a "Yeoman generator" is superfluous. The generator description should say what it does, not what it is.
And per the description from the generator page:

Your generator must have the "yeoman-generator" keyword and a repo description to be listed.

We use the repo description.

I'm sorry. I was a misunderstanding.
I Understand that it used  GitHub repo description, not NPM description.
I've rewritten the description of GitHub. Let’s wait and see for a while.

Thaks!
Now, If I look at the yeoman.io, it had been synchronized. :smile:


Add client.UpdateMetadata

What this PR does / why we need it?
Add client.UpdateMetadata.
Any background context you want to provide?
This PR applies the Client Metadata update feature implemented in Go.
What are the relevant tickets?

Fixes https://github.com/yorkie-team/yorkie/issues/153
Checklist

[x] Added relevant tests or not required
[x] Didn't break anything

@ppeeou Thanks for your comments.
How about using UpdateMetadata for data that needs to be transmitted to peers, but not stored(e.g. position of eraser) in CodePair drawing?

@hackerwins  sure! when this feature is released, I am going to prepare to upload a PR


Add skus PUT to upsert sku definitions

Modify POST /skus to 409 on name conflict
Create PUT /skus to upsert a sku definition
Modify POST /skus/pack to 409 on name conflict

@RackHD/corecommitters @uppalk1 @tannoa2 @keedya @brianparry
Resolves https://github.com/RackHD/RackHD/issues/113

*** BUILD #981 ***
Test Name: SKU Pack Service hould post a sku should post a sku
Error Details: Object #<Object> has no method 'findOne'
Stack Trace: TypeError: Object #<Object> has no method 'findOne'
    at SkuPackService.postSku (lib/services/sku-pack-service.js:9:2243)
    at Context.<anonymous> (spec/lib/services/sku-pack-service-spec.js:187:31)

Test Name: test_node_workflows_del_active
Error Details: (400)
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Content-Length': '78', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"4e-w9iAPXulXUwtqaIDfelxVg"', 'Date': 'Wed, 20 Apr 2016 15:44:39 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"TaskCancellationError: Failed to cancel 5717a3e442ea8b7070073ff7"}

Stack Trace: Traceback (most recent call last):
  File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/on-http/RackHD/test/tests/api/v2_0/nodes_tests.py", line 340, in test_node_workflows_del_active
    raise e
ApiException: (400)
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Content-Length': '78', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"4e-w9iAPXulXUwtqaIDfelxVg"', 'Date': 'Wed, 20 Apr 2016 15:44:39 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"TaskCancellationError: Failed to cancel 5717a3e442ea8b7070073ff7"}

:+1: it will be better to fix my comment.


SP4:  LegendViewer is throwing an unmanaged exception error.

Bug Report
Issue:
Index out of limit error occurs when playing with the detached legend viewer.
Reproducing:

Download the Windows Forms demo from here: https://scottplot.net/demo/
Click on the Launch ScottPlot Cookbook button
Choose the Legend Orientation demo from the Legend category
Right click on choose the Detach Legend option
Left click into the Legend Viewer to unselect the sin and cos plots
Left click in the empty interactive plot windows
Left click into the Legend Viewer on the sin or cos plot

System Details

ScottPlot Version: 4.1.67
Operating System: Windows 10 Pro
Application Type: WinForms

Thanks so much for this detailed bug report @LapinFou! I was able to resolve this issue and the fix will be in the next release 🚀


advanced search

is it possible to add a search by several parameters at the same time, as it is done in the PoE skill tree ("|" separator)

I think I replied to you on reddit already so I am gonna just copy paste that mag here just to keep track of this
"Aah i see, so you put stuff like "slum lord|superiority" in the search field and it will highlight them in the results, gotcha. I will implement this, as of now i am just waiting for GGG's response to this all, whether they will keep this as it is or change seeds and make it server sided? So once that is confirmed i will put more work in otherwise all this would be obsolete in coming weeks. Once it is confirmed i will add this feature in 24 hrs."

Added 'highlight' functionality for easy visibility. Cheers.
"Timeless Jewel Reverse Search v1.5-beta"


PHP Warning appears parameter is an array

Are you sure this is not a problem with your configuration? (ask on the
Google Group)

Minify commit/version: All (currently using 2.1.4 )
PHP version: All

What steps will reproduce the problem?
1. Builder is enabled
2. Open https://fluidsignal.timedoctor.com/v2/views/min/b=js&f%5B%5D=bla

Explanation: preg fails when the f parameter is an array, and PHP errors out
(depending on the server configuration). This error includes server paths.

Solution:
Verify the parameter is not an array
http://php.net/manual/en/function.is-array.php

Expected output:
Nothing.

Actual output:
Warning: preg_match() expects parameter 2 to be string, array given in
/var/www/cysoco/v2/views/min/lib/Minify/Controller/MinApp.php on line 92

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 29 May 2012 at 10:35
Attachments:

2012-05-29-173223_1366x768_scrot.png

Good catch.

Original comment by<EMAIL_ADDRESS>on 30 May 2012 at 12:00

Changed state: Accepted

Fixed in 666cd6d89a22:
For manual patching (I don't recomment) see:
http://code.google.com/p/minify/source/diff?spec=svn666cd6d89a224bbf3715b07be5f2
430c4c226a03&old=f7d73dcc566c99223138b525b37f6c6465a6704b&r=666cd6d89a224bbf3715
b07be5f2430c4c226a03&format=unidiff&path=%2Fmin%2Flib%2FMinify%2FController%2FMi
nApp.php

Original comment by<EMAIL_ADDRESS>on 4 Jun 2012 at 3:52

Changed state: Verified
Added labels: Release-2.1.5

Hello, is there any temporal patch for this? I would like to point it out to
somebody using Minify. Thanks

Original comment by<EMAIL_ADDRESS>on 4 Jun 2012 at 3:34


Can't find variable: atob (Jose.min.js) for React Native Project

I'm trying to integrate the library inside a react native project and it gives me this issue. Have some tried implementing json web encryption for react native?

You will need a atob polyfill

Does the following help? In some environments (e.g. node), atob/btoa don't exist but you can use Buffer.
function btoa(data) { return new Buffer(data, "binary").toString("base64"); }
function atob(data) { return new Buffer(data, "base64").toString("binary"); }

I have faced this issue and I have not solutions.

@MrLich does the above snippet now work for you? You just need to have btoa and atob functions be defined in the global scope.

@MrLich does the above snippet now work for you? You just need to have btoa and atob functions be defined in the global scope.

Thanks, I have solved it by adding more code .

@MrLich
how did you solve?  thanks

I had the same problem. I solved it by requiring this polyfill in my project

I had the same problem and found online the below that I added to my App.js file. It works for me
import {decode, encode} from 'base-64'
if (!global.btoa) {  global.btoa = encode }
if (!global.atob) { global.atob = decode }

I had the same problem and found online the below that I added to my App.js file. It works for me
import {decode, encode} from 'base-64'
if (!global.btoa) { global.btoa = encode }
if (!global.atob) { global.atob = decode }

it is not working for me

I had the same problem and found online the below that I added to my App.js file. It works for me
import {decode, encode} from 'base-64'
if (!global.btoa) { global.btoa = encode }
if (!global.atob) { global.atob = decode }

it is not working for me

Installing the base-64 npm package and then adding the import code above to App.js file solved my issue.

Installing the base-64 npm package and then adding the import code above to App.js file solved my issue.

This solved my problem too!

https://www.npmjs.com/package/@react-native-anywhere/polyfill-base64. helped me. Дапамагло мне


[REQ] Remember feed positions when switching tabs

Describe the problem that needs solving
All feeds currently return to the top when switching between navigation tabs (Tweets, Tweets &  Replies, Media, etc.), which is undesirable since we may have scrolled far down when reading and wish to return to it quickly.
It is also easy to accidentally switch tabs due to the sensitivity of the left and right swipe gestures. Swiping through an image gallery in the post can also accidentally trigger this.
Describe the solution you'd like
Cache posts and remember scroll positions when switching between tabs so we can quickly return to them. If updating the feed is an issue, add a drag down from the top of the screen gesture to trigger a manual refresh, if new posts cannot be simply added to the top of the feed and have scroll positions be recalculated.

Closing as the feed has now been removed, due to Twitter blocking access permanently. Please see https://github.com/jonjomckay/fritter/issues/668#issuecomment-1528784190


Feature/7840 create order item

Story: AB#7840
Task: AB#7847

Looking good. There are just four unresolved comments that I'm guessing github might have made difficult to find 😃

Yes it had, thanks 👍


Wallet API to create new currencies

We have a contract for doing this now, which I think fulfils the spirit.


Build improvements (+ update stb libraries)

Update stb libraries (there were some problems with the STB*DEF macros in the older versions). I tested animated scenery and all seemed to be well.
Just use standard C tools to export functions from stb.dll instead of the CMake trick.
CMake option to not build GNS (I believe closes #73).
Download GNS release instead of shallow clone. Helps avoid intermittent performance issues, I believe due to https://gitlab.kitware.com/cmake/cmake/-/issues/17770 .
Don't use lib prefix for GameNetworkingSockets.dll on WIndows, this just makes people rename libraries for no reason.
Fix Windows CI, windows-latest was recently updated to Windows Server 2022 and the path to vcvarsall.bat changed.
Add soldat.res back into source control. I removed it because I failed to consider using build systems other than Lazarus on a clean checkout, but its required for them to build.

I think soldat.res changes every time I make a build with Lazarus. Will I have to add it in every commit?

No it can be safely ignored, just don't add it to your commits. A note about this should be made somewhere (CONTRIBUTING.md probably).


Allow validating local datasets

I just tried validating a local file, and the tool didn't seem to work - the link I used was https://ome.github.io/ome-ngff-validator/?source=file:///Users/dstansby/notebooks/ct-scans/david_ct_scan.zarr, and the directory definitely exists. The error message is:
Error Loading file:///Users/dstansby/notebooks/ct-scans/david_ct_scan.zarr/.zattrs: TypeError: NetworkError when attempting to fetch resource.

The easiest solution is to use ome-zarr-py:
$ ome_zarr view path/to/ct-scans/david_ct_scan.zarr

That will serve the zarr locally and automatically open it in ome-ngff-validator.
See https://ome-zarr.readthedocs.io/en/stable/cli.html#view
It actually looks best if you don't add the trailing slash as above (not like in the docs)


Colision with Place Footrpints action plugin

Hi, a used (@codeman256) had an issue running my plugin (Place Footprints). Looking at the log file it seems that pcbnewTransition has an effect also on plugins that don't use it.

This should be already resolved in eb27d4b6c640034e0a600372c8da35b7a63038d2 (and it is already released).

Thanks for the prompt response.


Update Settings “general”

Automatically generated by Netlify CMS

👷 Deploy Preview for koytak processing.

Name
Link

🔨 Latest commit
c9da4e44e7d06c283ced34a4d96c901f8a711fa4

🔍 Latest deploy log
https://app.netlify.com/sites/koytak/deploys/65160cb99eaea900088d3064


Carousel fixes

This PR fixes a few carousel issues.

Ensures carousel works in IE10 and IE11 by removing the transform3d detection mixin entirely as all our supported browsers support it. There was no fallback being provided, so IE10/11 were left in the dark as we were keying off -webkit detection. Fixes #22198.

Fixes the image aspect ratio issues. Also moved from .img-fluid to .w-100 in our examples. Pulls in @vanduynslagerp's fix from #21799. Fixes #21658, fixes #21966, closes #21799.

Changes the timing function from ease-in-out to ease to fix the "bouncing" into place when carousel items move. This kinda sucks, but there's no other CSS change I can see us making to fix this issue. Fixes #21685, fixes #21751, fixes #22291.

Still doesn't works for me (only Chrome)
This will only work on v4beta?


aws-amplify Browserify is not defined

I am by no means a webpack wizard, so some help to point me in the right direction would be great.
If I do a fresh clone of the repo and install the aws-amplify package on running the project I get an error saying “Browserify is not defined” it appears to be stemming from crypto-Browserify which this package leverages when doing auth.
I am 99% sure I’m just missing something in the webpack configs, and of course I have searched for the solution but to no avail.

it uses c so its probably a native dependency. Try installing it to ./app/package.json instead of ./package.json. See my explanation

As a note for whoever passes by here, the package to install in ./app/package.json is aws-amplify, not crypto-browserify


d3.least[Index] should promote single-argument accessors to comparators.

Like d3.bisector does.
https://github.com/d3/d3-array/pull/108#issuecomment-493894485

Fixed in #111.


Need to tell user they are not connected to augur-node

There's a possibility that user losses connection to augur-node and doesn't know it. The block processing won't tell them since all block processing numbers come from augur-node.
User could be in a state where data isn't updating and they are making trades and not seeing the result.
I recommend some indication where Blocks Behind is that informs the user.

How does this issue get resolved for users?

Actually the UI should show the Not currently connected modal. That might be the real issue.

just tested and UI does show Reconnecting to Augur Node and if fails shows correct connection Modal. I'll close this.
What I saw was UI connecting to a augur-node that isn't fully synced. I think that is a rare edge case. closing


layout issue with bulk operations

when selecting multiple items i am getting the following layout...

@dylandepass could this be related to your recent styling updates?

Interesting.. I'm not able to reproduce with the released version of Sidekick Next Gen. What about you @rofe?

@davidnuescheler What project did you see this on? Any reproductions steps you can provide.

No, I haven't been able to reproduce it either.

Saw this on @tripodsan's screen yesterday, so I guess it's still a thing...

Should be fixed with #301, feel free to reopen if it persists.


CheckboxWithLabel returns empty array instead of true

Below is how I am implementing the checkbox.
                          <Field
                                Label={{label: 'Remember me'}}
                                checked={false}
                                onChange={() => console.log('checked')}
                                name="remember"
                                value="1"
                                color="primary"
                                component={CheckboxWithLabel}
                            />

When I check the box it returns empty array instead of boolean. This causes the error below:
Warning: Failed prop type: Invalid prop `checked` of type `array` supplied to `ForwardRef(Checkbox)`, expected `boolean`.

I'm having the same issue, but with a Switch element. Had to downgrade Formik to version 2.0 to make it work, but maybe 1.5.8 is safer...
Would be great if somebody could tell us when this might get solved or if there is any other work around.

the problem appears since version 1.0.0
can check here : https://codesandbox.io/s/competent-kare-j2y7g

the problem appeared with formik 2.0.1-rc5 to be precise : https://codesandbox.io/s/competent-kare-j2y7g

Same problem for me, downgrading formik to 2.0.0 temporarily fix the issue, but throws other warnings.
Checking PR #113 to see if it fixes

I've managed to get i work but couldn't use formik-material-ui, here's a hack while waiting for a fix:
import { Formik, Form, Field, ErrorMessage } from 'formik';
import Switch from '@material-ui/core/Switch';
import FormControlLabel from '@material-ui/core/FormControlLabel';

<Formik initialValues={{ switch: false }}>{form => (
    <Form className="form">
        <FormControlLabel
          control={<Field name="switch" component={Switch} />}
          label="My label"
          name="switch"
          required={true}
          onChange={(ev, checked) => { form.setFieldValue('terms', checked); }}
        />
        <ErrorMessage name="terms" />
    </Form>
)}</Formik>

Using onChange prop I can manually set the form state using the Formik context.

@riderodd Thanks for the solution. Below I have added the CheckBox version of your solution.
<FormControlLabel
     control={<Field name="remember" component={Checkbox} />}
     label="Remember me"
     name="remember"
     onChange={(ev, checked) => { setFieldValue('remember', checked); }}
     />

https://github.com/jaredpalmer/formik/blob/c0fe1b928b903405b8591f7250b66a8aa9828650/src/Formik.tsx#L1052
export const fieldToCheckbox = ({
  field,
  form: { isSubmitting },
  disabled,
  ...props
}: CheckboxProps): MuiCheckboxProps => {
  return {
    disabled: disabled != undefined ? disabled : isSubmitting,
    ...props,
    ...field,
    // TODO handle indeterminate
    checked: field.value,
    value: field.value ? 'true' : 'false',
  };
};

same problem using Switch

For Switch (boolean behaviour i.e. not multiple), I managed to make it work in Formik 2 natively (without  formik-material-ui), using <Field as> syntax.
Extract:
import Switch from "@material-ui/core/Switch"
import FormControlLabel from "@material-ui/core/FormControlLabel"
import { Field, Form, Formik } from "formik"
...<Formik><Form>...
              <FormControlLabel
                control={
                  <Field
                    name="someBool"
                    id="someBool"
                    type="checkbox" // seems required to handle correctly initial values of true
                    as={Switch}
                  />
                }
                label="Subunit based placement"
              />

using formik 2.0.6 and material-ui 4.6.1

For Checkboxes with many options, I did this and it works for me. Without using formik-material-ui.
<FormControl component="fieldset">
  <FormLabel component="legend">Choose the ones you want</FormLabel>
  <FormGroup>
    {options.map(opt => (
      <FormControlLabel
        control={
          <Field
            name="my_options"
            id="my_options"
            value={opt.value}
            as={Checkbox}
          />
        }
        key={opt.value}
        label={opt.label}
      />
    ))}
  </FormGroup>
  <FormHelperText>Be careful</FormHelperText>
</FormControl>

"formik": "^2.1.4"

Please retry with the latest version.
Also check the migration notes

Done! With the latest version (formik-material-ui v2.0.0-beta.1) is now like this:
<FormControl component="fieldset">
  <FormLabel component="legend">
    Choose the ones you want
  </FormLabel>
  <FormGroup>
    {options.map(opt => (
      <Field
        component={CheckboxWithLabel}
        type="checkbox" //REQUIRED to work with non-boolean options
        name="my_options"
        value={opt.value}
        key={opt.value}
        Label={{ label: opt.label }}
      />
    ))}
  </FormGroup>
  <FormHelperText>Be careful</FormHelperText>
</FormControl>

Looks good. But the documentation does not say anything about the type="checkbox" to work with non-boolean values.

@mrjdavidfg glad you got it working

But the documentation does not say anything about the type="checkbox" to work with non-boolean values.

What exactly do you mean?

As @r3mi also said, its necessary the type="checkbox" prop on the Field for it to work, if not added, the changes in the checkbox status will not be reflected in the Formik form values.
Example: https://codesandbox.io/s/material-demo-7zxgy

Ok I am going to close this out then

@mrjdavidfg thx. I tried to modify your example using integer values instead o string ones and then I get the following strange behaviour: if you click on a checkbox then the value is added, but the checkbox remain unchecked.
Any idea on this? Casting integers to string is a workaround.

Hi @maurosbu
If I remove component (taking formik-material-ui) out of the picture I still get the same issue.
<Field
                    type="checkbox"
                    name="numbers"
                    key={opt.label}
                    value={opt.value}
                    Label={{ label: opt.label }}
                  />

so this is likely an issue or expected behaviour of formik itself

@cliedeman thx, I will check / open an issue on Formik repo.


Current MP build failing because of problem with PATO

PATO imports an outdated definition of synovial cells which causes an illegal equivalency which breaks the current release.
Solution:

[x] Need to make new PATO release (https://github.com/pato-ontology/pato/issues/478)
[ ] We should probably think of moving MP to the newer BASE infrastructure like we have with CL and PATO, but no resources right now.

I think its fine now


Any way to validate raw POST data, type application/json or text/json

Yes, you can validate raw post data ( application/json or text/json).
See example (these example is validating the raw post body application/json, text/json):

Validate JSON to simple struct
Validate JSON to map

@thedevsaddam  curious why we have used govalidator.Int in the struct. Does it have any impact if I opt to use the standard go types?


Add an upload button for files and background

Currently the viewer is unusable on phones as the only option to open files is via drag and drop which is not possible on mobile devices. An upload button would be really helpful for mobile users as the rest of the UI already does work perfectly on phones.

https://github.com/playcanvas/playcanvas-viewer/pull/104

Been added


getting error when dependencies object in packge.json

Below is the package.json which gives the error.
{
  "name": "<MODULE_NAME>",
  "version": "1.0.0",
  "main": "index.js",
  "keywords": [],
  "author": "",
  "license": "ISC",
  "readme": "ERROR: No README data found!"
}

fix by https://github.com/rjoydip/pkg-dep/commit/56ea46f0740d329d427d304d73b642807f49c064


Change PyPI deploy account to mybinderteam

The current travis setup uses my personal PyPI credentials. This PR switches to using the mybinderteam account.
After this we can retry auto-deploying to PyPI which currently fails because my PyPI password has changed.

Thanks, @betatim!


cancelOnTapEmptyAreaEnabled - if YES, dismisses control if user taps on an empty area

if cancelOnTapEmptyAreaEnabled is YES, then control will hide when the
user taps on an empty area. (everywhere that is not a button (technically UITableViewCell)).
as seen in the Spotify app!:)

Thanks. I'll try to review this after WWDC.

sure!:) I'm using this in production.

I don't see what's changed from the user's POV. Version from master already makes action sheet disappear when tapped above the table view. Can you elaborate?

Hi,
That's interesting, has this been added in the meantime? I definitely can't reproduce the effect you've mentioned when I do a build from master. (Eg. if I tap over the table view - the action sheet stays on the screen).
I'm slightly confused now:).
Let me know!

You're correct. I was actually on a wrong branch.

Merged. Thanks!


ACM-2299: Onboarding modal should point to MCE docs

Signed-off-by: Maggie Chen<EMAIL_ADDRESS>https://issues.redhat.com/projects/ACM/issues/ACM-2299

/lgtm


Deployment

Deployment
User Story
As a bootcamp student,
I want the prework notes to be structured on a webpage,
So that I can easily find and read the information.
Acceptance Criteria
GIVEN a Prework Study Guide Website,
WHEN I visit the website using the URL,
THEN I can access my website from any browser

https://syd9f.github.io/prework-study-guide/


tweak latency function

@lbbrhzn I think it is best for the latency function not to close the connection or manage unexpected connection exceptions (leaving the main charger routine to do this), also if it does timeout to still log the 20000ms latency time.

Hi @drc38, my motivation for closing the connection was this: when there is a timeout, either the network or the charger response is seriously degraded. Likely the charger will experience similar issues and try to reconnect. We don't want old connections to remain lingering, so we need to close at some point. Due to the latency measurement the normal ping/pong timeout mechanism of websockets will no longer work, so we need to do that manually.
How does this scenario play out with your changes?  How do we close a previous connection when the charger reconnects? Should we keep the connection open indefinitely if it doesn't?

Hi @drc38, my motivation for closing the connection was this: when there is a timeout, either the network or the charger response is seriously degraded. Likely the charger will experience similar issues and try to reconnect. We don't want old connections to remain lingering, so we need to close at some point. Due to the latency measurement the normal ping/pong timeout mechanism of websockets will no longer work, so we need to do that manually.
How does this scenario play out with your changes? How do we close a previous connection when the charger reconnects? Should we keep the connection open indefinitely if it doesn't?

My understanding is the client should initiate any close, including if the transport layer is degraded.   I don't think it is possible to have a lingering connection if the client reconnects (ie it has to close first). Leaving it to the client may prevent unnecessary closing where transport layer degrades but not for long enough for charger to close socket.

My understanding is that either end can initiate a closing handshake in case of timeouts. See https://websockets.readthedocs.io/en/stable/topics/timeouts.html
Also note that the server can close at any time: See https://datatracker.ietf.org/doc/html/rfc6455#section-7.3

My understanding is that either end can initiate a closing handshake in case of timeouts. See https://websockets.readthedocs.io/en/stable/topics/timeouts.html Also note that the server can close at any time: See https://datatracker.ietf.org/doc/html/rfc6455#section-7.3

I guess it is more a design philosophy because as you say either end can close the connection. My wifi connection has medium signal strength and typical latency around 250ms, but at times goes to 3-4s and has gone to 20s without causing the charger to initiate a disconnect. The server could have dropped the connection but functionally it would not have made a difference as the transport layer went back to normal (possibly by the next ping/pong cycle).
If you'd prefer the server to drop the connection I'm ok with that, perhaps change the function to  manage_connection_latency to make it clear it is actively managing the connection rather than a passive measurement.

Let's revisit when the need arises.


pass pre-commit checks

Since unit tests have been passing before this branch, comment out parts so that tests pass now as well.

In a separate issue, resolve issues noted when certain tests were commented out due to failure with existing code.
Originally posted by @prjemian in https://github.com/bluesky/hklpy/issues/272#issuecomment-1766887521

wait for #276