[BUG] Unsupported data type when using PDFSearchTool

Description
I get this error:
I encountered an error while trying to use the tool. This was the error: Unsupported data type.
 Tool Search a PDF's content accepts these inputs: Search a PDF's content(query: 'string') - A tool that can be used to semantic search a query the my.pdf PDF's content. query: 'Mandatory query you want to use to search the PDF's content'
# Agent: Researcher...
## Thought: In order to ...
## Using tool: Search a PDF's content
## Tool Input:
"{\"query\": \"key skills and qualifications\"}"

Steps to Reproduce
The code I use is (fluff removed for clarity):
from crewai_tools import PDFSearchTool
my_file_tool = PDFSearchTool(config=azure_config, pdf='my.pdf')
my_researcher = Agent(
    role="Researcher...",
    goal="Make sure to...",
    backstory=("As a..."),
    tools=[job_file_tool],
    ...
)
my_task = Task(
    description=("Analyze..."),
    agent=my_researcher,
    tools=[my_file_tool],
    ...
)
crew_test = Crew(
    agents=[my_researcher],
    tasks=[my_task],
    process=Process.sequential,
    full_output=True,
    verbose=True
)

Expected behavior
As I cannot influence the format of what the agent sends to the tools, I'd expect the agent would send properly query=string. Could it be the config=... is messing up things?
Screenshots/Code snippets
The error is in the description above
Operating System
Windows 11
Python Version
3.12
crewAI Version
0.67.1
crewAI Tools Version
0.12.1
Virtual Environment
Poetry
Evidence
The error is in the description above
Possible Solution
None
Additional context
Same behaviour when I use the DOCXSearchTool, so there's either something I completely misunderstand, or worse.

Facing the same issue in gemini:
pdf_search_tool = PDFSearchTool(pdf="folder/Most_Admired_Wine.pdf", config=dict(
        embedder=dict(provider="google", config=dict(model="models/gemini-1.5-flash"))
    ))

...
	@agent
	def wine_tester(self) -> Agent:
		return Agent(
			config=self.agents_config['wine_tester'],
			verbose=True,
			llm='gemini/gemini-pro',
			tools=[pdf_search_tool]
		)

and error
I encountered an error while trying to use the tool. This was the error: 400 * BatchEmbedContentsRequest.model: unexpected model name format
* BatchEmbedContentsRequest.requests[0].model: unexpected model name format
.
 Tool Search a PDF's content accepts these inputs: Search a PDF's content(query: 'string') - A tool that can be used to semantic search a query the data-base/Most_Admired_Wine.pdf PDF's content. query: 'Mandatory query you want to use to search the PDF's content'

@mrSingh007 your error message is different. Are you sure your model name (deployment) is correct?

I can confirm that it happens only with Azure. If I switch to OpenAI, there's no need for a config dict, and everything works just fine.

Excuse the silly question, but is it that the agents have to learn the tools parameters, so the first tries will usually be random???


Unable to Send Alerts in Grafana

Hey,
I was trying to send alert from Grafana v4.4.* and it's not working, I've the same issue described in this question
As part of my troubleshooting I was referred to http://docs.grafana.org/alerting/rules/#troubleshooting, I need to update the Grafana’s ini config file How do I do that in heapster?
Does anyone faced this issue before? Are you able to send alerts from Grafana?

you can build your own image with your own config
https://github.com/kubernetes/heapster/tree/master/grafana
be careful for dont send public docker hub

That is the correct answer.  You should build a custom image with your own grafana.ini.  You can even use the existing image as a base image.


docs: reordered sections now they are matching the logical flow

docs: reordered sections under CRD references:
before:

After:

Hey @ab7022, Thank you for your contribution :)
Can you please sign off your commit for the DCO check to pass?

The sections have been rearranged to align with a more coherent and logical flow.

If I'm not wrong, this PR is trying to fix this issue https://github.com/keptn/lifecycle-toolkit/issues/1827.
The issue states to re-organize our README.md in proper flow which has already been fixed in this PR https://github.com/keptn/lifecycle-toolkit/pull/1685, which doesn't make the issue relevant anymore.
But I'm having double thoughts about changing the CRD refs that should we go with the logical flow or the alphabetical order?
WDYT @agardnerIT @StackScribe

okay :)

@rakshitgondwal is correct and I had exactly the same thought (re-organising the list) with @StackScribe and I can see perfectly valid arguments for both (alphabetical and "logical" organisation). @StackScribe convinced me though that alphabetical was better.
All of that aside, I again agree with @rakshitgondwal that this PR was intended to re-organise the readme not the website. Therefore I'm closing this PR.
Thank you @ab7022 and sorry that this couldn't be merged.


Using Gitflow

Please read up on gitflow here.  We will be using this to manage our git commits.

Agree :+1:


[FIX]: VSCode "Parsing error: Cannot find module 'next/babel" PNPM ESLint

🪲 Error Reported
Parsing error: Cannot find module 'next/babel'

💻 Where does the Error Spawn?
Requirements:

PNPM
ESLint
Monorepo (Turborepo)
Next.js

If all of the above requirements ✅ checked, you can see the Error in every ESLint config file in the children directories.
🤔 Cause
Still needed to figure out why does this happen. My hypothesis as it is because of the PNPM node_modules design that is read by VSCode's ESLint extension. But it's because ESLint cannot resolve next/babel.
🚀 How this solution works?
This works because require.resolve uses the node's module resolution to return the absolute path to a module. It can provide that absolute path to any importing modules.

Please don't merge it, I still want to add this fix to every affected examples as much as I could.

Good 👍 to go now, I already edit all potentially affected examples and edited the error I found in examples/basic 🚀

Awesome, thanks!

@tknickman @ImBIOS This fix can silent the error of VSCode ESLint extension, however the VSCode ESLint extension also stop working.
You can see the Output of ESLint extention:

Error: Cannot find module 'next/babel'

I think we should find the root cause and solve it.


feat: remove utxos cache from OMG.State on form_block

:clipboard: closes https://github.com/omgnetwork/private-issues/issues/62
Overview
This is to avoid potential memory leak due to increasing size of utxos.
See @pnowosie 's comment: https://github.com/omgnetwork/private-issues/issues/62#issuecomment-662907908
Changes

reset to empty map for utxos on form_block
add a unit test for above behavior
fix fee claiming unit test
remove one OMG.State core test as it is really testing integration behavior and not really possible to test with this change introduced. However, the test should already be covered by cabbage naturally.

Testing
CI

okay, confirmed an integration test that suppose not to fail failed due to the introduction of the change.
https://github.com/omgnetwork/elixir-omg/blob/1f7a6351b3c7b8af1de144936784ca22bbc1d1c5/apps/omg_child_chain/test/omg_child_chain/integration/happy_path_test.exs#L214

When receiving piggyback output event, it will try to get the utxo with the following line:
https://github.com/omgnetwork/elixir-omg/blob/522fb32c493196e3fe1d32b38dd61a9949c741ba/apps/omg/lib/omg/state.ex#L211
And the Core implementation would require the utxos memory:
https://github.com/omgnetwork/elixir-omg/blob/1feed637da2e5caf49b7fe2bb3a2872818baee46/apps/omg/lib/omg/state/core.ex#L339-L349
in find_utxo_matching_piggyback
https://github.com/omgnetwork/elixir-omg/blob/1feed637da2e5caf49b7fe2bb3a2872818baee46/apps/omg/lib/omg/state/core.ex#L502-L506


Difference with the PointGroup?

I notice that SoftGroup is very similar to PointGroup, the main difference lies in two points:

PointGroup uses one-hot semantic results from the semantic branch but SoftGroup uses softmax results.
PointGroup just uses one branch with sigmoid to predict the score of each cluster, while SoftGroup uses three branch.

Is my understanding correct? I  want to compare these two methods in detail

Hi authors!
Thank you for this amzing work! It's both effective and inspiring.
I'm also curious about a similar question:
what's the difference between the baseline in table 5, and pointGroup in table 3?
I notice in the ablation study of the paper that SoftGroup baseline in table 5 achieves 61.1/7.5 for AP50/AP25; while PointGroup in Table 3 achieves 51.7\71.3.
It's said in the paper that the baseline use hard group and a scoreNet for ranking. That sounds the same with PointGroup. And I didn't fine more description about the baseline.
So what's the difference between the baseline  in table 5, and pointGroup? They have very different performance but their methods sound the same.
Thank you!

@3bobo  Yes. Our ideas can be summarized as those.


CASMPET-7290: Add pylint to build pipeline; correct errors identified by pylint

This PR adds pylint to the build pipeline. The builds will only fail if pylint identifies fatal errors. A full pylint run will also happen, but currently it will not be able to cause the build to fail. This is because there are a lot of issues it identified in the existing Python code. Hopefully we can gradually address those. If so, we can eventually have pylint require minimum code quality, or else fail the build.
After adding pylint, it identified several fatal errors in the existing tests. This PR corrects those as well. None of them are tricky or risky changes.

Cool thanks

No problem -- this is something I've been trying to do in a lot of repos. I also want to eventually add mypy, but for that we'll need to make sure the code has type annotations, and that'll also take a little while. But that has allowed me to find a bunch of bugs in BOS, so I'm hoping to eventually get this done.


When trying to make an execution, an error occurs

I installed n8n-nodes-puppeteer using the command npm install n8n-nodes-puppeteer and entered into the environment the registered export N8N_CUSTOM_EXTENSIONS="/root/node_modules/n8n-nodes-puppeteer/" after receiving I get an error: "There was a problem executing the workflow:
"Failed to launch the browser process! [0609/151429.665860:ERROR:zygote_host_impl_linux.cc(90)] Running as root without --no-sandbox is not supported. See https://crbug.com/638180. TROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md " "
Please help me solve the problem.

Hi @Rocket74! I saw you posted on the N8N community forums so I figured I'd link the solution here:
https://community.n8n.io/t/n8n-nodes-puppeteer-error-please-help-me/14789
I do plan to add args support to the node so you can pass things like --no-sandbox in the future.


How to do it with ssh access via root

Does it need browser gui to complete the oauth process?

Yes, but it is decoupled so you can do the web browser part on any machine.
You could even do the whole process on one yt-dlp and copy the cached token file to other machines.

Sounds great, will try on windows thanks.


mark form pristine after successful deletion

Why are there so many commits in this PR? Aren't all the other commits already in develop branch?
There are code styling updates to files that are not related to the change, was this intentional?


Cannot see all commands on scroll

Describe the bug
Hi Team,
thanks for this brilliant library. I am facing one issue. I believe the default number of entries in the suggestionsList is 7, but even when I tried to override it, it shows only 7. So after the 7th position, it shows the suggestion at the 1st position again and keeps cycling through
However, if I search for an item which is outside the 1st 7 options, it does show up correctly
Expected behavior
I am looking for a way so that even though there may be only 7 suggestions on display, i can keep scrolling down to see all commands
Desktop (please complete the following information):

OS: iOS
Browser chrome

You may want to double check your data. The component won’t “wrap” the displayed commands. When the user scrolls to the bottom the last command is displayed and the user must scroll back to the top to see the first command.
So if you’re seeing the commands cycling there’s very probably dupes in your data. Please make sure your commands are unique. The command palette simply renders what’s present in your list, there’s no magic

thanks @asabaylus . I have provided unique ids (30 of them ) and the shortcut keys are also all different. I have not put in call the command functions  yet it's a WIP and will take longer.
Should the id field being unique along with unique shortcut not suffice?

Also, wanted to add that i looked at the sample here
https://codesandbox.io/s/hfqjn
even here, if you scroll through the options, it shows only 7 items.

Try setting maxDisplayed to a number greater than the available vertical space, ex: maxDisplayed={100}. Then set...
/* atomTheme.css */

.atom-suggestionsContainerOpen {
  overflow: auto;
  ...

Here's an example
https://codesandbox.io/s/react-command-palette-with-atom-theme-2qb4m?fontsize=14
Beware of browser performance limits.

thanks @asabaylus!  Yes this works. Appreciate the prompt revert.


Update and Patch for March Langpack

PR adds in the correct version number, updated strings from resources checked in after the initial langpack source commit, but still part of 1.42, and also adds in entry for changelog.
Port request of #22180
This PR fixes #22181

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.002%) to 41.938%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/dialog/configurePython/configurePathPage.ts
1
57.02%

Totals

Change from base Build<PHONE_NUMBER>:
-0.002%

Covered Lines:
28804

Relevant Lines:
63772

💛  - Coveralls


Docs in README 404

The docs in the readme section 404. Are these docs deployed elsewhere?

Which README?

The README in this Repo

@logankilpatrick no they are deployed anywhere yet. We plan to do so in coming days. After Stipple docs is ready. They will all go on genieframework.com

Oh sorry, got badge blindness :) They are hosted here before moving on GenieFramework.com but they are incomplete https://genieframework.github.io/SearchLight.jl/dev/

Oh sorry, got badge blindness :) They are hosted here, before moving to GenieFramework.com, but they are incomplete https://genieframework.github.io/SearchLight.jl/dev/

Are they going to be complete and if so when? I'm curious to know how we can do relationships with SearchLight

@ThalusA it's WIP. Maybe a couple of weeks more


Broken dictionary building

Replacing the language data with the training/dictionary_pickler.py script completely degrades, the previous results cannot be replicated anymore.
I believe that commit 63933fc accidentally reverted the conversion to bytestrings shortly before in 546ab7e, so that the lemmatizer ends up looking for binary data that is not there, which does not throw an error but does not return anything useful either.
The crucial line is here:
return {k.encode("utf-8"): v.encode("utf-8") for k, v in sorted(mydict.items())}
https://github.com/adbar/simplemma/commit/63933fcfd2e4fa9bb1626fa959d9777d9dee5f57#diff-f5e1d8737ff169b2b390ac79e7292d17bc3a41c2c2de3e6f2b348c78a70af724R123
@Dunedan It was your PR, could you please have a look at it? We should at best integrate the previous state into your code.

Thanks for the details and the quick response, it's really helpful.


Toggle date and author binding overrides standard delete word binding

The binding for <C-w> which toggles date and author in entry overrides the standard binding for delete word in vim and in terminals in general. This means that whoever uses the standard binding to delete a word within the telescope prompt can't do this anymore.
It would be best to change this binding to something which does not interfere with standard bindings in insert mode.

@dudicoco I opened a PR for configurable keymaps, can you validate the behavior?

@aaronhallaert works, thanks!


work well with esoteric page format

If the original PDF has pages in landscape format or with esoteric page size, the ouput PDF was cropped at A4 page size.
This fix allow to keep the original page size, whatever it is.

Thanks for your contribution :smile:


Master nmilovanov uniform dto models

It depends on:

#60 from retail-commons
#690 from retail-services
#185 from retail-idcloud

Seems good to me. @nbozic can we merge?

Wait to commit commented fixes ...

We can wait for Nenad to fix StringBuilder comment and we can merge. It is nice cleanup IMO, we tagged version before this commit so we can rollback if problems start appearing and I documented what needs to be done to get rid of old jackson annotations as well on confluence

Looks good tome, we can merge!


Added compatibility with WFRP 3.X (es6 module for tokenhud) + PL translation + Armour hud

Hi @Jagusti , few tweaks from my end, feel free to comment in case something doesn't make sense for you or merge if you find them useful.

Agreed to close. Perhaps revisit if official Polish support happens.


automatically detect if tracked object is visible, outside or occluded ,depending on scores and previous annotations

Hello,
First of all, thank you for your amazing tool.
The issue concerns a feature request/proposal, concerning the tracker (more precisely the one that can be incorporated on the AI tool):
is it possible to use the previous annotations, to automatically detect if the object on the current frame is (totally of partially occluded) ?
It could be on the form of a function that decide if the tracked object is hidden by analyzing the scores of the annotated frames (manually of semi-automatically) along with the properties of the object on the previous frames (not occluded ,occluded,outside).
The simplest default function, could be a function that compares the score of the tracked object on the current frame against a threshold value.
The use case of this feature would be to avoid for the user the burden to select multiple keyframes, each time an object appears and disappear (in case it happens multiple times), and maybe to add automatically new keyframes.
It would be more useful with recents trackers' models that can find back disappeared object, even if the tracked object disappeared for multiple frames.
Thank you for your reply.

Hello, I don't think it is possible to implement general solution for that using scores and previous annotation.


investigate why sprig_dodge panel does not appear

cc @SamDev-7 , I know you did the panel for getting_started, could you take a look in my commit: https://github.com/hackclub/sprig/commit/cf66dbf75f23f94086f52cca019e0c05a2a7a43b and see what is wrong? Thank you!

I'll take a look later today.

I've made a PR.


Mention how to connect to local notary in README

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "vikstrous-patch-1" git@github.com:vikstrous/notary.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.


(fleet) scaffolding of apt updater packaging

What does this PR do?
Add a simple build for an apt updater package. This is based on existing agent package.
Init scripts and systemd files are added following spec
Follow-ups

tests that verify and enforces systemd behaviours
tests on init scripts
support rpm

Test packages content
$ dpkg -e omnibus/pkg/datadog-updater_7.49.0~devel.git.1795.56d3c90-1_arm64.deb unpack_meta
tree unpack_meta
unpack_meta
├── control
├── md5sums
├── postinst
├── postrm
├── preinst
└── prerm

$ dpkg -x omnibus/pkg/datadog-updater_7.49.0~devel.git.1792.4bdbb3b-1_arm64.deb unpack_debug
❯ tree -l unpack_debug
unpack_debug
├── etc
│   └── datadog-agent
│       ├── conf.d
│       │   ├── apm.yaml.default
│       │   ├── container.d
│       │   │   └── conf.yaml.default
│       │   ├...
│       │   └── winproc.d
│       │       └── conf.yaml.default
│       └── datadog.yaml.example
├── lib
│   └── systemd
│       └── system
│           ├── datadog-agent-exp.service
│           ├── datadog-agent-process-exp.service
│           ├── datadog-agent-process.service
│           ├── datadog-agent-security-exp.service
│           ├── datadog-agent-security.service
│           ├── datadog-agent-sysprobe-exp.service
│           ├── datadog-agent-sysprobe.service
│           ├── datadog-agent-trace-exp.service
│           ├── datadog-agent-trace.service
│           ├── datadog-agent.service
│           ├── datadog-updater.service
│           ├── start-experiment.path
│           └── stop-experiment.path
├── opt
│   └── datadog
│       └── updater
│           ├── LICENSE
│           ├── LICENSES
│           │   ├── THIRD-PARTY-0BSD
│           │   ├── THIRD-PARTY-Apache-2.0
│           │   ├── THIRD-PARTY-BSD-2-Clause
│           │   ├── THIRD-PARTY-BSD-3-Clause
│           │   ├── THIRD-PARTY-ISC
│           │   ├── THIRD-PARTY-MIT
│           │   └── THIRD-PARTY-MPL-2.0
│           ├── bin
│           │   └── updater
│           │       └── updater
│           ├── embedded
│           │   ├── bin
│           │   └── lib
│           ├── run
│           ├── sources
│           │   ├── attr
│           │   │   └── offer.txt
│           │   ├── elfutils
│           │   │   └── offer.txt
│           │   ├── freetds
│           │   │   └── offer.txt
│           │   ├── gmp
│           │   │   └── offer.txt
│           │   ├── gnutls
│           │   │   └── offer.txt
│           │   ├── libacl
│           │   │   └── offer.txt
│           │   ├── libdb
│           │   │   └── offer.txt
│           │   ├── libgcrypt
│           │   │   └── offer.txt
│           │   ├── libgpg-error
│           │   │   └── offer.txt
│           │   ├── libsepol
│           │   │   └── offer.txt
│           │   ├── libtasn1
│           │   │   └── offer.txt
│           │   ├── libxcrypt
│           │   │   └── offer.txt
│           │   ├── m4
│           │   │   └── offer.txt
│           │   ├── nettle
│           │   │   └── offer.txt
│           │   ├── openscap
│           │   │   └── offer.txt
│           │   ├── procps-ng
│           │   │   └── procps-ng-procps-v3.3.16.tar.gz
│           │   ├── rpm
│           │   │   └── offer.txt
│           │   └── util-linux
│           │       └── offer.txt
│           ├── version-manifest.json
│           └── version-manifest.txt
└── var
    └── log
        └── datadog

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

I think this looks good overall (obviously the points brought up by @chouquette should be addressed). I think the two bigger things that will need improvement are:

The install_info file format will need to be amended to be able to handle information about the updater - alternatively we can have one install_info for Agent and then install_info_updater for the Updater. Either way the Agent will have to understand how to submit this new information and the backend code that parses it will need to be updated. I think we don't have to solve this right now, so I won't block the PR on it, but we must solve it before any real release.
I'm thinking whether we need to stop/restart all the Agent services in the package scripts when we're updating the Updater. In theory, the Agent could continue running when the Updater package is updating, couldn't it?

Good point, I've updated so the only interactions with the agent are

disable + stop on uninstall
enable the systemd files

Starting the agent is left to the updater and no restarts will happen when the updater is updated


remote URL not working for wiki links

GitLens Version:

VSCode Version: 1.29.1
OS Version: Windows 10

Steps to Reproduce:

Use the Remote features of GitLens (Copy or Open) Remote URL on a github wiki.

This results in a 404 as the URL gets set to the remote url for the git repository, which is .wiki
This should recognize the .wiki and redirect the remote URL to be /wiki
In practice, I am using GitHub Enterprise and setting the remote urls in the settings.json and it is working as expected on repositories that are not wikis

@jaywryan would you be willing to open a PR to support this?


This plugin does not appear to support US based ID accounts, how can I help?

This plugin seems to be using the european services. My ID4 is registered under the US portal.
How can we get this going in the us, or do I need to also register in europe?

Unfortunately I don't know which servers VW backend uses in the US. If you find out (inspect traffic from device?), I can make this an option in the config.


Parser Error: When trying to run (F5) a project

Godot version
4.0 Beta 6
System information
Windows 11
Issue description
When trying to run my project with F5 it halts with Parse Error:
The only information shown is in the console as follows.

E 0:00:02:0469   GDScriptCompiler::_populate_class_members: Condition "!base->is_valid()" is true. Returning: ERR_BUG
<C++ Source>   modules\gdscript\gdscript_compiler.cpp:2287 @ GDScriptCompiler::_populate_class_members()

My project is fairly large and runs fine in Beta 5.
in case it helps heres the log when loading up the project:

Godot Engine v4.0.beta6.official.7f8ecffa5 - https://godotengine.org
OpenGL Renderer: NVIDIA GeForce GTX 1080 Ti/PCIe/SSE2
Editing project: C:/SpaceSlog Game/SpaceSlog
Godot Engine v4.0.beta6.official.7f8ecffa5 - https://godotengine.org
Vulkan API 1.2.0 - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce GTX 1080 Ti
ERROR: Non-existent native base class.
at: (modules/gdscript/gdscript_analyzer.cpp:4052)
ERROR: Non-existent native base class.
at: (modules/gdscript/gdscript_analyzer.cpp:4052)
ERROR: Non-existent native base class.
at: (modules/gdscript/gdscript_analyzer.cpp:4052)
ERROR: Non-existent native base class.
at: (modules/gdscript/gdscript_analyzer.cpp:4052)
ERROR: Non-existent native base class.
at: (modules/gdscript/gdscript_analyzer.cpp:4052)
ERROR: Non-existent native base class.
at: (modules/gdscript/gdscript_analyzer.cpp:4052)
ERROR: Non-existent native base class.
at: (modules/gdscript/gdscript_analyzer.cpp:4052)
ERROR: Non-existent native base class.
at: (modules/gdscript/gdscript_analyzer.cpp:4052)
ERROR: Non-existent native base class.
at: (modules/gdscript/gdscript_analyzer.cpp:4052)
ERROR: Non-existent native base class.
at: (modules/gdscript/gdscript_analyzer.cpp:4052)
ERROR: Non-existent native base class.
at: (modules/gdscript/gdscript_analyzer.cpp:4052)
ERROR: Non-existent native base class.
at: (modules/gdscript/gdscript_analyzer.cpp:4052)
ERROR: Non-existent native base class.
at: (modules/gdscript/gdscript_analyzer.cpp:4052)
ERROR: Non-existent native base class.
at: (modules/gdscript/gdscript_analyzer.cpp:4052)
ERROR: Non-existent native base class.
at: (modules/gdscript/gdscript_analyzer.cpp:4052)
ERROR: Non-existent native base class.
at: (modules/gdscript/gdscript_analyzer.cpp:4052)
ERROR: Condition "!base->is_valid()" is true. Returning: ERR_BUG
at: _populate_class_members (modules/gdscript/gdscript_compiler.cpp:2287)
ERROR: Non-existent native base class.
at: (modules/gdscript/gdscript_analyzer.cpp:4052)
ERROR: Condition "!base->is_valid()" is true. Returning: ERR_BUG
at: _populate_class_members (modules/gdscript/gdscript_compiler.cpp:2287)
ERROR: Condition "!base->is_valid()" is true. Returning: ERR_BUG
at: _populate_class_members (modules/gdscript/gdscript_compiler.cpp:2287)
ERROR: Condition "!base->is_valid()" is true. Returning: ERR_BUG
at: _populate_class_members (modules/gdscript/gdscript_compiler.cpp:2287)
ERROR: Condition "!base->is_valid()" is true. Returning: ERR_BUG
at: _populate_class_members (modules/gdscript/gdscript_compiler.cpp:2287)
ERROR: Condition "!base->is_valid()" is true. Returning: ERR_BUG
at: _populate_class_members (modules/gdscript/gdscript_compiler.cpp:2287)
ERROR: Condition "!preset.is_valid()" is true. Continuing.
at: load_config (editor/export/editor_export.cpp:206)
ERROR: Condition "!d.has("handle_modes")" is true. Returning: false
at: _set (scene/resources/animation.cpp:319)

Steps to reproduce
Unfortunately i cannot help much as my project is fairly large. I have tried to narrow the issue down but cannot.  Any help with this would be appreciated.
Minimal reproduction project
Please see above.

You might have a cyclic reference in your code, which used to produce CRC errors and now presents Condition "!base->is_valid()" is true for me. The error is not locatable in GDScript, so perhaps you can think about where you are introducing cyclic references and untype the variables. See https://github.com/godotengine/godot/pull/67714#issuecomment-1328076248

CC @rune-scape

You might have a cyclic reference in your code, which used to produce CRC errors and now presents Condition "!base->is_valid()" is true for me. The error is not locatable in GDScript, so perhaps you can think about where you are introducing cyclic references and untype the variables. See #67714 (comment)

Your issue seems very similar to mine, though i have no idea where the cyclic reference is, unless it also refers to places where i check class types with x is class.
There are currently no cyclic reference errors whilst using Beta 5.

@adamscott Just ran into the same issue and managed to create a MRP, hope it helps!
MRPCyclicRef.zip

I ran into the issue as well and managed to create a MRP.
MRPCyclicRef.zip

@issork Thanks for the MRP! It really helped pinning down the issue.
If you could test my PR, it would be great. When the Github action will finish, you will be able to download the artifacts to test, if you don't feel to build from source.

The PR seems to fix the issue for me, I can run my project again. Thanks!

it seems like something may be going wrong in the analyzer? ERROR: Condition "!base->is_valid()" is true. Returning: ERR_BUG may be caused by the "Non-existent native base class." error

@adamscott had it right (nice job)
the other error in the analyzer is also a side effect of allowing cyclic references


Attempt to index a nil value

Hi, could you give us a bit more information about what you did to get that crash? Attempting to reproduce it on my end wielded no error.

Just tried to recreate the bug, after some tests i found out that what you need to do is to shoot up a portal near the flag pole, you need to do it when you're high enough to be off stage, i managed to do it in Level 1-1, 1-2, 1-3 and 1-1 from 0'Brothers to try a different mappack

I think it's trying to check the properties of a nonexistent tile.
Quick patch:
change line 4193 of game.lua to
if cox and tilequads[map[cox][coy]] and tilequads[map[cox][coy][1]]:getproperty("mirror", cox, coy) then
and see if that works.

Okay, i just tested it and it appears to be fixed so far


classes should be plural

near the bottom you have:
Rarity <= Magic
Class "Flask" "Body" "Helmet" "Boots" "Gloves" "Shields" "Quiver" "Mace" "Staff" "Quarter" "Bow" "Crossbow" "Wand" "Sceptre"
AreaLevel >= 65
Show
Rarity <= Magic
Class "Flask" "Body" "Helmet" "Boots" "Gloves" "Shields" "Quiver" "Mace" "Staff" "Quarter" "Bow" "Crossbow" "Wand" "Sceptre"
but for it to work, it has to be plural class names something like this:
Hide
Rarity <= Magic
Class "Wands" "Shields" "Sceptres" "Foci" "One Hand Maces" "Two Hand Maces" "Staves" "Quarterstaves" "Quivers"

@KarateSnoopy why not sending a PR? 👀


Convert landlord-immigration-check to use ERB templates for questions

Looks good to me.

I've rebased on master and force pushed in preparation for merging.


Line numbers in issues window are n*2-1 compared to actual line number in code

It appears that the line numbers in the issues window are incrementing by 2.

Are you running on windows?

I am.

@Rastem88 Can you confirm this is now working correctly in imdone-atom v1.1.33?

It is working correctly. Thanks for the quick update.


Error in "Branch.intersects(HyperRect rect, Consumer consumer)"

https://github.com/conversant/rtree/blob/0d792e3ca0980844c5c8225e854336a4fa2e1dfb/src/main/java/com/conversantmedia/util/collection/spatial/Branch.java#L197
This line should be
child[i].intersects(rect, consumer);

Yeah!  Good find!

Thanks @richkraft @twinprime


Query consistency and reject condition

The GO client has the QueryWorkflowWithOptions() method that accepts a structure that can specify query consistency as well as a query reject condition code.
The .NET client should support this as well.  I think we should just add parameters to the existing temporal-proxy query message(s) and have cadence-proxy call this method always.
This will require an update to temporal-proxy.
https://cadenceworkflow.io/docs/07_goclient/11_queries

CLOSING: Temporal is deprecated.  We're waiting for an official client.


Funnel Activation implementation question

Hi,
The depthwise convolution you're using in your  implementation of FRelu is this
the regular depthwise convolution or a depthwise separable convolution ? (a regular depthwise conv + 1x1 pointwise conv)
thanks

the regular depthwise convolution (implementation here)

Thank you very much!


Loop Swiper slide is removed after loop

Hey,
i use your swiper to create an app store like slider for featured content. I have set the options for the swiper div like in your demo-apps/appstore example  added the loop options (loop : true,loopAdditionalSlides : 3,loopedSlides : 3,). When i now slide through the slides i have at the "end of the loop and begin" the problem that the first slide will be removed and added when i start sliding again. I hope you can figure out my problem ;)
thanks

On More Question regarding the same.
I have created 2 sliders one is horizontal and one is vertical. I have added vertical slider inside the horizontal slider. But the slideTo() method is not working for the vertical slider. However slideTo() is working fine for the horizontal slider. Can you help me to sort out this issue?

I am getting TypeError: swiperV.slideTo is not a function error for vertical slider. The same is working fine for the horizontal parent slider. Vertical is child one..
Thanks,
Tejas


Option to turn off mouse changing task focus

I love the ability to navigate with the keyboard using vim style commands. As a feature request, I wish that I could turn off having the task that is focused change when I move the mouse. I would rather that the focused task only responded to keyboard inputs and not the mouse movement.
Could there be an option in the extension options to turn off the usage of the mouse for task focus?

Good point!  Mouse usage for this was actually specifically requested by Todoist folks.  I also prefer to have it disabled, but it didn't bug me all that much.
So far I'd resisted the complexity of adding an options page, but have now added one, so future addition of options should be much easier.


RFC 0011: Decorators --> ACCEPTED; Deadline 2019.12.06

Signed-off-by: Daniel Hardman<EMAIL_ADDRESS>

I think this PR covers the topic well, as a related note do we have thoughts on how decorators will be expressed under the discovery protocol?

Update: this PR is on hold pending a resolution to issue #78 ; there was a late-breaking comment there that is relevant to what's proposed here.

Per discussions in #79 that has now been closed, this status change has been re-activated, with a new 2 week deadline for discussion.

Final call. Any objections to this PR/Status Change from being merged?
@dhh1128 @tplooker @TelegramSam

Nope. I say merge it.

@dhh1128 - can you push a commit to the index.md file to get it up to date?  I'm not sure how to do that...
Thanks

On it. ETA 15 min.


Update ahpy.py

This is an update to the add_children() method in order to accept a dictionary as well as list/tuple as input


Ported → N2O.

Do I need also populate and inject this snippet into all synrc libraries ?

Eh. It depends.
I assumed n2o is kinda “master” one, so use N2O, with: [:n2o, :nitro] will inject records via imports and aliases for both n2o and nitro.
https://hexdocs.pm/elixir/Kernel.html#use/2

https://github.com/o7/sample/blob/master/lib/index.ex#L2
To inject nitro only, one might use N2O, with: [:nitro]. Maybe it makes sense to rename with: to only: to make it more explicit. Or to move the whole __using__/1 macro into some separated module, like N2O.Lib.

It's not that N2O master one, e.g. data-only apps depens then on KVX, this if you accept is an other root. I like the power of with:  syntax and want to include that into KVX as well. And we have console preprocessor that depend only on NITRO and even not KVX or N2O. MADness! :-)

Man, there is no with syntax. It’s a Keyword.t() argument in call to __using__/1 macro. You might pass any Keyword.t() list there, e.g. [{:all, true}, {:except, :nitro}, {:with_kv, :redis}]`. The code simply uses this list as a plain old good parameter.

I meant particular N2O DSL just committed. But I noted!


EmailMessageFacet should allow 0 values for isMimeEncoded and isMultipart

Background
Issue 380 included a few examples of reasons to generate "Stub" EmailMessage graph objects, as candidate objects to use to construct reply chains.  If one tried to validate those examples, they would get sh:Violation results from SHACL, that they lack two properties: observable:isMimeEncoded and observable:isMultipart.
It appears that there was a logic error when UCO 0.7.0 did its conversion from OWL to SHACL.  Those two properties are rightly described in OWL as having a cardinality of exactly 1 - an email instance has exactly one value for isMimeEncoded.  It just might not be yet recorded in a graph.  From OWL's perspective, it is fine for a graph to record 0 values for isMimeEncoded, or 1, just not 2.  (And likewise for isMultipart.)
The SHACL conversion likely took this "Exactly 1" cardinality and turned that into a too-stringent data requirement: A graph must recorded a value for isMimeEncoded.  (And likewise for isMultipart.)
Where this becomes a problem is, if an EmailMessage has to be generated as a placeholder for whatever reason, then SHACL validation fails unless some value is asserted for both of those properties.  This is not a correct requirement for UCO to put on applications, because those values is not inherently knowable without the email artifact in hand.
Requirements
Requirement 1

An EmailMessageFacet instance must be able to pass SHACL validation without requiring a value for isMimeEncoded.

Requirement 2

An EmailMessageFacet instance must be able to pass SHACL validation without requiring a value for isMultipart.

Risk / Benefit analysis
Benefits
Requirements 1 and 2 fit with a general usage pattern that it should be acceptable to define certain Facets even if that Facet houses no properties.  This usage pattern applies in the cases where a "Stub" object needs to be defined, and for whatever reason the Facet might need to be defined (e.g. to store a graph identifier for downstream processes).
No other properties in EmailMessageFacet have a sh:minCount, so it seems especially odd for these two to have a non-0 minimum.
Risks
The submitter believes there are no risks associated with this change.
Competencies demonstrated
Competency 1
Issue 380 demonstrated a use case for generating EmailMessage objects with only one in-Facet property known, deriving an object from an In-Reply-To header.
Competency Question 1.1
Can an EmailMessage defined housing only messageID?
Result 1.1
With this proposal, yes.
Solution suggestion

Change sh:minCount of isMimeEncoded within EmailMessageFacet to 0.
Change sh:minCount of isMultipart within EmailMessageFacet to 0.

The solution is provided in PR 384.
Coordination

Tracking in Jira ticket OC-240
[x] Administrative review completed, proposal and solution announced to Ontology Committees (OCs) on 2022-05-19
[ ] Solutions Approval to be discussed in OC meeting, 2022-06-02
[ ] Solutions Approval vote has not occurred

[ ] Solutions development phase completed.
[ ] Implementation has not been merged into develop

[ ] Milestone linked
[ ] Documentation logged in pending release page

I have no objections to removing the min constraint on these two properties and making them optional.
That being said, I believe the explanation and justification in the CP should be corrected and clarified.
This is a requested change to the cardinality of these two properties to support newly identified use cases.
The current SHACL constraints are not a OWL->SHACL conversion error between 0.6.0 and 0.7.0.
In 0.6.0, the constraints on these properties utilized a qualifiedCardinality of 1. This means that there must be exactly one instance of each property on an EmailMessageFacet class.
This is semantically identical to the current SHACL constraints of minCount=1 and maxCount=1.


fix when minimizer is fn

As discussed offline with @sokra, this is a fix for when you provide a function entry for optimization.minimizer config.
What kind of change does this PR introduce?
bugfix (related: https://github.com/webpack/webpack/pull/8405)
Did you add tests for your changes?
No, should i?
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
Done: https://github.com/webpack/webpack.js.org/pull/2743

Needs a test case

@sokra should i rebase this pr to point to master? I noticed same issue in master branch.

@sokra should i rebase this pr to point to master? I noticed same issue in master branch.

yep

ok, should be all set now.

Thanks

@sokra will this be cherry picked to next branch?

I merge master into next on every release


test: init container e2e tests

Fixes #N/A
Description
This PR adds some minimal end-to-end tests for init container resource computation in light of this upstream PR: https://github.com/kubernetes-sigs/karpenter/pull/569.
How was this change tested?
/karpenter snapshot
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Blocked by some changes that need to be changed in the upstream PR to support specifying init container images: https://github.com/kubernetes-sigs/karpenter/pull/569#discussion_r1462624455

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.53%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4951

Relevant Lines:
5999

💛  - Coveralls


Uncaught Error: Cannot find module '$ATOM_HOME/packages/browser-plus/node_modules/jquery-ui/autoc...

[Enter steps to reproduce below:]

Install browser-plus
Upgrade Atom from 1.9.3* to 1.9.4 after getting an error
Select Browser Open, yes I didn't install jquery-ui/autocomplete.js

Atom Version: 1.9.4
System: Mac OS X 10.11.6
Thrown From: browser-plus package, v0.0.74
Stack Trace
Uncaught Error: Cannot find module '/Users/philippederome/workspace/scalaLiftDemo/project/atom/packages/browser-plus/node_modules/jquery-ui/autocomplete.js'
At module.js:341

Error: Cannot find module '/Users/philippederome/workspace/scalaLiftDemo/project/atom/packages/browser-plus/node_modules/jquery-ui/autocomplete.js'
    at Module._resolveFilename (module.js:339:15)
    at Function.Module._resolveFilename (/Applications/Atom.app/Contents/Resources/app.asar/src/module-cache.js:383:52)
    at Function.Module._load (module.js:290:25)
    at Module.require (module.js:367:17)
    at require (/Applications/Atom.app/Contents/Resources/app.asar/src/native-compile-cache.js:50:27)
    at Object.<anonymous> (/Users/philippederome/workspace/scalaLiftDemo/project/atom/packages/browser-plus/lib/browser-plus-view.coffee:6:1)
    at Object.<anonymous> (/Users/philippederome/workspace/scalaLiftDemo/project/atom/packages/browser-plus/lib/browser-plus-view.coffee:1:1)
    at Module._compile (/Applications/Atom.app/Contents/Resources/app.asar/src/native-compile-cache.js:103:30)
    at Object.defineProperty.value [as .coffee] (/Applications/Atom.app/Contents/Resources/app.asar/src/compile-cache.js:208:21)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Module.require (module.js:367:17)
    at require (/Applications/Atom.app/Contents/Resources/app.asar/src/native-compile-cache.js:50:27)
    at HTMLEditor.module.exports.HTMLEditor.getViewClass (/Users/philippederome/workspace/scalaLiftDemo/project/atom/packages/browser-plus/lib/browser-plus-model.coffee:26:7)
    at ViewRegistry.module.exports.ViewRegistry.createView (/Applications/Atom.app/Contents/Resources/app.asar/src/view-registry.js:135:97)
    at ViewRegistry.module.exports.ViewRegistry.getView (/Applications/Atom.app/Contents/Resources/app.asar/src/view-registry.js:86:21)
    at atom-pane.PaneElement.getActiveView (/Applications/Atom.app/Contents/Resources/app.asar/src/pane-element.js:194:25)
    at atom-pane.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/pane-element.js:51:55)

Commands
     -3:17.3.0 command-palette:toggle (atom-text-editor.editor.is-focused.hyperclick)
     -3:11.9.0 ensime:start (atom-text-editor.editor.hyperclick)
     -2:01.6.0 core:copy (atom-text-editor.editor.is-focused.hyperclick)
  3x -1:27 core:select-up (atom-text-editor.editor.is-focused)
  9x -1:25.6.0 core:backspace (atom-text-editor.editor.is-focused)
     -1:18.6.0 core:save (atom-text-editor.editor.is-focused.hyperclick)
     -0:59.7.0 core:backspace (atom-text-editor.editor.is-focused)
     -0:58.2.0 core:save (atom-text-editor.editor.is-focused.hyperclick)
     -0:18.2.0 command-palette:toggle (textarea.)
     -0:05.7.0 browser-plus:open (textarea.)


Add possibility to specify a view-builder for annotations when binding

This PR adds a new overload to mapView.rx.annotations that permit the caller to define how a annotation should be rendered in the map, giving a callsite like:
requestForAnnotations() // Observable<[MyMapAnnotation]>
              .asDriver(onErrorJustReturn: [])
              .drive(mapView.rx.annotations) { (mapView, annotation) in
                  return mapView.dequeueReusableAnnotationView(withIdentifier: "MyMapAnnotationView", for: annotation)
              }
              .disposed(by: disposeBag)

This is a nicer solution to #12, at least in my opinion

@freak4pc Hi! Would you mind taking a look at this PR?


Upgrading from v1.1.2

Hi there,
I'm working with an application that is using an old version of Sneakers and would like to know what are the guidelines to bump the version up to the latest possible.
I don't see an upgrading doc nor notes in the readme so it makes me think that there aren't that many breaking changes but I'd like to check with maintainers or people that upgraded.
Thanks!

There is a change log.


How to use custom renderers in angular-handsontable

How to properly use custom renderers for the cells in angular2
Do we use the same approach as the docs indicated https://docs.handsontable.com/pro/1.13.1/demo-custom-renderers.html.
Thank you

Hi @GregFuntera,
Unfortunately, currently we have not any example, how you can do this.
On the other hand you can try to use something like that: http://jsfiddle.net/8854ae5b/

Below is example how you can add a custom renderer (with an editors and an validators is similar):
src/app/app.components.ts
import { Component} from '@angular/core';

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrls: ['./app.component.css']
})
export class AppComponent {
  settings = {
    renderer: function(hotInstance, td, row, column, prop, value, cellProperties) {
      // insert your custom renderer here
    }
  };
}

src/app/app.component.html
<hot-table [settings]="settings"></hot-table>

Read more about custom renderers.


Error building atom-keyboard-macros 0.12.1 on atom 1.31.1

Prerequisites

[ ] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
Please refer to issue https://github.com/atom/atom/issues/17828
I just upgraded to Ubuntu 18.04 LTS and am experiencing the same problem with the atom-keyboard-macros program.  Unfortunately the solution in issue 17828 of installing libxkbfile-dev is not available as it appears the package does not exist in the Ubuntu repos anymore.  The only libxkb* packages available are as follows:
ii  libxkbcommon-dev                          0.8.0-1                   amd64                     library interface to the XKB compiler - development files
ii  libxkbcommon-x11-0:amd64                  0.8.0-1                   amd64                     library to create keymaps with the XKB X11 protocol
ii  libxkbcommon0:amd64                       0.8.0-1                   amd64                     library interface to the XKB compiler - shared library
ii  libxkbfile1:amd64                         1:1.0.9-2                 amd64                     X11 keyboard file manipulation library

Steps to Reproduce

Start atom
One update shows for atom-keyboard-macros, click on it and then hit the update button
update fails

Expected behavior: [What you expect to happen]
Package is expected to update normally
Actual behavior: [What actually happens]
Package update fails with stack trace.  Pertinent information is below:
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
../src/keyboard-layout-manager-linux.cc:5:10: fatal error: X11/extensions/XKBrules.h: No such file or directory
 #include <X11/extensions/XKBrules.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [Release/obj.target/keyboard-layout-manager/src/keyboard-layout-manager-linux.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/share/atom/resources/app/apm/node_modules/node-gyp/lib/build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:126:13)
gyp ERR! stack     at ChildProcess.emit (events.js:214:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)
gyp ERR! System Linux 4.15.0-36-generic
gyp ERR! command "/usr/share/atom/resources/app/apm/bin/node" "/usr/share/atom/resources/app/apm/node_modules/.bin/node-gyp" "rebuild"
gyp ERR! cwd /tmp/apm-install-dir-11892-24006-1t2wuqh.fpja/node_modules/atom-keyboard-macros/node_modules/keyboard-layout
gyp ERR! node -v v8.9.3
gyp ERR! node-gyp -v v3.4.0
gyp ERR! not ok

Reproduces how often: [What percentage of the time does it reproduce?]
100%
Versions
bruce@BRUCE-CUSA:~/gitroot/3dprint/Marlin$ atom --version
Atom    : 1.31.1
Electron: 2.0.7
Chrome  : 61.0.3163.100
Node    : 8.9.3

Ubuntu 18.04 Linux 4.15.0-36-generic #39-Ubuntu SMP Mon Sep 24 16:19:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Additional Information
Problem occurs in safe mode as well

I'm surprised that the libxkbfile-dev package doesn't show up for you, it seems to be in Ubuntu's package site for 18.04: https://launchpad.net/ubuntu/bionic/+package/libxkbfile-dev.  I did a brief search and can't find any information about it being removed in that release.
What's the output of sudo apt-get install libxkbfile-dev?

Sorry, it is in the repo.  I was doing a dpkg-query to try and find it.  I must have been mistaken in thinking that would show me all packages available.  When I ran Synaptic, the libxkbfile-dev was there.  It's installed and the package builds now.  Closing this issue.

Glad to hear it's resolved for you now, thanks a lot for following up!

I'm surprised that the libxkbfile-dev package doesn't show up for you, it seems to be in Ubuntu's package site for 18.04: https://launchpad.net/ubuntu/bionic/+package/libxkbfile-dev. I did a brief search and can't find any information about it being removed in that release.
What's the output of sudo apt-get install libxkbfile-dev?

Thanks!
Was getting the same errors on doing npm install in Automattic/wp-desktop. Fixed after running sudo apt-get install libxkbfile-dev


Move Fern documentation to Fern's own documentation solution

Fern offers a strong documentation offering built in to the toolkit that allows developers to easily document their APIs. The Vellum documentation runs on this solution: https://docs.vellum.ai/api-reference/generate
However, Fern's own documentation currently does not. Let's fix that.

[x] Move documentation into its own repository (fern-api/docs)
[x] Change documentation to use fern's own solution
[ ] Implement GitHub actions to automate generation and deployments for documentation

Down to code review when ready

@dannysheridan There's an initial setup on the main branch of https://github.com/fern-api/docs already - figured since it's a carbon copy of the original docs there wasn't much to review.
I've currently published it to https://aevitas.docs.buildwithfern.com/ but it has some formatting issues, like none of the markdown elements look right. How can I best fix this?

I just added GitHub Actions to update the docs on release. I also renamed the docs URL to staging.docs.buildwithfern.com .
Ran into an issue here (https://github.com/fern-api/docs/actions/runs/5605814129/jobs/10255342974) that I hope to resolve promptly.

Thanks, I just made a few commits to that repo. Changes including:

org name to fern
docs link to staging.docs.buildwithfern.com
added logo and favicon

Formatting issues are going to require a deeper dive from @kafkas

I missed adding CONTRIBUTING.md to each of the repos. (Glad I checked all of the links.)

[x] Add to Typescript
[ ] Add to Java
[ ] Add to Go
[ ] Add to Python
[ ] Add to Postman
[ ] Add to OpenAPI

Formatting issues are going to require a deeper dive from @kafkas
Yeah, I think this is because the mdx and md renderers are currently using different settings. We probably need to file a separate issue for that.

This issue is pending resolution until we go live with the new documentation website.


Adapt ODS-293 to work with KFNBC and without old config maps

ODS-293 "Verify User Can Set Custom RHODS Groups" is still using the old config map way to set RHODS Access settings, instead of the new Dashboard CRD. This PR wants to fix the TC to work with the CRD.
Besides it fixes the compatibility issues between the TC and KFNBC
Signed-off-by: bdattoma<EMAIL_ADDRESS>

Jenkins Job 1211  SUCCESS

closed in favor of #533


HIVE-26759: Update SHOW_COMPACTION_QUERY to support postgres HMS

What changes were proposed in this pull request?

Update SHOW_COMPACTION_QUERY to support postgres syntax
Why are the changes needed?

Details: HIVE-26759
ERROR: column "CC_START" does not exist, when Postgres is used as Hive metastore
Due to this error, the Initiator class was failing after 1st iteration
Does this PR introduce any user-facing change?

No
How was this patch tested?

Manually configuring Postgres and Derby as HMS and see this error persist

@deniskuzZ @InvisibleProgrammer Thanks for the review, I have incorporated the suggestion, request your re-review


Fortify Insecure SSL: Overly Broad Certificate Trust (Security Features, Data Flow)

We are getting some security issues and one of them is as per title.
The call to dataTaskWithRequest:completionHandler:() in FIRMessagingTokenDeleteOperation.m on line 81 initiates an SSL/TLS connection using the default pre-loaded system Certificate Authorities (CAs) that might enable attackers to intercept encrypted communications by performing man-in-the-middle (MiTM) attacks using certificates signed with compromised root CAs.
Recommendations:
There are several possible solutions to reduce the level of trust on pre-loaded system certificates including:

Custom trust anchors: Use a custom keystore that only contains the certificates you want to trust.
Certificate pinning: Trust the default certificates but verify and enforce that the one used by your backend server is present in the certificate chain. As an alternative, public keys can be pinned instead.

Same goes for fetch The call to dataTaskWithRequest:completionHandler:() in FIRMessagingTokenFetchOperation.m on line 113 initiates an SSL/TLS connection using the default pre-loaded system Certificate Authorities (CAs) that might enable attackers to intercept encrypted communications by performing man-in-the-middle (MiTM) attacks using certificates signed with compromised root CAs.
Is this something we need to worry about?

@CyberMew Thanks for filing the issue. Would you mind file a ticket with the support team so we can follow up with more details on this?

Thanks, have just sent in a support ticket.

I don't think that's the right place to address this issue. @rizafran can you help @CyberMew file an internal bug?

Any solution?


Timeline in mobile app

When using the timeline in the salesforce mobile app it shows the outline of the component is out of place in the mobile view. The timeline it's supported for mobile devices?
Steps to reproduce:
Enter the Salesforce Mobile App
Go to an object with a timeline configured
Check that the line of the component overlaps the collapse/expand button

That indeed doesn't look great. We should be able to fix that in a next
release!
Ronald Klaassen
Senior Technical Architect | Salesforce
Mobile: +31620888998
http://salesforce.com/nl/signature
--
On Thu, Oct 10, 2024 at 2:35 PM paulopedras @.***>
wrote:

When using the timeline in the salesforce mobile app it shows the outline
of the component is out of place in the mobile view. The timeline it's
supported for mobile devices?
Steps to reproduce:
Enter the Salesforce Mobile App
Go to an object with a timeline configured
Check that the line of the component overlaps the collapse/expand button
timeline.final.jpg (view on web)
https://github.com/user-attachments/assets/e47a4b64-618f-40ce-a757-0224839b66bb
—
Reply to this email directly, view it on GitHub
https://github.com/SalesforceLabs/ActivityTimelineLWC/issues/30, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AF4CAFEN4XVL5FSZPL2NOKTZ2ZYBLAVCNFSM6AAAAABPWV64DOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU3TQNZRHE2TEOI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hi @paulopedras, looked into this. It seems that the mobile app doesn't apply the size attribute of the lightning-button-icon tag. Resolving this would mean refactoring all these kinds of buttons to a custom button. I don't think we will plan this work to be done unfortunately.


Revamp the frontend

The goal is to create a visually pleasing and intuitive user interface that enhances the overall user experience and incorporate changes from the CSV file.

can i work on this?

The goal is to create a visually pleasing and intuitive user interface that enhances the overall user experience and incorporate changes from the CSV file.

So i have worked on this and created a PR. Hope you like it


[RFC] Bolt Translate Compatibility

It would be nice to have this extension working with the bolt-translate extension.

A bit late to the party, but it seems there's no problem at all with Translate, the only thing you need to do is to add a &_locale=en to your call and Bolt + Transalte handles the rest.

Added this info to readme, so closing this one.

Thank you!


New Google Maps SDK Renderer

Feature request
Why it is needed
All devices on Android 5.0 (Lollipop) or later with 2 GB or more of data storage will use the new renderer. All other devices will continue to use the legacy renderer until further notice. SDK Progressive Rollout beginning March 2022.
Possible implementation
Upgrade Maps SDK to the new renderer (https://developers.google.com/maps/documentation/android-sdk/renderer)

+1 👍

I will take this issue, it looks simple to implement and for now I would just expose a prop to choose the renderer type.
the only issue I see is that the SDK demo shows initialization on application create, so it might be too late if we do it via prop (when view is loaded).

Is there any action required at all here? This repo still uses Maps SDK 5.1 so its not affected by Google's changes.
Or am I missing something here?

Everytime i add a new marker on the MapView, the MapView seems to rerender, it looks like its zooming in and out. i wonder if thats happening because this package is currently using the legacy renderer

Any timeline for this implementation ? current implementation isn't accepting playServicesVersion:18.0.0 from project level configurations.

any update on this ?

@Borduhh @siddharth-kt @pke @mak12 @dishantwalia Please take a look at this open PR #4055.
It would be very helpful if you can test the proposed changes with your app and report back with any issues you come across.

The new renderer can be now be enabled starting from v0.31.0-beta.2 which is released on the beta channel of npm. Props to @isidoro98.


Fix build failure in CI using temporary workaround

What this PR does / why we need it:
CI build fails as go import path is not migrated to sodafoundation. Use temporary workaround of creating soft link to fix this.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

Codecov Report

Merging #1238 into development will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development    #1238   +/-   ##
============================================
  Coverage        34.72%   34.72%
============================================
  Files               97       97
  Lines            17665    17665
============================================
  Hits              6135     6135
  Misses           10651    10651
  Partials           879      879


Add a new oneMKL sample: binomial

Adding a New Sample(s)
Description
Adding a new oneMKL Sample: binomial. It's planned to demonstrate how to use oneMKL RNG Host API with heavy computations after that.
Checklist
Code Development

[x] Implement coding guidelines and ensure code quality. see wiki for details
[x] Adhere to readme template
[x] Enforce format via clang-format config file
[x] Adhere to sample.json specification. https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-specification
[x] Ensure/create CI test configurations for sample (ciTests field) https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-ci-test-object
[x] Run jsonlint on sample.json to verify json syntax. www.jsonlint.com

Security and Legal

[x] OSPDT Approval (see Project Manager for assistance)
[x] Compile using the following compiler flags and fix any warnings, the falgs are: "/Wall -Wformat-security -Werror=format-security"
[ ] Virus scan

Review

[ ] Review DPC++ code with Paul Peterseon. (GitHub User: pmpeter1)
[x] Review readme with Tom Lenth(@tomlenth) and/or Project Manager
[ ] Tested using Dev Cloud when applicable

@IgorOchocki, @tomlenth, @jimmytwei, did you have a chance to look at the sample?

@IgorOchocki, @tomlenth, what else do we need to do for this PR to merge?

@andreyfe1, Igor is out on vacation, but is Jimmy's cover.  He's back early next week.  You may want to email directly or contact in real time via teams to get his attention on this.  He'll likely have well over a hundred git notices.


Parse M.[]

fixes #2028

What happens in a jsx context?

Thanks for the review. I added test cases for JSX context + tweaked the printer to print without parens.

Thanks for the quick PR! Looks fine by me.
@chenglou ready to merge.

Thanks


feat: add permissions v2

Permissions V2 endpoints

@peterdeme can you add support to context for Permissions related method please? cf https://github.com/GetStream/stream-chat-go/pull/153


[Question] Ability to call service to have Assist Microphone reactivate for continued conversation.

So far the Assist Microphone is working great, but I was wondering if there is any way to have it trigger with a service call? For Example, you make the service call, the Awake sound triggers and the mic is ready for further input.
I'm using the "Extended OpenAI Conversation" add-on to use the OpenAI conversation agent for device control as well as conversation via Assist. Which is a game changer for Assist (https://github.com/jekalmin/extended_openai_conversation)
It could easily have a function that would call this service if it's last response ended in a query.

Not only for continued conversation. I have a dashboard next to the microphone device and just want to have a button there, so I can skip the wake word. Wake words don't work in noisy environments.

This is something I would consider adding to the Wyoming Satellite code: https://github.com/rhasspy/wyoming-satellite

This is something I would consider adding to the Wyoming Satellite code: https://github.com/rhasspy/wyoming-satellite

Thanks for the update. I haven't had need for the satellite devices. The conference speaker I have connected to my HASS server via assist microphone picks me up from anywhere in my apartment thankfully. I suppose if we get service calls in the satellite code I can always move it to a pi, assuming it doesn't end up being slower than directly connected to HASS.


2647 result backend

André, this PR will:

Add reporting period start and end dates to the result creation endpoint
Make the result creation available to medium and high users, not just high users
Fix the Python tests by rejiggering the way admin_type is delivered by the serializers

I'm hopeful that this will make the admin_type available to both program pages and IPTT pages.


Add support for uploading an ostree commit to Pulp

A new target and uploader is added pulp.ostree.  The pulp namespace will most likely be used for more targets in the future.

If the user-defined repository does not exist, create it.
If the repository was created, distribute it (make it available for download).
Import the commit into the repository.

The uploader workflow was based on Pulp's guide and demonstration video.
It uses a client API library that I autogenerated and made available here: https://github.com/osbuild/pulp-client
Relevant tickets
https://issues.redhat.com/browse/HMS-1163
https://issues.redhat.com/browse/HMS-2340

About testing
We can add a test in CI that spins up a Pulp container to work with but in my local testing using the One Container the import and distribution tasks take a few minutes and would be adding extra delays to our ostree integration tests.  Maybe we should add a separate test for this that builds and pushes a single commit and does a remote repository check (with ostree remote add ... and ostree remote summary ...). (cc @henrywang)
Also, while testing, I discovered that there might be a bug when multiple commits with different refs are imported to the same repository: https://github.com/pulp/pulp_ostree/issues/277

This pull request includes:

[ ] adequate testing for the new functionality or fixed issue
[x] adequate documentation informing people about the change such as

[x] submit a PR for the guides repository if this PR changed any behavior described there: https://www.osbuild.org/guides/

Guides PR: https://github.com/osbuild/guides/pull/144

Something I wasn't sure about is the decision to return from the upload code before async tasks are complete.
The import and distribute can take a while but I made it so that the URL is returned before they're finished.  Would it be better if we blocked while these tasks run?  I don't know how long it can take for them to finish in realistic scenarios.

Converted to draft until we add tests.

I added a few comments, but the PR looks good. I have additional questions:

Is there a plan to add the support for Cloud API for this upload target?

Yes, in fact that's the main goal.  However, since in the cloud API we associate upload targets with image types directly, we need to wait until the internal Pulp service is available before adding the target to the Cloud API.  For now, I'm adding it to weldr only so we can test everything.

Is there any dependency between publishing of the repo and importing the commit, which would mandate a requirement to make them synchronous?

The two actions can be done in any order and are basically independent of each other.  Publishing/distributing a repository before a commit is imported creates a distribution (a content path) that has nothing to serve (it just 404s).

Can importing of the commit or publishing of the repo fail after the request for the action is created? I'm asking, because we may run into a situation where we return success for the target from the worker, but the actual import or publishing failed eventually and the content would not be available.

That's definitely possible.  It's basically the thing I was wondering in my second comment.  It would make sense to wait for the import to finish, but it can take several minutes.  So I'm wondering if it's a good idea to block for several minutes, holding up the worker that's not really doing anything, while a remote server is processing.  I don't know what's better here.

It would make sense to wait for the import to finish, but it can take several minutes. So I'm wondering if it's a good idea to block for several minutes, holding up the worker that's not really doing anything, while a remote server is processing.

This is what happens with AMIs today, AFAIK. A potential solution for both AMIs and ostree commits is to split the job in two pieces: 1) build+upload; and 2) import. Then importing could be done in parallel with future builds, so there is no blocking.

Questions:

Did you consider leaving the repository creation/publishing to the caller? Similarly to how S3 buckets are not set up in composer, but by the caller. Could simplify things potentially?
How will we deal with authentication between workers and pulp in crc? Will the pulp instance in crc publish a public API the worker can talk to?

Questions:

Did you consider leaving the repository creation/publishing to the caller? Similarly to how S3 buckets are not set up in composer, but by the caller. Could simplify things potentially?

Is the caller in this case the customer or the IB service?  We could go this way.  Assume it's all created beforehand.

How will we deal with authentication between workers and pulp in crc? Will the pulp instance in crc publish a public API the worker can talk to?

I think that's the plan, yes.  @croissanne ?

It would make sense to wait for the import to finish, but it can take several minutes. So I'm wondering if it's a good idea to block for several minutes, holding up the worker that's not really doing anything, while a remote server is processing.

This is what happens with AMIs today, AFAIK. A potential solution for both AMIs and ostree commits is to split the job in two pieces: 1) build+upload; and 2) import. Then importing could be done in parallel with future builds, so there is no blocking.

I had a very similar idea, I would just make the import async and add a new job type which would wait for import to finish in parallel with any osbuild job. Basically in the same way as we do for depsolving.
The tricky part is that such a change would be very disruptive, since composer assumes that the UUID of the osbuild job is the actual compose UUID and we use that to determine status, logs, etc in API endpoints. We already have a special case for Koji where the last job is the KojiFinalize and its UUID is used as the compose UUID. We would have to do a similar thing for new non-Koji composes and only for some of them depending on the used target. I'm sure someone can figure out an elegant and backward incompatible way to make it work, I just wanted to point out that this is not a trivial task.

Hi @achilleas-k I have tested uploading commit in pulp and it seems works well.
My steps:

configure pulp using one container
build edge-commit image and upload it to pulp.
create local repo, pull content from pulp to local repo.
provision vm with local repo
build an upgrade edge-commit image, and upload to pulp. (same repo, same distribution, same path). Now pulp repository changed to version 2 with new commit.
pull new commit content from pulp to local repo.
run 'rpm-ostree upgrade' to upgrade current vm, success.

And I have some questions:

Could you please give an example of 'composer-cli' command to build and upload to pulp?
Customer need to configure pulp properly before using composer to build image? like creating repo, creating distribution, etc.
The upload will take a while, if customer check the composer job status, what's the expected result? 'running', 'uploading', 'finished',  etc?
If build success but upload failed, can user still be able to download the image?

@yih-redhat, Achilleas is out until tomorrow so I can try answer some of your questions. He has a small test though that he wrote here: achilleas-k/pulp-ostree-test
The test does depend on https://github.com/pulp/pulp_ostree/issues/277, but there is an open pull request for this... I built the all-in-one container locally with the changes from that PR and I was able to test it successfully using the above tests.

Could you please give an example of 'composer-cli' command to build and upload to pulp?

For the configuration, here is a link to the guides PR: (https://github.com/osbuild/guides/pull/144). Or you could use the small test Achilleas wrote for reference.

Customer need to configure pulp properly before using composer to build image? like creating repo, creating distribution, etc.

As it stands the user doesn't need to do any of those steps. A repo will be created if it doesn't exist, the commit will get imported and the repository will get distributed.

The upload will take a while, if customer check the composer job status, what's the expected result? 'running', 'uploading', 'finished', etc?

As far as I know the job status will be 'running' even for the 'uploading' part... for on-prem we just have 'running', 'waiting', 'finished' & 'failed'. But maybe one of the others could correct me if I'm wrong.

If build success but upload failed, can user still be able to download the image?

I don't think this is possible at the moment. Again, someone could correct me here.

Thank you @kingsleyzissou

What's the final decision of async import job? I found the compose job is at finished status, but importing job is not finished yet, usually need to wait several minutes until I can see content in pulp (At first I thought something was wrong in compose job but the log shows no error, then after a while I checked pulp again and found the content.). Filed a github bug  https://github.com/osbuild/osbuild-composer/issues/3673 to track this.

Composer will build the image first even if the pulp configuration in pulp.toml is wrong and job will fail at final upload step.
Composer should check and deny the build request if pulp configuration is wrong, just like what it does for --url parameter, if --url is wrong, the compose job will not start.
Filed a bug https://github.com/osbuild/osbuild-composer/issues/3674 to track this.

https://github.com/pulp/pulp_ostree/issues/279 also blocks this PR.
I just found the child commit cannot be imported into pulp repo where parent commit was imported, and then I found @achilleas-k already filed this bug.

Added test case for pulp, and due to bug https://github.com/pulp/pulp_ostree/issues/279 , test case cannot success.

One more question @kingsleyzissou , what OS does this PR support? rhel9.3 and later? how about fedora and centos-stream?

Any releases made after this PR is merged will support this.  We wont be gating the feature on any OS or OS version.  Also, we wont be backporting this to any existing RHEL versions and I don't think we want to go through the exception process to get this into 9.3 or 8.9.
FTR, this feature is primarily intended for the hosted service.

Marking as ready since we have tests and we should be working to get this through tnow.

Hi @achilleas-k , for issue https://github.com/osbuild/osbuild-composer/issues/3673, is there any update?
Currently I can only check pulp to know if the import is completed, it might finish in about 5~20 minutes after compose job finished (importing child commit will take longer).
I suggest to fix this issue, but as this feature is for hosted service, maybe they have different thoughts.

Filed bug https://github.com/pulp/pulp_ostree/issues/288 in pulp repo.
Upload parent commit into pulp and ostree pull can pull the commit content from pulp, then upload child commit into pulp, but ostree pull cannot find the new commit content.

Filed bug https://github.com/pulp/pulp_ostree/issues/289 in pulp repo.
Issue description:
Upload parent commit takes around 5 minutes, but upload child commit takes more than 40 minutes, that's too long as there is only minor update content in child commit.

Hi @achilleas-k , for issue #3673, is there any update?

This wont be solved in this PR.  The current behaviour is compatible with what we do in other uploaders and a proper solution would be too big and is left for another time.  The alternative, quick solution would be to make the build wait for the import to finish which we don't want to do.

Did I misread @teg's comment (#3636 (comment))? Looking at the upload code, it seems we block until the AMI is ready to boot.

That's what I intended to write / suggest we do. But I may have mistyped my comment.

@achilleas-k yes, we always block until the image importing is finished. I must admit that I'm puzzled WRT which approach is the best here... Blocking the worker for tens of minutes is definitely not great. However, not having the image (commit) available in the target environment and claiming that everything is done is also not great.
I think that we should block for now, to be consistent with other uploaders and think about the best solution (potentially wait until this becomes an issue?)...

I addressed @thozza's minor comments.  I'll modify the uploaded to block until the repo is ready now.

The function that uploads and distributes a commit now waits for any async tasks to finish before returning.

The function that uploads and distributes a commit now waits for any async tasks to finish before returning. cc @yih-redhat

Thanks, and just let you know, there is a performance issue https://github.com/pulp/pulp_ostree/issues/289 here when uploading child commit, it could take more than 40 minutes. (my last attempt took 48 minutes)

The function that uploads and distributes a commit now waits for any async tasks to finish before returning. cc @yih-redhat

Thanks, and just let you know, there is a performance issue pulp/pulp_ostree#289 here when uploading child commit, it could take more than 40 minutes. (my last attempt took 48 minutes)

Thanks.  I think I'd rather get this merged now and then focus on these things later.

The function that uploads and distributes a commit now waits for any async tasks to finish before returning. cc @yih-redhat

Thanks, and just let you know, there is a performance issue pulp/pulp_ostree#289 here when uploading child commit, it could take more than 40 minutes. (my last attempt took 48 minutes)

Thanks. I think I'd rather get this merged now and then focus on these things later.

Ok, now we have only one blocking bug https://github.com/pulp/pulp_ostree/issues/288, this bug is already fixed by pulp team, and I am verifying it now.

Verified pulp bug https://github.com/pulp/pulp_ostree/issues/288 with nightly container in docker.io, fixed.
I updated my test script (which has passed in my local env) and triggered the CI test, once the CI pass this PR is ok to merge.

RPM builds are failing on RHEL 8 and CS8 for aarch64.  @kingsleyzissou and I have been trying to reproduce it but in our local builds it's working fine so far.

I found this in the logs:
github.com/osbuild/pulp-client/pulpclient: /usr/lib/golang/pkg/tool/linux_arm64/compile: signal: killed

I think it's an OOM killer. When I try compiling pulp-client, I get:
fatal error: runtime: out of memory

After some more investigation by @ondrejbudai, he discovered that a 1 GiB swapfile solves the OOM issue for el8 aarch64 builds and we agreed to use that.

Rebased and fixed conflicts.

Hi! @achilleas-k @yih-redhat,
I found the Pulp test takes more than 1 hour.

Building installation and upload to pulp takes 9 minutes (19:03:48-19:12:35) -- This looks reasonable.
Pull from pulp server (local server) to local takes 10 minutes -- 10 minutes doesn't make sense. It's local to local.
Building upgrade image and upload to pulp server takes more than 30 minutes (19:26:06-20:07:06 not finished yet) -- It's not reasonable.

@achilleas-k Do you have any suggestion on that? Thank you!

Hi! @achilleas-k @yih-redhat, I found the Pulp test takes more than 1 hour.

Building installation and upload to pulp takes 9 minutes (19:03:48-19:12:35) -- This looks reasonable.
Pull from pulp server (local server) to local takes 10 minutes -- 10 minutes doesn't make sense. It's local to local.
Building upgrade image and upload to pulp server takes more than 30 minutes (19:26:06-20:07:06 not finished yet) -- It's not reasonable.

@achilleas-k Do you have any suggestion on that? Thank you!

Yih already has an issue open for the upload performance here https://github.com/pulp/pulp_ostree/issues/289.
That issue links to this more general issue about investigating the performance of the pulp ostree plugin: https://github.com/pulp/pulp_ostree/issues/169

@henrywang I'd like to get this through without blocking on the Pulp performance issues.  There are other things dependent on this and the slow performance is an external factor.  Maybe it's better to disable the test or run it only nightly with a longer timeout so that it doesn't affect CI runtime for all PRs.
What do you (and everyone else) think?

I updated the pulp test case due to performance bug https://github.com/pulp/pulp_ostree/issues/289
Added short pulp test case in a separate ostree_pulp.sh, will build commit, upload to pulp and provision edge vm, it's much faster now.
The upgrade test are removed and can be added back once the performance pulp bug fixed.

As a new separate test script, ostree-pulp.sh need to be added into rhel-edge-ci project, then ci can run pulp test.
The problem is, once we added pulp test in rhel-edge-ci, pulp test will run for each new pull request after that, and if this pull request is not merged at that time, pulp test will fail.
The solution is to add pulp test in rhel-edge-ci, and merge this pull request at the same time. Here is the steps:

add pulp test in rhel-edge-ci
trigger ci test for this pull request.
merge this pull request.

We can do it at our day time, so it will not impact any new pull request in osbuild-composer. @achilleas-k @kingsleyzissou Please let us know when this pull request is ready for merge.

Rebased and resolved conflict.

The PR is green and ready from my side.

The PR is green and ready from my side.

Thanks, @henrywang and I will handle this.

@yih-redhat edge-minimal-raw-cs8 is failing on the persistent journal check.  Any idea why that might have changed?

Rebased and fixed go.mod conflicts.


Remove some more cut duplication

Praise ze awk!

I have a feeling this will lead to many changes to awk.
I don't think now is the time to go after the cut pipes. If you want to help out with some pipes, feel free to continue grouping the greps before we get to the cut stuff.
I like the idea as a whole, but let's hold off for a little bit.


[SPARK-12057] [SQL] Prevent failure on corrupt JSON records

This PR makes JSON parser and schema inference handle more cases where we have unparsed records. It is based on #10043. The last commit fixes the failed test and updates the logic of schema inference.
Regarding the schema inference change, if we have something like
{"f1":1}
[1,2,3]

originally, we will get a DF without any column.
After this change, we will get a DF with columns f1 and _corrupt_record. Basically, for the second row, [1,2,3] will be the value of _corrupt_record.
When merge this PR, please make sure that the author is @simplyianm.
JIRA: https://issues.apache.org/jira/browse/SPARK-12057
Closes #10043

@simplyianm  @srowen  I create this PR based on #10043. Please see https://github.com/yhuai/spark/commit/d8722bb30d347fa97c7d358284eb433edb1be6ec for my change. This PR should fix the test. It also makes the schema inference more robust to records that we cannot parse.

Test build #47641 has started for PR 10288 at commit d8722bb.

Test build #47641 has finished for PR 10288 at commit d8722bb.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47641/
Test FAILed.

Test build #47646 has started for PR 10288 at commit 9971300.

Test build #47646 has finished for PR 10288 at commit 9971300.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47646/
Test PASSed.

Test build #47863 has started for PR 10288 at commit ad71433.

Test build #47863 has finished for PR 10288 at commit ad71433.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47863/
Test PASSed.

Merged build finished. Test PASSed.

LGTM

I'm going to merge this into master & branch-1.6.


Update and fix dependencies (cough cough, Facebook 😁)

See #926
@samtstern I'm targeting v2.3.1... Do you still plan on releasing that? Or are we moving on to 3.0?

@SUPERCILEX this is the correct branch, may try and get a 2.4.0 out, 2.3.1 would not be the right version anymore since we added some functionality (default phone number args)

@SUPERCILEX what do we get by upgrading to 4.27.0?

@samtstern Oh, yeah gotya. 😄

What do we get by upgrading to 4.27.0?

Besides some bug fixes, we mostly benefit from Facebook's new module system to reduce APK size, hence why they broke compatibility. I'm guessing you're think of pushing this to 3.0 since it breaks compatibility for people who don't update the Facebook lib?

@SUPERCILEX does it break compatibility?  If someone consuming this specifies a lesser version Gradle will upgrade to ours.

@samtstern Not anymore, right? We're using provided deps for the auth stuff:
https://github.com/firebase/FirebaseUI-Android/blob/9dc4c120f33d4f4acc42b2a0c2195e130e8b1076/auth/build.gradle#L54-L55
And I'm pretty sure our Gradle deps don't touch the consumer's because we're using provided.

Ohhh yeah.  Well I think we can push this to 3.0.0 to be super-duper-safe.  Even though I bet it would be fine either way.

@samtstern K, I changed the base to 3.0.


bug: 500 Error when using non-existing attribute in uniqueness_constraints

Component
infrahubctl
Infrahub SDK version
0.14.0
Current Behavior
When defining a schema with a node that includes auniqueness_constraints field referencing a non-existing attribute, the system throws an internal server error (500).
Ideally, the system should provide a validation error or a clear message explaining that the referenced attribute does not exist.
Expected Behavior
The system should validate the schema and return a descriptive error message
Steps to Reproduce
Using the schema below with auniqueness_constraints, referencing an attribute that does not exist in the node's attributes list.
version: '1.0'

nodes:
  - name: Test
    namespace: Random
    attributes:
      - name: name
        kind: Text
    uniqueness_constraints:
      - ["non_existing_attribute__value"]

Load the schema.
The server returns a 500 error.
> infrahubctl schema load test-schema.yml
HTTP communication failure: Server error '500 Internal Server Error' for url
'http://localhost:8000/api/schema/load?branch=main'
For more information check:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/500 on POST to
http://localhost:8000/api/schema/load?branch=main

Additional Information
No response

This looks like a backend bug.


QA - update usage image for Search

Need a different cropping or context of this image to show search. I originally thought it was a bug in the site of a data table and did not realize it was trying to show Search in context.

Done


Implement fast checkout

Implement fast-checkout orb

Add .circleci/test-deploy for sanity checks
Add docs, usage, etc
Move builds to production builds

Orb is published to: https://circleci.com/developer/orbs/orb/issmirnov/fast-checkout

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/issmirnov/fast-checkout?version=dev:be26a105312cb65ab4dc3b325c8c0a3b2f566575

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/issmirnov/fast-checkout?version=dev:ac449ec98ea44ebb072faecf03f0262e5c43291b

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/issmirnov/fast-checkout?version=dev:0f5ac732015ec012f9ee1c3926465b52520301e6

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/issmirnov/fast-checkout?version=dev:f7907141ee6a0e45db5305aa85d6e6165806b7e6

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/issmirnov/fast-checkout?version=dev:cde68076c4119e155c589304362f0bd7450ae4c2

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/issmirnov/fast-checkout?version=dev:47438f1889b570ee26f39be1b4fb2accb26c55b4

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/issmirnov/fast-checkout?version=dev:595e8d3cda3dd5175b2c9a1e1e331086dda692c4

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/issmirnov/fast-checkout?version=dev:a864b8af0cd07262315bf371487f3707b2beb5b2

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/issmirnov/fast-checkout?version=dev:7b8853ac365f6a0934d0a18a7da97758d21e3b9d

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/issmirnov/fast-checkout?version=dev:8a07fd482984bc1565d1e22dc3f23152dba1fcef

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/issmirnov/fast-checkout?version=dev:c91cd24683ac1be8a5e54c68c07e435dde397ef4

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/issmirnov/fast-checkout?version=dev:0bd49d5f806c6d0b9a3319bad97c2fab60e3cc79

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/issmirnov/fast-checkout?version=dev:0bd49d5f806c6d0b9a3319bad97c2fab60e3cc79

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/issmirnov/fast-checkout?version=1.0.0


Op type not registered 'LSTMBlockCell' in binary running on _

I get this error when loading a graph. I'm trying to load a NER graph from Pavlov AI.
tensorflow v.1.10
Op type not registered 'LSTMBlockCell' in binary running on _. Make sure the Op and Kernel are registered in the binary running in this process. Note that if you are loading a saved graph which used ops from tf.contrib, accessing (e.g.) tf.contrib.resampler should be done before importing the graph, as contrib ops are lazily registered when the module is first accessed.
On the forum tensorflow offer to rebuild tensorflow api with enabled contrib module. Is this really the only solution?
Could you help to solve this problem?

I have the same issue with tf 1.8

Were there any updates or workarounds to this problem? I'm encountering the same issue currently.

I'm getting something very similar: "Op type not registered 'BlockLSTM'". Would love to have a solution.


Sanity rate contract should return 0 if rate was never set

In present implementation it might revert.

in which contract it might revert?
I does return 0 on this situation


Configurable units?

Hi there! Love the work you've done here, I just started using it with my daughter!
I noticed the feeding units are hardcoded to ounces, any chance you could make it configurable for us metric folks? :-)

Yeah, we're all over the place with units. I've generally just avoided using units at all (see weight), leaving it to the user to decide. The feeding amount field only shows "oz" in the list view (I think?). What I will likely do for now is just remove units where I see them.
Let me know what other things you run in to as you use it! My son is a little over six months now and we have pretty much settled in to our own habits of use, so new perspectives will help me identify improvements and additions we haven't thought of.
Congrats and good luck!

911cde4f9563472ace1a906526aadead2910f924 makes the small change of removing the couple uses of "oz".


Add how to re-publish a message to README

Adds a description about "how to re-publish a message" to the README.

@hnrkdmsk Maybe it's time to merge this? @danielrehmann last call to review 😁


Discussion: Should an admin be able to add names to the speaker list for those who doesn't use the website?

I think, and @Tejpbit please correct me here, that this is already possible?

If you mean that The speaker can add an arbitrary name to the list I believe this already works

Can confirm, already works.
An admin can add somebody to a speakers list. If the person already exists, then that person is added, otherwise, a new user is created and added.