cherry-pick (#359) to master

feat: support kubernetes api proxy

Signed-off-by: lyp256<EMAIL_ADDRESS>
golint fix

Signed-off-by: lyp256<EMAIL_ADDRESS>
adjust func

Signed-off-by: lyp256<EMAIL_ADDRESS>Signed-off-by: lyp256<EMAIL_ADDRESS>
What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

/cc @x893675

Codecov Report

Merging #374 (1e453d4) into master (e29d8d6) will decrease coverage by 0.04%.
The diff coverage is 16.26%.

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
- Coverage   12.33%   12.29%   -0.05%
==========================================
  Files         102      102
  Lines       16733    16817      +84
==========================================
+ Hits         2064     2067       +3
- Misses      14422    14502      +80
- Partials      247      248       +1

Impacted Files
Coverage Δ

pkg/apis/core/v1/registry.go
0.00% <0.00%> (ø)

pkg/apis/core/v1/utils.go
54.24% <0.00%> (-4.64%)
:arrow_down:

pkg/apis/core/v1/handler.go
0.33% <3.92%> (+0.02%)
:arrow_up:

pkg/authorization/rbac/rbac.go
51.63% <40.74%> (-1.82%)
:arrow_down:

pkg/server/request/request.go
73.46% <46.66%> (-6.54%)
:arrow_down:

/lgtm
/approve


Element header doesn't seem correct.

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details

The Element page states in the header

Element is the most general base class from which all objects in a Document inherit.

I'm not really sure how to understand this, but for me this seems completely wrong.
Maybe the author was thinking about Node?  But then, Document inheriting itself from Node that wouldn't make too much sense either to say this...
I think a complete rephrase is needed, though I fail to find the proper one.

I think you've got a point here.
If you look at the specs, Element inherits from Node, and everything else inherits from Node. FRom the spec:

Node is an abstract interface and does not exist as node. It is used by all nodes (Document, DocumentType, DocumentFragment, Element, Text, ProcessingInstruction, and Comment).

So I think they oare on about element objects, not all objects. I've updated the description to reflect this — do you think it is better now?

Yes thanks.


Refactor: Use github.com/spf13/cobra to execute cmd for apiserver

Signed-off-by: wuzhongjian<EMAIL_ADDRESS>Description of your changes
refer to kubesphere api server and kubevea plugin
Use github.com/spf13/cobra to execute cmd.

Fixes #
I have:

[x] Read and followed KubeVela's contribution process.
[ ] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

/assign @wonderflow
/assign @barnettZQG
/assign @Somefive

/assign @wonderflow /assign @barnettZQG /assign @Somefive

@nuclearwu P.S. Suggest not using "/assign" directly. Let's use assign if this is a decided task we needs to move on or keep an eye on that. If you want to call the approvers to review, using "@" itself is enough. :)

ok，thanks

/assign @wonderflow /assign @barnettZQG /assign @Somefive

@nuclearwu P.S. Suggest not using "/assign" directly. Let's use assign if this is a decided task we needs to move on or keep an eye on that. If you want to call the approvers to review, using "@" itself is enough. :)

ok, I got it

@barnettZQG


Fix. ZONEID support only since libcurl 7.65.0

Close #151

Coverage decreased (-0.5%) to 64.467% when pulling 069e78d64878fe48ce47dbc5bad64dd5b83e7cdd on moteus:zoneid into bddb7eb4c8c26a041ccff19812bfe137ee34548e on Lua-cURL:master.


Support for Vue v3.4 v-bind shortand syntax

In Vue v3.4, it is possible to write:
<script setup>
import { ref } from 'vue'

const disabled = ref(true)
</script>

<template>
  <button :disabled>Log in</button>
</template>

But vue-tsc throws with:
error TS2322: Type '{}' is not assignable to type 'Booleanish | undefined'.

26       <button :disabled>Log in</button>
                 ~~~~~~~~~

  ../node_modules/.pnpm/@vue+runtime-dom@3.4.0-rc.3/node_modules/@vue/runtime-dom/dist/runtime-dom.d.ts:411:5
    411     disabled?: Booleanish;
            ~~~~~~~~
    The expected type comes from property 'disabled' which is declared here on type 'ButtonHTMLAttributes & ReservedProps'

See the repro on the playground

Yes please. To be honest I am a bit disappointed that this was released as a new stable feature with barely, any support in the tooling.
In addition to the problem noted above, there are more errors, when using multi-word identifiers. E.g. <button :is-disabled> is interpreted as <button v-bind:is-disabled="is-disabled"> by vue-tsc, instead of <button v-bind:is-disabled="isDisabled">.

Even without TypeScript, I'm getting an error message like v-bind is missing expression. vue(34). Does language-tools generate this error? If it does, could you please fix it?

Because our support for v-bind shorthand has not landed yet.

Hi guys, any update on this one?

Are there any new updates on this? It looks like PR #3831 should be able to solve this. Can we expect it to to be merged soon?

I've implemented the basic functionality, but the mappings (highlight) are inaccurate. I can pack a vsix bundle if you need.

Any update on this?

Still nothing?

this is, literally, the only thing that prevents me from using this feature :/

Would really love to see this fixed. ✌

Finally working, Version 2.0 supports this, no more takeover-mode needed either, uninstall Volar :)

support camelCase, not support kebab-case

because you can not have kebab-case variable names in JavaScript

because you can not have kebab-case variable names in JavaScript

but this can run in .vue

vue shorthand is meant to bind your variables with their own name... thus, in shorthand you can only use valid javascript variable names. if you want to use kebab attributes, you can not use shorthand...

because you can not have kebab-case variable names in JavaScript

It actually does work, vue converts it internally. I do agree though that it's... not optimal 🥴

vue shorthand is meant to bind your variables with their own name... thus, in shorthand you can only use valid javascript variable names. if you want to use kebab attributes, you can not use shorthand...

It actually does work, vue converts it internally. I do agree though that it's... not optimal 🥴

eslint plugin vue rule recommend attribute hyphenation
https://eslint.vuejs.org/rules/attribute-hyphenation.html


customizable directory / file indicators

this would be nice to have as a personal preference (variable) that you can set inside .vimrc
I am not sure if this is already possible or not but it would be nice to have
thanks

Closing this off - as I am not intending to add fully customizable markers.


AAMP Node Names

In AAMP files, I have not yet figured out how the node names are indexed. They are probably hashed references to strings in U-King.rpx and other files. I am currently working on generating a hash table that matches but have not yet been successful. Once I have a hash table I will no longer use the id attribute, but just call the tag what the hash table indicates.

AAMP files are little-endian encoded so the crc32 hash was "reversed." Switching from hex strings to unsigned int indexes fixed the problem.


WIP: jbibla+fedekunze/1501 Modal Vote

Closes #1501
Description:

TODO:

[x] Modal to vote based on wireframe design
[ ] Link to explain the types of proposals
[x] Disable other option buttons if an option is selected and select the clicked button
[ ] Integrate modal with PageProposal blocked
[ ] E2E tests blocked

❤ Thank you!

[x] Added entries in CHANGELOG.md with issue # and GitHub username
[ ] Reviewed Files changed in the github PR explorer

this is governance 2 kind of stuff 😸

True ! I will add it to the scope of the gov2 issue


[Enhancement] Support compact thrift protocol

Fixes #issue

support thrift serialized protocol, for a complex sql, fragment plan size:

binary(default)
compact
json

901347 bytes
336452 bytes
2171040 bytes

and support thrift_plan_protocol in session variables  to control it

remove unused thrift parameters: signature and useVectorized

What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 3 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/service/internal_service.cpp
0
3
00.00%
[305, 398, 404]

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 3 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/service/internal_service.cpp
0
3
00.00%
[305, 398, 399]

[FE Incremental Coverage Report]
:heart_eyes: pass : 16 / 20 (80.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/rpc/AttachmentRequest.java
3
7
42.86%
[39, 41, 52, 54]

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/qe/scheduler/dag/FragmentInstanceExecState.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/rpc/PExecPlanFragmentRequest.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/qe/scheduler/dag/JobSpec.java
5
5
100.00%
[]

:large_blue_circle:
com/starrocks/rpc/BackendServiceClient.java
2
2
100.00%
[]

[FE Incremental Coverage Report]
:heart_eyes: pass : 18 / 20 (90.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/rpc/AttachmentRequest.java
5
7
71.43%
[39, 41]

:large_blue_circle:
com/starrocks/qe/SessionVariable.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/qe/scheduler/dag/FragmentInstanceExecState.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/rpc/PExecPlanFragmentRequest.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/qe/scheduler/dag/JobSpec.java
5
5
100.00%
[]

:large_blue_circle:
com/starrocks/rpc/BackendServiceClient.java
2
2
100.00%
[]

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 9 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/util/thrift_util.h
0
6
00.00%
[172, 173, 174, 175, 176, 178]

:large_blue_circle:
src/service/internal_service.cpp
0
3
00.00%
[305, 398, 405]


Set/change font color when working with Hyperlinks is impossible

Looks like it's not possible to set the color of the font if an hyperlink is present in the same run.
Here is my relevant code:
text_frame = shape.text_frame
p = text_frame.paragraphs[0]
# adding hyperlink
r = p.runs[0]
hlink = r.hyperlink
my_url = data["d_url"]
hlink.address = my_url

r.font.bold = False
r.font.italic = False
r.font.underline = False

r.font.color.rgb = RGBColor(0x00, 0x00, 0x00) # Black

This will still use the "hyperlink theme color" for the link, ignoring my setting.
Please suggest me how to change the hyperlink color or correct me if I am wrong

Do you actually want one hyperlink to look different from the rest? Other than "visited" versus "not" ? That would generally be considered poor for usability.

So the question becomes how to set the hyperlink colours - for visited and unvisited - across the board.
Glad I clarified - but I, personally, don't know how to do this.

Seeing if you can do it from the PowerPoint UI is a good start. If you can't that's a pretty strong indicator it's not supported and if you can it's an absolute indicator the format supports it.
The you can make a short PPTX that doesn't have a custom color, edit it with PowerPoint to color it, save it as a different name, then inspect the XML to see what's different. That's a reliable method to narrow down the XML portion anyway.

@scanny do you know where the theme stuff is stored - and how to edit it (in python-pptx)? Actually, where it's stored would narrow down the XML search space.
(To be honest - as I don't actually need this function in md2pptx - I doubt I'll have the time to prototype anything.)

IIRC there is a theme part, so it would be in the package, probably something like ppt/theme.xml. You could unzip -l a PPTX file to see if you see something like that in there. I don't believe we have a proxy part in the code for that though.
It's been a while, but I vaguely remember that being a pretty simple part, like not that many different element types and not very long.
@Mike3285 If that's where this setting (visited/not-visited link color) is stored then you could accomplish this by using a customized "template" presentation that you gave the color setting you want by hand using the PowerPoint UI. So like: prs = Presentation("my-customized-template.pptx") instead of prs = Presentation() in your code.

This link from Microsodft suggests it can be done in the UI - so must be doable in the file.

But, and this is more hopeful, you can override a hyperlink's colour explicitly. Here is the XML for a run in slide1.xml (in this case):
            <a:r>
              <a:rPr lang="en-US" dirty="0">
                <a:solidFill>
                  <a:schemeClr val="accent5">
                    <a:lumMod val="40000" />
                    <a:lumOff val="60000" />
                  </a:schemeClr>
                </a:solidFill>
                <a:hlinkClick r:id="rId2">
                  <a:extLst>
                    <a:ext uri="{A12FA001-AC4F-418D-AE19-62706E023703}">
                      <ahyp:hlinkClr xmlns:ahyp="http://schemas.microsoft.com/office/drawing/2018/hyperlinkcolor" val="tx" />
                    </a:ext>
                  </a:extLst>
                </a:hlinkClick>
              </a:rPr>
              <a:t>hyperlink</a:t>
            </a:r>

Certainly confectable, using python-pptx as a base. One could do this for all hyperlinks, I think.
Personally, though, I have no need for this. But it might inspire somebody else to write some Python.

By contrast, here's another hyperlink - that I didn't override the colour for:
            <a:r>
              <a:rPr lang="en-US" dirty="0">
                <a:hlinkClick r:id="rId3" />
              </a:rPr>
              <a:t>hyperlink</a:t>
            </a:r>

I looked at the theme. And this XML in ppt/theme/theme1.xml looks significant:
      <a:hlink>
        <a:srgbClr val="467886" />
      </a:hlink>
      <a:folHlink>
        <a:srgbClr val="96607D" />
      </a:folHlink>

The first looks like an unfollowed link and the seconf the followed link (both as RGB colours).
But, if as @scanny said, there's no way within python-pptx to modify this file the theme-wide approach won't work. A pity as it looks simpler.

IIRC there is a theme part, so it would be in the package, probably something like ppt/theme.xml. You could unzip -l a PPTX file to see if you see something like that in there. I don't believe we have a proxy part in the code for that though.
It's been a while, but I vaguely remember that being a pretty simple part, like not that many different element types and not very long.
@Mike3285 If that's where this setting (visited/not-visited link color) is stored then you could accomplish this by using a customized "template" presentation that you gave the color setting you want by hand using the PowerPoint UI. So like: prs = Presentation("my-customized-template.pptx") instead of prs = Presentation() in your code.

Thanks for your reply. At this point, I was referencing the Stackoverflow answer at the following link: Stackoverflow Answer where a kind user directed us to a guide explaining how to adjust the color template in PowerPoint directly.
Setting a theme and using it as a "template" for my presentations is working well, and I have successfully configured the hyperlinks in the desired color.
However, this approach is not particularly reliable or elegant, and I am eager to see this functionality incorporated into python-pptx. If we can't override the theme colors for hyperlinks, allowing us to set or modify the PPTX "theme" from within Python may be sufficient.


Surface pro 11 x

Had problems with the initial installation on the new surface pro 11.  Would not install or work correctly with SSMS v20 installed.  Had to remove SSMS, install sqlserver dev 2022 using the bat file and then install SSMS v18 as v20 appears to prevent the SQL server service to start for some reason.
Not really an issue now but just a note for reference.

@WW70ODY I'm trying to install SQL Server on my Surface Pro 11 (X Plus processor) but setup always fails. Can you help me by explaining a little bit more how you succeeded please ?

@maggimats Could you please share the log from the setup?

I finally made it to work with 2019 version but then couldn't login. Thanks to this comment, the elevated rights made it work as it was using a managed service account.


support setting integration name for alert

We'd like to start pushing some of our PrometheusRule evaluations through Coralogix, but at the moment we can't seem to natively setup the notification integration without using a Coralogix specific Kubernetes resource.
It would be nice if we could add an additional annotation to our already existing PrometheusRules to specify the name of the Notification Integration we would like to use.
Looking for some feedback on this approach.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @alexandermarston.
Thank you for your contribution. Please take into account that this may create a conflict with future support of alert-manger (ie alert-manager controller will override the logic you suggested).
Please resolve the conflict and I'll approve your PR.

Hi @alexandermarston. Thank you for your contribution. Please take into account that this may create a conflict with future support of alert-manger (ie alert-manager controller will override the logic you suggested). Please resolve the conflict and I'll approve your PR.

Thank you for the feedback.
Would ignoring the cxNotificationName annotation if the PrometheusRule is labelled with coralogix.com/managed-by-alertmanger-config be enough?
Just as some added context, the Alert Manager integration looks neat but as it currently stands it wouldn't be compatible with our Alert Manager implementation. We use the Alertmanager resource, but define our routes and receivers in a configuration secret not in the resource itself.

Thanks for the approval @OrNovo . I am still happy to add the additional check now, if you'd like?
I can see some tests are failing, but I don't believe they're related to my change.

@OrNovo regarding failing tests, I see on the e2e-test logs:
2024/10/13 15:21:42 Warning: teamLevelAPIKey was not provided. Some functionality will not be available.
2024/10/13 15:21:42 Warning: userLevelAPIKey was not provided. Some functionality will not be available.

I think there is no access to the repo secrets, because the tests run from @alexandermarston's fork. I think we can merge this PR.

@alexandermarston can you please sign your commit?

@assafad1 is there any chance for a review?

@alexandermarston thanks for your contribution!


Simplify AccountHash::from_public_key

There are various methods for constructing an AccountHash from a public key. Sometimes, the contract runtime's blake2bhash is called. Other times an account hash is constructed without going through the contract runtime.  We should decide how AccountHashs are constructed and be consistent.

@EdHastingsCasperLabs decided to close it


Include of non-modular header inside framework module 'Alamofire.Swift'

Using Xcode 7.1, installing Alamofire using either Carthage or CocoaPods results in a build failure.
May be related to https://github.com/CocoaPods/CocoaPods/issues/4420

Well, I tried cleaning and then rebuilding the project. Everything works now.

I just created a new Swift project and added Alamofire 3.1.1 using CocoaPods 0.39.0 and Xcode 7.1. Everything works properly. I'm going to close out. In the future, I'd encourage you to take these types of questions to Stack Overflow.


Localization updates for Hindi

Changes:

Renamed 3 locale files because they were incorrect.  I had also considered updating the language tags so that those with region/subculture tags were separated by a - instead of a _ (for consistency with BCP 47), but that didn't seem necessary.  (In case you're interested, here's a BCP 47 Validator.)
Added test for hi-IN.
Fixed a few trivial typos in comments.

Given that I was running this under bash on Windows, I had a minor problem getting the test npm script working (due to the leading environment variable assignment), so I improvised by adding "jest": "jest" to package.json, adding the following environment definition to the .babelrc file, and running the tests using npm run jest :
    "test": {
      "presets": ["env"],
      "plugins": [
        "transform-class-properties",
        "add-module-exports"
      ]
    }

Those improvisations aren't included in the PR, but I mention it in case you'd like to consider making a change like that for the benefit of others who may run into the same problem I did.

Pull Request Test Coverage Report for Build 396

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 40.288%

Totals

Change from base Build 395:
0.2%

Covered Lines:
118

Relevant Lines:
241

💛  - Coveralls


Don't working properly for global variables

DLight is very good project, thanks.
Unfortunately it does not work for such a simple code:

I'm not sure if what I'm venturing here is correct, but isn't that a feature, not a bug? The value of A (@Now, ie in memory) is displayed, it won't be able to look into the "future", after you have stepped past A:= 22, then the package will display the value of A as 22, you are measuring /before/ the memory of A is changed to 22, so it correctly displays the value of A=333 up until the point where you actually change the memory (by stepping past it) to 22, then all debug info of A wil read 22?

DLight currently does not support Global variables. I wish I could, but It is not yet examined.


Made table resize properly for all browser sizes

This was needed since my changes caused it to fail on any different window size than my resolution. If I shrunk my window it would break everything, now the tables are a bit stretched but work great for any resolution (even insanely compressed screens too).

One way to make this better might be to just drop the hacky floating middle piece and structure it like a table whereby we have
[left space] [table] [fixed width space] [table] [right space]
Where the tables are a fixed size, and the padding from the single column takes up the rest.
The floating buttons that go with you down the page is a cool idea, and maybe I'm not good enough at CSS yet to know how to tweak the file to do what I imagine (I can ask Christine tomorrow as well).

You're right -- the current stuff is pretty janky. Here's a potential replacement for it.

I like the improvements, there's only one thing to fix and it should be good (I'm not sure how to fix it): http://i.imgur.com/i3TOCff.png
If the elements can be nudged right a bit, I think it'd be a good to go replacement.
This one works better than the old one including corner cases of empty tables.

Thanks, @WChrisK and @arkon.
I don't have strong preferences here, and this does seem to be an improvements. Whatever is done for these tables, though, should also be done for the groups and graders table (and pull this out into common.scss or something).


Animation refactors tier 2

Tier 2 of around 5.
Introduces new SetAnimation() overload which allows for easy setting of animations from different slots.
To test:

All vehicles (mounts, dismounts, deaths).
Special creature deaths (TR1 torso boss, shiva, etc.).
Any other special animations.
Try killing various creature entities and see if they crash the game.

Okay done, nothing more will be pushed except to fix any bugs found.

I will be testing tomorrow

https://user-images.githubusercontent.com/84292688/229627702-e40301a8-6ec0-421f-9992-66fd24977ab0.mp4
If Minecart is parked on an angle, it loses its collision after lara dismounts and cannot be used again.

Killing the ID_GUARD will crash the game. I tested this with all weapons to the same result:
https://user-images.githubusercontent.com/84292688/229628142-0a2b7aa5-c015-41a8-9945-00f916c7bb10.mp4

https://user-images.githubusercontent.com/84292688/229630024-5d714857-4f1f-49ce-8c42-039ac3a5266b.mp4
This one I cannot quite describe but the jeep is really erratic on complicated terrain with lots of slopes and ramps. Will slide about and jump up to places it shouldn't.
This video was using this terrain:


Update and fix build for 0.11.0 beta 2

Debian is now used for the base image, and it's now multi-arch.

Thanks for submitting this. I just arrived at a very similar solution, which probably is a good sign :wink: Would you mind paramterizing the TARGETARCH in a way similar to what I attempted in #42?

Thank you for helping out! :heart:


Make kastri work with MQTT - The Standard for IoT Messaging

it will be great if kastri work with  MQTT - The Standard for IoT Messaging.
thanks

Can you be more specific about how Kastri should work with MQTT? Kastri covers a pretty broad spectrum of aspects of coding

Can you be more specific about how Kastri should work with MQTT? Kastri covers a pretty broad spectrum of aspects of coding

Closed due to no feedback received


esbuild plug-ins postcss / tailwindcss not working

I tried adding tailwind through an esbuild plug-in in various different ways. However, it seems like the plug-ins are never initiated.
This is my build-figma-plugin.main.js:
const { tailwindPlugin } = require("esbuild-plugin-tailwindcss");
const postcss = require("esbuild-postcss");

module.exports = function (buildOptions) {
  const config = {
    ...buildOptions,
    plugins: [...buildOptions.plugins, postcss() /* tailwindPlugin() */],
  };
  return config;
};

I also tried passing the plugin config directly:
plugins: [
    postcss({
      plugins: [
        tailwindcss('./tailwind.config.js'), // also tried without config path and passing config object
      ],
    }),
  ],

Here is a minimal setup
tailwindpostcss.zip
Is there a special way you have to add / configure esbuild plug-ins?

Suggest using the plugin/preact-tailwindcss template


DocumentReference.update throws an exception when the document does not exist

Fixes #40 and #152.

Published to https://pub.dev/packages/fake_cloud_firestore/changelog#124.

Note: we actually make the Future fail. Will switch to throwing an exception if necessary.


Missing rightmost cell borders when scrolling right with smoothScrollX

The last vertical cell borders disappears when scrolling right using keyboard arrow right on this small sample:
https://playcode.io/974328
You can see it flash before it disappears. Needs to have 5 or more rows to trigger the bug it seems.

You mean this?

No, in that last column the left border is missing on all rows. Impossible to take a screen shot/snip as the border will be drawn as soon as the grid lose focus. You should see it when scrolling using the keyboard right arrow key (selecting cell). Tested on Windows 10+11, latest Chromium browsers.

Thats it :)

Found the issue, it will be fixed in 5.1.3

Great :)


Package.isNew not behaving as expected

I think I know what's happening. We're tweeting inside analysis, before the new processingStage is applied. So technically, it's still on the previous stage. Need to either pull back the tweeting until after the stage is finished or revisit how we derive isNew. The former seems cleaner but might be tricky.

As an aside, the issue with tweetig about multiple tags is clearly fixed. Last night, we ingested the new package AppBoy iOS SDK with 117 releases:

That prompted only a single tweet:

So if isNew is proving problematic, we can perhaps make it a tweet that works for both new and existing packages and avoid the distinction.

The issue is that it's currently just not possible to tell from within any stage after reconciliation whether a package is new. I've updated the tests exposing the issue.
The problem with the isNew test that I'd added was that I'd not properly advanced the ingestion clock, meaning that the second cycle didn't actually take effect. Once it's added, it shows that isNew gets reset on the next ingestion, because it has no history.
When I worked on that yesterday got confused and thought we do

reconciliation
ingestion
analysis
go to 3 - analysis

when it's actually

reconciliation
ingestion
analysis
go to 2 - ingestion

The best way to fix this is probably to introduce a proper isNew flag on Package that we manage as we go through the stages, perhaps setting it to false once we complete analysis for the first time.
Alternatively, for the purpose of just tweeting, a simpler fix is to drop isNew for now and compose a message that works for both cases.

If it's any help with making the decision, one thing I've been thinking about for the front page is that we could combine the new releases and new packages lists into one "timeline" of stuff, giving us some space for more stuff on the home page. No firm plans yet, but it's been on my mind and it strikes me that a good decision here might make pulling that data easier.

Sounds like adding a isNew flag would offer us the most potential and flexibility down the line, but requires more work!


Feature: Up/Down transposing

Multiple people requested up/down transposing on the digigurdy.
I’ll incorporate this into the tuning menus somehow for all kinds of digigurdy.  Perhaps after the selection of strings, the summary screen would let you hit ok or go back, and additionally let you move everything up and down.  I don’t see a reason to not go ahead and support moving up and down an octave total in half-steps to make basically make playing in any key possible (as opposed to just a couple whole steps up and down or something).
For digigurdies that have the octave down/up buttons, maybe this should be their on-the-fly option.  Would want to re-think how the display works during play to not only show the note being played, but a little “status bar” showing where you’re at in terms of capo steps, listing of what that makes the strings currently.
I’m putting this down with the 1.5 milestone, but who knows… might bump it up.

The octave up/down buttons are now capo up/down.  It'll go an octave up or down in half-steps.
I got this in my rewrite already, so it'll be in the first stable version.  It will be reflected on-screen so you don't get lost 😄
I'm closing this issue.


Improve RequestScopedResourceModelCache execution flow and logging

The RequestScopedResourceModelCache can be improved in terms of execution flow (simplification of nested IFs), logging and null handling.

Done!


How to use C++ member function in thread pool

First of all thanks for your detailed write up to explain the code!
I am trying to use the threadpool submit function to take a C++ class member function. I am not able to compile. I followed standard std::thread  submitting a class member function method. Like the code shown below.
class A
{
   int i;
public:
      A() { i =10; };
    ~A()
    void func1() { i++;};
};

A objA;

ThreadPool tPool(10);

tPool.submit(&A::func1,&objA);

But I am getting the following error.
error: no matching function for call to ‘ThreadPool::submit(void (A::)(), A)’
Does the current submit() template function accept class member function? If not can you provide some tip as to how this function can be modified to accept class member function?
Appreciate your help.
Here is the std::thread method of passing a non static member function.
class Task
{
public:
	void execute(std::string command);
};

Task * taskPtr = new Task();

// Create a thread using member function
std::thread th(&Task::execute, taskPtr, "Sample Task");

Thanks,
Raj

Hey! I am glad you liked the readme, it took me some time to write it :+1:
Regarding your question, yes, there's a way to pass member functions. Unfortunately I am now having some trouble with the compilers and I cannot test it.
In the meantime, you can solve the issue using std::bind. The idea is basically to create a new function that is simply the function we want to call with the specific object from which we want to call it.
auto func = std::bind(&A::func_1, &objA);
pool.submit(func);

You could do exactly the same using lambda expressions, is up to you to choose what you think is better.
Hope this helps!

Thanks. I will  give std::bind a try or use lambda expressions. I will post the results to help answer others visiting your project.
Appreciate your quick reply.

Whenever I have some more time I will try to add an easier way to do it. I am really busy lately...

I tried both bind and lambda approach. Both did not work the way I wanted in my app! So using a C wrapper functions to invoke member functions via the class object. This works for me as I intended.

I tried both options and they worked for me. What do you mean with ¨Both did not work the way I wanted?
Anyway, I am glad you found the solution to your problem :+1:


warden xdebug 3 stop working

I was using this properly on my debian environment:

and my .env is:
WARDEN_ENV_NAME=project-alrajhi-m2
WARDEN_ENV_TYPE=magento2
WARDEN_WEB_ROOT=/
TRAEFIK_DOMAIN=project-alrajhi-m2.test
TRAEFIK_SUBDOMAIN=app

WARDEN_DB=1
WARDEN_ELASTICSEARCH=1
WARDEN_VARNISH=1
WARDEN_RABBITMQ=1
WARDEN_REDIS=1
ELASTICSEARCH_VERSION=7.9
MARIADB_VERSION=10.4
NODE_VERSION=10
COMPOSER_VERSION=1
PHP_VERSION=7.4
PHP_XDEBUG_3=1
RABBITMQ_VERSION=3.8
REDIS_VERSION=5.0
VARNISH_VERSION=6.0

WARDEN_SYNC_IGNORE=

WARDEN_ALLURE=0
WARDEN_SELENIUM=0
WARDEN_SELENIUM_DEBUG=0
WARDEN_BLACKFIRE=0
WARDEN_SPLIT_SALES=0
WARDEN_SPLIT_CHECKOUT=0
WARDEN_TEST_DB=0
WARDEN_MAGEPACK=0

BLACKFIRE_CLIENT_ID=
BLACKFIRE_CLIENT_TOKEN=
BLACKFIRE_SERVER_ID=
BLACKFIRE_SERVER_TOKEN=

phpstorm stoped receiving debugging session. I do nothing on machine except I install LAMP as well. I am not quite sure due to this its stop working.
Can any one guide me how can I debug this issue?

problem was with ufw
I run the command sudo ufw disable  resolve my issue


Astro does not refresh with Docker

What version of astro are you using?
1.2.6
Are you using an SSR adapter? If so, which one?
None
What package manager are you using?
npm
What operating system are you using?
Windows
Describe the Bug
I create my astro image in docker
FROM node:18-alpine3.15
RUN mkdir app
WORKDIR /app
COPY . .
RUN npm install
EXPOSE 3000
CMD ["npm","run","dev","--","--host"]

I build my image with the following command
docker build . -t astro-image
I run my container with this command
 docker run --name astro-container -p 3000:3000 -v C:\Workspace\Docker\docker-astro:/app -v /app/node_modules/ astro-image
So far without problems but when I make a change in the index.astro it does not refresh the page.
But the index.astro inside the container does change.
Link to Minimal Reproducible Example
https://github.com/SaulR07/docker-astro-example
Participation

[ ] I am willing to submit a pull request for this issue.

I'll take this up in the Docker recipe next week!

Should be documented now!

@ElianCodes I am having trouble finding a Recipe within the docs for a development container. Did it get written somewhere else?
These docs only seem to show how to deploy and build it.
https://docs.astro.build/en/recipes/docker/

Verify in the "Astro.config.mjs" Astro configuration file that has this configuration for recharge with the "NPM RUN DEV" command within a Docker container.
      export default defineConfig({
       server: {
                     host: true
                     hmr: {
                               //     This is if the Docker server is in another machine
                              //host: 'IP SERVER HERE'
                     }
         }
     });

I was stuck on this for a long time. I used the Vite config in Astro's astro.config.mjs file to enable hot reloading within a docker container.
// https://astro.build/config
export default defineConfig({
  integrations: [tailwind(), vue()],
  vite: {
    server:{
      host: "<IP_ADDRESS>",
      hmr: { clientPort: 3000 },
      port: 3000,
      watch: { usePolling: true }
    }
  }
});

You do also have to make sure you have a shared volume with your Docker Compose too.
web-dev:
    build:
        context: web
        target: develop
    volumes:
        - ./web:/web
        - /web/node_modules
    ports:
        - 3000:3000

Thank you for the solution. I would buy you a beer if I could.

I was stuck on this for a long time. I used the Vite config in Astro's astro.config.mjs file to enable hot reloading within a docker container.
// https://astro.build/config
export default defineConfig({
  integrations: [tailwind(), vue()],
  vite: {
    server:{
      host: "<IP_ADDRESS>",
      hmr: { clientPort: 3000 },
      port: 3000,
      watch: { usePolling: true }
    }
  }
});

You do also have to make sure you have a shared volume with your Docker Compose too.
web-dev:
    build:
        context: web
        target: develop
    volumes:
        - ./web:/web
        - /web/node_modules
    ports:
        - 3000:3000

Took me a while until this fixed it! Thank you!


add test to ensure that a version constraint having same upper and lower

bound works
compare with MNG-7106

Honestly, I was surprised by the existence of archaic maven-artifact org.apache.maven.artifact.versioning package, that is not even compatible (functionality wise) with resolver Version (and it's schemes). Personally, I'd just deprecate all this package as is.

@cstamas Are you fine with committing this additional test case?


[SLS-1260] Add functionname attribute to span metadata

What does this PR do?

Add the functionname attribute to the Lambda span metadata.
Motivation

Look at problem 2 here: https://docs.google.com/document/d/1Jd40XCKibvhVntIiT02xjaZZlq3P2ohRHZ8VnKtu46Q/edit#
Testing Guidelines

Check the trace metadata tags to ensure the functionname attribute is present.
Additional Notes

Types of Changes

[ ] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

[ ] This PR's description is comprehensive
[ ] This PR contains breaking changes that are documented in the description
[ ] This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
[ ] This PR impacts documentation, and it has been updated (or a ticket has been logged)
[ ] This PR's changes are covered by the automated tests
[ ] This PR collects user input/sensitive content into Datadog
[ ] This PR passes the integration tests (ask a Datadog member to run the tests)

Codecov Report

Merging #89 (bdfb945) into main (c88b4f4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   84.93%   84.95%   +0.01%
==========================================
  Files          13       13
  Lines         770      771       +1
==========================================
+ Hits          654      655       +1
  Misses         91       91
  Partials       25       25

Impacted Files
Coverage Δ

internal/trace/listener.go
59.01% <100.00%> (+0.68%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c88b4f4...bdfb945. Read the comment docs.


Error this afternoon (Could not pass event PlayerMoveEvent)

Build: Quests-3.3.2
Good afternoon everybody. I don't really know for the moment how the error happened but I'll tell you soon if I figure out. Here is the error: https://pastebin.com/pS6uEPHU

Use this build once available - http://ci.ac3-servers.eu/job/Quests/520/


Memory error in large datasets

Hello!
In your solution matrix of Jaccard distances is precomputed and takes up a lot of space in RAM. Are there ways to solve this problem? This question is relevant for large datasets.
Thanks!

Hi, maybe you can remove Jaccard distance and use Kmeans. Please refer to https://github.com/yxgeee/MMT/blob/057e1ea5d3054c9d7e5fa72c727298d8e4c5f668/examples/mmt_train_kmeans.py

ok, thank you. I will try this solution in the future


Physical flow specification page should not display inactive physical flows

waltz physical flow page currently displays inactive physical flows in associated flows section.

Or display as inactive...


The "npm run create" command creates an article, but it's not visible in Visual Studio Code

Description
When I use the "npm run create" command to create an article, it is not visible in the Visual Studio Code Explorer (the left sidebar with the table of contents). I tried refreshing and restarting VSC - nothing, I tried creating the same article again, and got the return message informing me that it already exists. When I ran the website in my local environment, I could see that it has indeed been created and is visible in the table of contents of the locally built documentation portal.
Steps to reproduce
Our docs repository: https://github.com/navipartner/docs

Use the terminal command "npm run create docs/np_pay/how-to/enable_tips/index.md".
The file is created successfully.

Look at the Explorer section (left sidebar) and it's nowhere to be found, so you can't open it to edit it.

I run the "npm run start" command to build the site locally, and the article is there, in the table of contents:

Expected result
The created article (docs/np_pay/how-to/enable_tips/index.md) should be visible in the Visual Studio file explorer in the left sidebar.
Actual result
The article cannot be seen, opened or otherwise interacted with from the Visual Studio Code explorer.
Environment
Paste the information here as shown by npm run info
This command returns an error for me. I hope the link to the repo on GitHub I provided above will be suficient.

I cannot reproduce your issue (with Visual Studio Code 1.95.3). It looks like something's off with your installation.

What if you hit Refresh Explorer?

Ah, you're using the browser editor?

Hmm, not really, but I'll give it a thought.
Maybe you could get help here: Stack Overflow


ng lint complains about rxjs operators being deprecated after migration to 6

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)
- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [x] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

node v8.11.1
npm v6.4.1
@angular-devkit/architect         0.7.5
@angular-devkit/build-angular     0.7.5
@angular-devkit/build-optimizer   0.7.5
@angular-devkit/build-webpack     0.7.5
@angular-devkit/core              0.7.5
@angular-devkit/schematics        0.7.5
@angular/cdk                      6.4.7
@angular/cli                      6.1.5
@angular/material                 6.4.7
@ngtools/webpack                  6.1.5
@schematics/angular               0.7.5
@schematics/update                0.7.5
rxjs                              6.3.1
typescript                        2.9.2
webpack                           4.9.2
Repro steps

Upgraded to angular 6
replaced deprecated API by new rxjs API with pipe operators
run ng lint
The log given by the failure

In log ng lint there are like 100+ warnings that we use deprecated mergeMap, combineLatest, switchMap etc.
Desired functionality

It should not show those warnings as Webstorm using same tslint.json file doesn't complain about it.
Mention any other details that might be useful

Webstorm code analysis has no issue with that and when going to source of used operator it actually points to new not deprecated signature of the operator)
I tried in newly created project, even copy pasted same code to it from our project something like
of({})
    .pipe(
      map(() => ''),
      withLatestFrom(of()),
      filter(() => true),
      switchMap(() => {
        return of('')
          .pipe(
            map(response => response || null),
            map(() => {
              if (![]) {
                return '';
              } else {
                return 'smth';
              }
            }),
            catchError(() => {
              return of('error');
            })
          );
      })
    );

Of course I had to simplify it a lot due to not having original services and sources, but flow is exactly like this and I think that's what matters. So in newly created project I couldn't reproduce it even this way, which is strange and seems to be rather project or migration related.
I also tried using tslint.json from new project which also didn't help.
Running tslint --project tsconfig.json -c tslint.json 'src/**/*.ts' only outputs few deprecated warnings, which are actually true and make sense.

Can you please share the import statements?

import { combineLatest, forkJoin, Observable, of as observableOf } from 'rxjs';
import { catchError, filter, map, mergeAll, switchMap, withLatestFrom } from 'rxjs/operators';

These are kind of imports we have.

I have tried to replicate this with the above provided code however I am not getting any lint errors, I am all only getting All files pass linting.
Can you setup a minimal repro please?
You can read here why this is needed. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.
This might be related to your directory structure so its really important to get an accurate repro to diagnose this.

@alan-agius4 I will do it next week, if that's fine. I'll try to make it reproducible.

I tried to create project where this issue is reproducible but unfortunately I didn't succeed. Creating new angular 6 project and passing there same rxjs/ngrx has no linting issues.
I tried to create angular 5 project and do the migration process on that again, because I suspect it has to do something with migration for sure. But when I run npm install @angular/cli on that it keeps installing 1.7 instead of 6.2. If I install latest manually ng update on that new project feels like hanging but maybe it is just so slow that I lose my patience(Issue#10622). So I didn't even manage to simulate the migration. If you guys don't have any clue what could be the root cause of the issue I think it makes sense to rather close this issue then. We'll just use tslint tool as workaround. Thankfully that works.

An interesting observation I have is that when I moved script tslint --project tsconfig.json -c tslint.json 'src/**/*.ts' to package.json and run it with npm then I again get crazy amount of warnings same as ng lint. Which gave me an idea that issue is in version of local tslint. For some reason it wasn't properly  updated automatically. So once I updated tslint in my package.json and installed newer version of tslint ng lint also started behaving properly!


AutomatedTestWidgetsFlutterBinding substantially slower to process animations than LiveTestWidgetsFlutterBinding

Steps to Reproduce

Given the following two files:

import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';

import 'scratch.dart';

void main() {
  group('Animation test', () {
    Widget _buildWidget() {
      return ScratchApp();
    }

    Widget _buildPage() {
      return MaterialApp(
        home: Material(
          child: MediaQuery(
            data: MediaQueryData(size: const Size(375, 1012)),
            child: _buildWidget(),
          ),
        ),
      );
    }

    testWidgets("Attempt to reproduce", (WidgetTester tester) async {
      var startTime = DateTime.now();
      var lastTimestamp = startTime;
      print("Start: $startTime");
      await tester.pumpWidget(_buildPage());
      await tester.pumpAndSettle();

      var latestTimestamp = DateTime.now();
      print("Elapsed: ${latestTimestamp.difference(lastTimestamp)}");
      lastTimestamp = latestTimestamp;

      await tester.tap(find.byKey(Key("expand_content")));
      await tester.pumpAndSettle();

      latestTimestamp = DateTime.now();
      print("Elapsed: ${latestTimestamp.difference(lastTimestamp)}");
      lastTimestamp = latestTimestamp;

      await tester.tap(find.byKey(Key("expand_content")));
      await tester.pumpAndSettle();

      latestTimestamp = DateTime.now();
      print("Elapsed: ${latestTimestamp.difference(lastTimestamp)}");
      lastTimestamp = latestTimestamp;

      await tester.tap(find.byKey(Key("expand_content")));
      await tester.pumpAndSettle();

      latestTimestamp = DateTime.now();
      print("Elapsed: ${latestTimestamp.difference(lastTimestamp)}");
      lastTimestamp = latestTimestamp;
    });
  });
}

import 'package:flutter/material.dart';

class ScratchApp extends StatefulWidget {
  @override
  State<StatefulWidget> createState() {
    return ScratchAppState();
  }
}

class ScratchAppState extends State<ScratchApp>
    with SingleTickerProviderStateMixin {
  bool expanded = false;

  void _toggleExpanded() {
    setState(() {
      expanded = !expanded;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Column(
      children: <Widget>[
        Container(
          constraints: BoxConstraints(maxHeight: 500),
          child: SingleChildScrollView(
            child: AnimatedSize(
              vsync: this,
              alignment: Alignment.topCenter,
              curve: Curves.easeInOut,
              duration: Duration(milliseconds: 350),
              child: _buildContent(),
            ),
          ),
        ),
      ],
    );
  }

  Widget _buildContent() {
    return Column(
      children: <Widget>[
        InkWell(
          key: Key("expand_content"),
          onTap: _toggleExpanded,
          child: Row(
            mainAxisAlignment: MainAxisAlignment.center,
            children: <Widget>[
              Row(
                children: <Widget>[
                  Text("Expand/Collapse"),
                ],
              )
            ],
          ),
        ),
        AnimatedCrossFade(
          duration: Duration(milliseconds: 500),
          crossFadeState:
              expanded ? CrossFadeState.showSecond : CrossFadeState.showFirst,
          firstChild: Container(),
          secondChild: _buildExpandedContent(),
        ),
      ],
    );
  }

  Widget _buildExpandedContent() {
    return Padding(
      padding: const EdgeInsets.symmetric(vertical: 8),
      child: Container(
        decoration: BoxDecoration(
          borderRadius: BorderRadius.all(Radius.circular(3)),
          border: Border.all(color: Colors.lightBlue),
        ),
        child: Padding(
          padding: const EdgeInsets.all(8.0),
          child: Column(
            children: <Widget>[
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
              SizedBox(height: 25),
              Text("text"),
            ],
          ),
        ),
      ),
    );
  }
}

Run the test in scratch_test.dart using flutter run, note the elapsed times logged by the test to the console.
Then run the test using flutter test and compare the elapsed times.

Results: When run with flutter test, an operation that took 0.8... seconds to perform now takes >6 seconds.
While this specific result is not too bad, the implications in larger test suites/applications is problematic. For example, running the same sort of evaluation on one of the tests that inspired this issue shows that a similar animation takes >32 seconds to elapsed using flutter test, whereas it takes 0.8 seconds using flutter run
The time taken for such animations to evaluate appears to scale relative to the overall height of the widget being animated.
$ flutter analyze
Analyzing icecrown...                                               No issues found! (ran in 2.5s)

[✓] Flutter (Channel stable, v1.9.1+hotfix.5, on Mac OS X 10.14.6
    18G1012, locale en-CA)
    • Flutter version 1.9.1+hotfix.5 at
      /Users/jm/.flutterio/flutter
    • Framework revision 1aedbb1835 (4 weeks ago), 2019-10-17
      08:37:27 -0700
    • Engine revision b863200c37
    • Dart version 2.5.0

[✓] Android toolchain - develop for Android devices (Android SDK
    version 28.0.3)
    • Android SDK at /Users/jm/Library/Android/sdk
    • Android NDK location not configured (optional; useful for
      native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.1, Build version 11A1027
    • CocoaPods version 1.6.1

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 41.1.2
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build
      1.8.0_202-release-1483-b49-5587405)

[✓] Connected device (1 available)
    • iPad Pro (9.7-inch) • 831BB050-0B84-4EAC-AFC7-B576B82228B0 •
      ios • com.apple.CoreSimulator.SimRuntime.iOS-13-1
      (simulator)

• No issues found!

I've been trying to figure out the reasons for this but so far failing; we're seeing widget tests take a long time (30 seconds) to execute.
It seems really counterintuitive that widget tests would take longer to execute than actually running the app 😃
Anyone know any workarounds to this?

This seems fixed on the latest master 1.22.0-10.0.pre.269.

flutter doctor -v
[√] Flutter (Channel master, 1.22.0-10.0.pre.269, on Microsoft Windows [Version 10.0.19041.508], locale en-US)
    • Flutter version 1.22.0-10.0.pre.269 at C:\Development\flutter_master
    • Framework revision 51fa704642 (2 days ago), 2020-09-19 11:27:04 -0700
    • Engine revision 4b8477d115
    • Dart version 2.10.0 (build 2.10.0-142.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at C:\Users\marku\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6626763\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.6.5)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.6.30320.27
    • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.0)
    • Android Studio at C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6626763
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] Connected device (6 available)
    • SM G950F (mobile)           • ce12171c51cc001c03 • android-arm64  • Android 9 (API 28)
    • sdk gphone x86 arm (mobile) • emulator-5554      • android-x86    • Android 11 (API 30) (emulator)
    • Windows (desktop)           • windows            • windows-x64    • Microsoft Windows [Version 10.0.19041.508]
    • Web Server (web)            • web-server         • web-javascript • Flutter Tools
    • Chrome (web)                • chrome             • web-javascript • Google Chrome 85.0.4183.102
    • Edge (web)                  • edge               • web-javascript • Microsoft Edge 85.0.564.51

• No issues found!

Logs
flutter run
I/flutter ( 2503): Start: 2020-09-21 10:04:14.192442
I/flutter ( 2503): Elapsed: 0:00:00.730603
I/flutter ( 2503): Elapsed: 0:00:00.152392
I/flutter ( 2503): Elapsed: 0:00:00.116005
I/flutter ( 2503): Elapsed: 0:00:00.119436
I/flutter ( 2503): 00:01 +1: All tests passed!

flutter test
00:05 +0: Animation test Attempt to reproduce
Start: 2020-09-21 10:01:59.885142
Elapsed: 0:00:00.344076
Elapsed: 0:00:00.812183
Elapsed: 0:00:00.101022
Elapsed: 0:00:00.692155
00:07 +1: All tests passed!

Closing this as probably fixed. Could everyone who still has this problem please file a new issue with a minimal reproducible code sample the exact description of the steps, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Auto-update hangs on installation, renders shortcuts invalid

VSCode Version: 1.25.1
OS Version: Windows 7

Steps to Reproduce:

When VS Code prompts you for an update, click on "Install update"
Update occurs, but when it's time to restart, the IDE hangs
Trying to relaunch via any of the shortcuts causes Windows to prompt the user to delete them because the targets no longer exist
I am able to relaunch VS Code by manually going into the Program Files subdirectory and clicking on the EXE file manually. From there I can re-pin the application and and create new shortcuts.

Does this issue occur when all extensions are disabled?: Not sure. It's difficult to test, but the extension updates do not cause any errors. Just the core product updates.

What do you mean by IDE hangs? Is there a crash?
Does this happen all the time, or was it a one time thing?


fix(slp timeout): Fixing timout for axios for slp endpoints

Fixes a typo that was preventing axios from timing out properly on slp endpoints.

Pull Request Test Coverage Report for Build 2750

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.993%

Totals

Change from base Build 2745:
0.0%

Covered Lines:
2337

Relevant Lines:
3348

💛  - Coveralls


[Clang importer] Import stub declarations with Swift 2 names to improve QoI

What's in this pull request?
When the Swift 2 and Swift 3 names of an imported API differ, create a stub declaration with the Swift 2 name that has an "unavailable" attribute pointing at the Swift 3 name. This provides much better diagnostics, which state the renaming and provide Fix-Its to update the code. Addresses most of rdar://problem/25309323

@swift-ci Please test and merge

The history here is a mess; closing this pull request to clean it up.


auto close after click window error

Hi
Problem: after click window or icon error.. the window close..

I want after click window error tries replay video .. how ?
I add this @Override in JCVideoPlayerStandard
@Override
public void onError(int what, int extra) {
super.onError(what, extra);
but same problem .. close window

Do you mean you click the error in fullscreen, the window will close.
I will try to test it then answer you.

yes ..
Ok .. I am waiting for you

hi .. done solve ?

do not worry


Add test for HCS datset

Fixes https://github.com/BioImageTools/ome-zarr-models-py/issues/73

there's a lot of off-spec stuff in that zarr hierarchy (basically all the anndata stuff), maybe we can remove it?

specifically, I think everything under tables is anndata-specific, can you confirm @jluethi ?

Yes, I can confirm that everything in the tables subfolder is Anndata related. It's all following the Fractal table specification, so out of scope for ome-zarr-py-models I'd say :)


Nevada's terrain almost completely flattened

i noticed the nevada being grass issue only was with Las Vegas and anywhere around it for some reason. i went outer parts and found out nevada is almost flat. Its canyons and everything are just colored spots made to "resemble" the canyons.

I'm not sure you will need to send a specific example. The Grand Canyon, a place very close to Nevada, generates fine.

Grand canyon generates fine but the place next to it, lake mead seems to be completely flattened including the lake itself.
 (one of the stuff next to the lake)
 (the lake itself i think)
As for most parts of nevada being grassy I think minecraft read one of its soil as being grass so it generated a grassland. Idk what soil data you're using but it could be nice to look into that. Maybe it should use some BoP idk.

Is this with advanced water on? If this is the middle of the lake, the depths of lakes is not accurate and the elevation is just the surface of the water.

The place next to it might just not be that steep on average. Also, small abrupt drops are often too small for the elevation data to pick up so theres not much to be done about that.

ill see what it looks like with advanced waters on. i assumed the spots were canyons

nothing changes with advanced waters except that the road next to lake mead is replaced with water


Logo design

Hi, I'm a logo designer, I saw your project and I can make a free logo for your project. So, what do you think?

Hi. Well sure that would be great, the current one is just a random pick really. I cannot promise to use it though before I've seen it though :-)

Hi again, I made a logo, if you like it I will send you all files to use it.

I've made some color variations of the logo, which color and logotype variation do you want?

Hi again, I made a logo. If you like it I'll send you all files to use it.

I've made some color variations of the logo, which color and logotype variation do you prefer?

Thanks, they look great. I think I will go with the purple to blue one. Is it possible to get also the files as svg? I would have to extract the magnifier glass alone also for the the favicon.

Sure, all files is here: https://drive.google.com/open?id=17_tK0stcuASwJVa-9uDAU7T1sdkL9Lts
Please LMK when you use it.

@tebriz159 how do you want to be mentioned in the app for the contribution? So far there were practically no contributions, so there is nothing setup yet


Can't pass custom renderer constructor to state

Follow props signature, we able to use a custom renderer, but it not make sense because we can't pass canvas reference, because canvas not exist when we create it.
https://github.com/pmndrs/react-ogl/blob/main/src/shared/utils.ts#L105
Need to allow use a functional argument of rendere that will return instance for allowing this:

Like this:
https://github.com/pmndrs/react-three-fiber/blob/0fd9337565e7ae264b539b0ef9be05c04f749b89/packages/fiber/src/web/index.tsx#L39

Fix published in v0.1.2.


Exposing WarpCTC to Tensorflow

Still WIP for now

let's do this from another branch. Sourcing external warp-ctc might be a problem afterall :(


Added nctalk nextcloud talk adapter

Automated adapter checker
ioBroker.nctalk

[ ] :heavy_exclamation_mark: [E518] "@alcalzone/release-script" is used, but ".releaseconfig.json" not found
[ ] :heavy_exclamation_mark: [E605] No actual year found in copyright. Please add "Copyright (c) 2023 Jochen Gerster<EMAIL_ADDRESS>at the end of README.md
[ ] :heavy_exclamation_mark: [E701] No actual year found in LICENSE. Please add "Copyright (c) 2023 Jochen Gerster<EMAIL_ADDRESS>at the start of LICENSE
[ ] :eyes: [W171] "common.title" is deprecated in io-package.json
[ ] :eyes: [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
[ ] :eyes: [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
[ ] :eyes: [W170] "common.keywords" should not contain "iobroker, adapter, smart home" io-package.json
[ ] :eyes: [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
[ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
[ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
[ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
[ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
[ ] :eyes: [W400] Cannot find "nctalk" in latest repository
[ ] :eyes: [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package

Add comment "RE-CHECK!" to start check anew

Hi
[E518] "@alcalzone/release-script" is used, but ".releaseconfig.json" not found
seems this came with a newer version of "@alcalzone/release-script" - what should I do now ? update to latest "@alcalzone/release-script"package ?
Anything special to take care of when updating or?
thanks
best regards
Jochen

RE-CHECK!

Automated adapter checker
ioBroker.nctalk

:thumbsup: No errors found

[ ] :eyes: [W171] "common.title" is deprecated in io-package.json
[ ] :eyes: [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
[ ] :eyes: [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
[ ] :eyes: [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
[ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
[ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
[ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
[ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
[ ] :eyes: [W202] Version of package.json (0.3.1) doesn't match latest version on NPM (0.3.0)
[ ] :eyes: [W400] Cannot find "nctalk" in latest repository
[ ] :eyes: [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package

Add comment "RE-CHECK!" to start check anew

RE-CHECK!

Automated adapter checker
ioBroker.nctalk

:thumbsup: No errors found

[ ] :eyes: [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
[ ] :eyes: [W202] Version of package.json (0.3.1) doesn't match latest version on NPM (0.3.0)
[ ] :eyes: [W400] Cannot find "nctalk" in latest repository
[ ] :eyes: [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package

Add comment "RE-CHECK!" to start check anew

RE-CHECK!

Automated adapter checker
ioBroker.nctalk

:thumbsup: No errors found

[ ] :eyes: [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
[ ] :eyes: [W400] Cannot find "nctalk" in latest repository

Add comment "RE-CHECK!" to start check anew

HI Martin,
thanks for checking :-)
On your last point - yes I was not sure about this point as well and about the prerequisite for "stable"...
For me the adapter runs "stable" :-D and it was also tested/used by several others (~20 if this number can be trusted) for approx 1 year and at the beginning quite some debugging was required but then there were no further problems reported so far...  here the forum entry https://forum.iobroker.net/topic/49298/neuer-adapter-nextcloud-talk-messenger
best regards
Jochen

RE-CHECK!

Automated adapter checker
ioBroker.nctalk

:thumbsup: No errors found

[ ] :eyes: [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
[ ] :eyes: [W400] Cannot find "nctalk" in latest repository

Add comment "RE-CHECK!" to start check anew

Please remove node 12 and 14 from test-and-release.yml and add n ode 18 and (optionally) add node 20 to testing matrix.
Node 14 is no longer supported and tests will fail since 22.5.2023.
Node 12 tests fail a longer time ago
In addition PLEASE REMOVE sources-dist-stable.json from this PR. Adapters MUST be some time available at lastest before they are allowed to be added to stable. So adding a new adapter to latest AND stable at the same time is inapproriate.
Thanks
McM1957

RE-CHECK!

Automated adapter checker
ioBroker.nctalk

:thumbsup: No errors found

[ ] :eyes: [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
[ ] :eyes: [W400] Cannot find "nctalk" in latest repository

Add comment "RE-CHECK!" to start check anew

Any news here?

Any news here?

Sorry to say still waiting for official review by @Apollon77 .

Ok 1. and 2nd is done
on the 3rd - is this the sequence how it should be?
if ack == false
then for example sent message to nextcloud talk
setstate ack to true?

onStateChange(id, state) {
    const as = id.split(".");
    const statename = as[as.length - 1];
    let obj = undefined;
    let fullpath = this.adapter.config.upload_path;

    switch (statename) {
        case "SendMessage":
            if (state.ack == false) {
                // ack==false are commands to be executed
                this.SendToGroup(state.val);
                this.adapter.setState(id, state.val, true);
            }
            break;

On the last point I'm not sure - Are you talking about the eventloop and the eventlooptrigger?
    _EventloopTrigger(event, timeout) {

        if (timeout) {
            setTimeout((function (event) {
                this.emit("Eventloop", event);
            }).bind(this), timeout, event);
        } else {
            this.emit("Eventloop", event);
        }
    }

State.ack:
This in the end depends on your logic. In many cases after a controlling action also new values come in and so they are set with ack=true in any case. if it is a state that just sends something out then yes you can also ack the value after successfull action is executed. Or you define it as "send only" state with read=false, then it is only ritable then ack= true is formally not needed
Eventloop:
When I understood the code right then once started tvia this event loop  (and other code places) always a timeout runs and data are updated any 30s ... in iobroker you need to be able to stup these timers to stop the adapter - especially relevant in compact mode.
So yes you shsould save the timeout you set there and allow it to be cleared on unload

thanks for the reply
On the eventloop - just to be sure you are talking about this timeout?
    _EventloopTrigger(event, timeout) {

        if (timeout) {
            **setTimeout((function (event) {**

actually this timeout is only used/called in case of an error case and this is if their is an error with the http REST API request to nextcloud talk server. There is a check (waitmsgongoing) that only one http request is pending at the same time.
Normally (none error case) the event loop takes care of the startup going to the different states of the state machine to gather all required information from the nextcloud talk server needed by this adapter
And then it only takes care of polling for new messages using an http request and the result of this http and initiate then a new one
https://nextcloud-talk.readthedocs.io/en/latest/chat/#receive-chat-messages-of-a-conversation
Or is your point is more that you need a graceful stop of the whole adapter/loop independent of the timeout call or the http request ?

I'm still stuck what exactly I should change - please advise..

Anyone who can help ?

Sorry
My fault. Will try to respond this week.

RE-CHECK!

First of all - THANK YOU for the time and effort you spend to maintain this adapter.
Sorry for the late reply. I did a complete rereview including special attention to the points appollon77 already noted.
Please see my feedback based on my personal oppinion. Please feel free to contact @Apollon77 if you cannot follow my suggestions or want to discuss some special aspects.

[ ] package.json should specifiy required nodejs version
Please consider adding an engines clause to package.json. Especially if you use adapter-core 3.x.x or newer nodegs 16 or newer must be reuested:
  "engines": {
  "node": ">= 16"
},

[ ] please verify that all dependencies are up to date
Some dependencies are outdated. Please update to current releases if no special reason to keep an older version exists.
i.e. adapter-core is outdated for sure.

[ ] on message handler seems to be unused
There seems to be no fucntional code within onMessage handler (https://github.com/jjqoie/ioBroker.nctalk/blob/3686e3ad961797ce65a5174d3262d66e97adf829/main.js#L239). If this is correct, please remove onMessage handler and remove '"messagebox": true,' from io-package.json.

[ ] onStateChange handler ignores ack flag
The adapter must honor the ack flag when processing onStateChange events. Whenever the onStateChange handler is called for an own state (a state owned by the processing instance of the adapter) it must ignore this event if the ack flags is set. Only stateChanges with ack==false are allowed to be processed normally. Exceptions might exist - please discuss if you fell a need for that.
When processing foreign states (states not created by this adapter)  processing most likely should only occure if the ack flag is true - but there might be exceptions.

[ ] creation of folders seems to be missing
Every folder (device, folder, ...) must be created explicitly. You may not create a state name.Sharefile.NetxCloudPath without creating a folder (?) ShareFile first.
https://github.com/jjqoie/ioBroker.nctalk/blob/3686e3ad961797ce65a5174d3262d66e97adf829/lib/iobtalk.js#L40

[ ] reevaluate state roles
Only the values specified here (https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/stateroles.md) may be used as state roles. Do not invent new names as this might disturb the functionalyity of other adapters or vis.
In addition the roles MUST match the read/write functionality. As an example a role value.* requires that the state is a readable state. Input states (write only) should have roles like level.*. Please read the description carefully. States with role 'button' should (must) have attribute 'common.read=false' set. A button ( "Taster" in german only triggers when you press but else has no state), so it should also be not readable. This is also like HomeMatic does it. A switch has clear states true or false and so can be read.
Please avoid using general roles (state, value) whnever a dedicated role exists.
Many of your states with role state look like text roles. Please review / adapt to rules linked above.

[ ] use not too long names for states
The text used here looks more like a description (which ia available too)
https://github.com/jjqoie/ioBroker.nctalk/blob/3686e3ad961797ce65a5174d3262d66e97adf829/lib/iobtalk.js#L43

[ ] avoid console.log
console.log should be avoided as it is only useable with a dubugger. Use adapter.log.debug or adapter.log.silly instead.
Note that adapter.log.* output is visible at debugger console too, so theres seems to be no need for console.log at all.

[ ] mionimize info logs to contain only really important info
I do not think thats its very importand for users to know every tme when a working directory is checkd to exist
https://github.com/jjqoie/ioBroker.nctalk/blob/3686e3ad961797ce65a5174d3262d66e97adf829/lib/webdavsupport.js#L27
Please check info logs and use i.e. debug or silly for if applicable.

[ ] why do you subscribe LastReceivedMessage?
Subscribing on states only written by your own adapter is normally uneccessary overhead. The handler does not do anything more than logging the change. So I suggest to remove the handling part and the subscription adn to move the logging near setState.

[ ] github dependabot support seems to be missing
It looks like you did not yet setup dependabot support; at least .github/dependaboit.yml is missing.
Please consider setting up dependabot support (and to ease life the workflow auto-merge.yml). Dependabot will ensure that your adapter uses the most recent versions of external packages and avoids problem due to outdted base libraries. Dependabit provides PRs at you repository to update the dependencies. Depending on you setting, especially on auto-merge.yml configuration no or only minor revisions will be outmatically merged into you main branch. All major revisions msiut (ans should) be reviewed by you.

[ ] nextcloud library and timeouts
Apollon77 already noted:
in fact this nctalk library has one big downside ... it never stops. The timeouts used in there are not tracked and can not be
stopped, soideally that should be enhanced because else this will create big issues in compact mode

NextCloud does not provide some clear stop/shutdown entry point (or you do not use it). So currently the adapter canot stop all (!) running timers or asynchronous operations in progress. This will cause very big problems in compact mode as in compact ode the adapter shares a process with other adapters. So when unloading this adapter the timers could possibly access adress space of other adapters.
If you cannot ensure / use a clean stopp/exit functionaliyt of nctalk I suggest to block compact ode for this adapter by setting compact:false at io-package.json.
to anser your Questsions
Would this be onUnload(callback) ??
Question if onUnload is called do you need an immediate reaction or how fast must the adapter been stopped?

Yes onOnload is called whenever a adapter is stopped regularly. Withon onAOnlad every executiong timer, intervall or other asynchronously running code must be stopped. This response should be as fast as possible, as far as I know the default is 500ms which could be extended in general altghough this should be avoided.
Normally adapter regsiter all timer / intvervals createwd and call clearTimer / Intervall during inOnload to abort running timers.
It's up to you to decide wether to implement a clean unload handling or to leave it "direty" and block compact mode. I would accept both.

Thanks for reading and evaluating this suggestions.
McM1957
Please add a comment when you have reviewed and fixed the suggestionsor at least commented the suggestions and you think the adapter is ready for a re-review!

Hello
concerning "avoid console.log"
Is there any simple approach to use the adapter logging (this.log.info) without the need to propagate the "log" instance to all submodules ? For example a global function or adapter global function?
thx
Jochen

As far as I know most dev propagate the 'this' (=adapter) info to all submodules during creating them.
But maybe you would get better feedback when aksing at our telegram channel (invite links at https://www.iobroker.dev).
Anyway I would like to state, that usage of console.log is NOT blocking for latest. So feel free to keep using it if you prefer. The major disadvantage is that console.log output is not (easily) retrievable from users while instrcuting them to set logging to debug or sille is an easy thing (at least most of the time :-) ).

reminder 31.12.2023

@jjqoie
Happy New Year !
How shall we continue?
Do you need any help?
Please let me/us know if you encounter any problem and which timefram you expect to fix the mentionend issues.
mcm1957
reminder 15.01.2024

Also happy new year
I have created a branch for this and created an issue to track the latest recent points...
https://github.com/jjqoie/ioBroker.nctalk/issues/12#issue-2061784329
https://github.com/jjqoie/ioBroker.nctalk/commits/2150%23issuecomment-1651871315/
On "why do you subscribe LastReceivedMessage?"
The idea is in case there is a burst of new messages - to implement a handshake to handle them message by message and not risk losing a messages - maybe this is not required if there is already a queuing mechanism in the object state instance ??
What what happen if I quickly update the object value without being acked?
On "github dependabot support seems to be missing"
If you have any reference / guide on your hand - would be helpful
on " nextcloud library and timeouts"
Currently adding shutdown functions - for any timeouts and https open connections
stupid question - how can I see if the adapter really was fully stopped?
br
jochen

Sorry fro the late reply.

On "why do you subscribe LastReceivedMessage?" The idea is in case there is a burst of new messages - to implement a handshake to handle them message by message and not risk losing a messages - maybe this is not required if there is already a queuing mechanism in the object state instance ?? What what happen if I quickly update the object value without being acked?

OK,
I do not really understand why subscribing to this state shoudl help avoiding or handling burst at other states. But as far as I know there is NO queuing at any states. You will always read the last value written to a state. If you need more datails please contact @Apollon77 or Foxriver76. In addtion such questsions would be discussed at out telegram channels at best. Invitelinks see https://www.iobroker.dev

On "github dependabot support seems to be missing" If you have any reference / guide on your hand - would be helpful

You have a PR for this

on " nextcloud library and timeouts" Currently adding shutdown functions - for any timeouts and https open connections stupid question - how can I see if the adapter really was fully stopped?

I do not know a way to determine "was fully stopped". And I do not really understand what you are meaning with this sattement. Whenever an adapter is stopped onUnload is called by js-controller. At this routine the adapter must stop all timers, interval timer, subprocesses etc. it has created. After returning from onUnload js-controlelr will terminate the adapter process if applicable or unload the mode (details depend on using copmpact mode or not).
So the requirement is that the adapter must stop whatever it startet.
And of couse the same is required fro all external libraries which should provide some cleanup / unload / terminate etc. entrypoint.
At non compact mode the adapter process will be terminated cleanung up most things anyway. But the user might opt to use compact mode. When using compact mode multiple adapters will share one process. When stopping an adapter tjs.controller unloads this adapters code. So if any timers etc. are still running theres a high risk the this process crashes (due to trying to execute already unloaded code) and so other adapters are effected.
So please ensure that you external library provides the possibility to cleanup everything. If this is not available a potenial option would be to block compact mode for this adapter.
Please let me/us know (by adding a comment) when all issues noted earlier are processed by you and a new review seesm to be appropiate.

How should we continuer?
Do you need any further help?
Please let me/us know (by adding a comment) when all issues noted earlier are processed by you and a new review seesm to be appropiate.
If there is no respnse until 28.2.2024 this PR might be closed.
reminder 15.2.2024

How should we continue?
Do you need any further help?
Please let me/us know (by adding a comment) when all issues noted earlier are processed by you and a new review seesm to be appropiate.
If there is no response until 28.2.2024 this PR might be closed.
reminder 22.2.2024

hi
still working on the "nextcloud library and timeouts" item, which takes a bit longer as I also want to take care of all active http requests also in the other states used during startup.
Could it be that using the "dev-server watch", that the adapter can't be stopped?
BR
Jochen

Thanks for feedback. As long you are working on the adapter everything is fine.
I do not really undersatnd you question. In general the dev-server should show the same behavior as the normal js-controller. Maybe you could try dev-server run which does not start the adapter and start the adapter afterwards using you ide (i.e. vs-code). But discussing dev-server is a little bit OT here. Please join our telegram groups (or discord) You find links at www.iobroker.dev. There should be devs to discuss the specific problem with you and help solvong it.
reminder 07.03.2024

Any news here?
Do you know any timeframe wh  to expect a new revier after your changes?
reminder 1.5.2024

Any news here?
Do you know any timeframe wh to expect a new review after your changes?
Please let us know whether you are still working at this adapter. Let us know if you need some help or simply more time.
If there is no reaction until 31.5.2024 we will consider closing this PR. (Of course you are welcome to open a new PR at any time.)
reminder 15.5.2024

Any news here?
Do you know any timeframe wh to expect a new review after your changes?
Please let us know whether you are still working at this adapter. Let us know if you need some help or simply more time.
If there is no reaction until 31.5.2024 we will consider closing this PR. (Of course you are welcome to open a new PR at any time.)
reminder 1.6.2024

As there was no reaction this PR has been closed.
Please feel free to open a new PR as soon as you think the adapter is ready for a new review


Add new dev environment

Blocked by this: https://gitlab.com/coiled/cloud/-/issues/3604 . I can see about creating the repo manually to unblock this


How to request a simulator as a webservice?

Hi,
I have successfully installed the project and import a simulator (as explained here: https://gitlab.com/pidila/sp-simulateurs-data/tree/master)
The simulator seems to works as entended, BUT, I would like to be able to request the simulator as a webservice.
So I try to look in the bundle config and find that there is a route defined for : /{simu}/api
Unfortunatelly when I try to request the route I get an exception :
"Error : API for this simulator is not implemented with code : 0"
When I start searching into the ApiController in order to figure out how I should process to configure an API for my simulator, but I'm a little lost.
Is it functionnal? Can you provide some help on that particular topic?

hi,
Suppose your simulator is called "mysimulator" and has three steps:
Step 1: The user enters the data requested, then clicks on the "next" button
Step 2:  The user enters the data requested, then clicks on the "calculate" button
Step 3: Display of the simulation results
The following lines must be added to the "EUREKA\G6KBundle\Resources\ config\parameters.yml" file
     aPI:
         mysimulator:
             Step: 2
             Action: calculate

Hi,
Thanks, much more clear now.


 Or docker it's used only to send/receive from/to server? And in this case how do I execute docker inside my code? Thank you

The judges don't help the teams figure this out beyond the provided documentation, which includes links to learning Docker. From your question, I don't think you understand what Docker is or why we use it in this repo. I recommend first learning what Docker is and how to use it, then you may answer your own question.
https://www.docker.com/why-docker
https://docs.docker.com/get-started/
To be more direct, you can extend the client container, manually add things into it, or not use the client container at all. You could use the repo code directly with our provided Pip integration. You don't need to use the client library either, and can make http+json requests directly.


Fixed building IPSec-MB 0.46 library error which is unable to get the source file

Due to the original url has changed to https://github.com/intel/intel-ipsec-mb/archive/$(version)

Erp, I should have disabled pull requests. You should instead look at https://gerrit.fd.io/


Windows

Thanks!

I guess we should add appveyor testing now?

Yeah, still not really ready, but these are simple. No reason to used namedtempfile, since you're in a temp directory already. on windows, the parent needs to close the file handle before the child can start reading it.

Whoops, sorry---I missed the bit where you said "still not ready".

Hopefully it's easy to submit a PR for the remaining bits when done.

No, this is fine. I mean the overall thing. This PR is fine.

Thanks, Robert.
—
Sent from Mailbox
On Wed, Aug 5, 2015 at 10:23 AM, Robert T. McGibbon
<EMAIL_ADDRESS>wrote:

No, this is fine. I mean the overall thing. This PR is fine.
Reply to this email directly or view it on GitHub:
https://github.com/choderalab/openmoltools/pull/149#issuecomment-127802500


Do not use the docstring of commented code for the next item

The empty line here is not considered and because of this, the return type of the above-commented function is considered for the bottom function.

/**
 * Returns the opacity value to use when rendering the `Minimap` text.
 *
 * @return {Number} the text opacity value
 * Unused (inlined)
 */
// getTextOpacity () { return this.textOpacity }

/**
 * Returns the default text color for an editor content.
 *
 * The color value is directly read from the `TextEditorView` computed styles.
 * @param {TextEditorElement} editorElement
 * @param {number} textOpacity
 * @return {string} a CSS color
 */
function getDefaultColor(editorElement, textOpacity) {
  const color = domStylesReader.retrieveStyleFromDom([".editor"], "color", editorElement, true)
  return transparentize(color, textOpacity)
}

Fix at #10 breaks file wide @typedef. We need to find a better way for detecting commented code.

Fix at #10 breaks file wide @typedef. We need to find a better way for detecting commented code.


DR16 Selection function

Hey Jo,
I tried cloning Ted's apogee ap2sf apogee branch to run the updated selection function for APOGEE dr16, but I seem to get the following error:
""

apo = apsel.apogeeCombinedSelect(year=7)
0%|                                                 | 0/89396 [00:00<?, ?it/s]Warning: no visit in combined spectrum found for data point b'apogee.apo25m.s.stars.N7789.2M00000068+5710233           '
b't9-5094-55874-263'
0

Traceback (most recent call last):
File "", line 1, in
File "/Users/qpasa/Desktop/apogee-halo/apogee/apogee/apogee/select/apogeeSelect.py", line 2169, in init
apo1sel = apogee1Select(year=self.apo1year, mjd=mjd, sample=sample, locations=ap1_locations, _justprocessobslog=_justprocessobslog)
File "/Users/qpasa/Desktop/apogee-halo/apogee/apogee/apogee/select/apogeeSelect.py", line 731, in init
self._load_spec_data(sample=sample, mjd=mjd)
File "/Users/qpasa/Desktop/apogee-halo/apogee/apogee/apogee/select/apogeeSelect.py", line 1664, in _load_spec_data
statIndx= self.determine_statistical(allStar, )
File "/Users/qpasa/Desktop/apogee-halo/apogee/apogee/apogee/select/apogeeSelect.py", line 1505, in determine_statistical
avisit= specdata['ALL_VISITS'][ii].split(',')[0].strip() #this is a visit ID
TypeError: a bytes-like object is required, not 'str'
""
Could it be that the file from which the selection function is reading has changed from a bytes to a string? it seems to me like a python2-python3 problem? I am running it on python3.
Cheers
Danny

Forwarding to @jmackereth...

Hi @DHortaD  - lets re-raise this over on my fork, and solve it over there.

actually.... I didn't realise you couldn't raise issues in forks. So when I find a solution, i'll post it here.

I believe this issue was a bug which was fixed in a commit that I hadn't yet pushed up (https://github.com/jobovy/apogee/commit/51b92092c106a40b0fbf777375b5fe042cddfa10). If you could pull the latest version and re-try, that would be great.


417 Update evm tx history API

https://github.com/Outblock/FRW-iOS/issues/417

@lmcmz this is ready for re-review

@Peppermint1020 This is on Testflight version 2.3.0 build 51


override languages in environment when running commands

Fix for https://github.com/chef-partners/redhat-subscription-manager-cookbook/issues/32

@jjasghar I fixed your requested changes. Please review.

Please sign your commit via the DCO. Company policy won’t let me merge this unless you do.

Signed.


fix: don't inspect REQUEST_FILENAME of uploads

Ignore PHP injections on file names during uploads
Remove duplicate rule

Fixes #38

@EsadCetiner I'd appreciate it if you would take a look at this PR.

I don't see which rule would cover the same thing as 9508173. Could you point me to it?


UAC prompt when installing application

It's ugly when you install a package using the command line and after that, a window prompt appears for a mouse click. Instead of this, something like sudo which ask for password before downloading the package will be beautiful and look consistent.
Yeah, you're right we can open the terminal as an administrator but when you working only on CLI it breaks the flow. It doesn't feel nice that you opened another terminal window just for installing a program.

In Windows, the closest thing to 'sudo' is Runas: https://docs.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2012-r2-and-2012/cc771525(v=ws.11)
But the only problem is that the command input is larger compared to just 'sudo winget install package', using runas you would have to do: 'runas /user:\administrator winget install package' (haven't tested that yet)

Could winget elevate itself and then install the packages?

Could winget elevate itself and then install the packages?

You can run the winget command from an elevated command prompt and won't see any UAC prompts when installing packages.

start the command prompt elevated using:
winkey, 'cmd', ctl-shift-enter'

Yeah, you're right we can open the terminal as an administrator but when you working only on CLI it breaks the flow. It doesn't feel nice that you opened another terminal window just for installing a program.

In Windows, the closest thing to 'sudo' is Runas: https://docs.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2012-r2-and-2012/cc771525(v=ws.11)
But the only problem is that the command input is larger compared to just 'sudo winget install package', using runas you would have to do: 'runas /user:\administrator winget install package' (haven't tested that yet)

This can do the work if implemented with windows 10 and winget. Never thought MSFT already had something similar to sudo.

start the command prompt elevated using:
winkey, 'cmd', ctl-shift-enter'

For some reason I am getting UAC prompts despite doing this. Any ideas?

Opening a separate elevated prompt not only breaks the user workflow, but also introduces other follow-up steps, too. The user potentially needs to refresh the environment in the other terminal instance, or even destroy it and start over, depending on the updates made.

start the command prompt elevated using:
winkey, 'cmd', ctl-shift-enter'

For some reason I am getting UAC prompts despite doing this. Any ideas?
Edit: Nevermind, fixed it. Some weird issue with SmartScreen.

I'm having the same issue, how did you fix it?

start the command prompt elevated using:
winkey, 'cmd', ctl-shift-enter'

For some reason I am getting UAC prompts despite doing this. Any ideas?
Edit: Nevermind, fixed it. Some weird issue with SmartScreen.

I'm having the same issue, how did you fix it?

iirc all I did was change the local group policy via gpedit.msc:
Local Computer Policy -> Computer Configuration -> Administrative Templates -> Windows Components -> Windows Defender SmartScreen -> Explorer -> Configure Windows Defender SmartScreen
Either enable and set to warn, or disable.

I solved it for myself through winget itself using gsudo:
winget install gerardog.gsudo
gsudo winget upgrade --all

When it is run from a normal (non admin) user, it will only ask for privileges escalation once (similar to how a normal sudo would work)

gsudo winget upgrade --all

gsudo is amazing, it even comes with an sudo alias so you can do sudo winget upgrade --all

I've been going through the backlog checking on older issues. This one seems to be resolved with the release of sudo on Windows.