A fix for Jupyter environment variable issue

fixes the Jupyter environment variable issues mentioned in issue #134
fixes format/lint issues in some unrelated files (from make format/lint)

@hwchase17 added your comments.

[x] make format
[x] make lint
[x] make tests
[x] make integration_tests


The VSC extension has very annoying problems

Sometimes it gets to the point where it opens whenever i try to write code and asks me what i want to run.
It sometimes automatically opens that terminal when i try to write code in my scene class.

Hi,
Do you have the runOnSave setting enabled? I suspect something related to automatic running is happening.

@Rickaym I have autosave on, but how do i disable runOnSave?
I think we found the problem

Nevermind i kinda got it

Ah, what was the issue?


fix: add resource icon

Hey, I just made a Pull Request!
Add resource default icon, looking like

Reused the work icon as this is the default one in all Backstage demos, as seen here

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Hmm, I wonder if the StorageIcon might be a better fit for default resources?

Agree that this icon would be nicer but currently we use the work icon to represent resources by default.
Should we change this overall?

Indeed it's the work icon at this point, we can change it consistently later right if we want to @benjdlambert?

Oops, misclick

Yeah - OK, let's revisit.

If you like I can tackle this right away in a new PR.
What would be the icon you like?
I suggest database or storage.


teams: fix absolute path usages

Motivation for this change
There are some references to absolute paths in the Teams application code:

/usr/share/pixmaps - The application icon.
/usr/bin/xdg-mime - Uses absolute path to invoke.
/usr/bin/teams - Uses absolute path in the autostart file if configured to start automatically at login.

Though the paths are hardcoded they can be easily changed within the application’s main JavaScript code bundle and so we’ll do just that.
This should at least fix auto-start not working, even when enabled.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I've tested Teams with this change and it works well. I don't use features such as autostart or desktop environment that shows icons, so I cannot really test whether the changes actually work :-)

Result of nixpkgs-review pr 128208 run on x86_64-linux 1

1 package built:

teams


Code request

can I ask for a copy of demo source code in the video folder?

What do you mean under "a copy of demo source code"?
The code of the algorithm is in repo and its publically available... Or are you looking for code that can visualize the resulting log-files?

Thanks a lot. It's good enough for me.


zh-translation: /intro/arch_overview/upstream/connection_pooling.rst

ref: https://github.com/cloudnativeto/envoy/issues/54

/LGTM


Retention Period

How can one manage the desired retention period? let's assume I am only interested in keeping the trace data only for 14 days or say 30 days and then the data should be deleted from S3 .. how can we manage that?

This would be an interesting feature. Internally we leverage on loki (boltdb-shipper) which in turn leverages on cortex so to interface with s3.
We did work on the "compactor" - which is what you want but there still needs some work on this and we're still working out a new release.

@sherifkayad I've released v1.2.1 (sorry i mistakenly set the packages/docker to private and should be public), with a more complete implementation of the compactor.
More info on configuring retention is here.


Why is the error- "'module' object is not callable"?

I am using Python 2.7.13 (64 bit) in windows 7 and I have successfully installed gdal, rasterio (following https://mapbox.github.io/rasterio/installation.html) and gribdoctor (using pip). So, whenever I am using gribdoctor smoosh -dev -uw raw.grib2 unwrap.tif command, I am getting the
error- "with rasterio.drivers(): TypeError: 'module' object is not callable." How can I fix this problem so that I can get converted output? Please note that raw.grib2 is the input GRIB file and unwrap.tif will be the output file.

:wave: @abu034004
https://github.com/mapbox/grib-doctor is not up-to-date with latest raster version.
rasterio.drivers() has been replaced by rasterio.env() since version 1.0a1.
Please feel free to fork and submit a PR if you want to help us, that will be really appreciated
cc @dnomadb


Current release version doesn't work

The current release of the module, along with missing the "lang" folder entirely, doesn't create the button at the top of journal entries. However, the current Main version of the module seems to work perfectly. Please update the release version!
Also, thanks so much for making this! It's gonna be a huge help with collaborative note taking for the sessions I play in moving forward!

I'll try to fix that tomorrow, i'll also add the new "update all" functionality at the same time ! ;)

Hey, I've just fixed the workflow issue that didn't zip the module correctly (it's the first module that i'm publishing, so i'm still learning how to do things...).
I've made a new release that works now and added an "update all" button on the journal page that searches all journals and updates them without opening each one.
Hope this module will help you !
If you have any ideas to improve the module, just tell me !
Have a nice day ! ;)


Add example to log

Just landed on a repo that used this and the default log isn't super helpful to understand what is needed.
Instead of:
INVALID COMMIT MSG: does not match "<type>(<scope>): <subject>" !

An example would commit would be helpful:
INVALID COMMIT MSG: Your commit message must follow the pattern "<type>(<scope>): <subject>".
                                         A valid commit message should look like: "test-fix(my-package): I fixed XYZ"

Hello Matt,
I'm currently in the process of deprecating this package and forwarding people over to commitlint. Getting things in place for the transition now.
Do you feel this is somewhat-important to be fixed here? Could we focus this kind of feedback over to commitlint instead to get that library's end user experience improved for the longer haul?
Thank you.

Totally makes sense if that's the case, will nudge Firebase to move over ;)

Thanks Matt. I completely see your concern here and I myself would like to see this kind of output for end users. Not everyone knows what the structure means or stands for. I'm simply considering imminent deprecation with improving the recommended library for the better in the same swoop.
It would be a good bit of work to make sure all the tests are updated properly and that the added output is only in place when needed (as well as properly formatted so it isn't one huge line.)
Thanks for understanding!


Error when using this awesome module in Electron

Hi,
When I use this module in pure node, everything is fine.
However, when I load it  in an Electron app, the app crashes when hitting reg.getValue
This is how I'm using it:
function getOutlookVersionPresent(): void {
  console.info("getOutlookVersionPresent - IN");
  try {
    const key = reg.openKey(
      reg.HKLM,
      "SOFTWARE\\Classes\\Outlook.Application\\CurVer",
      reg.Access.READ
    );
    console.warn("Something goes wrong here (In Electron)");
    const version = reg.getValue(key, "", ""); // default value
    console.info(`getOutlookVersionPresent - version:[${version}]`);
    reg.closeKey(key);
  } catch (e) {
    console.error("getOutlookVersionPresent - failure", e);
  }
}

The app crashes and this error message is printed:
#
# Fatal error in , line 0
# ignored
#
#
#
#FailureMessage Object: 00F7E16Cnpm ERR! code ELIFECYCLE

This is my repository.
To reproduce this issue, you just have to fire these commands:
$ npm install
$ npm start

Electron version (Windows ofc): 8.0.3 (tried both x86 & x64)
native-reg version: 0.3.3
I also tried to not use prebuilds and build the package from source but that didn't work either.
In pure node, this works perfectly.
What am I doing wrong?
Thanks in advance!

Thanks for the report!
TL;DR: Use reg.queryValue(key, "") instead, this seems to be specific to using getValue() to get the default value.
This is a bit confusing: I can reproduce it, but in both electron and node.
When running in node, I get a stack complaining about some internal validation (related to WASM!?), so I'm currently suspecting that the V8 runtime in electron is newer than the node version you are testing with, and it's not electron specific. I'll look into it.

Should be fixed in new 0.3.4

TL;DR: Use reg.queryValue(key, "") instead, this seems to be specific to using getValue() to get the default value.
This is a bit confusing: I can reproduce it, but in both electron and node.
When running in node, I get a stack complaining about some internal validation (related to WASM!?), so I'm currently suspecting that the V8 runtime in electron is newer than the node version you are testing with, and it's not electron specific. I'll look into it.

You're right I'm using node -v 12.0.5 where Electron 8 uses node -v 12.13.0.
reg.queryValue works perfectly. Thanks.

Have you tried with the new publish, too?

Yes and this issue is resolved. Thanks.


WIP: Enhance basis

Codecov Report
Patch and project coverage have no change.

Comparison is base (c46f7ed) 100.00% compared to head (08d267c) 100.00%.

:exclamation: Current head 08d267c differs from pull request most recent head a890065. Consider uploading reports for the commit a890065 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #2   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           20        20
=========================================
  Hits            20        20

Flag
Coverage Δ

unittests
100.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Prepare repository for Tenzir v4.12.0

This commit was created with /scripts/prepare-release.
Here is a high-level summary of the changes:

Updated /version.json to v4.12.0.
Generated a new entry in the docs version selector list.
Removed the docs for the previous release candidate.
Moved all changelog entries from /changelog/next to /changelog/v4.12.0.
Updated the python bindings version in /python/pyproject.toml to v4.12.0.

Maybe also ditch the docs for v4.9?

That's already part of this PR.


Possbile texture replacement

Since enemy and map data has been succefully eported and done. I guess this a formal request if there is a possibility  for texture replacement for graphical mods. Sorta like the same as TpSheets implementation on FFIX
the current workflow for graphical mods now involves some tedious work and requires editing source files.

[x] UnityEngine.Sprite
[ ] UnityEngine.Texture2D
[ ] UnityEngine.U2D.SpriteAtlas

First try. I lose transparency, and sprites blur.

there is white matte out side the sprite . mostly likely caused by photoshop

Just for reference this is how modders in VG does it at this time
https://steamcommunity.com/sharedfiles/filedetails/?id=2561708531

tha looks great

:D

hahahah

FF1_v2021.08.06_(Alpha).zip
Alpha.

imma test it now

imma test it now

Enable ImportTextures in config. It's disabled by default.

yup i did. it seems i cant find the button and keyboard fiiles

it does export successfully

Chiming in on this since I started looking into UI textures for other reasons. The actual main UI textures (UI_Common_WindowFrame02/UI_Common_WindowFrame03/UI_Common_WindowFrame04) are not actually referenced in the Addressable Assets (AssetsPath.json), thus Memoria in its current state is unable to export or import them.

Some further information: it seems the approach currently being used to load textures (and assets in general really) is a bit limited, as there are assets that are present in AssetsPath.json that never get called into ResourceManager.completeAssetDic when they are being used (like the cursor, UI_Common_Cursor01). So I figure the best approach would be to take a higher level approach, such as hooking the direct calling of asset bundles or something similar.

Some further information: it seems the approach currently being used to load textures (and assets in general really) is a bit limited, as there are assets that are present in AssetsPath.json that never get called into ResourceManager.completeAssetDic when they are being used (like the cursor, UI_Common_Cursor01). So I figure the best approach would be to take a higher level approach, such as hooking the direct calling of asset bundles or something similar.

Do you have any thoughts on which API we can hook?
As far as I know, all MonoBehaviour deserialization mechanisms go through a low-level API and don't use C# libraries at all.

In regards to the assets not being present in ResourceManager.completeAssetDic, a majority of those files are required files for prefabs that are registered into completeAssetDic. I suppose you could look into hooking AddressableAssetWrapper, although hooking generic functions are a pain and a half (couldn't get them working personally). I know some repos like XUnity hook the asset bundle loading directly.

nice

The problem is that the list of resources lists both atlases and regular sprites.
That is, there is an atlas:
Skip MO_FF2_N001_C00
WalkB_00(Clone)
WalkB_01(Clone)
WalkL_00(Clone)
WalkL_01(Clone)
And there are individual sprites:
WalkB_00
WalkB_01
WalkL_00
WalkL_01
We need to think about how to combine them so as not to create duplicates when exporting / importing.

FF2: Only 6 sprites without atlases.
Default_00
Default_00
Default_00
TitleLogoImage_ZH-CH
TitleLogoImage_EN
TitleLogoImage

FF2: Only 6 sprites without atlases.
Default_00
Default_00
Default_00
TitleLogoImage_ZH-CH
TitleLogoImage_EN
TitleLogoImage

Something went wrong while exporting:
Actual: WalkL_00(Clone)
Rect: (x:0.00, y:0.00, width:16.00, height:16.00)
textureRect: (x:0.00, y:0.00, width:0.00, height:0.00)
pivot: (8.0, 0.0)
border: (0.0, 0.0, 0.0, 0.0)
bounds: Center: (0.0, 8.0, 0.0), Extents: (8.0, 8.0, 0.1)
vertices: (-8.0, 16.0)|(8.0, 16.0)|(-8.0, 0.0)|(8.0, 0.0)
triangles: 0|1|2|2|1|3
Exported: WalkL_00(Clone)
Rect: (x:0.00, y:0.00, width:0.00, height:0.00)
textureRect: (x:0.00, y:0.00, width:0.00, height:0.00)
pivot: (NaN, NaN)
border: (0.0, 0.0, 0.0, 0.0)
bounds: Center: (NaN, NaN, 0.0), Extents: (-Infinity, -Infinity, 0.1)
vertices: (NaN, NaN)|(NaN, NaN)|(NaN, NaN)|(NaN, NaN)
triangles: 0|1|2|2|1|3
It looks like the sprite is not initialized at all...

The problem is that neither the sprites from the atlas, nor the individual sprites nearby have information about the position on the texture. O.o
Other errors are the result of incorrect scaling.
Rect: (x:0.00, y:0.00, width:16.00, height:16.00)
textureRect: (x:0.00, y:0.00, width:0.00, height:0.00)

I had the idea that these are separate textures, but no. they all look at the same atlas, but for some reason do not tell about their coordinates. :(
Apparently, we have to look for a fragment on the texture pixel by pixel. х__х
[Info   :Memoria IL2CPP] WalkL_00(Clone); Texture: UnityEngine.Texture2D, TextureSize: 128x64

Fixed!
sprite.textureRect => (x:0.00, y:0.00, width:0.00, height:0.00)
sprite.GetTextureRect() => (x:20.00, y:0.00, width:16.00, height:16.00)

-_-

I did it!

https://github.com/Albeoris/Memoria.FFPR/commit/b94a6d6e195508e8d14e30ec41b836707ba73f01
https://github.com/Albeoris/Memoria.FFPR/releases/tag/v2022.01.24

some assets require a bilinear filter like the burtons


CMS: Edit page visual update

Finalize draft/publish toggle position:
consider position which is more visible so that you can see at first glance if the content is published or not
A normal toggle is probably not very clear here, so either make it a text toggle or another solution.

Up for discussion

@belljohan3 there is no branch linked to this issue, but it is in review. I could also not find a PR for the issue.

Hey @ivanslabbert !
It is now fixed. You can check now

Hi @ivanslabbert !
The description you had in this issue has been done here in this PR #228.
This PR contains only draft/published toogle button changes.

As discussed in the standup, we merged this and will take a look at the translation/language switcher in the sidebar in a followup ticket.


gRPC requires HTTP/2

After following the step 5. Start the Flow emulator
I get the running results of gRPC and HTTP on following ports 3569, 8080.
But when I try to hit the http url I get following error gRPC requires HTTP/2

@AnikIslam1 How are you 'hitting' the URL ?

Flow emulator server provide a local IP, there I saw the gRPC requires

If you're creating requests manually using something like curl make sure you're including Content-Type: application/grpc-web+proto header?

Closing because not reproducable.

Sorry for late but I get that and its work thank you

I'm facing the same issue... I've followed all the steps in the documentation, i'm running the emulator chain and my project is on a vps, when I reach my server on chrome  I get the error on ports 3569, 8080
other ports:
3001 display kitty logo with sign in and signup button (not working)
3000 print "not found"
8701 display  account info
5432 page not working "the page is not sanding any data"


fixed an issue with recursive inclusion tags on Django 1.8

Hi,
today at the Pycon.it together with @yakky we've found an issue with the show_menu template tag of django-cms on Django 1.8. I don't fully understand this patch, to be honest, but it seems to solve the issue.
Tried on Django 1.6, 1.7, 1.8.
/cc @nostalgiaz

Thanks @vad will check this on django CMS.

@yakky news?

@nostalgiaz LGTM
@ojii could you consider merging this?

\o/ thanks @ojii !

released as 0.6.2

Thanks for your support @ojii


Advancing to Other Fields with the Next Keyboard Button Doesn't Work

Great work on this!
Just one issue I've found. The Readme states:
"It also automatically hooks up 'Next' buttons on the keyboard to switch through the text fields."
I added this to a UIScrollView that has fields in it, and I haven't been able to get this part to work. The scrollView adjustments with the keyboard work fine, but hitting Next on the fields doesn't do anything.
Thanks!

This is quite simple to implement manually with a combination of becomeFirstResponder() (on all but the last field) and resignFirstResponder() (on the last field).  For instance (longhand swift):
func textFieldShouldReturn(_ textField: UITextField) -> Bool {
    switch textField {
    case self.textField1:
        self.textField2.becomeFirstResponder()
    case self.textField2:
        self.textField3.becomeFirstResponder()
    case self.textField3:
        self.textField2.resignFirstResponder()
    }
}

For larger numbers of controls a more scalable solution - an array of controls? - is probably desirable.  In the above I'd modify the Return button manually but again, code could achieve the same.  It might be worth pointing out the delegate-proviso on the Readme.


Update build and test instructions

This patch updates the build and test instructions and also corrects
the minimal level of Golang required.

This change is

@alonm Thanks!
@shay-berman Any feedback on this patch set?

@jwcroppe thanks for this PR
Since we already update the contribution md file with more details as part of v1.1, this PR is less relevant. So I am closing it.
Note: later on we plan to add more details inside such as how to run unit tests in the docker image it self.


Command cannot be registered correctly.

When defining plugin code as a new assembly instead of directly placing it in the project code, commands cannot be registered correctly because the plugin uses Assembly.GetExecutingAssembly to get the assembly.

thank you for your feedback, this situation havn't be considered, I will fix it soon


Give users the freedom to set the sensor update interval per sensor basis

Currently the sensors have update interval hardcoded. This is required to be abstracted out such that the users can set them according to their own requirement.

#51 fixes this.


Adapter does not visible

Hi, I try to implement your gradle libs to me project, but i have a little issue, SwipeFlingAdapterView does not visible in me view. I created custom BaseAdapter and set up it
swipeFlingAdapterView.setAdapter(adapter);
but nothing to show in layout except button

This is still an issue. I just created a very simple custom adapter and it was just blank when I ran it.

Hello Dilor.
In first place thank you for you effort .
My question is when I want to swipe Images instead of text with custom BaseAdapter .Nothing is working for me ,it is giving null pointer exception,please help to let me whether I can set Custom Adapter or not .


Rule interface-name: Change the default value

Since the introduction of the 'never-prefix' option here (https://github.com/palantir/tslint/issues/512) it's seems to be agreed by everyone that the I prefix is not a good practice for TS (https://github.com/palantir/tslint/issues/1520)
The rule will be removed from tslint:recommended (https://github.com/palantir/tslint/pull/4312) but is still active in tslint:all
What about simply change the default value from 'always-prefix' to 'never-prefix' ?

it's seems to be agreed by everyone that the I prefix is not a good practice for TS (#1520)

Alas, not so ☹. The option was added because some folks and projects prefer it, but there isn't a single agreed-upon good practice.
Since #4312 already exists and this request is a subset of #4305, closing this issue as duplicate.


Autocomplete

This pull requests implements autocomplete in YagCommand for slash command arguments.
It also implements autocomplete in rolemenu create and cah create as examples.
Disclaimer: I have no idea what I'm doing, this works because it was added to the middleware that hooks into every command. There's probably a proper way to do this with another function in Cmd, but I could not wrap my head around doing that properly without setting up another middleware thing.
Very open to feedback, but this is at least a working prototype

Looks nice, I personally sorted CAH-pack choices alphabetically - matter of taste, also these debug fmt.Prints rolemenu's Autocomplete function has are not necessary : )

I did as well, don't think I've pushed those changes yet though - been debugging because I realized I didn't actually put any comparisons on CAH autocomplete, so it's just showing all the results, all the time.
I did notice the debugs when I was looking back through and removed those as well lol, that change will be soon™ as well
I'm trying to decide on the best way to set up multi-pack since autocomplete is limited to 100 characters, I'll push what I have soonish for help.

It might be worth filtering autocomplete options by string similarity to the input (using lib/jarowinkler), WDYT? Some other comments below.

I've been starting on some manual comparison, and I'm trying to set it up so it returns something like pack1 pack2 (packs matching current search) to support multiple packs, but if a lib exists probably is better to use that

At this point, would it be better to drop the CAH changes, merge this PR with just the middleware autocomplete implementation and rolecommand changes, and create a new PR for CAH autocomplete?

I don't even understand what it is auto-completing...
This time I am using YAGPDB code and your PR, does not "complete" or search for redbox cah-pack.

I don't even understand what it is auto-completing...
This time I am using YAGPDB code and your PR, does not "complete" or search for redbox cah-pack.

@mrbentarikau yeah, I initially uh...forgot to actually implement any kind of pattern matching in CAH, try pulling? Newest push should include that, it just gets a little janky after 100 characters
As for rolemenu, that works because I stuck the search in the DBQuery, and I agree that it shouldn't be requesting on every keypress, just not sure how best to cache the data.

yup, tried the code directly from your repo... at least now I see how it's supposed to work...

The use case for searching is more for when you have more than 25 and you need to narrow it down more.
I think I'm going to make CAH its own PR though, since I'd like to get at least the basis merged so others can start implementing it in more commands if they want.


Publish<EMAIL_ADDRESS>

Just adding the latest version of a module already published to the BCR. The changes in the presubmit.yml simply test a new target and set the Bazel version which didn't used to be required by bcr_validation.py.

@JasonSteving99 checks failed.

@Wyverald Do you know if these errors:
Unable to find package for @[unknown repo 'aspect_rules_js' requested from @claro-lang~0.1.500]//js:defs.bzl: The repository '@[unknown repo 'aspect_rules_js' requested from @claro-lang~0.1.500]' could not be resolved: No repository visible as '@aspect_rules_js' from repository<EMAIL_ADDRESS>
are related to my MODULE.bazel marking these modules as dev dependencies?

could be -- if you're defining the rules_js targets in the same package as your prod targets, you can't mark rules_js as a dev dependency.


create_protostar_project fixture

added create_protostar_project
refactored protostar format integration tests

added deploy command to ProtostarFixture and used it in tests/integration/deploying

To my eyes, usage of this fixture looks like still invocations of protostar and personally I would drop the project word from the name, i.e. replace protostar_fixture with this. Is something blocking such move?

conflict with the protostar fixture (which I'll replace in this PR)
ProtostarFixture depends on project root path which binds the instance of protostar to project. At the other hand, the ProtostarCLI is also bound to a project after instantiation, so I'll drop the project word to be consistent

btw i just had a thought about create_protostar_project - is there a case where we don't actually create the project? (don't call the function). Each time we want the cleanup logic, so having it as a context manager is kind of weird

btw i just had a thought about create_protostar_project - is there a case where we don't actually create the project? (don't call the function). Each time we want the cleanup logic, so having it as a context manager is kind of weird

There's no such case. However, we need to control project scope (function/module). I could add and use two fixtures protostar_project: ProtostarFixture and protostar_project_module: ProtostarFixture.
@mkaput @Arcticae WDYT?

btw i just had a thought about create_protostar_project - is there a case where we don't actually create the project? (don't call the function). Each time we want the cleanup logic, so having it as a context manager is kind of weird

There's no such case. However, we need to control project scope (function/module). I could add and use two fixtures protostar_project: ProtostarFixture and protostar_project_module: ProtostarFixture.
@mkaput @Arcticae WDYT?

I don't like the fact that some tests will use one name while others another.

I don't like the fact that some tests will use one name while others another.

So we have to use factory fixture (create_protostar_project) as it is now, similarly to tmp_path_factory.
The question is where to put the cleanup code. In the fixture or in the contextmanager. IMO create_protostar_project creates mess (changing cwd) so it should be responsible for cleaning this up.

Yeah, at this point I also lean towards using context managers here.


Fix clippy warnings in tests

I get these clippy warnings when using nightly rust. I don't see a nice way of handling this in the macro without just allowing it, doesn't seem to be a huge deal.
https://rust-lang.github.io/rust-clippy/master/index.html#/redundant_closure

With which version do the warnings show up? I tried with clippy 0.1.76 (49b3924b 2023-11-27) but don't get any.


About Datasets

Hello, I noticed that in your code, the training and testing sets are placed in the same folder. So, during testing, a portion of the images are randomly selected for segmentation testing? Or will the last 100 images be used for testing? If you could reply, I would greatly appreciate it

Dear @M0ck4ry,
Thank you for contacting us. In the datasets directory, we have outlined how the data is split for each dataset.
For example, in the case of the PH2 dataset, the code specifies the split as follows:

The first 80 images are used for training.
The next 20 images are used for validation.
The subsequent 100 images are used for testing.

This means the dataset split is not done randomly; it follows a predefined order as mentioned above.
If you have any further questions or need additional clarification, please feel free to ask.
Sincerely,
Yousef Sadegheih

Thank you for your reply. Yes, I noticed what you said. But I used 10 sample images for testing, but the final segmentation corresponding to the original image is different from the 10 sample images I found. What is the reason for this? If I could receive your reply, I would greatly appreciate it

Dear @bravo-hq ,
Thank you for your reply. Yes, I noticed what you said. But I used 10 sample images for testing, the final segmentation corresponding to the original image is different from the 10 sample images I found. What is the reason for this? If I could receive your reply, I would greatly appreciate it

Dear @M0ck4ry,
Could you please provide more details about the dataset you are working on and the specific changes you have made? This information will help us assist you more effectively. It's important to ensure that the pairs of images and labels remain together and are not mismatched.
Sincerely,
Yousef Sadegheih

Dear @bravo-hq
Thank you for your reply again. I tried to train with 80 images, validate with 10 images, and test with 9 images (these 99 images are located in a separate folder). It was found that the 9 images tested were completely different from the last 9 images in the previous dataset.Here are some screenshots and images of the files
The first image is the log section, and the second image is the generated result. I found that these 9 test images are completely different from the last 9 of the 99 images I set (i.e. the test set). Normally, im.png and gt.png should be identical to the previous pictures. But the result is not like that. I would greatly appreciate it if you could reply
![Uploading {__MLVXEU]SUKR(7HLNZYG3.png…]()
![Uploading 3XW52]I0LQ_A)238SH7`GHI.png…]()

Dear @bravo-hq
Thank you for your reply again. I tried to train with 80 images, validate with 10 images, and test with 9 images (these 99 images are located in a separate folder). It was found that the 9 images tested were completely different from the last 9 images in the previous dataset.Here are some screenshots and images of the files
The first image is the log section, and the second image is the generated result. I found that these 9 test images are completely different from the last 9 of the 99 images I set (i.e. the test set). Normally, im.png and gt.png should be identical to the previous pictures. But the result is not like that. I would greatly appreciate it if you could reply

Does ISIC2016

dataset work on your code? Because ISIC2018 is too large and I cannot successfully download it.

ISIC2016 数据集适用于您的代码吗？因为 ISIC2018 太大，我无法成功下载。

Hello, ISIC2016 is applicable; I ran his code and the results are almost identical to what is shown for ISIC2018 dataset in the  paper.

Thank you for your letter. I am only using the ISIC2018 dataset. The results obtained are similar to the paper, but the segmented images are not the sample images in the test set. I am not sure if it was a problem set by myself.
Message ID: @.***>


when new job includes cached entries risk_counts aren't populated correctly...

In this case, all 12 are cached - thus the duration of 0, but the risk_counts aren't correctly tallied when reports are pulled.
  "metadata": {
    "times": {
      "start_time": "2020-03-11T00:15:36.482550Z",
      "end_time": "2020-03-11T00:15:36.512132Z",
      "duration": 0
    },
    "risk_counts": {
      "": 12
    },
    "repo_count": 12

Fixing here and upstream - lei 0.4.3 will have fix to handle the struct.

"metadata": {
    "times": {
      "start_time": "2020-03-11T02:07:21.027503Z",
      "end_time": "2020-03-11T02:07:37.968507Z",
      "duration": 16
    },
    "risk_counts": {
      "medium": 1,
      "low": 5,
      "high": 2,
      "critical": 4
    },
    "repo_count": 12
  }

Fixed.


Confirm GetCustomerResponse is exported

We want to ensure that GetCustomerResponse can be used external to the SDK

@piyalbasu  Yes, I can confirm GetCustomerResponse can be used external to the SDK as long as you are on version 1.7.0 in which we've fixed lots of exporting.
Devs can import it like this:
import { Types } from "@stellar/typescript-wallet-sdk";

let customerResponse: Types.GetCustomerResponse;


chore: adds go mod tidy and go work sync for all modules.

Thank you for contributing to Coraza WAF, your effort is greatly appreciated
Before submitting check if what you want to add to coraza list meets quality standards before sending pull request. Thanks!

Make sure that you've checked the boxes below before you submit PR:

[ ] My code includes positive and negative tests.
[ ] I have an appropriate description with correct grammar.
[ ] I have read Contribution guidelines, maintainers note and Quality standard.
[ ] My code is properly linted and passes pre-commit tests.

Thanks for your contribution :heart:

PTAL @anuraaga

@anuraaga PTAL


issue-credential-#114 OpenAPI

Added /credential/issue endpoint to OpenAPI and did some refactoring

@Idontker will do the merge :))


WEEK 6 AND MODS FOLDER CRASH

Describe your bug here.
Heya! Redstone Engine creator here.
If anyone sees this issue, please help.
I need someone to fix Mods Folder and Week 6 crashing.
Help will be appreciated and you will get credited!
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No

send crash line when possible


OS chooser

Add OS choose

Won't get added. Other OS use way more resources.

Due to the new credit system, this will be added.


Passcode/password implementation update

Back end implementation of password/password to work with the latest mobile wallet library:

Implement passcode for signing transactions.
Startup PIN/Password.
Add option to change private/public security pin/password.

this was done in #137


Native type must not be used as object.

I pass the class name to the function and access a constant of this class by referring to it through a string. I receive an error message from php-hammer stating "native type must not be used as object.", but this is a static call, not an object. Is this the expected behavior?

Can you provide a complete example?

Class Bar contains a public constant CONST.

Is that enough for an example?

Perfect! I believe that in the case you mentioned I can try to check if the type of the parameter is a class-string and allow its use in this way. Thanks!

Implemented in version 0.22.0:
Hello @akar1n, the new version 0.22.0 has just been released and is available for direct download from the Releases page. This update will be available on the Jetbrains Market in approximately three days if you prefer to wait.
This version comes with some new features, now totaling 51 inspections:

Support for the new PhpStorm 2023.2 EAP (minimum version from now on);
Inspection to suggest strict comparison when possible;
Inspection to suggest the use of non-deprecated functions (e.g., mt_rand() to random_int());
Additional feature: add missing semicolon when saving a PHP file;
Other minor improvements.

Regarding your report, this issue has also been fixed in this version. Now, variables typed as class-string will be ignored by this inspection.


Change msbuild error

PR Details
This PR should make the readabilty of a common error easier to understand.
Description
I added references to the .NET 6 package in 2 places where an error describes needing MSBuild 16.0. I added these because even the VS2022 installation does not solve this error and user need to manually install the .NET 6 SDK in order for gamestudio 4.1 to run.
I also did a little bit of code clean up with some if statements.
Related Issue
https://github.com/stride3d/stride/issues/1612
also at least one question about this problem a week in the discord.
Motivation and Context
There are a lot of new Stride user coming in that have not manually installed the .NET 6 SDK. I am hoping this error message will be a bit more friendly to read.
Types of changes

[x] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

going to remake this PR because Im bad at git.

Looks good. Please squash your changes and rebase your branch to remove commits unrelated to this PR.

https://github.com/stride3d/stride/pull/1643 new PR because I totally messed up my master branch.


chore: add swagger doc for GetSuccessChunks

What type of PR is this?
/kind doc

What this PR does / why we need it
chore: add swagger doc for GetSuccessChunks
Which issue(s) this PR fixes

For https://github.com/kubeagi/arcadia/issues/447
Special notes for your reviewer

@xxxxibo can you add more docs for other apis in this pr?


Duplicate trait autoimport completions with trait objects

mod baz {
    pub trait DefDatabase {
        fn method1(&self);
    }
    pub trait HirDatabase: DefDatabase {
        fn method2(&self);
    }
}

mod bar {
    fn test(db: &dyn crate::baz::HirDatabase) {
        db.metho<|>
    }
}

The methods are already inherently available, but they get suggested as autoimports anyway.

Currently autoimoprts are getting scope definitions from Semantics and filter out any imports that are contained there:
https://github.com/rust-analyzer/rust-analyzer/blob/c2a63b97a80cb738f800da61c64e748994709c31/crates/ide_db/src/helpers/import_assets.rs#L230
For the current example, import.item_to_import in the code is a trait that contains the method.
Looks like we don't consider such traits as "scope definitions"?

They aren't in scope, but you can call the method anyway. We probably need to add a different check for method completions.

Yes, composing the test from the example and dbg-printing items in scope_definitions method shows that besides ModuleDef(BuiltinType(...)) there are only two definitions in scope for the code snippet given:

Local(Local(..)) with name db
ModuleDef(Function(..)) with name test

We get Semantics from the completion context: https://github.com/rust-analyzer/rust-analyzer/blob/e1e6e3b925bf7e0f6ca6cbc0d63d59572752653d/crates/ide_completion/src/completions/flyimport.rs#L140
so at least we're not utterly wrong on that side.
Another funny observation is that if I choose the autoimport completion option and insert the use statement, no warning is emitted by rustc about the "unused" statement, so technically it's a valid, different way of completing the method albeit I agree that it's odd.
I'm rather clueless on how to look for such items and check that they are fine to use without the import, do you have any ideas?

Here's the code which decides which traits are considered for a method call:
https://github.com/rust-analyzer/rust-analyzer/blob/e131bfc747df1b21ae6ea04eb9c55001e06b7bf0/crates/hir_ty/src/method_resolution.rs#L623-L635
Maybe the best approach would be to extract this and make it callable from completion, or add a method that checks whether a trait is an "inherent" candidate.


Rename BAPS3?

While BAPS3 will be the name of the URY implementation of this spec due to historical baggage, I think the actual name of the spec needs to be changed to something more approachable.
To get the ball rolling, here are some possibilities (mostly based on Norse mythology, because we're all based in York):

midgard (Microservices Delivering Great Audio for Radio)--a very human set of userland tools for pushing audio around the place.

Viking theme

Backronym makes sense

Exactly what it says on the tin

Backronym is a bit contrived and a bit unwieldy

Not a very catchy name

mjolnir (Multimedia Job Operation-**Level Nodes Intended for Radio)--a hammer with which to drive in the nail of audio.

Viking theme

Sounds awesome and powerful

Very contrived backronym (like, seriously, wat)

bifrost (Basic Interfaces For Radio-Oriented Sound Transfer)--magical rainbow bridge linking presenters to the music library

Also Viking theme

Vaguely relevant name?

Yes, this is contrived too

cougar - Collection Of Utilities Guaranteeing Amazing Radio
spartan - Systems/Protocols A Radio-station Transmitting Audio Needs
psiren - Protocol Specification Intended for Radio ENablement

wontfix


task(ci): add sonar

https://sonarcloud.io/summary/overall?id=rh-psce_trestle-bot

LGTM. Do you have test branch showing this running successfully? The workflow ended up being skipped in this instance because there are no python changes.

I found a phrase with a period that I removed to verify functionality. PTAL.


Hi, what is the writing method to the right of the equal sign in statement  ' img_size="${..encoder.img_size}" '

What does .. mean ?

Hi, @xiaoxiong007 .
${..encoder.img_size} is an expression of OmegaConf, you can find a detailed documents here. And in short, .. indicates the parent node of current leaf node.

Thank you, i get it!

I believe the issue at hand was addressed, as such I'm closing this. Feel free to ask if you have further questions.


📖 Translate documentation into different languages

Maybe use some translation tool for the initial translations and then get people to double check it.
When a translation is not available just show the english version. Also display what percentage of the website has been translated into the language.
Languages:

[ ] German
[ ] Korean
[ ] Chinese
[ ] Spanish
[ ] French

Resources

https://github.com/ivanhofer/typesafe-i18n
https://github.com/ivanhofer/typesafe-i18n-demo-sveltekit
https://crowdin.com/

Examples

https://pnpm.io/fr/using-changesets

It would make sense to do this down the road when the library doesn't change that much anymore.


Make thread safe

ExpressMapper is not thread safe.
Example:
An item with the same key has already been added.
   at System.ThrowHelper.ThrowArgumentException(ExceptionResource resource)
   at System.Collections.Generic.Dictionary`2.Insert(TKey key, TValue value, Boolean add)
   at ExpressMapper.MappingService.CompileCollection[T,TN]() in c:\SourceCode\ExpressMapper\ExpressMapper NET40\MappingService.cs:line 504
   at ExpressMapper.MappingService.PreCompileCollection[T,TN]() in c:\SourceCode\ExpressMapper\ExpressMapper NET40\MappingService.cs:line 493
   at ExpressMapper.MappingService.Map[T,TN](T src) in c:\SourceCode\ExpressMapper\ExpressMapper NET40\MappingService.cs:line 156

FIXED and will be included in 1.1 release


Journal: enable external reviewers through invite assignment invitations

Let the journal decide if they want to enable the "invite assignment" invitations to recruit external reviewers for a single papers.
This PR create the Invite_Assignment and Assignment_Recruitment invitations that supports the workflow.
There are two open issues in the edge browser in order to show this invitation button for reviewers that are not official.
It depends on https://github.com/openreview/openreview-web/issues/1761 and https://github.com/openreview/openreview-web/issues/1762 and https://github.com/openreview/openreview-api/pull/323

Test are not passing until we merge: https://github.com/openreview/openreview-api/pull/323 but first I need to modify a few things in openreview-py: https://github.com/openreview/openreview-py/pull/1970

switched to draft so it is not ready to be merged yet.

This is ready to review now, adding Emilia as reviewers so she gets familiar with the Journal changes.


Experiment with CI on public runners

~Blocked on runtimeverification/k#4059~

Integration test jobs seem to take twice as long as on private runners.


Build fails on Parcel 2 + pnpm because of stats.js module

Problem
When I try to import drei in a Parcel 2 project, like this:
import { OrbitControls } from 'drei'

that's what I get:

Solution
I think it's good to generate a bundle with not only dist/index.js but each component separately as well. It is possible if Rollup config uses output dir instead of output file. so we will be able to import each component separately without stats.js being a direct dependency.
Versions

pnpm: 4.14.2
drei: ^0.0.32
parcel: ^2.0.0-alpha.3.2

i dont see why this is a bug on rollups or dreis side<EMAIL_ADDRESS>import StatsImpl from 'stats.js';

<EMAIL_ADDRESS>
jsx```
"dependencies": {
  "stats.js": "^0.17.0",

@drei yeah it is a pnpm issue, it probably didn't link stats.js module.
I wanted to import HTML with drei/dist/HTML.js not to have to deal with missing module errors which I don't use.
I think I will close the issue though, but just in case anyone faces the same issue, the solution is installing stats.js directly in the project:
pnpm i stats.js


Improve auto reply registration

Why are these changes needed?

Make _check_termination_and_human_reply a registered method so that other functions can be registered before it.
Make registration position configurable.
Allow registered functions to be excluded in generate_reply.
Remove the need for overriding generate_reply completely.
Update the chess and groupchat notebooks.
Use object as key.
Add link to the groupchat notebook.

Related issue number

Checks

[x] I've included any doc changes needed for https://microsoft.github.io/FLAML/. See https://microsoft.github.io/FLAML/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

https://github.com/microsoft/FLAML/actions/runs/5756114523/job/15604943615?pr=1170#step:12:105
____________________________ test_responsive_agent _____________________________

monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7f95c06de1c0>

    def test_responsive_agent(monkeypatch):
        dummy_agent_1 = ResponsiveAgent(name="dummy_agent_1", human_input_mode="ALWAYS")
        dummy_agent_2 = ResponsiveAgent(name="dummy_agent_2", human_input_mode="TERMINATE")

        monkeypatch.setattr(sys, "stdin", StringIO("exit"))
        dummy_agent_1.receive("hello", dummy_agent_2)  # receive a str
        monkeypatch.setattr(sys, "stdin", StringIO("TERMINATE\n\n"))
        dummy_agent_1.receive(
            {
                "content": "hello {name}",
                "context": {
                    "name": "dummy_agent_2",
                },
            },
            dummy_agent_2,
        )  # receive a dict
>       assert "context" in dummy_agent_1.chat_messages["dummy_agent_2"][-2]
E       IndexError: list index out of range

test/autogen/agentchat/test_responsive_agent.py:[84](https://github.com/microsoft/FLAML/actions/runs/5756114523/job/15604943615?pr=1170#step:12:85): IndexError
----------------------------- Captured stdout call -----------------------------
dummy_agent_2 (to dummy_agent_1):

hello

--------------------------------------------------------------------------------
Provide feedback to dummy_agent_2. Press enter to skip and use auto-reply, or type 'exit' to end the conversation: dummy_agent_2 (to dummy_agent_1):

hello {name}

--------------------------------------------------------------------------------
Provide feedback to dummy_agent_2. Press enter to skip and use auto-reply, or type 'exit' to end the conversation: dummy_agent_1 (to dummy_agent_2):

TERMINATE

--------------------------------------------------------------------------------
Please give feedback to dummy_agent_1. Press enter or type 'exit' to stop the conversation:
>>>>>>>> NO HUMAN INPUT RECEIVED.

Would a function unregister_auto_reply be useful? Just a random thought, no actual use case from my side.

I guess it'll be useful. We can add it when needed.


User microservice unit tests

Pull Request
Description
Test cases have been added to the functions and endpoints in the user service. Some of the expected response codes have been commented out at the moment as I thought we might want to change the response codes in the future.
Related Issue(s)
Closes #46
Screenshots (if applicable)

Checklist

[x] I have checked that the changes included in the PR are intended to merge to master or any destination branch.
[x] I have verified that the new changes do not break any existing functionalities, unless the new changes are intended and have approved by the team.
[x] I will take care of the merging and delete the side-branch after the PR is merged.

Additional Notes/References

Can you help include grading-service test and user-service test in the CI? Just modify the Backend_CI.yml


Response "Premium required" though my account is premium

Hey there!
I am having issues using the player controls (next, previous, play/pause, setRepeat and setShuffle) in C#.
My client authorizes successfully when I call my code on initialization but it fails when calling the command.
My account is part of a spotify premium family account.
Auth Code:
private void AuthSpotifyClient()
{
    try
    {
        SpotifyClientConfig config = SpotifyClientConfig.CreateDefault();
        ClientCredentialsRequest request = new ClientCredentialsRequest("clientId", "clientSecret");
        ClientCredentialsTokenResponse response = new OAuthClient(config).RequestToken(request).Result;
        spotify = new SpotifyClient(config.WithToken(response.AccessToken));
        Debug.WriteLine($"spotifyAPI successfully authorized");
    }
    catch (Exception ex)
    {
        Debug.WriteLine($"failed to authorize spotifyAPI: {ex.Message}");
    }
}

Example player command:
private async void PreviousTrackButton_Click(object sender, RoutedEventArgs e)
{
    bool skipped = await spotify.Player.SkipPrevious();
    Debug.WriteLine($"SkipPrevious: {skipped}");
}

Best regards

Please have a thorough look at https://johnnycrazy.github.io/SpotifyAPI-NET/docs/auth_introduction and https://johnnycrazy.github.io/SpotifyAPI-NET/docs/client_credentials
The player is a user based endpoint, so client credentials can't work.


SSCS-10978: initial implementation of sending generic letter

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/SSCS-10978
Change description
initial implementation of sending generic letter
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

not needed


Move OneLogin_Saml2_ValidationError from Error.php to ValidationError.php

Currently Error.php file contains both OneLogin_Saml2_Error and OneLogin_Saml2_ValidationError. In case not classmap loader (e.g. psr-0) it causes error. Please keep 1 class per 1 file.

Do you have a PR for that?


Feature/build

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feature add password func

Proposed changes
add password function
select password("123");
+-------------------------------------------+
| password('123')                           |
+-------------------------------------------+
| *23AE809DDACAF96AF0FD78ED04B6A265E05AA257 |
+-------------------------------------------+

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.59 seconds
stream load tsv:          546 seconds loaded<PHONE_NUMBER>9 Bytes, about 130 MB/s
stream load json:         21 seconds loaded<PHONE_NUMBER> Bytes, about 107 MB/s
stream load orc:          67 seconds loaded<PHONE_NUMBER> Bytes, about 15 MB/s
stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select:          29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size:<PHONE_NUMBER>6 Bytes

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.51 seconds
stream load tsv:          547 seconds loaded<PHONE_NUMBER>9 Bytes, about 130 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          66 seconds loaded<PHONE_NUMBER> Bytes, about 15 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          30.2 seconds inserted 10000000 Rows, about 331K ops/s
storage size:<PHONE_NUMBER>5 Bytes


Delete Font.css

In your fonts folder there is a file called font.css, this is just to provide you some starting code but does not need to be left in the project.
Copy the @font-face values if you haven't all ready and add them to the appropriate sass partial.
Once you have done that, just delete this extra file!

[ ] Delete font.css file in the font folder

font.css file was deleted.


Update permissions on 2 blades

This is an update for issue #1020 submitted yesterday.
It adds permission check to blades so that Edit, Add, Delete buttons appear correctly based on set permission, especially in cases where user only has Browse and Read permission.
It also adds a "Return to List" button in the bread/read.blade.php

Thanks! Wonderful update! 👍


Support for NX - @nx/maestro?

I'd be great if NX and Maestro worked well together.
https://nx.dev/nx-api/detox is an existing plugin that could be used for inspiration.
https://github.com/nrwl/nx/issues/19470

Hi @tmc, thanks for using Maestro and creating this issue!
I'm not familiar with neither nx, and only a bit with Detox. Could you share what would be use-case for such an integration? Is there anything that cannot be achieved without it?


Add "expand/collapse all" toggle to the tree view in step 2 of the plan wizard

Currently this is not possible due to a limitation of the PatternFly TreeView. This needs to be solved in PatternFly itself, but I'm opening this issue so we remember to follow up and add that support here once it is available.

Upstream issue to track: https://github.com/patternfly/patternfly-react/issues/4797

This has now been implemented in PatternFly: https://github.com/patternfly/patternfly-react/pull/5503

Following up with https://github.com/patternfly/patternfly-react/issues/5933

@mturley , @seanforyou23 ,
Because for the Plan's wizard the top level of Treeview's FilterVMsForm is always a single node "All datacenters" there is no need for a collapse/expand all toggle.
The default behavior (not sure that was always the case for prior PF core version, but I can't see it in current master and following versions) automatically collapses/expands all sub-nodes when clicking a given node arrow (> or v).
So clicking "All datacenters" node arrow fullfills the requirement to collapse/expand all nodes.
Let me know what you think.

Ha! That's a good point, I hadn't considered that we basically already have this functionality. @vconzola do you have an opinion on this? A separate expand/collapse all button for the tree might be overkill.

@mturley I don't like the default behavior if it means that clicking an arrow expands all sub-nodes below it. That's a terrible idea because it doesn't scale well for large trees. I'll bring it up with Matt. I'd like to keep (or go back to) our current design where clicking an arrow only expands the nodes immediately below the selected node. And keep the select all toggle. Can we do this?

@vconzola looking into it more closely, it looks like when we passed the defaultAllExpanded prop (to make the whole tree start out fully expanded... if we're worried about larger trees, do we still want this behavior?) that causes the expand action to always expand all sub-nodes. That sounds to me like a bug in the TreeView.
However, @gildub now that the TreeView supports the allExpanded prop that we can use to implement the expand/collapse-all toggle, I think we can drop defaultAllExpanded and just default the allExpanded state to true. I'm not sure what the point of that prop is now that the other exists anyway, it seems there's some weird stuff going on with TreeView.

Unrelated, @vconzola I really like this new variant they added to the tree view with little dotted-line guides: https://www.patternfly.org/v4/components/tree-view#guides what do you think about switching to that style?

@mturley I like the guides in the tree view too. Let's switch to that style. Wrt having the whole tree fully expanded, for our use case, I'm on the fence. I don't really have a good feel for how many datacenters/clusters a customer will have. When we included hosts in the tree I think full expansion would be problematic, and it might be for folders too. I just don't know what customer environments look like. I guess for now we can keep it as is and change later if it becomes a problem.

Guides looks really good.
I adjusted PR accordingly.
Thanks!

Leaving this open after #766 so that we can address this after https://github.com/patternfly/patternfly-react/issues/6314 is addressed upstream.

This should be fixable by upgrading PF after https://github.com/patternfly/patternfly-react/pull/6326 is released

This issue is not relevant anymore as the current design works fine.
With the latest small change from https://github.com/konveyor/forklift-ui/pull/846 only the the children under first level "All datacenters" are initially expanded allowing a reasonable list to be displayed. From there the user can expand manually sub children using the arrow buttons.


Maximum call stack size exceeded

.....
cpu.js:479 RangeError: Maximum call stack size exceeded
    at vd (cpu.js:3684)
    at ud.L.rf (pic.js:157)
    at lb (cpu.js:3698)
    at Xe (cpu.js:2074)
    at vd (cpu.js:3680)
    at ud.L.rf (pic.js:157)
    at lb (cpu.js:3698)
    at Xe (cpu.js:2074)
    at vd (cpu.js:3680)
    at ud.L.rf (pic.js:157)
cpu.js:478 RangeError: Maximum call stack size exceeded
    at vd (cpu.js:3684)
    at ud.L.rf (pic.js:157)
    at lb (cpu.js:3698)
    at Xe (cpu.js:2074)
    at vd (cpu.js:3680)
    at ud.L.rf (pic.js:157)
    at lb (cpu.js:3698)
    at Xe (cpu.js:2074)
    at vd (cpu.js:3680)
    at ud.L.rf (pic.js:157)
cpu.js:479 RangeError: Maximum call stack size exceeded
    at vd (cpu.js:3684)
    at ud.L.rf (pic.js:157)
    at lb (cpu.js:3698)
    at Xe (cpu.js:2074)
    at vd (cpu.js:3680)
    at ud.L.rf (pic.js:157)
    at lb (cpu.js:3698)
    at Xe (cpu.js:2074)
    at vd (cpu.js:3680)
    at ud.L.rf (pic.js:157)
cpu.js:482 Uncaught RangeError: Maximum call stack size exceeded
    at vd (cpu.js:3684)
    at ud.L.rf (pic.js:157)
    at lb (cpu.js:3698)
    at Xe (cpu.js:2074)
    at vd (cpu.js:3680)
    at ud.L.rf (pic.js:157)
    at lb (cpu.js:3698)
    at Xe (cpu.js:2074)
    at vd (cpu.js:3680)
    at ud.L.rf (pic.js:157)
Works fine with qemu, Freezes in browser and this is the error I get.

@adminy Could you attach or link us to the disk image and provide reproduction steps?

@copy I've uploaded the image here: https://drive.google.com/file/d/1fKKgWaQQGzI6BpUY9YtRo4J1nTkUfHj7/view?usp=sharing

A very strange development on this issue happened. I commented out async: true and it got past this error. Pretty Strange I'd say.

Interesting find, I'm looking into it.


iPhone SE (2020) ?

iPhone SE (2020) ?
This should be: iPhone12,8
Not sure what most common name is, "iPhone SE 2020" or "iPhone SE 2nd generation". For now, I added it like this:
// iPhone SE 2020
@[@12, @8]: @[@(GBDeviceModeliPhoneSE2), @"iPhone SE 2020", @(GBDeviceDisplay4p7Inch), @326],

We merged it in as GBDeviceModeliPhoneSE2  in the end.
PS sorry for the late comment.


Framework for Unsafe ALTER TABLE support

Need to implement two mechanisms to support unsafe ALTER TABLE in a non-blocking manner:

[ ] Rollback mechanism for removing a staged DataTableVersion (likely lives inside TransactionManager::Rollback
[ ] Predicate check mechanism.  Current plan is two-stages in lifecycle:  Installed (visible and evaluated by all transactions immediately before commit; sets a failed flag if appropriate but still commits) & Enforced (visible and evaluated by all transactions and forces an abort if failed).

Sequencing for unsafe ALTER TABLE:

Grab begin timestamp
Parse query
Check if query executes an unsafe ALTER TABLE
Grab all planned write locks in the CATALOG (ensures fast abort and ensures schema change does not change between now and 6, below)
Install predicate
Fetch new "begin" timestamp
Execute table scan to check visible tuples for safety compliance.
Check predicate validity, abort now if invalid
Grab commit latch
Double-check validity, release latch and abort if invalid
Set predicate to enforcing.
Release commit latch.

Sequence for other transaction

[Proceed as normal until immediately before grabbing commit latch]
Run all predicate checks storing whether they succeeded or failed.
Check whether any failed predicates are enforcing, if so abort.
Grab commit latch
For each failed predicate, recheck enforcing.  If now enforcing, release latch and abort.
Grab commit timestamp.
For each failed predicate, set validity flag to false.
[Proceed as normal starting with logic immediately after grabbing commit timestamp]

Lifecycle management for predicates:

Immediately unlink on abort, GC with txn.
For committed: unlink predicate when timestamp older than oldest running transaction.
Delete predicate once unlink timestamp is older than oldest running transaction.

After diving through the code, the hash map we are currently using is unsafe under our use case (implementation).  This means we will either need an internal hash map implementation or a heavier wait process for executing rollbacks (i.e. copy over the hash map minus the removed element and CAS over to the new table).  We can punt the issue further down the road by only installing the new version after we've confirmed commit (but this doesn't solve the problem for compaction in the future).


Schema Introspection Failure

When using federation, Apollo Sandbox throws an error:
Schema Introspection Failure

We couldn't parse your graphql schema, or building your schema failed. The expected format is either IntrospectionQuery or SDL string.

Error in GraphiQL:
Name \"__resolveReference\" must not begin with \"__\", which is reserved by GraphQL introspection.

Looking at the schema through PAW(RapidAPI), I noticed that the types to which I added key have __resolveReference. I'm not sure but maybe it shouldn't be there.
Maybe I'm doing something wrong, I'm trying to make a subgraph in a service that has a table with addresses and it should give addresses for the company through the gateway if the client requests a company with an address
In SDL I added:
extend type Company @key(fields: "addressID") {
  address: Address
  addressID: ID @external
}

In the scheme:
        Type(CompanyModel.self, as: "Company") {
            Field("addressID", at: \.addressID)
            Field("address", at: \.address)
        }.key(at: GraphQLResolver.addressToCompany) {
            Argument("addressID", at: \.addressID)
        }

I haven't used the gateway yet, just trying to open the schema via Apollo Sandbox

Hey @ZirgVoice, thanks for reporting! You're probably the first one to be really using this feature so unfortunately you're hitting our rough edges.

I noticed that the types to which I added key have __resolveReference. I'm not sure but maybe it shouldn't be there.

I think I've fixed this issue  - see this pull request: https://github.com/GraphQLSwift/Graphiti/pull/103
For background, these were an artifact of how we implemented federation (see here). We took inspiration from this portion of the Apollo Federation documentation. However, for some convenience reasons, we defined __resolveReference as a full-on field as opposed to just a resolver function, which made the introspection queries unhappy. I've reworked that in the pull request I linked above
Thanks again!

Now it works, thanks a lot!


ci(config): update ci

Haven't touched husky v6, lint-staged and Node 14 like I wanted to. But at least this works and we can use yamllint again.

:tada: This PR is included in version 1.27.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix negative number support in Q REs and adds unit tests

QINTEGER and QFLOAT now correctly support negative numbers (verified on bq)
Adds unit tests for negative number and lower case booleans

Signed-off-by: Luigi Mori<EMAIL_ADDRESS>

Thanks for the fix and unit tests. I should have caught that. Merging...


Add Neat 2.0 ltr/rtl support

International projects have unique needs, one of which is support for ltr/rtl support. Ideally a user would be able to switch directions with use of a single setting. I have not seen this done successfully in other frameworks but I believe it to be successful.
I would love to hear from those who work in multiple languages and text directions and their successes and failures in doing so. This will likely have a significant impact on how this feature manifests.

@jensimmons recommended reaching out to the Drupal community.
Will invesigate

This will likely not make 2.0 but is a great candidate for a 2.X

Requires user data to resolve.
@whmii to make a survey about some of these features and reach out to the community.

Oh I misread your first post..so to answer your question:
Yes RTL float system is more intuitive since everything in terms of usability and ux in general is mirrored..so you'll find main" content blocks on the right and the sidebar on the left..etc
I usually work on either only Arabic(rtl) websites or multilingual websites that include at least Arabic and English(French comes next).
The first case would not differ much in terms of the grid..I know lots of developers in the region here who use Bootstrap; they use grid classes + push/pull helper classes to switch their divs' position..
But when it comes to bidirectional websites..it'll get ugly with Bootstrap, unless you separate your markup too(which is even uglier).
And I'm only here talking about grids; using frameworks' other ui components is a different story.
Foundation on the other hand, their rtl support makes everything easier..my sass is unified..and my output is two mirrored .css files.
Before CSS preprocessors, I would start with LTR version and then work on the RTL one. Because Drupal(and WordPress too) loads both(styles.css and styles-rtl.css), I would override only the horizontal positioning attributes in the -rtl.css file. It was a very time consuming and boring process.
All of the multilingual/bidirectional websites I've worked on share the exact layout but mirrored...what's left becomes on the right and vice versa.
Another non-layout difference is the font-size..Arabic fonts are usually smaller for some reason. A base font of 12px in English becomes 14px in Arabic(Tahoma for example). Sometimes this requires some layout alters(but this is very rare).
By the way, I really like your framework's logic..I personally use other frameworks' grid mixins heavily for the same reasons.
I hope my answers help you with your framework.
Layal

— crosspost from https://groups.drupal.org/node/513253#comment-1150039

@whmii I work for the DTO in Australia we are similar to 18F in the US. We will eventually need to translate a lot of our digital products into other languages so I would be keen to help out with this feature.

@catherine-jones I will work out a basic prototype that will flip the float and push/pull behavior and we'll see how it goes from there. 👍 👍 👍

I have created a PR for this feature. Once merged, I will close this issue

done :P


Request header field content-type is not allowed by Access-Control-Allow-Headers

This is fixed now. You can pass Content-Type header in a cross-origin request.


Access WebPage Content

Currently, there doesn't seem to be a way to access webpage contents, such as innerHtml. I tried to use WebBrowserController's evaluateJavascript method, but as it returns a Future, I'm not able to get data from it.

This package does give you access to the underlying controller (webview_flutter), which has relevant methods.


fix: Update the moving focus implementation

Coverage decreased (-1.02%) to 27.884% when pulling c99f24eb077be0797b368bc82fa3d05773302e39 on new-move-impl into 522b058ec8cecca76bd66926a5ec35beba936155 on master.


chore(e2e): add config options to internal dapp [LW-10134]

Context
JIRA Ticket
Currently everything in our custom cardano-js-sdk dapp is hardcoded: https://github.com/input-output-hk/cardano-js-sdk/tree/feat/dapp-connector-client-poc
We need to add feasibility to customize Dapp transactions
Proposed Solution

Specify amount/recipient for send tx
Specify staking pool id for staking transaction

@tomislavhoracek let's render the "Details" section differently, so that it also works on smaller window sizes (currently its truncated on the right side of the window):

lso works on smaller window sizes (currently its truncated on the right side of the window). The "connect lace" button doesn

@DominikGuzei Thanks for the feedback. I agree with you.
I left it as is since I'm working on another ticket and this one is currently unassigned. Would you like to add those changes ? 😄

@tomislavhoracek I changed the layout to this:

One thing i observed is that building a simple ADA transaction is a bit more involved now since i have to delete all the asset related fields

One thing i observed is that building a simple ADA transaction is a bit more involved now since i have to delete all the asset related fields

@DominikGuzei aha, that makes sense to me. It is cleaner and if you can add assets if you want 👌

I'm closing this PR due to the comment.
New ticket with adjusted requirements was created and will be handled in the new PR


reduce projected Site/Device details when getting devices/AirQlouds/Sites

reduce projected site and device details when getting Devices/Sites/AirQlouds
WHAT DOES THIS PR DO?

[x] reduce projected site details when getting devices
[x] reduce projected device details when getting sites
[x]  reduce projected site details when getting AirQlouds

WHAT JIRA STORY/TASK IS RELATED TO THIS PR?

README, staging
WHICH ENDPOINTS SHOULD BE READY FOR TESTING?:

N/A
ARE THERE ANY RELATED PRs?
N/A
SCREENSHOTS?

Hi @ja-odur , just merging this in a few....
Guess we shall just closely monitor staging frontend closely in the next 1/2 days.


DELIA-46667 : improve System.getXconfParams

Reason for change: Read only model (faster)
Test Procedure: Call System.getXconfParams
Risks: Low
Signed-off-by: Nikita Poltorapavlo<EMAIL_ADDRESS>

brings #459 to 2101

@anand-ky, please merge


doc: Estabilish a default Code Styling/Code Formatting

As the Web3Task project may receive more integrants to contribute to the project over time, it may be of mutual interest to establish a default Code Formatting to the visual studio, which is the default coding tool for Web3Task.
This would lead to comprehensive code and standardized patterns, improving reading time and cutting down the adjusting time.
For example:
If someone new clones a repository and starts building on it, its VisualStudio default configuration could format the file in a way that is not according to the patterns,  modifying the entire file and therefore making it harder to read the diff file when a pull request is initiated.

We need this! We can generate a Prettier file and leave it in the root folder to standardize the repo!

At the moment it doesn't make sense for the project


fast/stages/1-resman: Allow stage 2 Network and Security folders to be created under top level folder

https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/blob/24b90492999036c69d899974e3f775eacab01708/fast/stages/1-resman/stage-2-networking.tf#L42
below change to code will allow networking folder to be created under top level folder
parent = (
    var.fast_stage_2.networking.folder_config.parent_id == null
    ? local.root_node
    : try(
      local.top_level_folder_ids[var.fast_stage_2.networking.folder_config.parent_id],
      var.fast_stage_2.networking.folder_config.parent_id
    )
  )

same can be applied to stage-2 security as well

Yes, we have a bug there great find. I'll  send a quick fix.


[react][core] Add support for sx replacement in transformed jsx calls

This got left out in the last PR where it only supported transformation in code with JSX.
This PR adds support for sx transform in already transformed JSX element to jsx() calls.

@brijeshb42 what do you think about adding labels for each @pigment-css packages and add tags related to the packages. For example, I would title this PR: "[pigment-css-react][bug] Add support for sx replacements in transformed jsx calls"

Makes sense regarding the tags. I'd maybe skip the pigment in the name since this repo is only for Pigment CSS, like [react][bug]. WDYT?

@siriwatknp Let me know if this fixes your issues. I'll merge once you confirm.


Touch screen click and hold

Describe the solution
Click and hold allows users to access right click options it work everywhere but in files. It should work for single and double click options in any layout.

I just tested, touch and hold to right click does indeed work. Could you please provide more information on this issue?

i test this using touch mode on rdp android client

Fixed in 1.9.14


Works perfectly, thanks!


Replace retry library with thread-safe implementation

Replace the existing retry library github.com/cenkalti/backoff/v4 with github.com/sethvargo/go-retry which has thread-safe implementations and is widely used in g3 (see https://g3doc.corp.google.com/third_party/golang/go_retry/README.md?cl=head).
This PR also adds those tests related to RefreshToken + FetchContainerSignatures to a test suite with race condition check.

/gcbrun

/gcbrun

/gcbrun

/gcbrun


when source file changed, browser had download the changed file, but component can't re-render?

as title , when source file changed ,the browser download the  latest file by
http://localhost:3000/static/js0.4965c3f3795c7c33462d.hot-update.js
the older file is

when changed as  the red box
and browser just do like below , but the component can not re-render or refresh by itself,so i must reload the full page by myself

is this due to the hot and dev middleware??

The console output appears to show the hot reload being applied correctly.
Are you using react-hot-loader or similar to apply the hot update to your components? Can you share your webpack config, and the full browser console output from [HMR] bundle rebuilding onwards

i am using webpack-hot-middleware and webpack-dev-middleware, the whole console :
start to render
client.js:55 [HMR] connected
client.js:123 [HMR] bundle rebuilding
client.js:126 [HMR] bundle rebuilt in 209ms
process-update.js:27 [HMR] Checking for updates on the server...
client.js:18start to render
process-update.js:100 [HMR] Updated modules:
process-update.js:102 [HMR]  - ./src/client/static/js/components/Counter/index.js
process-update.js:102 [HMR]  - ./src/client/static/js/containers/Counter/index.js
process-update.js:102 [HMR]  - ./src/client/static/js/containers/index.js
process-update.js:102 [HMR]  - ./src/client/static/js/routes/index.js
process-update.js:107 [HMR] App is up to date.
5client.js:55 [HMR] connected
my dev webpack config
var path = require('path')
var webpack = require('webpack')
var AssetsPlugin = require('assets-webpack-plugin')
var ExtractTextPlugin = require("extract-text-webpack-plugin");
module.exports = function(config){
    console.log('dev:',__dirname)
    var webpackConfig = {
        devtool: 'cheap-module-source-map',
        entry: {
            app:[
                'webpack-hot-middleware/client?path=http://' + config.server_host + ':' + config.server_port + '/__webpack_hmr&timeout=20000&reload=true&overlay=true',
                './src/client/static/js/client.js'
            ]
        },
        output: {
            path: config.path.base + '/statics/static/js',
            //filename: '[name]-[chunkhash:8].js',
            filename: '[name].js',
            //chunkFilename: "[id].bundle.js",
            publicPath: '/static/js'//config.server_host + ':'+ config.server_port + '/static/js'
        },
        plugins: [
	        new webpack.DefinePlugin({
	            "process.env": {
	            	'NODE_ENV' : JSON.stringify('development'),
	            	'__BROWSER__': JSON.stringify(true)
	            }
	        }),
	        new ExtractTextPlugin("[name].css"),
        	new webpack.optimize.DedupePlugin(),// 优化的模块，不需要重复加载相同模块
            new webpack.optimize.OccurenceOrderPlugin(), //按照出现的顺序打包
            new webpack.HotModuleReplacementPlugin(), //热体验用的
            new webpack.NoErrorsPlugin()
        ],
        progress: true,
		resolve: {
			root: path.resolve('src'),
		    modulesDirectories: [
		      'node_modules'
		    ],
		    extensions: ['', '.json', '.js', '.jsx']
		},
		recordsPath: path.join(__dirname, 'console/_records.json'),
        //watch:true ,
        module: {
            loaders: [
              	{
	                test: /\.js$/,
	                loader: 'babel',
	                exclude: /node_modules/,
	                include: __dirname,

              	},{
				    test: /\.scss$/,
				    loader: ExtractTextPlugin.extract("style-loader", "css-loader!sass-loader")
		}
            ]
        }
    }

    var venderWebpckConfig = {
    	devtool: 'cheap-module-source-map',
    	entry:{
    		vendor: ["react", "react-redux", "react-router","react-dom","redux", "redux-thunk"]
    	},
    	output: {
    		path: config.path.base + '/statics/static/js',
            //filename: '[name]-[chunkhash:8].js',
            filename: '[name].js',
            //chunkFilename: "[id].bundle.js",
            publicPath: '/static/js',//config.server_host + ':'+ config.server_port + '/static/js',
            library:'[name]_library'
        },
    	plugins: [
	        new webpack.DefinePlugin({
	            "process.env": {
	            	'NODE_ENV' : JSON.stringify('development'),
	            	'__BROWSER__': JSON.stringify(true)
	            }
	        }),
            new webpack.DllPlugin({

		      path: path.join(__dirname, '/dist', '[name]-manifest.json'),

		      name: '[name]_library'
		    })
        ],
    };
    return {client:webpackConfig,vendor:venderWebpckConfig};
}

then i use the config by server rending with middleware, like this

if(__DEV__) {

  	let chokidar = require('chokidar');
  	let watcher = chokidar.watch(['./lib/server.js']);
  	let debugpath = require('path');
		watcher.on('ready', () => {
	  	watcher.on('all', (event, path) =>{
		    console.log("Clearing /server/ module cache from server");
		    console.log(event + ':' + path)
		    var fullPath = debugpath.resolve(__dirname, path);
		    if(require.cache[fullPath] && fullPath.endsWith('lib/server.js')) {
		    	console.log(`exist ${fullPath}`)
		    	delete require.cache[fullPath];

		    	require(fullPath);
		    }
	  	});
	});
    let webpackConfig = null;
    webpackConfig = require('./webpack.config.dev')(config);
    webpackConfig = webpackConfig.client;
    webpackConfig.plugins.push(
		new webpack.DllReferencePlugin({
		    	context: __dirname,
		    	manifest: require('./dist/vendor-manifest.json')
			})
		)
    const compiler = webpack(webpackConfig)
    app.use(webpackDevMiddleware(compiler, {
      stats: {
        color: true
      },
      inline:true,
      lazy:false,
      hot: true,
      noInfo: true,
      publicPath: webpackConfig.output.publicPath,
      headers: {'Access-Control-Allow-Origin': '*'},
      //contentBase: "http://" + config.server_host + ':' + config.server_port,
      quiet: true
    }))
    app.use(webpackHotMiddleware(compiler),{
    	heartbeat: 20 * 1000
    });
} else if(__PROD__){

    // we do nothing in prod envrioment
}

please help me to check the code , i really do not know how to resolve the problem, because if i refresh the full page by myself, it is meaningless  to hot reloading

and i also use module.hot in my client.js ,as below

//import 'babel-polyfill'   //这里先去掉这个，有babel-transform-runtime用来做转换的
import React from 'react'
import ReactDOM from 'react-dom'
import { Provider } from 'react-redux'
import {syncHistoryWithStore} from 'react-router-redux'
import {browserHistory,applyRouterMiddleware,Router} from 'react-router'
import useScroll from 'react-router-scroll'
import configureStore from './store/configureStore'
import routes from './routes'
const initialState = window.__INITIAL_DATA__
const store = configureStore(initialState)
const history = syncHistoryWithStore(browserHistory,store)
const rootElement = document.getElementById('app')
global.__SERVER__ = false ;

let render = () => {
	console.log('start to render')
	ReactDOM.render(
  		<Provider store={store} key="provider">
  			<Router history= {history}  render={applyRouterMiddleware(useScroll())}>
    			{routes}
    		</Router>
  		</Provider>,
  		rootElement
	)
};

if(module.hot) {
	let renderNormally = render;
	const renderException = (error) => {
		const RedBox = require('redbox-react');
		console.log(require('redbox-react'))
    	ReactDOM.render(<RedBox error={error}/>, rootElement);
	};

	render = () => {
		try{
			renderNormally();
		} catch(e) {
			renderException(e);
		}
	};
  	module.hot.accept('./routes', () => {
  		render();
  	});
}
window.Render = render;
render();

when source file changed ,i just re-render by then function render on client.js, and when file changed, the method accpet exectute, but the method render(),seems can not refresh the component

here i add transform for react by using react-hot-loader:
dev-wepack-config like this
var path = require('path')
var webpack = require('webpack')
var AssetsPlugin = require('assets-webpack-plugin')
var ExtractTextPlugin = require("extract-text-webpack-plugin");
module.exports = function(config){
    console.log('dev:',__dirname)
    var webpackConfig = {
        devtool: 'cheap-module-source-map',
        entry: {
            app:[
            	'react-hot-loader/patch',
                'webpack-hot-middleware/client?path=http://' + config.server_host + ':' + config.server_port + '/__webpack_hmr&timeout=20000&reload=true',
                './src/client/static/js/client.js'
            ]
        },
        output: {
            path: config.path.base + '/statics/static/js',
            //filename: '[name]-[chunkhash:8].js',
            filename: '[name].js',
            //chunkFilename: "[id].bundle.js",
            publicPath: '/static/js'//config.server_host + ':'+ config.server_port + '/static/js'
        },
        plugins: [
	        new webpack.DefinePlugin({
	            "process.env": {
	            	'NODE_ENV' : JSON.stringify('development'),
	            	'__BROWSER__': JSON.stringify(true)
	            }
	        }),
	        new ExtractTextPlugin("[name].css"),
        	new webpack.optimize.DedupePlugin(),// 优化的模块，不需要重复加载相同模块
            new webpack.optimize.OccurenceOrderPlugin(), //按照出现的顺序打包
            new webpack.HotModuleReplacementPlugin(), //热体验用的
            new webpack.NoErrorsPlugin()
        ],
        progress: true,
		resolve: {
			root: path.resolve('src'),
		    modulesDirectories: [
		      'node_modules'
		    ],
		    extensions: ['', '.json', '.js', '.jsx']
		},
		recordsPath: path.join(__dirname, 'console/_records.json'),

        //watch:true ,
        module: {
            loaders: [
              	{
	                test: /\.js$/,
	                loader: 'babel',
	                exclude: /node_modules/,
	                include: __dirname,
	                "env": {
						// only enable it when process.env.NODE_ENV is 'development' or undefined
						"development": {
							plugins: [ 'react-hot-loader/babel' ]
						}
					}
              	},{
				    test: /\.scss$/,
				    //loader: 'style!css?modules&importLoaders=2&sourceMap&localIdentName=[local]___[hash:base64:5]!autoprefixer?browsers=last 2 version!sass?outputStyle=expanded&sourceMap'
				    //loader: 'style!css?modules&importLoaders=2&sourceMap&localIdentName=[local]___[hash:base64:5]!sass?outputStyle=expanded&sourceMap'
				    //loader: 'style!css!sass?outputStyle=expanded&sourceMap' ,
				    loader: ExtractTextPlugin.extract("style-loader", "css-loader!sass-loader")

				}
            ]
        }
    }

    var venderWebpckConfig = {
    	devtool: 'cheap-module-source-map',
    	entry:{
    		vendor: ["react", "react-redux", "react-router","react-dom","redux", "redux-thunk"]
    	},
    	output: {
    		path: config.path.base + '/statics/static/js',
            //filename: '[name]-[chunkhash:8].js',
            filename: '[name].js',
            //chunkFilename: "[id].bundle.js",
            publicPath: '/static/js',//config.server_host + ':'+ config.server_port + '/static/js',
            library:'[name]_library'
        },
    	plugins: [
	        new webpack.DefinePlugin({
	            "process.env": {
	            	'NODE_ENV' : JSON.stringify('development'),
	            	'__BROWSER__': JSON.stringify(true)
	            }
	        }),
            new webpack.DllPlugin({

		      path: path.join(__dirname, '/dist', '[name]-manifest.json'),

		      name: '[name]_library'
		    })
        ],
    };
    return {client:webpackConfig,vendor:venderWebpckConfig};
}

but it seem to do not work

React Hot loader v3 is still a bit experimental. I suggest you try using https://github.com/gaearon/babel-plugin-react-transform which still works well.
The reason you're not seeing the update is likely because you're only re-rendering the root component after an update, and something is stopping the update from applying all the way down.

Closing, because hot-middleware is working correctly and the problem is in application setup.

ok，tks，i will try babel-plugin-react-transform， really tks

I'm looking into a similar behaviour with React Hot Loader v3. Top level components are are rendered on hot reload until we hit one that uses connect. Removing the DllReferencePlugin usage seems to solve the issue; hot loading works correctly with everything bundled in one set of webpack files.

Update: Keeping just the react-hot-loader package out of the dll (including it in the main app webpack instead) solved the problem for me.


Markdown files should ignore "Strip trailing spaces on save"

There is a "Strip trailing spaces on save" setting in Preferences->editor->others in PHPStorm 7.1.
I have set it up to "strip all trailing spaces on save", as this is the default condition I need for all the file types I work with, except for Markdown files.
Markdown uses 4 spaces to indicate a new line and being part of the language itself, the plugin should ignore any setting related to trailing spaces, or at least applies that filter only after the fourth space.

Using an .editorconfig file works for me.
[*.{md,markdown}]
trim_trailing_whitespace = false

Thanks @denofevil

This should be default beahvoure not a config i have to take with me to every computer and every project.

Installing PHPStorm EditorConfig plugin worked for me! :)
 [*.md]
trim_trailing_whitespace = false

@borisdiakur This works, But seems must install EditorConfig  plugin on phpstorm before it, as @felipsmartins said.


Dependencies and namespaces

Landed in https://github.com/metarhia/impress/commit/c31218574900e11a99f763080213c30a21597fea and https://github.com/metarhia/impress/commit/27485213a82bf384c76a7db84894d72a69b16bd7


No Ubuntu font for Ubuntu?

Thanks for the great framework!
I'm building a site on Ubuntu and see that the default system font stack doesn't include "Ubuntu" font family, so it falls back to sans serif font.
I'd suggest adding Ubuntu font in the default system font stack to make it display beautifully on Ubuntu.

What browser (navigator.userAgent) and OS version are you using?
For me, Chrome renders Ubuntu while Firefox renders Arial.
Ubuntu 18.04.4, Chrome 80, Firefox 74

I'm using Firefox 69, Ubuntu 19.10 and it shows Arial. In the font list here, I don't see "Ubuntu" listed.

I think this is probably the desired effect on Firefox, as per this bug report https://bugzilla.mozilla.org/show_bug.cgi?id=1469122
The closing comment that "resolved" the issue has this image: https://snipboard.io/1VfKwE.jpg
You can see that they acknowledge the difference between Chrome and Firefox, but doesn't seem to care:

So, I don't think there is a bug here, just normal differences between defaults on different platforms and browsers

But, I think we reached another point: when was Arial added to Ubuntu? Every mention to it that I found is from people asking how to add it, because, until today, I always thought it was a Microsoft font.
I will try this later, but I think that bringing "Noto Sans" (the default in most Linux systems I think) before Arial, would solve this, because the current rule assumes that Arial is not a Linux font.

@evenfrost I think you misunderstood. I didn't mean the font Arial is displayed differently on Chrome and Firefox on Ubuntu. I mean the font family declaration doesn't include the "Ubuntu" font (Ubuntu is a name of a font family).
The font stack for now is:
font-family: system-ui, -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, "Noto Sans", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";

which doesn't include "Ubuntu" font. So it falls back to "Arial", which is not what I want.
I'd suggest changing it to:
font-family: system-ui, -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Ubuntu, Arial, "Noto Sans", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";

I actually understood it right (and you tagged somebody else).
Just to make it clear, I'm trying to understand the bigger picture instead of just diving into adding a font that is used in only one distro.
I don't know any other Linux distro that packs Ubuntu, and the few that tried, realised it's a non-free font: Fedora and Debian.
That was my point.
Now I realised it's part of a bigger problem, probably introduced with https://github.com/tailwindcss/tailwindcss/pull/1326
Firefox does not support system-ui (Can I Use), while Chromium browsers do (that's why you see Ubuntu applied, not because it falls back to sans-serif). Without system-ui, you would be seeing Arial on both browsers on Ubuntu. (that's what Github and others are doing)
One of the points in the PR was

Never having to update the string again

So I see 3 options that only @adamwathan can solve: remove system-ui so every browser can fallback to a common font (not only Ubuntu the OS), add Ubuntu before Arial or leave it as it is?
My preference is to remove system-ui, which would make everything look the same. But more importantly, I think the OP https://github.com/tailwindcss/tailwindcss/pull/1326 really misinterpreted and oversimplified the issue with chinese/japanese characters.

the font they look at all day in that operating system.

The OP says as if they were looking at the same native text, while the problem is that the font their system renders chinese/japanese is used to render english text. It's about looking at the same font, applied to the wrong language.

Thanks for the clarification. It's very useful to understand the system-ui between browsers.

No plans to change this currently, but you can of course customize your font stack easily using your tailwind.config.js file 👍


Create a new pull request by comparing changes across

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

12 of 12 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.09%) to 95.658%

Totals

Change from base Build<PHONE_NUMBER>:
0.09%

Covered Lines:
1976

Relevant Lines:
2027

💛  - Coveralls


make it thread-safe

replacing all instances of Rc with Arc allows references to the battery manager to exist while communicating with other threads. see also:
https://users.rust-lang.org/t/tokio-std-mpsc-future-cannot-be-sent-between-threads-safely & https://gitlab.com/thomas351/rust-influxdb-udp-logger/-/blob/main/src/main.rs#L284

The CI (1.51.0, x86_64-apple-darwin) build seems to fail independent of my changes, problem seems to have started sometime after 2022-10-17 (when the last successful build happened) and before 2022-11-08 (the next build that was tried) and seems to be caused by some change lying outside your repository, since various independent changes lead to the same CI build error.

The test failure is likely happening because of a caching issue, please try also pulling in 4abc2434a26d19d76ca33227685dc434a33b5133.

Send trait would be awesome!!