[RSGroup] Forward-port HBASE-22658 to master branch and branch-2.x

JIRA link: https://issues.apache.org/jira/browse/HBASE-22740

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
7m  3s
the patch passed

+1 :green_heart:
compile
1m 13s
the patch passed

+1 :green_heart:
javac
1m 13s
the patch passed

-1 :x:
shadedjars
0m  9s
patch has 7 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 41s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
102m 54s
hbase-server in the patch passed.

124m 43s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1326/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1326

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f79b09ada8d5 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master /<PHONE_NUMBER>

Default Java
2020-01-14

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1326/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1326/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1326/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1326/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1326/1/testReport/

Max. process+thread count
4400 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1326/1/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


ttl parser failure for trivial case

parse.ttl:
""^^_:datatype a _:something .

parse it
In [1]: import pyoxigraph as og

In [2]: list(og.parse(open('parse.ttl'), 'text/turtle'))
Traceback (most recent call last):

  Cell In[2], line 1
    list(og.parse(open('parse.ttl'), 'text/turtle'))

  File <string>
SyntaxError: unexpected character '\"' on line 2 at position 1

In [3]: og.__version__
Out[3]: '0.3.20'

rdflib parses it.

oh...this is illegal rdf. rdflib is being permissive for some reason.


Other: Refactor site to move static sections out of the versioned /docs/ tree

Issue Summary
Really we should only version the "Standard" and "Deployment Best Practices" sections. Currently we have seperate versions for the "Learn More/* sections. Users should always be pointed to the latest version of these documents. They should be static and not part of the versioned docs components.
My expectation is that the Learn more section should not be versioned, and be found at the following URL tree...
https://uptane.github.io/learn-more
Details
No response
Priority Level
No response
Proposed Solution (if any)
No response
Related Information
No response
Additional Comments
No response

we need to use multi-instance for this : https://docusaurus.io/docs/docs-multi-instance#versioned-and-unversioned-doc,  I will look into this after v3 migration


Unable to see Azure Device Update Groups in IoT Hub

I followed this procedure  I manually prepared my VM
I added a tag for ADUGroup to my edge device in the Device Twin and in the  IoTHubDeviceUpdate module Twin (because it was not clear to me to which I had to):
'tags': {
'ADUGroup': 'gerryTest'
}

When I try to create a Group in Device Updates - Groups the tag is not present, in fact NO TAGS are available in the drop down at all.

UPDATE:
I tried using the "Deploy to Azure" Button and it worked!!, after I checked what was the difference, I noticed that the template used for creating the VM has these commands:
    apt install -y deviceupdate-agent
    apt install -y deliveryoptimization-plugin-apt
    systemctl restart adu-agent

I believe the trick is done by restart adu-agent before tag the device! that instruction is not referenced in the manually procedure, please confirm, if it is the case please add to the documentation

Using 0.8.0 release and connecting as module from my host, can't for the life of me get the ADUGroup tag to trigger any changes in the "Create Group" dropdown in IoTHub portal.

Yes, the agent needs to connect before setting the ADUGroup tag.
Can set ADUGroup to null in the twin and then restart via sudo systemctl restart adu-agent to resolve it.
Once you see it is connected in the twin, then add the ADUGroup tag.
Then you should be able to see the group available when adding a group.
@esha0611 Could you include this in relevant ms docs? I'll update the .md


Receptor feature extraction not defined to be parcellation-sensitive

The ReceptorQuery class caches extracted feature in a class instance list to avoid redundant queries for different parcellations  / region selections (since object construction of the extractor happens for every feature query). However, during the loading process, region names are decoded with the parcellation of the first object constructed. This can lead to problems if a query with a new extractor object which has a different parcellation defining the same region is called later on, for example, a different version of the same parcellation.

What I suggest is the following solution for RegionFeatures:

load the data only once, then generate feature objects without decoding the region name - just keep the region specification (typically a string)
add a _decoded_regions dictionary to the RegionFeature class, which is indexed by the parcellation used.
Whenever a feature extractor is constructed, go through the already loaded features, check if the regionname had already been decoded by the current parcellation (by looking at the keys of _decoded_regions), and decode only if necessary.

This is solved since GH-82


Add the genesis block from within the Ledger

It's not correct to add it within the BlockStorage, because then we lose track whether the block was just added, or if it was loaded from disk. The difference is important, because the Ledger keeps track of UTXOs based on newly-added blocks to the ledger (and the serialized UTXO on disk).
Required for https://github.com/bpfkorea/agora/pull/194

Thank you!

Not a fan of this to be honest. The isEmpty method seems to be single-purpose. After initialization, it will always return true, which is a red flag.
The two options I can think of is:

Hard-error if the storage was not previously initialized and force the user to call an init method. This is less user friendly, interacts badly with tests, but is more configurable.
Provide a delegate that is called on first initialization.

Yes I agree. Let's go with the second option. Maybe we can come up with something better later.


add maxvit model

Signed-off-by: xujinling<EMAIL_ADDRESS>

Codecov Report

Merging #1547 (22d4222) into main (89f49a9) will increase coverage by 0.04%.
The diff coverage is 84.82%.

@@            Coverage Diff             @@
##             main    #1547      +/-   ##
==========================================
+ Coverage   70.03%   70.07%   +0.04%
==========================================
  Files         351      358       +7
  Lines       20535    20650     +115
  Branches     3301     3318      +17
==========================================
+ Hits        14381    14471      +90
- Misses       5245     5265      +20
- Partials      909      914       +5

Impacted Files
Coverage Δ

towhee/models/max_vit/max_vit.py
64.51% <64.51%> (ø)

towhee/models/layers/mbconv.py
86.95% <100.00%> (+4.34%)
:arrow_up:

towhee/models/layers/relative_self_attention.py
100.00% <100.00%> (ø)

towhee/models/max_vit/__init__.py
100.00% <100.00%> (ø)

towhee/models/max_vit/configs.py
100.00% <100.00%> (ø)

towhee/models/max_vit/max_vit_block.py
100.00% <100.00%> (ø)

towhee/models/max_vit/max_vit_stage.py
100.00% <100.00%> (ø)

towhee/models/max_vit/max_vit_utils.py
100.00% <100.00%> (ø)

towhee/models/utils/gelu_ignore_parameters.py
100.00% <100.00%> (ø)

towhee/models/utils/get_relative_position_index.py
100.00% <100.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89f49a9...22d4222. Read the comment docs.


Mnemonic - Use SLP validator

Use the validator in bitbox, get error message from it also

fixed in #37


az aks nodepool add --os-sku Windows20XX w/o --os-type fails with confusing error message

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az aks nodepool add
Errors:
(InvalidOSSKU) OSSKU='Windows2019' is invalid, details: Unrecognized OSSKU
Code: InvalidOSSKU
Message: OSSKU='Windows2019' is invalid, details: Unrecognized OSSKU

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Prepare an AKS cluster
az aks nodepool add -g {} --cluster-name {} --os-sku Windows2019 -n {}  (w/o --os-type Windows)

Expected Behavior
You will say it lacks --os-type Windows, however it isn't obvious from the error message.
It will be better to assume --os-type :Windows automatically and succeeds, or at least indicates that OSSKU 'Windows2019' is invalid for os-type: Linux
Environment Summary
Linux-5.4.0-1098-azure-x86_64-with-glibc2.35 (Cloud Shell), CBL-Mariner/Linux
Python 3.9.14
Installer: RPM

azure-cli 2.43.0

Extensions:
ai-examples 0.2.5
ml 2.11.0
ssh 1.1.3

Dependencies:
msal 1.20.0
azure-mgmt-resource 21.1.0b1

Additional Context
It seems azure cli sends REST API request with osType: Linux (simply using the default value) and outputs the error message just given from ARM.

route to CXP team

@atakadams  Thanks for your feedback.  I have submitted a PR for the same and it will be merged once approved. Thanks again for pointing this out, I am closing the issue based on this update, please let us know if there is something else that we can help you with.


Live search todos

Input field that live filters todos listed in table.

@mrodalgaard Was this feature lost in recent versions? I see the "Search Todos" input field in your screenshot in README.md https://raw.githubusercontent.com/mrodalgaard/atom-todo-show/master/screenshots/preview.png
But I don't see it in my Atom :-( I have version 2.3.2 of the package.

@ThomasLandauer; yes. Unfortunately there was a bug that made a system error on Atom in certain cases, so I had to remove it temporary until I have the time to create a fix. See #198

For anybody needing the search functionality: https://atom.io/packages/todo supports it


What languages are supported?

The site is extremely unclear. Is it limited to C#, VB, C++, Python, and in the pairs listed, or are those just examples?

Hello @Zireael07 ,
That is a textbox; you can type anything. So there is no limit.
Well, in fact, the language limit is what the current AI knows (which we currently use OpenAI).
Let me know if that answers your question.
Best Regards,
Jon

No, it doesn't answer my question.
What programming languages does OpenAI work with?

Hello @Zireael07 ,
OpenAI works with pretty much any language. You can even ask to OpenAI itself this question: https://zzzcode.ai/answer-question?id=ddcebddb-1271-47f0-b679-021257511493
Best Regards,
Jon


Re-open iamgroot's pull request after fixing the previously broken build

@iamgroot42 Can you comment saying that you are OK with your commits being contributed to this project?

@goodfeli I am okay with my commits being contributed to the project.

@goodfeli  the build failed, this time for one of the PyTorch based models. Is the rng not fixed for these test?

The tests failed but this time it was only one job. I think it was a flaky test.

I'm not very familiar with those tests, but in a lot of cases there is
stochasticity even for a fixed RNG because different threads inside of
individual ops can schedule with different orders and get different
numerical rounding error.
On Fri, Oct 5, 2018 at 10:54 AM, Anshuman Suri<EMAIL_ADDRESS>wrote:

@goodfeli https://github.com/goodfeli the build failed, this time for
one of the PyTorch based models. Is the rng not fixed for these test?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/cleverhans/pull/727#issuecomment-427448112,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAXrGs2jBAG805DmHRgJUqDNrIAeQpfUks5uh5zIgaJpZM4XKmZv
.


🕵 Review Analytics Platform Ops repository

User Story
Follow on from https://github.com/ministryofjustice/data-platform/issues/536
As a DevOps/Platform engineer, I want all infrastructure code to be usable and up-to-date
User Type(s)
DevOps/Platform engineers
Value
healthy and maintainable infrastruce-as-code
Proposal
Review code in https://github.com/ministryofjustice/analytics-platform-ops, try and get access to git-crypt, see if you can get it to plan
Definition of done

[ ] Access to git-crypt
[ ] Able to plan

Reference
How to write good user stories

@jacobwoffenden to update

We're moving the repo into Data Platform, so it will be reviewed as part of that. Issue raised as #2137


Defense FeedBack

What does this PR do?

Implements feedback from my first cp defence with Mark

Description of Task to be completed?

Fix Search input
Fix NavBar
Write Client Test
Reduce the number of action files

Coverage decreased (-0.2%) to 79.417% when pulling dc0d92f78df692a3a7669bffae594f4f5746f0e8 on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage decreased (-0.2%) to 79.417% when pulling b53275c50e727b3e32200cc29397fed11d732f6a on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage decreased (-0.2%) to 79.417% when pulling 7966e75a98318c07c4e3a4229ee95cd6904a6f45 on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage decreased (-0.2%) to 79.417% when pulling 890d539998e2252eb24bfd9a45e589dcb98e52f1 on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage decreased (-0.2%) to 79.417% when pulling 74cf28252fdb88a8879403e8d67a774e731105c4 on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage decreased (-0.2%) to 79.417% when pulling d5b4411bfbf6cb22c24fc9279eb435608b303920 on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage decreased (-0.2%) to 79.417% when pulling 5ec2cec35358b59cdc438a91837690ff716ed4f2 on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage decreased (-0.2%) to 79.417% when pulling 7c077af621035001699600c0b5628bb78f0d7d45 on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage decreased (-0.2%) to 79.417% when pulling 7cfb0b35bcedcbe81b25034442a127237ab05ce1 on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage decreased (-0.2%) to 79.417% when pulling 4bdd7662d5ac74c85a138873096d3932c9e51319 on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage decreased (-0.2%) to 79.417% when pulling e1644fe6cfe60b47e6f3192cd2dfffe19a87d4c2 on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage decreased (-0.2%) to 79.417% when pulling 67cf01b370a607f3d9b154029dcafa3b40c29a2d on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage decreased (-0.2%) to 79.417% when pulling 7a69a30986fa4be7eda15c75ff6f7c93a0051c58 on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage increased (+0.8%) to 80.389% when pulling 2eacd0b7929150225f6624d073996a92124cc2b2 on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage increased (+0.8%) to 80.389% when pulling 31cf259b6dba9f1573e63c22bd7fab6b6314e974 on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage increased (+0.8%) to 80.389% when pulling 3ad12222bfec071c13cd9eb96efadb627c6327ed on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage increased (+0.8%) to 80.389% when pulling 00d6bfbd4f3b6cf2f85c1c53e9f58e60186b3ed0 on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage increased (+0.8%) to 80.389% when pulling 04803e008b6aef1e40c7e63466a486721b64275b on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage increased (+0.8%) to 80.389% when pulling db0f3c055b8522bd1834a7eed3d99d18e6e7f409 on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage increased (+0.8%) to 80.389% when pulling 64684b8e893425ff8758b0e0812aa5f3080b9136 on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage increased (+0.9%) to 80.519% when pulling 93fb0d2ae4ac3fb27fd281066d43db071006624a on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage increased (+0.9%) to 80.519% when pulling d57df7cff3c61b6f799f81c459a036e787c11fc9 on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Coverage increased (+2.3%) to 81.954% when pulling 66c8539bbc6b1a83e57435489970c364dd98259b on development into 596e0c84db6bd62dbd1d2ff27f12148c88053140 on master.

Changes Unknown when pulling 23eb0b879798db37d7094c5a1f370e93cae99943 on development into ** on master**.

Changes Unknown when pulling 23eb0b879798db37d7094c5a1f370e93cae99943 on development into ** on master**.

Changes Unknown when pulling 84500c85e743b1f24d0cbfe224afc8f679473771 on development into ** on master**.

Changes Unknown when pulling cc19c2523449aa31cf6758c89d6b108a6f032e9a on development into ** on master**.


Release tutorial along with API docs to GH pages

We should release the tutorial at a specific version and not via our repository so that people don't get confused. We can put them next to the API docs on GH pages.
Releasing them can go along with releasing the playground/API docs.

This would also be a good target for the "Tutorial" and "API" links in the Playground

We did this by deploying the docs along with the playground.


Using the Web GUI's "Select Distinct" function results in an error.

If you use "Select Distinct Values" in the Web GUI, it results in the table no longer displaying properly.

Create a table, and use the Web GUI to "Select Distinct Values". For instance, this table:
from deephaven import read_csv

seattle_weather = read_csv("https://media.githubusercontent.com/media/deephaven/examples/main/GSOD/csv/seattle.csv")

The error message in the table is Error: java.lang.AssertionError: realized table is closed, expected status DONE, instead is ACTIVE.

Expected results

Actual results

Additional details and attachments

Versions

Engine Version: latest
Web UI Version: latest
Java Version: 11
Barrage Version: Unsure
OS: OS X Monterey
Browser: Chrome
Docker: 20.10.13

Looks like it's tripping when we try and get the table size:

We remove all listeners when we're setting the table to the next model: https://github.dev/deephaven/web-client-ui/blob/main/packages/iris-grid/src/IrisGridProxyModel.ts#L146
Removing all listeners closes the table; would be nice if the table.size didn't throw and instead gave the previous size, but in any case we can hold off on removing the listeners until the next model resolves, which is probably more correct anyway.

Digging into it further, it looks like the problem is a race condition in TableViewportSubscription. Specifically, the subscription can be closed before the copied table is realized, which causes TableViewportSubscription to initialize after it's already been closed. Will have a fix shortly.


Several different classes

Greetings! Thanks for great work
I would like to clarify, if I have a dataset with several different classes in it - how is it possible to modify your framework, so it can do segmentation and polygonization for all of them?

Same problem.Have you solved it yet？

Same problem.Have you solved it yet?


Cannot install FluentFTP into a PCL project

Hi,
I'm trying to use FluentFTP in my PCL project with .net 4.5 and profile 111.
I got this error:

PM> Install-Package FluentFTP
Attempting to gather dependency information for package 'FluentFTP.16.2.1'
with respect to project 'ABCD', targeting '.NETPortable,Version=v4.5
,Profile=Profile111'
Attempting to resolve dependencies for package 'FluentFTP.16.2.1' with
DependencyBehavior 'Lowest'
Resolving actions to install package 'FluentFTP.16.2.1'
Resolved actions to install package 'FluentFTP.16.2.1'
GET https://api.nuget.org/packages/fluentftp.16.2.1.nupkg
OK https://api.nuget.org/packages/fluentftp.16.2.1.nupkg 145ms
Installing FluentFTP 16.2.1.
Adding package 'FluentFTP.16.2.1' to folder 'D:\abcd\packages'
Added package 'FluentFTP.16.2.1' to folder 'D:\abcd\packages'
Install failed. Rolling back...
Package 'FluentFTP.16.2.1' does not exist in project 'ABCD'
Removing package 'FluentFTP.16.2.1' from folder 'D:\abcd\packages'
Removed package 'FluentFTP.16.2.1' from folder 'D:\abcd\packages'
Install-Package : Failed to add reference to 'System.Web'. Please make sure
that it is in the Global Assembly Cache.
At line:1 char:1

Install-Package FluentFTP

 + CategoryInfo          : NotSpecified: (:) [Install-Package], Exception
 + FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.

PackageManagement.PowerShellCmdlets.InstallPackageCommand

The reason it failed to add reference to 'System.Web' is because System.Web cannot be added into a PCL project.
I'm not sure if this is an issue or not, do we have a workaround?

Actually I tried building for PCL but PCL does not contain the Socket class. Maybe if we can use this library we can target the PCL framework.

I've finally got VS 2015 community installed and I'm investigating a PCL version. Stay tuned! Shoutback if you want to help!

Due to lacking Socket support in PCL, we cannot release FluentFTP on PCL.


Analyzer checks overriding between superclass and superinterface incorrectly.

DART version: 2.2.1-dev-1.1
OS: Windows 10 64 bit
This bug is similar with #34392 which was fixed some time ago.
Here is a source code example:
abstract class I { foo(a) {} }

abstract class A { foo() {} }
abstract class B { another() {} }

abstract class C extends A implements I {}    // compile error here
abstract class D extends B implements I {}    // no error here

main() {}

Analyzer throws a compile error for the line #6 and passes with the line #7:

Analyzing test.dart...
error - Superinterfaces don't have a valid override for 'foo': I.foo ((dynamic) → dynamic), A.foo (() → dynamic) at test.dart:6:16 - inconsistent_inheritance
1 error found.

Seems like it should pass in both cases.
Please note that #34392 source example passes with the recent dart versions.
If I run my test with dart, it passes as well.

This is working as intended.
You need to say foo([a]) in I in order to make that signature more specific than A.foo. Otherwise you just have two incomparable signatures for foo in the superinterfaces of C, and that's an error of the declaration of C when C doesn't declare a foo.
Alternatively, if you add the declaration foo([a]); to the body of C then that declaration is a correct override of both A.foo and I.foo, and there is no error.

I tested this with 2.2.1-dev-1.1 and dart passed for me.
So, seems like it's fixed in the next release.

I get the same response (error on line 6) from dart version 2.2.1-dev.1.1 as I did for the other versions (older and newer than that), which is also the response we should get, and also the response that we get from dartanalyzer.
But I'm not quite sure what you mean by 'it passed for me'. Do you mean that you have a version of dart that does not report an error for line 6? That would be a bug, but I can't recreate that behavior.

Sorry for inaccuracy! Dart report compile error on the line 6 too, so if it's expected this bug can be closed.

Yep, that error is expected. Thanks!

@eernstg – is there a bug here? For whom? Otherwise, please close! 😄


Double click to select code.

I put forward the feeling of using it：
Double click to select code.
The background color of the same code is too shallow.
The same code has no hint on the right-hand sidebar.

Thanks for reaching out!
Please use the issue template as much as possible when opening issues, the information in the template is very helpful for us when triaging issues.
Can you share a screenshot of what you're describing?
Also, what version of Atom are you running (atom -v) and what operating system?

We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us half way :grinning:

this
You can't comment at this time — your comment cannot be blank.

https://upload-images.jianshu.io/upload_images/5141942-01ffa74ede6b46b9.png?imageMogr2/auto-orient/strip|imageView2/2/w/1240

@Kole6 Ohh.. I see. That is not supported by default, but you might can add it by installing https://atom.io/packages/minimap and maybe also https://atom.io/packages/minimap-highlight-selected.


Fixes CacheReaderTest.

CacheReaderTest needed to use a temporary cache directory that copies over the contents of the test resource cache directory because it is overwriting the metadata JSON file in there.

looks like you need to run the formatter on this.


Appstudio update test-component-pac-wdrb

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-wdrb-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
18 seconds
clone-repository

✅ Succeeded
33 seconds
build-container

✅ Succeeded
15 seconds
deprecated-base-image-check

✅ Succeeded
21 seconds
inspect-image

✅ Succeeded
35 seconds
clamav-scan

✅ Succeeded
16 seconds
clair-scan

✅ Succeeded
12 seconds
sbom-json-check

✅ Succeeded
13 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
8 seconds
show-summary


Enable CSS Support for Component-Level Styles

My component is generated dynamically based on the user selection, therefore,
I would like to enable CSS Support for Component-Level Styles instead of CSS Module Support.
Is it possible to do this in next-plugin-antd-less?
Thanks.

you can see:
https://github.com/SolidZORO/mkn/blob/5fd9609230532978600ec8a7d4113ca3b9f3a5f7/src/page-components/test/Test/Test.tsx#L9-L25


transcode H264 file too slow

When I decode an h264 file with a resolution of 1920*1080, it takes about 10 seconds.
...
          await ffmpeg.write('test.h264', event.data);
          const s = new Date().getTime()
          await ffmpeg.transcode('test.h264', 'uui.yuv', '-s 1920x1080');
          console.log(new Date().getTime() - s);
...
log：
16304

My device:

My brower：
Chrome 84.0.4147.105

me too

With latest version (0.9.3), x264 comes with better support for multi-threading, please try and see if there is any improvement. If the performance is sitll not satisfied your requirement, maybe it is better to use the native C/C++ version.


Bug Fixes and Style Updates

This pull request includes bug fixes and style updates for the repository. The changes made in this pull request address the following issues:
🎨 style(index.css): update color variables for chat bot and user icon
The color variables for the chat bot and user icons have been updated in the index.css file to improve the visual appearance.
🔧 chore(constants.tsx): add constant MAX_WORDS_HIGHLIGHT with a value
🐛 fix(index.css): swap colors for chat bot and chat user icons to match design

Bugs:

[ ] Human message disappears if the chat is closed and reopened
[ ] When importing a flow the edges are not being updated to the new style

Tested previous bugs and none of them persists.


layouts/error.vue should behave like any other page

What problem does this feature solve?
IMHO it would be a very good idea to refactor how errors are handled in Nuxt.
The current structure: error.vue should be treated as a page but is located in /layouts is confusing and doesn't allow any serious custom functionality.
The error.vue page component should definitely be treated like any other page located in /pages, which would give it their own route name/path and enable us to use for instance middlewares, which has been mentioned in bug reports already.
My current situation: When using nuxt-i18n, specifically using switchLocalePath nothing happens.
That is because getRouteName returns null, because layouts/error.vue is not a real standard page.
I think lots of developers would be glad if the error.vue page were implemented and handled as any other page.

Hi :)
I think it’s a good idea to moove error.vue into pages and not into the layout.
Could you add a reproduction of your context ?
Then i will try to purpose a PR for this improvment.
Thanks 😀

We've taken a different approach for error.vue so I believe this issue can be closed. Any future suggestions would be welcome, however.


No MWS Auth Token

Hi
I have my own account and not a developer account and hence i don't have MWS Auth token, so i leave this field blank but i am getting the following error which using this lib:
error  { Type: 'Sender',
Code: 'AccessDenied',
Message: 'Access denied',
RequestId: 'afa979de-7684-4a53-b19d-9a9c5ecd97cd' }
Please suggest how to resolve?
thanks

This Is specifically developed for the developer account. It will work only
if you have the developer account.
On Sun 24 Dec, 2017, 12:07 PM Abhishek Jain<EMAIL_ADDRESS>wrote:

Hi
I have my own account and not a developer account and hence i don't have
MWS Auth token, so i leave this field blank but i am getting the following
error which using this lib:
error { Type: 'Sender',
Code: 'AccessDenied',
Message: 'Access denied',
RequestId: 'afa979de-7684-4a53-b19d-9a9c5ecd97cd' }
Please suggest how to resolve?
thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bhushankumarl/amazon-mws/issues/8, or mute the thread
https://github.com/notifications/unsubscribe-auth/AK3gCiC8ebbh7zgnz-d9fz1XgDq9JZe_ks5tDfElgaJpZM4RL2Y9
.

Hi
I realized it is working for Amazon US but not for European account as the
host is defaulted to us url.
Thanks
Abhishek
On Sun, 24 Dec 2017 at 4:54 PM, Bhushankumar Lilapara <
<EMAIL_ADDRESS>wrote:

This Is specifically developed for the developer account. It will work only
if you have the developer account.
On Sun 24 Dec, 2017, 12:07 PM Abhishek Jain<EMAIL_ADDRESS>wrote:

Hi
I have my own account and not a developer account and hence i don't have
MWS Auth token, so i leave this field blank but i am getting the
following
error which using this lib:
error { Type: 'Sender',
Code: 'AccessDenied',
Message: 'Access denied',
RequestId: 'afa979de-7684-4a53-b19d-9a9c5ecd97cd' }
Please suggest how to resolve?
thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bhushankumarl/amazon-mws/issues/8, or mute the
thread
<
https://github.com/notifications/unsubscribe-auth/AK3gCiC8ebbh7zgnz-d9fz1XgDq9JZe_ks5tDfElgaJpZM4RL2Y9
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bhushankumarl/amazon-mws/issues/8#issuecomment-353779006,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABP7PBWw7mMWbiv2pdeznH3bn56gfjMQks5tDjRUgaJpZM4RL2Y9
.

--
Thanks and kind Regards,
Abhishek jain
+91<PHONE_NUMBER>

This API would not work based on the Region. It's independent of it.
Thr Host URL is common for all. Kindly check below link to trace out
actually problem.
http://docs.developer.amazonservices.com/en_IN/dev_guide/DG_IfNew.html
This will help you to find the required parameters for your request.
On Sun 24 Dec, 2017, 4:56 PM Abhishek Jain<EMAIL_ADDRESS>wrote:

Hi
I realized it is working for Amazon US but not for European account as the
host is defaulted to us url.
Thanks
Abhishek
On Sun, 24 Dec 2017 at 4:54 PM, Bhushankumar Lilapara <
<EMAIL_ADDRESS>wrote:

This Is specifically developed for the developer account. It will work
only
if you have the developer account.
On Sun 24 Dec, 2017, 12:07 PM Abhishek Jain<EMAIL_ADDRESS>wrote:

Hi
I have my own account and not a developer account and hence i don't
have
MWS Auth token, so i leave this field blank but i am getting the
following
error which using this lib:
error { Type: 'Sender',
Code: 'AccessDenied',
Message: 'Access denied',
RequestId: 'afa979de-7684-4a53-b19d-9a9c5ecd97cd' }
Please suggest how to resolve?
thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bhushankumarl/amazon-mws/issues/8, or mute the
thread
<

https://github.com/notifications/unsubscribe-auth/AK3gCiC8ebbh7zgnz-d9fz1XgDq9JZe_ks5tDfElgaJpZM4RL2Y9

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/bhushankumarl/amazon-mws/issues/8#issuecomment-353779006
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ABP7PBWw7mMWbiv2pdeznH3bn56gfjMQks5tDjRUgaJpZM4RL2Y9
.

--
Thanks and kind Regards,
Abhishek jain
+91<PHONE_NUMBER>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bhushankumarl/amazon-mws/issues/8#issuecomment-353779097,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AK3gCuObL3N8g7-VYv7sVQKjDOo4330aks5tDjTRgaJpZM4RL2Y9
.

Here is your required detail.

Thanks, works perfectly, for this call,


String operators (contains, startsWith, endswith) should be working on number columns

Problem
The string operators contains, startsWith and endsWith only works on string columns.
I think that should work with numbers too.
Suggested solution
I think the string operators should automatically convert the number column to string to do the comparison (but still returns the column as a number)
// Id column is of type number here.  Table contains a lot of data with Id like 265698, 445268, 2132126, and I think they should be retrieved with the following statement
prisma.myTable.findMany(
{
    where: {  Id: { contains: "26" }
});

Alternatives
An alternative could be to add a transform operation to the filter expression where we could add a number column casted as another type :
Something like that maybe (I understand that could cause problem with "idString" not existing in the model.  this is just some kind of an alternative idea)
prisma.myTable.findMany(
{
    transform: {
            {
                Id: {
                    cast: "string",
                    alias: "idString"
                }
            }
    }
    where: {  "idString": { contains: "26" }
});

Additional context
This is critical for me since we are using paging for all our requests to our service and the filtering must absolutely happend on the server.  In addition to that we have many thousands of rows into each tables, no way we can filter the data after fetching all of it.

This feature would also help on the project I'm working on.
We use a pagination with a filtering system, with one filter is on a specific number value that can be negative.
When the user types "-" to get a filter on "all negative values", wish I could filter on "all elements whose field value starts with '-' "

You can just use { where: { value: { lt: 0 }} for the - case, that way indexes will still work even, Converting to string seems unnecessary.


Vulnerabilities in Cloudwatch image

Scanning fluent/fluentd-kubernetes-daemonset:v1.11-debian-cloudwatch-1 with Twistlock reports the following vulnerabilities.
HIGH VULNERABILITIES: 10
MEDIUM VULNERABILITIES: 13
CVE-2019-19770, CVE-2018-12886, CVE-2020-11725, CVE-2019-19814, CVE-2019-19449, CVE-2019-19378, CVE-2019-19377, CVE-2020-25211, "Private keys stored in image"
We were wondering if there are any plans on upgrading?
Thanks

We use ruby:2.6-slim-buster for base image: https://github.com/fluent/fluentd-docker-image/blob/master/v1.11/debian/Dockerfile#L4
I want to know debian buster itself has this problem or not.

Hey @repeatedly , we ran a scan on ruby:2.6-slim-buster and you are correct the vulnerabilities are coming from the base image.
https://github.com/docker-library/ruby/issues/329


Incorrect directory separators under windows.

This is a great package, but had to make a few small tweaks to get it working under my windows machine.
There were 2 places in the code that are checking a regex against a filepath, however on windows my filepaths have backslashes instead of forward slashes causing the regex to fail to match.
For example in PathResolver.php getRealPath returns on my machine:
C:\path\to\www\app\vendor\package\file.php
instead of the expected
C:/path/to/www/app/vendor/package/file.php
to workaround this issue I simply changed any calls to $fileInfo->getRealPath() to str_replace('\\', '/', $fileInfo->getRealPath()) in the following files:

PathResolver.php
PatchDiffer.php

I can submit a pull request with this fix if you'd like?

Hi, thanks for reporting :+1:

I can submit a pull request with this fix if you'd like?

That would be best :)

JFYI https://symfony.com/doc/current/components/filesystem.html#path-manipulation-utilities ;)
I actually submitted a PR to symfony regarding this (which is why I know it exists in the first place), but in the end this was a superior implementation. It also takes care about some of the edge-cases.

I encountered the same issue ln52 of PatchDiffer and the solution proposed by @BARNZ worked a treat there as well.
@BARNZ can you confirm and if so can you roll the PatchDiffer alteration up into your PR please?


gift cards controller won't save if order doesn't already have shipping address etc

Was running into a problem with the gift_cards_controller rejecting the attempt to add a new line item.
I swapped out the code to use nested attributes and spree's order.contents.add function.
Happy to make a PR or link to commit =)

@joeswann Can you please elaborate the problem faced with steps to reproduce ?
PR for the fix would be great :+1:


Capturing stdout with slurm

We've been running our experiments with the slurm scheduler which captures stdout and stdin and pipes them to a file. This seems to confuse sacred, which doesn't capture stdout in this case.
Easiest solution by far would be just telling sacred where to look for stdout. Is there a way to do that?
Thanks!
A

That is an interesting case I hadn't thought about. So far this is not possible, no. If you are fine with only capturing stdout from within python, you could try to set the capture mode to sys. My guess is that this wouldn't be affected by stdout redirects:
from sacred.settings import SETTINGS
SETTINGS.CAPTURE_MODE = 'sys'

But I'll mark this as a feature request nonetheless.

This worked just fine! Thanks!

Hi @Qwlouse ,
I define my logger based on python's logging module. I can see my logger's console output and file output, but I cannot see the output in sacredboard's captured output. Maybe that's a sacredboard issue?
Otherwise, it might have to do with the fact that I setup the logger, after I start the experiment since I want to associate the logger's file path on the run's id.

Ohh, I found the problem: Sys-based capturing relies on replacing sys.stdout and sys.stderr with custom wrappers. But the StreamHandler still maintains a copy of the old sys.stderr and logs to that. So in fact any Sacred experiment that uses capture mode sys looses their logging.  That is clearly a problem!
You might be able to work around it with something like this, which should give you most logs (except for the "experiment started" logs):
@ex.pre_run_hook
def set_logger_stream(_run):
    _run.root_logger.handlers[0].stream = sys.stderr

I have to think about how to best fix this problem in a clean way. Let me know if you have any thoughts on this, especially also concerning the general integration of sacred with logging, since I am not entirely happy with the way it is currently done.

I think this might be easier to solve with an object-oriented interface which I see has been discussed in #193. Are there any news on that?
In the meantime, I thought of this (probably naive) solution:
I would move create_run inside the Run class as a static constructor-like method and make initialize_logging also a method of Run. Finally I would expose the Run class as a parameter of an Experiment, something like:
Experiment(name=None,..., run_type=Run)
This way, users would be able to subclass Run and add custom functionality, such as loggers.


text2image --degrade_image not working

Environment

Tesseract Version: tesseract 4.0.0-beta.1 leptonica-1.75.3
Commit Number:
Platform: Linux tensor 5.3.0-59-generic #53~18.04.1-Ubuntu SMP Thu Jun 4 14:58:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Current Behavior:
I am trying text2image for creating dataset for training tesseract, to apply noise to image or making the generated image look like scanned one i am using degrade_image parameter but its not working.
Working:
text2image --text data.gt.txt --outputbase /home/zyclyx/Documents/text2image/normal --font 'Arial' --fonts_dir /usr/share/fonts/truetype/msttcorefonts/
Not Working:
text2image --text data.gt.txt --outputbase /home/zyclyx/Documents/text2image/degrade_image --font 'Arial' --fonts_dir /usr/share/fonts/truetype/msttcorefonts/ --degrade_image
or
text2image --text data.gt.txt --outputbase /home/zyclyx/Documents/text2image/rotate_image --font 'Arial' --fonts_dir /usr/share/fonts/truetype/msttcorefonts/ --rotate_image
Expected Behavior:
The output tif before passing degrade_image or rotate_image and after passing are same. but expecting to have change.
I have gone through the usage document and the default boolean value is true only. Still the rotation is not working pls correct me if i did miss anything, i tried searching a lot but no luck.
Normal vs rotate vs degrade:

Random text file and commends used:

I think degrade_image is the default, so you may see different results only
if you set it to false. Take a look at multiple pages of the tif, usually
each page has a different rotation.
On Mon, Jun 29, 2020, 19:07 eliyaz-kl<EMAIL_ADDRESS>wrote:

Environment

Tesseract Version: tesseract 4.0.0-beta.1 leptonica-1.75.3
Commit Number:
Platform: Linux tensor 5.3.0-59-generic #53
https://github.com/tesseract-ocr/tesseract/issues/53~18.04.1-Ubuntu
SMP Thu Jun 4 14:58:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Current Behavior:
I am trying text2image for creating dataset for training tesseract, to
apply noise to image or making the generated image look like scanned one i
am using degrade_image parameter but its not working.
Working:
text2image --text data.gt.txt --outputbase
/home/zyclyx/Documents/text2image/normal --font 'Arial' --fonts_dir
/usr/share/fonts/truetype/msttcorefonts/
Not Working:
text2image --text data.gt.txt --outputbase
/home/zyclyx/Documents/text2image/degrade_image --font 'Arial' --fonts_dir
/usr/share/fonts/truetype/msttcorefonts/ --degrade_image
or
text2image --text data.gt.txt --outputbase
/home/zyclyx/Documents/text2image/rotate_image --font 'Arial' --fonts_dir
/usr/share/fonts/truetype/msttcorefonts/ --rotate_image
Expected Behavior:
The output tif before passing degrade_image or rotate_image and after
passing are same. but expecting to have change.
I have gone through the usage document and the default boolean value is
true only. Still the rotation is not working pls correct me if i did miss
anything, i tried searching a lot but no luck.
Normal vs rotate vs degrade:
[image: normal_rotate_degrade]
https://user-images.githubusercontent.com/55746134/86011690-b0bdb380-ba25-11ea-8c7d-3a9000ae393c.png
Random text file and commends used:
[image: random_txt_data]
https://user-images.githubusercontent.com/55746134/86011911-f7aba900-ba25-11ea-927f-828b94220dd5.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tesseract-ocr/tesseract/issues/3046, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABG37I3ND5H4VHKMDAT53W3RZCKJTANCNFSM4OLHDZCA
.

You need to add the --exposure parameter with one of these values: -3, -2, -1, 1,  2, 3.

First thanks for your support, and sry for the delay.
Its working large data!
when i tested multiple times with small data which was single .tif, gave the same output for all. but in large data it generated multi tif where i can see the rotation.

Main Goal:
-> i am trying to custom train only arabic numbers.
-> i wrote a script to write 100000 numbers in multiple gt.txt files. 100s of character in each gt.txt file.
-> then one script to convert text to image (text2image) which should be more like scanned image.
-> parameters used in the below order.
text2image --text test.gt.txt  --outputbase /home/user/output --fonts_dir /usr/share/fonts/truetype/msttcorefonts/ --font 'Arial' --degrade_image false --rotate_image --exposure 2 --resolution 300
sorry if its silly doubt

How much dataset i need to prepare for arabic number, as of now required only for 2 specific fonts which i already have.
Will dateset be duplicate if i follow this procedure, if yes is there any way to avoid it.
Can fill each gt.txt file with arabic numbers and create 1000 gt.txt files or is that good way to put each number like ex. 20012 in each gt.txt file and create multiple small tiff images.

If possible please guide me the procedure for datasets preparation.
For testing I tried 50,000 eng number with each number in one gt.txt file with 20,000 iteration but it fails

This place is for reporting about bugs.
For questions please use the forum.


Implement a simple node.js cli tool.

I've implemented a simple cli on work with npm.
I think budoux is a great tool for Japanese web development and people need CLI tool using more easier.  people can format texts only to install Node.js and run npx budoux-cli.
For test locally.
$ cd node_cli
$ npm link
$ budoux-cli -H

Output Example.
$budoux-cli
Please, pass one text argument to translate at least.
$budoux-cli --help
usage: budoux [-h] [-H] [-m JSON] [-d STR] [-V] [TXT]

オプション:
  -H, --html     HTML mode                                                [真偽]
      --version  バージョンを表示                                         [真偽]
      --help     ヘルプを表示                                             [真偽]
$budoux-cli --version
0.0.1
$budoux-cli 今日は天気です。
今日は
天気です。
$budoux-cli '今日は天気です。'
今日は
天気です。
$budoux-cli -H '今日はとても天気です。'
今日は<wbr>とても<wbr>天気です。

Are -m JSON, -d STR, -V options not yet  implemented?

I'm stucking in this implementation.
budoux-cli -d '---' 今日は天気です。 is going to be work well but budoux-cli --delim '---' 今日は天気です。 doesn't work.
It may a something bug in yargs. Anyway, it will take me more time to fix this problem.

Hi there, thank you for your proposal. I believe it will be useful for those who want to use the CLI without Python environment. That being said, I want to make it behave the same as the one written in Python by @eggplants to avoid the confusion between the Python version and the JavaScript version.
Could you consider to solve items below for consistency?

Please consider to move the CLI code under the javascript directory and add the "bin" field to the existing package.json. I want to avoid making another NPM package to maintain for the CLI functionality.
The command name could be simplified as "budoux".
I feel the biggest difference between the proposed CLI and the existing one is the support for standard inputs (e.g. use cases such as echo "今日は天気です。" | budoux). It would be great if the JavaScript version also supports that functionality.
I believe the meaning of the delimiter option differs from the existing one. It's the character to separate multiple text inputs concatenated by line breaks.

$ echo -e "今日は元気です\n明日は雨かな？" | budoux
今日は
元気です
---  <-- this is a delimiter.
明日は
雨かな？

@junseinagao Also, please visit https://cla.developers.google.com/ and complete signing CLA.
If you are not currently covered under a CLA, please visit https://cla.developers.google.com/. Once you've signed (or fixed any issues), please request a rescan from a repository manager.

@googlebot I signed.

Did you specify the arity of TXT in parser?
My implementation in Python restricts TXT's arity to only one.

Approving the change since my requests are reflected properly.
As @eggplants pointed out, it would be great if items below can be solved in the following changes.

Inconsistency in the number of arguments accepted for TXT

$ budoux 今日は寒いですね。 明日はどうでしょう？
usage: budoux [-h] [-H] [-m JSON] [-d STR] [-V] [TXT]
budoux: error: unrecognized arguments: 明日はどうでしょう？

Okey, I'm going to fix these problems.

@tushuhei
I fixed the program and here is changed points.
get the only one argument and stdin mode.
The program get 0 or 1 argument. (commander.js support this behavior to use placeholder [txt] instead of <txt>.) If the program get 0 argument, a user can input stdin and program parse stdin. If the program get more than one argument, throw error.
Add some tests.
I added some tests.

the program success when paese --model option with sample custom model.
the program success when parse --version or -V option.
the program fail when the program paese -v.
the program fail when get the extra program-arugments.
the program fail when get the extra option-arguments.

Maybe fix that optional arguments also accept more than one values.
Actually, I haven't reproduced the error you said.
I believe options (--delim and --model) won't get option-argument more than one value and parse its as a program-argument. Now, the program won't get more than one program-argument and throw error if get extra option-argument.
Please, tell me the specific failed test If you get tests to failed yet.
Import version number from package.json but reverted.
I tried to import version number from package.json but it occur change the directory structure of dist and module so I don't implement it's function and I only add the test that version is the same as package.json.

@tushuhei could you push Approve and run to run test CI?

@tushuhei Sorry for my mistake in CI. Could you re-run?

Hmm, I'm not sure how I can rerun the test with the latest configuration including npm link. It seems running on the old one.

@junseinagao please try:
git commit --allow-empty -m "empty" && git push

Pushed. I wish to pass tests in CI.

@tushuhei Please Approve and run again🙏

It seems the test is failing only on Windows. I'm not 100% sure, but the causation might be around the execution policy.
https://go.microsoft.com/fwlink/?LinkID=135170
@junseinagao Could you update your test code to run npx budoux instead of budoux? npx should run as long as Node.js is installed, so I'm curious to see if this solves the issue.

Probably the safest way would be not relying on execFile entirely. The problem should not occur as long as we test the cli method itself. I suggest to rewrite the test only to use the cli method as you do with the case: should output the error message when get more than one text argument..

@tushuhei
Just now, I'm thinking about that point. Testing with execFile has a lot of problem.
Okey, I'm going to rewrite tests to import cli methods.
(Under text is my writing text in the middle.)
npx don't parse EOL in argument'
This is my local zsh output. This behavior is a kind of mysterious. I guess both of budoux and npx budoux call node bin/budoux.js 🙃.
junsei@mbp2019 javascript % budoux '今日は元気です。
quote> 明日は晴れかな？'
今日は
元気です。
---
明日は
晴れかな？
junsei@mbp2019 javascript % npx budoux '今日は元気です。
明日は晴れかな？'
今日は
元気です。
\n明日は
晴れかな？

Shall we merge this PR once and create another PR with Windows support? It looks like this works perfectly except for the testing...

Sounds good. Let's merge this PR for now and start a new issue for the Windows support.

Thanks for merging PR! 😊 I will request a new PR for the WIndows support soon.


Add holy mountain portal mimics

I added my holy mountain portal mimics from Tales of Kupoli (1 in 75 chance for a portal to be replaced with a mimic, may change later)

works for me


None of your spec sources contain a spec satisfying the dependency: React/Core (from ../node_modules/react-native).

How to integration with existing apps in the 0.63.2 version?
https://reactnative.dev/docs/integration-with-existing-apps
I was unable to successfully set up and install the development environment through the documentation process.
The "pod install" error info in iOS Application use Swift or Objective-C:
[!] CocoaPods could not find compatible versions for pod "React/Core":
In Podfile:
React/Core (from ../node_modules/react-native)
None of your spec sources contain a spec satisfying the dependency: React/Core (from ../node_modules/react-native).
You have either:

out-of-date source repos which you can update with pod repo update or with pod install --repo-update.
mistyped the name or version.
not added the source repo that hosts the Podspec to your Podfile.

I looked for a lot of methods on the Internet, see a lot of posts, still can't solve this problem. I request the authorities to solve this problem or provide a feasible solution.

⚠	Missing Environment Information
ℹ	Your issue may be missing information about your development environment. You can obtain the missing information by running react-native info in a console.

How to run 'react-native info' ?  It's print ‘zsh: command not found: react-native’ in console.

How to run 'react-native info' ? It's print ‘zsh: command not found: react-native’ in console.

That information should be the same as your general setup that you did as part of Getting Started

No solution for this? i'm updating a project from 0.59.1 to 0.60.0 and getting the same.

No solution for this? i'm updating a project from 0.59.1 to 0.60.0 and getting the same.

I have given up using RN because it has too many problems and there is no official solution！

No solution for this? i'm updating a project from 0.59.1 to 0.60.0 and getting the same.

The current version is 0.64. 0.59 is 2 years old. You're going to get the best support apps by being updating to current versions. Since it seems like you're having an upgrade issue in which case the upgrade helper is maybe more what you're looking for.


harfbuzz: 2.5.0 -> 2.5.1

Motivation for this change
https://github.com/harfbuzz/harfbuzz/releases/tag/2.5.1
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Working here <3.


TypeError: Cannot read properties of undefined (reading 'path')

unable to create posts or upload media
Applicable Versions:

Netlify CMS version<EMAIL_ADDRESS>Git provider: git-gateway
Browser version: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36

CMS configuration
backend:
  name: git-gateway
  branch: master
local_backend: true
logo_url: https://d33wubrfki0l68.cloudfront.net/c89899bad974606ce0e0f5d5a95842dc787dcb56/7fe98/assets/images/logo-blue.png
media_folder: public/images/blog
public_folder: /images/blog
collections:
  - name: blog
    label: Blog
    folder: src/blog
    create: true
    slug: "{{pageName}}"
    fields:
      - label: Page-Name-with-dashes-only
        name: pageName
        widget: string
      - label: Blog Title
        name: blogTitle
        widget: string
      - label: Title Tag
        name: titleTag
        widget: string
      - label: Description
        name: blogDescription
        widget: string
      - label: Author
        name: author
        widget: string
      - label: Date
        name: date
        widget: datetime
      - label: Tags
        name: tags
        widget: list
        default:
          - post
      - label: Featured Image
        name: image
        widget: image
      - label: Image Caption
        name: imageAlt
        widget: string
      - label: Body
        name: body
        widget: markdown
    publish: true
    type: folder_based_collection
    sortable_fields:
      - commit_date
      - pageName
      - date
      - author
    view_filters: []
    view_groups: []
publish_mode: simple
slug:
  encoding: unicode
  clean_accents: false
  sanitize_replacement: "-"
isFetching: false
error: null

Additional context

the path was missing creating the folder solved the issue


Add Support for Code Davinci Models

Is there any enhancement plan to include code davinci models?

Yes, it will be added soon.

Code Davinci models have been discontinued in favor of gpt-3.5-turbo --
Per email from OpenAI:
"On March 23rd, we will discontinue support for the Codex API. All customers will have to transition to a different model. Codex was initially introduced as a free limited beta in 2021, and has maintained that status to date. Given the advancements of our newest GPT-3.5 models for coding tasks, we will no longer be supporting Codex and encourage all customers to transition to GPT-3.5-Turbo. About GPT-3.5-Turbo GPT-3.5-Turbo is the most cost effective and performant model in the GPT-3.5 family. It can both do coding tasks while also being complemented with flexible natural language capabilities."


Git extension - case-sensitive in Windows file system paths

I found issue that when switching to branch beggining from capital letter there is different treated by VS code plugin @ext:vscode.git.
VS code version:
Version: 1.77.1 (user setup)
Commit: b7886d7461186a5eac768481578c1d7ca80e2d21
Date: 2023-04-04T23:21:11.906Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19045
Sandboxed: No
Git extension version:
v1.0.0 and is bulit-in
Git version:
2.40.0.windows.1
Let's describe it:

I created new branch in project 'feature/case-sensitive-issue'
git branch feature/case-sensitive-issue
I switched to new branch:
git switch feature/case-sensitive-issue
I staged and commited some_file.txt on new branch:
git stage some_file.txt
git commit --message "Add some_file.txt"
I could see commit and I was able to undo commit from button or conext menu

I switched to smae branch, but with upper-case in "Feature" path part:
git switch Feature/case-sensitive-issue
I could not undo my commit from button:

After try to undo commit from context menu I had warning:

I tried to undo commit using git api:
git reset --soft HEAD~1
It laready worked!

I tried to commit last changes again and it worked and was commited to branch "feature/case-sensitive-issue" although I was on branch "Feature/case-sensitive-issue".
git commit --message "Add some_file.txt"

I don't know where is the problem: in git api or in git extension.
Please help me with this issue and fix it.
Regards,
Michal

Branches view on your screenshots is most likely from GitLens extension, not built-in Git.
Check if you ahve GitLens extension and if it's available if you disable it. Most likely this should be reported there first.

@IllusionMH thnank you for your suggestion. You was right, screens are from gitlens extension, except one with warning "Can't undo because HEAD doesn't point to any commit". This is from Git built-in extension. After disabling gitlens I successfully reproduced described warning.

The "Can't undo because HEAD doesn't point to any commit" error is caused by the fact that we cannot get the details of the current branch when incorrect casing is used. This is due to the fact that we are not calling git for-each-ref with the --ignore-case option. On Windows and macOS branch names are case-insensitive while on Linux and GitHub.com they are case sensitive. Closing a repository on Windows that contains branch names that only differ by case, will result in only one branch being pulled.
One potential solution would be that on Windows and macOS we include the --ignore-case flag.


~/.cache/plugged for plugins with neovim

In the README it says " Specify a directory for plugins (for Neovim: ~/.local/share/nvim/plugged) in the first line of the example init.vim. I feel like it would be more appropriate for the plugins to go into ~/.cache/plugged because they are non essential user data.

Type:

[ ] Bug
[ ] Enhancement
[ ] Feature Request
[x] Question

OS:

[ ] All/Other
[x] Linux
[x] OS X
[ ] Windows

Vim:

[ ] Terminal Vim
[ ] GVim
[x] Neovim

Hi, have you checked #559?

Hi, have you checked #559?

Actually, I still think this makes more sense.
\cc @justinmk @smyrman

Actually, I still think this makes more sense.
\cc @justinmk @smyrman

I am not a guru on the XDG spec, but I think XDG data is still more appropriate. Cache folder should be "safe to delete". If you need to run a command and have an Internet connection to get back to a working state after deleting the cache folder, I don't think cache is appropriate.

I am not a guru on the XDG spec, but I think XDG data is still more appropriate. Cache folder should be "safe to delete". If you need to run a command and have an Internet connection to get back to a working state after deleting the cache folder, I don't think cache is appropriate.


fix: CAA validation with CNAME record

Hi,
First of all thanks for this great package. We use it extensively for Mercure.rocks and stumbled upon a little bug that this patch fixes.
Pull Request Motivation
CAA validation is broken if the record is a CNAME that points to a subdomain and the CAA entry is defined on the root domain of this subdomain.
Validation should be done on the target domain (https://cabforum.org/2017/09/27/ballot-214-caa-discovery-cname-errata/), but it is currently done on the domain of the CNAME record.

Kind

bug
Release Note

fix CAA validation for CNAME, when CAA is set on a higher-level domain record

/kind bug

/remove-lifecycle stale
It's not stale, the issue is still there.


Homework 2

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Applied WHERE statement, joined tables and manipulate data using case function.
What did you learn from the changes you have made?
Learned to write sql queries
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
N/A
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist

[ ] I can confirm that my changes are working as intended

HW2 marked.


Add kernels for FusedBatchNormGrad when is_training=False

#10857

Can one of the admins verify this patch?

Let's wait a bit to see if zheng-xq has any comments (This PR may affect lots of users, let's be extra careful :) ). Thanks!

Any updates?

Thanks for the patience, Yuxin! zheng-xq will respond soon.

/CC @zheng-xq with the @ sign to trigger notification.

Jenkins, test this please.

Jenkins, test this please.

Jenkins, test this please.

Please merge this change. Thanks!


[Home Page] New UI (Secure Bitcoin Wallet)

This is the first of a series of New UI updates.
The focus of this update is to have a single home page where wallets are stacked vertically. We also only show 0 conf transactions (from all wallets) on the homepage.
Two wallets will be created by default: Secure Bitcoin Wallet and Instant Wallet
Only one of these two types of wallets can ever exist and are automatically created when the app is first installed.

[ ] Users should be able to import these wallets if they are migrating phones for example. So in this case what we can do is, still make a new wallet as default behavior and as long as they have not "Backed up" - we allow them to import and replace the default.

The focus of this issue is Secure Bitcoin Wallet which is an onchain wallet with swaps enabled.
Note: Users can create new/imported wallets however these will not have swaps enabled and will function the same as before. We will hide these buttons inside settings as it is considered and advanced feature. Those who need it can access it via settings.

Considerations:

How do we allocate space?

There are 3 main sections on the home page (arranged vertically)

Wallets: 6/10 space

There is a maximum number of wallets after which things will start getting crammed.

[ ] Imported wallets can be stacked together as one. On clicking it, it opens up the wallet selection screen as before and asks you to select which wallet to open. Same with Watch-only/Hardware. This would leave us with a maximum of 6 wallet types on home:

Secure

Instant

Imported (Multi-wallet stack)

Hardware (Multi-wallet stack)

Fiat (Multi-account stack [CAD,INR,EUR])

L-USDT

Latest Transactions: 2/10 space

We only show a maximum of 3 txs, latest first. A View All button will take us to a Latest Transactions Page where we can see all latest transactions.

Action Buttons: 2/10 space

Send/Recieve, Scan QR Buttons.

Related https://github.com/SatoshiPortal/bullbitcoin-mobile/issues/232


(test) minor - fix mock call args error on py37

Fixes below (only on Python 3.7):
            create_ctas_table_args = mock_create_ctas_table.call_args.kwargs
>           create_ctas_table_args["compression"] = compression
E           TypeError: '_Call' object does not support item assignment

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 87340f5116f501f54966c97719db5d0a291b24c0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 350a03a76937893b119301c957b0931a358f3970
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


how can i set the webview's width and height, and i can't close it or back to my app, because it open my browser, then if i tap back, the app will exit

It's not possible to define custom width or height. For the other problem, please add more information about your device so I could help you.

As there is no answer in 3 weeks I close the issue.


[Icon Request]:

Housekeeping

[X] I'm sure this issue is not a duplicate

Icon Type

[X] File Icon
[X] Folder Icon

Icon Type

[X] Extension
[X] Filename
[X] Language ID

Original Icon
ffwefw
Icon Information
efwwf
More Information:
No response

This is spam.


Ensure properties annotated to hold NodeList are not null

Resolves https://github.com/webonyx/graphql-php/issues/769
Fixes 2 bugs related to schema validation of directives.

Coverage decreased (-0.01%) to 86.367% when pulling c258d025b09cc8679f74c2e1851d2da273d2efa2 on spawnia:ensure-node-lists-are-never-null into 115a20e419439a27092788cdf36f1ac5f0fa429b on webonyx:master.

Coverage decreased (-0.01%) to 86.367% when pulling c258d025b09cc8679f74c2e1851d2da273d2efa2 on spawnia:ensure-node-lists-are-never-null into 115a20e419439a27092788cdf36f1ac5f0fa429b on webonyx:master.

I would argue this is a bugfix. The annotations said the property is an array, but it was falsely set to null.

I would argue this is a bugfix. The annotations said the property is an array, but it was falsely set to null.

Regarding your example, most likely the code inside the isset() will loop after the extension nodes.

Regarding your example, most likely the code inside the isset() will loop after the extension nodes.

Alright, since we are now moving towards a new major version the slight potential breakage of this PR should no longer be an issue.

@spawnia Is it ready to go?
@simPod are you good with this PR?


Invalid characters with Tesseract 5.1.0 and tessdata_fast data (for German version) when using 32-bit Microsoft compiler

Environment

Tesseract Version: 5.1.0
Platform: Windows 32-bit

Current Behavior:
I have the following problem:

I prepared a custom build for Tesseract 5.1.0, so as to generate dlls, which I then use in the project of a 32-bit .exe application.
I prepared the following dependencies with CMake 3.23 (without SW build):
a. tesseract 5.1.0, leptonica 1.82.0, libtiff 4.3.0, libjpeg-turbo 2.1.3, zlib 1.2.11, libpng 1.6.37.
b. Links to src:

tesseract 5.1.0 (https://github.com/tesseract-ocr/tesseract/releases) – 01.03.2022
leptonica 1.82.0 (http://www.leptonica.org/download.html) – 22.09.2021
libtiff 4.3.0 (http://download.osgeo.org/libtiff) – 20.04.2021
libjpeg-turbo 2.1.3 (https://github.com/libjpeg-turbo/libjpeg-turbo/releases ) – 25.02.2022
zlib 1.2.11 (https://github.com/madler/zlib/tags) – 15.01.2017
libpng 1.6.37 (https://github.com/glennrp/libpng/releases/tag/v1.6.37) – 14.04.2019
c. I also fix CMakeList.txt a bit for tesseract to be able to generate .dll files - see:
CMakeLists.txt

After generating the dependencies, I used them in a wrapper that uses CAPI and generated a dll file (also 32 bit) that I used in the application. The list of all dependencies is as follows:

In the next step, I performed an OCR test in the application with tessdata germany data - deu.traineddata model: https://github.com/tesseract-ocr/tessdata_fast.
At this point, I noticed inferior recognition quality compared to the Tesseract 4.1.1 version, which I used earlier.

a. test file:

I noticed that there is also a problem with slash, for example: It is then changed to "jj" - see:

I would like to add that I have also prepared a Tesseract 4.1.1 compilation with the dependencies as in point 2b. The quality of OCR did not change then.
I use tessdata_best as a temporary workaround (and it work), but the OCR speed for this model is not satisfactory for me.

Expected Behavior:
I expect Tesseract 5.1.0 to recognize characters correctly, ie not converting "l", "m" to "j" or "i" to "j" for example in the tessdata_fast mode. I would like character recognition to work similar to Tesseract 4.1.1.
Suggested Fix:
Consideration of an upgrade for deu.traineddata models on the website:
https://github.com/tesseract-ocr/tessdata_fast

Tesseract 5 still supports the model files from Tesseract 4 with the "legacy mode", so if you are happy with that, you can use it.

@krzysiekj94, I get a different result:
tesseract https://user-images.githubusercontent.com/12548678/158796308-0e0e8e57-ad24-4eb5-b70a-0c6b99722663.png - -l tessdata_fast/deu

Siegfried Aalfelden
Kurt-Schumacher-Platz 10
13405 Berlin

26.02.2019

Sehr geehrter Herr Aalfelden,

Informationen

Das Internet (von englisch internetwork, zusammengesetzt aus dem Präfix inter und
network „Netzwerk“ oder kurz net ‚Netz‘), umgangssprachlich auch Netz, ist ein
weltweiter Verbund von Rechnernetzwerken, den autonomen Systemen.  Dabei kann sich jeder Rechner mit jedem anderen Rechner verbinden.

Die Verbreitung des Internets hat zu umfassenden Umwälzungen in vielen
Lebensbereichen geführt. Es trug zu einem Modernisierungsschub in vielen
Wirtschaftsbereichen sowie zur Entstehung neuer Wirtschaftszweige bei und hat zu
einem grundlegenden Wandel des Kommunikationsverhaltens und der Mediennutzung
im beruflichen und privaten Bereich geführt. Die kulturelle Bedeutung dieser
Entwicklung wird manchmal mit der Erfindung des Buchdrucks gleichgesetzt.

Die Übertragung von Daten im Internet unabhängig von ihrem Inhalt, dem Absender
und dem Empfänger wird als Netzneutralität bezeichnet.

Mit freundlichen Grüßen

Hello @stweil , thanks for response.  I have more questions now:

Where exactly to get the tessdata_fast data for "legacy mode"?
Based on the documentation https://github.com/tesseract-ocr/tessdata_fast I can see that legacy mode is not supported.
Can support legacy for tesseract be enforced when building a solution via CMakeList.txt from CMake? If so, where is that option?
It's my preview of CMake with tesseract:

On which version of Tesseract did you get the correct result? Where can I get the exact version you used? Is it 32-bit or 64-bit? Can you send a link to this version?
Is it possible that there is a different behavior for tessdata_fast on 32-bit and 64-bit versions of Tesseract 5.0.1?
Can there be problems with the use of CAPI? Perhaps I should switch to object oriented programming?
Below is an example of initialize a tesseract in my wrapper code:

Thanks in advance for your answer! Have a nice day.

Please try the OCR with the default tesseract application. If that works fine (like it does in my test) you have to find out what you have to fix in your application.

Legacy model is available only in https://github.com/tesseract-ocr/tessdata.

I use tessdata_best as a temporary workaround (and it work), but the OCR speed for this model is not satisfactory for me.

Then please try, as suggested above, with model from  https://github.com/tesseract-ocr/tessdata which has legacy models as well as the 'fast' version of 'tessdata_best' models. Both are available in the same traineddata file, invoked with different --oem settings.

I found one of the articles that seems to be similar to my problem: https://github.com/tesseract-ocr/tesseract/issues/3283
I did one of the tests and changed the option related to O2 optimization to disabled.  I was very surprised because disabling /O2 optimization caused OCR to return almost identical texts as in tesseract 4.1.1, which I expected. See below for settings in Visual Studio 2019 and for differences in text:

Now I have a question: Would it be wise if I compiled tesseractlib 5.1.0 with the /O2 optimization option turned off? Does this have any unexpected consequences? Maybe someone has similar problems and experiences? I feel close to solving the problem.

Related issues: #2898 and #3283.

After installing the Mannheim installation, the OCR seems to form fine, but I don't know where it comes from.

The UB Mannheim binaries are build with the GNU compiler. Therefore they don't have this issue.

64bit works for me.:
>tesseract -v
tesseract 5.1.0-7-g0e526
 leptonica-1.83.0 (Jan 26 2022, 19:15:03) [MSC v.1929 LIB Release x64]
  libgif 5.2.1 : libjpeg 6b (libjpeg-turbo 2.0.91) : libpng 1.6.37 : libtiff 4.3.0 : zlib 1.2.11
 Found AVX2
 Found AVX
 Found FMA
 Found SSE4.1
 Found OpenMP 2019
 Found libarchive 3.5.1 zlib/1.2.11 liblzma/5.2.4 bz2lib/1.0.6 libzstd/1.4.9
 Found libcurl/7.75.0 zlib/1.2.11 libssh2/1.10.1_DEV

>tesseract i3769.png - -l tessdata_fast/deu
Siegfried Aalfelden
Kurt-Schumacher-Platz 10
13405 Berlin

26.02.2019

Sehr geehrter Herr Aalfelden,

Informationen

Das Internet (von englisch internetwork, zusammengesetzt aus dem Präfix inter und
network „Netzwerk“ oder kurz net ‚Netz‘), umgangssprachlich auch Netz, ist ein
weltweiter Verbund von Rechnernetzwerken, den autonomen Systemen.  Dabei kann sich jeder Rechner mit jedem anderen Rechner verbinden.

Die Verbreitung des Internets hat zu umfassenden Umwälzungen in vielen
Lebensbereichen geführt. Es trug zu einem Modernisierungsschub in vielen
Wirtschaftsbereichen sowie zur Entstehung neuer Wirtschaftszweige bei und hat zu
einem grundlegenden Wandel des Kommunikationsverhaltens und der Mediennutzung
im beruflichen und privaten Bereich geführt. Die kulturelle Bedeutung dieser
Entwicklung wird manchmal mit der Erfindung des Buchdrucks gleichgesetzt.

Die Übertragung von Daten im Internet unabhängig von ihrem Inhalt, dem Absender
und dem Empfänger wird als Netzneutralität bezeichnet.

Mit freundlichen Grüßen

Hello @zdenop .
The problem still exists with the use of \ Ox. OCR returns the same result as the \ O2 flag.

64bit works for me.:
>tesseract -v
tesseract 5.1.0-7-g0e526
 leptonica-1.83.0 (Jan 26 2022, 19:15:03) [MSC v.1929 LIB Release x64]
  libgif 5.2.1 : libjpeg 6b (libjpeg-turbo 2.0.91) : libpng 1.6.37 : libtiff 4.3.0 : zlib 1.2.11
 Found AVX2
 Found AVX
 Found FMA
 Found SSE4.1
 Found OpenMP 2019
 Found libarchive 3.5.1 zlib/1.2.11 liblzma/5.2.4 bz2lib/1.0.6 libzstd/1.4.9
 Found libcurl/7.75.0 zlib/1.2.11 libssh2/1.10.1_DEV

>tesseract i3769.png - -l tessdata_fast/deu
Siegfried Aalfelden
Kurt-Schumacher-Platz 10
13405 Berlin

26.02.2019

Sehr geehrter Herr Aalfelden,

Informationen

Das Internet (von englisch internetwork, zusammengesetzt aus dem Präfix inter und
network „Netzwerk“ oder kurz net ‚Netz‘), umgangssprachlich auch Netz, ist ein
weltweiter Verbund von Rechnernetzwerken, den autonomen Systemen.  Dabei kann sich jeder Rechner mit jedem anderen Rechner verbinden.

Die Verbreitung des Internets hat zu umfassenden Umwälzungen in vielen
Lebensbereichen geführt. Es trug zu einem Modernisierungsschub in vielen
Wirtschaftsbereichen sowie zur Entstehung neuer Wirtschaftszweige bei und hat zu
einem grundlegenden Wandel des Kommunikationsverhaltens und der Mediennutzung
im beruflichen und privaten Bereich geführt. Die kulturelle Bedeutung dieser
Entwicklung wird manchmal mit der Erfindung des Buchdrucks gleichgesetzt.

Die Übertragung von Daten im Internet unabhängig von ihrem Inhalt, dem Absender
und dem Empfänger wird als Netzneutralität bezeichnet.

Mit freundlichen Grüßen

In my case, unfortunately, I can't use the x64 version because I have a 32-bit application that uses Tesseract's .dll's :(

Now I have a question: Would it be wise if I compiled tesseractlib 5.1.0 with the /O2 optimization option turned off? Does this have any unexpected consequences?
You tried it yourself with a good result. The expected consequence is much slower program execution.
Which version of MSVC 2019 exactly do you use? If it's not lhe latest one (16.11.11), can you upgrade to the latest one and retest?
If the issue still exist with the latest MSVC 2019 version, I suggest to send a new bug report to Microsoft, or reuse this one: https://developercommunity2.visualstudio.com/t/1336629.

This is similar to issue as #3283.
I closed this issue because it seems to be an issue with MSVC, not with Tesseract.
If a future version of MSVC will solve the issue, let us know.

At the moment I'm using VS version 16.9.6 (older version) but I compiled on a different computer with the same VS 2019 x86 version. Interestingly, with /O2 optimization, but without AVX2, OCR works fine. Why? I do not know.

Interestingly, with /O2 optimization, but without AVX2, OCR works fine.

So the Microsoft compiler creates buggy code with /O2 for intsimdmatrixavx2.cpp.
@krzysiekj94, you could try to add #pragma optimize( "", off ) in that file and test whether that fixes the issue.

Interestingly, with /O2 optimization, but without AVX2, OCR works fine.

So the Microsoft compiler creates buggy code with /O2 for intsimdmatrixavx2.cpp.
@krzysiekj94, you could try to add #pragma optimize( "", off ) in that file and test whether that fixes the issue. If that works, you could also try #pragma optimize( "s", on ) as an additional pragma.

Hello @stweil ,
1). It looks like after adding only #pragma optimize( "", off ) in the intsimdmatrixavx2.cpp works - see code and comparing results:

2). After adding only #pragma optimize( "s", on ) in the intsimdmatrixavx2.cpp - you can see that somehow OCR is the worst

3). After adding #pragma optimize( "", off ) and  #pragma optimize( "s", on ) together - I have the same result as when I added only #pragma optimize( "", off )

My question is: I understand that by "you could also try #pragma optimize (" s ", on) as an additional pragma" you mean using these two #pragma together - as in step 3?

Now I have a question: Would it be wise if I compiled tesseractlib 5.1.0 with the /O2 optimization option turned off? Does this have any unexpected consequences?

You tried it yourself with a good result. The expected consequence is much slower program execution.
Which version of MSVC 2019 exactly do you use? If it's not lhe latest one (16.11.11), can you upgrade to the latest one and retest?
If the issue still exist with the latest MSVC 2019 version, I suggest to send a new bug report to Microsoft, or reuse this one: https://developercommunity2.visualstudio.com/t/1336629.

@amitdo  On version 16.11.11 the problem still recurs. I checked it.

My question is: I understand that by "you could also try #pragma optimize (" s ", on) as an additional pragma" you mean using these two #pragma together - as in step 3?

Yes, that's right. The first pragma disables the optimization options from your build environment. This was expected to work, but disabling all optimizations might result in bad performance. The second pragma therefore enables size optimization (similar to compiler option /Os).
Now those two pragma statements should be included conditionally, namely only for 32 bit builds and those compiler versions which show the bug. Maybe you can find out how this can be done with preprocessor conditionals.

I have added below a suggestion for a fix VS x86 version 16.5 - 16.11 (https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170).
See: https://pastebin.com/K1q5PzRf

Do you want to send a pull request? Then just add a comment (and an empty line after line 16).

The problem is with the 32-bit build only so there should be a check for 64-bit (_WIN64) build as _WIN32  is defined for 32 and 64-bit build.

In #3283 Windows 10 64-bit was used, but the MSVC build is 32-bit. how can we detect this?

Only a built time check is needed (#if ... defined(_WIN32) && !defined(_WIN64) ...). The resulting 32 bit code fails on both 32 and 64 bit Windows.

Hmm, from what I can see after changing the x86 / x64 compilation in combobox, the #pragma section turns on / off - after adding defined (WIN32) - this is probably used by MS to detect compile mode. Maybe it it's way to solve this problem?

WIN32 is defined by the SDK or the build environment, so it does not use the implementation reserved namespace

see: https://stackoverflow.com/questions/662084/whats-the-difference-between-the-win32-and-win32-defines-in-c

The non-underscore WIN32 is not well documented and appears to have no bearing on 32 vs 64 machine type. Standard Visual C++ projects for Windows generally don't appear to use it (it may not be in use at all).

see: https://stackoverflow.com/questions/17380340/win32-preprocessor-definition-in-64bit-windows-platform/51682888#51682888
Also https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-160 mentions only _WIN32 / _WIN64

That's right, and it should be sufficient to use only those two official macros (see my previous comment).

I noticed that after copying the generated Tesseract from a computer without AVX2 support, the problem occurs with copied dll's on a computer that supports AVX2

When I did my tests for #3283, I also tried to disable AVX2 usage with the statement
avx2_available_ = false;
in src/arch/simddetect.cpp, line 200. This is where the decision is made at runtime, so it should work on machines that have avx2 available.
This gave good results, and did not slow down that much. So I suggest to enclose this statement in the proper _MSC_VER macros, rather than turning off the optimizations with #pragma optimize.

On version 16.11.11 the problem still recurs. I checked it.

Thank you for checking that. So my preferred workaround ist still using VS 2019 with platform toolset v141 (which belongs to VS 2017) - you need no code patch then.

Hi @BJungmann,
1). Thanks for the suggestion for the version for VS 2017 version. I made a sample build for version 15.9.45 Community - see below:

2). I did performance tests - here the differences are diametrical excluding optimization in intsimdmatrixavx2.cpp - see below test for 7 page tiff in favor of VS 2017. I haven't checked your patch, but I think it will be above that time as well.
The OCR results are identical.

3). IMO, it seems that any change from #pragma will increase the OCR execution time...
I saw that you have already reported this problem to the microsoft team, but it has status: "Closed - Not Enough Info" - https://developercommunity2.visualstudio.com/t/1336629. Will you report this issue to microsoft again? I was wondering whether to do it myself, but maybe you already have it in your plans.

 This is the reason why I still recommend platform toolset v141.
I have no current plans to start a new effort with Microsoft. They like very short demonstration code for bug reports. A short main program and data set that shows wrong results would be feasible. But I do not understand enough details in the tesseract code using the MatrixDotVector functions, to see which call to which function with which data produces different results if executed with AVX2 hardware.

@stweil, can you push a workaround for this issue?

@stweil, can you push a workaround for this issue?

Something like #3778?

Yes :-)


Friending does not work

If you friend someone and they friend you back, it still says I have 0 friends.
please fix

Thankyou :)

What commands have you tried using? And did you get any feedback?

Hello, this works now, however some of the message variable are incorrect

Like recieved and sender are switched around etc

Which commands have incorrect messages?

Recieved and Sender

Sorry for the delay, but I couldn't recreate this bug. I might have accidentally fixed it already 🙃. If you still use my plugin and encounter this problem on its latest version, feel free to open another issue!


Enhancement: The feature renaming dependency is incomplete

Problem
The current kpm renaming dependency is incomplete, the current state of this function is only to replace the dependent name in kcl.mod.
This will result in the following situation:
kcl mod add helloworld:0.1.0 --rename new_helloworld

The command above will add dependency into kcl.mod as below
[dependencies]
new_helloworld = 0.1.0

And the kcl.mod.lock
[dependencies]
  [dependencies.new_helloworld]
    name = "new_helloworld"
    full_name = "new_helloworld_0.1.0"
    version = "0.1.0"

And these incomplete information does not support updating the dependency for helloworld when kcl mod update or kcl run. The link between helloworld and new_helloworld is missing.
Solution
Referring to cargo, add a package field to declare the association between new name and old name in kcl.mod.
Here is a example:
[dependencies]
new-flask-demo-kcl-manifests = { git = "https://github.com/kcl-lang/flask-demo-kcl-manifests", version = "v0.1.0", package = "flask-demo-kcl-manifests" }
flask-demo-kcl-manifests = { git = "https://github.com/kcl-lang/flask-demo-kcl-manifests", version = "v0.1.0" }

new_helloworld = { version = "1.0.0", package = "helloworld" }
helloworld = "1.0.0"

Hi @zong-zhe I would like to collaborate on this one.

Hi @Manoramsharma 😃
Are you going to finish this part of the work?

@zong-zhe It will be better if you can add some sub-tasks that will ultimately be achieving this and I can contribute to those small sub-tasks if you think this issue to be a complex one.

Hi @Manoramsharma 😃
The first step is to add this package field so that you can write something like this in kcl.mod
new_helloworld = {version = "1.0.204", package = "new_helloworld"}

flask-demo-kcl-manifests_new = {git = "https://github.com/kcl-lang/flask-demo-kcl-manifests", version = "v0.1.0 ", package = “flask-demo-kcl-manifests” }

helloworld_oci = {oci = "https://ghcr.io/kcl-lang/helloworld ", version = "v0.1.0, "package =" helloworld_oci "}

The first PR is that kcl.mod supports reading and writing to the above formats with package.
Change the contents of this file and write the corresponding tests for your work: https://github.com/kcl-lang/kpm/blob/main/pkg/downloader/toml.go

Hey @zong-zhe

the rename flag is not working as described above

Hey @zong-zhe  the rename flag is not working as described above Screencast from 30-07-24 10:29:27 PM IST.webm

Hi @Gmin2 😃
kpm is currently used by the kcl cli as a library. The kpm command has not been maintained for a long time. You can try to test this function through the kcl cli.
kcl cli - https://github.com/kcl-lang/cli


CORS-3739: Add c4a instance as arm type

** The c4a instance type needs to be added for other projects that import this package and its validation. Added the c4a instance type as an ARM type to the dictionary for lookup.

/approve
/lgtm

@barbacbd @JoelSpeed, as a reminder, we'll need to backport support for this to OCP 4.17.z

/jira backport release-4.17


make signing/signup pages inaccessible for loggged in users

Do all the work for this issue in branch called issue-26

Now, a logged in user can access "sign in" and "sign up" by going to the root url.
One possible solution:

When user is logged in, root url redirects to /userhome


Write documentation on how to use

/publish-release

/publish-release

/publish-release

/publish-release

/publish-release

/publish-release

/create-release

/publish-release

/publish-release

/create-release

/create-release

/create-release

/create-release

/create-release

/create-release

/create-release

/create-release

/create-release

/create-release

/create-release

/create-release

/create-release

/create-release

/create-release

/create-release

/create-release

/create-release

/create-release

/create-release


Include cache args in Dataset init

Fix mentioned in #50 .
I figure the signature should match wds.WebDataset exactly so you can just use **kwargs instead of explicitly listing the args in wds.Dataset's init. However, I opted to not do that since it would introduce breaking changes to the existing wds.Dataset API.

Thanks for the patch. I'm pulling it, but I still recommend you just switch to the WebDataset class. The interface is almost identical. I will probably put a deprecation warning on Dataset.