Update virtualScroll.component.ts

Hi Dinony,
We experience poor scrolling performance in IE even if we set vsDebounceTime to a large value. After some investigation we have discovered that Angular change detection is triggered on each 'scroll' event despite debounceTime(). This can be prevented by wrapping Observable.fromEvent(..., 'scroll') in zone.runOutsideAngular().
I couldn't figure out how to create a cold observable with Observable.fromEvent as if subscribe() is called outside of zone.runOutsideAngular() Angular change detection is still triggered on each scroll event. The proposed solution adds an intermediate scroll$ Subject.
Kind regards,
Serguei.

Hi Serguei, strange, can you tell me, which IE version you are using?

Hi Dinony,
I’m using IE11, v.11.0.10240.17354, but it doesn’t really matter. Angular change detection is triggered on each scroll event in all browsers. It’s just the performance degradation is more noticeable in IE in our case (depends on the complexity of the UI to be updated, of course).
Kind regards,
Serguei.
From: dinony<EMAIL_ADDRESS>Sent: Monday 12 June 2017 13:56
To: dinony/od-virtualscroll<EMAIL_ADDRESS>Cc: Serguei Martchenko<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [dinony/od-virtualscroll] Update virtualScroll.component.ts (#6)
Hi Serguei, strange, can you tell me, which IE version you are using?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/dinony/od-virtualscroll/pull/6#issuecomment-307768049, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXJMqxdfOq_e0s7A6kqtzF44lg_MH6KIks5sDSdAgaJpZM4N2Evg.
DISCLAIMER: This e-mail and any attachments are intended only for the individual or company to which it is addressed and may contain information which is privileged, confidential and prohibited from disclosure or unauthorized use under applicable law. If you are not the intended recipient of this e-mail, you are hereby notified, any use, dissemination, or copying of this e-mail or the information contained in this e-mail is strictly prohibited by the sender. If you have received this transmission in error, please return the material received to the sender and delete all copies from your system. This email has been scanned by the Email Security.cloud service.

Ok, thanks! On the component level I'm using ChangeDetectionStrategy.OnPush. In combination with Observables, this allows me to exactly mark for check when necessary and to avoid unnecessary checks.  So, the virtual scroll component subtree should be optimized for change detection.
Are you measuring performance on an isolated scroll example, or are you experiencing the performance degradation when embedded in your current application?

It’s when I’m using it in my application indeed. To be clear, the delays don’t come from the component but from the hosting application.
I think most applications will use Default rather than OnPush most of the time, so it’s best if virtualscroll limits the number of times it triggers Angular change detection.
BTW, I didn’t say it before, it’s a great control, it’s really useful and helped us a lot with improving performance of our app! Great job!
Kind regards,
Serguei.
From: dinony<EMAIL_ADDRESS>Sent: Monday 12 June 2017 14:43
To: dinony/od-virtualscroll<EMAIL_ADDRESS>Cc: Serguei Martchenko<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [dinony/od-virtualscroll] Update virtualScroll.component.ts (#6)
Ok, thanks! On the component level I'm using ChangeDetectionStrategy.OnPush. In combination with Observables, this allows me to exactly mark for check when necessary and to avoid unnecessary checks. So, the virtual scroll component subtree should be optimized for change detection.
Are you measuring performance on an isolated scroll example, or are you experiencing the performance degradation when embedded in your current application?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/dinony/od-virtualscroll/pull/6#issuecomment-307778061, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXJMq0VfOeQLshueU4Q0OBN8Sb3QSOk6ks5sDTJfgaJpZM4N2Evg.
DISCLAIMER: This e-mail and any attachments are intended only for the individual or company to which it is addressed and may contain information which is privileged, confidential and prohibited from disclosure or unauthorized use under applicable law. If you are not the intended recipient of this e-mail, you are hereby notified, any use, dissemination, or copying of this e-mail or the information contained in this e-mail is strictly prohibited by the sender. If you have received this transmission in error, please return the material received to the sender and delete all copies from your system. This email has been scanned by the Email Security.cloud service.

Btw, we also encountered a defect in od-virtualscroll that you might want to fix. If vsData is a BehaviorSubject (thus triggers synchronously as soon as you subscribe to it) then rendering might fail. For example, the following will break (will not render row numbers):
<od-virtualscroll [vsData]="behaviorSubject" [vsOptions]="vsOptionsObservable">

<span *ngIf="true">{{row}}

We work around this by using observable behaviorSubject.debounceTime(0)
Kind regards,
Serguei
From: dinony<EMAIL_ADDRESS>Sent: Monday 12 June 2017 14:43
To: dinony/od-virtualscroll<EMAIL_ADDRESS>Cc: Serguei Martchenko<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [dinony/od-virtualscroll] Update virtualScroll.component.ts (#6)
Ok, thanks! On the component level I'm using ChangeDetectionStrategy.OnPush. In combination with Observables, this allows me to exactly mark for check when necessary and to avoid unnecessary checks. So, the virtual scroll component subtree should be optimized for change detection.
Are you measuring performance on an isolated scroll example, or are you experiencing the performance degradation when embedded in your current application?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/dinony/od-virtualscroll/pull/6#issuecomment-307778061, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXJMq0VfOeQLshueU4Q0OBN8Sb3QSOk6ks5sDTJfgaJpZM4N2Evg.
DISCLAIMER: This e-mail and any attachments are intended only for the individual or company to which it is addressed and may contain information which is privileged, confidential and prohibited from disclosure or unauthorized use under applicable law. If you are not the intended recipient of this e-mail, you are hereby notified, any use, dissemination, or copying of this e-mail or the information contained in this e-mail is strictly prohibited by the sender. If you have received this transmission in error, please return the material received to the sender and delete all copies from your system. This email has been scanned by the Email Security.cloud service.

We experience the same problem as well. Change detection is triggered for entire page from top to bottom on every scroll event. For big pages performance degradation is very noticeable, especially in browsers with slow Javascript engines.
We use od-virtualscroll in many different components and not all of them use OnPush strategy.
Is there a need to actually trigger change detection for scroll event?
Any plans to merge this pull request?
Thanks for your hard work!

Hi @BogdanPolitaiev. Thanks, yep it's planned that I will look into this issue in September - I'm already late though, but it will happen!

Thanks for the help and for your patience! Changes will be in the next release.


FIX: hack directory now lives inside calico subdirectory

Description
Several links in docs refer to the hack directory, which changed locations in the repo from ./hack to calico/hack
Todos
~- [ ] Tests~
~- [ ] Documentation~
~- [ ] Release note~
Release Note

None required

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@marvin-tigera anything else for me/us to do here?

/sem-approve


fix awsconfig result processing by resource types

Proposed changes
Fix resource type grouping for AWS Config. Current implementation pushes all resources under the first resource type.
Issues for these changes

Types of changes

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (changes to code, which do not change application behavior)

Checklist

[x] I have filled out this PR template
[ ] I have read the CONTRIBUTING doc
[ ] I have added automated tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (README.md, CHANGELOG.md, etc. - if appropriate)

Dependencies and Blockers
none
Relevant Links

Further comments
Current results:
{
  "findings": [
    {
      "accountId": "0000000000000",
      "ruleName": "required-tags",
      "status": "NON_COMPLIANT",
      "flaggedResources": {
        "AWS::DynamoDB::Table": [1,2,3,4,5,6]
      }
}

After fix:
{
  "findings": [
    {
      "accountId": "0000000000000",
      "ruleName": "required-tags",
      "status": "NON_COMPLIANT",
      "flaggedResources": {
        "AWS::ACM::Certificate": [1,2,3],
        "AWS::AutoScaling::AutoScalingGroup": [1,2,3],
        "AWS::CloudFormation::Stack": [1,2,3],
        ...
        ],
    }
}

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Imunhatep Thanks for the contribution. Nice catch on this.
Can you add an entry in the the table test for pkg/cloudig/awsconfig_test.go for completeness.
Doesn't have to be complicated maybe something like ... and the corresponding output update.
// L208
{
	ComplianceType: aws.String("NON_COMPLIANT"),
	ConfigRuleInvokedTime: timeHelper(2018, time.December, 21, 8, 38, 52, 0, time.UTC),
	EvaluationResultIdentifier: &configservice.EvaluationResultIdentifier {
		EvaluationResultQualifier: &configservice.EvaluationResultQualifier {
			ConfigRuleName: aws.String("ALL_OPEN_INBOUND_PORTS_SECURITY_GROUP_CHECK"),
			ResourceId: aws.String("sg-00004"),
			ResourceType: aws.String("AWS::EC2::SecurityGroup2"),
		},
		OrderingTimestamp: timeHelper(2018, time.December, 21, 8, 38, 36, 0, time.UTC),
	},
	ResultRecordedTime: timeHelper(2018, time.December, 21, 8, 38, 53, 0, time.UTC),
},

Afterwards, I can approve and merge.

Adding more tests is ok, but..
That is my personal account. There is a license, including forked repository. I won't sign anything, it's OSS - take it or leave it.

Adding more tests is ok, but..
That is my personal account. There is a license, including forked repository. I won't sign anything, it's OSS - take it or leave it.

@Imunhatep Sorry but we can't accept the addition unless you approve the contributors agreement. If not, thank you for your interest in cloudig and I'll make an issue on this topic so it can be fixed some time in the future.

No problem. Thank you for looking into.


firebase authentication

I wonder if I can use Firebase authentication, put it on my web page, and use it in actions on Google?

Yeah you could do that. However, Firebase Authentication does not have an OAuth server in the backend, so you would need to do your own token management.


Opening from annotation could include line number

When right-clicking "Open in ..." from annotations, it currently takes you to the commit and file reference.
It would be useful if this also respected the line number of the annotation, and pulled this through to the link opened.

Released in 2.4.0


[pycarwings3.pycarwings3] got an empty BatteryStatusRecords makes the integration fail (could be due to 2G shut down)

System Health details
System Information

version
core-2024.9.1

installation_type
Home Assistant OS

dev
false

hassio
true

docker
true

user
root

virtualenv
false

python_version
3.12.4

os_name
Linux

os_version
6.6.31-haos-raspi

arch
aarch64

timezone
Europe/Oslo

config_dir
/config

Home Assistant Community Store

GitHub API
ok

GitHub Content
ok

GitHub Web
ok

GitHub API Calls Remaining
4998

Installed Version
1.34.0

Stage
running

Available Repositories
1401

Downloaded Repositories
11

Home Assistant Cloud

logged_in
true

subscription_expiration
January 10, 2025 at 01:00

relayer_connected
true

relayer_region
eu-central-1

remote_enabled
true

remote_connected
true

alexa_enabled
false

google_enabled
false

remote_server
eu-central-1-1.ui.nabu.casa

certificate_status
ready

instance_id
e26cf404b5804e879a0c2a083a0c5710

can_reach_cert_server
ok

can_reach_cloud_auth
ok

can_reach_cloud
ok

Home Assistant Supervisor

host_os
Home Assistant OS 13.1

update_channel
stable

supervisor_version
supervisor-2024.09.1

agent_version
1.6.0

docker_version
26.1.4

disk_total
116.5 GB

disk_used
13.8 GB

healthy
true

supported
true

host_connectivity
true

supervisor_connectivity
true

ntp_synchronized
true

virtualization

board
rpi4-64

supervisor_api
ok

version_api
ok

installed_addons
File editor (5.8.0), TellStick (2.2.0), Samba share (12.3.2), Z-Wave JS (0.7.1), Advanced SSH & Web Terminal (19.0.0), deCONZ (7.0.0), Mosquitto broker (6.4.1), Zigbee2MQTT (1.40.1-1), Home Assistant Google Drive Backup (0.112.1), SQLite Web (4.2.1)

Dashboards

dashboards
11

resources
9

views
20

mode
storage

Nibe Uplink Heat Pumps

api_endpoint_reachable
ok

Recorder

oldest_recorder_run
September 12, 2024 at 21:25

current_recorder_run
September 13, 2024 at 11:34

estimated_db_size
597.86 MiB

database_engine
sqlite

database_version
3.45.3

Checklist

[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of any previous issues..

Describe the issue
Running version 0.2.1
When the integration is loading, it fails with the following error:
2024-09-13 13:47:11.324 INFO (MainThread) [custom_components.nissan_carwings] Starting Nissan Carwings integration for user=REDACTED
2024-09-13 13:47:17.698 DEBUG (MainThread) [custom_components.nissan_carwings] carwings3.get_leaf() OK: vin=REDACTED
2024-09-13 13:47:19.237 WARNING (MainThread) [pycarwings3.pycarwings3] got an empty BatteryStatusRecords
2024-09-13 13:47:19.237 DEBUG (MainThread) [custom_components.nissan_carwings] Finished fetching nissan_carwings data in 7.913 seconds (success: True)
2024-09-13 13:47:19.240 ERROR (MainThread) [homeassistant.components.sensor] Error adding entity None for domain sensor with platform nissan_carwings
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 595, in _async_add_entities
    await coro
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 823, in _async_add_entity
    original_icon=entity.icon,
                  ^^^^^^^^^^^
  File "/config/custom_components/nissan_carwings/sensor.py", line 82, in icon
    charging = self.coordinator.data[DATA_BATTERY_STATUS_KEY].is_charging
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'is_charging'

I can authenticate using the app, and I can refresh/start the climate control, but I cannot see battery information in the app.
I then checked the online version on https://no.nissanconnect.eu/nb-no/CsmVehicle/Home/VIN-HERE. The battery information isn't showing there either.
However; when I logged in, I got this warning page (originally in Norwegian) :
https://www-nissan-no.translate.goog/carwings-maintenance.html?_x_tr_sl=no&_x_tr_tl=en&_x_tr_hl=no&_x_tr_pto=wapp
Dear customer,

We would like to inform you that the NissanConnect EV app currently connected to your car will be switched off in preparation for the 2G network shutdown. This will affect the Nissan LEAF produced until 2016 and the e-NV200 produced until 2018.

The discontinuation of the NissanConnect EV app is linked to the mobile network operators' decision to shut down the 2G network, which affects all car manufacturers that use the same 2G technology.

As a result, you will not be able to use your NissanConnect services remotely through the NissanConnect EV app from April 1, 2024.

However, we can inform you that the time setting of climate control and charging will still be available directly in the car's navigation system.

We can assure you that Nissan will also continue its commitment in the future and invest in future-oriented technologies and platforms for future products.

Thank you for being a Nissan owner and for your support.

Sincerely,
Nissan

This might explain why it fails, but it seems that it might still be able to control the climate system, which is something at least. However, the integration needs to handle the missing battery data to get past the startup.
Reproduction steps
Fails consistently when loading the integration.
Debug logs
2024-09-13 13:47:11.323 DEBUG (MainThread) [custom_components.nissan_carwings] <class 'custom_components.nissan_carwings.coordinator.CarwingsDataUpdateCoordinator'> initialized with update interval 0:05:00
2024-09-13 13:47:11.323 DEBUG (MainThread) [custom_components.nissan_carwings] <class 'custom_components.nissan_carwings.coordinator.CarwingsClimateDataUpdateCoordinator'> initialized with update interval 0:05:00
2024-09-13 13:47:11.324 DEBUG (MainThread) [custom_components.nissan_carwings] <class 'custom_components.nissan_carwings.coordinator.CarwingsDrivingAnalysisDataUpdateCoordinator'> initialized with update interval 0:05:00
2024-09-13 13:47:11.324 INFO (MainThread) [custom_components.nissan_carwings] Starting Nissan Carwings integration for user=REDACTED
2024-09-13 13:47:17.698 DEBUG (MainThread) [custom_components.nissan_carwings] carwings3.get_leaf() OK: vin=REDACTED
2024-09-13 13:47:19.237 WARNING (MainThread) [pycarwings3.pycarwings3] got an empty BatteryStatusRecords
2024-09-13 13:47:19.237 DEBUG (MainThread) [custom_components.nissan_carwings] Finished fetching nissan_carwings data in 7.913 seconds (success: True)
2024-09-13 13:47:19.240 ERROR (MainThread) [homeassistant.components.sensor] Error adding entity None for domain sensor with platform nissan_carwings
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 595, in _async_add_entities
    await coro
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 823, in _async_add_entity
    original_icon=entity.icon,
                  ^^^^^^^^^^^
  File "/config/custom_components/nissan_carwings/sensor.py", line 82, in icon
    charging = self.coordinator.data[DATA_BATTERY_STATUS_KEY].is_charging
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'is_charging'
2024-09-13 13:47:19.254 ERROR (MainThread) [homeassistant.components.binary_sensor] Error adding entity binary_sensor.leaf1stev_plug_status_2 for domain binary_sensor with platform nissan_carwings
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 595, in _async_add_entities
    await coro
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 909, in _async_add_entity
    await entity.add_to_platform_finish()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1366, in add_to_platform_finish
    self.async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1005, in async_write_ha_state
    self._async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1130, in _async_write_ha_state
    self.__async_calculate_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1066, in __async_calculate_state
    available = self.available  # only call self.available once per update cycle
                ^^^^^^^^^^^^^^
  File "/config/custom_components/nissan_carwings/binary_sensor.py", line 57, in available
    return self.coordinator.data[DATA_BATTERY_STATUS_KEY].is_connected is not None
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'is_connected'
2024-09-13 13:47:19.260 ERROR (MainThread) [homeassistant.components.binary_sensor] Error adding entity binary_sensor.leaf1stev_charging for domain binary_sensor with platform nissan_carwings
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 595, in _async_add_entities
    await coro
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 909, in _async_add_entity
    await entity.add_to_platform_finish()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1366, in add_to_platform_finish
    self.async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1005, in async_write_ha_state
    self._async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1130, in _async_write_ha_state
    self.__async_calculate_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1066, in __async_calculate_state
    available = self.available  # only call self.available once per update cycle
                ^^^^^^^^^^^^^^
  File "/config/custom_components/nissan_carwings/binary_sensor.py", line 83, in available
    return self.coordinator.data[DATA_BATTERY_STATUS_KEY].is_charging is not None
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'is_charging'
2024-09-13 13:47:19.276 DEBUG (MainThread) [custom_components.nissan_carwings] carwings3.get_leaf() OK: vin=REDACTED
2024-09-13 13:47:19.279 DEBUG (MainThread) [custom_components.nissan_carwings] carwings3.get_leaf() OK: vin=REDACTED
2024-09-13 13:47:20.582 DEBUG (MainThread) [custom_components.nissan_carwings] carwings3.get_latest_hvac_status() OK: running=False, remaining_time=None, start/stop timestamp: None
2024-09-13 13:47:20.583 DEBUG (MainThread) [custom_components.nissan_carwings] Finished fetching nissan_carwings data in 1.307 seconds (success: True)
2024-09-13 13:47:21.157 ERROR (MainThread) [custom_components.nissan_carwings] Error fetching driving analysis data - KeyError: 'ElectricMileageLevel'
2024-09-13 13:47:21.158 ERROR (MainThread) [custom_components.nissan_carwings] Error fetching nissan_carwings data: Error fetching driving analysis data - KeyError: 'ElectricMileageLevel'
2024-09-13 13:47:21.158 DEBUG (MainThread) [custom_components.nissan_carwings] Finished fetching nissan_carwings data in 1.880 seconds (success: False)

Diagnostics dump
No response

The NissanConnectEV (Carwings) services seem to be down since 2 weeks or so.. Historically, I've seen the API go down for a few days, but this current outage appears to be more significant. I have attempted to contact Nissan for clarification or an update, but I haven't received any response yet.
The connectivity in the car is OK, the car can at least update the chargepoint data successfully. Let's hope that they will not really shut down the service altogether..

Sorry if it's not completely related. Didn't the Carwings service become completely discontinued earlier this year (Feb or so)? Source here.
I think you're mixing NissanConnect (which is the post early-2016 system and still usable even if server issues a few weeks ago) with Carwings (pre 2016, the one I have in the car and can't log in at all).

The service is now officially  called "NissanConnectEV" but still uses the legacy carwings API, also the official NissanConnectEV App from Nissan uses this API. This was also the reason why I have decided to use this name for the project (carwings), to distinguish it from this integration, which works for Nissan vehicles 2016+ (see README). This integration uses the "new" NissanConnectAPI which unfortunately does not work for vehicles <=2016 (e.g. Nissan Leafs 30kWh)
The carwings API (the one being used by this project) was working till sep. 3 or so, my Nissan Leaf can also download data via cellular without issues.

The service is now officially called "NissanConnectEV" but still uses the legacy carwings API, also the official NissanConnectEV App from Nissan uses this API. This was also the reason why I have decided to use this name for the project (carwings), to distinguish it from this integration, which works for Nissan vehicles 2016+ (see README). This integration uses the "new" NissanConnectAPI which unfortunately does not work for vehicles <=2016 (e.g. Nissan Leafs 30kWh)
The carwings API (the one being used by this project) was working till sep. 3 or so, my Nissan Leaf can also download data via cellular without issues.

Sorry, still a bit confused.
So is the CarwingsAPI the one <=2016 vehicles use?

This integration uses the "new" NissanConnectAPI which unfortunately does not work for vehicles <=2016 (e.g. Nissan Leafs 30kWh)

When you say "this integration", you mean the NissanConnect  one? Or yours?
Still trying to figure out if yours should work on my 2015 Leaf.
Thanks.

@Chaoscontrol
I mean, the NissanConnect integration uses the new API which is unfortunately not usable for vehicles <=2016. My integration uses the old, legacy "carwings" API for vehicles <=2016.
Currently there is an API outage since 2-3 weeks for now but we're locking forward that they will fix that.. This integration should work with your 2015 leaf as well, but, as I said, currently the API is down for some unknown reason.
sorry for the confusion :)

@Chaoscontrol
I mean, the NissanConnect integration uses the new API which is unfortunately not usable for vehicles <=2016. My integration uses the old, legacy "carwings" API for vehicles <=2016.
Currently there is an API outage since 2-3 weeks for now but we're locking forward that they will fix that.. This integration should work with your 2015 leaf as well, but, as I said, currently the API is down for some unknown reason.
sorry for the confusion :)

WOW! Amazing then. I really find it weird as all other reports I've seen claim the disconnection of the service.
Apart from the last weeks outage, how should this be connected? Where can I get those details? And I guess I should enter them into the car head unit?

@Chaoscontrol you should make sure that you car does work with the current compatible Nissan Official App (for Apple e.g. https://apps.apple.com/de/app/nissanconnect-ev/id407497029). This will require to setup an account here http://www.nissanconnect.eu, enter you VIN, wait for the approval and then you can use the credentials for the app. It this all works and the API outage has been fixed, you can also use the credentials to setup this integration.
Currently also the Nissan+YOU service seems to be buggy and unavailable, though.. you could try to contact Nissan for support..

@remuslazar I think I was in the right. Maybe this is being discontinued differently in different countries?
The Official Nissan app on Android clearly says it's only compatible with Leaf after Nov 2015.
I'm in the UK, and this is what the NissanConnect page shows. This is what I had read elsewhere.
I did create an account on Nissan+YOU, added my VIN and it added my car instantly. I just haven't been able to log in inside the car itself to Carwings.

🎉 Good news! It seems that Nissan has recently resolved the API issues. The current release now also handles cases where the API is down, by reporting the sensors with an "unknown" value rather than marking all sensors as unavailable.
Everything should be working correctly now, so I will go ahead and close this issue as it has been resolved in the latest release, as previously mentioned.

@remuslazar
I get authentication error. But I can log with the same details on Nissan+YOU website. Any idea?
What are your thoughts on my last comment about the UK Nissan official note? What country are you testing in?

@Chaoscontrol I am from Germany, at least here everything is working again since a couple of hours.
First, make sure that you are able to fetch the battery status and all that using the official working NissanConnectApp. I have only apple devices, no clue which Android version is currently compatible with your Leaf, sorry. If this all works, you can try to use the credentials to setup the integration. The integration will check if the battery status is being available after login, if this fails an error will be thrown.

@remuslazar I have strong suspicion that it might only be working in Germany or some other countries.
It's true that the Deutsch website doesn't show the Nissan notice. UK and Spain do. France doesn't either.
I have tried logging in the Nissan Connect EV app on Android and it fails to log in as well. If I try in the car itself it will probably fail as well (will try at some point).

@Chaoscontrol probably. btw: you can not use the credentials to log in using the car head unit. You can just use the VIN to register the car and to bind the car to your account, which will also require some kind of approval from Nissan. At least here in Germany did it work that way.

Ah ok that's worth knowing at least. Will save me from trying with the crappy Carwings UI in the car.
I did add the VIN as I said, but in my case it did not require any authorisation at all. It was all instant.


Change license to GPL3

Currently the code is available as an MIT license. I'm thinking of moving it to GPL3 before doing the bulk of the work. Thoughts?

I think the decision lies with you. If you decide to release it under both licenses that's also possible. The main diff IMHO is that MIT allows for commercial products to use the code.

I've decided to move to GPL 3 starting with Cinco.
The commonly raised downside of GPL is that commercial companies are concerned about including GPL'd work in their own codebase because it might mean that they may also be required to release it under GPL. This is a valid concern, of course, but not really relevant to PCBmodE as it is not a library that is integrated into other software. Commercial companies can still use PCBmodE to create PCBs as the product of the software can be licensed as they wish.
The advantage of GPL is that it prevents -- to the extent that a license can -- commercial use of the software without contributing back. I don't believe in emotions coming into licensing. If a license allows something, there is no 'fair' or 'nice' or 'bad' if someone actually complies with it. The license is the license. So if I don't want others to take the code and commercialise it without releasing their contributions -- and I do not -- GPL is my only practical choice (I wish that there were more).
Finally, KiCad is GPL licensed, and so it re-inforced my choice.
This is the second license change of PCBmodE! Versions 1 to 3 are Apache-licensed. Version 4 is MIT licensed. Those licenses will continue to apply to these versions. Version 5 (Cinco) will be licensed under GPL 3.


🎮 Game Request
Game logic and basic description
A big puzzle game and a long journey to find a lossst kid.
Includes 75 puzzles with 3 different mind-bending mechanics, plus a puzzle editor and many bonuses.
All your progress is saved automatically.
This game relies heavily on very hacky web technologies: emoji, CSS3D and interactive wav music.
Point down the features
Demo Vedio:
https://github.com/kunjgit/GameZone/assets/98798977/306e3186-b7bc-40ba-b73e-c1342c1957fa
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @Durgesh4993 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @Durgesh4993 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Add config option to get config info (eg., user/password) via config file vs environment variables

Could an option be added to collect the current required environment variables (mostly MAXSCALE_USERNAME/MAXSCALE_PASSWORD) via a config file vs requiring them to be passed with environment variables?
With a config file, one could use a fuse file system to hide the config file, however using env variables exposes the password and violates security requirements.

I would argue that storing credentials in environment variables is better/more secure practice than using plain text files (configuration files).
IMO, credentials belong to the deployment (e.g. one might use Kubernetes secrets for storing credentials). You would separate managing the code from managing the deployment, which is a preferable way.

@rvlane as Vetal said oftentimes the disk is less secure, especially when using docker or the like. If you are still interested why not give it a shot yourself with a PR?

We have customers (major cellular carriers) that search /proc structure for environment variables holding passwords and flag security violations when they are found, Granted you must have permissions to read /proc structure, but they still consider this a security violation.
We have ways to use a fuse file system to inject configuration files into a "fake" file structure to make it impossible for anyone other than the process using it to "see" the contents.  This is how we handle the mysqld_exporter and how we managed the maxscale_exporter that we used to use.  We were interested in this one because we are moving to maxscale-2.5.


Move out linesearch.jl into a separate package

Most of the things in linesearch.jl could potentially be useful in other places (Optimization.jl based solvers at least) defined here that might be more generally useful so would be nice to move it out to a separate package

I think that could make sense.


[MINOR]: Bump trunk versions to 1.2-SNAPSHOT

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-test-coverage/239/

test failures are unrelated to this change. So i'm going to merge so the scripts are updated for people needing to dual commit to trunk and 1.1


Provide way to use flow with jsx-control-statements plugin

There is a popular repo - https://github.com/AlexGilleran/jsx-control-statements
This lib gives possibility to write jsx like this:
<If condition={foo}>
   {foo.bar}
</If>

But if foo is nullable, flow can't understand that there's a check. Can I declare such checks somehow on project or jsx-control-statements level?

I think what you are looking for is covered in this issue https://github.com/facebook/flow/issues/34

Oh, thanks, sorry fo a duplicate

We can't use predicate types to handle described case, because jsx-control-statements changes semantic of JSX and introduces custom control flow.
@vkurchatkin said:

The only thing that Flow can do to make this work is support custom source preprocessing

And there's some idea from @AriaMinaei

Having flow consume an ESTree-compatible AST  would open up that possibility, and much more.

This issue is too specific, let's continue this discussion in https://github.com/facebook/flow/issues/1515


Update menyx “test”

Automatically generated by Netlify CMS

👷 Deploy Preview for xenodochial-jang-0ad7f2 processing.
🔨 Explore the source changes: 8390b2ea3a1158a4e5af320439ff2eb9787c866a
🔍 Inspect the deploy log: https://app.netlify.com/sites/xenodochial-jang-0ad7f2/deploys/6139ddc884203f0007e94a4b


Updating package dependencies

This PR simply goes through the Package.Json and updates the packages to their latest release.  It omits the ngx-bootstrap package as the beta 8 of that package appears to require additional changes beyond updating the dependencies.

If you want to upgrade to ngx-bootstrap beta 8 you have to change code in the app.module.ts as well. As of beta 8 the Ng2BootstrapModule does no longer exist since it was bad practice anyway and never recommended - it loads all modules from ngx-bootstrap.
Since aspnetcore-angular2-universal only utilizes the accordion module in its ngx-bootstrap demo code you have to change the
import { Ng2BootstrapModule } from "ngx-bootstrap";
bit to
import { AccordionModule } from "ngx-bootstrap/accordion";
In the imports section of app.module.ts you then change Ng2BootstrapModule.forRoot() to AccordionModule.forRoot().

Also, @MarkPieszak wouldn't it be good to lock the typescript version to 2.4.2?
Regarding to this comment the officially recommended version of TypeScript by the Angular team is  typescript: '>=2.4.2 <2.5'

Closing for now as we're still on 4.x at the moment.
Apologies for the mix up!


ethereumjs docker stop timeout issue

Sometimes, due to the inefficiencies of ethereumjs, it cannot stop within 15 seconds (http current timeout).
Error message:
UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=15)

Workaround solution is mentioned in this issue: https://github.com/docker/compose/issues/3927
TLDR we should set:
export DOCKER_CLIENT_TIMEOUT=120
export COMPOSE_HTTP_TIMEOUT=120

I guess the related flag for the ansible module is one of these: https://docs.ansible.com/ansible/latest/collections/community/docker/docker_container_module.html#parameter-removal_wait_timeout
https://docs.ansible.com/ansible/latest/collections/community/docker/docker_container_module.html#parameter-stop_timeout
or probably change the generic timeout:
https://docs.ansible.com/ansible/latest/collections/community/docker/docker_container_module.html#parameter-timeout

fix in here: https://github.com/ethereumjs/ethereumjs-monorepo/pull/2899

Is this still a problem @barnabasbusa ? I think we can close thise one.

Lets close it for now, and reopen/restart a new issue if we still notice this issue.


FAQ: does Citus support non-linux OSes?

Communication goals (e.g. detailed howto vs orientation)
Find out which, and list them.

Solaris?
xBSD?

Good locations for content in docs structure
FAQ
How does this work? (devs)
Example sql
Corner cases, gotchas
Are there relevant blog posts or outside documentation about the concept/feature?
Link to relevant commits and regression tests if applicable

@jasonmp85 do you know the answer to this, or point me to where I can find out? Your deb and rpm scripts are linuxy.

I mean you can run it on macOS (Homebrew), there's nominal Windows support, and I know someone built it on some BSD a while back. But I don't know what we wanna say re: "support".

Agreed, I don't think we should classify this as "supported" OS's. We don't
regularly test or run on any of them.
@Joe Nelson<EMAIL_ADDRESS>What is the genesis of this issue again?
On Thu, Aug 16, 2018 at 9:10 PM Jason Petersen<EMAIL_ADDRESS>wrote:

I mean you can run it on macOS (Homebrew), there's nominal Windows
support, and I know someone built it on some BSD a while back. But I
don't know what we wanna say re: "support".
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/citusdata/citus_docs/issues/762#issuecomment-413752250,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACeeC5PiBgVbQ4NXOlazlW-15TDFnNSeks5uRkIcgaJpZM4WAjJS
.

--
Sumedh Pathak
Co-founder and VP Engineering | Citus Data |<PHONE_NUMBER>

It came from an SE suggestion in the docs prioritization meeting:
"FAQ: do you support non-linux OSes? E.g. solaris"
The issue was not added to the prioritized list, but it was written down in the document so I registered the issue here on github.

Much as I like real Unices, this is probably not relevant for most citus users.


Fix for graph updates when key is store-generated

Fix #2238.
This is the simplest fix for failing graph update tests. It removes the cached principal key.

:shipit:

Merged fbde66dca499a516d594ed6f89a8347998d69dbc


Add new log field for negotiated ALPN Protocol ID with the client

One of the requirements for #7241.

Update: When we have ALPN support on Partial Blind Tunnel (#7511), negotiated application protocol with the client can be different from cqpv. Because the Partial Blind Tunnel makes a synthetic HTTP request internally.
Logging negotiated ALPN on the cqpv is an alternative approach, but it requires incompatible changes, so I'd like to introduce a now log field.

The change for SSLNetVC looks very small. Why don't you make a similar change for QUICNetVC? As you know it uses ALPN.

I made a change on QUICNetVConnection to record negotiated ALPN id.

If I understand correctly, I think we should use cqpv for protocol name used in a tunnel, unless you need raw ALPN protocol ID.
Sounds like you want to log protocol name used in a partial blind tunnel but current path to gather protocol name (ProxySession::get_protocol_string()) doesn't allow a tunnel to tell protocol name because a tunnel doesn't have a ProxySession (or have a fake ProxySession). Is this correct?
I don't think protocol name always has to be get from ProxySession. If you can't get protocol name from ProxySession, you can fallback to NetVC. The opposite order should be also fine, because if the both can provide human friendly protocol names those should match.

Logging negotiated ALPN on the cqpv is an alternative approach, but it requires incompatible changes

Does it? I guess cqpv is "-" or some garbage value if partial blind tunnel is used. My view is it has never logged relevant values for partial blind tunnel.
So, I'm fine with introducing the new field if somebody need raw ALPN protocol ID, but I think having one place to indicate human friendly protocol name regardless of connection type is convenient. Even if my assumption on current cqpv value for partial blind tunnel is incorrect and the change is going to be an incompatible change, we should make the change on ATS 10, IMO.

Looks reasonable.  It is unfortunate we have to have very similar logging codes.  If I'm interpreting correctly you want to different between the tunneled and untunneled cases.  Or is it the issue between "h2" and "http/2"?

If I'm interpreting correctly you want to different between the tunneled and untunneled cases.

Right, in the Partial Blind Tunnel case, the cqpv says http even negotiated ALPN id is h2, currently.

Because we already have a ton of fields, I understand the sentiment of trying to keep it fewer. But I still not sure overwriting the cqpv by negotiated ALPN id is a better approach.

Compatibility
The current value of HTTP/2 protocol, http/2, needs to be changed to h2. This involves every user who is using cqpv.

Hiding some cases
The approach hides some cases because cqpv needs to log protocol and version even if ALPN was not used.

e.g. HTTP/1.1 over TCP, HTTP/1.1 over TLS without ALPN, and Blind Tunnel. ( the cqssa says - in these cases )

I merge this PR to roll forward. We can use a piece of code from this change in case we decide to go to the alt approach.

Cherry-picked to v9.1.x branch.


Deadlink in postinstall.js

Hello,
https://github.com/squareboat/nest-console/blob/6e3e11e942637a6e6011a3133d3afa27bf327f69/postinstall.js#L21 contains a dead link to https://squareboat.com/open-source/nest-console/config.
Thanks,

I already take a look at the source code, the check for the options argument is simply done after the one for required arguments.

I already take a look at the source code, the check for the options argument is simply done after the one for required arguments.

Released in v0.0.4


User/le2tang/elevator ctrl

this PR shows a diff for many things that i dont think are related to torso and head control. its a little hard to parse through. could u fix that please?


set dns policy in csi plugin so storage class can use mons' FQDN

@gman0

LGTM, this seems like a sensible default option since we had hostNetwork: true anyway

This might also help with https://github.com/ceph/ceph-csi/issues/13? Granted the mons would be behind a DNS

@gman0 next is to create a single mon service for all mon hosts in rook, then we won't have a scaling issue.


Make PhaseScriptExecution works when SRCROOT path has whitespaces.

When trying to build with scheme "MoltenVK Package (Debug) (macOS only)" on my Mac, it failed at the end with error such as:
/Users/bertel/Library/Developer/Xcode/DerivedData/MoltenVKPackaging-bwwesylglieoalcjcxoqerjnfgqh/Build/Intermediates.noindex/MoltenVKPackaging.build/Debug/MoltenVK-macOS.build/Script-A975D59A2140586700D4834F.sh: line 2: /Volumes/Macintosh: Permission denied
Command PhaseScriptExecution failed with a nonzero exit code
This is because the name of my volume has a whitespace in it: "Macintosh SSD"
With this patch, this step is successful.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@francoisbertelatschrodinger
Good catch!
Thanks for your PR. I'll merge it once you've signed the CLA.


Pyros node is not responding

I have example code for explain my issue here
First run $ bokeh serve sliders.py at my command prompt. Then navigate to the URL http://localhost:5006/sliders in my browser.
I would to do with simple pub from ros to pyros to bokeh plot with command
$ rostopic pub /topic_line_color std_msgs/String "data: 'red'" -1 to change the line color to red and
$ rostopic pub /topic_line_color std_msgs/String "data: 'green'" -1 to change to the back green one
It's work but after I would to refresh my browser for once so I pub with the same command but nothings change.
Question?
I think about the node has been created with the same name, then what I should do to solve this.
help me! I hope my question is clear for you, please give me some advice. Thank you.

Hello,
Thanks for trying pyros and posting about this issue.
Your code also is useful, and I had a quick shot at setting it up, but got quickly stuck because I don't have a ROS setup locally anymore (since I don't work with it daily nowadays). So it is one more reason to invest time in https://github.com/pyros-dev/pyros-rosinterface/issues/14 :-)
Anyway I had a couple of hints that might be useful for your usecase :

pub/sub communication is not the same as REST/HTTP Request/Response. so two options : Either have a ROS service based interface (cleaner, interface well with most other communicating systems, like the web), or have a specific trick to bridge both communication paradigm. Pyros does the latter, which means that the last message on the topic is kept in a buffer, and sent whenever a client requests it.
From memory, there have been known ROS1 issues (not sure nowadays) with node names and topic registration/de-registration, node restarting, listeners still using old socket, and so on... You might want to check step by step that 1) ROS topics and nodes are working (check master API to list topics and so on) and can send messages between each other the way you expect, and 2) what happens when you refresh the page / restart the node/ etc. ROS1 was rarely used with, and does not support well, a "reset anytime" architecture, which is everywhere in the web nowadays.
you want to plug a debugger on the running server to be able to step through and understand what is happening when a request arrives. There is likely a small communication issue that makes it behave in an unexpected way... the refresh will resend requests to grab the message and maybe something will go wrong there.

Good luck in tracking this down, it doesn't look trivial from your description.
Let me know when you find some clue !


Use CloudFormation exports/imports

Instead of relying on Ansible to set variables, we could use CloudFormation native exports/imports

I talked about that with you and we have some limitations:

For each AWS account, Export names must be unique within a region.
You can't create cross-stack references across regions.

on the other hand, I think that is really powerful use exports/imports and clean a lot of variables...
Do we deploy in one region or in more than one?

Good points!
We don't deploy in several regions yet, but we may do it?
Another problem with exports/imports is that wimpy.deploy is no longer independent of wimpy.environment: you need to have the wimpy.environment cloudformations so wimpy.deploy can work. I don't know if that's such a good idea, because at the moment, they are independent of each other, and I think that's a good thing.


Ability to merge some config?

Is there a way to modify some part of the default config rather that overriding it?
For example, the user could want to have a default version of the cluster configuration and only change one specific field (for example specific spark_env_vars) in the env configuration.
For example, if there are these definitions in conf/base/databricks.yml
default:
    job_clusters:
        - job_cluster_key: default
          new_cluster:
              spark_version: 15.3.x-scala2.12
              node_type_id: m4.large
              num_workers: 0
              runtime_engine: STANDARD
              data_security_mode: LEGACY_SINGLE_USER
              spark_env_vars:
                  KEDRO_LOGGING_CONFIG: "/dbfs/FileStore/david/conf/logging.yml"
              enable_elastic_disk: true
              spark_conf:
                  spark.databricks.cluster.profile: singleNode
                  spark.master: "local[*,4]"
              custom_tags:
                  ResourceClass: SingleNode

and in conf/provider/databricks.yml
provider:
    job_clusters:
        - job_cluster_key: default
          new_cluster:
              spark_env_vars:
                   PROVIDER_USERNAME: username
                   PROVIDER_PASSWORD: password

then the job definition would be
resources:
    jobs:
       provider:
            name: provider
            job_clusters:
            -   job_cluster_key: default
                new_cluster:
                    spark_version: 15.3.x-scala2.12
                    node_type_id: m4.large
                    num_workers: 0
                    runtime_engine: STANDARD
                    data_security_mode: LEGACY_SINGLE_USER
                    spark_env_vars:
                        KEDRO_LOGGING_CONFIG: /dbfs/FileStore/david/conf/logging.yml
                        PROVIDER_USERNAME: username
                        PROVIDER_PASSWORD: password
                    enable_elastic_disk: true
                    spark_conf:
                        spark.databricks.cluster.profile: singleNode
                        spark.master: local[*,4]
                    custom_tags:
                        ResourceClass: SingleNode

That is a very good question. I get the use case, but I really only OmegaConfLoader from Kedro to actually load the individual config files.
And as far as I know, that overrides? I'll look into this.
Otherwise, you could take advantage of the fact that whatever is in conf is only
used to generate the resources files and then use overrides as specified in the Databricks asset bundle's documentation. I haven't tried that myself, but we could also look into that.

@npfp Do you have any suggestions on how to implement it?

Yes, Kedro's OmegaConfigLoader is supposed to merge the configs.
Beware of the merge strategy as well: https://docs.kedro.org/en/stable/configuration/advanced_configuration.html#how-to-change-the-merge-strategy-used-by-omegaconfigloader

Thx, I'll look into it then.
In the mean time, I'm giving a try to Databricks Asset Bundle variables but I'm facing collision between the OmegaConfigLoader interpolation and the databricks substitution: both use ${} and when setting a databricks variable, omega conf will try to interpolate it. Not sure yet how to bypass this.

@astrojuanlu correct me if I'm wrong, but I guess this specific issue stems from the fact that we're merging a list value and there OmegaConfLoader will replace the whole value, not just what has changed?

Maybe I'm reading too fast but is that fixed by switching to soft merging? OmegaConfigLoader does destructive merging by default (sorry if this is still unrelated)

No you are completely on point! I can't quite figure out what the difference between soft and destructive is though.
As I read it, Any configuration for that key besides that given in the overriding environment is discarded., means that any key in the dictionary will be substituted and that holds for both destructive and soft.


refactor(sdk): improve (shorten) SDK method names

Description
As a developer I want to have an SDK that has method names that are sensible and not overly verbose so that my experience as a developer is much nicer when working with Cactus through the SDK.
Check out how the OpenAPI specs allow for operationId to override the method names that are otherwise inferred from the path (which can be pretty long for plugins because they include the fully qualified plugin ID)
https://swagger.io/docs/specification/paths-and-operations/#operations
Acceptance Criteria

OpenAPI specs are refactored to have SDK method names that are no longer than 20 characters.

FYI GFI: @ty-lazar @Jeff-Ushry @twiggins120 @awadhana @Leeyoungone

I will take this!

I will take this!


audio/internal/go2cpp: Confirm that pausing and resuming a player works

It looks like the loop ends when the player pauses. Is this expected?

I might buy a switch just to make games for it. What's the dev kit process like?

I might buy a switch just to make games for it. What's the dev kit process like?

You have to get a permission from Nintendo to access documentations for Switch first.

Confirmed examples/audio worked perfectly.


#332 - mysql2+jruby support, speedup

#332

@ahorek Thank you for your contributon! But could you make sure that the build passes with jruby?

@etagwerker Yes, it works well on mri and jruby (both tested with postgres and mysql2 adapters). Different configurations should work aswell.

I can ensure rspec compatibility with jruby, but it would require many changes.

Any chance on getting this merged?

@ahorek Ok, thank you! :+1:


Can we use this package for login and signup?

Maybe nope, we don't have the API of WeChat.

Okay!! Thanks for reply


Various Catwalk Block Issues

[x] Catwalks have no hardness
[x] Catwalks sound like stone
[x] Catwalks drop no item even when broken with a pickaxe
[x] Catwalks have no localization

Mod version: 3.0.1
Forge version: 1.12-<IP_ADDRESS>3

I also just noticed that the actual block breaking deals no damage to the pickaxe? That might be normal behaviour for a block with no hardness though, I forget..

These are all fixed in v3.0.3. I should be able to release it in less than an hour

Solved in Catwalks 3.0.3. Please re-download LibrarianLib as its code specified an incorrect version in the previous build.


[TASK] Check for ipopt before running PyomoTest

Issue Description
Is your feature request related to a problem? Please describe.
TEAL test tests/PyomoTest should check that the executable ipopt exists.

For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.

[ ] 1. Is it tagged with a type: defect or task?
[ ] 2. Is it tagged with a priority: critical, normal or minor?
[ ] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[ ] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[ ] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.

[x] 1. If the issue is a defect, is the defect fixed?
[x] 2. If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[x] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[x] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[x] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

Approved to close via #65.


Pr url anonymous

The idea was to have it so you get:
.../peer_reviews/42/test which would redirect you to the appopriate submission. After everything is working, then test would be renamed to something appropriate (edit).

@WChrisK there seems to be a problem with codeviewer for images (and possibly PDFs). Try updating from master and seeing if you can replicate, and fix, this problem. @christinem would have done this before, so it would be good to consult her.

Images and PDFs are now fully functional (special thanks to Christine as well)

@christinem this has been merged in now.


Add OpenShift Control Plane Nodes as backend listeners for the Ingress LB

For scenarios where the total number of Hosts in the cluster is less than 5, the Assisted Installer will make the Control Plane Nodes schedulable by default resulting in the Ingress Operator staying in a failure state preventing the cluster bootstrap process from completing successfully.
The Ingress LB should add by default the Control Plane Nodes as backend listeners so this issue can be prevented when deploying SNO and compact clusters.
For larger clusters with (5 nodes or more), a new feature has also been introduced in Assisted Installer that allows users, as part of installation setup, to schedule workloads so that they run on Control Plane Nodes as well as worker nodes

While testing the changes for this, I ran into an issue where there is a limit to the number of load balancer attachments on an instance pool. We are trying to have 6 total attachments and the current limit is 5. I have raised a ticket requesting for the limit to be increased to 6 globally. I'm looking for a more creative workaround in the meantime.

Mentioned in a few places now, but the limit increase has been applied globally for all tenancies.


github: add github release action

To automatically build and upload static binaries upon release tag
push events.
When we push a new tag like v10.10.10, the action would build static binaries and create a new release like https://github.com/bergwolf/image-service/releases/tag/v10.10.10
Example run:
https://github.com/bergwolf/image-service/actions/runs/657438261

We can tag a release next :)


Include NetFabric.CodeAnalysis

Hi,
I want to mention that I do not have any experience with nuget packages that have dependencies. I quickly tried to fix the issue myself.
The dependency on NetFabric.CodeAnalysis is lost due the use of SuppressDependenciesWhenPacking. When setting that to true the dependency will appear in the .nupkg. There is a separate project for the file creating the package, but that package id is the same as the project where the analyzers are living in. The $(MSBuildProjectFile)* was throwing an error, so I changed that to Dummy. Because there are two projects however the Package will also consider the referenced project as a dependency of the nuget package which is not ok. I did briefly explore the possibility to merge the contents of the  .Package. together with the actual analyzers project but this would be a huge refactor.
Instead I came up with this workaround:

CopyLocalLockFileAssemblies will copy a number of assemblies to the bin directory of the package. It seems a bit ugly, but that seems to work.
Include NetFabric.CodeAnalysis in the package (via TfmSpecificPackageFile)
Rectify the build error on PackageId containing invalid characters (*$(MSBuildProjectFile)*)

This should hopefully fix #73

@robinvanpoppel Thanks you so much for this PR!


SSL Development

This article feels incomplete.  We are pushing devs to work with SSL from the beginning yet all the above is http?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1b69a4b5-2003-e7a5-97a3-59e3737ea1ef
Version Independent ID: c8fefbe8-6f9b-209a-3563-2cb51384707c
Content: Development workflow for Docker apps
Content Source: docs/architecture/microservices/docker-application-development-process/docker-app-development-workflow.md
Product: dotnet-architecture
Technology: microservices
GitHub Login: @nishanil
Microsoft Alias: nanil

Hi @napalm684 , thank you for your feedback.
Could you please share one example for us to review the specific section ? So that it would be easy for us to update the necessary details.

Hi @napalm684 , did you get a chance to look into it ? Or we can close this as of now and revisit it later.
Please share your thoughts.
Thank you.

@sughosneo sorry for the delay. I revisited the docs and for every Docker file example port 80 is exposed not 443. The Docker compose example has http URLs. Linux containers have different constraints around using the locally installed certs for development etc.
The bottom line is best practice wants us to work with SSL from the beginning but here the official docs only cover HTTP. I think we can do better as a community to document the best practices rather than the easy win setup.
Does this help?

Hello @napalm684, Yes that's clear now. Thank you for your feedback.
Most of the docker files in reference application eShopOnContainers only exposes port 80 than 443 because of the following reasons.

All of these are internal communication and will stay behind the API gateway within a secure network/subnet.
And also to avoid self-signed certificate complexity for the beginners.

Yes, for the Production or Staging scenario it's recommended to use HTTPS with a valid certificate. For e.g you may want to refer AKS TLS wiki page which talks about how to enable TLS on AKS for eShopOnContainers?`
Hope this clarifies !

Hi @napalm684 , I am closing this issue as of now. If you have any further questions, please feel free to reopen it.
Thank you


Fix rotated chair draw depth

About the PR
Chair draw depth is adjusted on the client to draw the seat back over the player when the chair is facing north. However, a logic error exists in the code that restores the original draw depth that causes the chair to be drawn on top of the player.
 Player will be drawn under chair.
This PR fixes this (issues #11478 and #10326).
Screenshots
https://user-images.githubusercontent.com/3229565/198815216-c5570db3-a447-4482-96cf-d404531ee5d7.mp4
Changelog
:cl: notafet

fix: Chairs are drawn correctly when rotated.

Uhhh thanks for contributing but this is also now the 3rd open PR to fix these bugs (#12188 & #11600). 11600 even also mentioned those issues, so the PR is linked from them.
I get the impression people reaaaaly want this bug fixed.

merge the one that does it best

please fix chairs

Mine is best because it adds comments, has the smallest code diff, and most clearly explains what's going on.

After reviewing the competing PR's, I feel that we shouldn't be letting perfection impede progress. All 3 of these PRs fix the layering bug, which is strictly an improvement from the status quo. It shouldn't be on those trying to improve things to also have to fix a loosely related bug.

Need to add comments in the code and also remove the references to the gh issues as it'll be a workaround.

Aren't these comments?

There's nothing in the code that refers to GH issues.

Anytime you use a workaround you should leave a comment so future coders know why a thing was done a particular way.

Anytime you use a workaround you should leave a comment so future coders know why a thing was done a particular way.

Added a comment.


Coordinate System is off by one for negative X coordinates

Current:
-01-01 is at the same y height as 1.0
Expected:
-0100 should be at the same y height as 1.0

This might fix the issue. Please Review.
#7


League Console adapter

I would like to implement the console-adapter for CLImate (presented by the PHP League)
So we should either rename the current console-adapter to symfony-console-adapter (prefer this) or implement both in one package and suggest.

Also, the after renaming the console adapter should be added to scrutinizer and packagist. I cannot add them, as I cannot update the Webhooks.

Most packages aren’t yet added on Packagist, on purpose (until the names have settled down).
https://github.com/portphp/league-console-adapter
https://github.com/portphp/symfony-console-adapter

Any idea for namespace? Port\Console is ambiguous this way.
Port\SymfonyConsole
Port\Symfony\Console
Port\Symfony...(ConsoleProgressWriter)
(and the same alternatives for the League)

Port\Symfony|LeagueConsole makes most sense to me.

Maybe we could leave the Console prefix from ConsoleProgressWriter and ConsoleTableWriter now, that they are in a separate package.


$.type is deprecated

Using $.type is deprecated according to the jQuery Migration 3.3.2 tool.
See: https://github.com/jquery/jquery-migrate/blob/main/warnings.md#jqmigrate-jquerytype-is-deprecated
Cause: This method returns a string that indicates the type of the argument, for example "number" or "function". However, as the JavaScript language evolves this method has become problematic because new language constructs might require this function to either return a new string (potentially breaking existing code) or somehow map new constructs into existing strings (again, potentially breaking existing code). Examples of new recent JavaScript features include asynchronous functions, class constructors, Symbols, or functions that act as iterators.
Solution: Review code that uses jQuery.type() and use a type check that is appropriate for the situation. For example. if the code expects a plain function, check for typeof arg === "function".

Thanks for your report @melloware. I'll close this in favor of #3666.

Sorry, I closed this in error thinking that it relates to #3666, which is however a slightly different problem.
In any way, thanks for your report!
I'm still considering if I will support newer jQuery versions at all, but I'll leave this open for now.

@blueimp no problem I just wanted you aware.  I think it will be remove entirely in Jquery 4.0 I have removed it everywhere in my projects for the above Vanilla JS just to make our code forward and backward compatible. Thanks for your consideration!


⚠ GitLab Server has degraded performance

In 23ab93c, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 11023 ms

Resolved: GitLab Server performance has improved in 8d6fa82.


[WIP] Pbs docker ci

Bringing this work to the attention of everyone. Should close #41.
This is not fully working yet, but I need to begin integration with Travis, and maybe have some feedback.
Locally on my computer, test_basic is passing, but its teardown fails, and I don't really know what's happening. We'll see in Travis.

Nice to see that you're making progress here. It doesn't look like travis is picking up the pbs environment in the matrix though...
Also, can you remove the following files:
dask-worker-space/global.lock
dask-worker-space/purge.lock
dask-worker-space/worker-t461kxij.dirlock

Thanks for the comment, I've cleaned up commits and removed the file.
Travis is triggered this time, we'll see how it goes.

For this failure:
    def close(self, all_fds=False):
        self.closing = True
        for fd in list(self.handlers):
            fileobj, handler_func = self.handlers[fd]
            self.remove_handler(fd)
            if all_fds:
                self.close_fd(fileobj)
        self.asyncio_loop.close()
>       del IOLoop._ioloop_for_asyncio[self.asyncio_loop]
E       KeyError: <_UnixSelectorEventLoop running=False closed=True debug=False>

I recommend using distributed master if possible

So test_adaptive is almost working on my computer: it only fails because the cluster.jobs object is not cleaned up. Otherwise, cluster is automatically scaling up and down as expected.
This is not the case on Travis though, don't know why yet.
If I manage to make it work on Travis as on my laptop, I propose to just comment the part testing if cluster.jobs is empty for now, so that adaptive cluster fix is tackled in another pull request.
Any opinion on that?

Removing that part of the test seems fine to me.

Thanks for the feedback.
I think I've reproduced the problem from Travis on my laptop, and identified its source: PBS does not manage to really finish the jobs because it cannot copy its stderr and stdout files on the master. Thus it cannot run the job from the adaptive test as the two jobs from the previous one did not release the reserved resources.
I will try to work on it on my free time.

I believe this PR is ready to be merged, does anyone have some comment?


Create 2018-05-30-introducing-bazel-cquery.md

Attempt #3 to public cquery blogpost. Jin adding you in here because I feel like you caught an issue last time!

Ah I see you've been added to config.yml, feel free to skip that :-)

Note that I also moved the original posts into _drafts while fixing the authorship issue. Please change this PR to move that file from the _drafts folder into _posts, and to apply content changes appropriately.

https://blog.bazel.build/2018/06/06/introducing-bazel-cquery.html


why first temporal and then spatial attention？

Hi,
In temporal attention, the prev_bev features are integrated into query.
In spatial attention, query is only used to generate the attention matrix, and then we get the information from the current feature map to generate the bev features.But such bev features have no prev_bev information.
What is the meaning of temporal attention here?
Shouldn't it be spatial attention first and then temporal attention?
best wishes
rui

pls help


Setup Dependabot for automatic NuGet package update PR's.

Keeping NuGet packages up-to-date is a task that is often forgotten. Dependabot is a service that automatically updates NuGet packages by opening up pull requests. This way Qml.Net's packages will always be up-to-date and this will save us some time doing it ourselves.
The service is free for open source projects.
Setup is really easy:
https://dependabot.com/

Done (for Qml.Net.csproj only).


Kubernetes manifest should not require hostNetwork

The Kubernetes manifest added in https://github.com/aind-containers/aind/pull/8 requires hostNetwork:  true for some unknown reason.
Because of this, multiple aind pods cannot be launched on a single node.
Without hostNetwork: true, anbox session-manager crashes with random cryptic errors.
root@aind-6456bcc7cb-f748g:/# unsudo bash
+ car=bash
+ shift                                                                                + cdr=
++ which bash
+ exec machinectl shell user@ /usr/bin/bash
Connected to the local host. Press ^] three times within 1s to exit session.
user@aind-6456bcc7cb-f748g:~$ export DISPLAY=:0
user@aind-6456bcc7cb-f748g:~$ anbox session-manager
[ 2020-04-13 12:53:12] [client.cpp:49@start] Failed to start container: Failed to start container: Failed to start container
[ 2020-04-13 12:53:12] [session_manager.cpp:148@operator()] Lost connection to container manager, terminating.
[ 2020-04-13 12:53:12] [daemon.cpp:61@Run] Container is not running
[ 2020-04-13 12:53:12] [session_manager.cpp:148@operator()] Lost connection to container manager, terminating.
Stack trace (most recent call last) in thread 454:
#8    Object "[0xffffffffffffffff]", at 0xffffffffffffffff, in
#7    Object "/lib/x86_64-linux-gnu/libc.so.6", at 0x7f577153a152, in clone
#6    Object "/lib/x86_64-linux-gnu/libpthread.so.0", at 0x7f57718aa608, in
#5    Object "/lib/x86_64-linux-gnu/libstdc++.so.6", at 0x7f57716fbc83, in
#4    Object "anbox", at 0x5614afcd9e69, in
#3    Object "anbox", at 0x5614afc8c9ac, in boost::asio::detail::scheduler::run(boost::system::error_code&)
#2    Object "anbox", at 0x5614afd008ad, in boost::asio::detail::reactive_socket_recv_op<boost::asio::mutable_buffers_1, std::function<void (boost::system::error_code const&, unsigned long)>, boost::asio::detail::io_object_executor<boost::asio::executor> >::do_complete(void*, boost::asio::detail::scheduler_operation*, boost::system::error_code const&, unsigned long)
#1    Object "anbox", at 0x5614afc9b40b, in anbox::container::Client::on_read_size(boost::system::error_code const&, unsigned long)
#0    Object "anbox", at 0x5614afc848a6, in
Segmentation fault (Address not mapped to object [0x18])
Segmentation fault (core dumped)

This issue is specific to Kubernetes. docker run ... does not require --net=host.

This is probably because /sys is accidentally mounted as RO: https://github.com/containerd/containerd/issues/3221


Highlight the current date for which schedule is showing

Actual Behaviour
Currently, the "schedule" tab doesn't distinguish between the dates whose schedule is clicked and visible at the moment from others, through colours. They look the same.
Expected Behaviour
When a particular date's schedule is being shown, that date should be highlighted or there should be some distinction like in "tracks" tab.
Screenshots of the issue

Would you like to work on the issue?
No, @Princu7 shall be able to solve this I think.

Closed via #1336


Minor formatting problem when moment locale is zh-cn

Steps to reproduce

Set the moment.locale('zh-cn')
Open DateTimePicker

Expected behavior
Date to be in a single line.
Actual behavior
Date takes two lines.

Hi Christopher,
Please do not ignore our issue template - in your case Environment section is missing.
I can't reproduce your issue - here's the result:
(link to playground: https://codesandbox.io/s/m3zo490r4p)

That being said, I think it would be better to change toolbar styles from justify-content: center to justify-content: space-around:

Environment
MacBook Pro OS High Sierra
Chrome Version 63.0.3239.84 (Official Build) (64-bit)
Tried Safari and it had the issue as well.
It is reproducible on the codesandbox link that you provided in my environment.

I have no idea how to fix the issue that is not reproducible for us even  on the sandbox, only one thing, that can be a problem - default fontsize of system?
So closing this issue.

Still occurs on my system.
If the H1 font size that contains the date is 2.125em it bumps down.  If the font size is 2.110em is does not bump down.
Also, if the font size is the same, but the margin-left on the H1 is -0.06em instead of -0.04em is does not bump down.
So it's definitely close.

huh, I actually can reproduce it now on 4k screen, so it's related to devicePixelRation I guess.

@cthurston I've submitted a PR, could you check if it fixes your problem?

That fixed it.  Thanks guys.


feat(cactus-plugin-ledger-connector-ethereum): add signing utils

Add methods for signing transactions to ethereum connector.
Modify offline signing test to use this new method.
Modify electricity trade sample to use new signing method.
Add offline signature section to ethereum connector readme.

Pull Request Requirements
[ ] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
[ ] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
[ ] Follow the Commit Linting specification. You may refer to this link for more information.
Character Limit
[ ] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
[ ] Commit Message per line must not exceed 80 characters (including spaces and special characters).
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

LGTM
@petermetz I think we need to reopen the pull request template and update the template so that the text boxes are rendered correctly

Current:
[ ] Option 1

Expected:

[ ] Option 1

LGTM @petermetz I think we need to reopen the pull request template and update the template so that the check boxes are rendered correctly
Current: [ ] Option 1
Expected:
* [ ]  Option 1

@jagpreetsinghsasan Agreed.


Creating a file for Fuquay Varina

This Pull Request resolves #5

:+1: looks good to me :ship: it :shipit:


Missing timezone from API request

Add Olson timezone to request.

Possibily use https://github.com/tkuchiki/go-timezone

Closed via https://github.com/wakatime/wakatime-cli/pull/612


feat: add basic test and Lint CI

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[BlockSparseArrays] Sparse and block sparse matrix multiplication

This adds support for sparse and block sparse matrix multiplication.
TODO:

[x] Test matrix multiplication of DiagonalArray and SparseArrayDOK.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0ff3110) 84.03% compared to head (5835c3e) 53.82%.

:exclamation: Current head 5835c3e differs from pull request most recent head 78b7b21. Consider uploading reports for the commit 78b7b21 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1278       +/-   ##
===========================================
- Coverage   84.03%   53.82%   -30.22%
===========================================
  Files         100       99        -1
  Lines        8540     8487       -53
===========================================
- Hits         7177     4568     -2609
- Misses       1363     3919     +2556

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Great. Does this already use the sparse tensor type in the way you were saying, with the 'elements' being dense tensors/matrices?

Yeah, that's been the design of the BlockSparseArray type in the BlockSparseArrays library.


Error: EBUSY: resource busy or locked

Filed to save “html file” :unable to write file ‘disk\folder\htmlfile’ (unknown(FileSystemError):Error:EBUSY:resource busy or locked, open ‘disk;\folder\htmlfile’)
suddenly this error occured when i make change in the code and save'

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!


Proposal: Dry::Struct.map

First of all, https://discuss.dry-rb.org/ is down.
A little pattern appeared in my code base. Have to map a collection's items to Dry::Struct objects.
So, I did a module to extend my structs and share this new feature. But in my opinion, I think this could be a common problem and we can add this new little feature to the project.
PS: Another cool feature related to this one is: create another method (or a flag to Dry::Struct.map) to symbolize string Hash keys.

https://github.com/dry-rb/dry-struct/issues/49

sorry, I don't get what this method supposed to do. @serradura could you elaborate on this?


Textual Mistake at page 7

There are multiple ways to implement observability. You can use observable classes, observable fields, or, the preferred way, LiveData. The full documentation on that is here.

We're going to use ObservableFields as they are simpler

But in the next example, Live data is used. So I think there should be changes like this.

We're going to use LiveData as they are simpler.

I agree but I think it should be:
"We're going to use LiveData as they are the preferred way"

Also the links to observable classes, observable fields direct to pages in es locale. Should be in english


[Microsoft.KubernetesConfiguration] Release .NET SDK for 2022-03-01

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

Hi @m-nash, can you please take a look at this PR to review it for merge?


Release v1.7.6

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

Waiting on https://github.com/provenance-io/provenance/pull/572 also, we won't want to merge this pr.  This is just to verify the diff for v1.7.6


Pivot handles pivot_axis=-1 correctly, tests improved

Removes error trap that excluded the pivot_axis = -1 case.
Tests of pivot cover several choices of pivot_axis.

Codecov Report

Merging #748 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
- Coverage   97.63%   97.63%   -0.01%
==========================================
  Files         113      113
  Lines       18898    18897       -1
==========================================
- Hits        18451    18450       -1
  Misses        447      447

Impacted Files
Coverage Δ

tensornetwork/backends/abstract_backend.py
95.49% <100.00%> (ø)

tensornetwork/backends/jax/jax_backend_test.py
98.48% <100.00%> (ø)

tensornetwork/backends/numpy/numpy_backend_test.py
99.20% <100.00%> (ø)

...ornetwork/backends/pytorch/pytorch_backend_test.py
100.00% <100.00%> (ø)

tensornetwork/backends/shell/shell_backend_test.py
97.36% <100.00%> (-0.01%)
:arrow_down:

...sornetwork/backends/symmetric/symmetric_backend.py
91.53% <100.00%> (ø)

...ork/backends/tensorflow/tensorflow_backend_test.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4202ae3...b9007e9. Read the comment docs.


Update Performance/Sample to register offenses when shuffle is followed with at or slice

A few of the recent Performance cops have support for at and slice. This adds the same support to Performance/Sample.

It looks like build is failing because Travis CI doesn't know about jruby-<IP_ADDRESS>. The same failure is happening in master. I'm not sure why this would have started failing recently.

Yes. JRuby build errors on Travis CI are reported below. I think that changes in this PR are not related to this build error.
https://github.com/travis-ci/travis-ci/issues/9826

Nice update! Don't forget to update this spec in rubocop-performance as well.

I didn't know that rubocop-performance had been created yet. I'll update that code as well.
What else needs to be done to rubocop-performance and rubocop to make use of separate gems?


Reconnect and new Entities

Reconnect logic improvement
Temperature sensors
Blinds/Covers integration
updated websocket-client lib

New version new Entities


feat: linear spinner

Description

Add variant prop to handle circular or linear type loader

Create linear loader

https://user-images.githubusercontent.com/117667337/230776401-40c3c809-6103-4ebe-8901-f5a4fd655f04.mov
Related Issue
Fixes #48

You should expose spinner className as well. It might be enhanced with the variant so:
.spinner--circular .spinner--linear


Local part ending with _ does not validate correctly

This implementation does not work if the local part ends with _. According to https://tools.ietf.org/html/rfc5322.html#section-3.2.4 this is permitted.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 202e3f9f-a12a-53de-9069-fd469e3dbebc
Version Independent ID: fd3699bb-4881-b6b4-1275-43eed3d5f626
Content: How to verify that strings are in valid email format
Content Source: docs/standard/base-types/how-to-verify-that-strings-are-in-valid-email-format.md
Product: dotnet
Technology: dotnet-standard
GitHub Login: @adegeo
Microsoft Alias: adegeo

Hi. This issue has been reported 😄 We're not really doing much on this article because there are endless ways to change the regex to validate an email address. We have an old discussion open at #9547

Duplicate of #16299


Feature request Proxy support via cli arg

Hi,
is it possible to add a proxy support ?
I've added "export https_proxy=my_proxy", but it fails to download
HTTPSConnectionPool(host='www.kaggle.com', port=443): Max retries exceeded with url: /account/login (Caused by NewConnectionError('<requests.packages.urllib3.connection.VerifiedHTTPSConnection object at 0x7f8e70ef6f50>: Failed to establish a new connection: [Errno 110] Connection timed out',))

Just a finding.
Might be able to pass 'proxies=' into browser.get() and browser.submit() here

Env variables are case sensitive. Do you export HTTPS_PROXY="proxy's url" or export https_proxy=my_proxy?
Since there is a way to set the proxy for the request, I'm thinking the design of this config. In the meanwhile, could you check your command?

After my investigation, to add a proxy argument will affect all browser related operations, it involves changes at least 9 locations, and will increase when we add new features.
IMO, the best way to support proxy is following the Requests' advice.
I'll add it to README.


500 error at /api/github - local variable 'affects_str' referenced before assignment

local variable 'affects_str' referenced before assignment

Reported on modo_bugs.webhooks by logged_out```
--------------------------------------------------------------------------------
Request Method: POST
Path: /api/github?
Cookies: {}
Endpoint: /api/github
View Args: {}
Person: logged_out
Referrer: None
Request Data: {}
Host: localhost:5003
Accept-Encoding: gzip
Cf-Ipcountry: US
X-Forwarded-For: <IP_ADDRESS>, <IP_ADDRESS>
Cf-Ray: 4674d31a7d73579b-IAD
X-Forwarded-Proto: https
Cf-Visitor: {"scheme":"https"}
Accept: /
User-Agent: GitHub-Hookshot/5c88274
X-Github-Event: issues
X-Github-Delivery: edc085f0-cc1f-11e8-91ab-3bfdabfc78c6
Content-Type: application/json
Cf-Connecting-Ip: <IP_ADDRESS>
X-Forwarded-Host: modo_bugs.pennydreadfulmagic.com
X-Forwarded-Server: modo_bugs.pennydreadfulmagic.com
Connection: Keep-Alive
Content-Length: 9708

--------------------------------------------------------------------------------
UnboundLocalError
local variable 'affects_str' referenced before assignment
Stack Trace:
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 2309, in call
return self.wsgi_app(environ, start_response)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 2295, in wsgi_app
response = self.handle_exception(e)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 2292, in wsgi_app
response = self.full_dispatch_request()
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1815, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1718, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/home/discord/.local/lib/python3.6/site-packages/flask/_compat.py", line 35, in reraise
raise value
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1813, in full_dispatch_request
rv = self.dispatch_request()
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1799, in dispatch_request
return self.view_functionsrule.endpoint
File "/home/discord/.local/lib/python3.6/site-packages/github_webhook/webhook.py", line 73, in _postreceive
hook(data)
File "./modo_bugs/webhooks.py", line 36, in on_issues
update.process_issue(issue)
File "./modo_bugs/update.py", line 82, in process_issue
cards = get_affects(issue)
File "./modo_bugs/update.py", line 185, in get_affects
return strings.get_cards_from_string(affects_str)

This is a modo-bugs thing.  It'd be from when I was closing issues there.


Write the rest of the infrastructure reference

This is going to be moved out of /reference/ and into concepts.


[REQ] Add a (GH-compliant) license file

Hi there, 1st of all thanks for this awesome work !
Since we've 'doxed' it in our HyMPS project (under  Collections page), can you please add a GH-compliant license file for it ?
As you know, expliciting licensing terms is extremely important to let anyone better/faster understand how to reuse/adapt/modify sources (and not only) in other open projects and vice-versa.
Although it may sounds like a minor aspect, license file omission obviously causes an inconsistent generation of the relative badge too:

(badge-generator URL: https://badgen.net/github/license/psykon/awesome-synth)
You can easily set a standardized one through the GH's license wizard tool.
Last but not least, let us know how we could improve - in your opinion - our categorizations and links to resources in order to favor collaboration between developers (and therefore evolution) of listed projects.
Hope that helps/inspires !

done

Works now, thanks !


Document how Action.Submit works in a messaging extension result

Adaptive card Action.Submit in ME result sends an "invoke" activity to the bot w/ a value. Note that this is different from the way Action.Submit works in a conversation, where it sends a "message" activity w/ a value. The docs should describe this difference in behavior.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 88ff3777-49c4-8cdc-089e-8612a8774ffb
Version Independent ID: 0d927000-0b55-2129-cbbb-6630c1ec481e
Content: Search with messaging extensions - Teams
Content Source: msteams-platform/concepts/messaging-extensions/search-extensions.md
Product: msteams
GitHub Login: @o365devx
Microsoft Alias: o365devx

"invoke" and "Action.Submit" actions on cards that were shared via an ME cards are sent back to the bot as an invoke activity with name = composeExtension/onCardButtonClicked, and value = the usual payload.


Playstate not found

Describe your problem here.
Updated to latest release, now every time I use getPropertyFromClass I can't get anything from playstate.
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No, recompiled multiple times without changing anything and still didn't work

PlayState has been moved, use states.PlayState

PlayState has been moved, use states.PlayState

Thanks, probably should’ve dug a little deeper on my end in the first place


Can i Connect yandex map through this package?

Hi I have question can I connect yandex map via your package?

Yep, actually this is a feature request. :)


cli: Implement pause and resume commands.

Add two new commands: "pause" and "resume". The first suspends all
processes in a container, whilst the second "unpauses" or resumes a
container, allowing all processes within it to continue executing.
Fixes #99, #100.
Signed-off-by: James O. D. Hunt<EMAIL_ADDRESS>

Coverage decreased (-0.6%) to 37.658% when pulling d1478f8adb1af5c32382a3e49fd326731a314bcc on jodh-intel:implement-pause+resume-commands into 97041bdbfdc1c70f4ed66c25efa969f91cae2858 on clearcontainers:master.

Coverage decreased (-0.6%) to 37.658% when pulling d1478f8adb1af5c32382a3e49fd326731a314bcc on jodh-intel:implement-pause+resume-commands into 97041bdbfdc1c70f4ed66c25efa969f91cae2858 on clearcontainers:master.

Coverage decreased (-0.6%) to 37.658% when pulling cd6625600470732ca4c70b27fc01d22c639d67d1 on jodh-intel:implement-pause+resume-commands into 97041bdbfdc1c70f4ed66c25efa969f91cae2858 on clearcontainers:master.

LGTM

rebased onmaster to stop github complaining.

Coverage decreased (-0.6%) to 37.658% when pulling 7686fcc854e15e18fd8f7dfdd711b276aab50c7f on jodh-intel:implement-pause+resume-commands into b2c4d495e88c17070ce92aa838d23d6c05071256 on clearcontainers:master.

@jodh-intel Please rebase it again, it is again out-of-date apparently.
@devimc please review this PR so that we can merge this (or not if you think we should not :) ) when the rebase will have been done.

@sboeuf, @devimc - ready for review ;)

lgtm


JA: review your-first-pwapp/index.md

What's changed, or what was fixed?

ja/fundamentals/codelabs/your-first-pwapp/index.md

Fixes: #issue
Target Live Date: YYYY-MM-DD

[ ] This has been reviewed and approved by (NAME)
[ ] I have run npm test locally and all tests pass.
[ ] I have added the appropriate type-something label.
[ ] I've staged the site and manually verified that my content displays correctly.

CC: @petele

I left special keywords untranslated and added "Translated by: Ando Yasushi" at the bottom of doc.

:tada: This has been pushed live to https://developers.google.com/web/


M3-4149 Select options not being read by JAWS

Description
I initially approached this as something that needed to be entirely overhauled- while there is more cleanup that can take place, this is a little less 'invasive', less risk towards regression. Since Option wasn't being read by SRs, I replaced the react-select 'Option' with 'ComboboxOption' from Reach. Options are now appropriately read, and focus and selection states are announced.
The one caveat you'll find is that 'blank' is read before each option- this is the underlying input for search with an empty value. I tried setting this to the selected value (or fallback text when nothing is selected) but this breaks down since its technically for the search portion of this component. Leaving as is for now until I can determine a better way to handle this.
Type of Change

Bug fix ('fix')

Todo

[x] Fix scrolling with focused item (lost this with the MenuItem wrapping)
[x] Audit all selects in all browsers/screen reader combinations (so far I've been testing with Chrome/ Edge and JAWS)

Note to Reviewers
Ideally, this should be tested using a screen reader (JAWS was the particular SR I was able to replicate the issue) feel free to message me for instructions on how to set that up. While the original request was for the Images select under Linode Create, this change impacts all selects so they're all accessible.

Closing this for now- the work for this will be more extensive than is presented here.


refactor: create proto_reader

Once https://github.com/tailcallhq/tailcall/issues/1618 is done, refactor config::reader and pull out the proto reading logic. The proto reader should take in a list of paths and return a Vec<FileDescriptorSet>.

/bounty 50$

/attempt


Why push notification gets replaced when receiving a new one ?

I have recently implemented this awesome plugin but for the last few days I am struggling with this issue  on my android device when I sent push-notification via GCM I  can see it pop ups but when I sent another again the old one is being replaced... (I am only able to see the last notification) How can I fix this ????

http://stackoverflow.com/questions/42479692/xamarin-push-notification-issue


Add shunts for Beam typehints to apache_beam.dataframe.schemas

Currently we only support mapping typing.Optional, we should also support beam.typehints.Optional.
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Extracted from #22575