Error on zsh shell launch

Describe the bug
On launch,
~                                                          at 06:16:25 PM
❯
/Users/noahgaertner/.zinit/plugins/_local---lazyenv/evalcache.zsh:source:14: no such file or directory: /opt/homebrew/Cellar/pyenv/2.0.3/libexec/../completions/pyenv.zsh
~                                                          at 06:16:25 PM
❯

To Reproduce
honestly no idea - I don't have pyenv installed (or even listed anywhere in my zshrc, I checked) - and the mentioned file is completely blank (as in there is nothing in it at all).
Expected behavior
not have that error show up
Versions:

$ZSH_VERSION == zsh 5.8 (arm-apple-darwin20.2.0)
Operating system name and version (uname -a): MacOS 12.0 Monterey Public Beta 4

It looks like you've got something called maybe lazyenv? Do an rm -rf /Users/noahgaertner/.zinit/plugins/_local---lazyenv (or mv it instead to be safe) and restart a new zsh instance, and see what the output is.

Yeah, check if you have this installed. It seems to be trying to load some pyenv related stuff, which it is unable to find.


Some rules with $document modifier work incorrectly

I'm not sure if it's a bug or just CoreLibs limitation.
Steps to reproduce

Add this rule:
||reddit.*^$document,domain=~reddit.com
Go here - https://duckduckgo.com/?q=site%3Areddit.com&ia=web
Open/Click on any link

Expected behavior
Website shouldn't be blocked.
Actual behavior
Website is blocked and if I refresh website then it's not blocked anymore.
Screenshot:

It's also not blocked if I open it directly - https://www.reddit.com/
Your environment

AdGuard for Windows version 7.6 nightly 22 (build 3500, CL 1.7.202)

See https://github.com/AdguardTeam/CoreLibs/issues/1354#issuecomment-704226271 for the upcoming changes

@sxgunchenko This rule in Base filter works nowhere: /advertisement.$~script,domain=~advertisement.solutions.zalando.com, though it works with the extension. I can give an example if you want.

Yup, it seems like I need an example.
Tried some combinations of target and referrer and it works as expected (target = t, referrer = r) :
t = http://advertisement.com/some, r = http://example.com => blocked as rule's pattern matches the target
t = http://advertisement.com/some, r = http://advertisement.solutions.zalando.com => not matched as the referrer is explicitly excluded
t = http://advertisement.solutions.zalando.com/some, r = http://advertisement.com => blocked as the pattern matches the target (see my previous comment https://github.com/AdguardTeam/CoreLibs/issues/1421#issuecomment-795527069 about target exclusion)

Maybe a little help: https://kb.adguard.com/en/general/how-to-create-your-own-ad-filters#removeheader

It seems that now, rule like this:
||reddit.*^$document,domain=~reddit.com

blocks reddit.com, but I think that it shouldn't be blocked.
Steps to reproduce

Add this rule:

||reddit.*^$document,domain=~reddit.com

Go to - https://www.reddit.com/

Screenshot

reddit.com shouldn't be blocked.

Also uBo started mark *^ in that filters as no needed due ^ no protect path after TLD/ or TLD./.

@krystian3w *^ parsed as TLD only?

uBo use gray color in highlighter, so filter writers can remove this form projects.
IMO nice will be implement enforce limit to tld for .*^ insted only mark as no power syntax.

It seems that now, rule like this:
||reddit.*^$document,domain=~reddit.com

blocks reddit.com, but I think that it shouldn't be blocked.
Steps to reproduce
1. Add this rule:

||reddit.*^$document,domain=~reddit.com

2. Go to - https://www.reddit.com/

Screenshot
reddit.com shouldn't be blocked.
AdGuard for Windows version 7.9 nightly 3 (build 3789, CL 1.8.279)

Moved into a separate issue: https://github.com/AdguardTeam/CoreLibs/issues/1579


Update data-classification-content-explorer.md

Added more licenses to the list as Microsoft f5 add-on licenses can benefit from this feature.
reference: https://docs.microsoft.com/en-us/office365/servicedescriptions/microsoft-365-service-descriptions/microsoft-365-tenantlevel-services-licensing-guidance/microsoft-365-security-compliance-licensing-guidance#information-protection-data-classification-analytics-overview-content--activity-explorer

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/7992


added current location to data sent to api

Description:
Adding the current location to the data sent to the API receiving the data from the form
Linked issues:
Related ticket
Screenshots:
NA
How to test:
Complete the form and This is the endpoint

Ready to merge


Support for the HAProxy plugin

Hi @browningluke,
While adding more automation and infrastructure to my homelab, I came across this very interesting project.
As we all have different use cases/requirements, there is unfortunately no support for the HAProxy plugin yet.
I would like to try adding the code to set up the basic components (servers, backend, frontend).
I will create a Fork for now and create a PR when I succeeded.
API Reference: https://docs.opnsense.org/development/api/plugins/haproxy.html
Thank you for the great work on this project and also for the opnsense-go API!
Best regards
Robin

Hi there @Crisu1710
That would be great! Thanks so much.


SDK files_upload sometimes ignores set filetype

Some contents are usually alright, but the one below is being transformed into wrong filetype (binary instead of text).
Reproducible in:
The Slack SDK version
slack-sdk==3.8.0
Python runtime version
Python 3.6.13
OS info
sw_vers is not found. But it is centos 7.
Steps to reproduce:
This is how I call slack_api:
CLIENT = WebClient(token=<token>)
content = '''Invalid insolvency XML: <!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n\n<title>500 Internal Server Error</title>\n\n
Internal Server Error
\n
The server encountered an internal error or\nmisconfiguration and was unable to complete\nyour request.
\n
Please contact the server administrator at \n<EMAIL_ADDRESS>to inform them of the time this error occurred,\n and the actions you performed just before this error.
\n
More information about this error may be available\nin the server error log.
\n'''
CLIENT.files_upload(
    fallback=<some_fallback>,
    channels=<some_channel>,
    content=content,
    filetype="text",
    title=<some_title>,
    initial_comment=<some_comment>,
)

Expected result:
The content above should result in text type in slack channel
Actual result:
The content above resulted in binary type in slack channel.

Hi @LukasJerabek, thanks for writing in!
I've confirmed that the same situation can arise on my end.
As a workaround, using either filetype="auto" or filetype="html" instead works more properly for you. But I agree that text parameter should work too in this scenario.
I will share this feedback with the backend engineering teams concerned.
Let us close this issue now as we are unable to track and share the progress of the server-side development in this SDK project issue tracker. To check the progress, please contact our customer support agents from either /feedback command in your Slack workspace or https://my.slack.com/help/requests/new 🙇  Thanks again for taking the time to report this issue!

Workaround using html is not possible since there is not always just this type of content. Also auto is unreliable and does not always guess the right filetype and makes result confusing, thats why I wanted to use text.  Ok, thank you for your response.


TMAX -  logo hard to see on the light background

ENVIROMENT: production
COMPANY: Tmax
URL: https://scrapers.peviitor.ro/src/tmax/index.html#
Browser: Google Chrome
Device: PC
OS: Windows10
Precondition:
The site https://scrapers.peviitor.ro/ must be open with google chrome .
Typing TMAX in the search bar.
Steps:
Open https://scrapers.peviitor.ro/
Enter Tmax in the search bar. Enter
Click the link with the name of the company.
Open the page with TMAX
Verify the box where the logo is displayed.
Expected result:
On https://scrapers.peviitor.ro/src/tmax/index.html# we can see the logo of the company well displayed.
Actual result:
Logo is hard to see because the text of the logo is white and the background has a light background

please retest after website update

Retested.Fixed


⚠ PrivateHD has degraded performance

In 5aa2d68, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 3790 ms

Resolved: PrivateHD performance has improved in 3f750a8.


Search Query - Eloquent

Summary of problem or feature request
When search is used the resulting records are getting only top 10/25/50/100 records. Also, pagination is not working on search.
Code snippet of problem
Sample of query that is getting executed
select count(*) as aggregate from (select * from tblName where status = '1' and (LOWER(tblName.col1) LIKE '%2017-01-04%' or LOWER(tblName.col2) LIKE '%2017-01-04%' or LOWER(tblName.col3) LIKE '%2017-01-04%') order by id desc limit 10 offset 0) count_row_table
System details

Operating System : Linux
Laravel Version : 5.4
Laravel-Datatables Version : 7.2

Can you please paste some code to reproduce the error?

Hi, My bad. I had the controller wrongly setup.
Had
->skip($request->input('start'))
->take($request->input('length'))
that was added the the eloquent. Once I took them out. the "Search" and the "Paginiation" on search became fine.


Is it possible to make a library that wraps a component implementation?

Say I have a component interface that is slightly too low-level for the data I would like to pass between my components: maybe it's a HashMap somewhere that I'd like to pass and have to pass as a Vec of pairs, because there's no concept mapping to hashmaps afaik in wit. So I would like to have a high-level library that wraps the implementation of a component interface, and then one or several Rust packages would use this library to implement the underlying component. I would like to be able to use cargo-component, for this.
I've tried putting the Cargo.toml annotations defining that the lib "implements a component when used" to my library crate's TOML, but then cargo-component can't find the output: failed to find output for component package *libhighlevel*. And it's right: there's no output, it's a lib; the real output would be the package using that library.
Is this something that's possible to do, as of today?

It's not currently possible as the tool assumes that every Rust package with component metadata should have a component output.
There might be a few places where we're not expecting things to work this way, but on the surface I don't think it would be that hard to implement.
To be clear, you're talking about having a Rust package that has metadata in Cargo.toml to provide it some bindings, but have it produce an rlib that can be linked into some other bin/cdylib package that ultimately outputs a component?

Thanks for your answer!

To be clear, you're talking about having a Rust package that has metadata in Cargo.toml to provide it some bindings, but have it produce an rlib that can be linked into some other bin/cdylib package that ultimately outputs a component?

I think so, but I'm not very confident in my knowledge of what's an rlib; if that's what's generated when I do cargo init --lib, then yes. Trying to reformulate: I'd like the lib to provide a ready-to-be-customized implementation of the wit interface as a Rust guest, then when that library is used by a Rust package compiled to wasm, the package would output a wasm component.

For the feature request, I think it would be along the lines of:

Allow component metadata in lib packages that aren't cdylib; only generate bindings.
Do not attempt to componentize the output of such packages (i.e. there is no .wasm output).
Ensure that linking in multiple custom sections containing wit-bindgen metadata sourced from those rlibs is properly combined when linking the final component.


Codespaces went up to 100%

What product(s) do you have a question about?
Trying to create profile portfolio  on codespaces.
What is your question?
How do I customize the portfolio website and also reduce the size of codespaces?

Additional context
No response
What is your current role?
Student Ambassador
What technical topic is this question related to?
Other

Hi @Akintunde76 kindly Regularly remove or clean up unused CodeSpaces to free up resources and prevent 100% CodeSpaces usage


dheerajsingh0:98-Bottom-section-not-aligned-with-top-ones

#98 Bottom section not aligned with top ones
i have aligned bottom section with top once

Hey There
I can not able to add anyone for code review .
Please Add a access for it or else review This PR.


allow pool associations

the pool directive was introduced in https://github.com/geerlingguy/ansible-role-ntp/pull/77
in order to work properly, the nopeer restriction should be allowed for sources
See further information:
https://github.com/geerlingguy/ansible-role-ntp/pull/77
https://bugs.ntp.org/show_bug.cgi?id=2657

https://github.com/rgsystemes/ansible-role-ntp/pull/1

https://github.com/rgsystemes/devops-box/issues/208


feat(skipDelete): add an option to skip delete at end of test run

Description of your changes

add an option to skip delete at end of test run

Fixes #
I have:

[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

would be great to cut a new release after - that we can use this

@sergenyalcin thanks aware of this


[Fix]solve sonacloud analysis issues

Purpose of this pull request
solve sonacloud analysis issues

Brief change log

solve sonacloud analysis issues

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If necessary, please update the documentation to describe the new feature.

Codecov Report

Merging #56 (b726316) into dev (2c906c1) will not change coverage.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c906c1...b726316. Read the comment docs.


List assets that belong to a user

Given a user ID, I can query for all of the files that belong to that user ID,

[ ] with a ruby script that takes the user id as an argument.

https://github.com/pulibrary/tiger-data/compare/rubocop-rebase...issues-13-jrgriffiniii-list-assets?expand=1 advances this, but I keep encountering issues with my LastPass account which I am currently attempting to resolve.

https://github.com/pulibrary/tiger-data/compare/rubocop-rebase...issues-13-jrgriffiniii-list-assets?expand=1 is working, but I am afraid that I must attend to a Samvera Community meeting before I can resume progress on reformatting this for a PR.


DSEGOG-106 adding column filtering indicator

Description
This adds a filter icon in the header of a column that is currently subjected to filtering. Strictly speaking, any Token of type channel in the appliedFilters variable is marked as subject to filtering, so if it appears in the record table, it will have a filter icon next to its header.
The wireframes also mention that it would be nice if this icon opened the filters dialogue when clicked. So I've added this as well, with the token(s) in question being highlighted briefly when the dialog box opens. To allow for this, I had to rework a lot of the functionality that allows for the filters dialog to open and lifted it into the dataView component.
Further changes include some updates to some existing tests to make them better.
Testing instructions
Mention channels in a filter input and they should appear with a filter icon when the user views that column in the table. This icon should open the filter dialog when clicked, highlighting the channel in question for a short period of time.

[ ] Review code
[ ] Check Actions build
[ ] Review changes to test coverage

Agile board tracking
Closes DSEGOG-106

I have fixed the alignment of the buttons in the data header as best I can. The intention behind it is to fix the issue where the buttons are too spaced apart by default with no styling. There were two solutions I could go with to fix the highlighted issue:
Option 1 - hover shadows are centrally aligned again but the actual icon appears lower down than the menu icon:

Option 2 - icon is horizontally aligned with the menu icon at the cost of the hover shadow being partially cut off at the top (problem being that the hover shadow of the filter icon and the menu icon are not the same size):

I decided to go with option 2, as the shadow alignment issue is less noticeable to the end user

I've fixed the issue of the column widths resetting. It was caused by the availableColumns resetting whenever the user toggled word wrap, added/removed a column, etc. Why exactly, I'm not sure. Possibly because the filters being passed to useAvailableColumns were causing a refetch of data every time? Anyway, I've moved everything back to where it was in channels.tsx and now parse the filtered channel names in recordTable.component.tsx.
A column no longer has a filtered flag in its column instance anymore as a consequence of this. So there's more of a separation between the filters and the columns now but this was how I got things to work. I could potentially add a filtered flag to the ColumnState interface but this would require modifications of the table slice and multiple dispatch calls to make the table and filters state cohesive and I just didn't see the point. Let me know your thoughts.

@sam-glendenning I've managed to make the focus ripple circular and keep things nicely aligned - you just need to wrap the button in a div. I think this is because the button isn't forced to be square but will default to square in a div (or something!). It was either that or set explicit sizes for the button which imo is worse for maintainability.

If you're happy I can commit the changes :)

Oh nice! That would be gem, thank you


Appear the following problem when running the program

This bug appears when you are creating a folder in C:/
Move the program to D:/ will solve the problem


add e2e test for pkcs11 token signing

Summary
closes #3343
Earlier e2e test doesn't have facility to test PKCS11, but this PR has the support for end-to-end pkcs11 token signing
Following commands being run to automate the e2e test for PKCS11:
sudo docker run -dit --name softhsm4 -p 2348:2345 vegardit/softhsm2-pkcs11-proxy

cd $HOME
apk update
# add git
apk add git
# clone cosign
git clone https://github.com/sigstore/cosign.git
# cd to cosign
cd cosign/
# add make pcsc-lite-libs go command
apk add make build-base go
# test
softhsm2-util --init-token --free --label "My Token" --pin 1234 --so-pin 1234
go test -v -cover -coverprofile=./cover.out -tags=softhsm,pkcs11key -coverpkg github.com/sigstore/cosign/v2/pkg/cosign/pkcs11key test/pkcs11_test.go

Release Note

Documentation

@cpanato PTAL

thanks for this pr!


Feedback on tus2 setup and configuration

Hello my fellow community members! :)
As you might be aware there is currently a lot of effort put into creating tus2, the next major version of tus, and present it to IEFT to make it a "real" HTTP standard.
Since the tus2 protocol is a completely new protocol I have created a POC for it that includes many of the changes requested to tusdotnet over the years (e.g. using BodyReader as default, the controller pattern, endpoint routing etc). This requires the new tusdotnet version to have a completely new setup system and handling and I would love some feedback on the new way of doing things!
Readme with examples on how to use the new code can be found in the POC branch: https://github.com/tusdotnet/tusdotnet/tree/POC/tus2
Feel free to post any comments/ideas here or if you're shy, just drop me an email with your comments.

Thanks for the feedback and the kind words @mayoatte! I can't take all the credit though, most of the ideas for tus2 has come from the community in different forms.

When using named configurations like so, I think the creation of the configuration should happen in the ConfigureServices method and not in Configure. Some reasons why:
Doing it in ConfigureServices might be the idiomatic way of doing this in dotnet (most other libraries including framework ones such as Authorization act this way).

I agree that this config object is not very idiomatic. My idea was not to put configuration in it but rather use it as a "glue" object to map profile names to a specific endpoint. There have been some different ideas on how to do this, e.g in #148 (long read but fantastic discussions) including using attributes on the handler (called controller in #148). The downside to this is that each handler can only be used with a single profile as attributes are more or less "static". My gut feeling says that there are use cases where one wishes to reuse a handler between different endpoints but wishes to store data differently or allow deletes for one endpoint but not another. What do you think? Another pro with using a glue object is that we can extend the object in the future without adding breaking changes for everyone. Another idea that has been floating around is to remove the object and instead specify the data directly on the MapTus2 method, e.g.
endpoints.MapTus2<MyTusHandler>("/files-tus-2");
endpoints.MapTus2<MyTusHandler>("/files-tus-2-2", "MyStorageProfile");
endpoints.MapTus2<MyTusHandler>("/files-tus-2-3", "MyOtherStorageProfile", "MyUploadManagerProfile");

The above would simplify the configuration a bit. AllowClientToDeleteFile could be a property/method on the handler which would allow more dynamic configuration similar to how this is done in tus1. For instance, one could disallow deletes while the file is being processed or similar. What do you think?

I like the storage and upload manager interfaces, they seems to combine many of the tus1 ixstore interfaces into one. Should be easier to use a blob store for the raw bytes and a db for the upload manager. I think this setup makes the idea of some kind of request handler pattern for the upload manager (get data on request start --> process --> save) more possible (would still love explicit notifications though).

Oh definitely! I didn't add this in the POC but I think it would be a good idea to add something like OnRequestStart and OnRequestEnd to the handler. Good catch!

Is AllowClientToDeleteFile related to the explicit configuration of Tus protocol extensions that we have discussed elsewhere? If so, do we need to configure explicitly per endpoint again?

The spec is open for the server to allow or disallow deletes however it feels like. My initial idea was that this would be per endpoint. See my comment above for more reasoning on how it could be solved.

Is it possible to use constructor injection for the TusHandler? When creating a custom handler that extends this one, it is difficult for someone looking at the code to know what dependencies it needs. It would be nice to be able to pass them into the constructor of the subclass and then: base(store, options, uploadmanager etc.).

I considered constructor injection but I feel like it has some downsides. For one it would require breaking changes each time we need to add something to the base controller which is not ideal. If you look at how Microsoft solves this in MVC, there are a lot of property injection for controllers (e.g. HttpContext, User etc) which in my opinion gives a good separation between what I as a developer want to inject and "helpers" that are just there to make stuff easier. Another possible approach would be to inject a kind of TusContext object which would contain the things needed (storage, upload manager, httpcontext etc) but I don't think that would make it any clearer what is actually used and not.

Maybe this has to do with the storage factory pattern? Saw a mention of that in the readme, curious as to what benefit it brings over standard DI

There are use cases in tus1 where one wants to set things up depending on things in the current request, e.g. who the current user is. A very simple example is this one:
options.AddStorage("MyProfile", httpContext => new Tus2DiskStore(new()
{
    DiskPath = System.IO.Path.Combine(tus2Configuration.FolderDiskPath, "MyProfile", httpContext.User.Identity.Name)
}));

A more complex solution could be to resolve the path from a database or select a connection string based on the current user's tenant id or similar. I'm not sure if this is solvable in a good way using standard DI as these would be much more static once created.

Awesome stuff. Thanks for all your hard work.

Thank you!

Oh no problem, you can "at" me as much as you want :)
I was very busy the last two months, sorry for the delay.

No worries at all about the delay. I just wanted to check if the issue was still active or dead. :) After implementing the code for the tus2 POC I think most of my concerns and previous comments in this thread is gone :D I've spent a lot of time in the last couple of months with the tus group working on the tus2 spec (and the POC) and the handler/controller/module pattern (I'll call it handler below due to the tus2 POC using that name) is indeed more intuitive and separating concerns more is just a win for all of us. I'll still answer your comments below, if nothing else for the sake of argument ;)

Haha i had to smile when i read this because it reminded me of Discord.NET :) This is exactly what Discord.NET has been doing! They also use kind of the same controller-like pattern and also named it "Module".
Also, I think Discord.NET is a great example of a framework which benefits from the controller pattern. I think we can learn a lot from that library.

Thanks for the link! I'll have a look and draw some inspiration.

I was thinking of things like file encryption, rate limiting, changing the metadata storage format, and any other modification of the writing process. Examples are at the end of this comment.

Fair point and good examples. These seem much easier to follow in this pattern than in the previous one (even if that isn't that hard to follow either).

Yes, i agree. But i think it is less about the functionality and more about ease of use and how intuitive the api is.
And configuring tus using a callback kinda defeats the purpose of configuration, IMO. I think configuration should be "configured once" and not be dynamically computed using a httpContext. When i first used tusdotnet, it felt kinda wrong having the application logic mixed with static configuration inside a lambda, which was one of the reasons i created the issue in the first place: to seperate application logic and configuration.

I can see that, it's a fair point. In the tus2 POC I added the functionality to both add a single configuration object or have a factory similar to how it's done in tus1. I think this was a good compromise as I know a lot of people are using the factory to create configs on the fly per user.

Most users unfortuantely don't bother to read the wiki, so it is very important to have an design that is familiar and self-explainatory and i think the controller pattern is a good choice for that.

100% agree!

Can you explain this further? I dont think that there is a bug that it shares the options, because this POC has passed all the 600 unit tests which all have different options. One core difference between the normal TusProtocolHandler and TusProtocolHandlerEndpointBased is that the former is created exacly once and the latter is created once per endpoint (and each controller has its own endpoint), so theoretically, each endpoint should have its own configuration. Correct me if i'm wrong.

This was probably an oversight on my end, sorry about that. Can't remember the issue and I can't seem to recreate the bug either so I was probably just overtired or something. Sorry for causing confusion!

Thats nice to hear! What do you think about StoreChecksumAlgorythms? At first I thought it was pretty unneccessary bu as i implemented checksum-trailers, it was pretty handy because i didnt have to keep track of caching the result of GetChecksumsAsync, and it acrtually reduced the calls to GetChecksumsAsync inside the unit tests, which i had to adjust because of this.

I hade the same first thought but I think it plays out pretty good if we can reduce the number of calls to the actual store. Can't see it happening that the store would return different algorithms on different calls. Not impossible but very unlikely.
Side note here: I have been thinking about adding some kind of "request cache" for values that should not change during a request (such as checksum algorithms). Maybe also having it updatable so that e.g. Upload-Offset could always be read from a single source and not needed to be fetched from the store each time. This isn't really a problem for the disk store but other stores might suffer from poor performance due to network calls etc. This is probably a huge change though to get it correct so it's just on the drawing board so far.

Yeah these classes still need to be cleaned up. About the differnt overloads of the storage client, some of them where simplifing usage inside a controller, and i already moved them to extension classes in my latest commit.

Nice! 👍

Agreed! The "storage operation" classes where just a temporary soultion to reduce the size of the storage client class. I focussed only on the user facing api, so internal classes may look a bit messy, sorry :) Its obvious that so many method parameters is not good code and this part of the poc definetly needs some work.

Glad to hear it :)

Thanks for pointing that out! I didnt really think of this before. The point of moving validation to TusStorageService was to make it reusable and replaceable to suit following groups of people:

Funny you should mention this as I had similar thoughts implementing the tus2 POC :D I didn't implement it this way as it's only a POC for the new protocol but I had an idea that one might want to split the validation of the request to its own interface, say ITusValidator. This implementation could then be run anywhere (or be skipped if so). The handler invoker (TusProtocolHandlerEndpointBased in your code) could just grab the validator and run the appropriate method on it depending on what intent is performed by the client. This brings me to my other thought: If you look at most of the "OnBeforeX" events they will most often look like something like this:
OnBeforeCreateAsync = ctx =>
                    {
                        // Partial files are not complete so we do not need to validate
                        // the metadata in our example.
                        if (ctx.FileConcatenation is FileConcatPartial)
                        {
                            return Task.CompletedTask;
                        }

                        if (!ctx.Metadata.ContainsKey("name") || ctx.Metadata["name"].HasEmptyValue)
                        {
                            ctx.FailRequest("name metadata must be specified. ");
                        }

                        if (!ctx.Metadata.ContainsKey("contentType") || ctx.Metadata["contentType"].HasEmptyValue)
                        {
                            ctx.FailRequest("contentType metadata must be specified. ");
                        }

                        return Task.CompletedTask;
                    },

The above is just simple validation of the request so why not allow the dev to add their own (and possibly remove built in validation) from the request pipe? This would also be doable with a separate validator interface.

I disagree. For example, I need to reuse my storage backed code accross multiple upload methods, including TUS, FTP, etc. and the modular design is very useful for me.

This is embarassing on my end that I did not think of that. 🙈 Thanks for the clarification!

With the new design, i can just inject my custom services, used for storing the file, directly into the controller and call them directly.
In the current design i would have to write an ITusStore adapter just for TUS and if i want to call ITusStore in other places, i would additionaly be > forced to, again, add custom validation on top of it, adding unneccesary complexity.

100% agree with this.

I would put it this way:

Use endpoint routing to allow us to use the built in URL parsing, authorization etc
Allow users to intercept the request flow
Decouple the tus protocol and file storage from each other
Move away from the option callback to have a different workflow
creation-with-upload only works for non-chunked transfers

100% agree again :D

Oh good catch, i missed that! Note that this POC passes all unit tests, meaning that there is no unit test which tests this behaivior. It would be a good decision to write a unit test for that.

Agree with this aswell. Unfortunately the unit testing framework in .NET is really hard to use with "real" http requests as they are all abstractions on abstractions on... . If you look at e.g. Checksum_Is_Verified_If_Client_Disconnects_Using_Trailing_Header you can see what I mean. It's not really sending a trailing header, it just pretends that it did and hopefully Microsoft's code for handling that is not broken :) The first "unit test" of checksum-trailer was really just a simple node script running requests. 🤷♂

What makes you think that? The file chunk is reverted here, which is called from here
Note that this POC passes all unit tests. If you think that the behaivior of this POC is invalid, then there is a missing unit test for it. This would > actually be an interesting aproach to improve unit test coverage: Try to make my POC fail by writing more unit tests for this library! :)

I think I hit this line when I disconnected the client and thus though it would throw an exception. Sorry about that :) After six or so years building this project I can most certainly say that detecting client disconnection is incredibly hard and fragile. I have done some fixes in the latest master so probably just and old bug on my end.

Examples of how the controller pattern solves many problems better

Great examples! All of them are much clearer and easier to use than the current solutions.

Oh and i'll need some more time to look at your tus2 implementation and give feedback, but as far as i can tell, it definetly already looks promising!

Please do! I have borrowed (read stolen ;) ) lots of your ideas from this issue and others. It uses the handler pattern, endpoint routing, pipereaders and all the new fancy features. The tus2 protocol is simpler and there are currently no extensions which make everything a bit easier.There are some discussions in this issue. Feel free to tag along!

Uh, i think you posted your reply in the wrong issue :)
Also, i have some questions about how you want to move forward:

Should i focus on discussing tus2, or do you wish to continue the discussion and the efforts to improve tus1?
Will tus1 and tus2 share the same architecture or be two seperate code-bases?

If the former, are you gonna backport the architectural changes from tus2 to tus1 or the other way around?
If the latter, will the architecture of tus1 stay roughly the same or still be open to changes?

I'll try to give you feedback about tus2 as soon as possible! :)

@SnGmng haha I totally did. So much for "answering this real quick between meetings" :D Thanks for pointing it out! I have moved my post to the correct issue.

Should i focus on discussing tus2, or do you wish to continue the discussion and the efforts to improve tus1?

I think tus2 is the future but tus1 will still be around for years to come. The tus group just recently posted our initial draft of tus2 to IEFT and our internal work has been going on for quite some time. Once adopted by IEFT anything can happen. Maybe ASP.NET Core will get built in support for tus2 in which case tusdotnet is obsolete. Only the future can tell :)

Will tus1 and tus2 share the same architecture or be two seperate code-bases?

Same code base (same lib) but probably in different namespaces. My hopes are that a backport of the tus2 architecture is possible while still supporting the events approach in tus1 (will probably not add that to tus2). Ideally there would be some kind of hybrid mode were a single endpoint can handle both tus1 and tus2 requests but I'm not sure if that is possible as the the protocols differ quite a lot. As an example, the storage implementation will differ as the stores need to support different functionality. Another example is the upload manager in tus2 which simply does not exist in tus1.

The tus2 poc pretty good overall, good work!
A bit late but here's my feedback:
Configuration
Very nice i like it!
Maybe we could also provide typed configuration in addition to named configuration (just as the IHttpClientFactory does) like this:
services.AddTus2(options =>
{
    // Default configuration
    options.AddDiskStorage("/files");
    options.AddStorage(new Tus2DiskStore(new() { DiskPath = "/files" }));

    // Named configuration
    options.AddDiskStorage("MyProfile", "/files");
    options.AddStorage("MyProfile", new Tus2DiskStore(new() { DiskPath = "/files" }));

    // Typed configuration
    options.AddDiskStorage<MyHandler>("/files");
    options.AddStorage<MyHandler>(new Tus2DiskStore(new() { DiskPath = "/files" }));
});

AllowClientToDeleteFile could be a property/method on the handler which would allow more dynamic configuration similar to how this is done in tus1. For instance, one could disallow deletes while the file is being processed or similar. What do you think?

I think it should be a method/property on the handler. In the poc from #148 it was a method which you could override method:
public override async Task<FeatureSupportContext> GetOptions()
{
    return new FeaturSupportContext()
    {
        SupportedExtensions = new StoreExtensions()
        {
            CreationWithUpload = true,
            Termination = false,
            ...
        }
        SupportedFeatures = ...
        SupportedChecksums = ...
    };
}

// or

public override async Task<FeatureSupportContext> GetOptions()
{
    var extensionInfo = await StorageClient.GetExtensionInfo(HttpContext.RequestAborted);
    extensionInfo.SupportedExtensions.Termination = false;

    return extensionInfo;
}

I dont think this is the best design, but its a starting point.
HttpContext callback
options.AddStorage("MyProfile", httpContext => new Tus2DiskStore(new()
{
    DiskPath = System.IO.Path.Combine(tus2Configuration.FolderDiskPath, "MyProfile", httpContext.User.Identity.Name)
}));

As you may know, i quite dislike this method of configuration, because it mixes application code with configuration and requires IHttpContextAccessor. In my opinion, this is the wrong way to do it.
Instead, if there is any dependency on HttpContext, the code should  always be called from the handler/controller in my opinion. Here is how its done in #148:
// (working code example of the poc from #148)

[TusController]
public class MyTusController : TusControllerBase
{
    private readonly MyOptions _tusOptions;

    public MyTusController(IOptions<MyOptions> options)
    {
        _options = options.Value;
    }

    // For simplicity, i placed this method here,
    // but in the real world this should be a method of some service or helper class
    public TusStorageClient GetStorage(string userName)
    {
        var store = new Tus2DiskStore(new()
        {
            DiskPath = System.IO.Path.Combine(_options.FolderDiskPath, "MyProfile", userName)
            //
        });
        return TusStorageClient.Create(store);
    }

    public override async Task<ISimpleResult> FileCompleted(FileCompletedContext context)
    {
        var storage = GetStorage(User.Identity.Name); // "User" is a property of TusControllerBase which translates to HttpContext.User
        var file = await storage.Get(context.FileId, HttpContext.RequestAborted);

        // ...

        return Ok();
    }

    public override async Task<ISimpleResult> Delete(DeleteContext context)
    {
        var storage = GetStorage(User.Identity.Name);

        await storage.Delete(context, default, HttpContext.RequestAborted);

        return Ok();
    }
}

TusBaseHandlerEntryPoints
The biggest problem i see is that there is a dependency on TusStorage. This prevents users from creating the TusStorage on their own, each request (like in the example code above), or replacing it.
Also i think that each method should be moved to its own class (just like the IntentHandlers from tus1)
TusHandler
I think it looks good overall, but the methods look very hard to override without calling the base class, because there is too much tus-specific code:
https://github.com/tusdotnet/tusdotnet/blob/6ff071b1442285ad7359a94d9ffc5febfc4ff7ac/Source/tusdotnet/Tus2/TusHandler/TusHandler.cs#L44-L81
I think the code (especially the extension specific code) should be inside a "bridge" class which bridges between the TusHandler and the TusStorage and is user friendly and DI friendly. (In #148, this bridge class was called TusStorageClient)
TusConfigurationManager
Very nicely done!
...except for the IHttpContextAcessor dependency which is needed for the httpContext callbacks :)
The problem with that is that the httpcontextaccessor dependency is always there, even if the user doesnt even use it.
I would just remove the httpcontext callbacks to solve this.
TusStorage
https://github.com/tusdotnet/tusdotnet/blob/6ff071b1442285ad7359a94d9ffc5febfc4ff7ac/Source/tusdotnet/Tus2/Storage/ITus2Storage.cs#L28
Agreed
https://github.com/tusdotnet/tusdotnet/blob/6ff071b1442285ad7359a94d9ffc5febfc4ff7ac/Source/tusdotnet/Tus2/Storage/Tus2DiskStorage.cs#L13
I actually tried to implement this 4 months ago :) You can view it here
Some additional thoughts
Make tus extensions open for extension (pun intended :))
In tus1, we have a lot of "if (extension supported)" kind of code:
public Task OnWrite()
{
    if (_storeAdapter.Extensions.Expiration)
    {
        // [extension code for write operation]
    }

    if (_storeAdapter.Extensions.Concatenation)
    {
        // ...
    }
}

This violates the open-closed principle (open for extension, closed for modification) because we would have to modify the existing methods to add or change the behaivior of tus extensions.
What if we replace this with an more extendable approach for example:
public Task OnWrite()
{
    foreach (var extension in configuration.Extensions)
    {
        extension.OnWrite(tusHeaders, _storeAdapter);
    }
}

// and

public class ExpirationExtension : TusExtension
{
    public override Task OnWrite(TusHeaders headers, StoreAdapter store)
    {
        // [extension code for write operation]
    }
}

public class ConcatenationExtension : TusExtension { //... }

This would allow the easy addition of new extensions without changing any existing code.
What do you think of this?

The tus2 poc pretty good overall, good work!
A bit late but here's my feedback:

Thank you! And thanks for the feedback. Your feedback is always appreciated even if we don't always agree ;)

Configuration
Very nice i like it!

🥳

Maybe we could also provide typed configuration in addition to named configuration (just as the IHttpClientFactory does) like this:

Interesting idea! Could you give an example on how this would look? Basically how the implementation and usage of options.AddDiskStorage<MyHandler>("/files"); would look like?

AllowClientToDeleteFile could be a property/method on the handler which would allow more dynamic configuration similar to how this is done in tus1. For instance, one could disallow deletes while the file is being processed or similar. What do you think?

Yeah it's a fair point. In tus2 there are no extensions but getting some kind of options object from the handler is probably a better architecture than using the "glue" object when running MapTus2.

As you may know, i quite dislike this method of configuration, because it mixes application code with configuration and requires IHttpContextAccessor. In my opinion, this is the wrong way to do it.

I know but don't agree :D Problem is that this is a real world use case where one want to fetch something from a database before setting everything up. Could be something like a tenant connection string to where to save data or similar.

Instead, if there is any dependency on HttpContext, the code should always be called from the handler/controller in my opinion.

I don't think this is a good approach as it requires the consumer to setup storage and upload manager. I would like the handler to be as easy to use as possible, a.k.a everything is already setup for you when your code is executed. A better approach might be to remove the dependency on the HttpContext and instead introduce a factory that can create both storage and upload manager. This way one could still implement it the same way if needed or just ignore it otherwise. I.e. someone needing the HttpContext to set things up could implement their own factory which takes a HttpContextAccessor as a constructor parameter. What do you think?

TusBaseHandlerEntryPoints
The biggest problem i see is that there is a dependency on TusStorage. This prevents users from creating the >TusStorage on their own, each request (like in the example code above), or replacing it.

I don't think that the user should be required to create their own storage instance. This should just work out of the box while still allowing the for a custom implementation to be used. I don't really see this as a problem. In my point of view the handler is the smallest part that you can either run using MapTus2 or inject into some other service. You can either use the handler or inject the storage and upload manager directly (and thus handle everything like disconnecting other uploads etc).

Also i think that each method should be moved to its own class (just like the IntentHandlers from tus1)

I think this would make it harder for the user to share state between methods and would work more like the events in tus1. Also it would have the same issue as the multiple interface implementation of ITusStore in tus1 where one needs to inject multiple interfaces in the same service to use it properly. I might be misunderstanding something though?

TusHandler
I think it looks good overall, but the methods look very hard to override without calling the base class, because > there is too much tus-specific code:

I took inspiration from your code but decided on to not include the extra abstraction between the handler and the StorageClient/"processor". Running base.WriteData instead of TusProcess.WriteData seems like a small diff. If you need to inject something into another service I think the handler is what should be injected as this is the container for all the tus2 code that should run. In regards to the "DI friendly" part - I agree. I think it would make more sense to move this code to here. This would require us to remove the "glue" object for MapTus2, which we want to do anyway, and replace it with something else. Maybe an attribute like in #186.

TusConfigurationManager
Very nicely done!

Thanks :) I know you hate the dependency on HttpContextAccessor but as previously said it's a vital part of real production user cases. I don't see the problem being dependent on an http context. Your are after all in an ASP.NET Core environment where the HttpContext is a vital part. Moving the factory part into its own implementation might solve this better. What do you think?

//TODO: Use RandomAccess if possible
I actually tried to implement this 4 months ago :) You can view it here

Thanks for the example! I implemented something similar as a POC but didn't find it that much faster than FileStreams on .NET6 (but honestly only tested it on Windows).
Some additional thoughts

Make tus extensions open for extension (pun intended :))

I think discussion would be better in #186 as there are no extensions in tus2. Would love to hear more about the idea so maybe we continue in #186?

I think some of my comments above are a bit hard to grasp out of context of the code. I'll see if I can get some time next week to implement some of the changes to better show what I mean. Once again, thanks for the feedback!

Me: "I will totally get some time this week to work on tusdotnet"
Narrator: He didn't.
Changes made. Please note that I have not yet updated the readme in the POC branch.
TusBaseHandlerEntryPoints
This code has been moved to an internal class, Tus2HandlerInvoker, and TusBaseHandlerEntryPoints has been removed.
As pointed out the base class does not need to know about so much tus specific stuff. The code for each action has been moved into the new Tus2StorageFacade class.
TusHandler
Code has been changed to be possible to integrate better into DI. Constructor can take either a Tus2StorageFacade or a ITus2ConfigurationManager. The reason this is still passed to the TusHandler is to reduce the number of methods that needs to be overriden in a derived class (see OnlyCompleteTusHandler). Will possibly add an empty constructor to TusHandler that can be used in cases where one wants to override every single method and not rely on the base class.
EndpointConfiguration has been removed and replaced with a call to the TusHandler constructor (or can just be ignored if one wishes). AllowClientToDeleteFile has been moved to a virtual property in the TusHandler class
TusServiceBuilder
Named storage + ongoing upload manager has been removed. Possibility to add a StorageFactory instead which supports this behavior. Example storage factory has been added to the test site project (a.k.a in user code): SimpleTus2StorageFactory
OngoingUploadManager can no longer be split between different names. I don't see this being a major feature as the ongoing upload manager is responsible for synchronizing "locks" between requests and is thus very dependent on infrastructure. Thus I don't see there being multiple managers for the same cluster/machine. We probably want to add a way of adding a type of storage, e.g. builder.AddStorage<MyStorageType>() for it to integrate better with DI.

I have updated the readme with new examples.

Hello,
thank you for your contributions!
Are there any updates about adding this to the master-branch / releasing?
I would love to use tus2 with the endpoint-configuration.
BR, Edvin

@edvinkuric This is related to tus2, the new protocol. It is currently being discussed on the IETF httpwg Github and won't be released until it's been standardized which can take some time :) I'll update the original post to make it clearer. https://github.com/httpwg/http-extensions/issues?q=is%3Aissue+is%3Aopen+resumable-upload
Maybe #147 is what you are looking for?


chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
b4db5fd -> 0e4338f

terraform-ibm-modules/common-pipeline-assets
action
patch
v1.22.1 -> v1.22.2

Release Notes

terraform-ibm-modules/common-pipeline-assets (terraform-ibm-modules/common-pipeline-assets)
v1.22.2
Compare Source
Bug Fixes

replace ORG_READER_GH_TOKEN with GITHUB_TOKEN (#693)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

Depends on https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone/pull/805 being merged first

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 5.24.2 :tada:
The release is available on:

GitHub release
v5.24.2

Your semantic-release bot :package::rocket:


bump deps

Signed-off-by: Zbynek Roubalik<EMAIL_ADDRESS>
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

/run-e2e


geopandas / Shapely / pygeos

is there a way to specifiy a certain compiler version for both?
python
import geopandas
/nix/store/5b38d34wx66pkhn7zx4sn7ias4sgvjrz-python3-3.7.6-env/lib/python3.7/site-packages/geopandas/_compat.py:88: UserWarning: The Shapely GEOS version (3.8.0-CAPI-1.13.1 ) is incompatible with the GEOS version PyGEOS was compiled with (3.8.1-CAPI-1.13.3). Conversions between both will be slow.
  shapely_geos_version, geos_capi_version_string

I don't get the error with the newest version of mach-nix:
let
  mach-nix = import (builtins.fetchGit {
    url = "https://github.com/DavHau/mach-nix/";
    ref = "2.3.0";
  });
in mach-nix.mkPython rec {
  requirements =''
    geopandas
  '';
}

Please reopen with nix expression if error still occurs

I just noticed that the error is triggered by the following expression:
let
  mach-nix = import (builtins.fetchGit {
    url = "https://github.com/DavHau/mach-nix/";
    ref = "2.3.0";
  });
in mach-nix.mkPython rec {
  requirements =''
    geopandas
    shapely
    pygeos
  '';
}

The same problem occurs with pip under python 3.8. Tested via docker run --rm -it python:3.8-slim.
Please report upstream

how to tell mach-nix the following routine
pip install --no-binary shapely shapely

I assume --no-binary means that pip will not use wheel releases which include binaries.
For linux those releases would be tagged manylinux[1|2010|2014].
mach-nix does not have such function yet. But you can exclude wheel releases in general by setting providers.shapely = "sdist,nixpkgs"
Why do you need that functionality?

I just checkt and shapely seems to not have wheel releases which do not containing binaries.
You can check it here: https://pypi.org/project/Shapely/#files
All .whl releases are platform specific and for that reason can contain binaries.
The only non-binary option is the sdist release.
Therefore the providers.shapely = "sdist,nixpkgs" will achieve the same as --no-binary in pip.

one question regarding the date of the pip db
There is a Shapeky 1.7.1 Aug 21, 2020 but this is not yet in the mach-nix pypi db (even though you updated is two days ago, right?)

how to figure out about the point in time/date of the pypi db state?

providers.shapely = "sdist,nixpkgs"
works :-) thanks again

As you probably already figured out this file references the commit of pypi-deps-db, which is currently this one: https://github.com/DavHau/pypi-deps-db/commit/c6c31fb218f67930f3d9200e67a2bff441e38788 from Mon 24 Aug 2020
You can usually assume that the commit date of pypi-deps-db includes a snapshot of everything from pypi from that date, since the crawler runs every 12h.
shapely 1.7.1 is in fact available in the current version of mach-nix. A environment with a single requirement shapely==1.7.1 resolves successfully.
It might be the case that other requirements in your environment prevent that version via their constraints.

yes, I had to change the rev

What about blosc==1.9.1?
let
  mach-nix = import (builtins.fetchGit {
    url = "https://github.com/DavHau/mach-nix/";
    #ref = "refs/heads/master";
    rev = "67184df0c2cfe6974b774bc2ca0c10970c9bab39";
  });
  py_env = mach-nix.mkPython rec {
    python = mach-nix.nixpkgs.python37;
    requirements =  ''
    blosc>=1.8.0
      '';
  };
in
(py_env.override ( args:{ignoreCollisions=true; }) ).env


Plugin to run load test for a JINI based RMISever

This is a plugin that tests a Jini based RMI Srever. Jini is the Apache River Project: https://river.apache.org/
I have implemented all the review comments provided by Felix in the previous pull request.
This was the original pull request:
https://github.com/apache/jmeter/pull/18
Thanks,
Palash.

Thanks for looking at the comments, but the most important one is still left.
I still haven't seen a jini project anywhere in real life, so please discuss the need for this plugin on the devel or user mailing list.
Regards
Felix

Hello,
Thanks for the offer of the code.
The plugin seems to the team to be rather specialized, and unlikely to be
used by many other JMeter users.
Adding code to JMeter is only part of the overall development process.
It also needs to have test cases and documentation. And support on the
mailing lists.
And the code needs to be maintained.
All of which requires developer time and knowledge of the specific API
being tested.
In the team opinion, this means that this particular plugin is better left
as a 3rd party project.
Such projects can be listed on the JMeter Wiki -
https://wiki.apache.org/jmeter/JMeterPlugins
And of course any such plugins can easily be added to a JMeter installation.
Anyway thanks a lot for your offer to contribute, we'll be very happy to integrate
any other contribution more widely used by JMeter community.
Regards
The Apache JMeter Team


feat(http-log) Add basic auth header if credentials provided

Replaces #1730

Has the documentation been updated with this new allowed field on getkong.org?


Update streamdeck-ts to 5.0.0

And the other side of https://github.com/rweich/streamdeck-events/pull/30. This should make streamdeck-ts Fully Compliant With The Official Documentation (subject to notes discussed in the events repo).
This change only bumps the streamdeck-events version to 5.0.0. As most dependents of this library use streamdeck-events transitively, I'm electing to make this a breaking change to comply with the Principle of Least Astonishment.

Codecov Report

Merging #27 (7c087a8) into main (4000939) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #27   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           10        10
  Lines          143       150    +7
  Branches         7        11    +4
=========================================
+ Hits           143       150    +7

Impacted Files
Coverage Δ

src/Plugin.ts
100.00% <100.00%> (ø)

src/pi/ActionInfo.ts
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Fix Pulsar Function localrun with multiple instances and metrics server is enabled

Motivation
Due to the recent change to Pulsar Function local run in threaded mode that exposed metrics via a metrics server:
https://github.com/apache/pulsar/pull/10156
running multiple instances in threaded mode with metrics server turned on created a situation where instances attempted to register the same metric multiple times causing an exception with text
Collector already registered that provides name ...
The above PR also started up a metrics server per threaded instance on a different port which is also not ideal.  Ideally, all metrics for all instances are exposed via single port and metrics server.
Modifications
Change the metrics code in functions/sources/sinks to allow registering metrics that already been registered. When that occurs, the existing metric will be returned from the register method.

@michaeljmarshall please also take a look

Once this is merged, it'd be great to get this in branch-2.7, if possible.

@michaeljmarshall sounds good to me.  Can you volunteer to do the backport :) ?


Benchmark

Hi Zongyi Li,
Incredible work, very interesting!
I am studying this subject in my PhD.
But I am having some difficulty in obtaining the same results as figure 2 of the article (benchmark).
Do you have the codes of the other models that you used to compare with the FNO available?
Thank you,
Joao

Figure 2 in the paper seems to be the architecture. Do you mean the experiments on Burgers, Darcy, or Navier-Stokes?

Sorry, do you mean you cannot reproduce the results of FNO on any of these datasets? or do you want to test with the baseline methods?

I already reproduce for the FNO! I would like to reproduce for the other methods, such as NN, FCN, PCAMM, RBM and LNO. Do you have this code available, for example for the 2-d Darcy Flow equation?
My goal is to obtain the results from table 4 for the different methods. Thanks

Oh I see, I see. We haven't decided to publish all the baseline methods, since they need a lot of clean-up. But if you don't mind, I can send you some of these baselines we have at hand. If that can be helpful, please let me know your email address. Thanks.

I understand perfectly, so if you don't mind, I would ask you to send it. I'm sure that it will help me. Very grateful for your help, Zongyi. My email is<EMAIL_ADDRESS>Thanks!

While I am preparing the code, please see these repositories:

For GKN and MKGN: https://github.com/zongyi-li/graph-pde
For UNets, Resnets, TF-Nets: https://github.com/Rose-STL-Lab/Turbulent-Flow-Net
The lowrank method is contained in this repostory (e.g. lowrank_2d.py)

I when send you the code for FCN, PCANN, and ROM once I gather them. Thanks!

Thank you very much! I am already analyzing the repositories you sent.
Then when you get the code for FCN, PCANN, and RBM, please send. Thanks, Zongyi!

Hi Zongyi!
I am trying to reproduce the results right now. If you don't mind, is it possible for you to send a copy of the code for the baseline results as well (if you had it)? That would be really helpful!
Best,
Kai

Same here, would appreciate a copy of the code to replicate the benchmarks to<EMAIL_ADDRESS>Thanks!

Closing as inactive. Feel free to reopen.


Unable to compile on .NET Core

Hi there,
Is the .NET Core support current? When i compile it on Mac (dotnet core v1.0.4), i'm seeing two errors:
/Users/gertjaap/NBitcoin/NBitcoin/OpenAsset/CoinprismColoredTransactionRepository.cs(84,10): error CS1061: 'HttpWebRequest' does not contain a definition for 'ServerCertificateValidationCallback' and no extension method 'ServerCertificateValidationCallback' accepting a first argument of type 'HttpWebRequest' could be found (are you missing a using directive or an assembly reference?) [/Users/gertjaap/NBitcoin/NBitcoin.NETCore/NBitcoin.NETCore.csproj] /Users/gertjaap/NBitcoin/NBitcoin/OpenAsset/CoinprismColoredTransactionRepository.cs(170,9): error CS1061: 'HttpWebRequest' does not contain a definition for 'ServerCertificateValidationCallback' and no extension method 'ServerCertificateValidationCallback' accepting a first argument of type 'HttpWebRequest' could be found (are you missing a using directive or an assembly reference?) [/Users/gertjaap/NBitcoin/NBitcoin.NETCore/NBitcoin.NETCore.csproj]
From what i understand, this ServerCertificateValidationCallback is not available on .NET Core.
Is the .NET Core support supposed to work and am I doing something wrong?

In case anyone else runs into this, here's what i did to solve this.
It wasn't actually a compile error but the auto-conversion to the new project format (csproj) was not properly setting the target framework to netstandard1.3, which lead to the preprocessor flag NOCUSTOMSSLVALIDATION not being set. This caused the code causing the error to not be excluded.
So what i did was, i changed the XML node Project/PropertyGroup/TargetFramework to netstandard1.3 like so:

     ...
    **netstandard1.3**
     ...

   ...

hey, I plan to update NBitcoin to use latest Net Core tooling. It is still using old tooling wiht project.json from https://github.com/MetacoSA/NBitcoin/tree/master/NBitcoin.NETCore
Ideally it should be all into the NBitcoin csproj in the near future.

Actually I already did that for another project. It seems easy I just need to update my script for compiling and pushing on nuget.
I use the ./PushNuget.ps1 script. Basically I just want to have 1 place where to change the version, then running the script and it build and publish on nuget.

I would be happy if you can do it yes.

It seems though that a single csproj for .NET Core and .NET Framework 4.x requires to use the new csproj format throughout; this would make it incompatible with VS 2015 and before. I'm using VS 2017 on Windows and VS for Mac (Community Edition) v 7.0.1 on Mac.

Hi @gertjaap FYI we are moving NStratis(a port of NBitcoin) to its own netstandard6 project this is in the StratisFullnode repo.
You may want to participate in that, or find out how we are doing that.

@dangershony : Could we contribute the changes made back to this project as well, then? Since you started from NBitcoin (i see its first commit is from @NicolasDorier), is there any overlap in the work so we can solve this for both projects at once?

@NicolasDorier : Is there a reason to keep supporting netstandard1.1 and 1.3 with NBitcoin? Otherwise it might be useful to target netstandard1.6 here as well?

NBitcoin was started by @NicolasDorier yes, we need portions of NBitcoin/NStratis and we don't need to support legacy thats why we go directly to netstandard1.6
Definitely the dev that will do the migration can share the steps.
This is also tracked here https://github.com/stratisproject/StratisBitcoinFullNode/issues/189

@gertjaap there is no reason to support netstandard1.6 when you can support lower.
If you support netstandard1.3 then netstandard1.6 is also supported. Basically the lower you standard you can support the better.

@NicolasDorier : OK, sounds fair. I sent a PR for the NBitcoin library that compiles to net462 (but with your comment i guess we should get that lower as well - i think net45 was the indended target?).
Do we need the NBitcoin.Tests library on netstandard1.3/1.1 as well? It is using various instances of WebClient which is not available there.

Can you give it another try with what I just pushed ?

Compiles like a charm now, both NBitcoin and NBitcoin.Tests. On .NET Core on my Mac however, the tests are not running. Get the following error:
`Test run for /Users/gertjaap/sources/NBitcoin/NBitcoin.Tests/bin/Debug/netstandard1.5/NBitcoin.Tests.dll(.NETStandard,Version=v1.5)
Microsoft (R) Test Execution Command Line Tool Version <IP_ADDRESS>
Copyright (c) Microsoft Corporation.  All rights reserved.
Starting test execution, please wait...
Could not find testhost.dll for source '/Users/gertjaap/sources/NBitcoin/NBitcoin.Tests/bin/Debug/netstandard1.5/NBitcoin.Tests.dll'. Make sure test project has a nuget reference of package "microsoft.testplatform.testhost".`
But we might open a different issue for that? (Since compiling is not the problem anymore).

@gertjaap can you try dotnet add package Microsoft.NET.Test.Sdk -v 15.0.0-preview-20170106-0 in NBitcoin.Tests folder and give it another try ?

Sorry, seeing same error after that.

more chance with .net core 2.0 ?

@gertjaap I am closing for inactivity. I guess that .net core 2.0 should works fine now, feel free to reopen if not the case.


Added API Documentation

Ready for review

@mentos can you please review when you have a moment?

Ready for review


Scrolling goes past the component internal state and the rendering is offset

I'm using VirtualScroll and I set the rowHeight as 26.5 px. Every scroll goes 53 px down, which means 2 rows. I'm debugging the onScroll and onRowsRendered values and that works OK. Past the 10th row, the scroll is still going down 53px down, but the scroll goes down 4 rows instead of 2. This is also the time the overscanStartIndex starts being more than zero. This is making the component render previous rows, and newer rows are just a blank space.
Do you have any ideas why this might be happening?

This is making the component render previous rows, and newer rows are just a blank space.

This behavior often indicates that a user forgot to include the react-virtualized stylesheet.
// Make sure to import default styles.
// This only needs to be done once; probably during your application's bootstrapping process.
import 'react-virtualized/styles.css';

If that's not the cause, I'll have to see your project to be able to provide additional insight.

I have that stylesheet included in my source file. Is there any way I can confirm that this is really working?

Look for the CSS class .Grid or .Grid__cell in your bundled CSS to confirm it's being included successfully I guess. :)
Let me know when you have something I can take a look at.

Going to close this issue for now since I'm pretty sure the issue isn't in react-virtualized. But I could be wrong- in which case I'll keep watching for comments and re-open the issue. :)
Might help if you could provide me a Plunker or something so I can see what's happening.

Here is a Plunker you can fork that has React Virtualized loaded and supports JSX syntax: https://plnkr.co/edit/6syKo8cx3RfoO96hXFT1

Thanks, I'm trying to reproduce the bug there.
Do you know how to include react-addons-shallow-compare in Plunker? I'm using react-virtualized 7.12.1 (with React and  react-addons-shallow-compare 15.1.0).

Forget about my last post, it seems the css in not being included in the bundle. Is there anything else I should consider? I'm including that same line in the initial jsx file.

Fixed it. I didn't have style-loader.

Glad to hear you've fixed it! :)
On Jul 11, 2016 7:29 PM, "ivanfryda"<EMAIL_ADDRESS>wrote:

Fixed it. I didn't have style-loader.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/bvaughn/react-virtualized/issues/308#issuecomment-231698428,
or mute the thread
https://github.com/notifications/unsubscribe/AABznWk714LZrgmlY9RUuNgkDHKnwP5qks5qUhsBgaJpZM4JH-9D
.


Copy monomorphization from compiler to services

For reference, this pulls in #57703 so we can run compiler perf tests; the thing to compare to is: https://github.com/microsoft/TypeScript/pull/57703#issuecomment-1986571844
I did no analysis; just copy pasted. Will try a deopt run later but I suspect that copying it will be enough.

@typescript-bot perf test this

After the results come back, I'll try and rebase this PR such that it targets a branch that has the tsc change in place. The benchmark system is smart enough to compare a PR against its target branch so that will provide better results than comparing two negative results to see which one is less negative.
(I am liking what I'm seeing in the logs so far, though.)

@typescript-bot perf test this

Those results are a lot better than https://github.com/microsoft/TypeScript/pull/57703#issuecomment-1986571844.

Yessss

Hm, that lost all of the emit speed, without changing memory usage. Not great.

I... tested the wrong allocators.

FWIW comparing https://github.com/microsoft/TypeScript/pull/51682#issuecomment-1340222198, this increase memory is not unexpected. Maybe it's fine; this benchmark is already extra strange because I'm emitting stuff, which won't happen in tsserver... normally anyway.
I feel like if https://github.com/microsoft/TypeScript/pull/51682#issuecomment-1340222198 was "good", then this PR is good.

@typescript-bot perf test this

The _children change appears to have even more greatly improved tsserver performance. Awesome.

The _children change appears to have even more greatly improved tsserver performance. Awesome.

Unfortunately, it also came with an even greater memory cost. About 1% on top. I can't show the diff because the benchmarks ran on different machines so aren't comparable like that.

I'm marking this as ready to review, but I'll need to retarget main beforehand once we decide what variant of this we think is right.

I am curious if we end up with multiple maps for NodeObject due to how _children is allocated, since it starts as [] before nodes are added.

When I look at the deopt explorer, it sure seems like there's still only one, ignoring the extra one that's from the SourceFileObject extension.

Oh scratch that, I'm running it as tsc, which never even asks for the children, so I can't observe that.

@typescript-bot perf test this

Uh, that's not good. I guess the WeakMap thing makes things very bad, which is very confusing because tsc never asks for them?

Oh, the emit always assigns it an undefined value, so every single object creation now includes a map write.

@typescript-bot perf test this

Oh, this perf result will be bogus as it's totally broken. Oops.

It turns out that _children is referenced all over the place; simply making it a private prop or weak map is not good enough because it has to be reset and such all over. I'm going to rebase to do the "right" thing just to test, but it's quite invasive.
I have at least confirmed that the object size is increasing when I add _children. And using append for createChildren does not currently help: #58064  (but may after this PR?)

@typescript-bot perf test this

@typescript-bot perf test this

@typescript-bot perf test this

@typescript-bot pack this

The above looks exactly as expected for this PR targeting main; no change to tsc (it doesn't use this code), and all benefit for tsserver.

The benchmarking system now includes a benchmark for simulating tsc via the public API; testing:
@typescript-bot perf test this

Now that the benchmarker can test the public API as tsc:


1.x abstract ipc frontend

Should be the finishing touches on the abstractions to encapsulate IPC front-ends.

Thanks for getting the review done so quick @lugong & apologies for the sloppy formatting. Should be all fixed up. I'll merge it once the build shows up green.


In CentOS 7, the libevent-devel dependency is needed to be installed for mesos SSL build.

In  the link (https://github.com/apache/mesos/blob/master/docs/getting-started.md), it should be a proper instruction once user want to build a SSL mesos. Right now, it is missed.

OMG, it is need rebase.


crash caused by CPM?

As noted in #313, at least on my machine (Ubuntu 21.04) I can reliably reproduce the SEGV in YAML::LoadFile() call just by the order of the CPMAddPackage() calls in ThirdParties.cmake.
What is definitely suspicios is the following:

Have a look at the line -- CPM: libunicode: adding package yaml_cpp ....
The other CPM lines look different, i.e. they don't mention two different package names.
It might very well be a bug from CPM.cmake? At least the fact that the order changes the behavior does not sound quite right.  /cc @data-man (this is a tracker ticket).

Sorry, my system is now broken after the nightly update (I'm writing from the live OS). :(
I will look into the problem as soon as I fix my system.

@christianparpart can you check https://github.com/jbeder/yaml-cpp/pull/1011 in your system?

Hey. I will. Currently our ISP decided to take nature as excuse for taking me offline though. :)

We do not use CPM anymore


📝[Docs]: Add GitHub Desktop Contribution Instructions

What Docs changes are you proposing?
Provide a clear description of the changes you're proposing for the documentation. Are you suggesting corrections, clarifications, additions, or updates?
I am interested in contributing to the project by adding detailed instructions on how to contribute using GitHub Desktop.
Why do the Docs need this improvement? What is the motivation for this change? How will this change benefit the community?
Explain the motivation behind the proposed changes and how they will benefit the community or users of the documentation.
I believe that by providing clear and comprehensive guidance, we can encourage more contributors to participate in the project, especially those who prefer using GitHub Desktop for their contributions.
Describe the solution you'd like
Provide a clear and concise description of the changes you'd like to see implemented in the documentation.
I am interested in contributing to the project by adding detailed instructions on how to contribute using GitHub Desktop.
I believe that by providing clear and comprehensive guidance, we can encourage more contributors to participate in the project, especially those who prefer using GitHub Desktop for their contributions.
Could you please assign me the issue related to adding GitHub Desktop contribution instructions under gssoc24? I am excited about the opportunity to contribute to the project and help streamline the contribution process for others.
Describe alternatives you've considered
If you've thought about alternative approaches or solutions, briefly describe them here.
Additional context
Add any additional context, examples, or screenshots related to the proposed documentation changes.

@PradnyaGaitonde go for it


Release is responsibility of conn now

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is 60.00%.

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   83.12%   83.12%
=======================================
  Files           4        4
  Lines         243      243
=======================================
  Hits          202      202
  Misses         30       30
  Partials       11       11

Impacted Files
Coverage Δ

gue.go
87.00% <60.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a10eeb...16de1da. Read the comment docs.


Responding to keyboard events

I was wondering if there is a way to use keyboard events to call the update method in this framework. I looked through the documentation and examples and didn't see anything related to this. Thanks!

Hello, I've done this with subscription adapted it from Game of life example here.
You can find working program here (and link to code sample here). It was my first FuncUI program so many things may have been done wrong.
        let keyDownHandler _ =
            let sub dispatch =
                this.KeyDown.Add (fun eventArgs ->
                    match eventArgs.Key with
                    | Key.Up -> Game.Message.Up
                    | Key.Down -> Game.Message.Down
                    | Key.Left -> Game.Message.Left
                    | Key.Right -> Game.Message.Right
                    | Key.Space -> Game.Message.Pause
                    | Key.F2 -> Game.Message.NewGame
                    | _ -> Game.Message.Empty
                    |> dispatch)
                |> ignore
            Cmd.ofSub sub

Awesome, this worked perfectly for me. Thanks for the help!


Dashboard redesign

The dashboard which comes with Nakama server was re-enabled in the 1.0.2 release ahead of a redesign. This issue tracks design requirements and requests from the community for what they'd like to see in the reworked dashboard.

The most important thing, which dashboard will do is retrieving information from database through server requests. In which case else dashboard will be useful? For getting main information about configuration, managing access to server from client (I don't think you can update everything on fly, sometimes you will need to tell users that server will be updated and you can set server status from dashboard) checking server health and etc.
But, returning to the feature of reading database, of course, every project will have different data, which is stored in database and you cannot make all possible database requests by default for dashboard. In this case, it will be perfect to have possibility to add/make custom modules (in Go language in our case), like Django web-framework to work with data (read, add new records and etc) from cockroach database or collections.
In other words, may be we can use some existing web-frameworks to make data managing from dashboard much simple than fetching records from CLI? I think, this is would be main advantage of dashboard.

Definitely the ability to edit the all data, without needing to do it via code. See all the players and their data, and be able to edit it. Easy way to set remote config.
See Playfab cloud service how a decent dashboard should look like, although theirs is too complicated imo, better to keep it simple.

although theirs is too complicated imo
Exactly. Because they trying to predict every case in every game project. But most of modules you will never use. That's why custom modules is better solution in this case with open-source project.

There are a few different things mentioned in here that touch upon various aspects of a dashboard. Typically the point of an embedded dashboard is to allow operators to inspect the running state of the application, make configuration changes (and potentially apply them on the fly), and get a sense of what the system performance is like.
An example is RabbitMQ's embedded dashboard that exposes metric information, lets you configure exchanges and queues and other config options like setting policies and so on. This is similar to CockroachDB's embedded dashboard that exposes only metrics.

Definitely the ability to edit the all data, without needing to do it via code. See all the players and their data, and be able to edit it. Easy way to set remote config.

This is an entirely different dashboard domain. User management, views for supporting staff, different user logins with different access control levels, setting up live events and remove configuration will not be part of an embedded dashboard. What you are looking for is a live-ops dashboard which we are providing as a different product entirely and won't be part of Nakama.
Having said all of this, we are listening to the community and we will add read-only views to fetch some basic information from the database. This is purely to help developers when they are building their project with Nakama.

Ah I see.  Will the live ops dash be available as a standalone addon for nakama or just on your cloud or..?

@milox The LiveOps Dashboard is a standalone product that works with Nakama, and has a modular layout as @haones mentioned so that custom views can be added based on needs. It works with our cloud option and can also be deployed on your own.

After getting quite excited about giving Nakama a try, I was a rather disappointed to see that the dashboard for the open source server was just an 'it's up' screen, without even a log viewer or configuration options, let alone basic data viewing/editing.  And it seems that there's currently a lack of GUI tools for working directly with CockroachDB, too.
What you've branded as the 'LiveOps Dashboard' looks like an important part of the development process too. But with no pricing information on your website, it seems like a case of 'if you have to ask, you can't afford it' (to a solo indie developer, at least)?

@bluescrn we’re using Nakama as an indie studio and it’s installed on our free Azure subscription, which we got through BizSpark program.
Anyhow, we also needed to able to change the data in the DB, so we just put together a very simple HTML, node.js + Lu’s module, if you want I can share that with you.
It’s quite basic but it does do the job :)

@ulasbilgen Please do share with everyone

@ulasbilgen Right now, I'm mostly just weighing up the options out there for a back end for a small project, but yes, it looks like building some custom tools would be on the list of things to do if I went with Nakama.
(I guess theoretically, there could be an open-source effort to build an enhanced dashboard - but it seems wrong to encourage this if it's going to undermine the business model of Heroic Labs)

The initial release of the new Developer Console was added in the 2.5.0 release.


Prevent being able to set skeleton bone's parent as itself

This PR prevents being able to set a skeleton's bone's parent as itself. Previously, this caused an infinite loop when trying to run Skeleton::unparent_bone_and_rest.
Resolves #52875

This seems relevant to fix in the master branch too, the code is the same.

Should I create another pull request to fix that?

Yes, that would be great :)

@TokageItLab

It seems sensible.

Thanks!

Cherry-picked for 3.3.4.


revel build fails when vendoring revel binary

when I vendored revel binary and github.com/revel/revel in project vendor folder, revel build fails and output this error.
ERROR 2016/08/26 06:05:38 revel.go:317: Failed to find Revel with error: cannot find package "github.com/revel/revel" in any of:
        /usr/local/go/src/github.com/revel/revel (from $GOROOT)
        / ... /src/github.com/revel/revel (from $GOPATH)

This comes from calling build.Import with second arg being empty string.

looking at the code, this should now work, please reopen if it is still an issue


Fix error reporting text

Coverage decreased (-0.06%) to 85.889% when pulling d4cbe2735d5f28b34dcd22b6835bd625baf6b22e on Tobbe:err-report-text into 4fcd86e05460fbf605bb2508bf7e4056b0cb0c17 on tessel:master.

Thanks!


feat: media-type-profile parameter for agent-sdk rest and wasm

Signed-off-by: Filip Burlacu<EMAIL_ADDRESS>

Closing, duplicates work in #297 and isn't needed before that's merged


Update springboot templates to Spring Boot 3.0

add needed buildEnv properties
add class to register runtime hints for MessageUtils.MessageStructureWithCaseInsensitiveHeaderKeys
update README files

Signed-off-by: Thomas Risberg<EMAIL_ADDRESS>
Changes

:broom: Update springboot templates for Spring Boot 3.0
:bug: This fixes build issues that will happen after anonymous access to repo.spring.io/release is turned off Jan 26, 2023

/kind enhancement

Fixes #1470

Release Note

The springboot templates have been updated to use Spring Boot 3.0 and the new Spring 6.0 AOT support. Note: this requires Java 17 when building locally.

Docs

The only E2E test to fail was the OnCluster TestRuntime/node_s2i_test, which failed with:
Error: failed to run pipeline: function pipeline run has failed with message:
...
error creating build container: copying system image from manifest list: writing blob: storing blob to file "/var/tmp/storage2885866326/3": happened during read: unexpected EOF

This seems transient to me so I'll re-run the failed tests now.

/cc @salaboy

/lgtm
/approve


Why is there a python on a js oriented test page?

Just wonder.

this was used for the server side of the mindelay feature, which I deleted a couple of days ago, thus resolving your problem :)


code review

Don't assert, then catch assertion, this is very expensive at runtime
exit(1) would prevent any calling function from reacting to invalid input, either propagate/raise an exception, or handle the error
return the value, not just the p value

@kakumarabhishek


Relaunch Hacktoberfest page

We need to add the Hacktoberfest page back up into the site:
https://github.com/Comcast/Comcast.github.io/blob/main/hacktoberfest.html

Clear the contributors from last year
Make sure all of the text says 2020 where it says 2019
Update the image header to be: https://github.com/Comcast/Comcast.github.io/blob/main/img/hacktoberfest_logo_2020.png
Add the page to the main site via a linked banner at the top containing this blurb "Hacktoberfest is back!  Comcast is proud to participate in the Digital Ocean Hacktoberfest initiative.  Click here to learn more"

I've updated the banner from the 2019 one to the 2020 one. I've also updated where it says 2019 to 2020.
The contributors from last year still need to be cleared, and the participating repos/PRs/issues need to be updated to reflect this year as well. They are from last year. I think the script needs to be updated to reflect 2020 contributors, PRs/issues/ and stats, we can then link to the main page.


can u add example of env pls

hm

I added a readme wich should cover all relevant information.
But please be aware that this project is still verry work in progress and saving data from the dashboard will maybe not work.


Fix problem with app not work when notifications are off

Fix problem with app not work when notifications are off

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

[ ] Unit test(s)
[ ] Integration test(s)
[ ] Tested manually

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] I have checked my code and corrected any misspellings
[X] I have added frontend code and checked it for mobile & desktop

Task linked: CU-862jev0dg Application not work when notifications are off


Mark missing argument errors as unlikely

This ensures that the CPU's branch predictor will take the most likely branch when the function is run for the first time (in that situation, the branch predictor has no prior information about which branch is more likely).

ensures that the CPU's branch predictor will take the most likely branch

Not necessarily, but it can have an impact on the code structure that the C compiler generates. Probably worth doing.
Thanks

Thank you!


facets: New parameter, RECORDS_REST_FACETS_FILTER, to filter the face…

…ts based on a category based on all the other categories
:heart: Thank you for your contribution!
Description
This is inspired by the work of @ParthS007  here
The idea is to offer the possibility to apply the filters to the aggregations. As an example:

Imagine a search with two different categories,  cat1  and cat2.
The user selects cat1=value1
The current options are that either that selection is applied to the results, and the aggregation (standard filter), or only to the results (post_filter).
This PR introduces a new option, where the filter is applied to the results, and to all the other aggregations (in the example, the aggregation of cat2 will return only the entrie that satisfy cat1=value1, but the aggregation for cat1 returns everything.

Tests are failing: it might be that you first want to have the changes validated?


Extension contributed tasks don't get added to recently used tasks

An extension contributed task gets a recently used key that notes that it is contributed.
However, now when recently used tasks are displayed we show them in the same way that tasks.json tasks are show (because that's the way we store them as recently used).
This means that the key that the task is saved with doesn't match the key that we try to access it with later.
The fix is to save the task as recently used with the correct custom key instead of the incorrect contributed key.

To verify:

Open a folder with contributed tasks, such as the vscode repo folder
Run the Run Task command
Choose an extension contributed tasks, such as a typescript compile task from the typescript section. It doesn't matter if the task passes.
Run Task again. Verify that the task you just ran is now in the Recent Tasks section.


Overlapping Text

Describe the bug

Expected behaviour
The text comment and login is overlapping thus we cannot see the text beneath it. Please assign it to me under gssoc'23. I want to work upon this issue
Screenshots
No response
Additional context
No response

Oh, I think you tried one of the preview links given in the PRs.
You won't find that option in the production/main link i.e. https://your-jarvis.vercel.app/ @akanksha984

@akanksha984 , I  want to work on this issue please assign me this


2024-03 Latest Health LLM

LLaVA-Med: Training a Large Language-and-Vision Assistant for Biomedicine in One Day
MEDITRON-70B: Scaling Medical Pretraining for Large Language Models
Polaris: A Safety-focused LLM Constellation Architecture for Healthcare

LLaVA-Med

Why (Motivation)
What (Action/Method)
How (Process/Implementation)

Multimodal conversational AI has progressed rapidly, but general-domain vision-language models lack sophistication in biomedical contexts.
Proposed LLaVA-Med, a vision-language conversational assistant for biomedical images.
Leveraged a large-scale biomedical figure-caption dataset from PubMed Central and used GPT-4 to self-instruct open-ended instruction-following data from captions.

Biomedical image-text pairs differ significantly from general web content, leading to inefficiencies in general-domain visual assistants for biomedical applications.
Created a novel data generation pipeline for biomedical multimodal instruction-following data.
Generated diverse (image, instruction, output) instances by sampling image-text pairs and using GPT-4 to create instructions from the text, requiring zero manual annotations.

The need for a cost-efficient approach to empower biomedical practitioners with AI that can answer open-ended research questions about biomedical images.
Developed LLaVA-Med using a novel curriculum learning method for adapting to the biomedical domain.
Initially fine-tuned to align biomedical vocabulary using image-text pairs, then further trained on self-generated instruction-following data to master open-ended conversational semantics.

MEDITRON

Why (Motivation)
What (Action/Method)
How (Process/Implementation)

Access to medical knowledge is uneven, and LLMs have the potential to democratize this by improving the quality of medical decision-making.
Developed MEDITRON, a suite of LLMs with 7B and 70B parameters specifically adapted to the medical domain.
Used the Llama-2 model as a basis and extended pretraining on a curated medical corpus, including PubMed articles, abstracts, and medical guidelines, utilizing Nvidia’s Megatron-LM distributed trainer.

Existing medical LLMs are either closed-source or limited in scale, hindering their ability to perform complex reasoning tasks in the medical field.
Aimed to create an open-source, large-scale medical LLM that can perform high-level medical reasoning and match or outperform state-of-the-art baselines.
Released MEDITRON models with and without fine-tuning, along with the code for curating the medical pretraining corpus and a distributed training library, to facilitate further research and development in the medical LLM space.

There's a gap in the availability of high-quality, domain-specific LLMs that can tackle medical reasoning tasks effectively.
Evaluated MEDITRON's performance on major medical benchmarks to validate its efficacy in medical reasoning and knowledge recall.
Employed advanced prompting strategies like chain-of-thought and self-consistency, and tested the models on a set of medical reasoning benchmarks, demonstrating significant performance gains over several baselines.


Node.js Backend + API Integration Contest Spec

Complete the contest spec for the "Develop the backend & Node.js API (using Swagger) and integration with the regulations.gov API." contest. This is due on 11/14/16.

Working on this

Done. Please check https://docs.google.com/document/d/1JT5yofj4dnSr8a6XsbSEgsolzjzb5IpDzstOhnFzW5Q/edit#

Approved. I've posted it to: https://www.topcoder.com/challenge-details/30055710/?type=develop&noncache=true


Allow to export the description and attribution of the map

If the map has a description and title enabled, they should be included in the export. Same thing with the attribution.

First approach:

Can we make the opacity of the overlay different to the one on the title & desc canvas?

Sure!

And this is an example of a real export:

cc: @javisantana

Here's a little preview on how it works (I still need to add the attribution)

cc: @javisantana & @mbforr


Refs #26808 -- Avoid clashing keyword arguments in test_autodetector

When index argument is passed here, an error is thrown.
Although I think that these variables should be passed in a dictionary instead into a **kwargs but changing the variable name in the current signature seems a quick fix.

Thanks for your work. Merged in  f7e00b40c558967d697529b7ed55c5fb82396e6d 🔔🔨