Kiricon template

Fixes #51
Places template.html in the root of the generated preact project. This file is read and used for building the project, however if missing then the template defaults to the build in template included in the npm package.
This will allow uses to modify language settings, meta tags and asynchronous JavaScript dependencies that exist outside of preact.

I think it might be exposing a bit too much surface area to generate this into each project for everyone - it would make updating preact-cli very very hard since everyone would have custom templates right out of the box.  There was some discussion in #56 about allowing custom templates without requiring them (using the built-in one if none exists), which I'm more amenable to.  Perhaps we can use this in one of the preact create templates in order to get people started if they really do want a custom index file?

@developit to prevent that from happening, perhaps we can provide hook like: head.top, head.bottom, body.top, body.bottom. That's pretty much everything you'll need

@developit Continuing on your comments from PR #58 perhaps we should stead of including template.html/index.html in each create project, make it included in a new create/single create.
Despite that uses would still have the option to add a template file to their existing project if they would like.
This way the templates are not automatically included in each project, preventing everyone from having a custom template when they don't need it, and still giving people with an interest in having a template the ability to use one.
Making a single create have a template file would be an excellent example for user's looking to add that functionality to their project.

Open to options there.  We could also have preact-cli parse the HTML template and inject things appropriately (html-webpack-plugin does this internally)

I think the best approach would be to create a template based on variables like this:
<html>
   <head>
        {{ head.top }}
        {{ injectStyles() }}
        {{ injectPreload() }}
        {{ head.bottom }}
   </head>
   <body>
        {{ body.content }}
        {{ injectScripts() }}
        {{ body.bottom }}
   </body>
</html>

This way we could provide easy to use customization of templates and use it on server side if we go that way.

Hey customize is in preact-cli for a while, closing this


Fix trybuild tests broken by rust 1.65

Objective

Fix tests that now fail in rust 1.65

Solution

Update .stderr files with new output

bors r+


Fix source install on CentOS-6

Description
Currently compiling from source fails on CentOS 6, this PR fixes that.
Contribution Check List

[ ] All tests pass.
[x] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable

          1 Warning

:warning:
This Pull Request is probably missing tests.

  Generated by :no_entry_sign: Danger

Are you still using centos-6?
Were really thinking of dropping all non-systemd platforms, ie centos-6 and amazon Linux 1

Alas, yes, we still have some in production as it's EOL in 2020.
Been using the cookbook fine so far but as it fails when installing from source - and I have a fix - I thought I would contribute upstream.


Cannot find a descendant at path [1,0] in node: {"children":

I'm recently getting this error and the whole app crashes. Any idea what would be the root cause?

I also get this occasionally and it seems to fix itself with a refresh 🤷♂

@karthikcodes6 In my case, this was caused by setting autoFocus on the Editable component from Slate. Setting it to false seems to have solved the issue.
I think autoFocus causes slate to try to focus the editor before the yjs provider has synced. It's basically a race condition


IndexError and UnpicklingError during model training with pretrained weights

When trying to train I encountered two errors: an IndexError related to the list index being out of range and an _pickle.UnpicklingError regarding an invalid load key.

INFO:mi-test:{'train': {'log_interval': 200, 'seed': 1234, 'epochs': 20000, 'learning_rate': 0.0001, 'betas': [0.8, 0.99], 'eps': 1e-09, 'batch_size': 40, 'fp16_run': True, 'lr_decay': 0.999875, 'segment_size': 12800, 'init_lr_ratio': 1, 'warmup_epochs': 0, 'c_mel': 45, 'c_kl': 1.0}, 'data': {'max_wav_value': 32768.0, 'sampling_rate': 40000, 'filter_length': 2048, 'hop_length': 400, 'win_length': 2048, 'n_mel_channels': 125, 'mel_fmin': 0.0, 'mel_fmax': None, 'training_files': './logs/mi-test/filelist.txt'}, 'model': {'inter_channels': 192, 'hidden_channels': 192, 'filter_channels': 768, 'n_heads': 2, 'n_layers': 6, 'kernel_size': 3, 'p_dropout': 0, 'resblock': '1', 'resblock_kernel_sizes': [3, 7, 11], 'resblock_dilation_sizes': [[1, 3, 5], [1, 3, 5], [1, 3, 5]], 'upsample_rates': [10, 10, 2, 2], 'upsample_initial_channel': 512, 'upsample_kernel_sizes': [16, 16, 4, 4], 'use_spectral_norm': False, 'gin_channels': 256, 'spk_embed_dim': 109}, 'model_dir': './logs/mi-test', 'experiment_dir': './logs/mi-test', 'save_every_epoch': 10, 'name': 'mi-test', 'total_epoch': 200, 'pretrainG': 'pretrained/f0G40k.pth', 'pretrainD': 'pretrained/f0D40k.pth', 'version': 'v1', 'gpus': '0', 'sample_rate': '40k', 'if_f0': 1, 'if_latest': 1, 'save_every_weights': '1', 'if_cache_data_in_gpu': 0}
INFO:torch.distributed.distributed_c10d:Added key: store_based_barrier_key:1 to store for rank: 0
INFO:torch.distributed.distributed_c10d:Rank 0: Completed store-based barrier for key:store_based_barrier_key:1 with 1 nodes.
gin_channels: 256 self.spk_embed_dim: 109
INFO:mi-test:loaded pretrained pretrained/f0G40k.pth pretrained/f0D40k.pth
Process Process-1:
Traceback (most recent call last):
File "/mnt/c/users/john/documents/Retrieval-based-Voice-Conversion-WebUI/train_nsf_sim_cache_sid_load_pretrain.py", line 178, in run
utils.latest_checkpoint_path(hps.model_dir, "D_*.pth"), net_d, optim_d
File "/mnt/c/users/john/documents/Retrieval-based-Voice-Conversion-WebUI/train/utils.py", line 206, in latest_checkpoint_path
x = f_list[-1]
IndexError: list index out of range
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/se7dev/miniconda3/envs/RBVC/lib/python3.10/multiprocessing/process.py", line 314, in _bootstrap
self.run()
File "/home/se7dev/miniconda3/envs/RBVC/lib/python3.10/multiprocessing/process.py", line 108, in run
self._target(*self._args, **self._kwargs)
File "/mnt/c/users/john/documents/Retrieval-based-Voice-Conversion-WebUI/train_nsf_sim_cache_sid_load_pretrain.py", line 197, in run
torch.load(hps.pretrainG, map_location="cpu")["model"]
File "/home/se7dev/miniconda3/envs/RBVC/lib/python3.10/site-packages/torch/serialization.py", line 815, in load
return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args)
File "/home/se7dev/miniconda3/envs/RBVC/lib/python3.10/site-packages/torch/serialization.py", line 1033, in _legacy_load
magic_number = pickle_module.load(f, **pickle_load_args)
_pickle.UnpicklingError: invalid load key, 'v'.

me too.

Got same error when trying to separate voice/instrument
_pickle.UnpicklingError: invalid load key, 'v'.

related?

That is because the pre-trained model is saved as LFS (Large File Storage).
If you only use "git clone" or "curl", it will only give you an html file rather than the real document.
You can easily realize that by looking at the file size. Normally the model takes around 50MB ~200MB. However, the html file is only several hundred KB.
That is why it shows something like "_pickle.UnpicklingError: invalid load key, '<'." This "<" is from the html file.
The solution is to use "git lfs".
I think this mistake is very common if someone is a beginner, and we should mention it in the readme document.

I encountered this issue today. In my situation, I know it has nothing to do with HTML or FLS because I just finished training my other model. As it turns out, you cannot name your experiment with a name like XXXXXV3. Somehow, the RVC thinks you are attempting to find a Version3 pretrained model that doesn't exist yet. So, my takeaway is not to name your experiment with anything related to numbers and common coding instructions.

I resolved this error by following this tutorial https://www.youtube.com/watch?v=nXpBlC6OBw4&t=1119s
The error occurs because you must have some virtual environment with the name env in anaconda. This causes the env subfolder to not be created in Retrieval-based-Voice-Conversion-WebUI. Replace the command "python - m venv env" with python - m venv [your_name] then type your_name\Scripts\activate before executing the other commands:
pip install torch torchvision torchaudio --index-url https://download.pytorch.org/whl/cu117 our cu118 and
ip install -r requirements.txt and enjoy


Bug: This plugin has no effect

Hi, I just installed and enabled your plugin, but it did not show the effect as expected.
No matter what I typed into the [], it all turned out to be finished.
For example, I typed the example in yr README.md:
- [ ] Pending
- [.] In progress
- [~] Won't do
- [x] Done

and it just showed this:

Could it be because I changed some files before?
FYI, I changed my css before:

my current Obsidian version is v1.5.3(Installer version v1.4.13), and I'm running Obsidian on Window11

@how2051 thanks for the bug report. I’ll look into this!

@how2051 currently only reader mode is supported. You can toggle reading view on Windows using ctrl + e. Is reading mode enabled in your screenshot?

@joeriddles
I'm not sure if this is the reader mode you said ( also, I pressed ctrl + e but nothing happened, the mode since unchanged)

Notice the second line. It's already in effect.

yeah but the won't do is not as expected like the README.md like this:

the red one

@how2051, please update to the latest release. I have tested on Windows and this is now working as expected! Thanks for reporting this bug. Cheers.

@joeriddles  Hi, thank you for the patience and effort for fixing this bug.
I've updated to the latest release and do a simple test, but unfortunately, it is still not working as expected.
Maybe there's something wrong with my operation ?

I try it on 1.4 version of Obsidian, it doesn't work, so I updated my Obsidian to latest 1.5, still the same.

and here's what I type:

[ ] Pending
[.] In progress
[~] Won't do
[x] Done

which is copy from your README.md


default_date в multiple

$("#cal_").pickmeup({format: 'Y-m-d', mode: 'multiple', default_date: false, separator: ','});
есть элемент input, не могу добиться, чтобы при открытии календаря не выбиралась по-умолчанию сегодняшняя дата. приходится выбирать даты, потом "отжимать" текущую дату. вроде-же было заявлено, что пофиксено?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/36605303-default_date-multiple?utm_campaign=plugin&utm_content=tracker%2F451958&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F451958&utm_medium=issues&utm_source=github).

Any more details, demo?
https://github.com/nazar-pc/PickMeUp#contribution

example is here: https://partytown.ru/pickmeup.php
if i click on input, calendar is displayed, and today is selected "by default". when i click any day, in input shows two dates - today and selected

Because it is multiple mode, it selects 1, 2, 3, 4... any number of dates.
What did you expected?

For example, i want to select all saturdays in next month (3.09, 10.09, 17.09, 24.09).
i click to input, calendar opens, i click on ">" to change month to september, and begins to click on saturdays. when i select first day (3 september), in input displayed "2016-08-05,2016-09-03" - today date and my selected day.
in config - "default_date: false"

OK, then once again: https://github.com/nazar-pc/PickMeUp#contribution
Prepare standalone simple demo first and I'll take a look at it.

my example: https://jsfiddle.net/ws8a8ffy/

any ideas?

any ideas?

Confirmed to be a bug, will work on it.

Your example is not exactly correct as for what you want you have to also specify empty array of dates so that nothing is selected by default (default_date only affects value in `), but there was also a problem in PickMeUp itself, which should now be fixes.
So correct example I believe would be this (uses current master branch code): https://jsfiddle.net/ws8a8ffy/1/
There was a lot of changes recently, test it thoroughly from master branch before I release new version. New version will also address some other significant issues.


Java gRPC Client Change Log Compliance - Minimum Viable Tier

We should automate changelog updates similarly to how they are automated in the EventStore repo.

[ ] PR Check has been added
[ ] Automated changelog updates based on PRs

Done #209


Use lv2 toolkit submodules for aap-import-lv2-metadata

I have been trying to make changes to aap-import-lv2-metadata on aap-lv2-sfizz, and trying to find out how I can retrieve non-translated tags from .ttl files, as our tool is always picking up the last (Italian?) labels for scalePoints.
It turned out that this was an issue in somewhat older version of lilv, and it was fixed after https://github.com/lv2/lilv/issues/31 was filed.
There are two issues:

We use lilv from local system package. On Ubuntu 20.04 it is lilv 0.24.6, which is likely slightly older than the fix.
The fix is not a real fix as it is just picking up the first value. We still cannot import all translation labels.

Since we have made changes on how we build LV2 toolkits from submodules, we can also reuse these submodules to build aap-import-lv2-metadata to resolve the first issue. Maybe we can improve lilv for the latter issue too (not in high priority).

Since those submodules were the patched versions, and also we made hacky changes on abstract_io.*, they don't simply build for desktop yet.

Due to the problem above it is not realistic to use lv2 toolkit for now.


StackScripts e2e test maintenance

Description
Fix StackScripts e2e tests that were failing due to spelling errors.
Note to Reviewers
To test, run: yarn e2e --file e2e/specs/stackscripts/stackscript-detail.spec.js.

some spelling issues here, i think you meant to spell it diztrowution 😆


fix: correct annotation for transfer hpa ownership

Correct the wrong annotation used for the transfer hpa ownership.
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO)

Fixes #1170

Could you update docs v2.12(next release) too?

Too bad we are not using the old annotation.
Just to confirm, we are certain scaledobject is the correct prefix?

https://github.com/kedacore/keda/blob/main/apis/keda/v1alpha1/scaledobject_types.go#L51
There was a pattern in the module already ;/ https://github.com/kedacore/keda/blob/main/apis/keda/v1alpha1/scaledobject_types.go#L50C1-L50C1

Could you update docs v2.12(next release) too?

done

Btw, I might be the only one using that label at this point, so if you want, I can PR keda to change the label and you could release it as a patch fix.

It has been shipped so let's stick with that and no worries!
Thanks.


Create 2023-08-23-OpenSearch-Project-Q2-community-survey-results

Creating a PR to review OpenSearch Q2 survey results being shared with the community
Description
New Blog regarding Q2 community survey results by Aparna.
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

There are definitely pending edits. Not ready for publish.

@nateynateynate @pajuric @apasun - is this one still being worked on? Can we push it out? Should we close this?

A few weeks short of a year old now. I'm going to close this one out.


Update asdf command in README

When I run the command asdf global 3.6.2 2.7.13, I get the error message No such plugin: 3.6.2.
I think it's missing python after global. The command asdf global python 3.6.2 2.7.13 works for me.

Oh, indeed. Thanks!


updating french translation for v1.1.0

updating fr translation of the new texts added for v1.1.0 (see issues #43 for more information)

Added manually.


Migrating code-line.component.js styles to styled-component.

Based on issue #503 I want to translate the old styles in this component to the new styled-components way.

@josenaranjo Let us know if you have any question about this!
Thanks!


Issues with @EnableFeignClients(basePackages) scanning in Spring cloud version Finchley.RC1

Hi;
I'm getting issue with @enablefeignclients(basePackages) scanning in Spring cloud version Finchley.RC1;
Getting runtime exception saying that beans are not registered, Basically @enablefeignclients(basePackages = {"com.xxx.aa", "com.yyy.bb"}) are not scanning the packages and beans not getting registered.I'm getting base package beans classes from dependency artifacts.
It will great help if you guys provide a feasible solution or let us know in which version this issues can be solved.
The above issue used to work in spring cloud version 'Finchley.M5' before spring cmade have changes in feign client.
Thanks
Ravi

Without a way to reproduce the problem  it is going to be hard to help.  If you cant provide the actual code than maybe you can create a new project that reproduces the problem and attach that.

We have run into this issue. A Feign client build in our JAR with the regular @EnableFeignClients annotation works.
If we move the client to another JAR, add it as a dependency and then try to use the @EnableFeignClients(basePackages=....) we get an error indicating that there is a problem with one of the @PathVariables having a empty param 0.
I will try to create a small project to reproduce the issue.


DBZ-1150 CHECK TABLE options are valid identifiers

https://issues.jboss.org/browse/DBZ-1150

Upstream issue - https://github.com/antlr/grammars-v4/pull/1370

Applied. Thanks, @jpechane!


Assets/BattleFiels/NavMeshComponents/Editor/NavMeshModifierVolumeEditor.cs(20,42): error CS1729: The type UnityEditor.IMGUI.Controls.BoxBoundsHandle' does not contain a constructor that takes 0' arguments

Assets/BattleFiels/NavMeshComponents/Editor/NavMeshModifierVolumeEditor.cs(20,42): error CS1729: The type UnityEditor.IMGUI.Controls.BoxBoundsHandle' does not contain a constructor that takes 0' arguments
The same error with NavMeshModifierVolumeEditor.

@repeperilka Can you tell me please which Unity version do you use and which branch of this NavMeshComponents repository?

Not reproducible anymore.

Not reproducible anymore.


adding environment variable to allow for encrypted uploads to S3

This simply introduces an environment variable ENCRYPT_AWS_SBT_UPLOADS, which can be set to TRUE or FALSE. I'm sure there's more elegant ways to work with this code-base, I'm all ears as to how you'd prefer to approach this.

It might be interesting to add these to the various config files too, so it's not just an environment variable...albeit that probably requires a more complicated code change

This is also being worked on in https://github.com/frugalmechanic/fm-sbt-s3-resolver/pull/28 by automatically enabling SSE if the bucket policy requires it.

Hopefully #28 solved this.


[opentelemetry-cpp-contrib-version] update to 2024-11-14

Alternative to https://github.com/microsoft/vcpkg/pull/42325.
Update port opentelemetry-cpp-contrib-version to support ubuntu 24.04.

[x] Changes comply with the maintainer guide.
[x] SHA512s are updated for each updated download.
[ ] ~The "supports" clause reflects platforms that may be fixed by this new version.~
[ ] ~Any fixed CI baseline entries are removed from that file.~
[ ] ~Any patches that are no longer applied are deleted from the port's directory.~
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Thanks!


Entertainment form for CoS workshop - April 26

Entertainment form for CoS workshop food order.

Submitted to Susan, food will be ordered 2 weeks before event date.


Use interserver_http_host in isLocalAddress

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
I haven't tested this yet, but I think this will fix the issue I'm having in #2154

Gah, I have no idea what I'm doing here (I'm not a C++ dev)...


Markdown link exposed in text

Hi team, there is a markdown link exposed in the text for the paragraph: https://docs.microsoft.com/en-us/azure/synapse-analytics/sql/on-demand-workspace-overview#azure-active-directory-integration-and-multi-factor-authentication

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d7bba9da-4559-5bf8-1c57-6ec91d3693d0
Version Independent ID: 36809e5a-8508-445b-fd20-fd2763449aa2
Content: SQL on-demand (preview) - Azure Synapse Analytics
Content Source: articles/synapse-analytics/sql/on-demand-workspace-overview.md
Service: synapse-analytics
GitHub Login: @filippopovic
Microsoft Alias: fipopovi

@fabragaMS  Thanks for your feedback! We will investigate and update as appropriate.

@fabragaMS Thanks for your contribution, I've addressed this issue in PR: https://github.com/MicrosoftDocs/azure-docs-pr/pull/115803
The changes should be live EOD or tomorrow. We will now close this issue. In future, if you see any minor bug fixes in the doc, feel free to click on the edit button and submit a PR to update. we love to take community contributions.


compile issues due possible refactoring

It looks like the code and cmake think the eve_arch_esp32 directory should be in the lib folder and not in the ports directory.
Please let me know if this repo is the proper place for feedback/contrib.
thanks

Yes indeed, thanks so much for your feedback.
I've fixed the CMake files and updated references for ESP-IDF v4.4.
Only compilation tested at this point.
@BRTCHIP-GB: Can you verify functionality on ESP32 then approve related PR if successful?

Your update builds well on release 4.4 of the toolchain.
There is one additional warning
C:/Users/BRT/Documents/GitHub/esp-idf/components/esp_event/include/esp_event_loop.h:2:2: warning: #warning "esp_event_loop.h is deprecated, please include esp_event.h instead" [-Wcpp]


Support no packages

Can you give more detail about this issue? @holdenk

So currently we require a user specifies some packages in their env, but some users might be purely dynamic (at least initially) so we should allow building an empty env if that’s what they want.

Is anaconda package included in this empty env?

I’d say yes. It’s more no pip packages (we internally depend on som anaconda functionality to bootstrap the installs).


Added Kasr Al-Ainy

Added KasrAlAiny School of Medicine
domain: https://medicine.cu.edu.eg
Student Email : @students.kasralainy.edu.eg

@EGYWEB-Mohamed First stage of verification passed, official domain is facebook.com as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://ar-ar.facebook.com/140754629435841/posts/176251032552867/

@philipto Hello, main domain is: https://medicine.cu.edu.eg/student/index.php/s-suport/international-student-office
but they used @students.kasralainy.edu.eg as the email domain
and it's proofed in link above

@EGYWEB-Mohamed Thank you! Please provide us also with an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course. Thank you.

It's a medical college part of Cairo University https://cu.edu.eg/Home

@EGYWEB-Mohamed I am sorry, a medical college by default is not an organization that provides an education in software development. Therefore, most of the students there do not need a free license for a software development tool. Given a serious level of abusing similar domains in Egypt, I have to reject the request.
If you personally needs a software development license for your study, please apply for free educational license with an official document which proves that you are a student. You can do it using "OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students.
I have to close the request without merging.
Thank you for your understanding!


Debug with Nodejs and nodemon keep getting restart upon 'Attach to Process'

VSCode Version: 1.10.1
OS Version: Mac 10.12.3
Node Version: 6.10.0

Steps to Reproduce:

Launch a node process in console with nodemon nodemon --debug server.js
Click Attach to Process in vcode.
The server will be restarted by nodemon even though no files are changed
vcode throws and error: Request 'evaluate' was cancelled because Node.js is unresponsive.

Before this release the nodemon wasn't detecing changes all the workflow was fine. Now if the server is slow to start I cannot attach vscode to it. I tried to use the timeout option in launch.json with no luck.

I believe duplicate of https://github.com/Microsoft/vscode/issues/21681


Document how to use multiple rules in docker label 'rule'

What does this PR do?
Document how to use multiple rules in docker label 'rule' .
Motivation
It took me a while and only stackoverflow could help me in the end:
https://stackoverflow.com/questions/44232354/define-host-and-path-frontend-rule-for-traefik
More

[x] Added/updated documentation

Additional Notes
I'm not sure if the only way to do this is in the Host:domain.com notation, but Host(`..`) && did not work.
Also, I don't know how to do OR rules in this notation.

Hello @TeNNoX,
The v1 rules are documented here:
https://docs.traefik.io/v1.7/basics/#combining-multiple-rules
The v2 rules are documented here:
https://docs.traefik.io/v2.2/routing/routers/#rule
Unfortunately this PR is adding v1 documentation that is no longer accurate. For this reason, we are going to decline this PR.

Whoops. I'm using traefik 1 and wasn't aware of it. Sorry :facepalm:


PR: Fix tests on Linux

Description of Changes

Tests started to fail on Linux since yesterday. This PR fixes them.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

It seems this is not necessary anymore.


Project Tags with Special Characters.

#Steps to Reproduce

Open a project which which you have write/admin access.
Tag the project with an apostrophe in it. (e.g. "1 o'clock") and hit enter.
See the tag is correct.

Refresh the page.
See that the tag has had the apostrophe removed.

Now add a tag that contains both an apostrophe and a question mark.

See that the tag is correct.

Refresh the page and see that the tag was never saved.

@zobairAlijan will be taking a look at this one.

It looks like, It is working now.

@ZobairAlijan just verified on production. The problem still exists.

I can give this one a look through if nobody else is working on it

Patrick, I'm working on it and it is almost done.

I just finished it a couple of hours ago....  I figured since you hadn't worked on this in almost a week, it'd be fine if I took over


[feat] introduce Conventional Commits to optimize development workflow / Commitizen

Feature Request
To improve the quality and readability of this project, i want to suggest you to have a look at Convetional Commits + commitizen. It also helps you generating changelogs and releases.
The Conventional Commits specification is a lightweight convention on top of commit messages. It provides an easy set of rules for creating an explicit commit history; which makes it easier to write automated tools on top of. This convention dovetails with SemVer, by describing the features, fixes, and breaking changes made in commit messages.
Describe the Feature Request
Make the repository commitizen friendly and update the contribution guidelines.
Describe Preferred Solution
Describe Alternatives
Current solution.
Additional Context
Conventional Commits
Commitizen
https://reflectoring.io/meaningful-commit-messages/

Here an example repository using conventional commit messages.
Modern dApp Starterkit


ViewPagerAndroid has been removed from React Native

react native 6.1版本, 报了这个错误.
Invariant Violation: ViewPagerAndroid has been removed from React Native. It can now be installed and imported from 'react-native-viewpager' instead of 'react-native'. See https://github.com/react-native-community/react-native-viewpager
This error is located at:
in EmojiPanel (at ChatView.js:1124)
in RCTView (at createAnimatedComponent.js:151)
in AnimatedComponent (at ChatView.js:956)
in RCTView (at ChatView.js:954)

OK

你先自己改下这一块

已修复


Pinning the labels area

Hello, I was wondering if there is any provision in the Label studio community edition to pin or have a floating labels area? It gets really difficult to go top-down to select the labels when labeling long documents.
Thanks

@prakhar21 please check (this labeling config)[https://labelstud.io/playground/?config=<View>
  <View style%3D"padding%3A 0 1em%3B margin%3A 1em 0%3B background%3A %23f1f1f1%3B position%3A sticky%3B top%3A 0%3B border-radius%3A 3px%3B z-index%3A 100">
    <Labels name%3D"label" toName%3D"text" showInline%3D"true">

    <%2FLabels>
  <%2FView>

  <View>
    <Text name%3D"text" value%3D"%24text" %2F>
  <%2FView>
<%2FView>
]


Expand/load all hidden items (comments) recursively

Description
When comment chains get long enough, it's a massive pain to expand them all if you want to do a Ctrl + F on them. Add a button to continuously expand hidden items until they're all there.
Screenshot
No response
Example URLs
https://github.com/rust-lang/rust/issues/31844

We already have it: expand-all-hidden-comments

Ohhh, alt click! Thanks! :)

In fluxbox alt+lmb is used to move windows and thus this doesn't work. Any way to rebind it to another modifier than alt?


python: tpp.c:83: __pthread_tpp_change_priority: Assertion `new_prio == -1 || (new_prio >= fifo_min_prio && new_prio <= fifo_max_prio)' failed.

(vlogger_backup) root@ubuntu-vm01:/sdb/github/Vlogger# python sample_scripts/vlog_read_script_sample.py
Seed set to 3407
pretrained/stable-diffusion-v1-4/unet/config.json
Warnning: using half percision for inferencing!
model ready!
protagonists ready!
video script ready!
reference script ready!
zh script ready!
time script ready!
Generating the (Teddy bear in a kid's room.) prompt
python: tpp.c:83: __pthread_tpp_change_priority: Assertion `new_prio == -1 || (new_prio >= fifo_min_prio && new_prio <= fifo_max_prio)' failed.
Aborted (core dumped)

The error message you've encountered indicates that there's a failed assertion within the C library that handles thread priority (tpp.c). The assertion failure is related to thread priority values, where new_prio should either be -1 or within the range defined by fifo_min_prio and fifo_max_prio.
Here are some steps to troubleshoot and potentially resolve the issue:
· pip install --upgrade pip
· pip install --upgrade setuptools
· pip install --upgrade [package-name]
Hope the above can help you.


Resolve endpoint with default partition when no region is set

Addresses https://github.com/aws/aws-cli/issues/7455.
Changes endpoint resolution to resolve the endpoint for the default AWS partition when no region is given.

Codecov Report
Base: 93.49% // Head: 93.46% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (64381e1) compared to base (2df5c5b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2818      +/-   ##
===========================================
- Coverage    93.49%   93.46%   -0.04%
===========================================
  Files           63       63
  Lines        13346    13349       +3
===========================================
- Hits         12478    12476       -2
- Misses         868      873       +5

Impacted Files
Coverage Δ

botocore/endpoint_provider.py
99.35% <100.00%> (-0.01%)
:arrow_down:

botocore/compat.py
91.33% <0.00%> (-1.34%)
:arrow_down:

botocore/httpsession.py
91.40% <0.00%> (-0.40%)
:arrow_down:

botocore/utils.py
79.07% <0.00%> (-0.13%)
:arrow_down:

botocore/client.py
97.84% <0.00%> (+0.01%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


build(Discord.js): update to 14.15.2

:tada: This PR is included in version 9.8.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


What happen to gas and me conduits

I can understand there me conduit not being part of EnderIO any more as, it only newly come out on 1.10 but Mek has been out for quite some time, is there an reason you are no longer making conduit for other mods.

ME is a buggy mess atm that we don't want to pull into eio.


No coloring in shell

When I do npm test it outputs colored log.
When I do it with your tool there's no color.

Probably the test tool stops coloring in some uses.
If you use mocha, please try the --colors option, likely this.

@mysticatea  Wow, really, that helped mocha, and webpack too.

Doesn't fix non-mocha commands though. For example, I'm running istanbul check-coverage and the colors are lost.


Can we use fast dataset with Java program? Is it supported

On windows 7,I am trying to use Fast Traineddata files in my java project. But I am getting Invalid Memory access when using it even after setting datapath.
I have tried to use best data files but it also gives same error. Default data files are working but it is huge file so I was going for fast files.
Tesseract tess = new Tesseract();

tess.setDatapath("C:\\Users\\U6070534\\Downloads\\tess4j\\tessdata");
tess.setLanguage("eng");

String inputFilePath = "C:\\Users\\U6070534\\IdeaProjects\\ocrsample\\screenshot\\craft0.png";
    try {
        textpath.add(tess.doOCR(new File(inputFilePath)));
    } catch (TesseractException e1) {
        e1.printStackTrace();
    }

Exception in thread "main" java.lang.Error: Invalid memory access
at com.sun.jna.Native.invokePointer(Native Method)
at com.sun.jna.Function.invokePointer(Function.java:470)
at com.sun.jna.Function.invoke(Function.java:404)
at com.sun.jna.Function.invoke(Function.java:315)
at com.sun.jna.Library$Handler.invoke(Library.java:212)
at com.sun.proxy.$Proxy0.TessBaseAPIGetUTF8Text(Unknown Source)
at net.sourceforge.tess4j.Tesseract.getOCRText(Tesseract.java:437)
at net.sourceforge.tess4j.Tesseract.doOCR(Tesseract.java:292)
at net.sourceforge.tess4j.Tesseract.doOCR(Tesseract.java:213)
at net.sourceforge.tess4j.Tesseract.doOCR(Tesseract.java:197)
at OcrReader.main(OcrReader.java:25)
Failed loading language 'eng'
Tesseract couldn't load any languages!
Process finished with exit code 1

Please use tesseract user forum for asking question/support


$translate() returns Object instead of string

If I use the $translate service like this $translate('test') it returns an object. Loggin it into the console $log.log($translate('testa')); proves this.
I thought it should return a string, doesn't matter if the translation exists or not?!

FYI: $translate.instant() returns an object when you use the 'sce' sanitize setting


[otel log] Handle logs without Timestamp field better.

Describe the bug
Currently, quickwit is ignoring otel logs with a null (or 0) Timestamp.
// quickwit-opentelemetry::otlp::logs.rs line 441
for log_record in scope_log.log_records {
    if log_record.time_unix_nano == 0 {
        rate_limited_error!(limit_per_min = 10, "skipping record");
        num_parse_errors += 1;
        continue;
    }
    // ...
}

Some instrumentation only set ObservedTimestamp and leave Timestamp null.
Maybe we should default to ObservedTimestamp when Timestamp is not set.
Steps to reproduce
Use any Otel logs exporter which doesn't set the timestamp field.
In my case, I'm using rust tracing + opentelemetry-appender-tracing.
Expected behavior
Other people have encountered this problem using the same setup with the official otel collector (https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/11752#issuecomment-1895383712).
The official otel collector exporter use ObservedTimestamp when Timestamp is not set.
The PR: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/31844
Maybe Quickwit should also do this. Default to ObservedTimestamp when Timestamp is not set, instead of throwing away logs without a timestamp.

I've just encountered the same issue - traces work great, but the logs are silently ignored with the same error.

Experiencing the same issue as @spetz. Fingers crossed for https://github.com/quickwit-oss/quickwit/pull/5366


parallelized collapse function with openmp in StateVectorLQubit.hpp

Before submitting
Please complete the following checklist when submitting a PR:

[ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!

[ ] All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.

[ ] Ensure that the test suite passes, by running make test.

[ ] Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.

[ ] Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:
Would like to improve performance of the collapse method since Mid-Circuit Measurement (MCM) support was added to the lightning.qubit backend.
Description of the Change:
Parallelized collapse function with OpenMP.
Benefits:
Faster execution with several threads.
Here's the strong scaling results on my mac and on a cluster at UofT.
To benchmark the implementation, I assumed num_qubits = 10-30.  The upper bound of 30 is chosen so that on my mac a complex float array of size 1<<30 can be held in my RAM.
The execution times are obtained by averaging the run time of the collapse function 10 or more times.  Attached please also see the code that I used for benchmarking.

Possible Drawbacks:
Related GitHub Issues:
#962

Hi @xiaohanzai, thank you for that! Could you please resolve the conflicts so we can run our CIs?

Thank you, @xiaohanzai!

Thanks @xiaohanzai.  Could you please share your benchmark scripts (both cpp and shell script code) for discussion?

Thanks @xiaohanzai for sharing the scripts. A few questions come to my mind for discussion. Please feel free to leave your thoughts, thanks!

Since normalize() is a part of the collapse(), would you like to parallelize it as well?

Could you please explain why increasing the number of threads can improve the performance when num_threads <=16, while further increase of thread numbers would improve the performance  when num_qubits > 20?

Could you please explain why the stride=vec_size/2 scales better than stride=1 on the mac, while it's opposite on the node of cluster?

Is there any room to optimize this method? If yes, how would you like to further optimize this code? If not, why?

Hi @multiphaseCFD
I pushed another commit to parallelize normalize.  Here are my thoughts on your questions:

Could you please explain why more threads lead performance regression when the number of qubit is small, that's say num_qubits = 10?

There's too few array elements to deal with, so the parallelization overhead is a lot larger than the actual workload.  It's not very beneficial to parallelize the code unless the array size is large enough.

Could you please explain why increasing the number of threads can improve the performance when num_threads <=16, while further increase of thread numbers would lead the performance regression when num_qubits > 20?

My speculation is that 8 32KB L1 caches can hold about 2^15 complex float array elements, so when array size isn't too large they can be stored in the nearest caches.  But when array size gets too large e.g. 2^30 then they will have to be loaded from RAM.  Then memory latency gets in the way.

Could you please explain why the stride=vec_size/2 scales better than stride=1 on the mac, while it's opposite on the node of cluster?

That I'm not sure...  I'd expect the performance of stride=1 to be worse in general because of cache misses, but I'm not sure why mac and cluster appear to be very different.

Is there any room to optimize this method? If yes, how would you like to further optimize this code? If not, why?

I considered dynamic scheduling, static scheduling with a small chunk size, and loop tiling, but these all didn't seem to work better than the default scheduling.  I think the scheduling overhead is too large when array size is large and chunk size is small.  So I think on my side I don't have any further ways of optimizing it.

@multiphaseCFD Thanks a lot for the suggestion!  I just updated the code in codeshare.  It seems like on my mac the results didn't get improved a lot, especially for stride = 1.  This plot is got by running collapse function without normalize(), so same as before:

This is after adding in a parallelized normalize:

And results on the cluster with normalize:

Thanks @xiaohanzai


Allow Input to accept prepend/append elements

Currently inputs only allow an IconName to be passed as the prop:
<Input value='foo' appendIconName='hand-up' />
However sometimes we need to be able to render something completely custom inside, a good example of this is for rendering currency symbols 'inside' the input:
<Input value={amount} appendElement={<Lozenge>USD</Lozenge>} />
It would be good to allow Input's props to take either a string (IconName) or a ReactNode for something custom. Props could end up something like:
interface InputProps extends InputHTMLAttributes<HTMLInputElement> {
  ...
  prependElement?: IconName | ReactNode;
  appendElement?: IconName | ReactNode;
}

If an IconName is passed we render an <Icon /> component otherwise whatever is passed in.

[ ] Update Input to accept generic element for prepending/appending
[ ] Update token-input to render currency

Closing as in Done


feat: Update MWAATriggerDagsStage to pass json event to MWAA airflow dag

Description
Currently, MWAATriggerDagStage does not pass the sfn event to the MWAA dag. This enhancement enables to pass runtime parameters/sfn event when triggering dag. The parameters can be accessed from the dag_run.conf.
Changes Made
Changes made to MWAATriggerDagStage:

Trigger dag lambda has an additional payload of the sfn event passed in body
airflow command updated to pass sfn event to MWAA dag using --conf

Related Issue
#428

AWS CodeBuild CI Report

CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
Commit ID: c5c6b59399b6215307a8d72c2836479a02087e27
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Yes, in case of an empty event,  dags trigger DAG_ID --conf {} is valid.
To test this, i created a sample dag the prints out the conf. (logger.info(context['dag_run'].conf))
Scenario 1: In case of a dynamic dag ids passed through dag_path, the event body is not expected to be empty as the sfn event has the dag_ids list. The test dag completed execution and printed the dag_ids list in the logs.
Scenario 2: To test a static dag id, i triggered the dag from the mwaa ui using the "Trigger DAG w/ Config" option. The configuration JSON (conf) was set to {}. The dag completed execution and printed {}


TCP listener prevents application of HTTP rules

The hard coded protocol type of TCP makes haproxy inside amphorae to neglect L7 HTTP rules. Here's the line
https://github.com/kubernetes/cloud-provider-openstack/blob/cc82c7f119cd63e857c47c34796a272cc967cf02/pkg/ingress/controller/openstack/octavia.go#L395
My suggestion would be to change it to HTTP as for now Ingress only supports HTTP/HTTPS and discuss TCP loadbalancing capabilities of Octavia can be used through annotations in the Ingress resource itself

@netcho hi, thanks for reporting this issue. Could you please provide your pod/service/ingress manifest files you were testing with?

`apiVersion: extensions/v1beta1
kind: Ingress
metadata:
name: console-ingress
annotations:
kubernetes.io/ingress.class: openstack
spec:
rules:

http:
paths:

path: /
backend:
serviceName: frontend
servicePort: 80
path: /api
backend:
serviceName: backend
servicePort: 80`

Here it is. I forgot to mention that I recreated the loadbalancer manually changing the protocol to HTTP and it worked as expected.


Update azure-disks-dynamic-pv.md

Added a note indicating that managed disks are billed by SKU and that the performance of Premium managed disks depends on the SKU.

@nmackenzie : Thanks for your contribution! The author, @neilpeterson, has been notified to review your proposed change.

@nmackenzie : Thanks for your contribution! The author, @neilpeterson, has been notified to review your proposed change.

@nmackenzie thanks for the contribution.
#sign-off


Externalising config

Externalised configurations

:tada: This PR is included in version 1.1.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Added mandatory enable option for NixOS.

In order to fix the intero integration for NixOS, one solution is to modify the ~/.stack/config.yaml as described in #52, but we need both the ncurses package and nix to be enabled:
nix:
  enable: true
  packages: [ ncurses ]

Best solution is to add these default options in the stack/config.yaml of the project!

This broke the build so I reverted it. 😱

Oh sorry, just saw that too... Maybe just adding some instructions to the readme for NixOS users should be great.


Vanity GitHub Webhook URL

Problem
The MT githubsource controller generates webhook of the form http://githubsource-adapter.knative-sources.<domain>/<ns>/<name>
where ns and name corresponds the githubsource CR.
Instead it should generate webhook of the form http://<name>.<ns>.<domain>.
Context
See https://github.com/knative/eventing-contrib/issues/1131#issuecomment-612559118 for more details.
Depends on https://docs.google.com/document/d/1xK-g55kFdRRpYsiHyesmYWKURWi1sJlIWxMwkRmlyuM/edit#
/cc @dug @mattmoor

Ideally it should use the domainTemplate to generate the URL since the networking setup in the env might require a certain format.

The plan is for the GitHub controller to generate an Kingress of the following form:
apiVersion: networking.internal.knative.dev/v1alpha1
kind: Ingress
metadata:
  annotations:
    networking.knative.dev/ingress.class: istio.ingress.networking.knative.dev
  name: my-github-source
  namespace: tenant
spec:
  rules:
    - hosts:
        -  DomainNameFromTemplate(ctx, cr('mygithub-source'), 'mygithub-source')
      http:
        paths:
          - rewriteHost: github-adapter.svc.cluster.local
            appendHeaders:
              name: "my-github-source"
              namespace: "tenant"
      visibility: ExternalIP
  visibility: ExternalIP

Initially the domain template can be specified as an annotation on the GitHubSource CR and eventually we can add a ConfigMap in knative-sources where to specify the template.
I don't think we want the GithubSource adapter to read the serving cm config-network. I would rather keep it separate for portability reason.
@duglin @julz
Note: this will be an opt-in feature since it depends on Istio.

Note: this will be an opt-in feature since it depends on Istio.

Nit, but just for completeness, more accurate to say it depends on an alpha KIngress feature (rewriteHost) which currently only net-istio supports.

cc @tcnghia

which currently only net-istio supports

Is this is ingress conformance?

What is backing the adapter?  Does it implement the dataplane contract wrt probing?

Is this is ingress conformance?

Yeah: https://github.com/knative/networking/blob/master/test/conformance/ingress/rewrite.go

That's fun.  How is net-istio enabling that test? 🤔
https://github.com/knative-sandbox/net-istio/blob/f64ed34d3776a444372483dddc15a330c6c1ac53/test/e2e-tests.sh#L23-L24

cc @dprotaso - I got a bit lost on all the ingress conformance changes recently :(

I think net-istio needs: https://github.com/knative-sandbox/net-contour/pull/210

What is backing the adapter?

A Knative service

Does it implement the dataplane contract wrt probing?

I'm not sure it does today. Can you expand a bit on what you mean by probing?

So I changed my mind wrt. to getting the domain and domain template directly from the serving ConfigMaps. That's an implementation detail that shouldn't be exposed to the GitHub source user.


Shutdown code might not be working as expected. [BUG]

In the coiled dashboard, I'm seeing these clusters that have been up for a while not doing any work and the idle code is not closing them, even though the CI looks like passed with no problem. (Closing the clusters manually)

https://github.com/coiled/coiled-runtime/runs/6714230098?check_suite_focus=true
any idea what could it be?
Details pages:
https://cloud.coiled.io/dask-engineering/clusters/31051/details
https://cloud.coiled.io/dask-engineering/clusters/31122/details

I suspect they're running into the preload issue that https://github.com/dask/distributed/pull/6458 fixes. Updating to the latest distributed release (xref https://github.com/coiled/coiled-runtime/pull/149) should fix this

Closing as the 0.0.4 release is out and includes https://github.com/dask/distributed/pull/6458


Handle unofficial names for Yugipedia pages

Currently we are relying on the page title for the English name of the cards; nevertheless, the {{Unofficial name|English}} is present on some wikitext to mark some as unofficial. Handling this will help identifying cards that are not released yet and/or are OCG exclusive.

Forgot to mention that also {{Unofficial lore|English}} might  be present.


 Pretty much crushed my client several times, like non responsive. Tried to take out the problem ones but just crashed.
The logs in screen caps were also showing in client in game.
Reproduction
You can try check that replay or see the logs otherwise assuming it is to do with some generation of those roid types.
Screenshots

Additional context
There were no ghost roles showing too but there was a count for them.

these exceptions aren't referencing the vgroid but rather the outer debris that spawns as part of moony's old worldgen. Just pointing that out since the screenshot you have is of the wrong thing.

these exceptions aren't referencing the vgroid but rather the outer debris that spawns as part of moony's old worldgen. Just pointing that out since the screenshot you have is of the wrong thing.

Sorry, I'm not sure on the specifics, You probably have more knowledge here if this is a real issue or not.
But the first image was where I was teleported when i checked the grid that was erroring in the console logs in game, client.
I should of pulled my client logs but I was also juggling several admin issues at the time.
Each of those smaller grids seemed to have a error. Every 30s or so.
The game was also lagging and the lighting system was going crazy.
It seemed to resole the next game but I'm not sure if this is just a particular random generation that causes this.


The default property of core annotation @Default gets stripped when stubbed with kapt

This one is weird. The only annotation affected is @Default (all other core annotations appear fine) This could be a bug with schema-kenerator, kapt or avaje-inject
Placing @Default("xyz") on any type or property produces the stub (generated by kapt):
@Default("asc")
enum class OrderBy {
    ASC,
    DESC,
}

@kotlinx.serialization.Serializable()
@io.github.smiley4.schemakenerator.core.annotations.Default()
public enum OrderBy {
    // ... remainder omitted for brevity

As you can see, the parameter gets stripped, resulting in:
/home/rmcmk/project/build/tmp/kapt3/stubs/main/very/cool/package/names/OrderBy.java:9: error: annotation @Default is missing a default value for the element 'default'
@io.github.smiley4.schemakenerator.core.annotations.Default()
^

The only difference I physically see from the other annotations is that val default: String is not documented with KDoc, which really shouldn't matter?
Default.kt
Description.kt
Wondering if anyone else is using kapt (perhaps from another library than avaje-inject?) having a similar issue?
Edit: It's the name of the parameter... default is a restricted java keyword.. duh. Been awhile...

ah,  mmh, the java keyword ...    thanks for the fix :sweat_smile:  :+1:


chore: enhance bug and regression template with debug log session

Summary
Bring back debug log session from the old issue template to bug/regression issue template
Test plan
N.A.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
N.A.

Pull Request Test Coverage Report for Build 4366

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.809%

Totals

Change from base Build 4364:
0.0%

Covered Lines:
1146

Relevant Lines:
1182

💛  - Coveralls


Update side navigation icons with new duotone design

Is your feature request related to a problem? Please describe.
No issues with the current icons; this request is for a design enhancement.
Describe the solution you’d like
Replace the existing side navigation icons with redesigned duotone icons that align with the platform’s design system.

do you have any svg files for these logos bcz current page is having a green tone logo

As the theme is green and white we can use the combination of these two colors in icons.

This folder contains the duotone icons used for the side navigation links. I have updated the Ambulance and Microscope icons by optimizing them in Adobe Illustrator to reduce the number of paths. cc @bodhish
Sidenav-Icons-svg.zip

@vinutv no icon for facility
@bodhish

Sidenav-Icons-svg.zip
Here is the updated folder containing icons for the facility. @shivankacker


onMuted callback

I've looked at a few of the issues that address this to some extent but I'm confused why there isn't an actual callback function track whether video is muted or unmuted?
Current Behavior
I've seen the onProgress solution but that also continuously updates and causes the dataLayer to push every time the onProgress is updated... not really ideal if you just want to know when the unmutes or mutes.
@cookpete I believe your example to a listener demonstrates this https://jsfiddle.net/nxkfue56/
Expected(Liked) Behavior
It would be ideal if we had simply a callback function for mute similar to the onPlay and onPause

ReactPlayer can only support what the player APIs support. The only player API I can find that has a muted event is Wistia. There is no value in adding a callback prop only supported by one type of player. If you are playing Wistia videos and you want to know when the player is muted, you can just add a listener yourself using getInternalPlayer. For all other video types we can't support onMuted simply because the players do not tell us when they are muted or unmuted.
Not even <video> elements have a muted event (you can listen for volumechange events but obviously that triggers on every volume change too).


Not able to debug libvirt issues if launcher crashes

What happened:
A VM fails to start, the pod logs hint that it's a libvirt issues:
level=info timestamp=2018-07-13T09:22:14.125248Z pos=libvirt.go:256 component=virt-launcher msg="Connecting to libvirt daemon: qemu:///system"

level=error timestamp=2018-07-13T09:22:14.207290Z pos=libvirt_helper.go:146 component=virt-launcher msg="libvirtd exited, restarting"

level=error timestamp=2018-07-13T09:22:15.244135Z pos=libvirt_helper.go:146 component=virt-launcher msg="libvirtd exited, restarting"

level=error timestamp=2018-07-13T09:22:16.280373Z pos=libvirt_helper.go:146 component=virt-launcher msg="libvirtd exited, restarting"
…
panic: failed to connect to libvirtd: cannot connect to libvirt daemon: timed out waiting for the condition

goroutine 1 [running]:

main.createLibvirtConnection(0xc4200b4d80, 0x11f4c80)

    /root/go/src/kubevirt.io/kubevirt/cmd/virt-launcher/virt-launcher.go:111 +0x125

main.main()

    /root/go/src/kubevirt.io/kubevirt/cmd/virt-launcher/virt-launcher.go:253 +0x440

virt-launcher exited with code 2

When trying to exec into the compute pod, this fails, because the container continues to crash.
What you expected to happen:
Either get the libvirt logs on the pod logs. Or ability to log into the pod to debug libvirt
How to reproduce it (as minimally and precisely as possible):
Make virt-launcher crash and try to debug libvirt
Anything else we need to know?:
Environment:

KubeVirt version (use virtctl version): 0.7.0-alpha.2
Kubernetes version (use kubectl version): 1.11
VM or VMI specifications:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release): ubuntu
Kernel (e.g. uname -a):
Install tools:
Others:

In general, we can enable libvirt logs to write to /var/log/libvirt and to add the possibility to add PVC that will be mounted to this directory. @fabiand Will it be good enough?

Logs are written afaik.
The issue is that the container is restarting to fast to get them.
Adding a PVC could help. But if we use the PVC approach, then we should see that it fits in with other log aggregation.
What I want to say: libvirt logs are important for for debugging, thus these logs must land in the log aggregation system of the cluster.
Thus here to me it would be important to understand if it's a common pattern (and I heared that it was thought of) to use PVCs for log writing, and then also for log collection.

From my point of view the virt-launcher process which also starts and monitors libvirt should also collect the logs and write them to stdout. If we change the architecture on how we use libvirt we can change that again. Right now that seems to be the most logical solution ...

That looks straight forward.
Although we could also add a fluentd side-car as described in https://kubernetes.io/docs/concepts/cluster-administration/logging/#sidecar-container-with-a-logging-agent

@rmohr would configuration of libvirt to use stderr for all logs be a good solution?
https://libvirt.org/logging.html

@rmohr would configuration of libvirt to use stderr for all logs be a good solution?
https://libvirt.org/logging.html

If that works then great. As far as I remember the qemu logs are sent to virtlogd. So not sure if we would see these logs then too.

@slintes Just take in account that libvirt debug log is huge, so it ok for me if you want to send only errors messages to stderr, but you still will have cases when you will need whole debug log.


Made location object creation from snapshot function public

My particular application is watching location changes by location key, and querying for nearby locations.  The ability to take the snapshot from the query and directly convert that into a location object for the next query would be very handy.  This change makes that possible.

@jwngr thoughts?  This does seem useful but I assume you had a reason for making this private in the first place.

I'm a bit confused as to the exact use case. The intent of the library is to use a GeoQuery's onKeyEntered() method to query for nearby locations. That listener returns the location is a digestible format, as can be seen in the example here.
I guess I am not fully against making this public, but I would like to understand the use case more before we do that.
BTW @jdimond was the one who wrote this code, not me. He may have some opinion on the matter as well.

@jwngr Well, my intent was to have a bunch of users, each of which had a location attached to them.  The code was querying for users nearby to each other one, based on ID.  I wanted to query the location object directly to keep the GeoQuery up-to-date, but that didn't work, apparently because of a thread issue (https://github.com/firebase/geofire-java/issues/40).
So since that doesn't work, I guess my use-case for this has evaporated. If it's not possible to query the locations from the application in parallel with GeoFire, there's no real reason to need to perform that conversion. :cry:

Actually, my use-case is still valid.  I believe my app isn't working in AppEngine because of a bug (#40), not because of an inherent design flaw in my application.  Once that's fixed, my use-case will again be valid.

@jonahbron looks like some of your AppEngine code got mixed up in this PR, is that intentional?

@samtstern Oops, my bad.  Let me fix that.

@samtstern Fixed.  Moved some stuff into the wrong branch.

@jonahbron would you be able to squash commits?

@melashkov I could probably figure out how to do that, but I'm pretty sure you can choose that in Github when you merge.

Friendly ping here. @melashkov you can do this now with GitHub (Squash & merge)

@anniktech I am not a awener of repo, cant merge 😢

Thanks for the ping!  I will merge this now.

Could you also have a look at #76?


[Question]Can this work on nodejs?

It should, but it's blocking on #19 being fixed first.
More detail
You can use https://github.com/stackgl/headless-gl which implements the WebGLContext in node.js. The change you need to make is here: https://github.com/PAIR-code/deeplearnjs/blob/master/src/math/webgl/webgl_util.ts#L89
The bigger problem is that headless-gl doesn't support OES_texture_float extension which our library currently depends on. The good news is that we are working to get around that limitation since we wants to support large number of mobile devices (including iOS).

@dsmilkov The link: https://github.com/PAIR-code/deeplearnjs/blob/master/src/math/webgl/webgl_util.ts#L89, is now a 404. Could you please update it?

Updated!

With deeplearn.js becoming TensorFlow.js, we are super excited to share that we are actively working on node.js bindings that will use the TensorFlow C API. Stay tuned!

This is the tracking bug for nodejs: https://github.com/tensorflow/tfjs/issues/36


[DDW-10] Cardano is a fully decentralized screen

This PR implements Cardano is fully decentralized screen.
Design: https://app.zeplin.io/project/57acfaa7436a750316161a8b/screen/5f1c3d5dad536343006a092a
Todos

[ ] Add UI updates
[ ] Add copy changes

Screenshots

Testing Checklist

Slack QA thread
[ ] Test

Review Checklist
Basics

[ ] PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
[ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
[ ] PR has a good description that summarizes all changes
[ ] PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:

[ ] In English
[ ] In Japanese

[ ] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance and unit tests are passing (yarn test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
[ ] There are no flow errors or warnings (yarn flow:test)
[ ] There are no lint errors or warnings (yarn lint)
[ ] There are no prettier errors or warnings (yarn prettier:check)
[ ] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (yarn storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Merge the PR
[ ] Delete the source branch
[ ] Move the ticket to done column on the YouTrack board
[ ] Update Slack QA thread by marking it with a green checkmark

Closing this one as it is being replaced by https://github.com/input-output-hk/daedalus/pull/2463


Fix to show 404 for deleted user public profile page

I'm working on a quick fix of Public Profile page.
When Google tried to crawl deleted users' public profile pages, it generated a bunch of exception errors which fired false alert.  (opps)
I think it would be nice to render 404 not as exception error page.
But my method won't send 404 response to browser.
Does anyone know a quick way to render a real 404 page from view() method of single_page?

Hmmm I wonder why c5 core Travis CI test failed as my repo test was passed...
https://travis-ci.org/katzueno/concrete5/builds/257097972

@katzueno I posted about that in slack awhile ago. I don't know the answer but I suspect the reason has to do with some updates they did last week. Someone with more travis knowledge than me will have to investigate.


refactor: change phrase to describe end date of task

The description of the end date component will not change regardless of the timestamp. The button is not the best button as well and could use a little make up!

Proposal:

Change "Ending" into "Ended" after the task has been completed or expired.
Change the button colors and overall design to something that communicates better with the other components. Show us your inner artist!
Post the button design result in this issue or in the PR response.

I am working on this task!

I've changed the button to be red when the task is canceled and to be green when the task is completed, besides the message showing as "Ended" instead of "Ending" what do you think?
Img 1

Img 2

Hey, @0xneves What do you think of the changes? Do you want to see anything else or change something?

@RafaDSan  Awesome additions! This issue was not being tracked in the dashboard as in-progress so I skipped, thank you for updating it Sir!

Thank you for your feedback! I'll do the PR then :)


RDP to AADJ device using WHfB requires on-prem infrastructure and is …

…possible with key trust deployment
(I). Suggest updating the following statement:
From : "- Cloud only, Hybrid, and On-premises only Windows Hello for Business deployments"
To: " Hybrid and On-premises Windows Hello for Business deployments"
due to the following two reasons -
(i). customer was confused that that RDP to Azure AD Joined device using WHfB was possible with "cloud only" environment (without any only-premises infrastructure). At this time, in order to RDP to Azure AD Joined device using WHfB, a certificate needs to be installed on the devices, which in turn requires on-premises infrastructure (Certificate Authority server and AD DS).
(ii) This seems to contradict with other documents detailing the procedures where it this is stated in the context of "Hybrid deployment." Other documents URL copied below -
https://docs.microsoft.com/en-us/windows/security/identity-protection/hello-for-business/hello-hybrid-aadj-sso-base
https://docs.microsoft.com/en-us/windows/security/identity-protection/hello-for-business/hello-hybrid-aadj-sso-cert
https://docs.microsoft.com/en-us/windows/security/identity-protection/hello-for-business/hello-deployment-rdp-certs
(II) Suggest removing the following phrase
"This functionality is not supported for key trust deployments." because "deploying WHfB for RDP" is possible with "key trust" per following documents.
https://docs.microsoft.com/en-us/windows/security/identity-protection/hello-for-business/hello-hybrid-aadj-sso-base
https://docs.microsoft.com/en-us/windows/security/identity-protection/hello-for-business/hello-deployment-rdp-certs

thank you for the contribution @yukieryu , I approved the change


rand_from_seed needs a cleanup

As far @grabiller and I could work out from rand_from_seed in math_funcs.cpp, there are some inconsistencies in the function; among those:

line 50 winds up being s = -2836*s/127773
the condition in line 51 can never be true, therefore line 52 never executes

@iajrz Looks like you never got to make this PR?

@akien-mga The HDD I was working on died before I pushed the changes to my remote repo. I am still in pain over that. It's a bit unlikely that I set the dev-env up and write the code again 'cause of what I'm doing now, but if/when I find the time to do it, I'll let you all know in this thread.

@iajrz :
Wow ...
I tried with the godot's Math::rand_from_seed() and found it was giving poor randomness compared to MT19937 or XONOROSHI128PLUS.
And I've added and set MT19937 as default for the baker.
Now, I would like to improve Math:rand_from_seed() to gives better characteristics (like higher periodicity).
But the first problem i'm encountering, is that I find difficult not to break the API.
The seed of Math::rand_from_seed() that is passed as parameter and returned as result is not just a seed, it's also the 32bits state of the PRNG.
And in most other PRNG algorithms that I tried in #6683, the smallest state is 64 bits.
For instance, the suggested Mersenne Twister PRNG, standardized as MT19937, has a state of 20000 bits (2500 bytes), which would be difficult to pass and return through Math::rand_from_seed().
Could you try to remember how you proceeded to improve Math::rand_from_seed() without breaking API ?

Wow ... I hope there is no curse on Math::rand_from_seed(), because I definitively don't want my HDD to die if I manage to successfully succeed you on this task :-/
So a 32bits Xorshift PRNG :
uint32_t seed = 7;  // 100% random seed value

static uint32_t random()
{
  seed ^= seed << 13;
  seed ^= seed >> 17;
  seed ^= seed << 5;
  return seed;
}

found here : http://excamera.com/sphinx/article-xorshift.html

well, given that Math::RANDOM_MAX is 0x7FFFffff, the periodicity of this Xorshift32 PRNG "might be" 2^31 - 1.
I say "might be", because i'm not good enough with mathematics to understand if masking the returned seed with Math::RANDOM_MAX actually change Xorshift32 into Xorshoft31 ...
uint32_t Math::rand_from_seed(uint32_t *seed) {
	if ( *seed == 0 ) *seed = Math::RANDOM_MAX;
	(*seed) ^= (*seed) << 13;
	(*seed) ^= (*seed) >> 17;
	(*seed) ^= (*seed) << 5;
	return (*seed) & Math::RANDOM_MAX;
}

I'll just test the periodicity for your function... been looking for an excuse to test CLion :smile:

@SuperUserNameMan: with the masking you're using, I've found seed 6873698 has a period of 127. I think that is too low. 😢
This is what I used to find it:
uint32_t rand_from_seed(uint32_t *seed) {
    if (*seed == 0) *seed = 0x7FFFffff;
    (*seed) ^= (*seed) << 13;
    (*seed) ^= (*seed) >> 17;
    (*seed) ^= (*seed) << 5;
    (*seed) &= 0x7FFFffff;
    return (*seed);
}

long long period_for_seed(uint32_t seed,long long worst) {
    auto current_value = seed;
    long long i = 0;
    do {
        rand_from_seed(&seed);
        i++;
    } while (current_value != seed && i < worst);
    return i;
}

int main() {
    uint32_t current_seed = 0;
    uint32_t worst_seed = 0;
    long long worst_period =<PHONE_NUMBER>;

    while (current_seed <<PHONE_NUMBER>) {
        current_seed++;
        long long current_period = period_for_seed(current_seed,worst_period);
        if (current_period < worst_period) {
            worst_period = current_period;
            worst_seed = current_seed;
            std::cout << current_seed << "; seed: " << worst_seed << " period: " << worst_period << std::endl;
        }
    }
    return 0;
}

A good question is: why, if the function returns a uint32_t, is the value truncated to 31 bits? I would understand if it were signed. Any ideas?

This code is only ever called by gdscript and visualscript, and I see both the truncated value that is returned, and the non-truncated value that is set into the seed, passed as an array. I can't make time to trace the code any further, but the reason behind that should probably be cleared up before we keep playing around with this.

Well, I guess that Math::rand_from_seed() was masked to 31bits to keep it compatible with GDscript signed integers.
I will investigate a little further later this week when i'll have more free time to focus on it.

I think I understood what's happening with the return value and the one set on the seed's memory: the value is masked, but the seed is not, so that the 32-bit algorithm can work properly. If when you check this holds true, it would mean that you could use the 32-bit algorithm you found in this form:
uint32_t rand_from_seed(uint32_t *seed) {
    if (*seed == 0) *seed = 0x7FFFffff;
    (*seed) ^= (*seed) << 13;
    (*seed) ^= (*seed) >> 17;
    (*seed) ^= (*seed) << 5; /* seed is 32 bits, and is going to be used in the future. */
    return (*seed)&0x7FFFffff; /* current value is signed int (thus, masking the 32nd bit to 0 to keep it positive)*/
}

What bothered me was the int / uint32_t castings involved between C++ and GDscript in rand_seed() ...
As I did not code in C for long time, I forgot that the casting between signed and unsigned was not destructive.
So, yes, the masking can be applied only to the returned result and not to the stored seed.
I'm going to update the PR.

Well, as for the periodicity of this PRNG, as long as the stored seed remains 32bits, it should remain 2^32 - 1.
The natural periodicity of Xorshift32 will be altered only if the stored seed is altered somewhere between the signed/unsigned int conversions that happen between C++, Variants and GDscript.
uint32_t rand_from_seed(uint32_t *seed) {
    if (*seed == 0) *seed = 0x7FFFffff;
    (*seed) ^= (*seed) << 13;
    (*seed) ^= (*seed) >> 17;
    (*seed) ^= (*seed) << 5;
    return (*seed)&0x7FFFffff;
}


openssl error

Currently having SSL issues when running cypress tests inside github actions.
Some fixes I've tried that I found suggested through various googling:

Upgrading Node from 14.18.2 -> 16.20.0
Setting wait-on from http://localhost:9000 to http://<IP_ADDRESS>:9000
Upgrading github-actions from v3 to v5
Removing wait-on entirely (ssl error still occurs when running the tests)

Logs:
Run cypress-io/github-action@v2
  with:
    browser: chrome
    install: false
    config-file: cypress.config.ts
    command-prefix: yarn
    start: node server
    wait-on: http://localhost:9000
    spec: cypress/e2e/reports/*.spec.js
    record: true
Skipping install because install parameter is false
start server "node server command "node server"
current working directory "/home/runner/work/[redacted]/[redacted]"
waiting on "http://localhost:9000" with timeout of 60 seconds
/opt/hostedtoolcache/node/16.20.0/x64/bin/node server
App listening on port 9000!
(node:2057) NOTE: We are formalizing our plans to enter AWS SDK for JavaScript (v2) into maintenance mode in 2023.

Please migrate your code to use AWS SDK for JavaScript (v3).
For more information, check the migration guide at https://a.co/7PzMCcy
(Use 'node --trace-warnings ...' to show where the warning was created)
(node:2057) Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0' makes TLS connections and HTTPS requests insecure by disabling certificate verification.
(node:2046) Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0' makes TLS connections and HTTPS requests insecure by disabling certificate verification.
http://localhost:9000 timed out on retry 8 of 3, elapsed 94065ms, limit 90000ms
Error: write EPROTO<PHONE_NUMBER>34816:error:1408F10B:SSL routines:ssl3_get_record:wrong version number:../deps/openssl/openssl/ssl/record/ssl3_record.c:332:

These issues don't happen locally when I run tests following the same steps of:
yarn build:ci
node server
yarn cypress run

@emmakopf

These issues don't happen locally when I run tests following the same steps of:
yarn build:ci
node server
yarn cypress run

Which version of Node.js are you running locally? (Also for completeness, which version of Cypress are you running?)

I am running Node.js 16.20.0 and cypress 12.7.0

@emmakopf
Thanks for the version information!
I would suggest anyway to update to the latest version i.e. cypress-io/github-action@v5 as there are planned changes in GitHub which will stop earlier versions working sooner or later. @v2 as shown in your log runs on GitHub using node12 which is no longer supported, and possibly this could be causing a compatibility issue with AWS. @v5 runs on GitHub using node16.
If updating to @v5 does not solve your problem, then if you add the following to your workflow, you will see the steps in more detail:
  env:
    DEBUG: '@cypress/github-action'

Hi @emmakopf , did Mike's suggestions help you solve your issue?

@emmakopf
We haven't heard back from you. How are you progressing in resolving your issue? It does not look like it is primarily caused by github-action and it is more likely to be an app <=> Node.js version incompatibility I would guess.

Unfortunately we have to close this issue due to inactivity. Please comment if there is new information to provide concerning the original issue and we can reopen.


Feature: Add liquidity scan on startup for all markets of top 100 tokens

When searching for markets by token, we need to be able to sort them by $ in liquidity on bid/asks (combined), as a metric for which one the user should choose. (e.g. The more resting liquidity on the bid/ask -> Sorted higher).

Get best bid for SOL/USDC (For a SOL reference price)
After getProgramAccounts is called for SOL and USDC quoted pairs: For the top 100 tokens, aggregate all the bid/ask pubkeys on all their markets, and batch them into getMultipleAccounts. Sum up the liquidity for each marketId, and insert into a Map<String, Float> or Map<String, Map<String, Object>> (if using a "metadata" approach
Key: marketId (String)
Value: aggregateAmount (Float) or metadata (Map) containing the Float.

USDC quoted markets are already in USD value, so only addition is needed. The SOL quoted markets will be SOL * (SOL_Price), added together.

Resolved by 9c06152. (Which is much more efficient and just reads from the Market account struct, no other polls needed.)


fix: Changed "Searborn" to "Seaborn".

Hi @NeelPatel31 !
We just merged this PR that fixed the same issue so we are going to close this PR.
Thanks for understanding!


Changed crates.io badges

https://img.shields.io/crates badges sometimes works bad, sometimes doesn't work at all (as it now)

https://img.shields.io/crates now alive


[Draft] [Do Not Review] Depth Supervision for Gaussian Splatting

TBD

Hi! you might also find the work from @maturk interesting here: https://maturk.github.io/dn-splatter/

Hi @mattstrong-stanford, would you be interested in making a pr with your depth-ranking implementation within dn-splatter? In that project, I tried to support depth supervision with real sensors (either z-depths or euclidian/ray depths) as well as some minimal monocular supervision (via alignment of scale/shift). It also supports normal supervision within the 3DGS context, but I also plan to support a 2DGS variant in the future. I already have a few different depth losses supported, although the list is not exhaustive. Let me know what you think, happy to collab on depth GS stuff.

Hi @maturk, I would love to collaborate on depth-GS (I was using my other Github account because of different forked versions).
I and another robotics graduate student are planning to hopefully integrate 2D-GS into Nerfstudio soon, so I bet we could get that done as well.
Maybe we could sync up to collab via email? My email is<EMAIL_ADDRESS>


[SR-5822] Enum key paths

Previous ID
SR-5822

Radar
None

Original Reporter
@stephencelis

Type
Improvement

Additional Detail from JIRA

Votes
4

Component/s
Compiler

Labels
Improvement, LanguageFeatureRequest

Assignee
None

Priority
Medium

md5: 451b3f7df8e7d6b288d80f2e95904a96

Issue Description:
Key paths currently only work for product types, but sum types would benefit, as well!
enum Result<T> {
  case success(T)
  case failure(Error)
}

\Result<String>.success?.count
// KeyPath<Result<String>, Int?>

let kp = \Result<User>.success?.name
let result = Result.success(User(name: "an anonymous imp"))
result[keyPath: kp] = "Rumpelstiltskin"

if case let .success(user) = result {
  print(user.name)
}
// prints "Rumpelstiltskin"

For anyone still watching this.  https://github.com/apple/swift/pull/58940


blueprint reader: support implicit matset by detecting ho volfrac fields

Description
Extends support high order volume fractions detection to a new case  for the blueprint plugin.
Injects a matset into the blueprint index when fields named volume_fraction_001 --> volume_fraction_00Z are detected.
Then exist HO logic from @BradWhitlock kicks into gear during fetch.
Type of change

[ ] Bug fix~~
[x] New feature~~
[ ] Documentation update~~
[ ] Other~~

How Has This Been Tested?
Tested on test data set on LC.
Reminders:

Please follow the style guidelines of this project.
Please perform a self-review of your code before submitting a PR and asking others to review it.
Please assign reviewers (see VisIt's PR procedures for more information).

Checklist:

[x] I have commented my code where applicable.~~
[ ] I have updated the release notes.~~
[ ] I have made corresponding changes to the documentation.~~
[x] I have added debugging support to my changes.~~
[ ] I have added tests that prove my fix is effective or that my feature works.~~
[ ] I have confirmed new and existing unit tests pass locally with my changes.~~
[ ] I have added new baselines for any new tests to the repo.~~
[ ] I have NOT made any changes to protocol or public interfaces in an RC branch.~~

Need to re-target the source branch.


No implementation found for method listen on channel live_activities/token_channel

Interface to handle activityUpdateStream on native was removed in #25 but at the same time recommend to use it.
Which leaves us with the following error
MissingPluginException(No implementation found for method listen on channel live_activities/token_channel)

Hi @ErasmoCM thanks for your issue.
It's now fixed & released as 1.7.1!


pasting text into the input sends msg

no carriage return in the text being pasted, but it gets sent immediately

seeing another bug in pasting that when doing multi line pastes, the first character of each line is getting cut off.

Dup #26


Onboarding TODO list in Alby hub wallet page

From @bumi :
Once you get started it would be nice to have a TODO list on the main wallet page that's very obvious for what users should do next.

Open first channel
Link wallet to your Alby account
Create first app connection
Make first payment
Help a friend to get on lightning

(Maybe easy to start with the first 3)

Add save your seed phrase before Helping a friend

Fixed with #431


Consider using semantic HTML for the switch component

Switch component uses a button with role switch and aria properties. Consider switching (pun unintended) to <input type=“checkbox” role=“switch” > instead.

Switches are toggle buttons, which is why we're using a button instead of a checkbox :)

@asyncLiz According to the APG, this is not exactly true.

A switch is an input widget that allows users to choose one of two values: on or off. Switches are similar to checkboxes and toggle buttons, which can also serve as binary inputs. One difference, however, is that switches can only be used for binary input while checkboxes and toggle buttons allow implementations the option of supporting a third middle state. Checkboxes can be checked or not checked and can optionally also allow for a partially checked state. Toggle buttons can be pressed or not pressed and can optionally allow for a partially pressed state.

That describes switches as similar to checkboxes and toggle buttons, which is still accurate. Our switch is most similar to a toggle button in Material Design.
From an assistive technology's perspective though, they are identical. <button role="switch"> is semantically the same as <input type="checkbox" role="switch"> or <div role="switch">.


Added country/india

Pull Request Test Coverage Report for Build 355

216 of 216 (100.0%)  changed or added relevant lines in 2 files are covered.
40 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 99.021%

Files with Coverage Reduction
New Missed Lines
%

holidays.py
40
97.58%

Totals

Change from base Build 354:
0.0%

Covered Lines:
4955

Relevant Lines:
5004

💛  - Coveralls

Pull Request Test Coverage Report for Build 355

216 of 216 (100.0%)  changed or added relevant lines in 2 files are covered.
40 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 99.021%

Files with Coverage Reduction
New Missed Lines
%

holidays.py
40
97.58%

Totals

Change from base Build 354:
0.0%

Covered Lines:
4955

Relevant Lines:
5004

💛  - Coveralls


Does not accept over-disambiguated SAN moves

Hi,
I hit a problem today with SAN being somehow underspecified. Look at this case:
board = new Chess("1r5k/6p1/3p3p/8/8/4bQ2/2R3PP/2KRq3 w - - 6 44")
board.move("Rcd2")
The problem is that there are two rooks that can reach d2 (at c2 and d1). However, the rook at d1 cannot strictly reach d2, since doing that would put the king in check.
Different programs deal with this differently; I've seen programs that disambiguate (Rcd2) and programs that don't (Rd2). In an attempt at being compatible with less intelligent programs, which cannot accept Rd2, my program outputs the safe choice, but seemingly chess.js doesn't accept this. (It does accept Rd2.)
Would it be possible to make chess.js accept the over-disambiguated version?

Yes, we're currently working this into the next release.
This is issue seems to be popping up quite a bit over the last month.  For the record, over-disambiguation is incorrect according to section <IP_ADDRESS> of the PGN spec.  The next release will have something like chess.load_pgn({sloppy: true}) to handle situations like this.
This is a duplicate of issue #87 so I'm going to close it and suggest we keep discussion over there.

FWIW, I don't do this from PGN, so you'll need a parameter to move() as well.

0.10.0 should fix this issue now.  Use the sloppy parameter to force the parsing of any over disambiguation (e.g. chess.move('Rcd2', {sloppy: true})

The sloppy-mode in .move() works for overdisambiguations, but it not seem to accept the correctly disambiguated moves.
chess.load_pgn("1.e4 e5 2.Nf3 Nc6 3.Bc4 Nf6 4.Ng5 d5 5.exd5 Nxd5 6.Nxf7 Kxf7 7.Qf3+ Ke6 8.Nc3")

true
chess.move("Nb4", {sloppy: true})
null
chess.move("Ncb4", {sloppy: true})
Object {color: "b", from: "c6", to: "b4", flags: "n", piece: "n"…}

I'll change the logic to always try the strict parser first, then fall back to the sloppy parser if the move isn't found.

Go ahead and give 0.10.1 a try.

Works!


update requirment actions

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report
Base: 62.06% // Head: 44.45% // Decreases project coverage by -17.62% :warning:

Coverage data is based on head (49a714a) compared to base (2583ff6).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #555       +/-   ##
===========================================
- Coverage   62.06%   44.45%   -17.62%
===========================================
  Files         221      147       -74
  Lines       21466    15343     -6123
===========================================
- Hits        13323     6820     -6503
- Misses       7495     8213      +718
+ Partials      648      310      -338

Flag
Coverage Δ

1.16.x
44.10% <ø> (-17.65%)
:arrow_down:

1.19.x
44.53% <ø> (-17.38%)
:arrow_down:

1.20.x
44.47% <ø> (-17.47%)
:arrow_down:

insecure
?

integration
?

macOS-latest
44.06% <ø> (-0.37%)
:arrow_down:

secure
?

ubuntu-latest
44.45% <ø> (-17.58%)
:arrow_down:

unit
44.45% <ø> (-0.08%)
:arrow_down:

windows-latest
?

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


기여 횟수 접근 시 버그 발생: no such column: title

Environment (환경)

OS : Windows 10 (버전 1903, 빌드 18362.720)
Python version : 3.6.8
openNAMU version : v3.1.7-master-18 (커밋 8e32948)
Skin : marisa, simpledirty
Skin version : 1.1.8, 1

Explanation (설명)
기여 횟수 접근 시 발생.(/count)
내용이 없는 빈 문서를 생성하려는 시도를 하긴 했으나 이 버그의 발생에 영향을 줬는지는 알 수 없음. (재현 시도 안함)
sqlite3.OperationalError
sqlite3.OperationalError: no such column: title

Traceback (most recent call last)
File "C:\Users\ShapeLayer\AppData\Roaming\Python\Python36\site-packages\flask\app.py", line 2449, in wsgi_app
response = self.handle_exception(e)
File "C:\Users\ShapeLayer\AppData\Roaming\Python\Python36\site-packages\flask\app.py", line 1866, in handle_exception
reraise(exc_type, exc_value, tb)
File "C:\Users\ShapeLayer\AppData\Roaming\Python\Python36\site-packages\flask\_compat.py", line 39, in reraise
raise value
File "C:\Users\ShapeLayer\AppData\Roaming\Python\Python36\site-packages\flask\app.py", line 2446, in wsgi_app
response = self.full_dispatch_request()
File "C:\Users\ShapeLayer\AppData\Roaming\Python\Python36\site-packages\flask\app.py", line 1951, in full_dispatch_request
rv = self.handle_user_exception(e)
File "C:\Users\ShapeLayer\AppData\Roaming\Python\Python36\site-packages\flask\app.py", line 1820, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "C:\Users\ShapeLayer\AppData\Roaming\Python\Python36\site-packages\flask\_compat.py", line 39, in reraise
raise value
File "C:\Users\ShapeLayer\AppData\Roaming\Python\Python36\site-packages\flask\app.py", line 1949, in full_dispatch_request
rv = self.dispatch_request()
File "C:\Users\ShapeLayer\AppData\Roaming\Python\Python36\site-packages\flask\app.py", line 1935, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File "C:\Users\ShapeLayer\Documents\GitHub\2DU\openNAMU-SimpleDirty\app.py", line 636, in user_count_edit
return user_count_edit_2(conn, name)
File "C:\Users\ShapeLayer\Documents\GitHub\2DU\openNAMU-SimpleDirty\route\user_count_edit.py", line 18, in user_count_edit_2
curs.execute(db_change("select count(title) from topic where ip = ?"), [that])
sqlite3.OperationalError: no such column: title
The debugger caught an exception in your WSGI application. You can now look at the traceback which led to the error.
To switch between the interactive traceback and the plaintext one, you can click on the "Traceback" headline. From the text traceback you can also create a paste of it. For code execution mouse-over the frame you want to debug and click on the console icon on the right side.

You can execute arbitrary Python code in the stack frames and there are some extra helpers available for introspection:

dump() shows all variables in the frame
dump(obj) dumps all that's known about the object
Brought to you by DON'T PANIC, your friendly Werkzeug powered traceback interpreter.

Screenshot (스크린샷)

곧 수정 예정

수정 완료


Problem with Comparable

/Users/simon/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/activesupport-4.0.2/lib/active_support/callbacks.rb:378: warning: Comparable#== will no more rescue exceptions of #<=> in the next release.
Return nil in #<=> if the comparison is inappropriate or avoid such comparison.

@RickCarlino previously opened this here https://github.com/mongoid/mongoid/issues/3928
The folks at mongoid kind of closed it abruptly, but they may be right. Basically there's some places where we're comparing things that just ain't kosher. We should fix that. This might be a problem with our test suites!

This is what's causing the warnings: https://redmine.ruby-lang.org/issues/7688
I still don't know whether this is a problem with mongoid. I suspect it is, cause it happens when calling things like .save on a model.
(ex in mutations/gardens/create_garden.rb)

Interestingly enough these warnings aren't happening on TravisCI.

Turns out we changed something on TravisCI, and now they are happening there.

This is fixed with upgrading to Rails 4.1.9 and referencing Mongoid 4.0.2 from the gem.


add more tests

Codecov Report

Merging #5 (651341c) into master (695bf52) will increase coverage by 0.28%.
The diff coverage is 52.63%.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   14.73%   15.02%   +0.28%
==========================================
  Files          14       15       +1
  Lines        2504     2523      +19
==========================================
+ Hits          369      379      +10
- Misses       2135     2144       +9

Impacted Files
Coverage Δ

tests/unit/test_ecm_spiral.py
52.63% <52.63%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 695bf52...651341c. Read the comment docs.


使用VS2019社区版创建的MVC项目，编辑cshtml文件时，需要重新生成，浏览器才能生效-Using the MVC project created by the VS2019 Community Edition, when editing the cshtml file, it needs to be regenerated for the browser to take effect.

VSF_TYPE_MARKDOWNI have two versions of VS2017 and VS2019 on My Computer (WIN7), all of which are community versions,
I built a new asp.net Web core Application on two versions of VS,Select the MVC template.
Then discover that the project created on VS2017, starting on 17 or 19,Editing the Cshml file, F5 refreshing the browser, is normal.
And the project created on the VS2019, starting, on 17 or 19,
Edit the Cshml file, F5 refresh the browser, the interface is displayed or the previous interface is not edited.The browser displays the edited interface only if the VS is restarted.
To prevent it from being a caching problem, I also did tests in browsers such as Firefox,chrome,
And, manually cleaning up the cache, refreshing the interface, or no effect. That's VS2019 's problem, isn't it? Or what do you need to set up?
This issue has been moved from https://developercommunity.visualstudio.com/content/problem/595299/使用vs2019社区版创建的mvc项目编辑cshtml文件时需要重新生成浏览器才能生效.html
VSTS ticketId: 905445
These are the original issue comments:
Visual Studio Feedback System on 6/4/2019, 11:34 PM (34 days ago): We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.
Visual Studio Feedback System on 6/5/2019, 07:35 PM (34 days ago): Thank you for sharing your feedback! Our teams prioritize action on product issues with broad customer impact. See details at:  https://docs.microsoft.com/en-us/visualstudio/ide/report-a-problem?view=vs-2017#faq . In case you need answers to common questions or need assisted support, be sure to use  https://visualstudio.microsoft.com/vs/support/ . We'll keep you posted on any updates to this feedback.
These are the original issue solutions:
(no solutions)

Thanks for contacting us.
Are you creating these two projects targeting the same .Net Core SDK version?

And what is the version.

No, create the two projects simply,and then, start ,modified. Because I am a novice.

Thanks, @Homey-ka.
Please provide the result of dotnet --version and dotnet --info from within folders of both projects.
Also, here is an article about Runtime Compilation, in case it helps: https://docs.microsoft.com/en-us/aspnet/core/mvc/views/view-compilation?view=aspnetcore-2.2

Feel free to reopen once you have more details to share.


why_redux_preferred_over_context-api

Is the merging in this repository is stopped ..plzz accept it if not so..i have made pr 6 days ago..and still not accepted


Wrong sent folder when switching accounts

Expected behavior
I have two accounts, A and B. Email arrives in account A. I reply to it. In the From: field, I change from A to B. I expect the email to be saved in the Sent folder of account B. Instead, it is saved in the sent folder of account A.
Actual behavior
The email is saved in the sent folder of account A.
Steps to reproduce
See above.
Environment
K-9 Mail version: 5.403
Android version: 7.0
Account type (IMAP, POP3, WebDAV/Exchange): IMAP

i think i had something similar happen with a draft that i switched between identities (two different accounts). i'll try to post more details soon, like a proper pr.

Please create a new issue if this is still a problem with K-9 Mail 5.7xx.


Set screenshot threshold to 0

Description
Size of screenshots is pretty big so having even 3% threshold is too big to catch changes in icons or text. Setting it to 0 for now. We'll see whether it will introduce noise or not. Hopefully not much.
Checklist

[x] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release >
[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

Codecov Report

Merging #3214 (23f3466) into main (b091fe4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #3214   +/-   ##
=========================================
  Coverage     79.62%   79.62%
  Complexity     2286     2286
=========================================
  Files           282      282
  Lines          9015     9015
  Branches        602      602
=========================================
  Hits           7178     7178
  Misses         1605     1605
  Partials        232      232

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


removed eo-runtime dependency

Related to #80.
We don't need eo-runtime anymore in our pom.xml file

@yegor256 I believe this fix should solve related to your comment problem

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 9min)