Improve Object.keys(object) and Object.values(object)

Search Terms

Suggestion
When all keys and values of object is known

Object.keys(object) should return array type of union of known properties
Object.values(object) should return array type of union of known values

How to implement?
I tried creating the 2 functions:
declare function keys<
    Object extends { [_: string]: any },
    Key extends keyof Object
> (obj: Object): Key[]

declare function values<
    Object extends { [_: string]: any },
    Key extends keyof Object
> (obj: Object): Object[Key][]

I also tested them: playground link
Use Cases
Use with objects
const object = {
  abc: 123 as 123,
  def: 456 as 456
}

const objectKeys = Object.keys(object) // objectKeys: Array<'abc'|'def'>
const objectVals = Object.values(object) // objectVals: Array<123|456>

Use with enums
enum Foo {
  abc,
  def = 'def'
}

const FooKeys = Object.keys(Foo) // FooKeys: Array<'abc' | 'def'>
const FooVals = Object.values(Foo) // FooVals: Foo[]

Caveats
It is possible to ignore extra keys/values that don't exist in type definition
interface Foo {
  abc: 'abc' // the only known key/value pair of Foo
}

const bar = {
  abc: 'abc' as 'abc', // exist in Foo
  ghi: 'ghi' as 'ghi' // doesn't exist in Foo
}

const foo: Foo = bar
const keys = Object.keys(foo) // TS emits `keys: 'abc'[]` but the correct value is `['abc', 'def']`

Examples

See use cases and playground link above
Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript / JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. new expression-level syntax)

Duplicate of this closed PR #25832.
As an example why:
const object = {
  abc: 123 as 123,
  def: 456 as 456
}

const objectKeys = Object.keys<{abc: 123}, 'abc'>(object) // objectKeys: Array<'abc'> whoops, array will contain 'def'

enum Foo {
abc,
def = 'def'
}

const FooKeys = Object.keys(Foo) // FooKeys: Array<'abc' | 'def'>
const FooVals = Object.values(Foo) // FooVals: Foo[]
keys of enum has not only "key"

While crawling through the issues I found this merged PR: https://github.com/Microsoft/TypeScript/pull/18175
Based on this precedence, would it make sense to type Object.keys as the union of all known properties and string[] for the unknown ones? Or is there simply no reasonable way to represent such a type?

Dates back to at least #12253


Get latest terraform

probably not the niceset way, but it will keep it getting the latest version.

Failed lint.
I have really mixed feelings about this PR. It would be nice not to have to worry about updating the version, but doing this means we cannot pin to a specific version. At the moment the images are tagged with the SHA of the commit, so it could be very confusing to have a version one day, then a different version the other day all whilst pulling the same tag!
Is there anyway to tag these images with the version please?

there is an issue for that #32

There might be an issue for it but this PR makes it worse :p

what you on about, the linting is fixed :)


Adds support for MG1 / MG2

Closes #7
So it turns out MG1 / MG2 just use a modified version of MGS3 that's designed to launch directly into the games (hence why MGS3's save menu is present, and the logos are all the same.)
All functionality that applies to MGS3 works correctly without any modification needed (with the exception of skipping the intro logos, which fails on pattern scan.)
16:9 - 2560x1440
File verbosity level: 9
date       time         ( uptime  ) [ thread name/id ]                   file:line     v|
2023-10-28 20:57:47.645 (   0.000s) [        F95F1D8E]             loguru.cpp:841   INFO| Logging to 'MGSHDFix.log', mode: 'w', verbosity: 9
2023-10-28 20:57:47.645 (   0.000s) [Main            ]            dllmain.cpp:237   INFO| MGSHDFix v0.6 loaded
2023-10-28 20:57:47.646 (   0.001s) [Main            ]            dllmain.cpp:271   INFO| Config Parse: iInjectionDelay: 500ms
2023-10-28 20:57:47.646 (   0.001s) [Main            ]            dllmain.cpp:272   INFO| Config Parse: bCustomResolution: 1
2023-10-28 20:57:47.646 (   0.001s) [Main            ]            dllmain.cpp:273   INFO| Config Parse: iCustomResX: 0
2023-10-28 20:57:47.646 (   0.001s) [Main            ]            dllmain.cpp:274   INFO| Config Parse: iCustomResY: 0
2023-10-28 20:57:47.646 (   0.001s) [Main            ]            dllmain.cpp:275   INFO| Config Parse: bWindowedMode: 1
2023-10-28 20:57:47.646 (   0.001s) [Main            ]            dllmain.cpp:276   INFO| Config Parse: bBorderlessMode: 1
2023-10-28 20:57:47.646 (   0.001s) [Main            ]            dllmain.cpp:277   INFO| Config Parse: bSkipIntroLogos: 1
2023-10-28 20:57:47.646 (   0.001s) [Main            ]            dllmain.cpp:278   INFO| Config Parse: bDisableCursor: 1
2023-10-28 20:57:47.646 (   0.001s) [Main            ]            dllmain.cpp:279   INFO| Config Parse: bMouseSensitivity: 0
2023-10-28 20:57:47.646 (   0.001s) [Main            ]            dllmain.cpp:280   INFO| Config Parse: fMouseSensitivity: 0.00
2023-10-28 20:57:47.646 (   0.001s) [Main            ]            dllmain.cpp:281   INFO| Config Parse: bAspectFix: 1
2023-10-28 20:57:47.646 (   0.001s) [Main            ]            dllmain.cpp:289   INFO| Config Parse: Borderless mode enabled.
2023-10-28 20:57:47.646 (   0.001s) [Main            ]            dllmain.cpp:314   INFO| Custom Resolution: fNewAspect: 1.7778
2023-10-28 20:57:47.646 (   0.001s) [Main            ]            dllmain.cpp:315   INFO| Custom Resolution: fAspectMultiplier: 1.0000
2023-10-28 20:57:47.646 (   0.001s) [Main            ]            dllmain.cpp:316   INFO| Custom Resolution: fHUDWidth: 2560.0000
2023-10-28 20:57:47.646 (   0.001s) [Main            ]            dllmain.cpp:317   INFO| Custom Resolution: fHUDOffset: 0.0000
2023-10-28 20:57:47.646 (   0.001s) [Main            ]            dllmain.cpp:324   INFO| Config Parse: Aspect ratio is native, disabling ultrawide fixes.
2023-10-28 20:57:47.646 (   0.001s) [Main            ]            dllmain.cpp:337   INFO| Game Name: METAL GEAR.exe
2023-10-28 20:57:47.646 (   0.002s) [Main            ]            dllmain.cpp:338   INFO| Game Path: G:\Steam\steamapps\common\MG and MG2\METAL GEAR.exe
2023-10-28 20:57:47.646 (   0.002s) [Main            ]            dllmain.cpp:350   INFO| Detected game is: Metal Gear / Metal Gear 2 (MSX)
2023-10-28 20:57:47.647 (   0.002s) [Main            ]            dllmain.cpp:363   INFO| MG/MG2 | MGS 2 | MGS 3: Custom Resolution: Address is 0x7ff6e189b0e3
2023-10-28 20:57:47.647 (   0.002s) [Main            ]            dllmain.cpp:369   INFO| MG/MG2 | MGS 2 | MGS 3: Custom Resolution: New Custom Resolution = 2560x1440
2023-10-28 20:57:47.647 (   0.003s) [Main            ]            dllmain.cpp:384   INFO| MG/MG2 | MGS 2 | MGS 3: Framebuffer 1: Address is 0x7ff6e18b57de
2023-10-28 20:57:47.647 (   0.003s) [Main            ]            dllmain.cpp:387   INFO| MG/MG2 | MGS 2 | MGS 3: Framebuffer 1: Patched instruction.
2023-10-28 20:57:47.648 (   0.004s) [Main            ]            dllmain.cpp:384   INFO| MG/MG2 | MGS 2 | MGS 3: Framebuffer 2: Address is 0x7ff6e18b583f
2023-10-28 20:57:47.648 (   0.004s) [Main            ]            dllmain.cpp:387   INFO| MG/MG2 | MGS 2 | MGS 3: Framebuffer 2: Patched instruction.
2023-10-28 20:57:47.649 (   0.004s) [Main            ]            dllmain.cpp:403   INFO| MG/MG2 | MGS 2 | MGS 3: Window Mode: Address is 0x7ff6e18b5aaf
2023-10-28 20:57:47.649 (   0.004s) [Main            ]            dllmain.cpp:406   INFO| MG/MG2 | MGS 2 | MGS 3: Window Mode: Patched instruction.
2023-10-28 20:57:47.650 (   0.005s) [Main            ]            dllmain.cpp:444   INFO| MG/MG2 | MGS 3: Borderless: Hook length is 17 bytes
2023-10-28 20:57:47.650 (   0.005s) [Main            ]            dllmain.cpp:445   INFO| MG/MG2 | MGS 3: Borderless: Hook address is 0x7ff6e18b58b5
2023-10-28 20:57:48.164 (   0.519s) [Main            ]            dllmain.cpp:660   INFO| MG/MG2 | MGS 2 | MGS 3: Mouse Cursor: Address is 0x7ff6e18b8cc4
2023-10-28 20:57:48.164 (   0.519s) [Main            ]            dllmain.cpp:663   INFO| MG/MG2 | MGS 2 | MGS 3: Mouse Cursor: Patched instruction.

17:9 - 4096x2160
File verbosity level: 9
date       time         ( uptime  ) [ thread name/id ]                   file:line     v|
2023-10-28 21:11:53.985 (   0.000s) [        CBB8F5EA]             loguru.cpp:841   INFO| Logging to 'MGSHDFix.log', mode: 'w', verbosity: 9
2023-10-28 21:11:53.986 (   0.000s) [Main            ]            dllmain.cpp:237   INFO| MGSHDFix v0.6 loaded
2023-10-28 21:11:53.986 (   0.001s) [Main            ]            dllmain.cpp:271   INFO| Config Parse: iInjectionDelay: 500ms
2023-10-28 21:11:53.987 (   0.001s) [Main            ]            dllmain.cpp:272   INFO| Config Parse: bCustomResolution: 1
2023-10-28 21:11:53.987 (   0.001s) [Main            ]            dllmain.cpp:273   INFO| Config Parse: iCustomResX: 0
2023-10-28 21:11:53.987 (   0.001s) [Main            ]            dllmain.cpp:274   INFO| Config Parse: iCustomResY: 0
2023-10-28 21:11:53.987 (   0.001s) [Main            ]            dllmain.cpp:275   INFO| Config Parse: bWindowedMode: 1
2023-10-28 21:11:53.987 (   0.001s) [Main            ]            dllmain.cpp:276   INFO| Config Parse: bBorderlessMode: 1
2023-10-28 21:11:53.987 (   0.001s) [Main            ]            dllmain.cpp:277   INFO| Config Parse: bSkipIntroLogos: 1
2023-10-28 21:11:53.987 (   0.001s) [Main            ]            dllmain.cpp:278   INFO| Config Parse: bDisableCursor: 1
2023-10-28 21:11:53.987 (   0.001s) [Main            ]            dllmain.cpp:279   INFO| Config Parse: bMouseSensitivity: 0
2023-10-28 21:11:53.987 (   0.001s) [Main            ]            dllmain.cpp:280   INFO| Config Parse: fMouseSensitivity: 0.00
2023-10-28 21:11:53.987 (   0.001s) [Main            ]            dllmain.cpp:281   INFO| Config Parse: bAspectFix: 1
2023-10-28 21:11:53.987 (   0.001s) [Main            ]            dllmain.cpp:289   INFO| Config Parse: Borderless mode enabled.
2023-10-28 21:11:53.987 (   0.001s) [Main            ]            dllmain.cpp:314   INFO| Custom Resolution: fNewAspect: 1.8963
2023-10-28 21:11:53.987 (   0.001s) [Main            ]            dllmain.cpp:315   INFO| Custom Resolution: fAspectMultiplier: 1.0667
2023-10-28 21:11:53.987 (   0.001s) [Main            ]            dllmain.cpp:316   INFO| Custom Resolution: fHUDWidth: 3840.0000
2023-10-28 21:11:53.987 (   0.001s) [Main            ]            dllmain.cpp:317   INFO| Custom Resolution: fHUDOffset: 128.0000
2023-10-28 21:11:53.987 (   0.001s) [Main            ]            dllmain.cpp:337   INFO| Game Name: METAL GEAR.exe
2023-10-28 21:11:53.987 (   0.001s) [Main            ]            dllmain.cpp:338   INFO| Game Path: G:\Steam\steamapps\common\MG and MG2\METAL GEAR.exe
2023-10-28 21:11:53.987 (   0.001s) [Main            ]            dllmain.cpp:350   INFO| Detected game is: Metal Gear / Metal Gear 2 (MSX)
2023-10-28 21:11:53.987 (   0.002s) [Main            ]            dllmain.cpp:363   INFO| MG/MG2 | MGS 2 | MGS 3: Custom Resolution: Address is 0x7ff6e189b0e3
2023-10-28 21:11:53.987 (   0.002s) [Main            ]            dllmain.cpp:369   INFO| MG/MG2 | MGS 2 | MGS 3: Custom Resolution: New Custom Resolution = 4096x2160
2023-10-28 21:11:53.988 (   0.003s) [Main            ]            dllmain.cpp:384   INFO| MG/MG2 | MGS 2 | MGS 3: Framebuffer 1: Address is 0x7ff6e18b57de
2023-10-28 21:11:53.988 (   0.003s) [Main            ]            dllmain.cpp:387   INFO| MG/MG2 | MGS 2 | MGS 3: Framebuffer 1: Patched instruction.
2023-10-28 21:11:53.989 (   0.004s) [Main            ]            dllmain.cpp:384   INFO| MG/MG2 | MGS 2 | MGS 3: Framebuffer 2: Address is 0x7ff6e18b583f
2023-10-28 21:11:53.989 (   0.004s) [Main            ]            dllmain.cpp:387   INFO| MG/MG2 | MGS 2 | MGS 3: Framebuffer 2: Patched instruction.
2023-10-28 21:11:53.990 (   0.004s) [Main            ]            dllmain.cpp:403   INFO| MG/MG2 | MGS 2 | MGS 3: Window Mode: Address is 0x7ff6e18b5aaf
2023-10-28 21:11:53.990 (   0.004s) [Main            ]            dllmain.cpp:406   INFO| MG/MG2 | MGS 2 | MGS 3: Window Mode: Patched instruction.
2023-10-28 21:11:53.991 (   0.005s) [Main            ]            dllmain.cpp:444   INFO| MG/MG2 | MGS 3: Borderless: Hook length is 17 bytes
2023-10-28 21:11:53.991 (   0.005s) [Main            ]            dllmain.cpp:445   INFO| MG/MG2 | MGS 3: Borderless: Hook address is 0x7ff6e18b58b5
2023-10-28 21:11:54.502 (   0.517s) [Main            ]            dllmain.cpp:522   INFO| MG/MG2 | MGS 3: Aspect Ratio: Hook length is 15 bytes
2023-10-28 21:11:54.502 (   0.517s) [Main            ]            dllmain.cpp:523   INFO| MG/MG2 | MGS 3: Aspect Ratio: Hook address is 0x7ff6e1895e8c
2023-10-28 21:11:54.504 (   0.519s) [Main            ]            dllmain.cpp:660   INFO| MG/MG2 | MGS 2 | MGS 3: Mouse Cursor: Address is 0x7ff6e18b8cc4
2023-10-28 21:11:54.504 (   0.519s) [Main            ]            dllmain.cpp:663   INFO| MG/MG2 | MGS 2 | MGS 3: Mouse Cursor: Patched instruction.

(with the exception of skipping the intro logos, which fails on pattern scan.)

Hm, looks like MG1/2 does include the same intro logo code as MGS2/3 but seems it's going unused there and some other thing is handling the intro logos instead (eg. you can remove the whole Misc\splashscreen\_win folder and screens will still appear..), haven't been able to find how MG1/2 are handling it yet.


Breaking Changes: No more internal value state

Internal state was flaky to manage, there wasn't a real benefit to being an uncontrolled component
since you needed to provide onChange and a value anyway. A couple of bugs have been caused due to
this. Better just to remove it.
BREAKING CHANGE: No more uncontrolled components. Use onChange and value, set the value from state
and update the state from onChange.

:tada: This PR is included in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


build error, error: no type named 'shared_timed_mutex' in namespace 'std'

Hi, I'm trying to build voxblox++ in a ubuntu16 container. and I got the following error:
In file included from /workspaces/voxgraph_ws/src/voxblox-plusplus/global_segment_map/src/meshing/label_tsdf_mesh_integrator.cc:1:
In file included from /workspaces/voxgraph_ws/src/voxblox-plusplus/global_segment_map/include/global_segment_map/meshing/label_tsdf_mesh_integrator.h:15:
/workspaces/voxgraph_ws/src/voxblox-plusplus/global_segment_map/include/global_segment_map/meshing/instance_color_map.h:16:8: error: no type named 'shared_timed_mutex' in namespace 'std'
  std::shared_timed_mutex color_map_mutex_;
  ~~~~~^
In file included from /workspaces/voxgraph_ws/src/voxblox-plusplus/global_segment_map/src/meshing/label_tsdf_mesh_integrator.cc:1:
In file included from /workspaces/voxgraph_ws/src/voxblox-plusplus/global_segment_map/include/global_segment_map/meshing/label_tsdf_mesh_integrator.h:16:
/workspaces/voxgraph_ws/src/voxblox-plusplus/global_segment_map/include/global_segment_map/meshing/label_color_map.h:16:8: error: no type named 'shared_timed_mutex' in namespace 'std'
  std::shared_timed_mutex color_map_mutex_;
  ~~~~~^
In file included from /workspaces/voxgraph_ws/src/voxblox-plusplus/global_segment_map/src/meshing/label_tsdf_mesh_integrator.cc:1:
/workspaces/voxgraph_ws/src/voxblox-plusplus/global_segment_map/include/global_segment_map/meshing/label_tsdf_mesh_integrator.h:100:8: error: no type named 'shared_timed_mutex' in namespace 'std'
  std::shared_timed_mutex label_instance_map_mutex_;
  ~~~~~^
/workspaces/voxgraph_ws/src/voxblox-plusplus/global_segment_map/src/meshing/label_tsdf_mesh_integrator.cc:73:59: error: too few arguments to function call, expected 2, have 1
    sdf_layer_const_->getAllUpdatedBlocks(&all_tsdf_blocks);
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                 ^
/workspaces/voxgraph_ws/src/voxblox/voxblox/include/voxblox/core/layer.h:194:3: note: 'getAllUpdatedBlocks' declared here
  void getAllUpdatedBlocks(Update::Status bit, BlockIndexList* blocks) const {
  ^
/workspaces/voxgraph_ws/src/voxblox-plusplus/global_segment_map/src/meshing/label_tsdf_mesh_integrator.cc:74:68: error: too few arguments to function call, expected 2, have 1
    label_layer_mutable_ptr_->getAllUpdatedBlocks(&all_label_blocks);
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                  ^
/workspaces/voxgraph_ws/src/voxblox/voxblox/include/voxblox/core/layer.h:194:3: note: 'getAllUpdatedBlocks' declared here
  void getAllUpdatedBlocks(Update::Status bit, BlockIndexList* blocks) const {
  ^
/workspaces/voxgraph_ws/src/voxblox-plusplus/global_segment_map/src/meshing/label_tsdf_mesh_integrator.cc:142:10: error: no member named 'shared_lock' in namespace 'std'
    std::shared_lock<std::shared_timed_mutex> readerLock(
    ~~~~~^
/workspaces/voxgraph_ws/src/voxblox-plusplus/global_segment_map/src/meshing/label_tsdf_mesh_integrator.cc:142:27: error: no member named 'shared_timed_mutex' in namespace 'std'
    std::shared_lock<std::shared_timed_mutex> readerLock(
                     ~~~~~^
/workspaces/voxgraph_ws/src/voxblox-plusplus/global_segment_map/src/meshing/label_tsdf_mesh_integrator.cc:152:24: error: no member named 'shared_timed_mutex' in namespace 'std'
  std::lock_guard<std::shared_timed_mutex> writerLock(
                  ~~~~~^
/workspaces/voxgraph_ws/src/voxblox-plusplus/global_segment_map/src/meshing/label_tsdf_mesh_integrator.cc:152:44: error: unknown type name 'writerLock'
  std::lock_guard<std::shared_timed_mutex> writerLock(
                                           ^
/workspaces/voxgraph_ws/src/voxblox-plusplus/global_segment_map/src/meshing/label_tsdf_mesh_integrator.cc:178:3: error: cannot initialize object parameter of type 'voxblox::MeshIntegrator<voxblox::TsdfVoxel>' with an expression of type 'voxblox::MeshLabelIntegrator'
  extractBlockMesh(tsdf_block, mesh_block);
  ^~~~~~~~~~~~~~~~
1 error generated.

and similar errors in some other files. this looks like a c++ version issue, but I see c++14 flag is already added in the cmakelists, and I also tried gcc 5.5,7.5 and 8.4, all didn't work, the same error thrown.
Do you have any idea?

and I also tried ubuntu18 container, but still same error

and also tried c++17 and 1z, same result

I figured it out, I just forgot to add -DCMAKE_CXX_STANDARD=14 to catkin config

I am glad you could solve the issue yourself.
For anyone else experiencing the same problem: just following the installation steps in the Wiki should have you covered with setting the right C++ standard with catkin.


fix(material/progress-bar): Support ChromeVox

ChromeVox couldn't read a progress bar element without aria-hidden attributes set on child elements of mat-progress-bar.
Fixes #22165.

Added the tests, LMK if I could write them better


bug: Doc is not displayed

Did you check docs and existing issues?

[X] I have read all the flow.nvim docs
[X] I have searched the existing issues of flow.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.10.0
Operating system/version
MacOS Sonoma 14.3
Describe the bug
Doc is not working.
Steps To Reproduce
:h flow

Returns:
E149: Sorry, no help for flow.

Expected Behavior
Display the doc for the colorscheme.
Repro
No response

Fixed


app_state should be added to the login & register method

As per https://kinde.com/docs/developer-tools/javascript-sdk/#persisting-application-state
type AuthOptions = {
  org_code?: string;
  app_state?: object;
  authUrlParams?: object;
};

Should pass through the login and register methods, allowing for things like redirect to be managed.

Hi @ClintDavis, thank you for your feedback. I'm currently working on the issue. Please note that this package utilizes the TypeScript SDK, which uses slightly different props from those used by the JavaScript SDK.

Fixed by 4e332a7


Pause on mouseOver doesn't work when autoplay initiated via slickPlay

Normally, during autoplay, if you hover over an image it causes the autoplay to pause. Nice touch.
But if you set up slick with autoplay: false and then later initiate the autoplay via $('.slider').slick('slickPlay') then that pause effect no longer works, the slides keep on autoplaying regardless.
See jsfiddle here where I initiate autoplay after a delay.
(My actual use case is that I'm using scroll detection to only initiate autoplay once the slider comes into view, so that I know that the user will always see the slides from the beginning.)
Needless to say this is not a deal-breaker that will stop me using what is otherwise a great utility.

https://github.com/kenwheeler/slick/blob/master/slick/slick.js#L1203-L1207
The check for autoplay needs to be inside the event, not wrapping it :)

Technically this is a bug, but you can circumvent it for now by using: slick('setOption', 'autoplay', true, true) :)

That's great. Tested it in the fiddle and, yes, it works. Thanks.

Guys, additionally, if we initialize slick with autoplay: true; it will pause onHover and via.slick('pause') but it will re-autoplay manually changing slides. The autoplay restarts onMouseLeave.


Unable to download pretrained weights

Hi!
Thanks for the great resource!
I'm trying to work with your pretrained models, but getting the following error:

Any chance you're familiar with this and know how to solve it?
I made sure my PyTorch version is indeed 1.7.1.

My bad- used wrong environment.

My bad- used wrong environment.


Hide "Add Review" button when not logged in

@RudyCruisin please do this like you did with the nav bar. all the html is actually in the review router file!!


Multi-tenancy

Do you have any plans or interest in supporting multiple sites on a single instance?
(If it's not obvious, I kinda want to retire sitewriter.net and replace it with indiekit before picking development back up again.)

Ha, guess the shoe is on the other foot now! 😉
I did think about this earlier on, but decided to reduce the complexity to make the app easier to develop and more likely to ship. Not opposed to adding this in the future, however.

I'd be very interested in this. I've been thinking I want to make my static site starter kit a first-class citizen for Indiekit down the line. Essentially, a public server of Indiekit runs that with a few changes someone using a static site can plug into.
Now what Micropub client to recommend...

Multi-tenancy is quite far off, and setting up a service to host multiple Micropub endpoints seems unlikely. But we’ll see, one step at a time!

If/when it comes to adding multi-tenancy support, it would make sense to add support for [mp-destination](https://github.com/indieweb/micropub-extensions/issues/3), too.

Now I wonder if mp-destination would be a good way to designate "real" categories (since micropub categories are actually tags).

Okay, I’ll bite… what’s the difference between categories and tags? What are you currently trying to achieve, and how would mp-destination help?
(I’ve been thinking a bit about multi-tenancy, but deferring development until after I’ve launched 1.0)

I have a small number of categories like work, personal, and meta, which in some design iterations have been used for distinct feeds or index pages.
Tags are, well, tags. Folksonomy-style. I have at least dozens of them and only use them to inform search and "posts like this" pivots.

Possibly in the realm of ‘giant hack’, but it’s now possible to add separate tags and categories (or any other type of token array) to posts thanks to the recent APIs added for customising post types.
Take a look at https://github.com/paulrobertlloyd/paulrobertlloyd-indiekit/commit/287625010e839c2736922260ca7a9b852d6e4af7 for how I’m currently handling this for my own website. I’m sure there could be a smarter way to enable this sort of customisation, but this has at least moved from ‘impossible’, to ‘possible, with some effort’.


Support DataType::FixedSizeList in make_builder within struct_builder.rs

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Add the FixedSizeList datatype to make_builder in struct_builder
Describe the solution you'd like
Add the appropriate code
Describe alternatives you've considered
Adding the appropriate code

label_issue.py automatically added labels {'arrow'} from #6595


debug.getinfo(stacklevel, "S").what returns "Lua" instead of "main" when kleloadlua is used to load files.

This poses a big problem because of DST's strict.lua which allows setting values to work, but only if the code block is considered to be a "main" chunk, and not just a lua function(in which case the game would crash), this is a very important and key functionality to DST and must be preserved across to LuaJIT.

The behavior of debug library of LuaJIT varies from original ones. For example, LuaJIT does not count tailcalls on function level.
I've bypassed the compatibility problems between LuaJIT & GemCore by replacing tailcalls with normal function call, by matching code text. It's not the best choice but I have no better idea.
Have you released a new verison of GemCore and change the code that calls debug.getinfo()? If so, it would be better if you could remove tail calls on debug.getinfo....
Just as described here: https://github.com/paintdream/DontStarveLuaJIT#to-mod-developers对于mod开发者
Replace:
function a(option)
	return debug.getinfo(1, "option")
end

with:
function a(option)
	return debug.getinfo(1, "option"), nil
end

Except thats the weird part, the crash occurs when enabling Gem Core, and I'm not doing the debug call, the game is.
take this crash log: https://pastebin.com/rkLRcJzK the game crashes when GemCore sets a function to GetModModConfigData in the global namespace, the stacktrace even shows that the chunk is considered a "Lua" chunk(line 274 of that crash log), when I was testing on my machine(which doesn't have this installed), I could consistently get debug.getinfo to show the chunk as a "main" chunk, this is not my call to debug.getinfo, and therefore I can't fix it.

I've upgrade GemCore to latest and it runs well. Have you applied the latest DontStarveLuaJIT patch?

The "main" and "Lua" is NOT the key point. As I figured adove: https://github.com/paintdream/DontStarveLuaJIT/blob/master/src/luajit/src/lib_package.c#L476 , I've hooked the kleiloadlua function to solve the incompatibily with GemCore, so the caller is "Lua" function.

Hmm, it must be that the person who reported the bug must have been running an outdated version of LuaJIT, I'll fix the tailcalls in my next release so you can remove those hacks.

Hmm, it must be that the person who reported the bug must have been running an outdated version of LuaJIT, I'll fix the tailcalls in my next release so you can remove those hacks.

Thanks a lot~ The GemCore is powerful~


EPIC: As an OHS engineer, I can find and work on prioritized issues for technical debt that can help to reduce maintenance costs for further development of the project.

Focus here should be in things that will greatly reduce maintenance overhead for the project.
Beta must-have
Should-have
Nice-to-have

[x] #561

Definitely Post-beta

The only specifically mentioned issue here is done


[media-common] Migrate to library chart

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [radarr])

Will be discussing these changes on discord.


update pprof version to 0.3.15

Signed-off-by: Yang Keao<EMAIL_ADDRESS>What have you changed?
Update the version of pprof-rs. This update is necessary because:

This version of pprof supports Mac OS (through the update of libc)
Use prost message exposed in pprof-rs to fix potential version conflict
Remove deadlock when getting backtrace.

What is the type of the changes?

Bugfix

How is the PR tested?

Unit test
Manual test (perf while benchmarking)

As benchmark showed here, the result is much better than I thought.
@@                               Benchmark Diff                               @@
================================================================================
tidb: 4a63d416ba64467ec1f6348fe63d7d8ea441a589
--- tikv: 15693cede0e626fc9878b7667a6b21e4e894b5e9
+++ tikv: 5194d4edc8289c064a75b5a30d73bb660ca51758
pd: 5169308bfdb562ff0bd0795da146f7f47a2cace8
================================================================================
oltp_insert:
    * QPS: 6882.83 ± 0.00% (std=0.00) delta: -0.93% (p=nan)
    * Latency p50: 18.59 ± 0.00% (std=0.00) delta: 0.92%
    * Latency p99: 34.95 ± 0.00% (std=0.00) delta: 0.00%

oltp_point_select:
    * QPS: 41762.37 ± 0.00% (std=0.00) delta: -0.51% (p=nan)
    * Latency p50: 3.06 ± 0.00% (std=0.00) delta: 0.33%
    * Latency p99: 10.65 ± 0.00% (std=0.00) delta: 1.82%

oltp_update_index:
    * QPS: 4429.62 ± 0.00% (std=0.00) delta: -0.06% (p=nan)
    * Latency p50: 28.90 ± 0.00% (std=0.00) delta: 0.07%
    * Latency p99: 57.87 ± 0.00% (std=0.00) delta: 1.81%

oltp_update_non_index:
    * QPS: 4791.57 ± 0.00% (std=0.00) delta: -0.69% (p=nan)
    * Latency p50: 26.71 ± 0.00% (std=0.00) delta: 0.68%
    * Latency p99: 51.94 ± 0.00% (std=0.00) delta: 1.80%

/run-all-tests

/merge

/merge


Merge all of our improvements upstream

Since we forked, there has been some improvements made here but also we missed out on some of the PRs made against sccache (after the project got more action since the fork). This will be beneficial by getting new features/bug fixes but also will facilitate upstreaming some of our improvements as well.

As proposed at the meeting:
MVP for sccache in CI/CD

[ ] finer cache hits tracking and non-hits
[ ] overlay and docker support
[ ] rust bugs worked around: mtime and fullpath cache invalidation issues

Outside of MVP

distributed compilation for CI
encrypted/signed shared artifacts
undep OpenSSL
metrics support

Stuff not related to the CI use-case, but nonetheless important

distributed compilation for devs

cc @drahnr @kirushik

Hello, any progress in here?

@Xanewok will be chipping away on that in the long run, I'll be focused on merging and reviewing upstream PRs. So there is no timeframe right now when which fix will be upstreamed.

We will be winding down cachepot as a separate project and instead plan to upstream all of our fixes to the sccache project, now that we have maintainer access and help maintain the crate and publish it. This issue tracks the required work.

Does this mean cachepot is basically deprecated and we should use sccache instead? I just want to confirm since it looks like this project is still fixing bugs and updating dependencies.

Yes, since sccache increased its dev bandwidth and we can actually upstream the work, I think it's fair to say you should use sccache now, as we merge our stuff there.


Blog app - creating a data model

Status: Invalid 🔴
Hi @Santosh-Konappanavar 🙋♀,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request

You have submitted a project, that does not have a pull request description. Kindly write a very detailed pull request description explaining the feature implemented in this milestone.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers 🥂  and Happy coding!!! 👯
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me @KDlamini  in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


use zmq-port 18084 instead of 18083

Port 18083 conflicts with monero-wallet-rpc or the tor port as mentioned here:
https://www.reddit.com/r/Monero/comments/vga773/psa_to_public_node_operators_that_have_enabled/
https://xmrvsbeast.com/p2pool/monero_nodes.html
What do you think?

LGTM, thanks! Not sure where this one went but just discovered it, sorry for the delays!


Addition of models from other libs

Description
Currently, the addition of models requires a small wrapper. Since many models are available on time series libraries, the idea of this issue is to develop a feature to leverage all those models without the need to make a wrapper around all off them. This means that onTime would be mostly 'model free' but interoperable with others.
Tasks

[ ] Install GluonTS
[ ] Make a concept allowing interoperability of Darts and GluonTS
[ ] Make a notebook that demonstrates the usage

Refs
https://github.com/MaxBenChrist/awesome_time_series_in_python

Inclusion of GluonTS and Kats caused some dependencies issues, I decided to add SkForecast instead for now. Now, all Darts and Scikit-learn API compatible models can be used.


Update deps

So CODEOWNERS dosn't works as I expected. :)

So CODEOWNERS dosn't works as I expected. :)

Such a file in a repo still looks like we know what we are doing haha.
What do you expect it to do?

What do you expect it to do?

That your approvals will not be required for CMake's files. :)

Qt installation in Windows is frozen. :(

What do you expect it to do?

That your approvals will not be required for CMake's files. :)

AFAICT, CODEOWNERS file let's you auto-assign reviewers automatically based on file path/prefix.
And contour currently requires review count of at least 1 for PR merges to be allowed and nothing can go into master without a PR.
I think it is good practice to require a review for code changes.
On the other hand, no one can seriously review my code changes. But I hope that can change - given enough time in the future ;)

Qt installation in Windows is frozen. :(

CI restarted.

let's you auto-assign reviewers automatically based on file path/prefix.

But I can't approve my own PRs, if I'm not mistaken. :)

let's you auto-assign reviewers automatically based on file path/prefix.

But I can't approve my own PRs, if I'm not mistaken. :)

Exactly. Reviews wouldn't make sense at all if you (anyone) could.


Race/Ethnicity sections UI display fixes

address this story:  https://www.pivotaltracker.com/story/show/144417951
hiding Race & Ethnicity sections based on return of API from this PR #932.
NOTE this PR is dependent on changes in PR #932
@pbugni
Paul, thank you very much for the API.  It works for me.  If I understand correctly how this API works, I will need to add race, ethnicity to REQUIRED_CORE_DATA config list in EPROMs persistence file for my changes to work correctly, right?

@achen2401 Yes, please change to site_persistence if you want race&ethnicity for CRV users.


question regarding EGCL layer

plus in node_model you seem to do this:
agg = torch.cat([x, agg, node_attr], dim=1)


Unable to specify UDID with command line parameter

The command line parameter "-DconductorUdid" with env. variable does not take effect and instead uses one specified in YAML config.

Not sure if this is related but we also need to be able to specify the platformName on command line to be able to run iPhone and iPad simulator on teamcity

As we talkeda bout in slack, I think it would be better for the yaml to accept enviornment variables as part of the configuration, so you can do:
build_server:
    deviceName: ${DEVICE_NAME}
    udid: ${DEVICE_UDID}

and then the build step would use
-DconductorCurrentSchemes:build_server
Does that make sense?
platformName is already specifyable, you can use -DconductorPlatformName... do you mean deviceName?


update number of SLOC

I was surprised it was only 500 and just checking with cloc it looks like it's more around 1500 now

Haven't checked line counts in a long time, but I'm guessing the 1500 number includes comments?

This is what I get with cloc just against src
$ cloc src/
      15 text files.
      15 unique files.
       0 files ignored.

github.com/AlDanial/cloc v 1.80  T=0.01 s (1694.5 files/s, 247740.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
ClojureC                        13            373            273           1398
Clojure                          1             18             21             52
ClojureScript                    1             14              4             40
-------------------------------------------------------------------------------
SUM:                            15            405            298           1490
-------------------------------------------------------------------------------

It should be noted that (comment ,,,) forms count as source code as far cloc is concerned.

Okay, I just did a quick, inaccurate audit.
The first file I just looked in fx.cljc and it contains about 60-ish  lines of code despite being 171 lines long.  The rest is docstrings, comments and blanks.
https://github.com/Day8/re-frame/blob/master/src/re_frame/fx.cljc
Next file I looked into was  std_interceptors.cljc which looks to be about 50% docstrings:
https://github.com/Day8/re-frame/blob/master/src/re_frame/std_interceptors.cljc
I then  db.cljc but it is unusual so I ignored it (three line of code out of 10).
At that point, I stopped.   In the context of saying "there's not much code in re-frame really", it still feels to me that a round number like 500 loc  is more a more accurate indication of complexity than 1500, even if  650 is more accurate these days.

I'll accept this PR because the number should be updated, but I'll probably then re-edit it to 750 to be on the safe side.

Thanks!

Ah ok I see, the only problem with cloc as far as I can tell is that it counts docstrings also has code, which is what's skewing up the total number.
Ok thanks!

Was curious if there were any tools that would count lines properly for Clojure, and here we go: Counting Clojure Code (which introduces lein-count).

Ah nice @martinklepsch , I didn't find that because I was just trying the generic SLOC counters, and apparently none of the one I tried really work well with Clojure.
This is definitively going to be more accurate, thanks


dart2dart is not obvious

We (the project, team) refer to a thing called "dart2dart". However, there is no such command as "dart2dart".
Suggestion:
add a script to the SDK called dart2dart that simply delegates to dart2js --output-type=dart
As our deployment story gets baked, it's becomes important to incorporate dart2js and dart2dart as deployment options.

can be closed, no dart2dart anymore


Group config parsing

Description
This commit adds the first functionality for the service, allowing it to load a YAML configuration file with the groups definitions in an structured way
Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

Yes, sure...
Probably I won't need to even log it. It was only for "testing" purposes and I forgot to remove before pushing :-D


Four key combination shortcut will trigger three key combination shortcut

I am using Ctrl+Alt+Shift+E to trigger one command in one PPT-addin, and using Ctrl+Alt+E to trigger another command in another PPT addin.
But when I press Ctrl+Alt+Shift+E, both commands will be triggered.
What should I do to avoid this? Thanks.

Semaphoreslim
On Sun, 23 May 2021, 04:29 valuex, @.***> wrote:

I am using Ctrl+Alt+Shift+E to trigger one command in one PPT-addin, and
using Ctrl+Alt+E to trigger another command in another PPT addin.
But when I press Ctrl+Alt+Shift+E, both commands will be triggered.
What should I do to avoid this? Thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/gmamaladze/globalmousekeyhook/issues/145, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ALUIFUAUHGSYTC3YD37RJMLTPBR77ANCNFSM45LHB6AA
.


Halting the beta version of the Vagrant box renders the box unusable

It's not possible to restart Vagrant after a vagrant halt with the beta version of the box (a box run with config.vm.box = 'seravo/wordpress-beta' in Vagrantfile).
==> seravocom-box: Running triggers after up...
checking for composer... no
==> seravocom-box: Executing remote command "composer install --working-dir=/data/wordpress"...
==> seravocom-box: Waiting for container SSH...
==> seravocom-box: Waiting for container SSH...
==> seravocom-box: Waiting for container SSH...
==> seravocom-box: Waiting for container SSH...
==> seravocom-box: Waiting for container SSH...
==> seravocom-box: Waiting for container SSH...
==> seravocom-box: Waiting for container SSH...
==> seravocom-box: Waiting for container SSH...
==> seravocom-box: Waiting for container SSH...
==> seravocom-box: Waiting for container SSH...
==> seravocom-box: Waiting for container SSH...

There is a workaround: running vagrant destroy; vagrant up will clean up whatever went wrong with the vagrant halt, but it might still be worth it to investigate this.

I can also reproduce this issue with the seravo/wordpress-beta (virtualbox, 20180522.0.3) box by running
$ vagrant up
...
$ vagrant halt
...
$ vagrant up
...
==> wordpress-box: Waiting for machine to boot. This may take a few minutes...
    wordpress-box: SSH address: <IP_ADDRESS>:2222
    wordpress-box: SSH username: vagrant
    wordpress-box: SSH auth method: private key
    wordpress-box: Warning: Authentication failure. Retrying...
    wordpress-box: Warning: Authentication failure. Retrying...
    wordpress-box: Warning: Authentication failure. Retrying...

Fixed in version 20180528.0.1.


Optimize the plugin handle

closes https://github.com/dromara/soul/issues/349
1、增加字典管理
2、调整plugin_handle增加下拉框类型（直接读取字典表）

Codecov Report

Merging #371 (6a2d869) into master (025bef0) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #371   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files          21      22    +1
  Lines          47      60   +13
  Branches        1       1
======================================
- Misses         47      60   +13

Impacted Files
Coverage Δ

...gin/apache/dubbo/cache/ApplicationConfigCache.java
0.00% <0.00%> (ø)

...romara/soul/admin/config/SwaggerConfiguration.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 025bef0...6a2d869. Read the comment docs.

sql 文件有冲突，解决一下，刚有个用户密码的更改

good job


Convert bound fiefs and notables when assimilating culture

Some logic borrowed from the abandoned ChangeSettlementCulture mod.

Thank you for the contribution. I will only remove the bound villages part and format to my liking. This process applies to villages as well, but I believe I left a visual bug where the GUI always shows 0%.


Keyhandler Types should only be added with useFocusManager

https://github.com/lightning-tv/core/blob/main/src/intrinsicTypes.ts#L73
Most of the types in there are now added by default but should only be enabled if useFocusManager is ran.

Should be done...


Support for Python 3.12?

Version 1.5 should be tested if Python 3.12 can be supported!

See: https://github.com/Volue-Public/energy-mesh-python/pull/413#issuecomment-1943653401
Version 1.5 was already released and does not support Python 3.12.
Version 1.6 will support Python 3.12, but support for Python 3.8 will be dropped.

Python support added in #413


Concept simple table

Table that only will show a data base (text, numbers) without any possbility for interactions.
Concept "simple table"
variations:

[ ] table head

ascending / descending functionality
text gets truncated but shows a tooltip with all info
sticky header on scrolling the content

[ ] table content

states for highlighting: i.e. hover, focus
no multilines (but check with DEV for the future)

[ ] keyboard support (conceptual approach)

Figma

[ ] dev handover @SchwarzIT/onyx-dev
[ ] ux component @SchwarzIT/onyx-ux

documentation

[ ] keyboard support
[ ] property description
[ ] textual documentation
[ ] component grouping
[ ] further component tickets are created
[ ] Scrolling behaviour definitions

if needed links for comparison

link 1
link 2

Finalizing

[ ] approved @JoCa96

@jannick-ux Please arrange a meeting to discuss the future concept for tables in onyx


NamingConventionViolation does not correspond to Symfony standards

As Symfony documentation states, services' names can be FQCNs. But plugin raises NamingConventionViolation when service is accessed this way and I get:
ERROR: NamingConventionViolation - tests/... - Use snake_case for configuration parameter and service names (see https://psalm.dev/000)
        $this->hub = self::$container->get(HubInterface::class);

Works OK when using like self::$container->get('event_dispatcher'). But Sentry\State\HubInterface does not have snake_case alias and I don't want to create it just for Psalm :wink: Would be great if naming convention was determined differently for parameters and services.

@Wirone thanks for reporting.
Actually the plugin checks if service name is a class name then does not complain about naming convention. Here is the test https://github.com/psalm/psalm-plugin-symfony/pull/78/files
I suspect in your case HubInterface class is not loaded https://github.com/psalm/psalm-plugin-symfony/blob/v1.4.3/src/Handler/ContainerHandler.php#L94

@seferov thanks for the response. I don't know why, but it's working now (I just removed psalm-suppress and executed script). I have plugin registered like this:
<plugins>
    <pluginClass class="Psalm\SymfonyPsalmPlugin\Plugin">
        <containerXml>var/cache/dev/App_KernelDevDebugContainer.xml</containerXml>
    </pluginClass>
</plugins>

and it was complaining. I am going to close this issue since it started to work :thinking:


Deferring requests that require API calls

Whenever I try to search something, if it's not cached already, it has a 1/3 chance of failing because the search cannot be completed in 3 seconds, and respond to the interaction all within that 3 seconds.
After I retry the interaction, it gives me the actual response because it's cached (or something else, but it responds way quicker).
A simple fix to this is by first deferring the response, then search or do an API call.

Yeah, um, this has been fixed a long time ago. So...


Sysbox v0.6.1 daemon-set installer fails in GKE 1.24.10-gke.2300 with DataplaneV2 (Cilium)

It appears as though during the sysbox install process (via your daemonset) I get some extra cri-o configs 100-crio-bridge.conf, 200-loopback.conf co-located in /etc/cni/net.d that breaks my GKE networking and introduces a subnet for the node that's not correct according to what's been configured in GKE by the 10-gke-ptp.conflist config file already there.
When pods come back online after the kubelet restart on that node, a number of them including the sysbox-installer get this incorrect CIDR provided in 100-crio-bridge.conf and they go into crash loop backoff state as they cannot reach anything on the network (which is correct, there are no firewall/policy rules allowing traffic from this new CIDR that came out of thin air.)
For reference, here's the content of 100-crio-bridge.conf that gets placed into /etc/cni/net.d and breaks the networking for pods running on the node I'm trying to install sysbox on:
{
    "cniVersion": "0.3.1",
    "name": "crio",
    "type": "bridge",
    "bridge": "cni0",
    "isGateway": true,
    "ipMasq": true,
    "hairpinMode": true,
    "ipam": {
        "type": "host-local",
        "routes": [
            { "dst": "<IP_ADDRESS>/0" },
            { "dst": "1100:200::1/24" }
        ],
        "ranges": [
            [{ "subnet": "<IP_ADDRESS>/16" }],
            [{ "subnet": "1100:200::/24" }]
        ]
    }
}

I've tried restarting various services on the node, along with just restarting the node entirely after deleting these extraneous files from /etc/cni/net.d (while ensuring I keep 10-gke-ptp.conflist) but no dice, I just get a ton of messages like this:
Apr 19 21:27:34 gha-std-runners-2-baae0455-8zr5 kubelet[25451]: E0419 21:27:34.993101   25451 pod_workers.go:965] "Error syncing pod, skipping" err="network is not ready: container runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:Network plugin returns error: No CNI configuration file in /etc/cni/net.d/. Has your network provider started?" pod="kube-system/sysbox-deploy-k8s-98fpk" podUID=3287c25f-d5f2-477e-a934-918722a0908a

@rodnymolina for viz as you asked me to bring this in as an Issue to track.

Thanks @kevholmes, will take a look.

Same issue here with same GKE version. Nodes got upgraded and similar symptoms. However, I don't have a file 10-gke-ptp.conflist:
root@gke-k8stty-pool-1-afb28145-8549:/etc/cni/net.d# ls
10-calico.conflist  100-crio-bridge.conf  200-loopback.conf  calico-kubeconfig

I'm going to try using one of the untagged images from before the v0.6.1 release will report back.

Right, this is probably a consequence of sysbox-deploy deamonset being unaware of pre-existing cnis with non-default configurations. Will take a look when have a chance.

I think I've figured out the issue - it looks like the default routes/subnets in 100-crio-bridge.conf assume IPv6 is enabled and available based on the docs description.
Removing the route and range gets things working again on my nodes (edit file, check with jq because missing commas etc. will blow up crio, then systemctl restart crio:
root@gke-k8stty-pool-1-afb28145-8549:/etc/cni/net.d# git diff 100-crio-bridge.conf
diff --git a/100-crio-bridge.conf b/100-crio-bridge.conf
index d17c67a..ca9a5fd 100644
--- a/100-crio-bridge.conf
+++ b/100-crio-bridge.conf
@@ -9,12 +9,10 @@
     "ipam": {
         "type": "host-local",
         "routes": [
-            { "dst": "<IP_ADDRESS>/0" },
-            { "dst": "1100:200::1/24" }
+            { "dst": "<IP_ADDRESS>/0" }
         ],
         "ranges": [
-            [{ "subnet": "<IP_ADDRESS>/16" }],
-            [{ "subnet": "1100:200::/24" }]
+            [{ "subnet": "<IP_ADDRESS>/16" }]
         ]
     }
 }

But I'm still trying to confirm since I've got some wedged GKE ingress/neg bits to sort out still.

Well ignore what I wrote above, was a red-herring. Turns out after removing both 100-crio-bridge.conf, 200-localhost.conf, and adding "/home/kubernetes/bin" to crio.conf I've got things working:
  [crio.network]
    plugin_dirs = ["/opt/cni/bin/", "/home/kubernetes/bin"]

The issue being the calico CNI files live in /home/kubernetes/bin, and that having the upstream CNI bridge configuration included was assigning pods IPs that weren't reachable.

I can't find the source for /opt/sysbox/scripts/sysbox-deploy-k8s.sh but I think detecting GKE should be relatively easy to add. For example, if a node is part of a cluster, a GET/HEAD to the inter metadata endpoint should return an HTTP 200:
[root@sysbox-deploy-k8s-879zb etc]# curl -si -H "Metadata-Flavor: Google" <IP_ADDRESS>/computeMetadata/v1/instance/attributes/cluster-name
HTTP/1.1 200 OK
Content-Type: application/text
Metadata-Flavor: Google
Server: GKE Metadata Server
Date: Sat, 29 Apr 2023 14:23:00 GMT
Content-Length: 6

<cluster_name>

From there, removing the various /etc/cni/net.d/ files, and patching crio.conf should work. Something like this?
rm /etc/cni/net.d/100-crio-bridge.conf /etc/cni/net.d/200-localhost.conf
dasel put string -f ${host_crio_conf_file} -p toml -m 'crio.runtime.network.[]' "/opt/cni/bin/"
dasel put string -f ${host_crio_conf_file} -p toml -m 'crio.runtime.network.[]' "/home/kubernetes/bin"

This also happens on GKE v1.25.8-gke.1000 without dataplane v2.
Applying the fix @kevholmes posted and restarting all pods seems to fix the issue.

Installation failed for me in v1.26.5-gke.1400 though the error message is different and it is not clear to me if the problem is the same. Eliding some IAM setup I think is irrelevant:
gcloud container clusters create … \
  --release-channel=stable \
  --image-type=ubuntu_containerd \
  --machine-type=n1-standard-4 \
  --workload-pool=$(gcloud config get-value core/project).svc.id.goog \
  --num-nodes 3 \
  --min-nodes 3 \
  --max-nodes 9 \
  --spot \
  --addons=GcpFilestoreCsiDriver
kubectl label nodes --all sysbox-install=yes
kubectl apply -f https://raw.githubusercontent.com/nestybox/sysbox/master/sysbox-k8s-manifests/sysbox-install.yaml
kubectl -n kube-system rollout status daemonset sysbox-deploy-k8s

(Stable release channel pending #704. Image type according to this and this. Installation adapted from this.)
The daemonset rollout apparently succeeds, but then no other pods start successfully (3 node(s) had untolerated taint {sysbox-runtime: not-running}; all are still sysbox-runtime=installing), and then the sysbox-deploy-* pods and some other pods are stuck in ContainerCreating with
Warning  FailedCreatePodSandBox  29m                    kubelet            Failed to create pod sandbox: rpc error: code = Unknown desc = failed to get network status for pod sandbox k8s_sysbox-deploy-k8s-…_kube-system_…_0(…): error checking pod kube-system_sysbox-deploy-k8s-… for CNI network "200-loopback.conf": cache file path requires network name (""), container ID ("…"), and interface name ("eth0")

Not understanding what I am doing, on one node I tried deleting /etc/cni/net.d/200-loopback.conf (the only other file in that directory was 10-gke-ptp.conflist) and editing /etc/crio/crio.conf to include
  [crio.network]
    plugin_dirs = ["/opt/cni/bin/", "/home/kubernetes/bin"]

but this just leads to a different error, like the original shown in this issue
Warning  FailedCreatePodSandBox  1s    kubelet            Failed to create pod sandbox: rpc error: code = Unknown desc = failed to create pod network sandbox k8s_sysbox-deploy-k8s-…_kube-system_…_0(…): No CNI configuration file in /etc/cni/net.d/. Has your network provider started?

Well ignore what I wrote above, was a red-herring. Turns out after removing both 100-crio-bridge.conf, 200-localhost.conf, and adding "/home/kubernetes/bin" to crio.conf I've got things working:
  [crio.network]
    plugin_dirs = ["/opt/cni/bin/", "/home/kubernetes/bin"]

The issue being the calico CNI files live in /home/kubernetes/bin, and that having the upstream CNI bridge configuration included was assigning pods IPs that weren't reachable.

I can also confirm this issue and that the fix above resolves it. GKE 1.24.14-gke.1400 (Ubuntu with containerd (ubuntu_containerd))


Database upserts: add criterion and example

Add a new criterion for database upserts in the bulleted list
Add a code example to illustrate this criterion

Looks good. Thanks for the quick update


[Feature]: Show indication of model defaulting

At times when using GPT-4 the model will default to 3.5 in case of, for example, a breach of Openai's community guidelines. It would be nice if there is a indication of that.

I'm sorry, I was not aware of that. If I understand correctly, you're meaning that even when using GPT-4, the OpenAI API might respond using GPT-3 in certain cases? Is there any documentation to clarify this?

I can't seem to quickly find documentation on that but looking at the openai community forum, it it a thing that happens. In Chatwizard it seems to switch the model for a chat. What I suspect is happening is that openai sends a response as gpt-3 and that makes chat wizard pick it up as the model for the chat. So consequent prompts are send to gpt-3 without the user knowing it. Making the Ai suddenly seem a bit drunk.

Just as a idea, would it be relatively easy to label the response with the model as it is send by the api? Makes it easier to spot when this happens.


raft: use CheckQuorum option

Leader steps down as follower when quorum is lost. This option enabled
by default in etcd as well.

Current coverage is 54.04% (diff: 100%)

Merging #1564 into master will increase coverage by 0.06%

@@             master      #1564   diff @@
==========================================
  Files            79         82     +3
  Lines         13479      13606   +127
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           7276       7353    +77
- Misses         5219       5259    +40
- Partials        984        994    +10

Powered by Codecov. Last update 3be4c3f...5ac6b89

I think this is probably a good idea.
I don't have a good sense of what side effects we may trigger by switching this on.
There is more info here: https://github.com/coreos/etcd/issues/3866
Basically, if the network becomes partitioned, this will make client requests to the former leader fail quickly instead of hanging while waiting for quorum.
LGTM

@aaronlehmann @LK4D4 Are we good to merge this one?
Unfortunately you two are the only ones with deep knowledge of how our raft implementation works, so there can only be a single LGTM

Merge away

On Sep 28, 2016, at 21:24, Andrea Luzzardi<EMAIL_ADDRESS>wrote:
@aaronlehmann @LK4D4 Are we good to merge this one?
Unfortunately you two are the only ones with deep knowledge of how our raft implementation works, so there can only be a single LGTM
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I think this fixes #1341. Closing that issue.

Just discovered that this never took effect because of this code:
https://github.com/docker/swarmkit/blob/61a92e8ec074df5769decda985df4a3ab43c77eb/manager/state/raft/raft.go#L203-L210


Vendoring libnetwork integrated with Docker discovery service

This PR brings in end to end discovery and cluster-store integration with docker.
With this PR and #16645, docker multi-host networking will exit experimental.
cc @icecrime

@icecrime fixed the CI failures.
windows CI is failing on DockerSuite.TestExecStartFails which is not related to this change.
PTAL.

Please merge soon :pray:

LGTM (Windows CI issue tracked here #16738).

LGTM 🐼

Woo Hoo!!!


Failed to parse login response

With every account i try to log in i get always failed to parse login response.
I even tried the bot method but it crashes because it says that my account it's too big (even tho it's a fresh account)

What Atmosphere version are you using?

I have the same issue 8m running the latest as of 4/9/2020

I have the same issue im running the latest as of 4/9/2020

What Atmosphere version are you using?

I have the same issue im running the latest as of 4/9/2020

What Atmosphere version are you using?

Im Guessing He Using 10.4

I released a new version, to deal with crashes. I doubt it will fix the login problem though. Please use a bot if you can't get passed login.


Operation request: Improvements to Regex highlighting

Summary
The 'Regular expression' operation currently highlights matches. It would be useful to add a tooltip when hovering over those matches that displays information like their offset and capture groups.

How about this?

PR is comming.


Incorrect CXX value in internally generated Makefile

In the Makefile generated by poac when the CXX environment variable is not specified, CXX is specified as follows.
CXX ?= clang++
# https://github.com/poac-dev/poac/blob/0.9.3/src/BuildConfig.cc#L569

In this case, CXX is Implicit Variables in Gnu Make, so the default value of g++ is retained. This means that unintentional use of g++ will occur via make when CXX environment variables are not specified.
https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html
I'm not familiar with make, but the following might work as intended.
ifeq "$(origin CXX)" "default"
	CXX := clang++
endif

.PHONY: all
all:
	@echo "$(info $(CXX))"

@watiko  Thank you for reporting this!  Would you want to submit a PR for this?  I'm happy to review it.


Fix the release note guide

What this PR does / why we need it:
To keep consistent with the PR title format to avoid confusion.
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:

Release note:

NONE

/lgtm

/retest

@ramineni the issue seems to be a valid issue, I am checking this now...

/lgtm
/approve


error for most CSL files from https://github.com/citation-style-language/styles

Get an error of the type
pandoc-citeproc: ParseError {errorContexts = [], errorMessage = "Failed reading: takeWhile1", errorPosition = 44:3 (2579)}
Error running filter pandoc-citeproc:
Filter returned error status 1

for most csl files from [the csl repo](https://github.com/citation-style-language/styles]. For example this one fails and produces the errors above.
In fact, this is one of the view styles that work with pandoc.
Without csl citeproc works very fine.

My guess is that you're downloading the HTML rendering of these files, not the raw CSL files.
Try this: https://raw.githubusercontent.com/citation-style-language/styles/master/the-journal-of-neuroscience.csl

Oh dear - slightly embarrassing.  Thanks.


wip - cleanup debugging

WIP for now, clean up our debugging, and prepare to set version in the commit message for the template repository.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[ ] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Before we try to get the npm_version_number into this PR, we need to consider if this is the correct version number to include. Updating kit components without updating the cli obviously would not update this release number, and all of the kit component versions would be listed in the package.json anyway. So I wonder if this becomes more of a date, or something, or a reference to a build workflow run, instead.


Fix auth race condition

@ptnapoleon to review. Main fix is to prevent flakes like this in the future:
http://cassci.datastax.com/job/cassandra-3.0_dtest/607/testReport/junit/auth_test/TestAuthRoles/grant_revoke_roles_test/
I also removed some unused variables that flake8 caught. @ptnapoleon I pushed this to the riptano repo so you could rebase out the flake8 fixes commit and actually use those usercount variables if you want.

+1

Cheers, merging.


[EngAut] Faucets Q1 iteration

### Tasks
- [ ] #348
- [ ] #365
- [ ] #277
- [ ] https://github.com/paritytech/polkadot-testnet-faucet/issues/370

Weekly update:

Fixed some UX/UI issues https://github.com/paritytech/polkadot-testnet-faucet/issues/365
https://github.com/paritytech/polkadot-testnet-faucet/issues/370

Added Paseo to Web faucet
Modified default Paseo drip amount to 100 and daily cap to 500
Replaced the default *.parity.io and W3F whitelist with list of specific people for Paseo

No updates on this from last week

PR for #277 has been created:

https://github.com/paritytech/polkadot-testnet-faucet/pull/383


services.throttled.enable fails to build

System info:

OS: NixOS 24.05pre622847.b211b392b848 (Uakari) x86_64
Host: LENOVO 20L6SJDU00 (t480)
Kernel: 6.6.30

I recently tried to nixos-rebuild my system and got the following error:
× throttled.service - Stop Intel throttling
     Loaded: loaded (/etc/systemd/system/throttled.service; enabled; preset: enabled)
    Drop-In: /nix/store/8zm6yajvjc9ys9awm4fg6nlcmzpvdj8h-system-units/throttled.service.d
             └─overrides.conf
     Active: failed (Result: exit-code) since Thu 2024-05-09 22:29:53 EDT; 107ms ago
   Duration: 75ms
    Process: 3894 ExecStart=/nix/store/cvsy0h3s7s14s42n83gw9wi1q55jqwfb-throttled-0.10.0/bin/throttled.py (code=exited, status=1/FAILURE)
   Main PID: 3894 (code=exited, status=1/FAILURE)
         IP: 0B in, 0B out
        CPU: 74ms

May 09 22:29:53 nixos systemd[1]: Started Stop Intel throttling.
May 09 22:29:53 nixos throttled.py[3894]: Traceback (most recent call last):
May 09 22:29:53 nixos throttled.py[3894]:   File "/nix/store/cvsy0h3s7s14s42n83gw9wi1q55jqwfb-throttled-0.10.0/bin/.throttled.py-wrapped", line 25, in <module>
May 09 22:29:53 nixos throttled.py[3894]:     from gi.repository import GLib
May 09 22:29:53 nixos throttled.py[3894]:   File "/nix/store/40cddha2iiqzbqd6dpal3rlrgvb4p0yc-python3.11-pygobject-3.48.2/lib/python3.11/site-packages/gi/importer.py", line 133, in create_module
May 09 22:29:53 nixos throttled.py[3894]:     raise ImportError('cannot import name %s, '
May 09 22:29:53 nixos throttled.py[3894]: ImportError: cannot import name GLib, introspection typelib not found
May 09 22:29:53 nixos systemd[1]: throttled.service: Main process exited, code=exited, status=1/FAILURE
May 09 22:29:53 nixos systemd[1]: throttled.service: Failed with result 'exit-code'.
warning: error(s) occurred while switching to the new configuration

I'm happy to help debug, but I'd appreciate advice on where to start. I assume this error is due to https://github.com/NixOS/nixos-hardware/blob/a4e2b7909fc1bdf30c30ef21d388fde0b5cdde4a/lenovo/thinkpad/t480/default.nix#L11 Thanks!

https://github.com/NixOS/nixpkgs/pull/309377 was just merged and appears to fix the error. Can you update your Nixpkgs instance?

Amazing, thanks @tomodachi94.


change unit test port

What is the purpose of the change
change unit test port
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[ ] Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

why change port? any issue which cause unit test unstable?


create a remove workout card function

workout cards need to be removed or at the very least exit out of the cards to find new workouts

fixed


DrawerNavigatorItems

Can u please add new props for the DrawerNavigatorItems  that can identify the item not will not display in the DrawerItems..
example:

See https://github.com/react-community/react-navigation/issues/717#issuecomment-289904770


Update request: surrealist 1.11.7 → 2.0.1

Package name: surrealist
Latest released version: 2.0.1

Current version on the unstable channel: 1.11.7
Current version on the stable/release channel: -

[x] Checked the nixpkgs pull requests

Notify maintainers
@MDM23

NOTE
Surrealist has now officially moved to the SurrealDB Github org, see https://github.com/surrealdb/surrealist/

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

It seems like they added a lot more package formats in the releases, so theoretically Nix can just use the tar.gz instead of having to use the deb

Working on it. I'm currently stuck at an issue with the frontend build. There is a transitive dependency to rollup-linux-x64-gnu that does not get installed by pnpm.