MxNet can't fully utilize CPU in multithread programs

Hi, all:
I'm using mxnet scala package and runs prediction in a multithread program and each thread has a thread local FeedForward instance. It seems that mxnet is not able to utilize multi cores since only one core is busy while I have 20 threads in this program.  The java stacktrace show that all  threads are in   this mxNDArraySyncCopyToCPU method. Is this method waiting some lock for all threads in the same process? One quick solution may be to  use multi process instead of multi thread but jvm has much heavy overhead and this is may be my last resort. Is there any way to solve this issue?

@piiswrong @tqchen Any idea why this happens? It seems that all the threads bind the same cpu.

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!


Add Context support.

Pull Request Test Coverage Report for Build 12

47 of 47 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 8:
0.0%

Covered Lines:
252

Relevant Lines:
252

💛  - Coveralls

Pull Request Test Coverage Report for Build 12

47 of 47 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 8:
0.0%

Covered Lines:
252

Relevant Lines:
252

💛  - Coveralls

Pull Request Test Coverage Report for Build 12

47 of 47 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 8:
0.0%

Covered Lines:
252

Relevant Lines:
252

💛  - Coveralls

glitched PR


Support non-square tiles

Not sure if this happens in practice, but the logic was incorrect.

Non-square tiles DO happen in practice, but are uncommon.


Fix undo_transforms in volume reconstruction

Checklist
GitHub

[x] I've given this PR a concise, self-descriptive, and meaningful title
[ ] I've linked relevant issues in the PR body
[x] I've applied the relevant labels to this PR
[x] I've assigned a reviewer

PR contents

[x] I've consulted ivadomed's internal developer documentation to ensure my contribution is in line with any relevant design decisions
[ ] I've added relevant tests for my contribution
[ ] I've updated the relevant documentation for my changes, including argparse descriptions, docstrings, and ReadTheDocs tutorial pages

Description
This PR fixes an issue where the undo_transforms function in inference.py/volume_reconstruction was applied on each sub-volume instead of only once on the complete reconstructed volume (when running inference i.e. test and segment command).
This is the same fix as for image_reconstruction in PR #956 and should speed-up the segmentation process.
In addition, I added the slice_axis argument in the call of MRI3DSubVolumeSegmentationDataset in segment_volume.py. The argument was absent and set to 0 (sagittal) by default. Passing the slice_axis argument is the only way I found to be able to run --segment on a trained model, otherwise it would fail with wrong dimensions.
Let me know if that change makes sense as I have no experience with 3DUnet and segmentation. Thanks!
Linked issues
There is no open issue regarding this bug.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 5 (80.0%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.01%) to 70.782%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

ivadomed/testing.py
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

ivadomed/testing.py
1
48.21%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
4317

Relevant Lines:
6099

💛  - Coveralls

The argument was absent and set to 0 (sagittal) by default.

Pretty crucial!!


use xcode9.4 on travis-ci.

Pull Request Test Coverage Report for Build 44

0 of 0   changed or added relevant lines in 0 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-4.6%) to 73.203%

Files with Coverage Reduction
New Missed Lines
%

Sources/Scientist/Result.swift
2
61.29%

Sources/Scientist/Experiment.swift
5
77.61%

Totals

Change from base Build 42:
-4.6%

Covered Lines:
112

Relevant Lines:
153

💛  - Coveralls


Add visual indicator to labels of required fields

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Fixed issues

Test on contact page: this change works, but there are empty labels on the page. These are now made visible by the presence of a red star.
<label class="control-label control-label required" for="contactform-subject"></label>
Investigating

👍


Request to add a key to Windows Shortcut Guide

Hi,
Thought I'd mention a Win key combo that's missing from the image of the ShortcutGuide:
Win+. for the Emoji popup (1903)
Win+; for the Emoji popup (1809 or higher)
Thanks!

Those shortcuts perform the same behavior and are both necessary for world wide keyboards due to some keyboards not having a period "." key.

Sure, but it would be great to have them on the WindowsKeyShortcutGuide - almost everyone I talk to says "wait that's there already? Neat!"

This is a great idea.  We'll make this change before the first preview

Win + B sets the focus into system area.

Tracking in #179


UI to register new Ironic nodes through Mistral

Adds a page to register new nodes for only OpenStack infrasturcture
providers. The page allows a user to upload a JSON file describing
the nodes to be added. The format of the JSON file is described here:
http://tripleo.org/environments/environments.html#instackenv
Upon submission, the controller parses the JSON file and submits it
through Mistral using the tripleo.baremetal.v1.register_or_update
workflow. It then polls mistral for the workflow to complete. After
completion, it queues a refresh to pickup the new nodes.
Subsequent patches will allow admins to also introspect nodes and make
nodes available for use (aka provide).

@rwsu awesome!  I'll take a look soon - in the meantime, would it be possible to add a few GUI screenshots to this PR?

"Register Nodes" added to toolbar.

An admin selects a JSON file describing the nodes and their attributes.

Quick comments that maybe @Loicavenel or @anandeep can comment on - the UI here specifically calls out Ironic nodes, whereas I know the ManageIQ UI tends to be more provider-agnostic.
Are the screenshots as expected?

I was a bit concerned that we were blocking on the mistral workflow being completed, but this is just the node registration, which takes a few seconds at most.  Introspection is being added in a later patch, and will be queued as a separate task after node registration, so I'm okay with this!

@rwsu, I think there may be a fog issue - I'm getting this error:
Error caught: [NameError] uninitialized constant Fog::Workflow::OpenStack::V2
/home/stack/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/fog-openstack-0.1.11/lib/fog/workflow/openstack.rb:8:in new' /home/stack/manageiq/gems/pending/openstack/openstack_handle/handle.rb:78:in raw_connect'
/home/stack/manageiq/gems/pending/openstack/openstack_handle/handle.rb:51:in `block in raw_connect_try_ssl'
<...>

@rwsu nevermind, it was my error - I forgot my version of openstack didn't have mistral installed

Looks good!  One more request I should have mentioned earlier - is it possible to have this fail gracefully with informative messages if Mistral is not available, or if Mistral does exist but the workflow is not installed?  I think these are both likely scenarios that will cause user confusion.

@tzumainn. Yes, it is possible. I will update this patch shortly.

:+1: LGTM!

@miq-bot assign @dclarizio

@martinpovolny please review code as well as any potential security issues.
@epwinchell the upload file control looks a bit strange, does this match other areas of the product?

@dclarizio It doesn't seem to use our bootstrap file-style implementation. Here's an example:

The code is here:https://github.com/ManageIQ/manageiq/blob/master/app/views/ops/_settings_custom_logos_tab.html.haml#L56

On the first read I have 2 concerns here:

there's a log of logic that does not look exactly UI in the controller. Also that logic seems it might be one time exposed through the API. I'd say that this should be pushed down a bit. Maybe some Service class?
there's a log of code in the view. I'd rather have that code in the controller and have the variables passed to the view explicitly

@epwinchell The patch now uses the "bootstrap filestyle" implementation.
@martinpovolny I moved some of the logic out to the InfraManager class.

@epwinchell, @martinpovolny I've fixed the issues you found. Please have another look.

@dclarizio Looks good

@miq-bot add_label euwe/yes

Euwe Backport details:
$ git log
commit 9bcaf1eaf6b8f3e54e5da2a1419ee3c37981d0a6
Author: Dan Clarizio<EMAIL_ADDRESS>Date:   Wed Sep 21 14:40:31 2016 -0700

    Merge pull request #10644 from rwsu/node_management

    UI to register new Ironic nodes through Mistral
    (cherry picked from commit 0bd8d0c435ffaa93fd5a0a30e50ceaa078cc9e0d)


figure out what's wrong with alternate ssh keys

this has come up a few times where people using non-default ssh keys have issues either running the daemon or connecting via ssh. this needs to be debugged and fixed.

@nlf my idea for fixing this issue is to create or append a ~/.ssh/config file with the correct options for the user in it.
I've been doing the below myself, and it seems to work well for me. Especially because I do not have to remember to type out docker@ when logging in. I can just type ssh local.docker and because of my config file it knows that I mean<EMAIL_ADDRESS>I think this method will eliminate the need for a entry in /etc/hosts too, based on a small test where I changed the /etc/hosts entry to something bogus. I can still run docker ps and still ssh to the dhyve system because my personal ssh config file is setup correctly.
Proposal

create a ~/.ssh/config file with the following contents as part of the dlite install process.

Host local.docker
	HostName <IP_ADDRESS>
	User docker
        # below line is different per whatever the user supplies the installer
        IdentityFile ~/.ssh/docker.key

Where docker.key is any standard (e.g. id_rsa.pub) or "non-standard" (e.g. docker.key) key file name that the user might have supplied to the dlite installer.

More related to the installation process, and simplification of the setup.
I would suggest that dlite maintains it's own set of SSH keys and then ask the user to add to the ssh-config.
The following could be done during installation:
Key-generation $ ssh-keygen -t RSA -b 4096 -f ~/.dlite/id_rsa -N '', and config template:
Host local.docker
    IdentityFile ~/.dlite/id_rsa
    User docker

@nwillems Your suggestion seems like a good path forward. If I remember correctly even, cough, boot2docker did something similar with keys.
However, if you are talking about simplification, it would still be required for the IP address to be included in the ~/.ssh/config file entry if the dlite /etc/hosts append operation is going to be removed from the dlite install process:
Host local.docker
    HostName <IP_ADDRESS>  #set to whatever the dlite IP address is
    IdentityFile ~/.dlite/id_rsa
    User docker

Without the IP address above, and no hosts file entry, ssh local.docker would go no where.

The entry in /etc/hosts is going to stay so that exposed ports in docker are reachable from the host without needing the ip. Generating our own ssh key and creating an entry in the ssh config is a good idea though


Include environment name in target group name

Cloud Formation gets very confused if multiple stacks reference a target
group with the same name, leading to aborted updates and failure to
delete stacks. To prevent this prefix the target group name with the
stack name.

+1


[Regression] ValidationError thrown in action is not handled, does not print help

The bug previously reported and fixed in https://github.com/c4spar/deno-cliffy/issues/387 is back again. In v0.25.0, the bug is fixed, but in v0.25.1 and later versions the bug is back.

Thx for reporting this issue again @Macil and sry for that. There was a missing await which is fixed now. I've also added a test to make sure the issue doesn't happen again. It will be included in the next version.


[Feature-6586][Server]add some ds process definition demo when init

[Feature-6586][Server]add some ds process definition demo when init
1.add some ds process definition demo when init, to display what task type can run and make user easy to
use ds.
2.need configure the JVM parameters (-Ddemo=true) to turn on the StandaloneServer service
3.need modify the tenant information in it

Hi @amaoisnb , you could add closes: #6586 in you PR description to automatically link this PR to the issue it solves.

related: #6586

closes: #6586

I don’t think this is a good idea to couple the demo codes with the production code. At least, you should move the demo codes to the module dolphinscheduler-tools, and execute that tool after starting DS server. Mixing the demo codes and production code increases maintainability complexity

I don’t think this is a good idea to couple the demo codes with the production code. At least, you should move the demo codes to the module dolphinscheduler-tools, and execute that tool after starting DS server. Mixing the demo codes and production code increases maintainability complexity

+1

I don’t think this is a good idea to couple the demo codes with the production code. At least, you should move the demo codes to the module dolphinscheduler-tools, and execute that tool after starting DS server. Mixing the demo codes and production code increases maintainability complexity

+1

I don’t think this is a good idea to couple the demo codes with the production code. At least, you should move the demo codes to the module dolphinscheduler-tools, and execute that tool after starting DS server. Mixing the demo codes and production code increases maintainability complexity

+1

I have an other suggestion about add example workflow for DolphinScheduler, using Python API. It is already have example in more of the task type, and it define with code, most likely to ORM instead of sql, which is more stable and maintainable.
all we have to do is add a new docker image, and run all examples in Python API to export all example to target database,
or directly install python api and run all examples. do you guys think that will be a better solution?

I have an other suggestion about add example workflow for DolphinScheduler, using Python API. It is already have example in more of the task type, and it define with code, most likely to ORM instead of sql or json object, which is more stable and maintainable.
all we have to do is add a new docker image, and run all examples in Python API to export all example to target database, or directly install python api and run all examples. do you guys think that will be a better solution?

May I ask you how to do it

@amaoisnb please check the license header of the new files.

Codecov Report

Merging #11759 (a0a1193) into dev (77e29b5) will decrease coverage by 0.57%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev   #11759      +/-   ##
============================================
- Coverage     39.61%   39.04%   -0.58%
  Complexity     4192     4192
============================================
  Files          1038     1044       +6
  Lines         38843    39480     +637
  Branches       4447     4521      +74
============================================
+ Hits          15387    15414      +27
- Misses        21712    22314     +602
- Partials       1744     1752       +8

Impacted Files
Coverage Δ

...che/dolphinscheduler/common/utils/OkHttpUtils.java
0.00% <0.00%> (ø)

...method/HttpLoopTaskCancelTaskMethodDefinition.java
0.00% <ø> (ø)

...ethod/HttpLoopTaskQueryStatusMethodDefinition.java
0.00% <ø> (ø)

...method/HttpLoopTaskSubmitTaskMethodDefinition.java
0.00% <ø> (ø)

...uler/dao/utils/ResourceProcessDefinitionUtils.java
40.00% <0.00%> (-37.78%)
:arrow_down:

...api/dto/resources/visitor/ResourceTreeVisitor.java
72.72% <0.00%> (-22.73%)
:arrow_down:

...hinscheduler/api/controller/ProjectController.java
50.00% <0.00%> (-18.43%)
:arrow_down:

...heduler/api/service/impl/ResourcesServiceImpl.java
37.73% <0.00%> (-14.23%)
:arrow_down:

...erver/master/processor/queue/TaskEventService.java
69.64% <0.00%> (-10.72%)
:arrow_down:

...scheduler/api/dto/resources/ResourceComponent.java
25.00% <0.00%> (-6.25%)
:arrow_down:

... and 60 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

The comments are not addressed but you click resolve conversation, please fix or reply if you think it's wrong. Don't simply mark it as resolved.

The comments are not addressed but you click resolve conversation, please fix or reply if you think it's wrong. Don't simply mark it as resolved.

I'm sorry I didn't reply to this

Is this demo still working?
What are the preconditions?


multiple cmake and windows build fixes:

cmake < 3.13: LINK_FLAGS property is managed as a string
not a semicolon-separated list.
wavpack_local.h: define FASTCALL only if not already defined,
and define it as __fastcall only when targeting i386.
windows builds of client programs don't depend on iconv.
lowercase several winamp sources for cross-compilability.
winamp: thread_id must be a DWORD, not an int.
winamp: sample_buffer should be int32_t, not long.
winamp: change actual_size <<PHONE_NUMBER> comparison so that
the constant fits into a signed int.
winamp: change swprintf calls to _snwprintf
winamp headers: make sure _MSC_VER is defined when checking
its value.
winamp headers: define NOVTABLE as __declspec(novtable) only
for _MSC_VER, not _WIN32.
winamp, wasabi: make extern declaration of In_Module mod
more compatible.
winamp: added missing void type to UTF8ToAnsi()

Build tested on i686 and x86_64 linux using cmake-3.9.6 and 3.11.2.
Cross-build tested for i686 and x86_64 using mingw-w64 toolchains.

Thanks for these!
You mentioned that you tested the cross-build. Do you mean that you built the winamp plugin on Linux and tested that plugin on Windows using winamp? Which winamp version do you use? I haven't been keeping up with winamp, but it looks like there might be a 64-bit build now. Does that work with the WavPack plugin if it's built for 64-bit, or does it work with old plugins?
@evpobr you're far more experienced with cmake than I am; does this all seem good to go? Thanks!

You mentioned that you tested the cross-build. Do you mean that you built the winamp plugin on Linux and tested that plugin on Windows using winamp?

Build-tested only, not run-tested.

keeping up with winamp, but it looks like there might be a 64-bit build now.

It builds alright, but don't know whether there is a 64 bit winamp (not really
interested in it, I just fixed annoyances in the way of build procedure.)


Add ability to add extra fields to AzureSearch VectorStore when adding documents

Fixes #6134
This PR adds a feature to the ACS Vectorstore for adding extra fields beyond the required fields when adding documents into an Azure Cognitive Search Vectorstore.  By adding these extra fields , when later querying the vectorstore, the search engine's filtering capabilities can be used to narrow the number of records when doing the vector comparison.
The usage of this feature is:
extra_fields = {"extra_fields": {"important_field_1": 123, "important_field_2": 456}}

documents.append(doc1)
documents.append(doc2)
documents.append(doc3)

vector_store.add_documents(documents, **extra_fields)

Then when the user queries this vector store late they can do something like this:
retriever.search_kwargs = {'filters': "important_field_1 eq 123"}

qa = RetrievalQA.from_chain_type(
            llm=llm,
            chain_type="stuff",
            retriever=retriever,
        )

Who can review?
Tag maintainers/contributors who might be interested:
@hwchase17
@dev2049
@ruoccofabrizio
Twitter: poshporcupine

Thanks @CameronVetter -- My team is looking forward to this functionality! Much appreciated! 🙏

Hi @CameronVetter -- Just wanted to follow up on this PR, would be great to get an update! 🙏

@jbueza-railtownai I do not believe there is anything I can do to more this forward, this needs a maintainer to take the next step.  Which is probably:
@hwchase17
@dev2049

@CameronVetter Thanks for the idea. I think this should be a little bit more structural to support an end to end flow. I'll sync with the team next week.

Thanks @CameronVetter and @ruoccofabrizio -- we appreciate the update!

@CameronVetter integrated in #6843 relying only on the metadata dictionary for additional fields. It supports also custom index creation directly within LangChain.

@CameronVetter integrated in #6843 relying only on the metadata dictionary for additional fields. It supports also custom index creation directly within LangChain.

I'm not sure I agree with copy/pasting this bug fix into a larger feature PR when this valid and simple PR is ready to merge. It would have been better to get this fix in quickly for the people waiting for it when it was ready last week...  I suppose as long as it gets into the code base ASAP...

@CameronVetter integrated in #6843 relying only on the metadata dictionary for additional fields. It supports also custom index creation directly within LangChain.

I'm not sure I agree with copy/pasting this bug fix into a larger feature PR when this valid and simple PR is ready to merge. It would have been better to get this fix in quickly for the people waiting for it when it was ready last week... I suppose as long as it gets into the code base ASAP...

First, this is not a bug fix. Second, this is not copy/pasting as you are using an additional field instead of relying on the metadata dictionary which is already part of the standard LangChain document structure. Also, not giving the ability to add extra fields in the index definition as per this PR creates the need to work outside of the framework to add additional fields, which is not ideal.

Any news on that #6843 @CameronVetter @ruoccofabrizio ???
we would really love this #6843 to be merge @hwchase17

Wondering if this will be released, or if there's another way to add and populate extra fields?


Elassandra doesn't work with Istio

Elassandra doesn't work with Istio, but it's a known issue. The respective issues are https://github.com/istio/istio/issues/14662 and https://github.com/istio/istio/issues/10053 (more specifically., https://github.com/istio/istio/issues/10053#issuecomment-459443812). It would be nice if this could be supported out of the box.

What do you expect from Elassandra to make this work ?

Closing inactive ticket


MDLC vs LayoutRenderer

Hi 👏
I'm working on a tracing library - the Elastic APM .NET Agent.
We plan to implement a feature that correlates traces to logs and we plan to also support NLog.
The way this works is that each time a trace is started we'd like to put the id of this trace to every single log that is created while the trace is active. If you direct your log messages to elasticsearch we also have a feature in Kibana (the UI) to jump from traces to logs and vice versa.
An active trace is for example an incoming request in an ASP.NET Core application - we have a middleware which must be registered first, it starts the trace and the trace is active as long as the middleware is not finished - every log during this should be tagged with the id of this trace.
But traces can be also started manually, so for example it can also be a random method in a simple console application. A trace can be active across multiple async methods.
there are some more details here, but I don't wanna spam you with things that are probably not relevant
Now, the question is: what is the best feature in NLog to use here to propagate the trace id. One approach would be to use a LayoutRenderer similar to TraceActivityIdLayoutRenderer
In our case it'd be something like this:
LayoutRenderer.Register("apmtraceId", (logEvent) =>
{
	if(Agent.IsConfigured)
		return Agent.Tracer?.CurrentTransaction?.TraceId;
	return string.Empty;
});

The other option would be to use MDLC, like this - we'd call this method each time the active trace changes.
public void ActiveTraceChanged(ITransaction transaction)
{
	if (!Agent.IsConfigured) return;
	var currentTransaction = Agent.Tracer.CurrentTransaction;
	if (currentTransaction == null)
	{
		MappedDiagnosticsLogicalContext.Clear();
		return;
	}
	MappedDiagnosticsLogicalContext.Set("Trace.Id", currentTransaction.Id);
}

The MDLC approach (based on the name and what I see in the docs) sounds better suited for what we do, but it's more complex, since we need to actively maintain the MDLC - the LayoutRenderer is simpler, but I'm not sure if it's safe to use for this.
So, which one would you suggest to use in our scenario? Or is there anything better to use for this?
Thanks!
We discuss this here in our repo.

NLog MDLC / MappedDiagnosticsLogicalContext is the same as Serilog PushProperty
NLog LayoutRenderer is very equivalent to Serilog Enrichers. They allow you to capture context at the creation of the LogEvent.
Just like you have created Elastic.Apm.SerilogEnricher then I would create a Elastic.Apm.NLog-package that depends on NLog ver. 4.5.4:
Implemented something like this:
namespace NLog.LayoutRenderers
{
[LayoutRenderer("apm-transactionid")]
[ThreadSafe]
public class ApmTraceIdLayoutRenderer : LayoutRenderer
{
        protected override void Append(StringBuilder builder, LogEventInfo logEvent)
        {
            if (!Agent.IsConfigured) return;
            if (Agent.Tracer.CurrentTransaction == null) return;
            builder.Append(Agent.Tracer.CurrentTransaction.Id.ToString());
        }
}

[LayoutRenderer("apm-traceid")]
[ThreadSafe]
public class ApmTraceIdLayoutRenderer : LayoutRenderer
{
        protected override void Append(StringBuilder builder, LogEventInfo logEvent)
        {
            if (!Agent.IsConfigured) return;
            if (Agent.Tracer.CurrentTransaction == null) return;
            builder.Append(Agent.Tracer.CurrentTransaction.TraceId.ToString());
        }
}
}

Then you can reference it using <contextproperty> in in Targets that inherits from TargetWithContext/AsyncTaskTarget. Or you can add attribute to JsonLayout or property to XmlLayout. Ex:
<nlog>
<extensions>
   <add assembly="Elastic.Apm.NLog"/>
</extensions>
<target type="file" name="logfile" fileName="myfile.txt">
    <layout type="jsonlayout">
        <attribute name="traceid" layout="${apm-traceid}" />
        <attribute name="transactionid" layout="${apm-transactionid}" />
    </layout>
</target>
<rules>
    <logger name="*" minLevel="Trace" writeTo="logfile" />
</rules>
</nlog>

Thank you @snakefoot, this sound very good!
Just to clarify one last thing, so all my doubts go away:
This means, it’s safe to assume that the LayoutRenderer is called synchronously right after the Write (or Information, Debug, etc) methods?
Meaning if a user writes logger.Information(“…”); then the LayoutRenderer is called directly without any threading, dispatching, Task scheduling whatsoever?
The reason I ask is because Agent.Tracer.CurrentTransaction reads the transaction from the async local storage, so that only works the way we want when the user code writing the log runs in the same Task as the Renderer.
Probably the answer to my question is yes, but I wanna make sure I don’t misunderstand.
Also, thanks for the code snippets! Super useful.

Yes. It will perform the capture right away. Just like the existing ${threadid}
Sent from my Sony Xperia
---- Gergely Kalapos wrote ----
Thank you @snakefoothttps://github.com/snakefoot, this sound very good!
Just to clarify one last thing, so all my doubts go away:
This means, it’s safe to assume that the LayoutRenderer is called synchronously right after the Write (or Information, Debug, etc) methods?
Meaning if a user writes logger.Information(“…”); then the LayoutRenderer is called directly without any threading, dispatching, Task scheduling whatsoever?
The reason I ask is because Agent.Tracer.CurrentTransaction reads the transaction from the async local storage, so that only works the way we want when the user code writing the log runs in the same Task as the Renderer.
Probably the answer to my question is yes, but I wanna make sure I don’t misunderstand.
Also, thanks for the code snippets! Super useful.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/issues/3726?email_source=notifications&email_token=ACXZ7HEVIQHPDP5HSO6JTDTQXDWEZA5CNFSM4JVGIVK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGAQRMQ#issuecomment-562104498, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACXZ7HHLSUTMWGAZ4XAR2PTQXDWEZANCNFSM4JVGIVKQ.

Perfect, closing this as all questions are answered.
Thanks again!


Customize+ Not Letting Me Add Characters/Myself

So when a friend hits the Add Character button and types the info, they are then added to the list of editable characters.
When I do it, upon pressing ok. Nothing happens. No update, nothing. Trying to add other characters yields the same results. I've tried uninstalling and reinstalling

Did the issue ever resolve itself? Id close the issue if it did, or with no further response.
If it still does not work we can try troubleshooting now.


what are the status names in get session details?

other than
"status": "preview_done"

Unrelated issue to Nextra


Replace SURVEY RESULTS w/WEBINAR Notice

Signed-off-by: Rose Sakach<EMAIL_ADDRESS>Announce the July 21 Zowe Quarterly Update Webinar and include the registration link

@jmertic please merge when possible.  We are trying to promote the Zowe Webinar registration link here.


Optimization: reduce number of allocations on hot path in RcRasterizations.DividePoly

Before:

After:

thank you!


Support asset transfers via XCM

Adds support for the following features:

Upward/Downward transfer of DOT.
Transferring bridged Ethereum assets between sibling parachains.

Both kinds of transfers are performed using the reserve-backed model as described in Polkadot Cross-Consensus Message (XCM) Format.
Changes:

Added a pallet token-dealer. This module includes dispatchables for initiating transfers:

transfer_dot_to_relaychain
transfer_bridged_asset_to_parachain

Added a crate xcm-support which contains an implementation for XCM TransactAsset trait. This is key to enabling deposits and withdrawals of assets by the XCM executor.
Iterative improvements to the bridged assets pallet.
Wiring all the above into the runtime,

There is pretty good unit test coverage for all of this in the the token-dealer module:
vincent@crake:~/code/polkadot-ethereum/parachain/pallets/token-dealer (rococo-v1)$ cargo test
   Compiling artemis-xcm-support v0.1.0 (/home/vincent/code/polkadot-ethereum/parachain/primitives/xcm-support)
   Compiling artemis-token-dealer v0.1.1 (/home/vincent/code/polkadot-ethereum/parachain/pallets/token-dealer)
    Finished test [unoptimized + debuginfo] target(s) in 8.58s
     Running /home/vincent/code/polkadot-ethereum/parachain/target/debug/deps/artemis_token_dealer-10cd52ae3eab93d4

running 3 tests
test tests::transfer_foreign_eth_to_parachain ... ok
test tests::transfer_dot_to_relay_chain ... ok
test tests::transfer_native_eth_to_parachain ... ok

test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

   Doc-tests artemis-token-dealer

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

Note: Leaving this PR in draft mode until upstream dependencies have stabilized (i.e. the features we need have been merged into the master branches of Substrate, Polkadot, and Cumulus).

@vgeddes can close?

@vgeddes can close?

Obsoleted by #200

Obsoleted by #200


Add DirIter repositioning functions

DirIter missed functionality for the tell/rewind/seek functions. This adds these.
I had some slight reservations if it is ok to reposition an iterator, but since this is explicit there should be no problem.

Added DirPosition, I am not sure about the lifetime idea either. Overall the underlying C API is already a bit messy without error handling and filesystem implementation defined usage of the position value. We can't polish a turd.
Still i am in need of these functionality and would appreciate when you merge it. It may be refined in future as need arises. The lack if 'openat' being a leaky abstraction that doesn't support all the underlying
functionality it wraps is currently a bigger concern for me.

Some further thinking/brainfarting: POSIX says

If the value of loc was not obtained from an earlier call to telldir(), or if a call to rewinddir() occurred between the call to telldir() and the call to seekdir(), the results of subsequent calls to readdir() are unspecified.

If one wants to make this 'bulletproof' one could keep all positions queried by telldir() in a HashSet.  Then a call to seekdir() can verify against this. A call to rewinddir() will empty the HashSet.  BUT this contradicts with the idea of being a simple wrapper and the 'No Surprises' principle. Albeit the common case would be that one 'telldir()' only at very few positions.
This makes me thinking perhaps 'seekdir()' should be marked unsafe, document its invariants and call it a day. While technically it is not unsafe in the 'rust' sense either, as it won't produce data races or UB. The joy of unspecified :).

Merged. I don't think we need more guarantees. Thanks!

Released as v0.1.21


confirm cancellation of expense edit button unclear

It's not clear which button to click for your desired outcome here:

I suggest:

Are you sure?
[no, continue editing] [yes, cancel editing]

That's indeed confusing, introduced in https://github.com/opencollective/opencollective-frontend/pull/7010


ci: fix publish workflow

#765  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


GoAnything Panel border row

here 1.0.3 - uninstall, clean folder from old files, (re)install but nothing, there are not border on GoAnything Panel, it's a problem of my package?

Hm, not sure what's happening with this, @gpessia. I did a clean install, cleared my cache, and it was working as expected.

@karelvuong I reinstalled everything from scratch, deleting all (cache, package, etc) file from "Applications Support > Sublime Text 3"  but nothing has changed :cry:

Just pushed a release for v1.1.0 along with a dark theme. Hopefully this will fix your issue. :smile:

No change :( v1.1.0 - same problem in dark version

This has been fixed in v.1.1.2. Thanks @gpessia. :)

Nunc est bibendum!

PERFECT! :+1:


Energy Minimization should work properly with trivial problems

https://github.com/char-lie/patterns_recognition/commit/5d2470839ac4448a2af6da81bfb87f4ecb7c0f8c


Cleanup Whitespace and Newline Characters in Content

Is there anyway to clean up the content a little in postParseHandlers or otherwise?  I'm currently getting all sorts of '\n' newline characters and lots of whitespace.  I'd love to clean that up before committing to the index.  Maybe there's a function I'm missing?

You can first try ReduceConsecutivesTransformer.
If you need more flexibility, you can use regular expression to perform search and replace with ReplaceTransformer
Let me know how that goes for you.

While ReduceConsecutivesTransformer seemed to help, I ultimately preferred to use ReplaceTransformer.  This is what I ended up with:
      <transformer class="com.norconex.importer.handler.transformer.impl.ReplaceTransformer" caseSensitive="false">
          <replace>
              <fromValue>\n</fromValue>
              <toValue xml:space="preserve"> </toValue>
          </replace>
          <replace>
              <fromValue>\r</fromValue>
              <toValue xml:space="preserve"> </toValue>
          </replace>
          <replace>
              <fromValue>\t</fromValue>
              <toValue xml:space="preserve"> </toValue>
          </replace>
          <replace>
              <fromValue>[ ]{2,}</fromValue>
              <toValue xml:space="preserve"> </toValue>
          </replace>
      </transformer>

One more further question about this...  I'd like to also clean up the text in a field created using TextBetweenTagger.  The ReplaceTransformer only works on the content field.  Is there a way to cleanup this 'breadcrumb' field as well?
     <tagger class="com.norconex.importer.handler.tagger.impl.TextBetweenTagger" >
        <textBetween name="breadcrumb">
           <start>BEGINBREADCRUMB</start>
           <end>ENDBREADCRUMB</end>
        </textBetween>
      </tagger>

Transformers target content while taggers target fields.   For fields, you can use: ReplaceTagger.

Most excellent!  Thank you.  I went with:
      <tagger class="com.norconex.importer.handler.tagger.impl.ReplaceTagger">
          <replace fromField="breadcrumb" replaceAll="true" regex="true" caseSensitive="false">
              <fromValue>[ \t\r\n]{2,}</fromValue>
              <toValue xml:space="preserve"> </toValue>
          </replace>
          <replace fromField="breadcrumb" replaceAll="true" regex="true" caseSensitive="false">
              <fromValue>[\t\r\n]{1,}</fromValue>
              <toValue xml:space="preserve"> </toValue>
          </replace>
      </tagger>

This seems to work perfectly, thank you.  We can close this if you'd like, but I have one final question for you if I may.  There appears to be an initial space in the content field.  Normally, I'd use the regex ^ {1,} and replace with nothing, but that doesn't seem to be working in this case.
          <replace>
              <fromValue>^ {1,}</fromValue>
              <toValue></toValue>
          </replace>

Interestingly enough, the exact same regex for ReplaceTagger works perfectly.
          <replace fromField="breadcrumb" replaceAll="true" regex="true" caseSensitive="false">
              <fromValue>^ {1,}</fromValue>
              <toValue></toValue>
          </replace>

Any words of wisdom?

How would one replace with nothing?  For example, I'd like to replace "delete me" with "" (null).  When attempting to use <toValue></toValue> or even <toValue> </toValue> (with space) I'm met with an error:
ERROR (XML Validation) ReplaceTagger: cvc-minLength-valid: Value '' with length = '0' is not facet-valid with respect to minLength '1' for type '#AnonType_toValuereplace'.
ERROR [XMLConfigurationUtil$LogErrorHandler] (XML Validation) ReplaceTagger: cvc-minLength-valid: Value '' with length = '0' is not facet-valid with respect to minLength '1' for type '#AnonType_toValuereplace'.

Is there a special character or something I could use to say replace with nothing?

Despite the error, my testing shows that the replacement works by leaving the <toValue> empty.  This is an XML validation error which should not be triggered.  You can safely ignore until fixed in the next release.

Sounds good to me!  I'll ignore the error then and close this for now.
Also, just to mention, the error is thrown for ReplaceTransformer as well:
<transformer class="com.norconex.importer.handler.transformer.impl.ReplaceTransformer" caseSensitive="false">
              <replace>
                  <fromValue>^\s*[\r\n]</fromValue>
                  <toValue></toValue>
              </replace>
</transformer>

Thanks for letting me know about the transformer one.  This one will be fixed too.

FYI, the latest snapshot release now eliminates the validation error and you can safely omit the "toValue" tag to replace with nothing.   This applies to both the ReplaceTagger and ReplaceTransformer.


Switch filtering order to put education phase above subject

https://trello.com/c/3evIa4Rz/341-move-education-phase-further-up-the-filters-above-subject-on-the-jobs-page
Changes in this PR:
Move the education phase filter on the jobs page to just below the job role filter.
Screenshots of UI changes:

Next steps:

[ ] Terraform deployment required?

[ ] New development configuration to be shared?

 Move "education phase" further up the filters - above subject on the 'Jobs' page


Should log levels have translations?

These are static and could have translations added:

I believe we made a decision not to translate those?

I don't recall that conversation if we did have it at some point. What was the reasoning behind not localizing that dropdown?

@davidfowl

I'm currently checking what VS does in this scenario and I'm still a bit on the fence because the translation experience doesn't feel too consistent there either.  Here's the experience in the error window:

In contrast, here's the experience in the Output Window:

Personally, I would lean towards following the latter image experience with the dropdown since that feels the most similar to this scenario.

For now, let's keep the log levels as-is instead of translating them, based off the similar enum value behavior in VS.


No links found

v1.2.1
No links found

Android 8.1
v1.2.1
Oppo A5s

Apk Showing :  No links found
Version : 1.2.1
Lenovo Tab 7
Android 7.0
That's why I reinstated apk v1.1.4 for continue watching anime.

How am I supposed to help if you do not give what show you are trying to load :confused:
All link loading on the shows I have tested works fine for me.

I am trying to load Barakamon (Dub).
On Fri 1 Oct, 2021, 9:56 PM deceptions, @.***> wrote:

How am I supposed to help if you do not give what show you are trying to
load 😕
All link loading on the shows I have tested works fine for me.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/deceptions/no/issues/7#issuecomment-932374514, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AVAPQWPWE2ARPLXQN3DRZKDUEXOLTANCNFSM5FE2UEWQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

How am I supposed to help if you do not give what show you are trying to load 😕
All link loading on the shows I have tested works fine for me.

I tried all sorts of different anime (including the random one's) in v1.2.1 but the results are the same.

So I just reinstall the v1.1.4 since it work's fine.

See this video.😃

How am I supposed to help if you do not give what show you are trying to load 😕
All link loading on the shows I have tested works fine for me.

😃See this recording please.⬇

Looks suspiciously much like ISP blockage.
Can you load https://goload.one/streaming.php?id=MzUxOA== in your phone browser?
Try using a different DNS or VPN and see if it works. If it turns out to be ISP blockage I will add a switch for switching to streamani.

Looks suspiciously much like ISP blockage. Can you load https://goload.one/streaming.php?id=MzUxOA== in your phone browser? Try using a different DNS or VPN and see if it works. If it turns out to be ISP blockage I will add a switch for switching to streamani.

Yes, I can load that link but it still doesn't work on v1.2.1, I also tried using vpn but the results are the same.

That is very weird, I will send you a changed apk soon which might work.

Please try http://transfer.sh/apD2oT/app-phone-beta.apk @Benhirer @Jiimaa

Please try http://transfer.sh/apD2oT/app-phone-beta.apk @Benhirer @Jiimaa

Still the same result

Please try http://transfer.sh/apD2oT/app-phone-beta.apk @Benhirer @Jiimaa
Nothing changed.

Thanks for testing :smile:
I'm sending another apk soon. This time with proper error catching.

Added a toast showing what is wrong and added a separate try catch meaning that it should work at least partially. http://transfer.sh/2t3lX6/app-phone-beta.apk

Added a toast showing what is wrong and added a separate try catch meaning that it should work at least partially. http://transfer.sh/2t3lX6/app-phone-beta.apk

I've tried to load 10 animes but it still have the same problem previous problem, It still shows "No links found", I also tried using VPN or changing DNS but the results are the same. But im glad that you're working on it. I hope you could fix this soon. 😁😁

Not even showing an error Toast? My theories keeps getting dis-proven :sob:
I honestly have no clue anymore. Please post your logcat if possible.

Not even showing an error Toast? My theories keeps getting dis-proven 😭 I honestly have no clue anymore. Please post your logcat if possible.

See😥.

Not even showing an error Toast? My theories keeps getting dis-proven 😭 I honestly have no clue anymore. Please post your logcat if possible.

I'm ashamed to say that I am not deep into programming to basically understand how to get the logcat since I don't have PC/Laptop to do so, but @Benhirer might have.

Not even showing an error Toast? My theories keeps getting dis-proven 😭 I honestly have no clue anymore. Please post your logcat if possible.

I'm ashamed to say that I am not deep into programming to basically understand how to get the logcat since I don't have PC/Laptop to do so, but @Benhirer might have.
Edit: Yeah he have it 😂

I searched on google for how to get logcat and got an app from play store called 'Logcat Extreme' then I use to get this logcat.

The log is unfortunately missing anything anything useful. Either you are missing permissions or the app does not capture it properly, try searching for 'deceptions' instead of using the app specific feature.
I have tried and failed to replicate this issue on 4 different devices and I am unable to figure out what causes this as all the new code is in a try catch. :confused:
As I can not replicate it I can not fix the issue without logs.

The log is unfortunately missing anything anything useful. Either you are missing permissions or the app does not capture it properly, try searching for 'deceptions' instead of using the app specific feature.
I have tried and failed to replicate this issue on 4 different devices and I am unable to figure out what causes this as all the new code is in a try catch. 😕 As I can not replicate it I can not fix the issue without logs.

Yeah I think only Rooted Phones (Phones w/custom ROMs) can record the logcat which required PC and such as it says on the User Guide of the app.

Please try http://transfer.sh/apD2oT/app-phone-beta.apk @Benhirer @Jiimaa

This one is working Tnx bro ❤

I also have 2 tablets that don't work with 1.2.1. Working fine with 1.1.4. Both giving no links found error as well.

Since I have no logs I tried removing some of the new code to figure out the cause. Please try: http://transfer.sh/NOUzKY/1.apk and http://transfer.sh/TlQr71/2.apk and http://transfer.sh/kxT8fE/3.apk and tell me which of them works, if any of them work.

1,2 and 3 works fine 😁

Same goes to me😙

Since I have no logs I tried removing some of the new code to figure out the cause. Please try: http://transfer.sh/NOUzKY/1.apk and http://transfer.sh/TlQr71/2.apk and http://transfer.sh/kxT8fE/3.apk and tell me which of them works, if any of them work.

😊 It works great.

Since I have no logs I tried removing some of the new code to figure out the cause. Please try: http://transfer.sh/NOUzKY/1.apk and http://transfer.sh/TlQr71/2.apk and http://transfer.sh/kxT8fE/3.apk and tell me which of them works, if any of them work.

All 3 working with my tablets now when 1.2.1 didn't. 1 and 2 is more or less similar with identical server providers but no.3 with all vidstream ones load an episode the fastest without the need of shuffling through other servers like 1 and 2


chore(repo): Rename default charts repo to 'stable'

closes #1151
I think this is all that needs to be changed - I couldn't find any references to kubernetes-charts/<name> apart from the full URL which hasn't changed for now.
cc @technosophos @michelleN  @viglesiasce @jackfrancis

This change is

Code LGTM. How should we message this in the upgrade notes?

@technosophos I noticed I had to rm -rf ~/.helm and helm init again for it to pick up the new name, is there an easier way (presumably manually editing the repo yaml files?)
If people leave their ~/.helm untouched, it continues working as expected with the kubernetes-charts name.


nerdctl network create using another network id[0:12] will fail

Description
It does not if creating with id[0:x] where x != 12, which leads to a range of issues listed in other tickets.
There is no reason for that restriction.
Steps to reproduce the issue
No response
Describe the results you received and expected
na
What version of nerdctl are you using?
main
Are you using a variant of nerdctl? (e.g., Rancher Desktop)
None
Host information
No response

Note. This gymnastic is inside NetworkMap from netutil, which does slap in the fullform id and the [0:12] form as a key in the map.
From a 10 seconds review, the only reason I can think about why this would be useful is for completion.
We should remove all of that anyhow and fix completion.


feat (icm): configurable update strategy (#372)

PR Type

[x] Feature

Release
Be sure to include PR label major, minor or patch when merging into main. This determines which part of the semantic version number needs to be bumped automatically.
What Is the Current Behavior?
Update strategy is not configurable
Issue Number: Closes #372
What Is the New Behavior?
Update strategy is configurable
Does this PR Introduce a Breaking Change?

[x] Yes

Why is that a breaking change? The additional configuration will not break existing definitions.


Feature request: Max duration

Could it be possible to create an optional "max duration" parameter to APE? This way, when the user runs APE with ontologies and data that takes a lot of time, the user can limit the amount of time APE can take to find any workflows. It also protects the user's system from crashing, due to APE taking up too much memory in calculating workflows.

APE 1.1.3 introduced a configuration field "timeout(sec)"

APE 1.1.3 introduced a configuration field "timeout(sec)"


Full Screen at certain resolutions causes bottom bar to overflow.

Full Screen at certain resolutions causes bottom bar to overflow. This only affects Title Bar Style:  Custom, I'm using the Default Dark+ theme, in case it's potentially caused by that.

VSCode Version: Version: 1.40.2 (user setup) Commit f359dd69833dd8800b54d458f6d37ab7c78df520
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.18362

Steps to Reproduce:

Open VS Code in Full-Screen
On specific setups, the bottom action bar is partially obscured, going beyond the edge of the screen.

Does this issue occur when all extensions are disabled?: Yes

Looks like #83456, however it's not reproducible in insiders builds after #85266 was merged and cannot reproduce in 1.40.2 (zip download)
/cc @deepak1556

Thanks @IllusionMH , yeah it sounds similar but that one is definitely fixed.

On specific setups

@GeorgeWL can you be more specific about the setup in which you see this issue ? The resolution and how the displays are arranged. Also can you attach a video demo. Thanks!

Thanks @IllusionMH , yeah it sounds similar but that one is definitely fixed.

On specific setups

@GeorgeWL can you be more specific about the setup in which you see this issue ? The resolution and how the displays are arranged. Also can you attach a video demo. Thanks!

Well I'm not really sure why, but if I full screen it on my bottom screen, there's no issue there.
But on either of my two top screens, it is.
Top Left (screen 2): 2560 x 1440
Top Right (screen 3): 1920 x 1200
Center Bottom (screen 1): 3840 x 2160
Ignore the blurring, that's intentional obfuscation so don't get in trouble with work security team.

I have the exact same issue. It appeared today after updating to version 1.40.2 (f359dd6).
I have a two monitor setup:

Primary monitor: 3200 x 1800 (250% scaling)
Second monitor: 1920 x 1080 (100% scaling)

VS Code looks fine in my primary monitor, but goes beyond the screen boundaries in my second monitor. I'm happy to provide more info in order to help resolve this

That's something worth noting, it did only start after the latest update (1.40.2)
Before the update, I'd had no similar issues and hadn't seen this issue.

I'm having the same issue in 1.40.2 (issue did not exist in prior version). I have a laptop hooked up to an external monitor. The laptop screen is at 3840x2160, the monitor is at 2560x1440, and scaling is set to 250%. When Code is maximized in the external monitor, all 4 edges the window hang off the edges of the screen (it's particularly noticeable on the bottom bar, but all 4 edges are definitely doing it).

now that you mention it @SonOfHans yeah all 4 edges of mine hang off the edge of the screen, just only by a pixel or two, except the bottom bar, which is by like 10-20 pixels.

Just got a new Surface Book 2 at work and that was one of the first things I noticed.
Doesn't happen on the internal screen but on an external Dell one with high DPI.

The same thing happens on the Insider 1.41. This is particularly painful when the errors are hidden. I can't see the red squares in the scrollbar.
When it's small, it's OK...

But when it's maximized, it's not OK :(

Having this issue with 1.41.0.
I have 2 monitors setup:

Laptop screen, 3840x2160, 250%, VS Code looks ok
Connected monitor, 1920x1080, 100%, VS Code window exceeds screen margin when maximized. Screenshot attached below:

External monitors are 1920 x 1080 (Recommended) with 100% (Recommended) scaling.

Facing same problem. Not only bottom bar, even top, left and right bar are overflowing. It is more noticeable in bottom bar due to its color and less margin between text and the edges.
I am on surface book 2 using external display having resolution of 1920x1200.
Version: 1.42.0 (user setup)
Commit: ae08d5460b5a45169385ff3fd44208f431992451
Date: 2020-02-06T10:51:34.058Z
Electron: 6.1.6
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.19041

To anyone interested... I found a workaround... if you just set the primary monitor to be a non-high DPI and restart VSCode, it's sorted. (for now)

Simpler workaround, just disable custom title bar.

@GeorgeWL I did not even realize this was a setting!  Thank you!

Can confirm that untill Feb. 2020, this problem still exists.

Here's a workaround:
Manually drag the left/right borders to the edge of the screen, and then double click the top or bottom border to vertically size it to full height. This seems to fill the screen whilst making the status bar appear correctly.
This works for me putting VS Code on a 100% DPI monitor where my main display (with the windows taskbar) is the 250% Laptop screen.

Another workaround is to use cmdow to script positioning the window.

Put VS Code in the desired location using the above method.

Open a CMD prompt / terminal with CMDOW on path and run:
cmdow "*Visual Studio Code" /F /P

using the position and positon and size values from that command insert the values <X/Y/W/H> in this command and run it:
cmdow "*Visual Studio Code" /MOV <X> <Y> /SIZ <W> <H>

You can then use the command from 3 above to automatically position VS Code whenever you open it.

another workaround: disable custom title bar setting

Disabling the title bar is not an option for all affected use cases, nor is setting the primary monitor to the low dpi one.  In my scenario, for example, the problematic monitor is vertical.  Having that be the primary monitor breaks most things (hehe).  Additionally, the overflow is not just top or bottom, it flies off the side of the screen.

Another workaround: vscode properties-> compatibility -> enable "Override High DPI scaling behavior" and set the Scaling performed by to "Application"

Thanks, @matt13rox ! Your workaround worked for me.

Primary screen: 3840x2150, 250% scaling
2 external monitors: 1920x1080, 100% scaling

For clarity, it's not VS Code properties, but the VS Code launcher properties.

For clarity, it's not VS Code properties, but the VS Code launcher properties.
Where do I find the VSCode Launcher?

@DanielHabenicht , it's the Widows 10 app launcher for VS Code, so it's in the Start menu/screen or on your task bar. Just right-click the launcher, then rigth-click "Visual Studio Code" in the launcher menu that shows, then choose Properties > Compatibility > Change high DPI settings > Override HDP scaling behaviour. (check) | Scaling performed by: System (Enhanced)

The workaround solution provided by @matt13rox is working for me as well. I can confirm that this is still an issue with v1.43.0 which was released this week.

@DanielHabenicht , it's the Widows 10 app launcher for VS Code, so it's in the Start menu/screen or on your task bar. Just right-click the launcher, then right-click "Visual Studio Code" in the launcher menu that shows, then choose Properties > Compatibility > Change high DPI settings > Override HDP scaling behaviour. (check) | Scaling performed by: System (Enhanced)

This worked for me.

Another workaround: vscode properties-> compatibility -> Change high DPI settings -> enable "Override High DPI scaling behavior" and set the "Scaling performed by" to "System (Enhanced)"

Although this works and VS Code looks better in the secondary low resolution monitor, it makes text in the primary high resolution monitor blurry.

Possibly fixed in 1.43.0, although I did rearrange my displays in Windows settings, so I'm wondering if 1.43.0 doesn't fix it for others if it is due to slight misalignment of displays vertical position.

Issue still present in 1.43 for me. Windows 10 2004 19041.153

Same here. (It was the same before this version)
Version: 1.43.1 (user setup)
Commit: fe22a9645b44368865c0ba92e2fb881ff1afce94
Date: 2020-03-18T07:01:20.184Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362

I'm using Surface Pro 7, and two external monitors.
SP7 screen(set by main screen): 2736x1824 200%
Other two screens: 1920x1080 100%
There's no problem on SP7 full screen:

Move VScode window to external monitor and Maximize:

The scroll bar is too thin...
And if i press Win + ->, same issue on Surface Main Screen (not always)

There's no problem when disable custom title bar, but I want to use the more pretty VS Code.
I hope this problem will be solved soon.

FYI @matt13rox's solution worked perfectly for me: https://github.com/microsoft/vscode/issues/85592#issuecomment-596416698

Tried @matt13rox 's solution... it works, but the font rendering is now horrible.

Thank you @matt13rox for that solution it is working for me same:

Primary screen: 3840x2150, 250% scaling
2 external monitors: 1920x1080, 100% scaling

although if I move vs code to my 4k display all text looks fussy, so I have to revert the change from time to time.

Dual screen user here, also with same issues.
The fix reported #85592 works fine for me
I would also say, the text appears clearer using this setting? Seems like the scaling issue was causing some blurriness in the text.

I believe this is for sure related to the electron bug linked earlier in this issue.  The same thing happens in Slack for me (which is also using Electron).  It cuts off part of all four sides, but you can really see it at the bottom right of the picture.
The fix for vs code that @matt13rox mentioned also fixes Slack for me.

Difficult to tell with Slack as there is a lot more negative space in the UI compared to VS Code, but I can confirm (with the help of the scrollbar in the left menu) is affected by this issue.
For the benefit of newcomers, the comment @ryan-harris is referring to is https://github.com/microsoft/vscode/issues/85592#issuecomment-577362693

Gosh, going back to the native title bar... it just looks sooooooo ugly - but that's the only workaround to this issue.
I don't even need to set up a reminder to check this issue from time to time, because for sure ugly title bar will keep reminding me about this issue :smile:

Another workaround: vscode properties-> compatibility -> Change high DPI settings -> enable "Override High DPI scaling behavior" and set the "Scaling performed by" to "System (Enhanced)"

I had to use "System" instead of "System (Enhanced)" as the latter fixed the overflow on my 1080 external monitor but caused it to occur on my 4k internal monitor (which wasn't happening before). Using "System" works for me on both.

Your mileage may vary...

I'm experiencing this with an external monitor that is (2560x1440) in all selected resolution/scale options I've tried so far.
VS Code Version 1.25.1
OS: Windows_NT x64 10.0.18363

I'm experiencing this on my secondary monitor.
Primary monitor: 3840 x 2160 (250% scaling)
Secondary monitor: 2560 x 1440 (100% scaling)
Version: 1.45.1 (user setup)
Commit: 5763d909d5f12fe19f215cbfdd29a91c0fa9208a
Date: 2020-05-14T08:27:35.169Z
Electron: 7.2.4
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.17763

Same issue here.
Primary - Surface Book 3000x2000 (200%)
Secondary - 1920x1080 (100%)
Version: 1.45.1 (user setup)
Commit: 5763d909d5f12fe19f215cbfdd29a91c0fa9208a
Date: 2020-05-14T08:27:35.169Z
Electron: 7.2.4
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041
The workaround from @matt13rox fixes the scaling issue on the external monitor but I agree with @manospasj  that the text on the primary monitor is blurry now. I tried both "System" and "System (Enhanced)" options and both make the text blurry.

In case this is helpful: I'm also noticing this behavior on the Slack desktop client.  Guess it's an electron thing...

Same here.
Screen resolution: 1440 x 900 (100%)
Version: 1.45.1 (user setup)
Commit: 5763d90
Date: 2020-05-14T08:27:35.169Z
Electron: 7.2.4
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

Problem goes away when i change settings:
...
    "window.titleBarStyle": "native"
...

@airtonix this is a much better solution than the others I've tried even if vs code isn't quite as pretty anymore.

@dwaynebradley use @airtonix solution
@airtonix , set your default mode to "Dark" and then there is no difference.

@airtonix This totally works.  However, it gets better.
When I changed my settings to Title Bar Style = "native",
I noticed the ugly white bar at the top immediately.  I was curious as to what else had changed.
So I changed it back to "custom" and guess what happened?
The height of the bar at the bottom got fixed.  And my window menu bar went back to the dark theme.  It's great.
For reference, I'm on Windows 10.  The error was not present last time I was on my computer, and appeared today for no apparent reason.  I did not test just restarting/reloading vsCode, nor do I have the ability to test this.  This fix may have been simply the result of performing a full restart (which is required when switching the title bar style).

I also had this issue and changing the window.titleBarStle to native fixed it.
Resolution: 1920 x 1200
Orientation: Landscape
Scaling: 100%
Version: 1.46.0 (system setup)
Commit: a5d1cc28bb5da32ec67e86cc50f84c67cc690321
Date: 2020-06-10T09:03:20.462Z
Electron: 7.3.1
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

that's not really a fix though, rather a workaround.

Apparently the workaround also fixes it.  I changed to 'native', ran with it for a little while then changed it back to 'custom' and the issue appears to have disappeared.  This has remained trued for several restarts now, and even more recently after an upgrade to the latest 1.47.1.

That sounds more like coincidence tbh

Could be -- just documenting my experience, perhaps it could give some insight to the underlying cause and a true solution.

It's a bug in Electron afaik and they don't seem to care about it that much.

I've had it with all this negative talk about Electron.  I'm switching to
Proton.
On Fri, Jul 17, 2020 at 7:13 PM Benjamin Staneck<EMAIL_ADDRESS>wrote:

It's a bug in Electron afaik and they don't seem to care about it that
much.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/85592#issuecomment-660375795,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBNXX6TSZWZ7ZJJXBN5M4TR4DLI3ANCNFSM4JRVEVEQ
.

@davidrimshnick are you positive? I don't find it so attractive. Your decision seems a little bipolar

Does anyone have the issue tracker link for Electron for this issue?
On Sat, Jul 18, 2020 at 3:06 AM kcbleeker<EMAIL_ADDRESS>wrote:

@davidrimshnick https://github.com/davidrimshnick are you positive? I
don't find it so attractive. Your decision seems a little bipolar
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/85592#issuecomment-660440619,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBNXXZH6YVFU3G4CBST6ILR4FCYDANCNFSM4JRVEVEQ
.

I have this issue, and I think I have a reliable way to reproduce it, a possible explanation, and a workaround.
Background: I have one high-DPI display on a laptop, and a standard DPI monitor.
Steps to reproduce:

Close all instances of VS Code.
Ensure standard DPI display is disconnected, leaving only high-DPI display.
Start VS Code.
Connect standard DPI display and move VS code window to the display.
Maximize VS Code and observe that the window now extends slightly beyond the desktop area in all directions.

Observations: At step 3, right-clicking on the title bar will display a standard-sized system menu on the high-DPI display; after step 4, right-clicking on the title bar will display a larger-than normal sized system menu on the low-DPI display.  As if the DPI scaling has not quite fully changed when the window moved between the monitors.  I have a feeling exactly the same thing applies to the window border metrics (the resizing handles) and perhaps this difference in scaling accounts for the window overflowing by a small amount?
Workaround: The only way I know is to close all instances of VS Code and re-open them while the standard DPI display is attached.

I now have a good workaround for the issue, see: https://github.com/danielgjackson/vscode-maximize-fix
This program simply removes the "WS_CAPTION" window style on any VS Code windows, and this fixes the issue for me.
This is clearly not the real answer, and it may just be working around the symptoms and not the cause.

I'm having the same issue as above, the extension posted above by @danielgjackson fixed it for me. I tried switching to native and back to custom but even with dark mode set as my default the white bar remained.
Screenshots of my monitor setup for reference. Similar to another user above I'm using a Surface with a lower resolution external monitor.

This should be fixed with latest insiders https://code.visualstudio.com/insiders/ , please comment if its still an issue. Thanks!

@deepak1556 gave it a quick check:
Version: 1.50.0-insider (system setup)
Commit: e13875b77c89b95f20ccb5667e14ff164c198e57
Date: 2020-09-15T05:35:57.362Z
Electron: 9.3.0
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19041

And still no luck for me 😢 Here's a screenshot of entire screen:

Bottom bar (as well as all other edges of the window sticks outside). Added a Google Chrome window panned to the right side of screen for comparison.

@deepak1556 I'm afraid I don't think Insiders 1.50 fixes this issue.
I don't envy you getting to the bottom of this, it looks like a story of mixed-DPI (what was connected when launched vs connected later), window styles and client areas.  Hopefully some of the following details may help you.
Firstly, I made sure I was not running my "vscode-maximize-fix" extension (which works around this issue by changing the window style).
I have an internal high-DPI monitor:

Monitor 1: 3840x2400 (300%)

I used Spy++ to measure window coordinates, but I think it's not high-dpi aware so the ones on Monitor 1 are scaled to 1/3.
Spy++ measures a Notepad window (as it is per-monitor DPI aware) as:

Monitor 1 maximized: (-6, -6)-(1286, 776) 1292x782 (1/3 scaled coordinates)

Spy++ measures a VS Code Insiders 1.50 (all other instances closed, opened while only Monitor 1 active) as:

Monitor 1 maximized: (0, -6)-(1280, 770) 1280x776 (1/3 scaled coordinates)

Keeping VS Code-Insiders running, connecting an external monitor as the primary monitor (to the right of Monitor 1):

Monitor 2: 1920x1080 (100%)

Spy++ measures a Notepad window as:

Monitor 1 maximized: (-3846, -6)-(-2554, 776) 1292x782 (1/3 scaled coordinates)
Monitor 2 maximized: (-8, -8)-(1928, 1058) 1936x1066

...the overflowed window coordinates of Notepad are NOT visible, this seems to be a bit of a windows hack for standard window styles to push their resizing borders off the edge, even though they're not actually visible when maximized on multi-monitors; see: https://devblogs.microsoft.com/oldnewthing/20120326-00/?p=8003
Spy++ measures VS Code Insiders 1.50 (kept open since the different-DPI Monitor 2 was added)

Monitor 1 maximized: (-3840, -6)-(-2560, 770) 1280x776 (1/3 scaled coordinates)
Monitor 2 maximized: (-10, -18)-(1930, 1060) 1940x1078

...the maximized window overflows on Monitor 2, and the overflow is visible on the edge of Monitor 1.
Finally, restarting a fresh VS Code Insiders 1.50 while both monitors are connected (the primary is the 100% dpi), gives:

Monitor 1 maximized: (-3837, -3)-(-2564, 766) 1273x769 (1/3 scaled coordinates)
Monitor 2 maximized: (0, -8)-(1920, 1050) 1920x1058

...with no visible overflow on either monitor, but a white visible band of 10 pixels along the top when maximized on Monitor 1.
Something that may be a hint is that not everything is getting reset when moving between the high/low dpi monitors: I notice that the system menu (Alt+Space or right-click title bar) is not correctly rescaling when the window moves between the two monitors.

With both connected and launching on Monitor 2 (100%) the system menu is fine, moving to Monitor 1 (300%) the system menu appears tiny (1/3rd).
With only Monitor 1 (300%) connected the system menu is fine, attaching Monitor 2 (100%) and moving the window to it, the system menu appears huge (3x).

...is it possible that perhaps the system metrics used might also not be getting rescaled properly (or cached)?
If you find out why the system menu is not getting rescaled, I'd bet you would be closed in finding out why this issue is happening.
(I'm running 2004 build 19041.508).

Thanks for testing @mlewand
Also thanks @danielgjackson for the added details, the core of the change is in https://github.com/electron/electron/pull/25052. Basically, when WM_WINDOWPOSCHANGING occurs chromium calculates the client area insets using ElectronDesktopWindowTreeHostWin::GetClientAreaInsets which is based on the monitor in which the window is present, calculated using
MonitorFromRect(&rect, MONITOR_DEFAULTTONULL);

https://source.chromium.org/chromium/chromium/src/+/master:ui/views/win/hwnd_message_handler.cc;l=2785-2800 and returns the results in screen pixels scaled to the monitors' DPI. Finally when WM_WINDOWPOSCHANGED happens chromium will update the DWM frame which in turn calls ElectronDesktopWindowTreeHostWin::GetDwmFrameInsetsInPixels to extend the dwm frame into client area, we are currently using
HMONITOR monitor = ::MonitorFromWindow(
        native_window_view_->GetAcceleratedWidget(), MONITOR_DEFAULTTONEAREST);

most likely this is not returning the correct monitor during the drag operation, which would align with your observation. I am OOF this week, will look into this after I return to work.
Also there is a round-off error that comes with WinFrameView::GetBoundsForClientView() because its calculations are in DIP which is the cause for https://github.com/microsoft/vscode/issues/85655

Need some testing help again if the latest insiders https://code.visualstudio.com/insiders/ fixes the issue. Thanks!

Need some testing help again if the latest insiders https://code.visualstudio.com/insiders/ fixes the issue. Thanks!

I have a laptop 4k with a secondary 1080 screen, and with Insiders version the error is not present.

Cool, works also for me in the latest insider build 🎉 Now I'm anxiously waiting for the October release 😃

Workaround for me was just close all VS Code windows, disconnect my dock, reconnect my dock, re-open VS Code. Looking forward to the standard release to fix this.

Present for me as of 1.51.0 (2020-11-05)

Weird, it's fixed for me. Works like a charm @ 1.51.0.

Weird, it's fixed for me. Works like a charm @ 1.51.0.

huh :(
I'm still having to do the Win10 System (Enhanced) scaling


add new method setBaseURL(String baseUrl, CookieManager cookiemanager)

I have add a new method setBaseURL(String baseUrl, CookieManager cookiemanager) into SyncProxy.java, and modify populatePolicyMap() to populatePolicyMap(CookieManager cookieManager).
In the method setBaseURL(String baseUrl) body, I set the DEFAULT_COOKIE_MANAGER into populatePolicyMap(DEFAULT_COOKIE_MANAGER). So if any project only wants to use setBaseURL(String baseUrl), this change will not bring any impact to them.
And I have modified RpcPolicyFinder.java accordingly.
These modification has been tested in my local environment.

Overall looks pretty good, thanks for the PR. I'll get it integrated for the 0.6 release (hopefully the next few weeks)


Add GitHub Actions build

What does this PR do?
Fixes #707. it runs all os in one place and it seems to be even faster, around 6min compare to previous solutions has build time around 10min... it cal also generate a badge
With this CI we would drop Travis and Appveyor :]

Travis is recently changing his os images and debugging is painfull
Appveyort prefer only one concurrency job so we are not testing almost anything

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

as a follow-up to this, we would add the new badge to readme and drop Travis and Appveyor...

over all the complete built for 12 envs took only 10min

@Borda do we still need this after the travis fix?

it is faster and we have larger coverage of test for all major OS, python 3.6 & 3.7 and both minimal and lates requirements...
in past we had:

linux, for py36 + py37 for min + latest requirements
osx, for py37 for any (latest) requirements
win, for py36 + py37 for any (latest) requirements

with this one we have:

linux, for py36 + py37 for min + latest requirements
osx, for py36 + py37 for min + latest requirements
win, for py36 + py37 for min + latest requirements

moreover, it not for fist time when Travis changed something and our test start to crashing without any obvious reason... which is not very convenient... also having two different Ci platforms

@Borda ok. can you submit a PR with the new badge?


Crash when calling appWillForeground in GDTCORStorage class

Firebase/Core (6.10.0)
Firebase/RemoteConfig (6.10.0)
FirebaseABTesting (3.1.2)
Xcode version: Version 11.1 (11A1027)
iOS decices version: 12.3.1 and 13.1

If you run the tests in Xcode it crashes after starting, it happens no matter the device you choose to run them. It crashes because there's Null pointer passed as an argument and the function doesn't expect Null values. Image with file, class, function, call, error and debug data attached

Duplicate of #4039


VerboseLogger make a broken given a keyword describe title

Here is a simple example:
// __tests__/spec.js
describe('constructor', () => {
  it('should be true', () => {
    expect(true).toBeTruthy();
  });
});

and tests failed with the --verbose option:
jest __tests__/spec.js --verbose

but tests passed without  the --verbose option

Interesting, my guess is it has something to do with the word "constructor". Is the behavior the same if you change the describe block name to an arbitrary word like "foo"?

just broken of reserved words!

Does this also happen with jasmine2? You can switch out the runner using this option: http://facebook.github.io/jest/docs/api.html#config-testrunner-string

This was fixed in a19544fad5ac497c9ceaf65e568c393f5fb6fa56.
Thank you for reporting!


Keep reaching out from Big Picture Science

Big Picture Science is where I left off in my podcast app for reaching out for a combined round 1/2 validation for podcast producers

Change the subject line a d perhaps some of the body. No one has replied to any of the emails when I changed the subject line. Consider: Help validating cryptocurrency podcast app

Left off on Blockchain Talks by Rebel One

Left off on The World Crypto Network Podcast


chore: Clean up Profile Settings

Description 📝

General clean up of the code for Profile Settings

The existing code was fine, but we can do the same with less code...

Major Changes 🔄

Remove useless <Grid />s
Remove usage of <PreferenceToggle />
Improved Preference Editor UI

Preview 📷

Before
After

How to test 🧪

Test functionality and UI on http://localhost:3000/profile/settings
Verify the Preference Editor still works by visiting http://localhost:3000/profile/settings?preferenceEditor=true

Looks good!


Automated cherry pick of #680

Cherry pick of #680 on release-0.5.
#680: Upgrade to go version 1.11.4

Close in favour of #746
/close


NuxtHub Deploy use my local .env values instead in Nuxthub admin dashboard

Description
When deploying with npx nuxthub deploy, the deployment process appears to override the environment variables set in the NuxtHub admin dashboard with local .env file values. This creates inconsistency in environment management between local development and production deployments.
Current Behavior

Local .env file values are being used in production deployments
Environment variables set in the NuxtHub admin dashboard are being ignored/overridden
Environment variables set in the NuxtHub admin dashboard didn't change, but value was using my local .env value

Questions

Is this the intended behavior?
Is there a specific deployment flag or configuration to prioritize dashboard environment variables?
Should we be handling .env files differently during deployment? Or should i use .env.local instead .env in my local development?

Only build time env variables will be overwritten by your local .env (ex: used in nuxt.config.ts)
You can have a .env.prod file for instance for the prod env variables and use npx nuxthub deploy --dotenv .env.prod

@atinux thanks!


'synchronize MPEG-TS clients to a GOP start' for h265?

The 'synchronize MPEG-TS clients to a GOP start' seems to fix some issues I have, when OBS is connecting to an SRT-server. The sound becomes laggy from time to time. You guys seems to have fixed that.
Is there any timeframe for fixing this for the h265 as well? Or is there any other workaround until then?
Best regards.

Or is it already applying to h265? Seems to do a difference on h265.

Hi, the framing should be different on h265 so the buffer-start mode wouldn't work properly
It also shouldn't make a difference to the stream after the client starts receiving video/audio, because the buffering only applies to the start of stream.

My issues is at start receiving only :) Or was ...


predicted output

Hi all,
It seems strange I use test_kitti_pose.py to test sequence 9 dataset, and it executes well except some warnings, but nothing is generated.

Does anyone can help me ? I appreciate your help.

Heyy @danbo2 !
Have you got trained the code in TF 2.0 or 1.0?

@ezorfa I used the pretrained model.

Hi,Were you able to find the cause of this exception and any solution for it?


Update error handling for constant_time_compare webhooks validation

This PR updates the error handling within the constant_time_compare function of the webhook validation method and adds a test. Prior to this there was only an error thrown if the lengths of the signatures did not match. If the values were off, there was not an explicit error thrown.

Codecov Report

Merging #151 (0ce34da) into main (5c8cdda) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
+ Coverage   93.81%   93.83%   +0.02%
==========================================
  Files          20       20
  Lines         501      503       +2
==========================================
+ Hits          470      472       +2
  Misses         31       31

Impacted Files
Coverage Δ

workos/webhooks.py
94.23% <100.00%> (+0.23%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Cannot set both public read access & access policy on the same container

Storage Explorer Version: 1.1.0
Platform: Windows
Architecture: ia32
Build Number: 20180507.1
Commit: bcc8990d
Steps to Reproduce:

Create an Access Policy on your blob container with full access (rwdl)
Set public access level to "public read access for blobs only" on your blob container

OR

Set public access level to "public read access for blobs only" on your blob container
Create an Access Policy on your blob container with full access (rwdl)

Expected Experience:
You should be able to have both an access policy (to let contributors manage files in your container) and public read access enabled (to let anonymous users be able to access the files) on your container.
Actual Experience:

When setting public read access level on the container, all access policies are removed.
When creating a new access policy on the container, the public access level is reset to "no public access".

Workaround: do not use access policies with public read access, but generate a SAS without using access policies. The solution is less flexible (can't revoke or extend accesses to contributors), but it works.

Yep, that's a bug! The same REST operation controls both ACLs and the access level, but we don't preserve both pieces of information when setting either of them.

Fix has been merged into master for 1.3.0.

The changed access level can’t be saved for one blob container, so create the new bug #380 which is related to this issue.

This is still broken for me after updating to 1.3.0. Specifically, the scenario in https://github.com/Microsoft/AzureStorageExplorer/issues/317 Changing container Access Policies sets Public Access Level to "Private" which was closed as a duplicate of this issue. About info:

Version: 1.3.0
Platform: Windows
Architecture: ia32
Build Number: 20180706.3
Commit: 5319bc48

Should I file a new issue, or will this one be reopened?

I've reopened the issue. Apologies for not actually fixing. We'll be releasing a hotfix ASAP.

1.3.1 notification was sent out last night. That version contains the full fix for this bug. I am now closing this issue.


Deprecate '-c' short variant flag for 'docker build' and 'docker create'

As I say on #17101.
Given that -c (cpu-shares) flag as been removed from docker run in #16271, I think it should also be removed from docker build and docker create for consistency.

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

ping @tiborvass @runcom in case you think this would be consistent for the 1.9 release

+1 please PR, will add it to 1.9.0 since this would be inconsistent otherwise.

+1 (how do I missed this)

@runcom np, you're creating a PR?

@thaJeztah I can't now cause I don't have my laptop with me :( if nobody is gonna do this before Monday I'll do it btw

@runcom @thaJeztah I can take care of it :stuck_out_tongue_closed_eyes:

@vdemeester sgtm, I was about to give it a go, but you're probably faster than I am :+1:

@vdemeester thank you!


METRON-2127: Update Maven repositories to https

Contributor Comments
Updates Clojars and Hortonworks repos to use https instead of http.
The best way to test is unfortunately to purge your local repo and rebuild.  I did this and also ran up dev to make sure it ran up clean.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

[x] Have you included steps or a guide to how the change may be verified and tested manually?

[x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh

[x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

+1 by inspection pending Travis. Thanks @justinleet!

Should we invalidate our travis maven caches?

@ottobackwards I think I have permissions to could go ahead and do that.

I think so

Looking at our build times, I'm actually concerned that if we kill the caches our builds won't complete.  The integration tests take >45 minutes and it's very possible redownloading everything goes over our remaining time.
Right now, I'm not going to be able to take time to troubleshoot that if we dump the caches and the builds fail, so I'm inclined to at least temporarily hold off.  I'm open to suggestions about how to deal with it (and we may want to hit the dev list if there's a possibility of master not being able to be built if the cache is killed)

i just mean getting one build without the cache, and rebuilding the cache with the https sources

i just mean getting one build without the cache, and rebuilding the cache with the https sources

Yeah - so we have the ability to restart any 1 of the 4 build phases. Could we invalidate the cache once and then basically restart the fastest one first? Might need to restart the long pole build phases multiple times before we get a build that completes in the time window.

Looking at our build times, I'm actually concerned that if we kill the caches our builds won't complete. The integration tests take >45 minutes and it's very possible redownloading everything goes over our remaining time.

To recap, our current Travis CI build is composed of multiple jobs. Travis' time limit of 50 minutes is per job, rather than the total build time.  While our total build time is on the order of 2.5 hours, it is only our integration-test job which is coming close to that 50 minute limit.
We could try splitting our integration tests into multiple jobs.  Each of these would have the opportunity to run in parallel (given whatever resources Travis can allocate to us), but more importantly each one has its own 50 minute limit. For example...

Parser Integration Tests:

time mvn surefire:test@integration-tests -pl "metron-platform/metron-parsing/metron-parsing-storm, metron-platform/metron-parsing/metron-parsers, metron-platform/metron-parsing/metron-parsers-common/"

Enrichment Integration Tests

time mvn surefire:test@integration-tests -pl "metron-platform/metron-enrichment/metron-enrichment-common/,metron-platform/metron-enrichment/metron-enrichment-storm"

etc

We would just need to determine how to logically split the tests up.  If this sounds reasonable, I've already got a start on a POC.  I can also take this as a separate discuss thread, if appropriate.

@ottobackwards, @justinleet  - I blew away my personal local caches here - https://travis-ci.org/mmiklavc/metron/builds/538546730 and it succeeded. I took a peek at the logs and do see it downloading artifacts via https, e.g. https://travis-ci.org/mmiklavc/metron/jobs/538546731#L7699. I don't see it downloading any of the other project dependencies, however. I must be missing something on how we set this up. Any ideas?

Hey guys, any thoughts on this? We should probably get this working sooner than later.

I am +1

I'm +1 as well.


Suggestions

Hi,
I installed this in primo and have a few suggestions to share. This is an amazing tool! I am glad to see the power of linked data in Primo. Here are some thoughts:
(1) make sure the value of creator label in the JSONLD returned from linked data api is the same as the creator string on the item page. Sometimes the JSONLD put all the names under creator element including Fictitious character(https://open-na.hosted.exlibrisgroup.com/alma/01CALS_SDL/bibs/991016680679702917.jsonld)
(2) If a name only exists in Wikidata but not on DBpedia, it gives format error (the length of the more about the author is not correct).
Thanks again for this tool.
Best,
Greta

Thanks @gretaheng  for these suggestions. We'll look into them.


Support for 22+ fields in JSON reads/writes in Play 2.3 client

Currently if a defined case class has more than 21 fields, the JSON reads/writes will not compile. Before Scala 2.11, there was an arity limit of 21 fields in a case class; this was changed to allow for N fields in 2.11. Can the code generator for Scala Play clients leverage a Read/Write builder in some fashion (http://stackoverflow.com/questions/27301131/writes-for-json-views-with-more-than-21-fields-in-play-2-3) to allow for more than 21 fields?

I might be mis-remembering, but unfortunately the field limit still exists in play json - e.g. we did retry expanded field support in the client following scala 2.11 release, but unfortunately the libraries we use do not yet fully support this.

is this still the case?


Add option to suppress the rule on certain file patterns

I'm working with Storybook and on stories files a default export is always required.
I don't want to clutter every file with the eslint disable rule comment, so it would be awesome to have an option to disable the rule for defined file patterns (eg. *.stories.tsx)

Yeah just read the v6 et v7 doc for React, in both case an object export is required. So we can always skip analysing stories files. Available in v0.3.5


Encoding wikitext-2-raw-v1 using OGA Tokenizer hangs

Describe the bug
Using the OGA tokenizer to encode the wikitext-2-raw-v1 hangs and does not return, but works fine for wikitest-2-v1.
To Reproduce
Steps to reproduce the behavior:
import onnxruntime_genai as og
from datasets import load_dataset
tokenizer = og.Tokenizer(model)
testdata = load_dataset("wikitext", "wikitext-2-raw-v1", split="test")
tokenizer.encode("\n\n".join(testdata["text"]))
Expected behavior
Return a list of encoded wikitext2 dataset.
Desktop (please complete the following information):

OS: Windows 11
onnxruntime-genai-0.4.0

Describe the bug Using the OGA tokenizer to encode the wikitext-2-raw-v1 hangs and does not return, but works fine for wikitest-2-v1.
To Reproduce Steps to reproduce the behavior: import onnxruntime_genai as og from datasets import load_dataset
tokenizer = og.Tokenizer(model) testdata = load_dataset("wikitext", "wikitext-2-raw-v1", split="test") tokenizer.encode("\n\n".join(testdata["text"]))
Expected behavior Return a list of encoded wikitext2 dataset.
Desktop (please complete the following information):

OS: Windows 11
onnxruntime-genai-0.4.0

Consider this is a very large text operation, how long do you wait for the result?

@WA225 , Thanks for reporting this issue.
The sentencepiece converted tokenizer does not split long texts into smaller segments before applying BPE merges. This can lead to longer processing times for lengthy texts, though results can still be achieved. As a workaround, you can process the text sentence by sentence rather than in a single batch. We will incorporate code to handle text splitting into the tokenization process to address this issue soon.

Thank you for your help @wenbingl

I have made a PR to avoid this slowness of a long text, https://github.com/microsoft/onnxruntime-extensions/pull/799. After it was integrated into genai, you can have a try too.


Detect clicks per second

Hi,
I'm trying to learn Minecraft scripting to record CPS (click per second) during a game play. I've read the docs but could not find a way to detect the click event. Is it something already existed but I missed? Or is the click event called a different name in Minecraft?
Thanks.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0d089746-9c4b-101f-71f4-34140c0a6b05
Version Independent ID: 0d089746-9c4b-101f-71f4-34140c0a6b05
Content: minecraft/server-ui Module
Content Source: creator/ScriptAPI/minecraft/server-ui/minecraft-server-ui.md
Product: gaming
GitHub Login: @JakeShirley
Microsoft Alias: jashir

https://learn.microsoft.com/en-us/minecraft/creator/scriptapi/minecraft/server/entityhitevent

Closing as the previous comment provides the best solution to the problem presented. There is currently no way to directly capture input, so you need to do it via another event.


nn.tabulate() unexpectedly prints to the jupyter console

System information
flax 0.5.3
rich 11.2.0
Problem you have encountered:
The new tabulate() function returns a string. It doesn't print the tabulation to the terminal. However, if the function is run inside a jupyter notebook, the table is printed to the jupyter console when the string is generated. This is problematic for me, because the table then appears inside jupyter-book documentation even though I didn't request it, and there doesn't appear to be a way to supress the output.
What you expected to happen:
The same behaviour as in a regular python terminal---nothing printed unless I call print(s) on the returned string s.
Example
Run the following in a regular python terminal and nothing is printed.
Run it in a jupyter-lab ipython cell and the table appears.
import jax
import jax.numpy as jnp
import flax.linen as nn

class Foo(nn.Module):
    @nn.compact
    def __call__(self, x):
        h = nn.Dense(4)(x)
        return nn.Dense(2)(h)

x = jnp.ones((16, 9))
tabulate_fn = nn.tabulate(Foo(), jax.random.PRNGKey(0))
s = tabulate_fn(x)

If you run that example code in a jupyter notebook, the variable s has the value "\n\n", which doesn't quite seem right.
Probable fix
Maybe this is fixed by adding force_jupyter=False to the Console constructor?
https://github.com/google/flax/blob/48dfc05730f09868d511fa907da7e081ef316ca3/flax/linen/summary.py#L412-L416

Hey @grahamgower! Thanks for reporting this. I was checking Console and it seems there is a force_jupyter flag which when set to False might fix this issue, will test it and send a patch if works.

This should be fixed once #2316 is merged.


Download images from Issues

Hi and thanks for creating this plugin!
I was thinking that images could also be displayed in the GitLab Issue. As I see it, the best option os to download the remote image locally to some "/images/" folder, where Obsidian can render it locally.
I have also thought of extending the GitLab local uploads link with the gitlab instance and project name and use the image as an external one. However, I guess this would require authentication, in order to see the image in the Obsidian Note, which makes everything more complicated.
What do you think about this? 😄

What images are you referring to? Ones that are embedded into issue descriptions and comments?

Yup, exactly! The ones referenced in the Markdown as , for example.

Hi, any update on this issue? Should there be any help needed, please let me know, as I could perhaps contribute :)


minecraft, minecraft-server, papermc: remote code execution exploit (CVE-2021-44228)

A new vulnerability was recently discovered that affects minecraft clients and servers, allowing remote code execution,
Sources
CVE
CVE-2021-44228
Papermc discord

Twitter
A critical security issue has been found that affects Minecraft. If you have the game running, please shut down all running instances of the game and Launcher and restart - your Launcher will automatically download the fix.— slicedlime (@slicedlime) December 10, 2021
Updates

[x] minecraft: 2.2.1441 -> ?, updated through minecraft launcher
[ ] minecraft-server: 1.18 -> 1.18.1 - #150210
[x] papermc: 1.17.1r97 -> 1.17.1r398 - #149983

Maybe we should add the cve number to 21.05

What does that mean? Should I keep this open until that happens?