/message endpoint does not check if match exists

The /message endpoint does not check if the two users are actually matched and allows an arbitrary uuid as matchId.
Since messages are based on matches in the app/extension, the recipient will only receive a push notification / popup but won't actually be able to see the message, which might still be annoying and weird.
POC:
curl -i -X POST --header "Content-Type: application/json" --data '{"recipientId": "some-user-id-here", "text": "Hello", "matchId": "random-uuid"}' -H "access-token: XXX" -H "refresh-token: YYY" https://api.vsinder.com/message/

{"message":{"matchId":"random-uuid","senderId":"own-id","recipientId":"some-user-id-here","text":"Hello","id":"e374ff99-876d-409a-9bc6-63aecf537ab0","createdAt":1607628077252}}

rip I added a foreign key for this exact situation, but guess it's not working, thanks for letting me know, I'll fix asap

I am not sure if a normal foreign key is sufficient here... A foreign key would just mean, that there is "a valid" match . But wouldn't check that there is actually a match between the two users, would it? (someone could use the same matchId over and over again)

hmm that's a good point, I was trying to avoid doing a lookup on every message sent, but maybe it's unavoidable


Problem with breakpoints

I did everything as was written in this article, but could not set breakpoints  for the code lines  in razor files on the source tab. I tried a right click on the lines, saw the Breakpoint word in pop-up menu, but it was inactive. What's wrong?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ec2f61c7-9f51-6735-e328-3c7b495d70c3
Version Independent ID: 4d06e565-282d-6387-aa90-cb2c2986d35a
Content: Debug ASP.NET Core Blazor
Content Source: aspnetcore/blazor/debug.md
Product: aspnet-core
Technology: aspnetcore-blazor
GitHub Login: @guardrex
Microsoft Alias: riande

I was just working with this yesterday morning, and I think I'm close to working it out based on the blog post instructions. I placed my current approach on the issue.
Let's close this as a duplicate of that issue. I'm planning on working on it more today. If I can't get it running, we'll get input from engineering on that issue.
https://github.com/aspnet/AspNetCore.Docs/issues/15983


Enable window reproducible comparison

jdk17 enabled.
Close #743
Signed-off-by: Sophia Guo<EMAIL_ADDRESS>

https://ci.adoptium.net/job/jdk17u-windows-x64-temurin_reproduce_compare/13/console

Hmm, should code freeze bot not be blocking this?

/thaw


Remove useless path in individual code coverage report

simplecov.individual_report('coverage/coverage.json', Dir.pwd)
outputs coverage for files with fullpath, like:
| File                                  | Coverage |
|---------------------------------------|----------|
| /foo/bar/current/another_ruby_file.rb | 20.00%   |

Remove useless path, tables now become as follows:
| File                 | Coverage |
|----------------------|----------|
| another_ruby_file.rb | 20.00%   |

Thanks!


Update BinarytoDecimal.rs

Made it more functional

While this works, it doesn't use the algorithm which should be used whenever applicable. It is applicable in Rust.


Can not read directly from *os.File

Thanks for the great library!
Following the example:
f, _ := os.Open("file.data")
defer f.Close()
scanner := recordio.NewScanner(f)
for scanner.Scan() {
	data := scanner.Bytes()
	// Do something with data
}
if err := scanner.Err(); err != nil {
	// Do error handling
}

Produces error:
interface conversion: *os.File is not io.ByteReader: missing method ReadByte

Thanks for the report! This is fixed now, and was a result of the Scanner interface not doing the same io.ByteReader conversion that the old Reader interface did.


Fixed https://github.com/chjj/marked/issues/465

@matt- or @UziTech - Can you check this out.

I split my commit into two commits. To make it clearer what I am fixing, see https://github.com/chjj/marked/pull/974/commits/98ac7a43958014832788b9d01580f394c84bfb27

LGTM
The bug that code was meant to fix (https://github.com/chjj/marked/issues/77) seems to still work

@UziTech, when I do the following (with this my PR):
const marked = require('./');

const str = `[link][1]

* List

  [1]: http://example.com
`;

const md = marked(str);
console.log(md);

marked output this:

link

List

What is exactly awaits @tlvince.

By the way, and without my PR, it works as expected.


[Feature]  The usage of Llama positional encoding.

In the implementation of Fishspeech, LLAMA is used as the LM model to generate semantic tokens. I have some doubts about the usage of LLAMA position embedding here. The position embedding in this case combines text and semantic tokens together for encoding. However, theoretically, there should be no relative positional relationship between text and semantic tokens (the distance between a semantic token and a text token is theoretically meaningless). So, would it be more reasonable to refer to the implementation of VALLE and encode the positions of text and semantic tokens separately?

I previously saw that a new version of the model would be released in other issues which would address many problems present in the previous model. I am wondering if it has been released yet.

The relative positional relationship does matter for our case.
It's plan to release at under of April, we obersved siginificant better performance.


Add activate extension command

Summary
This ticket covers discussion of moving parts of functionality from Palo Alto's Makefile into dt-cli.

Add command activate to activate monitoring configuration of the extension.

P.S. This ticket was split from #2 which initially contained both commands.

Closing because this is out of scope


feat(avm): simulator relative addr

Implements relative addressing in the AVM simulator.

This is required for Brillig non-inlining of functions.
This is backwards compatible so it can be merged.

Note: this is not being used in the transpiler. Alvaro did something there so I might ask him for that code.

#8837  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on  Graphite

Merge activity

Oct 1, 10:29 AM EDT: @fcarreiro merged this pull request with Graphite.


Windows CPU build missing on PyPI?

🐛 Bug
Is there a reason the CPU build of torchvision is not pushed to PyPI anymore?
To Reproduce
Steps to reproduce the behavior:

pip install torch==1.7.1 torchvision==0.8.2 torchaudio==0.7.1

Output:
Collecting torch==1.7.1
  Downloading torch-1.7.1-cp38-cp38-win_amd64.whl (184.0 MB)
     |████████████████████████████████| 184.0 MB 201 kB/s
ERROR: Could not find a version that satisfies the requirement torchvision==0.8.2
ERROR: No matching distribution found for torchvision==0.8.2

Expected behavior
CPU build of torchvision is installed.
Environment

OS: Windows
Python version: 3.8.6

Additional context
torchvision used to be pushed to PyPI (up until v0.5.0) and I'm wondering why this isn't the case anymore. I'm aware the standard/recommended way of installing is through the pytorch.org index. However, the main torch package (CPU only) is being pushed to PyPI, so I'm wondering whether it is inteded that both torchvision and torchaudio are not or if it's just a bug?
I could not find any helpful recent information on this, only some discussions around PyPI binary size contraints (mainly this and this). I understand this is a problem for the CUDA builds but for the CPU build I really do not see any issue (e.g. torchvision v0.5.0 is 1.2 MB).
Does anybody have some insight as to why this is happening?
cc @peterjc123 @nbcsm @guyang3532 @maxluk @gunandrose4u @smartcat2010 @mszhanyi

Also cc @seemethere


Calc and display total time of queue after queue is printed

Added an additional line whenever the queue is printed that shows the total time of the queue (I don't think that includes the currently playing song). It will not display if there are no songs in the queue.
I also rewrote the calcLength function so that it can properly handle displaying hours.

Neat!

:+1:


Improved exception handling. Don't stop updating from server because …

Description:
Update to exception handling and avoid the case where an exception causes the next update to not be scheduled. Also restructed some to avoid a pylint warning about too many variables.
Related issue (if applicable): fixes #
Checklist:
If the code does not interact with devices:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

…of exception.

:dolphin:
Thanks for all your contributions improving error handling and logging!


check hash value in register model API

Description
Add hash value validation step in register model API.
Issues Resolved
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #878 (844aca2) into 2.x (90e5ea0) will increase coverage by 0.05%.
The diff coverage is 77.77%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##                2.x     #878      +/-   ##
============================================
+ Coverage     84.06%   84.12%   +0.05%
- Complexity     1749     1756       +7
============================================
  Files           139      139
  Lines          6721     6752      +31
  Branches        669      673       +4
============================================
+ Hits           5650     5680      +30
  Misses          774      774
- Partials        297      298       +1

Flag
Coverage Δ

ml-commons
84.12% <77.77%> (+0.05%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...java/org/opensearch/ml/profile/MLModelProfile.java
62.50% <0.00%> (ø)

...ain/java/org/opensearch/ml/engine/ModelHelper.java
88.28% <100.00%> (+0.66%)
:arrow_up:

...n/java/org/opensearch/ml/model/MLModelManager.java
77.80% <100.00%> (+0.04%)
:arrow_up:

... and 5 files with indirect coverage changes


Integration can not install

I agree to the following

[X] I have read the documentation right now
[X] I have read the FAQs right now
[X] I am aware of the latest release notes
[X] The Backend (CCU/Homegear/...) is working as expected and connected devices are controllable by its own UI.
[X] I am running the latest version of the custom_component (and Home Assistant)

The problem
Integration danielperna84/hahomematic> Repository structure for 2023.12.0 is not compliant
Seems to be related to actual version
User defined repository: https://github.com/danielperna84/hahomematic.git
What version of HomematicIP (local) has the issue?
2023.12.0
What was the last working version of HomematicIP (local)?
No response
What type of installation are you running?
Home Assistant Supervised
What type of installation are you running for your homematic backend?
CCU2
Which version of your homematic backend are you running?
2.616
What hardware are you running for your system?
Synology
Which config details do you use

[X] Username and password
[ ] TLS
[ ] callback data (see)

Which interfaces do you use?

[ ] Homematic IP
[X] Homematic (Bidcos-RF)
[ ] Groups (Heating-Group)
[ ] BidCos-Wired (HM-Wired)

Diagnostics information
No response
Anything in the logs that might be useful for us? The log (full log) is the best source to support trouble shooting!
No response
Additional information
No response

Integration danielperna84/hahomematic> Repository structure for 2023.12.0 is not compliant

Read your installation instruction carefully:
This is NOT the custom integration: https://github.com/danielperna84/hahomematic
This is the custom integration: https://github.com/danielperna84/custom_homematic


Bug with only Mapbox Imagery at exactly z18 in iframe demo

This is a weird one.
I captured this while testing the iframe demo. I clicked on the Steel Pier entry, and it takes the map to :
https://rapideditor.org/canary/examples/iframe/parent.html#map=18.00/39.35752/-74.41917/20.0&background=Mapbox
And an imagery tile does not load there.  It's consistently reproducible by going here, but only with Mapbox Satellite as the background layer.  This imagery layer is a bit special because it uses 512px tiles, maybe that has something to do with it.
It only happens at exactly z18.  Change the zoom to z18.01 and the tile will load.

Inspecting the scene graph with the PixiJS dev tool, shows that there really is no tile.
This means that it does not try to load, or if the tile was loaded and we move the map here, it's removed from the scene!
This means there is probably a bug in the Tiler code with knowing what tiles belong in this viewport.

Update:
Opening the url above demonstrates that the issue probably is in the Tiler, because OSM and Rapid data also don't initially load here - until you move the map slightly.

I did some more investigation today and the issue is the fast point-in-polygon tests that the tiler does to tell whether the tile is in the viewport.
It is also easy to reproduce just by zooming out to z0 and rotating until the tile corners are out of view.
(Note that it lags a bit behind when you'd expect it to disappear, because we wait 3 seconds before removing a tile believed to be out of view)


what should i do?

Searching for devices...
Killing adb, there might be an issue with it...
No devices attached, but I'll run anyway
======================================================
Something went wrong while executing this:
$ git clone --depth 1 https://github.com/shenhuanet/ViewScreenshot.git C:/User
s/ADMINI~1/AppData/Local/Temp/dryrun/5bb074c6fd3aa1e9dd140de65bbab485bd09f5faccc
677f9bc84a72ca610ab04

and I used it in window.please let me know what you have any solutions.

I have the same problem,need help

When you type the command "adb devices" on the terminal what appears?

Run this and tell me what happens:
git clone --depth 1 https://github.com/shenhuanet/ViewScreenshot.git C:/User
s/ADMINI~1/AppData/Local/Temp/dryrun/5bb074c6fd3aa1e9dd140de65bbab485bd09f5faccc
677f9bc84a72ca610ab04

This was probably solved by #63


No longer installs on .NET 4.6

Hello,
I've been using this for a project of mine in VS 2015 via Nuget.  I've attempted to update the package but I keep getting an error message to say that the package is no longer compatible due to the package being no longer compatible with .NET 4.6 (see screenshot)

I've had a look at your package via Nuget Package Explorer and it seems its missing the necessary libraries for .NET 4.6.  Can this be rectified at all?
Many thanks

It's dependent on .Net Standard 2.0 for some reason, which means I can't use it with the .Net Framework 4.5.2, gutted. Why make this so dependent on a specific .Net library?

It works on the previous version released. That's the one I'm using at the moment. Unfortunately Nuget keeps reminding me there is an update I need to do which is frustrating 😡

Fixed in tag 1.4.0 now available on nuget.org.


TypeError: Cannot read properties of undefined (reading 'row')

访问scope里面的row属性报类型错误，为什么？怎么解决呢？类似这种类型错误还有很多：

Can you provide us a small repro online using https://stackblitz.com/github/vuejs/create-vue-templates/tree/main/typescript-vitest?file=src%2Fcomponents%2F__tests__%2FHelloWorld.spec.ts ?
It only takes a few minutes, and we'll be able to take a look

We did not hear back from the OP, so I'm going to close the issue.
@black927 feel free to ping me with a repro and we'll reopen it if necessary!


.github: add multiple issues template

Changes
This move the current issue template to a bug-report template, and add
new ones (one for feature request and one free form). This follows
what was done in tektoncd/cli.
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>/cc @afrittoli @bobcatfish @sbwsg @dibyom

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[ ] Includes tests (if functionality changed/added)
[ ] Includes docs (if user facing)
[x] Commit messages follow commit message best practices
[x] Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

/kind misc

/test pull-tekton-pipeline-integration-tests


[BUG] Publishing fails if API user authorization is set to OAuth or OpenID

Release version
4.1.0
Describe the bug
Fails to publish when going from one environment to another , the Portal OAuth needs manually configuring in advance
Expected behavior
The OAuth 2.0 or OpenId Connect can be exported and published as part of the overall operation team setup
or
Alternative ignore the setting and proceed with the deployment
Actual behavior
Pipeline fails with the following error
crit: Publisher[0]       System.Net.Http.HttpRequestException: HTTP request to URI https://management.azure.com/subscriptions/***/resourceGroups/moint-paas-uat-rgp-001/providers/Microsoft.ApiManagement/service/apimapiops002/apis/crmues-accounts-anon-read-v20?api-version=2022-04-01-preview&asyncId=646242d54634611490b90e00&asyncCode=201 failed with status code 400. Content is '{"error":{"code":"ValidationError","message":"One or more fields contain incorrect values:","details":[{"code":"ValidationError","target":"AuthenticationSettings","message":"Authorization server was not found."}]}}'.          at common.HttpPipelineExtensions.Validate(Response response, Uri requestUri)          at common.HttpPipelineExtensions.WaitForLongRunningOperation(HttpPipeline pipeline, Response response, CancellationToken cancellationToken)          at common.HttpPipelineExtensions.PutResource(HttpPipeline pipeline, Uri uri, JsonObject resource, CancellationToken cancellationToken)          at publisher. Program.<>c__DisplayClass12_0.<<GetPutRestResource>b__0>d.MoveNext()       --- End of stack trace from previous location ---          at publisher.Api.PutApi(ApiName apiName, ApiInformationFile apiInformationFile, ApiSpecificationFile specificationFile, JsonObject configurationApiJson, ServiceUri serviceUri, PutRestResource putRestResource, ILogger logger, CancellationToken cancellationToken)          at publisher.Api.<>c__DisplayClass23_0.<<ProcessArtifactsToPut>b__4>d.MoveNext()       --- End of stack trace from previous location ---          at System.Threading.Tasks.Parallel.<>c__501.<b__50_0>d.MoveNext()
--- End of stack trace from previous location ---
at common.IEnumerableExtensions.ForEachParallel[T](IEnumerable1 enumerable, Func2 action, CancellationToken cancellationToken)
at publisher.Api.ProcessArtifactsToPut(IReadOnlyCollection1 files, JsonObject configurationJson, ServiceDirectory serviceDirectory, ServiceUri serviceUri, PutRestResource putRestResource, ILogger logger, CancellationToken cancellationToken)          at publisher.Service.ProcessArtifactsToPut(IReadOnlyCollection1 files, JsonObject configurationJson, ServiceDirectory serviceDirectory, ServiceUri serviceUri, ListRestResources listRestResources, PutRestResource putRestResource, DeleteRestResource deleteRestResource, ILogger logger, CancellationToken cancellationToken)
at publisher.Publisher.RunWithoutCommitId(CancellationToken cancellationToken)
at publisher.Publisher.Run(CancellationToken cancellationToken)
at publisher.Publisher.ExecuteAsync(CancellationToken cancellationToken)
`
Reproduction Steps

Extract API with User Authorization from Dev Env
Publish Back to Dev Env

Publish Back to UAT Env - Fails if User Authorization hasn't been preconfigured

@UniperMaster - ApiOps currently doesn't support authorization servers, so they will need to be pre-created another way (through Bicep, Terraform, etc). Closing, as we're tracking this in #235.


.NET API browser: sort order makes no sense

When searching for an API in the .NET API Browser, results come out in a very odd and unproductive order. For example, searching for Dictionary yields:
Java.Util.Dictionary
Foundation.DictionaryContainer
System.Collections.DictionaryBase
System.Collections.DictionaryEntry
ExchangeWebServices.DictionaryURIType
Microsoft.Office.Interop.Word.Dictionary
System.Configuration.DictionarySectionHandler
System.Web.Mvc.DictionaryValueProvider<TValue>
System.Collections.Generic.Dictionary<TKey,TValue>

The typical class being searched for - System.Collections.Generic.Dictionary - is in 9th place, after some explicitly obsolete types (Java.Util.Dictionary) and some extremely specific rare ones (ExchangeWebServices.DictionaryURIType).
A simple scheme, such as showing certain prefixes above others (e.g. System), would probably improve the situation considerably. Pushing obsolete results down (and marking them visually) would also help, etc.

@rloutlaw Can you please take a look at this issue?

Tagging @mimisasouvanh as well

We are tracking this internally. https://github.com/MicrosoftDocs/feedback/issues/224

@mimisasouvanh feel free to close this if #224 already tracks the problem and this issue brings no extra value.

@roji Thanks Shay! Unfortunately, I don't have the proper permission level to close this issue.


feat(remix-dev): add serverEntryFile config option

Currently if a dev wants to extend the configuration of Remix App Server, they
must eject from RAS to the Express adapter. This PR adds a new config option
serverEntryFile that specifies the file that will be used by RAS instead of
its default configuration. If the file is TypeScript, it will be transpiled
automatically.
// remix.config.js
module.exports = {
  serverEntryFile: './server.ts'
}

Running npm run dev will launch Remix App Server and import the server file.
For production builds, the dev should update the start script to specify the
server file for remix-serve. NOTE: If the server file is TypeScript, this must
be transpiled manually during the build process.
"build": "remix build && npm run build:server",
"build:server": "esbuild --format=cjs --platform=node --outfile=build/server.js server.ts",
"start": "remix-serve build build/server.js",

The server file should export the following functions:
// REQUIRED: create the Express app and return it
export function createApp(
  buildPath: string,
  mode = "production",
  publicPath = "/build/",
  assetsBuildDirectory = "public/build/"
): Express

// OPTIONAL: create an HTTP/HTTPS server and return it
function createServer(app: Express, port: number): Server

// OPTIONAL: create a WebSocket server and return it
function createSocketServer(port: number): WebSocket.Server

Here's a sample server file that includes all the exports.
https://github.com/kiliman/remix-ras-server-example/blob/main/server.ts

Aside from the readConfig test, I haven't added or modified any tests. I'm not really sure the best approach to testing this as it requires verifying remix dev, remix watch and remix-serve is processing the server file correctly.
Please advise.

@remix-run/dev has a config.ts file which expose a server property, which one can use to define a server entry point
frankly I haven't used the aforementioned server property but I did recall seeing @mcansh using it in here in this the examples folder of his `remix-fastify repo
@kiliman - is there an overlap with your new serverEntryFile config property and the server config property defined here?

Yes there is a difference. The server option compiles your server file AND bundles it with your app build (including node_modules) into a single file.
The new option is just an extension of Remix App Server. I suppose I could have added an argument to remix dev instead.

@kiliman - do you have any recommendations on how to test this change out?
I'd love to provide feedback and trial out the API and report my findings back in this thread

@cliffordfajardo I created a sample showing how to use a custom server file for RAS. It uses SSL and includes getLoadContext function.
https://github.com/kiliman/remix-ras-server-example

It might be nice to show how consumers can use this to get the default @remix-run/serve server plus extra middleware:
// server/index.ts
import { createApp } from '@remix-run/serve'
import express from 'express'
import path from 'path'
import myCustomMiddleware from './myCustomMiddleware'

const app = express()
app.use(myCustomerMiddleware)
app.use(createApp(path.join(process.cwd(), 'build'));
export default app

That way, if folks follow the docs, they'll still be as close to @remix-run/serve as possible. They can always customize further if they want.

@jamesarosen That's basically what this PR does. The issue is that the current Remix App Server doesn't expose the Express server, nor provide a way to override it.
This PR provides that extension point.

That's basically what this PR does

I understood. I wasn't clear, but I was saying the docs should prefer importing the default server and extending it:
import { createApp } from '@remix-run/serve'
…
app.use(myCustomMiddleware)
app.use(createApp(…))

over replacing it altogether:
const { createRequestHandler } = require("@remix-run/express");
…
app.use(compression())
app.disable("x-powered-by")
app.use("/build", express.static("public/build", { immutable: true, maxAge: "1y" }))
app.use(express.static("public", { maxAge: "1h" }))
app.use(morgan("tiny"))
app.all(createRequestHandler(…))

That way, people who follow the docs will get the benefit of the default createApp with its caching, logging, and any new features the community adds over time.

Ah, I think I see. So you're saying that in addition to my PR, make the default createApp an export so it can be used and extended in the server.ts file.
I agree. Sometimes you only want to make a simple change to the default, so may not want to write it from scratch (even if it is boilerplate).
My only concern is that Express app configuration is order dependent, so that my have unintended consequences, especially if the default is a black box.

make the default createApp an export so it can be used and extended in the server.ts file.
Exactly!

My only concern is that Express app configuration is order dependent, so that my have unintended consequences, especially if the default is a black box.

There are definitely pros and cons to both approaches. I don't think there's a clear winner. I spent a lot of time in the Ember community, which places a lot of value on preferring the framework, but offering a series of escalating escape hatches. In this case, that series would be

use @remix-run/serve. A basic Remix-friendly HTTP server with TypeScript and live-reloading.
serverEntryFile with createApp(). Add features to the basic server. Opt in to updates from the community.
serverEntryFile with custom createRequestHandler(). You still get TypeScript and live-reloading, but opt out of updates from the community.
server (I think; I'm not actually sure why someone would use this if serverEntryFile exists)
replace @remix-run/serve with node myServer.js. Totally custom. No TypeScript or live-reloading unless you build it (e.g. with tsc and nodemon)

server is for hosts that don't allow you to run npm i for node_modules. This way you bundle everything and copy a single file to your host. Probably pretty rare considering how many providers there are.

This change is exactly what I needed within Remix, I have lightly modified my express config but am now stuck using nodemon/tsc as described above. Using the framework in this case with an extended server.{t|j}s file would be such an benefit. Thanks for the hard work! Is there a timeline of when this would be merged into the core codebase?

@kiliman I think we can close this as we now have entryServerFilePath config option since @mcansh's #4600?

I think we can close this as we now have entryServerFilePath config option since @mcansh's #4600?

thats on the resolved config for entry.server

Oh yeah I missed that it's not in the user's config, but the resolved config 🙈

Yeah, I haven't been keeping this updated with the latest, as so many changes were happening with the new dev server.

Hi @kiliman!
Are you still interested in getting this one merged?
If so, please rebase onto latest dev & resolve conflicts

Hmm.. not sure. I think the new unstable_dev feature obviates the need for some of the items in this PR. I personally don't use it. I'll close it for now. I'll reconsider if somebody wants me to update it to the latest version.


Configure Aspire Dashboard with key-per-file configuration provider

Hi 👋🏻
Disclaimer: Since my issue is more a feature request than an API change, I decided not to use one of the predefined templates, but I'm happy to provide any further information you need.
I'm running the Aspire Dashboard as a standalone app via Docker which works nicely 👌🏻 this is my current docker-compose.yml:
services:
  aspire-dashboard:
    image: mcr.microsoft.com/dotnet/aspire-dashboard
    container_name: aspire-dashboard
    ports:
      - 4317:18889
      - 18888:18888
    environment:
      - Dashboard__Frontend__BrowserToken=Tralala

You immediately see the flaw: it contains the browser token as cleartext. Especially since I put my docker-compose.yml files under version control, that's not really great.
For my other .NET apps, I'm using the key-per-file configuration provider which would allow the following setting:
services:
  aspire-dashboard:
    image: mcr.microsoft.com/dotnet/aspire-dashboard
    container_name: aspire-dashboard
    ports:
      - 4317:18889
      - 18888:18888
    secrets:
      - Dashboard__Frontend__BrowserToken
secrets:
  Dashboard__Frontend__BrowserToken:
    file: Dashboard__Frontend__BrowserToken.txt

This way, I could easily put my docker-compose.yml under version control.
After a quick and non-comprehensive look, I think this might be implemented by adding the following lines here:
if (!string.IsNullOrEmpty(builder.Configuration[DashboardConfigNames.SecretsPath]))
{
    builder.Configuration.AddKeyPerFile(directoryPath: builder.Configuration[DashboardConfigNames.SecretsPath], optional: false);
}

With this change, the final docker-compose.yml could look like this:
services:
  aspire-dashboard:
    image: mcr.microsoft.com/dotnet/aspire-dashboard
    container_name: aspire-dashboard
    ports:
      - 4317:18889
      - 18888:18888
    environment:
      - Dashboard__SecretsPath=/run/secrets
    secrets:
      - Dashboard__Frontend__BrowserToken
secrets:
  Dashboard__Frontend__BrowserToken:
    file: Dashboard__Frontend__BrowserToken.txt

If you'd consider this a useful feature, I'm happy to provide a PR.

Fixed in #4526.


Fixed Warnings in React 0.14

Deprecation errors should no longer occur in the example or other projects. Added react-addons-update as a dep.

Thanks! Released v2.2.0

@jerairrest What does that mean? How to use the information you provided to get rig of the warning?
I have in my node_modules:
react "version": "0.14.7"
react-addons-create-fragment "0.14.7"
react-addons-css-transition-group "0.14.7"
react-addons-pure-render-mixin "0.14.7"
react-addons-transition-group "0.14.7"
react-addons-update "0.14.7"
And I still get this warning in Chrome Console
Warning: require('react/addons') is deprecated. Access using require('react-addons-{addon}') instead.
For me the question remains. What does that warning mean and how to get rid of it?
I do not use require('react/addons') anywhere in my code. I only use require('react').
However I use webpack to build my React components and have 'react/addons' in vendor bundle in webpacks config. But I repeat I do not require('react/addons') anywhere in my code, only require('react'). And if I remove 'react/addons' from webpack config and have only react instead, and build my app with that webpack configuration, no warning is thrown.

It could be that another dependency is still using 'react/addons' can you post all your dependencies?


Add support for comma-separated coordinates in tpll command

Maybe makes using the command a little easier :).

This would be really useful when copying coordinates directly from google maps


go install: serving stale code from main branch

What version of Go are you using (go version)?

$ go version
go version go1.18.1 darwin/amd64

Does this issue reproduce with the latest release?
Not sure. It's hard to reproduce once it's working again. I'd assume it's still a problem.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/m/Library/Caches/go-build"
GOENV="/Users/m/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/m/dev/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/m/dev"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.18.1"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/m/dev/src/github.com/matthewmueller/hack/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/4f/tcxcr6_55v9bp38d8g4hjlf80000gn/T/go-build3367796448=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

I tried locally running:
go install github.com/livebud/bud@main

Shortly after publishing to main (maybe 3-5 minutes) because of a failure in CI.
What did you expect to see?
I expected it to go out to Github, download the latest code from the main branch and install it.
What did you see instead?
I saw it succeed and serve stale code. This also appears to be what happened in CI too. I was able to trigger a refresh by running the following:
GOPRIVATE=* go install github.com/livebud/bud@main

However, this isn't intuitive because bud is a public repository.
The core of this issue may be related to https://github.com/golang/go/issues/42809, though when I tried GONOSUMDB=* go install github.com/livebud/bud@main, it still served stale code. Maybe because it was cached locally?

I expected it to go out to Github, download the latest code from the main branch and install it.

In your go env the GOPROXY value is set to "https://proxy.golang.org,direct". That configuration means it first tries the Go module mirror (not GitHub), and falls back to direct only if the module mirror reports 404/410. See the first entry in the FAQ of https://proxy.golang.org/ for information about timing and caching of newly committed versions.

Thanks for the fast reply @dmitshur!

In order to improve our services' caching and serving latencies, new versions may not show up right away.

It sounds like it's working as expected, though I'd argue it's a poor user experience. It seems like the Go Proxy is trying to save on a request to Github for branches. This is unexpected when you compare it to other package managers like NPM.
Personally, I expect a proxy to be transparent, something I don't really need to think about. This design decision requires me to consider it. It's also not the first place you think to look.
Questions that came up while I was trying to figure this out:

"Did I forget to push up to Github?"
"Should I be using @latest perhaps?"
"Is there something weird with my module cache? go install is finishing rather quickly... did it even check Github?"

Feel free to close if this decision is set in stone at this point, I think I'll be aware of this next time around. My hope is that Go Modules can reach the UX of NPM or Homebrew while still delivering on the promises of reproducible builds.

Duplicate of #38065


South Korea -> Korea Republic

On the Fifa web site the team is Korea Republic, not South Korea.
Not that it matters that much. I compare your json with my own database and found that small difference

Well, thats a hard one haha.
https://www.wikiwand.com/en/2018_FIFA_World_Cup#/Group_F
on Google "live coverage" its also South Korea

I will keep South Korea, as it seems that this is the most used

No worries. Like i said. It doesn't matter that much. Just thought i should mention this. To do online searches i also use South Korea and Korea Republic as "display name"


fixed test case: tuple_arguments.swift for s390x

Fixed test case: tuple_arguments.swift, the root reason is that there are invalid chars in the results of getTupleNames and tupleRepr->getElementName, solved it by introducing a std::string varible.
Note: the master branch changed this part code and no errors found. The fixing is applied to only  this 4.0 branch.

I can’t find the corresponding commit to master for this change. Please start there and cherry-pick to 4.0.

@samding01 You can avoid the issue that Robert is talking about by fixing on master and cherry-picking using the -x parameter for git-cherry-pick. This will place the original commit on master in the review message. It is useful.

git cherry-picked  two commits from the master branch and solved the problems.
Test case tuple_arguments.swift passed.

Can this PR be reviewed?

@swift-ci Please smoke test

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 376e288a4a8139416dddcc33f7b89aba972ab729

Build failed
Swift Test OS X Platform
Git Sha - 376e288a4a8139416dddcc33f7b89aba972ab729

Can this PR be merged?

Can this PR be merged?

@samding01 Sorry for the delay. Merging into the 4.0 branch requires top-level approval. I've pinged Ted for an update.

Got the go-ahead to merge.


Rename easytree.list and easytree.dict

The classes of easytree.list and easytree.dict shadows the built-in functions of list and dict. This can pose a problem such as the example below where one cannot use the built-in list or dict anymore when using import-from statements.
from easytree import list, dict

# need to make an easytree list and dict
a = list()
b = dict()

print(type(a), type(b)) # <class 'easytree.types.list'> <class 'easytree.types.dict'>

# now need to make a regular list and dict
c = list()
d = dict()

print(type(c), type(d)) # <class 'easytree.types.list'> <class 'easytree.types.dict'>
# ^ needed default list and dict, not easytree's

To fix this, one possible solution is to capitalize the class names to easytree.List and easytree.Dict. However, this would then intefere with the typing module's List and Dict, if that's worth considering.
One other possible solution is to rename them to easytree.EasyList or easytree.EasyDict or some other variation.

This is intentional and ultimately a design choice.
My recommendation is simply to import easytree (optionally renaming to a shorter name, if reducing verbosity is the intention) and to prefix dict and list instantiation.
import easytree

data = easytree.dict()

friends = easytree.list()

Importing objects from a package is an antipattern in my view, as it obfuscates the use of third-party libraries in source code.
This is same reason we generally import pandas as pd rather than from pandas import DataFrame, Series


Feature/jdk9

Coverage increased (+3.4%) to 78.491% when pulling 449f7fbe6c9840f674e049f696ae46a00e81b258 on feature/jdk9 into a5c85480c27ddf8babb2f18ddb0a32808baa1b3b on master.


potential fix for servers not stopping and the shutdown command getti…

…ng timed out. With the change the hangs got resolved
Pls refer to bug
SNAP-2252
With the change the stop all command is now executing successfully.
Though I am not sure its worth spending time to find out from where this launcher thread which is stopping the server connector thread ,  is getting a spurious interrupt flag set on it , causing join to get interrupted. If you have any clue let me know or I will spend time to find out where it is, in case it needs to be probed further
Patch testing
(Fill in the details about how this patch was tested)
ReleaseNotes changes
(Does this change require an entry in ReleaseNotes? If yes, has it been added to it?)
Other PRs
(Does this change require changes in other projects- snappydata, spark, spark-jobserver, aqp? Add the links of PR of the other subprojects that are related to this change)

@ahshahid Could you please explain what is actually happening?
What we had observed was that this vm was not replying to other VM in cluster and all other vms were stuck waiting for reply and not proceeding for shut-down.
Just want to make sure we are fixing that issue as well.

Well, I actually did not analyze which VMs were stuck  on which one or analyzed in detail.
From the code used in stopping the server , the only place which looked problematic was the join call throwing exception & that could explain every thing so I took a chance of try catching it & it solved the issue for me.
The cachserver starter process creates a serverConnector thread which is the thread  which is responsible for the server functioning. while the main thread loops periodically checking if a shutdown is issued or not ( by reading the status  from a file).
Meanwhile the process of stopping the nodes, changes the status in file to sort of initiate shutdown & then loops to check if the status has changed to sort of shutdown done or not else timing out after some time if not done.
When the main thread ( which launched the serverConnector), reads the status as initiate shutdown, it interuupts the serverConnector thread , disconnects the InternalDistributedSystem & writes the status in the file to Shutdown done.
But if for some reason the main launcher thread in the join gets an exception, that main thread will exit without issuing shutdown or changing the status in file.
As a result the thread which was polling for status change will timeout.
I will see if I can find out from where the main server launcher thread gets an interrupt such that join throws exception.  That would be the idea fix.
But ignoring the InterruptedException in join will also fix the issue.

bump.
pls update..

I think the possible place of  the server launcher thread to get an Interrupt set on it is in CacheServerLauncher line # 783.  In the call to readStatus, in certain situation, interrupt is set on the current thread which will cause subsequent join to throw InterruptedException.

@suranjan , @sumwale , @kneeraj  , any further comments?

Do we need to set the interrupt flag again in catch block?
Looks good to me otherwise.

setting interrupt back in try catch is a good practice :-). may be in this
case the cause of trouble. I think we can leave that untouched & just
ignoring the exception  in main loop should suffice.
Regards
Asif
On Wed, Apr 11, 2018 at 5:30 AM, suranjan kumar<EMAIL_ADDRESS>wrote:

Do we need to set the interrupt flag again in catch block?
Looks good to me otherwise.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SnappyDataInc/snappy-store/pull/382#issuecomment-380434482,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AL1zaAznsqxRlhSgXTza6jF0xIVA5WnAks5tnfdlgaJpZM4TJWBm
.


enableFlexibleCasting but just for scalars

we would want to have type juggling from e.g. numeric-strings into int; same for float from string (just like regular php cast rules).
we found the enableFlexibleCasting to achieve it,
$flexibleMapper = (new \CuyZ\Valinor\MapperBuilder())
    ->enableFlexibleCasting()
    ->mapper();

$flexibleMapper->map('int', '42');
// => 42

but it also enables some kind of list<->array juggling, which we would not want:
$flexibleMapper->map('list<int>', ['foo' => 42, 'bar' => 1337]);
// => [0 => 42, 1 => 1338]

is there a supported way to only enable type juggling for scalars? or some kind of api we should use?
our use-case: we want to convert from $_GET or $_POST which is always string and need to map it into objects which e.g. expect int.
it seems valinor is already able so we can easily define per class how data needs to be mapped to said class, but it seems to miss some kind of "general conversion" building blocks for scalar types only.

Hi @staabm, thanks for the report. For now it is not possible to distinguish the scalar casting from the other cases. I definitely see the value in your usecase and will be thinking about how to extend the current API.


Inaccurate information

[After some testing- the document statement that 'Team Owners can see the names of all private channels' is FALSE. ]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ce34b12b-aa50-608b-bbfa-a1fb4bb79f8d
Version Independent ID: 9ddeb6f4-f30a-1e72-fc94-ae66def91f40
Content: Private channels in Microsoft Teams - Microsoft Teams
Content Source: Teams/private-channels.md
Service: msteams
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

Hello @cowens16
How are you? Hope you are doing good.
I tested this, the owner, not part of the private channel, can see it by going to Team Settings - Channels.
Thanks


charles: 4.2.8 -> 4.6.1

Motivation for this change
upstream changelog

Note that as of 4.5, charles 4 now requires jdk11, and also has a different download path. I've updated that such that charles 3 will still build. (I did also test jdk11 with charles 3 to see if that was functional, but it doesn't appear to be)
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 117939 at 5bbadc0d run on x86_64-linux 1

1 package built successfully:

charles (charles4)

2 suggestions:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/networking/charles/default.nix:34:7:
   |
34 |       installPhase = ''
   |       ^

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/networking/charles/default.nix:34:7:
   |
34 |       installPhase = ''
   |       ^

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 117939 run on x86_64-linux 1

1 package built:

charles (charles4)


Reload Project leaking NodejsProjectNode

Repo

Create simple new Express 4 app.
Take memory snapshot.
Unload the project.
Reload the project.
Take another snapshot

Expected
Only a single NodejsProjectNodes should be loaded since this is a fairly heavy object (not directly, but in what it owns).
Actual
Two copies of the NodejsProjectNode now exist. Repeat to create more instance.

One potential cycle:
NodeProjectNode -> NpmController -> FileSystemWatcher -> NpmController -> NodeProjectNode where FileSystemWatcher is never released.

This doesn't seem to be a problem anymore


Performance improvements

This is an issue to track the different tests to improve performance.
Starting from 176.23 seconds to run over 916 meteo time-steps.

[ ] cache the node traversal, don't forget to add the node to the cache when created
[ ] Use an immutable MTG
[ ] use only one time-step (a status?) for the simulation, and extract only the variables that we need at the end of the day ?
[ ] Use pointers when giving values from other scales
[ ] Use @inline for functions that are called a lot
[ ] Use @simd for loops that can be vectorized
[ ] don't enter the functions when the organ is dead (harvested / senescent). To do so, we could update the status of the organ in the type of organ in the node, and add a dispatch method on nodes that are e.g. harvested

Down to 15s after these modifications in https://github.com/VEZY/MultiScaleTreeGraph.jl/issues/46

See this PR for following modifications: #3

This is closed after merging #3


new approach to uploading files

this is needed due to problems encountered in https://github.com/superphy/backend/issues/159

I'm thinking we might add user accounts https://github.com/superphy/backend/issues/131 which are just captcha clicks and have the backend request an api key from minio to store files to. also trip jobs once uploads are done (this will likely be handled via a second POST from the front-end)


Error: Cannot find module 'axios'

During a pipeline, I'm running the following commands
cd fr-config-manager/
npm install --ws
cd packages/fr-config-pull
npm link
...
fr-config-pull

But this is giving me
found 0 vulnerabilities
[2024-11-08T10:09:15.320Z] node:internal/modules/cjs/loader:1143
[2024-11-08T10:09:15.321Z]   throw err;
[2024-11-08T10:09:15.321Z]   ^

[2024-11-08T10:09:15.321Z] Error: Cannot find module 'axios'
[2024-11-08T10:09:15.321Z] Require stack:
[2024-11-08T10:09:15.321Z] - /codefresh/volume/fr-config-manager/packages/fr-config-common/src/authenticate.js
[2024-11-08T10:09:15.321Z] - /codefresh/volume/fr-config-manager/packages/fr-config-pull/src/index.js
[2024-11-08T10:09:15.321Z]     at Module._resolveFilename (node:internal/modules/cjs/loader:1140:15)
[2024-11-08T10:09:15.321Z]     at Module._load (node:internal/modules/cjs/loader:981:27)
[2024-11-08T10:09:15.321Z]     at Module.require (node:internal/modules/cjs/loader:1231:19)
[2024-11-08T10:09:15.321Z]     at require (node:internal/modules/helpers:177:18)
[2024-11-08T10:09:15.321Z]     at Object.<anonymous> (/codefresh/volume/fr-config-manager/packages/fr-config-common/src/authenticate.js:1:15)
[2024-11-08T10:09:15.321Z]     at Module._compile (node:internal/modules/cjs/loader:1364:14)
[2024-11-08T10:09:15.321Z]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
[2024-11-08T10:09:15.321Z]     at Module.load (node:internal/modules/cjs/loader:1203:32)
[2024-11-08T10:09:15.321Z]     at Module._load (node:internal/modules/cjs/loader:1019:12)
[2024-11-08T10:09:15.321Z]     at Module.require (node:internal/modules/cjs/loader:1231:19) {
[2024-11-08T10:09:15.321Z]   code: 'MODULE_NOT_FOUND',
[2024-11-08T10:09:15.321Z]   requireStack: [
[2024-11-08T10:09:15.321Z]     '/codefresh/volume/fr-config-manager/packages/fr-config-common/src/authenticate.js',
[2024-11-08T10:09:15.321Z]     '/codefresh/volume/fr-config-manager/packages/fr-config-pull/src/index.js'
[2024-11-08T10:09:15.321Z]   ]
[2024-11-08T10:09:15.321Z] }

[2024-11-08T10:09:15.321Z] Node.js v18.20.4

The dependencies have been centralised in the base package.json - please can you try linking from the repo base as per README at https://github.com/ForgeRock/fr-config-manager?tab=readme-ov-file#installing-from-source.

Morning, sorry should have closed this issue last week, as per the docs in your link, using
npm i -g @forgerock/fr-config-manager
Has sorted the issue


can i uninstall i need answers fast HELP!

Etcher version: ???
Operating system and architecture:
Image flashed:  retro pie
Do you see any meaningful error information in the DevTools?
it wont let me uninstall because there is no uninstall

Its hard to offer you help if we don't know the operating system you're running. In can any case, Etcher can be uninstalled with the standard uninstall method of your OS of choice.

thank you
I was putting in a retro pie on my rpi 3
and I couldn't fix it so I formated it because it was stuck in a boot loop.
just for future reference do you know where the uninstall button is
I don't know

and also when I download etcher it works then If I close it I searched my whole computer and I cant find etcher

I'm sorry but I can't help if without knowing the operating system that your laptop/computer where you have Etcher is running. In any case, the uninstall method is the standard one from your OS. i.e. if you have Windows, then you can uninstall Etcher from the Apps menu in the Settings application.

@Whoeverhitme are you asking about how to uninstall Etcher, or how to uninstall what you flashed onto the SD-card?

Closing this due to lack of response; @Whoeverhitme feel free to re-open if you come back to this


Design updates to terminal

White on black
14px font size
monospace font
Set defaults in widget, don't override in plugin

Yeah, first PR!

Do you think maybe the white-on-black should match the lab theme (i.e., dark theme -> white on black, light theme -> black on white)?
Thanks also for adjusting the size. It's been really small for me.

I am really torn on which should be the default. Originally, I was opposed
to the white on black terminal of the existing notebook as it didn't match
the rest of the visual design. However, one of the most important ideas in
usability is the idea of "prototypicality" - it basically amounts to asking
the question "how are users used to that entity being presented and styled?"
Even though many systems now have black on white terminals by default, I do
think that many users feel that a white on black terminal is more
prototypical. The other point is that if we use a black on white theme, the
following plugins all start to look almost identical:

Text editor
Console
Terminal

Using the white on black them for the terminal makes it very clear that it
is different. I propose we live with the white on black for a bit and see
how we feel about it - more than willing to change it back.
On Thu, Jun 9, 2016 at 6:46 PM, Jason Grout<EMAIL_ADDRESS>wrote:

Do you think maybe the white-on-black should match the lab theme (i.e.,
dark theme -> white on black, light theme -> black on white)?
Thanks also for adjusting the size. It's been really small for me.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/jupyter/jupyterlab/pull/26#issuecomment-225074418,
or mute the thread
https://github.com/notifications/unsubscribe/AABr0PJBv2ItXKToMqX9RgCKi055ALxpks5qKMHagaJpZM4Iyggr
.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Also, I think we need to have commands for the terminal plugin that:

Black/white to white/black and back
Increase font size
Decrease font size

To do that well, we will need to track all the terminal widgets and even
have an active terminal notion. Wondering if we should have a "tracking
factory" that we can use across the different plugins for this.
On Thu, Jun 9, 2016 at 9:22 PM, Brian Granger<EMAIL_ADDRESS>wrote:

I am really torn on which should be the default. Originally, I was opposed
to the white on black terminal of the existing notebook as it didn't match
the rest of the visual design. However, one of the most important ideas in
usability is the idea of "prototypicality" - it basically amounts to asking
the question "how are users used to that entity being presented and styled?"
Even though many systems now have black on white terminals by default, I
do think that many users feel that a white on black terminal is more
prototypical. The other point is that if we use a black on white theme, the
following plugins all start to look almost identical:

Text editor
Console
Terminal

Using the white on black them for the terminal makes it very clear that it
is different. I propose we live with the white on black for a bit and see
how we feel about it - more than willing to change it back.
On Thu, Jun 9, 2016 at 6:46 PM, Jason Grout<EMAIL_ADDRESS>wrote:

Do you think maybe the white-on-black should match the lab theme (i.e.,
dark theme -> white on black, light theme -> black on white)?
Thanks also for adjusting the size. It's been really small for me.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/jupyter/jupyterlab/pull/26#issuecomment-225074418,
or mute the thread
https://github.com/notifications/unsubscribe/AABr0PJBv2ItXKToMqX9RgCKi055ALxpks5qKMHagaJpZM4Iyggr
.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>
--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>


If the wavesurfer container has a very large width, only one canvas will be rendered.

I replicated this on a forked version of wavesurfer where I ran npm run start to start the local examples.
If the body, i.e., the wavesurfer's container, is given a very large width (e.g., 70000px), then the wavesurfer will only create one single canvas that is 70000px large. The expected behavior is that is creates lots of smaller canvases, such as 70 1000px canvases.
It also seems that this bug replicates when fillParent is both true and false.
I am currently fixing this on my fork and could contribute to wavesurfer by providing some code when I figure out what the fix might be.

EDIT: I noticed that this also replicated when I passed in a very large width in the wavesurfer options. The conditions in which the renderer will make only one canvas are a bit tricky to pinpoint.

Looking at the code it should always cap a single canvas width to 4K px max.
https://github.com/katspaugh/wavesurfer.js/blob/main/src/renderer.ts#L544
So if the total visible width is 7k, it should create 2 canvases. Not sure why it’s not doing that.

@katspaugh PR incoming: https://github.com/katspaugh/wavesurfer.js/pull/3685
I think this fixes the issue. However, I don't know how to run the e2e tests, and I'm not familiar with the code so there might be a better solution.

Thank you! 🙏
I’ve released v7.7.12 with your fix.


Fix os compatibility error

Resolves https://github.com/node-on-mobile/node-on-android/issues/15
This PR resolves an issue of naming collision that shows the error More than one file was found with OS independent path 'lib/arm64-v8a/libc++_shared.so' and upgrade the gradle wrapper and the target SDK to make the project work out of the box

👍 Sure! Happy to help and contribute.


Add activity to pick out the region to download for offline

Similar to how Google Maps gives you a mapview and a bounding box to pick a region to download, we can also include a similar activity which can be launched and allows users to download regions.

https://github.com/mapbox/mapbox-plugins-android/pull/329 closes this.


Server doesn't stop correctly

Minestom server doesn't stop correctly when using MinecraftServer#stopCleanly. Server's threads are still running.
I recorded a video showing the issue:
https://www.youtube.com/watch?v=QJkS8tqTKpA

I noticed that it happens only when at least one connection with player was made

We have exactly the same problem


chore(test): Test CLA add in

I have read the CLA Document and I hereby sign the CLA

Closing, test successful


feat(material/slide-toggle): Add disabled predicate to MatSlideToggleHarness

Add disabled predicate to MatSlideToggleHarness

Good addition, just needs a few small things:

Make a similar change to the mdc-based harness (they're separate implementations)

DONE

Add a unit test to slide-toggle-harness.spec.ts (we have separate component tests and component harness tests)

DONE

Run yarn approve-api slide-toggle to update the public API gold

DONE, .. I think?. This didn't appear to do anything interesting.
$ yarn approve-api slide-toggle
yarn run v1.22.17
$ node ./scripts/approve-api-golden.js slide-toggle
$ /Users/richieforeman/Documents/GitHub/components/node_modules/.bin/bazel run //tools/public_api_guard:material/slide-toggle.md_api.accept
Loading:
Loading: 0 packages loaded
DEBUG: /private/var/tmp/_bazel_richieforeman/ea52ae005abb2f90f3e4bcafc72866b6/external/build_bazel_rules_nodejs/index.bzl:122:10: WARNING: check_rules_nodejs_version has been removed. This is a no-op, please remove the call.
DEBUG: /private/var/tmp/_bazel_richieforeman/ea52ae005abb2f90f3e4bcafc72866b6/external/build_bazel_rules_nodejs/index.bzl:73:14: yarn_install#yarn attribute not set and no repository named 'yarn' exists; installing default yarn
Analyzing: target //tools/public_api_guard:material/slide-toggle.md_api.accept (0 packages loaded, 0 targets configured)
INFO: Analyzed target //tools/public_api_guard:material/slide-toggle.md_api.accept (1 packages loaded, 34 targets configured).
INFO: Found 1 target...
[0 / 4] [Prepa] BazelWorkspaceStatusAction stable-status.txt
Target //tools/public_api_guard:material/slide-toggle.md_api.accept up-to-date:
  /private/var/tmp/_bazel_richieforeman/ea52ae005abb2f90f3e4bcafc72866b6/execroot/angular_material/bazel-out/darwin-fastbuild/bin/tools/public_api_guard/material/slide-toggle.md_api.accept.sh
  /private/var/tmp/_bazel_richieforeman/ea52ae005abb2f90f3e4bcafc72866b6/execroot/angular_material/bazel-out/darwin-fastbuild/bin/tools/public_api_guard/material/slide-toggle.md_api.accept_loader.js
  /private/var/tmp/_bazel_richieforeman/ea52ae005abb2f90f3e4bcafc72866b6/execroot/angular_material/bazel-out/darwin-fastbuild/bin/tools/public_api_guard/material/slide-toggle.md_api.accept_require_patch.js
INFO: Elapsed time: 0.990s, Critical Path: 0.06s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
INFO: Running command line: /private/var/tmp/_bazel_richieforeman/ea52ae005abb2f90f3e4bcafc72866b6/execroot/angular_material/bazel-out/darwin-fastbuild/bin/tools/public_api_guard/material/slide-toggle.md_api.accept.sh
INFO: Build completed successfully, 1 total action
Analysis will use the bundled TypeScript version 4.5.5
*** The target project appears to use TypeScript 4.6.3 which is newer than the bundled compiler engine; consider upgrading API Extractor.
✨  Done in 5.06s.


Reorganize Time and FixedTimestep and add runtime step rate control

This PR centralizes most time-related things under the Time resource, revises how users interact with FixedTimestep, and implements step rate control.
I opted to put the new fields in Time because I think having those consolidated in one resource will be more familiar to newcomers and just more convenient. The timestep accumulator can just do its thing in the background.
I removed the FixedTimesteps resource (HashMap<String, FixedTimestepState>) in favor of having just one. This might be controversial for some people, but it's the correct "avoid user footguns" course of action (see below).
Setting the step rate isn't as ergonomic as before but it's still pretty easy to do.
Changes:

Added Time::fixed_delta() and Time::set_steps_per_second(steps: f32)
Added Time::relative_speed() and Time::set_relative_speed(relative_speed: f32)
Renamed Time::time_since_startup to Time::elapsed_since_startup
Time::delta and Time::elapsed_since_startup are now influenced by changes to Time::relative_speed.
Added Time::raw_delta() and Time::raw_elapsed_since_startup(), which aren't.
FixedTimestepState now only tracks accumulated time and steps.
There is now only one FixedTimestepState resource. (see below)
The built-in run criteria is now just FixedTimestep::step.

Why only one built-in fixed timestep?
A fixed timestep is an isolated, framerate-independent context for running systems. It can't really serve as a general per-system rate limiter. It's a stage-level concept. Having more than one in the same schedule is a misuse with some subtle side effects.
If you have two of these contexts, their steps will not run in a consistent order. E.g. if you have a 60Hz context (A) and a 30Hz context (B), you'd probably expect them to run like this:
A AB A AB A AB...
And that would normally be the case. But if the game hangs for a moment, suddenly A and B will have several steps queued, and then the order of their steps changes while they catch up.
AAAAAA...BBBBBB...  (or BBBBBB...AAAAAA...)
One long frame might be enough to cause really subtle bugs. The one and only time it's safe to use multiple contexts is when the contained systems are independent (in every sense). In that case, you probably wouldn't care what order they run in.
Still, what all users should be encouraged to do instead is use one high frequency context as a base and then, inside of it, derive lower frequencies using counters (#2683). A 10Hz step rate and a counter could create any lower frequency (well, any multiple of 100ms). If you put these counters inside run criteria systems, this "frequency divider" combo enables per-system rate limiting, without affecting system ordering.
That all said, the API for FixedTimestepState is all pub and leaves the possibility for users to recreate the old setup by adding their own HashMap<K, FixedTimestepState> resource and systems.

I can't seem to find any accumulated time / fixed time. Is there a reason for that?

No, I just forgot. This would do it.
pub struct Time {
    /* ... */
   pub(crate) fixed_time_since_startup: Duration,
   pub(crate) fixed_delta: Duration,
   /* ... */
}

impl FixedTimestep {
    pub fn step(
        mut time: ResMut<Time>,
		mut accumulator: ResMut<FixedTimestepState>
    ) -> ShouldRun {
        if accumulator.sub_step().is_some() {
            time.fixed_time_since_startup += time.fixed_delta;
            ShouldRun::YesAndCheckAgain
        } else {
            ShouldRun::No
        }
    }
}

Assuming "fixed delta" is constant, "fixed time since startup" would normally be equivalent to the total number of steps multiplied by time.fixed_delta(). tbh, maybe FixedTimestepState should just be part of the Time struct.

Can we add time()?

That's time.time_since_startup(). It's the accumulated time since startup, equivalent to Unity's Time.time.
Btw, time_since_startup() and fixed_time_since_startup() aren't strictly decoupled. They both derive from delta(). The former just adds it directly while the latter accumulates them to update in discrete increments. Just want to make sure that's clear.

Okay, I made edits to the fn comments, got rid of the "live" getters for the raw, unscaled time, and added a field to track the "current time" of the fixed loop.
Now I'm wondering if separating the fixed stuff into a FixedTime resource might be better. No matter what, it'd be functionally coupled to Time (because of the accumulator), but a system using FixedTime::delta might express intent more clearly than Time::fixed_delta.
AFAIK you wouldn't need both time resources in a single system, so having that split can still have clean ergonomics. Well, UI systems that produce stuff consumed by the fixed-step logic might need both, idk. Something to think about.

Nice!
Probably FrameTimeDiagnosticsPlugin and LogDiagnosticsPlugin should use raw time?

I think splitting makes sense, especially since accessing both is a code smell. The overall clock will be the latest but the fixed clock could be arbitrarily behind depending on the situation.

Decided to go ahead and split things into a separate FixedTime resource, so this could probably use another review.
(Also I messed up merging changes from main and had to rebase. Sorry if anyone was depending on my branch.)

#4187 would move these types into a separate crate.

I'm not sure how I feel about limiting this to only one FixedTimestep. I get that this is less error prone, but I'm not sure how it would like if people wanted to have multiple steps.

What I was trying to explain above is that multiple FixedTimestep instances will always jumble steps unless your frame-rate is literally perfect.  That might be OK if the systems in each timestep are logically independent from the others, but I've never seen that.

Maybe adding an example that pretty much does what you are describing in the PR description would be enough to show how to do this.

Good suggestion! I'll try to add one (might be a while, though).

What users should do instead is make their one timestep small enough to derive any longer periods by counting.

Caveat: when two step rates are semi relatively prime, this introduces a lot of new updates.
Example:
Consider a 10Hz update (e.g. a physics fixed timestep) and a 132bpm clock (2.2Hz, a standard allegro). This gives a LCM of 110Hz (~9ms delay) clock by my math, the majority of which are just updating the counters to divide it into the two useful clocks.
A much better solution imho would be to do this automatically and interleave the multiple fixed timesteps automatically. Very roughly, rather than update each fixed timestep until its caught up, update each timestep that has the chronologically first next tick and then queue its next tick, until no ticks are queued for this frame. Handling runaway and catchup is of course an unconsidered difficulty with multiple timesteps, but also has to be solved in the manual counting solution.
I'm not an expert on timesteps, but the fixed timestep implementation is in a better position to interleave multiple fixed timesteps than implementing subdivision on top of a single timestep, because it can skip/batch all of the unused timing steps.

A much better solution imho would be to do this automatically and interleave the multiple fixed timesteps automatically. Very roughly, rather than update each fixed timestep until its caught up, update each timestep that has the chronologically first next tick and then queue its next tick, until no ticks are queued for this frame.

FixedTimestep can never give you a fixed frequency in practice (because it's subject to frame delays). That would require a dedicated thread. It's better to think of it as a "fixed integration step size" or exchange rate than an actual frequency. We queue a step for every dt, but the actual steps have almost no real periodicity. Some frames we'll run 0 steps, others we'll run 2.

Handling runaway and catchup is of course an unconsidered difficulty with multiple timesteps, but also has to be solved in the manual counting solution.

Subdivision would handle catching up automatically. It actually can't get it wrong. The counters and the systems using them would still be "wrapped inside" the base timestep, so their order wouldn't change while it loops.
For the interleaving you mention (seems similar to deficit round-robin with a priority queue) to work, we still have to carve out a single block in the schedule where all the fixed timestep stuff happens (so we can loop over it to catch up) and make it clear to users, so it's pretty much the same thing.
But, like I said, the real pacing will never be that precise, so "more precision" is not worth the extra complexity.

I'm not an expert on timesteps, but the fixed timestep implementation is in a better position to interleave multiple fixed timesteps than implementing subdivision on top of a single timestep, because it can skip/batch all of the unused timing steps.

fwiw, I'm just looking at usage:

99.9% of usage is consistent, repeatable game physics.
The major game engines have just one, and I've never seen anyone complain about being held back by it.
Developers regularly misunderstand how a fixed timestep works.
No one has come here and said, "I needed this."

Honestly, I'm tired of the yak shaving on this particular point and am firmly "scream test." Everything is pub if some users have an exotic use case requiring multiple instances, but I doubt anyone does. I don't think subdivision will be common either. I expect "tick timers" and that's about it.

To be clear: I know how a fixed time step works and how it lies bends the truth about time. I also agree that the default support being for a single fixed step is better than multiple which don't interleave.
The bpm example may've thus been a poor example, but it fits for syncing gameplay to music, even if not for coordinating talking to the audio middleware[^1].
[^1]: Completely off-topic, I'd love to see bevy integration for fmod and/or wwise. Maybe I'll tackle that...

Subdivision would handle catching up automatically. It actually can't get it wrong.

What I'm trying to say here is that if you're interleaving, there's no obviously correct way to both interleave and run with a larger step in order to facilitate catch-up. (Not just the case of running it multiple times, but when you're best effort recovering from a hitch by running a larger update.) Effectively, in order to apply a larger step, you have to break proper interleaving.

The major game engines have just one, and I've never seen anyone complain about being held back by it.

I honestly don't know how it's implemented (and even if I did, that'd be under the Unreal Source NDA), but Unreal has Quartz, whose purpose is specifically setting up gameplay event notifications on an arbitrary fixed time step, for the purpose of syncing to audio.

I expect "tick timers" for stuff like ability cooldowns and that's about it.

On my end, I'd expect ability cooldowns to be on the frame update. Overgeneralizing, fixed updates are for physics/simulation updates, frame updates are for input/rendering.
I'm sure you've seen fix your timestep. It's still relevant and definitely still hard. Basically there's no right answer, only different flavors of wrong approximation.

The bpm example may have been a poor example, but it fits for syncing gameplay to music, even if not for coordinating talking to the audio middleware.

Ah, okay. Since you had mentioned bpm, I just assumed it was headed in the direction of "let's use FixedTimestep like a metronome", which just wouldn't work. But yeah, rhythm games and other audio-sensitive mechanics probably need their "time" driven by the audio hardware. Your understanding on how we might map game time to, like, track playback position is probably way better than mine.
In that case, I think that how the fixed timestep works is pretty orthogonal to all that, since regardless of how many there are, they would all derive from Time. Even if it turns out audio engines like Quartz use this same struct internally, we should expose it as a separate type/resource so we don't blur their roles.

Overgeneralizing, fixed updates are for physics/simulation updates, frame updates are for input/rendering.

Yes, this is my rule of thumb as well.

Time scaling added by #5752. I'll add FixedTime in another PR.


Actor subclasses [Enhancement]

I was planning to overhaul the documentation for the Actor subclasses. However, this turned out to be more complex than anticipated, so that I have now run out of the time that I am able to contribute for the moment. Below hence three items:

A text dump of the documentation that I have already written.
Some general suggestions on how I would structure the documentation.
Comments on the actor subclasses code.

I hope some of these will be useful.
A actors.md draft
Objects in 3D renderings are computationally represented as sets of 3D coordinates that form dense meshes, which delineate the surface of the object. Standard neurobiological data formats, however, typically do not specify the surface of their objects directly. For example, an SWC file specifies the morphology of a neuron as a graph of segments, with each segment being represented as a truncated cone with a start point, a diameter at the start point, an end point, and a diameter at the endpoint. So while this specification clearly implies a surface, it does not contain any explicit surface information. Actors in brainrender are classes that implement this transformation, i.e. they map user-provided numerical data to vedo Mesh objects, which can then be rendered.
Available actors are:

Point(pos, name, radius, color, alpha, res): render a (anterior-posterior, dorsal-vental, medial-lateral) point coordinate as a sphere with a specified name, radius, color, opacity, and resolution. The name is a string used as a handle, when modifying the scene. A color can be a valid matplotlib or VTK color specification, which includes the standard named web colors derived from the CSS Color Module Level 3 standard, hex codes, and RGB tuples. The opacity alpha is a float between 0 and 1. The integer resolution determines the density of the created mesh. Higher densities result in smoother surfaces (but are computationally more resource intensive).

from brainrender import Scene
from brainrender.actors import Point

s = Scene()
s.add(Point((1000, 2000, 3000), radius=100, color="blue",      alpha=0.33, res=20))
s.add(Point((4000, 5000, 6000), radius=200, color="#ff0000",   alpha=0.66, res=10))
s.add(Point((7000, 8000, 9000), radius=400, color=(0, 255, 0), alpha=1.,   res=5))
s.render()

Points(data, name, colors, alpha, radius, res): convenience class to render multiple Point actors at once. The data argument is either an (N, 3) numpy array or a filepath. radius and colors (plural!) are single floats and valid color specifications, respectively, or lists thereof matching the length of the coordinate array. Due to limitations in upstream packages, however, radius and colors cannot both be sequences. Other parameter specifications are as for Point

import numpy as np
from brainrender import Scene
from brainrender.actors import Points

s = Scene()

# supported: single radius, single color
s.add(Points(np.array([[1000, 2000, 3000], [4000, 5000, 6000]]), radius=100, colors="blue"))

# supported: multiple radii, single color
s.add(Points(np.array([[1000, 2000, 3000], [4000, 5000, 6000]]), radius=[50, 100], colors="blue", alpha=1))

# supported: multiple colors, single radius
s.add(Points(np.array([[1000, 2000, 3000], [4000, 5000, 6000]]), radius=100, colors=[blue", "red"], alpha=1))

# not supported: multiple radii, multiple colors
# s.add(Points(np.array([[1000, 2000, 3000], [4000, 5000, 6000]]), radius=[50, 100], colors=["blue", "red"], alpha=1))

# supported: import coordinates from .npy file
s.add(Points("/path/to/coordinates.npy", radius=100, color="blue"))

s.render()

Line(coordinates, color, alpha, linewidth, name): render an (N, 3) numpy array of (anterior-posterior, dorsal-vental, medial-lateral) point coordinates as a line. linewidth is a float; other parameter specifications are as for Point.
import numpy as np
from brainrender import Scene
from brainrender.actors import Line

s = Scene()
s.add(Line(np.array([[1000, 2000, 3000], [4000, 5000, 6000]]), linewidth=10))
s.render()

Volume(griddata, voxel_size, cmap, min_quantile, min_value, name, as_surface): render volumetric data (e.g. gene expression) from a numpy array or from a .npy file.

Neuron(data, color, alpha, neurite_radius, soma_radius, name): render neuron morphology data from a MorphoNeuron object (e.g. instantiated with morphapi) or from a .swc file.

Streamlines

Cylinder

Ruler

General comments on the documentation
The documentation currently is a weird in-between of a reference and a tutorial, which makes it unhelpful to both audiences, experienced developers and first-time users. Its structure strongly mirrors the structure of the code. However, while it compiles an inventory of available classes and methods, it lacks sufficient detail to be a useful reference. The style is colloquial but it contains no examples and the order in which material is covered doesn't mirror a typical workflow, so it's not a particular useful tutorial either.
To address this tension, I would split the documentation in two: a reference, preferably compiled from overhauled doc-strings, and a guided tour with many, simple examples that covers the topics in the order in which a first time user needs to know about them. For the latter, I would suggest the following structure:
0. Installation

1. Instantiating a `Scene` with a reference atlas

1.1 Basic invocation
1.2 Available atlases
1.3 Highlighting brain regions

2. Adding experimental data

2.1 Registering data to the reference atlas
2.2 Adding actors to a scene
2.3 Available actors
2.4 Manipulating actors

3. Rendering & exporting

3.1 Basic invocation
3.2 Cameras
3.3 Export to PNG or HTML
3.4 Animations

4. Known issues

4.1 Notebooks
4.2 IPython

Code comments
General comments
Actor arguments are in dire need of standardisation:

argument order varies widely between actors

most variables have proper names but some don't (res, s)

some actors have a res parameter even though probably most could/should

there are subtle naming differences and inconsistencies:
Point has the color argument, but Points has colors even though colors can be a single color specification. Both have the argument radius, which, however, can also be a sequence in Points (albeit an undocumented feature)!

Actor-specific
Neuron
IIRC, the SWC file standard supports neurite segment start and end thicknesses and soma diameters. As far as I can tell, the implementation, however, does not appear to expect/use that information. If that assessment is mistaken, neurite_radius and soma_radius should probably be called something else (default_neurite_radius?).
Volume
The min_quantile/min_value argument pair is very difficult to communicate. I would either have a single threshold argument (and let the user compute percentiles). Or, I would follow vedo and have vmin/vmax arguments, which would pair better with cmap and additionally lean on people's familiarity with matplotlib.
Streamlines
There is no documentation anywhere on what the basic streamlines data structure entails. Even the examples/streamlines.py file downloads data from the ABA. This makes it quite difficult to document the class.
ruler & ruler_from_surface
Why are these functions when all other actors are classes?
Also, I would remove the unit and unit_scale arguments and hardcode micrometers" as unit. Currently, coordinates are implicitly in micrometers, but the default unitis the empty string, and theunit_scale` is 1, neither of which communicates this to the user.  I would remove the arguments as everything about them is confusing and near-impossible to communicate.
Cylinder
Currently, cylinders are hard-coded to be vertical (unless I am missing something). Making the second argument another 3d coordinate (instead of Scene.root) would make this class a lot more flexible and easier to explain.

Thanks @paulbrodersen, much appreciated! Hopefully we will get to improving all of this sometime soon.

Sorry that I have to bail out like this (and pollute your issue tracker in the process with whatever this is), but I have a busy couple of weeks ahead. brainrender is a neat library, it just needs a little bit more documentation. Best of luck!


add 1.21 graceful node shutdown blog post

This is a 1.21 feature blog for graceful node shutdown (https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2000-graceful-node-shutdown).
Target publish date is 04/21/21.
cc @bobbypage @divya-mohan0209 @sftim @mrunalp

Because the first word of the article is a typo of “Kubernetes”:
/lgtm cancel
but: reviewers, feel free to re-add LGTM at will as needed.

Thanks for all the feedback @sftim. I updated based on your feedback and some other comments I received on the original Google doc. Please take a look again.

/approve
/hold
for further review

LGTM

/hold cancel
/lgtm
Scheduled for 2021-04-21


Created Automated Paloma Private Testnet Test of Arbitrary logic call functionality

In private testnet, we want a suite to be able to deploy all supported contracts to all required chains and test arbitrary logic calls on all deployed chains so that we will be able to verify that the logic calls run in private testnet before public testnet.

@taariq @verabehr
Here's my assumptions on this:
Supported chains

eth
bnb
matic
op

Testing strategy
For each of the chains outlined above, execute the following.
Basic testing
[] Ensure sure the chain proposal is accepted
[] Ensure the compass contract is deployed on the target chain
Abstract contract testing
[] Perform a valset update and ensure it's relayed accordingly
[] Run a (very basic) contract without COSMWASM as defined in here: https://www.notion.so/volumefi/Execute-a-job-without-wasm-in-private-testnet-b9bd3e3f805541199b9be291e2b01917
Specific contract testing
[] Run a vyper contract deployed on the target chain as defined here: https://www.notion.so/volumefi/Create-and-Execute-Cross-Chain-Job-50e42451cb324de19dd2357900043f15
Open questions:

What is the full extend when you say "all supported contracts on all required chains". Can we setup a document outlining this information?


Updated descriptions to use better cli ref

Proposed changes
Update CLI descriptions to use the proper CLI references
Related issues (optional)
https://github.com/docker/docker/pull/30514

Building this locally to check it now. I think we can ignore the Netlify error as it doesn't actually run the Dockerfile.

@mstanleyjones @johndmulhausen I can haz LGTM and get this merged?


EZSPA-56

create pull secret by default
fix apache spark job examples

@AlexNavara , @idzikovskyi please use descriptive commit messages & PR titles going forward. Do not use JIRA keys as they aren't reference-able publicly.


Initial dependency separation of Arch from SteamOS

Part of #1
Prevents installation failure on Arch Linux.
Note that it's likely the dependencies will need to be later combed more thoroughly to remove unnecessary parts, but this will at least allow arch users to get past the dependencies step without failure.

Removed duplicate bc and patch from SteamOS and curl, gawk, bc, and libxml2 from Arch

See discussion in #90 for potential further changes required.

cabextract should be added back to the main package lists. It is needed by winetricks.
patch I believe can be safely removed


Can't Update This App

Type: Bug
I'm stuck with this version and i can't seem to can update it from the app. i don't to go to MS vscode site and download the last version bc i don't want to risk that. I wish you could help!
Version: 1.79.2 (user setup)
Commit: 695af097c7bd098fbf017ce3ac85e09bbc5dda06
Date: 2023-06-14T08:57:04.379Z
Electron: 22.5.7
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
VS Code version: Code 1.79.2 (695af097c7bd098fbf017ce3ac85e09bbc5dda06, 2023-06-14T08:57:04.379Z)
OS version: Windows_NT x64 10.0.22621
Modes:

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.90.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

That is literally the problem...


add jvm import org.apache.spark.sql.api.python.*

What changes were proposed in this pull request?
jvm import org.apache.spark.sql.api.python.*. Or else pandas dataframe to spark dataframe will fail.
How was this patch tested?
import pandas as pd
from pyspark.sql import SparkSession

pandas_df = pd.DataFrame({
    'A': [1, 2, 3],
    'B': ['a', 'b', 'c']
})

spark = SparkSession.builder.getOrCreate()
spark_df = spark.createDataFrame(pandas_df)
spark_df.show()

this failed before, and now it's OK.

any one check here?

We have just merged a fix for LIVY-863 which adds a few missing imports including this one. I will close this PR, but thank you for testing and proposing a fix for this issue.


Depend on major version of test gems

Use a pessimistic version requirement for RSpec and Minitest in
gemspecs generated by the bundle gem command. It is best practice to
at least depend on major versions of development dependency gems.
refs #3811

@homu r+

:pushpin: Commit 121642a has been approved by indirect

@homu r-
@bundler/core?

@indirect why limit the tests to RG 1.8.1+?

I put it in the commit message, but RubyGems didn't add specific? until 1.8.1.

@homu r+

:pushpin: Commit 121642a has been approved by segiddins

:lock: Merge conflict

:umbrella: The latest upstream changes (presumably #3881) made this pull request unmergeable. Please resolve the merge conflicts.

@homu r+

:pushpin: Commit 2895dbc has been approved by indirect

:hourglass: Testing commit 2895dbc with merge 13bb571...

:broken_heart: Test failed - status

@indirect rubocop

dammit

Currently tempted to force the block style back to my personal default of no space before open curly :stuck_out_tongue_closed_eyes:

@homu r+

:pushpin: Commit 2e97cd4 has been approved by indirect

@homu r+

:pushpin: Commit 2e97cd4 has been approved by segiddins

:hourglass: Testing commit 2e97cd4 with merge 0209a58...

:broken_heart: Test failed - status

These flaky tests are totally killing me. :(


chore(Topology/ContinuousFunction/Bounded): Rename instances

All the unnamed instances here were very long, and Moritz recently linked one of these to a newcomer.
Also slightly clean up the Lattice instance

!bench

Thanks!
bors r+


created django template

Changed from Flask to Django fr

Wow, what amazing code. This pull requester must be quite competent.


Config flow - error 500 Internal Server Error

Running HASSOS on Raspberry Pi 4.  Added through HACS, restarted HA, and proceeded to add integration in HA.
HA on latest version 2023.01.04
Getting error:
Config flow could not be loaded: 500 Internal Server Error Server got itself in trouble
Any idea how to fix?
Log:
Logger: aiohttp.server
Source: config_entries.py:865
First occurred: 12:03:47 AM (8 occurrences)
Last logged: 12:27:53 AM
Error handling request
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/aiohttp/web_protocol.py", line 435, in _handle_request
resp = await request_handler(request)
File "/usr/local/lib/python3.10/site-packages/aiohttp/web_app.py", line 504, in _handle
resp = await handler(request)
File "/usr/local/lib/python3.10/site-packages/aiohttp/web_middlewares.py", line 117, in impl
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 60, in security_filter_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 100, in forwarded_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 28, in request_context_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 81, in ban_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 236, in auth_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/view.py", line 136, in handle
result = await result
File "/usr/src/homeassistant/homeassistant/components/config/config_entries.py", line 148, in post
return await super().post(request)
File "/usr/src/homeassistant/homeassistant/components/http/data_validator.py", line 73, in wrapper
result = await method(view, request, data, *args, **kwargs)
File "/usr/src/homeassistant/homeassistant/helpers/data_entry_flow.py", line 71, in post
result = await self._flow_mgr.async_init(
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 229, in async_init
flow, result = await task
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 247, in _async_init
flow = await self.async_create_flow(handler, context=context, data=data)
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 865, in async_create_flow
flow = handler()
TypeError: ABBPowerOnePVISunSpecConfigFlow.__init__() missing 1 required positional argument: 'config_entry'

Please try installing latest v2.3.1 and let me know if it fixes the issue. Thanks.

yeap! now it works :) Thanks!!


ES6 syntax doesn't appear to work when using ember:install

Hmmm.. It might be me then. I'l keep playing around!

@brandonparsons are you still having issues or can I close this PR?

Closed this issue. It's not really anything specific to do with your library (i.e. I'm having trouble finding consensus on what node version to use with recent versions of ember-cli).
However, note that most other libraries don't seem to be using ES6 syntax in these files, so some issues may crop up from time to time.


Proxy server appears to cause loading issues on testing site

I am doing selenium automation testing and am using a standalone BMP server on each of our remote grid machines.  We are using the proxy server to bypass browser authentication.   I am also running parallel tests on each machine.  My issue is that when the proxy server is running, it slows down the browser so much that it ends up timing out.  3 out of 5 tests will typically fail because the browser loads so long (3-5 minutes).  It seems to do fine when 1 test (1 browser instance) is running, but when we do 5 tests running at a time, the tests just tank.  I can run all 5 tests parallel without the BMP server, and they do not have the loading issue.  We have to use a proxy server for the authentication to our site - as there are 3 different authentication servers that will pop up during various places in the test (and you are not able to pass the credentials into the URL in one of those places).
My question is - should the BMP server be able to handle multiple browsers going at once?
My other thought - is that we have a BMP server running on each machine.  Would it be better to have a dedicated machine that just runs the proxy server - and have all the machines point to that one?  This is related to the above questions - as to whether the BMP server can handle (or was designed to) handle that type of traffic.
Related details: We are using azure machines that are some what lightweight - 2 cores with 7GB.  Each machine will either run chrome (latest) or firefox (version 45).  We are using the latest release of BMP server - and only Rest commands are to start it on port 9091, and to pass in the authentication credentials.

The proxy should definitely be able to handle a large number of browsers at once. I use a single embedded mode instance of BMP to handle traffic from dozens of browsers on a Selenium grid. A couple ideas come to mind:

Since you're using the REST API, create the proxy using the useEcc=true query param, e.g. curl -X POST http://localhost:8080/proxy?useEcc=true. If BMP is proxying a large number of HTTPS requests from various hosts, this will definitely reduce CPU usage (RSA keys are expensive to generate, EC keys are quick).
Are you setting any JAVA_OPTS on the command line that would affect heap usage?
Try enabling debug-level logging in the bmp-logging.yaml and see if that gives a clue about what it's spending so much time doing.

To answer your other question, either running one per node or a single instance should work just fine. BMP really shouldn't be using all that many resources.

Thanks so much for you quick & helpful response.  using the useEcc=true query parameter made a huge difference and has eliminated the loading issue.

Glad that fixed the problem, I'll close this issue.

@jekh why ecc was not the default encryption method, even though it is faster, are there any cons to using this?


Support string type index to add | delete | update | scan

depend on #156

Resolved conflict; adressed comments


Cannot add Rocky8 KVM host

When adding to the last step, it prompts that the server resources on the IP cannot be found.
Centos7.9 working well.
Who can tell me why? The official documentation says it supports Rocky8, but why can't it be added to the host

@Jonlli
It does support rocky8 and 9.
Have you configured linux bridges manually ?

yeah ,  bridges working
I checked all the configurations, the compute nodes, and the bridge configurations are working fine, but I still can't drop the compute node to join the control end

I reinstalled the bridge mode of centos7, and it can join the control node normally.

we have solved it. you can close the ticket

@Jonlli can you descrivbe what the issue was, for others to learn?

@Jonlli can you descrivbe what the issue was, for others to learn?

this could be the same issue in the mailing list
https://lists.apache.org/thread/xqp3db72phhrmhgt0kvpx8yzt7rr13v8
as suggested by @NuxRo
Add the following to /etc/libvirt/libvirt.conf :
remote_mode="legacy"

Then restart services.