Add app-level configuration for autorun on startup

Description
Having an app-level config for autorun is convenient for users who want some notebooks to run on startup and not others.
Currently, I have to enable and disable this config from marimo home by clicking Settings > User settings > Runtime > Autorun on startup (4 clicks to toggle one setting).
Suggested solution
Here's a quick table showing the expected behavior of these configurations:

User Config
App Config
Result

Disabled
Disabled
Notebook does NOT run on launch

Enabled
Disabled
Notebook does NOT run on launch.

Disabled
Enabled
Notebook does NOT run on launch.

Enabled
Enabled
Notebook runs on launch.

TLDR: The notebook can only be autorun on startup if BOTH user config and app config permit it.
Alternative
No response
Additional context
This issue is related to (and is part of the suggested solution for) #2884.

Thanks for the request this makes sense. Couple ideas for implementation:

Should we re-use AppConfig and add autorun there? What are the config names? off/default or off/on?
Should we re-use UserConfig and put in the to heading.

# /// script
# requires-python = ">=3.11"
# dependencies = [
#     "marimo",
# ]
# [tool.marimo.runtime]
# auto_instantiate = false
# ///

I prefer 2 but it is more work, but 2 will help when we want to support overriding notebook config with by the user's pyprojec.toml. It also allows overriding darkmode and other runtime configuration.

I also think we can improve the UX when starting up a notebook that is not instantiated, such as a banner at the top to "Run All" or "Run Markdown"

I don't have as much context around UserConfig so I'm not sure what you mean when you say to reuse it.
Also, I know it is a separate discussion, but when it comes to pyproject.toml settings, I'm not sure this solves the per-notebook basis that is requested for runtime configurations, since those are project-level settings.

"User config" is our MarimoConfig object in the code base, which right now is only set per-user, but we want to add it per-project and per-notebook. By using the pyproject.toml, we can do both, since PEP 723 allows for this.


Fail to generate valid test images and render valid video on lego dataset

Hardware: NVIDIA Tesla T4, cuda 11.3
JNeRF:
master branch
Description:
Test on lego dataset.
All the generated ./lego/test/lego_r_{number}.png is completely black.
TOTAL TEST PSNR is extremely low or even nan.
The rendered "demo.mp4" is completely black.

Besides, import jittor and import jnerf seem OK and did not report any errors.

I have the same issue, it is fixed by setting fp16 = False

It worked! Thanks a lot! @ellzeycunha0


Error on first user signup - JSON.parse: unexpected character at line 1 column 1 of the JSON data

I'm trying to deploy the docker project on a personal server running Fedora Server 39 and Docker. Using basically default settings in my .env, and updating only NEXT_PUBLIC_WEBAPP_URL, NEXTAUTH_SECRET, CALENDSO_ENCRYPTION_KEY and POSTGRES_PASSWORD, I am getting this error when inviting my first user:

calcom-1  | @calcom/web:start: Error: @vercel/edge-config: No connection string provided
calcom-1  | @calcom/web:start:     at m (file:///calcom/apps/web/.next/server/middleware.js:90:19)
calcom-1  | @calcom/web:start:     at E (file:///calcom/apps/web/.next/server/middleware.js:160:15)
calcom-1  | @calcom/web:start:     at N (file:///calcom/apps/web/.next/server/middleware.js:162:18)
calcom-1  | @calcom/web:start:     at middleware (file:///calcom/apps/web/.next/server/middleware.js:835:40)
calcom-1  | @calcom/web:start:     at Object.middleware (file:///calcom/apps/web/.next/server/middleware.js:750:32)
calcom-1  | @calcom/web:start:     at Object.handler (file:///calcom/apps/web/.next/server/middleware.js:2696:55)
calcom-1  | @calcom/web:start:     at <unknown> (file:///calcom/apps/web/.next/server/middleware.js:4420:23)
calcom-1  | @calcom/web:start:     at AsyncLocalStorage.run (node:async_hooks:338:14)
calcom-1  | @calcom/web:start:     at Object.wrap (file:///calcom/apps/web/.next/server/middleware.js:4251:24)
calcom-1  | @calcom/web:start:     at adapter (file:///calcom/apps/web/.next/server/middleware.js:4407:53)
calcom-1  | @calcom/web:start: react-i18next:: You will need to pass in an i18next instance by using initReactI18next
calcom-1  | @calcom/web:start:
calcom-1  | @calcom/web:start:  ⚠ metadata.metadataBase is not set for resolving social open graph or twitter images, using "http://localhost:3000". See https://nextjs.org/docs/app/api-reference/functions/generate-metadata#metadatabase
calcom-1  | @calcom/web:start: react-i18next:: You will need to pass in an i18next instance by using initReactI18next
calcom-1  | @calcom/web:start: 12:17:51:411    WARNorgDomains.ts Match of WEBAPP_URL with ALLOWED_HOSTNAME failed {
calcom-1  | @calcom/web:start:   WEBAPP_URL: 'https://mydomain.com',
calcom-1  | @calcom/web:start:   ALLOWED_HOSTNAMES: []
calcom-1  | @calcom/web:start: }

Adding ALLOWED_HOSTNAMES does not make a difference.
I also posted this on the Docker channel in Discord but given the presence of crypto and developer scam/spam bots it's very clear that the Discord community is unmoderated, hence filing this as an issue.

similar to #326

Any news? Did someone find out what is happening here? I'm running into the same issue here.


[feat]Rocksdb backend

RocksDB backend for TFRA Hastabale.

Hi @bashimao , thank you for your contribution , and can you squash your commits to one and describe your feature detail in your comment?

@googlebot I signed it!

@rhdong What could case this? @MoFHeka
root@13beb51e47e9:/# python
Python 3.7.7 (default, Jan 19 2022, 04:18:49)
[GCC 7.5.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from tensorflow_recommenders_addons import dynamic_embedding as de
2022-03-27 20:28:04.992289: I tensorflow/stream_executor/platform/default/dso_loader.cc:53] Successfully opened dynamic library libcudart.so.11.0
WARNING:tensorflow:dynamic_embedding.GraphKeys has already been deprecated. The Variable will not be added to collections because it does not actully own any value, but only a holder of tables, which may lead to import_meta_graph failed since non-valued object has been added to collection. If you need to use `tf.compat.v1.train.Saver` and access all Variables from collection, you could manually add it to the collection by tf.compat.v1.add_to_collections(names, var) instead.
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.7/site-packages/tensorflow_recommenders_addons/__init__.py", line 29, in <module>
    from tensorflow_recommenders_addons import dynamic_embedding
  File "/usr/local/lib/python3.7/site-packages/tensorflow_recommenders_addons/dynamic_embedding/__init__.py", line 58, in <module>
    from tensorflow_recommenders_addons.dynamic_embedding.python.ops.cuckoo_hashtable_ops import (
  File "/usr/local/lib/python3.7/site-packages/tensorflow_recommenders_addons/dynamic_embedding/python/ops/cuckoo_hashtable_ops.py", line 33, in <module>
    cuckoo_ops = LazySO("dynamic_embedding/core/_cuckoo_hashtable_ops.so").ops
  File "/usr/local/lib/python3.7/site-packages/tensorflow_recommenders_addons/utils/resource_loader.py", line 102, in ops
    self._ops = tf.load_op_library(get_path_to_datafile(self.relative_path))
  File "/usr/local/lib/python3.7/site-packages/tensorflow/python/framework/load_library.py", line 58, in load_op_library
    lib_handle = py_tf.TF_LoadLibrary(library_filename)
tensorflow.python.framework.errors_impl.NotFoundError: /usr/local/lib/python3.7/site-packages/tensorflow_recommenders_addons/dynamic_embedding/core/_cuckoo_hashtable_ops.so: undefined symbol: _ZN10tensorflow14kernel_factory17OpKernelRegistrar12InitInternalEPKNS_9KernelDefEN4absl12lts_2021032411string_viewESt10unique_ptrINS0_15OpKernelFactoryESt14default_deleteIS9_EE


Can't use headset or webcam

Hi
Is there a know reason why i'm unable to use my headset and webcam from within Ferdium?
Everything else seems to work. I've enabled webRTC also but nothing changes.

Hello @Falciform , please open this issue in the correct place (as you stated).
Thank you!


Add support for Iterator Helpers (now stage 3)

⚙ Compilation target
ESNext
⚙ Library
n/a
Missing / Incorrect Definition
IterableIterator should have map/filter/etc.
Sample Code
// Tested in both Node 22 and latest Edge

const m = new Map([[1, 2], [3, 4]]);
const keys = m.keys(); // IterableIterator<number>
const iter = keys.map(n => n * 100);
// Property 'map' does not exist on type 'IterableIterator<number>'.ts(2339)

const val = iter.next();
console.log(val);
// {value: 100, done: false}

Documentation Link

https://github.com/tc39/proposal-iterator-helpers
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Iterator/map
https://caniuse.com/?search=JavaScript built-in%3A Iterator%3A map

Already added in #58222

Yep: Playground Link

Ah I thought I saw this somewhere. Thanks guys.

Why do those docs say

and for some reason reduce

?

I have no idea lol. @DanielRosenwasser ?

It was just a playful dig at the method. reduce can be useful but unfortunately I find most uses of it are super inefficient, are just a bad forEach, or overly clever. You can feel free to use reduce and I won't judge you. 😄

True, I can't remember how many years it's been since I actually used reduce.


Fix error message

https://github.com/arfedulov/semantic-ui-calendar-react/pull/165
Complete this PR by fixing error msg

I close this pr as I fixed the issue myself already. See comment to your commit.


Fix bug stream closed bug when merging BAI files greater than buffer size

Adding a buffer size (of say 1000) to SeekableBufferedStream in HadoopFileSystemWrapper#open
exposes the bug when running BaiMergingTest. (It's tricky to add a unit test since the buffer size for SeekableBufferedStream is deeply embedded...)
This issue was raised in https://github.com/broadinstitute/gatk/issues/5919

I'd like to merge this soon unless there are any objections.

Thanks @heuermh


Metadata not returning on transactions

When creating or fetching transactions, the metadata is not returned.
To reproduce:

Given the transaction created with this payload:

{
    "from": "lucas",
    "to": "andrios",
    "amount": 100,
    "currency": "BRL",
    "metadata": [{
        "test": true
    }]
}

I should get back two transactions with the same metadata, but what I get back does not contain metadata:

[
    {
        "amount": 100,
        "date": "2020-09-12T09:21:23.764Z",
        "currency": "BRL",
        "balance": 500,
        "from": "lucas",
        "id": "16ea0f46389d2511cae81954309a339b",
        "to": "andrios"
    },
    {
        "amount": 100,
        "date": "2020-09-12T09:21:23.767Z",
        "currency": "BRL",
        "balance": 100,
        "from": "lucas",
        "id": "c44eacd2b08586b54b4ab179fdea09af",
        "to": "andrios"
    }
]

Also, would be nice to query transactions by metadata. Is that something you consider to implement?

@lnmunhoz solved in #12

Also, would be nice to query transactions by metadata. Is that something you consider to implement?

I thought about it, but don't think this is a good idea. Mostly because this is a dynamic field. There is no way we can build an efficient index to be queried on the data if we don't know it. Things like cardinality are very important for indexes.
Can you explain a bit of your use case?

The simplest use-case I can think of is merely searching/filtering transactions, e.g. if I consistently store tx messages in metadata["message"], or location of a purchase, if available, in metadata["WGS84"], the use-case would be to filter all transactions that has the tx message walmart.
(The location use-case on the other hand becomes hardcore pretty quickly: "give me all transactions in a 10 km radius around 55.276192,-5.3228631" 😅 ...)


Insert links in comments

Can we insert a hyperlink in a comment? I think a complete WYSIWYG bar would be distracting... maybe just take, say, markdown syntax? I have a PhD student interested in testing this in the spring

i want to try a complete wysiwyg bar first, and back off if it's distracting. maybe using http://textangular.com/


Swift compiler error

I cannot run up application with version 0.2.1 and got below error

@phanvanluan94 Thanks for reporting this. There was a breaking change in the Google UMP SDK. I'll have a fix this today probably.

Version '1.0.0' has been published which includes a fix.
Closed by cb90d3eb77af725ee55451085af1142557246f53 and 028967acba9b5a205573078e22cf78b72ef7c761.


Why infiniteLoopEnabled feature is removed?

This is a good library that save my life time.
I walked around your code and found that you removed the infinite loop feature in version 1.0.4 .
I thought there must be some reasons made you did this. But I didn't find the reason. Can you explain this, please. Or, if it was some bugs, do you have any plans to add it back to this awesome library?

I removed it because it caused various bugs. I can't focus on the library for now, maybe it can be rewritten cleanly later.


Separate routers and templates to their own packages

All concrete routers and templates have been moved to their own packages. This patch updates the main repository to remove them and add development dependencies on a subset of them for testing purposes. The composer suggestions have been updated accordingly.

This patch addresses #131 .


fix typo

What this PR does / why we need it:
fix endpoint typo
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE

Codecov Report

Merging #898 (6891e77) into main (d429908) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main     #898   +/-   ##
=======================================
  Coverage   29.80%   29.80%
=======================================
  Files          24       24
  Lines        1570     1570
=======================================
  Hits          468      468
  Misses       1040     1040
  Partials       62       62

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Seems the e2e test is timeout, let me retry again.

All right. It's time to merge now. Thanks.


cargo-xbuild: 0.5.14 -> 0.5.15

Motivation for this change
Update cargo-xbuild to the latest release.

https://github.com/rust-osdev/cargo-xbuild/releases/tag/v0.5.15

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@jonringer @worldofpeace Thank you!


Radio doesn't resume after network interruption - Wifi (working for cellular)

Hello Fethica,
I have been using the FRadio library in my radio app and encountered an issue. When there is a network interruption and the network type is Wifi -  the radio pauses and when the connection is back, the Radio wouldn't resume though the player state is 'Ready to play'. This is working fine with cellular data but not working with Wifi.
Please note that I have tested this on my iPhone 8 Plus device, however the same scenario is working fine in the simulator (radio resumes).
We have a release planned early next week and this is the show stopper. So, kindly get back to me ASAP.
Thank you.
Regards,
Hima

Hey @HimaKrishna
A couple of users have already mentioned the same issue, I'm looking into that!

Hey @HimaKrishna
A couple of users have already mentioned the same issue, I'm looking into that!
Thanks Fethica, I would like to provide more info on this. It seems like the issue is when the User turn OFF the wifi and turned it ON from the Control centre on iPhone, the radio player did not resume. But when the User turn the Wifi OFF the Wifi from the Settings and turn it back, the player is working fine (Resumes the stream).
I believe there is an issue in the reachability related to the command centre. Hope this helps you in your investigation.

hum interesting!
Thanks for the details @HimaKrishna that will really help 👍

My recommendation for you is to use Alamofire's NetworkReachabilityManager.


"derived is undefined" error in v1.6 of @steeze-ui/svelte-icon when using Svelte 4

The latest release (v1.6) gives an error that derived is undefined when used with Svelte 4. I'm not sure whether breaking backwards compatability with Svelte 4 was intended.
The new $derived syntax is used in Icon.svelte; Svelte 4 interprets this as use of a store that is undefined: https://github.com/steeze-ui/icons/blob/main/packages/components/svelte-icon/src/lib/Icon.svelte#L12
(this change was introduced in https://github.com/steeze-ui/icons/pull/60)

I think that compatability with both Svelte 4 and Svelte 5 could have been achieved by not using any new Svelte 5 syntax, and instead only changing package.json to specify dependency on either.
That is, change:
    "svelte": "^4.0.0",

to:
    "svelte": "^4 || ^5"

mistake by me, 1.6.0 should have been a major release. Svelte versions <5 must use 1.5.x


make check fails on Segmentation fault in mingw Windows 11

I have managed to install liquid dsp but when i do "make check" it stops on segmentation fault.
msresamp_crcf_num_output_6:
testing msresamp_crcf_get_num_output() with r=2980.96
max_input : 64, max_output : 763141
make: *** [makefile:1337: check] Segmentation fault
I am on mingw64 in windows. Any idea what could be wrong here?
make install works fine.
make example works fine.
Moreover, I am also trying to link library in code blocks IDE but failing everytime. I can share the results if you like.
Thanks

In order for me to help with this, I'll need a little more information. What specific version of the code are you using (e.g. git hash)? Does it fail every time you run "make check" (a different random seed is provided each time)? I'm not an expert on running in windows; what compiler/version are you using?

Hi Gaeddert,
Apologies for the delayed response. Installing liquid on windows was not a good idea. What i did is, i installed it on WSL and use VScode to access the libraries that are installed on WSL. So many tutorials are available on this. Thank you for making such a cool DSP library.


[SPARK-41921][CONNECT][TESTS] Enable doctests in connect.column and connect.functions

What changes were proposed in this pull request?
Enable doctests in connect.column and connect.functions
Why are the changes needed?
Improve test coverage
Does this PR introduce any user-facing change?
No
How was this patch tested?
New tests enabled

Merged to master.


Chapter 6 - Error: unable to verify the first certificate

node:events:492
      throw er; // Unhandled 'error' event
      ^

Error: unable to verify the first certificate
    at TLSSocket.onConnectSecure (node:_tls_wrap:1674:34)
    at TLSSocket.emit (node:events:514:28)
    at TLSSocket._finishInit (node:_tls_wrap:1085:8)
    at ssl.onhandshakedone (node:_tls_wrap:871:12)
Emitted 'error' event on WebSocket instance at:
    at emitErrorAndClose (C:\nextjs-dashboard\node_modules\ws\lib\websocket.js:1016:13)
    at ClientRequest.<anonymous> (C:\nextjs-dashboard\node_modules\ws\lib\websocket.js:864:5)
    at ClientRequest.emit (node:events:514:28)
    at TLSSocket.socketErrorListener (node:_http_client:495:9)
    at TLSSocket.emit (node:events:514:28)
    at emitErrorNT (node:internal/streams/destroy:151:8)
    at emitErrorCloseNT (node:internal/streams/destroy:116:3)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  code: 'UNABLE_TO_VERIFY_LEAF_SIGNATURE'
}

Node.js v20.10.0

i have same issue

I had the same problem.
I think this is something to do with my internet connection settings, potentially with VPN config.
When using a different internet connection (I used mobile data), this step worked for me.
I will add more to this comments if I find out more.

I am not able to reproduce this. Please open a new issue if you are still having trouble here. Thank you!


Using Client#status_update appears to do nothing

Title basically says it all. Whenever I try to update my bot's status, nothing occurs.

Fixed in #11.


Integration with MS Viva Sales

Connector to MS Viva Sales and skills for it's capabilities.  ref. https://www.microsoft.com/en-ww/microsoft-viva/sales

I am currently working on developing an AI Agent that aims to assist operators in their work. Integrating MS Viva meeting summaries into MS Teams has the potential to significantly enhance their productivity. Additionally, in the future, I plan to create a plugin that enables background recording, similar to the functionality provided by (https://www.bloks.app/).

Thanks for the additional context! I've added it to our backlog!

Closing this issue since it was created several months ago. Please create a new issue if you'd still like this integration.


Repo sync for protected CLA branch

The pull request is created from main637897667043440739 to main to fix git push error for protected CLA branch

@opbld15 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Remove quick-review additional listener when navigating

Fixes #5171
Test URLs
Go to https://togithub.com/refined-github/sandbox/pull/7 and click the linked issue in the sidebar
Screenshot
n/a

Problem: page stuck when navigating from isPRConversation to other pages via PJAX.

For the record: This addressed part of:

https://github.com/refined-github/refined-github/issues/5222#issuecomment-996625242


Title is "Install or update" but no instructions on update.

When installing from link on Windows- received "need to update" in power-shell after running az --version but no instructions on the update command syntax

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8246b90a-efb1-03ce-f642-d3eb2441fc30
Version Independent ID: 2fdd20ef-7bd3-57bc-7957-93f4bb5377ce
Content: Install the Azure CLI for Windows
Content Source: docs-ref-conceptual/install-azure-cli-windows.md
Product: azure
Technology: azure-cli
GitHub Login: @sptramer
Microsoft Alias: sttramer

There's currently a bug where az --version always reports a need to upgrade. However the section you're referring to on the page is called Install or Upgrade. The process identical for Windows.


Rely on session context when building sdist and wheel

Summary of changes

Closes #3059
Pull Request Checklist

[ ] Changes have tests
[ ] News fragment added in changelog.d/.
(See documentation for details)

Github has messed up this PR. The diff is wrong and there are too many commits. If I look at the branch, it shows correctly that this branch is one commit ahead of main:

That's not pertinent to the failures, but it surely doesn't help in the analysis.

Aha. I did some searching and found this article, which looks suspiciously similar, so I suspect its where the inspiration was drawn from, and confirms my misunderstanding about session fixtures. They're not automatically synchronized across workers in xdist, so each worker attempts to generate their own.

I distilled the two issues I found with that article.

Hi @jaraco, thank you very much for the deep investigation.
Indeed, I did not realise the shortcoming of this technique...
I understand that this PR will solve the problem if xdist is not used.
Does it make sense / is it worthy to manually remove the created directory after yield locked_dir and transform setuptools_wheel and setuptools_sdist in "yield fixtures"? Would that solve the problem?

I understand that this PR will solve the problem if xdist is not used, but when xdist is being used, things remain more or less the same. Is that correct?

Yes. That's right. As I was investigating, I learned that tmp_path_factory.getbasetemp() changes depending on whether xdist is enabled, and it was only in the case that xdist was disabled or using only one process that the state was getting stored outside the session dir.

Does it make sense / is it worthy to manually remove the created directory after the yield inside the context?

Originally, I was concerned, but once I figured out the basedir mismatch and also learned that pytest normally leaves files behind to clean them up in the future, so I'm okay with it now that it gets cleaned up with or without xdist.


Samples need updating to Azure.Storage.Blobs

Can samples be provided for using the latest SDK code (Azure.Storage.Blobs) and/r samples be clearly marked for which SDK they are meant - with now three different SDKs in existence it is getting impossible to find the right sample for the right SDK.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d02de0bf-09d7-a7fc-1b4a-213426e96b2d
Version Independent ID: 36f6c8fe-6bc1-6643-4b66-2c38bcd2e5f0
Content: Acquire a token from Azure AD for authorizing requests from a client application - Azure Storage
Content Source: articles/storage/common/storage-auth-aad-app.md
Service: storage
Sub-service: common
GitHub Login: @tamram
Microsoft Alias: tamram

@coreazure-jd Thank you for the feedback!  We are investigating this and will get back to you shortly.

In addition to working with Azure.Storage.Blobs the code and documentation needs to explain how to make this scenario work with the Azure.Identity sdk as I can't find any documentation around how to use the TokenCredentials mechanism with a TokenCache AND an Authorization Code to get the a token from another api.

@coreazure-jd - Both the article and the sample have been updated to use the latest libraries.
#please-close


ci: replace PAT with GITHUB_TOKEN for pr_title check

Description
Is there are reason why a PAT has been used? The default GitHub token has enough permissions to validate the PR title and I think it's a good pattern to avoid using PATs.
cc: @Salakar
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (melos run analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change.

Never mind GH_TOKEN and GITHUB_TOKEN are the same (https://cli.github.com/manual/gh_help_environment). I thought GH_TOKEN is a PAT.


[Plugin] draw-tools: How can I see data of IITC desktop with IITC mobile?

I've saved and used so many data with IITC desktop.
How can I see data of desktop with IITC mobile?

This is a very old but still open issue.  To answer the question of "how do I copy draw-tools objects from desktop to mobile" the current process might look like this:
On desktop:

Click on "DrawTools Opt"
Click on "Copy Drawn Items"
Select the JSON in the textarea
Paste the JSON into some storage that you can access from the mobile device (e.g., text file shared via Google Drive, etc.)

On mobile:

Retrieve JSON from storage in previous step #4 above
Click on "DrawTools Opt"
Click on "Paste Drawn Items"
Paste JSON into input field, click "OK"

Ideally, the Sync plugin could be used to automatically sync DrawTools data (c.f. issue #350), but until then, this is the manual process that can be used.

It's a real pain there's no auto-sync.
https://greasyfork.org/en/scripts/395541-iitc-plugin-draw-tools-sync/code is almost there but IITC Mobile seems to ignore it.
Google Keep is probably the simplest way to share text between desktop and mobile.

Switch to https://github.com/IITC-CE/ingress-intel-total-conversion


release 2021-08-10

New Terms:
L2/3 intratelencephalic projecting glutamatergic neuron of the primary motor cortex (Homo sapiens)
L5 intratelencephalic projecting glutamatergic neuron of the primary motor cortex (Homo sapiens)
L6 intratelencephalic projecting glutamatergic neuron of the primary motor cortex (Homo sapiens)
L5/6 near-projecting glutamatergic neuron of the primary motor cortex (Homo sapiens)
Edits:
synonym L5/6 NP -> L5/6 NP (Mus)
fixed duplicated entries in cl-full.obo
various other fixes

Thank you @shawntanzk


[SHIRO-722] Add SameSite option to cookies

I updated the PR and added also the None option. According to this SameSite is going to be the default in Chrome really soon so this PR becomes urgent.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/157/Build result: FAILURE[...truncated 436.68 KB...][JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr/core/pom.xml to org.apache.shiro/shiro-core/1.5.0-SNAPSHOT/shiro-core-1.5.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr/core/target/shiro-core-1.5.0-SNAPSHOT.jar to org.apache.shiro/shiro-core/1.5.0-SNAPSHOT/shiro-core-1.5.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr/core/target/shiro-core-1.5.0-SNAPSHOT-tests.jar to org.apache.shiro/shiro-core/1.5.0-SNAPSHOT/shiro-core-1.5.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr/core/target/shiro-core-1.5.0-SNAPSHOT-javadoc.jar to org.apache.shiro/shiro-core/1.5.0-SNAPSHOT/shiro-core-1.5.0-SNAPSHOT-javadoc.jar[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr/core/target/shiro-core-1.5.0-SNAPSHOT-sources.jar to org.apache.shiro/shiro-core/1.5.0-SNAPSHOT/shiro-core-1.5.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr/samples/aspectj/pom.xml to org.apache.shiro.samples/samples-aspectj/1.5.0-SNAPSHOT/samples-aspectj-1.5.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr/samples/spring-boot-web/pom.xml to org.apache.shiro.samples/samples-spring-boot-web/1.5.0-SNAPSHOT/samples-spring-boot-web-1.5.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr/samples/spring-client/pom.xml to org.apache.shiro.samples/samples-spring-client/1.5.0-SNAPSHOT/samples-spring-client-1.5.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr/tools/hasher/pom.xml to org.apache.shiro.tools/shiro-tools-hasher/1.5.0-SNAPSHOT/shiro-tools-hasher-1.5.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr/support/spring-boot/spring-boot-starter/pom.xml to org.apache.shiro/shiro-spring-boot-starter/1.5.0-SNAPSHOT/shiro-spring-boot-starter-1.5.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr/support/jaxrs/pom.xml to org.apache.shiro/shiro-jaxrs/1.5.0-SNAPSHOT/shiro-jaxrs-1.5.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr/samples/guice/pom.xml to org.apache.shiro.samples/samples-guice/1.5.0-SNAPSHOT/samples-guice-1.5.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr/crypto/cipher/pom.xml to org.apache.shiro/shiro-crypto-cipher/1.5.0-SNAPSHOT/shiro-crypto-cipher-1.5.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr/crypto/cipher/target/shiro-crypto-cipher-1.5.0-SNAPSHOT.jar to org.apache.shiro/shiro-crypto-cipher/1.5.0-SNAPSHOT/shiro-crypto-cipher-1.5.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr/crypto/cipher/target/shiro-crypto-cipher-1.5.0-SNAPSHOT-javadoc.jar to org.apache.shiro/shiro-crypto-cipher/1.5.0-SNAPSHOT/shiro-crypto-cipher-1.5.0-SNAPSHOT-javadoc.jar[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr/crypto/cipher/target/shiro-crypto-cipher-1.5.0-SNAPSHOT-sources.jar to org.apache.shiro/shiro-crypto-cipher/1.5.0-SNAPSHOT/shiro-crypto-cipher-1.5.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr/samples/web/pom.xml to org.apache.shiro.samples/samples-web/1.5.0-SNAPSHOT/samples-web-1.5.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr/support/servlet-plugin/pom.xml to org.apache.shiro/shiro-servlet-plugin/1.5.0-SNAPSHOT/shiro-servlet-plugin-1.5.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr/support/spring/pom.xml to org.apache.shiro/shiro-spring/1.5.0-SNAPSHOT/shiro-spring-1.5.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr/support/guice/pom.xml to org.apache.shiro/shiro-guice/1.5.0-SNAPSHOT/shiro-guice-1.5.0-SNAPSHOT.pomchannel stoppedSetting status of c4eeef366bce54e9eeca1f7e65f09f3ed3e40ba3 to FAILURE with url https://builds.apache.org/job/Shiro-pr/157/ and message: 'FAILURE 'Using context: Jenkins: mvn clean install

@boris-petrov Hi! we have the japicmp maven plugin failed on the build because of backward incompatibility:
[ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.14.1:cmp (japicmp) on project shiro-web: There is at least one incompatibility: org.apache.shiro.web.servlet.Cookie.getSameSite():METHOD_ADDED_TO_INTERFACE,org.apache.shiro.web.servlet.Cookie.setSameSite(org.apache.shiro.web.servlet.Cookie$SameSiteOptions):METHOD_ADDED_TO_INTERFACE,org.apache.shiro.web.servlet.SimpleCookie.buildHeaderValue(java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String,int,int,boolean,boolean):METHOD_REMOVED

I think it's better to add a new method instead of update the existing one.
@bdemers Thoughts?

@boris-petrov I can't see a Jira about this issue, may be I missed it :)

@fpapon - I've created a JIRA issue.
Please tell me what to do with the failing test and I'll do it.

@fpapon @boris-petrov Agreed,
Your best bet is to overload the existing method with a new one, and just make the old call the new with the previous default (null or NONE, I'm guessing?)

Greetings, Im having trouble as well. How do I go about setting this within Shiro? I have an application that isn't completely operational and could use the help. I have tried setting
sessionManager.sessionIdCookie.comment = ;SameSite=Lax
and
sessionManager.sessionIdCookie.comment = ;SameSite=NONE
within WEB-INF/shiro.ini.
Is there a way to set this within the Session programmatically?

try something like:
sessionManager.sessionIdCookie.sameSite=LAX

You can set it programmatically too, how you do that depends on your application.  Are you using Spring, Guice, or just servlet filters?

Im using Spring.

That did not work.

Ahh, it doesn't look like that setting is directly exposed.  I just created: https://issues.apache.org/jira/browse/SHIRO-787
Ideally it would be something like, just setting the property:
shiro.sessionManager.cookie.sameSite=LAX

But, you should be able to work around this but doing something like:
    @Autowired
    private SessionManager sessionManager;

    @PostConstruct
    void updateCookieConfig() {
        ((DefaultWebSessionManager) sessionManager).getSessionIdCookie().setSameSite(Cookie.SameSiteOptions.LAX);
    }

I tried setting the SameSite attribute within my authentication routine, but still no luck. Maybe there is something wrong with my spring wiring?
Spring Config
`

<bean id="jdbcRealm" class="xyz.ioc.realms.JdbcRealm">
	<property name="credentialsMatcher" ref="hashedCredentialsMatcher"/>
</bean>

<bean id="sessionManager" class="org.apache.shiro.web.session.mgt.DefaultWebSessionManager"/>

<bean id="securityManager" class="org.apache.shiro.web.mgt.DefaultWebSecurityManager">
    <property name="realm" ref="jdbcRealm"/>
	<property name="sessionManager" ref="sessionManager"/>
</bean>

<bean id="shiroFilter" class="org.apache.shiro.spring.web.ShiroFilterFactoryBean">
    <property name="securityManager" ref="securityManager"/>
    <property name="loginUrl" value="auth/signin"/>
    <property name="successUrl" value="/"/>
    <property name="unauthorizedUrl" value="/unauthorized.jsp"/>
</bean>`

AuthController
			DefaultWebSessionManager defaultWebSessionManager = (DefaultWebSessionManager)securityManager.getSessionManager(); 			defaultWebSessionManager.getSessionIdCookie().setSameSite(Cookie.SameSiteOptions.NONE); 			defaultWebSessionManager.getSessionIdCookie().setSecure(true);
In addition, here is a link to my project. http://github.com/mcroteau/Zeus

What version of Shiro are you using?

1.5.3

Did you code get executed?

Nope, I wasn't able to get it working. Im on Shiro 1.5.3. Sorry it took so long.

Do I need to add what the following to every request?
DefaultWebSessionManager defaultWebSessionManager = (DefaultWebSessionManager)securityManager.getSessionManager();
defaultWebSessionManager.getSessionIdCookie().setSameSite(Cookie.SameSiteOptions.NONE);
defaultWebSessionManager.getSessionIdCookie().setSecure(true);

Hi @mcroteau. If you use a file-based  configuration, you can set it there.
If you use programatically, you might want to use a DefaultWebSessionManagerFactory or -Producer (for injection).

Would you be willing to provide an example?


[Doc Improvement][User mention limitation in Adaptive Card]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/task-modules-and-cards/cards/cards-format.md
96
9
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/task-modules-and-cards/cards/cards-format.md
96
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/task-modules-and-cards/cards/cards-format.md
96
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


HiDPI Icons

It would be nice to see HiDPI icons for the app. Pixelation can be seen here: #29

https://github.com/Sytten/Facebook-Messenger-Desktop/issues/11

Guys remember that this is just a wrapper, icons a downloaded from facebook servers. Dont know if there is a way to force them to download HI-DPI icons...


[Network] az network private-endpoint-connection: Update api version for Microsoft.DesktopVirtualization/hostpools and Microsoft.DesktopVirtualization/workspaces

Related command
az network commands should support the latest api version for Microsoft.DesktopVirtualization/hostpools and Microsoft.DesktopVirtualization/workspaces resources for the private Endpoint Types
Description
This updates Microsoft.DesktopVirtualization/hostpools and Microsoft.DesktopVirtualization/workspaces in the az network supported provider for private endpoints version from 2021-04-01-preview to the latest 2022-10-14-preview
Testing Guide
No changes.
History Notes

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

Network

@necusjz , just bumping in case you haven't seen this. Please let me know if you need anything else from me.


[Flake] macOS grpc_basictests_python

Recently, Homebrew frequently fails to fetch a GitHub repo which is essential to its package list udpate: fatal: unable to access 'https://github.com/Homebrew/homebrew-core/': transfer closed with outstanding read data remaining.
The update failure will result in downloading out-of-date pacakges, and lead to error like Error: unknown or unsupported macOS version: :lion. Also, Homebrew won't be able to install newer coreutils that includes md5sum.
It's unclear yet what is the culprit. It could be a Kokoro network issue, GitHub throttling, or a bug in Homebrew.
CC @veblush
Here is a short log section for this issue:
$ brew update-reset
...
==> Fetching /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core...
fatal: unable to access 'https://github.com/Homebrew/homebrew-core/': transfer closed with outstanding read data remaining

==> Resetting /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core...
Reset branch 'master'
Branch 'master' set up to track remote branch 'master' from 'origin'.
Your branch is up to date with 'origin/master'.

++ brew upgrade coreutils
==> Downloading https://homebrew.bintray.com/bottles-portable-ruby/portable-ruby-2.6.3_2.yosemite.bottle.tar.gz

#################                                                         24.0%
#############################################                             63.7%
######################################################################## 100.0%
==> Pouring portable-ruby-2.6.3_2.yosemite.bottle.tar.gz
Updating Homebrew...
Error: Failed to import: /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/amqp-cpp.rb
amqp-cpp: "cxx11" is not a recognized standard
Error: Failed to import: /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/apache-arrow.rb
apache-arrow: "cxx11" is not a recognized standard
Error: unknown or unsupported macOS version: :lion
...

https://source.cloud.google.com/results/invocations/5a142e21-1685-4d8f-9440-b98e903b815c/targets/grpc%2Fcore%2Fpull_request%2Fmacos%2Fgrpc_basictests_python/log

Thanks Lidi to take a look at this strange problem. All of sudden, grpc_basictests_python on the master started passing from 14:17 Sep 30. Maybe some other external component made a recent change?

There were two bugs caused macOS Python tests to fail, one is fixed in https://github.com/grpc/grpc/pull/24267, the other one is this network issue.
Another failed build after https://github.com/grpc/grpc/pull/24267 merged:
https://source.cloud.google.com/results/invocations/c6e8cac8-01e4-4de9-885b-1b870a1abd1a/targets/grpc%2Fcore%2Fmaster%2Fmacos%2Fgrpc_basictests_python/log
I guess we can see how flaky it is, then file a bug to Kokoro team.


[CARBONDATA-1405]Added support for gathering coverage information when tests are run

Using jacoco for coverage
Using coveralls for CI integration

LGTM


fatal error: sass/context.h: No such file or directory on Linux/amd64

Hello - I am running into a problem installing in our build environment.  I have much less control over that build environment than I would on my development machine - it is behind a firewall without access to github, and only accesses npm packages through an internal registry.  Because of that, downloading the binaries fails as expected and the install falls back on a build - unfortunately the build is failing as well.
I have tried to conform to the guidelines for submitting this issue as best as possible - searched for existing issues and could not find any with solutions in this situation.  Also, the node_modules/node-sass directory is not in the workspace after the installation fails (assuming it's cleaned up after the failure by npm) - and I have no way to upload the node-sass binary file either, so I am counting on the build working.  Finally, the actual project directory has been replaced with <project_dir> here in the log.
npm -v
3.10.8
node -v
v6.8.0
npm -v process.versions
{ http_parser: '2.7.0',
node: '6.8.0',
v8: '5.1.281.84',
uv: '1.9.1',
zlib: '1.2.8',
ares: '1.10.1-DEV',
icu: '57.1',
modules: '48',
openssl: '1.0.2j' }
npm -p process.platform
linux
npm -p process.arch
x64
Output from the build process

<EMAIL_ADDRESS>install <project_dir>/node_modules/node-sass
node scripts/install.js

Downloading binary from https://github.com/sass/node-sass/releases/download/v4.5.3/linux-x64-48_binding.node
Cannot download "https://github.com/sass/node-sass/releases/download/v4.5.3/linux-x64-48_binding.node":
connect EHOSTUNREACH <IP_ADDRESS>:443
Hint: If github.com is not accessible in your location
try setting a proxy via HTTP_PROXY, e.g.
  export HTTP_PROXY=http://example.com:1234

or configure npm proxy via
  npm config set proxy http://example.com:8080

<EMAIL_ADDRESS>postinstall <project_dir>/node_modules/node-sass
node scripts/build.js

Building: /usr/local/node-v6.8.0-linux-x64/bin/node <project_dir>/node_modules/node-gyp/bin/node-gyp.js rebuild --verbose --libsass_ext= --libsass_cflags= --libsass_ldflags= --libsass_library=
gyp info it worked if it ends with ok
gyp verb cli [ '/usr/local/node-v6.8.0-linux-x64/bin/node',
gyp verb cli   '<project_dir>/node_modules/node-gyp/bin/node-gyp.js',
gyp verb cli   'rebuild',
gyp verb cli   '--verbose',
gyp verb cli   '--libsass_ext=',
gyp verb cli   '--libsass_cflags=',
gyp verb cli   '--libsass_ldflags=',
gyp verb cli   '--libsass_library=' ]
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| linux | x64
gyp verb command rebuild []
gyp verb command clean []
gyp verb clean removing "build" directory
gyp verb command configure []
gyp verb check python checking for Python executable "python2" in the PATH
gyp verb which succeeded python2 /usr/bin/python2
gyp verb check python version /usr/bin/python2 -c "import platform; print(platform.python_version());" returned: "2.6.6\n"
gyp verb get node dir compiling against specified --nodedir dev files: /usr/local/node-v6.8.0-linux-x64
gyp verb build dir attempting to create "build" dir: <project_dir>/node_modules/node-sass/build
gyp verb build dir "build" dir needed to be created? <project_dir>/node_modules/node-sass/build
gyp verb build/config.gypi creating config file
gyp verb build/config.gypi writing out config file: <project_dir>/node_modules/node-sass/build/config.gypi
gyp verb config.gypi checking for gypi file: <project_dir>/node_modules/node-sass/config.gypi
gyp verb common.gypi checking for gypi file: <project_dir>/node_modules/node-sass/common.gypi
gyp verb gyp gyp format was not specified; forcing "make"
gyp info spawn /usr/bin/python2
gyp info spawn args [ '<project_dir>/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'make',
gyp info spawn args   '-I',
gyp info spawn args   '<project_dir>/node_modules/node-sass/build/config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '<project_dir>/node_modules/node-gyp/addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/usr/local/node-v6.8.0-linux-x64/include/node/common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=/usr/local/node-v6.8.0-linux-x64',
gyp info spawn args   '-Dnode_gyp_dir=<project_dir>/node_modules/node-gyp',
gyp info spawn args   '-Dnode_lib_file=/usr/local/node-v6.8.0-linux-x64/$(Configuration)/node.lib',
gyp info spawn args   '-Dmodule_root_dir=<project_dir>/node_modules/node-sass',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'build',
gyp info spawn args   '-Goutput_dir=.' ]
gyp verb command build []
gyp verb build type Release
gyp verb architecture x64
gyp verb node dev dir /usr/local/node-v6.8.0-linux-x64
gyp verb which succeeded for make /usr/bin/make
gyp info spawn make
gyp info spawn args [ 'V=1', 'BUILDTYPE=Release', '-C', 'build' ]
make: Entering directory <project_dir>/node_modules/node-sass/build'   g++ '-DNODE_GYP_MODULE_NAME=binding' '-DUSING_UV_SHARED=1' '-DUSING_V8_SHARED=1' '-DV8_DEPRECATION_WARNINGS=1' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' '-DBUILDING_NODE_EXTENSION' -I/usr/local/node-v6.8.0-linux-x64/include/node -I/usr/local/node-v6.8.0-linux-x64/src -I/usr/local/node-v6.8.0-linux-x64/deps/uv/include -I/usr/local/node-v6.8.0-linux-x64/deps/v8/include -I../../nan  -fPIC -pthread -Wall -Wextra -Wno-unused-parameter -m64 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++0x -std=c++0x -MMD -MF ./Release/.deps/Release/obj.target/binding/src/binding.o.d.raw   -c -o Release/obj.target/binding/src/binding.o ../src/binding.cpp In file included from ../src/binding.cpp:3:0: ../src/sass_context_wrapper.h:8:26: fatal error: sass/context.h: No such file or directory compilation terminated. make: *** [Release/obj.target/binding/src/binding.o] Error 1 make: Leaving directory <project_dir>/node_modules/node-sass/build'
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (<project_dir>/node_modules/node-gyp/lib/build.js:258:23)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:191:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)
gyp ERR! System Linux 2.6.32-431.el6.x86_64
gyp ERR! command "/usr/local/node-v6.8.0-linux-x64/bin/node" "<project_dir>/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
gyp ERR! cwd <project_dir>/node_modules/node-sass
gyp ERR! node -v v6.8.0
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok
Build failed with error code: 1

It looks like libsass source code is not there during the build... can you check if it libsass is there under src?

Trying to figure a way to check that - I can't seem to find a way to get npm to not clean up the <project_dir>/node_modules/node-sass directory after the failed deployment.

I found a work-around for getting npm to keep the <project_dir>/node_modules/node-sass directory - using the --ignore-scripts install option .  This isn't ideal though because the poistinstall script won't run, but at least I can see the package as it's downloaded.  I can confirm from this that the src/libsass directory is there and appears to populated with the full libsass project / source.

Thanks to some help at npm I found the way to keep that failed install directory - set rollback=false ( https://docs.npmjs.com/misc/config#rollback ).  I can confirm src/libsass is in the directory when the install fails with that postinstall script.

I believe I have identified the problem although my lack of control over the build environment means I need some help to test a solution.  It appears that the condition 'libsass_ext == "" or libsass_ext == "no"' within /binding.gyp is not being matched when the default argument '--libsass_ext=' is provided to the node-gyp script by the postinstall script scripts/build.js.  This of course results in not having libsass added as a dependency.  I can test this in my build environment through what I have control over - which is running a preinstall script in my project - and from there I can execute node-gyp the exact same way it is executed via scripts/build.js.  Here is the command that fails:
const path = require('path');
const spawnSync = require('child_process').spawnSync;
var nodeGypArgs = [require.resolve(path.join('node-gyp', 'bin', 'node-gyp.js')),
'rebuild', '--verbose', '--libsass_ext=', '--libsass_cflags=', '--libsass_ldflags=', '--libsass_library='];
console.log(process.execPath + ' ' + nodeGypArgs.join(' '));
spawnSync(process.execPath, nodeGypArgs, {cwd: path.join(, 'node_modules', 'node-sass'), stdio: 'inherit'});
If we simply change the libsass_ext argument to '--libsass_ext=no' then the build succeeds.  The following builds successfully:
const path = require('path');
const spawnSync = require('child_process').spawnSync;
var nodeGypArgs = [require.resolve(path.join('node-gyp', 'bin', 'node-gyp.js')),
'rebuild', '--verbose', '--libsass_ext=no', '--libsass_cflags=', '--libsass_ldflags=', '--libsass_library='];
console.log(process.execPath + ' ' + nodeGypArgs.join(' '));
spawnSync(process.execPath, nodeGypArgs, {cwd: path.join(, 'node_modules', 'node-sass'), stdio: 'inherit'});

I wonder what in your environment breaks this?
I just tried your non-working script and I got:
gyp info it worked if it ends with ok
gyp verb cli [ '/usr/local/bin/node',
gyp verb cli   '/home/saper/node_modules/node-sass/node_modules/node-gyp/bin/node-gyp.js',
gyp verb cli   'rebuild',
gyp verb cli   '--verbose',
gyp verb cli   '--libsass_ext=',
gyp verb cli   '--libsass_cflags=',
gyp verb cli   '--libsass_ldflags=',
gyp verb cli   '--libsass_library=' ]

which is the same as you did - and the build proceeds happily.

What kind of shell are you using?

It's bash - the whole thing is being orchestrated by Jenkins by the way.  I'm going to take a look at the node-gyp script and see how it's picking the arguments up.

The next thing I noticed you are forced to use Python 2.6, but that should work as well.

One more thing, how do variables in question look like in your node_modules/node-sass/build/config.gypi file?

Ah yes - thanks - the value in config.gypi looks like it confirms the problem:
"libsass_ext": 0,

It's being set to the default value for an integer variable.

Same thing for all the others set to an empty value by the way:
"libsass_ext": 0,
"libsass_cflags": 0,
"libsass_ldflags": 0,
"libsass_library": 0,

Drilled down a bit further - which version of the nopt package do you have installed?

Python 2.7 is reguired for node-gyp https://github.com/nodejs/node-gyp#installation

I've got a local test now that I can reproduce the issue in finally - it has Python 2.7 installed so I can confirm the slightly older version of Python installed in the build environment did not affect this issue.  I think I can describe the whole situation at this point:
There is one specific change / fix in the nopt package https://github.com/npm/nopt/commit/c3b8bf0cf6689d9f712cc993e6cd5c50ec8ff030 - versions prior to this change (2.*) will fail in the failure scenario I described above, but anything with that change / fix (>=3.0.0) will succeed.  So the issue here is with the node-gyp dependency on nopt:
"dependencies": {
...
"nopt": "2 || 3",
...
},
This means anything in that range is valid - and we have a transient dependency in our project on<EMAIL_ADDRESS>so npm installs that and allows node-gyp to use it since it also satisfies the node-gyp dependency.
With that in mind, the test case can now be:

Create an empty directory with the following package.json:
{
"name": "test",
"version": "1.0.0",
"private": true,
"description": "test",
"scripts": {},
"dependencies": {
"nopt": "2.1.1",
"node-sass": "4.5.3"
},
"devDependencies": {}
}
npm install
cd node_modules/node-sass
The following will fail:
node ../node-gyp/bin/node-gyp rebuild --verbose --libsass_ext= --libsass_cflags= --libsass_ldflags= --libsass_library=
The following will succeed:
node ../node-gyp/bin/node-gyp rebuild --verbose --libsass_ext=no --libsass_cflags= --libsass_ldflags= --libsass_library=

Thank you, this looks like it! https://github.com/npm/nopt/issues/24 might be related. I only wonder what shall we do (except for bumping nlog dependency for us). Maybe make sure we don't pass those options if they are unset? They are rarely needed ( I think I am the only user of these :).

Yeah - I think not passing the options if they are unset then using node-gyp's support for setting default values on all of those variables should work well.  So then binding.gyp would be updated to include:
'variables': {
'libsass_ext%': '',
'libsass_cflags%': '',
'libsass_ldflags%': '',
'libsass_library%': ''
},
...
And scripts/build.js would be updated to not pass the options that aren't set on the env like you said:
function build(options) {
var args = [require.resolve(path.join('node-gyp', 'bin', 'node-gyp.js')), 'rebuild', '--verbose'].concat(
['libsass_ext', 'libsass_cflags', 'libsass_ldflags', 'libsass_library'].filter(function(subject) {
return !!(process.env[subject.toUpperCase()]);
}).map(function(subject) {
return ['--', subject, '=', process.env[subject.toUpperCase()] || ''].join('');
})
).concat(options.args);
...
This all seemed to work properly in a simple test without any of those parameters set in the environment.

For posterity, I'd like to specifically mention the workaround: LIBSASS_EXT="no" npm install

I'd like to add that installing libsass via pacman solved the issue for me (Manjaro/Arch).

When I  install node-sass on raspberry(raspbian stretch), I met the same mistake.
node version:  6.13
npm version:  3.10.10
node-sass verion: last version

I also encountered a similar issue and any of the below approaches worked:

LIBSASS_EXT="no" npm install (solution provided by @stevenvergenz above)

Set the LIBSASS_EXT environment variable before running the 'npm install command'

Install libsass before so that all the necessary library files are available for node-sass to install successfully.

NOTE: The libsass folder is not getting installed prior to 'node-sass' due to the value of the variable not being available.


20-transfer: store trace information in metadata instead of storing it separately

Also, take the trace as user input and calculate the hash instead of looking up (so we shouldn't need to look it up from metadata).

This would require users to pass in the full denom and trace history. Given that this is a performance improvement that hasn't been requested which requires UX to lessen, I will close the issue. A new issue can be opened if the 1 disc read becomes a serious concern (in addition to the extra storage), but I imagine not


Migrate 'Your manuals' page to design system

What
Migrate the 'Your manuals' view to the GDS Design System.
Why
This is part of the migration of all of the Manuals Publisher pages to the GDS Design System.
Visuals
Before

After

Trello
Trello card
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
Follow these steps if you are doing a Rails upgrade.

This PR should be merged at the same time as alphagov/smokey#1184 to avoid breaking the Smokey tests.


MRTK GA Release Progress

Overview
Here's the current timeline for the MRTK3 GA

[x] Aug 21 - Microsoft announces new organization
[x] Aug 21 - Make new repository public
[x] Aug 21 - Pre-release MRTK3 preview 18
[x] Sep 6-13 - Release MRTK3 GA via Microsoft's NPM feed using org.mixedrealitytoolkit.* packages

Details

Start Date
End Date
Task
Owner
Progress

Fri, Aug 11
Fri, Aug 11
Create "releases/3.0.0-pre.18” branch in new repository.
@shaynie
Completed

Fri, Aug 11
Fri, Aug 11
Create preview packages for 3.0.0-pre.18
@shaynie
Completed

Fri, Aug 11
Fri, Aug 11
Final reviews with writers about new MRTK Org announcement.
@kevincol
Completed

Mon, Aug 14
Tue, Aug 22
Microsoft validates 3.0.0-pre.18 preview packages
Microsoft
Completed

Wed, Aug 21
Wed, Aug 21
Microsoft announces new MRTK Organization. Microsoft posts an announcement on the Microsoft Tech site.
Kevin Collins
Completed

Wed, Aug 21
Wed, Aug 21
Publish MRTK 3.0.0-pre.18 packages to NPM feed (and MRFT), and project's releases page.
Microsoft
Completed

Wed, Aug 21
Wed, Aug 21
Publish MRTK 3.0.0-pre.18 release notes
Microsoft
Completed

Wed, Aug 21
Wed, Aug 21
Create "releases/3.0.0” branch in new repository.
@shaynie
Completed

Tue, Sep 6
Tue, Sep 13
Create final GA package for 3.0.0
@shaynie
Completed

Wed, Sep 6
Wed, Sep 13
Publish MRTK 3.0.0 (GA) packages to NPM feed (and MRFT), and project's releases page. This includes packages and release notes.
Microsoft
Completed

Wed, Sep 6
Wed, Sep 13
Publish MRTK 3.0.0 (GA) release notes
Microsoft
Completed

Wed, Sep 6
Thu, Sep 13
Publish MRTK3 API Reference Docs
Microsoft
Completed

Also completed and published learning paths


Validating Runtime Dependency: Functions Runtime

Does this occur consistently?
Repro steps:

Version: 1.15.3
OS: win32
OS Release: 10.0.19045
Product: Visual Studio Code
Product Version: 1.93.1
Language: en

Please provide repro steps and details about your issue.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


FileStoragePlugin: call the FileStorageService immediately (not debounced) on the first time

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 99.651%

Totals

Change from base Build<PHONE_NUMBER>7:
0.01%

Covered Lines:
12810

Relevant Lines:
12811

💛  - Coveralls


Support passing Enum types directly to make_executable_schema

Passing Enum type to make_executable_schema directly should be supported.
This will also need a research to see what should be done in conflict situations like:

Enum with name was already defined in schema, but has different values.
Enum with name wasn't defined in schema (create GraphQL type or raise error? this is mostly for future compat with Ariadne server lib.)

Done in #32


ms-python extension does not run

Web Browser: Chrome Version 83.0.4103.106 (Official Build) (64-bit)
Local OS: macOS High Sierra 10.13.6
Remote OS: Ubuntu 18.04
Remote Architecture: x65
code-server --version: 3.4.1 48f7c2724827e526eeaa6c2c151c520f48a61259

Just installed code server. I tried it about a month ago and got full ms-python language support, but now (after a fresh machine/install) I get the following errors in console:
Error Python Extension: 2020-07-29 03:55:52: Failure during activation. [Error: The number of constructor arguments in the derived class o must be >= than the number of constructor arguments of its base class.
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261081
	at Array.forEach (<anonymous>)
	at e (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:260644)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261118
	at Array.forEach (<anonymous>)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261097
	at Array.forEach (<anonymous>)
	at e (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:260644)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261118
	at Array.forEach (<anonymous>)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261097
	at Array.forEach (<anonymous>)
	at e (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:260644)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261118
	at Array.forEach (<anonymous>)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261097
	at Array.forEach (<anonymous>)
	at e (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:260644)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261118
	at Array.forEach (<anonymous>)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261097
	at Array.forEach (<anonymous>)
	at e (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:260644)
	at Object.t.plan (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261159)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:257812
	at e._get (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:257721)
	at e.get (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:256432)
	at a.get (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:48:1001920)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:280985
	at processTicksAndRejections (internal/process/task_queues.js:97:5)]
t.log @ console.ts:112
console.ts:137 [Extension Host] Error Python Extension: 2020-07-29 03:55:52: sendStartupTelemetry() failed. [Error: The number of constructor arguments in the derived class o must be >= than the number of constructor arguments of its base class.
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261081
	at Array.forEach (<anonymous>)
	at e (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:260644)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261118
	at Array.forEach (<anonymous>)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261097
	at Array.forEach (<anonymous>)
	at e (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:260644)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261118
	at Array.forEach (<anonymous>)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261097
	at Array.forEach (<anonymous>)
	at e (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:260644)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261118
	at Array.forEach (<anonymous>)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261097
	at Array.forEach (<anonymous>)
	at e (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:260644)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261118
	at Array.forEach (<anonymous>)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261097
	at Array.forEach (<anonymous>)
	at e (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:260644)
	at Object.t.plan (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261159)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:257812
	at e._get (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:257721)
	at e.get (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:256432)
	at a.get (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:48:1001920)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:280985
	at processTicksAndRejections (internal/process/task_queues.js:97:5)] {  vslsStack: [    CallSite {}, CallSite {}, CallSite {},    CallSite {}, CallSite {}, CallSite {},    CallSite {}, CallSite {}, CallSite {},    CallSite {}, CallSite {}, CallSite {},    CallSite {}, CallSite {}, CallSite {},    CallSite {}, CallSite {}, CallSite {},    CallSite {}, CallSite {}, CallSite {},    CallSite {}, CallSite {}, CallSite {},    CallSite {}, CallSite {}, CallSite {},    CallSite {}, CallSite {}, CallSite {}  ]}
t.log @ console.ts:112
console.ts:137 [Extension Host] rejected promise not handled within 1 second: Error: The number of constructor arguments in the derived class o must be >= than the number of constructor arguments of its base class.
t.log @ console.ts:112
console.ts:137 [Extension Host] stack trace: Error: The number of constructor arguments in the derived class o must be >= than the number of constructor arguments of its base class.
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261081
	at Array.forEach (<anonymous>)
	at e (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:260644)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261118
	at Array.forEach (<anonymous>)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261097
	at Array.forEach (<anonymous>)
	at e (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:260644)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261118
	at Array.forEach (<anonymous>)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261097
	at Array.forEach (<anonymous>)
	at e (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:260644)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261118
	at Array.forEach (<anonymous>)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261097
	at Array.forEach (<anonymous>)
	at e (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:260644)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261118
	at Array.forEach (<anonymous>)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261097
	at Array.forEach (<anonymous>)
	at e (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:260644)
	at Object.t.plan (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:261159)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:257812
	at e._get (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:257721)
	at e.get (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:256432)
	at a.get (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:48:1001920)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39:280985
	at processTicksAndRejections (internal/process/task_queues.js:97:5)
t.log @ console.ts:112
mainThreadExtensionService.ts:65 [[object Object]]The number of constructor arguments in the derived class o must be >= than the number of constructor arguments of its base class.
$onExtensionRuntimeError @ mainThreadExtensionService.ts:47
mainThreadExtensionService.ts:66 Error: The number of constructor arguments in the derived class o must be >= than the number of constructor arguments of its base class.

	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39
	at Array.forEach (<anonymous>)
	at e (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39
	at Array.forEach (<anonymous>)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39
	at Array.forEach (<anonymous>)
	at e (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39
	at Array.forEach (<anonymous>)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39
	at Array.forEach (<anonymous>)
	at e (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39
	at Array.forEach (<anonymous>)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39
	at Array.forEach (<anonymous>)
	at e (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39
	at Array.forEach (<anonymous>)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39
	at Array.forEach (<anonymous>)
	at e (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39)
	at Object.t.plan (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39
	at e._get (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39)
	at e.get (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39)
	at a.get (/home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:48)
	at /home/myuser/.local/share/code-server/extensions/ms-python.python-2020.6.91350/out/client/extension.js:39
	at processTicksAndRejections (/<path>/internal/process/task_queues.js:97)

After these message I get a whole stream of successful "info" messages of the style:
[Extension Host] Info Python Extension: 2020-07-29 03:56:10: Rule = settings, result = runNextRule

The extension then proceeds to correctly detect my python installation (3.7.6 64-bit {'base': conda}) and display it in the bottom status bar. None of the Python features work – not intellisense, linting, etc., and trying to run any of the > Python: commands results in:
Command 'Python: Start REPL' resulted in an error (command 'python.startREPL' not found)

Running with --log debug produces no output on loading the extension.
Thank you.

Ah yeah I haven't looked into it to be sure if it's not something on our side but it looks like the latest version of the Python extension has some issues. See https://github.com/cdr/code-server/issues/1837#issuecomment-653800193 for the last known version that works.
I'll close this as a duplicate of #1837.


implement create?

is there any particular reason create is not implemented?

no, not really, that's right (at least no other than "there is no way that our user will need that").
I'll add it.


Plugin is not supported in Intelij 2021.1

The plugin cannot be loaded into Intelij 2021.1, even when installed from disk.
Expected behavior
The plugin can be loaded by Intelij 2021.1
Version information

IDEA Version: 2021.1
JDK Version:1.8.0_281
OS Type & Version:Windows 10
Lombok Plugin Version:0.34.1_

Steps to reproduce
What steps do we need to take to reproduce this issue?

Attempt to install the plugin
Plugin Lombok version 0.34.1 is not compatible with the current version of the IDE

Is there a hack that can resolve this in the meantime?

Maybe, I'm not representative of this community, but
From Readme.md:

💥 Breaking News: Starting with IntelliJ version 2020.3 lombok plugin will be integrated and included in IntelliJ by default!. 💥

I have just now upgraded intellij to newest version (i.e. 2021.1) and Lombok is bundled(Therefore, it is not needed to install manually) in newest version and everything is working very smoothly right now.
Please try it again, if not working, escalate it again.

I am closing this issue, it is now bundled

The plugin cannot be loaded into Intelij 2021.1, even when installed from disk.
Expected behavior
The plugin can be loaded by Intelij 2021.1
Version information
* **IDEA Version: 2021.1**

* **JDK Version:1.8.0_281**

* **OS Type & Version:Windows 10**

* **Lombok Plugin Version:0.34.1**_

Steps to reproduce
What steps do we need to take to reproduce this issue?
1. Attempt to install the plugin

2. Plugin Lombok version 0.34.1 is not compatible with the current version of the IDE

Is there a hack that can resolve this in the meantime?

I also got the save incompatibility version error message.
Plugin 'Lombok' (version '0.34.1-2021.1') is not compatible with the current version of the IDE, because it requires build 191.* or older but the current build is IE-212.5284.55
I changed the version in plugin.xml file of META-INF directory of lombok-plugin-0.34.1-2019.1.jar file and It works for me. These are the steps which I did to change the idea version.

Download idea plugin jar file from Jetbrains website: https://plugins.jetbrains.com/plugin/6317-lombok/versions/stable/108259
Extract ZIP file
Go to lib directory lombok-plugin-0.34.1-2019.1 > lombok-plugin > lib
Copy or download META-INF > plugin.xml file from lombok-plugin-0.34.1-2019.1.jar file. Create META-INF directory inside lib directory and paste plugin.xml in META-INF directory.
Search idea version '191.*' and replace your IntelliJ IDE version. For example, I have installed Intellij IE-212.5284.55. So replaced the line as below
<idea-version since-build="191.6183" until-build="IE-212.*"/>
Save it and replace plugin.xml file in lombok-plugin-0.34.1-2019.1.jar using below command.
jar uf lombok-plugin-0.34.1-2019.1.jar META-INF/plugin.xml
Go to IntelliJ plugins and install this plugin.

I have attached my META-INF directory of Lombok plugin for reference.
META-INF.zip

Further from  [@DilipDalwadi (https://github.com/mplushnikov/lombok-intellij-plugin/issues/1028#issuecomment-937485680) I downloaded lombok-plugin-0.34-2020.2.zip from marketplace, unzip it, went to the META-INF directory, changed in the xml file the line to , then saved the zip, installed the plugin from disk on Android Studio.  Things seem to work - previous errors regarding unresolved getter functions now gone.  Pretty brute force.  Not sure if there will be side effects, but who knows if this plugin will be updated after next year?


Errors related to Float80 when  trying to compile on Raspberry Pi 3

I am trying to compile a vapor project that uses this repository on a Raspberry Pi 3 (w/ Ubuntu 16.04) but it fails with the errors below.
I might be wrong but from what I was able to find, Float80 is not available for ARM-based platforms.
Is there a way to overcome this error?
Thanks in advance!
The errors I get are:
/home/xxx/yyy-master/.build/checkouts/mysql.git-1505813759/Sources/MySQL/Connection/MySQLData.swift:219:24: error: use of unresolved identifier 'Float80'
.flatMap { Float80($0) }
^~~~~~~
Swift.Float:1:15: note: did you mean 'Float'?
public struct Float {
^
Swift.Float32:1:18: note: did you mean 'Float32'?
public typealias Float32 = Float
^
Swift.Float64:1:18: note: did you mean 'Float64'?
public typealias Float64 = Double
^
SwiftGlibc.float_t:1:18: note: did you mean 'float_t'?
public typealias float_t = Float
^
/home/xxx/yyy-master/.build/checkouts/mysql.git-1505813759/Sources/MySQL/Connection/MySQLData.swift:237:36: error: use of unresolved identifier 'Float80'
.flatMap { Float80($0) }
^~~~~~~
Swift.Float:1:15: note: did you mean 'Float'?
public struct Float {
^
Swift.Float32:1:18: note: did you mean 'Float32'?
public typealias Float32 = Float
^
Swift.Float64:1:18: note: did you mean 'Float64'?
public typealias Float64 = Double
^
SwiftGlibc.float_t:1:18: note: did you mean 'float_t'?
public typealias float_t = Float

I got that error on my ODROID XU4 too but I only changed Float by Float80 in that class and it worked.

Fixed in 3.2.6, thanks!


Zadnor duels

Hey there !
Are there any plans to add the other 2 duels in Zadnor?   aka. Menesius sas Lanatus and Lyon the Beast King
Thank you !

Plan to do it eventually, not very soon due to lack of time though.

Thanks for your hard work !

Dont know how to send you private message. I'd pay if it helps to implement these duels faster.

hey, id really like to get the other 2 duels, any chance to speed them up if i pay some? DM me

Outdated. Module are added as they are created.


chore: Add / tweak doc examples for use in dev docs

This commit does the following:

Add dependency on anyhow for examples, to simplify errors in example code
Disable rustfmt for docs_examples.rs, because cargo fmt was wrapping the
function signatures onto multiple lines, which was making things show up
weird in the dev docs
Add some additional rust examples to be used in cheat sheets.

I think cheat sheet was deleted again


Incident creation on vulnerabilities

Hi,
Thanks for a great effort you have put on developing this connector. And sorry for un-formal issue.
I tested 0.2.1 with docker and was able to enrich vulnerabilities, but I cannot get incident creation to work. Has it even been implemented for vulnerabilities?
I followed the docs in detail, and checked that incident creation is enabled and indicator is not required, but i just get the sightings, but no incident. Tested with per-query.
Also, it would be a great addition to have incident creation mode per-system.

Hei,
Thank you very much for testing! Yes, every single entity has been tested. Vulnerabilities as well. It sounds to me that you may need to configure  vulnerability_incident_cvss3_score_threshold, which by default is disabled in order to not flood you with alerts (depending on your sources, agents and patching procedures). Tell me if that helps you.
I see now that it is confusing that this setting is separate from the other "create_incident_" settings. I will work on that in the docs. Any suggestions are very welcome.
Note that I added two changes to dev today that may be relevant as well:

If CVSS3 score is not present, but CVSS3 severity is, severity is used as a fallback when determining whether the score meets the aforementioned threshold
If the vulnerability does no contain a published date, this no longer causes an exception

I must also note that I have only just recently begun running tests with plenty of real-world real-time IoCs, which presents a number of challenges in terms of noise. I'm focusing on addressing this going forward with the project.

After some more testing, I believe there may still be a bug in the logic that determines whether a vulnerability should cause an incident or not. I'll investigate.

The bug should be fixed now.

The documentation is now updated with a reference to the setting required for vulnerability incident creation. It will published on the next release. I hope this solves your issue, along with the aforementioned fixes. Feel free to reopen the issue if you still experience issues.


updated styles.css pricing h2 section

updated styles.css pricing h2 section to match style with other headers and be consistent with the style.

I propose to undo sticky navbar feature as when you click on any link on the navbar, when it scrolls down to the selected section, sticky bar overlaps with the section text.


feat: helm chart oci field for addons

depends on #27
adds a field for OCI registry to get helm charts from

can you please move ValidateTopology stuff in a separate PR


Can not add arm modes to areas

Alarmo Version
1.8.5
HA Version
2022.3.1
Bug description
The flip buttons don't to anything. I can not add arm modes to any area.
https://share.vidyard.com/watch/rwMdCViJGdbHpQWCdYF2Z1?
Steps to reproduce
No response
Relevant log output
No response

Duplicate issue.


Ability to define WebSocket Extensions

Environment Details

Helidon Version: 2.0.0-M2
Helidon SE or Helidon MP: MP
JDK version: N/A
OS: N/A
Docker version (if applicable):

Problem Description
WebSocket implementation does not permit defining of installed extensions. This is predicated on another change being performed in Tyrus before this can work: (eclipse-ee4j/tyrus#694).
I think the change would be overriding the #getInstalledExtensions method in here but not sure of how the actual Extension classes should be passed/loaded into it.
Steps to reproduce
N/A

@dansiviter Interesting, what extension are you looking to use?

@spericas permessage-deflate is the key one. It massively shrinks the websocket frames which is very useful for larger messages when clients are not geographically close.
It looks like Tyrus needs to do some work before Helidon can leverage it though. Undertow uses #installedExtensions as a basis for all endpoints, but Tyrus doesn't for some reason. 🤷♂

I've submitted a PR to Tyrus to link this to {{WebsocketContainer#getInstalledExtensions}} (eclipse-ee4j/tyrus#695). With this it may just be a case of overriding {{TyrusServerContainer#getInstalledExtensions}} in {{TyrusSupport}}.

Looks like 2.0.0-M1 of Tyrus has this in. I'll create a PR when it's made it to release version.

Implemented by PR #1934. Thanks @dansiviter


GIFs getting the same hash when the first frame is identical

Hi,
When generating hash values for two GIF files. I'm getting the same hash value for both if the first frame in both is identical.

Is that the expected behavior?
Thanks!

it currently is, but maybe we can alter it to something you seem appropriate.
What behavior would you like?
Create a single hash for the entire gif?

Concatenate different hashes for each frame? (Same gif will match but different order won't, this will prevent comparison of  gifs with different number of frames.
Creating a hash object for each individual image and group it in some kind of way to be able to compare all images and a single image within the gifs? (Search if individual images match within a collection?)
....

My suggestion is to create a "gif hash collection" allowing for different similarity distances.
'intersect' find image matches contained in both gif collections
'distinct' 1 - intersect
'totalDistance' summed distance frame by frame
'minDistance' summed distance for each frame to the closest frame
'distanceShifted' total distance but shifted to create the lowest value

I like what you suggest. A couple of things:

intersect - to find image matches in both collections, you'll have to allow for giving a minimum similarity value
What do you mean by distinct?
Maybe give a result of average distance and variance?

Thanks!

I define distinct as the inverse operation of intersection. Return all images which are unique to one collection.
The issue tracker serves as notes and comments, therefore don't worry if it gets a bit messy. I am just writing down random thoughts.
Coding all of this is trivial and can be done within a short time, the issue arrises from a design point perspective:

For my liking I would create a new class similar to FuzzyHash which groups hashes together. The hash object can be returned from the hashing algorithm easily if it extends Hash. If this is done maybe it's time to implement a new abstract super class hash collection.
Searching for images is more a feature of an `ImageMatcher' rather than a hash object. Semantically creating a hash object bothers me a tiny bit (We could query if an image is contained in the gif).
The base functionalities of the default hash object is still valid, therefore inheritance is the way to go but at the same time it's also a composition.

Note: This link explains how frames can be extracted from gif images:  https://stackoverflow.com/questions/8933893/convert-each-animated-gif-frame-to-a-separate-bufferedimage . This method requires a file as an input, we should also support a utility loader for gif images to not require the user to perform the same FileIO multiple times if he want's to hash the same gif with multiple algorithms. Are there any gif containers available or should we create our own bufferedImagecollection?
Do we want to overload the hash method of hashing algorithms checking if the supplied image is a gif and create the appropriate GifHashCollection, or create an entirely new method hashGif?


Assume/Abort in sub Steps creates Passed Scenario in the report with odd count of Steps/Skipped

Describe the bug
Hi!
Related to #299 in a way...
When an Assume/Abort - statement is made to stop the Scenario if needed, the Scenario-status in the @After-part (scenario.getStatus())  says SKIPPED.
However, I only get a Skipped Scenario in the report if there are no (zero) successful Steps completed.
If one or more Steps are completed before the Assume/Abort takes place, the Scenario is Passed in the Report.
Also, it does not calculate the skipped steps correctly, well , I added two snapshots for a look.
To Reproduce
Steps to reproduce the behavior:
Create a Feature with at least two Steps
Perform a
assumeTrue(false,"Oh No");
or
org.junit.jupiter.api.Assumptions.abort("stopping after a few steps");
at
Test 1/ the first Step of the Feature
Test 2/ the last Step of the Feature
1 => Skipped
2 => Passed
Expected behavior
I'd assume,  :-)  , that since the scenario.getStatus() reports SKIPPED, I'd get  Skipped scenarios in both cases in the Report.
Attachments
2 Scenarios with Assume/Abort done in sub steps of their Features.

** Note **
Cucumber 7.11.1, JUnit 5.9.3

Thank you for reporting, I will look into this.

A scenario is considered skipped when all steps are skipped. When there are passing steps before it is considered passed. This is according to the official Cucumber guidelines.

(see issue https://github.com/trivago/cluecumber/issues/283)
Could you send me the JSON result file of your use case so I can check this better?

Your example shows a passed step and then a skipped one. According to the Cucumber specs, this is considered passed.

@bischoffdev the state of a scenario is the most severe status of it's steps. But I didn't look at the json, maybe I'm reading your comment wrong.
https://github.com/cucumber/cucumber-jvm/blob/main/cucumber-core/src/main/java/io/cucumber/core/runner/TestCaseState.java#L54

I just tried Allure-reporting and got this for an Assume()/Abort() operation:
(w/o any claims of what is wrong or right, just as info)

@mpkorstanje this is interesting. What does "the most severe" status mean concretely?
I know the status constants are
PASSED,
SKIPPED,
PENDING,
UNDEFINED,
AMBIGUOUS,
FAILED,
UNUSED

Would that mean that any step status that is lower down the list than any other steps in the scenario determines the scenario status? If so, this is new info. I remember getting my initial info from the Cucumber Slack.
E.g.
Step 1: passed
Step 2: skipped
Step 3: skipped

=> Scenario is skipped?
According to my former info, this would be considered passed.

Yes, this specific example the scenario would be skipped.
Not sure what you got from Slack. I do remember this conversation:
https://cucumberbdd.slack.com/archives/C60TKS3SL/p1532961939000185?thread_ts=1532961939.000185&cid=C60TKS3SL

Ah cool! So I will refine the state handling again and adjust it to the official way. Thanks for your input!

Ready to release in v3.3.0


Update Webpacker to 5

Fixes #
Describe the changes you have made in this PR -
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Coverage decreased (-0.2%) to 87.843% when pulling dddf89dbc2ceaabae080c107dc0c473ef92f0cb7 on new_UI into 6b412d5e5198aa79bc2dea3db02574f24ac66231 on master.


FF ONLY Merge 0.6.x into master, November 16

$ git checkout -b merge-0.6.x-into-master-november-16

$ export mb=$(git merge-base scala-js/0.6.x scala-js/master)

$ git log --graph --oneline --decorate $mb..scala-js/0.6.x | cat
*   89928cd32 (scala-js/0.6.x, 0.6.x) Merge pull request #3855 from gzm0/fix-locale-string-test
|\
| * 08de5c049 Fix BigInt.toLocaleString test
|/
*   9fba684d2 Merge pull request #3849 from gzm0/array-select-side-effect
|\
| * f18a9b4c8 Fix #3848: Classify ArraySelect as side effecting
* |   462889c64 Merge pull request #3850 from sjrd/blacklist-compiler-plugin-partest-2.12.9
|\ \
| |/
|/|
| * c6fb0f5e8 Blacklist partest tests involving compiler plugins in 2.12.9.
|/
*   2af728be3 (sjrd/0.6.x) Merge pull request #3847 from sjrd/fix-checksizes
|\
| * dfbf71b75 Ignore 2.12.9 in checksizes, not 2.12.10.
|/
* b13321948 Merge pull request #3786 from exoego/0.6-bigint
* dd2712bd0 Add js.BigInt for ES2019 (ES10)

$ git merge --no-commit scala-js/0.6.x
CONFLICT (modify/delete): tools/shared/src/main/scala/org/scalajs/core/tools/linker/backend/emitter/FunctionEmitter.scala deleted in HEAD and modified in scala-js/0.6.x. Version scala-js/0.6.x of tools/shared/src/main/scala/org/scalajs/core/tools/linker/backend/emitter/FunctionEmitter.scala left in tree.
Auto-merging test-suite/js/src/test/scala/org/scalajs/testsuite/typedarray/TypedArrayTest.scala
Auto-merging partest-suite/src/test/resources/scala/tools/partest/scalajs/2.12.9/WhitelistedTests.txt
Auto-merging partest-suite/src/test/resources/scala/tools/partest/scalajs/2.12.9/BlacklistedTests.txt
Auto-merging ci/checksizes.sh
CONFLICT (content): Merge conflict in ci/checksizes.sh
Automatic merge failed; fix conflicts and then commit the result.

$ git commit
[merge-0.6.x-into-master-november-16 d2b6009d7] Merge '0.6.x' into 'master'

Looks like AppVeyor didn't like it :s

Updated (including log)

[error] C:\projects\scala-js\test-suite\js\src\test\scala\org\scalajs\testsuite\library\BigIntTest.scala:25:55: value executingInBrowser is not a member of object org.scalajs.testsuite.utils.Platform
[error]     assumeTrue(Platform.executingInNodeJS || Platform.executingInBrowser)
[error]                                                       ^
[error] one error found
[error] (testSuite2_12 / Test / compileIncremental) Compilation failed


Cannot change TextInput fontSize after typing anything once

Possibly related: #20224, #18874

[x] Review the documentation: https://facebook.github.io/react-native
[x] Search for existing issues: https://github.com/facebook/react-native/issues
[x] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
React Native Environment Info:
System:
OS: macOS 10.14
CPU: x64 Intel(R) Core(TM) i5-6267U CPU @ 2.90GHz
Memory: 43.02 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 8.11.3 - /usr/local/bin/node
Yarn: 1.9.4 - ~/.yarn/bin/yarn
npm: 5.6.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3
Android SDK:
Build Tools: 23.0.1, 23.0.3, 24.0.3, 25.0.0, 25.0.1, 25.0.2, 25.0.3, 26.0.0, 26.0.1, 26.0.2, 26.0.3, 27.0.0, 27.0.1, 27.0.2, 27.0.3, 28.0.0
API Levels: 19, 22, 23, 24, 25, 26, 27
IDEs:
Android Studio: 3.1 AI-173.4819257
Xcode: 9.4.1/9F2000 - /usr/bin/xcodebuild
npmPackages:
@types/react: ^16.4.7 => 16.4.7
@types/react-native: ^0.56.10 => 0.56.10
react: 16.4.2 => 16.4.2
react-native: 0.57.0-rc.3 => 0.57.0-rc.3
npmGlobalPackages:
react-native-cli: 2.0.1
react-native-macos-cli: 2.0.1
Description
I'm trying to implement a dynamic fontSize on React Native based on the content size, but I hit a React Native limitation / bug.
You can change the fontSize multiple times before typing anything in the TextInput, but once you type something you cannot change it anymore. See it in action in the link below.
Reproducible Demo
https://snack.expo.io/@brunolemos/react-native-textinput-bug

Interesting. I just found that this only happens on uncontrolled TextInput. If I add the properties:
<TextInput
+    onChangeText={text => this.setState({ text })}
+    value={this.state.text}
/>

then it works.
Is that the expected behavior or is this a bug?
I'll leave this open since it may be a bug.

+1


! could not download

The same thing happens when using degit.

Can you provide an example that can be replicated?

It appears there was some internal problem, because now it works.


linux_xanmod, linux_xanmod_latest: 2024-04-10

Description of changes

have checked the commits and compared the config files
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Why did you draft this?
If it's because there's a newer version, let's merge this first.

I've force pushed the new version..🤦♂

Feel free to simply force-push back real quick.

should be ok now