unimport crashes on py3.12 due to distutils removal

Repro steps:
Environment (from here):

sys.version: '3.12.0 (main, Oct  2 2023, 12:03:24) [Clang 15.0.0 (clang-15<IP_ADDRESS>)]'
os.name: 'posix'
sys.platform: 'darwin'
platform.system(): 'Darwin'
platform.python_implementation(): 'CPython'
sys.implementation.name: 'cpython'
sysconfig.get_platform(): 'macosx-14-arm64'

$ cat example.py
import sys
print('hello world')

$ pip freeze | rg unimport
unimport==1.0.0

$ unimport example.py
Traceback (most recent call last):
  File "/Users/mxr/tmp/venv3.12/bin/unimport", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/mxr/tmp/venv3.12/lib/python3.12/site-packages/unimport/__main__.py", line 4, in main
    from unimport.main import Main
  File "/Users/mxr/tmp/venv3.12/lib/python3.12/site-packages/unimport/main.py", line 6, in <module>
    from unimport import commands, utils
  File "/Users/mxr/tmp/venv3.12/lib/python3.12/site-packages/unimport/commands/__init__.py", line 1, in <module>
    from unimport.commands import options
  File "/Users/mxr/tmp/venv3.12/lib/python3.12/site-packages/unimport/commands/options.py", line 5, in <module>
    from unimport.config import Config
  File "/Users/mxr/tmp/venv3.12/lib/python3.12/site-packages/unimport/config.py", line 14, in <module>
    from unimport import constants as C
  File "/Users/mxr/tmp/venv3.12/lib/python3.12/site-packages/unimport/constants.py", line 2, in <module>
    import distutils.sysconfig
ModuleNotFoundError: No module named 'distutils'

See https://docs.python.org/3/whatsnew/3.10.html#distutils-deprecated for more info

Hi thanks for the issue but
officially, unimport does not yet support versions after Python 3.10.
Wouldn't this fix be a bit pointless when no development has been made yet? It would be better to develop support for Python3.11 and Python3.12 first.

Do you mind clarifying? I believe unimport already works on py3.11 (at least tox -e py3.11 passed and the wheel is not limited to <py3.10), so supporting it would be simply require changing CI parameters. And if desired, supporting py3.12 can happen with the 2 PR's I have open.

Phrased another way - if we don't want to support py312 then the right thing is to configure that in python_requires (currently we allow an install but crash at runtime)

If all packages support Python 3.11 and 3.12, we can make the necessary changes in Unimport and provide support for these versions, there is no problem with this.
Do you want to do this job or should I do it?

I don't know what you mean by "if all packages". According to https://endoflife.date/python python3.11 and python3.12 are supported officially by Python maintainers
I can update this project to run in CI for python 3.11

When I say all packages, I mean other 3rd party packages that unimport uses.

You don't need to do anything additional for now, I will check your PR.

I think we are mixing up two things
A) Whether unimport runs under python3.11+?
B) Whether unimport can process syntax available in python3.11+?
(A) is enforced by setting python_requires. Since unimport sets python_requires = >=3.6, users expect that the tool runs under all of those versions. One way to resolve this bug report is to remove usage of distutils in favor of other libraries. Another way is to set a ceiling on python_requires and keep using distutils
(B) does not have a standard way of enforcement. At the time of the bug report in #291, the match statement (new to py310) could not be processed by libcst even though unimport does run on py310. One way to solve this class of issue is to add a new target_version argument to unimport in order to be explicit/implicit about which syntax you support
I opened this ticket in response to issue (A) but it sounds like you want to resolve both (A) and (B)? What I can do is check if the dependencies run on py311 and/or set a ceiling for python_requires if you feel this better guards against surprises

Yes, I understand you, you are right.
1 -) There was a mistake when determining python_requires, we should update it to include only versions that we guarantee to support.
2 -) If we want to support Python 3.11 or a higher Python version, we must check the packages we currently use, update our setup file, add new tests to ensure that we support new features, and fix any issues related to these versions, if exists.
There are two separate jobs, they must be done in order.

I think we are still not totally aligned, or at least the use of 'supports' is overloaded. I may be guilty of this too.
Let's use the terminology "runs under" and "language version" to delineate the two. For example

asottile/pyupgrade runs under python 3.8.1 or higher and autofixes all python language versions, with the option to specify the language version with --pyxx-plus
psf/black runs under python 3.8 or higher and allows selecting the language version with -t
astral-sh/ruff runs under rust 1.73 and supports language versions 3.7 and higher

Now applied to unimport: unimport is configured to run under python 3.8. However it fails to run under 3.12 or higher - that's what this issue is about. Separately, it crashes on language version 3.10 or higher (#291).
It would be straightforward to fix unimport so it runs under python3.12 by removing distutils. I have a PR for that. It would take more work to support language versions 3.10+ and not something I can take on.
Let me know your thoughts

Ok I understand, thank you for your effort, and sorry for getting back late.

Now you can install and use version 1.0.1 -> https://pypi.org/project/unimport/1.0.1/

Thanks!


Move gps package out of internal

gomvpkg -from github.com/golang/dep/internal/gps -to github.com/golang/dep/gps
Fixes #575

(I requested this 😁)
let's see how tests so. also, @tamalsaha , I think we have an issue open for this - do you mind searching the queue for it?
/cc @spenczar - I know you were looking forward to this 😀

Added issue #. I am not sure what's wrong with codeclimate. Other tests are passing.

updated CHANGELOG

Are these tests known to be flaky? They started failing after I updated the CHANGELOG file.

the appveyor tests can be, yes. that particular failure is on a new test recently introduced for adaptive healing of the cache area. we've seen a couple other instances of flakiness from that.
the travis failure was on tip, so i'm gambling on a regression there. i've restarted both.

oh, the codeclimate failure is likely because we have some CI which knows dirs to exclude that needs to be updated.
it's worth grepping over the repo for instances of internal/gps in general (whether in *.go files or not) and seeing what may need fixing.

All tests are now passing except go/tip .


gonja CLI ?

Is there a gonja CLI I can use. Just asking before potentially writing it myself.

Wrote a little cobra thing: https://gitlab.com/qnib-golang/gonja-cli


record.list

I would like to request a list feature for records where it is possible to query and paginate records against a pattern.
e.g.
record.list('foo/*', { start: 0, limit: 256 }, ({ ids }) => console.log(ids))

This can be useful together with #535 to e.g. implement elasticsearch indexing directly through deepstream without coupling it to a specific database. Similar to https://pouchdb.com/api.html#batch_fetch.
This would require support from the storage connector.

https://gist.github.com/ronag/22501be05bed41d751db23365186b0f3


Chroma integration?

I don't see a Chroma integration on the docs
https://docs.sciphi.ai/integrations/databases
but I see it throughout the codebase. Anything I can do to help?

Thanks Jeff - those references were part of some demo capabilities for the web app.
We'd like to add Chroma as a vectordb provider. This means creating a specific implementation for the ChromaDBProvider which adheres to the format here -https://github.com/SciPhi-AI/R2R/blob/main/r2r/core/providers/vector_db.py.
This is something I have done in the past, I just haven't gotten to it yet for this repository. Are you interested in taking a stab at it?

should be pretty straightforward, i'm totally strapped for time these next few weeks else I would love to!

Closing for now.


Issue with the get_current_user method for authenaticaion.

Description
I am using this project as an API only application and so I've stripped the frontend. I am able to get everything up and running and am even able to authenticate in the /docs endpoint with my default superusers. However, after authenticating and testing any of the endpoints that require auth I get the response Could not validate credentials which is thrown from the def get_current_user() method in deps.py.
I've done step-thru debugging and am able to see that the payload is successfully extracted from jwt.decode() method, but this line: token_data = schemas.TokenPayload(**payload) doesn't seem to work. The token_data is never populated and an exception is thrown.
Has anyone run into a similar issue?
EDIT: The Token Payload schema and return values for jwt.decode() do not match. Why is the class TokenPayload(BaseModel): expecting sub to be of type Integer? Is there a reason for this? I have not changed anything with respect to authentication and am wondering if something might be off.
EDIT2: Closing this because I sorted it out by fixing the types in the schema to match jwt.decode(). (sub: int -> string) If there's a reason for why it was defined as an int by default though I'm curious.

Thanks for reporting back and closing the issue 👍

Sorry for the long delay! 🙈  I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.


Precision mode of path editing same as JOSM

Description
It would help a lot to realign roads

The JOSM feature is known as "Improve Way Accuracy" (see https://josm.openstreetmap.de/wiki/Help/Action/ImproveWayAccuracy ).
The keyboard shortcut is W, and is currently only available in Expert mode.

previous discussion here:
https://github.com/openstreetmap/iD/issues/3116


Enhancement(web-serial): Enable Serial Options During Port Initialization

What Does This PR Do ?

Add support for serialOptions other than baudRate that can be provided to port.open()/device.open() method while opening the port/connecting the device.
This PR may address #114

@brianignacio5 Could you please take a look into this ?

Since you're already able to pass in a port, is this PR still necessary? You can create/configure your port accordingly before passing it to esptool.

Since you're already able to pass in a port, is this PR still necessary? You can create/configure your port accordingly before passing it to esptool.

I'm attempting to pass portConnectionOptions(array of object which refer to serialOptions) through TOML in esp-launchpad, which can then be passed to the open method of the Web Serial API. I'm still a bit confused. @balloob, could you please provide some guidance on how I can pass serialOptions by taking expresslink's portConnectionOptions into consideration?i.e., how can I configure port before passing to esptool-js

Since you're already able to pass in a port, is this PR still necessary? You can create/configure your port accordingly before passing it to esptool.

With reference to the Weberial API Documentation - the SerialPort open method supports SerialOptions dictionary. https://wicg.github.io/serial/#serialoptions-dictionary.
We currently support passing only baudrate, where as other options would come handy as well. This PR still maintains baudrate as primary parameter (to preserve compatibility and not introduce any breaking changes). However we can phase it out later and make use of serialoptions dict to be passed instead in future.


Do u have plugin to count files when I selected it ?

I'd like to know number of files that I selected.
For example, I selected all files in src directory; Then, pls show me the number of selected files by me.

Search in our marketplace, there might be some extension. I do not know


Support for memory and bandwidth

For the fields of computer science and embedded systems it would be quite useful to have support for memory quantities (kbit, kB, kiB, MB, GB,...) and bandwidth quantities, i.e. memory quantities per time like kbit/s, MB/s and all declinations as well ( for describing data transfer capacities and measurements of all kind of memory and bus devices).

I agree, however, I am not sure if ISO C++ Committee will decide to release it as a part of a standardized library. However, the library is easy to extend so it can be added later. See here: https://github.com/mpusz/units/blob/master/test/unit_test/runtime/digital_information_test.cpp.

Would the extension work for the really large derived dimensions like exbibytes? A ratio can only cover a part of that and a ratio multiplied with a power of 10 can most likely also not cover everything.
=> Wouldn’t it make sense to have a configurable base for the exponent in the ratio template? Then your argument that it can easily be extended to digital information is true no matter how large the binary prefix is.

Sure ;-) See #14

I saw that, how I read the post it does not specify a configurable base for the exponent yet :-)


Override Agent Restart

Hi,
As mentioned in point 9 of the documentation, the Agent is set to complete with each job and is restarted by OpenShift. This however poses a problem for classic release pipelines.
When the agent jobs are small and there are multiple stages to deploy into, then as each stage completes OpenShift restarts the pod. After 3 or 4 such restarts, the pods enter into a CrashLoopBackoff in OpenShift, and waits for the configured amount of time before attempting to restart the pod. This means that not only does the release pipeline take a long time to complete as it waits for agents to be available, but sometimes the waiting also times out and fails the pipeline altogether.
Question: What is the best way to solve this problem? There are a few things we are thinking about, but some help would be greatly appreciated. We could theoretically:

Prevent the restart when each agent job completes. We are not sure what implications that might have for clean up etc. Maybe we could keep it alive for N jobs before restarting the agent. @bfarr-rh did you get a chance to dig into it?
Configure OpenShift to not put the pods into a CrashLoopBackoff state when they restart, maybe some form of graceful restart.
Change the pipelines from classic to YAML and combine all stages into a single stage with different jobs

FYI - we are trialling a work-around of cycling the agent after the first job finishing 11 minutes after pod start-up.
k8s resets crashloopbackoff tracking at 10 minutes, reverting to an immediate pod restart rather than exponentially backed off delay before re-start.
This is a trade off between minimising the risk of memory/process/disk resource leaks and the microsoft approach of a deployment that triggers a k8s crash-loop-backoff behaviour by exiting with every job.
/azp/agent/bin/Agent.Listener configure --unattended --agent "${AZP_AGENT_NAME}-${MY_POD_NAME}"
    --url "$AZP_URL" --auth PAT --token "$AZP_TOKEN" --pool "${AZP_POOL}"
    --work /_work --replace --acceptTeeEula
&&
while [[ $SECONDS -lt 660 ]]; do
    /azp/agent/externals/node/bin/node /azp/agent/bin/AgentService.js interactive --once;
    if [[ $? -ne 0 ]]; then exit 1; fi;
done

(newlines / spacing added for readability)

I am not sure of the reason for the Crashback loop - is this associated
with the process not starting ? or container image.
But if we look at option 1 to have a more long running job then we
could consider the maintenance jobs configuration in the pool.
https://learn.microsoft.com/en-us/azure/devops/pipelines/agents/pools-queues?view=azure-devops&tabs=yaml%2Cbrowser
You can configure agent pools to periodically clean stale working
directories and repositories. This should reduce the potential for the
agents to run out of disk space. Maintenance jobs are configured at the
organization level in agent pool settings.
Benjamin Farr
Associate Principal Solution Architect
Red Hat, Asia-Pacific Pty Ltd
Level 24, 120 Collins Street
https://maps.google.com/?q=Level+24,+120+Collins+Street+Melbourne+VIC+3000,+Australia&entry=gmail&source=g
Melbourne VIC 3000, Australia
https://maps.google.com/?q=Level+24,+120+Collins+Street+Melbourne+VIC+3000,+Australia&entry=gmail&source=g
E-Mail:  @.***
Mobile:  +61 478 195 145
https://www.redhat.com
[image: image.png]
https://www.redhat.com/en/anz-virtual-events-hub
On Fri, Feb 9, 2024 at 10:17 PM Mhano Harkness @.***>
wrote:

FYI - we are trialling a work-around of cycling the agent after the first
job finishing 11 minutes after pod start-up.
k8s resets crashloopbackoff tracking at 10 minutes, reverting to an
immediate pod restart rather than exponentially backed off delay before
re-start.
This is a trade off between minimising the risk of memory/process/disk
resource leaks and the microsoft approach of a deployment that triggers a
k8s crash-loop-backoff behaviour by exiting with every job.
/azp/agent/bin/Agent.Listener configure --unattended --agent "${AZP_AGENT_NAME}-${MY_POD_NAME}"
--url "$AZP_URL" --auth PAT --token "$AZP_TOKEN" --pool "${AZP_POOL}"
--work /_work --replace --acceptTeeEula
&&
while [[ $SECONDS -lt 660 ]]; do
/azp/agent/externals/node/bin/node /azp/agent/bin/AgentService.js interactive --once;
if [[ $? -ne 0 ]]; then exit 1; fi;
done
(newlines / spacing added for readability)
—
Reply to this email directly, view it on GitHub
https://github.com/bfarr-rh/azure-devops-ocp-agent/issues/9#issuecomment-1935740129,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACY3MW2ZB3JJU7KCTTGTD6LYSYASVAVCNFSM6AAAAABDAVNXR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZVG42DAMJSHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

The crashloopbackoff is purely because the container is exiting after 1 job (--once) often only shortly after the container starts (seconds to minutes). Keeping it running for at minimum 10+ minutes solves this.
We were not confident enough in the agent's stability / resource management / cleanup to switch it away from --once. Our nervousness was mostly because all the Microsoft docs/samples for containerised deploy include "--once".

Perhaps we should look at keda instead to scale
https://keda.sh/blog/2021-05-27-azure-pipelines-scaler/
Benjamin Farr
[image: image.png]
https://www.redhat.com/en/anz-virtual-events-hub
On Mon, 12 Feb 2024 at 17:48, Mhano Harkness @.***>
wrote:

The crashloopbackoff is purely because the container is exiting after 1
job (--once) often only shortly after the container starts (seconds to
minutes). Keeping it running for at minimum 10+ minutes solves this.
We were not confident enough in the agent's stability / resource
management / cleanup to switch it away from --once. Our nervousness was
mostly because all the Microsoft docs/samples for containerised deploy
include "--once".
—
Reply to this email directly, view it on GitHub
https://github.com/bfarr-rh/azure-devops-ocp-agent/issues/9#issuecomment-1938135286,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACY3MWZOFWKPMV4H26YZKS3YTG3MDAVCNFSM6AAAAABDAVNXR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZYGEZTKMRYGY
.
You are receiving this because you were mentioned.Message ID:
@.***>


Cannot leave task unassigned on creation

I am running version 1.0.11 and I have found that I am required to assign a new task to a user when I create it. But when editing the task I can update it to unassigned. I'd like to be able to set it as unassigned on creation also. Is this a bug, or am I overlooking something?

feature see #436

Ok, thanks. Wasn't clear to me from the UI.


[review only-test in progress] Latest source code pro with Russian / Cyrillic / Greek support.

Latest source code pro with Russian / Cyrillic / Greek support.
these fonts now support the WGL4 character set.

Note: Look over here to see the changes and compare the old and new versions: https://github.com/adobe/brackets/commit/07c3de7d60cc617974036064f09d98c349875cc4
The new version looks bolder and appears to be more readable to me.
I like it.

+1 I too like the new look of the fonts.

@rawat11 If There are no significant defects apart from this, Can we go ahead with this integration ?

After trying this out with my normal preferences (13px, "SourceCodePro-Medium"), I found that superscript dot of letter i doesn't have much distance from its bottom body and seems to be touching each other.

@sprintr Good observation! We should watch out for these kind of changes which are subtle but might impact the readability of code in general.
@rawat11 Please test specifically on MAC as there seem to be lot of font rendering issues on MAC and I am sure you will find a jewel in there :smile:

@sprintr Another question. Are you seeing this with certain font sizes or are you seeing this in general with all the font sizes?

@nethip It happen for (16px, 19px, 21px, 25px, 28px, 42px) etc as well, but seems bearable. with 13px it seems touching.

Using my color palette extension, to get a good view of the problem with i.

@abose Yes, the new font is definitely more readable, our internal team is verifying it, will update once it's done.

@sprintr Thanks for the screenshots. @rawat11 do we want to file a bug at https://github.com/adobe-fonts/source-code-pro

@nethip On MAC, there is some issue with the font rendering, some of the characters are not clearly visible with the respect to the other characters on the same plane.
Also there visibility is increased once we increase the font size.

On increasing the font size

And on windows the same data renders nicely

@rawat11 Thanks! Could you go ahead and update this with the above screenshots.

@nethip We already have a issue raised there, do you want me log another ? I can do that otherwise

@rawat11 That's fine! Let us wait to hear from @pauldhunt on that.

Reverted the font to TTF. Though I like the OTF rendering in windows better, Some of the character glyphs doesn't work well in windows[see https://github.com/adobe-fonts/source-code-pro/issues/98 for discussion].

@nethip The new fonts looks good to the linguist team. We can go ahead with the fonts

Thanks @rawat11 For the detailed tests. Merging.


Adds --target value as environment variable

Recreation of #3121
Closes #3119

I'm closing this PR because --target is deprecated.
This behavior can be achieved by assigning different environment variable values to production, preview, and development.
See the announcement here: https://vercel.com/blog/environment-variables-ui


migrate runner.py features into oss-fuzz/infra/helper.py

Making an issue of https://github.com/ossf/fuzz-introspector/pull/525#issuecomment-1302464937
oss_fuzz_integration/runner.py has a few features that are convenient for building and running fuzzers by way of oss-fuzz, including:

automatically downloading public corpus, which can be used to construct full coverage reports
run commands such as: python3 ../runner.py {coverage | introspector} proj_name exec_sec which will build fuzzers of proj_name with the default sanitizer, run the fuzzers for exec_sec seconds and then generate a coverage or introspector report.

The features are useful when improving fuzzers for a given project as it makes the workflow fast.
Some of these features would make sense to add to OSS-Fuzz, in particular coverage generation using public corpus, generation of fuzz introspector reports for a given project and also generation just coverage for a given project.

+1 to this!
Note that we already have a coverage command in helper.py which has some functionality to download corpora and generate coverage reports: https://github.com/google/oss-fuzz/blob/f2d79d7877f74b6086abf6e3aa97d8a89b41923c/infra/helper.py#L885
Is the difference here just the ability to generate an introspector report?
@evverx

Note that we already have a coverage command in helper.py which has some functionality to download corpora and generate coverage reports

helper.py makes it possible to download the latest corpora but it requires setting up gsutil, tokens and so on. I tend to run helper.py in throw-away VMs so there it's just easier to download public corpora and point helper.py to them without having to deal with any tokens. It also helps to build coverage/FI reports for projects I don't have access to.

Is the difference here just the ability to generate an introspector report?

Apart from downloading public corpora automatically I think it is. Right now to build FI reports it's necessary to clone the fuzz-introspector repository and then run runner.py (which does a few things using helper.py under the hood). It works but I think ideally it should be included in helper.py. Among other things it would automatically make it possible to pass paths to source code when fuzz targets are built (i.e. ./helper.py build_fuzzers project ~/path/to/project/source/code) to figure out whether changes/patches have improved anything.

Before I forget if it's decided that it should be possible to download public corpora via helper.py it should construct urls by analogy with https://github.com/google/oss-fuzz/blob/7797279c274d10197d62841dc43834238fd483a1/infra/cifuzz/clusterfuzz_deployment.py#L295-L298
    project_qualified_fuzz_target_name = target_name
    qualified_name_prefix = self.config.oss_fuzz_project_name + '_'
    if not target_name.startswith(qualified_name_prefix):
      project_qualified_fuzz_target_name = qualified_name_prefix + target_name

I don't think there are a lot of projects where it would be necessary but as far as I can remember libidn2 would be one of them.

The features are useful when improving fuzzers for a given project as it makes the workflow fast.

I'd add that it would make it easier to fuzz projects that aren't integrated into OSS-Fuzz. For example I fuzzed a small library today so I put its fuzz target in the OSS-Fuzz repository to make it easier fuzz it locally using the OSS-Fuzz toolchain. Once a couple of shallow bugs were fixed there I ran the fuzz target for a couple of hours to build up a corpora and was on the way to use them to build FI reports to figure out how it fared in general. I ended up cloning the FI repository, copying the OSS-Fuzz repository with that local project to the oss_fuzz_integration directory and pointing the runner script to various places. In the end I built the report but it would have been much easier if I could have just run ./infra/helper.py introspector directly from inside my local copy of the OSS-Fuzz repository.

@evverx I'll start this in the coming days!

@DavidKorczynski good to know. Thanks!
FWIW I'm not sure how to fix that "infra/helper.py" bug where it can't be run a few times in a row with local build directories. Unfortunately the patch where I added the ":O" option to get it to destroy any changes to build directories works with podman only. On the other hand if the script is going to be integrated into helper.py directly maybe it can avoid that bug somehow.

@DavidKorczynski now that FI is integrated into helper.py (and the documentation is updated) I think this issue can be closed. The only feature I'd add to make it perfect would be a way to point helper.py to directories where FI reports should be stored to make it easier to compare several FI reports produced by subsequent runs but it's probably a separate feature request and I can probably send a PR sooner or later. Thanks!

@DavidKorczynski now that FI is integrated into helper.py (and the documentation is updated) I think this issue can be closed.

Great! Am glad the recent additions improved things!

The only feature I'd add to make it perfect would be a way to point helper.py to directories where FI reports should be stored to make it easier to compare several FI reports produced by subsequent runs but it's probably a separate feature request and I can probably send a PR sooner or later. Thanks!

Sounds good! Let's track diffing of runs here https://github.com/ossf/fuzz-introspector/issues/734 -- fyi this is in my todo list for the near future, and we should probably have some updates in mid january!


Bump Go to 1.21 following upstream Coraza

Fixes Nightly Coraza Check https://github.com/corazawaf/coraza-proxy-wasm/actions/runs/10017481785

@fzipi it could be a good idea but I would say upgrading go here is a very sensitive task as you need to align tinygo version and compilation and etc so I would not trust an automated PR.


AWS Lambda runtime Go 1.x end of support

Describe the bug
Autoscaling lambda function created by the stack is using Go 1.x runtime, which is reaching end of support end of 2023.
I received the following email from AWS:

Hello,
We are contacting you as we have identified that your AWS Account currently has one or more Lambda functions using the Go 1.x runtime.
We are ending support for the Go 1.x runtime in AWS Lambda, in line with Amazon Linux AMI end of maintenance support on December 31, 2023 [1]. Lambda continues to support the Go programming language, using the provided.al2 runtime. Using the provided.al2 runtime offers several benefits over the go1.x runtime, including support for AWS Graviton2 processors and a streamlined implementation with a smaller deployment package and faster function invoke path. For more information, see our blog post [2].
As described in the Lambda runtime support policy [3], end of support for language runtimes in Lambda happens in two stages. Starting December 31, 2023, Lambda will no longer apply security patches and other updates to the Go 1.x runtime used by Lambda functions, and functions using Go 1.x will no longer be eligible for technical support. In addition, you will no longer be able to create new Lambda functions using the Go 1.x runtime. Starting January 30, 2024, you will no longer be able to update existing functions using the Go 1.x runtime.
We recommend that you upgrade your existing Go 1.x functions to the provided.al2 runtime before December 31, 2023.
End of support does not impact function execution. Your functions will continue to run. However, they will be running on an unsupported runtime which is no longer maintained or patched by the AWS Lambda team.
This notification is generated for functions using the Go 1.x runtime for the $LATEST function version. A list of your impacted Lambda functions can be found in the 'Affected resources' tab of your Personal Health Dashboard. The following command shows how to use the AWS CLI [4] to list all functions in a specific region using Go 1.x, including published function versions. To find all such functions in your account, repeat this command for each region:
aws lambda list-functions --function-version ALL --region us-east-1 --output text --query "Functions[?Runtime=='go1.x'].FunctionArn"
There is a difference in Lambda billing between the go1.x runtime and the provided.al2 runtime. With the go1.x runtime, Lambda does not bill for time spent during function initialization (cold start), whereas with the provided.al2 runtime Lambda includes function initialization time in the billed function duration. Since Go functions typically initialize very quickly, and since Lambda reduces the number of initializations by re-using function execution environments for multiple function invokes, in practice the difference in your Lambda bill should be very small.
If you have any concerns or require further assistance, please contact AWS Support [5].
[1] https://aws.amazon.com/blogs/aws/update-on-amazon-linux-ami-end-of-life/
[2] https://aws.amazon.com/blogs/compute/migrating-aws-lambda-functions-from-the-go1-x-runtime-to-the-custom-runtime-on-amazon-linux-2/
[3] https://docs.aws.amazon.com/lambda/latest/dg/runtime-support-policy.html
[4] https://aws.amazon.com/cli/
[5] https://aws.amazon.com/support

Steps To Reproduce
Steps to reproduce the behavior:

Provision an Elastic CI Stack

Expected behavior
Use a runtime which will continue to be supported (which implies probably changing the code but I'm not sure)
Actual behaviour
Not sure how to trigger the email from AWS, or if there's anywhere to see a warning in the AWS console, but you can at least verify that an Autoscaling lambda is created which uses the Go 1.x runtime.
Stack parameters (please complete the following information):

AWS Region: us-east-1
Version v6.1.0

Additional context

Thanks for letting us know @jkburges. We've received this too. We have plans to release a new version of the Elastic CI Stack with the provided.al2 runtime. We'll update this issue when we do.

Is there any timeline established for this? I have quite a few teams that will need to update their queues and I'd love to give some kind of guidance around when and how much effort they'll need to dedicate to this work.

Any updates yet?


deleting profiles

Deleting a user profile will break this system.  Either attempts to add a printer will fail, or unwanted printers will keep coming back.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2f5319b8-387d-0944-6ae7-6d71e827a878
Version Independent ID: 0b27703e-e073-ecd4-424d-6c09a792f1d3
Content: Known Issues with Client-Side Rendering
Content Source: windows-driver-docs-pr/print/known-issues-with-client-side-rendering.md
Service: unspecified
GitHub Login: @windows-driver-content
Microsoft Alias: windowsdriverdev

Also, see update so this is more than Windows Vista. =:-)

This option in combination with secure print can cause the Windows 10 print app to not work correctly.

This topic has been updated.
Thanks @jszabo98 and @TimvdLooy for your comments on this topic.


code smell - invalid link

The code smell link - https://deviq.com/code-smells/ - returns 404 Not Found. The correct link is https://deviq.com/antipatterns/code-smells.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d118f070-8743-e905-2d08-dc725a4e8b5f
Version Independent ID: fae35cbd-75ae-4448-f066-7c91ccc35779
Content: Using Enumeration classes instead of enum types
Content Source: docs/architecture/microservices/microservice-ddd-cqrs-patterns/enumeration-classes-over-enum-types.md
Product: dotnet-architecture
Technology: microservices
GitHub Login: @nishanil
Microsoft Alias: nanil

@ardalis, You probably missed a redirect on your website for this.

@ardalis, You probably missed a redirect on your website for this.

I opened a PR to add redirect for this, we also should update the link here to avoid redirection.

I opened a PR to add redirect for this, we also should update the link here to avoid redirection.

Thanks for the redirect fix on the site, @Youssef1313 ! I've created a PR to update the link to the new URL.

Thanks for the redirect fix on the site, @Youssef1313 ! I've created a PR to update the link to the new URL.


Draft Interop Roadmap for MVP

We need to provide a roadmap for delivering the interoperability specs and datasets for a Minimum Viable Product. Here is a shared document for drafting and discussion.

@ahwagner  I made a decent pass at this. But I think you and I need to discuss a bit before we send it out to a wider audience.


can not launch with webhook?

Describe the bug:
I tried to enable the webhook feature. I added the library/cert-manager app via my Rancher 2.2.2 UI. But it is unable to install.
Failed to install app cert-manager. Error: YAML parse error on cert-manager/charts/webhook/templates/deployment.yaml: error converting YAML to JSON: yaml: line 35: could not find expected ':
Expected behaviour:
cert-manager and webhook pods should intitialize start up.
Steps to reproduce the bug:
Go to your rancher interface.
select a project in a cluster
under Apps > Launch select the cert-manager from Library
set your e-mail address
set Enabled Webhook to true
click launch
Anything else we need to know?:
Environment details::

Kubernetes version: v1.13.5
Cloud-provider/provisioner: none (custom cluster)
cert-manager version: 0.5.2
Install method (e.g. helm or static manifests): not sure, I think static

/kind bug

I'm not too sure how Rancher is installing cert-manager under the hood, but I think you'd have better luck asking the Rancher folk for support on this.
If you can dig out the 'source' for the manifests, or try and discover what the 'rendered manifests' look like, I may be able to help. But otherwise it's difficult for me to investigate!


Fix crash when closing and quickly opening a split, then running /clearmessages

Pull request checklist:

[x] CHANGELOG.md was updated, if applicable

Description
When restoring a split, the split would be appended to the split container but would not be selected. When accessing the selected split upon running the /clearmessages command as shown in the bug report, nullptr would be returned resulting in a segfault.
This PR fixes the underlying issue of the split not being selected and also adds a check for nullptr.
Fixes #3846

Good fix, thank you!


NULL_AFTER_DEREF in test/integration.c

In file test/integration.c at #157
Pointer 'driver' is dereferenced which can be NULL.
Solution:
ASSERT_NOT_EQUAL( driver,  NULL, "Could not create driver." );
should come before
driver->send = &_send;

Oops, I missed that one.
Can you send a pull request for this?

commit a280ab4b5f6a134031c7c129af3c9af6e4574d70

Commit mentioned above is in PR #18. Merged, fixed, thanks ;)


[MINOR][ML] Increase the timeout for StreamingLinearRegressionSuite to 60s

What changes were proposed in this pull request?

Increase the timeout for StreamingLinearRegressionSuite to 60s to deflake the test.
Why are the changes needed?

Reduce merge conflict.
Does this PR introduce any user-facing change?

How was this patch tested?

Test build #134238 has started for PR 31248 at commit f8be90a.

Test build #134238 has started for PR 31248 at commit f8be90a.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38822/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38822/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38822/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38822/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38822/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38822/

Test build #134238 has finished for PR 31248 at commit f8be90a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #134238 has finished for PR 31248 at commit f8be90a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134238/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134238/

Merged to master/branch-3.1/branch-3.0

Merged to master/branch-3.1/branch-3.0


Update example outputs to reflect AnnData

In the examples folder we discuss an example run of the workflow and include a link to example outputs. Once we have completed the addition and modification of the AnnData objects, we will need to update the link to include the AnnData in the output as well.

Closed by #468


Two-Way Model Package Updates/Bug Fixes

The twoway/reconfigure script is looking for a CCTM config file called cfg*.  The name of this file in the new CMAQv5.2 release is now *.cfg.
Change line 3 for twoway/reconfigure to:
set cfg_file = ls -1 cmaq/*.cfg

Update the Build Instructions documentation to say that the user must set the variable FC to either ifort, pgi, or gfort before running the command twoway/assemble (8th bullet in the build instructions section)

Line 43 of twoway/reconfigure need to terminate the sed command by adding a "/" after the 132:
sed 's/-ffixed-form/-ffixed-form -ffixed-line-length-132/' \

Update twoway/reconfigure so that LIOAPI in configure.wrf is set to lib:
#if ($FC == ifort) then
echo "LIOAPI  = Linux2_x86_64ifort" >> __temp
#else if ($FC == pgi) then
echo "LIOAPI  = Linux2_x86_64pg" >> __temp
#else if ($FC == gfort) then
echo "LIOAPI  = Linux2_x86_64gfort" >> __temp
#endif
echo "LIOAPI  = lib" >> __temp

Add a note to the documentation that if Gfortran is used to compile WRF-CMAQ, it must be newer than v5.0 (requirement of WRF3.8).

Change line 3 of twoway/misc/Makefile.twoway.part1 from
IOAPI_INC_PATH = $(IOAPI)/ioapi/fixed_src
to
IOAPI_INC_PATH = $(IOAPI)/include_files

Variable biogon is undefined in the script twoway_model_run_script

The twoway/reconfigure script is looking for a CCTM config file called cfg*.
has been addressed

Update the Build Instructions documentation to say that the user must set the variable FC to either ifort, pgi, or gfort before running the command twoway/assemble (8th bullet in the build instructions section)
FC is inherited from configure.wrf so user does not need to set it

Line 43 of twoway/reconfigure need to terminate the sed command by adding a "/" after the 132
has bee addressed

Update twoway/reconfigure so that LIOAPI in configure.wrf is set to lib
I think we should keep the traditional notation Linux2_x86_* where * is a specific compiler, e.g. 64ifort or 64pg

Add a note to the documentation that if Gfortran is used to compile WRF-CMAQ, it must be newer than v5.0 (requirement of WRF3.8)
agree

Change line 3 of twoway/misc/Makefile.twoway.part1
I think we should keep the traditional IOAPI path structure, i.e. IOAPI_INC_PATH = $(IOAPI)/ioapi/fixed_src

Variable biogon is undefined in the script twoway_model_run_script
That line should be replaced with
  if ( $CTM_BIOGEMIS == 'Y' ) then

and it has been addressed


Possible Typo in fastapi_server.py: n_ctx vs n_batch

When running the server in fastapi_server.py I noticed a possible typo in the configuration of the llama_cpp.Llama instance.
Here is the relevant code:
llama = llama_cpp.Llama(
    settings.model,
    f16_kv=True,
    use_mlock=True,
    embedding=True,
    n_threads=6,
    n_batch=2048,     <--- Should be n_ctx=2048
)

It appears that n_batch is set to 2048, but I believe it might be intended to set n_ctx to 2048 instead. When I tried to run the code as is, I encountered an exception due to the assert for ctx being None during generation. Changing n_batch to n_ctx resolved the issue.
Also, default batch size is 8, so 2048 seems a bit high :)
Awesome job!!!
https://github.com/abetlen/llama-cpp-python/blob/b9a4513363267dcc1f4b77d709ac3333fc889c6e/examples/fastapi_server.py#LL36C5-L36C5

Yup! The parameters should probably be updated, obviously n_batch only makes sense to be as large as n_ctx and the user should set this based on their system so moving this to the Settings object is the ideal solution.
I think the ctx is None exception is due to your model not loading. For the api example you have to set a MODEL environment variable for the Settings object.


Convert director.yml.erb to use top level JSON.dump

JSON.dump doesn't work for strings in ruby 1.9.3, also escaping is
required for each property. This fix constructs ruby hash and then
convert it to JSON/YAML by a single JSON.dump call.
Also additional test for vsphere was introduced to catch conversion
errors. Verified on AWS, verification on the rest of CPIs is required.
[#104923910] (https://www.pivotaltracker.com/story/show/104923910)
Signed-off-by: Yulia Gaponenko<EMAIL_ADDRESS>

Thank you @hashmap. Looks much more better for me.
It seems it will fix this issue https://github.com/cloudfoundry/bosh-init/pull/46 with bosh-init.

@allomov yes, I was able to deploy bosh using bosh-init with ubuntu 14.04 default ruby (1.9.3)

I think it would be better to add 1.9.3 ruby version to this list in .travis.yml to be sure nothing is broken by upcoming changes.

Merged.


bug: Indenting issues

Did you check docs and existing issues?

[X] I have read all the LazyVim docs
[X] I have searched the existing issues of LazyVim
[X] I have searched the exsiting issues of plugins related to this issue

Neovim version (nvim -v)
0.8.2
Operating system/version
OpenSuSE Tumbleweed
Describe the bug
I set shiftwidth and tabstop to 4 in my config file like so:
-- ~/.config/nvim/lua/config/options.lua
-- Options are automatically loaded before lazy.nvim startup
-- Default options that are always set: https://github.com/LazyVim/LazyVim/blob/main/lua/lazyvim/config/options.lua
-- Add any additional options here
local opt = vim.opt

opt.shiftwidth = 4
opt.tabstop = 4

When I indent a C file I'm writing using >> or gg=G it sets the indent correctly, but when I do :w it resets the indent back to 2 spaces.
Steps To Reproduce

Set config file to what I have
Write a C file and indent to 4 spaces
Save and watch the indents go to 2 spaces

Expected Behavior
When I save it should keep the indents at 4 spaces, or set any indents with 2 spaces to indents with 4 spaces.
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")
-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  "folke/LazyVim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

Works as expected for me. You must have an LSP or null-ls formatter active. You need to configure indent for those separately from Neovim.

Maybe this is related. When using the LazyVim Starter, without any configuration, added plugins, or settings applied (here in a TSX file inside the component props), the cursor jumps not where one would expect it, but indents one level in. Might be from one of the included plugins.

Same answer. Might be the treesitter indent plugin. You may try disabling that.
  {
    "nvim-treesitter/nvim-treesitter",
   opts = {indent = {enable = false}},
}

In case somebody ended up here but got disappointed...
You can override the defaults for null-ls (handles auto-formatting on save, thus responsible for formatting), which uses clang_format (probably)
return {
    "jose-elias-alvarez/null-ls.nvim",
    opts = function()
        local nls = require("null-ls")
        return {
            root_dir = require("null-ls.utils").root_pattern(".null-ls-root", ".neoconf.json", "Makefile", ".git"),
            sources = {
                -- Sets the desired indent width
                nls.builtins.formatting.clang_format.with({
                    extra_args = { "--style", "{IndentWidth: 4}" },
                }),
            },
        }
    end,
}

Noice! You just got the indent width to what it deserves to be instead of the despicable 2.
this might be already fixed as you read this dear future traveler...
But now you get erronous warning messages
warning: multiple different client offset_encodings detected for buffer, this is not supported yet
What the hell?!
Maybe vscode.. Naah c'mon, we're too far deep.
Oh here is a similar issue -> jose-elias-alvarez/null-ls.nvim#428, maybe they have a solution? Nope.
Oh another, LunarVim/LunarVim#2597, maybe they will give us the solace we are seeking?? Sadly, not exactly. But some steps on the right direction.
Before we leave, let's take a moment to appreciate the patience and the kindness of @abzcoding, on that thread. I mean if you are reading this, omg my man :heart:.
The dev who responded to this issue can't imagine being half of that in his dreams.
Although getting a lesson on human values, we didn't get the lazy solution we were hoping for, can't someone fix this for us? Who is going to really check what is written here and there, digest and apply the solution in context of this LazyVim thingy?
Don't worry fren, here you go
-- This overrides the default setting for clangd with offset encoding to utf-16
-- to prevent erronous warnings
return {
    "neovim/nvim-lspconfig",
    opts = {
        servers = {
            clangd = {
                capabilities = require("cmp_nvim_lsp").default_capabilities(),
                cmd = {
                    "clangd",
                    "--offset-encoding=utf-16",
                },
            }
        }
    }
}

End of the elephant in china-shop method that I applied to solve this issue.
By.

Same answer. Might be the treesitter indent plugin. You may try disabling that.
{
"nvim-treesitter/nvim-treesitter",
opts = {indent = {enable = false}},
}

so is a nvim-treesitter bug ,


Pod can`t install

Hi.
The cocoapods returns:
[!] Unable to satisfy the following requirements:

- `Alamofire (~> 2.0.2)` required by `Podfile`
- `Alamofire (= 2.0.2)` required by `Podfile.lock`
- `Alamofire (= 2.0.0)` required by `AlamofireObjectMapper (0.9)`

My Podfile:
source 'https://github.com/CocoaPods/Specs.git'
platform :ios, '8.0'
use_frameworks!

target 'Doge' do
    pod 'PureLayout'
    pod 'RealmSwift'
    pod 'Alamofire', '~> 2.0.2'
    pod 'ObjectMapper', '~> 0.17'
    pod 'Nuke'
    pod 'kingpin'
end

Anyone knows what can be?

I've created a new release which should fix this. Please try version 1.0

Do you know what`s happens here? I already have imported the library...

Hello i have like this error:

ObjectMapper required by Podfile
ObjectMapper (= 2.2.2) required by Podfile.lock
ObjectMapper (~> 2.0) required by AlamofireObjectMapper (4.0.1)
ObjectMapper (~> 2.0.0) required by GoogleMapsDirections (1.1.0)

This is my pod file:
source 'https://github.com/CocoaPods/Specs.git'
platform :ios, '9.0'
target 'BarakaCardiOS' do
use_frameworks!
pod 'SlideMenuControllerSwift'
pod 'Alamofire'
pod 'AlamofireObjectMapper'
pod 'AlamofireImage', '~> 3.1'
pod 'AlamofireNetworkActivityIndicator', '~> 2.0'
pod 'SwiftyJSON'
pod 'SnapKit', '~> 3.0.2'
pod 'Localize-Swift', '~> 1.7'
pod 'GoogleMapsDirections', '~> 1.1'
pod 'ObjectMapper'
pod 'GoogleMaps'


Autocomplete box is misaligned

Looks good to me.

The actual bit you are autocompleting lines up with your cursor. Atom has concept of the type of the returned value being to the "left" of that. This matches the rest of the ecosystem. Need to discuss how closely to match VS.
I should note that the return type is optional.

It's a big waste of space:

@davidfowl  thoughts w/o the return type?

Looks nicer... but the return type is useful information. Why not put it on
the right? You don't need "Method", "Class" etc when you have the icons.
On Sat, Apr 25, 2015 at 3:07 AM, Chad T<EMAIL_ADDRESS>wrote:

@davidfowl https://github.com/davidfowl thoughts w/o the return type?
https://camo.githubusercontent.com/04dbff33f24d7cfa2b750dfb9043859c29b752e6/687474703a2f2f692e696d6775722e636f6d2f765371476e48352e706e67
—
Reply to this email directly or view it on GitHub
https://github.com/OmniSharp/omnisharp-atom/issues/137#issuecomment-96121403
.

Again, is about fitting in with the ecosystem, right label is to be used for ": An indicator (e.g. function, variable) denoting the "kind" of suggestion this represents".
Am wary of straying off course here.

I kinda like the return type to the right of the method call.
That said VS doesn't even in the give return type (there is a tooltip that shows up with the return type information if you wait though).

A few things:

The box shouldn't jump around and resize in a jerky manner. This is one of the reasons I dislike the sublime plugin.
It's just too big. I have a 13" MBP and it can sometimes take up the entire editor window.
Showing the return type and type of thing is also fine. I dunno if we need icons and text, maybe that's fine?

I'm for moving the type to the right of the method call.  The blank space where there return type will bring down the container size considerably.
I've knocked font back on mine to 0.7em, seems to display a little nicer, doesn't overpower the code quite so much.

Should probably use the same CSS class as the text in the linter status bar (.text-smaller).
https://github.com/AtomLinter/Linter/blob/dea8a89cfcb64f1f210189d1f83e0dfcae06acbc/lib/statusbar-view.coffee#L10
Which you can see in action here:

We're already using that for the left and right labels:
https://github.com/OmniSharp/omnisharp-atom/blob/master/lib/omnisharp-atom/features/lib/completion-provider.ts#L76


Minor issue in keygen.php example

When trying to run the keygen.php example I am getting
[Error] Cannot use object of type OpenPGP_SecretKeyPacket as array
I haven't had time to look into this in every detail, but could it be that line 29 should actually be changed like this?
- $pubm[0] = new OpenPGP_PublicKeyPacket($pubm[0]);
+ $pubm[0] = new OpenPGP_PublicKeyPacket($pubm[0]->key);

If you try with latest master, does it work for you?  I've pushed a restriction on the versions of phpseclib supported due to similar issues in other places.


Add SUPPORT.md

Add SUPPORT.md file with support policy.

ClrMD is moving to dotnet/diagnostics, see #1079.  We will be following their support policy and release schedule, so I don't want to merge this PR just for the few more weeks this repo is in operation.


Python 3 port of DHT

Porting the DHT to Python3.

@shyba is currently blocked in getting the tests to pass, needs @jackrobison to look at it.

Functional tests are flaky under Python 3, more specifically test_store and test_contact_expiration are the worse. While removing and adding back a peer, as orchestrated by the test suite, it takes longer than one hour (of events) for all other peers to consider the removed node a bad peer and also more than one hour for it to come back. When the test checks for the 8 storing nodes, some has 3 failures, some 2 and some others one or even no failure.
They were all failing, then I made the following changes, that allowed some of them to pass:

Test suite's reactor pumping logic changed for precision and speed
Start one node at a time, instead of every 10 together

Seeing this on my node when connecting to spee.ch staging:
2018-07-29 08:51:02,108 ERROR    lbrynet.dht.protocol:267: DHT RECV REMOTE EXCEPTION FROM <IP_ADDRESS>:4444: Cannot bencode '<class 'bytearray'>' object
2018-07-29 08:51:02,118 ERROR    lbrynet.dht.node:327: Unexpected error while storing blob_hash 88584c4e656cf93ea64d73245a1b22b8497ecd0bb119d4c07d2a37febc0446f03359b18251faa91f953c3dcb103626a2 at <lbrynet.dht.contact._Contact object; IP address: <IP_ADDRESS>, UDP port: 4444>: Cannot bencode '<class 'bytearray'>' object

The issue regarding bytearray was uncovered and fixed.


Entering a OpenID identifier that includes a comma turns the input into an array causing an error

For instance:

NoMethodError in Devise::SessionsController#create
undefined method `match' for ["http://foo.openid.ne", "jp"]:Array

Entering just a comma for the identifier also causes an error.
It would be nice to render a flash error (Invalid OpenId identifier etc.) for these two instances.
I don't have a regular devise installation (with password login) to test on, so I can't tell if this is actually a issue with devise itself.

Do you know why the input is ending up as a comma?  I don't think this is normal Rails behavior; is it ruby-openid doing it?


[Event Hubs] Document need to close EventHub(Producer|Consumer)Client

We've seen a few times in the Event Hubs integration tests a case where receivers that are left open cause downstream tests to fail sporadically. We should document best practices around closing receivers and call out some of the issues that can occur if they are left open.

When this issue was logged, we were working on a very different client structure with individual senders and receivers. Does the concern here still apply to the model that we eventually shipped?

Since we moved to the model of having a single client for receivers and a single client for producers, I don't think this is needed anymore. Closing!


[neteasemusic] Add album info

For a complete ID3 information.

It's also make sense to extract track and track_number and change title's format to $artist - $track.


Resolution layering

implements the resolution layering; this is branched off rings_new

Code looks good to me. I suggest getting rid of the fragment_strs as quickly as possible, and supplementing the given fragment_dicts with it. This simplifies the __init__ as well as resolve a bit. For example:
if len(fragment_dicts) != len(fragment_strs): raise IndexError
self.fragment_dicts = []
for f_dict, f_str in zip(fragment_dicts, fragment_strs):
    f_dict = copy(f_dict)
    f_dict.update(read_fragments(f_str))
    self.fragment_dicts.append(f_dict)

In the end, I think it makes the most sense to allow fragments to be provided as dict or str. Mixing both leads to all sorts of sanity checks we can avoid. It is so easy to split the string and populate a fragment dict together with some recycled fragments that I don't think this feature is needed. Hence the error message

@pckroon possibly but I think it is not worth doing at the moment. 99% of applications will be resolving a cgsmiles string where both fragments and the meta_graph are in the string. For those applications putting stuff in the init is sufficiently easy and takes little python knowledge.
The "advanced" API functions of providing a meta_graph or fragment list are mostly for polyply/vermouth. Even there I don't have a real use case yet. Perhaps at some point mapping files can be replaced and then it would make sense having an advanced API. That's quite a bit in the future in my opinion.

@fgrunewald I refactored the API as suggested using constructors. That is pretty neat. Additionally, one can have more advanced workflows by subclassing and adding a new constructor. I think that is actually even more handy. The only thing I'm now considering is having a simple resolve function as a wrapper like so:
def resolve(cgsmiles_str, all_atom):
      _, molecule = MoleculeResolver.from_string(cgsmiles_str, last_all_atom=all_atom).resolve_all()
     return molecule


customer feedback sentence

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

LGTM

Looks good to me, and congratulations on your first Pull Request!  🎉🎉🎉
We look forward to future contributions!


support loading from monolithic checkpoints

What does this PR do?
Right now, when we load from a save folder the yaml does not specify in advance whether the state dict will be sharded or monolithic. We would like to move towards using sharded state dicts by default but do not want to fail to load monolithic checkpoints. This PR adds a flag to allow composer to try to load state dicts as sharded by default, falling back to monolithic checkpoints if this fails.
Before submitting

[ ] Have you read the contributor guidelines?
[ ] Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
[ ] Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
[ ] Did you update any related docs and document your change?
[ ] Did you update any related tests and add any new tests related to your change? (see testing)
[ ] Did you run the tests locally to make sure they pass?
[ ] Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

Why do we want to change default?

I think I'm missing something. Shouldn't we just be changing the fsdp state dict type to full if we're loading a monolithic checkpoint? (barring new functionality to support loading and saving with different sharding formats)

yeah I'm confused too. This is for if the user misspecifies the state_dict_type of their checkpoint?

Right now, when we load from a save folder the yaml does not specify in advance whether the state dict will be sharded or monolithic.

Well it kinda does by the user setting state_dict_type.

Why do we want to change default?

https://github.com/mosaicml/mcloud/pull/3561

yeah I'm confused too. This is for if the user misspecifies the state_dict_type of their checkpoint?

Yes exactly - mcloud has no way of knowing at the time of yaml creation whether the save_folder will contain a monolithic checkpoint or a sharded checkpoint, or none at all. However, it still has to make a judgement call as to the desired format for the state_dict_type (full or sharded). The solution is to have mcloud request a "noncommital" configuration: state_dict_type: "full", fallback_to_monolithic: true.
We support this here by implementing a simple fallback to monolithic checkpoint loading if the checkpoint does not load as sharded.


Files are not sorted alphabetically

Description
Currently trying to have a folder with files that are sorted alphabetically, but the web interface does not sort it correctly.
I already tried uploading each version by alphabetical order individually, I also modified each file in temporal order in case the modified time might be influencing the order, but nothing works, it always keeps the same incorrect order.
Items from 1 to 9 are always sorted correctly, but anything with the 0 is positioned after 9 instead of before 1.
I cannot find any way to fix this, so I am filing it as a bug.
I am able to reproduce this problem on the demo site as well: https://gitea.com/ParticleCore/sortorder
Attached follows screenshots of the problem on the private repo and demo site
Screenshots
Private

Demo

Gitea Version
1.22.0
Can you reproduce the bug on the Gitea demo site?
Yes
Operating System
No response
Browser Version
Firefox Stable latest

It's related to this function:
func NaturalSortLess(s1, s2 string) bool {
	c := collate.New(language.English, collate.Numeric)
	return c.CompareString(s1, s2) < 0
}

Golang considers 0.0 > 1.1 (also 0.txt > 1.txt), strange .....

I am assuming that means strictly comparing numbers ("0", "1", "2", etc.) will not have this problem, but when the numbers are mixed with text the problem surfaces. If that is the case it could be because internally CompareString is converting the 0 number into a different equivalent code that has a higher position than 1...9.
I did check unicode and ASCII tables to see if 0 would be position after 9 but so far nothing, the only place I found where that happens is on the numeric row of the keyboard layouts.
I also did a simple test with an online terminal and I got a different result than the one linked in your issue

collate version 0.16.0
https://pkg.go.dev/golang.org/x/text/collate#example-Collator.CompareString
So I am not sure why it is giving different results between the web terminal and local install.

 c := collate.New(language.English, collate.Numeric)
collate.Numeric means:
	// numeric specifies whether any sequence of decimal digits (category is Nd)
	// is sorted at a primary level with its numeric value.
	// For example, "A-21" < "A-123".

So v2.0 < v10.0

Yep, just realized it and retested again and got the same results as yours, I updated my previous entry to mention that.

Before Golang fixes their bug, let's try this:  Fix natural sort #31384


Add subdirectory create and delete events for Shared Directory (#9061)

This PR will merge #9061 AND #10470 with the next branch. #10470 is included because there was a build break introduced in #9061 that it fixes.
@jatgarg Since you are the author of the original PR, please review this change. If there are any CI failures, you may be asked to help resolve them.
If you want to approve the PR, please add an "Approve" review.
If the PR requires changes, either to fix CI failures or for other reasons, you can follow the instructions in the GitHub UI to check out this PR, make changes, and push them back to this PR branch.
Once approved, @tylerbutler will merge the change into the next branch.

@tylerbutler I didn't added this function "serializeDirectory" in directory.ts file in my origina commit in main. How is it present in this cherrypick?

@tylerbutler I didn't added this function "serializeDirectory" in directory.ts file in my origina commit in main. How is it present in this cherrypick? This is causing the issue: 'serializeDirectory' is declared but its value is never read.

Thanks, it was due to a bad merge. I've fixed it. Thanks for the approval -- I'll merge once CI passes.


HashSet: Add Semigroup instance

This will be necessary under GHC 8.4.

This is a duplicate of #168, no?

I was planning to merge #168 as soon as enough dependencies were worked out
for it to build on Travis, but if y'all prefer I can merge it now and take
the dependency updates as a separate PR.
On Sep 13, 2017 7:37 PM, "Ryan Scott"<EMAIL_ADDRESS>wrote:
This is a duplicate of #168
https://github.com/tibbe/unordered-containers/pull/168, no?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tibbe/unordered-containers/pull/169#issuecomment-329326927,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABzi_ScSliQwYy8S3tyPzYFMuShil0qoks5siGcugaJpZM4PW2ll
.

Ah. It's a bit of a complicated story... The changes needed to fix primitive have landed, but I'm not sure if we'd want to make a Hackage release of it so soon, since there are still some other SMP-related changes that have yet to land in GHC HEAD.

Closing in favor of #168.


exec64_msft.exe is broken

Oddly the Win32 versions of exec work and the Win64 version linked with GoLink work as expected. Microsoft link.exe generates exec64_msft.exe as expected, but the program crashes with "Access Denied" when executed.

This issue was discovered for link.exe in 2018 refresh using version 14.00.24234.1 but 2022 refresh using version 14.29.30145.0 is okay. Closing...

I was in win32 directory. Still repros in win64 :)

Fixed with commit 6be534b92001db65c306b3d3efd2a1f703aa056a


Add close() method for cleaning up the discovery swarm

Hi, I'm working on integrating this library with dat-js.
I'm writing the tests for the cleanup behavior, and it would be nice if you had an easy way to close the swarm in the same vein as discovery-swarm.
Would a PR with this support be welcome?

Hi @RangerMauve 👋 Wow that sounds great and yeah a PR will be super welcome.
Feel free to reach us if you need anything else. 👍

Cool! I'll probably do one some time today. 😀

closed by https://github.com/geut/discovery-swarm-webrtc/pull/2


Breaking change in 6.8.0: "Cannot read property 'immutableProps' of undefined"

I just upgraded from 6.7.0 to 6.8.0, and looking at the release I expected a seamless upgrade.
However, I am now seeing the following error on some forms, with no changes to my code following the upgrade:
createReduxForm.js:317 Uncaught TypeError: Cannot read property 'immutableProps' of undefined
    at Form.shouldComponentUpdate (createReduxForm.js:317)
    at [...Lots of React internals]

Seems the new immutableProps feature introduced this issue. The error is coming from Line 308 in createReduxForm.js:
const { immutableProps = [] } = initialConfig

This is the only line of code in that file which relies on initialConfig not being undefined. I'm seeing the error on a form in which I'm passing all redux-form config at runtime as props instead of at "design-time". As a result, my form creator looks like this:
// Error starting in 6.8.0
const ReduxFormContainer = reduxForm()(InnerForm);

If I pass in an empty object as the config, the error goes away but this shouldn't be required.
const ReduxFormContainer = reduxForm({})(InnerForm);

This appears to be a breaking change.
Would changing line 84 from return initialConfig => { to return (initialConfig={}) => { be a proper fix?

I see this has been fixed on master! Closing as this should no longer be an issue one a patch version is released 🙂

Adding the empty object to the reduxForm (e.g., reduxForm({})(...)) worked for me. Hopefully @erikras will put out a new patch / minor release soon containing the fix :)


Delete inside iterator

tx.AscendKeys("object:*", func(k, v string) bool {
	if someCondition(k) == true {
		if _, err = tx.Delete(k); err != nil {

                            // got: "tx is iterating" error here

			return false // break
		}
	}
	return true // continue
})

Is there a way to Delete inside iterator?

If not then it is "feature request".

This is a feature that I would like too and I hope to add it in the future.
Here's a workaround that I use:
var delkeys []string
tx.AscendKeys("object:*", func(k, v string) bool {
	if someCondition(k) == true {
		delkeys = append(delkeys, k)
	}
	return true // continue
})
for _, k := range delkeys {
	if _, err = tx.Delete(k); err != nil {
		return err
	}
}

I'm closing this issue for now as I haven't found the time to add this functionality. I may come back to this issue the future. In the meantime I added the workaround to the README in hopes that other may find is useful.
Feel free to reopen if needed.
Thanks!


VMServiceFlutterDriver: Flutter Driver extension is taking a long time to become available on iOS Simulator

Unable to run integration tests on iOS using the following command
flutter drive --flavor staging --driver=test_driver/integration_driver.dart   --target=integration_test/my_test.dart

the same command works perfectly for Android emulator
I have referenced https://github.com/flutter/flutter/issues/26968#issuecomment-485970830 but my FLUTTER_TARGET is correctly set
I have all the necessary code & log output below
Expected results:
Ideally, it should show the same behavior of execution as on Android Emulators

Code sample

Code in test_driver/integration_driver.dart
import 'dart:io';

import 'package:integration_test/integration_test_driver.dart';
import 'package:path/path.dart';

Future<void> main() async {
  await integrationDriver();
}

Code in integration_test/my_test.dart
import 'dart:io';
import 'dart:typed_data';

import 'package:my_app/main_staging.dart' as app;
import 'package:flutter/services.dart';
import 'package:integration_test/integration_test.dart';
import 'package:path_provider/path_provider.dart';

void main() {
  IntegrationTestWidgetsFlutterBinding.ensureInitialized();
  // enableFlutterDriverExtension();

  const MethodChannel channel =
      MethodChannel('plugins.flutter.io/image_picker');

  channel.setMockMethodCallHandler((MethodCall methodCall) async {
    ByteData data = await rootBundle.load('assets/png/avatar.png');
    Uint8List bytes = data.buffer.asUint8List();
    Directory tempDir = await getTemporaryDirectory();
    File file = await File(
      '${tempDir.path}/tmp.png',
    ).writeAsBytes(bytes);
    // Ex file path  /data/user/0/<package name>/cache/tmp.png
    printLog("Getting mocked file path ${file.path}");
    return file.path;
  });
  app.main();
}

Logs

the test hangs after following console output
...
VMServiceFlutterDriver: Flutter Driver extension is taking a long time to become available. Ensure your test app (often "lib/main.dart") imports "package:flutter_driver/driver_extension.dart" and calls enableFlutterDriverExtension() as the first call in main().

flutter doctor -v

[✓] Flutter (Channel stable, 2.2.3, on macOS 11.3.1 20E241 darwin-x64, locale en-IN)
    • Flutter version 2.2.3 at /Users/cs/flutter
    • Framework revision f4abaa0735 (7 months ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/cs/Library/Android/sdk
    • Platform android-32, build-tools 31.0.0
    • ANDROID_HOME = /Users/cs/Library/Android/sdk
    • ANDROID_SDK_ROOT = /Users/cs/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.1

[✗] Chrome - develop for the web (Cannot find Chrome executable at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Ultimate Edition (version 2021.2.3)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.64.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.34.0

[✓] Connected device (1 available)
    • iPhone 12 Pro Max (mobile) • 04F69029-20CE-4D5F-9F44-D35B72884868 • ios • com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)

! Doctor found issues in 1 category.

@Bhupesh-V
Can you upgrade to latest stable (2.10.1) and try again ? There's similar issue that you can take a look at and see if it helps.


select element that has specific text

hi!
how i can select a element that has a specific text?
And a suggestion :
in css or jquery when i want select a element with two class i use this syntax .class1.class2
but in your script it doesn't work.i think you choose this syntax for this : .class1+.class2
please fix this.Thank You.

i found a solution.i use this way to select element :  .class{SomeText}

i write this function and add that to Dom.php.
public function findWithText($selector, $text)
{
$this->isLoaded();
$results = $this->find($selector);
$return = new Collection;
foreach($results as $result){
if($result->text == $text){
$return[] = $result;
}
}
return $return;
}

Is there a normal way to do this (selecting elements with text) in css/jquery?
Could you also open another issue with the double class issue. I would like to keep each issue dedicated to a single problem.
Thanks.

no jquery has this syntax  $(":contains(text)")

I have not been able to get this to work. If some one else can find a solution to this please send me a pull request but I am not able to modify the regex to get this suntax to work, sorry.

JQuery has this selector syntax:
"a:contains('https://google.com')"
Any alternate way to use the same function meanwhile its not supported yet?


2.12 build: retire "scala" and/or "assemble" build systems (and thereby ant); use pre-built Scala instead

build's "scala" build system is ant-based and isn't really worth updating to use sbt, because there's no need anymore to "address the case in which a cycle exists between the core (library/compiler) and the modules" within dbuild — we can just let scripts/jobs/validate/publish-core do it for us and consume the artifacts it produces
once this is done, https://github.com/scala/scala/pull/5311 can be merged, bye forever Ant!

Adriaan's WIP commits on this:

https://github.com/adriaanm/community-builds/commit/bc9909aca200478e4b354271aebbee80bbafba73 ("resolve scala locker using aether")
https://github.com/adriaanm/community-builds/commit/de77bb8f24dc70d0c24f723ea365cb934c2f5a73 ("sample jenkins.properties")

Adriaan: "my experiment with sucking in the jenkins.properties into the community build didn't work. let's just hardcode it all for now, as you suggested, Seth". eventually we would like the community build to be part of a jenkins workflow, so that was the experiment, but for now it's fine to just check the properties into version control directly

in Adriaan's WIP the publish-core-built Scala was used everywhere as the extraction version, but I think it's better to use STARR so dbuild doesn't think it needs to re-extract every project every time

if we don't have jenkins.properties we need to get the Scala version from somewhere. I suggest we use scala_ref, but instead of a Git ref it will be e.g. abcd123-SNAPSHOT

in Adriaan's WIP we are still using the "assemble" build system to pull JARs (for scala-library, scala-compiler, scala-reflect) even though we aren't using it to build anything. perhaps that's not actually necessary? I'm not sure. leaving it that way for now anyway

my WIP branch: https://github.com/SethTisue/community-builds/commits/anticide . test run https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/539/consoleFull failed with a bunch of these errors: sbt.ResolveException: unresolved dependency: org.scala-lang#scala-reflect;2.12.0-dbuildxeed9f5dad952ad70ecb8e07ca56059866ae0bd3c: not found

oh, it's not normal that compiler, library, and reflect all have different dbuild-rewritten Scala version numbers. if you look at any green old-style community build run you see e.g.
[utest] All Dependencies for subproject utestJVM:
[utest]    org.scala-lang:scala-compiler:2.12.0-dbuildx0148c1c541133faa1b3e4436a07f80e2cbe1fa99:scala-tool->default,optional(default)
[utest]    org.scala-lang:scala-library:2.12.0-dbuildx0148c1c541133faa1b3e4436a07f80e2cbe1fa99:scala-tool->default,optional(default)
[utest]    org.scala-lang:scala-library:2.12.0-dbuildx0148c1c541133faa1b3e4436a07f80e2cbe1fa99
[utest]    org.scala-lang:scala-reflect:2.12.0-dbuildx0148c1c541133faa1b3e4436a07f80e2cbe1fa99

where it's dbuildx0148c1c54... every time. (and for further confirmation dbuild's CHANGELOG file says "all Scala artifacts will get the same dbuild-specific default version number as scala-library")

hmm, maybe getting rid of the whole "system: assemble" thing would fix it

http://typesafehub.github.io/dbuild/0.9.5/dbuild.html#assemble-specific-options recommends (in bright yellow!) not using "assemble" at all: "It is therefore advisable to adopt a regular (non-cyclic) build as soon as that is feasible". so yeah, I'll try just getting rid of it

looking at the RP build, it looks like another approach could be to use set-version to force the aether-retrieved JARs to have a shared version number

getting somewhere with set-version. next error (from log) is
[async] java.lang.NoClassDefFoundError: scala/xml/NodeSeq
[async] 	at scala.tools.nsc.doc.html.HtmlFactory.writeTemplates(HtmlFactory.scala:119)
[async] 	at scala.tools.nsc.doc.html.HtmlFactory.generate(HtmlFactory.scala:107)
[async] 	at scala.tools.nsc.doc.html.Doclet.generateImpl(Doclet.scala:23)
[async] 	at scala.tools.nsc.doc.doclet.Generator.generate(Generator.scala:23)

taking a cue from the RP build again, it looks like we need deps.inject: [ "org.scala-lang.modules#scala-xml"]

holy circularity Batman!
[scala-xml] java.lang.NoClassDefFoundError: scala/xml/NodeSeq
[scala-xml] 	at scala.tools.nsc.doc.html.HtmlFactory.writeTemplates(HtmlFactory.scala:119)
[scala-xml] 	at scala.tools.nsc.doc.html.HtmlFactory.generate(HtmlFactory.scala:107)
[scala-xml] 	at scala.tools.nsc.doc.html.Doclet.generateImpl(Doclet.scala:23)
[scala-xml] 	at scala.tools.nsc.doc.doclet.Generator.generate(Generator.scala:23)

Adriaan took a stab at it in https://github.com/scala/community-builds/compare/2.11.x...adriaanm:scala-resolve — looks like the key difference is to get scala-xml (and other modules? maybe only scala-xml is necessary?) from Aether

Running that build here: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/544/console

I confused myself a bit, but that approach works. scala-js just needed a patch or two
I'm hopeful this one will be green: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/553

@SethTisue could you clean up my scala-resolve branch and make the necessary changes in the Jenkins jobs to run this downstream from release-main? @szeiger is working on the bootstrap script / sbt support to pass down version numbers

We should also be able to trigger the community build job to consume the artifacts produced by publish-core (it will have to publish sources for scala-js to succeed, but otherwise good to go) when we don't need to bootstrap.

Adriaan's changes for cleaning-up are at https://github.com/scala/community-builds/pull/275

As I said on Slack, I'd like you to adopt & polish #275 along with the needed changes to the jenkins jobs (variable renames, incorporate into release-main flow). Please coordinate with Stefan for the sbt changes to propagate version from the release/nightly/publish-core jobs to the community build job.

#309 means we'll still be using the "assemble" build system, to resolve the scala/scala-xml circularity.
ultimately we'd like to cut that circularity altogether (by having scala-xml implement an API), then we won't need "assemble" anymore. someday.

the basic thing is done. the Jenkins/Chef part is now https://github.com/scala/scala-jenkins-infra/issues/189


"Added to timetable" notification

I've noticed that there is no feedback when you add a course to the timetable. A possible fix for this is to show a small notification on the bottom right corner for 3 seconds that says "Course added to timetable" and links to the homepage, where you can find the actual timetable.

Definitely needed for nicer UX. Not really that visible if VVZ is full screen on a bigger screen / higher resolution. Will still accept but could be improved in the future -> relative size, better position?


Unity 2019.2 compatibility

Can anyone confirm if it works in 2019.2 a13
It does not work for me.
It does work in 2018.3

I am just a guest trying to run this code, but I feel I can provide some information to the developers. Here, in Unity 2019.1.4f1 (.NET 4x), it prints the following errors:

Starting from the first error, I found this stack trace:
System.NullReferenceException: Object reference not set to an instance of an object

  at UnityToolbarExtender.ToolbarExtender..cctor () [0x00043] in C:\Users\...\unity-toolbar-extender-master\unity-toolbar-extender-master\Assets\ToolbarExtender\Scripts\Editor\ToolbarExtender.cs:23
UnityEditor.EditorAssemblies:ProcessInitializeOnLoadAttributes(Type[])

Which brought me to this part of the code:

The hightlighted line is the source of the error I am facing and unable to solve. Maybe I am completely wrong, but it seems the field was static (GetValue(null)) and now it is a non-static member (null reference after finding the field).
Other simple problems I solved:

I needed to set to .NET 4x manually, it reduced the amount of errors.
ToolbarCallback.cs had the using UnityEngine.Experimental.UIElements, now it is using UnityEngine.UIElements; (not Experimental anymore :-).
After that, you should fall in the error described above.

In 2019, the toolbar changed a bit so this probably breaks the code. The error is pretty trivial (we just use it for a length), if someone has a fix a PR is welcome!

I found this, maybe it helps...
https://github.com/Unity-Technologies/UnityCsReference/blob/master/Editor/Mono/GUI/Toolbar.cs
For the time being, I'm using the following:
#if UNITY_2019_1_OR_NEWER 			m_toolCount = 7; #elif UNITY_2018_1_OR_NEWER 			m_toolCount = 6; #elif UNITY_2017_4_OR_NEWER 			m_toolCount = 6; #else 			m_toolCount = 5; #endif
I think the "move rotate or scale" tool was added in 2017.4? I'll have to check though...

Hi Frank, could you make a PR with that change? I will approve.

Hi Frank, could you make a PR with that change? I will approve.

Can't seem to make the code indent right...
Anyway, the problem is that I've tried before but couldn't manage to do it... I'm fairly new to github (other than downloading) and I'd appreciate if you could explain quickly or direct me to a tutorial or something?

Sure thing!

You can fork the project like this: https://help.github.com/en/articles/fork-a-repo
Change the code on your fork (by checking it out locally and pushing your change, or just change it in GitHub directly
And then you can create a PR like this: https://help.github.com/en/articles/creating-a-pull-request-from-a-fork

Thanks @Frank-99 . I consider this one closed for now as a hacky fix fits perfectly in this hacky project ;)

Thank you very much for the help! :)
Also, I'm happy I was able to help out with a hacky fix, as you put it!
Do you think you can get access to the field, now that its a constant?
I'm not too experienced with this stuff yet, but from what I've read here, the exception is thrown when Quote: <>.
I'm guessing this doesn't sound too good, and that for now this 'fix' will have to do, right?

I see, I didn't actually look at any of the new code, but the field just changed name! In the project, change s_ShownToolIcons to k_ToolCount and it will work. (see https://github.com/Unity-Technologies/UnityCsReference/blob/master/Editor/Mono/GUI/Toolbar.cs)
If you make that change, feel free to make another PR, it's a better fix!

I tried to do so, but I still get the following error...
`System.InvalidCastException: Specified cast is not valid.
at UnityToolbarExtender.ToolbarExtender..cctor () [0x00043] in F:\Unity\Projects\ProjectName\Assets\ToolbarExtender\Scripts\Editor\ToolbarExtender.cs:24
UnityEditor.EditorAssemblies:ProcessInitializeOnLoadAttributes(Type[])
`

It's not an array anymore, it's an int now. So instead of casting to an array and getting the length, just cast the result of GetValue to an int.

Yeah, sorry... I'm really tired, and when I saw the error I just assumed it was the same as before, without even checking, my bad ahah

Plus the heat is really a killer today, here...
Anyway, issue should be fixed now!
Glad i was able to help a little more :)

Cool, enjoy the heat a bit if you can ;)


Make an alternative damage animation for global powers

Instead of just damage, all unit affecting animations have been updated in b874851e898845df620f1c7ae18a52f4143b96e7


fix: add plugin can not be confirm

Signed-off-by: liuying<EMAIL_ADDRESS>
What type of PR is this?
/kind bug

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for reviewers:

Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

Codecov Report

Merging #227 (a0ea666) into master (03493f3) will not change coverage.
The diff coverage is n/a.


Example config.json file missing

Hello Alex
I was wondering if you can provide an example of a config.json file you used to run the assembler since it seems to be missing.
Thanks,
Andy

Hello Alex
Did you attach a skeleton config.json file? I cant seem to find it.
Cheers,
Andy

Hi Andy,
Apparently replying and attaching in email doesn't go through.  How about now?  It won't let me attach a *json so I moved it to a *txt file.
config.json.txt
alex

Thanks Alex!

Hello again Alex
I seemed to have run into this error and im not exactly sure what the
problem is:
2017-09-27 10:03:22 - --starting logging IndexReadsStep_Andynew --
2017-09-27 10:03:22 - index fastq
/srv/projects2/aom/10X/Andynew/outs/interleaved.seqpurged.fastq
2017-09-27 10:03:22 - ========== Exception ==========
2017-09-27 10:03:22 - Traceback (most recent call last):
2017-09-27 10:03:22 -   File
"/srv/sw/miniconda3/envs/athena_1.0/lib/python2.7/site-packages/athena/pipeline.py",
line 50, in _run_chunk
2017-09-27 10:03:22 -     chunk.run()
2017-09-27 10:03:22 -   File
"/srv/sw/miniconda3/envs/athena_1.0/lib/python2.7/site-packages/athena/stages/index_reads.py",
line 62, in run
2017-09-27 10:03:22 -     with FastqIndex(self.nfq_path, self.logger) as idx:
2017-09-27 10:03:22 -   File
"/srv/sw/miniconda3/envs/athena_1.0/lib/python2.7/site-packages/athena/mlib/fq_idx.py",
line 35, in init
2017-09-27 10:03:22 -     self.build_index()
2017-09-27 10:03:22 -   File
"/srv/sw/miniconda3/envs/athena_1.0/lib/python2.7/site-packages/athena/mlib/fq_idx.py",
line 70, in build_index
2017-09-27 10:03:22 -     lambda(x): x[0],
2017-09-27 10:03:22 -   File
"/srv/sw/miniconda3/envs/athena_1.0/lib/python2.7/site-packages/athena/mlib/util.py",
line 117, in fastq_iter
2017-09-27 10:03:22 -     qname, _, bcode = lines[0].strip().split('\t')[:3]
2017-09-27 10:03:22 - ValueError: need more than 1 value to unpack
2017-09-27 10:03:22 -
2017-09-27 10:03:22 - need more than 1 value to unpack
Do you know what this means?
I noticed your example reads look like this:
@NS500418:354:H27G3BGXY:3:12612:25572:11380 RG:Z:readgroup1
BC:Z:GCCAATTCAAGTTT-1
TTCCATGTGGAAGTAGTTGTATTTGACGTAGCCCGCCATACCGTTTTCTGACATGAAGCGGTAATTCTCCTCAGAACCGTAGCCGGATACGGCCACCACCGTATGGGCCAACCTGTCATATCTGCTTGAGAAGGATTG
+
EEEEEEEEEEEEEEEEEEEEEEEEEAEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE/EEEEEEEEEEEEEEEEEEE6EEAEEEEAEEEEEEEEEEEEEEAEEEEEEEEEEEEEAEEEEEE
But mine looks like this:
@NS500333:151:HNM55AFXX:2:11308:1131:10378 BX:Z:ACACGATCATTGAAAG-1
TCTATGATTCCATCAAGGTTAGTAACATTAACCTTTGGTGGAATCATAGAAAAAATGCAGGGCGAAGGGACTAATGGGAAATTGATTGAGCTCAAGGCAGAGGATGATATGATTAATGTGGATGTGCCAGAGAAGCTATCAAAAGAGCTTG
+
AAA6AE6EEEE/EEAEEEEEEEE<AAEEAEEEEEEEEEEEEEEEAAE6E/AA6EEEEEAEEEEE6AEEE/EE6AEAEE66AEEE/EAE/<EAE//AAA////6/E//E/EA/E///AEAE/<A//<</<</A//A/E/<<//////E<</6
Would this be the reason for the error? Also when you were generating
the reads, did you use the longranger makefastq and basic proram?
Cheers,
Andy
On 9/27/17, abishara<EMAIL_ADDRESS>wrote:

Hi Andy,
Apparently replying and attaching in email doesn't go through.  How about
now?  It won't let me attach a *json so I moved it to a *txt file.
config.json.txt
alex
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/abishara/athena_meta/issues/6#issuecomment-332289119

Hello again Alex
I seemed to have run into this error and im not exactly sure what the
problem is:
2017-09-27 10:03:22 - --starting logging IndexReadsStep_Andynew --
2017-09-27 10:03:22 - index fastq
/srv/projects2/aom/10X/Andynew/outs/interleaved.seqpurged.fastq
2017-09-27 10:03:22 - ========== Exception ==========
2017-09-27 10:03:22 - Traceback (most recent call last):
2017-09-27 10:03:22 -   File
"/srv/sw/miniconda3/envs/athena_1.0/lib/python2.7/site-packages/athena/pipeline.py",
line 50, in _run_chunk
2017-09-27 10:03:22 -     chunk.run()
2017-09-27 10:03:22 -   File
"/srv/sw/miniconda3/envs/athena_1.0/lib/python2.7/site-packages/athena/stages/index_reads.py",
line 62, in run
2017-09-27 10:03:22 -     with FastqIndex(self.nfq_path, self.logger) as idx:
2017-09-27 10:03:22 -   File
"/srv/sw/miniconda3/envs/athena_1.0/lib/python2.7/site-packages/athena/mlib/fq_idx.py",
line 35, in init
2017-09-27 10:03:22 -     self.build_index()
2017-09-27 10:03:22 -   File
"/srv/sw/miniconda3/envs/athena_1.0/lib/python2.7/site-packages/athena/mlib/fq_idx.py",
line 70, in build_index
2017-09-27 10:03:22 -     lambda(x): x[0],
2017-09-27 10:03:22 -   File
"/srv/sw/miniconda3/envs/athena_1.0/lib/python2.7/site-packages/athena/mlib/util.py",
line 117, in fastq_iter
2017-09-27 10:03:22 -     qname, _, bcode = lines[0].strip().split('\t')[:3]
2017-09-27 10:03:22 - ValueError: need more than 1 value to unpack
2017-09-27 10:03:22 -
2017-09-27 10:03:22 - need more than 1 value to unpack
Do you know what this means?
I noticed your example reads look like this:
@NS500418:354:H27G3BGXY:3:12612:25572:11380 RG:Z:readgroup1
BC:Z:GCCAATTCAAGTTT-1
TTCCATGTGGAAGTAGTTGTATTTGACGTAGCCCGCCATACCGTTTTCTGACATGAAGCGGTAATTCTCCTCAGAACCGTAGCCGGATACGGCCACCACCGTATGGGCCAACCTGTCATATCTGCTTGAGAAGGATTG
+
EEEEEEEEEEEEEEEEEEEEEEEEEAEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE/EEEEEEEEEEEEEEEEEEE6EEAEEEEAEEEEEEEEEEEEEEAEEEEEEEEEEEEEAEEEEEE
But mine looks like this:
@NS500333:151:HNM55AFXX:2:11308:1131:10378 BX:Z:ACACGATCATTGAAAG-1
TCTATGATTCCATCAAGGTTAGTAACATTAACCTTTGGTGGAATCATAGAAAAAATGCAGGGCGAAGGGACTAATGGGAAATTGATTGAGCTCAAGGCAGAGGATGATATGATTAATGTGGATGTGCCAGAGAAGCTATCAAAAGAGCTTG
+
AAA6AE6EEEE/EEAEEEEEEEE<AAEEAEEEEEEEEEEEEEEEAAE6E/AA6EEEEEAEEEEE6AEEE/EE6AEAEE66AEEE/EAE/<EAE//AAA////6/E//E/EA/E///AEAE/<A//<</<</A//A/E/<<//////E<</6
Would this be the reason for the error? Also when you were generating
the reads, did you use the longranger makefastq and basic proram?
Cheers,
Andy
On 9/27/17, andy leu<EMAIL_ADDRESS>wrote:

Hello again Alex
I seemed to have run into this error and im not exactly sure what the
problem is:
2017-09-27 10:03:22 - --starting logging IndexReadsStep_Andynew --
2017-09-27 10:03:22 - index fastq
/srv/projects2/aom/10X/Andynew/outs/interleaved.seqpurged.fastq
2017-09-27 10:03:22 - ========== Exception ==========
2017-09-27 10:03:22 - Traceback (most recent call last):
2017-09-27 10:03:22 -   File
"/srv/sw/miniconda3/envs/athena_1.0/lib/python2.7/site-packages/athena/pipeline.py",
line 50, in _run_chunk
2017-09-27 10:03:22 -     chunk.run()
2017-09-27 10:03:22 -   File
"/srv/sw/miniconda3/envs/athena_1.0/lib/python2.7/site-packages/athena/stages/index_reads.py",
line 62, in run
2017-09-27 10:03:22 -     with FastqIndex(self.nfq_path, self.logger) as
idx:
2017-09-27 10:03:22 -   File
"/srv/sw/miniconda3/envs/athena_1.0/lib/python2.7/site-packages/athena/mlib/fq_idx.py",
line 35, in init
2017-09-27 10:03:22 -     self.build_index()
2017-09-27 10:03:22 -   File
"/srv/sw/miniconda3/envs/athena_1.0/lib/python2.7/site-packages/athena/mlib/fq_idx.py",
line 70, in build_index
2017-09-27 10:03:22 -     lambda(x): x[0],
2017-09-27 10:03:22 -   File
"/srv/sw/miniconda3/envs/athena_1.0/lib/python2.7/site-packages/athena/mlib/util.py",
line 117, in fastq_iter
2017-09-27 10:03:22 -     qname, _, bcode =
lines[0].strip().split('\t')[:3]
2017-09-27 10:03:22 - ValueError: need more than 1 value to unpack
2017-09-27 10:03:22 -
2017-09-27 10:03:22 - need more than 1 value to unpack
Do you know what this means?
I noticed your example reads look like this:
@NS500418:354:H27G3BGXY:3:12612:25572:11380 RG:Z:readgroup1
BC:Z:GCCAATTCAAGTTT-1
TTCCATGTGGAAGTAGTTGTATTTGACGTAGCCCGCCATACCGTTTTCTGACATGAAGCGGTAATTCTCCTCAGAACCGTAGCCGGATACGGCCACCACCGTATGGGCCAACCTGTCATATCTGCTTGAGAAGGATTG
+
EEEEEEEEEEEEEEEEEEEEEEEEEAEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE/EEEEEEEEEEEEEEEEEEE6EEAEEEEAEEEEEEEEEEEEEEAEEEEEEEEEEEEEAEEEEEE
But mine looks like this:
@NS500333:151:HNM55AFXX:2:11308:1131:10378 BX:Z:ACACGATCATTGAAAG-1
TCTATGATTCCATCAAGGTTAGTAACATTAACCTTTGGTGGAATCATAGAAAAAATGCAGGGCGAAGGGACTAATGGGAAATTGATTGAGCTCAAGGCAGAGGATGATATGATTAATGTGGATGTGCCAGAGAAGCTATCAAAAGAGCTTG
+
AAA6AE6EEEE/EEAEEEEEEEE<AAEEAEEEEEEEEEEEEEEEAAE6E/AA6EEEEEAEEEEE6AEEE/EE6AEAEE66AEEE/EAE/<EAE//AAA////6/E//E/EA/E///AEAE/<A//<</<</A//A/E/<<//////E<</6
Would this be the reason for the error? Also when you were generating
the reads, did you use the longranger makefastq and basic proram?
Cheers,
Andy
On 9/27/17, abishara<EMAIL_ADDRESS>wrote:

Hi Andy,
Apparently replying and attaching in email doesn't go through.  How about
now?  It won't let me attach a *json so I moved it to a *txt file.
config.json.txt
alex
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/abishara/athena_meta/issues/6#issuecomment-332289119

Hi Andy,
Your *fastq looks fine from that single entry excerpt, and yes we use longranger makefastq+basic to generate our input *fastq files.  The error you encountered has since been addressed in the source repo.  Can you update to the latest version and give it another try?  Let me know if that takes care of it.
Thanks!
alex

Hello  Alex
when i used long ranger basic to deal with my 10X data, I found that the extracted barcoded reads were  fewer than other software, which may due to the strict criterion. Is there any parameter for long ranger basic to relax such criterion: for example, the extracted barcode my be allowed to have N.
Thanks
alex

Hi,
I recommend contacting the software support at 10X to ask why their longranger basic software is giving less reads than you expect from one of their libraries.
Please feel free to create another issue if you encounter issues with using the resulting barcoded *fastq with Athena.
Best,
alex


function calling and vision improvements

Refactor together service to use the openai library as per Together.ai's current recommendation to best support function calling.
Implement vision for openai service.

LGTM! So good to remove code!


Auto-generated citation needs to include Extended Abstracts or Poster Proceedings properly

Addressed this here: https://github.com/makeabilitylab/makeabilitylabwebsite/commit/d80910c0df05a642adf7af328167034aef0b67db

This is on production:


RepeatMasker "forksys: Program terminated by a signal 7"

Hi all,
I'm running RepeatMasker using TETools through the singularity wrapper script. And it seems to be terminating at the same spot. I get the following error message while it is generating the output:
forksys:  Program terminated by a signal 7. The executing command was:  /opt/RepeatMasker/ProcessRepeats -lib consensi.fa.classified -gff -poly -u -source -html -xm -orifile assembly_v1.0.fasta -maskSource /home/roger/Analysis/Assembly_v1.0/RM_1798.MonMar92212332020/assembly_v1.0.fasta -xsmall /home/roger/Analysis/Assembly_v1.0/RM_1798.MonMar92212332020/assembly_v1.0.fasta.cat.gz
I'm using this command:
RepeatMasker -pa 30 -gff -html -xsmall -lib consensi.fa.classified -xm -u -poly -q -source assembly_v1.0.fasta
any ideas what the problem could be?

Can you also report your kernel version / operating system distribution (uname -a)?
Signal 7 on linux is SIGBUS, which indicates a memory access error. It is unusual that it would happen from ProcessRepeats, which is a perl script.
Luckily ProcessRepeats is the last step, so nothing significant has been lost. I first suggest manually re-running that /opt/RepeatMasker/ProcessRepeats -lib consensi.fa.classified -gff -poly ... command again in case it was a spurious error.

Kernel version: Linux version 4.15.0-88-generic (buildd@lgw01-amd64-036) (gcc version 7.4.0 (Ubuntu 7.4.0-1ubuntu1~18.04.1)) #88-Ubuntu SMP Tue Feb 11 20:11:34 UTC 2020
Manually re-running the ProcessRepeats step did the trick. I've run the whole pipeline three times, with some modified parameters, and error happened every time. I also used conda to install RepeatModeler that way, and reran RepeatMasker, and the same error occurs.
At least I have a workaround now! Thank you!

Come to think of it, I believe that error can also be caused by running out of memory. If you do further runs of RepeatModeler it would be a good idea to watch the memory usage and make sure you are safely under available memory / limits.
Closing for now, until there is enough information to reproduce or trace a cause.