NIFI-1582 initial commit of UpdateAttribute with state

Little preemptive on the opening of the PR, forgot to add documentation for the new feature.


Merge Java Class Viewer into BinaryInternalsViewer

Because most of the functions are the same, so we try to merge them.
BinaryInternalsViewer is a plug-able and can support multiple formats, including .class file.

Follow up actions

Update mass change test script for .class files

Follow up actions

Add detailed descriptions for different tree nodes of .class file.


Bump to 4.13

The operator is currently disabled in ART's config for 4.13. It can be safely re-enabled once version is bumped
Ref. https://issues.redhat.com/browse/ART-5087

/assign @pliurh

@locriandev Could you rebase the PR?

Hi @locriandev, looks like a new rebase is required :(
@pliurh, apart from the rebase, is there anything else ART needs to do to get this merged?

If needed, I can push a new PR that properly bumps the version to avoid waiting for this. @thiagoalessio

You forgot the Makefile

/lgtm

/label approved

/approve


nixos networking module: resolvconf + dnsmasq

keep /etc/resolv.conf static when using dnsmasq
make resolvconf restart dnsmasq after an update

Any objections against that change?

cc @edolstra

I would prefer to have /etc/resolv.conf managed consistently, i.e., via resolvconf.

Could you maybe help me to understand your concerns? I thought the idea of having dnsmasq in the loop is to have a static /etc/resolv.conf that points to dnsmasq only, and then only update dnsmasq with resolvconf?

@edolstra I still think that this PR improves the current implementation when using dnsmasq to resolve DNS queries locally. If you don't have any strong objections I would go ahead and merge the PR in the next days.

I don't understand what this change does. What does it mean to "keep /etc/resolv.conf static"?

The desired configuration is that /etc/resolv.conf should point to dnsmasq, and then dnsmasq gets updated by resolvconf.
Currently, resolvconf updates dnsmasq and /etc/resolv.conf. libc=NO should stop that.
dnsmasq_restart=... makes sure dnsmasq actually reloads the new DNS settings provided by resolvconf.
An example where it is not desirable to write new nameservers into /etc/resolv.conf with resolvconf directly are, for example, VPN connections into a private network. When dnsmasq is receiving the updates from resolvconf, then the added DNS server can be bound to the private domain to only be queried for the private domain of the VPN. All other DNS traffic is still forwarded normally through the local network. Unfortunately, a setup like that is not possible within /etc/resolv.conf directly.

@edolstra Just as I don't know how github works, do you automatically get all messages that are written in a PR that you are a participant of, or do I have to at you explicitly in a message?

This behavior is working fine for me even before your change. Dnsmasq uses
inotify to determine when to reload /etc/dnsmasq-resolv.conf after
resolvconf writes to it. My resolv.conf currently and also seems to only
contain nameserver <IP_ADDRESS>
On Mon, Sep 14, 2015, 09:49 ts468<EMAIL_ADDRESS>wrote:

@edolstra https://github.com/edolstra Just as I don't know how github
works, do you automatically get all messages that are written in a PR that
you are a participant of, or do I have to at you explicitly in a message?
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/pull/9683#issuecomment-140141813.

@wkennington Thanks, I didn't know that dnsmasq uses inotify. But I've also got domain ... and search ... entries in /etc/resolv.conf that resolvconf is including for my VPN connections. What would be the disadvantage of setting libc=NO?

Is that not more inline with the behavior you expect when using a dhcp
client. As far as I'm aware, if you prevent those from being set, then you
are breaking dhcp setting the default search domain as I don't think
dnsmasq adds it back in.
On Mon, Sep 14, 2015, 14:18 ts468<EMAIL_ADDRESS>wrote:

@wkennington https://github.com/wkennington Thanks, I didn't know that
dnsmasq uses inotify. But I've also got domain ... and search ... entries
in /etc/resolv.conf that resolvconf is including for my VPN connections.
What would be the disadvantage of setting libc=NO?
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/pull/9683#issuecomment-140208749.

@wkennington Thanks for your help! How do I prevent resolvconf from adding search domains for private interfaces then? I've got the option of adding a domain with the expand-hosts option in dnsmasq, but I don't know of a way how to get rid of a domain that is included in /etc/resolv.conf. Does it mean I should patch resolvconf instead?

I'll look into this more but I'm pretty sure that is something you have to
live with unless you want to disable writing to /etc/resolv.conf entirely
and possible breaking some things. You could do this in your own configs
but I don't think this is a sane default.
On Tue, Sep 15, 2015 at 12:02 AM ts468<EMAIL_ADDRESS>wrote:

@wkennington https://github.com/wkennington Thanks for your help! How
do I prevent resolvconf from adding search domains for private interfaces
then? I've got the option of adding a domain with the expand-hosts option
in dnsmasq, but I don't know of a way how to get rid of a domain that is
included in /etc/resolv.conf. Does it mean I should patch resolvconf
instead?
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/pull/9683#issuecomment-140299733.

Thanks for your feedback and efforts so far! I've removed the default values from the PR and introduced a simple hook into resolvconf.conf instead. Would that be OK?

The changes shouldn't hurt anyone, so merging the PR.


add first draft of stats

This is a first draft of the stats section. I want to add more, but I am not sure exactly what yet.
This should act as a jumping off ground.

If @RMeli or @WG150 have comments they are more than welcome.

Looks alright, but... "This plot gives the probability that a particular value of $k$ would be measured" is not correct. The probability is deduced from an integral of the probability density function evaluated between two values. Having a pdf with values (> 1) may confuse students who see the pdf as probability. You could use "k_300 = np.array([13.31, 13.13, 13.17, 13.23, 12.17])" instead so all pdf values are below one. But that is still lying to the students if we say the pdf is equivalent to probability.

this is a good point, getting density and distribution mixed up. Will sort.

A lazy fix, I have changed it to relative likelihood, which I think is more accurate


Problems with travel Permalinks

https://www.apache.org/travel/stories/big_data.html#big-data-stories-for-past-travel-assistance-recipients
has become
https://www.staged.apache.org/travel/stories/big_data.html#big-data-stories-from-past-travel-assistance-recipients
Whilst it is OK to change the displayed text, it is not OK to change the associated Permalink.
There are several other similar instances in the travel section

If someone wants to fix these then the
# Big Data stories from past Travel Assistance Recipients {#big-data-stories-for-past-travel-assistance-recipients}

That syntax does not appear to be documented


Update Installation section in README

Added missing package to go through README tutorial

Thanks @isnifer , merging, and I'll improve it in a few minutes, because we need to tell people to add libraries according to their needs.


PATH of quickstart code is wrong

quickstart -> quickstarts

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

azure-go-sdk-conceptual/azure-sdk-go-qs-vm.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thank you for your contribution!


Error in /start-deploy-FTBA when setting up new docker on Raspberry Pi5

Describe the problem
I have tried to setup a container with this image today on a new Raspberry Pi 5, but am left with this error:
/start-deployFTBA: line 48: =/arm: No such file or directory
I have tried several combinations of modpacks from FTB and java version but ultimately run in the same error.
As I am new to docker it may be my fault, but looking into the GitHub commits it appears that the line throwing the error is rather new and the curl-call was handled differently before. I am not an expert in shell skripting, but this might be the problem. Would be happy for help.
Container definition
docker run -d --name mc-ftb -e EULA=TRUE   -e TYPE=FTBA -e FTB_MODPACK_ID=119  -p 25565:25565 -v /home/samuel/Docker/Minecraft/FTB_DW_21/  itzg/minecraft-server:java17

but also with different modpack/java version:
docker run -d --name mc-ftb -e EULA=TRUE   -e TYPE=FTBA -e FTB_MODPACK_ID=20   -p 25565:25565 -v /home/samuel/Docker/Minecraft/FTB_IE_S/   itzg/minecraft-server:java8

Container logs
[init] Running as uid=1000 gid=1000 with /data as 'drwxr-xr-x 2 1000 1000 4096 Oct 24 12:20 /data'

[init] Downloading FTB installer

[init] Downloading ARM installer

/start-deployFTBA: line 48: =/arm: No such file or directory

Yes your suspicion is mostly likely correct about that line probably being a new issue. I'll work on fixing that.

Or @IronMine if you can get to it before me.
I'm guess it's a regression from #3108

Or @IronMine if you can get to it before me.
I'm guess it's a regression from #3108

I am on it !

Thanks for the speedy replies! Very much appreciated!

Thanks for the speedy replies! Very much appreciated!

i made a mistake i am sorry ! it's normal to be fast

Fix will be in this build https://github.com/itzg/docker-minecraft-server/actions/runs/11532283059


Use FEMQuad.jl to calculate quadrature rules for elements

The code is separated from JuliaFEM.jl to its own package now.

Coverage increased (+0.3%) to 90.887% when pulling e9d6772f74cfd200b33a566e70829b44dc129ac7 on FEMQuad.jl into d7eb6133d47673004db13d24a24a8bdfa32afca8 on master.


translation

Hello, Mr. Daniel.
I am a developer from China. Can I fork this repository and translate it into Chinese? In China, many developers have poor English skills. I think this will help more developers use cURL effectively. Of course, the author's signature is still you. I'm just doing a translation job myself. Thank you. Look forward to your reply.

Hello!
You're of course much welcome and free to translate this document. It is no doubt a lot of hard work. Please keep the file names intact and put all the translated files in a new subdirectory zh/ as then once you have something to present, we can merge that into this repo and I can move the English pages into en/ and we can get the book presented in both languages!

Ok, I'll do as you say. I will take some personal time to do it every day. I think it will be a long time. Let's make this book more perfect together. Thanks again for your permission, Mr. Daniel.

Closing this issue for now. Please create PR(s) if you end up with something suitable to merge!


CONTRIBUTING for matrix-doc

fixes https://matrix.org/jira/browse/SPEC-418

On my side, this looks fine - pending Ara feedback.

@ara4n: PTAL?

lgtm - thanks :)


Question:  What are you using for the offline database?

I don't see IndexDb being used in your code and was wondering how you store the offline data?

The repo is designed to use an injected client-side Feathers service. For
the moment however its using its own in-memory custom service.
First, I want to reduce the number of moving parts until we're sure the
repo is solid. Second, I've been waiting on a project that's building a JS
friendly indexed store to run on the server, browser, Android and iOS.
On Wed, Oct 18, 2017 at 7:11 PM, Daniel Elebash<EMAIL_ADDRESS>wrote:

I don't see IndexDb being used in your code and was wondering how you
store the offline data?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/feathers-plus/feathers-offline-realtime/issues/15,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABezn_8h4QJYP0FwSMr46QVlak6z5DdAks5stoWegaJpZM4P-fEo
.


"Root redirector" syntax error when updating under Ubuntu 18.04

Just did an apt upgrade on my Ubuntu 18.04 machine and noticed this output when it got to the Keybase client:
Setting up keybase (2.11.0-20181121195344.99751ac04f) ...
Restarting existing root redirector.
bash: -c: line 0: syntax error near unexpected token `('
bash: -c: line 0: `nohup "/usr/bin/keybase-redirector" "/keybase" &>> /keybase/keybase.redirector.log &'
Root redirector now running as jcm.
Redirector hasn't started yet.

Haven't noticed any other weird behavior yet (and didn't see anything else in my apt output), but is this anything I should be worried about?

@myersjustinc interesting.  Is $XDG_CACHE_HOME set to anything unusual for the account that's running keybase (jcm)?  Maybe something with a parenthesis in it?

For what it's worth, I just updated again to 2.11.0-20181127185939.b44f456354 using Ubuntu's Software Updater utility (since it prompted me), and I didn't get that error. Only got the line that said Restarting existing root redirector. Maybe nothing to worry about!

Thanks for the update. Let us know if it happens again!

@heronhaye As requested, letting you know since this has happened again. It's happened for the last few updates, at least, but I don't remember for sure when it started again. In any case, it's been helpful that the run_keybase instruction has been added.
Relevant portion of my apt upgrade run, along with the packages immediately before and after:
Setting up linux-headers-generic (<IP_ADDRESS>.68) ...
Setting up keybase (4.7.0-20191021162721.67d9526320) ...
Restarting existing root redirector.
Redirector hasn't started yet.
-su: -c: line 0: syntax error near unexpected token `('
-su: -c: line 0: `XDG_RUNTIME_DIR=/run/user/1000 systemctl --user -q is-active keybase.service 2> /dev/null'
Keybase not running via systemd for jcm.
Restart Keybase manually by running 'run_keybase' as jcm.
Setting up linux-modules-extra-4.15.0-66-generic (4.15.0-66.75) ...

Sorry to hear that, We're going to get rid of this autorestarting mechanism in the nearish future so this code won't run.


Rake task should remove old vendor cookbooks before vendor again

Hi,
Every time Berks vendor the cookbooks for the delivery-cluster cookbook itself, it would re-creating subfolder cookbooks recursively.
We need a job to remove old vendor cookbooks, like
msg 'Remove old vendored cookbooks'
system 'rm -rf cookbooks/*'

msg 'Download and vendor the necessary cookbooks locally'
system 'chef exec berks vendor cookbooks'

@chrisduong Thank you so much for your feedback. Now we clean the cache before we run the prerequisites!!! 👍 https://github.com/chef-cookbooks/delivery-cluster/commit/18eb4739e6cbe101649bae6b3c3174bf595308c5


Fix useAccountSubmit ignoring empty error messages

Fixes #1.

That can only occur if there is a typescript error, so I don't think we should put too much error handling here as typescript should handle it.


After 1.7 LiT installation, missing Pool account/funds

I had pool with an active account and funds on 1.6.X. After upgrading to 1.7 and installing LiT, I no longer seem to have my existing pool account. I have active leases and funds so I'm a bit lost on what I'm supposed to do to recover those.
It's a non trivial amount so any advise would be great.

LIT is a new bundle of pool - its not using the old data. But you can reactivate the old pool single instance also which should have your old data with /home/admin/config.scripts/bonus.pool.sh on on terminal. After install see info on /home/admin/config.scripts/bonus.pool.sh menu.

Doesn't work.
pool@raspberrypi:~ $ pool getinfo
[pool] open /home/pool/.pool/mainnet/tls.cert: no such file or directory

More problems.
Reboot seemed to allow me to call pool getinfo but now with a different problem
pool@raspberrypi:~ $ pool getinfo
[pool] rpc error: code = Unimplemented desc = unknown method GetInfo for service poolrpc.Trader

but I can run some other stuff like accounts:
pool accounts list
{
	"accounts": []
}

However seems like my pool info was deleted.
reinstalling lit doesn't work because it doesn't remove the group properly.
admin@raspberrypi:~ $  /home/admin/config.scripts/bonus.lit.sh on
making sure the lit service is not running
# INSTALL LIGHTNING TERMINAL
adduser: The group `lit' already exists.

Trying to recover funds with pool or lit-pool results in
pool@raspberrypi:~ $ pool accounts recover
[pool] rpc error: code = Unknown desc = error performing recovery: could not recover account 02f3a961a097c69f52ecbdf89eba3266ab47682595e3417451a6f48ff42de8b621: error during authentication, before sending subscribe: rpc error: code = Internal desc = payment required

Despite being well connected enough.
I guess I'll wipe my device and try again?
Some suggestions of things to fix so others don't lose funds like I have.

Don't install LiT if there's an existing pool installation.
Warn users that a pool uninstall will result in a loss of funds (your LiT installation seems to be deleting my existing pool data, but if you fix 1, then warn)
Uninstall LiT properly so that it may be reinstalled again

I have no idea why a well connected node is having payment problems to pool, I can only imagine something screwed up with the install in general.

@openoms can you take a look

I can also confirm that my attempt of reinstalling LiT was unsuccessful.
admin@raspberrypi:~ $  /home/admin/config.scripts/bonus.lit.sh on
making sure the lit service is not running
# INSTALL LIGHTNING TERMINAL
adduser: The group `lit' already exists.

After removing the group manually I was able to reinstall it using the script. I think the uninstall script is not removing the LiT group. Let me know if I should open a proper issue for this. I'm just giving my feedback for now.
Thanks for your awesome work!

@mbombonato to reinstall first uncheck in SERVICES or use:
/home/admin/config.scripts/bonus.lit.sh off
that will run:
sudo userdel -rf lit
https://github.com/rootzoll/raspiblitz/blob/be19c565cb5fb570abcd7cf6ad83cc5e4b840520/home.admin/config.scripts/bonus.lit.sh#L360
which removes the user.
can use this step manually.
Uninstalling the lit user does nor delete data because it is symlinked from the disk.
@rootzoll bonus.loop.sh and bonus.lit.sh
are using the same data directory:
/mnt/hdd/app-data/.pool/
symlinked from the disk.
https://github.com/rootzoll/raspiblitz/blob/be19c565cb5fb570abcd7cf6ad83cc5e4b840520/home.admin/config.scripts/bonus.lit.sh#L146
@AnthonyRonning Likewise you pool data should be in:
/mnt/hdd/app-data/.pool/
and should be appearing on a reinstall between scripts as that directory is not deleted in any script.
To reach the Pool CLI while having lit installed use the alias:
lit-pool
can you please try reinstalling LIT again from the menu?
and check the contents:
$ ls -la /mnt/hdd/app-data/.pool/
total 16
drwxr-xr-x  4 lit  lit  4096 Oct 10  2020 .
drwxr-xr-x 15 root root 4096 Mar 28 11:02 ..
drwxr-xr-x  3 lit  lit  4096 Oct 10  2020 logs
drwxr-xr-x  2 lit  lit  4096 Oct 11  2020 mainnet

confirm the symlink:
$ ls -la /home/lit/.pool
lrwxrwxrwx 1 root root 24 Apr 18 17:52 /home/lit/.pool -> /mnt/hdd/app-data/.pool/

@AnthonyRonning just noting for the peace of mind, that even if the pool account has been somehow deleted the funds in the pool multisig will be returned automatically to the onchain part of the lnd wallet after the Pool account expires.
Checked that the bonus.pool.sh was using the
 /mnt/hdd/app-data/.pool
directory to store the data as well.
https://github.com/rootzoll/raspiblitz/blob/755b7460ca7d8f6aa614748e534ec0941fc891ea/home.admin/config.scripts/bonus.pool.sh#L55
Is that possible that you have installed Pool manually or with some early, experimental version of the script?

even if the pool account has been somehow deleted the funds in the pool multisig will be returned automatically to the onchain part of the lnd wallet after the Pool account expires.

I'm chatting with guggero on the lightning labs slack and he says that's not the case. A manual close is required to return the funds back.
I've done reinstalls (after manualing deleting the lit group) and even reinstalled the OS again. Still showing no auth, no accounts, etc..  Confirmed ls -la /home/lit/.pool is where my data is.
I only started using Pool with the last version, I would not have done anything manual or experimental. At this point I consider my data a goner and trying to go through recovery mechanisms but still can't recover funds with pool.

@AnthonyRonning
Is ls -la /home/lit/.pool not a symlink?
Did you overwrite your SDcard on update? Did you happen to have the old one?

It is
lit@raspberrypi:~ $ ls -la /home/lit/.pool
lrwxrwxrwx 1 root root 24 May  3 20:34 /home/lit/.pool -> /mnt/hdd/app-data/.pool/

I have files there, but at this point not sure if it was the original files or the new ones.
lit@raspberrypi:/mnt/hdd/app-data/.pool/mainnet $ ls
macaroons.db  pool.db  pool.macaroon

I had my old SDcard until I overwrote it with my 2nd installation attempt today.

So the old data is there.
There was no command in the scripts which could have deleted it.
Can you check when the pool.db was last modified (ls -la /mnt/hdd/app-data/.pool/mainnet/pool.db )?
What does:
lit-pool getinfo
show?
(The SDcard was unlikely having anything since the data was symlinked from the disk in v1.6.3 as well).

Showed that it was last modified today. I'm pretty much I moved that folder to a backup folder today during reinstalls but not sure if I moved the right folder or a symlink tbh.
I was able to recover my funds though. There is a bug in the poold version that is included in lit where it wouldn't allow recovery due to an LSAT bug, AFAIK.
I uninstalled lit, turned on the standalone pool, ran a git fetch & git pull and installed the master copy of pool. Was able to recover funds then.
Thanks for your help! Not sure what happened with me in the first place with accounts not loading in, but at least I'm squared away now.
FYI, I think the lit uninstall issue was from RTL being added as a user to the lit group but not being removed from the group before groupdel runs (thought I caught a glimpse as uninstall ran once).
Unless you want to leave this open for anything, feel free to close. Thanks again!

Thank you @AnthonyRonning it was a good exercise.
Will try to reproduce and fix this uninstall bug before closing this.

Apparently the latest pool master won't work for creating orders, so I had to downgrade pool.
I backed up my pool data (/mnt/hdd/app-data/.pool/mainnet/), uninstalled pool standalone, installed lit, and my lsat and key/cert had been removed. Accounts were missing again.
I put the backed up files back, restarted lit, and was able to have my accounts show up again. Just an FYI. Either my machine is just messed up a bit or these are some reproduction steps you might be able to try.

I'm running into the same issue except I don't have my old SD anymore. I have installed lit on the new SD, tried turning on the old pool but unable to getinfo (I get the poolrpc.Trader error). pool listauth does not show any LSAT.
@AnthonyRonning how did you install the master version of pool? You just ran make install?

I also had that error, I think it was related to incompatible macaroons with the new version.
Move your pool dir first (/mnt/hdd/app-data/.pool/) to have as a backup just in case. You should then, for safe measures, uninstall lit and reinstall pool, hopefully you get a good macaroon again and can at least getinfo.
After installing pool again, go to the pool directory (I think it's /home/pool/pool) and do a git pull. Afterwards, run this line
https://github.com/rootzoll/raspiblitz/blob/v1.7/home.admin/config.scripts/bonus.pool.sh#L207
Afterwards:
pool

pool accounts recover

It should hopefully find your account. If that's true, you can either close out your account if it's expired, or keep the account open.
If you want to keep the account open and create orders from it, you'll need to downgrade again.  Hopefully that works for you, this is pretty much the entire process I went through and was able to recover my funds and use the integrated lit.

Unfortunately, I'm unable to successfully call getinfo. I threw out a question in Slack about recovering a pool account, and he said this (posting for others):

I think I lost my pool data. I still have my lightning node running with the same public key as before though. If I pay for a new LSAT (I’m assuming this was lost), can I recover my pool account?

Guggero replied:

yes, but because of an LSAT related problem that was fixed recently, you need to build and compile the master branch of Pool from source for the account recovery. And then you need to downgrade again to the latest tagged version (v0.4.4-alpha) because we first need to deploy something on the server for you to be able to submit orders with the master version. a bit tricky, sorry. we're blocked on tagging a new version by a feature that's still in development

I can't find a file lsat.token anywhere, so it looks like I have to get a new LSAT token and begin account recovery.

I think I found the bug.
If the user has used the standalone Pool before it is installed after LiT during the recovery process when changing the SDcard.
Check for the owner of the lsat.token with:
ls -la /mnt/hdd/app-data/.pool/mainnet/lsat.token
it should be:
-rw-r--r-- 1 lit lit 57 May  5 09:34 /mnt/hdd/app-data/.pool/mainnet/lsat.token

if it is:
-rw-r--r-- 1 pool pool 57 May  5 09:34 /mnt/hdd/app-data/.pool/mainnet/lsat.token

the standalone Pool is running in the background too.
Fix with running the commands:
# remove the standalone Pool
config.scripts/bonus.pool.sh off
# fix the lsat token permission
sudo chown lit:lit -R /mnt/hdd/app-data/.pool
# restart LiT
sudo systemctl restart litd

PR #2276 wil fix this for v1.7.1.

I found the bigger issue also.
Unfortunately https://github.com/rootzoll/raspiblitz/pull/1957 introduced the command which deletes the Pool data when running:
config.scripts/bonus.pool.sh off
This results in the Pool data being deleted when installing LiT while the standalone Pool is installed.
Fixing this as well in #2276
@rootzoll could this be a trigger for v1.7.1 release soon?

In case the problem already happened (Pool data missing) got a general LSAT token from guggero which can be downloaded from:
https://oms.keybase.pub/lsat.token

if you want, you can give this token to anyone who has that problem. they should only use it for recovering/closing their account though and then start afresh (remove the token and create a new account)
that way people don't need to update to master to get a new token.

The procedure for people with the problem would be:

Place the token into /mnt/hdd/app-data/.pool/mainnet/lsat.token

# make sure the directory exists and owned by lit
sudo -u lit mkdir -p /mnt/hdd/app-data/.pool/mainnet/
sudo chown lit:lit -R /mnt/hdd/app-data/.pool
# download the token
sudo -u lit wget -O /mnt/hdd/app-data/.pool/mainnet/lsat.token https://oms.keybase.pub/lsat.token

Start LiT, then use lit-pool accounts recover

sudo systemctl restart litd
lit
lit-pool accounts recover

Check account is back with:

lit-pool accounts list --show_archived

If you have a Pool account and not installed LiT yet get rid of the problematic line with:
sed -i 's#sudo rm -r /mnt/hdd/app-data/.pool##' /home/admin/config.scripts/bonus.pool.sh

Thanks @openoms! Your instructions worked perfectly for me.

@openoms is anything to take care on this still for v1.7.1?

Fixed and tested, can be closed.


The built visit 3_2_1 reads the file error

Describe the bug
Hi, I would like to use the parallel version visit to read the simulation results of amrex. When I use the released ubuntu 20 visit 3.2.1, the file can be read normally. But when using the visit built by the build_visit script, an error occurred when reading the file.
VisIt could not read from the file "../plt00000/Header".

The generated error message was:

There was an error opening ..//plt00000/Header. It may be an invalid file.
VisIt tried using the following file format readers to open the file: <No suitable plugins were identified>

In addition, I tried to open the *.vtk file with the built version, the vtk file can be opened correctly.
Attachments
The format of the header file that needs to be read is as follows
HyperCLaw-V1.1
15
density
Temp
...

My build command is ./build_visit --mpich
Desktop

OS and version: Ubuntu 20.04
VisIt Version: 3.2.1
Server info (if applicable):

Additional context
Whether it is missing the necessary commands in the build?

Hmmm...the <No suitable plugins were identified> is a part of the problem. VisIt hasn't even attempted to open and read the header file yet because it doesn't think there is a plugin that supports it.
I can't recall but a long time ago, AMReX produced Boxlib files that VisIt read. More recently, I think it is capable of producing some other formats like maybe Conduit/Blueprint or another variant of HDF5. Do you happen to
Can you try doing an Open as... and explicitly selecting the Boxlib3D (3D for 3D data or 2D for 2D data) for the format?

Hmmm...the <No suitable plugins were identified> is a part of the problem. VisIt hasn't even attempted to open and read the header file yet because it doesn't think there is a plugin that supports it.
I can't recall but a long time ago, AMReX produced Boxlib files that VisIt read. More recently, I think it is capable of producing some other formats like maybe Conduit/Blueprint or another variant of HDF5.
Can you try doing an Open as... and explicitly selecting the Boxlib3D (3D for 3D data or 2D for 2D data) for the format?

Thank you very much! I can open it after  selecting Boxlib 2d/3d format !


Enable nested spire use case

This patch enables the nested spire use case:
https://spiffe.io/docs/latest/architecture/nested/readme/
You can have a root spire server external to Kubernetes that is the base spiffe ca.
Then each of your kubernetes clusters can run an instance of this chart bound to the root server and all will be trusted.

Closing here for now... keeping it open here:
https://github.com/kfox1111/spiffe-helm-charts/pull/2


[flatbuffers] Update to 2.0.8

Describe the pull request

updates version to 2.0.8.

removes patch no-werror: -Werror isn't set by default anymore

removes patch  ignore_use_of_cmake_toolchain_file: Seems not needed anymore

Does your PR follow the maintainer guide?

Yes

@JulZimmermann , Thanks for your pr, please get failure logs here. Please ping me if you need any help.

Looks like this is caused by https://github.com/google/flatbuffers/issues/7499 and fixed with https://github.com/google/flatbuffers/pull/7502.
The fix isn't included in the 2.0.8 release. I created a patch with the changes from https://github.com/google/flatbuffers/pull/7502.

@JulZimmermann
Please get failure logs here. Please ping me if you need any help.

@JulZimmermann , ping for response.

@JulZimmermann
Convert this PR to draft since there is no progress. Please ping us if this PR is ready for review again.

Closing this PR since it seems that no progress is being made. Please ping us to reopen if work is still being done.


message_feed: Improve tooltip on edited/moved notice.

This PR modifies the default tooltip to a tippy one by removing the title attribute from the element and inserting the string text in aria-label attribute.
It uses the aria-label attribute to get the last_edit_timestr for the tooltip which is modified to follow the rules(english).
The tippy tooltip fetches the html content from a new message_edit_notice_tooltip template.
It also adds a second line to the tooltip: "Click to view edit history".
Currently on disabling the View edit history feature, the edited/moved notice gets hidden, so the idea of hiding the second line and showing only the first would not work in current scenario.

Fixes: #23075

Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Thanks! Please leave a comment when you've had a chance to go through the PR checklist, and I'll take a look.

Hi, I've gone through the checklist and also updated the PR description.

Looks good to me in manual testing! @sayamsamal could you please review this PR?

Oh, and this wasn't in the issue description, but I think we should italicize the second line, to match the styling we're implementing here.

I've made the requested change and updated the screenshot.

Sure @alya, I'll review this PR.

@somesh202 Good job on the PR. I have left you some reviews that need fixing. Everything else looks good to me, thanks for the PR!

FYI @alya, as mentioned by @somesh202, we do not display any text like "EDITED" or "MOVED" and also remove any such option from the message actions dropdown, when the organisation turns off message edit history, So hiding the Second Line won't provide us with any visual changes.

So hiding the Second Line won't provide us with any visual changes.

Ah, got it -- no need to make changes there, in that case.

@somesh202 I see you pushed an updated version; can you explain how you addressed the review feedback? Replying to each review comment, plus adding a main comment with updated screenshots is usually the best practice.

@timabbott Sorry for the late response, I've addressed the feedback and implemented the changes suggested by @sayamsamal and you, the UI for tooltip remains same . One issue still remains, i.e. the message edit notice is not removed until we refresh the page after changing the edit history settings, I'll try working this out too.

Closing as the original issue was fixed in https://github.com/zulip/zulip/pull/25883.


[tcat] Implement tcat advertisement.

Commit introduces implementation of TCAT advertisement over BLE compialnt with Thread 1.3.1 specification.

@EskoDijk @arnulfrupp FYI

@EskoDijk @arnulfrupp any more comments from Your site?

@EskoDijk @arnulfrupp any more comments from Your site?

@canisLupus1313 Not for now - maybe I can propose further changes (if needed) in a later PR or issue. It's easier to see what's needed after some test runs (either in simulation or on the testbed).

@EskoDijk @arnulfrupp any more comments from Your site?

@canisLupus1313 Not for now - maybe I can propose further changes (if needed) in a later PR or issue. It's easier to see what's needed after some test runs (either in simulation or on the testbed).

@EskoDijk
Can I count on +1 from you then?

@jwhui @abtink Looks like this PR has already positive review. Can we merge it?


[MM-47623] Upgrade katex dependency to 0.16.3

Summary

This PR upgrades katex from v0.13.11 to v0.16.3. Despite the fact that in terms of semantic versioning this is a minor upgrade, apart from bugfixes, there are a few features introduced, so this needs to be thoroughly tested on QA review step (creating latex content, copy-pasting, etc).

From version
To version
Changelog
Notes

0.13.11
0.16.3
First 3 pages of releases
Apart from most of the releases that are bugfixes, the most relevant releases are: 0.16.0 -> changing behaviour of copy-paste. In our case copying the equations doesn't work the way described (ie copying the rendered formula is not pasting latex currently). Testing locally, the same behaviour is maintained.  The other change is relevant to 0.15.0 and the relax which despite the fact it's mentioned as breaking change, it is actually a fix

I have tested locally with latex and latex inline enabled and the behaviour is the same as before.
Ticket Link

https://mattermost.atlassian.net/browse/MM-47623
Release Note

NONE

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/254115

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/254767

E2E report - no PR related failures.

@m1lt0n
Latex is not rendering on the test server. See Town Square posts.

Hey @jgilliam17 I've pushed a couple of lines that fix the issue (for some reason while building this, it worked properly in my local, but today I confirm I reproduced the issue locally too). I've asked from the initial reviewers to take a look at the couple of lines I've added, feel free to test on a new test server, but reassign to me if everything works properly instead of merging.

/e2e-test

Thanks @m1lt0n
Tested, looks good now
E2E report doesn't show any PR related failures.


Cisco Email Threat Defense Connector - Updated offerID

Change(s):
Updated the offerID under SolutionsMetadata.json
Reason for Change(s):
offerId mismatch
Version Updated:
no
Testing Completed:
Yes. Manually deployed and tested.
Checked that the validations are passing and have addressed any issues that are present:
Yes

Hi @sahana-bannigol-cisco , can you please repackage the solution or update the solution Id in mainTemplate and solution zip?

Hi @sahana-bannigol-cisco , can you please repackage the solution or update the solution Id in mainTemplate and solution zip?

Hi, I have updated the solutionId

@sahana-bannigol-cisco please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Cisco Systems"


Update README.md

Signed-off-by: alabulei1<EMAIL_ADDRESS>

This PR's title doesn't match our requirement.
Please make sure your title includes the corresponding Jira id.
@alabulei1, please update it.


tools/minudumpserver: support auto parse log file feature

Summary
support to extract log and list all possible dumps from a full log file
now user can parse a full log but not only the specific part of the full log.
if user pass a full log contains multi crash logs, they will get a tui like this:
0: [12/31 00:01:36] [50] [xp] up_dump_register: R0: 3c23a4e0 R1: 000
1: [12/31 00:01:36] [50] [xp] up_dump_register: R0: 000000e0 R1: 000
Dump number[0]:

input the index for what to parse and debug.
if there is only one available crash log in the full log, it will start the process straightly.
Impact
Testing

@W-Mai please fix lint error

@W-Mai please fix lint error

done


A few additional IAM permissions needed for cfncluster deployer policy

Suggested Fix for:
https://cfncluster.readthedocs.io/en/latest/iam.html
... this section in the policy for deploy user:

        "Sid": "IAMModify",
        "Action": [
            "iam:PassRole",
            "iam:CreateRole",
            "iam:DeleteRole"
        ],
        "Effect": "Allow",
        "Resource": "arn:aws:iam::<AWS ACCOUNT ID>:role/<CFNCLUSTER EC2 ROLE NAME>"

Looks like the IAM set for the deployer user needs "iam:GetRole" in order to prevent this error on cluster creation:

Beginning cluster creation for cluster: XXX-use1-prod-liggghts-hpc
Config sanity error: User: arn:aws:iam::XXX:user/svc_use1_rdapps_prod_cfncluster-deployer is not authorized to perform: iam:GetRole on resource: role cfnclusterRole

And it also looks like it's missing "iam:SimulatePrincipalPolicy" as well as I see this error:

Config sanity error: User: arn:aws:iam::XXX:user/svc_use1_rdapps_prod_cfncluster-deployer is not authorized to perform: iam:SimulatePrincipalPolicy on resource: arn:aws:iam::XXX:role/cfnclusterRole

Suggested replacement text for IAMModify:

        "Sid": "IAMModify",
        "Action": [
            "iam:PassRole",
            "iam:CreateRole",
            "iam:DeleteRole",
            "iam:GetRole",
            "iam:SimulatePrincipalPolicy"
        ],
        "Effect": "Allow",
        "Resource": "arn:aws:iam::<AWS ACCOUNT ID>:role/<CFNCLUSTER EC2 ROLE NAME>"

And finally I could not get past this sanity check error

IAM role error on user provided role cfnclusterRole: action sqs:SendMessage is implicitDeny
See https://cfncluster.readthedocs.io/en/latest/iam.html

The IAM policy clearly allows sqs:SendMessage -- is there a chance that this particular sanity check test has a bug?  My policy looks like this now and there are no other SQS stanzas that should be inserting an implicit deny:

        "Sid": "SQSAllow",
        "Action": [
            "sqs:CreateQueue",
            "sqs:SetQueueAttributes",
            "sqs:DeleteQueue",
            "sqs:SendMessage",
            "sqs:GetQueueAttributes"
        ],
        "Effect": "Allow",
        "Resource": "*"

Hi,
about the two missing policy, they are already included in the PR https://github.com/awslabs/cfncluster/pull/475, as a follow up of your ticket https://github.com/awslabs/cfncluster/issues/473.
About the "sqs:SendMessage" I think you are confusing the "CfnClusterInstancePolicy" with the "CfnClusterUserPolicy".
The "CfnClusterInstancePolicy is the policy associated to the EC2 instances through a custom role that could be configured via the config option "ec2_iam_role", see https://cfncluster.readthedocs.io/en/latest/configuration.html?highlight=ec2_iam_role. The sanity check will check if the custom configured policy is compliant to (only the relevant portion reported)
[...]
        {
            "Resource": [
                "arn:aws:sqs:<REGION>:<AWS ACCOUNT ID>:cfncluster-*"
            ],
            "Action": [
                "sqs:SendMessage",
                "sqs:ReceiveMessage",
                "sqs:ChangeMessageVisibility",
                "sqs:DeleteMessage",
                "sqs:GetQueueUrl"
            ],
            "Sid": "SQSQueue",
            "Effect": "Allow"
        },
[...]

Instead the "CfnClusterUserPolicy" is the policy associated to the user who want to create the cluster. There is no sanity check for this policy at the moment  (only the relevant portion reported)
[...]
        {
            "Sid": "SQSModify",
            "Action": [
                "sqs:CreateQueue",
                "sqs:SetQueueAttributes",
                "sqs:DeleteQueue"
            ],
            "Effect": "Allow",
            "Resource": "*"
        },
[...]

As you see the "sqs:SendMessage" should be present into the "CfnClusterInstancePolicy" and it is not necessary into the "CfnClusterUserPolicy", in which I suppose you are adding it.
L

Thanks Luca!
I saw that error when deploying and thought it was IAM permission related on the deploy user but I just found the config_sanity.py script and it's pretty clear that sanity check is looking at the EC2 role:

if resource_type == 'EC2IAMRoleName':

    try:
        iam = boto3.client('iam', region_name=region,
                            aws_access_key_id=aws_access_key_id,
                            aws_secret_access_key=aws_secret_access_key)

        arn = iam.get_role(RoleName=resource_value).get('Role').get('Arn')
        accountid = boto3.client('sts').get_caller_identity().get('Account')

        iam_policy = [(['ec2:DescribeVolumes', 'ec2:AttachVolume', 'ec2:DescribeInstanceAttribute', 'ec2:DescribeInstanceStatus', 'ec2:DescribeInstances'], "*"),
                    (['dynamodb:ListTables'], "*"),
                    (['sqs:SendMessage', 'sqs:ReceiveMessage', 'sqs:ChangeMessageVisibility', 'sqs:DeleteMessage', 'sqs:GetQueueUrl'], "arn:aws:sqs:%s:%s:cfncluster-*" % (region, accountid)),
                    (['autoscaling:DescribeAutoScalingGroups', 'autoscaling:TerminateInstanceInAutoScalingGroup', 'autoscaling:SetDesiredCapacity'], "*"),
                    (['cloudwatch:PutMetricData'], "*"),
                    (['dynamodb:PutItem', 'dynamodb:Query', 'dynamodb:GetItem', 'dynamodb:DeleteItem', 'dynamodb:DescribeTable'], "arn:aws:dynamodb:%s:%s:table/cfncluster-*" % (region, accountid)),
                    (['sqs:ListQueues'], "*"),
                    (['logs:*'], "arn:aws:logs:*:*:*")]

Sorry for wasting your time :)

No prob at all,
glad that you solved.
L


Bind the internal and reflection Kotlin APIs

Bind the internal and reflection Kotlin APIs

they cause issues in other bindings if they are missing
add bindings for the full Kotlin reflection

The #717 needs to be merged first as this requires the Xamarin.Kotlin.BindingSupport NuGet to be published.

/azp run


Change handling on strings that cause too many matches.

Hello,
At the moment sometimes when scanning large files its possible for even relatively sensible rules to cause an error of the format:
"error scanning foo blah in rule bar causes too many matches"
The current behaviour when this happens is to stop scanning the file (afaik, based on testing with @wxsBSD ), but in this issue i would like to request a change so that instead it continues scanning the file. The requirements to make this work are:

Create a "max count" for each string, where each string can only match that # of times (I am unsure on what a sensible value for this is, but it should be based on whatever number currently causes this error to occur)
When this max count is reached for a given string, YARA should stop recording offsets // matches and should print a warning message "Warning maximum string count for string X matched in rule Y - rule Y may no longer work as intended"

The reason for this request is that although it doesnt occur often for regular files, when scanning large files it's possible for a variety of reasons that strings that are sensible on smaller files will cause errors, meaning users have to edit their rules file and rescan (which depending on the volume of data being scanned may be undesirable).
I also think that its not obvious to users with the current error message that the error will cause no rules to match the file, so as a minimum the error message could be modified to be more explicit.
Thanks,
Tom

Makes a lot of sense.

I’ll see if I can get a patch for this out in the coming week.

I've put up a PR for this so we can have discussion over there. Once we settle on the implementation I'll be sure to adjust the docs accordingly (if necessary).


Colab - ValueError: The parameter loc has invalid values

Hey Guys,
Nice Library! I get an error running the default FinRL_ensemble_stock_trading_ICAIF_2020.ipynb file in colab.
When running this code in Part 6, it results in this error:

It seems to be related to the timesteps_dict argument.
Only thing I changed in the file was updating this line when importing packages:
from finrl.trade.backtest import backtest_stats, backtest_plot, get_daily_return, get_baseline
Any thoughts, I can't find the cause?
Mark

Have you solve this problem? I meet the same error and have no idea about this

I had the same error and I believe it is because of missing data in the training set after transformation. I havent looked into it too closely whether there is actually missing data in the underlying data or if there are problems with the preprocessing component but if you adjust the training start date to 2015 for e.g. it will resolve the issue

Hey Sam,
Good catch, this indeed is causing the error. Updating:
train_start = '2015-01-01'
fixed it. If I find more info about the underlying missing data, I will update.
Thanks a lot!

Please check whether there is missing values in the data.

I tried the start date of 2013-01-01, and it runs as well.  2012-01-01 does not work.

Check data. I have the same problem before, and I found -inf in my data set.

I got the same error in validation date from 2019 and also I checked and there is not any missed value


configurator: optimize ConfigMap informer filtering

Description:
This change makes use of the filtering capability in informers
to filter API responses on the server side, by using a FieldSelector
to filter on the name of the ConfigMap as opposed to filtering all
objects on the client (osm-controller) side. The informer is already
namespaced, so the namespace and name should be enough to accurately
only have OSM's ConfigMap in the informer cache and events.
This change will also reduce the number of ConfigMap related events
the controller will receive when there are additional ConfigMaps in
the controller's namespace (ex. Grafana's ConfigMap when Grafana is
deployed as a part of control plane), and thus improving performance
in such scenarios. The informer resyncs are on a per resource basis,
so unnecessary events can take up processing resources.

Affected area:

New Functionality      [ ]
Documentation          [ ]
Install                [ ]
Control Plane          [X]
CLI Tool               [ ]
Certificate Management [ ]
Networking             [ ]
Metrics                [ ]
SMI Policy             [ ]
Security               [ ]
Tests                  [ ]
CI System              [ ]
Performance            [X]
Other                  [ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
No

Codecov Report

Merging #2000 into main will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2000   +/-   ##
=======================================
  Coverage   56.56%   56.56%
=======================================
  Files         141      141
  Lines        5677     5677
=======================================
  Hits         3211     3211
  Misses       2463     2463
  Partials        3        3

Impacted Files
Coverage Δ

pkg/configurator/client.go
89.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49a8099...16a5e80. Read the comment docs.


deterministic tie-breaking between categories.

CatBallotBox and its Tally() is here modified to use a slice rather than a map.
This avoids Go's non-deterministic map range, which made tie-breaking
between categories somewhat random, with the result that repeated
evaluations of the same tree could produce different predictions and
thus different error rates.
Test wise, lytics' fork has TestIris in data_test.go
using tree Copy()-ing that will sporadically fail without this fix.

I reported this Tim Kaye at Lytics (@timekaye11) over email, and he developed a slightly different fix at the same time --
https://github.com/lytics/CloudForest/pull/18
I think mine may be simpler (no sorting), but his may be preferred if the category numbering is not sequential.  I'm not familiar enough yet with the code to know for sure if categories are numbered non-sequentially, but the one place I saw them assigned it appeared that they were. Tim, thank you so much for the work, and I'm happy to hear if you think your approach has advantages.


Improvement: Couple Window position setting to method context

Window should have independent positioning settings for each method ID.  It might be better to set up reasonable defaults based on the position of other windows.

Because of the ZO GUI layout, I don't think this is necessary.  There is a position roughly in the middle which works for all three.  I will submit a different change for window visibility being tied to specific contexts.


Migration to Readium Kotlin toolkit v2.2.1

Please refer below ticket for reference regarding issues during migration.
https://github.com/readium/kotlin-toolkit/issues/321 - Reference Ticket
We have referred the migration guide and the sample test app. We are doing everything same as per testapp except the bookId part.
How can we open the ebook without using the bookId. What else can be used in the absence of bookId? We have following data with us. Which Activity in the readium toolkit will accept this data in order to open ebook. Please refer below Intent data available with us which is working in older version of the SDK. This is a blocker for us while updating SDK. Kindly help
putPublication(publication)
putExtra("baseUrl", baseUrl.toString())
putExtra("publicationPath", asset.file.absolutePath)
putExtra("publicationFileName", asset.name)
putExtra(Constants.ISBN, isbn)

Duplicates of https://github.com/readium/kotlin-toolkit/issues/321


[Release] Re-spin FST with signed artifact

#no-changelog

 Downloads
‣ diff -r /Users/nickcooke/Downloads/FirebaseFirestoreInternal.xcframework  /Users/nickcooke/Downloads/FirebaseFirestoreInternal_old.xcframework
Only in /Users/nickcooke/Downloads/FirebaseFirestoreInternal.xcframework: _CodeSignature

I don't think there is an issue but making a note here...
This is the build log that seems to confirm it is picking up a signature. Unfortunately, I cannot double click into the "Show Signature Information" part. Xcode 15.3 RC doesn't do anything when you double click that.

But, I manually dragged in the xcframework and you can see the signature pick up:

Pointing to this branch, I built my test app for iOS and also for macOS. Both archives validated successfully. This is gtg on green.

@paulb777, despite the failing CI,  think this can still merge. WDYT? I've never seen these failures before but they are mainly FirebasweFunctions integration tests.

SGTM - I would think any signing issues would show up at build time - not runtime.

I'll merge and retag now.


Return ServerNotInitialized according to the spec

According to the spec we should return ServerNotInitialized if the server is waiting for an initialize request and something else comes in.
Upgrading to lsp-server 0.5.1 will do this and retry until the initialize request comes in.
Fixes #8581

bors r+


chore: skips teardown for secure-cloud-func-internal-server

@apeabody Could you please update this PR?

@g-awmalik looking at the changes, this Pull Request is skipping the whole secure-cloud-func-internal-server tests , not only the teardown (destroy) phase .
Is this the original intent ?

@g-awmalik  to skip the teardown phaser of the secure examples wouldn't be enough to comment out this ones:

https://github.com/GoogleCloudPlatform/terraform-google-cloud-functions/blob/main/build/int.cloudbuild.yaml#L72C1-L79C33

https://github.com/GoogleCloudPlatform/terraform-google-cloud-functions/blob/main/build/int.cloudbuild.yaml#L97C1-L104C45

https://github.com/GoogleCloudPlatform/terraform-google-cloud-functions/blob/main/build/int.cloudbuild.yaml#L141C1-L148C38

@g-awmalik looking at the changes, this Pull Request is skipping the whole secure-cloud-func-internal-server tests , not only the teardown (destroy) phase .
Is this the original intent ?

No, definitely not the intent. The teardown was commented out and left stale resources in the project. Was unable to proceed further and I had to comment the entire secure-cloud-func-internal-server to debug the issue.

@g-awmalik - The added retry during the teardown appears to have worked around the issue: https://github.com/GoogleCloudPlatform/terraform-google-cloud-functions/pull/112


[BUG] Intermittent result discrepancy for NDS SF3K query86 on L40S

Describe the bug
NDS SF3K CI pipeline exhibits intermittent query result validation failures for various queries.
It is difficult to reproduce but I was able to reduce  the scenario to running q36 and q86 one after another, which fails 90+% out of the runs. I dropped LIMIT 100 from q86 to reduce chances of nondeterminism.
select
    sum(ws_net_paid) as total_sum
   ,i_category
   ,i_class
   ,grouping(i_category)+grouping(i_class) as lochierarchy
   ,rank() over (
        partition by grouping(i_category)+grouping(i_class),
        case when grouping(i_class) = 0 then i_category end
        order by sum(ws_net_paid) desc) as rank_within_parent
 from
    web_sales
   ,date_dim       d1
   ,item
 where
    d1.d_month_seq between 1205 and 1205+11
 and d1.d_date_sk = ws_sold_date_sk
 and i_item_sk  = ws_item_sk
 group by rollup(i_category,i_class)
 order by
   lochierarchy desc,
   case when lochierarchy = 0 then i_category end,
   rank_within_parent

The diff is large enough but there is a single row in the result and diff with lochierarchy=2 so it is to focus on for tests
-Row(total_sum=Decimal('988350515593.49'), i_category=None, i_class=None, lochierarchy=2, rank_within_parent=1)
+Row(total_sum=Decimal('988314086750.87'), i_category=None, i_class=None, lochierarchy=2, rank_within_parent=1)

This issue seems to be introduced between build 33
Archive:  /home/spark/gshegalov/dist/rapids/rapids-4-spark_2.12-24.12.0-20241101.120509-33.jar
  inflating: spark320/rapids4spark-private-version-info.properties
version=24.12.0-SNAPSHOT
user=root
revision=16a524fd6e1cfdbd8997227682ac638373b698b4
branch=HEAD
date=2024-11-01T07:46:20Z
url=https://gitlab-master.nvidia.com/nvspark/spark-rapids-private.git

  inflating: rapids4spark-version-info.properties
version=24.12.0-SNAPSHOT
cudf_version=24.12.0-SNAPSHOT
user=root
revision=2134f2eb665769c4f57a41104ce475d25a7224ee
branch=HEAD
date=2024-11-01T11:49:48Z
url=https://github.com/NVIDIA/spark-rapids.git

  inflating: cudf-java-version-info.properties
version=24.12.0-SNAPSHOT
user=root
revision=9657c9a5dc4c4a1bf9fd7b55cfeb53c60dda3c66
branch=HEAD
date=2024-11-01T06:27:54Z
url=https://github.com/rapidsai/cudf.git
gpu_architectures=70;75;80;86;90

  inflating: spark-rapids-jni-version-info.properties
version=24.12.0-SNAPSHOT
user=root
revision=86a9e16f555a8189d8bce45ed0bf9ba898585e09
branch=HEAD
date=2024-11-01T06:27:56Z
url=https://github.com/NVIDIA/spark-rapids-jni.git
gpu_architectures=70;75;80;86;90

and build 42
Archive:  /home/spark/gshegalov/dist/rapids/rapids-4-spark_2.12-24.12.0-20241113.144142-42.jar
  inflating: spark320/rapids4spark-private-version-info.properties
version=24.12.0-SNAPSHOT
user=root
revision=2f08e20170b66621d1f14ee0fb351ef5630ea811
branch=HEAD
date=2024-11-13T06:34:20Z
url=https://gitlab-master.nvidia.com/nvspark/spark-rapids-private.git

  inflating: rapids4spark-version-info.properties
version=24.12.0-SNAPSHOT
cudf_version=24.12.0-SNAPSHOT
user=root
revision=862dab0789abb95f860d1d42e06dad4690ca79e2
branch=HEAD
date=2024-11-13T14:24:52Z
url=https://github.com/NVIDIA/spark-rapids.git

  inflating: cudf-java-version-info.properties
version=24.12.0-SNAPSHOT
user=root
revision=487f97c036ae7919e98ddc8bf5412a8002a493c5
branch=HEAD
date=2024-11-13T08:01:08Z
url=https://github.com/rapidsai/cudf.git
gpu_architectures=70;75;80;86;90

  inflating: spark-rapids-jni-version-info.properties
version=24.12.0-SNAPSHOT
user=root
revision=ea47ecb58cab8228a81088b8ac44e3b336a9ba7e
branch=HEAD
date=2024-11-13T08:01:12Z
url=https://github.com/NVIDIA/spark-rapids-jni.git
gpu_architectures=70;75;80;86;90

Given that the runs are not 100% reproducible there is a chance the range is longer. I ran build 33 four times without reproducing the issue. Build 42 reproduces the failure quickly
Steps/Code to reproduce bug
Open the notebook on a single node with L40S https://github.com/gerashegalov/rapids-shell/blob/25ca477172f8ac45b71d0eed3452369299748284/src/jupyter/nds2-parquet-3k-snappy.ipynb
Expected behavior
Results must continue to match. These tests are consistently passing on the same node when configured to use an H100 GPU instead
Environment details (please complete the following information)
+-----------------------------------------------------------------------------------------+
| NVIDIA-SMI 560.35.03              Driver Version: 560.35.03      CUDA Version: 12.6     |
|-----------------------------------------+------------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id          Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |           Memory-Usage | GPU-Util  Compute M. |
|                                         |                        |               MIG M. |
|=========================================+========================+======================|
|   0  NVIDIA L40S                    Off |   00000000:01:00.0 Off |                    0 |
| N/A   47C    P0             88W /  350W |   44863MiB /  46068MiB |      0%   E. Process |
|                                         |                        |                  N/A |
+-----------------------------------------+------------------------+----------------------+

Environment location: [Standalone, YARN, Kubernetes, Cloud(specify cloud provider)]
Spark configuration settings related to the issue

Additional context
Add any other context about the problem here.

Rerun the repro with in two more modifications
disable async pool memory allocator
 .config('spark.rapids.memory.gpu.pool', 'NONE')

the diff still consistently reproduces
added compute sanitizer with the default memcheck
the default check does not catch errors and seems to change concurrency in a way that the issue stops reproducing.

Pursued a conjecture that the issue only reproduces due to forward compatibility because we have no cubin sections for compute capability 89
However,  a targeted compilation for 89 equally reproduced the issue

Running the executors under
compute-sanitizer --tool=initcheck

There are following issue classes:
Uninitialized global memory
========= Uninitialized __global__ memory read of size 4 bytes
=========     at T1 cub::CUB_200500_890_NS::ThreadLoad<int>(T1 *, cub::CUB_200500_890_NS::Int2Type<(int)0>, cub::CUB_200500_890_NS::Int2Type<(int)1>)+0x3b0 in /home/gshegalov/gits/NVIDIA/spark-rapids-jni/target/libcudf/cmake-build/_deps/cccl-src/cub/cub/thread/thread_load.cuh:289
=========     by thread (2,0,0) in block (0,0,0)
=========     Address 0x1940224208
=========     Device Frame:std::iterator_traits<T2>::value_type cub::CUB_200500_890_NS::ThreadLoad<(cub::CUB_200500_890_NS::CacheLoadModifier)0, int *>(T2)+0x3b0 in /home/gshegalov/gits/NVIDIA/spark-rapids-jni/target/libcudf/cmake-build/_deps/cccl-src/cub/cub/thread/thread_load.cuh:354
=========     Device Frame:int cub::CUB_200500_890_NS::CacheModifiedInputIterator<(cub::CUB_200500_890_NS::CacheLoadModifier)0, int, int>::operator []<int>(T1) const+0x3b0 in /home/gshegalov/gits/NVIDIA/spark-rapids-jni/target/libcudf/cmake-build/_deps/cccl-src/cub/cub/iterator/cache_modified_input_iterator.cuh:217
=========     Device Frame:void cub::CUB_200500_890_NS::LoadDirectWarpStriped<int, (int)15, cub::CUB_200500_890_NS::CacheModifiedInputIterator<(cub::CUB_200500_890_NS::CacheLoadModifier)0, int, int>>(int, T3, T1 (&)[T2], int)+0x1e0 in /home/gshegalov/gits/NVIDIA/spark-rapids-jni/target/libcudf/cmake-build/_deps/cccl-src/cub/cub/block/block_load.cuh:521
=========     Device Frame:void cub::CUB_200500_890_NS::LoadDirectWarpStriped<int, int, (int)15, cub::CUB_200500_890_NS::CacheModifiedInputIterator<(cub::CUB_200500_890_NS::CacheLoadModifier)0, int, int>>(int, T4, T1 (&)[T3], int, T2)+0x1e0 in /home/gshegalov/gits/NVIDIA/spark-rapids-jni/target/libcudf/cmake-build/_deps/cccl-src/cub/cub/block/block_load.cuh:574
=========     Device Frame:void cub::CUB_200500_890_NS::BlockLoad<int, (int)128, (int)15, (cub::CUB_200500_890_NS::BlockLoadAlgorithm)4, (int)1, (int)1, (int)0>::LoadInternal<(cub::CUB_200500_890_NS::BlockLoadAlgorithm)4, (int)0>::Load<cub::CUB_200500_890_NS::CacheModifiedInputIterator<(cub::CUB_200500_890_NS::CacheLoadModifier)0, int, int>, int>(T1, int (&)[15], int, T2)+0x1e0 in /home/gshegalov/gits/NVIDIA/spark-rapids-jni/target/libcudf/cmake-build/_deps/cccl-src/cub/cub/block/block_load.cuh:1284
=========     Device Frame:void cub::CUB_200500_890_NS::BlockLoad<int, (int)128, (int)15, (cub::CUB_200500_890_NS::BlockLoadAlgorithm)4, (int)1, (int)1, (int)0>::Load<cub::CUB_200500_890_NS::CacheModifiedInputIterator<(cub::CUB_200500_890_NS::CacheLoadModifier)0, int, int>, int>(T1, int (&)[15], int, T2)+0x1e0 in /home/gshegalov/gits/NVIDIA/spark-rapids-jni/target/libcudf/cmake-build/_deps/cccl-src/cub/cub/block/block_load.cuh:1595
=========     Device Frame:void cub::CUB_200500_890_NS::AgentScan<cub::CUB_200500_890_NS::AgentScanPolicy<(int)128, (int)15, int, (cub::CUB_200500_890_NS::BlockLoadAlgorithm)4, (cub::CUB_200500_890_NS::CacheLoadModifier)0, (cub::CUB_200500_890_NS::BlockStoreAlgorithm)4, (cub::CUB_200500_890_NS::BlockScanAlgorithm)2, cub::CUB_200500_890_NS::MemBoundScaling<(int)128, (int)15, int>, cub::CUB_200500_890_NS::detail::fixed_delay_constructor_t<(unsigned int)350, (unsigned int)450>>, int *, int *, thrust::plus<void>, int, int, int>::ConsumeTile<(bool)1>(int, int, int, cub::CUB_200500_890_NS::ScanTileState<int, (bool)1> &)+0x1e0 in /home/gshegalov/gits/NVIDIA/spark-rapids-jni/target/libcudf/cmake-build/_deps/cccl-src/cub/cub/agent/agent_scan.cuh:344
=========     Device Frame:cub::CUB_200500_890_NS::AgentScan<cub::CUB_200500_890_NS::AgentScanPolicy<(int)128, (int)15, int, (cub::CUB_200500_890_NS::BlockLoadAlgorithm)4, (cub::CUB_200500_890_NS::CacheLoadModifier)0, (cub::CUB_200500_890_NS::BlockStoreAlgorithm)4, (cub::CUB_200500_890_NS::BlockScanAlgorithm)2, cub::CUB_200500_890_NS::MemBoundScaling<(int)128, (int)15, int>, cub::CUB_200500_890_NS::detail::fixed_delay_constructor_t<(unsigned int)350, (unsigned int)450>>, int *, int *, thrust::plus<void>, int, int, int>::ConsumeRange(int, cub::CUB_200500_890_NS::ScanTileState<int, (bool)1> &, int)+0x90 in /home/gshegalov/gits/NVIDIA/spark-rapids-jni/target/libcudf/cmake-build/_deps/cccl-src/cub/cub/agent/agent_scan.cuh:419
=========     Device Frame:void cub::CUB_200500_890_NS::DeviceScanKernel<cub::CUB_200500_890_NS::DeviceScanPolicy<int, thrust::plus<void>>::Policy900, int *, int *, cub::CUB_200500_890_NS::ScanTileState<int, (bool)1>, thrust::plus<void>, cub::CUB_200500_890_NS::detail::InputValue<int, int *>, int, int>(T2, T3, T4, int, T5, T6, T7)+0x70 in /home/gshegalov/gits/NVIDIA/spark-rapids-jni/target/libcudf/cmake-build/_deps/cccl-src/cub/cub/device/dispatch/dispatch_scan.cuh:197
=========     Saved host backtrace up to driver entry point at kernel launch time
=========     Host Frame: [0x29d79f]
=========                in /lib/x86_64-linux-gnu/libcuda.so.1
=========     Host Frame: [0x39b458a]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame: [0x39f41d7]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame: [0xab3f1a]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame: [0x1a7f87b]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame: [0x1a925fb]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame: [0x1aa6b8b]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame:cudf::io::parquet::detail::reader::impl::read_compressed_data() [0x1aa9b60]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame:cudf::io::parquet::detail::reader::impl::setup_next_pass(cudf::io::parquet::detail::reader::impl::read_mode) [0x1a5d5bd]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame:cudf::io::parquet::detail::reader::impl::handle_chunking(cudf::io::parquet::detail::reader::impl::read_mode) [0x1a628ec]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame:cudf::io::parquet::detail::reader::impl::read_chunk() [0x1a2f4a7]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame:cudf::io::parquet::detail::chunked_reader::read_chunk() const [0x1a270bd]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame:cudf::io::chunked_parquet_reader::read_chunk() const [0x18612df]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame:Java_ai_rapids_cudf_ParquetChunkedReader_readChunk [0xb838c7]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame: [0xffffffffe7b7a77e]
```

# Unused memory warnings=========  Unused memory in allocation 0x1940225800 of size 1,536 bytes
=========     Not written 1,004 bytes between offsets 0x4 (0x1940225804) and 0x5ff (0x1940225dff) (inclusive)
=========     65.3646% of allocation were unused.
=========     Saved host backtrace up to driver entry point at allocation time
=========     Host Frame: [0x28d166]
=========                in /lib/x86_64-linux-gnu/libcuda.so.1
=========     Host Frame: [0x39b62ac]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame: [0x39fe8c9]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame:rmm::mr::cuda_async_view_memory_resource::do_allocate(unsigned long, rmm::cuda_stream_view) [0xbe10a3]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame:rmm::mr::limiting_resource_adaptor<rmm::mr::device_memory_resource>::do_allocate(unsigned long, rmm::cuda_stream_view) [0xbdf94d]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame: [0xbd5874]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame: [0xbd6b11]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame: [0xa13450]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame: [0x1a7fdc4]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame: [0x1ab3589]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame: [0x1aa695f]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame:cudf::io::parquet::detail::reader::impl::read_compressed_data() [0x1aa9b60]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame:cudf::io::parquet::detail::reader::impl::setup_next_pass(cudf::io::parquet::detail::reader::impl::read_mode) [0x1a5d5bd]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame:cudf::io::parquet::detail::reader::impl::handle_chunking(cudf::io::parquet::detail::reader::impl::read_mode) [0x1a628ec]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame:cudf::io::parquet::detail::reader::impl::read_chunk() [0x1a2f4a7]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame:cudf::io::parquet::detail::chunked_reader::read_chunk() const [0x1a270bd]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame:cudf::io::chunked_parquet_reader::read_chunk() const [0x18612df]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame:Java_ai_rapids_cudf_ParquetChunkedReader_readChunk [0xb838c7]
=========                in /tmp/cudf8253500082090784182.so
=========     Host Frame: [0x716fd1017de6]
=========                in
```
```


[test] Migrate TableCell test to react-testing-library

[x] I have followed (at least) the PR section of the contributing guide.

Migrated TableCell integration tests to React Testing Library.
Relates to #22911

@nicholas-l Thanks


Add Spider-man 2

button and device texture replacement minus DPAD textures (all platforms use the same arrow textures, and the game stores all inputs in 1 texture, meaning mapping the individual East West North South, and the NS, EW and PAD textures isn't really possible.

Aw man. I just wasted hours figuring out how to do this myself lol. Didn't realize it was already in the project cause I downloaded the latest packaged release


Update event-demographics.md

Updated description to include the sentence:
This metric is applicable to virtual, in-person, and hybrid events.
Signed-off-by: Matt Germonprez<EMAIL_ADDRESS>

@germonprez just for the record, I'm including this PR in the Translations issue with all the minor DEI changes. (I hope that makes sense, let me know if it doesn't!) :D


[Feature request] Add a way to scroll faster within the song select menus

For the ensou song select screen it's possible to move very fast by chaining double taps (which skip 7 boxes at once each), for dan I added the auto scroll while keeping the arrow button pressed in .5.2.1 so I'll consider this resolved for the time being


I'd like to join this project's community

Your public repo
https://github.com/akinorioyama/gov4git-identity-public.git
Your public branch
main
Your email (optional)
No response

Approved

akinorioyama added to community.


add createInputArray method to Join op

When json serialising a Join op, the class in the json is duplicated.  This method needs adding to the Join class to remove this.  an overriding shouldJsonSerialiseAndDeserialise test should be added to JoinTest to confirm this.
@JsonTypeInfo(use = JsonTypeInfo.Id.CLASS, include = JsonTypeInfo.As.EXISTING_PROPERTY, property = "class")
    @Override
    public Object[] createInputArray() {
        return MultiInput.super.createInputArray();
    }

Hi, just taken a look at the code and given a try of writing a test however I don't quite understand what you mean by the class being duplicated. Is this in regards to retaining all the variable values or that the point of the class is the same before/after serialisation?

So when the class is json serialised within the input, if you use an entity for example, the Entity class will show 2 times.

Merged into develop


Added JSON Lint link to check for linting error.

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[x] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[x] This PR does not contain plagiarised content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers
This pull request is regarding this issue:-
Add a link to jsonlint in the quickstart guide #3914

Looks good 👍 Made suggestion to be consistent with our docs

Yeah sure Eddie, I'll make the changes as suggested.

@ChinmayMhatre made a good suggestion 👍 this can come in another PR

Thank you guys @eddiejaoude @ChinmayMhatre  for helping me as am new to Open source .If any more changes are to be done feel free to ping me here .


does not work well in a flex container with the flex wrap property

Hi all, I am facing a problem that drag and drop is not working well.
Prerequisites:

Container flex
Container flex: wrap
The size of dragged elements is different

https://github.com/clauderic/dnd-kit/assets/55402324/370fe1cd-e503-4cad-b3d9-fbd4c77d9a4c
I can kind of understand him needing a foothold to lean on.
but I don't understand how to implement such functionality

Try to use different collision detectors. For example closest center. https://docs.dndkit.com/api-documentation/context-provider/collision-detection-algorithms


Commander can reassing zeus, when made with ace, even if disabled

Speculative is changing check, to add "REASSIGN ZEUS" action, to making sure zeus enabled. So player must be commander AND must be enabled.

Appears fixed in 7ab1514deba49cb8ac074412a0f6e340684995a3


atom-text-editor.Object.defineProperty.get is deprecated.

The contents of atom-text-editor elements are no longer encapsulated
within a shadow DOM boundary. Please, stop using shadowRoot and access
the editor contents directly instead.
atom-text-editor.Object.defineProperty.get (/usr/lib/atom/src/text-editor-element.js:68:18)
Object.open (/home/edar/.atom/packages/color-picker/lib/ColorPicker-view.coffee:319:32)
atom-text-editor.<anonymous> (/home/edar/.atom/packages/color-picker/lib/ColorPicker.coffee:36:29)
CommandRegistry.handleCommandEvent (/usr/lib/atom/src/command-registry.js:259:29)
handleCommandEvent (/usr/lib/atom/src/command-registry.js:3:59)
CommandRegistry.dispatch (/usr/lib/atom/src/command-registry.js:160:19)

Same issue here.

Same here

Same here

same here too.

Yep, same

same

M2

same

same what do

color-picker still works, right, or is it not opening? I'll probably fix this deprecation warning by the end of the week.

Great, yep still works, most package are up to speed now, pressure pressure !! ;)

Still working for me.  You've got time to fix it.  It's 'just' a deprecation warning, not a fatal error.
Thanks for a great tool!

Hi, guys. This should be fixed in v2.2.5.


Request to add school to jetbrains

file (3).zip
this is my school

file (2).zip
sorry this is my school

@bidishaMondal7 rcciit.txt: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@bidishaMondal7 rcciit.txt: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@bidishaMondal7 rcciit.txt: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@bidishaMondal7 I am sorry, I have to close the request without merging. Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with correct information.
Please do not upload file.zip. Please make a comment after you submitted a pull request, and write in the comment what is your school email address pattern, such as<EMAIL_ADDRESS>Thank you for the understanding!


Cannot share link content with quote

This is my code.
Plugin.FacebookClient.Abstractions.FacebookShareLinkContent linkContent = new Plugin.FacebookClient.Abstractions.FacebookShareLinkContent("awesome plugins",new Uri("http://www.github.com/crossgeeks", UriKind.Absolute));
var ret =await  CrossFacebookClient.Current.ShareAsync(linkContent);
i am getting error as
Cannot share link content with quote

Tested on iOS and Android on latest version and is working fine. Please re-open with more details if still not.


More bigger disk for spark

Running out of disk space again... current root volume is 100GB, let's try 500GB (unless there's a reason not to, in which case we can find something in the middle)
ubuntu@ip-10-0-0-237:~$ df -h
Filesystem      Size  Used Avail Use% Mounted on
/dev/xvda1       99G   99G     0 100% /
none            4.0K     0  4.0K   0% /sys/fs/cgroup
udev            241G   12K  241G   1% /dev
tmpfs            49G  388K   49G   1% /run
none            5.0M     0  5.0M   0% /run/lock
none            241G  344K  241G   1% /run/shm
none            100M     0  100M   0% /run/user

this is for /mnt/spark (currently on root volume)

Okay should be fixed? https://github.com/opensyllabus/osp-pipeline/blob/master/deploy/roles/ec2-instance/tasks/main.yml#L29

Raised to 2TB https://github.com/opensyllabus/osp-pipeline/commit/b6ffb55977aecf6b6a197ce7cecb29919acc29dc


docs: create PULL_REQUEST_TEMPLATE.md

Motive
The PR template created
Issue this PR is related
Reffers to Issue: #12
https://github.com/Showrin/nextjs-tailwind-storybook-with-ci-cd/issues/12
Additional Description
comments are added in the PULL_REQUEST_TEMPLATE.md to clear the intention of adding each and every heading

I have edited the file as you suggested
This time I have also added a screenshots section
so as to make it easy for the reviewer to know about the frontend changes

I have edited the file as you suggested
This time I have also added a screenshots section
so as to make it easy for the reviewer to know about the frontend changes

Thanks, @Anirudh3167 for the contribution.


[Android JNI] Render::readPixels get nothing in the buffer

Describe the bug
Get empty pixel buffer in android c++. The recordView i has setup some renderable and light. The recordSwapChain is created by engine->createSwapChain(params->width, params->height, 2). This is the jni code below :
if (renderer->beginFrame(params->recordSwapChain, frameTimeNanos)) {
    renderer->render(params->recordView);
        int size = params->width * params->height * 4;
        auto* captureBuffer = malloc(size);
        memset(captureBuffer, 0, size);

        auto callback = [](void* buffer, size_t size, void*) {
            uint8_t const* rgba = (uint8_t const*)buffer;
            onCaptureResult(rgba, size);
        };

        auto descriptor = PixelBufferDescriptor(captureBuffer, size, PixelDataFormat::RGBA, PixelDataType::UBYTE, 1, 0, 0, 0, callback,
                                                nullptr);
        renderer->readPixels(0, 0, params->width, params->height, std::move(descriptor));
    renderer->endFrame();
}

Expected behavior
read the pixel data succesfully
Screenshots

Additional context
The engine is initialized in jni,  and  this is all.
Device
The problem can be reproduced everytime , so it is not relevant about device

BitmapFactory.decodeByteArray won’t work, Filament returns a raw array of bytes, the result is not encoded. You should use Bitmap.copyFrom instead (or better, use our Java APIs that simplify handling this).

BitmapFactory.decodeByteArray won’t work, Filament returns a raw array of bytes, the result is not encoded. You should use Bitmap.copyFrom instead (or better, use our Java APIs that simplify handling this).

ok, i will try, thanks


Debugging format in CI

Current random CI failures (#6062) are very cryptic. I think enabling the --format doc flag might give some clues?

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[ ] Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

Funny, only 8 checks appear in this PR. I think this is because I enabled CircleCI in my fork to run some experiments, and tripped CircleCI up? :sweat_smile:

This is pretty much a WIP, so I'll close it until I have something better!

Since I started using the documentation format in my fork, I saw tests being killed in the same spec twice

That is very interesting…
Perhaps we could skip that one spec when running JRuby?

The problem with jruby seems like a too much memory issue. Spawing jruby subprocesses from jruby seems quite expensive currently in this regard. This comment exactly matches the failures and the reason, but in our case, tweaking memory limits is not enough.
I actually think I managed to consistently managed to fix this in my fork by turning the .travis.rb script into a shell script, since it reduces one level of subshelling everywhere. Since .travis.rb basically just shells out different processes, the resulting script is simpler IMO. You can see the WIP here. I enabled hourly builds of that branch in my fork for a couple of days, and it was consistently green except for a couple of failures that seem not memory related, but a bug in  bundler, I'd say.

So, let me just get this straight: .travis.yml and .circleci/config.yml call ruby .travis.rb, which will start a java process. From .travis.rb, we will three times in a row call ruby or bundle exec rake, that all start a 2nd java process. And from the process that runs rspec, we will eventually start a 3rd java process, sometimes (now unsurprisingly) causing CircleCI to run out of memory.

Yup.

I think it should be possible to run all that needs running in just one process instead of three.

I'd say let's start reducing one level the subprocess nesting and then further improve on that if it turns out to be necessary?

I actually think I managed to consistently fix this in my fork by turning the .travis.rb script into a shell script, since it reduces one level of subshelling everywhere.

Got it. Do you have that code shared anywhere?

Yep, I pointed to it in this comment, it's the branch called debug_ci_fork in my fork. Sorry it's a mix of unrelated changes, I'll clean that up when I compile the resulting PRs of all this work.

I found it: https://github.com/rubocop-hq/rubocop/compare/master...deivid-rodriguez:debug_ci_fork
Looking forward to seeing the pull request 😄

I found it: master...deivid-rodriguez:debug_ci_fork

I like how clear github renders diff links by default, I'll start just directly dropping the link in my comments :smile:

Looking forward to seeing the pull request :smile:

I'll open a few ones so they are focused and easier to review! :+1:

By the way, regarding if [ -z "$JRUBY_OPTS" ] you should look at https://circleci.com/docs/2.0/env-vars/#setting-an-environment-variable-in-a-container 🎉

Not sure what you mean... :sweat_smile:

Sorry :-) I just meant that with CircleCI config ENV variables can be configures per job, or per container. We can use this to set JRUBY_OPTS only on the JRuby jobs, and TEST_QUEUE_WORKERS on all jobs with a minimum of duplication. E.g. (with jruby_env being the important change):
steps: &steps
  steps:
    - checkout
    - run: bundle install
    - run: bash .travis.sh

jruby_env: &jruby_env
  # By default we have 2 CPUs and 4GB ram available
  # https://circleci.com/docs/2.0/configuration-reference/#resource_class
  JRUBY_OPTS: "--debug -J-Xmn1024m -J-Xms2048m -J-Xmx2048m"

common_env: &common_env
  # CircleCI container has two cores, but Ruby can see 32 cores. So we
  # configure test-queue.
  # See https://github.com/tmm1/test-queue#environment-variables
  TEST_QUEUE_WORKERS: 2

rubocop_env: &rubocop_env
  environment:
    TASK: "internal_investigation"
    <<: *common_env

jobs:
  # ...

  jruby-9.2-rubocop:
    docker:
      - image: circleci/jruby:9.2
        environment:
          <<: *jruby_env
    <<: *rubocop_env
    <<: *steps

Oh, yeah, sure, I was planning to open a PR with that change too! :)

I like your specific proposal a lot, can you PR it @bquorning?

#6225


 Then you can just save and push your commit again.

Will reopen.


img du requires runc binary?

img: v0.5.4
from https://github.com/genuinetools/img/releases/download/v0.5.4/img-linux-amd64
# img du -d
DEBU[0000] using backend: native
creating worker opt failed: failed to find runc binary

Is it a bug or it really needs it?

img du should not require runc, but why do you need to run img du when you don't have runc and hence you don't have any successful build?

@AkihiroSuda I actually do have a successful build. It doesn't require a runc binary for img build. Or maybe I misunderstand what you call a build?
# img ls
NAME				SIZE		CREATED AT	UPDATED AT	DIGEST
docker.io/grayhemp/build:master	20.88MiB	7 minutes ago	7 minutes ago	sha256:902f3c1cefb626675fb754f26580ab83d45c51c95989971a41cad1ac55e56f4b
# img du
creating worker opt failed: failed to find runc binary

Ah, I forgot now runc is embedded to into img binary

@jessfraz this bug hasn't been fixed yet even in the last version
# img version
img:
 version     : v0.5.6
 git hash    : d08b525
 go version  : go1.11.4
 go compiler : gc
 platform    : linux/amd64
# img du
creating worker opt failed: failed to find runc binary

It’s on master only
On Fri, Jan 4, 2019 at 00:34 Sergey Konoplev<EMAIL_ADDRESS>wrote:

@jessfraz https://github.com/jessfraz this bug hasn't been fixed yet
even in the last version
img version
img:
version     : v0.5.6
git hash    : d08b525
go version  : go1.11.4
go compiler : gc
platform    : linux/amd64
img du
creating worker opt failed: failed to find runc binary
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/genuinetools/img/issues/204#issuecomment-451357127,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYNbA1KzMLr77bMWSDo2O65TfebkHi9ks5u_uf9gaJpZM4ZiUPp
.

--
Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC  511E 18F3 685C 0022 BFF3
pgp.mit.edu http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3

Ah, sorry


Graceful shutdown in node

📚 Context
Assuming the node is deployed to a cloud environment, the orchestrator (e.g., Kubernetes) will eventually need to shut down a service. This shutdown usually comes as a system termination signal. For more details, see https://cloud.google.com/blog/products/containers-kubernetes/kubernetes-best-practices-terminating-with-grace
✔ Solution
Some services already handle the termination signal properly. In this issue, we need to verify which services need to be improved and implement these modifications.
Actix-web already supports graceful shutdown, so we should check it out. More information here: https://actix.rs/docs/server/#graceful-shutdown

This will be addressed in https://github.com/cartesi/rollups-node/issues/101


[dataset] how to inplement a simpler kinds of tokenizer: simple_space_split

Background

here in mindspore, there is text part in dataset for doing data_augmentation in some nlp task
in this process, we need some tokenizer to deal with origin text data, firstly tokenizer is needed

Introduction

To better support all kinds of tokenizer, we might can implement it in py_transform

For instruction, py_transform can be consider as a wraped python function, and easy to call in map function of dataset

Currenly in dataset, here support several kinds tokenizer like jiebaTokenizer and unicode tokenizer etal,  and we can refer some use case of these to know how to use that.

unicodeTokenizer: https://github.com/mindspore-ai/mindspore/blob/master/tests/ut/python/dataset/test_tokenizer.py
jiebatokenizer: https://github.com/mindspore-ai/mindspore/blob/master/tests/ut/python/dataset/test_nlp_jieop.py

so how to develop a simple_space_split  tokenizer in py_transform

its basic way, may like in pytorch :

https://pytorch.org/text/data_functional.html#simple-space-split
https://pytorch.org/text/_modules/torchtext/data/functional.html#simple_space_split

as for how to write a py_transform:

we can refer some already done case, like OneHotOp:
https://github.com/mindspore-ai/mindspore/blob/master/mindspore/dataset/transforms/py_transforms.py

Do you have some implemented way and code ?

(1) You can use PythonTokenizer to achieve this function.
see details in https://gitee.com/mindspore/mindspore/blob/master/mindspore/dataset/text/transforms.py
and here is the test case to use PythonTokenizer: https://gitee.com/mindspore/mindspore/blob/master/tests/ut/python/dataset/test_python_tokenizer.py
(2) You can also use WhitespaceTokenizer to split sentence by whitespace:
def test_whitespace_tokenizer():
    """
    Test WhitespaceTokenizer
    """
    whitespace_strs = [["Welcome", "to", "Beijing!"],
                       ["北京欢迎您！"],
                       ["我喜欢English!"],
                       [""]]
    dataset = ds.TextFileDataset(DATA_FILE, shuffle=False)
    tokenizer = nlp.WhitespaceTokenizer()
    dataset = dataset.map(operations=tokenizer)
    tokens = []
    for i in dataset.create_dict_iterator():
        text = nlp.to_str(i['text']).tolist()
        tokens.append(text)
    logger.info("The out tokens is : {}".format(tokens))
    assert whitespace_strs == tokens

see https://gitee.com/mindspore/mindspore/blob/master/tests/ut/python/dataset/test_tokenizer.py for details.


API rewrite for 2.0

Description
This issue is here to facilitate discussion regarding the structure of the API for 2.0

I'd like to see the API for salte-auth mimic something akin to firebase-sdk.
References

https://firebase.google.com/docs/reference/js/#firebase.auth.Auth

We should also attempt to extrapolate the route matching into salte-auth if possible.
References

https://github.com/PolymerElements/iron-location/blob/master/iron-location.html

We need to incorporate deeper ID token validation such as signature, audience, azp, nonce.  Much of this will be the same logic as exists in SalteAuth 1.x but we should review the specification to make sure that nothing was missed in the original implementation.  See http://openid.net/specs/openid-connect-core-1_0.html#ImplicitIDTValidation for more information.


Undefined behavior when adding an empty 1-ary array to a zeroary array

The following snippet leads to a seemingly undefined behavior:
#require "owl";;
open Owl;;
open Owl.Dense.Ndarray.Generic;;
of_array Bigarray.int64 [||] [|0|] + create Bigarray.int64 [||] 2L;;

- : (int64, Bigarray.int64_elt) Owl_dense_ndarray_generic.t =

              C0
R<PHONE_NUMBER>7458

Here, we try to add a scalar to an empty unary array. The expected output would be either:

An exception saying the operation is illegal
An empty unary array (as is the case in numpy when evaluating np.array([]).reshape(-1) + np.array(2))

Update: the same behavior happens here:
of_array Bigarray.int64 [||] [|0|] + create Bigarray.int64 [|1|] 2L;;

- : (int64, Bigarray.int64_elt) Owl_dense_ndarray_generic.t =

              C0
R<PHONE_NUMBER>6642

This is arguably even more problematic as the normal rules for broadcasting should apply here.

Thanks for reporting it.
This requires touching owl_ndarray_maths_stubs and owl_utils_infer_shape, which I am not familiar with.
@ryanrhymes or @tachukao could you look into this?

The current version still has this problem, but the result becomes:
- : (int64, Bigarray.int64_elt) Owl_dense_ndarray_generic.t =
  C0
R  2

But changing 1 to other number will lead to Exception: Owl_exception.NOT_BROADCASTABLE.
It should be note that corner cases using Bigarray together with Owl should often be changed to using built in types such as S or D, which leads to less bugs and confusing results.


Enhancement Request: Option to grab album cover from last.fm while syncing

First of all, thanks for creating Koel, I absolutely love it!
But I'm really obsessive when it comes to album covers and currently as far as I understand from the code bellow Koel will not grab the album cover from Last.fm while syncing ...
if (!$album->has_cover) {
    // If the album has no cover, we try to get the cover image from existing tag data
    if (!empty($info['cover'])) {
        try {
            $album->generateCover($info['cover']);
        } catch (Exception $e) {
            Log::error($e);
        }
    }
    // or, if there's a cover image under the same directory, use it.
    elseif ($cover = $this->getCoverFileUnderSameDirectory()) {
        $album->copyCoverFile($cover);
    }
}

Only when the album is played, the cover will be updated using Last.fm ... I assume this was done to avoid slowing down the syncing process? As far as API limitation go, their TOS states "You will not make more than 5 requests per originating IP address per second, averaged over a 5 minute period"
So grabbing while syncing looks feasible? Could this be made an option?

One of the benefits of Last.fm is that the album/artist art is always being updated, in your senecio this will stop happening, it will be especially annoying for an album that at the time of the sync did not have art or had the wrong art and was later updated.

But checking for album art when an album is played doesn't have to disappear? Just an optional grab while syncing, otherwise the album art is incomplete until you played your all the albums ...

Yes, this would slow down the whole syncing process significantly. Maybe a .env option (GET_LASTFM_COVER_WHEN_SYNC?) instead, but I don't have time for it right now. Feel free to send a PR over ;)