NNBD. No error in VM for class with generative constructor and non-initialized variable

According to the NNBD specification

It is an error if a class declaration declares an instance variable with a potentially non-nullable type and no initializer expression, and the class has a generative constructor where the variable is not initialized via an initializing formal or an initializer list entry, unless the variable is marked with the late modifier

This error is reported in analyzer but no error in VM. For example, the following code works without any errors in VM
class A {}

class C1 {
  A a;
  String s;

  C1() {}
//^^
// [analyzer] unspecified
// [cfe] unspecified
}

abstract class C2 {
  A a;
  String s;

  C2() {}
//^^
// [analyzer] unspecified
// [cfe] unspecified
}

class C3 extends C2 {}

main() {
  new C1();
  new C3();
}

Dart VM version: 2.8.0-dev.12.0 (Thu Mar 5 11:45:50 2020 +0100) on "windows_x64"

An error is report now, but not at the line that the test expects! We report on the field and not on the constructor.

Should we update the line on which the error is reported or the test?

This is mostly done. Test update requested in https://github.com/dart-lang/co19/issues/588
Note that co19/LanguageFeatures/nnbd/static_errors_A05_t14 not fixed yet because of the pending language issue https://github.com/dart-lang/language/issues/868

Is this still open?

Retested on Dart SDK version: 2.10.0-79.0.dev (dev) (Mon Aug 31 17:07:47 2020 -0700) on "windows_x64"
There are errors in CFE now, but CFE reports 4 errors here and analyzer only 2
class A {}

class C1 {
  A a;  // VM Error: Field 'a' should be initialized because its type 'A' doesn't allow null.
  String s; // VM Error: Field 's' should be initialized because its type 'String' doesn't allow null.

  C1() {} // Analyzer error - Non-nullable instance field 's' must be initialized.
}

abstract class C2 {
  A a;  // VM Error: Field 'a' should be initialized because its type 'A' doesn't allow null.
  String s; // VM Error: Field 's' should be initialized because its type 'String' doesn't allow null.

  C2() {} // Analyzer error - Non-nullable instance field 'a' must be initialized.
}

class C3 extends C2 {}

main() {
  new C1();
  new C3();
}

It seems that this is a presentation artifact in analyzer cli.
We do report all errors, but them they are probably coalesced into one.

Resolved by https://github.com/dart-lang/sdk/commit/734da2ca2cd0119140a00340ee2ffe47372fc956.


him/auto scroll

add extra space at bottom when streaming
snap to bottom
chat box on top on new sessions

[!IMPORTANT]
Enhance UI with auto-scroll, improved model selection, and UI adjustments in gui.tsx, ModelSelect.tsx, and Layout.tsx.

Behavior:

Auto-scroll to bottom when active in gui.tsx.
Add extra space at bottom when streaming in StepsDiv in gui.tsx.
Snap to bottom on new sessions in GUI in gui.tsx.

UI Adjustments:

Adjust Footer position and padding in Layout.tsx.
Modify StyledListboxOptions scrollbar styles in ModelSelect.tsx.
Change GradientBorder padding based on loading state in ContinueInputBox.tsx.

Model Selection:

Add keyboard shortcut to cycle models in ModelSelect.tsx.
Add "Add Model" option in ModelSelect.tsx.

Misc:

Adjust z-index for elements in StepContainer.tsx and gui.tsx.
Update StopButton styling in gui.tsx.

This description was created by  for f0b6b59716816aecb94f0bb96e7817ec1ef98de9. It will automatically update as commits are pushed.

is this true?

Fake news asf.
merging


Missing entries in the lang file

Describe the bug
Some rituals/advancements have missing names. They're probably missing in the lang file
To Reproduce
Following rituals/advancements have missing names. Not sure if I've missed any:

Advancement Summoning the Foliot Lumberjack
Ritual Familiar Parrot (start, interrupt, finished)
Ritual Wild Parrot (start, interrupt, finished)
Ritual Summoning Dawn (start, interrupt, finished)
Ritual Summoning Dust(start, interrupt, finished)
Ritual Drikwing Familiar (start, interrupt, finished) (by the way the book says that it needs spider web instead of cobweb not sure if that's intended)
Ritual Wild Drikwing (start, interrupt, finished) (also same thing with the cobweb)
Ritual Soul Gem (start, interrupt, finished)
Ritual Storage Stabilizer Tier 2 (start, interrupted. finished)
Ritual Storage Stabilizer Tier 3 (start, interrupted, finished)
Ritual Storage Stabilizer Tier 4 (start, interrupted, finished)

Expected behavior
Rituals/Advancements show correct names
Screenshots

System (please complete the following information):

Occultism Version: occultism-1.16.5-1.0.15
OS: Windows 10
Minecraft Version: 1.16.5
Forge 36.0.54
curios-forge-1.16.5-<IP_ADDRESS>
Patchouli-1.16.4-50
jei-1.16.4-<IP_ADDRESS>

@Wxrlds advancements are currently not enabled in the mod, they are only set up hidden to use as an entry point with quests. As such if a modpack enables the advancements, it needs to provide texts for them.

Then I suppose that the advancement is a separate bug as the only mods installed are the ones I listed. I think that this is on Occultism's side then. JEI isn't listed as dependency (unlike Patchouli and Curios) but I doubt that JEI is messing with only that one specific advancement from only your mod.


Does this code include the Semantic String Docid method that cluster the docid in the paper?

Hi, Maybe  Semantic String Docid will help improve the performance of DSI? In the data/create_NQ_train_vali.py, it uses random doc id.

Hi, yep it should help according to the original paper. I also find if further randomize naive ids by not using acceding order for each docs but shuffle all the ids will also increase the scores quit a bit.

Thanks for your reply.

I don't have semantic id implemented, I may have a try in the next month. If you want to have a try, you are also welcome to open a PR to add this feature!

I implemented it with another nlp task, but it doesn't work, I may try to use the semantic id with your code.


Non array style hook is not working

some example in the README is written this style.
   #...
    Hooks:
      BeforeConnect: exec echo hai

but an error happens in my environment.
Error: failed to open config: yaml: unmarshal errors:
  line 90: cannot unmarshal !!str `exec ec...` into hooks.Hooks

but dashed array style works.
    Hooks:
      BeforeConnect:
      - exec echo hai

I don't know whether it's a bug or the document is wrong.

Confirmed this issue in, well, version assh version n/a (n/a).  List works, string does not.  Changing the readme would be the easier route for now to reduce confusion until hooks can accept strings, which can either be a will-not-do as things work ok as is or put on a roadmap of some sort.


ENG-1253 rename jira client

Related PR: https://github.com/autokitteh/autokitteh/pull/527

I am closing because after trying to amend the unsigned commit, I did something even crazier to the PR.
Will open another as the changes are trivial.


Add args/kwargs remote files as dependencies

This looks through args and kwargs and stages in remote files in the manner that inputs list was processed.
Closes #526

With the test I just committed, I get this exception testing stage-in with a file in args. @ConnorPigg
        for idx, f in enumerate(args):
            if isinstance(f, File) and f.is_remote():
>               args[idx] = f.stage_in(executor)
E               TypeError: 'tuple' object does not support item assignment


Add 'get_vowel', improve profile and help

Implement vowel-only letter option
More helpful new player guidance
Level-error prevention on profile command

I'm a terrible person. I did three separate things in one PR

Merging this so I can work on #169


Switch roles to clusterroles

Description
Accompanies pull request https://github.com/tinkerbell/hegel/pull/370
Why is this needed
If hegel is going to read from multiple namespaces it need accompanying rbac
How are existing users impacted? What migration steps/scripts do we need?
May break compatibility if a user is running in an environment where they are not allowed to roll out cluster-rbac resources ?
Otherwise there should be no impact.
Checklist:
I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

@willemm Can this be provided as opt-in only?

Shouldn't be that hard, I'll give that a go.

Like this?  I named the option  allNamespaces: false
I also took the liberty of adding the --kubernetes-namespace option when not opting in to clusterroles for all namespaces because I felt that was prudent.

What do we think about offering a .Values.rbac.enabled which, when disabled, assumes the user configures the RBAC however they want?
I'm not fond of providing RBAC customizations and would prefer this approach.

If I, as a user, have to configure my own RBAC that means I have to introduce additional configurations myself, outside of the chart, and can no longer install it off-the-shelf as it were.  That kinda defeats the whole purpose of having a helm chart in the first place.
But if you're really not fond of the RBAC customizations, then I would suggest that most users will be fine with the default of ClusterRole and ClusterRoleBinding, which can then be disabled with a value.  Note that would also be consistent with all the other components which have cluster-wide rbac. (hegel is the exception in this).
That would be better anyway, because if a user really needs it to just look at a specific namespace, it's at least equally likely that that will not be the namespace hegel is installed in in the first place.
The values.args thing seems valid, I don't have any argument for or against.

Thanks for the feedback, @willemm. I'm open to making ClusterRole and ClusterRoleBinding the default, though it still needs to be opt-out so users can define a small scope should they want to.

... have to configure my own RBAC that means I have to introduce additional configurations myself, outside of the chart, and can no longer install it off-the-shelf as it were. That kinda defeats the whole purpose of having a helm chart in the first place.

The existing RBAC aligned with historical design decisions. I appreciate it doesn't suit your deployment model, but it is a valid deployment model that's been working for some time.
I don't think tweaking a chart to satisfy a different deployment model is abnormal.

Ok.  I had a small look and I'm not sure .Values.rbac.enabled works "nicely" without some other changes, mainly because there are currewntly two values, .Values.roleName and .Values.roleBindingName which seem like they shoud also go under .Values.rbac.* ?

Ok. I had a small look and I'm not sure .Values.rbac.enabled works "nicely" without some other changes, mainly because there are currewntly two values, .Values.roleName and .Values.roleBindingName which seem like they shoud also go under .Values.rbac.* ?

That's fine. There isn't an expectation to remain backward compatible yet, though we do our best to minimize disruptions.

#120 says, "unrestricted access shouldn't be the default or only option". I agree with this. @willemm, i apologies. i think we've gone back and forth on this, but i think we're going to need to be able to select between both role and clusterRole.

For Rufio that makes sense, as it can read secrets.  Which it can currently do, cluster-wide.
However, hegel only reads 'hardware' resources from the tinkerbell.org apigroup.
So I'm afraid I don't understand why this is an issue for the hegel chart.  Currently it is the only exception that does not have clusterrolebindings, and it's the least impactful one from a security standpoint.  Negligible impact, in fact.
So while this PR could include a switch option, I feel it would be much better if all the charts had the same rbac structure/setup, whuich should IMO be part of how you fix the #120 issue.  (i.e. don't just fix rufio there, but copy-paste the fix across all the charts)

Hey @willemm , Apologies for all the churn on this one. Thank you for putting this up. @chrisdoherty4 and I spoke today. I would like us to go back to what you originally had. Apologies for the flip-flopping. Also, as you've noted, we need a fix across all services. Not only that, but not all of our services handle single namespaces properly either. With all this said, I've created PR #129 and I'm working across the Tinkerbell service repos in order to make sure they all handle namespacing properly.
If you have some cycles (if not, totally fine), I'd really appreciate your review on #129. Thanks again for contributing!

No worries, I work in fintech so this is a breeze, comparatively ;)
I looked at it, all of it looks good.  (Assuming hegel indeed does not need access to workflows, which I think it shouldn't, but I'm not sure)


deep_merge! can cause changes to the other_hash

Test case:
class Face < Hash
  include Hashie::Extensions::DeepMerge
end

DEFAULT_FACE = {eyes: {color: green}}

my_face = Face.new
my_face.deep_merge! DEFAULT_FACE
my_face[:eyes][:color] = :red

puts DEFAULT_FACE
# Expected output (same as before):
# {eyes: {color: :green} }
# Actual output (changed!):
# {eyes: {color: :red} }

I think this is because deep_merge doesn't dup nested hash values inside DEFAULT_FACE in before assigning them to keys in the target hash.

Looks legit. I am not sure it should dup it, but I would build an actual spec in hashie next.

There's the spec.  I'd be happy to resolve it if we can agree on a solution.  My initial thought is to just change line 29 to v.respond_to?(:deep_dup) ? v.deep_dup : v

If, on the other hand, there is some case where this behavior is actually desirable, maybe it could be some kind of flag or option? (I would think it would be undesirable/unexpected in most cases).
Or, if nothing else, at the very least, I could add this behavior to the documentation of the DeepMerge extension.

Btw, do we dup hashes on merge elsewhere?

I know it works fine in a Hashie::Mash - so... I haven't looked, but I'm assuming that's what's happening there, possibly implicitly as part of converting all subhashes to Mashes, or something.

Care to look? ;)

Oh, hah, yeah so this is how it's defined in Mash:
    # Performs a deep_update on a duplicate of the current mash.
    def deep_merge(other_hash, &blk)
      dup.deep_update(other_hash, &blk)
    end

and deep_update is basically a re-implementation of _recursive_merge that calls convert_value on each value, which dups each nested Mash (dup == deep_dup for a Mash), and converts each hash value to a Mash, which process also basically accomplishes a deep_dup.
So yeah, basically, it does something similar to a deep_dup for each nested "hash-oid" :smile:

(Interesting that Mash doesn't even appear to use the deep_merge extension... or perhaps I'm missing it?)

Mash has its own version of deep_merge. It implements most of the extensions that we have within itself.


BUG - Cannot find module 'xml-js' Error Due to Incorrect Dependency Classification

Description
Cannot find module xml-js Error Due to Incorrect Dependency Classification.
The application consuming cap-config-writer should be able to locate and use the xml-js module without running into errors.
Screenshots
If applicable, add screenshots to help explain the problem.
Root Cause Analysis
Problem
xml-js was defined part of devDependencies in the package.json.
Fix
Move xml-js from devDependencies to dependencies in the package.json file to ensure it is available during runtime.
Why was it missed
The bug was introduced because the xml-js module was added to devDependencies instead of dependencies while copying package.json configuration.

Closing bug - fix provided


Update README.md

OP-0000
We prefer small, well tested pull requests.
Please refer to Contributing to Spinnaker.
When filling out a pull request, please consider the following:

Follow the commit message conventions found here.
Provide a descriptive summary for your changes.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Add inline code comments to changes that might not be obvious.
Squash your commits as you keep adding changes.
Add a comment to @spinnaker/reviewers for review if your issue has been outstanding for more than 3 days.

Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.

This PR  triggered this build in this execution, please wait for it  and child pipelines to succeed before merging:  https://isd.prod.opsmx.net/deck/#/applications/gcp-gitprtrigger/executions/details/01FZZWD4YMQK0CTR383WEK44YK

This PR  triggered this build in this execution, please merge to v3.12 branch only if this succeeds:  https://spin.prod.opsmx.com/#/applications/isd312/executions/details/01FZZWDD30M1MBSE4THGJ8JGJQ


use joi.link to only resolve strictly recursive self-references

... joi.link fails when attempting to resolve to a cousin or uncle node, which is not a scenario we need to handle since that's scenario is not recursive.

hey @tlivings could this bugfix get merged? would you like a test to be added?

Is it gonna be merged? I need this in my project.

@tlivings Hey, is it something wrong with this PR? Many people is waiting for it.

Sorry this fell off my radar. Reviewing now.

Can you add a test?
thanks.

@nlundquist

just pushed that test, apologies for the delay.


ENH: New LAPACK drivers are added to the least-squares solvers linalg.lstsq

This is a continuation of the pull request #4478. Now the function linalg.lstsq is modified to use extra LAPACK drivers.
Sorry, but I do not know how to satisfy these requirements, could you give a hint:
-Is the new functionality tagged with .. versionadded:: X.Y.Z (with X.Y.Z the version number of the next release can be found in setup.py)?
-Is the new functionality added to the reference guide?

Sorry, but I do not know how to satisfy these requirements, could you give a hint:

-Is the new functionality tagged with .. versionadded:: X.Y.Z (with X.Y.Z the version number of the next release can be found in setup.py)?

I think @rgommers has written that part of the docs, and I think it means adding a line like the following one:
https://github.com/scipy/scipy/blob/maintenance/0.15.x/scipy/linalg/decomp_cholesky.py#L267
In your case, it would be version 0.16.0 instead of 0.8.0 if your changes will go into the next version of scipy which would be 0.16.0.
The parser that turns scipy docstrings into html documentation is quite finicky, and so the number of blank lines around the versionadded line might matter, and also it might need to be in a Notes section.  I'm not sure about the details, but here's a related comment https://github.com/scipy/scipy/pull/3877#discussion_r16313644.  Maybe @WarrenWeckesser has more information.

Benchmark results:
NumPy version 1.10.0.dev+03c2bb8
SciPy version 0.16.0.dev+3c6bab0

                       Least-Squares Solver
==============================================================
      shape      |   LAPACK   |        dtype       |   time
                 |   driver   |                    | (seconds)
--------------------------------------------------------------
      (500, 334) |   *gelss  |            float64 |   0.16
      (500, 334) |   *gelsy  |            float64 |   0.02
      (500, 334) |   *gelsd  |            float64 |   0.05
      (500, 334) |    Numpy  |            float64 |   0.05
      (500, 334) |   *gelss  |         complex128 |   0.28
      (500, 334) |   *gelsy  |         complex128 |   0.06
      (500, 334) |   *gelsd  |         complex128 |   0.07
      (500, 334) |    Numpy  |         complex128 |   0.09
     (1000, 667) |   *gelss  |            float64 |   1.61
     (1000, 667) |   *gelsy  |            float64 |   0.10
     (1000, 667) |   *gelsd  |            float64 |   0.21
     (1000, 667) |    Numpy  |            float64 |   0.19
     (1000, 667) |   *gelss  |         complex128 |   1.66
     (1000, 667) |   *gelsy  |         complex128 |   0.19
     (1000, 667) |   *gelsd  |         complex128 |   0.31
     (1000, 667) |    Numpy  |         complex128 |   0.31
    (1500, 1000) |   *gelss  |            float64 |   2.13
    (1500, 1000) |   *gelsy  |            float64 |   0.25
    (1500, 1000) |   *gelsd  |            float64 |   0.46
    (1500, 1000) |    Numpy  |            float64 |   0.46
    (1500, 1000) |   *gelss  |         complex128 |   5.50
    (1500, 1000) |   *gelsy  |         complex128 |   0.72
    (1500, 1000) |   *gelsd  |         complex128 |   1.30
    (1500, 1000) |    Numpy  |         complex128 |   1.28
    (2000, 1334) |   *gelss  |            float64 |   8.53
    (2000, 1334) |   *gelsy  |            float64 |   0.67
    (2000, 1334) |   *gelsd  |            float64 |   1.34
    (2000, 1334) |    Numpy  |            float64 |   1.31
    (2000, 1334) |   *gelss  |         complex128 |  35.72
    (2000, 1334) |   *gelsy  |         complex128 |   1.98
    (2000, 1334) |   *gelsd  |         complex128 |   3.59
    (2000, 1334) |    Numpy  |         complex128 |   3.59
    (2500, 1667) |   *gelss  |            float64 |  11.03
    (2500, 1667) |   *gelsy  |            float64 |   1.67
    (2500, 1667) |   *gelsd  |            float64 |   3.07
    (2500, 1667) |    Numpy  |            float64 |   3.06
    (2500, 1667) |   *gelss  |         complex128 |  27.04
    (2500, 1667) |   *gelsy  |         complex128 |   4.14
    (2500, 1667) |   *gelsd  |         complex128 |   7.52
    (2500, 1667) |    Numpy  |         complex128 |   7.47
    (3000, 2000) |   *gelss  |            float64 |  21.15
    (3000, 2000) |   *gelsy  |            float64 |   3.11
    (3000, 2000) |   *gelsd  |            float64 |   6.09
    (3000, 2000) |    Numpy  |            float64 |   5.73
    (3000, 2000) |   *gelss  |         complex128 | 110.78
    (3000, 2000) |   *gelsy  |         complex128 |   7.08
    (3000, 2000) |   *gelsd  |         complex128 |  12.70
    (3000, 2000) |    Numpy  |         complex128 |  12.70
.
                       Least-Squares Solver
==============================================================
      shape      |   LAPACK   |        dtype       |   time
                 |   driver   |                    | (seconds)
--------------------------------------------------------------
    (10000, 100) |   *gelss  |            float64 |   0.15
    (10000, 100) |   *gelsy  |            float64 |   0.08
    (10000, 100) |   *gelsd  |            float64 |   0.07
    (10000, 100) |    Numpy  |            float64 |   0.06
    (10000, 100) |   *gelss  |         complex128 |   0.17
    (10000, 100) |   *gelsy  |         complex128 |   0.17
    (10000, 100) |   *gelsd  |         complex128 |   0.15
    (10000, 100) |    Numpy  |         complex128 |   0.19
    (20000, 100) |   *gelss  |            float64 |   0.18
    (20000, 100) |   *gelsy  |            float64 |   0.16
    (20000, 100) |   *gelsd  |            float64 |   0.20
    (20000, 100) |    Numpy  |            float64 |   0.16
    (20000, 100) |   *gelss  |         complex128 |   0.44
    (20000, 100) |   *gelsy  |         complex128 |   0.42
    (20000, 100) |   *gelsd  |         complex128 |   0.46
    (20000, 100) |    Numpy  |         complex128 |   0.42
    (30000, 100) |   *gelss  |            float64 |   0.31
    (30000, 100) |   *gelsy  |            float64 |   0.29
    (30000, 100) |   *gelsd  |            float64 |   0.33
    (30000, 100) |    Numpy  |            float64 |   0.29
    (30000, 100) |   *gelss  |         complex128 |   0.69
    (30000, 100) |   *gelsy  |         complex128 |   0.75
    (30000, 100) |   *gelsd  |         complex128 |   0.72
    (30000, 100) |    Numpy  |         complex128 |   0.78
    (40000, 100) |   *gelss  |            float64 |   0.40
    (40000, 100) |   *gelsy  |            float64 |   0.43
    (40000, 100) |   *gelsd  |            float64 |   0.45
    (40000, 100) |    Numpy  |            float64 |   0.39
    (40000, 100) |   *gelss  |         complex128 |   1.01
    (40000, 100) |   *gelsy  |         complex128 |   0.97
    (40000, 100) |   *gelsd  |         complex128 |   0.95
    (40000, 100) |    Numpy  |         complex128 |   1.01
    (50000, 100) |   *gelss  |            float64 |   0.52
    (50000, 100) |   *gelsy  |            float64 |   0.60
    (50000, 100) |   *gelsd  |            float64 |   0.53
    (50000, 100) |    Numpy  |            float64 |   0.54
    (50000, 100) |   *gelss  |         complex128 |   1.34
    (50000, 100) |   *gelsy  |         complex128 |   1.37
    (50000, 100) |   *gelsd  |         complex128 |   1.35
    (50000, 100) |    Numpy  |         complex128 |   1.37
    (60000, 100) |   *gelss  |            float64 |   0.71
    (60000, 100) |   *gelsy  |            float64 |   0.65
    (60000, 100) |   *gelsd  |            float64 |   0.64
    (60000, 100) |    Numpy  |            float64 |   0.71
    (60000, 100) |   *gelss  |         complex128 |   1.70
    (60000, 100) |   *gelsy  |         complex128 |   1.96
    (60000, 100) |   *gelsd  |         complex128 |   1.63
    (60000, 100) |    Numpy  |         complex128 |   1.60
    (70000, 100) |   *gelss  |            float64 |   0.79
    (70000, 100) |   *gelsy  |            float64 |   0.84
    (70000, 100) |   *gelsd  |            float64 |   0.79
    (70000, 100) |    Numpy  |            float64 |   0.84
    (70000, 100) |   *gelss  |         complex128 |   1.91
    (70000, 100) |   *gelsy  |         complex128 |   2.21
    (70000, 100) |   *gelsd  |         complex128 |   2.00
    (70000, 100) |    Numpy  |         complex128 |   1.88
    (80000, 100) |   *gelss  |            float64 |   0.98
    (80000, 100) |   *gelsy  |            float64 |   0.97
    (80000, 100) |   *gelsd  |            float64 |   0.91
    (80000, 100) |    Numpy  |            float64 |   0.90
    (80000, 100) |   *gelss  |         complex128 |   2.08
    (80000, 100) |   *gelsy  |         complex128 |   2.11
    (80000, 100) |   *gelsd  |         complex128 |   2.10
    (80000, 100) |    Numpy  |         complex128 |   2.08
    (90000, 100) |   *gelss  |            float64 |   1.08
    (90000, 100) |   *gelsy  |            float64 |   1.05
    (90000, 100) |   *gelsd  |            float64 |   1.02
    (90000, 100) |    Numpy  |            float64 |   1.06
    (90000, 100) |   *gelss  |         complex128 |   2.41
    (90000, 100) |   *gelsy  |         complex128 |   2.49
    (90000, 100) |   *gelsd  |         complex128 |   2.51
    (90000, 100) |    Numpy  |         complex128 |   2.38
   (100000, 100) |   *gelss  |            float64 |   1.20
   (100000, 100) |   *gelsy  |            float64 |   1.17
   (100000, 100) |   *gelsd  |            float64 |   1.18
   (100000, 100) |    Numpy  |            float64 |   1.18
   (100000, 100) |   *gelss  |         complex128 |   2.61
   (100000, 100) |   *gelsy  |         complex128 |   2.87
   (100000, 100) |   *gelsd  |         complex128 |   2.85
   (100000, 100) |    Numpy  |         complex128 |   2.79
   (110000, 100) |   *gelss  |            float64 |   1.47
   (110000, 100) |   *gelsy  |            float64 |   1.61
   (110000, 100) |   *gelsd  |            float64 |   1.42
   (110000, 100) |    Numpy  |            float64 |   1.31
   (110000, 100) |   *gelss  |         complex128 |   3.42
   (110000, 100) |   *gelsy  |         complex128 |   3.32
   (110000, 100) |   *gelsd  |         complex128 |   3.12
   (110000, 100) |    Numpy  |         complex128 |   3.00

Regarding versionadded, @argriffing's comments are correct. It can go in the Notes section and needs one blank line below it.

Now that LAPACK drivers are merged (gh-4661 and references therein), this should probably be rebased on master to only keep commits related to using the new LAPACK routines in lstsq. @AlexGrig ?

(working on this one now)

Here is a rebased branch, to which I added a bunch of little fixes and translation of the first benchmark to the new benchmark framework: https://github.com/rgommers/scipy/tree/pr/4489
There are some issues though, tests are failing. Might be related to changes in the calc_lwork stuff - the problem is that the number of return values from the lapack driver calls isn't right.
@AlexGrig could you take over that branch and push it here? And then have a look at what needs fixing up?

I'd like to see this get merged before the release split (probably on Sunday), but there still seems to be a fair bit to do and review. So removing the 0.16.0 milestone.

Follow-up to this PR is in gh-5262, so closing this.


Add support for duplicating lines

Duplicates lines that are selected

I added it under "Other movement and deletion commands". Not sure if that is the right section though.

I noticed Travis has been building this branch for a while. Maybe something got stuck?

hmm, good point. I checked and it said it passed, just this graphic hasn't updated?

After duplicating multiple lines the selection is somewhat unexpected:

before
after

This makes it hard to run duplicate_line multiple times.

hmm good point, I think I'd call that a bug. @scholtzan?

Oh, I will look into it.


fix: move measurement into separate process

https://github.com/omisego/elixir-omg/issues/936
Overview
Lets try a solution and see how it behaves in the wild, metrics are available in Datadog.
Changes

Spawn a process that does a complete copy of OMG.State state and performs the necessary computation and dies.

Testing
/

Coverage remained the same at ?% when pulling ef1c5a8e29d6f98572696cc8e23db754d13c7e7f on spawn_intesive_computation into 1d99b8bd044cbe9e4f814c56bf705ca67c14f4bf on master.


Update Heading for Speaker or Amp based on odometry

Please update label correctly, don't know where vision drive falls under.
Update Maintain Heading to point towards the Speaker or Amp based on odometry until vision detects an april tag, then switch to vision for heading. (Like what we did in 2022 Rebound Rumble)
Speaker Heading:
Blue = 180
Red = 0
Amp Heading
Blue = 90
Red = -90

@Tan560 I don't think that is how we want to do it.  These are separate heading options.

closing this one and creating several more.


Support multiple Desktop Actions

A single Desktop Entry can have multiple Desktop Actions (see e.g. https://github.com/swaywm/sway/wiki/Tricks#take-screenshots-and-open-them-in-annotation-tool)
It would be nice if this was somehow supported by yofi itself. How much effort would that be?

Yeah, quite an expected issue. That's probably would not be hard to implement from tech perspective but it's hard to provide a nice UI, I don't really want to complicate it and support some kind of nested entries list. Perhaps it can be done simply by adding a new hotkey (e.g. right arrow) for switching to the list of actions for selected desktop entry, but I'm not sure whether it's an intuitive or not. Do you have an idea how it should look like?

I guess if the entry has at least one action, show a second row for an entry and with a distinct different color/font-size show the actions there. Making that selectable by left and right (with some indicators ->/<-) could look alright.

Something like that layout you mean?

#78 adds the feature, though it renders badly (inline). Idk whether I want to change layout at this patch, but the proposed one looks better so I don't want to close that issue yet.


validation: add interface to GovernanceManager

I added an interface to the governanceManager in order to be able to mock it and to add new implementations (apart from picking updates from a local file).
I modified the behavior of the manager to run it in a goroutine and receive updates whenever it's available.
Do you think it should live it should live in its own package ?

This change is

Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion.

tmpop/state.go, line 102 at r1 (raw file):
Previously, alexppxela (Alexandre Thibault) wrote…
I think that if you update the validator here, you can validate several links in the same block with differents validation rules

that's right ! this is why I kept a s.validator in the first place... thank's !

Comments from Reviewable

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Move to using Processing as a library

This will enable us to take full advantage of Java 7/8 functionality. We can also use Maven, as well as writing JUnit tests for everything.

In a similar vein, what if we started using PixelFlow for particle effects and post processing? It might be a little overkill, but it's worth looking into.

This article describes how to use Processing as a library.

Fully completed in #36


Add assert for test of plot example

The src/js/example-plot.html is tested in https://github.com/NLESC-JCER/cpp2wasm/blob/master/TESTING.md, but there is no check if the plot has been drawn correctly.
Testing is hard due to vega rendering to canvas and different duration's each run

Maybe we can export the chart data and check this in a test.


Added Face Alignment in Full Pose Range

Fixes: #169
Proposed Changes
This model holds the pytorch improved version of the paper: Face Alignment in Full Pose Range: A 3D Total Solution.
Applications

Face Reconstruction
Face Alignment
3D Pose Estimation
Depth Image Estimation

@akshitagupta15june The applications are diverse but currently i have added this model in the Face Reconstruction folder. I can later change it if required.

Thanks a lot @akshitagupta15june , can i know what i should do , will be glad to share my work.

@infiniteoverflow would you like to be the mentor for face reconstruction in this repo?
The mentees in open source programs will be happy to learn from you.
like i will inform you and invite you for a session with them.
can you share your mailid here.

Sure, i will be glad to. I will message you the details in DM. Thank you.

thankyou so much!


VS Code Bug in April 2018 update

What the the meaning of expecting a ';' .  I have already given the ';'

Or file it against the C extension if you do not think this is a legal error


[Question] How to cancel a key send payment at the recipient?

Background
I can send a key send payment like this:
lncli sendpayment --dest=03f0afb639388c025189a19cf90421b6c728a0addc1ea9d1c32c09332a7a6b5373 --amt=100 --final_cltv_delta=40 --key_send

What I want to do further is to be able to cancel this payment at the recipient. Does lnd currently support this? If not, will this feature be added to key send? When can we expect to see it?
Your environment

version of lnd : version 0.9.0-beta
which operating system (uname -a on *Nix) : Ubuntu 16.04
version of btcd, bitcoind, or other backend : Bitcoin Core Daemon version v<IP_ADDRESS>

Expected behaviour
Be able to cancel a key send at the recipient.
Actual behaviour
Cannot cancel a key send at the recipient.

By default a node will reject all keysend payments unless they start with a flag that signals that they wish to accept them. In the future, we plan to add more functionality around the invoice RPC sub-server to allow users/developers to preferentially accept/deny a given keysend payment based on details such as any extra information attached along-side the payload.

@Roasbeef  Also, could we have a flag to set the minimum of payment that we would accept if we don't want to accept dust amounts?


Sponsorship for AD: Capsolver

From January 25, 2024, Capsolver became the Bronze Sponsor1 of the Wechaty open-source project.
According to the discussion2 in our mail list, we will add their logo with bio in our README.
This will be a monthly sponsorship, and the logo will be removed from the sponsorship section if they stop being Bronze Sponsor at any time.

AD online at https://github.com/wechaty/wechaty?tab=readme-ov-file#smirk-sponsors

removed AD for Capsolver because the sponsorship has been terminated.


Update dep and fix sourcemap

Coverage remained the same at 100.0% when pulling d8b8f638d091cd2905b21774aa4f6154b719940d on update-dep into 7857933d3520f98b4b27386d798e6a2df6c68603 on master.


Removed obsolete test_skip_link_is_skipped_when_there_is_searchbar test.

searchbar doesn't have autofocus since d938b3b2577807ffd585f654caa0f37d9574e565.

buildbot, test on selenium.

Thanks both :+1:


[zh-cn] sync /service-resources/endpoints-v1.md

Replace #34641 with the co-author @shixiuguo. Listed in issue #34733.
content/zh-cn/docs/reference/kubernetes-api/service-resources/endpoints-v1.md

Preview: https://deploy-preview-35601--kubernetes-io-main-staging.netlify.app/zh-cn/docs/reference/kubernetes-api/service-resources/endpoints-v1

/approve

/lgtm


Part 2 of implementations to perform migration to C#

This PR completes a part of the migration/adjustments of blast furnace mass balance to C#. It has been decided to have fewer commits / changes, since setup of tests, generation of reports and mutation tests will be performed later using the samples and templates saved in my personal gist.

This PR is linked to issue #8


Feature : Need to disable transaction mode globally not only per sql script file

Using Community command line version of Flyway 7.4.0 with Windows 10 Pro 1703 & Sql Server 2017
Hi! We already have this functionnality per sql script and it works very well.
But adding a .conf for each sql script to a large number of sql files this add too much noise.
There's any way to add executeInTransaction=false globally?
Thank you in advance

Hi. There isn't currently any option to do this globally
If the pain comes from creating each script config file, you could perhaps automate it for all of your .sql files by grabbing their name, let's call it script, and creating a new file script + ".conf" and writing executeInTransaction=false to these
I'll leave this open to see if it gets further interest for now since it's already achievable on a per script basis

Hi. There isn't currently any option to do this globally
If the pain comes from creating each script config file, you could perhaps automate it for all of your .sql files by grabbing their name, let's call it script, and creating a new file script + ".conf" and writing executeInTransaction=false to these
I'll leave this open to see if it gets further interest for now since it's already achievable on a per script basis

Hi! It's exactly what I'm talking about.  Here we have not some scripts, but some thousand of them. It's why I ask for a global option and tagged it like a feature. But I can understand that we cannot do each wish and maybe it's not a need for all.

Hi! It's exactly what I'm talking about.  Here we have not some scripts, but some thousand of them. It's why I ask for a global option and tagged it like a feature. But I can understand that we cannot do each wish and maybe it's not a need for all.

@JeanFrancoeur Flyway has a mechanism to detect non-transactional statements, and exclude them from transactions. Ideally we'd prefer users to rely on this detection logic rather than turning off transactions completely.
The script config option was introduced as a stop-gap to unblock users if non-transactional cases are discovered which Flyway doesn't currently cover.
Can you share more about why you need this feature? Have you come across many non-transactional statements in your scripts?

@JeanFrancoeur Flyway has a mechanism to detect non-transactional statements, and exclude them from transactions. Ideally we'd prefer users to rely on this detection logic rather than turning off transactions completely.
The script config option was introduced as a stop-gap to unblock users if non-transactional cases are discovered which Flyway doesn't currently cover.
Can you share more about why you need this feature? Have you come across many non-transactional statements in your scripts?

@MikielAgutu We have more than 5000 scripts to run to see if Flyway or your competitor beginning with L or a custom tool is better, more stable or faster. Actually using transaction mode is too slow. And we got some non-transactional errors too. We didn't investigate each, it was quicker to add .conf until now. Because we can't configure the non-transaction keywords dynamically, we have used the per script way. But restarting each time the whole thing is time consuming. We need to be able to see a complete run result in one pass and compare it against the other methods.

@MikielAgutu We have more than 5000 scripts to run to see if Flyway or your competitor beginning with L or a custom tool is better, more stable or faster. Actually using transaction mode is too slow. And we got some non-transactional errors too. We didn't investigate each, it was quicker to add .conf until now. Because we can't configure the non-transaction keywords dynamically, we have used the per script way. But restarting each time the whole thing is time consuming. We need to be able to see a complete run result in one pass and compare it against the other methods.

Thanks for the extra information. If I understand correctly, you're unblocked for the time being - albeit with a workaround that admittedly isn't ideal?
We'll consider adding a 'disable transactions' flag, but again we'd rather build in this understanding to Flyway itself. If you could provide any non-transactional examples that would be helpful.
I'll keep the issue open to see if others have this problem.

Thanks for the extra information. If I understand correctly, you're unblocked for the time being - albeit with a workaround that admittedly isn't ideal?
We'll consider adding a 'disable transactions' flag, but again we'd rather build in this understanding to Flyway itself. If you could provide any non-transactional examples that would be helpful.
I'll keep the issue open to see if others have this problem.

@MikielAgutu Yes, the workaround give me the opportunity the get forward, but I'm still getting some hurdles, so I can't give you all the non-trasactional missing tags for now.  I can't understand this one.  Please note that the script is executed with the non-transactional .conf file with executeInTransaction=false like all others.  I understand that the sys.sp_fulltext_database cannot be executed in transaction mode under mssql, but the current sql script only contains an EXEC command against a storedproc, nothing more.  What I'm missing here?
Migrating schema [dbo] to version "<IP_ADDRESS>.000230 - C991 RebuildFullTextSearch" [non-transactional]
ERROR: Migration of schema [dbo] to version "<IP_ADDRESS>.000230 - C991 RebuildFullTextSearch" [non-transactional] failed! Please restore backups and roll back database and code!
ERROR:
Migration C<IP_ADDRESS>.000230_C991_RebuildFullTextSearch.sql failed
SQL State  : S0001
Error Code : 15002
Message    : The procedure 'sys.sp_fulltext_database' cannot be executed within a transaction.
Note: I've been able to run all the same scripts with mssql command line runners and with another engine.
Thank you in advance for your help

@MikielAgutu Yes, the workaround give me the opportunity the get forward, but I'm still getting some hurdles, so I can't give you all the non-trasactional missing tags for now.  I can't understand this one.  Please note that the script is executed with the non-transactional .conf file with executeInTransaction=false like all others.  I understand that the sys.sp_fulltext_database cannot be executed in transaction mode under mssql, but the current sql script only contains an EXEC command against a storedproc, nothing more.  What I'm missing here?
Migrating schema [dbo] to version "<IP_ADDRESS>.000230 - C991 RebuildFullTextSearch" [non-transactional]
ERROR: Migration of schema [dbo] to version "<IP_ADDRESS>.000230 - C991 RebuildFullTextSearch" [non-transactional] failed! Please restore backups and roll back database and code!
ERROR:
Migration C<IP_ADDRESS>.000230_C991_RebuildFullTextSearch.sql failed
SQL State  : S0001
Error Code : 15002
Message    : The procedure 'sys.sp_fulltext_database' cannot be executed within a transaction.
Note: I've been able to run all the same scripts with mssql command line runners and with another engine.
Thank you in advance for your help

Regarding the warning you are seeing, this is a result of PRINT statements, and you can read about how to handle these in our docs for error overrides. Other than that, if there was no error then execution is successful
Regarding the error in your first case, would you be able to isolate this to a single script or a couple of scripts that cause this when executed together? It might be a result of making all of your migrations execute without a transaction when some actually require a transaction, and having the scripts would help us figure out what the issue is

Regarding the warning you are seeing, this is a result of PRINT statements, and you can read about how to handle these in our docs for error overrides. Other than that, if there was no error then execution is successful
Regarding the error in your first case, would you be able to isolate this to a single script or a couple of scripts that cause this when executed together? It might be a result of making all of your migrations execute without a transaction when some actually require a transaction, and having the scripts would help us figure out what the issue is

Thank you @DoodleBobBuffPants for your answer.  I know & already tried the error overrides, it works very well but it's a no-go for us, because it's a Teams only feature.
Because our current poc is very complex, it's not easy to investigate and isolate each case.
As previously discussed, @MikielAgutu here's 2 identified commands that cannot be run inside a transaction, they are missing from SQLServerParser:
sp_addsrvrolemember
sp_change_users_login

Thank you @DoodleBobBuffPants for your answer.  I know & already tried the error overrides, it works very well but it's a no-go for us, because it's a Teams only feature.
Because our current poc is very complex, it's not easy to investigate and isolate each case.
As previously discussed, @MikielAgutu here's 2 identified commands that cannot be run inside a transaction, they are missing from SQLServerParser:
sp_addsrvrolemember
sp_change_users_login

Thanks for letting us know. We'll keep this open as a reference to add these sprocs to our parser

Thanks for letting us know. We'll keep this open as a reference to add these sprocs to our parser

@DoodleBobBuffPants I did a quick test for our non-transactional case (C<IP_ADDRESS>.000230_C991_RebuildFullTextSearch.sql) I simply copied the content of the sproc directly inside the script file and the execution was successfull.  I will try to isolate this case into a smaller poc to see if we got a problem related to the BlockDepth detection.  I thought if the script has a .conf file everything executed from that point was not transactional, but it seems not to be the case.

@DoodleBobBuffPants I did a quick test for our non-transactional case (C<IP_ADDRESS>.000230_C991_RebuildFullTextSearch.sql) I simply copied the content of the sproc directly inside the script file and the execution was successfull.  I will try to isolate this case into a smaller poc to see if we got a problem related to the BlockDepth detection.  I thought if the script has a .conf file everything executed from that point was not transactional, but it seems not to be the case.

I don't know if it's a good idea to add a new comment here because it's closed, but it's directly linked.  Thank you for adding support for SP_FULLTEXT_DATABASE into the SPROCS_INVALID_IN_TRANSACTIONS in v7.5.2, but you forgot to add the 2 others listed in this issue: "SP_CHANGE_USERS_LOGIN", "SP_ADDSRVROLEMEMBER".  I made great execution progress.  I found that some file extensions were .SQL and I didn't find anywhere the mention that the filename extension is case sensitive.  Windows is not case-sensitive and finding them (only a few) was very painfull inside 5000+ scripts. For reference, I'm using this config : flyway.locations=filesystem:./sql/**/Sql/M*.*. Can you add this very important information somewhere like by adding this case here : https://www.red-gate.com/blog/database-devops/flyway-naming-patterns-matter?  I made my snapshot from 7.5.2.  Actually, even if the parser contains SP_FULLTEXT_DATABASE and SP_INDEXOPTION (a new one), it seems that an EXEC SPROC and EXEC sp_executesql @sql hide non-transactional keywords and it's not possible to grab them.  I'm still getting "The procedure 'sp_xyz' cannot be executed within a transaction".  To be able to complete the migration, I need to create a .conf file for each script.  By the way, I don't know if it can makes any difference, but I'm using migrate with the -target parameter.

I don't know if it's a good idea to add a new comment here because it's closed, but it's directly linked.  Thank you for adding support for SP_FULLTEXT_DATABASE into the SPROCS_INVALID_IN_TRANSACTIONS in v7.5.2, but you forgot to add the 2 others listed in this issue: "SP_CHANGE_USERS_LOGIN", "SP_ADDSRVROLEMEMBER".  I made great execution progress.  I found that some file extensions were .SQL and I didn't find anywhere the mention that the filename extension is case sensitive.  Windows is not case-sensitive and finding them (only a few) was very painfull inside 5000+ scripts. For reference, I'm using this config : flyway.locations=filesystem:./sql/**/Sql/M*.*. Can you add this very important information somewhere like by adding this case here : https://www.red-gate.com/blog/database-devops/flyway-naming-patterns-matter?  I made my snapshot from 7.5.2.  Actually, even if the parser contains SP_FULLTEXT_DATABASE and SP_INDEXOPTION (a new one), it seems that an EXEC SPROC and EXEC sp_executesql @sql hide non-transactional keywords and it's not possible to grab them.  I'm still getting "The procedure 'sp_xyz' cannot be executed within a transaction".  To be able to complete the migration, I need to create a .conf file for each script.  By the way, I don't know if it can makes any difference, but I'm using migrate with the -target parameter.

Those other 2 sprocs can be executed in transactions and don't need executeInTransaction=false. As per their docs, it's only user-defined transactions they cannot be executed in, so we cannot reliably add them to our auto-detection logic
Our official documentation does say that the file suffix should be .sql (lowercase). You can specify the migration suffixes to sqlMigrationSuffixes, so perhaps providing both the lowercase and uppercase suffix here could help

Those other 2 sprocs can be executed in transactions and don't need executeInTransaction=false. As per their docs, it's only user-defined transactions they cannot be executed in, so we cannot reliably add them to our auto-detection logic
Our official documentation does say that the file suffix should be .sql (lowercase). You can specify the migration suffixes to sqlMigrationSuffixes, so perhaps providing both the lowercase and uppercase suffix here could help

@DoodleBobBuffPants My bad, the default extension was effectively in lower case. Yes you are right, the 2 other SPROCS was a side effect.  Now about the embedded non-transactional issue, I made a little poc.
TestEmbededNT.zip
You will find the sql scripts and the sproc.  When doing the migration, the first script is successful with the automatic non-transational detection.  but the second one calling the same sql inside a sproc fail.
Successfully validated 3 migrations (execution time 00:00.037s)
Current version of schema [dbo]: 1
Migrating schema [dbo] to version "002 - TestNT" [non-transactional]
Migrating schema [dbo] to version "003 - ExecEmbeddedNT"
ERROR: Migration of schema [dbo] to version "003 - ExecEmbeddedNT" failed! Changes successfully rolled back.
ERROR:
Migration C003_ExecEmbeddedNT.sql failed
SQL State  : S0001
Error Code : 15002
Message    : The procedure 'sys.sp_serveroption' cannot be executed within a transaction.
Location   : .\testsql\C003_ExecEmbeddedNT.sql (D:\flyway\flyway-7.5.0 - Copy.\testsql\C003_ExecEmbeddedNT.sql)
Line       : 1
Statement  : EXEC [TestEmbeddedNT]
I hope you can find why I'm getting the strange behavior.

This is actually expected behavior. Our auto-detection logic is based off of the contents of your SQL. In the first case we can see the call to the non-transactional sproc, but in the second case, all we have access to is a call to your own sproc, so we cannot auto-detect the non-transactional sproc being used, and in this case you would have to set executeInTransaction=false

Ok noted, thank you.  Including an sp_execute_sql containing a non-transactional command like this?
DECLARE @sql NVARCHAR(MAX), @tabName VARCHAR(50), @ndxName VARCHAR(50)
DECLARE cur_indexName CURSOR FOR
SELECT t.name,i.name
FROM sys.indexes i
INNER JOIN sys.tables t ON t.object_id = i.object_id
WHERE Allow_Row_Locks = 0 OR Allow_page_Locks = 0
OPEN cur_indexName
FETCH cur_indexName INTO @tabName, @ndxName
WHILE @@FETCH_STATUS = 0
begin
SET @sql = 'exec sp_indexoption ''' + @tabName + '.' + @ndxName +''', '+ '''AllowRowLocks'''+ ', TRUE'
--PRINT @sql
EXEC sp_executesql @sql
SET @sql = 'exec sp_indexoption ''' + @tabName + '.' + @ndxName +''', '+ '''AllowPageLocks'''+ ', TRUE'
--PRINT @sql
EXEC sp_executesql @sql
FETCH cur_indexName INTO @tabName, @ndxName
END
CLOSE cur_indexName
DEALLOCATE cur_indexName

Jumping in here to say that we would also like to have a global flag like this, since we're running complex scripts of data changes that have internal transaction management in batches to avoid the long locks of a big transaction. It would be great to be able to tell flyway "hey, don't worry, we're adding transactions where needed" globally, without creating conf files per migration. Thanks!


MAPL build produces a blank argument for cmake duirng the build process

Describe the bug
This isn't preventing the build from working, but thought I would submit this issue to help remind us to clean this up. The symptom is that when cmake is run to configure the build for MAPL, a blank argument appears in the cmake command:
cmake '... opt/curl;/opt/homebrew' '' '-DBUILD_WITH_ PFLOGGER:BOOL=ON' '-DBUILD_WITH_FARGPARSE:BOOL=ON' '-DBUILD_SHARED_MAPL:BOOL=ON' '-DUSE_EXTDATA2G:BOOL=ON' '-DUSE_F2PY:BOOL=OFF' '-DCMAKE_MODULE_PATH:STRING=/Users/steveherbener/spack-stack/envs/unified-env.mymacos/install/apple-clang/15.0.0/esmf-8.6.0-arh6774/cmake' '-DCMAKE_Fortran_FLAGS:STRING=-ffree-line-length-none -fallow-invalid-boz -fallow-argument-mismatch' '/Users/steveherbener/spack-stack/cache/build_stage/spack-stage-mapl-2.40.3-7y27wlepvd76j5cvhogy7ey7vskf6xar/spack-src'

Note the empty argument ('') right before the '-DBUILD_WITH_ PFLOGGER:BOOL=ON' argument.
A quick look in the package.py script for MAPL shows:
https://github.com/JCSDA/spack/blob/66e9ce432da4a88fe075b9f9a8c3d4fb5e42da73/var/spack/repos/builtin/packages/mapl/package.py#L253-L260
It seems that the flap variant is not set and then an empty string gets set in the cmake arguments.
To Reproduce
Steps to reproduce the behavior:
set up and build MAPL
Expected behavior
The empty cmake argument is eliminated
System:
What system(s) are you running the code on?
MacOS<EMAIL_ADDRESS>GNU fortran 12.3.0
Additional context
Add any other context about the problem here.

If it's not a problem then send it straight to the icebox :-)

I think I've figured this out and it'll be included in my updated MAPL package when 2.46 (and ESMF 8.6.1) are out.

@mathomp4 Was this just fixed with adding<EMAIL_ADDRESS>?

Yes. I believe this should be fixed by this bit of code:
        # We only want to add BUILD_WITH_FLAP if we are @:2.39 otherwise
        # there is a weird empty string that gets added to the CMake command
        if self.spec.satisfies("@:2.39"):
            args.append(self.define("BUILD_WITH_FLAP", self.spec.satisfies("+flap")))

Though I guess @srherbener will let me know if I got it right next time he builds 😄

Perfect, thanks! Closing.


Digi

For digi errors,
Maybe cache can be purged, not too often, but when the error appears. This way it uses less reousrces but does still work.
Or instead keep no cache since the tokens are very low lasting now :(

And also trying to get digisport not from digi online won't work

Also, since AMINO is now secured :(, a EPG would be useful ig?
I've made a parser to the old amino which shows now & next with a STB-ish UI
program-tv.zip

yeah well unfortunately it doesn't work

also i found when i was scrubing the tv channels id's that digi-online has a epg api like this https://www.digionline.ro/epg-xhr?channelId=30

as for the 401 error seems like i commented out the line that sets a timeout for deleting object with the url and forgot to put it back

thanks for the epg API

yeah well unfortunately it doesn't work

yes it was made for amino

i've found out the hard way that caching the tokens is only useless

yeah well it was intended so it doesn't request a new url on every request but now when i think about it, it doesn't make sense if you don't proxy the segment files.

i actually have a proxy that works with dynamic https://proxy.canale.live/stream.php?url=https://edge213.rcs-rds.ro/V5-1250823-53a43010558f1c3956002a346eeb4182-3111686696-0-1612614844-1-digisport1-0877f7addc73df76/digionline/digisport1hq.stream/media-uz5np4ccq_77123.ts

alright, I'll integrate that right away

the proxy is insxtable tho

what do you mean?

it has a lot of downtime from time to time

de asemenea, digisporturi fara digi online nu merg, nada, nilch

adica?, la mine nu sunt probleme

hmmm, ciudat

dai un pul acuml, commit-ul 0327dbe0eecc2a8ba3b16c6104499cb3deae8355 elimina stocarea url-ului daca nu folosesti parametrul ts

pai si pe TS param TS era problema

cum as putea sa scot cache la TS uri ( ca e inutil, tot aceleasi probleme face )

uite 176fd2f62719d096e9a784e8da3c417a50c9c04f , nu este inutil, este o metoda de precautiune sa nu zica ceva digi ca faci prea multe cereri, daca nu salvez link-ul atunci ar fi echivalentul unui refresh la pagina pe digionline (deci de fiecare data o alta cerere pentru link catre stream)

ah, mersi totusi :)

si oricum, la viata lunga unui token, nici nu cred ca ar fi alta optiune

pai da, a doua zi nu mai poti folosi acelasi base URL, asa ca am pus sa stearga dupa 6 ore

closing the issue as the reported issue has been fixed since


docs(api): fix transfer example to use new_tip='once'

overview
We had a errant new_tip='single' in the API example docs. This PR fixes that line to use the correct new_tip='once'.
Going ahead and calling #357 fixed by this PR
changelog

docs(api): fix transfer example to use new_tip='once'

review requests

Did I miss any other places where this sort of typo slipped in?

I think that ticket is specifically referring to API v1 docs. If you checkout this section there is actually no mention of new_tip='once'


move draft PR tests off ci.deis.io

After the Microsoft acquisition in late April, this infrastructure is currently un-maintained and will eventually go away. We need a new place to host Draft test infrastructure for PRs and for #186.

done. We're now on CircleCI.


Add compat for ColorTypes.jl v0.10, add CompatHelper

Also decrease frequency of TagBot to once per day.
@aviks: v0.1 of this package is compatible with any release in v0.x series of ColorTypes, that's why updating ColorTypes to v0.10 downgraded this package to v0.1 for me

@jonathanBieler bump :slightly_smiling_face:

Thanks, sorry I missed this.


glob broken on Python 3.7

PR #202  introduced using pathlib internals for the glob implementation which make use of the scandir function as a contextlib.contextmanager. Apparently, pathlib used to work differently (expecting scandir to be an iterator directly) before 3.8 so glob essentially doesn’t work for older python versions. I would suggest dropping support as 3.7 has reached end-of-life status.

I think this is a dupe of https://github.com/drivendataorg/cloudpathlib/issues/210, not all 3.7.
0.18.1 is already our last 3.7 supporting release:
https://github.com/drivendataorg/cloudpathlib/blob/master/HISTORY.md?plain=1#L13


Can't get type name when running with ts-jest

Issue :
The code that I'm testing rely on the object class name, and to get the name I use this code:
const sourceKey = object.constructor.name;

and the object definition is:
const object: Login = {
    username: 'username',
    password: 'password'
};

When used with tsc, the value of sourceKey is Login but when I test the code with ts-jest the sourceKey value is Object.
Is this the normal behavior ? Or I'm I missing something.
Expected behavior :
Debug log:

log file content
# content of ts-jest.log :

Minimal repo :

Hi,
I think this is more about basic of typescript and javascript. As far as I work with typescript, it's not possible to get type name (if you define using type or interface). In javascript, constructor.name will always return Object because your object is
const object: Login = {
    username: 'username',
    password: 'password'
};

However, if you create an object via es6 classes, you will get the name of your class. For example
class Foo {
}
console.log(Foo.name) // "Foo"

I forgot to show the Login class, but it's indeed a class.
In fact, my tsconfig has a target of es6 that's why it works event after it's transpiled to JavaScript, but I think that ts-jest is not using my tsconfig file and is transpilig to es5, is there a way to change this ?

Hi,
Please check the documentation for configuration. It's possible to specify the path of your tsconfig for ts-jest 🙂.


training compatibility with RTL languages

thanks for your efforts and i would d like to ask if it is possible to train nougat on different right to left languages like hebrew, arabic, and persian
additionally i believe we would benefit if you can add more information on data preparation and particularly regarding the ideal image sizes and labeling formats :)

@AhmadHakami I am afraid that training Nougat on right-to-left languages such as Hebrew, Arabic, and Persian will have limited performance compared to fine-tuning the latest language model. Although fine-tuning Nougat-LaTex can bring satisfying results on img2latex task, it is because of the strong base model, nougat-base, which has been pre-trained on millions of tokens in science paper reports and has already seen many latex formulas at that stage. What I am doing here with the LaTeX dataset is only to "activate" its corresponding ability.
As for data preparation, I think the most effective method from my practice is to adjust the input resolution and use an adaptive padding approach to ensure that equation image segments in the wild are resized to closely match the resolution of the training data. Please check the processor here.
What is your task BTW?

i'm trying to recognize text in both arabic and english languages within a single image or document similar to the surya model. however there are issues with surya: the training source code is not available and it does not recognize numbers, regulars, and dates in both languages (arabic and english) and its not recognize some other fonts
this example contain arabic content with some english & arabic numbers, dates and regulars:
تمديد المدة الخاصة بتطوير وبناء المنصة لمدة (١٢٠) يوماً إضافياً ابتداء من ١٧/٢/١٤٤٥هـ. وبعد الاطلاع على ضوابط قرار رقم (٥٦٣) وتاريخ 15/8/1444هـ. وبعد الاطلاع على المذكرتين رقم (٨٤٩) وتاريخ ١١/٣/١٤٤٥هـ ، ورقم (١٠٥٣) وتاريخ ٢٧/٣/١٤٤٥هـ ، المعدتين في الهيئة، وبعد الاطلاع على المحضرين المعدين برقم (٥٤٢/٤٥/م) وتاريخ [ ١٥/٣/١٤٤٥هـ ]، ورقم (٦٥٣/٤٥/م)

@AhmadHakami Looks like an OCR task. It is hard to find a good open-source text recognition model for Arabic. My suggestion is to train one with Arabic data.
A simple roadmap.
Text Detection: check out DBNet. It is a good and easy to train according to my experience.

Data Preparation: You can start with open checkpoints of DBNet and fine-tune with some Arabic documents. Fine-tuning doesn't need too much data, ~1k is enough I guess.

Text Recognition: You may want to start with CRNN, a classical text recognition model.

Data Preparation: You'll need about 50k image segments cropped from document text lines, each paired up with the actual text for training your recognition model. There are some open-source datasets, please check this repo; However, finding Arabic datasets / open-source CRNN checkpoints might be a bit hard. I suggest making sure more than 50% of your training dataset is in Arabic.

Hope this can help. Feel free to ask me if you have any questions.

after finishing the finetuning i found all the weights in this directory nougat-latex-ocr/workspace/nougat_latex and all of them in zip format and when i extracted the files from one of the zip files i found a long-name folder in it containing:
1. three files: byteorder, data.pkl, version
2. data folder: containing many files named with numbers: 1, 2, 3, 4, ...
how can i predict using the run_latex_ocr python file using the finetuned weights?

@AhmadHakami there should be a *.pth fille under the workspace folder

the same problem:
OSError: Incorrect path_or_model_id: 'workspace/nougat-base_epoch3_step260000_lr1.870306e-05_avg_loss0.06036_token_acc0.51288_edit_dis0.10794.pth'. Please provide either the path to a local folder or the repo_id of a model on the Hub.
this is the .pth file if you could try it on your machine

@AhmadHakami  Please try the following script
model_name = "Norm/nougat-latex-base"
checkpoint_path = "./workspace/nougat-base_epoch3_step260000_lr1.870306e-05_avg_loss0.06036_token_acc0.51288_edit_dis0.10794.pth"  # this is your fine-tuned checkpoint
device = "cuda" if torch.cuda.is_available() else "CPU"

# Initialize the model
model = VisionEncoderDecoderModel.from_pretrained(model_name).to(device)

# load the model weight
state_dict = torch.load(checkpoint_path, map_location=torch.device("cpu"))
model.load_state_dict(model_state_dict, strict=strict)

it works with model.load_state_dict(state_dict, strict=True)
thank you life saver :)


cannot compile non-adafruit oled code with arduino 1.6.8

Hey im trying to compile the non adafruit display version and I keep getting this error, any advise?
"C:\Program Files (x86)\Arduino\tools-builder\ctags\5.8-arduino10/ctags" -u --language-force=c++ -f - --c++-kinds=svpf --fields=KSTtzns --line-directives "C:\Users\Vlad\AppData\Local\Temp\build63c49c85898a371be4a35fbd0f3cefff.tmp\preproc\ctags_target_for_gcc_minus_e.cpp"
Using previously compiled file: C:\Users\Vlad\AppData\Local\Temp\build63c49c85898a371be4a35fbd0f3cefff.tmp\sketch\TVOut_screens.cpp.o
Using previously compiled file: C:\Users\Vlad\AppData\Local\Temp\build63c49c85898a371be4a35fbd0f3cefff.tmp\sketch\oled_128x64_adafruit_screens.cpp.o
"C:\Program Files (x86)\Arduino\hardware\tools\avr/bin/avr-g++" -c -g -Os -w -std=gnu++11 -fno-exceptions -ffunction-sections -fdata-sections -fno-threadsafe-statics -MMD -mmcu=atmega328p -DF_CPU=16000000L -DARDUINO=10608 -DARDUINO_AVR_PRO -DARDUINO_ARCH_AVR   "-IC:\Program Files (x86)\Arduino\hardware\arduino\avr\cores\arduino" "-IC:\Program Files (x86)\Arduino\hardware\arduino\avr\variants\eightanaloginputs" "-IC:\Program Files (x86)\Arduino\hardware\arduino\avr\libraries\EEPROM\src" "-IC:\Users\Vlad\Documents\Arduino\libraries\U8glib\src" "-IC:\Users\Vlad\Documents\Arduino\libraries\TVout" "-IC:\Users\Vlad\Documents\Arduino\libraries\TVoutfonts" "C:\Users\Vlad\AppData\Local\Temp\build63c49c85898a371be4a35fbd0f3cefff.tmp\sketch\oled_128x64_u8g_screens.cpp" -o "C:\Users\Vlad\AppData\Local\Temp\build63c49c85898a371be4a35fbd0f3cefff.tmp\sketch\oled_128x64_u8g_screens.cpp.o"
oled_128x64_u8g_screens.cpp:53: error: prototype for 'char screens::begin()' does not match any in class 'screens'
char screens::begin() {
  ^

In file included from C:\Users\Vlad\AppData\Local\Temp\build63c49c85898a371be4a35fbd0f3cefff.tmp\sketch\oled_128x64_u8g_screens.cpp:39:0:
screens.h:50: error: candidate is: char screens::begin(const char*)
     char begin(const char *call_sign);

          ^

oled_128x64_u8g_screens.cpp:116: error: prototype for 'void screens::updateSeekMode(uint8_t, uint8_t, uint8_t, uint8_t, uint16_t, bool)' does not match any in class 'screens'
void screens::updateSeekMode(uint8_t state, uint8_t channelIndex, uint8_t channel, uint8_t rssi, uint16_t channelFrequency, bool locked) {
  ^

In file included from C:\Users\Vlad\AppData\Local\Temp\build63c49c85898a371be4a35fbd0f3cefff.tmp\sketch\oled_128x64_u8g_screens.cpp:39:0:
screens.h:58: error: candidate is: void screens::updateSeekMode(uint8_t, uint8_t, uint8_t, uint8_t, uint16_t, uint8_t, bool)
     void updateSeekMode(uint8_t state, uint8_t channelIndex, uint8_t channel, uint8_t rssi, uint16_t channelFrequency, uint8_t rssi_seek_threshold, bool locked); // seek and manual mode

          ^

C:\Users\Vlad\AppData\Local\Temp\build63c49c85898a371be4a35fbd0f3cefff.tmp\sketch\oled_128x64_u8g_screens.cpp: In member function 'void screens::updateBandScanMode(bool, uint8_t, uint8_t, uint8_t, uint16_t, uint16_t, uint16_t)':
oled_128x64_u8g_screens.cpp:135: error: 'SCANNER_LIST_X_POS' was not declared in this scope
 static uint8_t writePos=SCANNER_LIST_X_POS;

                         ^

C:\Users\Vlad\AppData\Local\Temp\build63c49c85898a371be4a35fbd0f3cefff.tmp\sketch\oled_128x64_u8g_screens.cpp: At global scope:
oled_128x64_u8g_screens.cpp:139: error: prototype for 'void screens::screenSaver(uint8_t, uint16_t)' does not match any in class 'screens'
void screens::screenSaver(uint8_t channelName, uint16_t channelFrequency) {
  ^

In file included from C:\Users\Vlad\AppData\Local\Temp\build63c49c85898a371be4a35fbd0f3cefff.tmp\sketch\oled_128x64_u8g_screens.cpp:39:0:
screens.h:66: error: candidates are: void screens::screenSaver(uint8_t, uint8_t, uint16_t, const char*)
     void screenSaver(uint8_t diversity_mode, uint8_t channelName, uint16_t channelFrequency, const char *call_sign);

          ^

screens.h:65: error: void screens::screenSaver(uint8_t, uint16_t, const char*)
     void screenSaver(uint8_t channelName, uint16_t channelFrequency, const char *call_sign);

          ^

oled_128x64_u8g_screens.cpp:142: error: prototype for 'void screens::screenSaver(uint8_t, uint8_t, uint16_t)' does not match any in class 'screens'
void screens::screenSaver(uint8_t diversity_mode, uint8_t channelName, uint16_t channelFrequency) {
  ^

In file included from C:\Users\Vlad\AppData\Local\Temp\build63c49c85898a371be4a35fbd0f3cefff.tmp\sketch\oled_128x64_u8g_screens.cpp:39:0:
screens.h:66: error: candidates are: void screens::screenSaver(uint8_t, uint8_t, uint16_t, const char*)
     void screenSaver(uint8_t diversity_mode, uint8_t channelName, uint16_t channelFrequency, const char *call_sign);

          ^

screens.h:65: error: void screens::screenSaver(uint8_t, uint16_t, const char*)
     void screenSaver(uint8_t channelName, uint16_t channelFrequency, const char *call_sign);

          ^

oled_128x64_u8g_screens.cpp:163: error: prototype for 'void screens::save(uint8_t, uint8_t, uint16_t)' does not match any in class 'screens'
void screens::save(uint8_t mode, uint8_t channelIndex, uint16_t channelFrequency) {
  ^

In file included from C:\Users\Vlad\AppData\Local\Temp\build63c49c85898a371be4a35fbd0f3cefff.tmp\sketch\oled_128x64_u8g_screens.cpp:39:0:
screens.h:79: error: candidate is: void screens::save(uint8_t, uint8_t, uint16_t, const char*)
     void save(uint8_t mode, uint8_t channelIndex, uint16_t channelFrequency, const char *call_sign);

          ^

Using library EEPROM at version 2.0 in folder: C:\Program Files (x86)\Arduino\hardware\arduino\avr\libraries\EEPROM
Using library U8glib at version 1.19.1 in folder: C:\Users\Vlad\Documents\Arduino\libraries\U8glib
Using library TVout at version 1.0.1 in folder: C:\Users\Vlad\Documents\Arduino\libraries\TVout
Using library TVoutfonts in folder: C:\Users\Vlad\Documents\Arduino\libraries\TVoutfonts (legacy)
exit status 1
prototype for 'char screens::begin()' does not match any in class 'screens'

u8g library was never completed due to library limitations.

Good to know, might be worth taking it out from the codebase in master.


compat.py: Ensure Python is >= v3.8

https://pypi.org/project/flake8-2020 says...
./python-package/xgboost/compat.py:13:8: YTT201 `sys.version_info[0] == 3` referenced (python4), use `>=`
assert sys.version_info[0] == 3, "Python 2 is no longer supported."
       ^

I don't think this is necessary, since we already require a specific Python version in setup.py:
https://github.com/dmlc/xgboost/blob/28a466ab518fbb1fccef777bf4efb0b9d8c79514/python-package/setup.py#L373

Python 4 would pass the setup.py test but fail the compat.py test.

We'll come back to this when Python 4 is  released.


All documentation out of date and fully incomplete

Brief Description
is this project even maintained?
all documentation seems to be out of date to some degree and completely lacking.
wiki and files under docs/ are out of sync.
there are also no comments that could lead me anywhere. function naming doesnt seem this projects strong suit either.
Examples dont build.
My example which tries to follow the very lacking GeneratingBindings.md runs outputs all kind of things to the console but no target file ever gets generated. But there is aboslutely nothing that helps me find out why since thats all the documentation seems to say about it.
OS: Windows / OS X / Linux (include version and/or distro)
Used headers

Used settings

Target: MSVC/GCC/Clang
Other settings
Stack trace or incompilable generated code

is this project even maintained?

As you can see we have PRs being merged as recent as a few days ago.

all documentation seems to be out of date to some degree and completely lacking.

Please file an issue about which sections are out of date, and what you find lacking and maybe we can improve it.

wiki and files under docs/ are out of sync.

This is from the main wiki page: The Wiki is outdated! Please use the docs inside the repository instead.
I am sorry you are not having a good experience, but overall you are coming across as just complaining.
Remember this is an open source project, we are not getting paid for anything.
Anyone is free to help improve the project by sending PRs.
Feel free to open other issues with some more concrete issues you are facing or suggestions.

Please file an issue about which sections are out of date, and what you find lacking and maybe we can improve it.
lol literally everything.
and yes i am complaining since i have a hard time understanding the level of incompetence at play here


Raise warning about saving nn.Module in save_hyperparameters earlier

Proposed refactor
Raise warning about saving nn.Module in save_hyperparameters earlier
Motivation
We have a warning when a user tries to "save" a nn.Module as hyperparameter here:
https://github.com/Lightning-AI/lightning/blob/8e83bfafcd92793910a76bbc41c58a91393da6fd/src/pytorch_lightning/utilities/parsing.py#L264-L267
This is to avoid redundantly big checkpoints and undesired behavior. The warning however is emitted after the deepcopy, and this can create memory issues or hangs and the warning will never be shown.
Pitch
Move the warning up so we can emit it earlier.
Additional context
Reported by user via social media.

If you enjoy Lightning, check out our other projects! ⚡

Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging PyTorch Lightning, Transformers, and Hydra.

Hi! Thank you for creating the issue out of a tweet!
Here is a collab showing my issue. Interesting, sending a small nn.Module to the constructor will not reproduce the hanging part of the issue. Also, in collab, the "saving nn.Module" warning is shown.
Unfortunately the machine where I work is not available right now, to check if this was shown. 100% possible to missed it!
https://colab.research.google.com/drive/19pbWe2LduqLRiGG64iVGpe2zp4Vitzuw?usp=sharing
Hope it helps!

@cristi-zz Thanks a lot. I confirm this is reproducible, and the warning is shown as expected. The program seems to hang when TensorBoard attempts to dump the hparams into a file here: https://github.com/Lightning-AI/lightning/blob/5dd7b6a4787819f12758a7d68d6c0cfdbed405c2/src/pytorch_lightning/core/saving.py#L405
I suppose yaml is not efficient in serializing the "big" resnet module. I'm sure it would eventually end or error out, but it will take a while. Not sure what we can do here except continue to show the warning. Perhaps a timeout?

Thanks for looking into it! I doubt much can be done, except maybe a stronger lettered warning? I believe there are legitimate use cases when one would like to save a nn.Module. None cross my mind right now.

Yes agree. A simple use case could be a loss function, implemented as an nn.Module with no parameters.


[Event Request] Codeunit 21 Item Jnl.-Check Line - OnOutputQuantity

Hi, would it be possible to get an event OnOutputQuantity in codeunit 21 Item Jnl.-Check Line, like this :

?
Thanks

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Bugs found in testing asar (running list)

option to name directory for output would be nice - I tried running this on server R and got interesting results - the default location will only work for windows machines with directories that match IMO using the current wd would be better.

example should load the parameter files, or at least the report.sso from "simple" SS3 example (I think that is the intended example file)

requires functions from satf (suggest adding remotes::install_github("nmfs-ost/satf") to readme

maybe add require("satf") somewhere? there are several references to satf functions from within the other satf functions that aren't receded by satf::  or satf::: that cause errors otherwise.

bugs in satf::table_indices
flextable::add_header_row(top = TRUE, values = c(
        "", rep(ind_fleets, each = 2))
      )

lacks the colwidths argument which causes an error  - I am not sure how to fix this - one I tried
 flextable::add_header_row(top = TRUE
          ,values = c("", rep(intersect(ind_fleets,fleet_names), each = 2))
          ,colwidths = c(1,rep(2,length=length(ind_fleets)))
      )

but this does not put the header in the correct place
bugs in satf::plot_spawning_biomass
the first line
model <- match.arg(model, several.ok = FALSE)
causes an error because the call to the function redefines model from the vector of possible values to 'SS3'. I think this needs an argument
choices= c('SS3','BAM', 'ASAP', 'AMAK', 'WHAM', "standard")
or some way to make this the default? I am not sure what you are going for here, but it throws an error for me.
I think you need to add
else endyr=end_year
in several places. For example line 68 - basically anywhere that
if (is.null(end_year)){
is tested.

@DHennen1 thanks for testing the tool Dan! I have addressed your first bullet by designating the output directory to the user's working directory with the option of changing it using the parameter file_dir.  I have also added the direction to install the satf package in the readme (third bullet).
In regards to the remaining bullets,
"example should load the parameter files, or at least the report.sso from "simple" SS3 example (I think that is the intended example file)"
The example is a generic input of a SS3 report file with no linked example. The current blank template or example does not actually use or convert the data. I am in the works of changing this chunk in the base template.
https://github.com/nmfs-ost/asar/blob/d9b69a1912f36a127e8d52dd69ef93f9f475f662/R/create_template.R#L466-L487
I plan to upload a full working example with what should be produced in the next week that will be reflected in the example in the README.
"Bugs in SATF [functions]"
satf is still in the beginning stages of development and I have recently had to make changes with how it worked specifically for SS3 output files. Thank you for pointing out these bugs. I am going to open a new issue in the satf repo describing these bugs.


Add a Zign ResourceTokenProvider extension

It would be useful to have an extension jar that supported fetching Zign tokens

added in #44


Disk resize

Fixes: Issue #127
Solution/Idea
This uses the machine driver's "UpdateConfigRaw" API introduced in the previous release in order to implement disk resizing support. This needs machine driver support as well.
Proposed changes
List main as well as consequential changes you introduced or had to introduce.

Added --disk-size argument to the start command.
Added 'disk-size' config key

disk size is always in GiB<PHONE_NUMBER>24 bytes) and can't be less than 31 GB as this is the size used by our bundles, and disks can't be shrunk.
Testing
What is the bottom-line functionality that needs testing? Describe in pseudo-code or in English. Use verifiable statements that tie your changes to existing functionality.

start without any argument/special configuration succeeds
crc start --disk-size xxx succeeds and resizes the disk
crc start succeeds after crc config set disk-size xxx
in both cases, disk is resized (can be checked with ssh ... df -h, or on linux through virsh vol-info crc.qcow2 crc)

For now this is not supported on macos
6. start fails after start succeeded or after status says CRC is Running
7. ...

@cfergeau can you describe clearly for @kowen what is supported and what not? This needs to be part of the release note,s. But let's also consider to actually document this. Can this be a follow PR?

@cfergeau can you describe clearly for @kowen what is supported and what not? This needs to be part of the release note,s. But let's also consider to actually document this. Can this be a follow PR?

The machine PR https://github.com/code-ready/machine/pull/48 adds support for disk resize on Windows (though I haven't retested it recently). The machine-driver-libvirt PR adds support on linux https://github.com/code-ready/machine-driver-libvirt/pull/68
hyperkit won't be supported for now, the hyperkit machine driver needs to be updated to use the latest version of https://github.com/moby/hyperkit/tree/master/go to get resizing support https://github.com/moby/hyperkit/commit/7e0fa508edd58db99f011f14a59c09ba1fd4f4a2
This PR description https://github.com/code-ready/crc/pull/1607#issue-506926874 has a user-level explanation regarding how to use it. Disk size is specified in GiB, though this can easily be changed to GB if more user friendly.

/retest


remove proxy limit from loader, avoid proxy error in egg-mock/bootstr…

…ap's app

Checklist

[x ] npm test passes
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added
[ ] commit message follows commit guidelines

Affected core subsystem(s)

Description of change

can easyly been used in egg unitest
const sequelize_load = require('egg-sequelize/app');
let {app} = require("egg-mock/bootstrap");

before(()=>{
  sequelize_load(app);  //would raise cannot proxy 'model' attribute before
});

用法错了， egg-mock/bootstrap 中的 app 不应该再sequelize_load(app);


set SMB target port bug fix

when reading settings file, properly apply target smb port (user set target smb port was applied to the master)

the error in code occured on your yesterday commit, just spotted it
can you also adapt the DEFAULT list [] to order the items ?
I will test the GUI and report back about your last commit
👍

I merged your changes.

👍


Type Guards and CallBack Parameters are any, if worked, could successfully defined a callback type and respective guard

TypeScript Version<EMAIL_ADDRESS>Two bugs in one, if both of these issues work, I would be able to properly defined a callback type function call signature overloads and a type guard to go with it.

CallBack, Type Guards with extends fails, CallBack with overloads signatures types become any type, instead of union of their respective params.
Issues

Callback types params with methods overloading are always any type, should be respective union of each parameters types.
Type Guards for more complex type guards doesn't work.

Summary
If all of this were to work, I would be able to correct write a typescript type for a callback with its associated type guard.
1. CallbackTypes are not correctly computed, which expected to be a union of the respective overloads params.
// function call signatures.
interface CallBack<T>
{
    () : void
    (error : Error) : void
    (error : undefined, result : T) : void
    (error : null, result : T) : void
}

function takeCallBack(callback: CallBack<number>)
{
    callback();
    callback(null, {A:77});
    callback(new Error(''));
}

//Fails to determine which function signature was used to call, because it could have been any of the //formats. The final format is an any type. It would be nice to  be able to write a type guard

//[ts] 'result' is declared but its value is never read.
//[ts] Argument of type '(error: any, result: any) => void' is not assignable to parameter of type 'CallBack<number>'
takeCallBack((error, result) => {

});

Expected, however, this is not enough information us to write a proper type guards
and we have also lost information about the results, which is the most important.
we need to be able to distinguish between T and T | undefined.
takeCallBack((error : Error | undefined | null, result : T | undefined) => {

});

CallBack type formulation
The only was to be able to do this, without having complicate solution, by means on inspection the body of the the function in which the callback is call to determine or infer the variants. Would be to break the callback definition into three.
Callback A:
interface CallBackError<T>
{
    () : void   // sucessfully, results undefined
    (error : Error) : void  // Error
}

function takeCallBackNoResults(callback: CallBackError<number>)
{
    callback();
    callback(new Error(''));
}

//[ts] 'results' is declared but its value is never read.
//[ts] Argument of type '(error: any, results: any) => void' is not assignable to parameter of type 'CallBackError<number>'.
takeCallBackNoResults((error,results) => {

});

takeCallBackNoResults((error : Error,results : undefined) => {

});

I can now write a guard statement for this, to ensure a clean output of results, however, in this case I shouldn't need it.
CallBack B:
Here I can use the null permutation of error, to determine
interface CallBackResult<T>
{
    (error : null, res : T) : void
    (error : Error) : void
}
function takeCallBackResults(callback: CallBackResult<number>)
{
    callback(null, 6);
    callback(new Error(''));
}

//[ts] 'results' is declared but its value is never read.
//[ts] Argument of type '(error: any, results: any) => void' is not assignable to parameter of type 'CallBackResult<number>'.
takeCallBackResults((error,results) => {

});

takeCallBackResults((error : Error | null,results : number | undefined) => {

});

I can't write a guard for this, but would be nice if I didn't need it in the first place, but there is now getting around that.
Callback C:
interface CallBackOpResult<T>
{
    () : void
    (error : null, res : T) : void
    (error : Error) : void
}
function takeCallBackOpResults(callback: CallBackOpResults<number>)
{
    callback();
    callback(null, 5);
    callback(new Error(''));
}

//[ts] 'results' is declared but its value is never read.
//[ts] Argument of type '(error: any, results: any) => void' is not assignable to parameter of type 'CallBackError<number>'.
takeCallBackOpResults((error,results) => {

});

takeCallBackNoResults((error : Error | null | undefined,results : number | undefined) => {

});

I can't write a guard for this, but would be nice if I didn't need it in the first place, but there is now getting around that. Because we have to now do an unnecessary check for undefined, when results mayn't have support undefined in the first place.
CallBack - Conclusion on how to write the final form
What we are not able to distinguish here is that, is whether results would be a plain T or meant to tbe T | undefined. This is a problem, the only way we able to to really know that is if error and results parameters could be treated as one and a set. I can write a type gaud, have knowledge of this already, to check for the 3 cases, but I will always have to check for undefined
What I could do is use the fact that error being of type null, means that results shouldn't have the undefined, I could strip it, but I wouldn't be able know difference of which results still
If I decided to not allow undefined error, for default case of no results I could be able to write a gaud check that would work, based on the input of error being null or not.
interface CallBackOpResult<T>
{
    () // error = undefined, results = undefined
    (error : null, res : T) : void
    (error : Error) : void
}

function takeCallBackOPResults(callback: CallBackOpResults<number>)
{
    callback();
    callback(null, 5);
    callback(new Error(''));
}

//[ts] 'results' is declared but its value is never read.
//[ts] Argument of type '(error: any, results: any) => void' is not assignable to parameter of type 'CallBackOpResults<number>'.
takeCallBackOpResults((error,results) => {

});

Simple Use of Type Guard:
takeCallBackNoResults((error : Error | null, results : number) => {

    if(!CallBackHasResults(error, results))
        console.log(error);// handle error
    else
    {
        results
    }
});

Type Guards Failed:

function CallBackHasResults1<Err extends undefined | null | Error, Result>(error : Err, results : Result) : results is undefined | Result
function CallBackHasResults1<Err extends null | Error, Result>(error : Err, results : Result) : results is Result
{
    return error !== null && error !== undefined;
    //return results;
}

// Fails to work correctly:
const callBack = (error : Error | null | undefined, results : number |undefined) => {

    if(!CallBackHasResults1(error, results))
        console.log(error);// handle error
    else
    {
        results // expect type = number | undefined
    }
}

// Fails to work correctly.
const callBack2 = (error : Error | null, results : number | undefined) => {

    if(!CallBackHasResults1(error, results))
        console.log(error);// handle error
    else
    {
        results // expect type = number
    }
}

The alternative would be to introduce a compound type for callbacks, were by both error and Results are used to dictate the output format, which I have achieved here by doing this manual.
Another alternative, using the this parameter, which may work if the overloads function parameters unioned correctly.
interface CallBackOpResult2<T>
{
    () // error = undefined, results = undefined
    (error : null, res : T) : void
    (error : Error) : void
}

interface TT<T> {
    callback : CallBackOpResult2<T>
}

function takeCallBackResults3(callback: TT<number>['callback'])
{
    //this = {a : 'a'}
    callback();
    callback(null, 5);
    callback(new Error(''));
}

//[ts] 'results' is declared but its value is never read.
//[ts] Argument of type '(error: any, results: any) => void' is not assignable to parameter of type 'CallBackError<number>'.
takeCallBackResults3((error,results) => {

});

takeCallBackNoResults3(function (error, results) {

    if(!CallBackHasResults3(error, results))
        console.log(error);// handle error
    else
    {
        results
    }
});

function CallBackHasResults3<T extends {callback:any},Err extends undefined | null | Error, Result>(this : T, error : Err, results : Result) : results is undefined | Result
//function CallBackHasResults3<Err extends null | Error, Result>(this : {a:'a'}, error : Err, results : Result) : results is Result
{
    return error !== null && error !== undefined;
    //return results;
}

Ghosts Type
The other alternative is that in each of the variants of CallBack function signatures I can union
the error parameter with a string literals that would identify the the CallBack variant in use by union each overload error with string literal identifier.
I could then use type inspection, to check for the Error** | '____NoResults' or Error** | '___ResultsOnly or explicitly undefined,  in which I would know the input formats, so I know which output format to produce when using a gard.
One could look at introducing a Ghost type, for call backs, which is just used to identified callback function signature formats. This ghost type could be defined in the this part of the function signature and when removed would be any type of what every type it was unioned with.
ghost('noResults') | Error **
An any type should not consume a ghost type,ghost type compound operator on with any,
should remain no simplified as any | ghost() type.
interface CallBackOpResult2<T, ID = ghost('opResults')>
{
    (this : ID) // error = undefined, results = undefined
    (this : ID, error : null, res : T) : void
    (this : ID, error : Error) : void
}

I struggled to follow some of the details, so sorry if I misunderstand you. What is wrong with writing this:
takeCallBack((error?: Error | undefined | null, result? : number | undefined) => {

});

This doesn't produce any errors for me.

which is the most important. we need to be able to distinguish between T and T | undefined.

Unless you constrain T in some form, I'm not sure there is a difference. T could be any type, so saying it's any type or undefined doesn't seem any different me. I could well be wrong/confused here.


fix ci: came back unit and coveralls

Description of the change:
The unit test and coveralls should not be removed.

They just moved to here: https://github.com/operator-framework/operator-sdk/blob/master/.travis.yml#L136


Update documentation for Soroban transactions

This updates reflects the state of the current release, so it would be nice to get it merged into main.

Preview is available here:http://soroban-docs-pr251.previews.kube001.services.stellar-ops.com/

@dmkozh We should merge into main not dev, so this change is reflected publicly.

Preview is available here:http://soroban-docs-pr251.previews.kube001.services.stellar-ops.com/


Add experimental support for bitbucket cloud

I still have some todos left, so this is still a draft pull request. :)

Sorry for the merge conflicts 🙈
Do you need any help with this?

No help needed, mostly the time is missing ;)


feat: Add python solution for euler#53

wait, the pull request title says "Add python solution for euler#53", but this is the solution for 52. Was that a mistake?

I'll submit a new PR if that's okay. Let me know @mre.

Yeah, if you have the time and you'd like to do it sure, go ahead. 👍


Better conditions for between

Add documentation for between and handle the conditions where the two bookends are the same and the if there is no text between the bookends. Updated tests.

Looks good. Thanks @Abizern !


Dashed Underline

[ y] I agree to follow the Code of Conduct that this project adheres to.
[y ] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Is your feature request related to a problem? Please describe.
In many CS courses, Entity Relationship Diagrams (ERD) are made at the beginning of database courses.
In these ERD diagrams, weak entity sets with partial keys require the attributes that are part of the partial key to be underlined with a dashed line. As this is common across many Computer Science programs, it may be a worthy pursuit to resolve.
Describe the solution you'd like
An option to alter the underline of text (as if it were a line). Or a weak entity set attribute shape templet/preset.
Describe alternatives you've considered
Drawing and placing the line, although consistency is difficult.
Additional context
N/A

Hi,
at the moment it is not possible to do that in UI, but you could try the following in order to insert a dashed underline:
click </> button in the toolbar and add e.g.
Test
If this is not what you are looking for, feel free to attach an example.


[Feature Request] Maybe add artisan table cart as well?

As stated in the title.

Probably won't be adding this until they add a use for that table.


how-to-attend: add pages based on recent online workshops

[draft until the sphinx stuff is accepted, then needs TOC linking]

how-to-attend-online: how to successfully take part online.
how-to-attend-inperson: same, but for inperson
Copied from mega-CR and Finland HPC kickstart general information
and lessons learned.
This is not designed to replace installation instructions, but more
general mental and physical preparation.  Should this me moved to
installation instructions sometime?
To review: deserves a detailed reading to make sure things are what
we agree on, typographical errors, and to ensure it general positive
message and doesn't demotivate people.

Should I take care of the TOC part and finishing up this PR?

updated and ready to go


Multiple Resource View

Hey,
A calendar with multiple Resources would be nice.
Something like this
https://dhtmlx.com/docs/products/dhtmlxScheduler/sample_units.shtml

Duplicate of #28
Thanks for the nice visual example! I'll add it to the parent task and close this one.


Flatline Rule going off when there is data

Hi, I have been having some issue with a flatline rule that I wrote for one of my indexes.
Here is the rule:
es_host: $ES_HOST
es_port: $ES_PORT
name: rule_name
type: flatline
index: index_name
timestamp_field: "date_event"
realert:
   hours: 4
threshold: 1
timeframe:
   hours: 8
filter:
   - term:
      _type: "windows_firewall_event"
slack_webhook_url: $SLACK_WEBHOOK_URL
alert:
   - slack

But when I check Kibana every time I see data, so then I actually captured the get request as the rule was being run just to see what query the rule actually runs, here is what I found:
{"sort":
  [
    {"date_event":
    {"order": "asc"}
      }
    ],
    "query":
    {"bool":
      {"filter":
        {"bool":
        {"must":
          [
            {"range":
              {"date_event":
                {"gt": "2018-01-03T20:11:08.077692Z", "lte": "2018-01-03T20:20:08.894815Z"}
              }
            },
             {"term":
              {"_type": "windows_firewall_event"}
           }
          ]
        }
      }
    }
   }
}

Then I ran that same query for each time stamp the flatline alert on and every time I saw data.
Not sure why the rule is going off when there is data in the index.
Any help would be appreciated.
p.s. - the variables in the rule get changed (with an external script) before the rule is placed into the rules folder

I'm seeing the same behavior :/

https://github.com/Yelp/elastalert/issues/2162#issuecomment-470644784