Deployment doesn't zip files filtered by files.exclude setting if there is no .funcignore file (v1.13.3)

We have the following directory structure:
build/
  azure/
    host.json
    my-function/
      function.json
      index.js

and this in .vscode/settings.json:
  "azureFunctions.projectLanguage": "JavaScript",
  "azureFunctions.deploySubpath": "build/azure/",

Deploying with v.1.13.2 obviously destroyed our deployment, due to #3969 and v1.13.3 seems to be at least looking in the right directory. However, critically, it now seemingly ignores the index.js file. Output from Azure Functions in VSCode:
10:38:02 AM test-my-function: Starting deployment...
10:38:02 AM test-my-function: Creating zip package...
10:38:02 AM test-my-function: Adding 3 files to zip package...
10:38:02 AM test-my-function: c:\Users\...\Source\my-function\build\azure\local.settings.json
10:38:02 AM test-my-function: c:\Users\...\Source\my-function\build\azure\host.json
10:38:02 AM test-my-function: c:\Users\...\Source\my-function\build\azure\my-function\function.json
10:38:02 AM test-my-function: Zip package size: 981 B
10:38:06 AM test-my-function: Updating submodules.
10:38:06 AM test-my-function: Preparing deployment for commit id '86...0f'.
10:38:06 AM test-my-function: Skipping build. Project type: Run-From-Zip
10:38:07 AM test-my-function: Skipping post build. Project type: Run-From-Zip
10:38:07 AM test-my-function: Triggering recycle (preview mode disabled).
10:38:07 AM test-my-function: Deployment successful.
10:38:21 AM test-my-function: Syncing triggers...
10:38:23 AM test-my-function: Querying triggers...
10:38:25 AM test-my-function: No HTTP triggers found.

981B zip file doesn't look good, and the "Code + Test" tab in the Portal confirms that only the function.json file is in the function folder.

Do you happen to have a .gitignore file in your directory? I can't really think of any reason why your function.json file is getting added to the zip file, but not the index.js if they are in the same folder.

Of course, I have a .gitignore ☺ Why do you ask?

We don't have a .funcignore (since we have the build output in a separate folder), if that's what you mean. Did you reintroduce the bug where .gitignore is confused for .funcignore?

Oops, haha yeah, you're right, I meant .funcignore. As far as I know, that bug has not been reintroduced 😅
The relevant code for acquiring files to zip is right here: https://github.com/microsoft/vscode-azuretools/blob/main/appservice/src/deploy/runWithZipStream.ts#L136-L149 (ignore the name of the function, it is using the .funcignore path for this). Really not sure why it's totally ignoring the index.js. I'll try to see if I can reproduce this.
Just to confirm, this was working prior to v1.13.2?

Yeah, was also looking at this, on the surface it looks OK... though the test coverage could probably be improved 😅
Yes, it was working fine up to and including v.1.13.1. Also, to be clear, we're not using any zipGlobPattern or zipIgnorePattern, but we are using files.exclude in .vscode/settings.json to hide both the build folder and any .js files.

This was some good insight.

we are using files.exclude in .vscode/settings.json to hide both the build folder and any .js files.

From vscode API documentation:

@param exclude  A glob pattern that defines files and folders to exclude. The glob pattern
* will be matched against the file paths of resulting matches relative to their workspace. When undefined, default file-excludes (e.g. the files.exclude-setting
* but not search.exclude) will apply. When null, no excludes will apply.

Seems like the fix for us is to pass in null when we do not detect any funcignore file (or an empty one).
Sorry for the inconvenience, but the workaround right now seems like is to remove that files.exclude for the .js files.

though the test coverage could probably be improved 😅

sigh definitely agree with you there. It's part of our tech debt, but feels like we can't pay off the interest fast enough sometimes.

@kristoffer-zliide Totally understandable.  We are planning another release soon.
Would it be possible for in the meantime for you to have a .funcignore file wherever the deploy subpath is? It doesn't need anything meaningful, just some value that wouldn't return falsey/undefined and thus invoke VS Code's default behavior of using files.exclude setting when undefined is passed in.

Sorry, don't really see the difference between adding a dummy file or making a dummy modification to a file.

@kristoffer-zliide Yeah, I see your point. Our current release plan is to ship the extension end of next week, but I can build you a custom vsix with the fix that you can install manually.
Let me know if you'd prefer the custom vsix solution.


Handle when black times out formatting on save

Environment data

VS Code version: 1.28.2
Extension version (available under the Extensions sidebar): 2018.9.2
OS and version: Windows 10
Python version (& distribution if applicable, e.g. Anaconda): Miniconda Python 3.7
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
Relevant/affected Python packages and their versions: black 18.9b0

Actual behavior
When black fails to format on save due to timeout, there is no message in the output window, indicating this is the reason for not formatting the document.
Expected  behavior
When black fails to format on save due to timeout, it would be useful to see some kind of warning about this in the output window. Not only in the developer tools console.
Steps to reproduce:

Set "python.formatting.provider": "black", "editor.formatOnSave": true and save a large Python script (mine was 712 pep8-compliant rows).
Save

Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
Starting Jedi Python language engine.

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)
WARN Aborted format on save after 750ms

Extra note
As a solution to the fact that black doesn't format a big file, increase the default "editor.formatOnSaveTimeout": 750 to a larger value in settings.json.
However, this issue is not about that, but rather the fact that it took me hours 🤕 to figure out WHY black was not formatting on save, as I was unaware of the developer tools console.

Sorry about the time it took to diagnose. 😞 We know we need to add more debugging information in the extension.

Hey @brettcannon no worries. I failed to explain "it took me hours" to figure this one out but also get set up with black as a whole in a large project. So, to be fair, it sounded worse than it was from that sentence. Sorry about that. But I anticipate that if black will timeout this easily, lots of users may start thinking something's wrong and spam you with issues here in github (like I do). :wink:
Thanks again for your tremendous work on vscode-python!

Came to Github to file an issue for this! I assumed format on save was buggy due to the silent failure and was just dealing with it for about a week or two before I realized I should say something, and the process of filing an issue made me learn the timeout setting was the cause. Doubling the timeout from 750 to 1500 solved the problem for me. P.S. I was using Black.

Solution: Increase timeout to 1000.
Todo: Check telemetry to learn about average time taken to format code (when using our tools).

related to #8196

This is now addressed in black extension.


Re-render a component on url change

Hi,
I got a component "CreateForm" who is used in these routes:
<Route path="/view/:bannerId" component={CreateForm}></Route>```

When i'm in the /view/:bannerId url, i want the form to be filled with the informations of my banner, when i click "Create", i want my form to be completely blank. But i don't know how to do it. Can anyone help me? I'm with ES6 classes. Thank you

This is not really React Router issue, React Router does not help with managing your data, it only helps with routing.
It's good to use stack overflow for such problems.
You will need to have some initial state with the data you want to use in your component or pass data as props.

You're probably not going to be able to do this with the same component for both anyway. Just use composition.

We can't launch a function from a route?

You could use onEnter but you're much better off handling this in your component.


Update travis, appveyor account

Update travis, appveyor account
Forgot to do this one..

b988534d68bc64ebd0509e39c432dc8acef6d649
fixed.
Travis, Appveyor accounts were also updated according to project ownership change


How to exit halted state (using python interface)?

Hi
I am working on yet another old microcomputer from the 70s. It uses the halt instruction to
wait for interrupts.
I try to fake the interrupt by storing the current PC on the and then adjust the PC to point to the
interrupt address.
This does not seem to work. Presumable the emulator needs to be informed to leave the halt
state?
Is there any example for how to fake an interrupt (to simulate external hardware)?
Cheers
Morten

Hi Morten, a1fc0e2b1dc948a7745c9f15fca1236ec10eb5f2 makes the Z80Machine.halted field writable, so now it should be possible to exit the halted mode by setting the field to be false. The commit adds an example that does exactly that.


Issue with ipfs daemon code example

const db = await orbitdb.log('hello')

I'm getting a linting error that you can't use await like this, outside of an async function. Should we remove it from the example?

Can you link where you get the code sample please?

@BartKnucle This is from the README, here.

I think we need to either assume that people will understand that it needs to be wrapped in an async function, or wrap the examples in an async IIFE like so:
(async () => {
  const db = await orbitdb.log('hello')
})()

Can we just add a note that it needs to be wrapped in an async? I think the IIFE might introduce more confusions than not. But this might just be me being confused, so I'm not sure it's necessary to change anything.

Yeah, a note should be fine


Submission improvement - size should be numbers only

We do allow size to also include multipliers (k,M,G), spaces, commas and periods (both as a decimal separator and/or thousand separator). It should be either numbers only, or there should be some automatic conversion.
This surfaced as part of #930, but if the field is ever to be used for searching or faceting we need a common format

duplicate of #939


Atomic scalar list operations

Problem

Scalar lists only support setting a value

This results in a less pleasant developer experience as well as potential data loss from race conditions.
Suggested solution
Add push (add elements) and pull (remove elements) operators.
Maybe also a pop operator.
Some thought should be put into the syntax used to push 1 element or 1+ elements. MongoDB uses an object with the $each operator:
db.students.update(
   { name: "joe" },
   { $push: { scores: { $each: [ 90, 92, 85 ] } } }
)

Additional context
Database documentation for array updates:

MongoDB
PostgreSQL

Just realized this is a (partial?) duplicate of #5078 and is partially solved by prisma/prisma-engines#1753.

I will consider it as full duplicate of #5078 and it will available in the next release. For deletion, you will need to use set as you can't uniquely identify them and there can be duplicates so it will be application specific logic.


Documentation needs updating

The documentation at https://book.cakephp.org/phinx/0/en/index.html only includes v0.13. This should be updated for v0.16.

Fixed on #2279


fix(version): update fabric8-runtime-console to 0.17.18

@fabric8cd snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-1587-fabric8-ui.int.rdu2c.fabric8.io


Session cookie generation - unexpected behavior

Expectation:
Session cookies will be set while the user is logged in, and would not be set otherwise.
Reality:
When a user isn't logged in, a session cookie is still being set. I visit the root page, and every time I refresh, a new cookie is set in the browser.
The user is not logged in

I'm still able to access the /sign_up and /sign_in pages, without auto-redirecting to the root url
I'm able to access routes that require "authenticated_user".

I'm trying to understand

why these session cookies are being sent, even when the user isn't logged in?
where are the session cookies being generated?
is there a way to disable session cookies altogether? (I'm trying to migrate to JWT auth standard, so that my app can be used with multiple client types, instead of just a browser).

As something extra, where are sessions stored server side?
I'm using rails 5.0.3, with ActiveRecord and postgres. But I don't have a backing sessions table in postgres that contains session ids. (And I didn't manually create a sessions table at any time).
Does rails not actually store any session cookies on the server side? And all it does is decrypt the cookie, and extract the session id (similar to how JsonWebTokens are handled)? I can't seem to find anything in the /tmp directory either containing anything about generated sessions.

Did more debugging. I realized that rails (not devise) will autogenerate a session id cookie whenever a page is fetched.
Still not sure how to disable session cookies altogether, or why they're being generated.
But guess this is not applicable here.
(Closing the issue)


Write function to calculate the estimated balance of a trustline with interests at time t

https://github.com/trustlines-network/project/issues/245

Not sure if I should use data['interest_ab'] or data['interest_ba'], since this abstraction makes no sense to me. It appears that creditline_ba is the credit limit given by b to a (a can spend up to creditline_ba) so I will assume 'interest_ba' is the interest given by b to a.


Allowing description to be optional.

Coverage remained the same at 60.671% when pulling 4131c8da925f6660c4206be2473883db826c359d on kevgliss:description-required into 54105e221e9017fe54114456763fa55e72994eed on Netflix:master.

👍


sync-etc.sh: Fix #57 (spaces in filenames), general

Closes #57
Changes were tested on a dual-node setup with the sleep example.

Thanks for the fixes!

Thanks for the fixes!


python311Packages.canals: 0.10.0 -> 0.11.0

Diff: https://github.com/deepset-ai/canals/compare/refs/tags/v0.10.0...v0.11.0
Changelog: https://github.com/deepset-ai/canals/releases/tag/v0.11.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 269932 run on x86_64-linux 1

4 packages built:

python310Packages.canals
python310Packages.canals.dist
python311Packages.canals
python311Packages.canals.dist


Better setup

Please add comments & code as needed.

Unfortunately there are still problems with the readme - some sections are still repeated. Sorry!
Can I suggest just copying and pasting https://github.com/open-contracting/ocdsdata/blob/master/README.md to https://github.com/open-contracting/ocdsdata/blob/better-setup/README.md ?
I  think only one thing in the README.md actually needs to change as a result of this pull request.
I see you added "pip install -e ." to the first section, which I guess is needed because "requirements.txt" has had  "--e ." removed?
So copy and pasting and then changing that one thing may be the easiest way to solve this merge. Thank you :-)

Firstly Sebastian, sorry this has taken so long. Honestly, I'm not an expert in Python packaging so my reviews of this have been slower than I would have liked.
(I pushed a commit to fix the README.md - the new pip line needed wasn't in, and some of the other lines had changed)
I have been asking others in an attempt to get help, and from that I have some questions:

it's been pointed out that the setup.py says:

Note: this will only work if 'README.md' is present in your MANIFEST.in file!

However, there is no MANIFEST.in file in this pull request? Should there be?

We weren't sure if the contents of requirements.txt should be in setup.py, in the install_requires key?

We weren't sure if the "-e ." should be taken out of the requirements.txt - as that then needs extra instructions added to the readme file. Is there a good reason to do that? Or should the requirements.txt have just "-e ." and then leave the setup.py to install everything else?

Can we take both ''Intended Audience' classifications out of setup.py? Neither of them are quite right - looking at the list it's not clear there is a perfect one, so we will just leave it for now.

Again, sorry for the delay! With some discussion we can sort this soon.

The Manifest was removed at @kindly 's request. I think it is a good idea to have one, which at least includes a list of routes, but it is fine either way.. https://github.com/open-contracting/ocdsdata/pull/132#discussion_r199165246

&  3. The rationale for leaving out the -e . is: -e. should only be run when installing in development mode, making it explicit as a command is good. When we have a deployment cycle, we want most people to be installing our tool from packaged sources (either PIP or a dist..?) When running pip install ocdsdata e.g. The other reason was to be able to parse REQUIREMENTS and load them into setup.py at "runtime", this means less problem when changing/updating deps, this is still lacking code, however... I am in favour of using install_requires, as it allows us to keep both the convenience of requirements.txt as well as ensuring both install methods are supported.

 4. Surely, will push ASAP.
What do you think could be a good course of action.

@odscjames i dunno how to re-ask you for review via the UI, sorry if dismissing the review seems rude .

The Manifest was removed at @kindly 's request.

He said to remove the MANIFEST, this comment refers to MANIFEST.in - different files.
However, I don't think we need one. https://packaging.python.org/guides/distributing-packages-using-setuptools/#readme-rst-readme-md says that README's are included automatically in later versions. (This explains @jpmckinney comment about ocdskit) So in fact, can we remove the comment:

Note: this will only work if 'README.md' is present in your MANIFEST.in file!

As that appears not to be true any more.
So that's one change.
Other steps:

ocdskit's .travis.yml does pip install without -e (no need for editable mode for automated testing).

Yup, lets do that as a second change.

However, flatten-tool and CoVE should ideally make releases

I think we should aim to get this P.R. in without this to start with, as this won't be happening shortly. We have started on this for flatten-tool but it will take longer to get CoVE sorted out for various reasons. (Actually, I'd prefer to solve this problem a different way but that's for a seperate issue.)

I agree that requirements.txt should only contain any requirements that cannot be in setup.py
Non-essential 'requirements' like flake8 should be in extra_requires.

Given the last point, and because I'm aware this has gone on a bit (Sorry!) let's leave this for now and come back to this when we can achieve more by this move? Is that ok?
So with those 2 changes, shall we merge this in?
Hint: If #175 is merged to master it will make another merge conflict here - so if it is possible to make these 2 changes quickly I'll merge this in first so that I have to take the hit of fixing the conflict in #175 instead!


Allow the readonly Keyword in Constructor Parameters

Having a class
class Person {
    private firstName: string;

    constructor(firstName: string) {
        this.firstName = firstName;
    }
}

TypeScript allows a shorthand notation for assigning the property
class Person {
    constructor(private firstName: string) {
    }
}

However, if a property has the readonly modifier, we cannot use this notation anymore.
class Person {
    constructor(private readonly firstName: string) { // an error.
    }
}

Would it be possible to allow the syntax from the last snippet?

This is already supported in the current dev releases and is a very nice feature.
test.ts
class ReadonlyPropertyParameter {
    constructor(readonly parameters) {
    }
}

transpiled test.js
var ReadonlyPropertyParameter = (function () {
    function ReadonlyPropertyParameter(parameters) {
        this.parameters = parameters;
    }
    return ReadonlyPropertyParameter;
}());

Duplicate of #7590; please search before logging new issues


Fix: Stop sending "pending" email to automatically approved collective from Github

This PR fixes #2063 by adding a new activity GITHUB_COLLECTIVE_CREATED (in /constants/activities.js) instead of using COLLECTIVE_CREATED causing the pending  email to be sent.

Sounds good. You might clean the following from case activityType.COLLECTIVE_CREATED:
      } else if ((get(activity, 'data.collective.tags') || []).includes('open source')) {
        notifyAdminsOfCollective(activity.data.collective.id, activity, {
          template: 'collective.created.opensource',
        });

Also, perhaps COLLECTIVE_CREATED_GITHUB instead of GITHUB_COLLECTIVE_CREATED.

Done

Coverage decreased (-0.02%) to 64.991% when pulling afbf2e520212584db322cb21aa86e74bd693f1f2 on fix/email-notification into 1b8f5633f7354f174dbc94536834d22206ddb66d on master.

@znarf this says it's been merged but I am still getting these emails.

@alanna The merged fix was about the PENDING email sent to collectives. Fixing properly what was described in https://github.com/opencollective/opencollective/issues/2063
There was some confusion with the APPROVE email sent to the host, this one was was not handled. We should not have closed https://github.com/opencollective/opencollective/issues/2068


Add the cart near nourtheast of brimhaven near hajedy to the entery menu swapper

Pretty much the title,you can left click "Pay" on hajedy to travel to shilo village,but not with the cart near him sadly

Added in #10614


Enhancement: change primary color on new Collective page to black

For new Collectives created going forward, we want the default primary color to be neutral, not blue, until the Collective sets their own primary color.
This is for new Collectives created after this change goes into affect, not existing ones.

Bump

Bump

@opencollective/design : This seems a very old issue; so I am wondering if this design still applies? 🤔


Home: Current Meeting Display Watch buttons are misaligned

Omar just noticed the display of the "Watch in English" and "Ver en Espanol" are misaligned. I could've sworn they were lined up at the start of the meeting, but I'm seeing it now, too. Here it is in Firefox:

And in Chrome:

@shrayshray We put the listen links below the main block a couple of years ago, because the addition of the eComment link crowded it too much. https://github.com/datamade/la-metro-councilmatic/pull/589#issuecomment-611584220
Do we want to revise this now?

Let's try logic like, if there is public comment, show buttons below; otherwise, show them next to the photo, in the event deetz column.

@hancush It seems like when the event has an agenda, it'd still look pretty off.

What about placing all buttons in a row under the meeting info/photo if there's an agenda?

@antidipyramid Can you mock that up and post here, tagging Shelly?

@shrayshray The number of buttons + different screen sizes can lead to an awkward layout.
What do we think of putting all of the buttons in a row? Here's what that could look like on a few different screen sizes:
(13" Macbook)

(slightly wider screen)

(very wide screen)

(smartphone)

@antidipyramid I really like how these look, but could I see mock-ups without the public comment button? I think it's worth planning for it in the design because it could comeback someday, but we haven't been using it for a couple years at this point.

@shrayshray Sure thing. Here's what that would look like:

@antidipyramid That looks good to me, thank you!

@antidipyramid @camachoo would like a slight revision on this. Is it possible to have the Spanish and English buttons separated but still have them side-by-side?

@shrayshray No problem. I'll work on implementing that.


Build a graph of packages and vulnerabilities

This feature is to group packages across all the different types (say openssl) that share the same version to find vulnerabilities that exist in other types of packaging of the same code and same version.
Consider using libversion and repology as helpers and also there are version-related tickets that need to be addressed

Here's how repology composes the package graph.
From https://github.com/repology/repology-updater/commit/7a9f741a35f71c9113f38e3cb224d4f684e4837c
For each link assigned to a project, a rank is calculated as a
quotient of a spread (number of repository families) for a particular
link to a maximum spread.

That is, if some specific link is provided by all repository families
which define links for a particular project, it gets 1.0. If only one of
10 families provide it, it gets 0.1.

The rank would be used related projects calculation, to sink projects
discovered through rare links as less relevant.

The algorithm implementation is here https://github.com/repology/repology-updater/blob/1f14f67c65e7f0a34ff7374d293ea61852516610/sql.d/schema/create_schema_functions.sql#L87 .
So repology considers versions as minor factor than links when guessing related packages which IMHO is a superior approach than what I was suggesting earlier(connecting nodes of similar purls).

Here's how repology composes the package graph. Technically it's not even a graph just a list of packages sorted according to confidence level of repology thinking that they are related.

@sbs2001 excellent find!


return exit code 1 for errors

Description
When the program fails and exit, I'd like to return an exit code other than 0.
On unix system, a exit code 0 means success while 1-255 means error
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated the docstring for new or existing methods
[x] I have modified this PR to merge to the develop branch

oops sorry I forget to push the rebase


Speaker diarization?

Is there a recommended method to implement speaker diarization with this whisper solution?

Haha, was asking myself the same at the same moment ;-)

This is like a #1 feature request for any whisper impelentation and it seems it's hard to do 😞

I have a repo Here that does this, I explored using whisper-jax instead of faster-whisper but the results weren't promising using GPU (RTX3070Ti)

Hey all! As far as I'm aware, there isn't a dedicated speaker diarization model in JAX. If anyone knows of one, we could get the sentence level timestamps from Whisper JAX, and the speaker turn timestamps from the diarization model, and then segment the transcript based on the two sets of timestamps (we do something similar in Speechbox, where we have both models in PyTorch: https://github.com/huggingface/speechbox/tree/main#asr-with-speaker-diarization)
Without a speaker diarization model in JAX, we would have to run the Whisper model in JAX, but the speaker diarization model in PyTorch -> I'm not sure how feasible it is to have a JAX and PyTorch model running on the same device. Probably the best thing to do here would be to run them sequentially (one after the other), or have one GPU running speaker diarization in PyTorch, and one TPU running speech transcription in JAX, and then transfer the results between the two (I think this is the current fastest way you could do it).

If anyone knows of one, we could get the sentence level timestamps from Whisper JAX, and the speaker turn timestamps from the diarization model, and then segment the transcript based on the two sets of timestamps

I'm just an amateur interested in this topic, but I've had luck so far with this solution which uses Pyannote.audio to perform diarization:
https://github.com/m-bain/whisperX
I believe this also aims to achieve the same thing:
https://github.com/MahmoudAshraf97/whisper-diarization
Additionally, I've tried this solution and it also does the job though I don't know how well-maintained it is (I could reform the code for Google Colab and run it there), it also uses Pyannote:
https://huggingface.co/spaces/vumichien/Whisper_speaker_diarization

@7k50 , I've played with Pyannote.audio which seems great although install is a hassle on a M1 (compatibility issues with Torch and all...) but seems one of the best solution for diarization.

I ran Here through whisper with multiple speakers, got the transcript with timecodes. Submitted to gpt , roughly describing who the speakers are and ask to break it down accordingly. Got perfect result back. Here is an excerpt:
`Interviewer: Welcome Hayek and Banderas, it's a pleasure to have you both here today. How are you both feeling?
Hayek: ¡Hola! Estamos muy emocionados de estar aquí. Gracias por invitarnos. (Hello! We are very excited to be here. Thank you for inviting us.)
Banderas: Sí, estamos encantados de compartir nuestro tiempo contigo y hablar sobre nuestra última película. (Yes, we are delighted to share our time with you and talk about our latest movie.)
Interviewer: I'm glad to hear that. Let's dive right in. Can you both share your experiences working on your latest project together?
Hayek: Claro, fue increíble volver a trabajar con Antonio después de tanto tiempo. Siempre es un placer, y creo que nuestra química en la pantalla es aún más fuerte que antes. (Of course, it was amazing to work with Antonio again after so long. It's always a pleasure, and I think our on-screen chemistry is even stronger than before.)
Banderas: Estoy de acuerdo. Salma y yo nos llevamos muy bien y siempre nos divertimos mucho en el set. Además, creo que nuestra amistad fuera de la pantalla se traduce en una gran química en la pantalla. (I agree. Salma and I get along very well and we always have a lot of fun on set. Also, I think our off-screen friendship translates into great on-screen chemistry.)`

These are all great speaker diarization models, but all ones that run on PyTorch only - as mentioned before, if we want to maximise performance of Whisper JAX, we'll need a speaker diarization model that runs in JAX as well.
Otherwise, if we're happy running the speaker diarization model in PyTorch (slower than JAX), we can try using the SpeechBox implementation of Whisper + Speaker Diarization: https://github.com/huggingface/speechbox/tree/main#asr-with-speaker-diarization
Here, we'd run the Whisper model in JAX (Whisper JAX), and the speaker diarization model in PyTorch (pyannote.audio). We'd then merge the outputs of the two to get our diarised text. A code snippet for this would be:
from pyannote.audio import Pipeline
from whisper_jax import FlaxWhisperPipeline
from speechbox import ASRDiarizationPipeline
import jax.numpy as jnp

diarization_pipeline = Pipeline.from_pretrained("pyannote/speaker-diarization", use_auth_token=use_auth_token)
asr_pipeline = FlaxWhisperPipeline("openai/whisper-small", dtype=jnp.float16, batch_size=16)

pipeline = ASRDiarizationPipeline(asr_pipeline=asr_pipeline, diarization_pipeline=diarization_pipeline)

# do a compilation step of the FlaxWhisperPipeline to get it out of the way
text = asr_pipeline("audio.mp3", return_timestamps=True)

# now we can use our combined pipeline for ASR + Speaker Diarization
diarized_text = pipeline("audio.mp3", return_timestamps=True)

Hey. Thanks for the developments so far. Im getting a error after implementing previously mentioned code.
ERROR: TypeError: SpeakerDiarization.apply() got an unexpected keyword argument 'return_timestamps'
Is there a way to fix this somehow?

Is it something to do with Speechbox? I see that there has been merging with it, but it doesnt seem to be applied in the code? Or im missing something here.


fix(deps): update terraform-module

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/cbr/ibm (source)
module
minor
1.22.2 -> 1.23.0

terraform-ibm-modules/cos/ibm (source)
module
patch
8.5.1 -> 8.5.3

terraform-ibm-modules/event-notifications/ibm (source)
module
patch
1.6.5 -> 1.6.8

Release Notes

terraform-ibm-modules/terraform-ibm-cbr (terraform-ibm-modules/cbr/ibm)
v1.23.0
Compare Source
Features

Ability to add optional location for each serviceRef when creating zone (#457) (3142064)

v1.22.3
Compare Source
Bug Fixes

update required ibm provider version to >= 1.65.0, < 2.0.0 to ensure fix for known provider issue is included (#467) (2e9cff1)

terraform-ibm-modules/terraform-ibm-cos (terraform-ibm-modules/cos/ibm)
v8.5.3
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/cbr/ibm to v1.23.0 (#657) (7563ea2)

v8.5.2
Compare Source
Bug Fixes

update bucket DAs dependencies (#654) (e311989)

terraform-ibm-modules/terraform-ibm-event-notifications (terraform-ibm-modules/event-notifications/ibm)
v1.6.8
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/cos/ibm to v8.5.3 (#240) (7091014)

v1.6.7
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/cos/ibm to v8.5.2 (#238) (993db8e)

v1.6.6
Compare Source
Bug Fixes

updated CBR module to 1.23.0- updated required ibm provider version to >= 1.65.0, <2.0.0 (#236) (66512d2)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.6.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


new config.xml option keystore/fixedSalt

dependency for https://github.com/Evolveum/midpoint/pull/151

merge status? thanks

Merged. This thing is dangerous, but as far as it is not easy to configure it by mistake I'm OK with it. However, I have added appropriate warnings in the code.


Fixed test/run and syncing 2.4 and 2.6 test/run

[test]

@mfojtik I hope @bparees can better explain your questions - this PR only sync changes which are in 2.4 only to 2.6 - this PR: #103 #104 #105 #106

[test]


[Facebook] Sharing with Image

I realize that not everyone wants to integrate with Facebook but given it's one of the largest social media platforms, is it worthwhile considering a better intgration so that images can be shared when sharing on Facebook?
Steps to reproduce
Use a file:// url and notice how Share.open will not populate the Facebook post with an image. Share.shareSingle actually fails to open the webpage.
Expected behaviour
This may require an integration with Facebook, but if present, sharing on Facebook is quite easy like below.
import { ShareDialog } from 'react-native-fbsdk';

const photoUri = 'file://' + '/path/of/photo.png'
const sharePhotoContent = {
  contentType: 'photo',
  photos: [{ imageUrl: photoUri }],
}
ShareDialog.show(sharePhotoContent);

Environment

React Native version: 0.57.8
React Native platform + platform version: iOS 12

react-native-share
Version: 1.1.3

@a-koka are you working on this?

@murtraja This is not as trivial as it seemed at first.
Firstly, FB has some permission issues where it won't let you post both an image and a description/text at the same time. That last time I checked, this just isn't possible using react-native-fbsdk.
Secondly, The original proposal was to modify the share functionality and use fb-sdk if Facebook app was selected. From what I gathered, there is no callback once the app is selected so we can't quite control what happens next. I could be wrong on this but I wasn't able to get much help from the Slack channel so I gave up.
I am personally resolving to a custom UI in my app which let's the user select from a list of apps, and then have complete control over the workflow. The first problem is still a big issue.

@a-koka, I am doing the exact same thing. Also, using react-native-fbsdk will involve signing up for a facebook developer key, which I don't like. When I first saw this issue, I assumed that we aren't able to share images via Facebook, but when I tried, I could share multiple images without the need of any external SDKs which was a win. Hence, I see no need for the integration.
Thanks,

How can I get the local file url for an online image?

@manujbahl, you need to download the image first. I am using rn-fetch-blob
      const path = ((isAndroid)? dirs.DownloadDir : dirs.DocumentDir) + '/' + fileName;
      const res = await RNFetchBlob
        .config({
          path,
          session: SESSION_NAME,
        })
        .fetch('GET', imageUrl)
      paths[i] = res.path()
      if(isAndroid) {
        paths[i] = 'file://' + paths[i]
      }

what about iOS?

I guess that rn-fetch-blob works fine for both Android and iOS


feat: Add support for aws provider 5.0

what

why
That fields/modules have deprecated stuff, that was removed in 5.0
references

You will need something like this to fix the problems regarding S3 :
https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/compare/main...hdurix:terraform-aws-cloudfront-s3-cdn:master

Good catch @sebnapo
So, depends on #282
/cc @aknysh


[release-1.3] feat(proxy templates): reflect istio/istio templates additions

This is an automated cherry-pick of #343

Putting this backport on hold to prevent merging until 1.3.2 is published.

/retest

/retest


az vm user update failed with an unexpected error

Describe the bug
Created a 2016-Datacenter server and setup some new users, Then did system updates and rebooted. After reboot I could not log in anymore.
Tried to reset password to log back in.
Command Name
az vm user update
Errors:
The command failed with an unexpected error. Here is the traceback:

'VirtualMachineExtensionsOperations' object has no attribute 'create_or_update'
Traceback (most recent call last):
  File "/opt/az/lib/python3.6/site-packages/knack/cli.py", line 233, in invoke
    cmd_result = self.invocation.execute(args)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 660, in execute
    raise ex
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 723, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 716, in _run_job
    six.reraise(*sys.exc_info())
  File "/opt/az/lib/python3.6/site-packages/six.py", line 703, in reraise
    raise value
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 694, in _run_job
    result = cmd_copy(params)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 331, in __call__
    return self.handler(*args, **kwargs)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/__init__.py", line 808, in default_command_handler
    return op(**command_args)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/vm/custom.py", line 2244, in set_user
    return _reset_windows_admin(cmd, vm, resource_group_name, username, password, no_wait)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/vm/custom.py", line 2231, in _reset_windows_admin
    poller = client.virtual_machine_extensions.create_or_update(resource_group_name,
AttributeError: 'VirtualMachineExtensionsOperations' object has no attribute 'create_or_update'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az vm user update -u {} -p {} -n {} -g {}

Expected Behavior
Environment Summary
Linux-5.4.0-67-generic-x86_64-with-debian-buster-sid
Python 3.6.10
Installer: DEB

azure-cli 2.20.0

Extensions:
storage-blob-preview 0.3.0
image-copy-extension 0.2.8

Additional Context

hi @qwordy, is this issue fixed in latest version?

@henti Thank you for reporting it. This issue is fixed in the coming version on 3/23/2021.
It is fixed by https://github.com/Azure/azure-cli/pull/17257.


[SILInliner] Inherit SILBuilderContext when creating a new one.

Addresses Michael's feedback on my last commit.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci smoke test

@swift-ci smoke test linux

Thanks. LGTM!


Aggregation of multiple CAN messages in 1722 frame

Based on comment from @JLPLabs we should consider adding support to aggregate multiple CAN frames into a single Ethernet frame.

Adriaan,
You'll see a 3rd commit on this PR.
NOTE  PLEASE LET ME KNOW:
a) if this is more than you want,
b) if there is a better / more idiomatic approach I should be taking.
This last change can be summarized as:

LISTENER

updated one line in acf-can-listener so that the acf_pdu pointer is moved through the ethernet frame. (right now there is logic that seems to imply that was the desired behavior, but the pointer wasn't actually being updated).

TALKER

added a --count COUNT flag to the command line. This allows the user to require COUNT number of CAN frames to be packed into one Ethernet frame.
used the variable that already existed, num_acf_msgs for handling the count logic.

Originally posted by @JLPLabs in https://github.com/COVESA/Open1722/issues/18#issuecomment-2248463892

Hey, this looks very well thought out to me. Big thanks! Unfortunately I can only give you a short reply, because I'm in a little bit of hurry. Some thoughts:

Seems plausible to me now that you might want to limit the number of CAN frames for debugging purposes :+1:
I think it makes more sense to interpret the timeout with respect to the oldest (not the newest) message in the buffer. The reason is that you want to be able to guarantee a deadline (or worst-case transmission time) for your CAN messages. For example you might want to ensure that certain sensor signals are delivered to your central compute in under <100ms. If you reset the timeout every time a new CAN message is added to the buffer, it becomes quite hard to estimate for how long CAN frames could get delayed in the worst-case.
Having ~1h as the max timeout seems more than enough to me. I don't think there are use cases where it's acceptable to wait 1h to receive the data even it's not that important. I'd estimate that in most real-world scenarios the timeout would be set to <1s.

Sorry for my delayed response.
I think your logic for timing makes sense. I'll start to work on updated code with this definition for --timeout:

--timeout <time> where <time> is an integer number of microseconds, "usec". (not milliseconds)

The timeout establishes the maximum wait for retransmission of a CAN message.
The timeout clock starts with the arrival of the first message.
The retransmission may be sooner than <time> usec if the Ethernet frame becomes full or the maximum count (see --count) of CAN messages has arrived.
minimum value: 0
maximum value: (2^32 - 1)
default: maximum value

examples:

--timeout 0 means no waiting, immediately pack and send the CAN frame in a 1722 frame.
--timeout 700 means wait no longer than 700 usec from the arrival of the first CAN frame to start the 1722 frame transmission process.
if no value for --timeout is given, then the 1722 frame will be launched when one of these is true:

the 1722 frame is full
the 1722 frame has <count> number of messages
1.193 hours has passed since the arrival of the first message (in a real network this effectively never going to happen)

Hi,
don't worry take your time.

Only thing I'd change is to set the default timeout to 0 instead of 2^32-1 because then it could happen that a single CAN frame gets delayed for a very long time. I fear some users could interpret this as a bug if they don't study the documentation first.

If you need any help or feel stuck at some point let me know.
Regards
Adriaan


Adding a handler after having removed the same handler does not work

Description:
First, i add a handler with ractive.on(), then i remove it either calling ractive.off() or .cancel(). Then, if i try to add the same handler again it doesn't work. No error occurs but the handler is not installed.
Versions affected:
Tested on Ractive v.0.8.12 and v0.7.3
Platforms affected:
Tested on Google Chrome 56.0.2924.87 (64-bit) / Mac OS X 10.11.6 (15G31)
Reproduction:
See snippets below.
Code:
From my understanding, the exectution of the three snippets bellow should print ok in the console. 1/ and 2/ don't work. 3/ works (this third snippet is the workaround i use).
1/
var printHandler = function() {
    console.log("ok");
}

ractive.on('print', printHandler);
ractive.off('print', printHandler);
ractive.on('print', printHandler);
ractive.fire('print');

2/
var printHandler = function() {
    console.log("ok");
}

ractive.on('print', printHandler).cancel();
ractive.on('print', printHandler);
ractive.fire('print');

3/
var printHandler = function() {
    console.log("ok");
}

ractive.on('print', function() {
    printHandler();
}).cancel();

ractive.on('print', function() {
    printHandler();
});

ractive.fire('print');

Do i miss something or is there a bug ?

There is a bug. Since event subscribers can get modified while events are firing, the event firing code makes a copy of the subscriber list before dispatching events. When off is called on a handler, it gets a flag off added to it to let the firing code know that it should skip that handler. In this case, the handler is being added back with the off flag still intact, meaning it gets skipped for firing.
I think we can work around this by using a setTimeout to drop the off flag, but looking at it, there may be other implications for other scenarios still. For instance, attaching the same function to two different events with two calls to on and then offing one looks like it would stop the other from firing too.


NFT navigation

[ ] Click on "NFT" in navigation does not activate "collectables" tab, except when wallet modal is opened, try to open from

@Kersten-TCD can you add reproduction steps or we can walk through it.

Steps to reproduce:

login to web-wallet
Click on "wallet" and open the "wallet" page
Then click on "NFT", this will activate the "Collectable" tab on the "wallet" page
Now click on "Profile" or "dApps" and open the page
Click on "NFT" again, this will open the "wallet" page but does not activate the  "Collectable" tab


no_std support

Hello,
I just noticed that metrics still only supports std env. and it would be beneficial to take a look at how much effort is needed to make it no_std and suitable for use in embedded systems.

A while ago, I had tried to add the relevant cfg flags and what not to support no_std environments, but truthfully, I myself don't have any no_std projects so the support was purely theoretical and based on the other code required (like an exporter that was also no_std compatible), we removed all the no_std bits to avoid any confusion/frustration.
If you wanted to do some of this exploration work, perhaps by forking the library and seeing how much work it took to get it working in a no_std environment, I'd be interested in seeing that and helping/guiding where possible.
Unfortunately, this isn't something I can commit any time to researching.

Thank you very much for your response @tobz .
Apart from embedded systems it seems that there are more and more container runtimes that can run no_std in Linux user space.
I might look into it and see how much work it is to do it. Given the fact that the embedded ecosystem is growing rapidly, it might be a good opportunity to introduce this to metrics but only if it's worth it.
The go-to-standard for logging - defmt is specifically created to support no_std and log also supports it but there isn't anything for metrics yet.


Use long tags in PHP

PHP short tags doesn't work well with the interpreter shipped with Ubuntu 14.04 LTS.
This causes that Apache prints PHP codes on the "Problems" pages.

Thanks very much for your contribution!
:+1:


Manta is stuck when executing the workflow

Describe the bug
Manta tries to connect to port 25 of localhost which makes it stuck on our HPC because it does so without a timeout.
To Reproduce

Run snappy-pipeline with manta step
See it getting stuck

Expected behavior

Manta should run

Additional context

Illumina/manta#293

Root Cause Analysis
The problem is connecting to localhost port 25 when no server is running.

Resolution Proposal
Use perl to prevent the call to isLocalSmtp.


Missing py.typed marker file for PEP 561

When type checking projects that depend on InquirerPy with mypy with default settings, the following error results in a type checking failure:
Skipping analyzing "InquirerPy": module is installed, but missing library stubs or py.typed marker

To reproduce:

Install InquirerPy as dependency into a project
Run mypy my-project-directory to type check the project

Related information:

PEP 561: https://www.python.org/dev/peps/pep-0561/
mypy docs about the error: https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-library-stubs-or-py-typed-marker

Hi jonemo ,
Thanks again for doing this. I should have touched up in the issue ticket for this. No not your changes broke the pyright lints, think pyright updated some checks around Optional[XXX] which I need to update the codebase to align with that.
I've been quite busy for the last few months and should have fixed the pyright thing first. I'll close your issue once I fix the linting and make a quick release.
Thanks

cross posting here ..


Error is thrown if drop is destroyed before hover timeout executes

Create a drop that opens on hover with a hoverOpenDelay
Hover over target, which sets a timeout
Destroy the drop (before timeout executes)
Timeout is not cleared, and when it executes a js error is thrown

The actual error thrown is Cannot read property 'parentNode' of null and is caused by https://github.com/HubSpot/drop/blob/master/src/js/drop.js#L374
If this.drop is null when open is called it should probably just return instead of trying to do things.

Looks like a duplicate of #139.

Indeed. Sorry about that, I only looked for existing open issues, not open PRs.


Write manual test cases for MunsterPage, ConnachtPage, UlsterPage,  MadridPage, and BarcelonaPage

Please write a manual test case for the following pages manual test which involves breaking down the webpage's functionality into specific steps that can be tested.
MunsterPage:
https://prayersconnect.com/mosques/search/Waterford%252C%2520Munster%252C%2520Ireland/52.2593197%2C-7.110070299999999/52.2593197%2C-7.110070299999999
ConnachtPage:
https://prayersconnect.com/mosques/search/Ballyhaunis%252C%2520Connacht%252C%2520Ireland/53.7628378%2C-8.7645957/53.7628378%2C-8.7645957
UlsterPage:
https://prayersconnect.com/mosques/search/Cavan%252C%2520Ulster%252C%2520Ireland/53.9897186%2C-7.3633319/53.9897186%2C-7.3633319
MadridPage:
https://prayersconnect.com/mosques/search/Madrid%252C%2520Madrid%252C%2520Spain/40.4167754%2C-3.7037902/40.4167754%2C-3.7037902
BarcelonaPage:
https://prayersconnect.com/mosques/search/Pineda%2520de%2520Mar%252C%2520Barcelona%252C%2520Spain/41.62451009999999%2C2.6827579/41.62451009999999%2C2.6827579
Please use this Google doc for your test cases.
https://docs.google.com/spreadsheets/d/1PQAPc3LDIXRTGbLO4RmzezR6MrMjo-zTs7WhXgOpw98/edit?usp=sharing

MunsterPage:
https://docs.google.com/spreadsheets/d/187vkbUPP-tr9rzD8KEt1yxhxCDsAlBwzgoCWh5me-RU/edit?usp=sharing
ConnachtPage:
https://docs.google.com/spreadsheets/d/1We0I4fHRE8TS5vDovG1nx1nvD8HYtQ44gxkLdIT_Vqw/edit?usp=sharing
UlsterPage:
https://docs.google.com/spreadsheets/d/10YQSDQIRq5hGWjwZhE-uvR-DIR1L2jiVMAz0jmJXBss/edit?usp=sharing
BarcelonaPage:
https://docs.google.com/spreadsheets/d/1k3jxbwPmjcV9r2sbMtfSSyc8JJF6xYu2UCoSiufwZEY/edit?usp=sharing

Done


Update MEI bib file

This small PR adds two more bibliography items recently published and fixes a typo in the ACM Proceeding Series title.
Ready to review.

Thanks!


During form submission, embedded arrays only contain the last entry

I currently have a schema with this shape:
  schema "ClientInstance" do
    field :ext_ref, Ecto.UUID
    field :notes, :string
    embeds_one :query, EmbeddedSchema.ClientInstance
    timestamps()
  end

with the embedded schema as follows:
  embedded_schema do
  field :includes, {:array, :string}

  field :queries, {:array, PolymorphicEmbed},
        types: [
          queryquery: [module: Query, identify_by_fields: [:bar]],
          ...
        ],
        on_type_not_found: :ignore,
        on_replace: :delete
end

Given a changeset like so:
#Ecto.Changeset<
  action: nil,
  changes: %{
    ext_ref: "6201d502-6422-4b49-9849-e07fd4fe5899",
    notes: "Misbehaving Tester",
    query: #Ecto.Changeset<
      action: :insert,
      changes: %{
        queries: [
          %Query{
            foo: nil,
            bar: "5642"
          },
          %Query{
            foo: nil,
            bar: "5672"
          }
        ]
      },
      errors: [],
      data: #EmbeddedSchema.ClientInstance<>,
      valid?: true
    >
  },
  errors: [],
  data: #Controller.ClientInstance<>,
  valid?: true
>

I have this rendering via polymorphic_embed_inputs_for/4 the form successfully against the existing data
<%= polymorphic_embed_inputs_for query_form, :queries, :queryquery, fn fp -> %>, with the array of existing foo/bar fields present. On validation however, I only recieve a single one in the params passed back to the form as so:
%{
  "notes" => "Misbehaving Tester.",
  "query" => %{
    "includes" => [""],
    "queries" => %{
      "__type__" => "queryquery",
      "foo" => " ",
      "bar" => "5672"
    }
  }
}

as opposed to an array like I was expecting
%{
  "notes" => "Misbehaving Tester.",
  "query" => %{
    "includes" => [""],
    "queries" => [
    %{
      "__type__" => "queryquery",
      "foo" => " ",
      "bar" => "5642"
    },
    %{
      "__type__" => "queryquery",
      "foo" => " ",
      "bar" => "5672"
    }]
  }
}

I've been toying around with various solutions but I've reached a bit of an impasse at this time.

In my experience, you need to set the name of an input manually when working with array inputs.  You can use the index and something like name="#{@name}[#{index}]".

I think what would be interesting is to see the rendering.
It's probably the names of the inputs that are wrong.

The to_form implementation of phoenix_ecto checks the cardinality of a field and sets the name and id to id: name <> "[" <> index_string <> "]" and id <> "_" <> index_string respectively.
https://github.com/phoenixframework/phoenix_ecto/blob/4aa366cfc26b06433521a92deff27b52cec6d450/lib/phoenix_ecto/html.ex#L69
I think the to_form implementation of polymorphic_embed needs to check whether the field is of type {:array, PolymorphicEmbed} and modify the name and id attributes accordingly.
https://github.com/mathieuprog/polymorphic_embed/blob/05f682cd2328907a207085240e45c7e3f42afacf/lib/polymorphic_embed/html/form.ex#L117

There has been a fix for form input rendering of list of embeds (now we render the index). It probably fixes this issue.


Login - "Here is your magic code" appears briefly before the abracadabra page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4481382&group_by=cases:section_id&group_id=229043&group_order=asc
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Start logging in with a new Gmail account
Copy the magic link, paste it to iCloud notes and add "staging" to it
Open it from iCloud notes

Expected Result:
Only the abracadabra page should show.
Actual Result:
"Here is your magic code" appears briefly before the abracadabra page.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/f6943da6-e9c3-42da-a061-8ba029b0b725

View all open jobs on GitHub

@adelekennedy I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

Production
https://github.com/Expensify/App/assets/115492554/d15f2723-fe8c-4a71-bfaf-880eded70ca8

How do we want to handle this @lakchote? Looks for a proposal or ask original author to solve it.

I'm open to fixing this as soon as possible in a correct way. We should not revert the offending PR as per the comment here.
I've asked @mountiny on how to handle this, as we've got no proposals. I've already tagged the original author in this PR.
I'll update whenever I have new info.

Since the user user can sign in normally, and the problem is more that a flash of text appears, I'm going to remove the Deploy blocker label.

Thanks, I agree this does not have to be a blocker

Agree, thank you

Proposal
Please re-state the problem that we are trying to solve in this issue.
The magic code appears briefly when opening magic link before the loading indicator shows. This happens before, you can see the mWeb recording of my past PR here
What is the root cause of that problem?
The loading indicator will show if the autoAuthState is SIGNING_IN.
https://github.com/Expensify/App/blob/468ee2f66b84dad74d6ab2cc6ec71ad2d9bd629d/src/pages/ValidateLoginPage/index.website.tsx#L74-L80
However, it's not updated immediately as we need to merge it first.
https://github.com/Expensify/App/blob/0995d40b43d91749260a1d490dfebc5433f3e0fb/src/libs/actions/Session/index.ts#L526-L528
And the default value of autoAuthState is NOT_STARTED.
https://github.com/Expensify/App/blob/468ee2f66b84dad74d6ab2cc6ec71ad2d9bd629d/src/pages/ValidateLoginPage/index.website.tsx#L23
That's why we see the magic code for a brief moment.
What changes do you think we should make in order to solve the problem?

The sign in with validate code is triggered when mounted after going through 2 if.
https://github.com/Expensify/App/blob/468ee2f66b84dad74d6ab2cc6ec71ad2d9bd629d/src/pages/ValidateLoginPage/index.website.tsx#L28-L46
If both if are pass, then we can optimsitically know that we need to show a loading indicator. So, we can create 2 new variable.
const isUserClickedSignIn = !login && isSignedIn && (autoAuthState === CONST.AUTO_AUTH_STATE.SIGNING_IN || autoAuthState === CONST.AUTO_AUTH_STATE.JUST_SIGNED_IN);
const shouldStartSignInWithValidateCode = !isUserClickedSignIn && !isSignedIn && (login || exitTo);

Then replace the if with the above condition.
if (isUserClickedSignIn) ... return
Session.initAutoAuthState(autoAuthState);

if (!shouldStartSignInWithValidateCode) ... return

// The user has initiated the sign in process on the same browser, in another tab.
Session.signInWithValidateCode(Number(accountID), validateCode);

And last use the new variable to show the loading optimistically.
https://github.com/Expensify/App/blob/468ee2f66b84dad74d6ab2cc6ec71ad2d9bd629d/src/pages/ValidateLoginPage/index.website.tsx#L74-L80
{autoAuthState === CONST.AUTO_AUTH_STATE.NOT_STARTED && !exitTo && !shouldStartSignInWithValidateCode && ...}
{(autoAuthState === CONST.AUTO_AUTH_STATE.SIGNING_IN || shouldStartSignInWithValidateCode) && <FullScreenLoadingIndicator />}

What alternative solutions did you explore? (Optional)
Don't default autoAuthState to anything. This will render nothing for a brief moment.
https://github.com/Expensify/App/assets/50919443/0c2431fd-5388-4694-a955-dc7bc0919fb5

@parasharrajat could you please review @bernhardoj's proposal today? Thank you!

We already have logic to show the loader but that is not triggered immediately as Onyx takes time to update the state. So I think its better to fix that.

I do agree. Thanks for your review @parasharrajat.
@bernhardoj's proposal LGTM.

PR is ready
cc: @parasharrajat

What's the latest here? This has been in review for a while at this point.

Waiting for @parasharrajat testing.

@bernhardoj payment made!

Payouts due:

[ ] Contributor: $250 @bernhardoj (Upwork)
[ ] Contributor+: $250 @parasharrajat (NewDot)

Upwork job is here.

@lakchote to review the regression test steps above!

I completely forgot @lakchote is on parental leave - I think the regression steps make sense so moving forward with creating the GH

$250 approved for @parasharrajat


Fix MAMP 4.4.1 SHA256

The SHA256 of MAMP is not correct.
See https://www.mamp.info/en/downloads/ for correct digest.

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Thank you, but duplicate of https://github.com/caskroom/homebrew-cask/pull/44087.


ComplexityAffectingNodeFinder: remove wrong comment

I think this comment is not placed correctly (might be a leftover of a rectoring or similar)

Thanks


Automatic dispatch upon route change

I'm not sure how to call store.dispatch when a route changes. mounted lifecycle won't work, since component isn't re-mounted on route param change (/user/1, /user/2).
What I do today is something like:
const router = new VueRouter({
  routes: [
    {
      path: '/', component: App, meta: {dispatch: 'loadData'}
    }
  ]
});

router.beforeEach((to, from, next) => {
  const {dispatch} = to.meta;
  if (dispatch) store.dispatch(dispatch);
  next();
});

I'm not sure if this is the most elegant/correct solution, but it does seem to work, and I find myself re-using this pattern for almost every app.
Would this be a good addition to this library (if it is a good solution)?

Well, it's indeed a pattern that can be used in some apps.
Personally, I prefer calling the dispatch in the View component so I can handle the loading state locally but some prefer handling the loading state before reaching the view like you do. You can even have some loading bar going on if you wait for the dispatch to be over before calling next


Spelling

Description:
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/rxjs/commit/57df4bc5809b740f680bc5c13b1db2294d2bea34#commitcomment-72980168
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/rxjs/commit/905bd866a29d7fe698c55614c55cd48f2d020aed
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.
BREAKING CHANGE:
Related issue (if exists):

I'm not sure why I can't find an option to approve and run the pre-merge pipelines.


Website/about/contributors section

Begins team section

closing bc messy, going to open new one!


DocRequired: deployment of examples for cephfs

It would be nice to have more docs on examples/cephfs.
Also I got a question ceph-csi in general:
For example, the sc defined in rook repo can also be used to provision rbd PVCs. What is the difference if we use the one defined here?
For cephfs, there is no such provisioner or sc defined in rook. openshift/external-storage provides those with some restrictions. That is the reason that I was suggested by @travisn to explore options here until @ShyamsundarR reminds me that Requires Kubernetes 1.13 and OCP is with
$ oc version --short
Client Version: v4.0.22
Server Version: v1.12.4+7cf6a84
$ oc get clusterversion
NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.0.0-0.nightly-2019-03-25-180911   True        False         3h35m   ...

OCP 4.1 uses k82 1.13.
Any doc about ceph-csi and ocp4.1?
$ oc version --short
Client Version: v4.0.0-alpha.0+858c9f7-2002-dirty
Server Version: v1.13.4+2e01d67

$ oc get clusterversion
NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.1.0-0.nightly-2019-05-08-131137   True        False         25h     Cluster version is 4.1.0-0.nightly-2019-05-08-131137

$ oc get nodes ip-172-31-130-237.us-west-2.compute.internal
NAME                                           STATUS   ROLES    AGE   VERSION
ip-172-31-130-237.us-west-2.compute.internal   Ready    master   25h   v1.13.4+d34b8bd34

@hongkailiu we have addressed the documentation in various PRs and also have a support matrix..etc now. I believe this is addressed and if you see any missing documentation please open a new issue. I am closing this for now.


Revert "clear all env vars except PATH when running cargo"

This reverts commit 90051482c4fc1d6ca33a866fd2edfa073c031079.
Turns out it was more trouble than it was worth and broke Windows CI.

Can we selectively filter out problematic var(s)?

Probably, but that would require determining which var(s) are problematic, which is more effort than I care to spend at the moment.


coverage addition is too specific

adding new plots is a bit difficult. I.e. if we want to add multiple coverage plots, we cannot with the current instance without a weird work around
i.e. we upload a tumor drycleaned cov plot with the ggraph.
We run into an issue with the graphs and we want to diagnose with the normal coverage plot. How do we add this easily?
Have to do a workaround where we individually add the graph via something like this:
cov2arrowPGV(PGVpairs_dcn$normal_dryclean_cov[1],
             field = "foreground",ref = "hg19",
             output_file = paste0(PGVdb$data_folder, "/",
                                  PGVpairs_dcn$pair[1], "/",
                                  PGVpairs_dcn$pair[1], "dcN-coverage.arrow"),
             meta.js = "~/public_html/PGV_viz/public/settings.json")

ngraph = data.table(sample = PGVpairs_dcn$pair[1], type = "scatterplot",
                    source = paste0(PGVpairs_dcn$pair[1], "dcN-coverage.arrow"),
                    title = paste0(PGVpairs_dcn$pair[1], "dcN Coverage Distribution"),
                    visible = FALSE,
                    patient.id = PGVpairs_dcn$pair[1], plot_id = NA)

PGVdb$plots = rbind(PGVdb$plots, ngraph)
push_PGV_db(PGVdb)

perhaps when I move the object to R6 we just ask the user to provide a graph and we check for the types and then adds with a title I guess? hard to say.


JWT key handling in code does not correspond with blog resulting in execution errors

The blog on https://aws.amazon.com/blogs/networking-and-content-delivery/securing-cloudfront-distributions-using-openid-connect-and-aws-secrets-manager/ does not include PUBLIC_KEY and PRIVATE_KEY in the example  idP configuration secret. This causes the Lambda function to fail. It is not apparant to me in what format those keys should be provided in order for the function to execute correctly.
In the end I chose to distribute generated JWT private and public key files together with the Lambda function and refer to those files instead by changing line 88 in /src/js/auth.js into:
		var publicKey = fs.readFileSync('public.key');
		await verifyJwt(Cookie.parse(headers.cookie[0].value).TOKEN, publicKey, {

Inserting the following line after line 286 in /src/js/auth.js:
	var privateKey = fs.readFileSync('private.key');
And changing line 306 in /src/js/auth.js into:
						JsonWebToken.sign({}, privateKey, {

They're PEM format RSA, ie:
"PRIVATE_KEY": "-----BEGIN RSA PRIVATE KEY-----\nMII...SU\n-----END RSA PRIVATE KEY-----\n",
"PUBLIC_KEY": "-----BEGIN PUBLIC KEY-----\nMIG...AB\n-----END PUBLIC KEY-----\n",

Thank you for opening this issue. We are working on updating the code and instructions on this step.

Thank you for the feedback and questions on the private and public key pairs.
The documentation has been updated based on this feedback below:
https://github.com/aws-samples/lambdaedge-openidconnect-samples/blob/master/docs/keypairs.md
https://github.com/aws-samples/lambdaedge-openidconnect-samples/blob/master/docs/configuration.md#example-document-manually-created
Also, we have developed a CLI utility that will generate the configuration document including the private and public key pairs:
https://github.com/aws-samples/lambdaedge-openidconnect-samples/tree/master/cli
Please let us know if there are any other questions and we can open another issue.
Closing this issue for now.


include vbox timing note as an aside

output learned from debugging and diagnosing the rejecting i/o input from offline devices error scenario we encountered this past week

@RackHD/corecommitters @RackHD/doccommitters please review
FYI @jgolio @stuart-stanley @johren

Looks good to me.

:+1:


Text isn't vertically centered

TTTAttributedLabel always draws its text in the top left corner.

I'm seeing this same issue.  I tried tinkering with the framesetter values, but to no avail. TTTAttributedLabelVerticalAlignmentTop just seems not to work.

I had this problem before and I committed a code patch to fix it -- it worked for me, so it must have been that however I implemented it didn't work for all cases?  Take a look at this:
https://github.com/mattt/TTTAttributedLabel/pull/13

Just tried it again. Don't know what didn't work last time but it actually works now as it's supposed to.

@gefilte You need to use TTTAttributedLabelVerticalAlignmentCenter instead of TTTAttributedLabelVerticalAlignmentTop to draw the text in the middle. Does that work?

As someone who, at least on iOS, doesn't touch IB with a 10-foot pole, nothing immediately comes to mind. Does anyone else have any idea what's going on?

So my comment above was a mis-paste. I'm really using TTTAttributedLabelVerticalAlignmentCenter.  I just tried it again (I had switched my code to OHAttributedLabel so I had to finagle a little), and it still doesn't work.
So more details then:
I'm not using Interface Builder for any of these components. My TTTAttributedLabel is a subView of a UITableViewCell.contentView. The only thing in IB is the outer TableView, everything else is programmatic.
Here's the reusable cell generation code:
    rightBoxLabel = [[[TTTAttributedLabel alloc] initWithFrame:CGRectMake(CELLLEFT + 212, CELLTOP + 35, 89.0, 25.0)] autorelease];
    rightBoxLabel.font = [UIFont systemFontOfSize:12.0];
    rightBoxLabel.textAlignment = UITextAlignmentCenter;
    rightBoxLabel.textColor = [UIColor colorWithHexString:@"3A4B59"];
    rightBoxLabel.backgroundColor = [UIColor colorWithHexString:@"E2E4E6"];
    rightBoxLabel.verticalAlignment = TTTAttributedLabelVerticalAlignmentCenter;
    rightBoxLabel.autoresizingMask = UIViewAutoresizingNone;
    [rightBoxLabel.layer setCornerRadius:10.0f];
    [rightBoxLabel.layer setMasksToBounds:YES];
    [cell.contentView addSubview:rightBoxLabel];

And the assignment code:
NSMutableAttributedString *distanceText = [NSMutableAttributedString attributedStringWithString:[NSString<EMAIL_ADDRESS>km", 10.0]];
[distanceText setTextAlignment:kCTCenterTextAlignment lineBreakMode:kCTLineBreakByTruncatingTail];
[distanceText halfBoldWithFontSize:12]; // This is a styling bit in in a category, just styles a range bold
rightBoxLabel.text = [NSAttributedString attributedStringWithAttributedString:distanceText];

No matter how I slice this, the text is always aligned to the top of the label rect.
I even considered the possibility that I needed to rejigger after setting the text on the individual cell, so I tried this after the assignment:
rightBoxLabel.verticalAlignment = TTTAttributedLabelVerticalAlignmentCenter;
[rightBoxLabel setNeedsDisplay];

No dice, same result.  (I tried setNeedsLayout as well to no avail.)
This works fine with OHAttributedLabel, and I see that the algo for determining the framesetter is very similar.
Ideas?

So... no ideas here?

I haven't looked into it yet personally.  I could, but I'm busy on another project at the moment... could you put together a brief project file that demonstrates the error?  I've been thinking this library could use more tests.

I'm also having this issue at the moment.

Also having this issue right now. I wonder if it only occurs when inside a tableviewcell.

Nope, I didn't use a UITableViewCell.

Hi all,
I believe I've fixed this issue, which is in pull request 29.  Anyone who's still having trouble with this, could you give my fork a try and see if that resolves it?

@tyrone-sudeium's pull request #29 should fix this issue. Thanks again, Tyrone!
If anyone is still having problems, even with that patch, please reopen the issue and describe what's going wrong.


🔼 Change upgrade command based on environment variable

Currently if myst is out of date, there is a message to upgrade via npm. If we change this message based on an environment variable, the env var can be set in the python wrapper so the message is correct for python users.

This was completed in #519!


phoronix-test-suite: init at 8.8.1

Motivation for this change
I want to use it to benchmark filesystems and NixOS configurations :)
Some tests work, some need additional dependencies. I will extend it later to support more tests.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Can you give a short list of examples for some tests that work out-of-the-box with that derivation?

First it's helpful to setup batch mode, so you don't have to give names to every single run.
https://dustymabe.com/2012/12/30/running-benchmarks-with-the-phoronix-test-suite/
Then just try some tests:
phoronix-test-suite batch-benchmark pts/iozone pts/compress-7zip
You find all tests with: phoronix-test-suite list-available-tests
They are downloaded and compiled by gcc. Some need extra dependencies, some don't run.
Maybe a FHS environment would help here.
I'm not sure if we should include gcc or document the usage using nix-shell, so you can use different gcc versions and dependencies.
phoronix-test-suite want's to download dependencies itself using the systems package manager like apt. Maybe we can integrate nix shell later. (it's all PHP)

OK, I see where the complication comes in here. I did try to run the cpu test suite (pts/cpu) with nix-shell but some tests fail to compile. That seems more complicated to fix since it would require patching of the build script? How about this: let's merge the base version since it seems to work in principle. You could then open an issue with a list of tests that need to be fixed and we could try fix test-suite by test-suite.

@markuskowa yes, i would merge this in this state since it's already useful.
Then improve in additional PRs.
I will improve the style as you suggested later today.

done


[web]: link to samples in the repo

Add links to https://flutter.github.io/samples/ to...

[ ] Root readme of https://github.com/flutter/flutter_web
[ ] Add a readme to  https://github.com/flutter/flutter_web - /examples

@kevmoo Can I get this done?

@kevmoo Can I get this done?

Sadly, no. We sync from an internal Google code base (in the short term). I'm fixing this now!


Is there any API documentation for fixio?

I am very much new to the Stock exchange market. I just started looking into QuickFix  and when I am searching for that I found this project is very much useful for me. But I didn't found any API documentation. Can anyone provide me the documents, so that I can start as quick as possible. I will be very graceful if anyone can provide me  some more examples than they are already in the project source library. I have already worked with the examples in the library and I can able to see that, only a session is being created.After that nothing is being happening. Can anyone help me how can I place some orders from the initiator to the acceptor and again receive the response back? Some more examples with added order placing will help me a lot. I am very much interested in this project. I am really fed up with QuickFix latency and this the only thing that can help me a lot.
I am also very much new to GitHub. And I am extremely sorry if this is the wrong place to ask such type of questions.

You need to construct order messages and send it to client. Also, you need to process response message in message handler.

@Hema-Chandra If you are not specifically tied to Netty, you might be interested in giving Philadelphia a spin as as well.

@jvirtanen  Thank you. I am not specifically tied to Netty. All I want is a very fast, low latency library. I have a small question. I have seen Philadelphia, and it seems quite interesting. Is this even faster than Netty?

@kpavlov  Thank you sir. Is there any example for constructing order messages? I am really confused in how to construct. A small example can help me a lot sir.

@Hema-Chandra Philadelphia is built on the Java NIO API, so you can directly poll the socket if you want. Furthermore, message reception, parsing, formatting, and transmission are all garbage-free operations. While real-world performance depends on the actual application, simple tests over the loopback interface indicate that Philadelphia's latency figures are close to those of Libtrading, a low-latency FIX engine implemented as a C library.

You can create BUY market order as simple as this:
FixMessageBuilder newOrderSingle = new FixMessageBuilderImpl(MessageTypes.NEW_ORDER_SINGLE);
newOrderSingle.add(FieldType.ClOrdID, "1234");
newOrderSingle.add(FieldType.Side, '1');
newOrderSingle.add(FieldType.OrdType, '1');

newOrderSingle.add(FieldType.Symbol, symbol);
newOrderSingle.add(FieldType.TransactTime, System.currentTimeMillis());

@kpavlov  Thank you very much sir.

@jvirtanen  Thank you very much sir. And one last question. It is an open source library? so that I can just plug it into my code and can modify.

@Hema-Chandra Yes, it's open source under the Apache License, Version 2.0 and you are free to modify it to suit your needs.

@jvirtanen Thank you very much sir


Tooltip on the PageHeader-TagSet-Tag component does not close when clicked on the right of it

Using a PageHeader with a list of tags, when they collapse becase too many and opening the Tooltip on the Tag component does not close when clicked on the right of it (appear also to be on the right of the main Grid container).
Is this issue related to a specific component?
PageHeader (carbon/ibm-cloud-cognitive": "^0.31.0), Grid, Tag,
What did you expect to happen? What happened instead? What would you like to
see changed?
When clicked outside of it the tooltip close. Maybe even when clicked again the tag that open it.
What browser are you working in?
Chrome Version 90.0.4430.93 (Official Build) (64-bit)
What version of the Carbon Design System are you using?
10.25
Steps to reproduce the issue
Open the tooltip and close it in the 4 directions. On the right should not do anything.
Please create a reduced test case in CodeSandbox
https://codesandbox.io/s/shy-sun-0e2ww

@ninjasun I am unable to reproduce this can you reproduce?
P.S. The codesandbox did not work for me.

Not able to reproduce @andrea-gm recommend close.


Update UI Navigation Diagram/Storyboard to reflect changes

Although the design layout is very different, all the functionality is consistent to what we currently have (no major changes are needed yet)


[Governance]  Create and document chain upgrade process + requirements checklist

Once the minimal level of governance and decentralization has been established, Determine and document the step by step process of how we would go about upgrading the chain
This assumes the broad process is:
Improvement Proposal Issue → Discussion in GitHub → PR(s) → GitHub tag and release → Proposal → Referendum → Voting → Enactment
- Update This is basically the process.
Completed:
For these below, see the Release Process on the wiki.
Manual QA is minimized as much as possible but detailed in the release process.

[x] what additional tests, if any, are required to green-light a new GitHub release
[x] what the release process looks like, i.e. how it's tagged and marked ready for release
[x] is there any manual QA, and if so what is it?

For these, see Upgrading Runtime on the wiki.

[x] If using the referendum functionality, when and how to create the proposal on chain
[x] What happens during enactment period

For these,

[x] How upgrades are announced and discussed in GitHub prior to any chain-level governance proposal (e.g. the GitHub issue, a DIP-NNN/DesignDoc, PRs associated with it)
[x] How the changes are documented:  in the Changelog

We will be using Polkassembly (Frequency Mainnet, Frequency Rococo) and the referenda process, combined with GitHub release process, and the changes are in GitHub and shown in the Changelog. Major changes will have the label "change/major"
Not needed:

[x] any handoff process between BC team and DevOps

TO Do/Decide

[ ] Anything we need to do differently if a storage migration is required

References:

v0.9.29->v0.9.30 Code upgrade example

I started this as part of documenting governance planning and launch checklist

Closing as completed except for storage migration process, in a new Issuem #918


Stop running cps-ir tests on the bots

Since work on the cps backend is paused, we will remove testing of it from the buildbots.
@asgerf @sigmundch

Done


Prevents infinite loop in Table._computeColumnWidths

Description
Fixes infinite loop in Table._computeColumnWidths occurring in cases redistributed deficit is so small that the result of dividing it by number of columns available results in 0.0.
This infinite loop resulted in application freezing.
Related Issues
Closes #36256, which is similar to #27083.
Tests
I added the following tests:
Added a regression test in packages/flutter/test/widgets/table_test.dart.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[x] No, this is not a breaking change.

@Piinks could you take another look?

We can ignore the testing-windows failure, that's a known flake.  Once flutter-build is green this can land.


Add config for local cluster

We need a config for hasta in order to test the pipeline with a full scale dataset

https://github.com/nf-core/configs/pull/284


Update rust-selectors

I changed two of your suggestions to stay compatible with the types previously used (both: String => Atom).
Also BTW it appears that you changed Namespace to NamespaceUrl in master.

@SimonSapin This now passes all tests.

I don't really understand why selector doesn't come with some implementation of SelectorImpl.

The point of SelectorImpl is to allow users of selectors to specify things they might want to do differently. But yeah, I suppose there could be a "reasonable default" implementation.

Also BTW it appears that you changed Namespace to NamespaceUrl in master.

Yes, I made another change that turned out to be breaking: recording the namespace prefixes to support serialization. This rename is to disambiguate with the new NamespacePrefix associated type. This is all in version 0.10 which I had neglected to publish on crates.io. I’ve just done so.
(There is no hurry to update to that, old versions stay around.)

Looks good! Please squash into one commit and this is good to go.

You can do this with the GitHub UI, otherwise I will squash tomorrow

Oh that’s right, I forgot about that feature.

Thanks!

Thanks to you as well. Could you also release a new version?
On 17 August 2016 01:18:41 CEST, Simon Sapin<EMAIL_ADDRESS>wrote:

Thanks!
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/SimonSapin/kuchiki/pull/27#issuecomment-240268919

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

v0.3.3 is up.

Thanks!
On 17 August 2016 01:27:12 CEST, Simon Sapin<EMAIL_ADDRESS>wrote:

v0.3.3 is up.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/SimonSapin/kuchiki/pull/27#issuecomment-240270339

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.


lazyLoad not working

I'm not able to preload all pages at once even with lazyLoad is set to false. Here's my Implementation:

I'm also facing this same issue. Even though 'lazyLoad' is set to false, it shows loading icon on each page swipe.

I am also facing the same issue.

facing the same issur

I'm not able to preload all pages at once even with lazyLoad is set to false. Here's my Implementation:

I fix this #65, hope for your help.


Added folder-icon for element, elements

Description
Add folder-icon for 'element', 'elements'
Contribution Guidelines

[x] By creating this pull request, I acknowledge that I have read the Contribution Guidelines for this project.
[x] I have read the Code Of Conduct and promise to abide by these rules

I'm so used to typing 'git add .' that I accidentally committed it, haha.

A file got inadvertently deleted in my commit, an innocent casualty 🤣


Fix typo: Change console.logWarn to console.warn in gltf-exporter.js

Fixes #5949
Updated to console.warn method, as the previous console.logWarn was considered a typo.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

Great, thanks for the report and the fix.

Thanks for the merge!
I'm sorry for the duplication of the Pull Request that you had prepared.


Bug: TurtleSerializer Does Not Properly Group Common Subjects

Despite there being code to do so (here) TurtleSerializer does not properly group triples with common subjects.  It appears to work properly for a graph like the following:
let g :: RDF TList
    g = RDF.empty
      & flip addTriple (triple (unode ":something") (unode "rdf:type") (unode "schema:Document"))
      & flip addTriple (triple (unode ":something") (unode "dc:title") (lnode (plainL "Some title")))

This will serialize to
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
@prefix schema: <http://schema.org/> .
@prefix dc: <http://purl.org/dc/elements/1.1/> .

<:something> <dc:title> "Some title";
	     <rdf:type> <schema:Document> .

(ignore the invalid < and >; this issue is discussed in #97).  But if you create a graph like the following (note the interleaved triple with a different subject):
let g :: RDF TList
    g = RDF.empty
      & flip addTriple (triple (unode ":something") (unode "rdf:type") (unode "schema:Document"))
      & flip addTriple (triple (unode ":another") (unode "rdf:type") (unode "schema:Document"))
      & flip addTriple (triple (unode ":something") (unode "dc:title") (lnode (plainL "Some title")))

you'll get a serialization like:
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
@prefix schema: <http://schema.org/> .
@prefix dc: <http://purl.org/dc/elements/1.1/> .

<:something> <dc:title> \"Some title\" .
<:another> <rdf:type> <schema:Document> .
<:something> <rdf:type> <schema:Document> .

Closed by https://github.com/robstewart57/rdf4h/pull/99


savepoint

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
Cannot map checkpoint/savepoint state for operator 141d3e51f76730254ed522f0ecc3aaed to the new program, because the operator is not available in the new program. If you want to allow to skip this, you can set the --allowNonRestoredState option on the CLI.   修改sql任务后无法基于savepoint重启
What you expected to happen
正常提交代码方式 bin/flink run -s :savepointPath -n [:runArgs] 可以解决  在dlink中应该如何解决
How to reproduce
执行任意sql语句，基于savepoint停止、恢复
Anything else
No response
Version
0.7.1
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

https://stackoverflow.com/questions/56977241/adding-uid-to-operator-causes-cannot-map-checkpoint-savepoint-state-for-operato

https://nightlies.apache.org/flink/flink-docs-master/docs/ops/state/savepoints/#allowing-non-restored-state

我在代码中看到只有这些模式才支持 修改代码恢复  请问yarn-session可以支持吗

All modes support save point recovery.

All modes support save point recovery.

我修改了执行sql之后  然后基于savepoint重启恢复  yarn-session模式下不能恢复  会报我描述的错误

use params execution.savepoint.ignore-unclaimed-state:true
Allows skipping savepoint states that cannot be restored. This operation is allowed if the operator is removed from the pipeline after the savepoint is triggered.
This is not dinky's problem, see the official documentation for details
https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/

use params execution.savepoint.ignore-unclaimed-state:true Allows skipping savepoint states that cannot be restored. This operation is allowed if the operator is removed from the pipeline after the savepoint is triggered. This is not dinky's problem, see the official documentation for details https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/
This parameter has no effect，  my flink version：1.15.3

use params execution.savepoint.ignore-unclaimed-state:true Allows skipping savepoint states that cannot be restored. This operation is allowed if the operator is removed from the pipeline after the savepoint is triggered. This is not dinky's problem, see the official documentation for details https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/

This parameter has no effect， my flink version：1.15.3

use params execution.savepoint.ignore-unclaimed-state:true Allows skipping savepoint states that cannot be restored. This operation is allowed if the operator is removed from the pipeline after the savepoint is triggered. This is not dinky's problem, see the official documentation for details https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/

This parameter has no effect， my flink version：1.15.3

my flink version is 1.15.2,
Where did you add this parameter?

use params execution.savepoint.ignore-unclaimed-state:true Allows skipping savepoint states that cannot be restored. This operation is allowed if the operator is removed from the pipeline after the savepoint is triggered. This is not dinky's problem, see the official documentation for details https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/

This parameter has no effect， my flink version：1.15.3

my flink version is 1.15.2, Where did you add this parameter?

dinky script

use params execution.savepoint.ignore-unclaimed-state:true Allows skipping savepoint states that cannot be restored. This operation is allowed if the operator is removed from the pipeline after the savepoint is triggered. This is not dinky's problem, see the official documentation for details https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/

This parameter has no effect， my flink version：1.15.3

Add in more configuration via dinky's lower-right corner, do not add in sql script

use params execution.savepoint.ignore-unclaimed-state:true Allows skipping savepoint states that cannot be restored. This operation is allowed if the operator is removed from the pipeline after the savepoint is triggered. This is not dinky's problem, see the official documentation for details https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/

This parameter has no effect， my flink version：1.15.3

Add in more configuration via dinky's lower-right corner, do not add in sql script

I'm using session mode

The same goes for a session. You can try it

use params execution.savepoint.ignore-unclaimed-state:true Allows skipping savepoint states that cannot be restored. This operation is allowed if the operator is removed from the pipeline after the savepoint is triggered. This is not dinky's problem, see the official documentation for details https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/

This parameter has no effect， my flink version：1.15.3

Add in more configuration via dinky's lower-right corner, do not add in sql script

I'm using session mode

The same goes for a session. You can try it

set execution.savepoint.ignore-unclaimed-state=true


[Enhancement] Consider replacing string representation for ChainEpoch.

This would work, we just need to make sure to convert a potential try_into error into something readable.
i64::from_le_bytes(self.db.read_bin(SETTINGS_KEY)?.unwrap_or_default().try_into()?)

Edit: Actually, now that I think about it - unwrap_or_default might need to be replaced with 0::to_le_bytes or something along those lines.
Originally posted by @aatifsyed in https://github.com/ChainSafe/forest/pull/4270#discussion_r1583107462

I'm okay with the code as it is. It's readable, and performance doesn't matter.


fuzzy trests for substrate pallet

for grant https://github.com/ComposableFi/Private-Issues-/issues/97

done


MAPI_E_FAILONEPROVIDER == 0x8004011D when openingen mailbox in Online mode

I've seen older issues ablout this topic and followed the workaround (download latest version of MFCMAPI and restart outlook a few times) but after restarting outlook more than 5 times, I still get the same error.

Mailbox is in O365 with cached mode.
MFCMAPI is in online mode.

you don't have an auth token for online cached and MAPI does not provide a way for MFCMAPi to request one. You can build an online profile and use it once in Outlook to get the token cached and then MFCMAPI should work.

Thank you for the answer @stephenegriffin but I don't understand it completely.
What do you mean with "You can build an online profile and use it once in Outlook"?
Do you mean I need to remove the cached option? What if it is blocked by policy?
On the other hand, on another PC using an older 32bit version of MFCMAPI I can connect to the same mailbox.
Thanks in advance for your reply.


WIP: MH-13025: Add workflow API to external API

WIP: do not merge!
This extends the external API with endpoints for workflow instances and definitions. It is still early in the development, but I figured since this is the external API the community should be involved in the design decisions as early as possible. Currently all GET endpoints are implemented and nearly documented.
One question I had during the development is, whether it makes sense to add create, update, and delete endpoints for workflow definitions assuming those endpoints only operate in-memory and don't actually persist workflows as XML in the configuration directory. What do you think?
What is currently missing:

[ ] tests

For the full documentation see the docs/guides/developer/docs/api/workflow-api.md guide.
tl;dr: Extension with the following endpoints:
GET    /api/workflows
POST   /api/workflows
GET    /api/workflows/{id}
PUT    /api/workflows/{id}
DELETE /api/workflows/{id}

GET    /api/workflow-definition
GET    /api/workflow-definition/{id}

I updated the PR with create, update, and delete endpoints for workflow instances. I also removed the preparatory code for write endpoints of workflow definitions. Next, I will work on adding tests.

The functionality and tests are now implemented. There are only a couple of open questions from my side (see inlined TODOs and FIXMEs).

@mtneug Note that I am currently on standby mode. Please let me know once I should continue the review.

@staubesv have we come to a conclusion about event/series metadata? Apart from that, please continue the review.
Looking at your PR #387, I have updated the event_created filter accordingly.
Also, could you comment on wether camelCase, snake_case, or just concatenation should be used for the various API fields (see e.g. GET /api/events: textFilter vs. start_date vs. withmetadata)?

@staubesv thank you for the review!