Plan Status should include a timestamp

Plan(s) for "cassandra-instance" in namespace "sanity-test-namespace":
.
└── cassandra-instance (Operator-Version: "cassandra-99.99.99-testing" Active-Plan: "upgrade")
    ├── Plan deploy (serial strategy) [NOT ACTIVE]
    │   └── Phase nodes (parallel strategy) [NOT ACTIVE]
    │       └── Step node [NOT ACTIVE]
    └── Plan upgrade (serial strategy) [IN_PROGRESS]
        ├── Phase cleanup (serial strategy) [COMPLETE]
        │   └── Step cleanup-stateful-set [COMPLETE]
        └── Phase reinstall (serial strategy) [IN_PROGRESS]
            └── Step node [ERROR] (A transient error when executing task upgrade.reinstall.node.node. Will retry. failed to apply StrategicMergePatch to object sanity-test-namespace/cassandra-instance-node: StatefulSet.apps "cassandra-instance-node" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'template', and 'updateStrategy' are forbidden)

At the moment, the plan status does not include a "last-updated" timestamp, which makes it hard to decide if something is still happening or not.
In this case I assume that I have a transient error which gets resolved after a while, but looking at the manager logs, I see that the repeated execution of the step stops at some point (which is another issues).
What would you like to be added:
Either the aggregatedStatus of the instance or the InstanceStatus itself (or event every Plan/Step/PhaseStatus) should contain a timestamp that tells when the status was last updated.
Why is this needed:
To figure out if KUDO is still working and retrying a plan and when the last update happened from the controller.

PlanStatus already has a LastFinishedRun field, what about using that in the output for example:
Plan(s) for "mysql-instance" in namespace "default":
.
└── mysql-instance (Operator-Version: "mysql-0.3.0" Active-Plan: "deploy")
    ├── Plan deploy (serial strategy) [COMPLETE], last updated 2020-02-15 11:02:42
    │   └── Phase deploy (serial strategy) [COMPLETE]
    │       ├── Step deploy [COMPLETE]
    │       ├── Step init [COMPLETE]
    │       └── Step cleanup [COMPLETE]
    ├── Plan restore (serial strategy) [NOT ACTIVE]
    │   └── Phase restore (serial strategy) [NOT ACTIVE]
    │       ├── Step restore [NOT ACTIVE]
    │       └── Step cleanup [NOT ACTIVE]
    └── Plan backup (serial strategy) [NOT ACTIVE]
        └── Phase backup (serial strategy) [NOT ACTIVE]
            ├── Step pv [NOT ACTIVE]
            ├── Step backup [NOT ACTIVE]
            └── Step cleanup [NOT ACTIVE]

Disregard my previous comment - I did some digging and now realise that LastFinishedRun isn't adequate for what's required here.  Also TIL plan history is a thing.

@ANeumann82 How about something like:
Plan(s) for "mysql-instance" in namespace "default":
.
└── mysql-instance (Operator-Version: "mysql-0.3.0" Active-Plan: "backup", last updated: "2020-02-21 13:05:46")
    ├── Plan deploy (serial strategy) [NOT ACTIVE]
    │   └── Phase deploy (serial strategy) [NOT ACTIVE]
    │       ├── Step deploy [NOT ACTIVE]
    │       ├── Step init [NOT ACTIVE]
    │       └── Step cleanup [NOT ACTIVE]
    ├── Plan restore (serial strategy) [NOT ACTIVE]
    │   └── Phase restore (serial strategy) [NOT ACTIVE]
    │       ├── Step restore [NOT ACTIVE]
    │       └── Step cleanup [NOT ACTIVE]
    └── Plan backup (serial strategy) [COMPLETE], last finished 2020-02-21 13:05:41
        └── Phase backup (serial strategy) [COMPLETE]
            ├── Step pv [COMPLETE]
            ├── Step backup [COMPLETE]
            └── Step cleanup [COMPLETE]

So the summary shows when the status was last updated (I've added a field to AggregatedStatus, and individual plans also show the LastFinishedRun.

Cool, that looks good :)


No completions for external package at first tries (integrated with ycmd)

Please answer these questions before submitting your issue. Thanks!
Also, remember that to restart gocode, you have to run gocode close.
What version of Go are you using (go version)?
go1.11
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/magodo/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/magodo/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/lib/go"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/magodo/projects/udb-v2/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build613089893=/tmp/go-build -gno-record-gcc-switches"
What editor are using?
vim
Description
I substitute mdempsky/gocode with this one in ycmd. I also added -source option for external package completion. It almost works besides when I first open a go file and complete some external package, it will fail with no completions found error. After several (~3 times) retries, it works.

I'm not able to reproduce this when opening files, but if you are opening new Go files, perhaps you are encountering https://github.com/stamblerre/gocode/issues/3?

I'm not able to reproduce this when opening files, but if you are opening new Go files, perhaps you are encountering #3?

No, sometimes when the external package is big/complex, it seems will fail. I think it is caused by some different reason. I don't know how to get the error from vim/ycmd (even i added -debug option for gocode, the output from ycm seems have no help).

Where should the -source option be added for external package completion?

-source is necessary to type-check packages from source (rather than export data from a build), so it shouldn't be necessary for external packages to be completed. The -source flag should be provided on the client side, so you will have to configure it in your editor settings.

Closing this issue, as the current recommendation for autocompletion is to use gopls.


Changed macro if to prevent Errors

this stops MINGW throwing it's toys out of the pram when you try to cross compile

looks good, approved!

thanks


Convert posix scripts to bash

Addresses rust-lang/rust#31036
E: Force was because I saw the file had CRLF, not LF, so fixed.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Sorry but I don't have time to review this, I'd recommend working with folks from rust-lang/rust to review this.

r? @Mark-Simulacrum for now, though it's unlikely that we'll review this before the main rustc PR has a decision made it on it

Closing after it was assessed by the infra team. https://github.com/rust-lang/rust/pull/71932#issuecomment-633134566


Skip Events is not getting triggered on mobile browser

Hi team,
I am not able to trigger any skip Ads event on mobile browser, but the same I am able to do it on desktop
Please let me know, what can be done to trigger this event on mobile browser

Hello @Nishu2696 ,
I am not sure what you mean by triggering skip events. Are you saying that skippable ads are not being returned? Or that the SKIPPED event is not firing when an ad is skipped?
If you could create a reproducible sample, that may also help debug the issue.
Thank you,
Jackson
IMA SDK team


Processor compiler combination required

I have a Binary that was flashed on a processor with below specs.
I am not sure which exact Processor, Bit, Endian, Compiler combinations to use?
Specs
Architecture:             aarch64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:               Little Endian
CPU(s):                      8
On-line CPU(s) list:    0-7
Model:                       0
Model name:             ARMv8 Processor rev 0 (v8l)
Compiler:                  aarch64-gnu-linux GCC compiler
Note: The Binary I am testing is just 1 of the 11 Binaries flashed on this processor.

@astrelsky Thank you for the quick response :)
Sorry for a very delayed follow up, I was caught up with something else.
I had tried as you mentioned. AARCH64 : LE : 64 : v8A : default quite straight forward & tried that, but the result didnt look complete. I could see some functions/instructions it did disassemble well but majority were just "??"
Below is just a snippet of the analyzed Binary. We can see some instructions have been identified while a lot are just "??"

Want to know the reason for this. Is it something I am not selecting right or the input file is not supported or something?


DOC: add a SciPy Code of Conduct.

This code of conduct has been discussed on the mailing list so far (https://mail.python.org/pipermail/scipy-dev/2017-September/022100.html). It starts with an adaptation of the Apache CoC. The later bits about reporting and handling reports are derived from the Contributor Covenant and the Jupyter CoC.

Thanks for clarifying.
On 05 October 2017 10:47:01 Ralf Gommers<EMAIL_ADDRESS>wrote:

rgommers commented on this pull request.

+code of conduct; in particular, it should not be abusive or disrespectful.

+If you believe someone is violating this code of conduct, you may reply to
them
+and point out this code of conduct. Such messages may be in public or in
+private, whatever is most appropriate. Assume good faith; it is more likely
+that participants are unaware of their bad behaviour than that they
+intentionally try to degrade the quality of the discussion. Should there be
+difficulties in dealing with the situation, you may report your compliance
+issues in confidence to either:
+
+- The SciPy Code of Conduct Committee, at conduct@TODO (preferred)

Members of this committee are TODO

+Or alternatively to:
+
+- Chair of the SciPy Steering Committee: Ralf Gommers
These are kept separate on purpose in case someone does not want to contact
the Code of Conduct Committee for some reason (e.g. one of the members of
that committee is involved).
I could be on the CoC committee, but don't have to be. Leah shouldn't be on
the CoC committee, she's not really part of the project - she's there as
NumFOCUS director to have an outside contact in case someone feels they
can't contact any of the SciPy committee or leadership.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/scipy/scipy/pull/7963#discussion_r143008622

Looks good to me, I don't have further input.

Thanks for the detailed comments Stefan. I took over pretty much all your suggestions unchanged in the last commit.

It looks like my comments got crossed with the last commit, and one of my longer comments is marked as "outdated", though I think it still applies. So please do click "show outdated" there :-)

Ralf - thanks for your sympathetic reading - all your changes are fine with me.

Updated for all comments and for today's discussion on Google Hangouts. Also created<EMAIL_ADDRESS>

I've mostly been silent but just adding my +1 to the general state of things with CoC and the (obviously passionate) efforts that many have put in here based on the PR/ mailing list / discussion yesterday.

Current readable.io scores
CoC doc / enforcement manual are about the same: C for readability; grade level 11.3 / 12.6, fairly strongly male, somewhat formal.  Advice for both "You are using too many long words. Try replacing some of them with shorter alternatives.".
Still a fair amount of passive tense as well.  But - it could be worse, especially since we've used the Contributor's Covenant, which is an E.

releasing soon ?

releasing soon ?

tomorrow

Okay, last comments addressed, hitting the green button. Thanks all!

Congratulations! And thanks all for the civilized discussion.

backport to 1.0.x in gh-8070

Thanks a lot for your patience - and sorry for testing it.   As I said in the phone call - I think this is the best code of conduct is the best I've seen so far, and a large part of that is the result of the calm and reasonable way that you managed the process.

I am happy with this document.  It shows the community's desire to be approachable, inclusive, and friendly, and a willingness to take action to keep it that way and to remove bad actors.
Thank you @rgommers for guiding the discussion, and @matthew-brett, @njsmith, et al. for input.


gpt2 contiguous fix

What does this PR do?
change tensor to contiguous after split heads and before attention for gpt2
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

With generation task, max_new_token=100 and bs=100
Before:
Throughput (including tokenization) = 13081.375516379572 tokens/second
Memory allocated                    = 1.94 GB
Max memory allocated                = 28.02 GB
Total memory available              = 94.46 GB
Graph compilation duration          = 3.4164320450508967 seconds
After:
Throughput (including tokenization) = 25008.293587717493 tokens/second
Memory allocated                    = 2.09 GB
Max memory allocated                = 3.48 GB
Total memory available              = 94.46 GB
Graph compilation duration          = 2.0869328420376405 seconds

After these changes:

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

LGTM!
The code style check failed, could you run the following from the root of the repo to make sure it passes please?
pip install --upgrade black ruff
make style

Got it, thanks!

@BaihuiJin comments added, please have a look

@regisss let's merge this PR?


Memory leak in Microsoft ODBC Driver 17.10.5 for SQL Server

This is a report regarding a bug in the odbc driver. I'm writing here because I don't know the appropriate place to report it.
(I also posted it here. https://learn.microsoft.com/en-us/answers/questions/1418766/memory-leak-in-microsoft-odbc-driver-17-10-5-for-s)
The following code:
// odbc.c
#include <sql.h>
#include <sqlext.h>
#include <string.h>

int main(void) {
    HENV env;
    HDBC db;
    char *dsn = "Driver={ODBC Driver 17 for SQL Server};Server=sql-server;Port=1433;Database=test;uid=SA;pwd={/* pass */};"; // myenv
    SQLCHAR dsnbuf[1024];
    short dsnbuflen;

    SQLAllocEnv(&env);
    SQLAllocConnect(env, &db);
    SQLDriverConnect(db, NULL, (SQLCHAR*) dsn, strlen(dsn), dsnbuf, sizeof(dsnbuf) - 1, &dsnbuflen, SQL_DRIVER_NOPROMPT);

    SQLDisconnect(db);
    SQLFreeHandle(SQL_HANDLE_DBC, db);
    db = NULL;

    SQLFreeHandle(SQL_HANDLE_ENV, env);
    env = NULL;

    SQLAllocEnv(&env);
    SQLAllocConnect(env, &db);
    SQLDriverConnect(db, NULL, (SQLCHAR*) dsn, strlen(dsn), dsnbuf, sizeof(dsnbuf) - 1, &dsnbuflen, SQL_DRIVER_NOPROMPT);

    return 0;
}

compile command:
gcc -fsanitize=leak,undefined,address -fno-sanitize-recover -DZEND_TRACK_ARENA_ALLOC -Wall -o odbc odbc.c -lodbc

exec:
# ./odbc

=================================================================
==12092==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x7fd55793e587 in operator new(unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cc:104
    #1 0x7fd5532728da  (/opt/microsoft/msodbcsql17/lib64/libmsodbcsql-17.10.so.5.1+0x1808da)

Indirect leak of 88 byte(s) in 1 object(s) allocated from:
    #0 0x7fd55793e587 in operator new(unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cc:104
    #1 0x7fd5531fa909  (/opt/microsoft/msodbcsql17/lib64/libmsodbcsql-17.10.so.5.1+0x108909)

SUMMARY: AddressSanitizer: 112 byte(s) leaked in 2 allocation(s).

In this way, once I close the connection and connect it again, I will get a memory leak.
Regards.

Which operating system are you running this on, and what's the version of unixODBC?

@v-makouz
ubuntu:20.04 (docker for mac)

# odbcinst --version
unixODBC 2.3.6

Regards.

I can reproduce the leak, and it looks like it was fixed in ODBC Driver 18. If possible, I would recommend using Driver 18, if not the next release of Driver 17 (with the fix) would probably be next year.

Thank you!


[Tuto] Combine custom font with splitTextToSize

Note by Aras:
Deleted this text because it is a total misleading "tutorial".

In what ways was my text misleading ? People were searching for a solution like mine for months. What did confuse you, isn't clear enough ?

Well the problem is that you even don't understand which typographical BS you recommended to us. If the splitTextToSize-method is bugged, which I doubt, then I have to fix splitTextToSize-method and not recommend some thing called "solution" which in fact gives false results.
Easiest example:
Use a customfont which is a monospace font. If I use your "solution" I would use Helvetica letter widths and kernings and the text would be split wrong. Or use any font which has wider oder thinner letters, more or less kerning than Helvetica.
The splitTextToSize-method uses for custom fonts a method supplied by the TTFFont class so that we get accurate widths.
Hope this helps to understand "my" confusion

D!ckfight in 3..2..1 Letting everyone know how long is your d!ck; Your aggressivity shows how low is your self-confidence, monospace font letter's width was indeed so nothing new, keep in mind that yall been searching for my SOLUTION for months so you're welcome bro

The size of my genitals doesnt matter. What matters is the useability and quality of your solution. I wrote in the meanwhile unit tests for splitTextToSize when using custom fonts. Could not write earlier unit tests for it, because I had fixed just last week or two weeks ago the custom fonts module to be unit testable. And what I saw was that the method is working without any flaws for custom fonts. So even if we ignore the fact, that your workaround is totally typographically useless, your "solution" is not the answer for a monthlong researched question. When I fixed the issue #1719 i had a solid solution for that issue.
The only thing i will research more is if the pageunit is messing up with the methods. But that's it.
If you want you can restore your poorly written solution on stack overflow or on your personal blog. If you want to contribute here, you are welcome. But let it be said, that we want here quality not something coded were you already know that it is flawed, as you self confessed that monospace is breaking your solution.
Etc.etc.

Helping people to solve this issue IN THE MEANWHILE YOU WRITE the unit tests. Just wanted to help or bring something to the project.  You're that kind of dude that will share anything on stack or your personal blog to feed your ego, I'm not. See, I brang a solution that works for the current version of the projet.


text.diff not working with Nord Theme

I noticed I get no syntax highlighting when tree-sitter-diff is active.
It appears that these are not set https://github.com/nvim-treesitter/nvim-treesitter/issues/4097#issuecomment-1374556679

Playing around with some highlights, it seems that parser provides less specificity than the default highlight groups. Meaning that without that parser, you can have better diff highlighting.


Toggle for branch comparison does not work

GitLens Version:
v11.5.1
Git Version: Run git --version
git version 2.31.1.windows.1

VSCode Version: Run code --version
1.57.1
507ce72a4466fbb27b715c3722558bb15afa9f48
x64
OS Version:
Windows_NT x64 10.0.19042
Steps to Reproduce:

I see no toggle icon within branch comparison section when hovering over it.

Moreover, if I change the option to compare the current branch it still shows the comparison between the working tree.

Thanks.

This feature seems to be working only for the new branches. So, when I check out to a new branch and choose another one to be compared with then there is no way to change a branch for comparison. Is this expected or am I doing something wrong?

Same here.

Gitlens: v11.5.1
Git: v2.20.1
VSCode : 1.57.1
507ce72a4466fbb27b715c3722558bb15afa9f48
x64
WSL2 Ubuntu 20.04

(Also happens when running VSCode natively, Windows 10 Pro 10.0.19042 Build 19042 ).

This still works properly in version 11.4.1

Duplicate of #1545


Use react component as prop

I would like to pass a react component as a prop, but I could not find a way using the current implementation. After reading the code, my solution would be to create a custom converter to serialize an IReactComponent to "React.craeteElement(..., ...)".
Any suggestions?

Using webpack, you can import the component to others over props. Besides that, you can import third-parties :D

@daiduongbian44 how can import third-parties in reactjs.net?can you give a example?

@doterme yep, let's download webpack and npm, each components that you should put on one file (maybe .js or .jsx). In a component, we could use require function of nodejs to import third-parties. Ex: `var React = require('react');
var Slider = require('react-slick');
var SimpleSlider = React.createClass({
render: function () {
var settings = {
dots: true,
infinite: true,
speed: 500,
slidesToShow: 1,
slidesToScroll: 1
};
return (
<Slider {...settings}>
1
2
3
4
5
6

);
}
});`
then using webpack to bundle your components to one file. This file will be import to ReactConfig
P/s: Example copy from here: https://github.com/akiran/react-slick

@daiduongbian44 What I mean is to pass an IReactComponent as a property. The IReactComponent will be created in C#, not in JS.

Closing issues older than a year, please re-open if you think this is still relevant.


Does not work with React v15.2.0

ERROR in ./frontend/~/react-three-renderer/lib/React3Renderer.js
Module not found: Error: Cannot resolve module 'react/lib/getNativeComponentFromComposite' in /Users/daniel/Documents/Code/x/frontend/node_modules/react-three-renderer/lib
 @ ./frontend/~/react-three-renderer/lib/React3Renderer.js 65:39-91

using react-three-renderer v2.1.3 and react v15.2.0

Thanks for the report, I will update the lib ASAP

Still working on this, getting some progress, still need to fix the annoying unkown prop warnings...

Hey,
Would you mind providing versions of react-three-renderer and react that are compatible? I installed react-three-renderer today and I was given this same error.
Thanks in advance.

Latest react three renderer should work with<EMAIL_ADDRESS>On Fri, 15 Jul 2016, 17:23 bitten<EMAIL_ADDRESS>wrote:

Hey,
Would you mind providing versions of react-three-renderer and react that
are compatible? I installed react-three-renderer today and I was given
this same error.
Thanks in advance.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/toxicFork/react-three-renderer/issues/85#issuecomment-232999268,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0iLXit1tId5pct7zRnBbfhPqvg5imjks5qV7QVgaJpZM4JEqpA
.

Great, thanks. And thanks for the quick reply!

2.2.0 should fix this :)


Upgrade to google-cloud-cpp-common-${NEXT}

The next version of google-cloud-cpp-common has some incompatible changes, we need to test this repository with that version, before we create the -common release.

Done in #3366.


[Critical] - Find Relief camp drop down button retuns no data

Subject of the issue & Steps to reproduce
Describe your issue here.

Visit  Relief Camps | ദുരിതാശ്വാസ ക്യാമ്പുകൾ  Page
Select a district name
No data is shown on template

Tell us how to reproduce this issue. Please provide a working demo as a GIF, if possible.

I believe this page is accessed many people at a time.

I can only see data when selecting Thrissur. I guess it is not a programmatic problem, rather a lack of data problem.

how shall i help @bobinson

fixing the issue

ok @bobinson

@jose2007kj Are you working on this?

@remedcu - Wondering how can Thrissur have like 15 relief camps registered and no other district has anything listed!

no shall i test this

@jose2007kj No pull request yet, I am afraid.

@jose2007kj Please share the fix lets test it if it goes well we can go ahead

Looks like data needs to be populated.
Can anyone help with that?

Is there some way to copy the data from here?
Kerala Flood Resource - Google Map
I was able to export the kml file and convert it to csv. But the lat_long data was not available.

Not a issue. Yet to add data from ground

@namboodiri can we use Google APIs to pull the information https://cloud.google.com/maps-platform/products/


Optimize Webpack script

Pull Request Test Coverage Report for Build 119

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.952%

Totals

Change from base Build 118:
0.0%

Covered Lines:
265

Relevant Lines:
284

💛  - Coveralls


Convert ICMP subtypes selector control in fw_rules_edit.php as suggested, and refactor jscript a little

See PR #3328 for background.
This PR converts the new ICMP subtypes selector in firewall_rules_edit.php from a single multi-select list box to a double selector, as suggested by @jim-p, which leaves it clearer and more obvious which items are selected, without adding a list of checkboxes.
It does indeed improve the form.
I hope no "junk" or merge conflicts have made it into this, I have worked from a copy-paste of the current code, but mistakes are always possible.
I also refactored the javascript by collecting all functions and all on load activities together ("like with like") for convenience of devs in future. However all code except that directly controlling ICMP subtype selection should be unchanged.
The only functional change to the form is that it now returns icmptype as a comma separated string via a hidden control, rather than as an array of elements from the list box (as in the example suggested by @jim-p in the original PR). This made the code simpler, because the source data for the "selected" list box was already generated from a JS array anyhow, and the data in $config is in that format.

Self-note as being dragged away - to double check that if existing icmp rule has icmptype unset or empty string, it interprets this as "all subtypes selected" rather than "none selected". I assumed this as existing code worked, but now feel I want to double-check,

@stilez please rebase your fork to make this patch ok to apply for testing

@rbgarga - done

thanks @jim-p. can you take a look at the review point I mentioned above and reassure me if its catching all it needs to, or any fixes needed? (Ii want to be sure old configs won't have issues if icmptype is blank or unset on existing/associated rules, obviously.)

I didn't try that case, but I tried setting a few other flags before applying the patch and it seemed to read those OK.
It seems to treat an old "any" selection as none being selected, and then gives an error on save. It could allow none to be selected and still treat that as any/all, since selecting nothing makes no sense, and someone who doesn't care isn't likely to want to select all before saving.

I'll look at and fix that but not today, thanks jim

Reset review while we wait new commit

@rbgarga  @jim-p  - Done. 3 places where icmptype is pulled from old data, clearly should be doing the same kind of check on all 3 of them as well, so I moved the check into a separate function and added detection of "any" to it. Should work now - does it? :)

2 x review points fixed

I nreed to look at that last again. Just setting to empty string isn't necessarily a fix (I did it in a rush). (And if it's referring to an existing rule, or existing associated rule, how can ['ipprotocol'] not be set and valid....?)

Try that :)

Typo fixed. Grumble grumble

I'm really not happy with "select none means all types".
It means having multiple ways to enter and represent the same thing in the config, and also in the UI, which is rarely a good idea, and increases complexity and risk of code error.
Also, the only options supported in rules previously were "all types" or "one specific type only", so empty/unset==all made sense and it was an obvious dropdown box and config choice. With multiple choice, some quick way to choose "all types" is needed.  But I don't think defaulting to "empty selection means all selected" makes sense or is the way to go, and it's very counterintuitive in the UI.
Instead this UI offers a very standard, very intuitive "select all" button. One click gets all valid types, and it's clear all types are selected because the left hand list of unselected types is empty. I think we could break from the past UI to that extent, and it's much clearer at a glance. I just don't think that a single click on "select all" is likely to be any kind of problem or annoyance, at most it'll take a few moments for existing users to notice and click "select all" to select all, the first time they see the rules page.
Can you try it a bit more - I just think it's a cleaner approach this way, both code and UI.

An existing 'any' icmp type rule has nothing selected when loaded, so the behavior must be preserved. Other areas operate the same way (e.g. selecting no interfaces in some places binds to all). That's the preferred behavior, making the default what people expect/want.

I hope this is a reasonable approach - I've fixed it so thsat if there wasn't an icmptype selection (which is the only way the SELECT box can be created with an empty list), then all icmptypes are pre-selected and it's displayed as all selected. If something was selected then the code change has no effect.
I don't have a copy of a sample old config to test this against, if this works then good, if not can you attach a sample config I can debug against to this PR, or email it to me? Thanks.

Issues fixed I think?

I haven't had a chance to test it again yet, been wrapped up in 2.3.3 stuff and other things. I'll get to it today.

Getting closer...
It doesn't work with a rule that had "any" selected previously
<icmptype>any</icmptype>

@jim-p try that. Now recognises and handles correctly, the case you gave, of any in an older ICMP rule.

@jim-p :

Done,

Intended behaviour, due to the way that each ipproto has different but overlapping sets of icmptypes that could be valid.

When the user switches to a new ipprotocol, one could add logic that says "if all types were selected for the old ipproto, then automatically select all types valid for the new ipproto after the switch". Would that be the sort of thing you're after?

I had a rule with 'any' from before this change, editing the rule and saving it lost the 'any' and now shows all types in the list. A new rule works the same way, so the 'any' detection bit doesn't seem to work for me.

Yeah that sounds good, if it was 'any' before then switching protocols should have everything selected.

@jim-p I'm away the weekend and VM store is fiddling in the background. Found one other place to simplify (see previous commit) and will deal with above shortly

No worries, take your time

Please resolve conflicts and review the state of this PR

In an effort to improve the tracking of changes and bug/feature requests, we have decided to require an entry on the pfSense Redmine issue tracker associated with every pull request, and likewise the Redmine entry should also have a link back to the pull request.
If you could, please associate this PR to a Redmine issue either by locating an existing issue at https://redmine.pfsense.org or by creating a new issue. Add a link to the Redmine issue that points to this PR, and also add a link on the PR to the Redmine issue.
For more information, see https://doc.pfsense.org/index.php/Submitting_a_Pull_Request_via_Github
Thanks!

No resolution in 10 months. Please resubmit if still required.


Added configuration for Docker

I added the ability to deploy a container with your application.
How to work with it is written in the readme
I checked the work on arm64 and amd64, I think there will be no problems on other platforms. Thanks to self-assembly of the container

Hi!
I'd like to keep this repository's contents as KISS and true to its name as possible. There is another repository with a PoC docker config here, and I'm thinking I'd like to keep it separate in the future as well.
I'd wouldn't mind PRs against that repo though. It could really do with some more effort put into it :upside_down_face:
I have a few comments anyway:

CGI is a performance concern
There is no accounting for different configuration values as far as I can make out(?) People will want to set those. And setting upload_max_filesize to a fixed 2048M etc. is kind of bad.
Lots and lots of unnecessary stuff in php.ini in general
apk add stuff could be consolidated to one RUN
Not sure what php-dom is for, and considering config values should be changeable, the "fileinfo" module would be a good thing to have.
What's up with the values for static-file.exclude-extensions and index-file.names?

Feel free to contribute to my docker repository. It's not yet mentioned in the readme, because it's a PoC I threw together in like 1 afternoon and I don't use docker to host this myself. If it got a bit more mature(?), I'd link it.
Btw. getting rid of the php config and using sed instead is a good call, but you're still hard-coding config values. I get around that by using a shell script as an entry point: https://github.com/Rouji/single_php_filehost_docker/blob/master/entry.sh


Greatly decrease the amount of Chat Color config options

The sheer amount of config options makes it daunting to try and find the config you're looking for, and the clients lack of a way to display them in a user-friendly way doesn't exactly make it better.
Ways this could be decreased include bundling transparent and opaque chat, and making the highlights the same

This is a very old issue at this point, but since it's still open and the grouping has been implemented, I'd like to suggest removing "(transparent)" from the transparent setting names / description strings, since they are under a separate section now.
Further grouping based on the type of chat that the color config relates to (e.g. public, clan, friend, etc.), might be nice, too.


Occurrances Panel

Show the occuranes of the token in the draft text see

Show reference and draft text in each row, show 5 by default in a page,
Have 2 icons also next to the reference as in image below

on clicking the first icon call a function openSource(projectId, book,chapter) take from props
on hovering over the 2nd icon show the source text in a tooltip as in image above,
Show the token in bold in all the occurances and tooltip as in image

Have 3 props for this component
1- token - Judah (String)
2- book reference - Micah (String, Book)
3- Current Occurance - 1(integer, occurance)


Allow splitting USARTs

This PR implements a split method on USARTX, much like in other HAL crates.
Currently, only samd51 is implemented. Once we're confident that this implementation is good, I can generalize it to the other variants.

I briefly reviewed this and everything seems pretty reasonable. I noticed a few TODOS, etc. in there but I'm sure you're aware, not sure how many pre-date your changes.
I did some testing on the ATSAMD51P19A, and (at least for the things I tried) it seems to be working! I'd like to get another set of eyes on this if possible, but so far things are looking good.

What's the status of this? No rush or anything, I just wanted to check if you are still able/willing to complete this. No worries if not, of course.

Oh, I was originally thinking I'd wait to finish until the USART stuff was refactored to use the new GPIO interface, and then I kinda forgot about this for a while. I'm still around and willing to finish this, though.

Haven't tested this on hardware (my Wio Terminal has a flaky USART, and I'm not even sure where I put it at the moment), but I think it's ready.

Oops, forgot about this PR sitting at the bottom of the list. Would you mind making a quick example I can test for metro m4?

OK, I just added a method to allow re-joining the split halves. I think that's everything for this PR.

OK, I just added a method to allow re-joining the split halves. I think that's everything for this PR.


HDFS-17267. Client send the same packet multiple times when method markSlowNode throws IOException.

Description of PR
Since we have HDFS-16348, we can kick out SLOW node in pipeline when writing data to pipeline.
And I think it introduced a problem, that is the same packet will be sent twice or more times when we kick out SLOW node.
The flow are as below:
1、 DFSPacket p1 is pushed into dataQueue.
2、DataStreamer takes DFSPacket p1 from dataQueue.
3、Remove p1 from dataQueue and   push p1 into ackQueue.
4、sendPacket(p1).
5、In ResponseProcessor#run,  read pipelineAck for p1.
6、We meet SlOW node,  so method markSlowNode throw IOException and does not execute ackQueue.removeFirst();.
7、In next loop of DataStreamer#run, we come into method processDatanodeOrExternalError and execute dataQueue.addAll(0, ackQueue);.
8、the p1 will be sent repeatedly.
We can debug the unit test method testPipelineRecoveryWithSlowNode to verify this PR.
Set breakpoint in DataStreamer#run : LOG.debug("{} sending {}", this, one);.
We can see the DFSPacket with seq=3 sends twice.
BTW, on datanode side. It will not write packet data twice, because if will compare the onDiskLen and offsetInBlock in method receivePacket(). if onDiskLen >= offsetInBlock, there will not happen writing data behavior.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
6m 44s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 42s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 16s

trunk passed

+1 :green_heart:
compile
2m 52s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
2m 50s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 42s

trunk passed

+1 :green_heart:
mvnsite
1m 12s

trunk passed

+1 :green_heart:
javadoc
1m  3s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m  4s

trunk passed

+1 :green_heart:
shadedclient
20m 35s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m  5s

the patch passed

+1 :green_heart:
compile
2m 47s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
2m 47s

the patch passed

+1 :green_heart:
compile
2m 42s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
2m 42s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 2 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
0m 36s

the patch passed

+1 :green_heart:
mvnsite
1m  2s

the patch passed

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 20s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 12s

the patch passed

+1 :green_heart:
shadedclient
20m 34s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 51s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
187m 11s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

298m 32s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6311

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 3f0e01bdd62e 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c3694bfd1c69dce0da12ab9001f360a4147477d4

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/1/testReport/

Max. process+thread count
4021 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
7m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 37s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m  3s

trunk passed

+1 :green_heart:
compile
3m 28s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
3m 14s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 47s

trunk passed

+1 :green_heart:
mvnsite
1m 18s

trunk passed

+1 :green_heart:
javadoc
1m  4s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 29s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 31s

trunk passed

+1 :green_heart:
shadedclient
21m 27s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
3m 35s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
3m 35s

the patch passed

+1 :green_heart:
compile
3m 30s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
3m 30s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 2 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
0m 40s

the patch passed

+1 :green_heart:
mvnsite
1m  9s

the patch passed

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 38s

the patch passed

+1 :green_heart:
shadedclient
21m 35s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 50s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
185m 27s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 27s

The patch does not generate ASF License warnings.

304m 10s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestDFSStripedOutputStreamWithFailure

hadoop.hdfs.TestDistributedFileSystemWithECFile

hadoop.hdfs.server.namenode.TestReconstructStripedBlocks

hadoop.hdfs.TestUnsetAndChangeDirectoryEcPolicy

hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks

hadoop.hdfs.TestDecommissionWithStripedBackoffMonitor

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6311

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 9eac047cf9f5 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c3694bfd1c69dce0da12ab9001f360a4147477d4

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/2/testReport/

Max. process+thread count
4377 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
7m  3s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 37s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 39s

trunk passed

+1 :green_heart:
compile
3m 32s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
3m 20s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 46s

trunk passed

+1 :green_heart:
mvnsite
1m 16s

trunk passed

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 30s

trunk passed

+1 :green_heart:
shadedclient
21m 14s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
3m 26s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
3m 26s

the patch passed

+1 :green_heart:
compile
3m 22s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
3m 22s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 2 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
0m 37s

the patch passed

+1 :green_heart:
mvnsite
1m  9s

the patch passed

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 24s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 36s

the patch passed

+1 :green_heart:
shadedclient
21m 29s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 50s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
190m 31s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

308m 23s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

hadoop.hdfs.TestUnsetAndChangeDirectoryEcPolicy

hadoop.hdfs.TestReconstructStripedFileWithValidator

hadoop.hdfs.TestDecommissionWithStripedBackoffMonitor

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6311

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux b027b640c9fc 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c3694bfd1c69dce0da12ab9001f360a4147477d4

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/3/testReport/

Max. process+thread count
4233 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 34s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 26s

trunk passed

+1 :green_heart:
compile
2m 54s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
2m 46s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 43s

trunk passed

+1 :green_heart:
mvnsite
1m 15s

trunk passed

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 33s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 56s

trunk passed

+1 :green_heart:
shadedclient
20m 29s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m  2s

the patch passed

+1 :green_heart:
compile
2m 46s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
2m 46s

the patch passed

+1 :green_heart:
compile
2m 44s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
2m 44s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 34s

the patch passed

+1 :green_heart:
mvnsite
1m  6s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 19s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 10s

the patch passed

+1 :green_heart:
shadedclient
20m 29s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 51s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
187m 30s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 30s

The patch does not generate ASF License warnings.

292m 57s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6311

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 3571ec18557f 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 17f321a14c40ac9427bd1116ebbd2389e9f2a7da

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/4/testReport/

Max. process+thread count
4105 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

the failed unit tests were passed in my local. It seems unreleated with this PR.

@Hexiaoqiao @tomscut @zhangshuyan0 Sir, could you please help me review this code when you have free time? Thanks a lot.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
6m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 40s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 34s

trunk passed

+1 :green_heart:
compile
2m 55s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
2m 46s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 46s

trunk passed

+1 :green_heart:
mvnsite
1m 14s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 29s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m  9s

trunk passed

+1 :green_heart:
shadedclient
20m 38s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m  2s

the patch passed

+1 :green_heart:
compile
2m 49s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
2m 49s

the patch passed

+1 :green_heart:
compile
2m 42s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
2m 42s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 35s

the patch passed

+1 :green_heart:
mvnsite
1m  2s

the patch passed

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 22s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m  7s

the patch passed

+1 :green_heart:
shadedclient
20m 37s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 49s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
186m 58s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

299m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6311

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 20d321195b42 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ec10b91fd9e54fd0444c189917bcf3dfee68a79d

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/5/testReport/

Max. process+thread count
4388 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 22s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m  9s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 21s

trunk passed

+1 :green_heart:
compile
2m 58s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
2m 44s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 44s

trunk passed

+1 :green_heart:
mvnsite
1m  8s

trunk passed

+1 :green_heart:
javadoc
1m  4s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m  1s

trunk passed

+1 :green_heart:
shadedclient
20m 30s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m  0s

the patch passed

+1 :green_heart:
compile
2m 50s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
2m 50s

the patch passed

+1 :green_heart:
compile
2m 46s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
2m 46s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 37s

the patch passed

+1 :green_heart:
mvnsite
1m  3s

the patch passed

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 19s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m  6s

the patch passed

+1 :green_heart:
shadedclient
20m 43s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 50s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
181m 29s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

286m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6311

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux e1393099b340 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e689dec0ebfaaacd2dee139fb64b2945613add28

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/6/testReport/

Max. process+thread count
5010 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Indeed, there is another way of implementing.  We throw a SlowDataNodeException which defined by us, and catch this kind of Exception, remove packet from ackQueue.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 38s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 15s

trunk passed

+1 :green_heart:
compile
2m 56s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
2m 46s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 43s

trunk passed

+1 :green_heart:
mvnsite
1m 16s

trunk passed

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 32s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m  0s

trunk passed

+1 :green_heart:
shadedclient
20m 28s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m  2s

the patch passed

+1 :green_heart:
compile
2m 46s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
2m 46s

the patch passed

+1 :green_heart:
compile
2m 46s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
2m 46s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 35s

the patch passed

+1 :green_heart:
mvnsite
1m  1s

the patch passed

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 22s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m  9s

the patch passed

+1 :green_heart:
shadedclient
20m 20s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 49s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
189m 46s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 27s

The patch does not generate ASF License warnings.

294m 13s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6311

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 557e59a81cb3 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 633bbb1717600d019cf22b44746087580b295aa2

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/7/testReport/

Max. process+thread count
4728 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 22s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 13s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 43s

trunk passed

+1 :green_heart:
compile
3m 28s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
3m  7s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 49s

trunk passed

+1 :green_heart:
mvnsite
1m 21s

trunk passed

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 18s

trunk passed

+1 :green_heart:
shadedclient
21m 57s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m  8s

the patch passed

+1 :green_heart:
compile
3m 22s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
3m 22s

the patch passed

+1 :green_heart:
compile
3m  2s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
3m  2s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 45s

the patch passed

+1 :green_heart:
mvnsite
1m 10s

the patch passed

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 26s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 32s

the patch passed

+1 :green_heart:
shadedclient
21m 55s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 53s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
185m 21s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 24s

The patch does not generate ASF License warnings.

297m 33s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy

hadoop.hdfs.TestUnsetAndChangeDirectoryEcPolicy

hadoop.hdfs.TestReadStripedFileWithDNFailure

hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes

hadoop.hdfs.TestDecommissionWithStripedBackoffMonitor

hadoop.hdfs.TestDFSStripedOutputStream

hadoop.hdfs.TestPread

hadoop.hdfs.TestEncryptionZonesWithKMS

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6311

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 64c64aaa4551 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3c0d085e232b6d50a678879ddf3e4bdda60c07e5

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/9/testReport/

Max. process+thread count
4550 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 21s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m  7s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 28s

trunk passed

+1 :green_heart:
compile
2m 52s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
3m 26s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 48s

trunk passed

+1 :green_heart:
mvnsite
1m 21s

trunk passed

+1 :green_heart:
javadoc
1m 17s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 35s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 24s

trunk passed

+1 :green_heart:
shadedclient
21m 49s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m  7s

the patch passed

+1 :green_heart:
compile
3m  4s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
3m  4s

the patch passed

+1 :green_heart:
compile
3m 23s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
3m 23s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 35s

the patch passed

+1 :green_heart:
mvnsite
1m 12s

the patch passed

+1 :green_heart:
javadoc
1m  4s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 26s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 32s

the patch passed

+1 :green_heart:
shadedclient
22m 18s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 47s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
206m  1s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 29s

The patch does not generate ASF License warnings.

318m  8s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy

hadoop.hdfs.TestDFSStripedInputStream

hadoop.hdfs.TestReadStripedFileWithDecoding

hadoop.hdfs.TestDFSStripedOutputStream

hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy

hadoop.hdfs.TestErasureCodingPolicies

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6311

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 11467317b2ab 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3c0d085e232b6d50a678879ddf3e4bdda60c07e5

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/8/testReport/

Max. process+thread count
3770 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 21s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 46s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 28s

trunk passed

+1 :green_heart:
compile
2m 55s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
2m 49s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 46s

trunk passed

+1 :green_heart:
mvnsite
1m 12s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 29s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m  0s

trunk passed

+1 :green_heart:
shadedclient
20m 16s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m  2s

the patch passed

+1 :green_heart:
compile
2m 48s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
2m 48s

the patch passed

+1 :green_heart:
compile
2m 43s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
2m 43s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 34s

the patch passed

+1 :green_heart:
mvnsite
1m  4s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 21s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 13s

the patch passed

+1 :green_heart:
shadedclient
20m 25s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 48s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
187m 56s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

293m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6311

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux a7737ef5daa9 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 318bb6cf9ee37248ef46887b2c17b0d961a01b9a

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/10/testReport/

Max. process+thread count
4254 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 23s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 29s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 47s

trunk passed

+1 :green_heart:
compile
2m 59s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
2m 54s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 41s

trunk passed

+1 :green_heart:
mvnsite
1m 17s

trunk passed

+1 :green_heart:
javadoc
1m  1s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m  1s

trunk passed

+1 :green_heart:
shadedclient
20m 20s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m  7s

the patch passed

+1 :green_heart:
compile
2m 51s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
2m 51s

the patch passed

+1 :green_heart:
compile
2m 46s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
2m 46s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 37s

the patch passed

+1 :green_heart:
mvnsite
1m  7s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 20s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m  7s

the patch passed

+1 :green_heart:
shadedclient
20m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 51s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
184m 43s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 27s

The patch does not generate ASF License warnings.

290m 33s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy

hadoop.hdfs.TestErasureCodingPolicyWithSnapshot

hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6311

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux b0035275bc85 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 67870e486b3faeb19c39c3274c86045a8af4fc63

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/12/testReport/

Max. process+thread count
4919 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/12/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
18m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 53s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
30m 50s

trunk passed

+1 :green_heart:
compile
5m 27s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
5m 11s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 20s

trunk passed

+1 :green_heart:
mvnsite
2m 17s

trunk passed

+1 :green_heart:
javadoc
1m 51s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 21s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
5m 43s

trunk passed

+1 :green_heart:
shadedclient
34m 39s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 57s

the patch passed

+1 :green_heart:
compile
5m 18s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
5m 18s

the patch passed

+1 :green_heart:
compile
5m  4s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
5m  4s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 12s

the patch passed

+1 :green_heart:
mvnsite
2m  4s

the patch passed

+1 :green_heart:
javadoc
1m 29s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m  9s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
5m 53s

the patch passed

+1 :green_heart:
shadedclient
34m 38s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 24s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
261m 49s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

448m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6311

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux b3eb94be7f8c 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 67870e486b3faeb19c39c3274c86045a8af4fc63

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/11/testReport/

Max. process+thread count
3231 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6311/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Add URL and dependencies for new tracker

We would like to have this journey also sent metrics to our new tracker to see its behavior.

Add the new tracker SDK package, SDK call, and the metadata file(repository.yaml)
Update privacy notice

cc: @animeshsingh

Thanks @Tomcli - Also add the badges from the new repo to this one. This will reset the counter - and Steve is fine o start the counter with 500 for this Journey

hey folks - what is this waiting on?

why was this closed?

Think this was a mistake

@animeshsingh OK, i can merge it now, can you confirm that things are ready on your end? @scottdangelo last chance to review

Done


Update Symfony to 7

Hello, Can you perform a release ? Thanx !

@RobinDev Thanks for remind. Done!


Switch to allow permanent full path availability

The address bar needs a switch to allow full path to be always available. Now it needs clicking to be visible.

@Xemanth The full path should show by default in v0.20, can you confirm if this is what you had in mind?

Thanks again for your feedback.
Since we didn't hear from you on this topic for 7+ days, we'll assume everything is worked out and close this feedback item. If you had more feedback to provide, please re-open this and help the owners by describing the current status and any steps taken to troubleshoot this.


Doesn't work on Google App Engine

When petl is used on app engine, the io module cries because some dependencies can't be resolved. GAE doesn't support C modules, thus it's not possible to install sqlite for instance, and it doesn't make sens to install such module when not used.
What about extracting all sqlalchemy and sqlite functions from io.py and make sure the init.py doesn't import them automatically?

Imports of sqlite3, cStringIO and cPickle are all now conditional or hidden in v1.0, so petl should work on GAE, but feel free to re-open if any problems arise.


SendBatchAsync; a Servicebus batch mechanism approach

When a "tax tariff" in the "charges-domain" is created or updated all actors must be notified of the change, and "charges-domain" must guarantee that all actors are notified.
Up till now, each actor is notified one by one, this is cumbersome and "charges-domain" can either; not guarantee that all actors are notified or some actors will possibly receive the same notification multiple times.
"charges-domain" therefore need to utilize the servicebus batch mechanism, to make sure all actors are notified once and only once for a "tax tariff" change.
The "IDatavailableNotificationSender" interface in package "Energinet.DataHub.MessageHub.Client" has not implemented support for servicebus batches, so the "dream scenario" would be a SendBatchAsync method in DataAvailableNotificationSender, that takes a collection of dataAvailableNotificationDto alongside a correlationId.
public interface IDataAvailableNotificationSender
{
    /// <summary>
    /// Encodes the specified DataAvailableNotification and places it onto the post office DataAvailable queue.
    /// </summary>
    /// <param name="correlationId">The correlation id that can be used to track the data represented by the notification.</param>
    /// <param name="dataAvailableNotificationDto">The notification to send to the post office.</param>
    Task SendAsync(string correlationId, DataAvailableNotificationDto dataAvailableNotificationDto);

    Task SendBatchAsync(string correlationId,
        IReadOnlyCollection<DataAvailableNotificationDto> dataAvailableNotificationDtos);
}

@PerTHenriksen ingen i teamet vidste noget om denne, så derfor flyttet tilbage til Product Backlog.


Create faceted searching interface

Development tasks (in order)

[x] @djbpitt Create faceted search interface mockup as dev/facets-mockup.xhtml. The mockup content is hard-coded and there is no actual searching, but the accordion and checkboxes respond to events.
[ ] @EmmaSchwarz @gabikeane Open dev/facets-mockup.xhtml from your local file system; review and comment (here, as Issue comments). The mockup does not interact with eXist-db; at the moment it's a hard-coded form that does no searching or other querying.
[ ] @djbpitt Implement for testing in the app context

Issues you may encounter

@EmmaSchwarz @gabikeane Once the page interacts with the database, should it reload after every checkbox change or only when the user pushes a "Submit" button? Amazon and Google shopping seem to reload after every check, which is sort of consistent with the “drill down” aspect of faceted searching. But users may want to select several things at once, and a reload on each check or uncheck may be both slow and distracting.
@djbpitt Need to learn how to maintain state when reloading the new page after each selection.

Additional context

Use local session storage for checkbox state? https://www.sitepoint.com/quick-tip-persist-checkbox-checked-state-after-page-reload/

Interface has changed; issues are now different, so closed this one


Add KNContactsPicker to UI category

Adds KNContactsPicker to the UI category list.
Project URL
https://github.com/dragosrobertn/KNContactsPicker/
Category
UI
Description
KNContactsPicker is a modern, highly customisable contact picker with multi-selection options that closely resembles the behaviour of the ContactsUI's CNContactPickerViewController.
Why it should be included to awesome-ios (mandatory)
Checklist

[ ] Has 50 GitHub stargazers or more
[x] Only one project/change is in this pull request
[x] Isn't an archived project
[ ] Has more than one contributor
[ ] Has unit tests, integration tests or UI tests
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 4 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Warning

:warning:
Found 12 link issues, a project collaborator will take care of these, thanks :)

Link issues by awesome_bot

Line
Status
Link

4
302
https://triplebyte.com/a/azelHFa/d redirects tohttps://triplebyte.com/

276
301
https://github.com/analytics-pros/Swift-GA-Tracker-for-Apple-tvOS redirects tohttps://github.com/adswerve/Swift-GA-Tracker-for-Apple-tvOS

934
301
https://github.com/onmyway133/Anchors redirects tohttps://github.com/onmyway133/EasyAnchor

1332
404
https://github.com/jorik041/PerfectAPIClient

1381
301
http://www.catapush.com/ redirects tohttps://www.catapush.com/

1451
301
https://github.com/adrianmateoaea24/magic-mapper-swift redirects tohttps://github.com/adrianmteo/magic-mapper-swift

1531
301
https://github.com/IvanVorobei/SPPermission redirects tohttps://github.com/ivanvorobei/SPPermissions

1614
301
https://github.com/facebook/facebook-swift-sdk redirects tohttps://github.com/facebookarchive/facebook-swift-sdk

2007
301
https://github.com/Babylonpartners/DrawerKit redirects tohttps://github.com/babylonhealth/DrawerKit

2095
301
https://github.com/soheil/RadialLayer redirects tohttps://github.com/soheil-zz/RadialLayer

2136
301
https://github.com/ML-Works/Overlap redirects tohttps://github.com/MLWOS/Overlap

3249
301
http://jamesonquave.com/blog/tutorials/ redirects tohttps://jamesonquave.com/blog/tutorials/

  Generated by :no_entry_sign: Danger

@dragosrobertn We cannot merge your PR yet until you fill all of the contribution guideline requirements. Feel free to open PR once it is ready.
Please check our CONTRIBUTION GUIDELINES


Prevent default behaviour when showing all available page types

Prevent default behaviour (#) when clicking a link to show more page types

I think return false is the best way to do this these days fwiw


docs: updated package version and added contributors

Hi again @nicholas-ramsey !
Since I mentionned your profile in the package.json I'd prefer your approval (or disapproval!) before publishing the new version including your fix ! 😄
Let me know and thank you again for your contribution ! Have a great day !

I'll publish the 1.0.2 in a minute then 😉


Update url of help button to our UG

Edited copy url button link to our FinBook UG link

Codecov Report
Base: 72.52% // Head: 72.52% // No change to project coverage :thumbsup:

Coverage data is based on head (f636e46) compared to base (b943b41).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #56   +/-   ##
=========================================
  Coverage     72.52%   72.52%
  Complexity      437      437
=========================================
  Files            74       74
  Lines          1354     1354
  Branches        149      149
=========================================
  Hits            982      982
  Misses          324      324
  Partials         48       48

Impacted Files
Coverage Δ

src/main/java/seedu/address/ui/HelpWindow.java
0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

LGTM!


How to Update the Vesrion

I m trying to update the muslide version from 11 to 12 but my all system have been updated to 12 but one system still showing 11 how to update from 11 to updated version . is their any command to update if then please share the command .

Hi @chhajervikram
With the npx command it will check for updates and download new updates automatically if you use the @latest suffix:
npx mudslide@latest -V

The binaries on GitHub are built infrequently and need to be downloaded manually.
Hope this helps, Rob