How can I bind for IP_ADDR_ANY with port 0 to intercept all connections?

Hello, I want to implement a Tun-based VPN with smoltcp, so I need to intercept all connections.
But I didn't find a way to do that......
I have noticed that TcpSocket::listen simply returns a Error::Unaddressable when found port==0.
Or is there any way to inspect the protocol in the traffic to establish the corresponding socket?

I have noticed that TcpSocket::listen simply returns a Error::Unaddressable when found port==0.

Indeed; if you try this on a BSD-derived network stack (on Windows, Linux, macOS...) you'll notice that the OS allocates a random ephemeral port for you in that case, rather than intercepting all connections. Smoltcp cannot allocate ephemeral ports for you because of the way it's structured, so it returns an error.

I want to implement a Tun-based VPN with smoltcp, so I need to intercept all connections.

I don't understand why you need to use TCP sockets to implement a TUN-based VPN. Could you describe your requirements in more detail?

Thanks for your reply, sincerely.
I want to implement a rust version of tun2socks on windows, which can forward all traffic through a socks/http proxy.
I know there are tools like Proxifier  for this purpose, but it cannot handle traffic from UWP or WSL2. I want to solve this from the Internet layer, so I need a user-level TCP/IP stack like smortcp to handle connections from local programs.
BTW:
I am considering to add the feature about accepting all incoming connections to this repo.
My basic idea is to detect the status of the TCP connection in the process_tcp function in ethernet.rs, and if the status is SYN, add a new connection in the SocketSet.
Some structures also need to be changed, such as InterfaceInner and Packet.
Could you tell me what do you think of this feature?
Thanks.

I am considering to add the feature about accepting all incoming connections to this repo.

I think it would be a very niche feature that does not justify the added maintenance burden, and I would prefer to not have it upstream.
However, smoltcp is quite modular, so you should be able to reuse much of its infrastructure to achieve your goal. You could take a look at EthernetInterface::poll to see what you need to do to implement the functionality you want.

Thank for your advice.


Update main.py

ecdsa v value fix (tests working!)

v = 0 fails on ecdsa_raw_recover and ecdsa_raw_verify (False and ValueError, respectively) since v value is lost with DER encoding

@vbuterin this code fixes failing tests

@vbuterin can this be merged, so tests stops failing? thanks


Fixed NPE exception when querying with NOT on null object field

A null check for the query returned was missing, leading to org.apache.lucene.search.BooleanClause's ctor to throw and NPE for passing a null query.
Follows: #13106

interesting that test_is_not_null_matches_empty_objects doesn't catch it - indicates we need an integration test?

Don't know if integ test is necessary, I'm working on a test.

We need NOT <somefunction>(<object_field>) to trigger the NPE.


Capture case when both circles are the same in convexHullOfTwoCircles.

Fix of issue #99 .

Thanks!


[WIP] Re-enable unit tests on appveyor

Part of #1756

Codecov Report

Merging #1760 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1760   +/-   ##
=======================================
  Coverage   49.87%   49.87%
=======================================
  Files          70       70
  Lines        7449     7449
=======================================
  Hits         3715     3715
  Misses       3114     3114
  Partials      620      620

Flag
Coverage Δ

#linux
49.87% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a542cf7...cf1d010. Read the comment docs.

LGTM


Fix target="_blank"

It's tricky because "blank" (without an underscore) will still open a new tab, but it's actually being interpreted as a browsing context name, and so clicking it a second time will replace the previously opened tab (even if navigated away).

Good catch, thanks! I'll update the snapshots.


improve path payment operation setup

Reordering things and making things more easy to understand. I misunderstood how path payments worked when I first created this pane.

Clicking Add new intermediate asset results in:
ManualMultiPicker.js:43 Uncaught TypeError: Cannot read property 'concat' of undefined

Did npm install and it's the same.

Thanks for catching it @bartekn. Not sure how that slipped through me.
It's fixed now.

:+1:


Update README.md

You changed from pipenv to poetry in https://github.com/stephenswat/eve-abyssal-market/commit/c4a59c69f928afbb7dfcafa1f6804658a7abbd32

Well spotted, thanks!


When etcd service upgrade is done , it gets to "upgraded" state when one of the new etcd instance is not present.

Rancher versions: v1.6.6
K8s env with 8 etcd nodes.
Force upgrade etcd service.
1 of the new etcd instance (upgraded)  got created and then got deleted immediately.
At this state etcd service is already in "upgraded" state.
So no further reconcile happens  and no attempt to start new etcd instance.
But once finish upgrade is done, etcd instance gets recreated successfully.

2 bugs :

etcd flapped in the first place
cattle didn't wait for it to go healthy before deciding the upgrade was complete


Features should be additive, don't use nostd feature, but use an std one instead

Based on https://doc.rust-lang.org/cargo/reference/features.html?highlight=additive#feature-unification
We should replace our nostd feature to instead have an std feature that enables std.

One example of where this should be addressed: https://github.com/facebook/akd/blob/main/akd_core/src/lib.rs#L182


Add low-level print configuration option.

Defaults to console.log. Set to function process.stdout.write(log + '\n'); to avoid output to
devtools console while still reporting jasmine results to command line.

Three tests do not pass, but let me see if you are up for this kind of change before I invest more time to fix them.

It is a great option, go for it!

Ready for review.

Available in<EMAIL_ADDRESS>


nni default experiment path is ~/nni-experiments ,could it be changed?

Describe the issue:
Environment:

NNI version:2.0
Training service (local|remote|pai|aml|etc):
Client OS:
Server OS (for remote mode only):
Python version:
PyTorch/TensorFlow version:
Is conda/virtualenv/venv used?:
Is running in Docker?:

Configuration:

Experiment config (remember to remove secrets!):
Search space:

Log message:

nnimanager.log:
dispatcher.log:
nnictl stdout and stderr:

How to reproduce it?:

nni==2.0  config.yml   logDir:    xxxxx/xxxxx
nni>=2.3  config.yml  experimentWorkingDirectory: xxxxxx/xxxxxx

@DavideHe - thanks for submitting the issue. may I know more about why you'd like to change the default experiment path? thanks.

@DavideHe - thanks for submitting the issue. may I know more about why you'd like to change the default experiment path? thanks.

I run nni on a GPU docker cluster,but I couldn't  ping the ip of the docker straightly; so I want to write the  experiment to other path,then I could create a cpu docker to view it (nnictl view experiment_id).As you know cpu docker only will be used to edit code and debug ,not suitable to train,althrough I could ping its ip and port.


Package the pyspec

Branched of my remerkleable PR, with the phase1 PR merged in.
Changes:

Integration things to make remerkleable work for test generation etc.
Organize config loading code better
Do away with the spec build code, move in the core logic to setup.py, as a dist-utils command, and integrated into default build + dev command.
Updated build/makefile things, read the readme pyspec doc in the tests/core/pyspec dir for usage instructions.

With this PR, it becomes super easy to install the spec as dependency, and write python tools to toy around with the spec.
Example set up:
#!/bin/bash

mkdir spec-experiment
cd spec-experiment

python3 -m venv venv
. venv/bin/activate

# Or use your branch of choice
pip install "git+https://github.com/ethereum/eth2.0-specs@pkg-the-pyspec"

# Or editable mode (make sure to run pyspecdev to get editable spec files, instead of relying on re-building the spec):
# pip install -e /path/to/spec
# cd /path/to/spec && python setup.py pyspecdev

echo "
from eth2spec.phase0 import spec
print(spec.BeaconState)
" >> experiment_code.py

python3 experiment_code.py

Or in steps:

create your venv (as with any project)
one command to install spec from git (whatever branch you need, or locally) with pip
from eth2spec.phase0 import spec (phase 1 works too)
write some fun python!

It's that easy now :tada:

Yeah, agreed. stub fine.
Let's figure out a flow to integrate version before next release

excellent job!


rustc complains about missing dependencies on debian even though they're installed

Bevy: 5.0
OS: Debian GNU/Linux Bullseye (v11)
Expected: Build succeeds after following setup.
Actual: Build fails with an error message telling me that 'Package libudev was not found in the pkg-config search path'. libuvdev is installed, as are the other dependencies specified in
https://github.com/bevyengine/bevy/blob/main/docs/linux_dependencies.md
This is probably an apt issue, since it should have installed the packages properly. I think I fixed an issue like this before by installing the problematic package with linuxbrew, but libudev-dev does not appear to be downloadable that way.

Do you have libudev-dev installed as well?

Why isn't libudev-dev downloadable? It should be in the debian repository. Try apt search libudev

I meant not via linuxbrew. I already have libudev-dev (and even libudev1) installed via apt, but it doesn't seem to be recognized, which is why I tried Linuxbrew.
It doesn't really matter anymore since I've moved on to a slightly lower-level approach, but thanks for trying to help :)

Googlers: I had this same issue where the developmental libraries were installed via apt, but cargo still complained that they were missing. In my case, I had to deactivate my conda environment. If you also have conda running, you should deactivate it too.


First take on refactoring IOHMM to a package.

This change is

Reviewed 24 of 24 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


The icon of the fab is shown as background for the toolbar.

This problem occurs when the following actions are executed:

Change the icon of the fab with fab.setImageResource(int res)
Call fabLayot.Show() to transform the fab into toolbar.
Now the new icon of the fab will be animated and also stay as background for the toolbar

I have tested this behaviour on:

Nexus 5 (Android 6.0.1)
Samsung Galaxy Note 3 Lite (Android 5.1.1)
Nexus 10 emulator (Android 4.4)

If android:background element is set for the toolbar, then the fab's icon won't stay as background for the toolbar, but the animation issue still remains.
This issue might be related to Issue on Sony Devices with FabToolbar, but this is a problem for more than just Sony devices.

#23


Integrate top loader bar

Add the nextjs-toploader library to the project by following the docs - https://www.npmjs.com/package/nextjs-toploader
Make sure to hide the spinner.

can you assing me this

@wenayy you are assigned!

you can check the pr #22 i have made the changes and give feedback

PR is open for new assignees

Can I work on this issue?

@parthivsaikia u are assigned

can you provide what color and height of the loader will you prefer.

Keep the color black and size as default

Ok sir.

Can you please assign me this issue under SWOC?


Improve UI/UX of the patient waiting room screen

it is necessary to make it clear that the patient will receive contact through the waiting room

As a Patient, I want to know where the doctor will contact me after I register.

We have some problems with the layout of our current "Patient waiting room" screen.
The screen is not intuitive enough, so patients that register in the system just grab the generated ticket number e close the browser, because they think the doctor will approach through WhatsApp or E-mail.
We need to make the screen more intuitive and make it more "obvious" that the contact will be made IN the waiting room screen.

In this issue I'll try to suggest some other layouts, and we can vote if its good or not =D

@pedropiccaro What do you think?

Ficou ótimo!


Remote repository

Hello, hope you are doing well :)
Has this library been published to jitpack?
Regards,
Nuno Palma

Hi. Yes, it's on jitpack.io, added how to set up gradle to README.md


Race condition suspected in runtime

//
//  Distributed under the Boost Software License, Version 1.0. (See accompanying
//  file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
//
// launch with --hpx:threads=8 or more
//
// OSX : set seed to<PHONE_NUMBER>
// Linux : set seed to<PHONE_NUMBER>
//
// if it does not crash set seed to (unsigned int)std::time(0) + std::rand()
// and be patient, it throw an exception eventually. Then retry uing the seed printed

#include <hpx/hpx_init.hpp>
#include <hpx/hpx.hpp>
#include <hpx/include/parallel_copy.hpp>
#include <hpx/util/lightweight_test.hpp>

#include <string>
#include <vector>

#include <tests/unit/parallel/algorithms/test_utils.hpp>

#define SEED<PHONE_NUMBER>
//#define SEED<PHONE_NUMBER>
//#define SEED (unsigned int)std::time(0) + std::rand()

//#define PREFIX_SCAN 1

#ifdef PREFIX_SCAN
# include <hpx/parallel/algorithms/prefix_copy_if.hpp>
# define COPY_X prefix_copy_if
#else
# define COPY_X copy_if
#endif

////////////////////////////////////////////////////////////////////////////
template <typename ExPolicy>
void test_copy_if(ExPolicy policy)
{
    static_assert(
        hpx::parallel::is_execution_policy<ExPolicy>::value,
        "hpx::parallel::is_execution_policy<ExPolicy>::value");

    typedef std::vector<int>::iterator base_iterator;
    typedef test::test_iterator<base_iterator, std::forward_iterator_tag> iterator;

    std::vector<int> c(10007);
    std::vector<int> d(c.size());
    auto middle = boost::begin(c) + c.size()/2;
    std::iota(boost::begin(c), middle, std::rand());
    std::fill(middle, boost::end(c), -1);

    hpx::parallel::COPY_X(policy,
        iterator(boost::begin(c)), iterator(boost::end(c)),
        boost::begin(d), [](int i){ return !(i < 0); });

    std::size_t count = 0;
    HPX_TEST(std::equal(boost::begin(c), middle, boost::begin(d),
        [&count](int v1, int v2) -> bool {
            HPX_TEST_EQ(v1, v2);
            ++count;
            if (v1!=v2)
              throw std::string("help");
            return v1 == v2;
        }));

    HPX_TEST(std::equal(middle, boost::end(c),
        boost::begin(d) + d.size()/2,
        [&count](int v1, int v2) -> bool {
            HPX_TEST_NEQ(v1, v2);
            ++count;
            if (v1==v2)
              throw std::string("help");
            return v1!=v2;
    }));

    HPX_TEST_EQ(count, d.size());
}

int hpx_main(boost::program_options::variables_map& vm)
{
    hpx::util::high_resolution_timer t;
    do {
      unsigned int seed = SEED;
      std::cout << "using seed: " << seed << std::endl;
      std::srand(seed);
      test_copy_if(hpx::parallel::par);
    } while (t.elapsed()<300);

    return hpx::finalize();
}

int main(int argc, char* argv[])
{
    // add command line option which controls the random number generator seed
    using namespace boost::program_options;
    options_description desc_commandline(
        "Usage: " HPX_APPLICATION_STRING " [options]");

    desc_commandline.add_options()
        ("seed,s", value<unsigned int>(),
        "the random number generator seed to use for this run")
        ;

    // By default this test should run on all available cores
    std::vector<std::string> cfg;
    cfg.push_back("hpx.os_threads=" +
        std::to_string(hpx::threads::hardware_concurrency()));

    // Initialize and run HPX
    HPX_TEST_EQ_MSG(hpx::init(desc_commandline, argc, argv, cfg), 0,
        "HPX main exited with non-zero status");

    return hpx::util::report_errors();
}

The above code snippet (assuming it does not contain errors) reproduces for me reliably on two machines OSX/Linux an error in the copy_if calculation, which I believe is caused by a race condition somewhere in hpx.

Note : this is a very high priority for me because when I run the benchmark suite for vtkm, it tests thousands of iterations of algorithms and during these tests I get random segfaults/errors that I cannot explain in terms of faulty algorithms. The HPX unit tests usually only test a small number of iterations and do not show any signs of this error.

This is nonsense. It gives an error even with seq policy and hpx:threads=1 I must have made a mistake in the checks

The error is
/Users/biddisco/src/hvtkm/testing/copyif.cpp(62): test 'v1 == v2' failed in function 'auto test_copy_if(hpx::parallel::v1::sequential_execution_policy)::(anonymous class)::operator()(int, int) const': '-2147483648' != '0'
which is actually 0xFFFFFFFF80000000 - some sort of overflow is taking place

@biddisco the error is happening when you iterate over source vector with iota and get overrflow

so a static_cast<> should fix it....

@biddisco: the fix might be to do something like
    std::iota(boost::begin(c), middle, std::abs(std::rand() - c.size()));

As a side note, MSVC RAND_MAX is criminally low and masks the problem in this snippet, I reckon.

@AntonBikineev I put int
    std::iota(boost::begin(c), middle, std::rand()%65535 );
and the error goes away. This is deeply troubleing as it means the error is a trivial buffer fill and does not help me solve the other (presumably unrelated) segfaults I have been getting.
Thanks for spotting the problem. I don;t see why the rand() isn't converted correctly to an int by sdt::iota, but at least I can stop wasting time on this.

@biddisco are you still getting segfault? I've tried the code on OS X and Linux with --hpx:threads=8 and couldn't reproduce.

I used the iota fix above and the errors are gone. The segfaults are in my main benchmarking code and I tried to reproduce them by making a cut-down test based on the copy_if test. When I got errors with the copy_if test I thought 'aha' this might be a symptom of the same underlying problem (my code calls copy_if etc etc) and it seems like I was chasing a red-herring.
I've restarted my benchmarks and will see if they complete without error. (they won't).

Closing this issue because although I still have suspicions about races in the runtime, the test above was not relevant.


Github is deprecating the authentication API

on login to Github with the plugin, this email message is received...
"
We will remove the Authorizations API endpoint on November 13, 2020. If you accessed the API via password authentication, then we recommend you use the web flow to authenticate. Please check that your app uses the web flow for authentication https://developer.github.com/apps/building-oauth-apps/authorizing-oauth-apps/#web-application-flow
You can learn more about these changes by visiting our developer blog https://developer.github.com/changes/2020-02-14-deprecating-oauth-auth-endpoint/
"

I received the same message. Could someone confirm how it will affect this extension?

thanks, I'll take some time to fix this before the deadline

Thank you!


Removed unused references

I have removed some unused assembly reference from the main project.
I see that also Microsoft.CSharp is unused, but I have not removed it, as removing it will help if someone wish to use a previous framework version but on the other side keeping it can be useful if in future someone need dynamic keyword. Let me know your preference.
Very good job your cleanup of BC. Just to understand there is a reason for the unreferenced interfaces (like for example Asn1SetParser) you keep there ?

I think Microsoft.CSharp should go if not using it.
For unused reference, there is no reason. I tried to remove as much as I could given limited time, if you see code still unused in BouncyCastle, it must also go. Doing so bring down the size of the NBitcoin package. (the cleanup decreased size of the nuget package from 10MB to 5MB)

my goal is to have such a BC library that I can get rid of it and just include it into NBitcoin dll.


Merge apache d62c37b

Merge latest apache master to lyft master

Codecov Report

Merging #41 into lyft-master will not change coverage.
The diff coverage is 100%.

@@             Coverage Diff              @@
##           lyft-master      #41   +/-   ##
============================================
  Coverage        64.61%   64.61%
============================================
  Files              444      444
  Lines            22261    22261
  Branches          2451     2451
============================================
  Hits             14384    14384
  Misses            7742     7742
  Partials           135      135

Impacted Files
Coverage Δ

superset/viz.py
68.37% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae173c...e00c7aa. Read the comment docs.


accessToken is missing in the json response

Category

[ ] Question
[ ] Documentation issue
[X] Bug

Expected or Desired Behavior
When using the parameter "endpointHint" to specify a full path to a Sharepoint library, it is expected to retreive in the json response the accessToken and the apiEndpoint. You can read the info in the section 4 of the documentation here.
Observed Behavior
When populating the parameter "endpointHint" with a full URL to a SharePoint document library, the returned json response is missing accessToken and apiEndpoint.
Steps to Reproduce
Here an example of code to use to reproduce the bug.
var odOptions = {
clientId: oneDriveApplicationId,
action: "query",
multiSelect: false,
openInNewWindow: false,
advanced: {
endpointHint: "https://xxxxxxx.sharepoint.com/sites/TestServicesRequests1/TestServicesRequests/",
redirectUri: "http://<IP_ADDRESS>:5500/DoSomething.html"
},
success: function (files) {
resolve(files);
},
cancel: function () { resolve(null); },
error: function (e) { reject(e); }
};
OneDrive.open(odOptions);
Here the result returned when you point directly to a sharePoint site:
Object:
value: Array(1)
0: {id: "01KFYDXCCSPIM52FIDDVHKD477Y6VSID5M", parentReference: {…}, sharePoint: {…}, endpoint: "https://idscollabdev.sharepoint.com/_api/v2.0"}
length: 1
proto: Array(0)
webUrl: null

Thanks for your report @seanix99. We will look into this and get back to you. cc: @margoflynn

@KevinTCoughlin Any news about this issue ?

@KevinTCoughlin Any news about this issue ?

The team is currently addressing a few Picker regressions including #1076. We will investigate this soonest. cc: @aditima @margoflynn
The Picker response should include accessToken to issue subsequent API requests. I'm not yet sure why it isn't in the above case.

@KevinTCoughlin @JeremyKelley Any news if its have been adressed by the teams ?

one thing I did find is that the token while I believe it used to be populated in more cases, is only documented to give one back for Graph endpoints -
"The access token received by the file picker for your application. This can be used to make additional requests to Microsoft Graph without requiring another authentication flow."
(https://docs.microsoft.com/en-us/onedrive/developer/controls/file-pickers/js-v72/open-file?view=odsp-graph-online#response-properties)

As part of a repository clean up effort we are closing older issues. If this issue remains, please: open a new issue, reference this issue, and provide any additional details that may help in resolution. Thank you for your understanding as we work to improve our responsiveness.


zookeeper_current_node_hostname: <IP_ADDRESS> makes nodes unable to work after restart

Describe the issue
Setting zookeeper_current_node_hostname: <IP_ADDRESS>  in inventory makes nodes unable to work after restart.
The setting was added with PR- https://github.com/confluentinc/cp-ansible/pull/281
To Reproduce
systemctl restart confluent-zookeeper
Expected behaviour
Node must survive restart, so does the cluster
Additional context
This is confirmed zookeeper bug - https://github.com/apache/zookeeper/pull/1254
fixed in version 3.5.8 -https://github.com/apache/zookeeper/commit/800cc26a768fceda9ea42fe8121acf45fe781c57
Hower, according to the table, latest version used by confluent platform is 3.5.7

@AntonSmolkov Thanks for this!  We are looking at this internally currently and will come up with a solution shortly.  Rolling back that PR maybe the best option for the moment, will confirm.

@kongslund be careful

I'm actually using our external IP. I don't see a need for a rollback since <IP_ADDRESS> is not the default.

To elaborate, I set zookeeper_current_node_hostname like this:
    zookeeper_current_node_hostname: "{{ hostvars[inventory_hostname]['ansible_default_ipv4']['address'] }}"

@AntonSmolkov @kongslund We are going to remove the example where we show you how to override this behaviour, as the default uses the Hostname/IP Address in the inventory file.  We will leave this issue open until a new version of Zookeeper is shipped.

Closing this because this is an issue with zookeeper not with cp-ansible. The default of zookeeper_current_node_hostname is the inventory_hostname, so there is no bug


Using the adapter-common

Current coverage is 100.00%

Merging #13 into master will not affect coverage as of 98eb19d

@@            master     #13   diff @@
======================================
  Files            2       1     -1
  Stmts          133      18   -115
  Branches         0       0
  Methods         23       6    -17
======================================
- Hit            133      18   -115
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of 98eb19d

Powered by Codecov. Updated on successful CI builds.


Add retries to publish?

Some builds fail in actions because of network timeouts, especially in publish. Could we add retries (with backoff?) to apko to hopefully reduce some of these fails?

This was done in #241.


Add more test for server.go

And remove unused function.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: incfly
Assign the PR to them by writing /assign @incfly in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wattli: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
67647f895f6236450ed399945331f76604c4a1ee
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: myidpt
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS [myidpt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: myidpt
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS [myidpt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wattli: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
3dbf856befaf51b4d7261c58cb2a2e7d7932c652
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: myidpt
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


fix formatting issues on hosting article

The article on hosting a Nodejs application on an AWS EC2 instance was pulled (exported) directly from my Notion article of the same name.
However, Notion being notoriously incompetent at exporting written content as markdown, proved itself by not carrying over callouts, and accordions. Some formatted text is also raw, not showing their style.
This needs to be manually fixed, but a long-term fix is to explore and find something like notion2md to properly export these files.

Formatting issues have mostly been fixed. Accordions have been added in place of collapsible sections.


On ESP32 DevKit, pin 2 is a better onboard LED (blue)

Hi @info-lvsys !
Thank you for your contribution improving nanoFramework samples.
Question: what DevKit are you refering to? On the ESP32-WROVER-KIT I have, changing the GPIO from 4 to 2 makes the green LED blink instead of the blue one (both on the tri-colour LED).

Oh interesting. I have the Xiuxin ESP32 Development Board, with the ESP Wroom 32 chip. On that board, using PIN 2 blinks nothing.

From the look of it, it's a regular ESP32-WROOM, there are no LEDs connected to any GPIO... so it doesn't matter if you have there 2 or 4 (as it was)… Care to confirm at your end?

Hi
I confirm on Xiuxin ESP32 Development Board, GPIO 2 is connected to the blue on board LED.
See the pin out documented here:  https://randomnerdtutorials.com/esp32-pinout-reference-gpios/
Maybe just reject my commit - all that is needed is to tell people in the comment that depending on the dev board if 4 does not work, that the should try pin 2 as well.

That seems a more reasonable approach.
Care to update the comment instead and maybe explain that depending on the ESP32 variant the gpio maybe be different from baird to board?

OK, just did.

@info-lvsys are you on our Discord community?
What name should I use for listing you at the contributors hall?

Hi - Wasn't on Discord. Just joined it. you can use LVSYS for the contributors hall if you want - I feel I made too small a contrib ;) must say.

Will do. This project lives from all contributions: large and  small. If more people were willing to contribute, even with small ones, we would way ahead! 😉


Highlighting code only works for one editor

The new feature (thanks @RabsRincon !) only works for the last compiler. Ideally as you mouse over the code you'd see all the compiler outputs highlight together.

Addressed by a312325de9520e848d99048949c5c8e60f778252 (thanks @RabsRincon)


When I try to change album art for this particular manga, the app crashes everytime

Steps to reproduce

Open the manga. (My Dress-up Darling)
Tap on artwork button.

Expected behavior
Allow me to change the artwork for the manga.
Actual behavior
App crashes and shows this messege.

Crash logs
https://github.com/CarlosEsco/Neko/assets/79253278/ba33cc0d-e9be-4aad-a4b1-78131931bce4
Neko version
2.12.3
Android version
Android 13
Device
Xiaomi 11i
Other details
No other details.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to the newest version Latest.
[X] I have filled out all of the requested information in this form.

Update your app


Struct accessors using the wrong name for the type in the OVERLAPPED struct

I just synced to the latest source and built it and I'm trying to use it for the Win32metdata project. It looks like something has changed that has broken the scraping of the _OVERLAPPED struct:
The accessor properties for Offset and OffsetHigh use _Anonymous_e__Struct._Anonymous_e__Struct instead of _Anonymous_e__Union._Anonymous_e__Struct. The previous version didn't have this problem. This keeps it from compiling.
    public unsafe partial struct OVERLAPPED
    {
        [NativeTypeName("ULONG_PTR")]
        public UIntPtr Internal;

        [NativeTypeName("ULONG_PTR")]
        public UIntPtr InternalHigh;

        [NativeTypeName("_OVERLAPPED::(anonymous union at D:/repos/win32metadata/artifacts/InstalledPackages/Microsoft.Windows.SDK.CPP.10.0.19041.5/c/Include/10.0.19041.0/um/minwinbase.h:55:5)")]
        public _Anonymous_e__Union Anonymous;

        [NativeTypeName("HANDLE")]
        public IntPtr hEvent;

        public ref uint Offset
        {
            get
            {
                fixed (_Anonymous_e__Struct._Anonymous_e__Struct* pField = &Anonymous.Anonymous)
                {
                    return ref pField->Offset;
                }
            }
        }

        public ref uint OffsetHigh
        {
            get
            {
                fixed (_Anonymous_e__Struct._Anonymous_e__Struct* pField = &Anonymous.Anonymous)
                {
                    return ref pField->OffsetHigh;
                }
            }
        }

        public ref void* Pointer
        {
            get
            {
                fixed (_Anonymous_e__Union* pField = &Anonymous)
                {
                    return ref pField->Pointer;
                }
            }
        }

        [StructLayout(LayoutKind.Explicit)]
        public unsafe partial struct _Anonymous_e__Union
        {
            [FieldOffset(0)]
            [NativeTypeName("_OVERLAPPED::(anonymous struct at D:/repos/win32metadata/artifacts/InstalledPackages/Microsoft.Windows.SDK.CPP.10.0.19041.5/c/Include/10.0.19041.0/um/minwinbase.h:56:9)")]
            public _Anonymous_e__Struct Anonymous;

            [FieldOffset(0)]
            [NativeTypeName("PVOID")]
            public void* Pointer;

            public partial struct _Anonymous_e__Struct
            {
                [NativeTypeName("DWORD")]
                public uint Offset;

                [NativeTypeName("DWORD")]
                public uint OffsetHigh;
            }
        }
    }

Taking a look...

@sotteson1, this will be resolved with #219.
The logic was simplified and moved to be part of IndirectFieldDecl traversal (now that libClangSharp correctly exposes those) but it was accidentally reusing the the anonymous record decl when generating the type name rather than using the parent record decl.
#219 resolves things by ensuring the correct record decl is used when constructing the type to use.


Send more debug information in hello command

Allows for easier server-side debugging by sending the equivalient of an HTTP
Agent string.
Other notable change is handling a response that comes in over multiple packets. This basically had a FIXME comment.

Merged this from other branch, you can close this @jqr.

NM, autoclose confused me, how do I github

Pretty well, most of the time.


Update deploy.bat

I have customized this script because the previous script always deploy the sysmon if Splunk Universal Forder or Splunk instance is restarted

Thanks for this improvement!


Add postgres backups

This is a first pass at adding manual backups of postgres. There are a number of improvements that I would like to make, but will come in a future PR I think:

[ ] Monitoring of this job
[ ] Backup other directories we care about (looking at you blobdb)

@czue @benrudolph @orangejenny

this looks great!

sweet! do we care about storing backups on a different machine than the actual database? if the hqdb0 goes (like the hard disk gets struck by :zap:), then the backups go down with it no?

in addition to this we're installing software that backs up the directory

@benrudolph As Cory said, this is only half the backup process, the whole /opt/data/backups directory is pulled onto a separate disk after this completes (but that is configured through softlayer ui)

ah awesome. makes sense, thanks for the info


Still white screen when scanning using the rocket assembling machine

Still happening after update when placing the Rocket Assembling Machine and hitting scan, everyone looking in the direction of the machine gets a white screen, it does not go away. Using latest 1.12.2 version.
AdvancedRocketry 1.12.2-1.4.0-65-UNSTABLE build -65 for 1.12.2

it was fixed in 68cc272b8a4f7613b37f9cd141c35d5b016df7b3, it missed the auto commit by a few hours.  It'll be fixed in build 66


v8: fixes darwin build

Motivation for this change
v8 compilation on macOS was failing because of missing dependency and wrong linker. This PR fixes those problems.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Thanks for your contribution! If you are able to you might want to look into applying these patches to other versions of v8. I'm not sure if any others have these problems, though.

@matthewbauer should that be a separate PR or part of this one?

@LnL7 The latest change successfully builds on a machine without Xcode.

On the commit message:
(pkg-name | service-name): (from -> to | init at version | refactor | etc)

(Motivation for change. Additional information.)


Release 1.0.0-rc.1 to next

What this PR does / why we need it:
Merge main into next and release 1.0.0-rc.1
Special notes for your reviewer:
We have not previously released a release candidate version. Absent previous controller RC releases to mimic, I've attempted to follow the style conventions used by the kong repo, namely:

The RC version format is x.y.z-rc.RCCOUNTER
CHANGELOG.md stages expected 1.0.0 changes under a "1.0.0-rc.1" header. We will need to change this to "1.0.0" and update the anchor date before final release, and move any subsequent RC changelogs under the consolidated 1.0.0 changelog section. Slight deviation from kong here: at least for the 2.0.0-rc.1 release, it used a "2.1.0rc1" header. I kept the . between rc and 1 in ours to keep the version formatting consistent throughout.

I have future-dated this to tomorrow, as Harry is out today and Michal probably is out for the evening, and I expect this will get reviewed EMEA tomorrow when Michal's workday starts. In the process doc, the next step following approval and merger into next is 'Tag 0.10.0 and push it (e.g. “git tag 0.10.0 origin/next; git push --tags”)'.
Mundane retro stuff:

The steps we wrote for 0.10.0 omit a few steps (creating a release branch and merge it). I've added those in suggestion mode. Please review them and approve if they make sense.
The changelog merger step assumes that we've written a changelog in advance of release and have an open draft PR. That's probably good practice for future releases, as they can take a while to write depending on how clean history is and how complex the changeset is. 1.0.0's is fortunately pretty simple, since it's mostly just deprecations and everything was indeed included in the milestone, which wasn't the case for 0.10.0. We should definitely continue adding things to milestones in the future, as that saves a lot of error-prone PR/commit history review by release date.
Google Docs is misery, at least for me, as finding stuff in it can be a crapshoot, and as-is we could easily miss steps because they're just a bullet list--no way to mark a step as done. I propose migrating the release steps to Confluence with a templated checklist similar to what Fast Track uses for Enterprise releases. Confluence is its own set of misery on account of Atlassian's incredibly slow JS+slow managed services grinding the editor to a halt after any appreciable amount of time (maybe it works better in Chrome, but lol web devs doing performance testing under any JS engine other than V8), but I figure that's outweighed by the organizational benefits here--ticking boxes on a checklist while reading through them is pretty simple, so it doesn't suffer as much from the slowness (not much in the way of "okay, wait for the text displayed on the page to catch up with my typing speed" pauses when ticking boxes on an existing checklist).

I propose migrating the release steps to Confluence with a templated checklist similar to what Fast Track uses for Enterprise releases.

@rainest would a GH issue template with checkboxes work?


NTRUGen Algorithm

This PR attempts to implement generation of polynomials $f, g, F, G ∈ Z[x]/(x^n + 1)$ s.t. it satisfies the NTRU equation $fG − gF = q \mod φ$, following algorithm 5 of the Falcon specification.

Ensure you've GNU MP library and header installed
sudo apt-get install -y libgmp-dev
# or
brew install gmp

Then test by issuing
make

If you've not brought in git submodule dependencies then
# first clone repository
pushd falcon
git submodule update --init
popd


Add support for HTTPS_PROXY

Checklist

[x] npm install && npm test passes
[ ] tests are included
[x] documentation is changed or added
[x] commit message follows commit guidelines

Description of change
See #1749. If the requested URI is HTTPS, attempt to use an HTTPS proxy, if configured, and fallback to the HTTP proxy if one isn't found. This change should be backwards-compatible except in the case where someone is using a broken HTTPS proxy (in which case I would argue that that isn't node-gyp's problem anyway).
If desired, I can remove the url require and substring the uri to detect if it's HTTPS.
No tests were added because there aren't any existing proxy tests.

I think I'm OK with this but I think it's going to have to be semver-major because it introduces potentially new behaviour in existing environments. Would you mind squashing the commits into one and changing the prefix to lib: please?

Sounds good! I'll get to that in the next day or two.

@rvagg squashed!

I'd like to get some tests in for this. Have a look in test/test-download.js, you'll see that you can interact directly with the download function and even pass it environment variables. So it should be straightfoward to come up with some tests that trigger each of these variables. The trick is going to be confirming that it's connecting via a proxy. There's a test/simple-proxy.js that's currently only used by docker.sh (I'm thinking that needs to be removed since it's not really used). That could be repurposed for this. There's also a self-signed certificate in test/fixtures/ that could be used for https proxy tests.
Let me know if you have trouble with this. I can help out as time allows if you're struggling.

Popping in to say I haven't forgotten about this -- just a little short on time recently.

I believe we have this now via #1978, thanks for the code though


fix out of index bug

Thanks for your work! Will review and probably merge on Tuesday, given the free time I anticipate having remains.


added to open new tab and made message shorter

Can I be added please?
On Thu, Dec 30, 2021, 8:48 PM ClaudioAsuncion @.***>
wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/IvanARodriguez/StudentSite/pull/32
Commit Summary

7c100ab
https://github.com/IvanARodriguez/StudentSite/pull/32/commits/7c100ab11352f77a600a7b32afd4618427482694
added tab on button and paragraph shorter
06b1cf0
https://github.com/IvanARodriguez/StudentSite/pull/32/commits/06b1cf0916e01767e12644951d1ef143aa5b53d8
added a tab and made paragraph smaller
76999c4
https://github.com/IvanARodriguez/StudentSite/pull/32/commits/76999c4f575d6409ba5010936b3f651a328f62fd
Merge branch 'IvanARodriguez:main' into main
c55da50
https://github.com/IvanARodriguez/StudentSite/pull/32/commits/c55da50d4a088e8ef219d70bec093cb77df95cdf
added tab for botton and style css
9ef1a5a
https://github.com/IvanARodriguez/StudentSite/pull/32/commits/9ef1a5a86719d5704e6397542f698e2fddab3de8
add tab to button and style css

File Changes
(2 files https://github.com/IvanARodriguez/StudentSite/pull/32/files)

M index.html
https://github.com/IvanARodriguez/StudentSite/pull/32/files#diff-0eb547304658805aad788d320f10bf1f292797b5e6d745a3bf617584da017051
(4)
M style.css
https://github.com/IvanARodriguez/StudentSite/pull/32/files#diff-b78be019f1dc6d57753ea900c3805b114cd53ab7c0db836cc081836df1b99b7a
(12)

Patch Links:

https://github.com/IvanARodriguez/StudentSite/pull/32.patch
https://github.com/IvanARodriguez/StudentSite/pull/32.diff

—
Reply to this email directly, view it on GitHub
https://github.com/IvanARodriguez/StudentSite/pull/32, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALNCFN6NNYRLTFLGJ4B33RDUTUY2BANCNFSM5LAYNKGQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


send back HTTP 400 where there is a client error

What have you changed? (required)
pd server
We often send a 500 error where it should be 400 or 404.
It is important to get these right.
A client will assume it did nothing wrong when a 500 is received
and perhaps automatically retry the request.
This is a conservative change in that
there are many more places that should be changed from 500 to 400 or 404.
Mostly this is due to not investing more time to understand the entire code base.
In some cases, functions are called which don't differentiate error types properly.
A forthcoming PR will provide some help in this case.
A helper function jsonRespondError is added.
What are the type of the changes (required)?

Breaking change

I can only assume that most client code is not differentiating between 400 and 500 error codes. In that case there will not be any breakage.
How has this PR been tested (required)?
There is a new test suite for the jsonRespondError helper.
Otherwise the test suite was ran and I was surprised that no tests broke.
Does this PR affect documentation (docs/docs-cn) update? (optional)
There is a PR to add an API specification. That would need to be updated to add more 400 entries.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@disksing PTAL

You don't have to update the year in all files, only new files need to use '2018'. The rest LGTM.
PTAL /cc @nolouch


Main process doesn't print uncaught exceptions to console anymore

Instead it prints a bunch of "undefined"s:

This is very inconvenient when having unknown issues with our apps.
Not sure since which version this problem occurred (probably v0.36.0), because I didn't even realise what those "undefined"s are until recently...

It is probably because you are catching uncaughtException in your app.

At the end I found than it was the colors js we use failed for some reason.
Thanks for your hint!


feat: add ability to toggle between default & express vars

This adds a new switch to the website that allows for users to toggle back and forth between the default and express versions of the CSS vars.
We listen for a click or a key event that corresponds to the "vars version" drop down, get the version of the vars that the user has chosen, and change the resource URL in the <link> tags in the DOM. Key events will correspond to control + e (for expressvars) and control + d (for vars/the default option).
Refs #1238
How and where has this been tested?

Manually tested in a local dev environment.
Tested on MacOS in the latest versions of Firefox (91.0.2), Chrome (92.0.4515.159), and Safari (14.1.2 (166<IP_ADDRESS>.6)).

Screenshots

New Drop Down:

Before:

After:

To-do list

[ ] If my change impacts other components, I have tested to make sure they don't break.
[ ] If my change impacts documentation, I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.

[X] This pull request is ready to merge.

Validation

Pull down this branch and run it locally (gulp dev)
Navigate to any component page (ie: http://localhost:3000/docs/accordion.html)
Observe that a new "Vars Version" drop down is available in the upper right portion of the window.
Open your browser's inspector, click the drop down, and switch the vars version from "default" to "express".
In your browser's inspector, observe that the markup for the <link> tags containing the style assets in the <head> has changed the href attribute from a path that had vars to a path that now has expressvars.
Click the vars version drop down once again, and observe that the <link> tag paths have switched back to vars from expressvars.
Using your keyboard, hold the control key and press the e key, and observe that the <link> paths switch to expressvars.
Using your keyboard, hold the control key and press the d key, and observe that the <link> paths switch to vars.

Not sure if this is targeting production, but SWC was separately informed that the options should be Theme to manage the vars package to use and Color Theme to manage which color stops to use, a la:

Not sure if this is targeting production, but SWC was separately informed that the options should be Theme to manage the vars package to use and Color Theme to manage which color stops to use, a la:

Thanks for the heads up! I don't believe that this will be targeting production initially, but maybe @GarthDB can provide a little more insight as to that comment + the SWC comment.

@pfulton @Westbrook yeah, we aren't going to go into production quite yet, this is for local dev. @pfulton and I were talking about enabling it with a env variable. We'll enable that before publishing the site.


Add Script on .js

I want to add the code to integrate Customer.guru the code is the following:
<script type="text/javascript">   window.customerguru=window.customerguru||[],customerguru.load=function(t,e){window.customerguru.client_token=t,window.customerguru.config=e=e||{};var r=e.forceSSL||"https:"===document.location.protocol,u=document.createElement("script");u.type="text/javascript",u.async=!0,u.src=(r?"https:":"http:")+"//cdn.customer.guru/embed/v1.js";var o=document.getElementsByTagName("script")[0];o.parentNode.insertBefore(u,o);for(var c=function(t){return function(){customerguru.push(Array.prototype.slice.call(arguments,0))}},n=["schedule"],s=0;s<n.length;s++)customerguru[n[s]]=c(n[s])};   customerguru.load("HIDDEN", { autoschedule: true, debug: true }); </script>
When I added to BaseHtml.js I couldn't start the App because of a fatal error.
Where can I add it so when customers hit the website it's there?
Crisp.im not working
I tried integrating Crisp by adding my Website ID here  but seems like there is no response. No chat show up, nothing. Any add up?

You can't simply drop a script tag like that on React's render function. You can do something in the lines of what I did with Crisp (https://github.com/yoonic/nicistore/blob/master/static/vendor/crisp.js). Btw... did you also add Crips ID in this file? Should do the trick.

Nope, not working. Added both but it showed this error:

About Customer.Guru (and any other apps) when using their API to handle request instead of a <script> box, where exactly should I add the codes (I mean which files to refer).

Did the trick when doing it with HTTPS SSL Let's Encrpt (Nginx)


Update develop branch

I think it's about time to do a general merge of master into develop, since we now have commits from September 2020 that are not available on master. @progfolio, you have the most context on recent development; what should be the cutoff point for which commits are merged into master? I usually default to a heuristic of anything older than a month (e.g. https://github.com/raxod502/straight.el/commit/ac4df5c in this case), but I also try to give more time for changes that I think are risky.

I'd say we're good up to the current head of "develop". The commits after ac4df5c are relatively low-risk:
962d236 develop origin/develop Merge pull request #702 from raxod502/outline-regexp
4ddc3e2 Also move "straight.el ends here" footer
e36e9a9 [raxod502/selectrum#437] Use default outline-regexp
c94516d Include ox-odt styles when building org (#699)
0f9b828 straight--select-package: Add generic candidate filter. (#696)
dab2c6f straight--select-packge: fix for-build filter, candidate order (#695)
f2cb888 straight--directory-files: remove ".", "..", ".git" dirs when FULL paths (#693)
dedae21 straight-vc-git--ensure-remote: use git config to determine URL (#690)

I assume a good deal of our users are on Doom which defaults to the "develop" branch, too.

Merged it. Not sure why there were so many conflicts, but I felt it was safe to resolve all of them in favor of develop.


⚠ WS API has degraded performance

In 6c1a7b8, WS API (https://wsapi-lab.retargetly.com/healthcheck) experienced degraded performance:

HTTP code: 504
Response time: 10311 ms

Resolved: WS API performance has improved in fa1e26e.


Generated types aren't compatible with Kysely query results?? (Timestamp issue)

If I have my appuser generated like
export interface Appuser {
  created_at: Generated<Timestamp>;
  email: string;
  join_date: Generated<Timestamp>;
  last_login: Timestamp | null;
  name: string | null;
  password_hash: string;
  profile_picture_url: string | null;
  updated_at: Timestamp | null;
  user_id: Generated<number>;
  username: string;
}

I cannot use this type to capture results returned from Kysley query.
const results: Appuser = db.selectFrom('appuser')
  .selectAll()
  .execute();

Doesn't work because the returned Date columns (that are Timestamp columns in the model like updated_at) lack these Timestamp properties:
readonly __select__: SelectType;
readonly __insert__: InsertType;
readonly __update__: UpdateType;

Am I misunderstanding this module's purpose? Shouldn't I be able to use the generated db.d.ts file as my db models?

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

You're probably using your generated Appuser interface directly, when you should be using it as follows:
import { Selectable } from 'kysely'

const results: Selectable<Appuser> = await db.selectFrom('appuser').selectAll().execute()

That was exactly it, thank you.
We should probably add a note about this to the README.md.

const results: Selectable<Appuser> = await db.selectFrom('appuser').selectAll().execute()

No no. You shouldn't use explicit types like this. The output type is automatically Selectable<Appuser> here. No need for the explicit type.


Fix APPSEC_AUTO_EVENTS_EXTENDED scenario

Description
Fixing #1347
Reviewer checklist

[ ] If this PR modifies anything else than strictly the default scenario, then add the run-all-scenarios label (more info).
[ ] CI is green

[ ] If not, failing jobs are not related to this change (and you are 100% sure about this statement)

Workflow

⚠⚠ Create your PR as draft
Follow the style guidelines of this project (See how to easily lint the code)
Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
Mark it as ready for review

Once your PR is reviewed, you can merge it! :heart:

Let #1362 do the job :)


cnf ran: update pod security label for test namespace

In the powermanagement test suite, there is a failure due to the stressng pods not meeting the restricted security standard. This updates the namespace to only enforce the baseline standard, which should allow the stressng pods to be created.

cc: @dgonyier
Leaving this here until we can verify this fixes the issue.

Closing since this hasn't shown up in multiple weeks of CI. Will reopen if it does come up again.


feat[issue #16143]:  Changed CategoryShortcutButton class component

Details

Changed Class component to function component for EmojiPicker/CategoryShortcutButton.js
ran npm test and passed all test.
Fixed Issues

$ https://github.com/Expensify/App/issues/16143
PROPOSAL: https://github.com/Expensify/App/issues/16143#issuecomment-1622584475
Tests

Hover over shortcut emojis to check if they get highlighted
Click on shortcut emojis to see if they take you to the chosen category

[x] Verify that no errors appear in the JS console

Offline tests

Hover over shortcut emojis to check if they get highlighted
Click on shortcut emojis to see if they take you to the chosen category

QA Steps

Hover over shortcut emojis to check if they get highlighted
Click on shortcut emojis to see if they take you to the chosen category

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

I have read the CLA Document and I hereby sign the CLA

@AGarciaNY looks like you have some conflicts that need to be addressed.

@AGarciaNY Your commits are not signed
Please follow the below guideline and setup for signing the commits https://docs.github.com/en/authentication/managing-commit-signature-verification
Once you've set it up check this thread to retroactively sign commits. Thanks!

@Santhosh-Sellavel I think this message if for you.

Will try to get to it today or tomorrow.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop
https://github.com/Expensify/App/assets/85645967/fd47be8b-ed59-48a6-b297-b8a680a10ea1

Mobile Web - Chrome & Mobile Web - Safari
https://github.com/Expensify/App/assets/85645967/2a5a3b2a-2514-4e1f-85a7-690e4e8b38fc

iOS & Android
https://github.com/Expensify/App/assets/85645967/aba35a33-d3b5-4560-8618-2c6a03152921

@AGarciaNY
Test steps for QA can be more descriptive i.e. about how to go to the componet, please update!
Ex:

Go to any chat on New dot
Click on the emoji on Composer, to open the emoji picker

@Santhosh-Sellavel I updated the test steps

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.42-0 🚀

platform
result

🤖 android 🤖
cancelled 🔪

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
cancelled 🔪

@AGarciaNY Can you pls clarify what do you mean by "Test the shortcut button"

They are in the first row under the search input.


try out linkchecker through github actions

Trying out this link checker on github actions: https://github.com/gaurav-nelson/github-action-markdown-link-check

Looks good now.


User Management feature

Adding a user management feature, consisting of a new User Management page which will contain a table of all currently existing users along with their data (excluding passwords, of course 🙂).

[x] Create a new User Management page
[x] Set up routes for the User Management page
[x] Show table of users with placeholder data
[x] Placeholder Delete functionality
[x] Fetch and show actual user data
[x] Add functionality
[x] Delete functionality

FYI, the "merge branch 'development'..." commit is just conflict resolution.


Modules restructuring

Rename newhelp to help
Move sortchan to channel management
More chans need better modules

Rename newhelp to help
in 89465161fd4aeaed113baa57b1d0c58aee1a1914

Move sortchan to channel management
in e89bdf506d9e817ecbc24a236825606f33e88a75

More chans need better modules

in b57b71e
@kevslinger This structure looks reasonable enough to be closed?

I'm fine closing this for now. Eventually I want to overhaul a lot of the modules/channel locations, but it's so low priority for me at the moment that I don't mind

Split sheets into "Sheets/Lion/Crab" modules


raise exception on invalid images

What does this PR do?
This PR is meant to handle cases in which the images provided are invalid.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@Narsil

Doesn't this also crash the webserver ?


CAMEL-21049: Kamelets in Camel core

Description
Kamelets are still kind of separated from the Camel core project. The Kamelets live in a separate GitHub project repository (https://github.com/apache/camel-kamelets) and follow a separate release lifecycle which creates cyclic module dependencies.
In addition to that, writing and maintaining Kamelets is no fun as it boils down to writing YAML files manually.
This PR shows a potential way to move Kamelets into the Camel core project. The Kamelets are written in Java instead of YAML and use of a new service provider annotation @KameletSpec. The Kamelets are discoverable via service loader discovery mechanism. The metadata as well as the service loader information is auto-generated by the Camel Maven plugin tooling. The Kamelets also become part of the Camel catalog.
The PR implements a few Kamelets as an example:

set-body-action
data-type-action
timer-source
log-sink

Target

[x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[x] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

See CAMEL-21049

Apache Camel coding standards and style

[x] I checked that each commit in the pull request has a meaningful subject line and body.

[x] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

going back to the drawing board. thanks for all comments and feedback


configure-security-policy-settings french translation space after '.' in secpol.msc

Hi,
It is about the page :
https://docs.microsoft.com/fr-fr/windows/security/threat-protection/security-policy-settings/how-to-configure-security-policy-settings
In the french translation there is a space after the dot : "secpol. msc"
it is just a little annoying.
French
Pour ouvrir la stratégie de sécurité locale, dans l’écran d' Accueil , tapez secpol. msc, puis appuyez sur entrée.
English
To open Local Security Policy, on the Start screen, type secpol.msc, and then press ENTER.
Best regards

@christianruffenach thank you for reporting it.   It is caused by an issue with our machine translation tool which is under investigation.  @OfficGlobal please human translate this article and check that the issue is fixed.

@TinaMcn . There is no edit option in french artice

@RAJU2529 I am hoping to enable the edit option in French articles later this year.  It will require native speaker moderators and internal tools to manage the workflow which takes time to set up.  In the meantime you are welcome to leave feedback about the French articles via the English articles and I will pass on your feedback to the translators.

@TinaMcN . Thanks for the reply. I will feedback.

@TinaMcN @officeglobal - Do you have any updates if this issue has been fixed?
Thank you.

From the French page (https://docs.microsoft.com/fr-fr/windows/security/threat-protection/security-policy-settings/how-to-configure-security-policy-settings) :
Configurer un paramètre à l’aide de la console Stratégie de sécurité locale

Pour ouvrir la Stratégie de sécurité locale, dans l’écran de Démarrage, tapez secpol.msc, puis appuyez sur ENTRÉE.

This single character (space) issue has been resolved, therefore this ticket can be closed.
Thank you to @TinaMcN and @OfficeGlobal for the work done.


[FEATURE] Physical collisions need to be prevented (in code)

Need a system of preventing subsystems that share space from colliding

Not currently a problem, however wouldbe nice to implement in the future sometime


Forbid field and method name duplication in struct definition

Currently, field and struct names can be duplicated in a struct definition. For example, the below code is allowed,
pub struct Bar {
    pub x: i32

    pub fn x(self) -> i32 {
        return 0
    }
}

This can be error-prone; Unintentionally, users might write field access with the intention of a method call or vice versa.
So it would be better/safer to forbid this duplication.

I would like to take this. I would like to know more info about this though. Where can I look for?

Can I take this issue? Would love to contribute.
Also, let me know what additional info I need to solve this.

I was looking for a first issue to get started on but when looking through the code I found this
https://github.com/ethereum/fe/blob/da8aed3af8ad7edb3b0dba729c9ff6c63084dac1/crates/parser2/src/parser/struct_.rs#L73-L80
Is this issue still relevant or should it be closed?


Prevent end-user defined callbacks from blocking websocket code execution

Fixed possible null pointers and added more clarity in/by exception logging.
I couldn't add more tests because of the current code setup. I've changed this in my next pull request "Added better error feedback and websocket control", which already includes this pull request, but for the sake of clarity I committed this part also separately.

I've added this PR because I ran into the problem that an uncaught exception in my user callbacks was really hard to track due to lack of stacktraces. This made it a challenge to find out whether there is an bug in the websocket client or in my application. To prevent this challenge, I've enclosed every call to the end-user's code/callback within a try/catch clause, so when an exception occurs, it's will be quickly visible if it's in the end-user's code or in the client code.
Also, I've added the onConnectionFailure callback to OBSRemoteController, to catch any connection failures there.


Questions about Secondary Pretraining strategy

Check before submitting issues

[X] Make sure to pull the latest code, as some issues and bugs have been fixed.
[X] I have read the Wiki and FAQ section AND searched for similar issues and did not find a similar problem or solution
[X] Third-party plugin issues - e.g., llama.cpp, LangChain, text-generation-webui, we recommend checking the corresponding project for solutions

Type of Issue
Model training and fine-tuning
Base Model
Others
Operating System
Linux
Describe your issue in detail
I'm planning to do secondary pretraining Llama-2-7b  on my language with a node of 8x H100 80GB. So given that I'm given enough time and resource, do you recommend:

Training on both English and my language (I'm aiming for ratio 1:1) so that the model do not forget English knowledge?
Since extending vocab (30k -> 55k) means introducing many newly initiated weights. It makes sense to me to go for LoRA, because it reduces the number of trainable weights and the training would be more stable. But given that I can do full weight training, do you recommend I do it?

Dependencies (must be provided for code-related issues)
# Please copy-and-paste your dependencies here.

Execution logs or screenshots
# Please copy-and-paste your logs here.

We lack supporting experimental results on this matter. Further testing of the effectiveness or referencing other literature is needed.
LoRA has a faster training speed and requires less GPU memory compared to the full-params training. It allows for rapid iteration to validate experimental results. Choosing full-params training after confirming the experimental plan may yield better results.

Got it, thank you.


Test: Delayed enrollment

In this test, genesis validators cant enroll all at the same time.
Some of them will have to wait for the next block.
Part of #1545

Thanks everyone. Updated according to the reviews.

Thanks everyone. Updated according to the reviews.


Prefix commands

So that it's easier to find them from the Command Palette.

Fixed in 3dda7d48464c05c7e0ce339aab9e8f7060345cb8


Replace renovate with dependabot

This PR adds dependabot configuration instead of renovate, since Github started supporting pnpm and it's a bit more convenient to use the built-in dependency management tool.
Reference: Dependabot version updates now supports pnpm
Relates to https://github.com/P5-wrapper/react/pull/280
Proposed Changes

Add dependabot config
Remove renovate config
Update workflow config for formatting PRs from bot

@jamesrweb Here is the PR with the dependabot configuration. Please have a look when you are free


Unable to run functional tests

I have been following this guide https://github.com/projectkudu/kudu/wiki/Getting-started in order to get the functional tests to run locally, but have been unsuccessful. All tests continue to fail even though I have been through all the steps in the guide above.
It looks like all the folders are created (ie. C:\Kudu-Test-Files\KuduApps), and I can see that the site(s) are created in IIS (kudu_*). But for a test like AppChangesShouldTriggerBuildTests I see in an System.Net.Http.HttpRequestExceptionResponse status code does not indicate success: 401 (Unauthorized). error, which I assume should not happen. Below is the full stack trace.
Any pointers as to what could be wrong in my setup? (I'm running VS2013 as Admin, and I've tried granting "Network Service" full control over the Kudu.Services.Web folder within the solution).
System.AggregateExceptionOne or more errors occurred.
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.Threading.Tasks.Task.Wait()
   at Kudu.TestHarness.ApplicationManager.Run(String testName, Action`1 action) in ApplicationManager.cs: line 242
   at Kudu.FunctionalTests.AppChangesShouldTriggerBuildTests.PushAppChangesShouldTriggerBuild() in GitRepositoryManagementTests.cs: line 329
System.AggregateExceptionOne or more errors occurred.
   at System.Threading.Tasks.Task`1.GetResultCore(Boolean waitCompletionNotification)
   at Kudu.TestHarness.SitePool.<CreateApplicationInternal>d__c.MoveNext() in SitePool.cs: line 116
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at Kudu.TestHarness.SitePool.<CreateApplicationAsync>d__0.MoveNext() in SitePool.cs: line 45
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at Kudu.TestHarness.ApplicationManager.<RunNoCatch>d__7.MoveNext() in ApplicationManager.cs: line 259
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Kudu.TestHarness.ApplicationManager.<RunAsync>d__4.MoveNext() in ApplicationManager.cs: line 252
System.Net.Http.HttpRequestExceptionResponse status code does not indicate success: 401 (Unauthorized).
   at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()
   at Kudu.SiteManagement.SiteManager.<WaitForSiteAsync>d__48.MoveNext() in SiteManager.cs: line 598
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Kudu.Core.Infrastructure.OperationManager.<>c__DisplayClass4.<<AttemptAsync>b__3>d__6.MoveNext() in OperationManager.cs: line 56
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at Kudu.Core.Infrastructure.OperationManager.<AttemptAsync>d__9`1.MoveNext() in OperationManager.cs: line 76
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Kudu.SiteManagement.SiteManager.<CreateSiteAsync>d__15.MoveNext() in SiteManager.cs: line 180

If you open IIS manager and try to browse to site with prefix kudu_service_TestRunner*, what do you see on browser?  It might give some more clue.

@suwatch01 While the tests are running I usually get an error: "The site kudu_service_TestRunnerSite* does not exist". Sometimes I can browse to the site, but its empty. But I'm guessing that is mostly because the tests create and delete the two kudu_* sites in IIS as they start and terminate.
I tried running the Kudu.Web project from VS, which loads fine. But I when I try to open the Kudu.Services.Web project (which is also available with IIS Express) I get an error around the PathResolver and not being able to find the %HOME% directory. If I set that in my environment variables to the defatult ..\apps folder Kudu is able to load. But I can't actually create an application as per the last part of the "Getting Started" documentation. It seems to just stall when clicking create. I see the two sites being created in IIS, but something never finishes.
Following the code I reach CreateSiteAsync in the SiteManager class, and it never gets past await OperationManager.AttemptAsync(() => WaitForSiteAsync(serviceUrls.First())); line 154 and when I look at the service site in IIS it says it can't read web.config. The kudu site itself only gets the hostingstart.html file. So possibly a permissions issue in reading or creating the necessary web.config file.
Any guidance on how to continue?
And how should the %HOME% environment variable be configured when running from VS? And does this setting also affect the functional tests?

Umm ..  strange.   Mind try clean up and some simple test.

On IIS Manager, delete every sites with Kudu_service_TestRunner* and Kudu_TestRunner* prefix.
Also, on IIS Manager, delete relevant app pools (TestRunnerSite* prefix).
Remove directory c:\Kudu-Test-Files.
Open Kudu.sln, clean and rebuild.
After build successful, you should see the list of tests on the Test Explorer left pane.
Select SettingsApiFacts.SetGetValue (type in the Test Explorer text box) and run it.

See if the test run and successful?  Let us know the issue you ran into.

@suwatch When I run that test it just keeps spinning in what seems to be an endless loop.
The C:\Kudu-TestFiles\KuduApps\TestRunnerSite*\ has a site and LogFiles folder. The site folder has deployments and locks, but everything is empty.
The kudu_service_TestRunnerSite* gives me the following error when going to the site.
Access is denied.
  Description: An error occurred while accessing the resources required to serve this request. You might not have permission to view the requested resources.

 Error message 401.3: You do not have permission to view this directory or page using the credentials you supplied (access denied due to Access Control Lists). Ask the Web server's administrator to give you access to 'C:\Users\Morten\Documents\GitHub\kudu\Kudu.Services.Web'.

Version Information: Microsoft .NET Framework Version:4.0.30319; ASP.NET Version:<IP_ADDRESS>

The kudu_TestRunnerSite* site gives a HTTP Error 500.19 - Internal Server Error. And says it can't read the web.config, which is not surprising since there is no web.config - maybe because it can't access the kudu_service site?
Module
   IIS Web Core

Notification
   Unknown

Handler
   Not yet determined

Error Code
   0x80070003

Config Error
   Cannot read configuration file

Config File
   \\?\C:\Kudu-Test-Files\KuduApps\TestRunnerSiteTHINKPAD-X2201\site\wwwroot\web.config

So looks like a permissions issue, but I'm still unsure of what I'm missing or what needs special permissions? VS2013 is running in admin mode.

Definitely looks like a permission issue. At this point, I think it's best to isolate this from Kudu and VS and simply look at it as an IIS investigation. i.e. based on the site created in IIS in the given App Pool, what is preventing it from running. Please look at both the App Pool identity, and the permissions on the relevant folder.

@sitereactor  if you check your apppool, they should run under NetworkService identity.  Also do check ACL for C:\Kudu-Test-Files folder.  Does it allow authenticated user all-but-full-control permission?  If not, try granting that and run the same test again.   I assume you have Windows 10 OS on your thinkpad,

Both Kudu sites in IIS use the same app pool, which runs under Network Service.
The C:\Kudu-Test-Files folder has Authenticated Users set to Modify, and the KuduApps folder under it has Network Service and Authenticated Users set to Modify.
The Kudu.Services.Web folder in the git repo has Network Service set to Modify, but only because I added it manually. I assumed it was necessary as that is what the app pool identity was set to. It doesn't have any permissions set for Authenticated Users.
I'm running Windows 8.1 on this laptop.

I removed Network Service and added Authenticated Users (Modify) to the Kudu.Services.Web site in my git repository, and now the SettingsApiFacts.SetGetValue test actually works and passes Yay! :smile:
When I run all functional tests I still get a lot of failures though. 109 out of the 219 functional tests fail. Some stats: In the KuduApps folder I end up with 4 folders/sites, and the same in IIS. The RepositoryCache has 81 folders, and the TestRepositories folder has just one folder.
Would be great if the part about setting Authenticated Users to modify on the Kudu.Services.Web folder was added to the wiki.
And one more thing that I think could use some clarification is the use of the %HOME% environment setting when running Kudu.Web and Kudu.Services.Web from Visual Studio, as the services project does not appear to work unless that environmetn variable is set.
The list of pre-requisites probably also needs to be updated with Asp.Net 5 at some point :smile:

@sitereactor, great that you have made some progress.  Concerning number of sites and cache folder, they are all expected.
For 109 failed test, I assumed you have followed getting started.   ASP.NET 5 requires HttpPlatform (also see getting started).   The remaining, we might have to try to debug it one by one.
As far as %HOME%, Kudu site requires _app vdir so we know where the deployment and so on go.  If you just run Kudu.Services.Web in VS, there will be no _app vdir, most Kudu functionality would like be broken anyway.   If one really wants to run in that manner, there are a few workarounds - one of which is to pre-specify the %HOME% before opening the VS.

Generally, you should never run Kudu.Services.Web directly. We never do this, and it's not meant to work.
Also, before trying to run any tests, try using Kudu manually. i.e. run Kudu.Web, create site, push some MVC app. Until you can do that successfully, no point trying to run more complex tests.

Hi
Kudu will continue to run in Azure App Service. However, this repo will no longer be maintained.
If the problem persists and is related to running on Azure App Service, please open a support incident in Azure:
https://learn.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request
This way we can better track and assist you on this case
Thanks,
Joaquin Vano
Azure App Service


AmplitudeEnvelope: Fix wrong default value in doc

new Tone.AmplitudeEnvelope().get("sustain") returns 0.5, not 1.0

Thanks @timpulver, but this example was meant to illustrate how to use the AmplitudeEnvelope, it isn't meant to show the default values. To see the defaults for this class you have to click on Envelope which is a little confusing. I am eventually planning to refactor the docs code to account for these sorts of things and i'll try to make it more clear in the future.


Feature request: Add padding in main container for better UI experience

Checks

[X] I searched the issues page for already existing feature requests.

Description
Please add padding in main container for better ui experience
Screenshot

assign the issue to me
Alternatives considered
No response

I am interested please assign it to me

Hey,
I am interested to work on this issue.
Kindly please assign this to me.


Make source an argument for IFS, default of aws

Earth2Studio Pull Request
Description

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[x] The CHANGELOG.md is up to date with these changes.
[x] An issue is linked to this pull request.

[x] https://github.com/NVIDIA/earth2studio/issues/168

Dependencies

/blossom-ci

/blossom-ci

Thanks for the fix!


Parametrization for decoder/encoder generation

Hi, is it possible to parametrize generated encoder/decoder?
In particular, I'm asking for some way to replace current exception throwing in C++ generator for something. Right now, the only way for a decoder/encoder to generate an error is throwing std::runtime_error.
So, the idea is to let a developer decide what to do, raise std::runtime_error exception or raise some platform-specific exception or legacy way with setjump/longjump.
As an addition, this idea may require some additional headers to be included (for custom exceptions, for example).
How it may be solved. Pass both additional classpath at sbe-tool start (for loading developer's code) and some '-D' argument which make an sbe-tool to instance custom developer's code and to execute some callbacks from developer's code which generates whatever developer wants.

Would you like to submit a PR with your ideas for how this can be implemented?


Regression: SSO Email Assignment is broken

In gitlab by @A-Lawrence on Apr 6, 2016, 17:49
Since moving emails to the mship_account model, the assignment feature is broken.
Ensure regression test is written to confirm this behaviour and verify it is fixed.

In gitlab by @A-Lawrence on Apr 6, 2016, 17:54
Removed ~98470 label

In gitlab by @NFarrington on May 15, 2016, 11:40
mentioned in commit 7a9c127b15d207799790bdf1853652d6a9b14836

In gitlab by @NFarrington on May 15, 2016, 11:43
Fixed, tests not yet written.

In gitlab by @NFarrington on May 15, 2016, 23:52
Integration tests written - f005d92cc873cb56111c8345d48e9be5b7bfc0a4