Cache invalidation issue for test files

Describe the bug
For the very first time when I run the test command lage is triggering the test scripts. But when I add/update test file without change in any source file lage is not triggering the test case and return the cached state.
I have to manually pass --no-cache options which is a pain as it triggers script in all the packages.
Below is my lage config:
module.exports = {
  pipeline: {
    build: ['^build'],
    lint: ['^build'],
    test: ['^build'],
  },
  ignore: ['*.md', '.vscode/**'],

  cacheOptions: {
    // These are the subset of files in the package directories that will be saved into the cache
    outputGlob: ['dist/**/*', '!node_modules'],

    // These are relative to the git root, and affects the hash of the cache
    // Any of these file changes will invalidate cache
    environmentGlob: ['*.js', '*.json', '*.yml'],
  },
  npmClient: 'yarn',
};

To Reproduce
Steps to reproduce the behavior:

Create a mono repo with above lage config file.
Run lage test
Update any test file
Run lage test
Check the lage output

Expected behavior
Lage should run the test case of the updated package but it return the cached result
Environment/Troubleshooting
System:
    OS: Windows 10 10.0.19045
    CPU: (16) x64 11th Gen Intel(R) Core(TM) i7-11850H @ 2.50GHz
    Memory: 38.57 GB / 63.20 GB
  Binaries:
    Node: 18.15.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 3.6.1 - C:\Program Files\nodejs\yarn.CMD
    npm: 9.5.0 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.6.0 - C:\Program Files\nodejs\pnpm.CMD
  Managers:
    pip3: 21.1.1 - ~\AppData\Local\Programs\Python\Python38\Scripts\pip3.EXE
  Utilities:
    Git: 2.41.0. - /mingw64/bin/git
    Curl: 8.1.2 - C:\Program Files\Git\mingw64\bin\curl.EXE
  Virtualization:
    Docker: 24.0.2 - C:\Program Files\Docker\Docker\resources\bin\docker.EXE
  IDEs:
    VSCode: 1.81.0 - C:\Users\soumtr\AppData\Local\Programs\Microsoft VS Code\bin\code.CMD
  Languages:
    Bash: 5.2.15 - C:\Program Files\Git\usr\bin\bash.EXE
    Go: 1.20.2 - C:\Program Files\Go\bin\go.EXE
    Java: 11.0.18 - /c/Program Files/Amazon Corretto/jdk11.0.18_10/bin/javac
    Perl: 5.36.1 - C:\Program Files\Git\usr\bin\perl.EXE
    Python: 3.8.10 - /c/Users/soumtr/AppData/Local/Programs/Python/Python38/python
    Python3: 3.8.10 - /c/Users/soumtr/.pyenv/pyenv-win/shims/python3
  Browsers:
    Chrome: master_preferences
    Edge: Spartan (44.19041.1266.0), Chromium (114.0.1823.86)
    Internet Explorer: 11.0.19041.1566
  Monorepos:
    Yarn Workspaces: 3.6.1

@soumyart did you try adding the *.js files to the test task inputs?
E.g:
module.exports = {
  pipeline: {
    build: ['^build'],
    lint: ['^build'],
    test: { dependsOn: ['^build'], inputs: ['**/*.js', '*.json', '*.yml'] }, // Put the inputs here,
  },
  ignore: ['*.md', '.vscode/**'],

  cacheOptions: {
    // These are the subset of files in the package directories that will be saved into the cache
    outputGlob: ['dist/**/*', '!node_modules'],

    // These are relative to the git root, and affects the hash of the cache
    // Any of these file changes will invalidate cache
    environmentGlob: [],  // Probably should avoid adding things in here because any changes here would invalidate all caches
  },
  npmClient: 'yarn',
};


hi

PS F:\jhipster\app> jhipster-uml project1.xmi
Parser detected: MODELIO.
An error has occurred:
WrongTypeException
Error message:
The type 'ELong' isn't supported by JHipster.

Yes, you must be using the wrong UML implementation. Carefully read the doc here about how exporting is done.

https://github.com/jhipster/jhipster-uml/blob/master/test/xmi/visualparadigm.uml  404
I use Visual Paradigm for UML 10.0  get uml ,but
jhipster-uml testAlbedo.xmi.uml
? Please choose between the available editors: (Press  to select)
An error has occurred:
TypeError
Error message:
Cannot read property 'parse' of undefined
Stack trace:
TypeError: Cannot read property 'parse' of undefined
at Object. (E:\nodejs\node_global\node_modules\jhipster-uml\lib\jhipsteruml.js:54:24)
at Module._compile (module.js:541:32)
at Object.Module._extensions..js (module.js:550:10)
at Module.load (module.js:458:32)
at tryModuleLoad (module.js:417:12)
at Function.Module._load (module.js:409:3)
at Module.require (module.js:468:17)
at require (internal/module.js:20:19)
at Object. (E:\nodejs\node_global\node_modules\jhipster-uml\jhipster-uml.js:7:3)
at Module._compile (module.js:541:32)

Yes, Visual Paradigm is no longer supported. Please open a new issue next time, these two are different.

ok, Thanks!


VoID header on Jenkins has outdated link

Should be configurable. See WPREST2RDF.java line 271:
		populateVOID(
			voidWp, "https://jenkins.bigcat.unimaas.nl/job/GPML%20to%20GPML%20+%20WP%20RDF/ws/WP2RDF/output/#CODE#/*zip*/#CODE#.zip",
			"http://rdf.wikipathways.org/"
		);

Fixed.


Procedure testing with failpoint

What problem does the new feature solve?
Improve the robustness for DDL procedures
What does the feature do?
Injects the failpoint and checks the behavior of procedure
Implementation challenges
No response

You mean that something like:
CreateTableProcedure::new([step1, fail_step2, step3]) // we can inject failpoint via new method

?

You mean that something like:
CreateTableProcedure::new([step1, fail_step2, step3]) // we can inject failpoint via new method

?
Yep, we can utilize the fail-rs
https://github.com/tikv/fail-rs

@WenyXu Please take a look at this issue.

@WenyXu Please take a look at this issue.

I have yet to make a plan to inject the fail point. Specifically, for the region migration procedure, almost all errors can be covered with unit tests.

Then let's close this issue as won't do or invalid for now.
Once we find a concrete necessary or plan to introduce failpoints-based test, we can open a new issue for that.


Rebase/Rebuild Penumbra Hermes support on top of backend-specific configs

Is your feature request related to a problem? Please describe.
Our initial attempt at Hermes support for Penumbra was done as a one-off, since Hermes didn't have support for non-Cosmos chains. Since then we landed https://github.com/informalsystems/hermes/issues/3636 and can rebuild a Penumbra backend on top of new Hermes.

Haven't been able to get Hermes building against 64 yet. Here's what I tried:

Bump penumbra-proto dep to v0.64.0, here: https://github.com/penumbra-zone/hermes/blob/d8c0245f05c065286d670f4b5c52be44fba8d4b2/crates/relayer/Cargo.toml#L78
Observe build errors
Rename IbcAction to IbcRelay, matching https://github.com/penumbra-zone/penumbra/pull/3284
Bump prost 0.11 -> 0.12.3
Bump ibc-proto 0.32.1 -> 0.39.0
Adjust traits where necessary

Even after all that, I'm stuck on trait problems. @avahowell can you give it a go? I recommend starting from step 1 above, on a clean branch of the hermes fork. Once we have a clean build against v0.64.0, then we can try another patch for the cnidarium rename.

@conorsch if i want to take a look, i should checkout that d8c0245 commit and run cargo build -r right?

@erwanor That's right! Don't forget to manually increment the penumbra-proto version number, to v0.64.1, which includes the cnidarium rename.

The git commit referenced above is the current HEAD of main branch on the Penumbra fork of Hermes, post merge of https://github.com/penumbra-zone/hermes/pull/11.

Yes, that code is not to be maintained or developed going forward. This issue is tracking rebuilding Hermes support on top of the changes we merged upstream two months ago. What happened to that effort?

Yes, that code is not to be maintained or developed going forward.

I've set the penumbra-zone/hermes fork to archived/read-only, to make it clear we shouldn't be interacting with that codebase as the default. Last week we merged two (2) PRs into that fork:

https://github.com/penumbra-zone/hermes/pull/10
https://github.com/penumbra-zone/hermes/pull/11

Those changes are necessary but not sufficient for restoring Penumbra compatibility in Hermes, but our goal is to leave that codebase behind, and use it only as a reference. Next steps should be:

Branch from upstream latest tag: https://github.com/informalsystems/hermes/releases/tag/v1.7.4
Re-implement Penumbra support, targeting compat with v0.64.1
Ensure that logic from PRs 10 & 11 is accounted for.
PR Penumbra compatibility into upstream.

No, we need to be using that repo to develop our Hermes integration. I unarchived it. The point of this issue is that we need to rebuild Penumbra support, in that repo, on top of the changes we were able to merge upstream in the issue linked above, so that the code is maintainable going forward.

Not sure if it is worth aiming at but since #3531 landed it may be possible to have Penumbra Hermes support not use ABCI Query interface at all. we could perhaps at the astria relayer code for an example.

We discussed this at sync today. Right now, Hermes is working against Testnet 64, although it's still built against Testnet 63 dependencies. That's "good enough" for now, so we plan to hold steady with the same setup on Testnet 65. If things break, we'll prioritize rebasing at that point. For now, it's higher priority to work with Astria on their IBC needs.
Separately, it would be nice to have a Hermes instance running against preview, so we could monitor compatibility more closely.

Work is active on this front, see https://github.com/penumbra-zone/hermes/pull/12. However, we don't intend to block release of 65 (#3554) in order to land these changes.

Update from IBC sync today: @avahowell is optimistic about having PR against upstream by Friday, 2024-02-09. We'd love to see it land upstream, but either way, once it's working, we can start using it again on Testnet 65. We'll miss go-live of 65, so let's aim to follow up with a Hermes deploy on or around Monday 2024-02-12.

Overview on the progress and remaining items here (pr: https://github.com/penumbra-zone/hermes/pull/12):

[ ] Add a stub implementation of the penumbra ChainEndpoint, using the new multi chain backend and config
[ ] add a view service and custody service to the ChainEndpoint
[ ] implement the queries for ChainEndpoint
[ ] implement transaction building and submitting with the custody service
[ ] write configs and verify that relaying on penumbra devnets works
[ ] write configs and verify that relaying between penumbra and cosmos sdk works

Update from IBC sync today: @avahowell is optimistic about having PR against upstream by Friday, 2024-02-09.

Yet another update: @avahowell now expects a PR to be ready for review by this Friday, 2024-02-23. New commits landing the boxed gRPC services (https://github.com/penumbra-zone/penumbra/pull/3711) in the Hermes code have been pushed to the WIP PR branch. The checklist above is still accurate: config changes are in, and the code compiles, but there's still active debugging towards getting relaying working between Penumbra devnet chains.

I was able to successfully test:

Opening channels between penumbra testnets
Relaying packets between penumbra testnets
Opening channels between cosmos and penumbra (using the celestia mocha-4 testnet and penumbra deimos testnet)
Relaying packets between mocha-4 and deimos

We should do a review pass on the code in https://github.com/penumbra-zone/hermes/pull/12 in order to ensure that the approach taken will be maintainable going forward, both from a penumbra perspective (we're using the penumbra crates to build txs now) and an hermes perspective.


Fix: Remove clean-webpack-plugin again

The dependencies removed ressource assets from the build

:tada: This PR is included in version 3.5.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


SkEncodedOrigin wrong for one JPEG but not another - why?

I have two images (attached) which I'm trying to load, orient correctly, and then resize/crop to make thumbnails. My code to load the codec is super simple (I haven't included the code to resize and rotate, but can do if appropriate):
            SKCodec codec = SKCodec.Create(source.FullName);
            SKImageInfo info = codec.Info;

When I load the code via the Codec, the origin is coming back as 'Default' (TopLeft) for P8211052.JPG, which means that my resized thumbnails are not rotated correctly.  However, for PA010741.JPG, the origin is correct, so my rotation code works as expected.
I'm struggling to see what the difference is between the two images; both were taken on an Olympus OMD-EM5 Mk2. If I use other image processing libs to do the same thing (e.g., the AutoOrient method in ImageSharp) it works fine - and the photos display correctly-oriented in MacOS Preview. So I'm wondering if there's either something odd about the photos, or a bug in the Codec (which seems less likely, being JPEG). Any ideas?
I could use ImageSharp - which works - but SkiaSharp can process the thumbnails about 4-6x as fast, which is important as I'm processing hundreds of thousands of images in my app.
P8211052.JPG.zip
PA010741.JPG.zip

Very interesting...
I opened both in Windows Photos app, they are upright. But, when I open them in IrfanView, one is on its side.
But what is even more interesting is that they both have the orientation, but it seems a different order...

When I open it with GIMP, the one that is upright has a popup saying that it contains EXIF metadata. But the other one does not.
I'll see what I can do. Hopefully it is just a matter of different EXIF data that maybe skia is struggling to load.

Yes, I wondered if it might be a small glitch in the exif code. Let me know what you find and if you want me to test anything!

All right. I managed to locate the issue.
What is happening is that the EXIF data is not is the usual location. As a result, there is a special entry in the tags to point to the correct location of the data. However, skia is not actually handling this case. Instead, it stops with the initial set of tags, which is just a pointer to the real data.
I'll get a fix in and then report this to the Google team so that is can reach upstream.

That's totally awesome. Thanks for the super quick response!

I have the fix building, and I have also reported it to Google: https://bugs.chromium.org/p/skia/issues/detail?id=10799

@Webreaper, I have just pushed the PR build to the preview feed. It would be great if you were able to check it out and see if it works for all your images that you can test on. I want to make sure I got all the cases. I think it should be good, but won't hurt to confirm.
Preview feed: https://aka.ms/skiasharp-eap/index.json
Exact version: 2.80.3-pr.1518.1

Will certainly give it a go - how do I use the preview feed...?

Built a new version using 2.80.3-pr.1518.1, and it's working perfectly. I see no images mis-oriented. Thanks for the quick fix!

Awesome! I'll merge them and try get a release out asap!

Nice!
Would it be possible to apply this patch to 1.68.3 too?
PS: Related, I find it very unfortunate Skia doesn't provide a full blown metadata API, like Windows Imaging Component does.

I can try see if CI can build v1 again, but I am not sure if it will actually be good.
Skia is more creation than reading, so I think they decided to not put as much effort into the codecs.

I have created a CR that probably will get merged: https://skia-review.googlesource.com/c/skia/+/323217
I'm going to wait for feedback form the experts and then use whatever the final result is as this fix.

Any timescales for when a new release with this fix is going to be made?

I tried loading the images, and saving them back as PNG.
Here are my findings:
var bitmap = SKBitmap.Decode(inputPath); => does not automatically orient images. Related post
var image = SKImage.FromEncodedData(inputPath); => does* auto-orient all images starting from 2.88.0-preview.36, doesn't work in any 2.80.x release.

@Webreaper Could you share your thumbnail generation code?

Sure. It's here: https://www.github.com/Webreaper/Damselfly/tree/master/Damselfly.Core%2FImageProcessing%2FSkiaSharpProcessor.cs
The LoadOriented... method is where the orientation action happens. Please let me know if you see anything dumb in there. 😁

Okay, so after a quick test, looks like I should just change LoadOrientedBitmap(...) to use the method you suggest:
        private SKBitmap LoadOrientedBitmap( FileInfo source, int desiredWidth )
        {
            SKImage img = SKImage.FromEncodedData(source.FullName);
            var bmp = SKBitmap.FromImage(img);
            return bmp;
        }

I'm using 2.80.3-preview-40, and can confirm that with the change to the load/orientation above, it's all working now. Thanks very much! Pushed the change here: https://github.com/Webreaper/Damselfly/blob/develop/Damselfly.Core/ImageProcessing/SkiaSharpProcessor.cs#L172
PS: If you feel like reviewing my code for any other n00b errors, please feel free. ;)

Your original code didn't work because you only handled 4 out of 8 possible orientations.
Your new code that used SKImage looks fine :-)
IMHO the SkiaSharp documentation should clearly state that SKBitmap does not auto orient, while SKImage does.

Thanks. May have missed that in the docs. Should be all good now - thanks for the help!

Thanks. May have missed that in the docs. Should be all good now - thanks for the help!

No you didn't miss anything, the docs are missing this bit of information at first sight.
Thank you for reporting this, otherwise I would not have figured this weird discrepancy between SKBitmap and SKImage!

Chaps, one follow-up on this issue.... so I've noticed some speed issues, and last night I tracked down why. The reason I was using the Codec method to load, rather than FromEncodedData is because I was using the optimisation to only load the scale closes to the resolution I need. So if I'm loading a 3,000 x 2,500 image to generate a 1,200 x 800 image, it loads closest to the 1200x800 scale - which significantly decreases the time to read the image off the disk.
The new code is taking nearly a second to load a full-res image from disk in order to resize it to 1600 on the longest side, which is really slow.
I think I took the general approach from this post: https://forums.xamarin.com/discussion/88794/fast-way-to-decode-skbitmap-from-byte-jpeg-raw - and this was why I had my own AutoOrient code (which, as you pointed out, @Ziriax, was missing orientation cases).
Is there any built in load/orientation code so I can load a scaled version of the image more quickly, correctly oriented? If not, I'll have to revert to my previous code (with the additional orientation cases).....

(I guess you should open a new issue, this one is closed)
No, it seems you can't do both auto-orientation and DCT-level scaling at the same time in SkiaSharp.
Skia itself supports this with its SkCodecImageGenerator, but SkiaSharp doesn't expose this.
I would suggest to open a new issue to expose this class.
However, when looking at the C++ codec of how Skia applies the orientation, we see it is just drawing the image to a canvas, creating a temporary internal bitmap! In many cases, this is not very efficient, as this could be a SIMD inplace operation...
Anyway, we can cook something like that ourselves...
Here's the code I'm using.
First, we need a way to convert the orientation into a transformation matrix, and to flip width & height if a 90 degree rotation happens.
Based on the Skia C++ code, we can make something like this:
private static (SKMatrix? transform, int width, int height) GetOrientationMatrix(SKEncodedOrigin origin, int sourceWidth, int sourceHeight)
{
	var isRotated = origin >= SKEncodedOrigin.LeftTop;
	var (w, h) = isRotated ? (sourceHeight, sourceWidth) : (sourceWidth, sourceHeight);

	// Based on SkEncodedOriginToMatrix in the Skia source code.
	SKMatrix? transform = origin switch
	{
		SKEncodedOrigin.TopRight => new SKMatrix(-1, 0, w, 0, 1, 0, 0, 0, 1),
		SKEncodedOrigin.BottomRight => new SKMatrix(-1, 0, w, 0, -1, h, 0, 0, 1),
		SKEncodedOrigin.BottomLeft => new SKMatrix(1, 0, 0, 0, -1, h, 0, 0, 1),
		SKEncodedOrigin.LeftTop => new SKMatrix(0, 1, 0, 1, 0, 0, 0, 0, 1),
		SKEncodedOrigin.RightTop => new SKMatrix(0, -1, w, 1, 0, 0, 0, 0, 1),
		SKEncodedOrigin.RightBottom => new SKMatrix(0, -1, w, -1, 0, h, 0, 0, 1),
		SKEncodedOrigin.LeftBottom => new SKMatrix(0, 1, 0, -1, 0, h, 0, 0, 1),
		_ => null
	};

	return (transform, w, h);
}

Given any SKPixMap sourceMap, we can then apply this orientation transform
var (orientationMatrix, orientedWidth, orientedHeight) = GetOrientationMatrix(orientation, sourceMap.Width, sourceMap.Height);

var transformedMap = sourceMap;

if (orientationMatrix.HasValue)
{
	// Need to apply orientation
	// Code below based on draw_orientation at https://cs.skia.org
	var newInfo = sourceMap.Info;
	newInfo.Width = orientedWidth;
	newInfo.Height = orientedHeight;

	using var tempBitmap = new SKBitmap(newInfo, SKBitmapAllocFlags.None));

	using var canvas = new SKCanvas(tempBitmap);
	using var sourceBitmap = new SKBitmap();
	// NOTE: InstallPixels *does not* transfer ownership of pixels!
	// We must keep sourceMap alive as long as sourceBitmap lives.
	// In our cause, this is just what the doctor ordered.
	sourceBitmap.InstallPixels(sourceMap);

	using var paint = new SKPaint
	{
		BlendMode = SKBlendMode.Src,
		FilterQuality = SKFilterQuality.None
	};

	canvas.SetMatrix(orientationMatrix.Value);
	canvas.DrawBitmap(sourceBitmap, 0, 0, paint);

	transformedMap = tempBitmap.PeekPixelsEx();
}

// TODO: Don't forget to dispose the transformedMap when it is different from the sourceMap!

PS: Unfortunately, in my benchmarks, the Skia solution is still twice as slow as the DirectX/WIC approach that I currently use on Windows.
PS: Somehow SkiaSharp's JPEG decoder seems to run 3x slower than should be possible based on the libjpeg-turbo. I haven't figured out why this is the case, it might be that libjpeg-turbo is incorrectly compiled or called, or that I'm just doing the benchmarking wrong. I logged this issue here https://github.com/mono/SkiaSharp/issues/1693

Thanks, this is useful. Since it's the loading which is the lion's share of the effort, I suspect minor inefficiencies of creating a temp bitmap are less critical. For the brief benchmarking I did previously, loading scaled takes around 900ms on my M1 MBP, whereas loading the scaled version takes around 150ms. So it's quite a saving. :)
I'll raise the issue you mentioned later today when I get a chance.


Migrate NestedProgram fields to JSONFields

What is the expected enhancement?
NestedProgram has some fields configured as TextFields instead of JSONFields. The idea is migrate the fields to that specific fields to manage the JSON in an easier way. The specific fields that are going to be change are:

arguments
env_vars
dependencies

I'm not sure if I understand this correctly.  The fields are now
    env_vars: Optional[Dict[str, str]] = None
    dependencies: Optional[List[str]] = None

Is this issue still valid?

Nope, probably fixed in some pull request. Thank you, Aki!


Add an option to ignore specific terms

This allows specifically ignoring certain terms by doing e.g.
equality.config.ignoreTerms = {
    host: 'a computer server',
    pop: 'operating on a data structure'
};

I have some misgivings about this particular manner of configuration (reaching in and modifying an object in-place) but it seems like the simplest way to do this without changing the API at all and maintaining backwards compatibility. Other options include:

equality.ignoreTerms(["host", "pop"]) would add the words to the local ignore table
equality({ ignoreTerms: ["host", "pop"] }) would return an attacher with configuration (this would change equality much more significantly, but allow different instances of attachers to have different options, which seems desirable but maybe more trouble than it's worth)

I'm open to any other way to attach options. Also it may be desirable to remove the terms from the patterns and lookup tables, rather than simply ignoring them in check(), but this was by far the easiest and least invasive way of doing it, and the performance downsides (given we're doing a lookup on an object) seem minimal

If you like this, I'd also like to investigate other configure options - one specifically I have in mind is being able to configure it so that "he/she" is also a warning (since it excludes people who don't identify as gender binary) and (as mentioned elsewhere) specific names which trigger allowing gendered pronouns.

Also I should point out I'm more than happy to implement one of the other configuration styles, but it always feels a bit presumptuous to come into someone else's project and do serious restructuring. If you like in principle doing something like having a "default instance" of the attacher which also has a method to create a custom attacher (so that it wouldn't break backwards compatibility) I could do that, too.
I have to say though I really like the clean, functional way in which retext-equality is implemented and I'm kind of loathe to make it more object-oriented. I might go with a simple closure-generator where you do either retext.use(equality) or retext.use(equality.withConfig({ ... }))? At any rate this is definitely the main thing blocking me from making this part of our CI so I'm eager to do what it takes to get the pull request accepted (I hate either vendoring in packages or depending on a github fork that may diverge from the mainline)

Thanks a lot! I'll reply more in depth soon.
However, I really appreciate the time and thought you put into this! But, I'd prefer the use of standard retext options. As in, the second argument to 'attacher'. Read more about it in the docs: https://github.com/wooorm/retext/blob/master/readme.md#function-attacherretext-options

Ahhhh I didn't know about standard retext options, that sounds much better!
Would you be interested in me changing this to that form, or do you have your own plans and I should abandon this?
FWIW what I'm doing right now is just building an internal version with a custom list of patterns (as there are also some patterns not present in retext-equality we'd like to check for), so there's no rush from my side, but I'm also happy to help :-)

I’d love it if you would be able to find the time to implement this here in retext-equality, @agnoster. Also: really cool that Asana is intending to use alex / retext-equality :+1:
You mentioned patterns you’re using internally, I’d be interested in hearing what those are! Of course, I can imagine that you’d like to keep some private :wink:
I’d go for a method where the second argument passed to retext.use() by users, given as the second argument to retext-equalitys attacher, be an options object with a allow (maybe a different naming) array of strings (maybe a hash, curious to know why you opted for a dictionary mapping between words and different descriptions here?)
There’s also the fact that some phrasing can include multiple words, e.g., man made. Am I correct in assuming your PR doesn’t handle this? One could only allow either man or made to disallow this phrase from matching?

Regarding https://github.com/wooorm/retext-equality/pull/7#issuecomment-148863912:
This could probably be handled in a way where the or pattern is handled as simple. I’m not sure if the or pattern would ever be useful for non-gender patterns (as "or" is by definition binary!)

I'm definitely interested in implementing this! Will update the PR when I get a chance.
At Asana we are currently using gulp-alex to check our entire website (including job descriptions and internal docs) automatically. I'm happy to say that it only found a few issues but they're fixed now :-)
One example of an internal pattern is we decided we don't like the term "non-technical" to describe roles, as it could be seen by some as devaluing non-engineering work which is still in some sense technical. That's not generally a phrase everyone should avoid, though, just something we prefer other phrases for.
I think you're right and this doesn't handle multi-word phrases. Any good suggestions of how best to do that?
And yeah, internally I just bound "simple" to "or" since the reason I initially started integrating this was after we replaced "men and women" with "people". To be honest, I almost would propose this be done generally, it's more inclusive on people who don't identify as gender binary.
On Sat, Oct 24, 2015 at 12:18 PM, Titus Wormer<EMAIL_ADDRESS>wrote:

I’d love it if you would be able to find the time to implement this here in retext-equality, @agnoster. Also: really cool that Asana is intending to use alex / retext-equality :+1:
You mentioned patterns you’re using internally, I’d be interested in hearing what those are! Of course, I can imagine that you’d like to keep some private :wink:
I’d go for a method where the second argument passed to retext.use() by users, given as the second argument to retext-equalitys attacher, be an options object with a allow (maybe a different naming) array of strings (maybe a hash, curious to know why you opted for a dictionary mapping between words and different descriptions here?)
There’s also the fact that some phrasing can include multiple words, e.g., man made. Am I correct in assuming your PR doesn’t handle this? One could only allow either man or made to disallow this phrase from matching?
Reply to this email directly or view it on GitHub:
https://github.com/wooorm/retext-equality/pull/7#issuecomment-150842124

Maybe it’s simplest to create a new whitelist pattern which works exactly like simple but doesn’t warn (just moves the pointer forward so other patterns do not match).
Then, upon attaching, a custom byWord and byId dictionary is created, the allowed phrases are expanded!

@agnoster Ping! Still interested in working on this?

Still interested, in principle - but not had a lot of bandwidth to tackle. :-( I've got a task to track this and will get to it Someday, but if you feel strongly about getting it done I won't feel bad if you beat me to it, either :-)

Thanks for getting back to me, @agnoster. I of course understand time limitations, as I myself am pressed for time too. I hope to be able to get to this soon, but can’t promise anything. Let’s just leave it pending for now until someone finds the time! :+1:

Sounds good!

This was closed by fea3f1a. Thanks so much for the ideas though :+1:

Awesome work, thanks so much!
:heart:


Icon enum missing Success

Hi,
Icon enum does not have Success listed, is there any reason for that?

fixed

1.1.2


Congestion window increases after MTU increase

When the MTU for a path is increased after successfully MTU probing, the congestion window (measured in bytes) is recalculated based on the new MTU size: https://github.com/awslabs/s2n-quic/blob/09d75247a3ddac8ab0930b0d994903c99bf784cb/quic/s2n-quic-core/src/recovery/cubic.rs#L374-L386
RFC 8899 specifies that this should not happen:

An update to the PLPMTU (or MPS) MUST NOT increase the congestion window measured in bytes [RFC4821].

The downside of fixing this is that when the MTU increases, the number of packets in the congestion window will decrease. If middleboxes are mostly buffering based on packet count, rather than total bytes, this would mean we are missing out on a potentially larger window. I haven't been able to find much information that routers/switches behave this way though.
Other implementations are following the specification in RFC 8899:
Linux TCP, which tracks the congestion window (tp->snd_cwnd) in packets, does decrease the number of packets in the window when the MTU is increased, to maintain the same bytes in the congestion window: https://github.com/torvalds/linux/blob/fc02cb2b37fe2cbf1d3334b9f0f0eab9431766c4/net/ipv4/tcp_input.c#L2710-L2712
Google Quiche tracks the congestion window in bytes, but does not change it when the MTU changes

Hi there, I am currently implementing PLPMTUD for Quinn and came across this issue. I'm a bit confused, because RFC 9002 says here that If the maximum datagram size changes during the connection, the initial congestion window SHOULD be recalculated with the new size. Are RFC 8899 and RFC 9002 contradicting each other?

Thanks, that makes things much clearer!


AIn Shams University Account

AIn Shams University is a popular university in Egypt!

AIn Shams University is a popular university in Egypt!


The operator 'aten::arange.start_out' is not currently supported on the ocl backend.

When I try to run VITS I get this:

Accessing device #0:gfx900:xnack- on AMD Accelerated Parallel Processing
Text splitted to sentences.
['Hello world!']
Hello world!
[!] Character 'H' not found in the vocabulary. Discarding it.
Hello world!
[!] Character 'e' not found in the vocabulary. Discarding it.
Hello world!
[!] Character 'l' not found in the vocabulary. Discarding it.
Hello world!
[!] Character 'o' not found in the vocabulary. Discarding it.
Hello world!
[!] Character 'w' not found in the vocabulary. Discarding it.
Hello world!
[!] Character 'r' not found in the vocabulary. Discarding it.
Hello world!
[!] Character 'd' not found in the vocabulary. Discarding it.
/home/leviathan/.local/lib/python3.10/site-packages/torch/nn/functional.py:2233: UserWarning: The operator 'aten::index_select' is not currently supported on the ocl backend. Please open an issue at for requesting support https://github.com/artyom-beilis/pytorch_dlprim/issues (Triggered internally at /home/leviathan/Desktop/YouTube/AI/pytorch_dlprim/src/tensor_ops.cpp:311.)
return torch.embedding(weight, input, padding_idx, scale_grad_by_freq, sparse)
/home/leviathan/.local/lib/python3.10/site-packages/TTS/tts/utils/helpers.py:55: UserWarning: The operator 'aten::arange.start_out' is not currently supported on the ocl backend. Please open an issue at for requesting support https://github.com/artyom-beilis/pytorch_dlprim/issues (Triggered internally at /home/leviathan/Desktop/YouTube/AI/pytorch_dlprim/src/tensor_ops.cpp:311.)
seq_range = torch.arange(max_len, dtype=sequence_length.dtype, device=sequence_length.device)
Traceback (most recent call last):
File "/home/leviathan/TTSTest/test1.py", line 15, in
wav = tts.tts(text="Hello world!", speaker_wav="annitta.wav")
File "/home/leviathan/.local/lib/python3.10/site-packages/TTS/api.py", line 341, in tts
wav = self.synthesizer.tts(
File "/home/leviathan/.local/lib/python3.10/site-packages/TTS/utils/synthesizer.py", line 386, in tts
outputs = synthesis(
File "/home/leviathan/.local/lib/python3.10/site-packages/TTS/tts/utils/synthesis.py", line 221, in synthesis
outputs = run_model_torch(
File "/home/leviathan/.local/lib/python3.10/site-packages/TTS/tts/utils/synthesis.py", line 53, in run_model_torch
outputs = _func(
File "/home/leviathan/.local/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/home/leviathan/.local/lib/python3.10/site-packages/TTS/tts/models/vits.py", line 1124, in inference
x, m_p, logs_p, x_mask = self.text_encoder(x, x_lengths, lang_emb=lang_emb)
File "/home/leviathan/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/home/leviathan/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
return forward_call(*args, **kwargs)
File "/home/leviathan/.local/lib/python3.10/site-packages/TTS/tts/layers/vits/networks.py", line 94, in forward
x_mask = torch.unsqueeze(sequence_mask(x_lengths, x.size(2)), 1).to(x.dtype)  # [b, 1, t]
File "/home/leviathan/.local/lib/python3.10/site-packages/TTS/tts/utils/helpers.py", line 55, in sequence_mask
seq_range = torch.arange(max_len, dtype=sequence_length.dtype, device=sequence_length.device)
RuntimeError: Buffer is not valid for unallocated defvice

Interesting.

RuntimeError: Buffer is not valid for unallocated defvice

This is actual problem. Something fails in cpu fallback. I need to check why it fails.
In any case I'm working on layer_norm now to enable VITS in general - they currently don't work.
Also I must say lots of stuff is still missing and I hadn't tested anything related to NLP (mostly due to lack of experience in that area)

That's the code I've been running, in case it helps:
import torch
torch.ops.load_library("/usr/local/lib/libpt_ocl.so")
torch.ops.load_library("/usr/local/lib/libdlprim_core.so")
torch.utils.rename_privateuse1_backend('ocl')

from TTS.tts.configs.vits_config import VitsConfig
from TTS.tts.models.vits import Vits
from TTS.api import TTS

print(TTS().list_models())
tts = TTS("tts_models/bn/custom/vits-female").to("ocl:0")

wav = tts.tts(text="Hello world!", speaker_wav="annitta.wav")
tts.tts_to_file(text="Hello world!", speaker_wav="annitta.wav", file_path="output.wav")


Transitive closure of a graph

Given a directed graph, find out if a vertex j is reachable from another vertex i for all vertex pairs (i, j) in the given graph. Here reachable mean that there is a path from vertex i to j. The reach-ability matrix is called the transitive closure of a graph.
Graph is given in the form of adjacency matrix say ‘graph[V][V]’ where graph[i][j] is 1 if there is an edge from vertex i to vertex j or i is equal to j, otherwise graph[i][j] is 0
Please assign me this question as a part of LGMSOC 21.
Question Link : https://www.geeksforgeeks.org/transitive-closure-of-a-graph/
Programming language

[ ] C
[ ] C++
[ ] Java
[ ] Python

@Saurabh4626  Assign me in cpp OR python under LGMSOC21

@Saurabh4626 @ravikr126 @Ayush7614 Please Assign me this issue. I will solve it in java Or C++ or C
LGM-SOC'21


Add CONCATENATION to tflite frontend, support Inception V3

add concatenation to tflite frontend to support inception v3.

@kazum @FrozenGene @Huyuwei  please help review this PR

@FrozenGene @srkreddy1238 fixed, please check again.

@srkreddy1238 please follow up on this PR

Thanks @kazum @FrozenGene for reviewing


systemtests/hostaccess: remove redundant sleep

This PR removes one redundant sleep at the beginning of the TestBasicHostAccess test. Based on how the tests come up, this shouldn't be needed.
Let's see what happens on the CI.

LGTM


[Bug, Nuxt]: Hydration children mismatch on HTMLInputElement

Environment
Developement/Production OS: MacBook Air M1, 2020
Node version: v20.11.0 (lts)
Package manager: yarn/npm
Radix Vue version: ^1.5.3
Vue version: 3.4
Nuxt version: 3.11.1
Nuxt mode: universal
Nuxt target: server
CSS framework<EMAIL_ADDRESS>Client OS: MacBook Air M1, 2020
Browser: Chrome 123.0.6312.58

Link to minimal reproduction
Reproduction Link
Steps to reproduce

Open my reproduction link
Initialize the repro (yarn && yarn run dev)
Open devtools console
See Vue Warnings

Describe the bug
chadcn-vue TagsInput example combined with combobox when reproduced with Nuxt.js throws vue warnings:
warn [Vue warn]: Hydration children mismatch on HTMLInputElement
Server rendered element contains fewer child nodes than client vdom.
  at <Primitive id=undefined ref=fn<s> type="text"  ... >
  at <TagsInputInput placeholder="Framework..." class="text-sm min-h-5 focus:outline-none flex-1 bg-transparent w-full px-3" onKeydown= (4) [ƒ, ƒ, ƒ, ƒ]  ... >
  at <TagsInputInput class="w-full px-3" onKeydown= (4) [ƒ, ƒ, ƒ, ƒ] type="text"  ... >
  at <PrimitiveSlot type="text" disabled=false value=""  ... >
  at <Primitive ref=fn<s> as="input" as-child=true  ... >
  at <ComboboxInput placeholder="Framework..." as-child="" >
  at <PrimitiveSlot >
  at <Primitive as-child=true as=undefined >
  at <PrimitiveSlot >
  at <Primitive ref=fn<s> as=undefined as-child=true >
  at <PopperAnchor as-child="" >
  at <ComboboxAnchor as-child="" >
  at <Primitive ref=fn<s> style= {pointerEvents: } as=undefined  ... >
  at <PopperRoot class="w-full" >
  at <ComboboxRoot modelValue= [] onUpdate:modelValue=fn open=false  ... >
  at <Primitive dir="ltr" as=undefined as-child=false  ... >
  at <PrimitiveSlot ref=Ref< undefined > class="flex flex-wrap items-center rounded-md border border-input bg-background py-1.5 text-sm px-0 gap-0 w-80" >
  at <CollectionSlot class="flex flex-wrap items-center rounded-md border border-input bg-background py-1.5 text-sm px-0 gap-0 w-80" >
  at <TagsInputRoot modelValue= [] onUpdate:modelValue=fn onInvalid=fn  ... >
  at <TagsInput class="px-0 gap-0 w-80" model-value= [] >
  at <Index onVnodeUnmounted=fn<onVnodeUnmounted> ref=Ref< undefined > >
  at <Anonymous key="/" vnode= {__v_isVNode: true, __v_skip: true, type: Object, props: Object, key: null, …} route= {fullPath: '/', hash: '', query: Object, name: 'index', path: '/', …}  ... >
  at <RouterView name=undefined route=undefined >
  at <NuxtPage>
  at <NuxtLayoutProvider layoutProps= {ref: Object} key="default" name="default"  ... >
  at <NuxtLayout>
  at <App key=3 >
  at <NuxtRoot>

I have no idea how to properly debug and find the cause for such type of warnings  😄
Expected behavior
There should be no vue warnings
Context & Screenshots (if applicable)

This should be fixed with https://github.com/radix-vue/radix-vue/pull/776 where we try to render <img> with SSR.

@zernonia Sorry for the offtopic question, is it possible to install radix-vue directly from github?
I tried to install radix-vue as "radix-vue": "radix-vue/radix-vue#main", to check if PR you mentioned works, but I get:
Pre-transform error: Failed to resolve entry for package "radix-vue". The package may have incorrect main/module/exports specified in its package.json

I guess I should wait for a release to test it?


Tried to upgrade to 4.1.1-8 and fails with errors

Trying to run the container I get an error about not being able to find Yard gem and fails.
If I try to go back to 4.1.1-1, I get:
Installing mysql2 0.5.3 with native extensions
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

    current directory: /var/lib/gems/2.4.0/gems/mysql2-0.5.3/ext/mysql2
/usr/bin/ruby2.4 -r ./siteconf20201027-995-f0tinz.rb extconf.rb
checking for rb_absint_size()... yes
checking for rb_absint_singlebit_p()... yes
checking for rb_wait_for_single_fd()... yes
checking for -lmysqlclient... no
-----
mysql client is missing. You may need to 'sudo apt-get install libmariadb-dev', 'sudo apt-get install
libmysqlclient-dev' or 'sudo yum install mysql-devel', and try again.
-----
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers.  Check the mkmf.log file for more details.  You may
need configuration options.

I'm running Coreos 2303.4.0 so can't easily install from apt, nor should I have to, the 4.1.1-1 image worked before.
Also not sure why bundle can't find yard?
No plugins installed at this point.
Not using sameersbn mysql.
Any help would be appreciated. Currently the container is up and docker logs show running but site is 502.

hah just noticed #349 this is my exact problem.  But 4.1.1-1 is was working

I would try to bring down the container and manually delete the temp folder in the data volume mount location.  To see if that allows bundle to find things?

I see this in the log:
cp: cannot overwrite non-directory '/home/redmine/data/tmp/bundle' with directory '/home/redmine/redmine/vendor/bund
le'

Same.  There was initially an issue where sym links stop new bundle dir and lock file but after I delete those, bundle and lock appear.
myslq2 is there with proper sub dirs and content but get same extconf.rb fail error and bundler stops.

I see this:
"gcc -o conftest -I/usr/include/x86_64-linux-gnu/ruby-2.4.0 -I/usr/include/ruby-2.4.0/ruby/backward -I/usr/include/ruby-2.4.0 -I. -I/usr/local/include -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -fPIC conftest.c  -L. -L/usr/lib/x86_64-linux-gnu -L/usr/local/lib -L/usr/local/lib/mysql -L. -Wl,-Bsymbolic-functions -Wl,-z,relro -L/build/ruby2.4-IB2yVO/ruby2.4-2.4.10/debian/lib -fstack-protector -rdynamic -Wl,-export-dynamic     -lruby-2.4 -ltrue  -lpthread -lgmp -ldl -lcrypt -lm   -lc"
/usr/bin/ld: cannot find -ltrue
collect2: error: ld returned 1 exit status
checked program was:
/* begin */
 1: #include "ruby.h"
 2:
 3: /*top*/
 4: extern int t(void);
 5: int main(int argc, char **argv)
 6: {
 7:   if (argc > 1000000) {
 8:     printf("%p", &t);
 9:   }
10:
11:   return 0;
12: }
13:
14: int t(void) { ; return 0; }
/* end */

--------------------

/var/lib/gems/2.4.0/extensions/x86_64-linux/2.4.0/mysql2-0.5.3/mkmf.log file

Sry, forgot about this post and can't remember how I got it working.  I think @jcormier 's suggestion around the tmp folder was a big part of it though.


Support validations

Validate

[ ] support author isn't the author of the proposal as well
[ ] proposal isn't already supported by same participant

For https://github.com/oliverbarnes/participate/pull/17


Json optional data path

Related to issue 187.
I think the best way to handle directly providing a Dataframe rather than a path to data is to treat the data_path as optional.
Which it already is, so this adds a check to assert that one of the methods for providing data has been done

I wanted to update the docs to include this feature, then ended up writing a lot of extra JSON Frontend docs. Which ideally should have been a separate PR..


Use of unresolved identifier swift_allocObject

I installed Runtime 2.1.0 using Cocoapods. When I opened Xcode and ran a clean build, I got the following build error in Runtime's Factory.swift:
Use of unresolved identifier 'swift_allocObject.
Here are the details on my environment:

Xcode 10.2 (10E125)
Command Line Tools: Xcode 10.2
Swift version: Apple Swift version 5.0 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)
Cocoapods: 1.5.3 (also tried 1.6.1 with the same results)
Runtime version: 2.1.0 (also tried 2.0.0 with the same results)

Here are the troubleshooting steps I've tried so far:

Removed the post_install from my Podfile, and ran pod install again after deleting the Pods/ directory and Podfile.lock
Tried different versions of Runtime, and 2 versions of Cocoapods (described above)
Deleted DerivedData

Screenshot for more context:

Adding the CRuntime bridging header broke it. Trying to fix it but I'm coming up empty. My cocoapods experience is pretty minimal.

Ah, ok. I manually added the missing const void * _Nullable swift_allocObject function to the CRuntime.h file, and that got the build working as a temporary fix.
I saw your cocoapods branch on the CRuntime repo. Any luck?

Actually, I think the fix is really simple. I cloned the Runtime and CRuntime repos locally, then imported those local pods into my app, rather than using the Cocoapods master repo. The build succeeded when I did that (although there was a warning about not being able to process CRuntime/module.modulemap).
I checked cocoapods.org; it looks like it only has 2.0.1 as the latest version for CRuntime. I think all you need to do is a pod trunk push to get the latest version (2.1.2) on Cocoapods.

I noticed I forgot to do that yesterday and pushed it, but when I tested it out it was still broken for me, so I deleted the trunk. Turns out the project I was using to test out Cocoapods has something else wrong with it. I created a new iOS project and confirmed it works. Guess I shouldn't have used a 2 year old unmaintained project to test it  😅
Anyways, thanks for looking into that!

Ahh, I gotcha. I just did a pod install, built my app, and it seems to be working just fine now. Thanks for the quick turnaround!


Show Distributions after Extend Corpus

After we extended the corpus, we need to clean up the CSV files of four classes (description, citation, invocation, and installation) and run the distribution script to show the distributions in bar graphs.

The distributions have been recorded in Distribution.ipynb.


Create a secret route /data-research

Just a route that everyone who adds feature in the MS can use, that will not be exposed in the UI.

tasks (can be done on different PRs):

[ ] create an empty page in the specified path
[ ] create an easter egg to open that path
[ ] place some nice GIF/emoji to tell everyone it's under development

To clarify, need to create a new URL route not a bus route.

I created a protected path, I hope you liked it (:

@Haim-S thanks for your contribution!
The term protected that we used was misleading, there is no authentication mechanism. Just don't link to that new rout


Fix migration conditions and shared services invariant

PR for issue https://github.com/microsoft/AzureTRE/issues/2234
What is being addressed
Fixing the condition in the migration script so that only duplicated and not deleted shared services are deployed.
As part of the fix, I have realised that he invariant for shared services is wrong.
We need to have only one shared service at one time being active and having operations performed to, but we can't check for status as "deployed", as it can have multiple other statuses (eg "actionSucceeded", etc) and be perfectly valid.
So I made it to check "not deleted", and "not failed to be deployed". If there is a shared service satisfying this criteria, new one cannot be deployed.
This way we can still retry the deployment if the previous one fails.

/test

/test

/test

/test

/test

/test

/test


Use NTPv4

The code was using NTPv3 for some reason, this just updates it to v4.

Thanks for getting involved! We're actually going to lean on the ntptime module from now on as it is the more standard way to achieve this. Previously it wasn't included in the MP build for Pico.


Make RSpec/ExampleWording handle "it will" future tense

Fixes #1751
Replace this text with a summary of the changes in your PR. The more detailed you are, the better.

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Updated documentation.
[x] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have modified an existing cop's configuration options:

[x] Set VersionChanged: "<<next>>" in config/default.yml.

What is the project's preferred way to satisfy these offenses in the code? To me, breaking these small functions into smaller functions doesn't feel like a win.
lib/rubocop/cop/rspec/example_wording.rb:70:9: C: Metrics/MethodLength: Method has too many lines. [12/10]
        def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler ...
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/rubocop/rspec/wording.rb:20:7: C: Metrics/MethodLength: Method has too many lines. [12/10]
      def rewrite ...
      ^^^^^^^^^^^

What is the project's preferred way to satisfy these offenses in the code? To me, breaking these small functions into smaller functions doesn't feel like a win.
lib/rubocop/cop/rspec/example_wording.rb:70:9: C: Metrics/MethodLength: Method has too many lines. [12/10]
        def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler ...
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/rubocop/rspec/wording.rb:20:7: C: Metrics/MethodLength: Method has too many lines. [12/10]
      def rewrite ...
      ^^^^^^^^^^^

You may want to silence the offense with a disable comment.
refs: https://docs.rubocop.org/rubocop/configuration.html#disabling-cops-within-source-code

@ydah Thanks! I took this approach in the latest revision.


fix typo in msi provider

:+1:

technically you don't need to update the changelog, we usually do that, but it looks fine and hasn't merge conflicted on the changelog yet.


Revert "Prevent useless retries on osc cat always failing in pipe"

Reverts os-autoinst/scripts#306

I guess we can avoid this in favor of #307.

https://github.com/os-autoinst/scripts/pull/307 is already merged


Define error handling guidelines

From enarx created by rvolosatovs: enarx/enarx#1038
We should come up with guidelines around error handling.
The main intention is to provide consistent and clear output to the user on errors.
What needs to be included is:

Shared error definition approach. It appears that simple enums are the preferred approach without relying on any external/custom libraries.

$ rg -A 2 'enum .*Error'
src/backend/sev/cpuid_page.rs
94:pub enum Error {
95-    /// the page already contains the maximum number of entries
96-    Full,

src/backend/sev/snp/mod.rs
74:pub enum Error {
75-    /// Something went wrong when communicating with the "outside world"
76-    /// (kernel, SEV platform).

internal/shim-sev/src/pagetables.rs
104:pub enum Error {
105-    /// The given virtual address is not mapped to a physical frame.
106-    NotMapped,

internal/shim-sev/src/allocator.rs
92:pub enum AllocateError {
93-    /// Memory or Size not page aligned
94-    NotAligned,

internal/shim-sev/src/snp/mod.rs
35:pub enum Error {
36-    /// Reasons:
37-    /// - Page size is 2MB and page is not 2MB aligned

internal/shim-sev/src/snp/cpuid_page.rs
94:pub enum Error {
95-    /// no memory allocating structs for the ioctl
96-    NoMemory,

internal/wasmldr/src/workload.rs
13:pub enum Error {
14-    /// configuration error
15-    ConfigurationError,

Error message formatting and style:

Wording, how many implementation details we want to leak
Whether to capitalize the first character of the error or not for consistent output (I vote for lowercase, for more natural wrapping of errors)
Best practices on adding context to propagated errors.

$ rg 'anyhow!\(|context\('
src/cli/mod.rs
49:                .ok_or_else(|| anyhow!("Keep backend {:?} is unsupported", name))
55:                .ok_or_else(|| anyhow!("No supported backend found"))
77:            .ok_or_else(|| anyhow!("No supported workldr found"))

src/cli/log.rs
47:            _ => Err(anyhow!("unknown log target {:?}", s)),

src/backend/binary.rs
30:            return Err(anyhow!("unsupported ELF header: e_ident[EI_CLASS]"));
34:            return Err(anyhow!("unsupported ELF header: e_ident[EI_DATA]",));
38:            return Err(anyhow!("unsupported ELF header: e_ident[EI_VERSION]",));
42:            return Err(anyhow!("unsupported ELF header: e_machine"));
46:            return Err(anyhow!("unsupported ELF header: e_version"));
50:            return Err(anyhow!("unsupported ELF header: p_type == PT_INTERP",));
60:            return Err(anyhow!("unsupported ELF header: e_entry"));
148:            .ok_or_else(|| anyhow!("Shim is missing the executable slot!"))?
154:            return Err(anyhow!("The executable doesn't fit in the slot!"));
165:            return Err(anyhow!("Unable to satisfy sallyport version requirement!"));
180:                return Err(anyhow!("Segments overlap!"));

src/backend/kvm/thread.rs
139:            reason => Err(anyhow!(
147:            reason => Err(anyhow!("{:?}", reason)),

src/backend/sev/builder.rs
108:                    .context("launcher.update_data for CPUID failed")?;
123:                .context("SNP Launcher update_data")?;
135:                .context("SNP Launcher update_data")?;

src/backend/sgx/config.rs
47:                        .ok_or_else(|| anyhow!("SGX shim is missing MISC"))?,
50:                        .ok_or_else(|| anyhow!("SGX shim is missing MISCMASK"))?,
55:                        .ok_or_else(|| anyhow!("SGX shim is missing ATTR"))?,
58:                        .ok_or_else(|| anyhow!("SGX shim is missing ATTRMASK"))?,
62:                    .ok_or_else(|| anyhow!("SGX shim is missing PID"))?,
65:                    .ok_or_else(|| anyhow!("SGX shim is missing SVN"))?,
70:                .ok_or_else(|| anyhow!("SGX shim is missing SSAP"))?;
72:                NonZeroU32::new(ssap.into()).ok_or_else(|| anyhow!("SGX shim SSAP is invalid"))?;
76:                .ok_or_else(|| anyhow!("SGX shim is missing BITS"))?;

I support better definition of this in the style guide!


📄: add caveat section

(just in case)

please don't merge this for as long as you can hold out :)

@threepointone haha! i know, it's too fun, right?


tf.raw_ops.ExtractImagePatches: Assertion failure in shape inference step

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
tf 2.17
Custom code
Yes
OS platform and distribution
Linux Ubuntu 22.04 LTS
Mobile device
No response
Python version
3.11.7
Bazel version
6.5.0
GCC/compiler version
clang 16
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
tf.raw_ops.ExtractImagePatches can lead to assertion failure in shape inference step.
Error location is here:
      TF_RETURN_IF_ERROR(c->Multiply(
          c->Dim(input_shape, 3), ksize_rows * ksize_cols, &output_depth_dim));

Because it does not check validity of ksize_rows * ksize_cols, the negative value of it is fed to Multiply:
Status InferenceContext::Multiply(DimensionHandle first,
                                  DimensionOrConstant second,
                                  DimensionHandle* out)

And it ends up with assertion failure at a constructor of DimensionOrConstant.
Standalone code to reproduce the issue
import tensorflow as tf

tf.compat.v1.disable_eager_execution()

tf.raw_ops.ExtractImagePatches(
    images=tf.random.normal([1,1,1,1]),
    ksizes=[1,-1,2,1],
    strides=[1,1,1,1],
    rates=[1,1,1,1],
    padding="VALID",
    name=None
)

Relevant log output
Release build: Outputs nothing
Debug build:
2024-02-27 20:05:58.701202: F ./tensorflow/core/framework/shape_inference.h:891] Check failed: val >= 0 || val == InferenceContext::kUnknownDim Dimension must be non-negative or equal to InferenceContext::kUnknownDim but got -2
Aborted (core dumped)

In release build, we can observe unstable intermediate tensor with invalid dim(gist).
import tensorflow as tf

tf.compat.v1.disable_eager_execution()

x = tf.raw_ops.ExtractImagePatches(
    images=tf.random.normal([1,1,1,1]),
    ksizes=[1,-1,2,1],
    strides=[1,1,1,1],
    rates=[1,1,1,1],
    padding="VALID",
    name=None
)

# Prints "True"
print(tf.is_tensor(x))

# Ends up with "ValueError: Dimension -2 must be >= 0"
print(x)

Hi @Sehun0819 ,
I think this behaviour exists if negative values passed to strides and rates also. Validation might be costly in that case.Since this behaviour is specific to a debug build and official builds won't have this behaviour, could you please mention the build command used for this build. May be there exists a nice way for fixing this.
Thanks!

@SuryanarayanaY
Hi!
I built it following manual with --config=dbg.
I just found that it runs without any error message when both ksizes[1] and ksizes[2] are negative(gist), and it seems even worse.
import tensorflow as tf

x = tf.raw_ops.ExtractImagePatches(
    images=tf.random.normal([1,1,1,1]),
    ksizes=[1,-1,-2,1],
    strides=[1,1,1,1],
    rates=[1,1,1,1],
    padding="VALID",
    name=None
)

# Tensor("ExtractImagePatches_8:0", shape=(1, 3, 4, 2), dtype=float32)
print(x)

Hi @Sehun0819 ,
The DCHECK pointed here already addresses in PR #63089. I believe the API still lacks some validations.


Add Press Back Again Toast in Simulator

Fix #368
@opticod Please Review. PR for templates sent too.
I have also handled another case - Earlier on pressing back when navigation drawer was opened caused drawer and app both to close. Now only drawer closes.

@opticod Changes made !! Please review.
A side note - In Quiz and some templates having navigation bar, if let you open a simulator => Ques 1 appears, now if you open same from navigation bar => Press back => Nothing happens (it looks that bug is still not solved but it is !! (back press killed the duplicate instance of Ques 1)

Will soon start reviewing and merging the PRs. Thanks.


WIP: Issue #34 - Unit tests for CopyButton component

Fixes #34
Description
WIP
Other information
WIP
Checklist:
WIP

Closing this PR. New one including unit along with e2e tests on:
https://github.com/creativecommons/cc-chooser/pull/46


Initial solution by raipc

Check List:

[x] Tests pass (./test.sh <username>)
[x] All formatting changes by the build are committed
[x] Output matches that of calculate_average_baseline.sh

Execution time: 0m11.721s
Execution time of reference implementation: 4m49.937s

My solution is based on implementing fork/join tasks and using JVM internals to access vectorized intrinsics.

Added custom hash map -- decreased exec time to  0m8.542s

@gunnarmorling I fixed the script and license. Could you merge it, please?

Have some patience, please :) I'm swamped with submissions, and there's an issue with the evaluation environment to sort out. I'll get to this in due course. Thx for hanging in!

00:10.473. Thx for participating!


Add UK Regions to Supported EU Statsbeat Regions

Update Statsbeat EU regions.

@AaronMaxwell

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


refactor(freespace_planner): parameterize margin.

Description
Resolves #1165
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Thank you for your contribution!
Could you also add config parameter here for upper launching layer?

Yes, I can do that! @shmpwk

@shmpwk Should I create a new issue?

@klu17
https://github.com/autowarefoundation/autoware.universe/issues/1165 is enough, thank you.

@klu17
Thank you for your refactoring.
I'm checking it works correctly.
(But for me, it looks like it doesn't change anything. Let's me check for a while.)
Also, it is very helpful if you modify readme https://github.com/autowarefoundation/autoware.universe/tree/main/planning/freespace_planner

Thank you for adding readme.
Also thank you for summing up the commit, but you don't have to since actually we will squash marging the commit.
(And I'm still testing now......)

@klu17 Could you fix this?
https://github.com/autowarefoundation/autoware.universe/pull/1190#pullrequestreview-1022837633

Should be up now.

@klu17 Thank you for your full commitment!


Release notes should link to the correct version

URL to the relevant documentation
https://docs.quantum.ibm.com/api/qiskit-ibm-runtime/release-notes
Please describe the UI problem.
If I'm looking at Qiskit Runtime .20, for example, and click Release Notes, it just opens the Release notes at the top of the page and in the current version of the API.  It's pretty jarring.  Could we possibly link it to the correct location in the Release notes?

in the current version of the API.

This is intentional to avoid duplicating the release notes for each version. We used to do this and realized it was overly complicated.

Could we possibly link it to the correct location in the Release notes?

This would be cool. I think it will look like in _toc.json for historical API versions putting the link to the release's anchor.


Support previous versions of the same CRD

What problem are you facing?

When upgrading stack-gcp from v0.4.0 to v.6.0. some of the existing resources are not supported. For instance, the following network resource that already exists:
apiVersion: compute.gcp.crossplane.io/v1alpha3
kind: Network
metadata:
  name: my-network
spec:
  name: my-network
  providerRef:
    name: gcp-provider
  reclaimPolicy: Retain
  routingConfig:
    routingMode: REGIONAL

is no longer supported (e.g. apiVersion: compute.gcp.crossplane.io/v1alpha3 does not exist in stack-gcp v0.6.0).
How could Crossplane help solve your problem?

Keep all the previous api versions for backward compatibility, unless there is a major version bump.

Tracked here https://github.com/crossplane/crossplane/issues/1584


Grammar config filename typo

Thanks for putting this together.  I just spotted the grammar config filename is grscript.toml instead of gdscript.toml

whoops, thanks!


Request for rbenv list as an alias for rbenv versions

I keep running rbenv list, because so many other version managers use list. e.g. nvm list, rvm list, brew list. I think most CLI tools have adopted list as a standard command. I have to keep reminding myself that rbenv uses a different versions command, and it's a bit annoying since I only run it a few times a year.
Other people have run into this as well: https://github.com/rbenv/rbenv/issues/1105
I think it would be very nice to add an alias, even if it's undocumented. Thanks for your consideration!

Thank you for the feature request, but I am unconvinced of this now just the same I was unconvinced back then.
With rbenv list, it's not clear what property you are listing. With rbenv versions, it's clear that you are listing versions. This command isn't difficult to discover either, as it's clearly documented.


[Flag] Adding Scotland and Wales

Scotland and Wales flags are available in the sprite, but do not exist in the CSS. Added them in this PR. Their ISO code is "GB-SCT", and "GB-WLS", respectively, as described in https://en.wikipedia.org/wiki/ISO_3166-2:GB

Check notes

Corrected the name, @jlukic

@edumucelli Sorry, somehow slipped through the cracks

Added #3494 to merge on next.


Use package root document

Any chance this could address #158? If not should I start off from this PR to try to properly (re)implement .cas (as it appears to be a pretty significant refactoring)?

Yeah, so this was originally supposed to resolve the issue caused by needle ( #164). This is going to be a larger refactor. The goal is to have separate "strategies" (e.g. registry/ npm, git, etc.). This branch is quite experimental. I think the .cas improvement should be on master, since it's quite significant and more important than this branch.


OrderItem's product_reference is a CharField

This may not seem like a bad thing now, but it becomes a problem if you ever want to do analysis on that data ( see airtonix/cmsplugin-shop#1 ).
Is there any reason why this would not be a ForeignKey with on_delete=[NULL|PROTECT] ? This would allow ORM querying as expected and also preserve OrderItems when Products are deleted.
I would be happy to submit patches/tests if needed.

AFAIR I fix this long time ago https://github.com/divio/django-shop/blob/master/shop/models/defaults/bases.py#L421

Apologies, I must have glossed over it. Is there any reason why product_reference still exists then?

Compatibility with old installations?


sid timeout for long-lasting instances

Hi,
I have come from the home-assistant community where we're having an issue around SIDs expiring and causing any instanced SurveillanceStation instances to become stale, requiring a full restart of the app.
What are your thoughts about your library silently re-establishing connections in cases like that? Meaning when you get an exception from Synology:
https://github.com/home-assistant/home-assistant/issues/12037
Just recreate the API?

Thanks for raising this, I'll have a look this weekend to see what should be done. Ideally this should be handled inside this lib

@cmsimike what do you think of this PR? https://github.com/snjoetw/py-synology/pull/4

@snjoetw Thank you for your work on this, and apologies for the delay in getting back to you. I will test this out and let you know.

Installed! Ill report back in a few days.

Thanks! Hopefully this fixes your problem.
btw how do you reproduce it? Do you just leave it run for a few days and it’ll start erroring out?
It’s weird that I’ve never seen the error myself. I have a DS216+II with DSM 6.2

Exactly that. I (unfortunately) never paid too much attention when it goes out but eventually after a few days the cameras won't load anymore and I am spammed in the log with exception.

Closing this one and will integrate with next home assistant release


Cannot set headers after they are sent to the client

Hi.
I'm using remix-fastify with streaming hydration, and sometimes I got this error:
Error: Cannot set headers after they are sent to the client
    at new NodeError (node:internal/errors:393:5)
    at ServerResponse.setHeader (node:_http_outgoing:644:11)
    at ServerResponse.writeHead (node:_http_server:377:21)
    at onSendEnd (node_modules/fastify/lib/reply.js:598:7)
    at onSendHook (node_modules/fastify/lib/reply.js:529:5)
    at fallbackErrorHandler (node_modules/fastify/lib/error-handler.js:130:3)
    at handleError (node_modules/fastify/lib/error-handler.js:60:5)
    at onErrorHook (node_modules/fastify/lib/reply.js:699:5)
    at _Reply.Reply.send (node_modules/fastify/lib/reply.js:133:5)
    at defaultErrorHandler (node_modules/fastify/lib/error-handler.js:91:9)

My server file is identical to the example/server.js, my entry.server.ts file is like this

hm, to my knowledge i don't think i've seen this, but i'll keep an eye out for it

alright got it to happen if i spam refresh the page - i'll try and see what's up with it

This still happens on v2.2.1 @mcansh


Automated cherry pick of #8420: fix: add rds quota check

Cherry pick of #8420 on release/3.5.
#8420: fix: add rds quota check

/lgtm
/approve


Inventory and create library functions for common functionality

[x] #2637
[ ] #2786
[ ] publishToArtifactRepository - published artifacts to artifacts.opensearch.org location following release practices
[ ] publishToCrates - publish to crates.io (rust artifacts)
[ ] #2839
[ ] publishToRubyGems: Ruby client is published to RubyGems.org. Note: The signing for ruby takes place when the artifact is built. In order to replicate the build environment of ruby clients they need to be build on docker images which can be also used by release pipeline
[ ] publishToNuGet: The dot net client is published to NuGet
[ ] publishToDockerHub
[ ] publishToECR
[ ] More to add if any.

Client   Universal Release process (ETA)
opensearch-py-ml    November 15th, 2022
opensearch-py          November 15th, 2022
Java                            November 30th, 2022

Closing this issue as all tasks are complete. For packagist we do not need to add a library as it is directly integrated with GitHub.


'react-native init MyApp --template demo' is not work

react-native init MyApp --template navigation is OK for me , but why react-native init MyApp --template demo  is not.

Hey, thanks for reporting this issue!
It looks like your description is missing some necessary information. Can you please add all the details specified in the template? This is necessary for people to be able to understand and reproduce the issue being reported.
I am going to close this, but feel free to open a new issue with the additional information provided. Thanks!


[issuefix]:clusterloader2 testing result missing ControllerManagerMet…

…rics #895

remove all outdated metrics labels for interestingControllerManagerMetricsLabels and replace with new labels
Changes to be committed:
modified:   clusterloader2/pkg/measurement/common/metrics_for_e2e.go

Review tips:
I listed all the available metrics labels in case you want to add anyone during review.

/ok-to-test

/lgtm
/approve


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-27-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3783

Questions ?
Please refer to the Backport tool documentation


Support for encoding/decoding non-string messages

I've been trying to figure out how to send Avro-encoded messages with kafka-python. As best as I can tell, this isn't possible, since the write_int_string  method called by _encode_message checks to make sure that the message is of type String, and errors out if this is not the case.
I don't see any reason why the kafka-python Producer should require that the message be a string, since Kafka messages are just bytes. Why was this design decision made, and is this something that's easily changeable to support non-string messages?
Or, am I just missing something, and this is possible with the current release of kafka-python?

Hi, late to the party here, but I've been looking all over the internet to find an example that can show me how to implement kafka-python using an avro encoding and I can't find anything amazingly.  Would you be able to point me to any code samples for this?  It would be greatly appreciated.  Thanks.

Heh blast from the past, I'd forgotten that I worked on this issue.
I was able to dig up this script and, miraculously, it worked. Here's a gist that should get you started:
https://gist.github.com/jakekdodd/e7ee38fd945818d86eb4

Nice thank you!  That's very helpful.  I appreciate it.

KafkaProducer and KafkaConsumer classes support value_serializer and value_deserializer, respectively, which mean you can use any arbitrary function to convert messages to bytes and back.


Add an Express.js middleware

Why 2.0? This does not break, right?

2.0 will isolate marshalling from server implementation modules, allowing you to easily make an npm xmlrpc-express that just implements express middleware and requires just the marshalling module and has express-oriented unit tests!. If we supply middleware for express within this module, the next PR will be for another framework, and then another, and so on; it will bloat this module and cause unnecessary centralization and more work for the maintainers of this module.
Since unfortunately no one is actually working on 2.0, I'll make a start with it and expedite a workable marshalling-only module, that I will depend on with 2.0 and you can depend on in an express middleware module. I'll update here when I have something up.

Please see xmlrpc-js/xmlrpc-marshalling for a working (but not-yet documented) marshal/unmarshal module, split off from here, that you can depend on within an express middleware module. The module has been published to npm in it's 0.0.1 form.
You can see how I'm planning to implement it for 2.0 over at patricklodder:2.0-dev
I'd guess that after adapting to the marshalling API, your middleware function would look something like this:
var Marshalling = require('xmlrpc-marshalling');
var Unmarshaller = Marshalling.Unmarshaller;
var Marshaller = Marshalling.Marshaller;

function xmlrpcExpressMiddleware (routes, notFoundFn) {
  return function(req, res) {
    var unmarshaller = new Unmarshaller();

    var callback = function(error, value) {
      res.header('Content-Type', 'text/xml');
      if (error !== null) {
        return res.send(Marshaller.marshalFault(error));
      } else {
        return res.send(Marshaller.marshalMethodResponse(value));
      }
    };

    return unmarshaller.unmarshalMethodCall(req, function(error, methodName, params) {
      if (routes.hasOwnProperty(methodName)) {
        return routes[methodName].apply(null, params.concat(callback));
      }

      // Method not found
      if (typeof notFoundFn === 'function') {
        notFoundFn(methodName, params);
      }
      return res.status(404).end();
    });
  };
};

Please let me know if this helps you.


Reporting certain pattern parse errors

Putting this into the repl:
» 0,0

...yields this panic:

'not yet implemented: unhandled parse error: Pattern(IndentEnd(3, 7), 3, 6)', compiler/reporting/src/error/parse.rs:534:14

Similarly, this:
» 0,

...yields a similar panic for a different Pattern variant:

'not yet implemented: unhandled parse error: Pattern(Start(3, 6), 3, 6)', compiler/reporting/src/error/parse.rs:534:14

Update: 0,0 now results (in the online REPL) in:
» 0,0

── UNEXPECTED COMMA ────────────────────────────────────────────────────────────

I am trying to parse an expression, but I got stuck here:

1│  app "app" provides [replOutput] to "./platform"
2│
3│  replOutput =
4│      0,0
         ^

This comma in an invalid position.

which looks ok. However, 0, still yields a panic.

I got a an error message instead of a panic with 0, now, still needs improvement though.
» 0,

── UNHANDLED PARSE ERROR ───────────────────────────────────────────────────────

I got stuck while parsing this:

1│  app "app" provides [replOutput] to "./platform"
2│
3│  replOutput =
4│      0,
          ^

Here's the internal parse problem:

    Pattern(Start(@68), @68)

Unfortunately, I'm not able to provide a more insightful error message
for this syntax problem yet. This is considered a bug in the compiler.

Note: If you'd like to contribute to Roc, this would be a good first issue!


feat: Adds support to multiple dependencies to the native filters

SUMMARY
Adds support to multiple dependencies to the native filters. This will allow the user to create hierarchical and graph relationships among filters. The changes are the result of a series of interviews conducted by the design team with Superset users. Here's a summary of the changes:

Creates the "Values are dependent on other filters" section
Removes the "Filters is hierarchical" section
Adds indentation to the collapsable containers
Removes the hierarchical display of filters in the left panel of the modal
Adjusts the algorithm to validate circular dependencies on the fly
Remove cascading popovers from filter bar @kgabryje
Effectively uses the filter cards to display filter context
Adjusts RTL and Cypress the tests

It's important to note that major refactors are not in the scope at this stage. Our first objective is to deprecate FilterBox. We'll tackle code improvements in the next stage of the native filters revamp.
@kasiazjc @jess-dillard
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/70410625/155568831-ae7871b9-5c54-4060-beeb-11ac70978463.mov
TESTING INSTRUCTIONS
We need to test the whole module. Apart from the basic tests, some important behaviors that should be checked:

When selecting "Values are dependent on other filters" a value is automatically suggested and this value does not generate a circular dependency warning if possible.
The circular dependency checking should occur on the fly while the user is selecting the filter dependencies.
If a filter is removed or has its type changed to one different than "select", all references to this filter should display "(deleted or invalid filter)". After saving and reopening the modal, that reference should disappear.
Only filters of type "select" should be available to be referenced as a dependency.
All filters in scope should be displayed on the filter bar independently of their relationships.
The values of a filter should be affected by its dependencies when applicable.
The filter card context is correctly displayed and text is truncated as expected. Please refer to #18874 to see the requirements.

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

/testenv up

@kasiazjc @jinghua-qa @rusackas We can start testing the feature. Don’t worry about code review, this PR is a combination of a few PRs that have already been reviewed.
As soon as we get Preset’s approval, we’ll tag more people from the community to also validate the feature.

/testenv up

I found a problem in config modal - when we add a new filter, dependencies for other filters get reset
https://user-images.githubusercontent.com/15073128/155576669-6aece1ab-2b76-48b4-81b2-b2a9cb43ec7a.mov

@michael-s-molina I found a problem in config modal - when we add a new filter, dependencies for other filters get reset

Fixed.

Also, it looks like adding a new filter triggers rerendering of all other filters and charts, but I'm not sure if this was introduced in this PR or if it's an old issue

This also happens on master so it's not a problem introduced by this PR. I think this falls under the category of performance improvements and should be planned and addressed in another PR.

/testenv up

I found an issue that default value did not stay
https://user-images.githubusercontent.com/81597121/155784379-c0b263b2-695e-4483-9992-24dfbf7be02b.mov

Another issue that could be related to the default value did not show in the filter is:
when select time range with required setting, since the default value did not show in time range filter, it show error in time range filter and other filters can not apply change
https://user-images.githubusercontent.com/81597121/155816507-4a9be646-7d16-4aad-8b54-519cd86a7969.mov

When user select a scope for the filter, the scope of the chart information will not show in the tooltip? When the filter apply to all it will show " apply to all charts", but if it is only applied to selected chart or tab it did not show which scope it is in the tooltip, is this expected?
Uploading Screen Recording 2022-02-25 at 3.39.51 PM.mov…

When user select a scope for the filter, the scope of the chart information will not show in the tooltip? When the filter apply to all it will show " apply to all charts", but if it is only applied to selected chart or tab it did not show which scope it is in the tooltip, is this expected?
Screen.Recording.2022-02-25.at.3.33.54.PM.mov

Yes - tooltip shows only when text is truncated. I think there's no point in listing every chart in the dashboard when scope is "All charts". As for the second case - yes, not showing "Scope" row when nothing is in scope was intentional. I can add a row "Scope: None", but I don't think there's a point in creating a filter with nothing in scope and then opening "Out of scope panel" to see that filter. @kasiazjc wdyt?

When user select a scope for the filter, the scope of the chart information will not show in the tooltip? When the filter apply to all it will show " apply to all charts", but if it is only applied to selected chart or tab it did not show which scope it is in the tooltip, is this expected?
Screen.Recording.2022-02-25.at.3.33.54.PM.mov

Yes - tooltip shows only when text is truncated. I think there's no point in listing every chart in the dashboard when scope is "All charts". As for the second case - yes, not showing "Scope" row when nothing is in scope was intentional. I can add a row "Scope: None", but I don't think there's a point in creating a filter with nothing in scope and then opening "Out of scope panel" to see that filter. @kasiazjc wdyt?

For "All charts" we won't be showing a tooltip, because as Kamil said it does not make sense to list all of the charts/tabs. If there is no scope added though we should still keep the "scope" row with value "none" as it is a valuable information for the user who is looking for information about the filter.

I found an issue that default value did not show in the filter value, the filter is applied, i saw it in the query and in the filter indicator.
Screen.Recording.2022-02-25.at.11.39.42.AM.mov

Thanks for spotting that! It looks like the bug is present on master though, so maybe let's fix that in a separate PR?
Same applies to the second comment about filter value

@jinghua-qa Fixed by #18963

Empty scope done @jinghua-qa @kasiazjc

When user select a scope for the filter, the scope of the chart information will not show in the tooltip? When the filter apply to all it will show " apply to all charts", but if it is only applied to selected chart or tab it did not show which scope it is in the tooltip, is this expected?
Screen.Recording.2022-02-25.at.3.33.54.PM.mov

Yes - tooltip shows only when text is truncated. I think there's no point in listing every chart in the dashboard when scope is "All charts". As for the second case - yes, not showing "Scope" row when nothing is in scope was intentional. I can add a row "Scope: None", but I don't think there's a point in creating a filter with nothing in scope and then opening "Out of scope panel" to see that filter. @kasiazjc wdyt?

For "All charts" we won't be showing a tooltip, because as Kamil said it does not make sense to list all of the charts/tabs. If there is no scope added though we should still keep the "scope" row with value "none" as it is a valuable information for the user who is looking for information about the filter.

Thank you for your explanation.

Hi @graceguo-supercat @amitmiran137. I'm tagging you to help us review this PR that effectively implements all the changes planned for stage 1 of native filters. This PR is a combination of multiple PR that should be merged together and were previously reviewed so you can focus more on functionality than the code. Tagging @rusackas as well who is coordinating the work for deprecating FilterBox which should be possible after this PR.

/testenv up

I found an issue related to the number filter, it is also in master
https://github.com/apache/superset/issues/18985

/testenv up

Looks great! From my perspective - all of the things that were supposed to be included in Stage 1 were implemented and are added to this PR. I also tested the feature and it seems to be working well. Kudos @michael-s-molina @kgabryje @jinghua-qa 👏
One additional comment from me - you may see that the filter type is different on filter card and in "add/edit filters" modal. This is something that has to be fixed separately and hopefully will be fixed soon (cc: @kgabryje)

One additional comment from me - you may see that the filter type is different on filter card and in "add/edit filters" modal. This is something that has to be fixed separately and hopefully will be fixed soon (cc: @kgabryje)

The reason for that is that in filter cards we use "official" filter names from metadata, while in the modal there's a mapping from metadata names to different names. We should change the names in metadata to match the ones in the mapping, probably do a db migration and delete a mapping.
CC @villebro

@michael-s-molina this is great! i play with it sample dashboards, no issues were found!
I have only 1 question. definitely LGTM!


WIP: Add container image for uploading files to GCS

Also update other container image directories to correct example build
instructions.
Signed-off-by: Chris Evich<EMAIL_ADDRESS>

note to me: add a "test" cirrus job that uploads a file to verify functionality

note to me: add a "test" cirrus job that uploads a file to verify functionality


left-sidebar: Add scrollbar to the list of private messages.

Recent PM's list doesn't have scrollbar #5384
Testing Plan:
Created a lot of private messages and placed a scrollbar on the list, restricted it's width and observed that the scrollbar is working.
GIFs or Screenshots:

@showell can you review this one?  You've had that part of the code in cache more recently than I have :)

I get this when I reload with a stream as the narrow:

I tested this and found no bugs.
Tim, you will probably want to just squash this into one commit, because without the scroll behavior the other changes aren't really necessary.  (But I do appreciate that they were broken out for easier review.)
One possible improvement is to call ui.set_up_scrollbar inside of rebuild_recent, and then we wouldn't need the length check.

One layout thing is that the background color for the PM list extends all the way right, so it doesn't look great when you have the scrollbar on top of it.  I don't think we need to block on that--tweaking layout in the left sidebar can be a bit risky.  Although in theory it should be a two-line fix or so.

@timabbott @showell are there any changes I need to make before it gets merged?

Squashed and merged, thanks @Raghavareddy21!


Define GitHub action to get notifications about IDE-related issues

The GitHub Slack plugin does not support listening to multiple labels. We work around this limitation by setting up a github action that sends similar messages.
The PR can be merged after we have the Slack webhook URL deployed as secret on the gradle/gradle repository.

@bot-gradle test and merge please

No milestone for this PR. Please set a milestone and retry.

@bot-gradle test and merge please

Your PR is queued. See the queue page for details.

I've triggered a build for you.


AUI-2037

Just started reviewing :) :octocat: Sent from GH.

Pull request submitted to https://github.com/mairatma/alloy-ui/pull/287. :octocat: Sent from GH.


raycast: 1.53.0 -> 1.53.2

Description of changes
raycast: 1.53.0 -> 1.53.2

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 237284 run on aarch64-darwin 1

1 package built:

raycast


fix(contentBlockMixed): align to non-gutter grid

Related Ticket(s)
#4962
Description
Align to non-gutter grid line. Also updated stories to match react storybook options.
Changelog
Changed

use CSS grid for layout for <dds-content-block-mixed>.

LGTM basically, one question; Did we need any CodeSandbox updates? Thanks @ariellalgilmore!

Good catch! looks like a codesandbox was never created for this component.

Thank you for clarifying @ariellalgilmore! Another question; Seems that there are changes to two other components. Do their stories and CodeSandbox need any update? Or are they not necessary...?

Thank you for clarifying @ariellalgilmore! Another question; Seems that there are changes to two other components. Do their stories and CodeSandbox need any update? Or are they not necessary...?

The other components are not necessary. I will create a codesandbox example for content-block-mixed though and include in this PR.


Popup feature

Modify the code for pop up feature when copy button is clicked

We have enhanced the pop-up when the 'copy' is clicked


face_recognition in ROS

face_recognition version: 1.2.2 // dlib version: 19.7
Python version: 2.7.6
Operating System: Ubuntu 14.04.x (Trusty)

Description
I have installed the face_recognition package in the system (sudo pip2 install face_recognition) and also the dlib library.
I am trying to use the package in a ROS node with python. When I compile it (build the package) in ROS, it says: "face_recognition has no module called 'load_image'", so I guess I am not importing the package correctly in ROS. I have tested it as a simple python script and it gives no problems of compilation or execution, only when I use the package in ROS.
My guess is that I have not set up the CMakeLists.xml file correctly (I am starting to develop in ROS), so I have also tried to import the package in ROS, like:
find_package(face_recognition REQUIRED)
include_directories(${face_recognition_INCLUDE_DIRS})
But no luck, when I compile it (build it), it gives the next error:
By not providing "Findface_recognition.cmake" in CMAKE_MODULE_PATH this
project has asked CMake to find a package configuration file provided by
"face_recognition", but CMake did not find one.
Could not find a package configuration file provided by "face_recognition"
with any of the following names:
face_recognitionConfig.cmake
face_recognition-config.cmake
Add the installation prefix of "face_recognition" to CMAKE_PREFIX_PATH or
set "face_recognition_DIR" to a directory containing one of the above
files. If "face_recognition" provides a separate development package or
SDK, be sure it has been installed.
Did you ever find this errors? How can I use the package in ROS?
Thank you in advance.
What I Did
Up to now, I am only using the next commands:

#! /usr/bin/env python
import rospy
import face_recognition
...
image_path = "pictures/ivan_2.png"
rospy.loginfo("Este es el path de la foto: ")
rospy.loginfo(image_path)

image = face_recognition.load_image(image_path)
face_encoding = face_recognition.face_encodings(image)[0]

I am not doing more, as there is where the first error appears.
Any help would me amazing.
Thanks!
//Ivan L

I have never used ROS and am not familiar with it in particular, so I don't know for sure.
But face_recognition itself is purely python and has no CMake component to compile. Nothing with CMake would be required. Only dlib (which this depends on) uses CMake.
Based on the error you got, one obvious thing to check is to make sure you didn't name your own file face_recogntion.py because that is one thing that could cause the error you saw since that name would conflict with the name of the library itself and make Python load your file again instead of loading the real library.
Beyond that, I'm not sure because I've never seen ROS.