Terraform v0.12.x

Terraform v0.12 is a major release, including changes to the HCL language and provider plugin protocol. Coming Typhoon releases will first introduce using Terraform v0.12 and transition to recommending Terraform v0.12.

[x] terraform-provider-ct v0.3.2
[x] terraform-provider-matchbox v0.3.0
[x] terraform-render-bootkube upgrade
[x] Port DigitalOcean
[x] Port AWS
[x] Port GCP
[x] Port Azure
[x] Port bare-metal
[x] Migration guide

Migration work will take place on a branch terraform-v0.12 and later merge to master. Note, do not rely on sha's not chaning prior to merge.
Compatibility

~Backwards compatibility with Terraform v0.11.x will be maintained for some time beyond that transition as well.~

The Terraform v0.12 list language change precludes having a release that supports both Terraform v0.12 and Terraform v0.11 at the same time. List references in v0.11 required redundant list brackets to assist the language interpreter. In v0.12, such list brackets produce lists of lists. No construct supports example = ["${var.any_list}"] or concatenation cases dns_names = ["${var.api_servers}","kubernetes"] in a way that works with both Terraform v0.11 and Terraform v0.12 at the same time.
Scope
Focus will be on making the migration as simple as it can be given the significance of the change. Adopting every new v0.12 feature and capability is not a goal. That can wait until the time is right.
Notes

Please follow this issue to track Terraform v0.12.x support. The changelog will be updated when support is available. Filing individual issues is not neccessary.
Typhoon docs describe the version of Terraform, Terraform provider plugins, and Typhoon to use together. Currently, you should be using Terraform v0.11.14

This should be mostly ready, and now just down to timing the best time to shift over.


Triggering onChange event on the target input

Need your help to figure out how to get called $('target.input').onChange when editor stops, saves, etc... Couldn't find this feature / option in the manual. Thanks!
PS: Also, could I count on having onChange event just without stop the editor? The default HTML form behavior when you change an element is ok for me.

Hi @way5 - Sorry I'm not entirely sure what you're after from your description above, if you'd like to execute code when the editor starts/stops maybe this example can help:
const editor = ContentTools.EditorApp.get()

editor.addEventListener('start', (ev) => {
    // ... do something
 })

editor.addEventListener('stop', (ev) => {
    // ... do something
})

HI @anthonyjb! Just as an example:
var editor = ContentTools.EditorApp.get(); editor.editor.addEventListener('saved', function(ev) {    ev.detail().regions.regionName.trigger('change'); });
It would be perfect to somehow figure out this functionality via code...


Option to change color to black for text and icons

Hey guys, I feel that we need an option in the settings to change the friends activity text to black and the icons also to black because sometimes the white does not follow well with certain colors and it can be frustrating at times.
FYI: This used to exist before 3.1.0 as a small workaround by doing spicetify config color_scheme but it was recently removed from the updates.

Please share an exemple showing the problematic font color.

Before 3.1.0 there was a way in changing this to black unofficially but since 3.1.0 there is no way to change the color to black so what I suggest is that we need setting that can let the user change it to black

A black font in your screenshot would result in unreadable text.

About this, more than a configuration option it would be cool if the forecolor adapted depending on the color of the background, because there are some cases where text becomes unreadable there
Examples:
Song: https://open.spotify.com/track/2sf18cEv463VgqmdjDsFpw?si=0199dfec431846f5

Song: https://open.spotify.com/track/0Wjl0wDy3oSn3c4RxF0HpZ?si=110c959358f04b07

Most of the time white font color is ok (the issues arise with colors similar to yellow)
but if performance allows it I think having it dyanmic could also increase the range of types of colors you can use from covers.

Yeah I want to change the way colors are grabbed / used completely. But right now that's not my main focus since that would require a lot of work, and I'm not even completely sure how to go about doing this.

Should work out of the box in 4.0.0


fix for the wrong jax version installed

I still get the error with your version. @Marcelovk

@Marcelovk this version should be using GPU and CuDNN right? Or is there something else I need to add to make it use GPU? My GPU doesn't appear to be being used.

As far as I understood yes, but you need to have your nvidia drivers running in order and have the nvidia docker container toolkit, as stated in https://github.com/saharmor/dalle-playground/blob/main/README.md?plain=1#L43
Check the result of the command docker-compose run dalle-backend nvidia-smi to see if your driver is being loaded correctly

docker-compose run dalle-backend nvidia-smi

Looks like it is, I would've thought this would be faster on GPU :P Thanks again for the help.

I have no idea how fast it should be: Here in my Ryzen 7 notebook with a RTX2060 and 16GB of RAM I get one image every 6 seconds on average

How would one go about having fix #79 included? I tried reinstalling the docker, libraries, and MEGA as per the instructions in the Dall-e windows installation guide, but was still running into the issue.

How would one go about having fix #79 included? I tried reinstalling/building the docker, libraries, and MEGA as per the instructions in the Dall-e windows installation guide, but was still running into the issue.

If you can't switch the branch manually using git, you can try making the exact changes on the files and lines that the commit in this PR makes.

I was actually trying to install DALL-E-MEGA on my Windows 11 x64 WSL 2 Ubuntu 22.04 LTS installation and I had run into a bug like this one. Is this that bug?


Aggregate-friendly tables with sign=-1 column

ReplacingMergeTree in its classical usage is not the best instrument for storing binlog events.  We can't attach Materialized View to RMT to produce a table with aggregated data due to UPDATES and deletes in source MySQL table.  It needs first to subtract the old value from the sum aggregate and only then add a new value.
CollapsingMergeTree (and VersionedCollapsingMergeTree) was invented in Clickhouse to solve exactly that scenario.
For the UPDATE event, MySQL binlog contains both old and new values, so it's quite easy to insert both rows to the Clickhouse table with sign = -1 and 1.
For the DELETE event we also have old values and can insert them with sign = -1. In such case, CollapsingMergeTree will delete both rows (sing = 1 and -1) with the same id during SELECT ... FINAL processing.
ReplacingMergeTree also can have a sign column with 1/-1 values and work the same way removing all rows except the last one.  But the sign column allows correct aggregation by Materialized View.
See Robert's slides about RMT with sign - https://www.youtube.com/watch?v=G9MxRpKlbnI&t=547s
Requires exactly-once semantic delivery - https://github.com/Altinity/clickhouse-sink-connector/issues/359
Example:
create table VCMT (
     id                   UInt64,
     value             UInt64,
     updated_at   DateTime materialized now(),
     _version        UInt64,
     _sign              Int8
) ENGINE = VersionedCollapsingMergeTree(_sign, _version)
ORDER BY id;

create table SMT (
   day    Date,
   id       UInt64,
   value UInt64
) engine = SummingMergeTree
order by (day,id);

create materialized view __SMT to SMT as
select day, id, sum(_sign*value) as value
from VCMT;

See details about VCMT - https://clickhouse.com/docs/en/engines/table-engines/mergetree-family/versionedcollapsingmergetree#table_engines_versionedcollapsingmergetree

@BorisTyshkevich RMT should be the default and we plan to enable overrides for the engine.

CollapsingMergeTree (and VersionedCollapsingMergeTree) was invented in Clickhouse to solve exactly that scenario.

we can not use those because we need to return the same version and the version is always increasing.
If you want to use projections and MVs, you can use a regular MergeTree (or even ReplicatingMergeTree), we should support it. https://github.com/Altinity/clickhouse-sink-connector/issues/330
cc @hodgesrm

we can not use those because we need to return the same version and the version is always increasing.

There are no version in binlog, only position.
We need a MySQL table with DateTime64 column _updated_at  that can be used as _version for VCMT  (it will be received as a normal column in UPDATE and DELETE events).
(added to the description above)

If you want to use projections and MVs, you can use a regular MergeTree

I need a Null Engine for that, as for regular MergeTree I have to regularly delete all that data from the disk and waste server resources.  A separate issue was created for that - see https://github.com/Altinity/clickhouse-sink-connector/issues/360
As Sync Connector ingests data in a single thread we could use the deduplication-in-insert like technique to make a workaround that will work even without exactly-once and addition updated_at column in source table:
create table X ( id UInt64, data String, _sign Int8) engine = Null;
create table Y ( id UInt64, data String, _sign Int8, _version DateTime) engine =  VersionedCollapsingMergeTree(_sign, _version);

create materialized view _Y to Y as
with new as (select *, now() as _version from X),
     old AS (
        SELECT * EXCEPT _sign, arrayJoin([-1, 1]) AS sign
        FROM Y FINAL
        PREWHERE id IN ( SELECT id FROM X )
     )
select id,
     if(sign = -1, old.data, new.data) AS data,
     if(sign = -1, old._version, new._version) AS _version,
     if(sign = -1, -1, 1) AS _sign
from new left join old using id;

That will work fine on not-so-big ingest volumes. But for binlog processing, it's mostly OK.


Registered scopes should not be defaulted for client_credentials grant

If scope is not requested by the client for the client_credentials grant flow, the client's registered scope(s) are used as the defaults for the authorized access token. This behaviour needs to be changed to only include the requested scope(s) only. Furthermore, if no scopes are requested then the access token should still be granted but will exclude the scope claim.
Defaulting scope(s) is the responsibility of the consuming application.
Related gh-600, gh-737, gh-738

If a client does not request scopes the default consent page displays a confirmation page that allows you to submit consent to no scopes. After consent is provided OAuth2AuthorizationcodeRequestAuthenticationProvider fails because there were no scopes. Ideally, if no scopes requested by the client should cause it to fail the failure should happen as soon as no scopes were provided rather than after consenting.

Hi all
i'm in the process of evaluating the new authorization server project to replace our internal oauth2 which was based on the deprecated spring-security-oauth2. one of the issues i encounter is that, the default behaviour as is documented in DefaultOAuth2RequestFactory is not possible anymore
if ((scopes == null || scopes.isEmpty())) {
  // If no scopes are specified in the incoming data, use the default values registered with the client
  // (the spec allows us to choose between this option and rejecting the request completely, so we'll take the
  // least obnoxious choice as a default).
      scopes clientDetails.getScope();
}

in short if no specific scope set was requested, the set was "defaulted" to the configured set  of the client.
note that none of our resource owners use consent because the data is not linked to user like phone/email but to
tenants , so user consent is not used in our case and defaults to always allow all.
with the new project, using version 0.3.1, i see when requesting access tokens, without specifying scopes, a empty scope list is returned which breaks scope validation later on when using the tokens.
reading https://datatracker.ietf.org/doc/html/draft-ietf-oauth-v2-1-05, section <IP_ADDRESS>,
i read it's up to the authorization server to determane the resulting scopes , defaulting to preset or error this.
so the "old" behaviour seems still valid in this case.  this both for authorization_code and client_credentials grants.

@rwinch I believe that the behavior that you are describing is exactly what this issue is meant to resolve.  Once this issue is completed, a request with no scope parameter will be valid and will result in a token/token response with no scope.

@lucwillems Since Spring is defaulting to "no scope" when the client requests "no scope" couldn't you do what you are proposing using a custom AuthenticationConverter?

i've been looking at that, but as far i can see now, it means customising all AuthenticationConverter  and copy 90% of original code,  and for TokenEndPointFilter we have A DelegatedConverter including 3 other converters . so there is also work needed.
doesn't seem optimal to me. also see the related gh-600 and my comments there.

@lucwillems I'm not sure what you need to customize for your use cases, but if you only want to customize the scope then it shouldn't be as involved as that. There's definitely no need to copy the default converter code.  You can follow the advice in https://github.com/spring-projects/spring-authorization-server/issues/600 and delegate most of the work to the default converter.  Then, you only need to add your own code to customize the scope on the resulting authentication object.
Just threw this together as an example:
`
public class CustomAuthorizationCodeRequestConverter implements AuthenticationConverter {
private final OAuth2AuthorizationCodeRequestAuthenticationConverter authenticationConverter = new OAuth2AuthorizationCodeRequestAuthenticationConverter();
private final RegisteredClientRepository clientRepository;
public CustomAuthorizationCodeRequestConverter(final RegisteredClientRepository clientRepository) {
    this.clientRepository = clientRepository;
}

@Override
public Authentication convert(final HttpServletRequest request) {
    if (POST.matches(request.getMethod())) {
        return authenticationConverter.convert(request);
    }

    return convertAuthorizationRequest(request);
}

private Authentication convertAuthorizationRequest(final HttpServletRequest request) {
    final OAuth2AuthorizationCodeRequestAuthenticationToken authenticationToken = (OAuth2AuthorizationCodeRequestAuthenticationToken) authenticationConverter.convert(request);

    if (isEmpty(authenticationToken.getScopes())) {
        final String clientId = authenticationToken.getClientId();

        return OAuth2AuthorizationCodeRequestAuthenticationToken.with(clientId, (Authentication) authenticationToken.getPrincipal())
                .authorizationUri(authenticationToken.getAuthorizationUri())
                .redirectUri(authenticationToken.getRedirectUri())
                .scopes(clientRepository.findByClientId(clientId).getScopes())
                .state(authenticationToken.getState())
                .additionalParameters(authenticationToken.getAdditionalParameters())
                .consent(authenticationToken.isConsent())
                .build();
    }

    return authenticationToken;
}

}
`
That would be used for the authorize endpoint.  For the token endpoint, if we're still just talking about scope, I think that you only need to customize the OAuth2ClientCredentialsAuthenticationConverter in a similar manner. Then, you'd just use your own DelegatingAuthenticationConverter instance containing your customer client credentials converter along with the standard OAuth2RefreshTokenAuthenticationConverter and OAuth2AuthorizationCodeAuthenticationConverter converters.
Sorry, if I'm missing some of what you're trying to do, but hopefully this helps to simplify your implementation a bit.

@rwinch Regarding your comment:

If a client does not request scopes the default consent page displays a confirmation page that allows you to submit consent to no scopes...

The use case where the client does not request scope but is configured for authorization consent is invalid. It doesn't make sense to require authorization consent for the client when it doesn't request any scopes for the resource owner to consent to. This use case happens when the RegisteredClient is configured with ClientSettings.requireAuthorizationConsent(true). If you update the configuration to ClientSettings.requireAuthorizationConsent(false) and request without scope then the access token will be generated without any scope claim associated to it.
Furthermore, the default consent page is designed to work with scope-based authorization only. This is why the access_denied error occurs because no scope is available to authorize so when the authorization consent is processed the assumption is that an empty authority (scope) list means the authorization request is not authorized (approved).
Also, the default consent page is meant to be used for development only. In a production application a custom consent page would be configured and has the flexibility to handle any type of authorization consent without being limited to scope-based authorization consent only. For example, the consent page may display claims, permissions, roles, etc. The following test demonstrates the custom configuration for this use case.
https://github.com/spring-projects/spring-authorization-server/blob/2b47a1695659b9df7e050a1aa8e3cbd3936c8e72/oauth2-authorization-server/src/test/java/org/springframework/security/oauth2/server/authorization/config/annotation/web/configurers/OAuth2AuthorizationCodeGrantTests.java#L564

@lucwillems I'm not sure what you need to customize for your use cases, but if you only want to customize the scope then it shouldn't be as involved as that. There's definitely no need to copy the default converter code. You can follow the advice in #600 and delegate most of the work to the default converter. Then, you only need to add your own code to customize the scope on the resulting authentication object.
Just threw this together as an example:
public class CustomAuthorizationCodeRequestConverter implements AuthenticationConverter {
    private final OAuth2AuthorizationCodeRequestAuthenticationConverter authenticationConverter = new OAuth2AuthorizationCodeRequestAuthenticationConverter();
    private final RegisteredClientRepository clientRepository;

    public CustomAuthorizationCodeRequestConverter(final RegisteredClientRepository clientRepository) {
        this.clientRepository = clientRepository;
    }

    @Override
    public Authentication convert(final HttpServletRequest request) {
        if (POST.matches(request.getMethod())) {
            return authenticationConverter.convert(request);
        }

        return convertAuthorizationRequest(request);
    }

    private Authentication convertAuthorizationRequest(final HttpServletRequest request) {
        final OAuth2AuthorizationCodeRequestAuthenticationToken authenticationToken = (OAuth2AuthorizationCodeRequestAuthenticationToken) authenticationConverter.convert(request);

        if (isEmpty(authenticationToken.getScopes())) {
            final String clientId = authenticationToken.getClientId();

            return OAuth2AuthorizationCodeRequestAuthenticationToken.with(clientId, (Authentication) authenticationToken.getPrincipal())
                    .authorizationUri(authenticationToken.getAuthorizationUri())
                    .redirectUri(authenticationToken.getRedirectUri())
                    .scopes(clientRepository.findByClientId(clientId).getScopes())
                    .state(authenticationToken.getState())
                    .additionalParameters(authenticationToken.getAdditionalParameters())
                    .consent(authenticationToken.isConsent())
                    .build();
        }

        return authenticationToken;
    }
}

That would be used for the authorize endpoint. For the token endpoint, if we're still just talking about scope, I think that you only need to customize the OAuth2ClientCredentialsAuthenticationConverter in a similar manner. Then, you'd just use your own DelegatingAuthenticationConverter instance containing your customer client credentials converter along with the standard OAuth2RefreshTokenAuthenticationConverter and OAuth2AuthorizationCodeAuthenticationConverter converters.
Sorry, if I'm missing some of what you're trying to do, but hopefully this helps to simplify your implementation a bit.

Hi,@lucwillems,I faced with same issue and tried this for my token endpoint case(OAuth2ClientCredentialsAuthenticationConverter), but I have any idea how to use DelegatingAuthenticationConverter in my AuthorizationServerConfiguration. In which place can I use it in my SecurityFilterChain authorizationServerSecurityFilterChain(HttpSecurity http). Do you have a code example?

The use case where the client does not request scope but is configured for authorization consent is invalid.

We about to migrate to the this new auth-server, and we have many service registered, who need to make the change define the scope when requesting service token (client_credential grant type). Is it possible to override this default behavior in case of service token?


[language, easy] Fix a leftover comment

Drive-by fixup of #4877 while working on something else.

@bors-libra r=tzakian

:pushpin: Commit b617771 has been approved by tzakian

:hourglass: Testing commit b617771f16fd0cb1d6bc5a25cefc85af8edbbc13 with merge 04367397e9fee02ce58e450635c061a0a9e6fce8...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: tzakian
Pushing 04367397e9fee02ce58e450635c061a0a9e6fce8 to master...


Combine with natural key

Adding a couple of failing specs for some scenarios I'm hitting in the wild.
The first set is a reproduction of a bug that I'm actively seeing.  The second is chasing after syntax for a join; I can remove that commit from this if necessary to keep things focused.

As these are repro bugs, the failing specs are expected; it's just easiest to get commentary using a PR

I should mention that with assocs configured with custom combine keys and overridden views, you can just do users.combine(:drafts).


[BOT PR] to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
7225e8f3ec4e80282ef7b6c67457bef7a8112b75
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Image download optimisation

Dear LXD developers,
how hard do you think it would be to implement some kind of differential scheme for official images (i.e. layers, similar to Docker) when using ZFS as a storage backend? I'm using LXD v2.7 on Ubuntu 16.10 ...
I was really surprised to discover that when the auto-update option is turned on, LXD just moved now "old" images to /deleted dataset (because I still have running containers from these now "old" datasets) and then LXD just downloaded the new, full images, instead of differences only from the previous images :-(
The situation is, for currently 8 distributions I have pulled locally and these are used frequently to create many new containers often (Alpine, Arch, Centos, Debian, Fedora, Gentoo, Opensuse and Ubuntu), it can eat up to 4+GB everytime the auto-update process happens.
Now you can possibly imagine that the ZFS pool will relatively quickly run out of disk space - old images just won't be deleted because there are still running containers based on them.
I really hoped that LXD would take full advantages of the ZFS snapshots / clones functionalities, like Docker does.
Also, I'd be interested in implementing this if you can guide me a little bit where to start (I've already done some private fixes for the LXD to get it running on other distributions than Ubuntu, but just haven't had the time to contribute yet...)
Thanks.

Have you been able to get lxd running on debian?

ZFS is only one of the supported backends and the only one with the annoying limitation that old images must be kept around so long as they have downstream references.
We may consider using a standard binary delta mechanism to reduce the network usage when using the daily generated images in the future, but it's something we'd need to carefully think through on the server side as we don't want to raise disk size too much on the server end as that may impact mirroring and caching negatively.
Layering on top of a previous ZFS image as opposed to keeping everything as separate filesystems may be worth considering at some point, at least as an option. This however does come with the obvious cost that you will never be able to remove the base image, which for rolling distributions would likely mean more disk usage than the current scheme.
This would also need much more careful tracking of images on LXD's part than is done today. The storage rework currently in progress would make such tracking easier but will also add complexity as images will have to be present in a variety of different pools based on container usage, so the layering would have to be done on a per-pool basis and needed snapshots sent through send/receive as needed.

So we're moving forward on this one with xdelta3 diffs of images. This will allow the daily images to refresh with a very minimal download. The rest of the LXD behavior remains unchanged, so this is purely a download time and bandwidth optimization.
https://images.linuxcontainers.org is busy building deltas now. Over the next 3 days we should have all images available as squashfs and with binary deltas for those squashfs available.
The main difficulty on the server side is the design of the stream metadata to expose those diffs. Once we figure out something which works for us and doesn't break older LXD, we'll expose the metadata and start working on LXD support for it, which should be reasonably straightforward.

simplestreams support was added for this now, so we can work on the client side.

Is it possible that this same process of only transferring image diffs could be incorporated into LXD when transferring containers/images to an LXD remote? (e.g. between a development and production environment with limited bandwidth).

This should have been closed by #3675. @stgraber, if there is still something outstanding please re-open.


Observables support

Similar to:

https://github.com/LeetCode-OpenSource/rxjs-hooks
https://github.com/crimx/observable-hooks

This would be especially useful with libraries like rxfire
This ties into web socket (or similar), server subscriptions.
If you're not convinced consider the popularity of rxjs.

How would you use SWR with Observables? Do you want support in the fetcher or as a way to get the data?

I've been thinking about this too. (but I don't have a clear way in mind to do that). 🤔
const { data } = useSWRSubscription('key', (onData, onError) => {
  const starCountRef = firebase.database().ref('posts/1/starCount')
  starCountRef.on('value', function(snapshot) {
    onData(snapshot.val())
  })
  return () => starCountRef.off()
}

But there're a lot of challenges, and it doesn't seem to have any benefits from useSWR.

Maybe an API like that should be used together with useSWR, as a way to mutate the cache and not to get the data directly, this way you can subscribe to WebSockets or GraphQL subscriptions there and get new values, but you still get the normal SWR features like in focus revalidation.


Add Nicolas Quiceno to Spanish approver team

Given his active collaboration in Spanish localization team, this PR recognizes the effort made by @@92nqb and promotes him to the approver role.
/cc @raelga @krol3

Hold until
https://github.com/cncf/glossary/pull/1191#issuecomment-1210428062
is resolved :)

After reviewing this during the weekly meeting, @92nqb will join to the approver team instead of @ramrodo.

@seokho-son https://github.com/cncf/glossary/pull/1191#issuecomment-1210428062 has been closed after reviewing the situation during the latest weekly meeting.

Thanks @raelga  :)
Hi @92nqb
Thank you for applying for a localization approver :)
PTAL Policies for localization approvers (to be confirmed by candidates)
and please leave a comment here to confirm you read the policy and understand it.

Thanks @raelga :)
Hi @92nqb Thank you for applying for a localization approver :)
PTAL Policies for localization approvers (to be confirmed by candidates)
and please leave a comment here to confirm you read the policy and understand it.

@seokho-son, I confirm that I have read and understand the policies for localization approvers.

Thanks @92nqb !
/lgtm

Let me invite an additional approval from maintainers.


[SSD] Update logging to v0.7

This PR is based on https://github.com/mlperf/training/pull/367 but fixes syntax errors and adds missing keys

@gsrujana89 , As this work builds on top of #367, can you sign the CLA to unblock the PR.
Thank you

Hi @christ1ne , could you please have @gsrujana89 sign the CLA so we can get this PR merged?

ok

@googlebot I consent

@googlebot I consent

@googlebot I consent.

@googlebot I consent.

@googlebot I fixed it.

To resolve this CLA issue, I suggest @ahmadki open a new PR with the same code change, and close this one. Much faster that way.


crash when run as plugin

When I run this via Option 1: Run as c-lightning plugin all looks fine at first in the .lightning/debug.log:
plugin-plugin.js --- Starting the cl-rest server ---
INFO plugin-plugin.js Changing the working directory to :/opt/src/c-lightning-REST
INFO plugin-plugin.js Reading SSL cert and key
INFO plugin-plugin.js Reading rootkey for macaroon
INFO plugin-plugin.js macaroon converted to base64:
INFO plugin-plugin.js <REDACTED>Q=
INFO plugin-plugin.js --- cl-rest api server is ready and listening on port: 3001 ---

However the the api server is not running and I'll see:
$ ps aux | grep node
lightning  1393  0.0  0.0      0     0 ?        Z    10:31   0:00 [node] <defunct>

Which means it crashed for some reason. But there's no more info in the .lightning/debug.log. Is there any way to debug c-lightning plugins? Or is there a way I can write the whole STDOUT to a file when it is run as plugin?
If I run the api-server standalone it works and there's no crash.

Hi @wanxewoj
Did your npm install ran without any issue?

Hi @wanxewoj
Did your npm install ran without any issue?

Yes. No issues.
And as I wrote, Option 2: Run as an API server runs without issues. Only when run as a plugin it crashes. I'm using c-lightinging master branch.

I'm using c-lightinging master branch.

FWIW the master had a bug with dynamic plugin until lately.
@wanxewoj I updated clightningjs, can you try with the latest release ? If you experience a crash again could you give me c-lightning logs ?

@darosior thanks for looking into this. I meant to tag you here. :-)

@wanxewoj please pull the latest cl-rest version (0.0.4) and run it along with c-lightning v0.7.3
You issue should be addressed.


Power Toys stops working after a while or after computer go to sleep

I'm only using Power Toys for the Fancy Zone feature. I use my laptop on an external monitor. The problem is that everytime my computer goes to sleep Power Toys stops working completely, I can't even launch it, it still on the background but not working. Even if I try to end the power toys runner with crtl alt delete the app won't launch again until I restart my computer.
Please help

ℹ Computer information

PowerToys version: v0.33.1
PowerToy Utility:
Running PowerToys as Admin: yes
Windows build number: [run "winver"] Version 1909 (OS Build 18363.1440)

📝 Provide detailed reproduction steps (if any)

…
…
…

✔ Expected result
What is the expected result of the above steps?
❌ Actual result
What is the actual result of the above steps?
📷 Screenshots
Are there any useful screenshots? WinKey+Shift+S and then just paste them directly into the form

I'm only using Power Toys for the Fancy Zone feature. I use my laptop on an external monitor. The problem is that everytime my computer goes to sleep Power Toys stops working completely, I can't even launch it, it still on the background but not working. Even if I try to end the power toys runner with crtl alt delete the app won't launch again until I restart my computer.
Please help

@brenomirisola
how is the external monitor connected? HDMI, DisplayPort, USB-C?

@brenomirisola
how is the external monitor connected? HDMI, DisplayPort, USB-C?

It is connected through HDMI

I'm facing the same issue over here. I have two monitors connected through HDMI.

@brenomirisola @rbakerbotelho
when it happens can you check the Task Manager to verify the CPU usage of the PowerToys.exe process?
Does the problem happen all the times you put the computer to sleep?
Adding a reference to the tracker for this problem https://github.com/microsoft/PowerToys/issues/9853

It doesn't happen every time it goes to sleep. Just tested putting it to sleep and PowerToys kept working. One thing I've noticed is that when it happens, Powertoys on System Tray does not respond, no right-click menu. And even if I kill it through task manager and reopen it, it doesn't work anymore. I have to reboot.

@brenomirisola @rbakerbotelho
when it happens can you check the Task Manager to verify the CPU usage of the PowerToys.exe process?
Does the problem happen all the times you put the computer to sleep?
Adding a reference to the tracker for this problem #9853

If I put it to sleep and wake it up in less than 2 minutes it doen't happen but if I'm away for at least 20 minutes it stops working 100% of the times.
Right now is not working and I checked the cpu usage on task manager on the Power Toys Runner and it is 0% most of the time, sometimes goes to 0,2 or 0,1% for one second

Just one thing to add, It is not when go to sleep but actually after sometime of use!! After 30 minutes without selecting the Fancy Zone it also stopped working and this time I didn't leave the computer for one moment!!!

@brenomirisola @rbakerbotelho
when it happens can you check the Task Manager to verify the CPU usage of the PowerToys.exe process?
Does the problem happen all the times you put the computer to sleep?
Adding a reference to the tracker for this problem #9853

CPU usage is between 0% and 0.3%. It happened now after a long sleep (~7h).

Tkanhs

Today I used it without an external monitor and it worked all day long so the problem is definetly when I have my external monitor connected

For me, the problem (sluggishness) happen only on boot and it lasts like couple minutes -- and it will settle and normal / or I can force close powertoys and start again and it will normal.
Settings panel a bit unresponsive and for that window time of slowness after boot, keyup also slow (typed much word but registered one by one characters). Yes I use remap shortcut.

I'm using a single screen, and I'm also seeing the problem when I resume from hibernation or standby.
The stack for the thread that is blocking the CPU is the same as what has been posted before on other tickets about this issue.

@brenomirisola
Does the issue still happen? If yes, can you install a private build to help us troubleshoot the issue?

Should be fixed by #12240 .
@brenomirisola let us know if this issue still happens when next release comes out.
Thanks

Issue perists :/


Map fails to render correctly if created on an element that isn't yet part of the document tree

Hi,
I noticed a behaviour in Leaflet that I consider a bug. Consider the following code: it creates a div element, inserts it into the document tree and then renders a map into it.
      var div = document.createElement("div")
      div.setAttribute("id", "myMap") // my stylesheet contains the formatting for this ID
      document.body.appendChild(div)
      var map = L.map(div).setView([51.505, -0.09], 13)
      L.tileLayer("http://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png").addTo(map)

This works fine. But if I create the map first and then insert it into the document tree like so
      var div = document.createElement("div")
      div.setAttribute("id", "myMap") // my stylesheet contains the formatting for this ID
      var map = L.map(div).setView([51.505, -0.09], 13)
      L.tileLayer("http://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png").addTo(map)
     document.body.appendChild(div)

then I get completely broken rendering. The map is mostly grey except for a very narrow stripe of map material on the left edge of the div. Panning leads to map fragments being rendered here and there, but there's never a complete map to be seen. When I resize the browser window, it fixes itself and works flawlessly from then on.
So why am I even trying to do that? Because I'm using a library that helps with DOM manipulation. This library expects me to create and initialize elements, but will take care of inserting them into the document tree itself, hence I can't control the order.

Hi Matthias!
Before map container is added to DOM, it's size is 0 x 0 px. Use map.invalateSize() after adding container to DOM in order to recalculate container size.
P.S. In the future, please ask questions on Stack Overflow or gis.stackexchange.com. Github issues are used for reporting bugs.
If you really sure it's Leaflet issue, please fill up issue template and provide link to minimal example reproducing the issue.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_a08e9f64-b1f6-4778-9209-0961f740105c/pull/1 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-target_a08e9f64-b1f6-4778-9209-0961f740105c.git

Docs Build status updates of commit 7d40c78:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-ServiceAccountCannotAccessRepository] Your repository https://github.com/VSC-Service-Account/docs-archive-test-source has enabled Docs Build service account. It seems that at least one of the accounts, e2ebd2, does not have Read permission to the repo. Please ask your repo admin to grant correct permission to service accounts (refer to this document: https://review.docs.microsoft.com/en-us/engineering/projects/ops/engdocs/how-to-grant-service-account-permission-in-your-repository?branch=master#ops-e2e-ppe) and then retry the build. Don't know who to contact? Refer https://repos.opensource.microsoft.com/VSC-Service-Account/repos/docs-archive-test-source/permissions/ to get admin list of the repo if the repo is in one of the organizations Microsoft owns.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


The plugin cloud_firestore could not be built due to the issue above.

Hi,
I was building a flutter app with firebase using a AVD. The app is almost done, running without any error, but when i try to build a release version i got this error:
The plugin cloud_firestore could not be built due to the issue above.
Here is the build apk --verbose: https://pastebin.com/rSEHS8iz
That is my build gradle(/android/l):
https://pastebin.com/jtaNF1cC
That is my build gradle(/android/app/):
https://pastebin.com/tV1crnzQ
And that is my pubspec.yaml:
https://pastebin.com/bpNrxTbj

I am facing the same problem. Can someone help?

Hello everyone,
I've solved my problem.
One of my dependences in .flutter.pub-cache\hosted\pub.dartlang.org\ was using CompileSdkVersion 27 in build.gradle.
I just changed it to 28 and everything works just fine.

Same problem but it is already set to 28...
build.gradle
android {
compileSdkVersion 28
...
}

fixed


Bitmap resolution and animation smoothness

Hi!
When I've been writing my scripts , at first I decided to use drawing on bitmap as easier way to deal width gradient and moving objects. But I've ended manually controlling color of each button cause of smoothness.
Resolution of bitmap causes animations and transitions to be noticeably stepped.
While manually setting color we have about 255 shades, using bitmap drawing we get only about 5 shades.
I wonder if increasing resolution will significantly hit performance?
Maybe provide user choice between performance hit and smoothness?
Right now it's better to avoid using drawing on bitmap if we want to get fist-class quality animation and transitions.

The time it takes to render 1 frame (as in after all layers have been sent to the engine) is very small at 0-1 ms and about 900-1500 ticks.
When I increase the bitmap of keys by 2, the results are similar.
When x2: 0-1 ms, 1000-4000 ticks.
When x4: 2-6 ms, 8000-11000 ticks.
When x8: 9-15 ms, 29000-36000 ticks. (Animations begin to stutter)
When x16: 95-400 ms,<PHONE_NUMBER>000 ticks. (Animations stutter all over, performance isn't optimal at all)
I didn't want to go higher than the defined bitmaps because an average person won't notice the difference. Perhaps instead of increasing the bitmap size, we could include some smoothing via overlaying the previous frame at half opacity? It would give the color changing animations a bit more steps at the cost of adding one more layer. Which is very insignificant.

Nice idea but as drawback it can make smooth things that shouldn't be smooth.
Anyway it's more like thing to consider when writing animations than a real problem. Just a better approach.
I am sure most of the animations could be manually calculated, it just take's a little more mind work.
After I re implemented mine's it even resulted in smaller code.

You could manually save the previous layer that you want smooth animation on, set it to half opacity, and render it next time.
It wouldn't hurt other layers, will only affect layers that you implement this on.

Oh, you were talking about manually adding smoothness by overlaying. Now I got it.
But the thing that caused me to open this discussion is rain fall away animation, it's great but it's really stutters a lot, painfully to see. It's not my animation but ok, I will see if I can re implement it.

In commit above I've made what I could.
Also I am thinking about making some kind of SmoothGraphics class which can be used as regular Graphics but will instead draw by keys. This will allow easily remake any existing drawing animating to be smooth and lightweight. I will do this if there would be free time.

I've just discovered that there is already a lot of useful functions for effects. Sadly I've known all them before, cause I've spent way too much time on implementing many things manually. I could made what I wanted much easier TT_TT. But that is my fault.
Still there are a lot of  missing functions? it will be great to extend it someday in future.

I've just discovered that there is already a lot of useful functions for effects. Sadly I've known all them before, cause I've spent way too much time on implementing many things manually. I could made what I wanted much easier TT_TT. But that is my fault.
Still there are a lot of  missing functions? it will be great to extend it someday in future.

What I can do is, for each layer add an option to "smooth" the layer. This will tie into scripts, as they will have a script layer.
This will allow user to select whether or not they want this smooth effect, as well as developers don't have to implement it.


Feature Request : Make FLAML installable with Conda

Basically the title.
Gherkin style :

AS A ML developer
WHEN  I run conda install flaml (or conda -c conda-forge install flaml)
THEN it installs FLAML in my current Conda environment

AND I can execute the following code :

from flaml import AutoML
from sklearn.datasets import load_iris
# Initialize an AutoML instance
automl = AutoML()
# Specify automl goal and constraint
automl_settings = {
    "time_budget": 10,  # in seconds
    "metric": 'accuracy',
    "task": 'classification',
    "log_file_name": "test/iris.log",
}
X_train, y_train = load_iris(return_X_y=True)
# Train with labeled input data
automl.fit(X_train=X_train, y_train=y_train,
           **automl_settings)
# Predict
print(automl.predict_proba(X_train))
# Export the best model
print(automl.model)

Can someone help with this issue? Right now catboost is the only required package unavailable from conda. I can make flaml work when catboost is not installed. Can someone help with uploading the package to conda after that?

@MichalChromcak and @qingyun-wu v0.6.6 is published to PyPI with the CD github actions. Thanks @MichalChromcak again for recommending it.
Request for @MichalChromcak could you try the conda package build again?
Request for @qingyun-wu could you make the PR in the automlbenchmark?

@MichalChromcak please wait for v0.6.7 as I am adding pandas into install_requires in #244

@MichalChromcak v0.6.7 is released.

@MichalChromcak To confirm, if the package version in install_requires changes, we need to update in the conda recipe before we publish the pypi package, right? Otherwise the automerge will publish a conda package with wrong dependencies and I suppose there is no way to revert it.

@sonichi One can make a manual second build with updated recipe. It might take some time (to 1 hour?) until conda install would prefer the new build for the same version…(see the two builds on the anaconda.org as an example)

@MichalChromcak FYI https://github.com/microsoft/FLAML/issues/223#issuecomment-948863047. There seems to be a conda package of catboost, though I've no idea how to leverage it.

@sonichi sorry, wasn't around for a while.
The catboost - if I remember it well the problem was with other libraries, that would need to be added - like graphviz. For some reason, it seems, that the conda install <package_name> work as expected, but following pip check command is sometimes missing already existing installation. The pip check is no longer there, so maybe it would work now.
I will update the sklearn version and try again if the latest release is as expected.

@sonichi there already is sklearn >=0.24 in the recipe. The following now is the minimal configuration of the conda environment if created as is. Any update needed?
conda create -n flaml
conda install -c conda-forge flaml

conda list

# packages in environment at /home/michal/miniconda3/envs/flaml:
#
# Name                    Version                   Build  Channel
_libgcc_mutex             0.1                 conda_forge    conda-forge
_openmp_mutex             4.5                       1_gnu    conda-forge
_py-xgboost-mutex         2.0                       cpu_0    conda-forge
ca-certificates           2021.10.8            ha878542_0    conda-forge
flaml                     0.7.0              pyhd8ed1ab_0    conda-forge
joblib                    1.1.0              pyhd8ed1ab_0    conda-forge
ld_impl_linux-64          2.36.1               hea4e1c9_2    conda-forge
libblas                   3.9.0           12_linux64_openblas    conda-forge
libcblas                  3.9.0           12_linux64_openblas    conda-forge
libffi                    3.4.2                h9c3ff4c_4    conda-forge
libgcc-ng                 11.2.0              h1d223b6_11    conda-forge
libgfortran-ng            11.2.0              h69a702a_11    conda-forge
libgfortran5              11.2.0              h5c6108e_11    conda-forge
libgomp                   11.2.0              h1d223b6_11    conda-forge
liblapack                 3.9.0           12_linux64_openblas    conda-forge
libopenblas               0.3.18          pthreads_h8fe5266_0    conda-forge
libstdcxx-ng              11.2.0              he4da1e4_11    conda-forge
libxgboost                1.3.3                h2531618_0
libzlib                   1.2.11            h36c2ea0_1013    conda-forge
lightgbm                  3.2.1            py39he80948d_0    conda-forge
ncurses                   6.2                  h58526e2_4    conda-forge
numpy                     1.21.3           py39hdbf815f_1    conda-forge
openssl                   3.0.0                h7f98852_2    conda-forge
pandas                    1.3.4            py39hde0f152_0    conda-forge
pip                       21.3.1             pyhd8ed1ab_0    conda-forge
py-xgboost                1.3.3            py39h06a4308_0
python                    3.9.7           hf930737_3_cpython    conda-forge
python-dateutil           2.8.2              pyhd8ed1ab_0    conda-forge
python_abi                3.9                      2_cp39    conda-forge
pytz                      2021.3             pyhd8ed1ab_0    conda-forge
readline                  8.1                  h46c0cb4_0    conda-forge
scikit-learn              1.0.1            py39h7c5d8c9_1    conda-forge
scipy                     1.7.1            py39hee8e79c_0    conda-forge
setuptools                58.5.2           py39hf3d152e_0    conda-forge
six                       1.16.0             pyh6c4a22f_0    conda-forge
sqlite                    3.36.0               h9cd32fc_2    conda-forge
threadpoolctl             3.0.0              pyh8a188c0_0    conda-forge
tk                        8.6.11               h27826a3_1    conda-forge
tzdata                    2021e                he74cb21_0    conda-forge
wheel                     0.37.0             pyhd8ed1ab_1    conda-forge
xgboost                   1.3.3            py39h06a4308_0
xz                        5.2.5                h516909a_1    conda-forge
zlib                      1.2.11            h36c2ea0_1013    conda-forge

@MichalChromcak that looks good to me. Thanks for double checking.
@qingyun-wu @fleuryc @cdeil @angela97lin Could you test the new conda package, especially on macos? We can close this issue if it works.
@cdeil you had a good suggestion about adding conda package test into the CI. Would you like to create a PR or an issue for it?

To be realistic, no, I don't have any spare time, sorry.

@MichalChromcak @sonichi Can I help maintain the conda package? I am very happy to do this.

@sonichi such test might be added to the test section of the conda package creation if you want - replacing just import check with something more detailed. Is there already some code, which should be executed to check for correctness?
@Shao-kun-Zhang from my end - sure, happy to have more people on board.

@MichalChromcak ok, If there is anything I can help with, please tell me!

@MichalChromcak what about adding the test for the example code in the main post?
Change "test/iris.log" into "iris.log".
@Shao-kun-Zhang Thanks for helping!

@sonichi Yes I can do that :)

@sonichi, @Shao-kun-Zhang
I added the test in this PR.
There were few architectural decisions made, let me comment on them...
I decided to keep the test within the flaml-feedstock repository, as it provides more control over

the environment (no need to install all the dependencies)
test duration
test definition itself

On the other hand, this setup might cause out of sync behavior with the package development.
So if wanted, another options are to:

use existing test within flaml repository (less prefered)

this might need dependencies, that are not currently installed
we might get in more complicated and time consuming test setup here

create a new test in flaml repository, which is dedicated to the conda forge build

in this case, the test file itself might be the same as the one my PR introduces, just live in different repository
such setup might benefit from pytest markers (we could mark the file to not run by default in your CI, and explicitly run it in conda forge build test section)

As this seems nicer for the testing code locality, both above mentioned options require contributions to the flaml repository, making redeployments if the test changes and so on.
Let me know, if you prefer the current way, where the conda forge build is self contained also with the test or any of the proposed changes.

@sonichi, @Shao-kun-Zhang I added the test in this PR.

Thank you! It looks good.

There were few architectural decisions made, let me comment on them...
I decided to keep the test within the flaml-feedstock repository, as it provides more control over

the environment (no need to install all the dependencies)
test duration
test definition itself

On the other hand, this setup might cause out of sync behavior with the package development.
So if wanted, another options are to:

use existing test within flaml repository (less prefered)

this might need dependencies, that are not currently installed
we might get in more complicated and time consuming test setup here

create a new test in flaml repository, which is dedicated to the conda forge build

in this case, the test file itself might be the same as the one my PR introduces, just live in different repository
such setup might benefit from pytest markers (we could mark the file to not run by default in your CI, and explicitly run it in conda forge build test section)

I like option 2. We can put the test file you need in test/conda/.

As this seems nicer for the testing code locality, both above mentioned options require contributions to the flaml repository, making redeployments if the test changes and so on.
Let me know, if you prefer the current way, where the conda forge build is self contained also with the test or any of the proposed changes.

Ok, the last change was made and conda distribution should now contain test taken from flaml repo. pytest.ini was also not copied over during the distribution creation, but as pytest markers work also without it I just skipped copying it. Changing pytest.ini option into setup.cfg should not need any change in the flaml-feedstock repo now.
I would propose to close this now, what do you think @sonichi?

@MichalChromcak Thanks for the great effort in helping with this issue. I really appreciate it. I'm closing it now.

Thanks everyone ! :tada:


pass environment variables to vagrant process

Fixes #36.

@aconrad Would you mind taking a look at the tests directory and trying to add a new test that verifies this change?
Something like: https://github.com/todddeluca/python-vagrant/blob/master/tests/test_vagrant.py#L377-L392

@aconrad Doesn't merge cleanly anymore either

@todddeluca I've updated the CHANGES and the README. I still need to work on the tests.
I was wondering if it was useful to even introduce the env kwarg of Vagrant(env=env). Users may just assign Vagrant.env directly. Passing env as part of __init__ is just for convenience but I don't feel it's actually useful (and more code to maintain). We could add it later if there is a demand for it. What do you think?

One could consider passing env via the constructor a matter of style. I prefer to include the environment in the constructor, since doing so:

documents the "parameters" of the object, letting a user know that they can construct a Vagrant instance with a non-default environment.
offers the convenience of setting the environment while constructing the object.
maintains the illusion that a Vagrant instance is an immutable object, for the functionally inclined among us.

Of course, if someone needs a different environment for a specific method call, they can tweak the env member directly (or create a second Vagrant instance).


merge to live

[Add-ins] Add delegate access article
Updates based on feedback

OPS Build status updates of commit 2e60bda:
:clock10: Preparing: average preparing time is 41 sec(s)

OPS Build status updates of commit 2e60bda:
:clock10: Incremental building: average incremental building time is 18 sec(s)

OPS Build status updates of commit 2e60bda:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/add-ins/delegate-access.md
:white_check_mark:Succeeded

docs/add-ins/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Expose MaxUsagesPerEngine as an configuration option in React.NET

Thanks!

This is included in the 3.1 release: https://reactjs.net/2017/07/3.1.0-release.html. Thanks for your contribution!


[R-package] Export callback functions

See this comment and this comment thread from #2443 . Currently the functions in callback.R are not exported in the R package. This means that the use of callbacks keyword argument in lgb.train() is unclear.
To close this issue, submit a PR with the following features

[ ] Roxygen documentation on relevant functions in R-package/callbacks.R, including @export tag. Consider also using @family tag to auto-generate see-also links.
[ ] regenerated .Rd documentation (see this comment for how to do this). This should also regenerate R-package/NAMESPACE.
[ ] updated documentation in any other functions that expose callbacks, linking to the relevant documentation

Closing this in favor of being in #2302 . We keep all feature requests in #2302 . If you'd like to pick this issue up and submit a PR, please do and it can be re-opened.

PR #5018 has been closed. Since there's no active work going on for this feature, I'm going to close this issue.
Anyone interested in this feature is welcome to contribute it! If you'd like to contribute this, comment here and the issue can be re-opened. Maintainers will be happy to help you.

@jameslamb I see you

self-assigned this on Jan 3

Are you still working on this feature request?

Yes, thanks for the reminder, I'd like to get to this within the next release cycle. Not having it is blocking #6172. Let's leave it open please.


LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20230105171657930 to main

LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20230105171657930 to main with localized lcls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 42.086%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/jupyter/serverInstance.ts
4
75.5%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
28591

Relevant Lines:
63109

💛  - Coveralls


Bollinger Bands implementation

Implemented Bollinger bands and have done unit testing.
Please accept pull request if implementation is ok.

Hey, thanks for the PR.
There was a discussion regarding Bollinger Bands here: https://github.com/greyblake/ta-rs/issues/6
@Bartoshko are you implementing BB as well?

@shreyasdeotare Thank you for your PR again.
It happened so, that BB was implemented by 2 people simultaneously.
With some modifications, I accepted this version, since it was initiated earlier with this design discussion
Bollinger Bands now are available in version 0.1.2 : https://docs.rs/ta/0.1.2/ta/indicators/struct.BollingerBands.html

@greyblake alright.


Seeding DB with DREAM Challenges

@tschaffter
I pushed the codes and updated json files for seeding challenges. The followings properties still need to be tested if they work fine with current codes and latest schema.

start/endDate:  they have been changed to optional in the latest schema, since some challenge has no start/end dates
organizerIds, dataProviderIds, grantIds: check if empty array, [] is accepted in the latest services, since they are required

@rrchai Thanks! I fixed the service issue that you reported about empty array (see https://github.com/Sage-Bionetworks/rocc-service/pull/113). I'll now try to find an elegant way to fix the seeding using RxJS.

ECONNRESET issue
I now experience ECONNRESET errors randomly. Initially after submitting a random number of persons, now also affecting other objects like Organization.
[HPM] Rewriting path from "/api/organizations?organizationId=clinical-proteomic-tumor-analysis-consortium" to "/organizations?organizationId=clinical-proteomic-tumor-analysis-consortium"
[HPM] POST /api/organizations?organizationId=clinical-proteomic-tumor-analysis-consortium ~> http://localhost:8080/api/v1
[HPM] Rewriting path from "/api/organizations?organizationId=columbia-university" to "/organizations?organizationId=columbia-university"
[HPM] POST /api/organizations?organizationId=columbia-university ~> http://localhost:8080/api/v1
[HPM] Error occurred while trying to proxy request /organizations?organizationId=cincinnati-childrens-hospital-medical-center from localhost:4200 to http://localhost:8080/api/v1 (ECONNRESET) (https://nodejs.org/api/errors.html#errors_common_system_errors)
[HPM] Error occurred while trying to proxy request /organizations?organizationId=celgene from localhost:4200 to http://localhost:8080/api/v1 (ECONNRESET) (https://nodejs.org/api/errors.html#errors_common_system_errors)
[HPM] Error occurred while trying to proxy request /organizations?organizationId=clinical-proteomic-tumor-analysis-consortium from localhost:4200 to http://localhost:8080/api/v1 (ECONNRESET) (https://nodejs.org/api/errors.html#errors_common_system_errors)
[HPM] Error occurred while trying to proxy request /organizations?organizationId=center-for-research-computing from localhost:4200 to http://localhost:8080/api/v1 (ECONNRESET) (https://nodejs.org/api/errors.html#errors_common_system_errors)
[HPM] Error occurred while trying to proxy request /organizations?organizationId=columbia-university from localhost:4200 to http://localhost:8080/api/v1 (ECONNRESET) (https://nodejs.org/api/errors.html#errors_common_system_errors)
[HPM] Rewriting path from "/api/organizations?organizationId=consejo-superior-de-investigaciones-cientificas" to "/organizations?organizationId=consejo-superior-de-investigaciones-cientificas"
[HPM] POST /api/organizations?organizationId=consejo-superior-de-investigaciones-cientificas ~> http://localhost:8080/api/v1
[HPM] Rewriting path from "/api/organizations?organizationId=corevitas" to "/organizations?organizationId=corevitas"
[HPM] POST /api/organizations?organizationId=corevitas ~> http://localhost:8080/api/v1
[HPM] Error occurred while trying to proxy request /organizations?organizationId=consejo-superior-de-investigaciones-cientificas from localhost:4200 to http://localhost:8080/api/v1 (ECONNRESET) (https://nodejs.org/api/errors.html#errors_common_system_errors)
[HPM] Error occurred while trying to proxy request /organizations?organizationId=corevitas from localhost:4200 to http://localhost:8080/api/v1 (ECONNRESET) (https://nodejs.org/api/errors.html#errors_common_system_errors)
[HPM] Rewriting path from "/api/organizations?organizationId=defense-advanced-research-projects-agency" to "/organizations?organizationId=defense-advanced-research-projects-agency"
[HPM] POST /api/organizations?organizationId=defense-advanced-research-projects-agency ~> http://localhost:8080/api/v1
[HPM] Rewriting path from "/api/organizations?organizationId=corrona" to "/organizations?organizationId=corrona"
[HPM] POST /api/organizations?organizationId=corrona ~> http://localhost:8080/api/v1
[HPM] Rewriting path from "/api/organizations?organizationId=dana-farber-cancer-institute" to "/organizations?organizationId=dana-farber-cancer-institute"

@rrchai Getting this error after your last commit:
POSThttp://localhost:4200/api/organizations?organizationId=applied-proteogenomics-organizational-learning-and-outcomes-network

Temporarily renaming this organization ID;

applied-proteogenomics-organizational-learning-and-outcomes-network => org-a
eunice-kennedy-shriver-national-institute-of-child-health-and-human-development => org-b

@rrchai You replaced Challenge.organizationIds by Challenge.organizations, which is incorrect. I'll fix this.

Removed the following organizations from challenge.json because their ID is too long (> 60 char).

eunice-kennedy-shriver-national-institute-of-child-health-and-human-development
applied-proteogenomics-organizational-learning-and-outcomes-network

Sorry about introducing new errors. There were some typos when I did the refactoring.
I have added following data (use other names to avoid conflicting your work):

organizations-fix.json: trim the long names of organizations
challenges-fix.json: fix the incorrect property names; (this file is still person objects for organizers)

With @tschaffter suggestions in #84, I also added two files using fake ids:
4. challenges-add-peronIds: replace organizers with fake organizerIds to match the challenge schema.
3. persons.json: array of persons object following the order of organizersId in challenges.json.
note: if challenges do not have any persons, it will be the empty array in organizerIds/organizers in challenges.json and will not be written in persons.json.

@rrchai I don't recommend to rely on the order of the objects in files. Instead, can you please generate fake ids for persons objects? If possible, please generate fake ids that comply with the format defined in schemas (e.g. PersonId.yaml).

@rrchai Also remove the Person objects from the Challenge object, include the fake ids instead. Please use the default parameter names like organizerIds or grantIds instead of what I did previously for the grants (tmpGrantId). It will take care of managing the fake and real ids in the seeding script.

@rrchai You can generate "fake" MongoDB ObjectId with the instruction bson.objectid.ObjectId() from the Python Package PyMongo.

@tschaffter  I have updated files:

add organizerId to persons-fakeIds.json
add grantId to grants-fakeIds.json
update organizerIds and grantIds in challenge-fakeIds.json. Fake Ids in challenge objects match with the ids in person/grants objects.

@rrchai Can you remove the following files?

challenges-fakeIds.json
grants-fakeIds.json
organizations-fix.json
persons-fakeIds.json

And update the remaining files so they meet the required defined in my previous comment. Ultimately we should only have the following files whose content match the ROCC schemas either based on the schemas {schema} (e.g. Tag, Organization) or {schema}CreateRequest.

challenges.json
grants.json
organizations.json
persons.json
tags.json

@rrchai @vpchung FYI Here is a nice illustration on how Lodash can be used to manipulate objects. In this example, I use Lodash omit method to remove the property id from object in order to obtain {schema}CreateRequest objects that are ready to be posted. :)

@rrchai @vpchung This PR is ready for your review. The remaining issue "Error: bundle initial-es5 exceeded maximum budget." should be fixed soon.
@rrchai I can't assign you as a reviewer because you create this PR. Do you mind giving a 👍 to this comment if you approve this PR?


Custom labels through extra specs or podTemplate

What is the feature you would like to have?
I would like to be able to add custom labels through the extra specs or podTemplate.
I was hoping this was already possible and I tried enhancing the podTemplate in the provider config as follows:
podTemplate:
  metadata:
    labels:
      custom-label: custom-value

and it did not reflect successfully on the instance spec once deployed.
This seems to be because the merge functionality specifically merged the Spec object inside of podTemplate.
Anything else you would like to add?
We use labels for network filtering and this would be useful to be configurable.

Hi @Hdom sorry for the late response. I have added a new test via #49 which merges additional labels via the podTemplateSpec prop of the provider config, so with the current provider version this should work. Does this work for you now? Also feel free to raise a PR anytime you encounter any issues or need additional functionality :)

With the recent version of the provider, the issue is fixed (+ we have a test for that case as well).
Will close the issue for now - if there is still an issue, please let us know!


Pre-caching proposal

Pre-caching data is simple when the data is a manageable size and we can perform a single query to get all of it. However when the data is potentially huge and various filters and transforms are applied we need to find a different solution to caching individual queries. Since we now express all filters and transform at the level of a Pipeline this is also the appropriate place to declare the pre-caching configuration. There are two possibilities for expressing the space of queries to cache:

Express the values for each filter and potentially also options for specific transforms. We could then compute the cross-product of all of those options and execute and cache those queries. The problem with this approach is that cross-products quickly get huge and often we just need to pre-fetch the most commonly viewed combinations.
Express each explicit combination of filter, transform and variable values to fetch.

Both approaches have value but for now we will focus on the latter.
Specification
The proposed specification for defining individual pre-cached values looks like this:
pipelines:
  sql_table:
    - source: sql_source
      table: sql_table
      filters:
        a:
          type: widget
        b:
          type: widget
      sql_transforms:
        - type: aggregate
          by: $variables.groupby
          aggregates:
            c: mean
      precache:
        - a: 1
          b: 2
          variables:
            groupby: day
        - a: 2
          b: 1
          variables:
            groupby: week
        ...

To address option 1 we will eventually also support this syntax:
pipelines:
  sql_table:
    - source: sql_source
      table: sql_table
      filters:
        a:
          type: widget
        b:
          type: widget
      sql_transforms:
        - type: aggregate
          by: $variables.groupby
          aggregates:
            c: mean
      precache:
        a: [1, 2]
        b: [1, 2]
        variables:
            groupby: [day, week]

This has been merged.


Fix spire-server configmap UpstreamAuthority/aws_pca and KeyManager/a…

Current configmap template renders to a wrong KeyManager and UpstreamAuthority configurarion when aws_kms and aws_pca are enabled and container is crashing. The proposed changes will fix the issue.

Thanks for the fixes.
Could you please add a quick section to tests/unit/spire_test.go that turns the features on to see if it renders ok? Not having any tests at all, even "does it render to valid yaml" makes it hard to not accidentally break.

@unufr33 Do you have time to write the test? No problem if not, we can merge without it. We understand people are busy.

Hope this works

Is this test failure related to this pr?
INFO: Downloading bootstrap version 'v2.0.0' of cosign to verify version to be installed...
      https://storage.googleapis.com/cosign-releases/v2.0.0/cosign-linux-amd64
Error: Process completed with exit code 56.

I don't think the failed tests are related to my changes. My changes are in the "checks" job and it passes. The failed jobs passed several times before that .Can you please rerun ?

Is this test failure related to this pr?
INFO: Downloading bootstrap version 'v2.0.0' of cosign to verify version to be installed...
      https://storage.googleapis.com/cosign-releases/v2.0.0/cosign-linux-amd64
Error: Process completed with exit code 56.

Looks like a transient network issue. I just re-triggered the failed job to rerun. I'm expecting it to pass.

I don't think the failed tests are related to my changes. My changes are in the "checks" job and it passes. The failed jobs passed several times before that .Can you please rerun ?

Yeah. The tests look great. Thanks for writing them. :)


Template - Customers - Validation

@jelenamitrovic980 for all the REST API methods done in #3, could you implement validation:

firstName must not be null or empty
lastName must not be null or empty

@valentinacupac
do I have to have a special customerController for validation?

@jelenamitrovic980 there is only one controller, i.e. CustomerController, so you don't need to make any new controllers... Trying finding tutorials: Java Spring Boot REST API validation

@valentinacupac
Spring Boot Rest API Validation with Hibernate Validator  https://www.youtube.com/watch?v=pjA9Pc7aTic
May I have more different methods Get, Post, Put in the Controller then?

@jelenamitrovic980 yes you can do it like they showed in the tutorial (but it would be done for existing Get, Post, Put methods, i.e. there won't be new methods)


Add a Sentry.EventFilter.exclude_event?/2 callback

We can filter exception messages captured from LoggerBackend if the event has an exception attached although if we raise a Logger.error message without exception, the events can not be filtered.
For example
Logger.error("My error message")

This line always will be sent because it not has an exception attached in metadata.

We can add a callback that takes a Sentry.Event struct and returns a boolean.


Add EverWallet as a class to nekoton

As EverWallet is a default wallet for network it would be really handy if it was provided in nekoton as some standard class
https://github.com/broxus/nekoton-python/blob/master/examples/wallet.py#L34

Done


Explain how to join vertical nav items with a bar

I didn't see this addressed elsewhere in the docs.
Is this the best spot for it? I suppose it could go in the Navigation Groups area.
I'm just not sure where people will "look for" this to be explained, and what words they will use when searching, so that we give them something to find with the search.

Example from the Demo site:

It's not just for group items, also for nested items of a parent which has an icon and children without.

But that one isn't a choice, so I don't think there is much to explain in the docs.

But that one isn't a choice, so I don't think there is much to explain in the docs.

Fair.


python312Packages.ds4drv: fix build

Description of changes
fix build (https://hydra.nixos.org/build/259568832)
ZHF: #309482
solution from https://github.com/chrippa/ds4drv/issues/208

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build python312Packages.ds4drv


Equaition 3.165 typo on page 90 in 2022-07-07 version

The integral should be equal to (B-c)-(A-c)=B-A, not A-B.

fixed


The app build failed to produce artifact folder: 'build'. Could help me as I am not aware about how this things work in webdev

@yuvraaj2002 did you trigger npm run build in your CodesSpace terminal ?


Create my_review.md

Thanks for the contribution! Please make sure your review is a new Markdown file in the new_reviews directory, eg: new_reviews/my_reviews.md.
Once you submit your pull request, the review will be validated and once all tests have passed we'll merge it into the repo.  GitHub Pages will then auto-magically generate the review at repo-reviews.github.io.
:heart: Repo-Reviews Contributors

Hi, this is Narendhar and part of the assignment made the review, commit, merge and pull request.
Please go through it and let me know.
Regards,
Narendhar.


Provide better error details

I see this error frequently, it would be nice to see why it's occuring

I see this error frequently, it would be nice to see why it's occuring

Nice!
Looked through my logs and haven't seen any entry at all.. hope it helps you locate some issue that we can fix :)
log.printf should maybe be better to use when having variables in log rows.. but I have planned to implement logrus anyways so all println/printf will be replaced then :)


NPE when passing mouse over variable during debug

Code to reproduce:
var {Script} = require("vm")
var fun = new Script("var __global__ = this; debugger;");
fun.runInNewContext();

GraalVM 1.0 RC 15

Node v10.15.3

This was adressed in https://github.com/oracle/graal/commit/6e5f22e5c6bc27505740f605053a48de37db1ebc


Add option to not save new movie set artwork in subdirectories in central directory

To match the existing setup implemented by Movie Set Artwork Automator, and other tools designed to work with it. Artwork Beef will already identify artwork either way, this is just about where to save newly downloaded images.
Much like the Kodi (18 Leia) built-in music "Artist information directory", I think this is a good place for other movie collection related things, like an NFO, so it won't be the default, but it can be an option.

Option added in 0.22.0.


[WIP] Set priority of layers to 12

To make sure that specific components can override/redefine settings from more generic levels, we set the following priorities for levels:
meta-xt-common     -  8
meta-xt-<platform> - 10
meta-xt-<product>  - 12

Signed-off-by: Ruslan Shymkevych<EMAIL_ADDRESS>

Acked-by: Volodymyr Babchuk<EMAIL_ADDRESS>

Rebased.
'Ack' is added.


Package Splitting works

I've done the initial version of splitting work.
the package spitted by

core: issue, present, verify
decode: decode sdjwt into object
hash: purejs sha256 function
present: present sdjwt & get presentable keys
utils
types
node-crypto: contain sample crypto logic for optional use for nodejs
browser-crypto: contain sample crypto logic for optional use for browser

Todos:

support sync functions for decode, present and core(issue, present, verify)
fix examples

I'll add the sd-jwt-vc in next PR

@lukasjhan I added some notes, most of them are relevant for all packages since it is based on the package json.
I am also missing code documentation. Even when the functions are small it is good for a quality based project ;)

@cre8 Good points :)
I'll make a docs right away

I should have written some comments while I was working on it.

@lukasjhan I added some notes, most of them are relevant for all packages since it is based on the package json.
I am also missing code documentation. Even when the functions are small it is good for a quality based project ;)

Sorry for ping again.
Where can I find you notes? I couldn't find it.

I added

comments
examples
README of examples

I added

comments
examples
README of examples

I checked the examples and it works well!

@lukasjhan With code documentation I do not mean some google docs explaining implementation decision. But documentation for variables, functions, classes, etc directly in the code

@lukasjhan With code documentation I do not mean some google docs explaining implementation decision. But documentation for variables, functions, classes, etc directly in the code

I got it. I wrote some comments in the code. you can check here :) a50d838

@lukasjhan With code documentation I do not mean some google docs explaining implementation decision. But documentation for variables, functions, classes, etc directly in the code

I got it. I wrote some comments in the code. you can check here :) a50d838

Great. Do you think it makes sense to also add eslint during this PR? opened an issue for this, see #69

I would like to merge this PR and do other task in different PR. It's too big :)


utils: Don't evaluate empty column's dtype

In standardize_dataframe(), we create empty columns and fill them with
pd.NA which results in a numpy.dtype that is not comparable with
panda's string dtype. This resulted in a TypeError when evaluating if
the empty column's dtype == 'string'.
Because we only use this value when creating empty columns, check if the
column is not entirely empty before comparing its dtype to panda's
string.
Resolves the issue described by @tsibley in #59 using @joverlee521's debugging findings.

Nice debugging! Conditionalizing the dtype comparison seems like fixing the symptom, not the root problem, though. What about making sure the empty columns have a valid Pandas-native nullable dtype?
df[field] = pd.Series(dtype = "string")

will fill field with pd.NA and df[field].dtype will still work with Pandas-native dtypes (as opposed to just numpy-native dtypes). An empty Series of Int64 or Boolean, the other Pandas-native dtypes, would also work.

Nice debugging! Conditionalizing the dtype comparison seems like fixing the symptom, not the root problem, though. What about making sure the empty columns have a valid Pandas-native nullable dtype?
df[field] = pd.Series(dtype = "string")

will fill field with pd.NA and df[field].dtype will still work with Pandas-native dtypes (as opposed to just numpy-native dtypes). An empty Series of Int64 or Boolean, the other Pandas-native dtypes, would also work.

Agreed, that's a superior solution. I incorporated this suggestion into a new commit.


Support dataset provo fields

The Sweden in Eurovision datasets have data from two different sources, Wikipedia and SixOnStage. Though the data is published by ONS, it is sourced from two locations.
Source might contain a list of sources for a dataset; however the publisher will always be one. Maybe? To be confirmed. Align to provo.
This will require a wider discussion with the Data Architect and Manager.

You've removed this from the product backlog! Let's keep this one open and close the others.

There's loads we could do here, but I guess what you're really wanting is to indicate a dataset was created using some upstream source.
In future (and I need to bring my proposal for distributions to the group) I think I'd recommend it working like:
# We have a dcat:Dataset with a CSVW distribution and a qb:DataSet distribution
</dataset/sweden-at-eurovision> a dcat:Dataset ;
    dcat:distribution </dataset/sweden-at-eurovision.csv>, </dataset/sweden-at-eurovision/datacube> ;
    .

# The CSVW distribution is prov:derivedFrom some upstream datasource
</dataset/sweden-at-eurovision.csv> a csvw:Table ;
    prov:wasDerivedFrom <https://en.wikipedia.org/wiki/Sweden_in_the_Eurovision_Song_Contest> ;
    # We can qualify (provide more detail) about the derivation if we want:
    prov:qualifiedDerivation [
        a prov:Derivation;
        # The CSV was derived from the wikipedia page
        prov:entity <https://en.wikipedia.org/wiki/Sweden_in_the_Eurovision_Song_Contest> ;
        # It was derived in the Jenkins pipeline
        prov:hadActivity <ci.data.gov.uk/12718530-bff7-4a6f-907d-f0ee564e8cac> ;
    ] ;
    prov:wasGeneratedBy <ci.data.gov.uk/12718530-bff7-4a6f-907d-f0ee564e8cac> ;
    .

# The qb:DataSet was derived from the CSV + CSVW metadata
</dataset/sweden-at-eurovision/datacube> a qb:DataSet ;
    prov:wasDerivedFrom </dataset/sweden-at-eurovision.csv>, </dataset/sweden-at-eurovision.csv-metadata.json> ;
    prov:wasGeneratedBy <ci.data.gov.uk/12718530-bff7-4a6f-907d-f0ee564e8cac> ;
    .

<ci.data.gov.uk/12718530-bff7-4a6f-907d-f0ee564e8cac> a prov:Activity ;
    prov:wasAssociatedWith <https://github.com/Swirrl/csv2rdf>, <https://github.com/GSS-Cogs/csvcubed> ;
    prov:startedAtTime "2015-02-13T15:12:44"^^xsd:dateTime ;
    prov:endedAtTime   "2015-02-13T15:12:46"^^xsd:dateTime ;
    prov:used <https://en.wikipedia.org/wiki/Sweden_in_the_Eurovision_Song_Contest>,
        </dataset/sweden-at-eurovision.csv>,
        </dataset/sweden-at-eurovision.csv-metadata.json> ;
    prov:qualifiedUsage [ a prov:Usage ;
        prov:entity </dataset/sweden-at-eurovision.csv> ;
        prov:hadRole csvw:csvEncodedTabularData
    ];
    prov:qualifiedUsage [ a prov:Usage ;
        prov:entity </dataset/sweden-at-eurovision.csv-metadata.json> ;
        prov:hadRole csvw:tabularMetadata
    ];
    .


Look into supporting react

In light of this forum post, lets see if we can't make some react template/component helpers.
No extensive experience with react yet, any help with this is appreciated.
An example on how react users would like to see this package being used in a react component would be nice.
Support for react-router is probably needed.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/28476397-look-into-supporting-react?utm_campaign=plugin&utm_content=tracker%2F522373&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F522373&utm_medium=issues&utm_source=github).

title

#41

zimme or someone else, please provide example of how to use meteor-active-route with react and react mount. Thanks.

@zimme that's exactly what I'm looking for

@zimme +1 A React example would be highly appreciated! :)

@GilbertMizrahi, @s-devaney, @sandervanhooft: I don't think there's a specific way or using this with react, I'm working a bit on this package now, re-writing it to es2015. After this I would probably start working on the react support a bit and see if I can't add support for react router as well as kadira:flow-router and iron:router. But I would love to get feed back on how people using react would expect this package to work with react.
Maybe just having ActiveRoute as a javascript export is enough? or do we need to do some helpers too? components maybe?

I have figured out a way to make it work with React. I will write about it in the next couple of days. I will let you know.

@GilbertMizrahi, which router did you use? I know you can make it work with react using iron:router or kadira:flow-router, but I would like to make it as frictionless as possible to use it.

@zimme I am using kadira:flow-router.
And fair enough, if you  can make it better for any scenario, that will be great:)

From what I have gathered, if I can make ActiveRoute.name('home'); return either the class as a string 'active' or boolean false, like the blaze helpers does. It should me a minor help for using it with react, but maybe there's some kind of component I can do that would make using this package with react "much" better.

@zimme I wrote a short article how I use it with React. http://meteorlife.com/using-zimmeactive-route-package-to-show-the-active-route-in-a-meteor-react-app/
if ActiveRoute.path(path) returns true, a class of active is added to the active route element.

@GilbertMizrahi, awesome! I'm working on a re-design of this package and I'm putting it under a new namespace where you can just add what you need.
meteor add activeroute:core activeroute:flow-router

This is pretty much what you would need for flow-router and react, as you don't need all the iron-router and blaze stuff.
But anyways, hopefully the article can be a good base for a paragraph in the official guide.

@zimme great. Looking forward for the re-design

That's great @zimme !
On Tue, 7 Jun 2016 at 23:12 GilbertMizrahi<EMAIL_ADDRESS>wrote:

@zimme https://github.com/zimme great. Looking forward for the re-design
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zimme/meteor-active-route/issues/45#issuecomment-224415912,
or mute the thread
https://github.com/notifications/unsubscribe/AG7dpxmtCNavLQrkhpGGJcqQ2f2SaWPJks5qJd6sgaJpZM4GmuAT
.


Occlusion not compatible with bootstrap tables

First thank you for occlusion rendering.  Occlusion rendering will override Bootstrap classes assigned to tableClassNames. So the following doesn't work
 {{#light-table table
   height='60vh'
   tableClassNames="table table-striped"
   occlusion=true
   estimatedRowHeight=50
  as |t|}}

...

{{/light-table}}

which is fixed by creating your own class to mimic bootstrap tables
.occlusion-bs-striped {
    table {
      width: 100%;
      max-width: 100%;
      margin-bottom: 1rem;
      background-color: $table-bg;
    }

  td {
    padding: $table-cell-padding;
    vertical-align: top;
    border-top: $table-border-width solid $table-border-color;
  }

  thead > tr > th {
    vertical-align: bottom;
    border-bottom: 2px solid $table-border-color;
  }

  tbody tr:nth-of-type(odd) {
      background-color: $table-accent-bg;
  }

  tr {
    height: 25px;
  }
}

 {{#light-table table
   height='60vh'
   tableClassNames="occlusion-bs-striped"
   occlusion=true
   estimatedRowHeight=50
  as |t|}}

...

{{/light-table}}

A minor issue but it may throw some people off.

Are you using Bootstrap v3? They're using overly restrictive CSS selectors in that version: .table-striped > tbody > tr:nth-of-type(odd)
The selectors were relaxed in Bootstrap v4: .table-striped tbody tr:nth-of-type(odd)
Occclusion rendering wraps the
 elements in another element (<vertical-collection>), building this contstruct:

    <vertical-collection>
      <occluded-content></occluded-content>

      <occluded-content>And 84 items after</occluded-content>
    </vertical-collection>

You can upgrade to Bootstrap v4 to fix that. Maybe we can get rid of the <vertical-collection> element, but I can't promise anything yet.

Yes, forgot to mention v3.  I'm using ember-cli-bootstrap-sassy which is still on v3, so until the addon author upgrades, I'll be on v3.
I figured the  element was causing the issue.  To be honest, creating a specific class to solve my problem is fine.  Unless it's breaking something else, I'd not spend time removing it.  I put it up as much to document it, in case someone else ran into the issue.


"Getting started" link on home page is broken

@Yajur-Grover can you look into this?

Link on Getting Started tile is broken - PR attached should resolve this.


Log-Error: Device is not responding

Describe the bug
After about 15 min of working fine the instance starts to continuosly log
2022-07-19 08:54:27.333  - warn: wamo.0 (25319) Warnmeldung
2022-07-19 08:54:27.335  - error: wamo.0 (25319) [async getData(statesToGet)] 1 try / Device at <IP_ADDRESS>:5333is not responding
2022-07-19 08:54:27.335  - warn: wamo.0 (25319) Waiting for 3 seconds ...
2022-07-19 08:54:30.336  - warn: wamo.0 (25319) retry connection ...
In the meantime the values are still read out of the device.
This only stops of the instance is stopped or restarted.
From the code it seems as if each value is read out of the device using a single http-request.
Maybe using the single
http://ip-address:5333/safe-tec/get/all
call parsing the json string could be better. I'm using this in fhem to get all parameters from the device every 5 s successfully for months now without problems.
Adapter version is 0.1.4, running on raspberry 3+

http://ip-address:5333/safe-tec/get/all is not really an option because in a further release I would like to make each parameter selectable for read out in the settings page.
So I have to fix the issue related to connection dropouts to the device. Since the read requests to the device are handled within different timers, some of the values will still be updated where other requests are hanging. So I need to improve the whole read request handling.

Related to #1

fixed in release v0.1.5


Fixed issues from PR #11628.

cc @RichieEscarez @thockin @brendandburns

I'm going to self-merge and will fix issues later.


Set "discovery"."resourceType" with one exception

I used this rule to ensure all records imported from Digital Commons had the same resource type suggested by our Special Collections team, except for our items in the "Masters Theses and Doctoral Dissertations" set.
rule "all archival materials"
when
"dc"."source" not equals "Masters Theses and Doctoral Dissertations"
then
set "Archival Material" in "discovery"."resourceType"
end

Kia ora alsalatkajr,
I'm sorry about the delay but the teams workload commitments meant that this volunteer project had a lower priority over the last month.
Just a note, I tried your code but there was a compilation error. The code that did work was:
rule "all archival materials"
when
"//*[local-name()='source']/text()" not equals "Masters Theses and Doctoral Dissertations"
then
set "Archival Material" in "discovery"."resourceType"
end
Ngā mihi,
Craig.

Combined with https://github.com/primousers/primo-ve-norm/issues/25, added to code base and closed.


[WM-1981] Support for Dockstore methods in POST /method endpoint

Closes https://broadworkbench.atlassian.net/browse/WM-1981

Added metric counter for error when importing dockstore method:


ppc64le support

Any chance this could get built for ppc64le as well?

Sure. See https://github.com/conda-forge/clinfo-feedstock/pull/3

Thank you!


⚠ Turnos 24x7 has degraded performance

In 85405e1, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 3120 ms

Resolved: Turnos 24x7 performance has improved in 1f22d58.


host_install.sh: Source os_ver_details.sh

This fixes the errors identified in #58 where the top-level sourcing of
the file os_ver_details.sh wasn't being done with a full path. I also
updated the instructions in README_HOST_INSTALL.sh to address the
example in there.
Closes #58
Signed-off-by: Kyle Mestery<EMAIL_ADDRESS>

@jafingerhut let me know if this fixes the error you identified in #58, I think it will.

I fully believe this change would avoid the error I was seeing.   Looks good to me.


chore(main): release 1.8.0

:robot: I have created a release beep boop
1.8.0 (2024-01-16)
Features

add sanctum support + API key management on profile page (7db7d85)
support API uploads (sharex support) (2be1260)

Bug Fixes

title content editable by guests/non-owners (dffc43d)

Miscellaneous Chores

add tests for apikey (169047e)
add upload controller test (json add), consolidate most of 'public identifier' logic (0497567)
lint php (9f6c1bb)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/mdshack/shotshare/releases/tag/v1.8.0 :sunflower:


DNS Resolver visibility into individual queries

Motivation:
A single DNS query may follow many different paths through resolver-dns. The query may fail for various reasons related to the DNS protocol, general IO errors, it may be cancelled due to the query count being exceeded, or other reasons. A query may also result in other queries as we follow the DNS protocol (e.g. redirects, CNAME, etc...). It is currently impossible to collect information about the life cycle of an individual query though resolver-dns. This information may be valuable when considering which DNS servers are preferred over others.
Modifications:

Introduce an interface which can provide visibility into all the potential outcomes of an individual DNS query

Result:
resolver-dns provides visibility into individual DNS queries which can be used to avoid poorly performing DNS servers.

@Scottmitch ship it once ci finishes!

4.1 (5a2d04684)


Implement reject functionality

This leverages the acknowledgement_state accessor
that was added to support ack/nack tracking. This
supports the requeue param.
Paired with @dwhenry

Coverage remained the same at 100.0% when pulling f5ffb9d1a7794064dcc4a170292baf92cf89e93e on alphagov:add-tracking-for-channel-reject-method into 4f61a5e106e5e16098bb90b03e15ecc075de613c on arempe93:master.

thanks for the PR - ill try to look at this after work

Hi @arempe93, not sure if you got a chance to look at this yet? Do let us know if there is anything unclear.

@binaryberry hey sorry I took a long weekend and forgot to look beforehand.

Everything looks good so I'll do a 1.7.0 release sometime today

@arempe93 Thanks a lot! 😃

Hi @arempe93 ! I wanted to check in to see if you might know when you'd be releasing this?
It'll be helpful for us knowing we're no longer relying on our own fork, but I do realise you're doing this in your own time.

@binaryberry just pushed out v1.7.0 - thanks for your patience and for reminding me

@arempe93 Thank you so much for doing this! 🎉


Create CODE_OF_CONDUCT.md

Codecov Report

Merging #47 into review will increase coverage by 1.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           review      #47      +/-   ##
==========================================
+ Coverage      75%   76.19%   +1.19%
==========================================
  Files           2        2
  Lines          40       42       +2
==========================================
+ Hits           30       32       +2
  Misses          5        5
  Partials        5        5

Impacted Files
Coverage Δ

pkg/token/manager/demo/demo.go
72.22% <0%> (+1.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47a23c1...25928a5. Read the comment docs.