Build clang-tidy support into node-cpp-skel

The clang-tidy command is a powerful tool from the llvm suite with the ability to:

apply a large set of robustness checks
automatically modernize code

Details at https://clang.llvm.org/extra/clang-tidy/
clang-tidy uses static analysis
We should integrate an easy clang-tidy workflow into node-cpp-skel by following the lead of both nodejs core, mapbox-gl-native, and OSRM:

https://github.com/nodejs/node/pull/7986
https://github.com/mapbox/mapbox-gl-native/pull/5325
https://github.com/Project-OSRM/osrm-backend/commit/998abf05bab47f6d7593e17540fc314c2c294ba9

Note: I presume clang-tidy will find very few issues with the current node-cpp-skel code, since it is fairly simple. The main idea here is to put this in place so that modules based on node-cpp-skel will more readily catch bugs before they hit production.

One challenge here is that clang-tidy needs to compile the code to do its checks. And to compile node-cpp-skel code requires a variety of unique include paths to node-gyp bundled headers and nan.h in node_modules, and any mason deps.
To avoid needing to write a second build system to collect and pass all these paths, it is best to have the build system generate a compile_commands.json that clang-tidy can consume. The format is basically an JSON array of which files are compiled, with what compiler args should be used. It is described in detail at https://clang.llvm.org/docs/JSONCompilationDatabase.html.
The cmake build system has support for outputting compile commands this with cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON. But we don't use cmake here because the nodejs standard is gyp. So the question becomes how to generate the compile_commands.json ourselves.
I've found https://github.com/rizsotto/Bear, but it looks like overkill. It would need to be compiled itself, packaged in mason, and who knows how well it works.
So, instead I think we should write a command that captures the output of the existing build, parses it, and rewrites the compile_commands.json from it. We can pipe the output of the existing build into this tool in order to capture it.

Done in #64


Use AWS SDK built in upload implementation

Great library, thanks for making it open source! I'm considering replacing some code I have with a similar purpose with your lib, but I'm hesitant to give up the built in managed uploader from the AWS SDK.
What are your thoughts on swapping it in?
http://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html#upload-property
The benefits I see are:

Built in multi-part management -> you can delete code
Parts are uploaded concurrently
Many more advanced options

Hey there! Thanks for the feedback. I noticed that the other day when going through the S3 documentation some more and was considering replacing the code here shortly.
With it we would be able to continue to support our current features and some additional pieces. Our implementation currently support multi-part or single upload negotiation, and streams with it but that's about it. Here's the announcement that AWS made about the feature.
As a workaround for you right now, if you wanted to use s3fs but also use the S3.upload() function we actually expose our underlying S3 instance on the object itself. So as a temporary solution (until we trade out our code for theirs) you could have code like this:
var S3FS = require('s3fs');
var fsImpl = new S3FS('test-bucket', options);
fsImpl.writeFile('message.txt', 'Hello Node', function (err) {
  if (err) throw err;
  console.log('It\'s saved!');
});

var params = {Bucket: fsImpl.bucket, Key: path.join(fsImpl.path, 'key.json'), Body: stream};
fsImpl.s3.upload(params, function(err, data) {
  console.log(err, data);
});

This would give you the best of both until we are able to transition over.


SearchView not working in Androidx

My search view was working fine before i migrated to androidx and now its not working at all.
I think the problem lies with the androidx.appcompat.widget.Toolbar. My searchview is not even visible now and the funny thing is i used the same thing in other fragment and its working fine there but after migrating i used the searchview in another fragment and now its not visible at all.

    <androidx.appcompat.widget.Toolbar
        android:id="@+id/toolbarinsearch2"
        android:layout_width="match_parent"
        android:layout_height="?attr/actionBarSize"
        android:background="@android:color/holo_blue_light" />

    <com.miguelcatalan.materialsearchview.MaterialSearchView
        android:id="@+id/searchHere2"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:theme="@style/MaterialSearchViewStyle" />
</FrameLayout>

Same, I don't think this library is implemented for that.

Woo


Add support for more companies

Currently there is only Intel (INTC) and Dollby digital (DLB) . Goal is to improve parser to have support for other companies like AMD, NVIDIA.

The older statements for AMD Stock statements called ACCOUNT STATEMENT used to work, however since E*TRADE has transition to MS_ClientStatements_<stock_plan_id>_<year><month>.pdf files, these no longer seem to be recognized:
$ ./etradeTaxReturnHelper.exe *.pdf *.xlsx
2024-03-23T11:53:43.332Z ERROR [etradeTaxReturnHelper::logging]

ERROR: Sold transaction in Gain&Losses:
 (trade_date: 11/10/2023, acquisition date: 11/09/2023, cost basis: xxx, income: xxx) exist,
 but corressponding data from PDF document is missing. You can download account statements PDF documents at:

            https://edoc.etrade.com/e/t/onlinedocs/docsearch?doc_type=stmt

I can provide sample MS_ClientStatements pdfs of AMD stocks for testing.

@Sand3r-  Thanks for reporting an issue. I was able to reproduce problem and now working on having it solved.


TypeError: pair[2].integrate is not a function 2.3.0

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
When I try to compile I get: TypeError: pair[2].integrate is not a function at Compilation.compilation.plugin (*/node_modules/webpack/lib/optimize/MinChunkSizePlugin.js:59:13)
If the current behavior is a bug, please provide the steps to reproduce.
Compile that worked on 2.2.1

What is the expected behavior?
Compilation success
If this is a feature request, what is motivation or use case for changing the behavior?
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
node 7.7.1 on Mac
I do have two configs that compile simultaneously
Client:
new webpack.optimize.MinChunkSizePlugin({
minChunkSize: 10000
}),
Server:
new webpack.optimize.MinChunkSizePlugin({
minChunkSize: Infinity
})
And I do use webpack-hot-server-middleware in case that has anything to do with it.

Would it be possible to provide a reproducible example in a small repo?

I got the bug, you don't need a repro repo. Thanks for reporting.

👌


Minor 2.0 Updates

Some small changes I made whilst looking at the Sample Comments App (which I am also pushing)

Thank you!


Encountering a "type object is not subscriptable" error when invoking hub.pull.

System Info
Python = 3.8.16
langchain==0.0.304
langchainhub==0.1.13
Who can help?
@hwchase17 @agola11
Information

[ ] The official example notebooks/scripts
[X] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[ ] Embedding Models
[X] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction

install python 3.8.16
install langchain==0.0.304 and langchainhub==0.1.13
Run the following script :

from langchain import hub
LANGCHAIN_HUB_API_KEY is set on my .env file
pull a chat prompt
try:
prompt = hub.pull("efriis/my-first-prompt")
except Exception as e:
print(e)
raise e
Expected behavior
I'm uncertain about the expected behavior, as I've never been able to successfully execute hub.pull.

@dosu-bot The dosu-bot doesn't seem to have provided a solution to my problem. Can anyone assist me with this?

This problem should be came from langchainhub library.
stack trace:
Traceback (most recent call last):
  File "d:/Python/langchain/libs/langchain/test.py", line 4, in <module>
    prompt = hub.pull("efriis/my-first-prompt")
  File "d:\Python\langchain\libs\langchain\langchain\hub.py", line 79, in pull
  File "d:\Python\langchain\libs\langchain\langchain\hub.py", line 15, in _get_client
    from langchainhub import Client
  File "C:\Users\AppData\Local\Programs\Python\Python38\lib\site-packages\langchainhub\__init__.py", line 1, in <module>
    from langchainhub.client import Client
  File "C:\Users\AppData\Local\Programs\Python\Python38\lib\site-packages\langchainhub\client.py", line 53, in <module>
    def parse_owner_repo_commit(identifier: str) -> tuple[str, str, Optional[str]]:
TypeError: 'type' object is not subscriptable

Execution sequence:

hub.pull()
In hub.py, the following is executed: from langchainhub import Client
The error comes from client.py in langchainhub: tuple[str, str, Optional[str]], and this type hint cannot be smoothly executed in Python 3.9 and below.

Solution:
Add the following at the top of client.py in langchainhub:
from __future__ import annotations

As I couldn't find the open-source project address for langchainhub, I'm unable to create a pull request for langchainhub to fix this error.
Hope other maintainers to help with modifying this error.
@lehic
If you don't want to wait for changes in langchainhub, you can add the following code to client.py yourself. This should resolve the issue.
from __future__ import annotations

You can directly modify your local langchainhub/client.py, and the file location should be something like:
C:\Users\<yourname>\AppData\Local\Programs\Python\Python38\lib\site-packages\langchainhub\client.py

Thank you, @Lin-jun-xiang, for your assistance.
Just to keep you updated, I resolved the issue by upgrading from Python 3.8 to Python 3.9. Since making this change, I haven't encountered the problem anymore. I'll go ahead and close the issue now.

This problem should be came from langchainhub library.
stack trace:
Traceback (most recent call last):
  File "d:/Python/langchain/libs/langchain/test.py", line 4, in <module>
    prompt = hub.pull("efriis/my-first-prompt")
  File "d:\Python\langchain\libs\langchain\langchain\hub.py", line 79, in pull
  File "d:\Python\langchain\libs\langchain\langchain\hub.py", line 15, in _get_client
    from langchainhub import Client
  File "C:\Users\AppData\Local\Programs\Python\Python38\lib\site-packages\langchainhub\__init__.py", line 1, in <module>
    from langchainhub.client import Client
  File "C:\Users\AppData\Local\Programs\Python\Python38\lib\site-packages\langchainhub\client.py", line 53, in <module>
    def parse_owner_repo_commit(identifier: str) -> tuple[str, str, Optional[str]]:
TypeError: 'type' object is not subscriptable

Execution sequence:

hub.pull()
In hub.py, the following is executed: from langchainhub import Client
The error comes from client.py in langchainhub: tuple[str, str, Optional[str]], and this type hint cannot be smoothly executed in Python 3.9 and below.

Solution: Add the following at the top of client.py in langchainhub:
from __future__ import annotations

As I couldn't find the open-source project address for langchainhub, I'm unable to create a pull request for langchainhub to fix this error.
Hope other maintainers to help with modifying this error.
@lehic If you don't want to wait for changes in langchainhub, you can add the following code to client.py yourself. This should resolve the issue.
from __future__ import annotations

You can directly modify your local langchainhub/client.py, and the file location should be something like: C:\Users\<yourname>\AppData\Local\Programs\Python\Python38\lib\site-packages\langchainhub\client.py

worked for me, thanks.

This has also been fixed in langchainhub 0.1.14! Thanks for raising!

For those who do not want to change the version of python from 3.8 we must modify the file Python38\Lib\langchain_cli\utils\pyproject.py
`from pathlib import Path
from typing import Any, Dict, Iterable
from tomlkit import dump, inline_table, load
from tomlkit.items import InlineTable
from typing import Iterable, Tuple
def _get_dep_inline_table(path: Path) -> InlineTable:
dep = inline_table()
dep.update({"path": str(path), "develop": True})
return dep
def add_dependencies_to_pyproject_toml(
pyproject_toml: Path,
local_editable_dependencies: Iterable[Tuple[str, Path]]
) -> None:
"""Add dependencies to pyproject.toml."""
with open(pyproject_toml, encoding="utf-8") as f:
# tomlkit types aren't amazing - treat as Dict instead
pyproject: Dict[str, Any] = load(f)
pyproject["tool"]["poetry"]["dependencies"].update(
{
name: _get_dep_inline_table(loc.relative_to(pyproject_toml.parent))
for name, loc in local_editable_dependencies
}
)
with open(pyproject_toml, "w", encoding="utf-8") as f:
dump(pyproject, f)
def remove_dependencies_from_pyproject_toml(
pyproject_toml: Path, local_editable_dependencies: Iterable[str]
) -> None:
"""Remove dependencies from pyproject.toml."""
with open(pyproject_toml, encoding="utf-8") as f:
pyproject: Dict[str, Any] = load(f)
# tomlkit types aren't amazing - treat as Dict instead
dependencies = pyproject["tool"]["poetry"]["dependencies"]
for name in local_editable_dependencies:
try:
del dependencies[name]
except KeyError:
pass
with open(pyproject_toml, "w", encoding="utf-8") as f:
dump(pyproject, f)
`

@sethemis if you pip install -U langchainhub do you still see the error?

Hi! @efriis Efriis I tested it this morning pip install langchainhub and I think there were no errors, but then I wanted to run langchain serve and this appeared not work..

@Dante690 maybe you're using a different environment for your langserve app? Maybe try upgrading langchainhub using the same environment your langserve app runs in?

For anyone who experienced the same issue, I found the reason. I was behind a VPN, and as soon as I turned off my VPN, everything worked fine.


Addition of information in security properties

As suggested by the user, there were security properties missing in the document and has been added.
Problem: https://github.com/MicrosoftDocs/windows-itpro-docs/issues/8819

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.


update ipset for arm64

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Issue in installing in dephi 11.1

I install Alcinoe for Delphi Rad studio 11.1, everything got installed when i open for windows it enable components but when i do for android components get disable so what will the solution ..please help
I would like to request you to make a tutorial video on how to install your library in a proper way so that every new comer could easily understand...or easy process like skia installation.
Thank you

Alcinoe is not tested with Delphi Rad studio 11.1, only with Delphi Rad studio 11.2 and Delphi Rad studio 11.3

Ok so I upgraded to Rad studio 11.3 ... evrything got install and even i
build an app but the problem is when I run app on my phone it get stuck in
splash screen (default firemonkey screen ) app doesn't open so what will be
the problem..
On Tue, 14 Mar, 2023, 5:41 pm Zeus64, @.***> wrote:

Closed #272 https://github.com/MagicFoundation/Alcinoe/issues/272 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/MagicFoundation/Alcinoe/issues/272#event-8742852077,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUJJJEIT4QN2SOORQ4FHFTLW4BOABANCNFSM6AAAAAAVXI6A2U
.
You are receiving this because you authored the thread.Message ID:
@.***>

I understand, with app get stuck? the demo ?

I didn't try the demo...but now I tried to open demo it says TCxMemo not
found.ignore and continue
On Tue, 14 Mar, 2023, 6:17 pm Zeus64, @.***> wrote:

I understand, with app get stuck? the demo ?
—
Reply to this email directly, view it on GitHub
https://github.com/MagicFoundation/Alcinoe/issues/272#issuecomment-1468042456,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUJJJEPGM4SMUDQN52LK6UDW4BSGNANCNFSM6AAAAAAVXI6A2U
.
You are receiving this because you authored the thread.Message ID:
@.***>

hi, i have corrected the bug in the very last version of Alcinoe. please use androidMerger in your project. This bug was because of the Delphi 11.3 bug : https://quality.embarcadero.com/browse/RSP-40709


Moya 8.0.0 final

I haven't found it anywhere and it seems that the Moya 8 milestone is empty: https://github.com/Moya/Moya/issues?q=is%3Aopen+is%3Aissue+milestone%3A"Moya+8+%2F+Swift+3", so what is blocking Moya 8.0.0 to be released?
My guess would be ReactiveCocoa and RxSwift. If so, couldn't we just pin their versions to their latest betas for now and once they're final we can make a new release. Thoughts?
Another (much more difficult) option would be making these subspecs projects themselves so that they can have their own release cycle. Of course that would break everyone's Podfiles 😅

Hmm, not sure where that milestone came from actually. I agree it's time to consider releasing Moya 8.
We're still ironing out regular bugs and other breaking changes for Swift 3, personally I'm fine with keeping it in beta for now. Especially since if we go final with beta versions of RxSwift/RAC, and then there's another RxSwift/RAC beta with breaking changes, then we need to have a new major version to avoid breaking semantic versioning.

I also think that we should stay in beta as long as our dependencies are. No need to rush and ReactiveSwift isn't even out of alpha. Also, I've removed the milestone to avoid confusion.

My main issue with staying in beta is that the main reason seems to the optional subspecs dependencies and that only Moya 8 is compatible with Swift 3 - which is out for a while. I don't like the idea of "being stuck" because of RxSwift/RAC as none of those are dependencies of my project.
I know it's unfair, but just tried to expose my concern as others might have the same feeling.
I opened this issue to check if they were any other blockers and how I could help 😊
Also, since we're here, it seems that there're a lot of changes since beta 2. Could we have a new beta? 😅

It's a fair point, thanks for bringing it up. I think a new beta makes at least makes sense, I'll try to get it done today.

Cool, beta 3 is up and pushed for Carthage and CocoaPods 👍

RxSwift's updated to 3.0 final, so we're just waiting on Reactiveswift now. I'll open an issue asking for a timeline.

Thanks for the update, Ash! 💯

Closing in favor of #758


AR-292 Integration test for GET endpoint for pull-based consumers

Ticket: https://jira.sso.episerver.net/browse/AR-292
This PR adds an integration-test for GET /channel/{channel-id}/consumer/{consumer-id}/queued-jobs endpoint.
Related PRs:

https://github.com/newscred/webhook-broker/pull/141

Addresses part of #53


Support using parts of VMA without vulkan [virtual allocation & defragmentation]

I am currently using VMA in a vulkan project for most of my memory management. Recently an alternative rendering backend was merged (DX12), for which we had to roll our own memory management.
The real problem is how we manage the content of our SSBO. We have a handful of massive SSBOs and use VMA's virtual allocator to manage their content, something that happens outside the backend dependent code.
Given how both the virtual allocator and the defragmentation should be possible without relying on anything from vulkan it would be nice if VMA either had the vulkan specific code behind a define or offered the non platform dependent features (such as virtual allocaton & defragmentation) in a separate header file.

I am sorry, but this is out of scope of this project.
I agree that it would be good to have the core allocation algorithm (as exposed by "virtual allocator" feature, plus maybe defragmentation support) extracted to a separate library, used by VMA, D3D12MA, and available for use without any specific graphics API. However, we don't have a plan to provide it. VMA is a single-header library. Changing it would require major refactoring.
Extracting the allocation algorithm manually should be relatively easy. Please look at VmaBlockMetadata_TLSF class.
You may also look for some other libraries that implement TLSF or other allocation algorithm alone.


fix #409: add validation for missing redirect uri with openid scope

Add validation for missing redirect uri when scope contains openid

This branch is out-of-date and can not be merged. It includes commits from 4.x which are not in 5.x.
To fix either:

revert to the latest common commit, add the actual commit, rebase on 5.x and force push
close the pull request, make a new branch from 5.x, copy the updated file, make new commit + pull


merge from arlac77/template-arlac77-github,arlac77/template-esm-only,arlac77/template-node-component

package.json

chore(deps): add ^13.1.0 remove ^13.0.2 (devDependencies.documentation)

:tada: This PR is included in version 3.1.13 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[3.x] Fix: Cant set ScrollContainer *_scroll value in _ready()

Fix: #58914
for 4.0: #70564

Superseded by #70564 (should be cherry-pickable as it's only a documentation change).


Add options to all methods

We should allow the user to provide an options object in all methods to enable them to set things like gasPrice and gasLimit

Already done in #29


docs: fix example changing main file

In the giving example
  fs.writeFileSync(api.entryFile, contentMain, { encoding: 'utf-8' })

it was being written back the original content instead of the modified lines. I've changed the approach adding the new line to the array and then joining it back.
  lines.splice(renderIndex, 0, `  router,`)
  const newContent = lines.join('\r\n')
  fs.writeFileSync(api.entryFile, newContent, { encoding: 'utf-8' })

Thanks for this pull request and sorry for the late reply.
But we found https://github.com/vuejs/vue-cli/pull/3656 to be a better fix for this example.
Thanks again though, your help is much appreciated.


Icon disappears during error

Accidentally overlooked that the error state still triggers an icon change to an image that no longer exists... Oops.

Fixed in v2.2.1


Module enabled event

Hi,
I'm trying to fire the 'modules.xxx.enabled' event but it doesn't work.
I think it’s due to the fact that the module isn't boot when enabled event is fired.
It's a bug ? Someone has a workaround ?
Thanks

From what I can see the event is fired. You can see this happening here: https://github.com/nWidart/laravel-modules/blob/master/src/Module.php#L194
Maybe try to debug from there to understand what's happening.

@nWidart, it works when i catch the enabled event since laravel app  but it doesn't work when i try to catch them since an module

Ah ok, that means you didnt register your event in your module.
Example:
        $this->app['events']->listen(
            BuildingSidebar::class,
            $this->getSidebarClassForModule('page', RegisterPageSidebar::class)
        );


Conflicting information with other pages, clarity on recommended practice?

It is a bit unclear what is necessary, and recommended, for diagnostics and monitoring solutions for service fabric. The information here seems at odds with other pages.
For example, this page states that you only need to create the app insights resource in azure and then add the fabric native nuget package to your services and it gives full comprehensive telemetry out of the box, organized and stamped by types and other properties.
Compare this to what's stated on the page under How-to Guides > Monitor and diagnose:
https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-diagnostics-event-analysis-appinsights
Where it says nothing about adding it to the code or nuget packages, but requires you to set up diagnostics on the fabric cluster itself through azure portal when it is created, and/or through the resource manager template by use of Sinks, and also states that all logs will only show up as traces and not as any other type. It then also goes on to recommend that EventFlow be used as the preferred solution. That article is also a fair bit older than this (current) one
Also of note, that the other article was written before .NET Core 2.2 was released, which claims to have brought feature parity with .NET Framework for Application Insights SDK, which is not clear in this article if that is a requirement to leverage Application Insights in the manner as described in this document.
Please advise. Cheers.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0402be82-9542-9eb9-7c9f-278e16b59d66
Version Independent ID: 01446149-6253-1e6e-5dda-a500f9717a2f
Content: Monitor and diagnose ASP.NET Core services on Service Fabric in Azure
Content Source: articles/service-fabric/service-fabric-tutorial-monitoring-aspnet.md
Service: service-fabric
GitHub Login: @dkkapur
Microsoft Alias: dekapur

@srrengar

hi @ththiem thanks for the feedback. You are correct, that article is a bit confusing, The recommended practice is using the App Insights SDK to instrument your application, with this you get application level diagnostics out of the box. However, you can also see platform events from Service Fabric (NodeUp, Down, etc.) in App Insights too and that is done through the portal configuration. That section of the article should be under "monitor clusters" which I will change in the docs. Thanks for pointing this out and hope this helps!

Thanks for the quick reply. Can you also confirm, for .NET Core, if 2.2 is required for App Insights SDK features in Service Fabric, as mentioned here?
https://docs.microsoft.com/en-us/azure/azure-monitor/app/asp-net-core#application-insights-sdk-comparison

@brahmnes could you comment on the .NET Core version required for the App Insights SDK for Service Fabric? I didn't see it in the repo https://github.com/Microsoft/ApplicationInsights-servicefabric

The Application Insights for Service Fabric nugets doesn't require anything specific in .NET core 2.0. It should work with anything from .NET core 1.1 and above. However, I am not sure about Application Insights SDK itself. I guess it depends on which version of the Application Insights ASP.NET core nuget and which version of Service Fabric SDK you are using.
You can check on the dependencies for the nuget. For example:
https://www.nuget.org/packages/Microsoft.ApplicationInsights.AspNetCore/2.6.1

Sounds good, thanks for the advice. Closing this.


Large screen layout: content colspan

The main view is split in 6 cols, but the content is only set to take up 5 cols of it, making it off-center, which feels weird, and leaves some empty space on the right that the content could expand into:

I propose to align it and set the content col-span to 6:

Hey! See https://github.com/scaffold-eth/se-2/pull/179#issuecomment-1434939452

I think very large inputs or very large areas of text are hard to parse for the eyes.

The main view is split in 6 cols, but the content is only set to take up 5 cols of it,

The implementation is a bit weird, yes haha (it was by accident here https://github.com/scaffold-eth/se-2/pull/174).
It's the same effect as if we have a max-width for the main area.

Closing it for now, but happy to review when the "core" is finished. We should include Andrea also!
Thanks


Update box.json

available<EMAIL_ADDRESS>

Can you please add a ^ to the start of the version number.  This will be even better as CommandBox will automatically grab newer versions that are part of the same major version.


Mili auxiliary data bugfix

Description

Fix obvious bug Eric and I noticed when we were first working on the mili material edge lines issue.

Type of change

[x] Bug fix~~
[ ] New feature
[ ] Documentation update
[ ] Other

How Has This Been Tested?

built and ran on rzhound toss4. All mili tests pass.
Reminders:

Please follow the style guidelines of this project.
Please perform a self-review of your code before submitting a PR and asking others to review it.
Please assign reviewers (see VisIt's PR procedures for more information).

Checklist:

[x] I have commented my code where applicable.~~
[x] I have updated the release notes.~~
[ ] I have made corresponding changes to the documentation.
[ ] I have added debugging support to my changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] I have confirmed new and existing unit tests pass locally with my changes.~~
[ ] I have added new baselines for any new tests to the repo.
[x] I have NOT made any changes to protocol or public interfaces in an RC branch.~~

merge w/ develop in #19785


[CS] Fixes #2331 Add ForbiddenProtectedPropertyRule

All checks have passed 🎉 I apply ignore phpstan error on existing codebase. Do you think we need to skip protected property in test classes (with Test suffix) ?
@TomasVotruba it is ready for review.

I added  allow class with Test and TestCase suffix to have protected property

All checks have passed 🎉 @TomasVotruba it is ready for review.

Rebased. All checks have passed 🎉 @TomasVotruba it is ready for review.

What is the motivation to exclude tests?
They should be written correctly too.

I was thinking it should not for test classes. Ok, I undo exclude the class with Test and TestCase suffix.

All checks have passed 🎉 @TomasVotruba I think it is ready.

Thank you :+1:

I just saw one more case that we need cover - the autowired property via @required methods:
abstract class SomeAbstractClass
{
    /**
     * @var AnnotationItemsResolver
     */
    protected $annotationItemsResolver;

    /**
     * @required
     */
    public function autowireAbstractPhpDocNodeFactory(
        AnnotationItemsResolver $annotationItemsResolver
    ): void {
        $this->annotationItemsResolver = $annotationItemsResolver;
    }
}

These shoud be covered too

I will try.


--exclude not working?

I've got an issue where I'm trying to use --exclude on jquery (as is shown in the examples in the (browserify-handbook)[https://github.com/substack/browserify-handbook#excluding]) and it is not excluding jquery in the bundle.  My app is a small test app just to test this purpose where i include jquery like so:
var $ = require('jquery');

I then run browserify directly in terminal using:
browserify js/app.js --exclude jquery > js/bundle.js

This results in jquery still being in the output bundle.js file.  What am I missing here? Is the command just flat out not working or am I doing something wrong?
Thanks in advance for any help offered.

Apologies, it's working, i was requiring the node_module rather than using it off the window :)


[nrf noup] boot_serial: Add SMP command for erasing settings

In the default command group 0 I have added the erase command with ID 6.
Sending this command with operation WRITE or READ will trigger the
command to erase settings flash area.
A successful command will return the following data structure encoded
in cbor:
{ rc : <int> }

Where rc will be the return value of the erase function or open
function if open fails.
Edit:
It will return rc = 1 if successful as an empty response would return rc = 0
Ref. TG53-97
Signed-off-by: Sigvart Hovland<EMAIL_ADDRESS>

This PR is now dependent on https://github.com/nrfconnect/sdk-nrf/pull/4537


style the post test input form, then hide the div so it only appreas after the test is run

Currently the div containing the post-test additional data form is exposed for styling purposes.
We need to style the form, then make the div hidden again.

issue added to the bq2geojson repo because it's UI


Add endpoint to upload AI topic & increase max topic length

Description
Related PRs:

https://github.com/dockstore/dockstore-support/pull/489
https://github.com/dockstore/dockstore-ui2/pull/1950

This PR adds an extended TRS endpoint that uploads an AI topic for the entry identified by the TRS ID. If the manual and automatic topics are empty, then the topic selection is automatically set to AI. This new endpoint requires an admin or curator token.
I also removed for end users to update the topicAI field using the update endpoint since AI topics are updated by the topic generator.
This PR also increases the maximum topic length from 150 to 250 characters because there were AI generated topics that exceeded 150 characters. I don't see any harm in doing this because the UI truncates the topics if they exceed 2 lines on the search page. I created a UI PR to update the maxLength allowed for the manual topic to 250 https://github.com/dockstore/dockstore-ui2/pull/1950.
Review Instructions
See instructions in https://github.com/dockstore/dockstore-support/pull/489
Issue
SEAB-6007
Security and Privacy
If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.

[x] Security and Privacy assessed

e.g. Does this change...

Any user data we collect, or data location?
Access control, authentication or authorization?
Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

[x] Check that you pass the basic style checks and unit tests by running mvn clean install
[x] Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
[x] Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
[x] If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
[x] Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
[x] Do not serve user-uploaded binary images through the Dockstore API
[x] Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
[x] Do not create cookies, although this may change in the future
[x] If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

Belated thought: should the endpoint automatically set the TopicSelection as AI if none of the other topics are filled in?

Belated thought: should the endpoint automatically set the TopicSelection as AI if none of the other topics are filled in?

Makes sense, I guess they wouldn't be visible otherwise unless we did something tricky with elastic

Updated the PR so that if there is no manual or automatic topic, the topic selection is automatically set to AI.
Furthermore, I modified the updateWorkflow and updateContainer endpoint so that it does not update the topicAI field since AI topics are updated by the topic generator, not by end users.

Updated the PR so that if there is no manual or automatic topic, the topic selection is automatically set to AI.

Does this mean that in those cases, the AI topic automatically appears in search and/or on the entry page, without entry owner approval?

Updated the PR so that if there is no manual or automatic topic, the topic selection is automatically set to AI.

Does this mean that in those cases, the AI topic automatically appears in search and/or on the entry page, without entry owner approval?

Yeah, that's correct, but it should only be for published entries. Are you thinking it should be opt-in instead of opt-out?

Updated the PR so that if there is no manual or automatic topic, the topic selection is automatically set to AI.

Does this mean that in those cases, the AI topic automatically appears in search and/or on the entry page, without entry owner approval?

Yeah, that's correct, but it should only be for published entries. Are you thinking it should be opt-in instead of opt-out?

Mixed feelings, automatic inclusion is good for usability, but I feel like there's the possibility that owners might not always approve.  Acceptable risk?  Not sure.

Mixed feelings, automatic inclusion is good for usability, but I feel like there's the possibility that owners might not always approve. Acceptable risk? Not sure.

Well, this was the intent, to have the topic sentences show up as a last resort but be labelled as AI
https://github.com/dockstore/dockstore-ui2/pull/1939
Many workflows should have a topic one way or another, harvested from the github repo, from the .dockstore.yml, or from the workflow descriptor itself


Precision lets scientific notation leak for small values

Hi,
I have very little experience with color spaces. I found your solution for a simple theme designer that i build for my app using DaisyUI.
They store the colors in oklch and when the user pickers a rgb color, using a color picker I have to make the conversion. It is actually super easy:
const color = new Color(input.value);
const converted = color.to('oklch');

root.style.setProperty(style, `${converted.coords[0]} ${converted.coords[1]} ${converted.coords[2]}`);

It works fine, except for black and white:
Except black and white (#00000 and `#ffffff)

Black returns the same: 1.0000000000000002 4.996003610813204e-16 NaN
White returns 1.0000000000000002 4.996003610813204e-16 NaN

Black returns the same: 1.0000000000000002 4.996003610813204e-16 NaN
White returns 1.0000000000000002 4.996003610813204e-16 NaN

Are you saying that a conversion from sRGB #000000 is giving you the same value that #ffffff gives you? I'm a bit confused by your statement.
This is what I get for black and white:
> new Color('#000000').to('oklch').coords
[ 0, 0, NaN ]
> new Color('#ffffff').to('oklch').coords
[ 1.0000000000000002, 4.996003610813204e-16, NaN ]

This matches what I get in their live playground: https://colorjs.io/notebook/

Yes, you are right. I also get [0, 0, NaN] now. Not sure what I did.

What is the status?

Your issue is not reproducible, and then it also seems you are now getting what you should, so there is nothing to look into. The issue has been closed.

I am confused. My test with black was obviously wrong, but both colors do not return the expected result.
Black:

Result: [1,5e-16,NaN]
Expected [100, 0, 0] (https://oklch.com/#100,0,0,100)

White

Result [0, 0, NaN]
Expected [0, 0, 0]

My problem was not that both return the same color, but that the conversion from black and white return invalid colors.

Unfortunately, it was not clear from your filed issue what your issue was, so let me explain.

The site you linked is giving you rounded values after conversion, if they were to give you full precision values, you would see that chroma for white is very near zero but not quite zero. This is due to the perils of floating point math.

When a color is achromatic, during conversion, hues are returned as undefined or represented by NaN ("not a number") in floating point numbers. This is because achromatic colors such as white, gray, black, etc. do not actually have a hue. Coupled with floating point math, you will often get a nonsensical hue around achromatic colors. In order to interpolate between achromatic colors, you can't treat achromatic hues as real values, or you get influences of the nonsensical hues in the interpolation.  It is a convention though to return zero as the hue for achromatic colors. When serializing CSS may do this as well. Treating these hues as undefined helps when interpolating between achromatic colors though so you don't introduce a mysterious red, blue, or some other color.
In short, Color.js, by default, returns achromatic hues as undefined for color spaces where this makes sense. Unfortunately, there is no automatic way to extract the color coordinates without NaN, so you will have to convert them to zero yourself.
This is discussed more here: https://github.com/color-js/color.js/issues/328. Color.js has not at this time decided to provide a way to easily pull values without NaN.

Now, I have found an issue, so I'll reopen this issue. What I am experiencing is that rounding to a given precision isn't quite working. I think this is a new bug introduced by https://github.com/color-js/color.js/pull/384. This seems to specifically affect very small numbers using scientific notation.
> new Color('red').to('oklch').toString({precision: 1})
'oklch(0.6 0.3 30)'
> new Color('red').to('oklch').toString({precision: 3})
'oklch(0.628 0.258 29.2)'
> new Color('red').to('oklch').toString({precision: 16})
'oklch(0.6279553639214311 0.2576833038053608 29.23388027962784)'
> new Color('white').to('oklch').toString({precision: 3})
'oklch(1 5e-16 none)'
> new Color('white').to('oklch').toString({precision: 1})
'oklch(1 5e-16 none)'
> new Color('white').to('oklch').toString({precision: 16})
'oklch(1 4.996003610813204e-16 none)'

In their defense, precision is working much better, but it now specifically has an issue with very, very small numbers that JS will display with scientific notation. What we should get, because 5e-16 is so far below the rounding precision, is something more like this (I will have to use my own color library to demonstrate).
>>> Color('red').convert('oklch').to_string(precision=1)
'oklch(0.6 0.3 30)'
>>> Color('red').convert('oklch').to_string(precision=3)
'oklch(0.628 0.258 29.2)'
>>> Color('red').convert('oklch').to_string(precision=16)
'oklch(0.6279553639214313 0.2576833038053606 29.2338802796279)'
>>> Color('white').convert('oklch').to_string(precision=1)
'oklch(1 0 0)'
>>> Color('white').convert('oklch').to_string(precision=3)
'oklch(1 0 0)'
>>> Color('white').convert('oklch').to_string(precision=16)
'oklch(1 0.0000000000000005 0)'

I see. Thanks for your awesome explanation

I am confused. My test with black was obviously wrong, but both colors do not return the expected result.
Black:
* Result: `[1,5e-16,NaN]`

* Expected `[100, 0, 0]` (https://oklch.com/#100,0,0,100)

White
* Result `[0, 0, NaN]`

* Expected `[0, 0, 0]`

My problem was not that both return the same color, but that the conversion from black and white return invalid colors.

Your first problem is that you have mixed up black and white. Black should give [0, 0, NaN] and white would give [1, 0, NaN].
Your second is that you seem to believe Oklab (and thus, Oklch) Lightness goes from 0 to 100. It does not, the range is 0 to 1. See the actual defining document:

https://bottosson.github.io/posts/oklab/

However, I can see why you think that: Oklch.com is using percentage values (but leaving out the percent sign from the picker!)
Thirdly, an undefined hue is correct for achromatic colors.
As @facelessuser said, rounding should be catching those tiny almost-zero numbers, but the scientific notation is leaking out and this is a Color.js problem that we need to fix.

 But I do not really understand oklab yet, but it looks interesting to generate colors for things elements like avatars.
The only motivation was to convert a color, that I got from a color-input to something that CSS understands, because the CSS framework uses oklab. If there is a good reason why it should not work out of the box, it would be great to have documentation, an alternative conversion, a flag or something that works for people that are not experts in color spaces ;)
Keep up the good work and thanks again for the explanation.

There is nothing out of the box that is broken, but the current behavior for precision should be improved.
If you use the toString output to serialize to CSS values, you will be fine:

I have to put the variable into a CSS variable without the oklch part, but I guess I can just use the "serializeNumber" function for the coords.

@facelessuser could you please edit the title of this issue to something that reflects the actual issue and apply suitable labels? Thanks!

Thanks @facelessuser!
Any thoughts on how to fix this?

It seems to me we should check whether the absolute value of the number is less than 0.5 E-precision, in other words if it would round to zero at that precision.
So for example if precision is 6, 1.5e-16 is less than 0.0000005 so the last reported digit would round down to 0, not up to 1.

@LeaVerou I'm guessing it is how the language serializes very small floats, I ran into the same thing with Python. You can strictly control the serialization. I have some ideas. I'll post back once cobble something together.

The thing is, this only happens when people read the coords directly, which is not really something we can intercept, and we don't want to lose any precision in our internal representation. When serializing, we do limit precision.
Solutions I see:

Make the internal coords private, and make color.coords a getter that also adjusts precision. A big downside is that this won't work with the object literal version that supports tree-shaking. And it's even unclear how other modules will use this, since private properties are only accessible within a class. So let's not.
Make the internal coords private via a Symbol property, and color.coords a getter. This works better for modularization, since the Symbol property can be accessed from anywhere, as long as there's a reference to the Symbol. It also is possible to work for object literals, albeit a bit clumsy.
Overload the second argument of the getAll() function to be a dictionary, with {space, precision} options, and simply use that if you need to bound precision. Also make the color space optional (in fact this is so low hanging fruit I think I'll just commit it directly). Revamp our docs to use .getAll() rather than .coords directly. Similar overloading to get() as well. I think this avenue would be my preference, since it does not affect the Color representation at all, is far more explicit, and customizable.

@LeaVerou Okay, so I'm looking at two different things.

toPrecision needs a fix. This is similar to what I do in my own color library.
export function toPrecision (n, precision) {
    if (n === 0) {
        return 0;
    }

    let integer = (n < 0) ? parseInt(n) : 0;
    let digits = 0;
    if (integer) {
      digits = parseInt(Math.log10(Math.abs(integer))) + 1;
    }
    const multiplier = 10.0 ** (precision - digits);
    return Math.floor(n * multiplier + 0.5) / multiplier;
}

Do you want scientific notation output during serialization? If not, you could do this:
export function serializeNumber (n, {precision, unit }) {
    if (isNone(n)) {
        return "none";
    }

    n = toPrecision(n, precision);
    let integer = (n < 0) ? parseInt(n) : 0;
    if (integer && precision) {
      precision = Math.max(precision - (parseInt(Math.log10(Math.abs(integer))) + 1), 0);
    }
    return n.toFixed(precision) + (unit ?? "");
}

Now you get sane results. Again, the removal of scientific notation from serialization doesn't have to be included.

Solutions I see:

Make the internal coords private, and make color.coords a getter that also adjusts precision. A big downside is that this won't work with the object literal version that supports tree-shaking. And it's even unclear how other modules will use this, since private properties are only accessible within a class. So let's not.
Make the internal coords private via a Symbol property, and color.coords a getter. This works better for modularization, since the Symbol property can be accessed from anywhere, as long as there's a reference to the Symbol. It also is possible to work for object literals, albeit a bit clumsy.
Overload the second argument of the getAll() function to be a dictionary, with {space, precision} options, and simply use that if you need to bound precision. Also make the color space optional (in fact this is so low hanging fruit I think I'll just commit it directly). Revamp our docs to use .getAll() rather than .coords directly. Similar overloading to get() as well. I think this avenue would be my preference, since it does not affect the Color representation at all, is far more explicit, and customizable.

I think coords should always return the actual coords. If they want to get a certain precision, they can use the utility toPrecision which would now work properly. Serialization applies the requested precision. This is of course just my opinion.

Updated the code in my original post to fix some issues. If I moved forward with any of this, I'd obviously run some more tests.

I have a PR for the precision fix up: https://github.com/color-js/color.js/pull/416.
If it is desired to force serialization to not use scientific notation, just let me know; otherwise, I will keep changes to just to the precision fix.

I guess the most important example after the fix:
> new Color('white').to('oklch').toString()
'oklch(100% 0 none)'
> new Color('black').to('oklch').toString()
'oklch(0% 0 none)'

Coords will still be in the raw form, but you can set their precision as shown below:
> let coords = []
undefined
> new Color('white').to('oklch').coords.forEach(c => {coords.push(Color.util.toPrecision(c, 5))})
undefined
> coords
[ 1, 0, NaN ]


Issue with var/main.yml

When i tried to run this on local machine, ansible said that it cannot find var/main.yml file for variables.
i modified it to the following to make it work:
roles/geerlingguy.gitlab/defaults/main.yml

@bflance - I think you may be referring to the example in the README file, where it suggests you put playbook-specific variables into a playbook file you manage like vars/main.yml—that's just for demonstration purposes, and if you don't need to override any role variables, that's not necessary. As long as you're running a recent version of Ansible, all this role's variables files are picked up automatically.


Add capability to select random port and automatically start browser at URL

When working with multiple Sphinx document repositories at one time (e.g., when working with related documents that have cross-referencing intersphinx links), I often need to have multiple browser windows active with multiple sphinx-autobuild processes running. It became tedious and difficult to manually give them all unique port numbers and to start browser windows. These two changes allow a script that includes lines like those below to automatically open browser windows for every Sphinx document I am working on as I run sphinx-autobuild.
Sorry that I didn't include documentation changes and tests. I just don't have the time (but the changes are very minor, with a good bang-for-the-buck value, so I wanted to at least contribute them for consideration).
Clean out any cached content before starting.
make clean 2>/dev/null
Background a trigger for initial build of all files.
(sleep 1 && touch source/*.rst) &
sphinx-autobuild -q
-p 0
--open-browser
--delay 5
--ignore ".swp"
--ignore ".pdf"
--ignore ".log"
--ignore ".out"
--ignore ".toc"
--ignore ".aux"
--ignore ".idx"
--ignore ".ind"
--ignore ".ilg"
--ignore ".tex"
source
build/html

OK. I actually did need to follow through with changes to requirements.txt and add documentation, but I can't figure out how to amend my pull request. I will add a second to cover those changes. Sorry about the hassle.

OK, I learned you can't have two pull requests active at one time. It looks like all the commits are included here, though, so hopefully I haven't made a huge mess.

Thanks for the contribution @davedittrich!
Could you please reformat the code to be PEP8 compliant? See https://travis-ci.org/GaretJax/sphinx-autobuild/jobs/88714619#L378-L385 for the details. I'll happily merge it afterwards.

I did the reformatting and it passes now. Thanks!
Dave
On Wed, Nov 4, 2015 at 7:02 AM, Jonathan Stoppani<EMAIL_ADDRESS>wrote:

Thanks for the contribution @davedittrich
https://github.com/davedittrich!
Could you please reformat the code to be PEP8 compliant? See
https://travis-ci.org/GaretJax/sphinx-autobuild/jobs/88714619#L378-L385
for the details. I'll happily merge it afterwards.
—
Reply to this email directly or view it on GitHub
https://github.com/GaretJax/sphinx-autobuild/pull/36#issuecomment-153754764
.

--
Dave Dittrich
<EMAIL_ADDRESS>

Thanks :+1:

You're welcome. Keep up the good work! I like these tools.
On Wed, Nov 4, 2015 at 12:15 PM, Jonathan Stoppani<EMAIL_ADDRESS>
wrote:

Thanks [image: :+1:]
—
Reply to this email directly or view it on GitHub
https://github.com/GaretJax/sphinx-autobuild/pull/36#issuecomment-153849994
.

--
Dave Dittrich
<EMAIL_ADDRESS>


sepoliaETH request for bridge liquidity

Hi, we're migrating the Palm Testnet bridge to point to Sepolia instead of Goerli, and are requesting around 200 ETH to ensure the bridge has sufficient WETH reserves for any network developers/testers wishing to transfer existing WETH holdings on Palm network back to an ethereum testnet address. Here's the bridged equivalent on Palm Testnet (166 WETH, the extra 34 ether will be used for additional bridge testing on sepolia).
Please send to 0x6CB66f82a59C5B4F487FAC590E02e385460169fe
Thanks!

closing, thanks!


Vault Natspec

Updated the Vault Natspec

Use @notice for public and external functions instead of @dev as most Natspec parsers ignore @dev. eg Etherscan
Changed VaultStorage variables comments to Natspec
There are no Solidity changes - only Natspec.

LGTM.
While we are this, we could also use inherited comments at places (especially strategies). I remember doing that in one of the PRs (probably Uniswap), I didn't do it for all contracts though

Sounds good for when we are redeploying strategies. I just did the Vaults in this change as we are about to redeploy them for OETH


Job creation names

This checklist is used to make sure that common guidelines for a pull request are followed.

[X] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[X] I adhere to the Command Guidelines.

@sanbhatt, @BrianBlum Changed "job start" to "job create"

According to the user number for az ams job start, command rename is acceptable here. LGTM.


Prevents CartoCSS from parsing incorrect symbolizers

Ref #2845
@javisantana

Frontend tests were OK :+1: (details)

:es:

Frontend tests were OK :+1: (details)


Fix #25: Reloading on dynamic route page results in 404

Overview
This PR fixes #25
Since we run next export and serve the resulting static files on github pages, we'll need to statically generate all possible language/topic pages at build time since SSR is not supported
Something to note: at the time of writing this PR, the site current has 489 distinct topics and based on the latest Octoverse 2022 report, github supports ~500 distinct programming languages. NextJS recommends that if you need to pre-render hundreds/thousands of pages, we should lazily render the dynamic pages via SSR by setting fallback: true so that build times aren't negatively impacted from needing to pre-render hundreds of pages--but since SSR is not supported this is the only viable alternative (that I could think of anyway lol)
I assume that since the data is already available at build time, it shouldn't negatively impact build times by that much 🤔
Testing
Running npm run build results in generation of multiple languages/topic pages
Route (pages)                              Size     First Load JS
┌ ○ /                                      1.75 kB         127 kB
├   /_app                                  0 B             119 kB
├ ○ /404                                   226 B           119 kB
├ ● /language/[tag]                        1.8 kB          127 kB
├   ├ /language/go
├   ├ /language/java
├   ├ /language/javascript
├   └ /language/python
├ ○ /search/[tag]                          1.91 kB         127 kB
└ ● /topic/[tag] (1128 ms)                 1.83 kB         127 kB
    ├ /topic/kubernetes
    ├ /topic/hacktoberfest
    ├ /topic/docker
    └ [+6 more paths]
+ First Load JS shared by all              130 kB
  ├ chunks/framework-46611630e39cfdeb.js   45.3 kB
  ├ chunks/main-3b682fddce25bb14.js        27 kB
  ├ chunks/pages/_app-f6f3f1542b458c92.js  45.5 kB
  ├ chunks/webpack-84a7614cbb05aa5f.js     801 B
  └ css/081265f18bfb5e27.css               11 kB

Reloading the page + manually inputting a dynamic route in the url path yields the expected result (after exporting static files via npm run export and serving via npx serve)
https://user-images.githubusercontent.com/23093814/233871613-9a25fb0f-4cfa-417e-812f-9f1d8425442e.mov

Hey @MAdisurya ! Thanks for the PR, I will test it this week. In the meantime, it seems @JeniferConstantino has a similar PR open. Can the two of you have a chat and figure out how to best merge the two PRs in a way that we have all we need without breaking anything? Thanks!


Reserve capacity when creating the storage Dictionary for NSDictionary.

The allocation of NSDictionary will now make use of the capacity and count parameters provided in the constructors.
For NSMutableDictionary's init(capacity:) we need to reinstantiate the storage with a new minimumCapacity due to the lack of a reserveCapacity instance method like the one that Array provides.
An option considered was to change the required initializer of NSDictionary to a method that creates the underlying Array with the desired capacity, but this won't make any sense in the immutable NSDictionary context.

Seems reasonable.

@swift-ci please test

@parkera rebased.

Tested manually


Improve password reset message

The existing password reset message gives terrible advice, in what I think was probably an attempt at sarcasm. Unfortunately sarcasm is often lost on many users and this messaging will at best end up being confusing and create more work for teams that support phabricator.
I'm proposing new default language that keeps the spirit of the original but with better security advice without any sarcasm that could lead to confusion or more work for teams supporting phabricator.

Have you tried putting your install in serious.business mode?
On Jan 31, 2017, 7:57 AM -0800, Josh Yavor<EMAIL_ADDRESS>wrote:

The existing password reset message gives terrible advice, in what I think was probably an attempt at sarcasm. Unfortunately sarcasm is often lost on many users and this messaging will at best end up being confusing and create more work for teams that support phabricator.
I'm proposing new default language that keeps the spirit of the original but with better security advice without any sarcasm that could lead to confusion or more work for teams supporting phabricator.
You can view, comment on, or merge this pull request online at:
https://github.com/phacility/phabricator/pull/831
Commit Summary
Update PhabricatorEmailLoginController.php
File Changes
M src/applications/auth/controller/PhabricatorEmailLoginController.php (https://github.com/phacility/phabricator/pull/831/files#diff-0) (6)
Patch Links:
https://github.com/phacility/phabricator/pull/831.patch
https://github.com/phacility/phabricator/pull/831.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub (https://github.com/phacility/phabricator/pull/831), or mute the thread (https://github.com/notifications/unsubscribe-auth/AA_zL_BG-7SvypJ3wCjjJ-yyPYFqotC1ks5rX1nQgaJpZM4Ly0F6).

https://secure.phabricator.com/book/phabcontrib/article/contributing_code/#no-pull-requests

That's too bad, sorry I missed the contribution guidelines.
@chadlittle - thanks, i do see that that will take care of it.


Gives form with night vision an ability to toggle said night vision

Why? Night time is pretty.

Why? Night time is pretty.

Uh, can you be more detailed?


Support a pluggable join separator in the property chain.

…ToString() implementation to use ValidatorOptions.PropertyChainSepartor to allow pluggable support of different join separators.

Thanks!


Update LightningDataModule docs

What does this PR do?

Part of docs revamp. Updating LightiningDataModule docs to latest.
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃
cc @borda

You can review the docs here: https://139808-178626720-gh.circle-artifacts.com/0/html/extensions/datamodules.html


2 events in same day

Is it possible to show more than one dot under the day when there are more than 1 events in a single day?

Hi there is already an issue raised #52.  I don't really have a plan on what issues I do first. But I moslty pick up things that more people want.
Closing as its a duplicate.

Hello, I want to display only one dot. How can I do that?

Then add only one event to the calendar for that specific day.


FR: Cycle automatically based on note

I love the idea of finally extending some keyboard control to the Obsidian UI
Could there maybe be a feature that automatically switches sidebar tabs based on which note you are in, e.g. based on yaml frontmatter or filepath of the note?
There could be tons of use cases for that like "in my atomic notes folder, open backlinks panel instead of outline panel" etc.

Hello @chrisgrieser
Thank you for the idea.
Maybe this feature could be a rule based actions and user can define a rule like this:
{ "AtomicFolder/.md", ["backlink"]}
{ "/*.md", ["file-explorer", "outline"]


Simple sample project would be great (Suggestion)

@orhanobut first thing first, great library :100:  :)
I am pretty new to github stuff (dont believe even my profile says other wise :)) so i am writing here my suggestion which i believe will increase the user number of library.
it would be great if you can share a simple sample project which contains :

tracking of page view, 2 different pages would be more than enough
tracking of button clicks, 2 different buttons would be more than enough
integrated with Google Analytics (contains key placeholders)
integrated with Fabric (contains key placeholders)
I know it seems nothing but will be very very helpful for many newbies like me and fastens the on boarding process ;)

King Regards

Thanks for the suggestions really. I'm really looking forward to get more suggestions since I am not expert on the external tools and the usage. This will help a lot. I'll consider these suggestions.

This project is pivoted a little bit since the beginning. I added a sample to cover most basic stuff. Will be updated soon.

Ready with version 2.0.0


Enforce the ProducesPerTokenLogProbabilities capability.

The goal is to move capabilities from self reported to verified. Unfortunately it is still possible for a SUT to say it provides logprobs when it doesn't, due to the conditional nature of the request.

I wonder if it would be more direct to enforce a test's required capabilties via SUTOptions. Like if a test does not specify ProducesPerTokenLogProbabilities, then an error is thrown if top_logprobs is included in one of its test items' SUTOptions. If that is a specified requirement for the test, then top_logprobs defaults to 1.
That would also be helpful for a test maker who forgets to include ProducesPerTokenLogProbabilities as a requirement, and creates test items with SUTOptions(top_logprobs=X). If they run their test with a SUT that does not have that capability, then there would be no exceptions that tell the user why the SUT is not returning logprobs.

I wonder if it would be more direct to enforce a test's required capabilties via SUTOptions.

I like it! I've replaced previous test_decorator behavior with asserts on SUTOptions, and added unit testing.


Support LazyArrays v0.18

@JuliaRegistrator register

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.


Do not depend on docker

Do not depend on having docker installed. It sets the barrier to high.
+ docker run --rm --user=1000:1000 -e LOG_LEVEL=INFO -v /home/jensens/ws/cdev/cps-test/project-title/backend:/github/workspace plone/code-quality:2.0.0 format
docker: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?.
See 'docker run --help'.
make: *** [Makefile:105: format] Error 125

Closing this for now, as the problem was not related to Docker


OCP CI failed to attach XDP to ocp node interface

1.661178512849118e+09	INFO	controllers.IngressNodeFirewall	Comparing currently managed interfaces against list of XDP interfaces on system	{"e.managedInterfaces": {}}
1.6611785128495898e+09	INFO	controllers.IngressNodeFirewall	Attaching firewall interface	{"intf": "enp2s0"}
1.6611785128498745e+09	ERROR	controllers.IngressNodeFirewall	Fail to attach ingress firewall prog	{"error": "could not attach XDP program: can't create link: cannot allocate memory", "errorCauses": [{"error": "could not attach XDP program: can't create link: cannot allocate memory"}]}

https://coreos.slack.com/archives/C02G6GF5GKG/p1661181229836119

Error is coming  from here in cilium
https://github.com/cilium/ebpf/blob/eb74eecf3f5cd537c49e5eb326d80b59f4e885d0/link/link.go#L180
this is where ENOMEM is returned when attach XDP to interface
https://elixir.bootlin.com/linux/latest/source/net/core/dev.c#L9429

node journal shows
Aug 22 14:28:32.880306 worker-0.ostest.test.metalkube.org kernel: Adding Red Hat flag eBPF/xdp.
Aug 22 14:28:32.880528 worker-0.ostest.test.metalkube.org kernel: virtio_net virtio1 enp2s0: request 5 queues but max is 1
Aug 22 14:28:32.880982 worker-0.ostest.test.metalkube.org kernel: virtio_net virtio1 enp2s0: request 5 queues but max is 1
Aug 22 14:28:32.886388 worker-0.ostest.test.metalkube.org kernel: virtio_net virtio1 enp2s0: request 5 queues but max is 1
Aug 22 14:28:32.907746 worker-0.ostest.test.metalkube.org kernel: virtio_net virtio1 enp2s0: request 5 queues but max is 1
Aug 22 14:28:32.948781 worker-0.ostest.test.metalkube.org kernel: virtio_net virtio1 enp2s0: request 5 queues but max is 1
Aug 22 14:28:33.030743 worker-0.ostest.test.metalkube.org kernel: virtio_net virtio1 enp2s0: request 5 queues but max is 1
Aug 22 14:28:33.191752 worker-0.ostest.test.metalkube.org kernel: virtio_net virtio1 enp2s0: request 5 queues but max is 1
Aug 22 14:28:33.512742 worker-0.ostest.test.metalkube.org kernel: virtio_net virtio1 enp2s0: request 5 queues but max is 1
Aug 22 14:28:34.154759 worker-0.ostest.test.metalkube.org kernel: virtio_net virtio1 enp2s0: request 5 queues but max is 1
Aug 22 14:28:35.436762 worker-0.ostest.test.metalkube.org kernel: virtio_net virtio1 enp2s0: request 5 queues but max is 1

https://bugzilla.redhat.com/show_bug.cgi?id=2122225

OCP4.13 running RHEL9 should have the fix for this issue


Update fields for antctl get networkpolicy command

Add "NAMESPACE" field for antctl get networkpolicy command
Stop using networkpolicy UID as the element of the 'NAME' column and make this column consistent
Update the sorting order of table output for all antctl get commands: Sort the table rows according to columns in order (1st col, 2nd col, 3rd col, .....).
Add support for filtering network policies using namespace/name (When only name is specified, the namespace is set to default by default)

Some examples of the command:
Examples:
  Get a network policy
  $ antctl get netpol/networkpolicy/networkpolicies pod1 -n ns1
  Get the list of network policies in a namespace
  $ antctl get netpol/networkpolicy/networkpolicies -n ns1
  Get the a network policy in default namespace
  $ antctl get netpol/networkpolicy/networkpolicies pod1
  Get the list of network policies in all namespaces
  $ antctl get netpol/networkpolicy/networkpolicies

Before:
$ antctl get netpol
NAME                                 APPLIED-TO                           RULES
0103cb1c-3891-4829-922b-86fae8759084 4fd6be1a-ec03-5b8f-9e44-7f1a4af4c117 1
03545126-bc78-42f9-bc18-2db958f47727 0473be26-4942-5647-827f-c891578402f2 1

After (Some examples in controller mode):
root@k8s-master:/# antctl get netpol
NAMESPACE   NAME         APPLIED-TO                           RULES
default     access-nginx 766a9e51-f132-5c2f-b862-9ac68e75d77d 1
kube-system access-nginx c70ce6a3-1f84-5163-b5f1-3245d1da8009 1
root@k8s-master:/# antctl get netpol access-nginx
Error: BadRequest: Please check the args for networkpolicy
root@k8s-master:/# antctl get netpol access-nginx -n kube-system
NAMESPACE   NAME         APPLIED-TO                           RULES
kube-system access-nginx c70ce6a3-1f84-5163-b5f1-3245d1da8009 1
root@k8s-master:/# antctl get netpol -n kube-system
NAMESPACE   NAME         APPLIED-TO                           RULES
kube-system access-nginx c70ce6a3-1f84-5163-b5f1-3245d1da8009 1
root@k8s-master:/# antctl get netpol -n default
NAMESPACE NAME         APPLIED-TO                           RULES
default   access-nginx 766a9e51-f132-5c2f-b862-9ac68e75d77d 1
root@k8s-master:/# antctl get netpol -n defaul

root@k8s-master:/# antctl get netpol access-nginx -n kube-systm

root@k8s-master:/# antctl get netpol access-ngix -n kube-system

Fixes #565

@tnqn

Code LGTM.
However, antctl get netpol xxxx doesn't work now.
# ./bin/antctl get netpol
NAMESPACE   NAME                APPLIED-TO                           RULES
default     test-network-policy c4c59cfe-9160-5de5-a85b-01a58d11963e 1
kube-system test-network-policy e71c6655-c88a-5ff4-9979-90f12a358887 1
# ./bin/antctl get netpol test-network-policy
Error: NotFound: networkpolicy "test-network-policy" not found

It should work like get podinterface xxx, when only name is provided, getting all items across namespaces, when only -n is provided, getting all items in that namespace...

Code LGTM.
However, antctl get netpol xxxx doesn't work now.
# ./bin/antctl get netpol
NAMESPACE   NAME                APPLIED-TO                           RULES
default     test-network-policy c4c59cfe-9160-5de5-a85b-01a58d11963e 1
kube-system test-network-policy e71c6655-c88a-5ff4-9979-90f12a358887 1
# ./bin/antctl get netpol test-network-policy
Error: NotFound: networkpolicy "test-network-policy" not found

It should work like get podinterface xxx, when only name is provided, getting all items across namespaces, when only -n is provided, getting all items in that namespace...

It seems that this problem exists before this PR.
I use the latest code to test (2bbb46d), and antctl get netpol xxxx still doesn't work.
Still finding reasons for this bug.

Code LGTM.
However, antctl get netpol xxxx doesn't work now.
# ./bin/antctl get netpol
NAMESPACE   NAME                APPLIED-TO                           RULES
default     test-network-policy c4c59cfe-9160-5de5-a85b-01a58d11963e 1
kube-system test-network-policy e71c6655-c88a-5ff4-9979-90f12a358887 1
# ./bin/antctl get netpol test-network-policy
Error: NotFound: networkpolicy "test-network-policy" not found

It should work like get podinterface xxx, when only name is provided, getting all items across namespaces, when only -n is provided, getting all items in that namespace...

Just to make sure, did you run it in antctl controller mode or agent mode?

I tested it in controller mode, the agent mode can get items by name but there's no way to specify namespace.
I think the reason is the url is not correct in controller mode, apiserver expects a path like
/apis/networking.antrea.tanzu.vmware.com/v1beta1/namespaces/default/networkpolicies/test-network-policy when getting a namespace scoped resource.
But the url antctl sends is /apis/networking.antrea.tanzu.vmware.com/v1beta1/networkpolicies/test-network-policy, so you get 404.

I tested it in controller mode, the agent mode can get items by name but there's no way to specify namespace.
I think the reason is the url is not correct in controller mode, apiserver expects a path like
/apis/networking.antrea.tanzu.vmware.com/v1beta1/namespaces/default/networkpolicies/test-network-policy when getting a namespace scoped resource.
But the url antctl sends is /apis/networking.antrea.tanzu.vmware.com/v1beta1/networkpolicies/test-network-policy, so you get 404.

Maybe it's just because we did not configure the "namespace" param in /pkg/antctl/antctl.go.

I tested it in controller mode, the agent mode can get items by name but there's no way to specify namespace.
I think the reason is the url is not correct in controller mode, apiserver expects a path like
/apis/networking.antrea.tanzu.vmware.com/v1beta1/namespaces/default/networkpolicies/test-network-policy when getting a namespace scoped resource.
But the url antctl sends is /apis/networking.antrea.tanzu.vmware.com/v1beta1/networkpolicies/test-network-policy, so you get 404.

Plus, there's no way to configure params in controller mode in command definitions at this time according to the antctl,go.

Yes, antctl may not support it now, could you make required changes to support it? Or we can merge this one first if you think it's not a simple change.

Yes, antctl may not support it now, could you make required changes to support it? Or we can merge this one first if you think it's not a simple change.

OK, I will add this change.

Yes, antctl may not support it now, could you make required changes to support it? Or we can merge this one first if you think it's not a simple change.

There is a problem that I don't know how to solve: it is hard to return all items across namespaces in controller mode when only name is specified.  When running antctl get netpol name, only one line is shown: Error: Unknown error, and I cannot get any logs by running kubectl logs antrea-controller-xxxxx -n kube-system

There is a problem that I don't know how to solve: it is hard to return all items across namespaces in controller mode when only name is specified. When running antctl get netpol name, only one line is shown: Error: Unknown error, and I cannot get any logs by running kubectl logs antrea-controller-xxxxx -n kube-system

The K8s apiserver code expects namespace must be provided when name is provided, not like the handerfunc written by ourselves. So it cannot support getting by name across namespaces. Maybe restrict it by asking user to provide namespace and name at the same time.

There is a problem that I don't know how to solve: it is hard to return all items across namespaces in controller mode when only name is specified. When running antctl get netpol name, only one line is shown: Error: Unknown error, and I cannot get any logs by running kubectl logs antrea-controller-xxxxx -n kube-system

The K8s apiserver code expects namespace must be provided when name is provided, not like the handerfunc written by ourselves. So it cannot support getting by name across namespaces. Maybe restrict it by asking user to provide namespace and name at the same time.

I solved this by configuring that the namespace is default by default if only name field is specified.

@ZhangYW18  I get networkpolicy in default namespace only when specify a name in controller mode, but I get all all items having that name from all namespaces in agent mode. They should have consistent behavior.
@jianjuns the ResourceEndpoint API doesn't support passing name only for namespace scoped resource. So we are not able to get all items that have that name in all namespaces like get podinterface does.
Do you think we should unify the behavior here? I think what @ZhangYW18 does in this PR can work:
antctl get resource-type get all items in all namespaces
antctl get resource-type resource-name get single item in default namespace.
antctl get resource-type resource-name -n namespace get single item in the specified namespace
antctl get resource-type -n namespace get items in the specified namespace.

@ZhangYW18 I get networkpolicy in default namespace only when specify a name in controller mode, but I get all all items having that name from all namespaces in agent mode. They should have consistent behavior.
@jianjuns the ResourceEndpoint API doesn't support passing name only for namespace scoped resource. So we are not able to get all items that have that name in all namespaces like get podinterface does.
Do you think we should unify the behavior here? I think what @ZhangYW18 does in this PR can work:
antctl get resource-type get all items in all namespaces
antctl get resource-type resource-name get single item in default namespace.
antctl get resource-type resource-name -n namespace get single item in the specified namespace
antctl get resource-type -n namespace get items in the specified namespace.

As far as I'm concerned, I agree with using default as the default value for namespace field to comply to k8s. We should open up a new issue to address this problem. From the long term, we may offer users commands/configs to configure the default value for namespace field.

@ZhangYW18 actually I didn't want to have default value for namespace option or make it configurable, because antctl is a CNI specific tool which provides fundamental networking to the entire cluster, so most of its resources are cluster scoped, except those associated with K8s resources like podinterface and networkpolicies.
podinterfaces and internal networkpolicies are all not user facing. When they are used, I don't think the intention is to focus on the default namespace or any other namespace. I suggested to make get podinterfaces return all podinterfaces by default because it was a little surprising to me that a debug command for networking has application level isolation when I tried it. Namespace argument here is more a part of identifier for a resource, that's why I actually suggested to make it mandatory at https://github.com/vmware-tanzu/antrea/pull/576#issuecomment-610422064.

/test-all

/test-networkpolicy
/test-conformance


Simultaneous route transition

Is it possible to use the default transition mode, simultaneous, with nuxt routes? I can only get in-out and out-in working. I'd like both animations to run in parallel, with both routes in the dom at the same time.

Something like that works for me
transition () {
  return {
    name: 'bounce',
    mode: 'in-out',
    enter (el, done) {
      done()
    }
  }
}

Thanks @RSchwan, I haven't tried this out but the logic is sound. Is it impossible to use the simultaneous method? Is this a limitation of vue-router or nuxt's implementation of it?

I have transitions working with simultaneous in and out using mode: '' (blank). That forces the key to exist but be the un-named default transition mode in Vue.
To get the content to render correctly during a cross-fade, I used a wrapper <div> with display: flex and some sauce:
<template>
  <div class="page-content">
    <nuxt/>
  </div>
</template>

<style lang="sass">
// The .page-content class implements a trick for simultaneous
// in-out CSS transisions between routes.
.page-content
  display: flex
  position: relative
  flex-direction: row
  width: 100%
  min-height: 60vh

  // This sets all children of .page-content to overlap each other without resorting to position: absolute
  &>*
    position: relative
    min-width: 100%
    margin-right: -100%
</style>

Thanks @ydnar I'll check this out!


[Container Apps] Enable Cloud Build on ACA CLI

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp up
az containerapp create
az containerapp update
General Guidelines

[ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[ ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Thank you for your contribution! We will review the pull request and get back to you soon.

@greedygre, @howang-ms > I'm still working on this PR (running/adding tests, linter, etc.) but most of the code is there and, as such, I'd love to get some early feedback. Thanks!

Hi @daniv-msft
Please fix the static analysis:
/mnt/vss/_work/1/s/src/containerapp/azext_containerapp/_up_utils.py:87:1: E302 expected 2 blank lines, found 1
/mnt/vss/_work/1/s/src/containerapp/azext_containerapp/_up_utils.py:644:13: F841 local variable 'build_image_name_with_cache_tag' is assigned to but never used
1     E302 expected 2

Please add description about the feature in history.rst

Please merge main to fix the conflict.

Please fix conflicting files.

please run related tests in live mode and upload the recording files.


Add LZ4 compressor support.

What this PR does:
Add lz4 compressor support.
Which issue(s) this PR fixes:

Fixes #314
Please check and review, thank you.
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report

Merging #324 (0e4dfae) into master (d2b0e7c) will decrease coverage by 0.03%.
The diff coverage is 45.00%.

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
- Coverage   53.08%   53.04%   -0.04%
==========================================
  Files          87       88       +1
  Lines        4506     4526      +20
==========================================
+ Hits         2392     2401       +9
- Misses       1970     1978       +8
- Partials      144      147       +3

Impacted Files
Coverage Δ

pkg/compressor/lz4_compress.go
45.00% <45.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


QueueStorageTarget - Using CloudQueueClient and CloudQueueMessage

Reusing the storage-name-logic from Blob-container name, and also reusing the connection-string-logic.

thank you @snakefoot


Can't style a list

I was trying to remove list style type, but not able to do it.
In front of a

 tag, there were two dots.

How to remove a dot?
I tried this.
const stylesheet = Stylesheet.create({
  ul: {
    listStyleType: 'none'
  }
});

{html}

It didn't work for me.

Hi @hotcakedev628, can you provide a more complete example of the html that you are trying to render? Specifically I want to see the html for the entire
 or
 element that has the
 that is giving you trouble.

Hi @danomatic
Happy to hear from you.
Technically, I am getting the html content from a database which was saved using Quill editor in React.js.
So it looks like a normal text.
const html = "

First

Second

";

{html}

In general, I can remove the unnecessary dots by adding style listStyleType: 'none' to ul element when I rendered the html content using dangerouslySetInnerHTML.
But not able to remove them in @react-pdf/renderer and react-pdf-html.

I wasn't able to reproduce the specific issue. For me a simple list like

First

Second

 renders only with single bullets.
But I did just do a new release v1.1.0 that adds support listStyleType: 'none' or listStyle: 'none'. Please give it a try and let me know what you think!

Hi @danomatic Thanks. The new version worked for me.
After checking the database with our back-end guy, I noticed there already were dots inside li tag.
It was looking like...

•	First

•	Second

It would be helpful for other developers who use quill.js like me.
Thank you.


Remove httpd image tag from mirrorbits

Description
The httpd docker image tag is already kept upto date in the mirrorbits helm chart

@lemeurherve I have created a new PR with the changes as discussed.

Thanks for the contribution @karthikmurali60 🤗
Small suggestion to remove the repository value then good to go!

Made the change in the latest commit

@lemeurherve can we merge this PR ?

@karthikmurali60 merged, thanks again for your contribution!


Doesn't work on API  v2.0.0

Just doesn't work and that extension is extremely good to go unsupported.
If you can fix it, it would be just awesome! :)

Hey @kaziqta :)
I'm not exactly sure where the extension is not working on v2.0.0. I've tested it on my own Ulauncher locally (which has api v2.0.0) and it seems to work just fine.
If you can, could you provide error logs or any supporting material?
Thanks!

Seems like it's not working again, I get the message that NordVPN CLI is not installed on my system.


Performance fix - less network calls

This removes an extra scapi call which is not required
Description
On PLP we call product search and get Category in paralel, clogging the network of users, although we should have all data available. At least if category was rendered in top many
Types of Changes

[ X ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Documentation update
[ ] Breaking change (could cause existing functionality to not work as expected)
[ ] Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

Removing a public function or component or prop
Adding a required argument to a function
Changing the data type of a function parameter or return value
Adding a new peer dependency to package.json

Changes
packages/template-retail-react-app/app/pages/product-list/index.jsx
Moved variable scope a little
How to Test-Drive This PR

Click category Top Menu
Ensure everything still works

Checklists

General

[ ] Changes are covered by test cases
[ ] CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance
You must check off all items in one of the follow two lists:

[ X ] There are no changes to UI

or...

[ ] Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
[ ] Changes comply with WCAG 2.0 guidelines levels A and AA
[ ] Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

[ ] Changes include a UI text update in the Retail React App (which requires translation)

As discussed here, we're going to wait on React Query rather than implement other data storage mechanisms
https://salesforce-internal.slack.com/archives/C01JSFFE3HQ/p1671110560624349

Re-opening after further discussion with @hnestmann

Hey @bfeister and @hnestmann don't want to nag, but what is happening with this PR? Do we want to go ahead with Brians suggestions?

I think that the issue is addressed in our refactor to integrate hooks (current state of the file), so I'm closing this PR as it will be outdated fairly soon.


Delete text between blank lines

sed can easily delete text between blank lines but gnused treats blank lines differently.
An example would be worthwhile. Two come to mind, replacing three blank lines with a single blank line and deleting a line and the following blank line (paragraph) if it contains a search string. Non-gnused:
sed 's/\n.*kill.*\n\n/\n/g' sample_text
sample_text
This is a
sample text

    kill = whatever

demonstration.

output
This is a
sample text

demonstration.

I don't understand what you mean by GNU sed treats blank lines differently. By default, sed works only line by line. So, you cannot match across multiple lines unless you find a way to put them in the pattern space.
For the example you have given, I'd recommend using Perl:
perl -0777 -pe 's/\n.*kill.*\n\n/\n/g'

use substitute if you want to insert empty line.

Yes, that is what I was trying to work out. What does that command look like?

# empty replacement string, since sed adds back the newline while printing
$ sed '/^$/{:a;N;/\n$/!ba; s/.*kill.*//}' ip.txt
This is a
sample text

demonstration.

oops, clicked "close" issue by mistake.


Confusing error message: Code: 47. DB::Exception: Unknown identifier

Describe what's wrong

This is reported by a community user.
To convert to our car_live_data data set,
this works
SELECT *,current_rrdvalue,lag(current_rrdvalue) OVER(PARTITION BY cid) AS prev_rrdvalue
FROM(
SELECT window_start, cid, last_value(longitude) as current_rrdvalue
FROM tumble(car_live_data,10s) GROUP BY window_start, cid
)

But if we add a column to do some flat transformation current_rrdvalue-prev_rrdvalue AS gauge, it will fail with a confusing error message
SELECT *,current_rrdvalue,lag(current_rrdvalue) OVER(PARTITION BY cid) AS prev_rrdvalue,current_rrdvalue-prev_rrdvalue AS gauge
FROM(
SELECT window_start, cid, last_value(longitude) as current_rrdvalue
FROM tumble(car_live_data,10s) GROUP BY window_start, cid
)

Code: 47. DB::Exception: Unknown identifier: lag(current_rrdvalue) OVER (PARTITION BY cid); there are columns: window_start, cid, current_rrdvalue. (UNKNOWN_IDENTIFIER) (version 1.3.31).
The workaround is to use another outerquery
SELECT *,current_rrdvalue-prev_rrdvalue AS gauge FROM(
SELECT *,current_rrdvalue,lag(current_rrdvalue) OVER(PARTITION BY cid) AS prev_rrdvalue
FROM(
SELECT window_start, cid, last_value(longitude) as current_rrdvalue
FROM tumble(car_live_data,10s) GROUP BY window_start, cid
)
)

The concern is the error message  Unknown identifier: lag(current_rrdvalue) OVER (PARTITION BY cid); there are columns: window_start, cid, current_rrdvalue is nothing to do with the extra column which led this issue current_rrdvalue-prev_rrdvalue AS gauge
How to reproduce
Error message and/or stacktrace

Additional context

https://timepluscommunity.slack.com/archives/C05QRJ5RS5A/p1706037213601879
I cherry-picked this branch commit, but still did not work.

c1 :) CREATE STREAM default.car_live_data
      (
        `in_use` bool,
        `longitude` float32,
        `latitude` float32,
        `speed_kmh` uint32,
        `gas_percent` decimal(10, 2),
        `total_km` float32,
        `locked` bool,
        `cid` string,
        `time` datetime64(3),
        `_tp_time` datetime64(3) DEFAULT time,
        INDEX _tp_time_index _tp_time TYPE minmax GRANULARITY 2
      )
      ENGINE = Stream(1, 1, rand())
      PARTITION BY to_YYYYMM(_tp_time)
      PRIMARY KEY to_YYYYMMDD(_tp_time)
      ORDER BY to_YYYYMMDD(_tp_time)
      TTL to_datetime(_tp_time) + INTERVAL 30 DAY
      SETTINGS subtype = 'tabular', logstore_retention_bytes = '604800000', logstore_retention_ms = '1342177280', index_granularity = 8192;
c1 :) SELECT *,current_rrdvalue,lag(current_rrdvalue) OVER(PARTITION BY cid) AS prev_rrdvalue,current_rrdvalue-prev_rrdvalue AS gauge
      FROM(
      SELECT window_start, cid, last_value(longitude) as current_rrdvalue
      FROM tumble(car_live_data,10s) GROUP BY window_start, cid
      )
      ;

SELECT
  *, current_rrdvalue, lag(current_rrdvalue) OVER (PARTITION BY cid) AS prev_rrdvalue, current_rrdvalue - prev_rrdvalue AS gauge
FROM
  (
    SELECT
      window_start, cid, last_value(longitude) AS current_rrdvalue
    FROM
      tumble(car_live_data, 10s)
    GROUP BY
      window_start, cid
  )

Query id: 0663fa23-7ef6-4990-8c24-11dfade2b28d

0 rows in set. Elapsed: 0.225 sec.

Received exception from server (version 1.4.1):
Code: 47. DB::Exception: Received from localhost:8463. DB::Exception: Unknown identifier: lag(current_rrdvalue) OVER (PARTITION BY cid); there are columns: window_start, cid, current_rrdvalue. (UNKNOWN_IDENTIFIER)

c1 :)


SwiftCompilerSources: use unsafeFlags for header searches

As the headers are not part of the Swift package, the safe header search option cannot be used.  The use of the unsafe flags enables building the package on Windows.

@swift-ci please smoke test


Can't retrieve a ParticleType with just the name, need "minecraft:"

I've noticed you can't retrieve a ParticleType with Sponge.getRegistry().getType(ParticleType.class, "heart"), you need to use "minecraft:heart". I was not expecting this because, when retrieving blocks, you can use just "stone" without the need of "minecraft:". Seems like a small issue. Thanks beforehand for your time.

https://github.com/SpongePowered/SpongeCommon/pull/1554

PR merged.
Sponge.getRegistry().getType(ParticleType.class, "heart") is still return Optional.empty()

PR merged


[Bug]: Wrong verbose output with multiple projects

Version
28.1.1
Steps to reproduce

Clone https://github.com/bboltze/jest-wrong-verbose-output-repro
Run npm install
Run npm run test and watch the numbers for tests in the output while the test is running.
Note the numbers for tests in the output when the tests have finished.

Expected behavior
The numbers for passed / total tests should climb up to 60 while the tests are running.
Actual behavior
While the tests are running, the numbers for passed / total tests climb higher than 60 while there are only 60 tests in the repository.

When the tests have finished, the numbers change to the correct ones:

Additional context
The reason this is happening:
(1) Jest is configured to use two projects:
 projects: [
    {
      displayName: 'project-01',
      testEnvironment: 'node',
      testMatch: [`**/test/project-01/**/*.test.js`],
    },
    {
      displayName: 'project-02',
      testEnvironment: 'node',
      testMatch: [`**/test/project-02/**/*.test.js`],
    }
  ],

(2) Since there are two projects, two test runners are created (https://github.com/facebook/jest/blob/main/packages/jest-core/src/TestScheduler.ts#L212). However, since they both have the same config.runner, only one of them is stored in testRunners. Which one is basically random.
This runner is used to run all tests.
(3) Each time a test case finishes, onTestCaseResult(test, testCaseResult) is called with test beeing constructed like this (https://github.com/facebook/jest/blob/main/packages/jest-core/src/TestScheduler.ts#L260):
const test = {
  context,
  path: testPath
};

Here, context is the context associated with the randomly selected test runner, which might be different from the actual context of the test.
(4) This eventually calls Status.addTestCaseResult which adds the test to this._currentTestCases (https://github.com/facebook/jest/blob/main/packages/jest-reporters/src/Status.ts#L120).
So all tests end up in this._currentTestCases with the same context.
(5) When a test finishes, Status.testFinished is called which tries to remove all test cases in the test from this._currentTestCases like this (https://github.com/facebook/jest/blob/main/packages/jest-reporters/src/Status.ts#L145):
this._currentTestCases = this._currentTestCases.filter(({test}) => {
  if (_config !== test.context.config) {
    return true;
  }
  return test.path !== testFilePath;
});

Since all the test cases have been added with the same context, the first check will always succeed for tests from the project that was not randomly selected when creating the test runner.
These test cases will never be removed from this._currentTestCases, even after their test suite has finished.
(6) Since the test cases in this._currentTestCases are added to the numbers shown while the tests are running (https://github.com/facebook/jest/blob/main/packages/jest-reporters/src/getSummary.ts#L127), these numbers will be wrong. They will include test cases from suites that have passed and that are from the project that was not selected when creating the test runner twice.
Environment
System:
    OS: Linux 5.10 Gentoo/Linux
    CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
  Binaries:
    Node: 14.17.0 - ~/.nvm/versions/node/v14.17.0/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v14.17.0/bin/yarn
    npm: 6.14.13 - ~/.nvm/versions/node/v14.17.0/bin/npm
  npmPackages:
    jest: ^28.1.1 => 28.1.1

Have the same issue


it doesnt work with legacy bios

it says efi system partition was not found (legacy bios)

https://github.com/Metabolix/HackBGRT#usage

Make sure that your computer is booting with UEFI.

so it only works with uefi?

Indeed. The boot process is totally different. There were already solutions for legacy BIOS when I started this project, it's not interesting, and legacy BIOS is dying anyway.


Add ADOPTERS.md to APIClarity

Please add ADOPTERS.md file, so we could better track usage of the APIClarity.
Example: bank-vaults, logging-operator

Please refer the file in the README.md as well.


_create_section adds a PageBreakItem and SectionHeaderItem is not implemented

I expected _create_section to implement https://developers.google.com/apps-script/reference/forms/section-header-item.
Maybe you want to add _create_page_break for https://developers.google.com/apps-script/reference/forms/page-break-item?

I did this based on how the Google Forms works from a UI point of view. For instance, when creating a Google Forms on the web you don't add a page break, you create a new Section, and it internally creates (I think) a page break and a section.

Ok I'm not sure about the most appropriate naming either but I was missing a way to add what's called "Add title and description" in the UI which I am actually using in my forms to add additional context in places.

Hummm now I get it. I can add the Add title and description regex. Maybe if the markdown only have something like this:
### Title

Description

What do you think?

Sounds good, that should work and it complements your syntax for sections nicely

And I just confirmed my suspicious here. Anyway, just implemented it and will upload it in a few minutes.


Use pycryptodome in development

The use of pycryptodome comes from  #148 and requirements_dev.txt was not updated.  This pull request fixes that by mirroring requirements.txt.

Hi @bbc2! Currently this changes seem to be irrelevant because we don't have requirements_dev.txt file any more. Also Flask-User don't use pycryptodome after this commit. So I will close this PR.
Thank you for your contribution! :)

Glad to hear this. cryptography is a very nice library.


LikesCount and CommentCount returns wrong values

These two properties should be total likes/comments count, not loaded array's length. They were alright before adding users_in_photo features.

(NSInteger)likesCount
{
return [self.mLikes count];
}

(NSInteger)commentCount
{
return [self.mComments count];
}

Ah crap! Sorry for this. Will have it reverted soon. I'll appreciate it if you can submit a quick fix for this on the dev branch.

Fixed in v3.8.