failed to get CSI client: driver name secrets-store.csi.k8s.io not found in the list of registered CSI drivers

Followed directions from https://github.com/Azure/secrets-store-csi-driver-provider-azure#usage
Installed fresh today on a new cluster (v1.17.5 via Rancher) with:
helm install csi-secrets-store-provider-azure/csi-secrets-store-provider-azure --generate-name
(also tried:
helm install csi-secrets-store secrets-store-csi-driver/secrets-store-csi-driver
kubectl apply -f https://raw.githubusercontent.com/Azure/secrets-store-csi-driver-provider-azure/master/deployment/provider-azure-installer.yaml
Identical results)
All the pods deploy fine
I created Service Principle and installed as secret as directed
Deployed provider class https://github.com/kubernetes-sigs/secrets-store-csi-driver/blob/master/test/bats/tests/azure_synck8s_v1alpha1_secretproviderclass.yaml
(updated appropriate values)
The applied the example https://github.com/kubernetes-sigs/secrets-store-csi-driver/blob/master/test/bats/tests/nginx-deployment-synck8s-azure.yaml
(nginx as container)
nginx pod stuck on ContainerCreating, reporting
Warning  FailedMount  7s (x7 over 39s)  kubelet, temp2-2   MountVolume.SetUp failed for volume "secrets-store-inline" : kubernetes.io/csi: mounter.SetUpAt failed to get CSI client: driver name secrets-store.csi.k8s.io not found in the list of registered CSI drivers
What did you expect to happen:
Create pod and sync secrets as described by docs
Which access mode did you use to access the Azure Key Vault instance:
Service Principal
Environment:
Add defaults as of 5/14/2020

Secrets Store CSI Driver version: (use the image tag):
Azure Key Vault provider version: (use the image tag):
Kubernetes version: (use kubectl version):
Cluster type: (e.g. AKS, aks-engine, etc):

@travis-sobeck Can you list the csidrivers running on the cluster?
kubectl get csidrivers
kubectl describe csidriver secrets-store.csi.k8s.io

PS C:\Users\travis\Documents\GitHub> kubectl get CSIDriver
NAME                       CREATED AT
secrets-store.csi.k8s.io   2020-05-14T18:24:16Z
PS C:\Users\travis\Documents\GitHub> kubectl describe csidriver secrets-store.csi.k8s.io
Name:         secrets-store.csi.k8s.io
Namespace:
Labels:
Annotations:
API Version:  storage.k8s.io/v1beta1
Kind:         CSIDriver
Metadata:
Creation Timestamp:  2020-05-14T18:24:16Z
Resource Version:    473851
Self Link:           /apis/storage.k8s.io/v1beta1/csidrivers/secrets-store.csi.k8s.io
UID:                 49d8dedd-3502-4830-8aa0-4f591c298fc2
Spec:
Attach Required:    false
Pod Info On Mount:  true
Volume Lifecycle Modes:
Ephemeral
Events:
I'll clean out environment and re-run the helm

install.go:148: [debug] Original chart version: ""
install.go:165: [debug] CHART PATH: C:\Users\travis\AppData\Local\Temp\helm\repository\csi-secrets-store-provider-azure-0.0.6.tgz
client.go:87: [debug] creating 7 resource(s)
NAME: csi-secrets-store-provider-azure-1589487363
LAST DEPLOYED: Thu May 14 15:16:04 2020
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE: None
USER-SUPPLIED VALUES:
{}
COMPUTED VALUES:
image:
pullPolicy: IfNotPresent
repository: mcr.microsoft.com/k8s/csi/secrets-store/provider-azure
tag: 0.0.5
linux:
enabled: true
resources:
limits:
cpu: 50m
memory: 100Mi
requests:
cpu: 50m
memory: 100Mi
secrets-store-csi-driver:
global: {}
install: true
linux:
enabled: true
image:
pullPolicy: Always
repository: docker.io/deislabs/secrets-store-csi
tag: v0.0.10
livenessProbe:
port: 9808
logLevel:
debug: true
rbac:
install: true
windows:
enabled: false
image:
pullPolicy: IfNotPresent
repository: mcr.microsoft.com/k8s/csi/secrets-store/driver
tag: v0.0.10
windows:
enabled: false
resources:
limits:
cpu: 100m
memory: 200Mi
requests:
cpu: 100m
memory: 200Mi
HOOKS:
MANIFEST:
Source: csi-secrets-store-provider-azure/charts/secrets-store-csi-driver/templates/serviceaccount.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
name: secrets-store-csi-driver
namespace: default
labels:
heritage: "Helm"
release: "csi-secrets-store-provider-azure-1589487363"
revision: "1"
chart: "secrets-store-csi-driver"
chartVersion: "0.0.10"
app: secrets-store-csi-driver
Source: csi-secrets-store-provider-azure/charts/secrets-store-csi-driver/templates/secrets-store.csi.x-k8s.io_secretproviderclasses.yaml
apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.2.4
creationTimestamp: null
name: secretproviderclasses.secrets-store.csi.x-k8s.io
spec:
group: secrets-store.csi.x-k8s.io
names:
kind: SecretProviderClass
listKind: SecretProviderClassList
plural: secretproviderclasses
singular: secretproviderclass
scope: Namespaced
validation:
openAPIV3Schema:
description: SecretProviderClass is the Schema for the secretproviderclasses
API
properties:
apiVersion:
description: 'APIVersion defines the versioned schema of this representation
of an object. Servers should convert recognized schemas to the latest
internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#resources'
type: string
kind:
description: 'Kind is a string value representing the REST resource this
object represents. Servers may infer this from the endpoint the client
submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#types-kinds'
type: string
metadata:
type: object
spec:
description: SecretProviderClassSpec defines the desired state of SecretProviderClass
properties:
parameters:
additionalProperties:
type: string
description: Configuration for specific provider
type: object
provider:
description: Configuration for provider name
type: string
secretObjects:
items:
description: SecretObject defines the desired state of synced K8s
secret objects
properties:
data:
items:
description: SecretObjectData defines the desired state of synced
K8s secret object data
properties:
key:
description: data field to populate
type: string
objectName:
description: name of the object to sync
type: string
type: object
type: array
secretName:
description: name of the K8s secret object
type: string
type:
description: type of K8s secret object
type: string
type: object
type: array
type: object
status:
description: SecretProviderClassStatus defines the observed state of SecretProviderClass
properties:
byPod:
items:
description: ByPodStatus defines the state of SecretProviderClass
as seen by an individual controller
properties:
id:
description: id of the pod that wrote the status
type: string
namespace:
description: namespace of the pod that wrote the status
type: string
type: object
type: array
type: object
type: object
version: v1alpha1
versions:

name: v1alpha1
served: true
storage: true
status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []

Source: csi-secrets-store-provider-azure/charts/secrets-store-csi-driver/templates/role.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: secretproviderclasses-role
rules:

apiGroups:

secrets-store.csi.x-k8s.io
resources:
secretproviderclasses
verbs:
get
list
update

apiGroups:

secrets-store.csi.x-k8s.io
resources:
secretproviderclasses/status
verbs:
get
patch
update

apiGroups:

""
resources:
secrets
verbs:
create
delete
get
update

Source: csi-secrets-store-provider-azure/charts/secrets-store-csi-driver/templates/role_binding.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: secretproviderclasses-rolebinding
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: secretproviderclasses-role
subjects:

kind: ServiceAccount
name: secrets-store-csi-driver
namespace: default

Source: csi-secrets-store-provider-azure/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver.yaml
kind: DaemonSet
apiVersion: apps/v1
metadata:
name: csi-secrets-store-provider-azure-1589487363-secrets-store-csi-d
namespace: default
labels:
heritage: "Helm"
release: "csi-secrets-store-provider-azure-1589487363"
revision: "1"
chart: "secrets-store-csi-driver"
chartVersion: "0.0.10"
app: secrets-store-csi-driver
spec:
selector:
matchLabels:
app: secrets-store-csi-driver
template:
metadata:
labels:
heritage: "Helm"
release: "csi-secrets-store-provider-azure-1589487363"
revision: "1"
chart: "secrets-store-csi-driver"
chartVersion: "0.0.10"
app: secrets-store-csi-driver
spec:
nodeSelector:
beta.kubernetes.io/os: linux
serviceAccountName: secrets-store-csi-driver
hostNetwork: true
dnsPolicy: ClusterFirstWithHostNet
containers:
- name: node-driver-registrar
image: quay.io/k8scsi/csi-node-driver-registrar:v1.2.0
args:
- --v=5
- --csi-address=/csi/csi.sock
- --kubelet-registration-path=/var/lib/kubelet/plugins/csi-secrets-store/csi.sock
lifecycle:
preStop:
exec:
command:
[
"/bin/sh",
"-c",
"rm -rf /registration/secrets-store.csi.k8s.io-reg.sock",
]
env:
- name: KUBE_NODE_NAME
valueFrom:
fieldRef:
apiVersion: v1
fieldPath: spec.nodeName
imagePullPolicy: Always
volumeMounts:
- name: plugin-dir
mountPath: /csi
- name: registration-dir
mountPath: /registration
- name: secrets-store
image: "docker.io/deislabs/secrets-store-csi:v0.0.10"
args:
- "--debug=true"
- "--endpoint=$(CSI_ENDPOINT)"
- "--nodeid=$(KUBE_NODE_NAME)"
- "--provider-volume=/etc/kubernetes/secrets-store-csi-providers"
env:
- name: CSI_ENDPOINT
value: unix:///csi/csi.sock
- name: KUBE_NODE_NAME
valueFrom:
fieldRef:
apiVersion: v1
fieldPath: spec.nodeName
imagePullPolicy: Always
securityContext:
privileged: true
ports:
- containerPort: 9808
name: healthz
protocol: TCP
livenessProbe:
failureThreshold: 5
httpGet:
path: /healthz
port: healthz
initialDelaySeconds: 30
timeoutSeconds: 10
periodSeconds: 15
volumeMounts:
- name: plugin-dir
mountPath: /csi
- name: mountpoint-dir
mountPath: /var/lib/kubelet/pods
mountPropagation: Bidirectional
- name: providers-dir
mountPath: /etc/kubernetes/secrets-store-csi-providers
- name: liveness-probe
image: quay.io/k8scsi/livenessprobe:v1.1.0
imagePullPolicy: Always
args:
- --csi-address=/csi/csi.sock
- --probe-timeout=3s
- --health-port=9808
volumeMounts:
- name: plugin-dir
mountPath: /csi
volumes:
- name: mountpoint-dir
hostPath:
path: /var/lib/kubelet/pods
type: DirectoryOrCreate
- name: registration-dir
hostPath:
path: /var/lib/kubelet/plugins_registry/
type: Directory
- name: plugin-dir
hostPath:
path: /var/lib/kubelet/plugins/csi-secrets-store/
type: DirectoryOrCreate
- name: providers-dir
hostPath:
path: /etc/kubernetes/secrets-store-csi-providers
type: DirectoryOrCreate
Source: csi-secrets-store-provider-azure/templates/provider-azure-installer.yaml
apiVersion: apps/v1
kind: DaemonSet
metadata:
name: csi-secrets-store-provider-azure-1589487363
namespace: default
labels:
heritage: "Helm"
release: "csi-secrets-store-provider-azure-1589487363"
revision: "1"
chart: "csi-secrets-store-provider-azure"
chartVersion: "0.0.6"
app: csi-secrets-store-provider-azure
spec:
updateStrategy:
type: RollingUpdate
selector:
matchLabels:
app: csi-secrets-store-provider-azure
template:
metadata:
labels:
heritage: "Helm"
release: "csi-secrets-store-provider-azure-1589487363"
revision: "1"
chart: "csi-secrets-store-provider-azure"
chartVersion: "0.0.6"
app: csi-secrets-store-provider-azure
spec:
containers:
- name: provider-azure-installer
image: "mcr.microsoft.com/k8s/csi/secrets-store/provider-azure:0.0.5"
imagePullPolicy: IfNotPresent
resources:
limits:
cpu: 50m
memory: 100Mi
requests:
cpu: 50m
memory: 100Mi
env:
- name: TARGET_DIR
value: "/etc/kubernetes/secrets-store-csi-providers"
volumeMounts:
- mountPath: "/etc/kubernetes/secrets-store-csi-providers"
name: providervol
volumes:
- name: providervol
hostPath:
path: "/etc/kubernetes/secrets-store-csi-providers"
nodeSelector:
beta.kubernetes.io/os: linux
Source: csi-secrets-store-provider-azure/charts/secrets-store-csi-driver/templates/csidriver.yaml
apiVersion: storage.k8s.io/v1beta1
kind: CSIDriver
metadata:
name: secrets-store.csi.k8s.io
spec:
podInfoOnMount: true
attachRequired: false
Added in Kubernetes 1.16 with default mode of Persistent. Secrets store csi driver needs Ephermeral to be set.
volumeLifecycleModes:

Ephemeral

I have not configured an storageclasses for this cluster yet if that matters

@travis-sobeck Could you check the csi-driver logs?
You can get the driver pods by running -
kubectl get pods -l app=secrets-store-csi-driver

Then view the logs for the pod
kubectl logs <pod name> node-driver-registrar
kubectl logs <pod name> secrets-store

PS C:\Users\travis\Documents\GitHub> kubectl get pods -l app=secrets-store-csi-driver
NAME                                                              READY   STATUS    RESTARTS   AGE
csi-secrets-store-provider-azure-1589487363-secrets-store-jfc5g   3/3     Running   0          20m
csi-secrets-store-provider-azure-1589487363-secrets-store-sxvjm   3/3     Running   0          20m
csi-secrets-store-provider-azure-1589487363-secrets-store-zps45   3/3     Running   0          20m
I0514 20:16:08.320163       1 main.go:110] Version: v1.2.0-0-g6ef000ae
I0514 20:16:08.320373       1 main.go:120] Attempting to open a gRPC connection with: "/csi/csi.sock"
I0514 20:16:08.320488       1 connection.go:151] Connecting to unix:///csi/csi.sock
I0514 20:16:13.580978       1 main.go:127] Calling CSI driver to discover driver name
I0514 20:16:13.580998       1 connection.go:180] GRPC call: /csi.v1.Identity/GetPluginInfo
I0514 20:16:13.581004       1 connection.go:181] GRPC request: {}
I0514 20:16:13.587538       1 connection.go:183] GRPC response: {"name":"secrets-store.csi.k8s.io","vendor_version":"v0.0.10"}
I0514 20:16:13.588102       1 connection.go:184] GRPC error:
I0514 20:16:13.588122       1 main.go:137] CSI driver name: "secrets-store.csi.k8s.io"
I0514 20:16:13.588200       1 node_register.go:58] Starting Registration Server at: /registration/secrets-store.csi.k8s.io-reg.sock
I0514 20:16:13.603986       1 node_register.go:67] Registration Server started at: /registration/secrets-store.csi.k8s.io-reg.sock
{the other 2 look the same]
PS C:\Users\travis\Documents\GitHub> kubectl logs csi-secrets-store-provider-azure-1589487363-secrets-store-zps45 secrets-store
time="2020-05-14T20:16:08Z" level=info msg="Driver: secrets-store.csi.k8s.io "
time="2020-05-14T20:16:08Z" level=info msg="Version: v0.0.10"
time="2020-05-14T20:16:08Z" level=info msg="Provider Volume Path: /etc/kubernetes/secrets-store-csi-providers"
time="2020-05-14T20:16:08Z" level=info msg="Minimum provider versions: "
time="2020-05-14T20:16:08Z" level=info msg="Enabling controller service capability: CREATE_DELETE_VOLUME"
time="2020-05-14T20:16:08Z" level=info msg="Enabling volume access mode: SINGLE_NODE_READER_ONLY"
time="2020-05-14T20:16:08Z" level=info msg="Enabling volume access mode: MULTI_NODE_READER_ONLY"
time="2020-05-14T20:16:08Z" level=info msg="minimum compatible provider versions not specified with --min-provider-version"
time="2020-05-14T20:16:08Z" level=info msg="Listening for connections on address: //csi/csi.sock"
time="2020-05-14T20:16:08Z" level=debug msg="GRPC call: /csi.v1.Identity/GetPluginInfo"
time="2020-05-14T20:16:08Z" level=debug msg="GRPC request: "
time="2020-05-14T20:16:08Z" level=debug msg="Using default GetPluginInfo"
time="2020-05-14T20:16:08Z" level=debug msg="GRPC response: name:"secrets-store.csi.k8s.io" vendor_version:"v0.0.10" "
time="2020-05-14T20:16:09Z" level=debug msg="GRPC call: /csi.v1.Identity/GetPluginInfo"
time="2020-05-14T20:16:09Z" level=debug msg="GRPC request: "
time="2020-05-14T20:16:09Z" level=debug msg="Using default GetPluginInfo"
time="2020-05-14T20:16:09Z" level=debug msg="GRPC response: name:"secrets-store.csi.k8s.io" vendor_version:"v0.0.10" "
time="2020-05-14T20:16:43Z" level=debug msg="GRPC call: /csi.v1.Identity/Probe"
time="2020-05-14T20:16:43Z" level=debug msg="GRPC request: "
time="2020-05-14T20:16:43Z" level=debug msg="GRPC response: ready:<value:true > "
time="2020-05-14T20:16:58Z" level=debug msg="GRPC call: /csi.v1.Identity/Probe"
time="2020-05-14T20:16:58Z" level=debug msg="GRPC request: "
.... [repeats for a while]

@travis-sobeck From the logs you posted for node-driver-registrar, looks like kubelet never finds /registration/secrets-store.csi.k8s.io-reg.sock.
https://github.com/kubernetes-sigs/secrets-store-csi-driver/blob/23eaef9b463bdbe0433549cd65d8dde55ac35776/deploy/secrets-store-csi-driver.yaml#L99-L102
Does your kubelet use the same path?

When I fist tried to get this going I ran into the error "MountVolume.SetUp failed for volume "registration-dir" : hostPath type check failed: /var/lib/kubelet/plugins_registry/ is not a directory"
and the csi driver pods wouldn't start, then I found this https://github.com/rancher/rke/issues/1151
and added the following to the k8s config file
kubelet:       extra_binds:         - "/var/lib/kubelet/plugins_registry:/var/lib/kubelet/plugins_registry"
After that the csi driver pods spun up

does that answer your question?  I'm not a k8s expert quite yet :)

@travis-sobeck can you try this workaround - https://github.com/rancher/rke/issues/1151#issuecomment-466113635
You'll probably need this one too -
        - "/var/lib/kubelet/plugins:/var/lib/kubelet/plugins"

I'll give it a go

I made the change, clear everything out and re-applied. same error
MountVolume.SetUp failed for volume "secrets-store-inline" : kubernetes.io/csi: mounter.SetUpAt failed to get CSI client: driver name secrets-store.csi.k8s.io not found in the list of registered CSI drivers
logs the same too
PS C:\Users\travis\Documents\GitHub> kubectl logs $pns[2] node-driver-registrar
I0514 21:20:13.495206       1 main.go:110] Version: v1.2.0-0-g6ef000ae
I0514 21:20:13.496827       1 main.go:120] Attempting to open a gRPC connection with: "/csi/csi.sock"
I0514 21:20:13.496924       1 connection.go:151] Connecting to unix:///csi/csi.sock
I0514 21:20:14.498178       1 main.go:127] Calling CSI driver to discover driver name
I0514 21:20:14.498470       1 connection.go:180] GRPC call: /csi.v1.Identity/GetPluginInfo
I0514 21:20:14.498569       1 connection.go:181] GRPC request: {}
I0514 21:20:14.501180       1 connection.go:183] GRPC response: {"name":"secrets-store.csi.k8s.io","vendor_version":"v0.0.10"}
I0514 21:20:14.501889       1 connection.go:184] GRPC error:
I0514 21:20:14.501974       1 main.go:137] CSI driver name: "secrets-store.csi.k8s.io"
I0514 21:20:14.502082       1 node_register.go:58] Starting Registration Server at: /registration/secrets-store.csi.k8s.io-reg.sock
I0514 21:20:14.502322       1 node_register.go:67] Registration Server started at: /registration/secrets-store.csi.k8s.io-reg.sock

it gets a response when it asks for plugin info GRPC response: {"name":"secrets-store.csi.k8s.io","vendor_version":"v0.0.10"}
so it knows it exits?
After GRPC error:
it seems to complete Registration Server started at: /registration/secrets-store.csi.k8s.io-reg.sock  is it a timing issue?

@travis-sobeck It never gets a response back because kubelet doesn't recognize the /var/lib/kubelet/plugins or /registration/secrets-store.csi.k8s.io-reg.sock
A successful log looks like this -
I0514 20:30:11.784808       1 node_register.go:67] Registration Server started at: /registration/secrets-store.csi.k8s.io-reg.sock
I0514 20:30:12.728625       1 main.go:77] Received GetInfo call: &InfoRequest{}
I0514 20:30:13.724772       1 main.go:77] Received GetInfo call: &InfoRequest{}
I0514 20:30:13.745770       1 main.go:87] Received NotifyRegistrationStatus call: &RegistrationStatus{PluginRegistered:true,Error:,}

From the logs you posted, the request just hangs because kubelet is probably looking for the socket in a different path.

I know this isn't super amazing to look at, but maybe it has some useful info

@travis-sobeck What is the root-dir that kubelet is using for this cluster? You should be able to hop on any node and run ps aux | grep kubelet.The --root-dir might be configured to a different path.
I believe RKE starts kubelet with a different root dir -
--root-dir=/opt/rke/var/lib/kubelet

--root-dir=/opt/rke/var/lib/kubelet
I saw something about that in another issue with rke but can't find it now

https://github.com/rancher/rke/issues/1585 but not sure if its %100 related

@travis-sobeck Can you edit the daemonset to change all references of /var/lib/kubelet to /opt/rke/var/lib/kubelet in the driver?

sure, I can give that a go

@travis-sobeck Also, please note, changing the will enable mount to work, but the secret creation will still fail. The driver currently only understands /var/lib/kubelet. I've opened an issue to track this change - https://github.com/kubernetes-sigs/secrets-store-csi-driver/issues/206

That worked! Thanks.  Would it be worth adding that as a path option in values.yaml ??
it created the secret just fine, i was able to decode it, got what I expected

@travis-sobeck Yeah, I've opened the issue to track that change. I'll get that added.

Thanks.  Will updating the path negate the need to add those extra binds to the k8s config?
I guess I can roll back and test it.

@travis-sobeck The driver updates the status of SecretProviderClass after successfully creating the secret. It gets the podUID from the mount target path and adds that to the status field. In RKE cluster, as the path starts with /opt/rke/*, it'll update the status with wrong data. I'll get that fixed with PR to allow kubelet path to be configurable.

Just FYI, create secret works because podUID in NodePublishVolume comes from the volume's attribute. Delete secret during unmount will fail as getPodUIDFromTargetPath assumes the root dir.

@ritazh thanks.
For reference to anyone else that finds this, in the end I didn't need to add the extra_binds
I just had to Update the secrets-store-csi-driver.yaml file to replace any reverence to /var/lib/kubelet to /opt/rke/var/lib/kubelet
Then after running

helm install csi-secrets-store-provider-azure/csi-secrets-store-provider-azure --generate-name
kubectl delete daemonset -l app=secrets-store-csi-driver
`kubectl apply -f <path_to_updated_secrets-store-csi-driver.yaml>

The issue aramase submitted above should simplify things.  Not sure about the fix for deleting secret.

@aramase I see your change got added to the "upstream" helm Change
but I don't see the change reflected in the csi-secrets-store-provider-azure helm chart?
Thanks

@travis-sobeck The changes have been merged, but we have not yet cut a release with for the helm charts and driver with the changes included. We'll cut a new release this week and then you should be able to try it out with the official helm charts.

@aramase Sounds good, thanks

@anujgeek The custom kubelet dir is not applicable in your scenario. @travis-sobeck is using a rancher cluster and the kubelet root dir is /opt/rke/var/lib/kubelet for that cluster. For AKS, the kubelet root dir is the default /var/lib/kubelet.

@ritazh thanks.
For reference to anyone else that finds this, in the end I didn't need to add the extra_binds
I just had to Update the secrets-store-csi-driver.yaml file to replace any reverence to /var/lib/kubelet to /opt/rke/var/lib/kubelet
Then after running

helm install csi-secrets-store-provider-azure/csi-secrets-store-provider-azure --generate-name
kubectl delete daemonset -l app=secrets-store-csi-driver
`kubectl apply -f <path_to_updated_secrets-store-csi-driver.yaml>

The issue aramase submitted above should simplify things. Not sure about the fix for deleting secret.

@travis-sobeck Where is the file secrets-store-csi-driver.yaml located. I ssh into the vm and dont see this file.


replaces /deepseek/deepseek-coder model with /deepseek/deepseek-chat

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Support custom hook for HTTP access log

HTTP access log is quick useful for many applications. They will like to provide custom hooks to intercept the request_info after response data is send but before all data structures are gone.  It also needs a way for DecoderFilter or EncoderFilter to create some data objects for the request and pass them to custom access_log hooks.

@RomanDzhabarov can you meet with @qiwzhang offline and come up with a proposal to add back to this issue. As I see it, there are several options:

Use a "tracer" vs. a direct hook in the active stream destructor path.
Add a new extensibility mechanism independent from filters, to add post request hooks.
(Possibly easiest and most straightforward), allow filters to register for a post request hook callback. They would be passed request info, etc. and could make calls. The assumption here is that the hook can not block destruction, but can make an async call for example via AsyncClient.


Sync repo settings with GitHub app

Proposal
We can sync GitHub repo settings with .github/settings.yml using a GitHub App.
This will allow us to keep some settings in sync between all projects, like "Automatically delete head branches".
Proposed first pass on settings:
---
repository:
  delete_branch_on_merge: true
  enable_vulnerability_alerts: true

Other things like branch protection can be added later if we want.

CC @RichiH

I am against this for Prometheus-community. For Prometheus, we would need to review our members listing.

Security Implications
WARNING: Note that this app inherently escalates anyone with push permissions to the admin role, since they can push config settings to the master branch, which will be synced. In a future, we may add restrictions to allow changes to the config file to be merged only by specific people/teams, or those with admin access (via a combination of protected branches, required statuses, and branch restrictions). Until then, use caution when merging PRs and adding collaborators.

Until restrictions are added in this app, one way to preserve admin/push permissions is to utilize the GitHub CodeOwners feature to set one or more administrative users as the code owner of the .github/settings.yml file, and turn on "require code owner review" for the master branch. This does have the side effect of requiring code owner review for the entire branch, but helps preserve permission levels.

It does say that this would escalate all the members to admins.

It does say that this would escalate all the members to admins.

It looks like you can also define the permission level per member like that: https://github.com/coredashio/community/blob/main/.github/settings.yml

Anyone with push access to the file can change parameters that only admins can normally change.

that would be a huge security breach if it's possible to increase your right just by changing the file without having an admin access.

Hello from the bug scrub!
Nothing has been moving here in the last 2.5y. We'll close this, but of course, anyone interested in this and with plans to defend its usage, please re-open/follow-up.


Pilot: Out-of-process platform adapters

As part of the Cloud Foundry (CF) integration work (https://github.com/istio/istio/issues/1371), considerations for availability and scalability have led us to consider introducing a new platform component in CF (working name: copilot) that will serve service discovery data to the (work-in-progress) CF Pilot platform adapter.
Pilot Core <--> CF Platform Adapter   <--- gRPC ---   Copilot  <----> Cloud Foundry APIs (CAPI,Diego)
^----------------------------------^                   ^
         Pilot binary                             separate binary

We're thinking that the in-process CF Platform Adapter will be a relatively thin gRPC client, with the bulk of the data fetching & joining living in Copilot.
In fact, the gRPC protocol could mirror the Golang interfaces that Pilot Core defines for ServiceDiscovery, which are implemented by platform adapters.   That gRPC could become platform agnostic and the CF Platform Adapter might eventually be just a Remote Platform Adapter, with all the platform-specific logic living on the gRPC server.
We're thinking we'll build this out for Cloud Foundry support right now without working too hard to be fully-platform agnostic.  But would be happy to have the interface evolve in that direction long-term.
Thoughts?  Any existing work / design docs on this?

We have similar plans for Mixer grpc adapters. We want to make it a build time decision. You should be able to build it in process or out of process if written in go.
Are you planning to implement copilot in a language other than go ? For availability and scalability we could simply scale Pilot with built in CF adapter. How different is it from that.
I think the operator should see clear benefits of managing yet another component.
Even though for a CF operator one extra component is not much.

This is no different than us talking to service registries today (kube api server, consul, eureka). From that point of view, you really should not be focusing on standardizing the service registry interface as there is no standard. Besides, the service model undergoes changes. Many newly introduced fields can be derived from existing fields.
I suggest you use whatever protocol/data format that is expedient to communicate with your DB backends/api servers in front. Internally in the code, adhere to the service model as other adapters do. This model has served us very well for the last year and we have been able to easily expand from kubernetes to consul to Eureka (and some teams internally at watson have been able to map some bespoke systems into this model without any pain). But please do publish the API exposed by your service registry, just like apis from consul, eureka, etc., so that we can mock and test. If your service registry server happens to be open source and comes with some mock data, its all the more better because it will allow us to test the integration continuously.
p.s. not a fan of name copilot but thats a matter of personal taste. I prefer something like air traffic controller or registrar or CFR (cloud foundry registry)

@mandarjog That's good to know about Mixer.  Long-term we can think about maybe allowing an option between in-process/out-of-process.  As for scaling, yes, we plan to horizontally scale the Pilots.  But then we have to consider the load they put onto the upstream platform API servers.   Suffice to say, we think a new component, scaled independently, is a good plan to start with.
@rshriram These are good points, especially about flexibility in the interfaces and being able to derive new fields from old ones on the client side.  For that reason, I think we'll steer clear of anything that tries to look generic -- and I'll close this issue.
Thanks!


Upgrade API

Include latest describe API changes

Codecov Report

Merging #53 (3933b11) into main (77351fa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   80.76%   80.76%
=======================================
  Files          10       10
  Lines         863      863
=======================================
  Hits          697      697
  Misses        133      133
  Partials       33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77351fa...3933b11. Read the comment docs.


Disable libtiff Win32 I/O

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Resolves #73

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [23]

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I restarted the Travis build and it failed again with some kind of crash ... but Azure is building macOS too, so I think we should be able to remove the Travis build anyway. I need to jog my memory about how to do that.

Can confirm that this fixes #73!

Great, thanks for testing!

Can we use cross-compilation instead of emulation? That should be much much faster.

@xhochy I don't know but we could try. How is that enabled?

Have a look at how osx-arm64 works or how I enabled it in glib in https://github.com/conda-forge/glib-feedstock/pull/83/commits/49a2696a56f2088099d2b22f43dd2bff965095ae

Github didn't want to let me add a code suggestion to that file :(

@xhochy Thanks! Testing in a separate PR.

Hmm, aarch64 didn't work, and I don't really want to go down the rabbit-hole of trying to solve that stuff right now, so I'll merge this PR as-is.


Ability to use the APPLICATIONINSIGHTS_CONNECTION_STRING env variable in the OTel exporter

Fix #42583

API change check
API changes are not detected in this pull request.


Move uproxy-specific icons to uproxy-icons and use them

This adds svg versions of uProxy-specific icons to an iconset,
uproxy-icons.  They can now be referred to anywhere within Polymer using
a core-icon.  This also gives us the ability to have simpler styling of
the icons.

Fixes #1345

:+1:


Does the Linux Builds Have Support for HDR, HDR10 & HDR10+?

I'm wondering if the Linux builds here have support for HDR, HDR10 & HDR10+?
Background on my question here:
https://github.com/GyanD/codexffmpeg/issues/165

I don't know what kind of answer you expect.
What specific libraries would FFmpeg need for that?
If you want to know how to generally work with ffmpeg and hdr material, the ffmpeg-user list would be a better place to ask.


Fix glitches/crashes with high DPI displays

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Works on a pure brew installation of gnuradio. Should be applied to gnuradio as well.


Always print banner before verifyToken

onlineornot checks delete followed this order already.
Previously, the user wouldn't see the banner if they had any errors.

Sorry I missed this @tehtnaz ! Cheers!


Question: logbook dependency

Quick question, why is the logbook used instead of logging? I didn't dig through the codebase much, but it doesn't look like the features of logbook are being used in a way that necessitates using it?

At some point logging was deprecated and logbook was the replacement.  I made the change, but then started using warnings more and kept logging for more informational output.

If you have a compelling reason to change things, I have a deprecation warning that needs to be propagated from the develop to the master branch and am willing to do some additional stylistic fine-tuning.

logging was deprecated? I can't find any information about this with a Google search. It's included in python 3.7 even: https://docs.python.org/3/library/logging.html
Mostly just curious. The most compelling reason to use logging instead of logbook is that users don't need to install another dependency if logging is used, especially if none of the logbook functionality is being used.

I wish I could point you somewhere, but it was a few years ago and I don't remember.  Clearly it didn't happen.
Removing dependencies is a good enough reason for me.  I will put it on the to-do list.

No worries. I am mostly curious because we use logging a lot and if it were deprecated I would want to be moving away from it to something else!

Addressed in new branch, will be out in the next version.


Issues with SST deployment

Describe the bug
I want to deploy the app using SST, I'm running npx sst dev and when I tried to make any /graphql request is returning a 404
To Reproduce
Steps to reproduce the behavior:
I've tried with my src/index.ts
import { app } from '@getcronit/pylon'
import { handle } from "hono/aws-lambda";

export const graphql = {
  Query: {
    hello: () => {
      return 'Hello, world! x2'
    }
  },
  Mutation: {}
}

app.get("/health", (ctx, next) => {
  return new Response("OK!");
});

export const handler = handle(app)
export default app

with SST config
/// <reference path="./.sst/platform/config.d.ts" />

export default $config({
  app(input) {
    return {
      name: "store-backend",
      removal: input?.stage === "production" ? "retain" : "remove",
      home: "aws",
    };
  },
  async run() {
    const hono = new sst.aws.Function("StoreBackend", {
      url: true,
      handler: "src/index.handler",
    });

    return {
      api: hono.url,
    };
  },
});

The app runs well locally but trying to access the /graphql endpoint in the deployed version from SST, the endpoint /health works but trying to make any POST request to /graphql fails
Expected behavior
it should return
{
  "data": {
    "hello": "Hello, world! x2"
  }
}

Screenshots
I changed the URL of the endpoint

Hi @gersongams!
I will take a deeper look into that tomorrow.
Some quick thoughts on this topic:

You need to run npm pylon build. This generates the .pylon/index.js file. This happens automatically in development, but should be defined in your build step.
Instead of referencing the src/index.handler in your SST config, use .pylon/index.js

Please let me know if this works for you.

thank you @schettn !!!! You are the best

Glad it works @gersongams!
I want to include AWS as a Pylon template in the future. Before that I need to do some research because I am not familiar with AWS that much. Don’t even have an account there yet.


Final PPP for Zacchaeus

Codecov Report

Merging #261 (626b592) into master (a42205b) will decrease coverage by 0.58%.
The diff coverage is 12.00%.

@@             Coverage Diff              @@
##             master     #261      +/-   ##
============================================
- Coverage     62.78%   62.19%   -0.59%
  Complexity      713      713
============================================
  Files           129      129
  Lines          2644     2669      +25
  Branches        335      339       +4
============================================
  Hits           1660     1660
- Misses          828      853      +25
  Partials        156      156

Impacted Files
Coverage Δ

src/main/java/seedu/condonery/MainApp.java
0.00% <0.00%> (ø)

src/main/java/seedu/condonery/model/Model.java
100.00% <ø> (ø)

...ava/seedu/condonery/model/util/SampleDataUtil.java
7.50% <0.00%> (+0.35%)
:arrow_up:

.../main/java/seedu/condonery/model/ModelManager.java
77.45% <45.45%> (-3.87%)
:arrow_down:

...va/seedu/condonery/logic/commands/UndoCommand.java
66.66% <100.00%> (+2.38%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


mod_static: use Counter instead of Gauge

use Counter instead of Gauge：

FileBrowseSize
FileBrowseCount
FileBrowseNotExist
FileBrowseContentTypeError

resolve by #202


Added camera info publisher

Added camera_info topic to camera driver.  Takes an additional dependency on camera to handle loading/reading camera calibration parameters from config.

Looks good :) let's wait for the CI to finish before merging

I'm not familiar with all the relevant ROS conventions. Would it be better to publish camera_info once as a latching message, or is there some non-obvious problem with that?


[BUG] ClassNotFoundException: io.opentelemetry.javaagent.instrumentation.opentelemetryapi.context.AgentContextStorage

Describe the bug
Similar to https://github.com/Azure/azure-sdk-for-java/issues/32980 I am facing this issue
java.lang.ClassNotFoundException: io.opentelemetry.javaagent.instrumentation.opentelemetryapi.context.AgentContextStorage
Infra details
Spring boot 2.7.7, Java 11
Azure core 1.38.0
azure-messaging-eventhubs-checkpointstore-blob 1.16.4, azure-messaging-eventhubs  5.15.3
Exception or Stack Trace
23:42:13.934 [pool-12-thread-1] DEBUG i.o.j.i.a.v.s.c.a.c.t.o.i.OpenTelemetrySpanSuppressionHelper - Failed to discover OpenTelemetry agent classes, HTTP spans may be duplicated
java.lang.ClassNotFoundException: io.opentelemetry.javaagent.instrumentation.opentelemetryapi.context.AgentContextStorage
at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:476)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:589)
at org.springframework.boot.loader.LaunchedURLClassLoader.loadClass(LaunchedURLClassLoader.java:151)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
at java.base/java.lang.Class.forName0(Native Method)
at java.base/java.lang.Class.forName(Class.java:315)
at io.opentelemetry.javaagent.instrumentation.azurecore.v1_19.shaded.com.azure.core.tracing.opentelemetry.implementation.OpenTelemetrySpanSuppressionHelper.(OpenTelemetrySpanSuppressionHelper.java:31)
at io.opentelemetry.javaagent.instrumentation.azurecore.v1_19.shaded.com.azure.core.tracing.opentelemetry.OpenTelemetryHttpPolicy$ScalarPropagatingMono.subscribe(OpenTelemetryHttpPolicy.java:241)
at reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:64)
at reactor.core.publisher.MonoFlatMap$FlatMapMain.onNext(MonoFlatMap.java:157)
at io.opentelemetry.javaagent.shaded.instrumentation.reactor.TracingSubscriber.lambda$onNext$1(TracingSubscriber.java:58)
at io.opentelemetry.javaagent.shaded.instrumentation.reactor.TracingSubscriber.withActiveSpan(TracingSubscriber.java:79)
at io.opentelemetry.javaagent.shaded.instrumentation.reactor.TracingSubscriber.onNext(TracingSubscriber.java:58)
at reactor.core.publisher.FluxHide$SuppressFuseableSubscriber.onNext(FluxHide.java:137)
at reactor.core.publisher.Operators$MonoSubscriber.complete(Operators.java:1839)
at reactor.core.publisher.MonoCallable.subscribe(MonoCallable.java:62)
at reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:64)
at reactor.core.publisher.MonoFlatMap$FlatMapMain.onNext(MonoFlatMap.java:157)
at io.opentelemetry.javaagent.shaded.instrumentation.reactor.TracingSubscriber.lambda$onNext$1(TracingSubscriber.java:58)
at io.opentelemetry.javaagent.shaded.instrumentation.reactor.TracingSubscriber.withActiveSpan(TracingSubscriber.java:79)
at io.opentelemetry.javaagent.shaded.instrumentation.reactor.TracingSubscriber.onNext(TracingSubscriber.java:58)
at reactor.core.publisher.FluxHide$SuppressFuseableSubscriber.onNext(FluxHide.java:137)
at reactor.core.publisher.Operators$MonoSubscriber.complete(Operators.java:1839)
at reactor.core.publisher.MonoCallable.subscribe(MonoCallable.java:62)
at reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:64)
at reactor.core.publisher.MonoFlatMap$FlatMapMain.onNext(MonoFlatMap.java:157)
at io.opentelemetry.javaagent.shaded.instrumentation.reactor.TracingSubscriber.lambda$onNext$1(TracingSubscriber.java:58)
at io.opentelemetry.javaagent.shaded.instrumentation.reactor.TracingSubscriber.withActiveSpan(TracingSubscriber.java:79)
at io.opentelemetry.javaagent.shaded.instrumentation.reactor.TracingSubscriber.onNext(TracingSubscriber.java:58)
at reactor.core.publisher.FluxHide$SuppressFuseableSubscriber.onNext(FluxHide.java:137)
at reactor.core.publisher.Operators$MonoSubscriber.complete(Operators.java:1839)
at reactor.core.publisher.MonoCallable.subscribe(MonoCallable.java:62)
at reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:64)
at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:52)
at reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:64)
at reactor.core.publisher.MonoFlatMap$FlatMapMain.onNext(MonoFlatMap.java:157)
at reactor.core.publisher.Operators$ScalarSubscription.request(Operators.java:2400)
at reactor.core.publisher.MonoFlatMap$FlatMapMain.onSubscribe(MonoFlatMap.java:110)
at reactor.core.publisher.MonoJust.subscribe(MonoJust.java:55)
at reactor.core.publisher.Flux.subscribe(Flux.java:8642)
at reactor.core.publisher.FluxExpand$ExpandBreathSubscriber.drainQueue(FluxExpand.java:179)
at reactor.core.publisher.FluxExpand.subscribeOrReturn(FluxExpand.java:71)
at reactor.core.publisher.InternalFluxOperator.subscribe(InternalFluxOperator.java:55)
at reactor.core.publisher.FluxDefer.subscribe(FluxDefer.java:54)
at reactor.core.publisher.InternalFluxOperator.subscribe(InternalFluxOperator.java:62)
at com.azure.core.util.paging.ContinuablePagedFluxCore.subscribe(ContinuablePagedFluxCore.java:244)
at com.azure.core.http.rest.PagedFluxBase.subscribe(PagedFluxBase.java:220)
at reactor.core.publisher.Mono.subscribe(Mono.java:4490)
at reactor.core.publisher.MonoZip.subscribe(MonoZip.java:129)
at reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:64)
at reactor.core.publisher.FluxRepeatPredicate$RepeatPredicateSubscriber.resubscribe(FluxRepeatPredicate.java:120)
at reactor.core.publisher.MonoRepeatPredicate.subscribeOrReturn(MonoRepeatPredicate.java:48)
at reactor.core.publisher.Flux.subscribe(Flux.java:8628)
at reactor.core.publisher.Flux.subscribeWith(Flux.java:8815)
at reactor.core.publisher.Flux.subscribe(Flux.java:8608)
at reactor.core.publisher.Flux.subscribe(Flux.java:8532)
at com.azure.messaging.eventhubs.PartitionBasedLoadBalancer.loadBalance(PartitionBasedLoadBalancer.java:151)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305)
at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:829)
To Reproduce
Code Snippet
Add the code snippet that causes the issue.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Setup (please complete the following information):

OS: [e.g. iOS]
IDE: [e.g. IntelliJ]
Library/Libraries: [e.g. com.azure:azure-core:1.16.0 (groupId:artifactId:version)]
Java version: [e.g. 8]
App Server/Environment: [e.g. Tomcat, WildFly, Azure Function, Apache Spark, Databricks, IDE plugin or anything special]
Frameworks: [e.g. Spring Boot, Micronaut, Quarkus, etc]

If you suspect a dependency version mismatch (e.g. you see NoClassDefFoundError, NoSuchMethodError or similar), please check out Troubleshoot dependency version conflict article first. If it doesn't provide solution for the problem, please provide:

verbose dependency tree (mvn dependency:tree -Dverbose)
exception message, full stack trace, and any available logs

Additional context
Add any other context about the problem here.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[ ] Bug Description Added
[ ] Repro Steps Added
[ ] Setup information Added

@bhupendergiri Thank you for identifying this issue. @anuchandy could you please follow up?

@bhupendergiri this log is recorded with DEBUG severity and does not indicate any particular issue. So it's ok to ignore it.
Also, it seems you're using an oldish version of OpenTelemetry agent, this log record should not appear with a few latest versions of the agent.
Please try updating OpenTelemetry agent to the latest version and feel free to reopen the issue if you still observe this log record.


[Backport] Ensure RabbitMQ WithDataVolume/WithDataBindMount methods actually enable persistent storage

Backport of #3152
Microsoft Reviewers: Open in CodeFlow

/azp run


Fix leading tab in linux install script

When listing the dependencies for Linux installation - there is leading tab on the installed items. As seen here:

This pull requests proposes the following:

Remove all leading tabs from both OS dependencies and pip dependencies.
Adds the header Status  Package  Version to pip dependencies
Refactor installed/missing text coloring with helper functions

Result:

Can one of the admins verify this patch with one of the following commands:

"jenkins test please" for a one time test run
"ok to test" to accept latest and future commits on this pull request for testing
"add to whitelist" to add the author to the whitelist

Thanks for contributing!
ok to test

It seems like the building is failing in Jenkins but its being installed successfully and tests are passing.
14:29:49 pr_stress #467 completed. Result was SUCCESS

Yeah, this test failed due to an internal bug. It should be resolved now.  I'll trigger the test to start again.
Jenkins test please


Web / desktop rendering discrepancies

The water and sky do not render on the web. There may be others, but these are the most immediately obvious. I believe these are just a matter of wiring up the relevant systems and shaders.
Might also be a good chance to fix the texcoord wrapping on the water, now that I think about it.

@philpax see: https://github.com/AmbientRun/Ambient/issues/649 as well
Not all of these are necessary for the launch, but I put all these (somewhat) non-breaking things in an umbrella issue to avoid the fragmentation of 10+ issues floating around and being hard to find. It is something I prefer and helps me focus

Sky is fixed, water is covered in #889


how to train models with multiple gpus in C++

The mx.mod.Module provides a convenient high level api for model training in python. But due to some reasons, I need to train my models in pure C++ environment. I am wondering if it is also possible to support multiple gpu device with the interfaces in cpp-package/include/mxnet-cpp. Currently, I can only find the Executor in cpp-package/include/mxnet-cpp/executor.h which can get a single context variable each time.

@nicklhy
For questions, please submit on MXNet discussion forum (https://discuss.mxnet.io), where it will get a wider audience and allow other to learn as well.
Thanks!

@sandeep-krishnamurthy to close this issue now in favor of the discussion forum issue you will file, please feel free to re-open if closed in error.
Thanks!


Adding Firewall Integration testing

This readds Firewall Integration testing now tha tI've been able to figure out what was causing the previous failures. This also fixes #41 as I modified the changes to match the suggestions made by @PrahlM93 (whom I hope will review the change as well).
@PlagueHO - if you have some time to review this I'd appreciate it.

Good thinking on introducing Integration Testing - should definitely pick up things like issue #41! I'll also use your integration tests as a template and add them to other resources as well when a change is next required. Nicely done. :+1:
I took a look and the code all looks 100% to me.
I know the Group/DisplayGroup stuff is because of the odd behavior of the new-netfirewallrule cmdlet, it doesn't support setting the DisplayGroup, even though set-netfirewallrule does. It would actually be possible to work around this limitation at some point (by firing a new-netfirewallrule then set-netfirewallrule when new rules are created that contain a DisplayGroup). That way both DisplayGroup and Group could be supported and set by the resource and more closely match what actually is stored internally. Right now it is a little bit strange. But I think that should be left for another time.

@PlagueHO I think you are right we should fix up the DisplayGroup/Group. I've created #44 in order for us to get back to this. As I agree we should deal with this seperately.
As for treating this integration test as a template let me get a PR open to actually create a template so we can document the logic I used. Once we land on it we can try to get it put somewhere so the rest of the resources can benefit. :+1:
Thanks for the review.

Good thinking! Might be nice to get other templates in there as well - for example, the header and footer of the unit/pester tests. I've tended to copy the ones you created and they work well in every scenario I've put them through.


Enable image replacement

I think we need this ability, as I talked in this issue: #54
I check the implements in knative-serving operator and implement in tekton.

https://github.com/vincent-pli we setup CI with e2e tests. Could you rebase your branch.

/ok-to-test

@nikhil-thomas @sthaha
Is the e2e failure is a real broken?
Could you take a look at it?

@vincent-pli thank you for your patience. Since #66 has now merged, could you please rebase this patch?

/retest

/retest

/retest

@vincent-pli closing this PR. lets continue this upstream of needed.


Handle content in base interface when nothing is returned

In the event that we have a bulk fetch endpoint, let's say for example /v1/model, and there is nothing returned because there are simply no models.  We should specify how to handle this.
We could return a 204 error as http status code spec suggests, but I actually argue against this for our spec, and simply have it return an empty array with a 200 (this is how we have traditionally handled this).
There might actually be useful information we would want to pass in the body (perhaps an error-detail), and most http clients respect the 204 request and don't pass along any body.

@tmilewski would like to hear your thoughts on this.  I'm pretty confident you're in agreement, but just want to verify.

Do you think there will be relevant error details for a fetch that returns empty data? I think if a 204 is returned, the client side should deal with it accordingly bc most likely the reason why the data is empty should be straight forward enough where the client side shouldn't need further instructions. I'm just scratching the API surface but i would love read everyone's thoughts on everything. I've seen API's that handle it both ways and never really understood why to go one way or the other except for personal preference.


minimising the time (upload zip to training scripts)

Please reduce the waiting time as much as possible

What's the update on this task ?

will be updated by tonight

Let me know when it's done so I can test it

Done merged in #8


Bump version

Bumps the ruby version to 2.4.1 to match view-data.

Do we need to re-deploy the docker image?

I'm not actually sure how any of this works, but it does look like there's a conflict here. It looks as if the docker image is build and pushed in the deploy step (which is run after the tests are run).

I think there may be a CI specific docker image.  Probably not urgent anyway and we can wait for LL.

This is no longer necessary as we're not using docker any more.


CI infrastructure management: costing, visibility, accessibility

How do we handle the CI infrastructure post launch?

Where should the CI infra be hosted
How is the cost handled
How do developers get visibility into the cluster in case of failures
Who is allowed to access the CI cluster

Scope (please mark with X where applicable)

[X] New Functionality
[ ] Install
[ ] SMI Traffic Access Policy
[ ] SMI Traffic Specs Policy
[ ] SMI Traffic Split Policy
[ ] Permissive Traffic Policy
[ ] Ingress
[ ] Egress
[ ] Envoy Control Plane
[ ] CLI Tool
[ ] Metrics
[ ] Certificate Management
[ ] Sidecar Injection
[ ] Logging
[ ] Debugging
[ ] Tests
[X] CI System

CI is running on a local Kind cluster. This issue isn't a problem at the moment.

CI is running on a local Kind cluster. This issue isn't a problem at the moment.


Database failover - closed connections returned from pool

Environment
HikariCP version: 3.2.0
JDK version     : 1.8.0_111
Database        : SQL Server 2017
Driver version  : 7.0.0

We have recently moved to a new SQL Server 2017 Always On Availability Groups cluster. The application is based on Spring 5, Hibernate and HikariCP. Everything is working fine, but when we did failover testing the application logged exceptions when the failover happened. The application recovered shortly afterwards (̃~1 second). I suspect that connections already in the pool were not tested on borrow causing the exception due to closed/reset connection to the database. New requests for connections afterwards apparently connected to the new master correctly.
`
12-Dec-2018 21:51:22.435 SEVERE [https-jsse-nio-443-exec-6] org.apache.catalina.core.StandardWrapperValve.invoke Servlet.service() for servlet [dispatcher] in context with path [] threw exception [Request processing failed; nested exception is org.springframework.transaction.CannotCreateTransactionException: Could not open JPA EntityManager for transaction; nested exception is org.hibernate.TransactionException: JDBC begin transaction failed: ] with root cause
java.net.SocketException: Connection reset
at java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:115)
at java.net.SocketOutputStream.write(SocketOutputStream.java:155)
at com.microsoft.sqlserver.jdbc.TDSChannel.write(IOBuffer.java:1988)
at com.microsoft.sqlserver.jdbc.TDSWriter.flush(IOBuffer.java:4096)
at com.microsoft.sqlserver.jdbc.TDSWriter.writePacket(IOBuffer.java:3998)
at com.microsoft.sqlserver.jdbc.TDSWriter.endMessage(IOBuffer.java:3128)
at com.microsoft.sqlserver.jdbc.TDSCommand.startResponse(IOBuffer.java:7602)
at com.microsoft.sqlserver.jdbc.TDSCommand.startResponse(IOBuffer.java:7590)
at com.microsoft.sqlserver.jdbc.SQLServerConnection$1ConnectionCommand.doExecute(SQLServerConnection.java:2907)
at com.microsoft.sqlserver.jdbc.TDSCommand.execute(IOBuffer.java:7240)
at com.microsoft.sqlserver.jdbc.SQLServerConnection.executeCommand(SQLServerConnection.java:2869)
at com.microsoft.sqlserver.jdbc.SQLServerConnection.connectionCommand(SQLServerConnection.java:2912)
at com.microsoft.sqlserver.jdbc.SQLServerConnection.setAutoCommit(SQLServerConnection.java:3045)
at com.zaxxer.hikari.pool.ProxyConnection.setAutoCommit(ProxyConnection.java:388)
at com.zaxxer.hikari.pool.HikariProxyConnection.setAutoCommit(HikariProxyConnection.java)
at org.hibernate.resource.jdbc.internal.AbstractLogicalConnectionImplementor.begin(AbstractLogicalConnectionImplementor.java:67)
at org.hibernate.resource.jdbc.internal.LogicalConnectionManagedImpl.begin(LogicalConnectionManagedImpl.java:263)
at org.hibernate.resource.transaction.backend.jdbc.internal.JdbcResourceLocalTransactionCoordinatorImpl$TransactionDriverControlImpl.begin(JdbcResourceLocalTransactionCoordinatorImpl.java:236)
at org.hibernate.engine.transaction.internal.TransactionImpl.begin(TransactionImpl.java:80)
at org.springframework.orm.jpa.vendor.HibernateJpaDialect.beginTransaction(HibernateJpaDialect.java:183)
at org.springframework.orm.jpa.JpaTransactionManager.doBegin(JpaTransactionManager.java:401)
at org.springframework.transaction.support.AbstractPlatformTransactionManager.getTransaction(AbstractPlatformTransactionManager.java:378)
at org.springframework.transaction.interceptor.TransactionAspectSupport.createTransactionIfNecessary(TransactionAspectSupport.java:474)
at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:289)
at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:98)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:688)
at xxx.xxx.service.xxxxx.xxxxService$$EnhancerBySpringCGLIB$$d1eb44bc.findByXXXX()
`
According to the documentation it looks like connections should be tested before they are given to the application.
Is there any configuration needed perhaps in order to get the connections tested on borrow?

HikariCP, by default, has a performance optimization such that connections used within the past 500ms are considered valid (as they were just used) — an therefore validation is skipped.  This is called the bypass window.
Users think they want to validate on every borrow, by this has two pitfalls.  First, doing so will absolutely crush your performance, likely cutting it nearly in half; as well as increasing the server load significantly.
Second, it actually doesn’t provide any additional guarantees; it is a classic race condition.  Just as the connection that was valid 500ms before, is not valid now — because the database failed during those 500ms — as soon as a theoretical validation would complete it is possible for the database to fail before the user’s query executes, and encounter a similar error.
Basically, even validating every connection cannot provide guarantees because the database can fail after validation but before query execution.
If you still want to validate every connection, you can set the referenced system property to zero (0).


Please add information on Teams Chat appearing in Timeline in a separate section

please add the following in a separate (configuration) section after
(https://learn.microsoft.com/en-us/dynamics365/sales/teams-integration/enable-teams-chat#set-the-default-name-for-connected-chats)
Timeline display and configuration
Teams Chat activities by default will show in the Timeline,
however Teams chats cannot be created from the Timeline
(in customization on the timeline control, the "Create directly from timeline" can't be set for Teams chat)
as the Timeline control only supports simple record creations on Dataverse,
while here the creation of a Teams chat and a record pointing to its ID is needed)
Creating an embedded chat from the (Sales) App is only offered via its Teams chat pane,
not from the timeline

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e79df50a-98c4-f692-cba0-17c99a814a09
Version Independent ID: e79df50a-98c4-f692-cba0-17c99a814a09
Content: Configure Microsoft Teams chat in Dynamics 365 Sales
Content Source: ce/sales/teams-integration/enable-teams-chat.md
Service: dynamics-365-sales
Sub-service: d365-sales-teams
GitHub Login: @sbmjais
Microsoft Alias: shjais

Thanks for your comment, @CarstenMS. This issue has been assigned to the doc author for review.


steam and rf

please make, that the reactor can output steam and rf at the same time.

It can. With turbines.

i mean rf direct from the reactor and steam at the same time. like the mekanism fusion reactor.

Why

mo power


[RFE] Make reconciler_cron_expression configurable via environment variable

in system with high churn on pod's we do not want to wait until 4:30 AM to run the reconciler, as such the request is to make the reconciler_cron_expression configurable via a environment variable in the daemonset installation doc
it could be something like:
in file : install-cni.sh
replace: "reconciler_cron_expression": "30 4 * * *"
with:  "reconciler_cron_expression": "${WHEREABOUTS_RECONCILER_CRON:-30 4 * * *}"

According to our docs, it seems it is configurable: https://github.com/k8snetworkplumbingwg/whereabouts/blob/master/doc/extended-configuration.md#reconciler-cron-expression-configuration-optional
Having said that, this is a really poor API (... if at all).
IMO, your proposal makes sense. @dougbtv any objections ?
@caribbeantiger would you be open to push a PR with that ?

no problem, i can create the PR @maiqueb

Closed by #317


Use useId for input IDs

That way if I render multiple of the same input field I don't violate HTML :)

Released in 0.4.0 👍

Thanks!


Remove UTF8 encoding/decoding of messagepack strings

The MessagePack spec (https://github.com/msgpack/msgpack/blob/master/spec.md#type-system) specifies that the implementation should give access to the underlying byte array for String types, because the contents may not be valid.
We argue that the library should expose String fields as a ByteString in order to avoid invoking partial functions outside the control of the library user. If the user is confident that the String type will only encode UTF8 in their user case, or are happy to handle the exception, then they can use decodeUtf8 themselves, but they should be given the choice.
Because of the history of the message pack spec (initially did not have a Binary type, Strings were used for arbitrary byte arrays) some encoders never use the Binary type, even when encoding arbitrary byte arrays.

But the spec explicitly says that type string is uff-8 encoded... if it's not, is an message-pack encoding error. so that is always the case that a string should be utf-8 decoded.

Why would it be a msgpack encoding error if contents are not utf-8 encoded? In the spec it's saying that "String objects may contain invalid byte sequence" and "Deserializers should provide functionality to get the original byte array".

Yes, as @osa1 said, we are going by the description in the Limitations section in the spec. It seems that ideally messagepack strings should be utf8 encoded strings, but because of the history of the spec, this is not guaranteed. For example the official messagepack Ruby library will encode raw bytes as a messagepack String.

I see, I understand requirements... I'm trying to think of a solution that supports both: i.e. a way we can have one to have access to byte-strings if he wants to, but allows one to use Strings if he trusts.
A couple of ideas:

Refactor Object type to be polymorphic on the type of the ObjectString constructor.
Add Another constructor ObjectStringRaw and have a option flag somewhere where the user can decide if the decode will produce ObjectStringRaw or ObjectString.
Refactor ObjectString constructor to have two type parameters: the raw bytes and the decoded String... although this seems very inefficient.
Refactor ObjectString to have a Either ByteString String type, so that is Right String if the utf-8 decoding succeeded or Left ByteString if it failed.
(a merge of option 2 and 4) Refactor ObjectString  to have a Either ByteString String  but allow the user to set an option somewhere to decide how it's going to be constructed (as a Left or Right)... I feel this solution is a bit of a misuse of Either` though.

What do you guys think? any idea is good? other ideas? or should we keep with the current PR proposal from @mdpye?

I think that the best solution is to follow the spec as closely as possible.
Personally, just exposing messagepack strings as ByteStrings would be my choice (it would be much cleaner and simple even if it is idealistically seems wrong), but if you want to expose both, then these are my thoughts

To me this sounds the most promising, but I am a bit unclear about how you would specifically do this. It would be nice to see an example.

I'm not such a big fan of this because I think the Haskell type should match the spec as much as possible, and having an extra Constructor goes agains this principal

This is a possibility, but yes, it would be inefficient in terms of size. You could try benchmarking.

In terms of using Either values: the problem I see with this is the whole point in the library doing the utf8 decoding is that it should be more convenient for client programs, but having to deal with Either values would lead to more work in all cases. That's in addition to the issues you already mentioned.

The option would have to be per-field, which might turn out to be a pain
What does the "decoded bytes" side contain if the bytes don't represent UTF8
I'm strongly against this option. Some arbitrary byte strings will be valid UTF8 by chance rather than design.

On 1 and 5 I don't have much of an opinion.
On the whole subject, my opinion is that all the options are more complicated for the user to understand than if they receive a `ByteString

I'd say let's merge this and leave decoding and error handling to users.
About ideas:

This seems unnecessarily complicated to me. As far as I understand, we need to create a typeclass for decoding to Object type and implement two instances, one that decodes strings and one that doesn't. All of this just to prevent a single decodeUtf8 call.

I wouldn't like this because of unreachable patterns in pattern matching depending on the flag.

Not necessarily very inefficient, thanks to lazy evaluation, but again why do that? Users can just call decodeUtf8 instead of doing pattern matching on this constructor. If they want pattern matching syntax they can even use ViewPatterns :) Also, as @mdpye noted, decoded part should be a Maybe.

If we really want an alternative, I think that's the best one, except we should use Text instead of String as before. EDIT: I @mdpye think has a good point, some arbitrary bytes strings may be valid UTF-8.

No, for same reason as (2).

So again, I say let's merge this. What's going to happen in the worst case is users will have to add some decodeUtf8 calls and that's basically it.

Ok. merged. Thanks!

Cool, thanks!


support multiple subscriptions on customer object

https://support.stripe.com/questions/whats-new-with-multiple-subscriptions-per-customer-january-2014
their blog post: https://stripe.com/blog/multiple-subscriptions

closed by 1fd490818e2ad575f45ab9a863e8d749521a63d9

:clap:


rewrite readme in markdown

I think I can pimp the readme a little by adding a little markdown.
Imo this looks better and we can add code examples, images or simple text decoration in the feature

Yes that's something that could certainly be improved. Do you have a proposal for some changes?
Or you could simply create a PR for an improved version, we can always discuss the changes in the PR.


[1.11.2][a-0.2.7] Inserting blueprint into engineering table crashes client

When I attempt to place a blueprint in the blueprint slot of an Engineering Table, my client crashes.
Crash Report
Related, the item name for the blueprints shows as "item.cyberware.blueprint.notBlank.name" and the shift prompt is "cyberware.tooltip.shiftPrompt".

I have the same problem when placing a blueprint into its slot of the Engineering table. This occured in single player with a 1.11.2 client, Forge v2279. The only mod installed is Cyberware CRash Report

Make sure you're using Alpha 0.2.8 for 1.11

Closing as nothing else was said about this issue and I believe it is fixed. Reopen if this is inaccurate.


rddrone-uavcan146 removed shared clock between hrt & rtc

Removed non-existing SW2 button
Fixed SW3 button pinmux
Added FlexCAN pin definition
hrt use external sirc clock
rtc use 32khz lpo clock
Describe problem solved by this pull request
RTC & HRT uses the same input clock, which can be only be resetted using a power cycle. Yielding weird hrt.c behavior if when RTCCLKSEL is different then we expect.

Any idea why the "SITL Tests / build (pull_request)" CI task fails? In my previous PR #14461 same thing happened

@PetervdPerk-NXP  I restarted SITL CI.
@dagar, @julianoes  any idea what is up with SITL CI?


Suggestion: Add new --emitHelpersFile compile flag

The new --emitHelpersFile compile flag will generate tslib file according to TS version, that will allows do not forget update tslib file.

The compiler should give you an error if the tslib version is not compatible with the compiler. otherwise the version should be matching.
can you elaborate on the problems you are running into? and why they are not just versioning problem on tslib side.

I did not now that. How parser determines the correct version?

it checks the .d.ts in tslib for the functions it needs. if the functions do not exist, or their signature changed, it will complain.

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


Add tag field name for custom codable instances generation

Aeson allows for JSON encodings with both custom "tag" and "contents" field names. We already pass the contents field name through, we should pass the tag along as well. This change would allow for better custom codable instances for IOS which dont need to manually pass in the tag field.
We sort of do this already by passing in a custom sumAnnotation for android "JsonClassDiscriminator("tag")" but this allows for more flexibility on the client's end for generating their own code (without having to mess around with parsing the sum annotation for android or removing it for swift and adding a different one)

AFAICT, this change actually doesn't do anything as of 2a614ab?
Don't we need to actually use the tag in the codebase somewhere else?


Unknown Region

Why this happens
If this issue is open, it means that the server filters are not working at the moment. This is usually because the token got invalidated.
What you can do to help

Wait patiently for a new token
Donate a months worth of a RoPro Rex subscription by contacting me on Discord after purchasing it

Help, I'm having this issue but the issue is closed
Make sure that you're experiencing the unknown region across all servers. It's common to have many that say "Unknown Region" but then the there's one that does work. This is a RoPro fault.
If you have checked and sure it's not working, then you can either let me know on Discord or comment under this issue post.

new error Manifest version 2 is deprecated, and support will be removed in 2023. See https://developer.chrome.com/blog/mv2-transition/ for more details. its when i try to unpack the patch in opera and google

Hey @Stefanuk12! I've purchased a pro subscription, and I'll be doing so for a while. If you'd like to get in contact, please dm me over at (https://discord.com/users/398304429788626946) or shoot me an email.

Hey @Stefanuk12! I've purchased a pro subscription, and I'll be doing so for a while. If you'd like to get in contact, please dm me over at (https://discord.com/users/398304429788626946) or shoot me an email.

@builtbyvys I'm not able to add you through that link, what's your username?

My username is "vyslix"

Fixed, will re-open if not working again.


blocked - deriv.com?

I see that deriv.com was blocked in 0e90c2f88d.    Was this block intentional?

Thank you for your question @PinkFreud.
Just for general FYI, there are no "legitimate" sites or companies here.  If they are involved in tracking, adware, malware, or worse, they get listed.
The domains deriv.com and www.deriv.com come to us from upstream, the good folks at KADhosts.
You can investigate their rationale by submitting an issue here:
https://github.com/PolishFiltersTeam/KADhosts/issues
Closing.


[Query] Do not recompile binds if already compiled

Description
Fixes #4518
The thing is the Database Collector call Query::debugToolbarDisplay to return a nicely formatted SQL string. However, that method will erroneously call $this->compileBinds() everytime. The problem with this approach is that the DB operation had run before the toolbar display collection so all queries have been compiled. Calling it again will give false positives for bind markers when special syntaxes uses the bind marker (such as Postgres' JSON operations).
What we really need is the compiled final query string. Since the compiling was done before collection, we can be sure that it is already set. However, for the sake of prudence, we'll put up a guard if the requested string is not yet initialized and then we'll call compileBinds() right away.
ping @byazrail kindly check this if it will work on your issue
Checklist:

[x] Securely signed commits

Refs #5127.

You mentioned Postgres' JSON operations. Could you provide an example of SQL string that gets modified again if the compiles are run on it a second time? This would help writing tests for #5127.

@vlakoff This? https://github.com/codeigniter4/CodeIgniter4/issues/4518#issuecomment-813532971
$builder = $db->table('search p');
$sql = $builder
	->select('p.*')
	->where('p.location ?| ARRAY[\'639\']', null, false)
	->where('p.status', 1)
	->orderBy('p.id', 'ASC')
	->limit(10)
	->get();

https://www.postgresql.org/docs/9.5/functions-json.html


Selfie in 3/9/3/e/393efa5963.jpg (test set)

I was playing with the test set and found someone's selfie mixed into the data.

您好，这个数据集在哪里下载的呀？我发邮件访问一直没有回复


Review ConcurrentHashMap usage in helidon-messaing-kafka

Problem Description
Thread pinning can occur if the mapping function passed to any of the compute methods in ConcurrentHashMap results in any I/O. The internal implementation of ConcurrentHashMap will hold a lock while the VT is parked, causing the pinning.
Note that I/O in the mapping function can be indirect: for example, using config or a service loader. Please verify that the following calls will never need I/O to complete:
KafkaConfig:51

If required, re-implement the map using a traditional reentrant lock and a hash map.

Non-concurrent HashMap used in this case


Add 136-Single-Number.kt

File(s) Modified: 136-Single-Number
Language(s) Used: Kotlin
Submission URL: _https://leetcode.com/submissions/detail/759502104/_

Please include the class Solution { in your solution, you can keep your code exactly the same as the version you run on leetcode.

Yes, sure.

Thanks, @sharansalian!


add Lowcoder Logo

Thank you for considering to add the Lowcoder Logo too.
We have in Lowcoder icons as Components. Would it be allowed to also link and use your Logo library, so our community can enjoy this too?
Thank you very much in advance!

I followed your steps of the documentation but see now there are merge conflicts at pnpm-lock.yaml, which I did not touch by myself. How to resolve? is there an action needed from my side?


WIP: Remove src from tests

Description of the pull request:
Removes direct src dependencies on tests.
Fixes the following issues:
https://github.com/ractivejs/ractive/issues/2904 . Should also speed up builds for dev:browser since altering src won't cause tests to recompile anymore.
Is breaking:
No.
Reviewers:
Everybody!

Looking good! 🎉

Was just looking at creating a sort of meta transition to run multiple transitions in sequence (possibly parallel, but that's trickier), and having findInViewHierarchy exposed as maybe Ractive.findPlugin('transition', 'bounce', instance) would be super useful.

@fskreuz I completely forgot about this PR before I did the getContext switchover and created a bunch of conflicts 😞. Do you think there's any chance this could land before 0.9?

No worries. I'll look into this later. 😄

Still contemplating whether or not I should expose those APIs above. While normaliseKeypath is a good candidate since it goes well with the escape and unescape as utility functions, parseJSON and findInViewHierarchy feel too internal to me.
Still looking for a good way to test them from the public API.

I've been thinking about dropping the parseJSON support for a while. It seems kinda surprising to me actually with the way it's used. If you pass and attribute like this <div data-foo="{ bar: 42 }">, which would normally be a string, ractive will try to parse it with parseJSON first. I kinda get why it was done originally, but it has some weird implementation details. It can also be replaced with bind-data-foo={ bar: 42 } as of 0.9.
I still like findPlugin as a front for findInViewHierarchy for library purposes - not really meant for general use, but nice for decorator and component authors.

Pondering for a tiny bit more, I'd say go ahead and expose parseJSON for now to land this for 0.9. Since most people probably don't know about the whole bound attribute without an interpolator thing, we can leave it undocumented and pull it out before 1.0. Has the benefit of speeding up attributes slightly and dropping a little more code weight.

I think this is good to go.

The tests! They stand alone! 🎆 🍾


Docker-compose default postgres user for tests

Introduction
Running the tests with the provided docker-compose.yml gives you an error.
Issue Description
Quoting https://github.com/bookshelf/bookshelf/blob/master/.github/CONTRIBUTING.md

This starts the test databases
docker-compose up -d
.
.
.
Once you have your development environment properly setup, you can run the tests:
npm test #

But the tests are not running. It throws an error at "before all hook" with dialect "postgres" because it is not connecting with username "postgres"
This is because docker-compose.yml is creating an image with "root" user
Steps to reproduce issue
Simple:
Clone the repo at master
then
$ npm i
$ docker-compose up -d
$ npm test
Expected behaviour
The tests to run properly
Actual behaviour

Fix
I fixed it with:

I didn't open a PR because don't know if I'm missing something.
I also searched for a similar problem but didn't find anything.

You're probably not missing anything. PR welcome. Thanks for the report and providing all the required info.


AZURESTREAMANALYTICS: Create azure stream analytics not working

Hi, I was trying to create all the setup in one go but as soon as i define AZURESTREAMANALYTICS started getting compilation errors.I fix those errors at my end then try to execute.
But getting exception at line 185:
var groupCreateResponse = groupCreateRequest.GetResponse();
Exception:
The remote server returned an error: (401) Unauthorized.
Kindly help.

Initial version implemented at ehconsoleUpd branch.

Merged with master - welcome to check this out.


Improve the Kubernetes Destination plugin

This pull request depends on my two previous PRs: #2218 and #2219
The plugin now supports loading details from local files rather than requiring them to be entered through the UI. This is especially relaent when Lemur is deployed on Kubernetes as the certificate, token, and current namespace will be injected into the pod. The location these details are injected are the defaults if no configuration details are supplied.
The plugin now supports deploying the secret in three different formats:

Full - matches the formate used by the plugin prior to these changes.
TLS - creates a secret of type kubernetes.io/tls and includes the certificate chain and private key, this format is used by many Kubernetes features.
Certificate - creates a secret containing only the certificate chain, suitable for use as trust authority where private keys should NOT be deployed.

The deployed secret can now have a name set through the configuration options; the setting allows the insertion of the placeholder '{common_name}' which will be replaced by the certificate's common name value.
Debug level logging has been added.

As mentioned in my previous PRs, I'm not a seasoned python developer, and I would appreciate any feedback. This collection of PRs represents most of the python I've worked with.


BXMSPROD-83 update bits to RHPAM 7.1.0.CR2.

Signed-off-by: Piotr Szubiakowski<EMAIL_ADDRESS>Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:

[ ] Pull Request title is properly formatted: [RHPAM-XYZ] Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Attached commits represent units of work and are properly formatted
[ ] You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
[ ] Every commit contains Signed-off-by: Your Name<EMAIL_ADDRESS>- use git commit -s

Closing as rejected since we will be merging rhpam71-dev into 7.1.x instead of using a separate PR. So, https://github.com/jboss-container-images/rhpam-7-image/pull/45 was sufficient.


can httpclient send any character in http header?

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.10beta1 darwin/amd64
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
What did you do?
i want to check the Vulnerability CVE-2006-3918，so i set http method as “”，then http.NewRequest return a error:"net/http: invalid method """;
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
What did you expect to see?
httpclient can send any character in http header。
What did you see instead?

I think you can directly use TCP Connection.
package main

import (
	"fmt"
	"io/ioutil"
	"log"
	"net"
)

func main() {
	addr, err := net.ResolveTCPAddr("tcp", "google.com:80")
	if err != nil {
		log.Fatal(err)
	}
	conn, err := net.DialTCP("tcp", nil, addr)
	if err != nil {
		log.Fatal(err)
	}
	fmt.Fprintln(conn, "<script>alert(12345)</script> / HTTP/1.1")
	fmt.Fprintln(conn, "Host: google.com")
	fmt.Fprintln(conn, "Accept: */*")
	fmt.Fprintln(conn)
	err = conn.CloseWrite()
	if err != nil {
		log.Fatal(err)
	}
	data, err := ioutil.ReadAll(conn)
	if err != nil {
		log.Fatal(err)
	}
	fmt.Printf("%s", data)
}

For questions about Go, see https://golang.org/wiki/Questions


Hotfix data source

修复 https://github.com/alibaba/lowcode-engine/issues/466

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

还差俩文件，不然一起改完吧😅

另外帮忙更新一下 CHANGELOG.md 和 package.json 的版本哈

@alvarto done 了


#274 fix date

#274

@rultor merge

@rultor merge

@dmzaytsev Thanks for your request. @yegor256 Please confirm this.

@rultor merge it

@rultor merge it

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@dmzaytsev Travis CI build is in progress

@k0r rultor makes build before merge
rultor doesn't merge if the build fail

@k0r keep in mind that Travis is only supplementary for us. Rultor is a much stronger protection mechanism. Even if Travis says that everything is fine, we don't trust this information entirely. All merges should go through Rultor.

@yegor256 merge confirmations and reviews often take more time than it should, that's why I've been manually merging PRs.

@rultor merge it

@yegor256 Done! FYI, the full log is here (took me 10min)

@yegor256 let's release it?

@rultor release, tag is 0.3.32

@rultor release, tag is 0.3.32

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.3.32

@yegor256 Done! FYI, the full log is here (took me 6min)

@dmzaytsev many thanks.

@yegor256 @k0r it works

@dmzaytsev bit.ly links are all the same.

@dmzaytsev @k0r please remember that we are using one issue per problem. Every time we see a bug, a new issue has to be created, a new performer assigned, etc.


Unable to install pack on stackstorm 2.5.X

Pack installation is failing on stackstorm with the following error:
requests.exceptions.HTTPError: 502 Server Error: Connection refused
Unable to retrieve detailed message from the HTTP response. Expecting value: line 1 column 1 (char 0)
for url: http://<IP_ADDRESS>:9101/v1/packs/register.
Though the required pack gets downloaded under /opt/stackstorm/packs but fails while trying to register it with stackstorm

@rashisha wlWhat pack are you trying to install?
Are there any errors in /var/log/st2/st2api.log or /var/log/st2/st2actionrunner.*.log


Grpc

Codecov Report

Merging #17 (9c1521d) into main (0fe7617) will increase coverage by 21.48%.
The diff coverage is 92.68%.

@@             Coverage Diff             @@
##             main      #17       +/-   ##
===========================================
+ Coverage   63.46%   84.94%   +21.48%
===========================================
  Files           2        3        +1
  Lines          52       93       +41
===========================================
+ Hits           33       79       +46
+ Misses         17       10        -7
- Partials        2        4        +2

Impacted Files
Coverage Δ

internal/app/grpc/server.go
92.68% <92.68%> (ø)

internal/app/http/server.go
78.00% <0.00%> (+16.00%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us.


Won't refresh

Expected behavior
When clicking between My Images, All, Recommended, etc, screen should refresh
Actual behavior
Screen stays on Recommened screen.
Information about the Issue
Just upgraded to Docker 2.0 and new version of Kitematic.
Steps to reproduce the behavior

Open Kitematic
Click on My Images

Having the same problem. Running version 0.17.5

Duplicate issue of #4306

Having the same problem...


Allow GPIO exclusions

I'm writing an Arduino/Raspberry Pi/Lego blog (www.internetoflego.com) and was going to include some of your work. As I was testing a project, I realized that I have a major conflict and was hoping you could point me in the right direction.
Setup:
Raspberry Pi v2
Johnny-Five
LIRC for Lego IR Power Functions control
https://github.com/dspinellis/lego-power-scratch
My Code (still needs tested)
https://gist.github.com/dexterlabora/49ab4509ca4ef5edc8fd
The issue I am having is that in order to use the LIRC infrared driver/commands directly from Linux, pins 22 & 23 are reserved for this service. As I try to run a J5 app, I'm getting the following error, likely because the pins are already in use.
(Error: Pin "22" does not support mode "2").
I had a look through the index.js file, and assume I could write some code to bypass the initialization of these pins, but before I go down that rabbit hole, I was hoping you could guide me on this. I want a clean (less hacky) way of doing this as I write my instructional blog for the general public. Currently, I have to use the Rasp Pi for only the LIRC functions and all other GPIO related stuff on an Arduino. This works, but obviously I'm limiting my self here and requiring two controller boards.
Thanks for you help and the work you've done so far. I will be sure to credit you in the blog post!
~~ Console Error ~~
1442855141613 Device(s) RaspberryPi-IO
1442855141665 Connected RaspberryPi-IO
1442855141681 Repl Initialized

Error: Pin "22" does not support mode "2"
at Raspi.pinMode (/root/IoL/node_modules/raspi-io/lib/index.js:345:17)

at new Sensor (/root/IoL/node_modules/johnny-five/lib/sensor.js:79:11)

at new module.exports.Digital (/root/IoL/node_modules/johnny-five/lib/johnny-five.js:87:10)

at Board.<anonymous> (/root/IoL/citystation.js:32:28)

at Board.emit (events.js:92:17)

at process._tickCallback (node.js:448:13)

Thanks again,
Cory
www.InternetOfLego.com

Looking at it more in depth, it's not because the pins are reserved, it's because Johnny-Five is trying to set the pin mode to analog input, which the Raspberry Pi does not support. So, the error message is technically correct.
Turns out, this is a bug in Johnny-Five itself. I submitted a PR to fix this at https://github.com/rwaldron/johnny-five/pull/908

Thank you very much!
On 23 Sep 2015 16:49, "Bryan Hughes"<EMAIL_ADDRESS>wrote:

Closed #33 https://github.com/nebrius/raspi-io/issues/33.
—
Reply to this email directly or view it on GitHub
https://github.com/nebrius/raspi-io/issues/33#event-417137043.


[release-4.2] Bug 1716697: strip the tag from the reference we print after pushing

When we combine the image name that we pushed to with a digest in order to print the "Successfully pushed..." message, strip out the tag.  Cherry-picked from #89.

@nalind please open this PR against master. We are not planning on opening master to 4.3 work yet.

@adambkaplan #89 is the same patch as this PR, but for the master branch.

/close
Duplicates #89


Input Security Groups not deleted by Delete section

https://github.com/awslabs/live-stream-on-aws/blob/e691332b659652ccf8aff8dddf2e4fd0e833551c/source/custom-resource-py/lambda.py#L81-L98
Does not include code to delete Input Security Groups so these build up as orphan resources in the account as the stack is created / deleted.

Hi and thanks for the feedback.
You are correct deleting the Security Group is currently not part of the custom resource, we will look this add this as a feature in the next release.

v2.2.1 Update.


UI: Replace outer DHTMLX layout with responsive CSS for explorer screens

Initial thoughts:

The center DHTMLX layout will need to be based on the non-DHTMLX center area that the classic screens will be using.  We need to make sure that all of the inner DHTMLX layouts and controls can be responsive to the resizing of the center area.

@miq-bot move_issue manageiq-ui-classic


[FUNCTION] Flip

A function that flips the texture either horizontally or vertically
Flip(bool vertical, bool horizontal)

Added


Mobile Support

Mobile support can be easily added by double-checking the scaling and adding a bunch of buttons from 1-9 (and a backspace)

Homepage has mobile support. Still need the game window to have mobile support

Mobile support is complete!!!


Windows compatibility with postinstall

Hey,
Just FYI for anyone using windows trying to install this with NPM. NPM install will fail with the postinstall command in package.json having unix reference  "postinstall": "./node_modules/bower/bin/bower install". For windows if you change it to "postinstall": "bower install" everything should work fine.
Thanks.

@MumblesNZ Thanks, correct. There is a new branch 2.0 where all dependencies will be installed with npm.


v1.16 Backports 2024-08-03

[ ] #33934 (@giorio94) :warning: resolved conflicts
[ ] #33904 (@chaunceyjiang)
[ ] #33908 (@giorio94) :warning: resolved conflicts
[ ] #33952 (@chancez)
[ ] #33517 (@jrajahalme)
[ ] #33847 (@tommyp1ckles)
[ ] #34004 (@tommyp1ckles)
[x] #33971 (@rastislavs)
[ ] #33947 (@harsimran-pabla)
[ ] #33905 (@chaunceyjiang)
[x] #34032 (@sayboras)
[ ] #34017 (@ysksuzuki) :warning: resolved conflicts
[x] #34031 (@rastislavs)
[ ] #34059 (@joamaki)
[ ] #34062 (@giorio94)
[ ] #34044 (@Huweicai) :warning: resolved conflicts
[ ] #34097 (@chancez)
[ ] #33518 (@jrajahalme)
[x] #33989 (@bimmlerd)
[x] #34106 (@dylandreimerink)
[x] #34109 (@sayboras)
[x] #34121 (@michi-covalent)
[x] #34110 (@mhofstetter)
[ ] #34104 (@jrajahalme)

Once this PR is merged, a GitHub action will update the labels of these PRs:
 33934 33904 33908 33952 33517 33847 34004 33971 33947 33905 34032 34017 34031 34059 34062 34044 34097 33518 33989 34106 34109 34121 34110 34104

/test-backport-1.16

@nbusseneau Unfortunately I've managed to introduce two bugs with #33989 - I'm fixing them in #34175 but let's drop #33989 for now until the fixes are merged and can be backported too. Apologies for the overhead.

/test-backport-1.16

e2e upgrade tests are hitting https://github.com/cilium/cilium/issues/33979 - won't become green.


Create branches with files for chapter 2 and chapter 3

Hi @thegoleffect,
I've created this separate issue (which is linked to #43) to split my task out from yours because:

When I need to ask task-specific questions it doesn't make sense to bloat #43
I keep track of all my tasks through GH issues so I'd be grateful if you could assign this to me?

Thank you!

Issue to be dealt with in readme of branch on chapter 2:
In chapter 2 on servers, the book talks through the longhand way of creating a server and then strongly recommends the use of glue. So for me, that meant I should adapt my code to use glue, overwriting what was there before.
However, chapter 6 is based on non-glue version of index.js and talks about it as if that were the default version (even though the code in GH uses glue).

@thegoleffect Awesome, thanks!

Closing as no longer relevant.


Add PVC support for Registry addon

Previous implementation just simply hardcode map the /var/lib/registry to emptyDir.
This patch add the PVC support and asking for a StorageClassName, e.g. we could now provide:

local-volume, or
cephfs

Also provide a default PV with storageClassName kube-registry-pv + emptyDir implementation, so could always works in deployment even if we don't specify our custom registry_storage_class.

Also provide a default PV with storageClassName kube-registry-pv + emptyDir implementation, so could always works in deployment even if we don't specify our custom registry_storage_class.

@ant31 may i have your help for review?

fix previous implementation, only create PVC if registry_storage_class != none, else just simply map as emptyDir: {}

Moved into https://github.com/kubernetes-incubator/kubespray/pull/2332


Can't find OpenJpeg 2.3 installed by MacPorts

MacPorts installs OpenJpeg to /opt/local/include/openjpeg-2.3
But OpenImageIO can't find it because it only searches /opt/local/include.  If I add the location in src/cmake/modules/FindOpenJpeg.cmake then it builds correctly.

Care to make a PR with this fix?

Okay I have never done a PR before, I hope I did it right.
https://github.com/OpenImageIO/oiio/pull/1948

You certainly did. Thanks, it's much simpler for me to review the code, see that the CI tests pass, and hit the 'merge' button on GH, than it is for me to try to reconstruct it on my end without a good way to test.

Cool!