router doesn't work when the schema returned by the _service.sdl includes the _service or _entities fields

Component(s)
router
Component version
0.54.2
wgc version
0.35.0
controlplane version
not using controlplane
router version
0.54.2
Description
Router returns HTTP 500 error when the schema returned by the _service.sdl includes the _service or _entities fields.
I'm building a custom supgraph library and I included these things in the _service.sdl field, because I only need to work with Federation 2.0 and, as stated here (https://www.apollographql.com/docs/federation/subgraph-spec#required-resolvers-for-introspection), they should only be omitted when support for Federation 1.0 is needed.
This error is printed in the logs:
{"level":"error","time":1709041748292,"caller":"core/graphql_handler.go:357","msg":"internal error","hostname": (redacted),"pid":10948,"component":"@wundergraph/router","service_version":"0.69.0","reqId": (redacted),"error":"1 error occurred:\n\t* nodesResolvableVisitor: could not select the datasource to resolve Query.mediaplans_results on a path query.mediaplans_results\n\n","stacktrace":"github.com/wundergraph/cosmo/router/core.logInternalErrorsFromReport\n\tgithub.com/wundergraph/cosmo/router/core/graphql_handler.go:357\ngithub.com/wundergraph/cosmo/router/core.(*PreHandler).writeOperationError\n\tgithub.com/wundergraph/cosmo/router/core/graphql_prehandler.go:418\ngithub.com/wundergraph/cosmo/router/core.(*PreHandler).Handler-fm.(*PreHandler).Handler.func1\n\tgithub.com/wundergraph/cosmo/router/core/graphql_prehandler.go:293\nnet/http.HandlerFunc.ServeHTTP\n\tnet/http/server.go:2166\ngithub.com/wundergraph/cosmo/router/core.(*WebsocketHandler).ServeHTTP\n\tgithub.com/wundergraph/cosmo/router/core/websocket.go:176\ngithub.com/go-chi/chi/v5.(*Mux).ServeHTTP\n\tgithub.com/go-chi/chi/v5@v5.0.11/mux.go:73\ngithub.com/go-chi/chi/v5.(*Mux).Mount.func1\n\tgithub.com/go-chi/chi/v5@v5.0.11/mux.go:315\nnet/http.HandlerFunc.ServeHTTP\n\tnet/http/server.go:2166\ngithub.com/go-chi/chi/v5.(*Mux).routeHTTP\n\tgithub.com/go-chi/chi/v5@v5.0.11/mux.go:443\nnet/http.HandlerFunc.ServeHTTP\n\tnet/http/server.go:2166\ngithub.com/wundergraph/cosmo/router/pkg/cors.(*cors).ServeHTTP\n\tgithub.com/wundergraph/cosmo/router/pkg/cors/config.go:66\ngithub.com/wundergraph/cosmo/router/internal/requestlogger.(*handler).ServeHTTP\n\tgithub.com/wundergraph/cosmo/router/internal/requestlogger/requestlogger.go:99\ngithub.com/wundergraph/cosmo/router/pkg/trace.(*Middleware).Handler.func1\n\tgithub.com/wundergraph/cosmo/router/pkg/trace/middleware.go:45\nnet/http.HandlerFunc.ServeHTTP\n\tnet/http/server.go:2166\ngo.opentelemetry.io/contrib/instrumentation/net/http/otelhttp.(*middleware).serveHTTP\n\tgo.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@v0.46.1/handler.go:229\ngo.opentelemetry.io/contrib/instrumentation/net/http/otelhttp.NewMiddleware.func1.1\n\tgo.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@v0.46.1/handler.go:81\nnet/http.HandlerFunc.ServeHTTP\n\tnet/http/server.go:2166\ngithub.com/go-chi/chi/v5/middleware.RealIP.func1\n\tgithub.com/go-chi/chi/v5@v5.0.11/middleware/realip.go:36\nnet/http.HandlerFunc.ServeHTTP\n\tnet/http/server.go:2166\ngithub.com/go-chi/chi/v5/middleware.RequestID.func1\n\tgithub.com/go-chi/chi/v5@v5.0.11/middleware/request_id.go:76\nnet/http.HandlerFunc.ServeHTTP\n\tnet/http/server.go:2166\ngithub.com/wundergraph/cosmo/router/internal/recoveryhandler.(*handler).ServeHTTP\n\tgithub.com/wundergraph/cosmo/router/internal/recoveryhandler/recovery.go:103\ngithub.com/wundergraph/cosmo/router/core.(*Router).newServer.func2.1\n\tgithub.com/wundergraph/cosmo/router/core/router.go:836\nnet/http.HandlerFunc.ServeHTTP\n\tnet/http/server.go:2166\ngithub.com/go-chi/chi/v5.(*Mux).ServeHTTP\n\tgithub.com/go-chi/chi/v5@v5.0.11/mux.go:90\nnet/http.serverHandler.ServeHTTP\n\tnet/http/server.go:3137\nnet/http.(*conn).serve\n\tnet/http/server.go:2039"}

Steps to Reproduce
Have the Query._service.sdl field's return value include this in at least one subgraph:

extend type Query {
  _service: _Service!
}

extend type Query {
  _entities(representations: [_Any!]!): [_Entity!]!
}

Expected Result
Router should handle request correctly
Actual Result
HTTP 500: internal server error
{"errors":[{"message":"internal server error"}],"data":null}

Hi @vidmartin,
How were you able to conclude this? The error didn't happen when those fields were not included?

And this error is still present in router v0.69.0

Hi @vidmartin, could you provide a full reproduction? (Including schemas etc..) Ideally, put it in a separate repository and share the link.

Closing due to inactivity. Please re-open in case it doesn't work on the latest version.


Large loadable types pass: resolves a case wherein a tuple’s extracted type is a function signature

Radar rdar://problem/31972859
Fixes an issue in the large loadable types conversion pass: given a tuple element which is a SIL function signature, and given that said signature is modified by the large types pass, we need to do a cast from the tuple's returned value to the new function signature.

@swift-ci Please smoke test

@swift-ci Please smoke test

Discussed / Reviewed offline with @swiftix and @aschwaighofer

@swift-ci Please smoke test


Create 2020-03-16.md

Signed-off-by: Mark Boorer<EMAIL_ADDRESS>

CLA is checking out, but DCO failing. Maybe you just need to update the email used for your sign-off?

Resubmitted in #992


Improve complex object filtering in view

Currently any object other than String, Integer or Boolean has to be inputted via JSON. We should allow users to specify which type from the type service they wish to use - along with a custom type if it doesn't exist (JSON string).

Merged into develop.


Docs: update integration pages with the option of using lakeFS-specific Hadoop FileSystem

In the page of using lakeFS with Spark we added the option of access lakeFS using the lakeFS-specific Hadoop FileSystem, but didn't updated other integration pages accordingly.
Specifically the Using lakeFS with Databricks doesn't contain any information about using lakeFS Hadoop FileSystem.
We should update the docs with the option of lakeFS Hadoop FileSystem.

Same as https://github.com/treeverse/lakeFS/issues/2757


"'trigger_config' is undefined" when generating device documentation

AVD 4.8.0
Python 3.11.7
ansible [core 2.17.0]
jinja version = 3.1.4
I have this in my 'FABRIC.yml'
event_handlers:
  - name: clear-host-dampening
    actions:
      bash_command: 'FastCli -p 15 -c "clear bgp evpn host-flap"'
    delay: 300
    trigger: on-logging
    trigger_on_logging:
      regex: EVPN-3-BLACKLISTED_DUPLICATE_MAC

when running the build.yml, I get this error:
TASK [arista.avd.eos_cli_config_gen : Generate device documentation] ********************************************************************************************************************************
fatal: [dc1-spine1 -> localhost]: FAILED! => {"msg": "'trigger_config' is undefined"}
fatal: [dc1-spine2 -> localhost]: FAILED! => {"msg": "'trigger_config' is undefined"}
fatal: [dc1-leaf1b -> localhost]: FAILED! => {"msg": "'trigger_config' is undefined"}
fatal: [dc1-leaf1a -> localhost]: FAILED! => {"msg": "'trigger_config' is undefined"}

Seems that the trigger_config is not defined in some conditions in the event-handlers.j2
https://github.com/aristanetworks/avd/blob/2616f34e4539ca2bdd6e2a8f96a85bdecd2f728e/ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/event-handlers.j2#L15
I added
{%             set trigger_config = [] %}

between line 14 and 15, and that worked out
Or there is something else going on, that line 74 is not getting hit properly
https://github.com/aristanetworks/avd/blob/2616f34e4539ca2bdd6e2a8f96a85bdecd2f728e/ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/event-handlers.j2#L74

Hello thanks @PieterL75 for raising this issue!
I confirm that I can repro in AVD 4.8.0 though it is not failing anymore in devel. It has been fixed by https://github.com/aristanetworks/avd/pull/4055 and will be fixed in the next AVD release.
I am closing this issue but feel free to reopen if you have any follow-up question.


Replace 'vCPU' with 'vcpus'

GCE shows vCPU in the description of the machine, not the vcpus.

Nice, thanks!
Could you please edit the commit message based on our docs? Sorry, it seems we do not have this document for front end, but the same rules should apply.

/retest

Could you please edit the commit message based on our docs? Sorry, it seems we do not have this document for front end, but the same rules should apply.

@stejskalleos feel free to use fix(HMS-2301): Replace 'vCPU' with 'vcpus' it will satisfy the linter, even tho it's bit of a cheating to use closed ticket, for such a small change I'd be perfectly fine with it :)

/retest

I've addressed @avitova and @amirfefer concerns, so we can get this in, could you please re-review? :pray:

/retest
weird timeout :thinking:

I'll go ahead and merge, Amir might not get to it and we addressed his comments, so we should be good :)
I'm happy to address any additional comments, if Amir has some :)


Expected Behavior
Reasonable retention of precision.
Actual Behavior
Some of these numbers are off by 4 times EPS!!!
[
  [ 2.999997997037038, 1.499998998518519 ],
  [ 3.999997329382717, 1.499998998518519 ],
  [ 3.999997329382717, 2.499998330864198 ],
  [ 2.999997997037038, 2.499998330864198 ]
]
[
  [ 0, 0 ],
  [ 8.000044658732051, 0 ],
  [ 8.000044658732051, 0.9999993323456793 ],
  [ 8.999993991111113, 0.9999993323456793 ],
  [ 8.999993991111113, 2.999997997037038 ],
  [ 8.000044658732051, 2.999997997037038 ],
  [ 8.000044658732051, 3.999997329382717 ],
  [ 0, 3.999997329382717 ]
]
[
  [ 1.9999986646913586, 2.999997997037038 ],
  [ 5.999995994074076, 2.999997997037038 ],
  [ 5.999995994074076, 0.9999993323456793 ],
  [ 1.9999986646913586, 0.9999993323456793 ]
]
[
  [ 3.1499978968888898, 1.8499987648395066 ],
  [ 3.349997763358026, 1.8499987648395066 ],
  [ 3.349997763358026, 1.6499988983703708 ],
  [ 3.1499978968888898, 1.6499988983703708 ]
]
[
  [ 3.3999977299753095, 2.39999839762963 ],
  [ 3.6999975296790133, 2.39999839762963 ],
  [ 3.6999975296790133, 1.9999986646913586 ],
  [ 3.3999977299753095, 1.9999986646913586 ]
]

Steps to Reproduce the Problem
const { geom2 } = jscad.geometries
const { rectangle } = jscad.primitives
const { union, subtract } = jscad.booleans
const { translate } = jscad.transforms
const { extrudeLinear } = jscad.extrusions

const main = () => {
	let g2 = subtract(rectangle({size:[8, 4], center:[4,2]}), translate([2, 1], rectangle({size:[4, 2], center:[2, 1]})));
	g2 = union(g2, translate([7, 1], rectangle({size:[2, 2], center:[1,1]})), translate([3, 1.5], rectangle({size:[1, 1], center:[0.5,0.5]})));
	g2 = subtract(g2, translate([3.15, 1.65], rectangle({size:[0.20, 0.20], center:[0.1,0.1]})));
	g2 = subtract(g2, translate([3.4, 2.0], rectangle({size:[0.30, 0.40], center:[0.15, 0.2]})));
	const outlines = geom2.toOutlines(g2);
	for (let i =0; i<outlines.length; i++) {
		console.log(outlines[i])
	}
	let g3 = extrudeLinear({height:5}, g2);
	return g2
}

Anyway, as step one to correcting the Boolean issues (#1113 ), I'm working on booleans for 2D.
It's kind of crazy to be using 3D for 2D anyway.

BTW, is there some hidden documentation about how Geom2 outlines and sides work?
I was making a sample, trying to understand how they work when I realized the severe precision issues.

Yea using the 3D BSP algorithms (which already have issues) for 2D is kind of crazy. Using the "fake polygons" to do so leads to a whole bunch of numeric errors, and the performance is awful.
There has been discussion, and I even started some work, on changing the 2D boolean operations to use better algorithms which are both 1) much faster and 2) more accurate and stable.
There was general agreement with z3dev that martinez might be the best implementation to use as inspiration. It is a line-sweep algorithm which is generally considered state of the art in computational geometry. It is very well tested on edge cases, see here.
There has also been some discussion of just depending on another lib such as here

Great. I'll look at those two. In almost every case, a JS version exists of the algorithms I've been looking at and they had either MIT or Boost licenses.

Comments moved that were posted in the wrong place...
OK, just been looking around. Polybooljs is also based on Martinez. More important from my standpoint is that two C# ports already exist!
Martinez-Rueda is very full blown... it will be quite of bit of work paring it down...
Oh, NOTE: polybooljs seems to have a different maintainer, it now appears to be at: https://github.com/velipso/polybooljs ... no idea what the story is, but the links to the old place are all broken, including the doc ones on npmjs.com.

OK, revising my opinion about the martinez-reuda link @z3dev gave above. It seems it's is very similar to polybooljs, and the reason
is simple, it all started with the author's C code, see:
https://github.com/akavel/martinez-src
The link @z3dev gave above is probably the best to go with because it uses the newest form of the algorithm.
The new form gives information on what are holes, for example.
And I think I'd really like to see "sides" go away in Geom2 and a form of the data provided by toOulines be the format used.
In almost every instance, the first use of sides is to convert them back to points.
If you know of a reason why sides need to stay, I'd love to hear it.

Comments moved that were posted in the wrong place... The link that @z3dev posted in the other thread (that I refer to below) is: https://github.com/w8r/martinez

This library has also been ported to Rust, if that helps. Bot are actively maintained.

FYI, the results of 2D booleans are snapped (rounded) in order to prevent gaps, which comes from the 3D booleans, so precision is 'adjusted'.

@z3dev , this is what numbers should look like!!!
ccw cw Vec2(3.35000,1.85000), Vec2(3.35000,1.65000), Vec2(3.15000,1.65000), Vec2(3.15000,1.85000),
cw Vec2(3.70000,2.40000), Vec2(3.70000,2.00000), Vec2(3.40000,2.00000), Vec2(3.40000,2.40000),
ccw Vec2(3.00000,2.50000), Vec2(3.00000,1.50000), Vec2(4.00000,1.50000), Vec2(4.00000,2.50000),
cw Vec2(6.00000,3.00000), Vec2(6.00000,1.00000), Vec2(2.00000,1.00000), Vec2(2.00000,3.00000),
ccw Vec2(8.00000,3.00000), Vec2(8.00000,4.00000), Vec2(0.00000,4.00000), Vec2(0.00000,0.00000), Vec2(8.00000,0.00000), Vec2(8.00000,1.00000), Vec2(9.00000,1.00000), Vec2(9.00000,3.00000),

I hacked in a C# translation of https://github.com/velipso/polybooljs called Polybool.Net.
I wanted to see if it was worth translating w8r/martinez.
The verdict is YES.
The version of the algorithm I running is older and does not separate out holes, so I had quite a bit of frustration
getting this in proper order for Geom2.
w8r/martinez does separate "contours" from holes -- see index.js there.
So I will be translating that next.
There are some challenges, but even so, it runs about 10% faster than the current method.
Challenges... one Geom2 sides really need to go, the take extra storage and are not useful anywhere that I can see.
I've been playing around with stuff and I believe we should store things as Outlines.
This would be a List<List> with ordering as you would expect.
Each list in the list of lists would be a complete path.
We spend a lot of time building sides, then tearing them down.
My favorite example of this craziness is in the Extrudes. We get the sides, pass them to the Slice constructor.
Which essentially rebuilds sides, calling them edges.
Having them as outlines, preferable with some easy way to identify holes.
(For example, w8r/martinez appears to do something like List<List<List>> where the call the first level rings, which seem to consist of a "contour" and it's associated rings. The "contour" seems to be the first entry in the array.
Note, I could be wrong here... I've not started the port yet.
Anyway, I'd like to see a discussion about replacing sides with a different form of storage.

It is very important that you guys look into what I have done. @platypii @z3dev @hrgdavor
Much, if not all of this needs done in JSCAD.
OK, I've done the following to CSharpCAD:

Changed 2D booleans to use a C# translation of polybooljs called NPolyBool.

It is based on the eariler martinez algorithm. I had difficulties with the w8r/martinez. Problems in the code, etc. Also I did not like the fact that the paper isn't generally available. The only problem with the algorithm is that it had the side effect of me needing to dectect which were shapes and which were holes. This turned out to be a blessing, not a curse. See next comment about why.
NPolyBool runs about 30% faster than the existing 2D booleans. It has much better data integrity.
If I were you guys, I'd try the w8r/martinez to see if it is faster than polybooljs.
I entirely replaced the non-twisty portion of ExtrudeLinear. it is 30x (that's TIMES, not %) faster than the existing extrude Linear.  There are many reason why this is true, I'll deal with that in the next comment.
I tried a different earcut, but ended up back with the current one. I FOUND AN IMPORTANT PROBLEM, see issue: #1132
Because of the need to fix 3D booleans, I have made this and most of the primitives triangulated. I expect to have this completed soon. It will be far easier to fix the 3D problems if everything is triangulated.

Why I've started deprecating sides in Geom2.
They simply are not useful. I cannot find a single place in the code where having sides was useful.
In most cases ToSides is called only to get data and convert it to some other format.
They take twice the storage and it is fairly expensive creating them.
What I am using:
I created an NRTree (a nested Ring Tree).
It is incredibly simple:
 internal class NRTreeNode
    {
        internal Vec2[] Points;
        internal Vec2 Min; // BoundingBox of points
        internal Vec2 Max;
        internal List<NRTreeNode> Contained;
        }

It takes less storage and time to create than sides.
It AUTOMATICALLY figures out spaces and holes on creation (solving the NPolyBool/polyboojs problem of winding.
It bypasses the need for Earcut AssignHoles.
It improve performance anywhere ToOutlines() is used.
I haven't done it yet, but it is likely to make offset/expand/extrudeRectangular work faster.
It is one of the reason that my extrudeLinear is so much faster.
You can find the code here: https://github.com/briansturgill/CSharpCAD/blob/main/CSharpCAD/src/geometries/Geom2.cs

You can see extrudeLinear (no twisting) here: https://github.com/briansturgill/CSharpCAD/blob/main/CSharpCAD/src/operations/extrusions/extrudeLinear.cs

OK, I have created a full replacement for extrudeRotate. It runs about 50% faster than the old version.
The primary problem with the current JSCAD extrudes in general is that they all cater to extrudeRotate.
This makes most extrudes way too slow.
I have code that autoselects midpoint triangulation over earcut if the Geom2 is Convex.
Earcut handles Convex shapes somewhat painfully... especially on circles where it makes very tiny triangles and a few huge ones. It is also much slower, here it is in action:

You can find extrudeRotate code at:
https://github.com/briansturgill/CSharpCAD/blob/main/CSharpCAD/src/operations/extrusions/extrudeRotate.cs

Some may be mystified about my making new extrude functions... but take a look at what happens when you extrudeLinear under JSCAD.

You (Have created Sides in a Geom2), now copy the Sides in Edges (which are 3D).

Remember each point gets a memory allocation. (Really 2 in the sides and 3 in Edges)

You the

@briansturgill all of your insights are appreciated, and I enjoy reading your posts here and suggestions. @z3dev is much longer on this project than me and he may know (but may also not) who made some choices in the current code-base.
I agree with your sentiment about the extrude, and although elegant I prefer splitting the concept so simple linear extrude can benefit in performance.
Thank you for sharing your experiences from CSharpCAD. You could have easily just done the improvements there, and not take time to share these insights with us.


Convert loader & browser-loader to typeScript

jsonldToManifest is used by loader.ts but had the wrong signature. This wasn't picked up until I converted loader to typeScript.


[Bug]: ts-jest silently hangs up with certain moduleResolution options

Version
29.1.1
Steps to reproduce

Open minimal reproduction https://stackblitz.com/edit/sbnc-tsnode-hang-issue?file=package.json
Wait for npm install
Run npm run test

Expected behavior
The test should either run or give some error.
Actual behavior
The test hangs up forever.
Debug log
You can find the debug log in the reproduction: ts-jest.log
Additional context
Please check out jest.config.js. It only has two meaningful config items: extensionsToTreatAsEsm and transform.isolatedModules. Comment out any of them, and the test run fails properly with an error message. Leave them both in, and the test hangs up forever.
The issue is related to moduleResolution in tsconfig.json. Set it to node10 or classic and there is no hang, set it to node16, nodenext or bundler and the issue comes up.
Please note, that it is very minimal, I've removed everything not related to the issue. So ignore if this configuration does not make sense, I've narrowed it down from a much more complex real issue I had. The main point here is that ts-jest hangs without any indication of an error, which is very painful to debug.
The reproduction is on node v16, but the same happens on Node v20 as well.
Environment
System:
    OS: Linux 5.0 undefined
    CPU: (4) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
  Binaries:
    Node: 16.20.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.4.2 - /usr/local/bin/npm
    pnpm: 8.6.10 - /usr/local/bin/pnpm
  npmPackages:
    jest: ^29.0.0 => 29.7.0

I'm pretty sure this is what I'm running into as well, for a slightly less minimal example if it's useful then have a look at https://github.com/mscharley/ioc-deco/pull/63
Seems to only be an issue with TS ~5.2, 5.1 is unaffected. It's similarly happening across Node 16, 18, and 20 for me as well.
I'd also be interested to know why it seems like ts-jest is messing with moduleResolution and especially module settings - it can trigger very different behaviour in projects if it gets toggled between different values. In my project I have both module and moduleResolution set explicitly to node16 but I managed to get the same error out of Jest:
  ● Test suite failed to run

    error TS5110: Option 'module' must be set to 'Node16' when option 'moduleResolution' is set to 'Node16'.

But are you getting a hang as well? I would have been happy about an error message tbh. Hang is way harder to deal with, and has some dire implications in a CI environment eating away server time...

Yep, I'm getting the hang with no changes other than the package version update, eg: https://github.com/mscharley/ioc-deco/actions/runs/5994385300/job/16255936781?pr=63
I got the error message by disabling NODE_OPTIONS=--experimental-vm-modules, similar to how you did modifying some of Jest's options.

Borrowing from #4198 I tried using a special tsconfig for just jest:
{
	"extends": "./tsconfig.json",
	"compilerOptions": {
		"module": "ESNext",
		"moduleResolution": "Classic"
	}
}

This is working for me, even for node imports which wouldn't normally work. This is very much a workaround though. This feels like a combination of two issues:

Per the comments in #4198 ts-jest is modifying the module compilation option used to compile typescript with when it is in ESM mode but isn't modifying moduleResolution as well which is now an error in TS >= 5.2 if you have both explicitly specified in your tsconfig.
This compilation error isn't being handled properly somewhere inside either Jest or ts-jest and the compilation error is leading to a hang condition (this issue).

@mscharley excellent workaround, thanks so much for sharing!

Opened #4226 fixing the error being gobbled up

@SimenB regarding the error itself did I misconfigure something or is it yet another issue?

Dunno, I haven't used those options. Error message says to ensure outDir

Error message says to ensure outDir

Which unfortunately makes no sense either. For esm javascript they suggest to use an empty transform but obviously I can't do that with Typescript.

I managed to get it working: https://github.com/darkbasic/jest-esm-repro
Unfortunately we still have problems with errors not bubbling up, in fact the culprit was "noEmitOnError": true but still no clue which errors it is supposed to cause since yarn compile works fine with the same tsconfig.

Even worse I've just noticed that snapshots don't work at all: https://github.com/jestjs/jest/issues/14723


Scaled permutation and improved permutation interface

This creates a new permutation interface to enable more functionality without overloading the Csr and Dense interfaces (which was a valid concern in #1338) and adds scaled permutation functionality merging scaling and permutation.
This is still WIP, but the interface itself is already polished enough (and the PR is big enough) that this should already be reviewed.
TODO:

[x] SYCL kernels
[x] Switch from S * P to P * S, i.e. first scaling, then permuting.
[x] Match Permutation and ScaledPermutation interface (removing size parameter and permute mask member)
[x] Add combination functionality (Scaled)Permutation * (Scaled)Permutation
[ ] Add Permuted and ScaledPermuted interface (probably better aimed at another PR)

format!


Godot code editor incorrectly colors inline dictionary when declared in function call

Godot version
3.5.1 stable
System information
Windows 10
Issue description
The code editor incorrectly colors the value of a dictionary when it is declared inline as a parameter on a function call.
When declaring a dictionary in a single line outside of a function call, the code is colored and highlighted normally.

When declaring the same dictionary but as part of a function call, variable names used as values are colored as if they were a type declaration in static typing.

The bug does not appear when using constants as values, nor when the dictionary is split in multiple lines.

Steps to reproduce

Create a script
Declare a dictionary as a parameter in a function call, as shown above.

Minimal reproduction project
N/A

Pretty sure we have a similar issue reported already 🤔

Pretty sure we have a similar issue reported already 🤔

Apologies if it's repeated

Apologies if it's repeated, I couldn't find the issue after searching.
Furthermore, apologies for accidentally closing it while typing this comment.

Apologies if it's repeated, I couldn't find the issue after searching.

I couldn't find it either, I just vaguely remember it, so it's ok.


Wrap React PDF for more advanced manipulation

We could wrap  this lib to provide more advanced PDF manipulation (limited to display):
https://www.npmjs.com/package/react-pdf

Apparently it can also support displaying annotations from PDFs: https://github.com/wojtekmaj/react-pdf/blob/main/packages/react-pdf/README.md#support-for-annotations

This should be a 3rd party component now - closing this issue for now.


esp_ble_gattc_read_char Read 21 bytes {00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00} (IDFGH-12868)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
After I connect to the peer ble and I use esp_ble_gattc_read_char without sending any data, I get the event “ESP_GATTC_READ_CHAR_EVT”
I can confirm that the opposite end is not sending any data, and the opposite end is another development board with verified ble interaction with the Android phone.
        case ESP_GATTC_READ_CHAR_EVT:
            if(param->read.status == ESP_GATT_OK){
                m_readlen = param->read.value_len;
                ESP_LOGI(LOG_TAG, "GATTDevice.cpp Read %d bytes", m_readlen);
                ESP_LOG_BUFFER_HEX(LOG_TAG, param->read.value, m_readlen);
                memcpy(m_readbuff, param->read.value, m_readlen);
                m_readbuff[m_readlen] = 0;
            }
            else{
                m_readlen = 0;
            }
            m_lock->Unlock();
            break;

outputs:
I (43311) GATTDevice: GATTDevice.cpp Read 21 bytes
I (43311) GATTDevice: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
I (43321) GATTDevice: 00 00 00 00 00

I'd like to know what the 21 bytes means.

Another noteworthy piece of information is that
I will see these logs when I call esp_ble_gattc_write_char or  esp_ble_gattc_read_char after:
outputs:
W (7100) BT_HCI: hci cmd send: disconnect: hdl 0x0, rsn:0x13
W (7100) BT_APPL: gattc_conn_cb: if=3 st=0 id=3 rsn=0x16
W (7110) BT_HCI: hcif disc complete: hdl 0x0, rsn 0x16
W (7120) GATTDevice: GATT event 0x5
W (7120) GATTDevice: ESP_GATTC_CLOSE_EVT status:0 conn_id:0 remote_bda:cd:fb:50:e6:33:fe reason:0x0
W (7130) GATTDevice: GATT event 0x29
W (7130) GATTDevice: ESP_GATTC_DISCONNECT_EVT reason:0x16 conn_id:0 remote_bda:cd:fb:50:e6:33:fe

In the idf sdk I see that the esp_ble_gattc_open I'm using is defined in the esp-idf-v5.2.1\components\bt\host\bluedroid\api\esp_gattc_api.c
The #if (BLE_42_FEATURE_SUPPORT == TRUE) scope.
Does this mean I am using BLE 4.2 GATTC?
If the peer is not BLE4.2, could that be the cause of the problem?

Resolved.
The problem with 21-bit 0 is that the slave sets these 0 in characteristic.
The reason for the disconnection may be that I did not receive the slave's notify, which caused the slave to think that it had timed out, so it actively disconnected.
So my problem is because I thought I should read char on this feature, but the slave is designed to reply to the data via notify, not read.
Knowing this, I have solved all my problems.

Thank you for your report. Feel free to ask if you encounter any other issues later on.


oldChildren.length -> oldChildrenLength to save a few bytes

Since the length is saved in line:29, we can use it right?

Coverage remained the same at 100.0% when pulling e37d272eccaec0642f3aa1da97feb70551f9d983 on yuqianma:oldChildrenLength into<PHONE_NUMBER>5df10c2a17482f27ef386f9a741476 on developit:master.

👏


input data

Hi iprada,
If the tool is dedicated for DNA-seq data from circular amplification or it can be used to identify circular DNAs from WGS data? Can we use HiFi reads as well?
Is it possible to use minimap for the mapping step ?
thank you

Hi Carole,
Thanks for your question.
The tool is designed with short reads in mind and should not work optimally for HiFi. If you want to use it with long reads giving a look at our Molecular Cell paper (Henriksen et al.,) might help you. Rasmus Henriksen developed a method to detect circles from long reads and takes minimap2 as input. I also recall skimming through some papers with long reads in mind lately, but I do not work with circles anymore and I am far from being updated with the literature. Some simple literature search might point you to new tools.
I hope this helps and happy circle hunting
Best,
Iñigo
From: Carole Belliardo @.>
Reply to: iprada/Circle-Map @.>
Date: Wednesday, 2 August 2023 at 18.06
To: iprada/Circle-Map @.>
Cc: Subscribed @.>
Subject: [iprada/Circle-Map] input data (Issue #95)
Hi iprada,
If the tool is dedicated for DNA-seq data from circular amplification or it can be used to identify circular DNAs from WGS data? Can we use HiFi reads as well?
Is it possible to use minimap for the mapping step ?
thank you
—
Reply to this email directly, view it on GitHubhttps://github.com/iprada/Circle-Map/issues/95, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGB2FW2PAHM6YL47AKADWYLXTJ3IJANCNFSM6AAAAAA3BQAESQ.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


[Bug] Unable to drag TitleBar when maximized

After updating to 3.1.16, if the MicaWindow is maximized and you try to drag the title bar down to move it around, the window stays maximized and doesn't move.
On 3.1.15, the TitleBar drags correctly.
Also, 3.1.16 's TitleBar is much bigger in height compared to 3.1.15 and I think the 3.1.15 height is better as it matches every other Windows applications' TitleBar height.

Normally it is dictated by the CaptionHeight the issue I had with the old titlebar is this

The button is not the same size for some reason (It is the one by Windows)
I will take A look at what I can do.
Maybe I will revert the change for now you can Use 3.1.15

That issue with the maximize button is an issue across all Win32 apps that use the dark mode title bar provided by the undocumented api. If you look at file explorer it has the same issue.

And the custom buttons a big issue I'll get used to it haha...some apps such as MS Office have the same big custom caption buttons. However the critical issue is being unable to drag the TitleBar to move the window when maximized.

Also, even for the title bar height if we can define the CaptionHeight property on the window to make it as big or small as we choose and the custom caption buttons will scale with it that'll work

I'll add an option probably for the Legacy (Windows TitleBar) and the New TitleBar I will see when I come back from work

FYI: see https://stackoverflow.com/questions/24654845/dragging-custom-window-title-bar-from-top-when-maximized-does-not-work for dragging with custom TitleBar

Here is my plan:
Add 2 new Property to the Windows:

TitleBarHeight (Will scale de button properly)
TitleBarType

And an enum for the TitleBarType:
enum TitleBarType
{
WinUI,
Win32 (Default)
}

I will start working on It once I am back from work.

Now with the new one it is responsive to the TitleBarHeight
TitleBarHeight="50"
TitleBarType="WinUI"

If you want the old one:
TitleBarType="Win32"

(P.S I've tested and dragging the titlebar works in both cases)

Pushed version 3.1.17

I'm getting this error from my splash screen:

  | StackTrace | "   at System.Runtime.CompilerServices.CastHelpers.Unbox(Void* toTypeHnd, Object obj)\r\n   at MicaWPF.Controls.MicaWindow.get_TitleBarType()\r\n   at MicaWPF.Controls.MicaWindow.OnSourceInitialized(EventArgs e)\r\n   at System.Windows.Window.CreateSourceWindow(Boolean duringShow)\r\n   at System.Windows.Window.CreateSourceWindowDuringShow()\r\n   at System.Windows.Window.SafeCreateWindowDuringShow()\r\n   at System.Windows.Window.ShowHelper(Object booleanBox)\r\n   at System.Windows.Window.Show()\r\n   at System.Windows.Window.ShowDialog()\r\n   at NickvisionApp.App.OnStartup(StartupEventArgs e) in C:\\Users\\nlogo\\OneDrive\\Documents\\Programming\\NickvisionApp\\NickvisionApp\\App.xaml.cs:line 15\r\n   at System.Windows.Application.<.ctor>b__1_0(Object unused)\r\n   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)\r\n   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)\r\n   at System.Windows.Threading.DispatcherOperation.InvokeImpl()\r\n   at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)\r\n   at MS.Internal.CulturePreservingExecutionContext.CallbackWrapper(Object obj)\r\n   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)" | string

Defined as
<mica:MicaWindow x:Class="NickvisionApp.Views.SplashDialogView"
                 xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
                 xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
                 xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
                 xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
                 xmlns:behaviors="http://schemas.microsoft.com/xaml/behaviors"
                 xmlns:mica="clr-namespace:MicaWPF.Controls;assembly=MicaWPF"
                 xmlns:hc="https://handyorg.github.io/handycontrol"
                 xmlns:nickvision="clr-namespace:Nickvision.WPF.Controls;assembly=Nickvision.WPF"
                 xmlns:local="clr-namespace:NickvisionApp.Views"
                 mc:Ignorable="d" Name="Dialog" Width="500" Height="300" ShowInTaskbar="False"
                 WindowStartupLocation="CenterScreen" ResizeMode="NoResize" SystemBackdropType="Mica">

Just from upgrading to 3.1.19, not changing anything.

I am a complete Idiot forgot to change this when I copy pasted my code:
//Is Right now:
    public TitleBarType TitleBarType
    {
        get => (TitleBarType)GetValue(MarginMaximizedProperty);
        set => SetValue(MarginMaximizedProperty, value);
    }

//Should be:
    public TitleBarType TitleBarType
    {
        get => (TitleBarType)GetValue(TitleBarTypeProperty);
        set => SetValue(TitleBarTypeProperty, value);
    }

I am a complete Idiot forgot to change this when I copy pasted my code:

//Is Right now:

    public TitleBarType TitleBarType

    {

        get => (TitleBarType)GetValue(MarginMaximizedProperty);

        set => SetValue(MarginMaximizedProperty, value);

    }

//Should be:

    public TitleBarType TitleBarType

    {

        get => (TitleBarType)GetValue(TitleBarTypeProperty);

        set => SetValue(TitleBarTypeProperty, value);

    }

Haha no worries we've all had our fair share of copy paste bugs

Pushing version 3.1.20 right now

Ok just updated.
With TitleBarType="Win32" everything works fine no problems.
However, when I change TitleBarType="WinUI" and have WindowState="Maximized", the window enters a fullscreen mode which hides the taskbar and prevents dragging the window down from the TitleBar to exit maximize mode.
Whereas, with Win32 TitleBar mode, when WindowState="Maximized", the window sits above the TaskBar, and dragging the window down from the TitleBar works as expected.

Ok just updated. With TitleBarType="Win32" everything works fine no problems. However, when I change TitleBarType="WinUI" and have WindowState="Maximized", the window enters a fullscreen mode which hides the taskbar and prevents dragging the window down from the TitleBar to exit maximize mode. Whereas, with Win32 TitleBar mode, when WindowState="Maximized", the window sits above the TaskBar, and dragging the window down from the TitleBar works as expected.

I've found out why in WPF there is a known issue that a WindowStyle="None" goes over the taskbar I've added a Hook now it shouldn't go over it.

Pushing 3.1.21 now

Ok, taskbar issue is fixed.
However, when using TitleBarType="WinUI" and having the window maximized, there is this weird extra padding around the window.
Not maximized:

Maximized:

Using Win32 TitleBar and Maximized:

Ah probably the compensation I needed to add to the Win32 mode I will disable it for WinUI mode

Fixed the padding

Pushing version 3.1.22

Um...with updating to 3.1.22, the padding issue still occurs when using WinUI TitleBar. But now for both maximized and not maximized.
Not Maximized:

Win32 Not Maximized:

Maximized:

Win32 Maximized:

I've tried now with a controls that goes right to the edge the padding should be gone now
Pushing version 3.2.23

Ok figured out the issue.
So with TitleBarType="WinUI" and WindowState="Normal", yes the padding is gone. However, when  WindowState="Maximize" in the Window XAML, then the padding is there and doesn't go away even when the window is out of maximize.

Also, I have a dual-monitor setup and when the TitleBar type is WinUI, the maximized window doesn't cover the taskbar on the primary monitor, however, when the window is moved to my second monitor and maximized again, the window will cover the taskbar on the second monitor.

I figured the issues.
It was checking the WindowState only on update now it looks for it when it changes and when it starts.
For dual monitors i've figured how to fix it pushing update 3.1.24 now.

No problem thx for your contribution to be honest I wouldn't have noticed most of the bugs you submitted!

Padding fixed in 3.1.24

However, the dual monitor situation has not.
My primary monitor is 1920x1080 and my secondary monitor is 2048x1152.
Moving the application from my primary monitor to the secondary monitor with 3.1.24 causes the window on the second monitor to still cover the task bar and by stretched out and overlaps back onto the primary monitor as such:

Weard how it works on my 3 monitor

s

Are your 3 monitors all the same resolution? Could be when I move from my primary to secondary, the window isn't scaled to the higher resolution of the second.

Ah I think I found out why I am using the cursor position instead of the window position let me change that.

Pushing 3.1.25

Waiting for the Nuget...funny how a little custom TaskBar can cause all these windowing issues

I should have tested it more rigorously before pushing the feature to production, Well this is my first big public project I will learn from my errors.

Haha no worries, I completely understand. I have one too (https://github.com/nlogozzo/Nickvision.WPF) and I push out updates for 1 line code changes all the time lol that I just glossed over.

  (V3.1.25) xD
Insert table flipping
I will check my math

I will check from work tomorrow could be caused by the fact that your 2 monitors are not of the same size (I got 2 different size monitors at work.)

Sounds good! Thanks!

Status update?

Hello, sorry for the delay I catched a stomach flu

Oh no! Hoping for a speedy recovery!!
If your up for it, I was thinking maybe you can replicate the bug in your home machine by changing the resolution of one of the monitors 🤷🏻♂
But only if you feel up to coding haha...no rush

It does the issue only if my MAIN monitor is a lower resolution than my second monitors.
I will investigate why:

Glad to see you are doing better :)
Let me download and test the update...

All issues fixed. Everything works perfectly, thanks for all the work!


Back label font size behaves inconsistently after transition with iOS system text scaling.

Hi,
Thanks for your hard work and for this great library!
I’ve encountered an issue with the back button label text size change in the widget when the iOS system text size scaling is enabled.
Steps to reproduce
On iOS, after adjusting the system’s text size (Settings > Display & Brightness > Text Size), the back button label behaves unexpectedly during a screen transition.
Here is my iOS font size setting:

Here is the side-by-side comparison of font size changes during the transition animation:

This situation happens on both BackChevron, BackLabel and title.
The above screenshots are from the example on the master branch. I have tested this on both Flutter 3.24.3 and 3.22.2.
I’ve also recorded a short video that demonstrates the issue more clearly, making it easier to observe the behavior.
https://github.com/user-attachments/assets/cf64c357-6ca3-48bd-9293-668d6e4c2f6b

I reviewed the implementation of this component and noticed that MediaQuery.withNoTextScaling is used at top level to prevent scaling for navigation-related components.
However, it seems that this behavior is not fully applied to the backLabel and backChevron. I tried printing the current textScaleFactor inside the backLabel component (as shown in the screenshot), and the output was 0.83, which matches the smallest scaling factor set in my iOS system settings.

I tried wrapping the BackLabel (and chevron) component with MediaQuery.withNoTextScaling, and the issue was resolved.

I haven’t delved deeply into your source code, so I’m not sure if adding MediaQuery.withNoTextScaling separately to all components like label, chevron, and title aligns with your original design intentions. If this approach seems appropriate, I’d be happy to submit a PR to help fix the issue.
Please feel free to let me know if you need any further information, and thanks again for creating this library. In my opinion, it’s by far the most iOS-like navigation bar in the Flutter ecosystem.


Comparison table is not rendered properly

This commit might be the cause.

Thanks for the issue!
The cause is GitHub changing their markdown parser, unfortunately. I was hoping for them to catch up and fix it...

Fixed


Add eagerScalingStrategy for ScaledJob

Added eagerScalingStrategy for ScaledJob
Checklist

[x] When introducing a new scaler, I agree with the scaling governance policy
[x] I have verified that my change is according to the deprecations & breaking changes policy
[x] Tests have been added
[x] Changelog has been updated and is aligned with our changelog requirements
[x] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[x] A PR is opened to update the documentation on (repo) (if applicable)
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5114

Relates to #

Could you please open pr in https://github.com/kedacore/keda-docs/ to cover this new feature?

Sure, thanks! Will do that.

/run-e2e internal

@zroubalik Hi there, I'm sorry that the e2e test didn't go well. I'm glad to analyze the logs, although it seems that I don't have access to it.

@junekhan you should be able to access the logs by following these steps (let me know if you are not):

@zroubalik Thanks for your input. I have no problem accessing the test suite log you mentioned, but I was looking for the log from inside the cluster, which can contain information about how the scaling decision was made. The test suite log only shows that the scaling didn't happen a single time, otherwise, I didn't find any clues.

@zroubalik Thanks for your input. I have no problem accessing the test suite log you mentioned, but I was looking for the log from inside the cluster, which can contain information about how the scaling decision was made. The test suite log only shows that the scaling didn't happen a single time, otherwise, I didn't find any clues.

At the bottom of the output, there's log from KEDA operator as well. That's the best we can do, you can always run the failed test locally:  https://github.com/kedacore/keda/tree/main/tests#specific-test

@zroubalik Thanks for your input. I have no problem accessing the test suite log you mentioned, but I was looking for the log from inside the cluster, which can contain information about how the scaling decision was made. The test suite log only shows that the scaling didn't happen a single time, otherwise, I didn't find any clues.

At the bottom of the output, there's log from KEDA operator as well. That's the best we can do, you can always run the failed test locally: https://github.com/kedacore/keda/tree/main/tests#specific-test

@zroubalik Thanks for your hint! That looks daunting 😨  but I will try.

I got this error when setting up the e2e test. Any thoughts?
GOOS="darwin" go test -v -tags e2e ./utils/setup_test.go
# runtime/cgo
_cgo_export.c:3:10: fatal error: 'stdlib.h' file not found
FAIL	command-line-arguments [build failed]
FAIL

I got this error when setting up the e2e test. Any thoughts?
GOOS="darwin" go test -v -tags e2e ./utils/setup_test.go
# runtime/cgo
_cgo_export.c:3:10: fatal error: 'stdlib.h' file not found
FAIL	command-line-arguments [build failed]
FAIL

Solved by export SDKROOT="$(xcrun --sdk macosx --show-sdk-path)"
Do you like me to update the document in case other developers get caught?

=== RUN   TestVerifyCommands
--- PASS: TestVerifyCommands (0.00s)
=== RUN   TestKubernetesConnection
--- PASS: TestKubernetesConnection (0.00s)
=== RUN   TestKubernetesVersion
    setup_test.go:38: kubernetes version: Client Version: v1.29.4
        Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
        Server Version: v1.30.1
--- PASS: TestKubernetesVersion (1.12s)
=== RUN   TestSetupHelm
Password:
--- PASS: TestSetupHelm (11.51s)
=== RUN   TestSetupAzureManagedPrometheusComponents
    helper.go:548: Applying template: azureManagedPrometheusConfigMapTemplate
--- PASS: TestSetupAzureManagedPrometheusComponents (1.38s)
=== RUN   TestSetupCertManager
    setup_test.go:68: skipping cert manager is not required
--- SKIP: TestSetupCertManager (0.00s)
=== RUN   TestSetupWorkloadIdentityComponents
    setup_test.go:90: skipping as workload identity tests are disabled
--- SKIP: TestSetupWorkloadIdentityComponents (0.00s)
=== RUN   TestSetupAwsIdentityComponents
    setup_test.go:112: skipping aws identity tests are disabled
--- SKIP: TestSetupAwsIdentityComponents (0.00s)
=== RUN   TestSetupGcpIdentityComponents
    setup_test.go:134: skipping gcp identity tests are disabled
--- SKIP: TestSetupGcpIdentityComponents (0.00s)
=== RUN   TestSetupOpentelemetryComponents
    setup_test.go:173: skipping installing opentelemetry
--- SKIP: TestSetupOpentelemetryComponents (0.00s)
=== RUN   TestDeployKEDA
    helper.go:246: deleting namespace keda
    helper.go:299: waiting for namespace keda deletion
    helper.go:233: Creating namespace - keda
    setup_test.go:229:
        	Error Trace:	/Users/june/Projects/gitroot/keda/tests/utils/setup_test.go:229
        	Error:      	Received unexpected error:
        	            	bash: /Users/june/Projects/gitroot/keda/bin/controller-gen: cannot execute binary file
        	            	make: *** [manifests] Error 126
        	Test:       	TestDeployKEDA
        	Messages:   	error deploying KEDA - bash: /Users/june/Projects/gitroot/keda/bin/controller-gen: cannot execute binary file
        	            	make: *** [manifests] Error 126
--- FAIL: TestDeployKEDA (2.47s)
=== RUN   TestVerifyKEDA
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-operator, Current  - 0, Target - 1
    setup_test.go:240:
        	Error Trace:	/Users/june/Projects/gitroot/keda/tests/utils/setup_test.go:240
        	Error:      	Should be true
        	Test:       	TestVerifyKEDA
        	Messages:   	replica count should be 1 after 3 minutes
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-metrics-apiserver, Current  - 0, Target - 1
    setup_test.go:242:
        	Error Trace:	/Users/june/Projects/gitroot/keda/tests/utils/setup_test.go:242
        	Error:      	Should be true
        	Test:       	TestVerifyKEDA
        	Messages:   	replica count should be 1 after 3 minutes
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - keda-admission, Current  - 0, Target - 1
    setup_test.go:244:
        	Error Trace:	/Users/june/Projects/gitroot/keda/tests/utils/setup_test.go:244
        	Error:      	Should be true
        	Test:       	TestVerifyKEDA
        	Messages:   	replica count should be 1 after 3 minutes
--- FAIL: TestVerifyKEDA (549.92s)
=== RUN   TestSetUpStrimzi
    setup_test.go:253: --- installing kafka operator ---
    helper.go:246: deleting namespace strimzi
    helper.go:299: waiting for namespace strimzi deletion
    helper.go:233: Creating namespace - strimzi
panic: test timed out after 10m0s
running tests:
	TestSetUpStrimzi (34s)

goroutine 191 [running]:
testing.(*M).startAlarm.func1()
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/testing/testing.go:2366 +0x30c
created by time.goFunc
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/time/sleep.go:177 +0x38

goroutine 1 [chan receive]:
testing.(*T).Run(0x140000db520, {0x105b12f3d?, 0x1400019db38?}, 0x1060bb7a8)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/testing/testing.go:1750 +0x32c
testing.runTests.func1(0x140000db520)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/testing/testing.go:2161 +0x40
testing.tRunner(0x140000db520, 0x1400019dc58)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/testing/testing.go:1689 +0xec
testing.runTests(0x1400000ee70, {0x106c9bd40, 0xd, 0xd}, {0x1400019dd18?, 0x104bf1ef0?, 0x106cb2900?})
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/testing/testing.go:2159 +0x3b0
testing.(*M).Run(0x140005b43c0)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/testing/testing.go:2027 +0x5a4
main.main()
	_testmain.go:71 +0x16c

goroutine 188 [syscall]:
syscall.syscall6(0xc?, 0x14000051d50?, 0x1000110?, 0x1070c6720?, 0x90?, 0x106e1cf18?, 0x90?)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/runtime/sys_darwin.go:45 +0x68
syscall.wait4(0x14000051d18?, 0x104b9e0c8?, 0x90?, 0x106057320?)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/syscall/zsyscall_darwin_arm64.go:44 +0x4c
syscall.Wait4(0x1400027e0e0?, 0x14000051d54, 0x14000268160?, 0x106e1cf40?)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/syscall/syscall_bsd.go:144 +0x28
os.(*Process).wait(0x14000048600)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/os/exec_unix.go:43 +0x80
os.(*Process).Wait(...)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/os/exec.go:134
os/exec.(*Cmd).Wait(0x14000464000)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/os/exec/exec.go:897 +0x38
os/exec.(*Cmd).Run(0x14000464000)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/os/exec/exec.go:607 +0x38
os/exec.(*Cmd).Output(0x14000464000)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/os/exec/exec.go:991 +0xbc
github.com/kedacore/keda/v2/tests/helper.ExecuteCommand({0x14000460000?, 0x78?})
	/Users/june/Projects/gitroot/keda/tests/helper/helper.go:127 +0x24
command-line-arguments.TestSetUpStrimzi(0x140005f8000)
	/Users/june/Projects/gitroot/keda/tests/utils/setup_test.go:263 +0x220
testing.tRunner(0x140005f8000, 0x1060bb7a8)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/testing/testing.go:1689 +0xec
created by testing.(*T).Run in goroutine 1
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/testing/testing.go:1742 +0x318

goroutine 114 [IO wait]:
internal/poll.runtime_pollWait(0x10ddaa858, 0x72)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/runtime/netpoll.go:345 +0xa0
internal/poll.(*pollDesc).wait(0x14000056b00?, 0x140006aa000?, 0x0)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/internal/poll/fd_poll_runtime.go:84 +0x28
internal/poll.(*pollDesc).waitRead(...)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Read(0x14000056b00, {0x140006aa000, 0x1300, 0x1300})
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/internal/poll/fd_unix.go:164 +0x200
net.(*netFD).Read(0x14000056b00, {0x140006aa000?, 0x107172308?, 0x140004628d0?})
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/net/fd_posix.go:55 +0x28
net.(*conn).Read(0x1400048e098, {0x140006aa000?, 0x140003898f8?, 0x104af0dfc?})
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/net/net.go:179 +0x34
crypto/tls.(*atLeastReader).Read(0x140004628d0, {0x140006aa000?, 0x0?, 0x140004628d0?})
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/crypto/tls/conn.go:806 +0x40
bytes.(*Buffer).ReadFrom(0x140001e9430, {0x1060c3820, 0x140004628d0})
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/bytes/buffer.go:211 +0x90
crypto/tls.(*Conn).readFromUntil(0x140001e9188, {0x107175018, 0x1400048e098}, 0x140003899d0?)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/crypto/tls/conn.go:828 +0xd0
crypto/tls.(*Conn).readRecordOrCCS(0x140001e9188, 0x0)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/crypto/tls/conn.go:626 +0x35c
crypto/tls.(*Conn).readRecord(...)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/crypto/tls/conn.go:588
crypto/tls.(*Conn).Read(0x140001e9188, {0x140003bd000, 0x1000, 0x104b24f54?})
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/crypto/tls/conn.go:1370 +0x168
bufio.(*Reader).Read(0x140003b6480, {0x140001b0ac0, 0x9, 0x104ae9208?})
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/bufio/bufio.go:241 +0x1b4
io.ReadAtLeast({0x1060c2718, 0x140003b6480}, {0x140001b0ac0, 0x9, 0x9}, 0x9)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/io/io.go:335 +0xa0
io.ReadFull(...)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/io/io.go:354
golang.org/x/net/http2.readFrameHeader({0x140001b0ac0, 0x9, 0x105ebbe20?}, {0x1060c2718?, 0x140003b6480?})
	/Users/june/Projects/gitroot/keda/vendor/golang.org/x/net/http2/frame.go:237 +0x58
golang.org/x/net/http2.(*Framer).ReadFrame(0x140001b0a80)
	/Users/june/Projects/gitroot/keda/vendor/golang.org/x/net/http2/frame.go:498 +0x78
golang.org/x/net/http2.(*clientConnReadLoop).run(0x14000389f98)
	/Users/june/Projects/gitroot/keda/vendor/golang.org/x/net/http2/transport.go:2429 +0xcc
golang.org/x/net/http2.(*ClientConn).readLoop(0x140001b2300)
	/Users/june/Projects/gitroot/keda/vendor/golang.org/x/net/http2/transport.go:2325 +0x5c
created by golang.org/x/net/http2.(*ClientConn).goRun in goroutine 49
	/Users/june/Projects/gitroot/keda/vendor/golang.org/x/net/http2/transport.go:369 +0x38

goroutine 95 [IO wait]:
internal/poll.runtime_pollWait(0x10ddaaa48, 0x72)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/runtime/netpoll.go:345 +0xa0
internal/poll.(*pollDesc).wait(0x14000118420?, 0x14000470035?, 0x1)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/internal/poll/fd_poll_runtime.go:84 +0x28
internal/poll.(*pollDesc).waitRead(...)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Read(0x14000118420, {0x14000470035, 0x3cb, 0x3cb})
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/internal/poll/fd_unix.go:164 +0x200
os.(*File).read(...)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/os/file_posix.go:29
os.(*File).Read(0x1400008a4a0, {0x14000470035?, 0x14000495d18?, 0x35?})
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/os/file.go:118 +0x70
bytes.(*Buffer).ReadFrom(0x1400024adb0, {0x1060c2358, 0x1400020e0f0})
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/bytes/buffer.go:211 +0x90
io.copyBuffer({0x1060c27d8, 0x1400024adb0}, {0x1060c2358, 0x1400020e0f0}, {0x0, 0x0, 0x0})
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/io/io.go:415 +0x14c
io.Copy(...)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/io/io.go:388
os.genericWriteTo(0x4dfab4d35d8faf01?, {0x1060c27d8, 0x1400024adb0})
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/os/file.go:269 +0x5c
os.(*File).WriteTo(0x106c85af0?, {0x1060c27d8?, 0x1400024adb0?})
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/os/file.go:247 +0x60
io.copyBuffer({0x1060c27d8, 0x1400024adb0}, {0x1060c2418, 0x1400008a4a0}, {0x0, 0x0, 0x0})
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/io/io.go:411 +0x98
io.Copy(...)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/io/io.go:388
os/exec.(*Cmd).writerDescriptor.func1()
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/os/exec/exec.go:577 +0x44
os/exec.(*Cmd).Start.func2(0xde6ec38e337578a3?)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/os/exec/exec.go:724 +0x34
created by os/exec.(*Cmd).Start in goroutine 188
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/os/exec/exec.go:723 +0x7cc

goroutine 96 [IO wait]:
internal/poll.runtime_pollWait(0x10ddaa950, 0x72)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/runtime/netpoll.go:345 +0xa0
internal/poll.(*pollDesc).wait(0x140001184e0?, 0x14000172000?, 0x1)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/internal/poll/fd_poll_runtime.go:84 +0x28
internal/poll.(*pollDesc).waitRead(...)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Read(0x140001184e0, {0x14000172000, 0x8000, 0x8000})
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/internal/poll/fd_unix.go:164 +0x200
os.(*File).read(...)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/os/file_posix.go:29
os.(*File).Read(0x1400008a4b8, {0x14000172000?, 0xc2e0ba21115d1301?, 0x1dcbdad175b3ceb6?})
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/os/file.go:118 +0x70
io.copyBuffer({0x1060c2858, 0x14000154000}, {0x1060c2358, 0x1400048e4f0}, {0x0, 0x0, 0x0})
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/io/io.go:429 +0x18c
io.Copy(...)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/io/io.go:388
os.genericWriteTo(0x1?, {0x1060c2858, 0x14000154000})
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/os/file.go:269 +0x5c
os.(*File).WriteTo(0x106c85af0?, {0x1060c2858?, 0x14000154000?})
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/os/file.go:247 +0x60
io.copyBuffer({0x1060c2858, 0x14000154000}, {0x1060c2418, 0x1400008a4b8}, {0x0, 0x0, 0x0})
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/io/io.go:411 +0x98
io.Copy(...)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/io/io.go:388
os/exec.(*Cmd).writerDescriptor.func1()
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/os/exec/exec.go:577 +0x44
os/exec.(*Cmd).Start.func2(0xf6430d8d9376ca4?)
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/os/exec/exec.go:724 +0x34
created by os/exec.(*Cmd).Start in goroutine 188
	/opt/homebrew/Cellar/go/1.22.4/libexec/src/os/exec/exec.go:723 +0x7cc
FAIL	command-line-arguments	600.336s
FAIL

Although it didn't pan out well in a while.

Could you please rerun the checks? The result doesn't make sense.

@junekhan so sorry for the delay, I have been busy and missed the notification

/run-e2e internal


Use a folder reference instead of groups for the functional tests

As suggested by @mike-ferris-apple https://github.com/modocache/swift-corelibs-xctest/commit/9466dc1990c89624e60913669a5ff225fb147213#commitcomment-16524676
This removes the need for people to explicitly add new functional tests to Xcode for them to be browsable, since Xcode doesn't care about them during its native build process anyway.

Pulled it down to try it--looks good to me! One silly thing I'll miss: I used to be able to temporarily add the files to the corelibs-xctest target in order to get autocompletion and syntax highlighting from Xcode. :stuck_out_tongue_closed_eyes:
@mike-ferris-apple could you ask @swift-ci to please test? :bow:

Hmm that's actually not entirely silly at all. I remember doing the same from time to time and appreciating letting the IDE help me out more.
Still, I think that if we are feeling the urge to do that frequently, it may be a sign that the functional tests are too complex. In any case, it's still possible to pop the file into the target, it just requires a few more clicks than before.

@swift-ci please test

@swift-ci Please test

The OS X check is broken until xcodebuild uses the latest Swift toolchain. (Still, I'm hesitant to disable the OS X path in the Swift build script, since I believe this xcodebuild problem will be fixed in the CI infra.)
This seems good to merge, so I went ahead and merged. Thanks, @briancroom!

Wow, one really nice thing about this change is that I can easily see the output of the functional tests, right in Xcode:

That more than makes up for the lack of autocompletion. Thanks @briancroom! :bouquet:

Ohhh, nice! That's beautiful.
Thanks @mike-ferris-apple for pointing out this improvement.


Implement AMSMath's \dots

I spent a few hours reading AMSMath's source code for \dots.  Wow, what a beast!  This should be a full implementation (fixing #528), except for one issue:
I don't know how to add some positive or negative space left or right of a symbol returned by a function, which is what should happen for \dotsi and dotso in some cases (as described in the TODO comments).  Is there an easy way to do this?

Hmm, I'm having another problem.  Even with the PR code as is,  which returns a symbol similar to existing \bigvee, rendering \dots gives me a warning:
No character metrics for '…' in style 'Size1-Regular'
groupTypes.op() seems to set the fontName to 'Size1-Regular' or 'Size2-Regular', but I don't understand how fonts work, so I'm not sure whether this is correct...  \ldots works fine, using font 'Main-Regular' I assume.  The warning is problematic as it leads to the character being higher than intended.  (Same thing with \cdots+ which expands to \cdots+.)
Relatedly, I'm vaguely worried that my \dots macro is returning an type: "op" instead of a type: "inner", but maybe that's OK...  (As I understand the existing function infrastructure, it would be impossible to return a type: "inner" with a string as a value.)  Not sure whether this will affect spacing, though.

Seeing macro support in #605, I wonder if it would make more sense to have \dots expanded at the macro level, so that it can literally expand to an \ldots, \cdots, \!\cdots, \cdots\,, etc. and be reparsed accordingly.  This is how it works in TeX, of course.
But currently functions can't return strings.  Does this seem like a good direction to go?  If so, I can try.

@edemaine thanks for the PR.  I checked out your branch.  The wrong font is definitely a problem.  A person could fix groupTypes.op in buildHTML.js, but that seems hacky.  It would be great if we could use macros for this, but this seems doubtful with our current macro support b/c it looks like we'd need conditionals which we don't have yet.  In the short term maybe we set type: "inner" instead of type: "op".  It clears up the font issue and appears to be what LaTeX is doing:
Running the following using pdflatex:
\documentclass{article}
\usepackage{amsmath}
\begin{document}
\tracingonline=1
\showboxbreadth=\maxdimen
\showboxdepth=\maxdimen
$1\dots n\showlists$
\end{document}

produces the following (partial) output:
\mathord
.\fam0 1
\mathinner
.\mathpunct
..\fam1 :
.\mathpunct
..\fam1 :
.\mathpunct
..\fam1 :
\mathord
.\fam1 n

Please ignore the suggestion in my previous comment... it doesn't actually work. :(

Yeah, op is pretty magical/special.
How crazy would it be to add support for returning a string from a defined function, and having that trigger macro expansion? That's exactly what I want here... (\dots returning \ldots or etc.)  Alternatively, adding support for Javascript functions in a defined macro...

Returning a string from a function would work as a shortcut, but calling something else might be better. Doing macro expansion there might be tricky, since built-in functions are working on the level of parse tree nodes, not input text tokens. What we could do is parse a whole string using a separate parser instance, and then extract the root node out of that tree and include it in the current tree. This should work well for some simple functions, but might be problematic once you have arguments or state to deal with.

@gagern What if I moved this from a function to a macro, adding support for functions in defineMacro?  I think that would be the right place to do this, assuming macros have nextToken defined...  (In TeX, there are no functions, only macros...)

Right now, macros don't have access to the next token, but perhaps we should change that. In the long run we'll want to support things like \@ifstar, which in turn builds on \futurelet. The question is, do you need the next token from the input stream, or the next unexpandable token from the final stream handed on to the parser? The former we get from the lexer, the latter from the macro expander. In either case it should be OK to unget the token once we have examined it, although we have to be careful about whitespace handling if we got the token from the lexer instead.

I checked the amsmath code, and it uses \expandafter, so I believe we want the next unexpandable token from the final stream (latter).  Relevant definitions:
\let\@xp=\expandafter
\DeclareRobustCommand{\dots}{%
  \ifmmode \@xp\mdots@\else \@xp\textellipsis \fi
}
\def\FN@{\futurelet\@let@token}
\def\mdots@{\FN@\mdots@@}

In general, though, I think we might need either one -- a plain \futurelet without these \expandafter shenanigans probably want the very next token in the input (former).  But maybe we can use direct access to the lexer in this case, via a context object.

What exactly does \expandafter do? Given input \expandafter\foo\bar I'd assume it would remove \foo from the sequence, then expand \bar one level, then put \foo back into the sequence and start the next cycle with expanding that. So it does not expand \bar as far as possible, that's what \edef is for.
I guess \expandafter could use two utility functions factored out from the current nextToken function: one to obtain the next token of input either from the stack or from the lexer, and one to perform a single level of expansion without doing so recursively. This should definitely be built on the argument-handling macro expander from #605, I'd say, so perhaps I should see after that first.

Ah, you're right about \expandafter.  See this tutorial.  In that case, actually, just getting the next unexpanded token from the lexer would do pretty well in our case, because we have so few macros, and rather have lots of functions and symbols.  The \expandafter in \dots is to get the \DOTSB etc. at the beginning of macros (which tell \dots what type of dots to be), but given that all our symbols are implemented via a different mechanism, this feature isn't critical to support in \dots at this time.
Anyway, I'd like to request that #605 be extended to allow a JavaScript function in defineMacro, which gives access to at least the lexer (presumably via a context object).  Then I can move this PR to use that instead.  Once \expandafter is also supported (which doesn't sound too difficult...), I can use it in \dots too.

I'd not modify #605; it already does contain three distinct features, which might make review slower than it would otherwise be. But having a branch build on #605 and posted as a separate PR either immediately or once that got merged sounds like a good idea. Usually I'd say I'll have a look, but I feel we are opening up new areas of development faster than we are closing them right now, so I'm not sure I'll get to that in a timely manner.

Sounds good; please reinterpret my request as features for a future follow-up to #605, then.  I agree that waiting for #605 to be approved first might make sense.  Then you or I can look at the requested extensions.

I think this should be closed right @edemaine?

@kohler Nope, still need to revise this to work with new macro parser. \dots remains unimplemented in KaTeX.

Are the screenshot images correct?  Here's what I get using quicklatex.com:

and KaTeX:

Definitely not correct.  There were various issues, described above, with building the parse structure directly.  Macros should let it actually expand to \cdots or \ldots.

@edemaine I'm going to check out your branch and see what's causing the square dots.

https://github.com/edemaine/KaTeX/pull/2 fixes the issue with square dots.

I'm not sure why the Dots screenshot test is failing now.

Should be replaced by #794.


Insane load when using slasher in HA setup

Relates to https://github.com/prysmaticlabs/prysm/issues/6519
Trying:

[x] enable-local-protection: true -> didn't help
[x] haproxy reties 0 on all backends -> didn't help
[x] validator --grpc-retries 0 -> didn't work
[x] validator enable-external-slasher-protection: false (was true) -> works
[ ] haproxy connection limit to beacon backend
[ ] slasher using --enable-historical-detection
[x] more ram -> works see https://github.com/prysmaticlabs/prysm/issues/6519#issuecomment-656642177

lgtm


Consider accepting three-dimensional edge Tensors for MatrixProductState

We could loose the current requirements that disallow creating a MatrixProductState where all the tensors are three-dimensional. In that case, we could just check that the dimension of the left and right index for the first and last Tensor, respectively, are one.
I think this could allow an easier implementation of the algorithms where MatrixProductState are used since it is easier to generalize the code, and we wouldn't have to worry about the boundary Tensors being different.
What do you think?

Related code moved to Qrochet.jl.


PR: Change subprocess.Popen to QProcess

Fixes #264

There's also a small conflict you need to fix now.


Unit tests: combine into one test file

Summary
What:
Right now we have firefox and chrome tests, both test files are 99% the same. Combine test files into one by defining test cases inside a loop
Why:
Test files are 99% the same, thus duplicating a tonne of a logic, this could be solved by looping through each browser typr
How:
Pserudo code impl
// tests/unit/client_test.ts
["firefox", "chrome"].forEach(type => {
Deno.test
(type + " goTo() ) => {} )
})

done as part of #91


Send Token & Swap Token Agent Benchmark

Create a multi-agent benchmark that uses the SendToken and SwapToken agents in tandem. The prompts should be sufficiently complex leading to 2+ tasks within the agent's execution plan.

We the introduction of autogen (https://github.com/polywrap/AutoTx/pull/142) and tests are passing more consistently although the send and swap complex test is at 50%
@dOrgJelli should we close this and open a new one for that case?

Let's move this work to #166


navigator is not defined - running react router on server

Debugger listening on port 5858
/Users/michaelbenin/Projects/express-react-isomorphic-fastboot/node_modules/react-router/lib/DOMUtils.js:50
  var ua = navigator.userAgent;
           ^
ReferenceError: navigator is not defined
    at supportsHistory (/Users/michaelbenin/Projects/express-react-isomorphic-fastboot/node_modules/react-router/lib/DOMUtils.js:50:12)
    at new BrowserHistory (/Users/michaelbenin/Projects/express-react-isomorphic-fastboot/node_modules/react-router/lib/BrowserHistory.js:52:54)
    at Object.<anonymous> (/Users/michaelbenin/Projects/express-react-isomorphic-fastboot/node_modules/react-router/lib/BrowserHistory.js:148:22)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/michaelbenin/Projects/express-react-isomorphic-fastboot/build/react_router/react_router.js:17:37)

we might still need to work out some things with server rendering on the master branch, but your log indicates you're using BrowserHistory, instead you need to create a location on the server var location = new Location(req.path, req.query);
https://rackt.github.io/react-router/tags/v1.0.0-beta1.html#Server Rendering

@ryanflorence  creating just a location without the history, throws an invariant error, and throughout the app it always refreshes the page


[WEB-740] Refactored AppBoySegment to SPM

📲 What
Refactor of this pr so no code changes are required.
🤔 Why
Wanted to ensure we had as minimal code changes as necessary.
🛠 How

Removed github "appboy/appboy-segment-ios" == 4.0.0 from Cartfile and Cartfile.resolved
Removed Segment.framework and Segment_Appboy.framework from app-input-files app-output-files library-input-files library-output-files
Removed all dependencies from project.pbxproj

Build Phases - Link Binary With Libraries
Kickstarter-Framework-iOSTests
Segment_Appboy.framework

Library
Segment.framework
Segment_Appboy.framework

Library-iOSTests
Segment_Appboy.framework

Kickstarter-iOS
Segment.framework
Segment_Appboy.framework

Build Phases - Copy Files

Library-Framework-iOSTests
Segment.framework
Segment_Appboy.framework

Kickstarter-Framework-iOSTests
Segment.framework
Segment_Appboy.framework

Used https://github.com/Appboy/appboy-segment-ios in SPM, only pulled in AppboySegment not AppboySegmentCore.

Only added AppboySegment to Kickstarter-FrameworkiOS and Library, nowehere else.

Made minor import corrections in

AppDelegate, BrazeTypes,
import Segment_Appboy --> import AppboySegment

KSRAnalytics
import Segment --> import AppboySegment

Segment
import Segment, import Segment_Appboy, import Appboy_iOS_SDK --> import AppboySegment

✅ Acceptance criteria

[ ] See that segment events are still being sent
[ ] Ensure Braze pn's and in-app messages are still working.

crashing on launch on device, one sec, maybe this does require more code changes.

SwiftFormat found issues:

File
Rules

Kickstarter-iOS/AppDelegate.swift:274:1
warning: (indent) Indent code in accordance with the scope level.

  Generated by :no_entry_sign: Danger

crashing on launch on device, one sec, maybe this does require more code changes.

No longer issue, last commit resolves a weird threading issue and prevents duplicate configuration on Analytics


Update our URL on https://github.com/cds-snc/status-statut #159

📇 User story
As a developer, I want the CDS service status website to track resources.alpha.canada.ca and ressources.alpha.canada.ca and not learning-resources.cdssandbox.xyz
✅ Definition of Done

[ ] The .upptimerc.yml is amended to include the new directive

📜 Acceptance criteria

[ ] The status page shows learning-resources.cdssandbox.xyz

📝 Notes
No PRs will be created on this repo, but rather on https://github.com/cds-snc/status-statut
This is a relatively easy task, and you do not need any knowledge of the Learning Resources' tech stack to complete this

Ticket opened on: https://github.com/cds-snc/status-statut/pull/130


Fix for LatheRecipe queue list icons appearing blank

About the PR

Fixed lathe recipes and the currently fabricating icon showing up incorrectly
Engine PR that updated ItemLists to use Layered textures, updated every instance that required a change
Requires https://github.com/space-wizards/RobustToolbox/pull/5191
Why / Balance

it look badd
Technical details

updating every declaration of Item's Icon/Texture to IconTextures/List
changed some obsolete frame0s to use the sprite system
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Before:
https://github.com/space-wizards/space-station-14/assets/58439124/c6688a24-c6fd-4ae0-970f-e5ed2f575cf8
After:
https://github.com/space-wizards/space-station-14/assets/58439124/29372abe-a4df-4e56-812d-06e1520c623b
Breaking changes

Changelog

:cl:

fix: Queued lathe recipe icons now appear correctly.

closed for jank


Mtl 1560

Adds enhanced disk resolution for more flexible deployments, such as single disked servers.

https://github.com/Cray-HPE/dracut-metal-mdsquash/pull/14
https://github.com/Cray-HPE/dracut-metal-dmk8s/pull/7
https://github.com/Cray-HPE/dracut-metal-luksetcd/pull/13

This will need to rebuild, since one or two of the RPMs hadn't published yet.


extract model.pushObjects to a method

...to allow overrides in the case when more specialized munging/manipulation might be required.
For one part of our app that needs infinite scroll, we have a slightly non-traditional API that requires a more complicated merging of our initial data and subsequent requests. This extremely minor change makes it much easier for us to use ember-infinity in that case.

I would suggest a README change to help others with this. Then squash commits and LGTM.

I updated the method signature and also renamed some variables so that infinityModel consistently refers to the route's model rather than the new objects to be added to it. Let me know if the README example which I c/ped from you is ok :grin:

this is perfect @asross - can you put up a simple test?  Once we've got some test coverage this is good to merge

Can u give it a quick squash?

Can u give it a quick squash?

Yep, done!

:+1:

Nice work.

Thanks!


feat: add issue templete

Add issue template, refer to https://github.com/NVIDIA/k8s-device-plugin/blob/main/.github/issue_template.md

@ArangoGutierrez will be able to comment on where we stand w.r.t. issue templates.


Generate suttle secrets file

I closed the PR because the git history is very dirty and I have not been able to fix it


Toolbar.js error when clicking on the switch button from the History panel

Hello,
There occurs some uncaught error in toolbar.js when I click on the "switch" button under the History panel.
Tried with Opera and Chrome.
Django debug toolbar version 3.1
Using default debug toolbar configurations.

Looks like a bug or some problem with my configuration?

Can you get the panelId that's being used to create the query selector for me?

I hope that is what you mean:

Is there a Timer Panel for you in the toolbar? And can you verify that a div with the selector .djdt-TimerPanel exists on the page?

Also, please include your configurations and your workflow to reproduce this issue.

Ah right, I can reproduce this. b0ba22765999003428c21bbd52dc405df7c5244d this will be the problem.
Replacing djDebug.querySelector('.djdt-'+panelId) with djDebug.querySelector('#djdt-'+panelId) seems to fix it for me.

@matthiask We should revisit #1251 as I think that would have caught this.

Ah right, I can reproduce this. b0ba227 this will be the problem.
Replacing djDebug.querySelector('.djdt-'+panelId) with djDebug.querySelector('#djdt-'+panelId) seems to fix it for me.

Yes, that fixed for me too.

@KStenK @tim-schilling 3.1.1 contains the fix referenced above.

@KStenK @tim-schilling 3.1.1 contains the fix referenced above.

Everything is working now via 3.1.1. Thanks ;)


Current problem scenario:
I have about 10,000 items that have the state "Unpublished" that I want to change to "Published".  For the past few days, GEOMG has frozen up when I try to do them all at once.

I am able to select all the items and choose "Published" from the State dropdown.
After this, the site freezes. If I clear the search and start over, it occasionally throws a Rails "We're sorry, something went wrong" message.
I am able to publish the records in small batches, but the site loads very sluggishly.

Just seeing this issue now. Can do some debugging early this afternoon.


Slate UI migration

Slate UI Migration using 3 layers of commits. 1.) Accepting updated file changes in SlateUI. 2.) Discarding all modified markdown files. 3.) Deleting all the unnecessary swagger files following the slate ui migration for API-Explorer.
*Please see notes for commits and comments to gain additional information.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.d.ra seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Kept header.html and head.html because both contained small styling adjustments that otherwise when removed adjusted the view. Header.html also contained various slate-ui changes in the pathname, those were the only immediate changes I noticed.
Jekyll breadcrumbs, looks like there were no actual changes from the original, but I replaced them with the original just in case. Same goes for the drops/breadcrumbe_item.rb. The remaining files have all been reset to their previous state.


[release-4.13] OCPBUGS-11387: bump(github.com/containers/common) to v0.51.2

Bump github.com/containers/common from v0.51.0 to v0.51.2, which puts CAP_SYS_CHROOT back into the default list of capabilities that we grant when handling RUN instructions.  Backported from #335.

/hold
I think you meant to do a pull request against release-4.13 instead of master?

/jira refresh

/hold cancel
I was able to change the branch
/approve
/lgtm
/label backport-risk-assessed
/label cherry-pick-approved


#816 Fix for google services issue (Firebase not initialized)

#816  Created pull request to fix google services issue, which causes app crash, after this with latest changes we need to do  window.FirebasePlugin.initFirebase()

Inserted the line after updating to 1.1.3 :
"Cannot read property 'initFirebase' of undefined"


Adding onBlur and onFocus

Small PR to allow callbacks for onBlur and onFocus

Sorry, can you make the PR to master instead?


move registry to root of networking/plugin

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hzxuzhonghu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [hzxuzhonghu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
c92a10701d3e61d06e3182eeef21369fc35923bb
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
c92a10701d3e61d06e3182eeef21369fc35923bb
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
c92a10701d3e61d06e3182eeef21369fc35923bb
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
c92a10701d3e61d06e3182eeef21369fc35923bb
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
c92a10701d3e61d06e3182eeef21369fc35923bb
link
/test istio-integ-local-tests

prow/istio-presubmit.sh
c92a10701d3e61d06e3182eeef21369fc35923bb
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-minProfile.sh
1baa583a9a05705c63f5ad8007c17a478005f480
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[Bug]: The Errors,Logs,Inspect Entity tabs on the query editor do not go away on navigating to the Edit DS page

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When I run a query or an api, and it errors out, if I open the Error tab [or Logs/Inspect Entity], and then with it open, I navigate to the Edit DS screen, the tabs remain open.
Steps To Reproduce

In an application, create a new api
Type some random, incorrect url, and run the api
Errors get generated in the console below.
Click on Error tab [or Logs/Inspect Entity tab]
Now navigate to Data-> go to any datasource, and click to edit the datasource details
Note that the Error tab Error tab [or Logs/Inspect Entity tab] do not get closed.

https://github.com/appsmithorg/appsmith/assets/101863839/cfe25823-5e59-404a-afcf-2ad09d9d7940
Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Cloud

this is fixed now and can be tested on release


Added Solution for  A closest product problem in Hacker earth

Hey there!, Thanks for submitting a PR to this repo :smiley:
Please complete the following checklist for your PR to be approved. Mark the items by adding an x.
Example:  - [ ] Mark me as completed
To mark: - [x] Mark me as completed

[x] My Pull Request adheres to the Contribution guidelines.
[x] I have added problem.md and solution files in the appropriate folder
[x] In problem.md I have provided a correct link to the problem.
(In case you are not adding a problem, you can freely mark this as complete)
[x] My solution passes all the testcases within the given constraints.
[x] I have properly indented and documented my solution using comments.

If any of the above is unmarked, please make the necessary changes and then mark them so that you're PR can be approved and merged.
(Only completed checklist PRs will be reviewed)

Your solution does not have comments explaining the logic used. This is clearly mentioned in the contribution guidelines.
Since you falsely marked in your PR that you have added comments , I am closing this.
You may submit another PR that follows all the contribution guidelines.