hey  can you make it so we can put color in the name of items ? if so thank you :)

hey  can you make it so we can put color in the name of items ? if so thank you :)

I'm assuming you're referring to the text box at the top of the /nbt menu?
You can currently add color to item names, but you have to edit the nbt directly.
Current Method
If you set display.Name to '{"text":"Some Name","color":"red","underlined":"true"}', the item will be named to Some Name, in red, with an underline.
For the full text format, refer to the official wiki:
https://minecraft.fandom.com/wiki/Raw_JSON_text_format
Future Upgrades
While the text box is meant to be similar to an anvil's rename field, I have plans to implement color codes.
At some point, I plan to add a /itemfactory name <name>, which would rename the item to the supplied name. Importantly, this supplied name would support the & formatting system. For example:
/itemfactory name &c&nSome Name
Would be the formatting code equivalent of the nbt above.

In the v1.9.0 update, I have now released the /itemfactory name feature mentioned above. For information on the specifics of the formatting system, refer to /get help textformat. This new feature also applies to the lore and signature commands.
For users who want to use the previous JSON system, there is now a config option.


Add an info box to home page regarding installing and updating Tatin

Provide easier access to the relevant information and the download page.

Done


Add support for loading binary files using array buffers

206 files changed:). I think something went wrong

Sounds good!

Thanks!


fix: Add additional required expression for natural join

Which issue does this PR close?

Closes #11635
Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

I checked that the final logical plan is correct, but the calling of expand_wildcard in wrap_projection_for_join_if_necessary breaks it.  expand_wildcard removes duplicate columns in the using join, but this column is needed by the parent plan.
The use of expand_wildcard was introduced in https://github.com/apache/datafusion/pull/4443/. I speculate that it was a refactor of the following old implementation.
let mut projection = vec![Expr::Wildcard];
        projection.extend(expr_join_keys.into_iter());
        LogicalPlanBuilder::from(input)
            .project(projection)?
            .build()?

Its purpose should be to re-project all the outputs of the input plan.
So I think another simpler fix might be to replace expand_wildcard with this.

I checked that the final logical plan is correct, but the calling of expand_wildcard in wrap_projection_for_join_if_necessary breaks it. expand_wildcard removes duplicate columns in the using join, but this column is needed by the parent plan.
The use of expand_wildcard was introduced in #4443. I speculate that it was a refactor of the following old implementation.
let mut projection = vec![Expr::Wildcard];
        projection.extend(expr_join_keys.into_iter());
        LogicalPlanBuilder::from(input)
            .project(projection)?
            .build()?

Its purpose should be to re-project all the outputs of the input plan.
So I think another simpler fix might be to replace expand_wildcard with this.

Yes, I am aware of

expand_wildcard

I agree, It's is much simpler, I was thinking about how to add missing expressions that  are excluded by expand_wildcard but haven't thought about replace it directly. Thanks for this.

I checked that the final logical plan is correct, but the calling of expand_wildcard in wrap_projection_for_join_if_necessary breaks it. expand_wildcard removes duplicate columns in the using join, but this column is needed by the parent plan.
The use of expand_wildcard was introduced in #4443. I speculate that it was a refactor of the following old implementation.
let mut projection = vec![Expr::Wildcard];
        projection.extend(expr_join_keys.into_iter());
        LogicalPlanBuilder::from(input)
            .project(projection)?
            .build()?

Its purpose should be to re-project all the outputs of the input plan.
So I think another simpler fix might be to replace expand_wildcard with this.

expand_wildcard

I agree, It's is much simpler, I was thinking about how to add missing expressions that are excluded by expand_wildcard but haven't thought about replace it directly. Thanks for this.


App Crashes upon scheduling an alarm

Alarm plugin version
1.1.7
I schedule 2 alarms, the first one to go off instantly and another one after some duration of time. After a fresh install of the app (in debug or release mode doesnt matter) the first time i try to schedule an alarm the app freezes and or just closes. Also this is appearing when permission have been granted and if they haven't been granted.
To Reproduce

Initialize the package
Schedule an alarm
App crashes.

Expected behavior
The App should not crash.
Screenshots

The Error Message i get:
* thread #3, queue = 'com.apple.root.default-qos', stop reason = EXC_BAD_ACCESS (code=1, address=0x8000000000000028)
    frame #0: 0x00000001b855b6c0 libswiftCore.dylib`Swift.__RawDictionaryStorage.find<τ_0_0 where τ_0_0: Swift.Hashable>(τ_0_0) -> (bucket: Swift._HashTable.Bucket, found: Swift.Bool) + 36
libswiftCore.dylib`Swift.__RawDictionaryStorage.find<τ_0_0 where τ_0_0: Swift.Hashable>(τ_0_0) -> (bucket: Swift._HashTable.Bucket, found: Swift.Bool):
->  0x1b855b6c0 <+36>: ldr    x0, [x19, #0x28]
    0x1b855b6c4 <+40>: mov    x8, x2
    0x1b855b6c8 <+44>: ldr    x9, [x8, #0x20]!
    0x1b855b6cc <+48>: mov    x17, x8
Target 0: (Runner) stopped.
Error launching application on iPhone von Samuel (3).
Exited

Device info
iPhone 12, iOS 16.4
Additional context

Hey @aissam-amez,
Sorry to hear you have this issue too.
Can you both provide detailed steps to reproduce the issue ? I'm not able to reproduce it on my device. Also provide the frequency of the crash.
Thanks in advance

I have a fitness app that allows users to select how much time for training and adjust it in multiple sets
for each set it will have an alarm to notify that the set is finished.
here is my code:
for (var i = 1; i <= countTimes; i++) {       final alarmSettings = AlarmSettings(         id: i,         dateTime: DateTime.fromMillisecondsSinceEpoch(             timeNow + i * 20 * minuteInMilliseconds),         assetAudioPath: 'assets/songs/alarm.mp3',         fadeDuration: 3.0,         notificationTitle: 'fitness app',         notificationBody:             '$separateTime minutes has passed. it is time for the other set',         enableNotificationOnKill: false,       );       Alarm.set(alarmSettings: alarmSettings);       setState(() {});     }   }
the odd thing is that the app sometimes works fine, and sometime the app crashes when set the alarms  like 5% of the time

OK thank you for your answer, I'll look into it as soon as possible.

Sending notifications causes the app to crash on Android 7.1.1, and probably other older versions too.  Everything else works fine for me so far if I'm not using notifications.

Hi @imperialmarch55
Please make sure you followed the installation steps. Otherwise, do you have any logs before your app crashes ? Could be very useful to identify your issue.

I'm experiencing the same thing.
The app crashes when I try to register multiple alarms.
Exception: Unable to terminate com.xxx on B940F6DF-F90D-4633-A8A4-7B35C85E011A:
ProcessException: Process exited abnormally:
An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=3):
Simulator device returned an error for the requested operation.
found nothing to terminate
Underlying error (domain=NSPOSIXErrorDomain, code=3):
	The request to terminate "com.xxx" failed. found nothing to terminate
	found nothing to terminate
  Command: /usr/bin/arch -arm64e xcrun simctl terminate B940F6DF-F90D-4633-A8A4-7B35C85E011A com.xxx
the Dart compiler exited unexpectedly.

Hi @synstin
It might be a Simulator issue. Do you have a physical iOS device to test ?

@gdelataillade
I thought it was a simulator issue too, but I'm currently testing in testflight.
It happens less in testflight than in the simulator, but it does happen.
I am using an iPhone 14.

Hi @synstin
Thanks for your answer.
I think you should try to wait for an alarm to be set before trying to set another one, with await keyword:
for (final alarm in alarmList) {
   await set(alarmSettings: alarm);
}

The issue occurs maybe because of concurrency. Let me know if it fixes your issue.

@gdelataillade It's fixed perfectly, thank you.


NO-ISSUE: device: improve context cancel handling

This PR improves the handling of context cancellation around image upgrades. When we apply the upgrade a SIGINT is sent to the agent process. This change helps to halt future progress by returning when the ctx error is observed. The net result can be an invalid upgrade.

combined with #632


Darkmode edits

These are some old edits I did, but I feel that it is neccessary again to update for vs2019
Extension Gallery version looks outdated, getting this in there before an update would prevent further effort

Putting this as a draft until I can review anything for 2019 version

Updating list of notes:

[ ] Live Share Button on hover

Also, a diff
https://gist.github.com/Scrxtchy/3787a9e92665f0e231d10707963feb51

The color theme format of VS is not program-friendly editable, and vs color theme editor is very complex. So I don't want to edit it manually any more.
Thank you for editing this.

The color theme format of VS is not program-friendly editable

Yeah it's a bit rough, the colour themes extension allows exporting an XML, which really really helps
It would help if we had the colour theme these were initially based off, as then I could probably do a better job in just applying those changes into the updated colours, instead of going through every change and seeing what's important

Found a good diff tool, really helps in finding the transparent values

I've completed a decent effort, there's still quite a bit of minor changes to colours over the years, but this appears to function as intended.
some xml files are stored in this gist file, as I try to remember how I pulled out theme configs from six months ago to commit them into the repo
https://gist.github.com/Scrxtchy/d450ca7aee33b3a7ca3ddb091c39938e

What I ultimately want is generating a complete table with just master hue and transparency.
The easiest way should be joining VS dev team and expose their potential internal tools.


x/website: show current Go version next to download button on homepage

The previous website design had a string with the current version. As part of my workflow, I used to check the website to see if a new version was released, at the same time I was checking if new interesting blog posts were available.
Seems like the new website removed that version string.
Could you please put it back?
Thanks!

If the version were near the download button (as opposed to being in the footer) would that satisfy your request?

Definitely! Anywhere would be fine, and near the Download button makes a lot of sense.
Thanks!

@andybons I am interested in contributing can I pick this up?

@gondar00 let me get a design first then I’ll post it here.

This is implemented on go.dev. Perhaps that can help inform this issue.


Alternative MFA devices / solutions are not supported, the script does not fail nicely in cases where such devices are configured as MFA on AWS side

AWS cloud supports multiple sorts of MFA devices, for example Yubikeys. The acquire code implementation of AWSMFA does not support any such devices https://github.com/dcoker/awsmfa/blob/4d3565c78e5a53a85a42aeecd32909f2079e97f4/awsmfa/main.py#L170.
If such devices are not planned to be supported, I think adding a validation for a supported MFA method here https://github.com/dcoker/awsmfa/blob/4d3565c78e5a53a85a42aeecd32909f2079e97f4/awsmfa/main.py#L162 would make sense. Also the while loop at line 170 of main.py could also output an error for the user if the entered token is over 6 characters long.
If such devices could be supported (for example yubikey could be supported with an optional dependency to python-yubico, or even with some custom code) that would be great (and I could maybe look into adding some support for my devices in a PR).

Hi Xylix! I would be happy to review PRs that bring the tool up to date on the new features of the related AWS APIs and improve input validation. Thanks!

Cool! I'll try to get a PR up.


How Can I Change the BarcodeView  Center Layout ？

Description of the problem:
Which library version are you using? E.g. 3.2.0.
Which phone/tablet are you using, and which Android version does it run? (e.g. Samsung Galaxy S5,
Android 5.0)
Does the same happen on other devices or an emulator?
Can you reproduce the issue in the sample project included with the library? If not, can you
provide your own sample project or sample code that produces this error?
In the case of an error do you have a stack trace or adb logs?

I have the same question,have you found a solution?

I have the same question,have you found a solution?

You'll need to extend from BarcodeView and override calculateFramingRect.


Is it possible to call a computed property on select event?

We have 4 dropdowns and the following computed property, which calculates which items from the dropdowns have been selected. The property is then used when emitting events in order to perform some API calls.
bidsSelectedFilters () {
  let selFilters = {}
  let mappedBTypeValue
  let mappedBitStatusValue

  if (this.bTypeValue !== null) {
    mappedBTypeValue = this.bTypeValue.map((member) => member.uc_code)
    for (let i = 0; i < mappedBTypeValue.length; i++) {
      mappedBTypeValue[i] = { id: mappedBTypeValue[i] }
    }
    selFilters.ucode = mappedBTypeValue
    this.updateBTypeValue(mappedBTypeValue)
  } else {
    selFilters.ucode = []
  }

  if (this.bidStatusValue !== null) {
    mappedBitStatusValue = this.bidStatusValue.map((member) => member.js_ref)
    for (let i = 0; i < mappedBitStatusValue.length; i++) {
      mappedBitStatusValue[i] = { id: mappedBitStatusValue[i] }
    }
    selFilters.status = mappedBitStatusValue
    this.updateBidStatusValue(mappedBitStatusValue)
  } else {
    selFilters.status = []
  }

  if (this.groupValue !== null) {
    let gpNameObj = { id: this.groupValue.gp_ref }
    selFilters.group = gpNameObj
    this.updateGroupValue(gpNameObj)
  } else {
    selFilters.group = {}
  }

  if (this.personValue !== null) {
    let pxdRefObj = { id: this.personValue.pxd_ref }
    selFilters.person = pxdRefObj
    this.updatePersonValue(pxdRefObj)
  } else {
    selFilters.person = {}
  }
  return selFilters
}

Now, when we pass the property to the dropdown's select event like so         @select="bidsSelectedFilters" we get the following error
[Vue warn]: Error in v-on handler: "TypeError: handler.apply is not a function"

The error makes us think that we cannot pass computed properties to the events, however, we are not sure. Any help will be appreciated!

Only functions should be passed as event handlers in templates (@ or v-on). Computed property is used to access the value for which we define a getter (your code above).
Suggested way would be to define a method, for example, onSeletFilter and pass it as @select event handler. onSeletFilter will receive selected value as an argument that can assigned to update specific defined data property. Such data property then can be included in bidsSelectedFilters computed property. Once data property is updated, bidsSelectedFilters will be re-computed and therefore will always provide correct value to be used in API call, etc.


VSCode does not support Unity 5.4+ built-in matrix variables (fixed by pull request #33317)

VSCode Version: Code 1.15.1 (41abd21afdf7424c89319ee7cb0445cc6f376959, 2017-08-16T18:07:25.676Z)
OS Version: Windows_NT x64 10.0.15063
Extensions: none

Fixed by #33317
The vscode could not highlight builtin shaderlab matrix for unity builtin.
for example for built-in variable unity_ObjectToWorld (introduced by unity v5.4+)

But, the following built-in variable could be highlighted by default (available in Unity before 5.4)

Waiting for fixing...

See my comment in #33317. The fix need to go to https://github.com/tgjones/shaders-tmLanguage.

Thanks~!
(Fixed by https://github.com/tgjones/shaders-tmLanguage/pull/1 , a grammar update required)


Enhancement: Component to follow the add pattern

What will this achieve?
The idea would be to have a modal that standardises the "add" pattern similar to what has been created for the "create" pattern.
Carbon guidance mentions that add is similar to the create pattern, however the create modal is limited to the small modal variant. When using it for adding there is not enough space to view the content so a wider modal is required.
Our original thought would be to expand the capabilities of CreateModal to allow for larger sizes, but the component should follow a defined "Add" pattern rather than assuming it would be the same as Create.
How will success be measured?
Be able to use a component that follows the guidelines for "add" out of the box. The developer ideally would only supply the data to be used in the component.
Additional information

Designs
Existing code
etc

@tomleah are there designs to support this? i checked that link you provided and it's nothing more than a few bullet points.

sounds like we're still waiting on design to finalize the pattern @andrea-gm

@tomleah closing this issue pending design update, feel free to re-open.


Spyder and makpass.advpass()

When I run code in spyder pwd = maskpass.advpass() the console will hang and not run anymore code.

10 mins after running

Can you tell me your OS and Python version please?

win10 and 3.9.12

Spyder IDE

Can you check if the newest commit works? I haven't yet pushed it to pypi.org so you'll have to install it using  pip install https://github.com/FuturisticGoo/maskpass/archive/refs/heads/main.zip

Hey Mate, thanks for the help I installed the link but I it still hangs as soon as I press enter

Hey I reinstalled Spyder and now it works

Thank you so much


Frontend

Basic frontend in React with React Router

Please squash the commits before submitting them for review.
Here is how:
https://gist.github.com/longtimeago/f7055aa4c3bba8a62197

Alright, done!


Add two JavaScript features: array-grouping and array-relative-indexing

Trying to get into the habit of adding something on a regular basis. These are the last of the (non-huge) APIs in my spreadsheet from the mockup.
This adds:

Array grouping (this one is boring and straightforward)
Array relative indexing

The latter entry has two interesting quirks:

It consists of one compat feature. A group of one is perhaps a degenerate case. But I suspect its relationship to other groups (including, eventually, an Array group) might merit its inclusion. Any thoughts on this?
The spec URL limitations continue to be a problem. Needs loosening sooner rather than later, I think.

It consists of one compat feature. A group of one is perhaps a degenerate case. But I suspect its relationship to other groups (including, eventually, an Array group) might merit its inclusion. Any thoughts on this?

For posterity, Philip and I discussed this on a call earlier today. We decided that single-feature groups are OK: they're significant in their relationship to other groups and may be necessary to tell the story of a group evolution (e.g., Array acquiring new methods which eventually just become routine parts of the Array API).


Demand: Inundation Analysis

We want to achieve the effect of flooding analysis on oblique photographic data！Mesh type：MeshCollider!  Thanks!

I will try to add this in the next version but please keep in mind that since the simulation is done on a grid, the look might not be fully accurate with high detail meshes as they will not be able to match the simulation grid perfectly..

v1.1.1 is submitted and has support for assigning a MeshCollider as the base ground for the Fluid Simulation. Awaiting Unity approval and expecting it to go live in the next few days.

v1.1.1 is released which has support for MeshColliders as input..

Wow,thank sir! But the effect is not as good as on the unity terrain.

I might be able to improve on this if you have any example meshes you wish to use.  I mainly tested this by using this converter on my terrain meshes: https://assetstore.unity.com/packages/tools/terrain/mesh-terrain-editor-free-67758 which is why for my did matched closely, but if you have higher/lower detail meshes that don't match a grid it might be trickier.
A example scene could help me improve it if you could provide it (does not need to be your real project, just a concept of how your meshes look).

Hopefully, water can flow on this mesh,thanks.
------------------ 原始邮件 ------------------
发件人:                                                                                "FrenzyByte/fluidfrenzy"                                                                                @.>;
发送时间: 2024年12月30日(星期一) 下午5:01
@.>;
<EMAIL_ADDRESS>主题: Re: [FrenzyByte/fluidfrenzy] Demand: Inundation Analysis (Issue #15)
I might be able to improve on this if you have any example meshes you wish to use.  I mainly tested this by using this converter on my terrain meshes: https://assetstore.unity.com/packages/tools/terrain/mesh-terrain-editor-free-67758 which is why for my did matched closely, but if you have higher/lower detail meshes that don't match a grid it might be trickier.
A example scene could help me improve it if you could provide it (does not need to be your real project, just a concept of how your meshes look).
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


no-undef error for 'module' in created .eslintrc.js when using ESM and not-Node

I ran this creator with as few plugins / extra points as possible, with esm as the module selection:
$ npm init @eslint/config

✔ How would you like to use ESLint? · problems
✔ What type of modules does your project use? · esm
✔ Which framework does your project use? · none
✔ Does your project use TypeScript? · No / Yes
✔ Where does your code run? · No items were selected
✔ What format do you want your config file to be in? · JavaScript
Local ESLint installation not found.
The config that you've selected requires the following dependencies:

eslint@latest
✔ Would you like to install them now? · No / Yes
✔ Which package manager do you want to use? · npm

...

A config file was generated, but the config file itself may not follow your linting rules.
Successfully created .eslintrc.js file in /Users/josh/repos/eslinttemp

The config file itself not following the linted rules is something that I've seen confuse newcomers repeatedly. Example: https://github.com/typescript-eslint/typescript-eslint/issues/6825
Since no-undef will hit roughly every project that uses ESM, is putting an /* eslint-env node */ on top of the config (if it would violate no-undef for module.exports = ...) reasonable?
I also understand the new flat config is going to take over within the next 1-5 years. A lot of people still use the current config, so it'd be nice to have it be less confusing to them in the interim.
Edit: to be clear, what I found confusing is that this ESLint error is caused by running ESLint with the config generated by init:
'module' is not defined. eslint [no-undef](https://eslint.org/docs/rules/no-undef)

Since no-undef will hit roughly every project that uses ESM, is putting an /* eslint-env node */ on top of the config (if it would violate no-undef for module.exports = ...) reasonable?

I don't think so. Unless someone explicitly says that the JavaScript is intended to run on Node.js, adding a whole environment might cause problems. We could add /* global module */, though.

I also understand the new flat config is going to take over within the next 1-5 years. A lot of people still use the current config, so it'd be nice to have it be less confusing to them in the interim.

I'm not sure I understand the context of this comment. Soon, we'll switch --init to generate a flat config file so this won't be an issue. And this command is used only rarely when people start a new project (even then, they are probably copying from an existing project instead), so I'm not sure how the people who are using the current config now would be affected.

Unless someone explicitly says that the JavaScript is intended to run on Node.js
adding a whole environment might cause problems

Oh, is it not the case that .eslintrc.js files are explicitly made to run in Node.js? I was under the impression ESLint runs only on Node.js. Assuming that's correct - I don't follow how this could cause problems. If .eslintrc.js is made to run in Node.js, does adding /* eslint-env node */ to the top of .eslintrc.js impact any other files?
An example target project could be no environment for source files in general but still Node for .eslintrc.js.

the context of this comment

I was worried that you / the ESLint team would see that this issue is for the legacy config and wontfix it because soon --init will soon switch generating a flat config. So I wanted to point out that this is still a command used not-rarely when people start a new project. 😄

And this command is used only rarely when people start a new project

...huh. I find that to be a surprising comment. Given that npm init @eslint/config is on the homepage of https://eslint.org I don't see how that could be the case for projects not managed by an external framework builder (e.g. Next.js).

Oh, is it not the case that .eslintrc.js files are explicitly made to run in Node.js?

Fair point, got my wires crossed a bit. Still, we are phasing out the use of environments, so don't want to start introducing them in new places.

...huh. I find that to be a surprising comment. Given that npm init @eslint/config is on the homepage of https://eslint.org/ I don't see how that could be the case for projects not managed by an external framework builder (e.g. Next.js).

Most people don't start projects from scratch. They end up joining a project already in progress or, if they actually are starting from scratch, they tend to just copy over existing configuration rather than running --init.

phasing out the use of environments

TIL. Are there discussion notes somewhere explaining more on that? Any formal plans around deprecation

Most people don't start projects from scratch. ... joining a project already in progress

Just making sure we're talking about the same thing: I'm attempting to report a seeming-bug in npm init @eslint/config. Even if most people don't start projects from scratch, this is still a bug that some users will see -> should be fixed, right?

Taking a step back from @eslint/config: I've seen a good number of people -myself included- hit the no-undef error for module when trying to either create or update an ESLint config. Is there  guidance from the ESLint team on the right way to solve this? E.g. /* global module */ as posted?
Note that in https://github.com/typescript-eslint/typescript-eslint/issues/6825 -> https://github.com/typescript-eslint/typescript-eslint/pull/6918 we added /* eslint-env node */ to https://typescript-eslint.io/getting-started. So it'd be great to know whether we got that wrong. 😄

TSC meeting transcripts and notes are available here: https://github.com/eslint/tsc-meetings

Just making sure we're talking about the same thing: I'm attempting to report a seeming-bug in npm init @eslint/config. Even if most people don't start projects from scratch, this is still a bug that some users will see -> should be fixed, right?

Yes. I'm just saying that because environments are going away, I'd prefer the fix to just add the missing global rather than adding in the environment.

Oops, also announced that environments are going away here: https://eslint.org/blog/2022/08/new-config-system-part-2/#goodbye-environments%2C-hello-globals


Change cursor color when JSON format is invalid

I'm color blind, and I find it very difficult to see the cursor when the JSON is invalid because red is the color I see the least. It would be very nice if I could change the cursos color.

This sounds like a config in your editor, not an issue with the library. Quicktype has no control over the colours that are displayed on your local development setup.


Parsed mentions to names in suggestions + Improved invite detection system

parsed mentions to names in suggestions names and suggestions threads names
removed discord.gg from the words filter that use string similarity detection
added a more accurate invite url detector and checked if it's not an invite from the bots working server before deleting it

conflicts!!


Support handling more than 10 word sets at once

Helium Wallet 2.4.2 only lets me add 10 word sets at a time.  When I try to add the 11th it tells me "You have reached the wallet limit." and refuses to let me add more.
Why does this limit exist?  Can it be removed or increased?  I have more than 10 word sets and would rather not have to juggle them.

@Perronef5 is there a reason this limit exists or can we just up it?

Duplicate of https://github.com/helium/wallet-app/issues/541

Can you link to the commit where this was completed?

https://github.com/helium/wallet-app/pull/685


Got lots of matched records

Added the row's height for calculating the drop-down menu's height to prevent the case if we got lots of matched records.
(It is a quick fix for me. Any suggestions?)

Could you show me an example demonstrating how things go wrong?

example 1 is what I needed, I missed the example.


ARROW-6136: [FlightRPC][Java] don't double-close response stream

This fixes a bug where if the service implementation called ackStream#onError, the Flight implementation would always call onCompleted, causing an error in gRPC.
Travis build: https://travis-ci.com/lihalite/arrow/builds/121967873

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@03dc59d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #5013   +/-   ##
=========================================
  Coverage          ?   89.68%
=========================================
  Files             ?      670
  Lines             ?    99184
  Branches          ?        0
=========================================
  Hits              ?    88954
  Misses            ?    10230
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03dc59d...d8aa234. Read the comment docs.

@jacques-n do you think you will have time to review, otherwise I can try to take a look?


Update the following tests with fixtures from the alma box.

https://github.com/pulibrary/bibdata/blob/debcea3841be7020846539994ffe3f13330b4dc6/spec/marc_to_solr/lib/config_spec.rb#L85-L105
mms_id:<PHONE_NUMBER>0521 and<PHONE_NUMBER>00541 are from the sandbox
describe "the date cataloged facets" do
context "When the record has 876d and 951w fields" do
it "will index the 876d field" do
record = fixture_record('99211662100521')
indexed_record = @indexer.map_record(record)
expect(record['951']['w']).to be_truthy
expect(record['876']['d']).to be_truthy
expect(record['950']['b']).to be_truthy
expect(Time.parse(indexed_record['cataloged_tdt'].first)).to eq Time.parse(record['876']['d']).utc
end
end
context "When the record has only a 950b field" do
it "will index the 950b field" do
record = fixture_record('991330600000541')
indexed_record = @indexer.map_record(record)
expect(record['950']['b']).to be_truthy
expect(record['876']).to be_falsey
expect(record['951']).to be_falsey
expect(Time.parse(indexed_record['cataloged_tdt'].first)).to eq Time.parse(record['950']['b']).utc
end
end

closed by #1543


Fix #3500: ISO 8601 parsing should match the full string, not the beginning of the string.

Before the fix, date strings which started with a valid ISO pattern but ended with non-conforming data would pass as valid ISO dates and not trigger the deprecation warning, causing garbage-in/garbage-out bugs and silent failure.
Example of a garbage date which was considered Valid ISO before:
 2016-01-Just a bunch of junk

Example of silent failure cases:
2016-12-4 would be match the "YYYY-MM" ISO pattern, so would silently become "2016-12-1".
2000-01-01T11:00:00 PM would match the "  2000-01-01T11:00:00" ISO pattern, silently turning 11 PM into 11 AM.

Non of the above cases trigger the "non-ISO deprecation warning", either.
Because of the nature of how the related tests are put together, the newly added test passes even before the fix is applied.
This happens because the "non-ISO" tests are tested against the same ISO regex which is being fixed.
Because the broken regex is also used in the test, it allowed the non ISO date to be validated before the fix.
This fix exposed another problem with non-ISO dates in the test suite, so it causes 3 other test failures, which are now fixed, too. The other test failures are in:
test/moment/is_same_or_before.js
test/moment/is_same_or_after.js
All concern dates which look like this:
2013-02-01T-05:00
From what I can tell, it is not valid IS0 8601 to include a timezone offset without a time. The references I checked included:

The moment test suite, which has an extensive set of ISO 8601 cases to test
IS0 8601 wikipedia page
Attempt an IS0 8601 ABNF grammar http://www.egenconsulting.com/ietfcns.nsf/0bd281b2cc02b86a852564060002ca3d/cfcc618830db7cc5852563fb00584230?OpenDocument

These tests were updated to avoid this invalid date format after @icambron agreed the dates were not ISO format but should be.

See #2985. I'll reiterate my take there: we should always parse ISO strictly. So I'm +1 here.
Re: the Travis failures: I agree that 2013-02-01T-05:00 is bogus.

@icambron: Thanks for the response.
I read through the related thread and saw some other people also ran into problems with junk at the end of ISO-valid strings--  Like my case where December 4th became December 1st, someone else had an unnerving case where 11 PM became 11 AM.
I see no need to add a "strict" flag as part of fixing this. I see this fix as simply making the ISO parser work as advertised-- more correctly!    I don't see the current behavior has being "not strict", it's not like "not behaving advertised by silently discarding at the end of valid ISO patterns".
I pushed another commit to fix the bogus date strings in the test suite that the original ISO fix turned up.
This pull request will put a stop the unknown amount of silent failures where invalid date strings are translated into other ISO dates or junk is simply allowed through as a "ISO valid" when it is not.

Fixing Travis complaint.

I think we not be on the same page about what "non-strict" means. It really just means "wrong but in ways that are hopefully helpful". I also agree that the current behavior is an especially unhelpful flavor of non-strictness.I agree that we don't need a global non-strict flag to make ISO strict.

Non-strict really just means "wrong but in ways that are hopefully helpful". I agree that the current behavior is an especially unhelpful flavor of non-strictness. But AFAIK, it's the only bit of slack in the parser, so fixing has the effect of making it strict. My point in the other thread was that I don't think need a global non-strict parsing flag to make ISO in particular strict. I think you agree.

@icambron I think we agree on all points.
Where does that leave the future of this pull request? It seems to be in alignment with changes you support.

I have a little member badge, but I'm not in charge. It seems like an important bug fix, especially because it breaks the passthrough to the native parser. But it's a breaking change, so I'll ask the rest of the team to weigh in and make the call. (cc @ichernev, @maggiepint, @mj1856)

About this change not being backwards compatible -- we've done those in the past with varying success. So we can try to ship in in 2.16 and if there is massive backlash cut out 2.16.1 ... not really something I can predict now, but in general, given how many mistakes have happened even in our code (tests) its hard to be against this PR.
I'll merge it in next release (2.16)

Heads up. Because we came under JS Foundation management, we need a CLA signed for this to be merged. Should be just a couple clicks.

I found the CLA here and completed it. https://js.foundation/CLA/

@markstos well, not according to the checkmark :) We'll investigate

@markstos - click the Details link on the license/cla line above and follow from there.  Thanks.

@markstos - Try this link please.

OK, done now.

Merged in 68a68b8730fbb69515ddbfb1d62bcfe34a484ae1


If ref=None part reference gets incremented twice

Describe the bug
If ref=None is passed to a part, then the reference number gets incremented twice.

Part.__init__ adds itself to the circuit
Circuit.add_parts sets the part ref. Because keyword ref is None, a unique ref is generated.
Part.__init__ in the very end calls setattr on remaining keywords, including ref. Since the keyword value is still None, a unique ref is generated again. Since the ref generated in step 2  above is already taken, we end up with an extra increment.

Part ref setter should perhaps free the old name, if set, before generating a new one? Or ignore None if it already has a ref?
To Reproduce
from skidl import *

r = Part('Device', 'R', ref=None)

print(r.ref)
>>> R2

Expected behavior
>>> R1
Desktop (please complete the following information):

OS Gentoo Linux
Python version 3.8.5
SKiDL version 0.0.30

I decided to pop the ref=None item from the attribs argument to Part(). That seems to solve the problem and doesn't lead to any other test failures.
BTW, is there a situation where setting ref = None is useful? Or is this something you just stumbled across?


methods to read constants

address public lnx_address;
address public lnxp_address;
uint256 public lock_start;  // todo use uint40
uint256 public lock_end;

After a bit of consideration, I figured we will need view methods to read these constants.
lets call them:
getTokenAddress
Get the LNCHX token address
getSyntheticTokenAddress
Get the LNCHXP token address
getLockStartTime
Get the lock period starting time
getLockEndTime
Get the lock period ending time

fixed


Update go get command

the go get command on the readme wasn't working

https://we.tl/Mb0VCdRtPA

I don't know wat I'm supposed to do here

I'm sorry


sync the fork

What is this PR about? / Why do we need it?
sync the mesosphere/aws-ebs-csi-driver using PR instead of pushing to mater

Thanks!


AttributeError 'Bot' object has no attribute 'base_url' for bot.send_image

Hi, I wanted to send an image as a file, not via url, but got an AttributeError 'Bot' object has no attribute 'base_url' for bot.send_image.
Traceback (most recent call last):
  File "paul.py", line 166, in webhook
    bot.send_image(sender_id, generated_image)
  File "/home/psuser/paul/paul/local/lib/python2.7/site-packages/pymessenger/bot.py", line 135, in send_image
    return requests.post(self.base_url, data=multipart_data, headers=multipart_header).json()
AttributeError: 'Bot' object has no attribute 'base_url'

Hey, looks like that function was never actually tested. I've been working on a minor rewrite that works with local attachments. Try using the partial-rewrite branch!

Fixed in #18


Missing features

Very nice little utility!
Now you should implement "noisy" lines (spurious characters) or error correction emulation (speed will not be constant depending on noisiness).
Full model emulation would be very nice also :smiley:

What would such noise look like? I haven't ever used an actual teletype or serial terminal.

Another feature would be compression such as V.42bis or V.44. This one is tricky because compression takes computational time and speed of such may need to be adjustable. However important because 2400 BPS modems and above almost always had compression and it was working really well. From my own experience text operations (unlike file transfers for example) were compressing very well and 2400 BPS V.42bis modem was almost same speed as 9600 without compression (again for text/shell work only).


Add travis config with linter

(Thank you, @knifewine)
This adds a travis configuration file to the repo. It'll run pep8 on changed lines, so idiomatic-ness will only improve.
It also runs pyflakes via flake8 on all files. It only reports on importing errors, since @ptnapoleon fixed all those and all of this type of error found should be new.
This PR also removes unused imports and from module import *, as found by pyflakes, so we don't start off with failing linters. It also cleans up the imports with isort because why not?
For the errors we've ignored and for PEP8 checking on the entire codebase, we can take it in chunks, or just improve things as we change tests, with the help of this linting.

I don't know who has permissions to do this, but someone will have to set up the Travis service for this repo. Is that helpdesk?

Bah, not ready for merge yet. Need to add a warning to the ignored flake8 errors.

Force pushed the fix. Good to go. I'll still hold off on merging until helpdesk can turn the service on.

Here is an example of the checking in action on a PR. It should demonstrate that the config works.

-1 to forgetting "Linter is coming" from that image macro. +1 to the PR.

It looks like the plumbing is in place. Merging.


Add OVMS OOTB with GPU support

Description

Closes: #1257
How Has This Been Tested?

Deploy the manifest files
Check that you can see both Custom Serving Runtimes as pre-installed

Test Impact

Test will be done in the follow up testing section for Custom Serving Runtime

Request review criteria:

[x] The commits have meaningful messages (squashes happen on merge by the bot).
[x] Included any necessary screenshots or gifs if it was a UI change.
[x] Included tags to the UX team if it was a UI/UX change.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work
[x] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

@vconzola I've attached a screenshot just to validate if this is what you were expecting, maybe we can review the name of the GPU one

@Xaenalt If we can validate the spec it would be super helpful, I'm still confused about the different images in ovms.

@vconzola I've attached a screenshot just to validate if this is what you were expecting, maybe we can review the name of the GPU one

I think we wanted to go with (GPU Required) as it can't work on a non-GPU node.

@lucferbux Actually, seeing how this looks to the end user, maybe "Supports GPUs" makes more sense than "GPU required". What do you think?

I didn't realize that both runtimes would have the exact same name. Yuck! But it is what it is. Instead of parenthetical text after the name, can we put "GPU required" in a label, just like "Pre-installed". I think that will draw more attention.

mmmm, the hole point of getting this to the display name is that is displayed in the selection of the runtime (I'm gonna attach new screenshots). We can add a label too, but what should we do in the modal selection?

@vconzola

Looks good to me, we validated the correct image tag to use as well

/hold
This looks good by all parties -- only holding until I get confirmation from Lucas.

It should be fine by now, based on conversations we had this should be the image, already tested so it's working as intended.


Add virtual scheme functionality into base

Removed VirtualSchemeOptions
Added to AuthenticationSchemeOptions as
Forward[Authenticate/Challenge/Forbid/Selector]
Added abstract SignIn/OutAuthenticationHandler base classes
VirtualAuthenticationHandler uses these, will update existing handlers
to use the new base classes once things are stable

This makes social auth no longer even need a 3rd 'virtual' scheme.  Instead, the default cookie scheme can set ForwardChallenge = "Google".
@Tratcher @davidfowl

Can someone describe the real world scenario that this change solves?

This is mostly targetting making it easier for these two scenarios:

Mix different auth schemes (i.e. cookies and bearer)
Today's AuthenticationSchemes property on AuthorizationPolicies is not powerful enough to express what we were trying to enable, what's actually needed there was the ability to configure a coherent set of challenge/authenticate/forbid behaviors for a specific authorization policy (which is what we are calling a virtual scheme, but its basically an authentication policy to match an authorization policy)

Mix different auth schemes (i.e. cookies and bearer)

What's the exact problem with that today? Besides that they shouldn't be mixed?

What's the exact problem with that today? Besides that they shouldn't be mixed?

It makes it possible to simplify authentication schemes that require a different combination of values for Challenge/SignIn/SignOut/Authenticate etc. It means we can introduce higher level schemes that basically combine lower level ones. A concrete example of this would be a Google+Cookies authentication scheme that has Challenge = Google, EverythingElse = Cookies.

It makes it possible to dynamically select a scheme on a per request basis. There's been consistent feedback that what we have today is extremely limiting (specifying authentication schemes on the authorize attribute). See https://github.com/aspnet/Security/issues/1338. This was another concrete scenario driving this discussion https://github.com/aspnet/Security/issues/1469

It means we can introduce higher level schemes that basically combine lower level ones

Oh well - sure even more shielding of devs from the way it works. Besides that Google+Cookies is never the answer. But that's a different discussion

It makes it possible to dynamically select a scheme on a per request basis.

OK - if that makes it easier to select the right validator for a bearer token, then this is an improvement. Not sure if you had that use case in mind...

Updated PR adding self forwarding checks and a test that verifies we get the proper error for all of the existing handlers.  Its a shame we didn't add the base SignIn/SignOut handlers in 2.0, can't use the new base handler pattern since the existing handlers expose the interface methods as public virtual :(

One more update, allowed explicit target to Scheme.Name to skip forwarding, which allows setting of ForwardDefault and selectively pointing at yourself to opt out of some forwarding

This makes social auth no longer even need a 3rd 'virtual' scheme. Instead, the default cookie scheme can set ForwardChallenge = "Google".

You are aware that this is not how it works in the real world? For 90% of the time you want to show some sort of page before challenging the external provider? And this will then probably also use the external cookie for signin...
I have the feeling you are building something here where you don't understand the real world requirements.

@davidfowl @HaoK
Will this feature help me to invoke different authentication handlers based on the "format" or "shape" of an incoming bearer token?
This is something that is really needed.
We had to jump through a couple of hoops to make it work
https://github.com/IdentityServer/IdentityServer4.AccessTokenValidation/blob/c5631a3fa91aeeb97e40d58a8ed534c321acd5f6/src/IdentityServer4.AccessTokenValidation/IdentityServerAuthenticationHandler.cs#L51-L61

You are aware that this is not how it works in the real world? For 90% of the time you want to show some sort of page before challenging the external provider? And this will then probably also use the external cookie for signin...

Complex flows like you describe here (like what identity needs) will always have to build their own custom authentication "policy", that's not really any different than today, except it can be expressed using a named virtual scheme instead of shoehorning things into the single set of defaults.  This would also let authentication frameworks target their own named scheme, i.e. Identity can target the "Identity" scheme instead of hardcoding a bunch of constant schemes.

It gets you closer, you are given the ability to dispatch based on the context, but you would still have to extract the token and return the appropriate scheme name, so...
   // Configure the selector in your IdentityServerAuthenticationOptions
  o.ForwardDefaultSelector = ctx => {
     var token =  Options.TokenRetriever(Context.Request);
     if (token != null) {
        if (token.Contains('.') && Options.SupportsJwt)
            return Scheme.Name + IdentityServerAuthenticationDefaults.JwtAuthenticationScheme;
        else if (Options.SupportsIntrospection)
            return Scheme.Name + IdentityServerAuthenticationDefaults.IntrospectionAuthenticationScheme;
        return null;
     }
  }

   // And then you can update HandlerAuthenticateAsync to return NoResult always.

Updated cleaning up the ResolveTarget helper to also take care of the self targeting check.  Unfortunately the circular reference issue is unavoidable with scheme forwarding in general, I could check for it using a hashset with the scheme name instead of the bool per action handler, that might look a little better

Actually never mind, tracking visited schemes via hashset is a lot messier than the flag per handler

These cycle problems a deal breaker. We need to step back and redesign this. I think we can achieve most of our goals using the current forwarding handler without introducing these cycle complexities. I'll be in the office tomorrow and we can go over it.

Just the concept of a forward handler creates cycle detection issues, that logic needs to exist in the forwarding code regardless, since you can always forward A to B which forwards back to A.
So I'm not sure how we can design away the issue

The issue becomes worse the deeper you integrate the forwarding. For the forwarding handler in dev the risks are much lower because you primarily forward from one virtual handler to as series of concrete handlers, and those handlers have no mechanic for forwarding back to you. In the worst case you point two forwarding handlers at eachother. Even if we needed this kind of cycle detection for those cases it would be contained to the virtual handler, not spread through every call path.
I think we can go back to using the distinct virtual handler and still achieve our design goals without introducing these complexities to the rest of the stack.

So is your main concern the gross _inSignIn checks in every method being part of the base methods instead of only the virtual handler class?
To me, the existence of that code is painful regardless of where it lives, but if it is going to exist anyways, deep integration of virtual schemes/handlers at least gives the benefits of making it possible to glue two schemes together without introducing a 3rd pure virtual scheme (i.e. mix cookies and an oidc via forwarding, instead of cookies + oidc + virtual).
When forwarding isn't being used, the checks actually still have some value, since now that I think about it, didn't we have cases in the past where event code tries to call Authenticate on itself would blow up?  I'll see if I can reproduce that issue tomorrow.

Filed https://github.com/aspnet/Security/issues/1578 to track hardening against reentrancy/circular references in general, as this isn't something unique to virtual handlers, events and sign in scheme already have the same issue.  I'll remove the checks and tests from this PR

Updated removing all the safeguard checks

Updated the doc comments:
ForwardDefault:
        /// <summary>
        /// If set, this specifies a default scheme that authentication handlers should forward all authentication operations to
        /// by default. The default forwarding logic will check the most specific ForwardAuthenticate/Challenge/Forbid/SignIn/SignOut
        /// setting first, followed by checking the ForwardDefaultSelector, followed by ForwardDefault. The first non null result
        /// will be used as the target scheme to forward to.
        /// </summary>

ForwardXyz:
        /// <summary>
        /// If set, this specifies the target scheme that this scheme should forward AuthenticateAsync calls to.
        /// For example Context.AuthenticateAsync("ThisScheme") => Context.AuthenticateAsync("ForwardAuthenticateValue");
        /// Set the target to the current scheme to disable forwarding and allow normal processing.
        /// </summary>

ForwardDefaultSelector:
        /// <summary>
        /// Used to select a default scheme for the current request that authentication handlers should forward all authentication operations to
        /// by default. The default forwarding logic will check the most specific ForwardAuthenticate/Challenge/Forbid/SignIn/SignOut
        /// setting first, followed by checking the ForwardDefaultSelector, followed by ForwardDefault. The first non null result
        /// will be used as the target scheme to forward to.
        /// </summary>

Wasn't the big thing Fowler wanted with this PR new combine extensions for .AddGoogle/Facebook/Etc. that included Cookies for you? I think it would be more effective to start with those and work backwards.

I have those extensions in another PR, the main issue there is where they should live, currently the auth packages don't depend on cookies, we need some package that depends on auth + cookies, unless just depend on cookies for everything
There's nothing too interesting about those methods, they basically just all look like:
   AddGoogleSignIn(this AuthenticationBuilder builder, Action<GoogleOptions> configure) {
      builder.AddAuthentication("Cookies")
            // Don't add the default cookie if it already exists, but always configure it
           .TryAddCookie(o = o.ForwardDefault = "Google")
           .AddGoogle(configure)
   }

Typically you'd only call one of each, the templates wouldn't use any of these except for maybe AddOpenIdConnectSignIn

Does this do about the same using the checked in code?
        public static IServiceCollection AddOpenIdConnectSignIn(this IServiceCollection services, Action<OpenIdConnectOptions> configure)
        {
            services.AddAuthentication(options =>
            {
                options.DefaultScheme = "Cookies";
                options.DefaultChallengeScheme = "OpenIdConnect";
            })
            // .TryAddCookies()
            .AddOpenIdConnect(configure);

            return services;
        }
or
        public static IServiceCollection AddOpenIdConnectSignIn(this IServiceCollection services, Action<OpenIdConnectOptions> configure)
        {
            services.AddAuthentication(options =>
            {
                options.DefaultScheme = "OIDCSignIn";
                options.DefaultSignInScheme = "Cookies";
            })
            // .TryAddCookies()
            .AddOpenIdConnect("OpenIdConnect", "", configure)
            .AddVirtualScheme("OIDCSignIn", "OpenIdConnect", options =>
            {
                options.Default = "Cookies";
                options.Challenge = "OpenIdConnect";
            });

            return services;
        }

Yup pretty much a (much) cleaner way to express that

At the cost of adding unnecessary complexity to the core classes. I'm putting this on hold until we can review it in person with Eilon.

That's fine, I can schedule an in person review with @davidfowl and @Eilon when everyone is back

But I'd say its better to look at the whole virtual scheme/forwarding feature as more of a new core concept rather than some tangential functionality limited to a special virtual handlers.

We're having a hard time keeping track of what their for though. The two scenarios I'm aware of are API + Cookies which is handled by the existing DefaultSelector, and AddOpenIdConnectSignIn which doesn't require virtual schemes at all.

So remember what's driving this change, its not meant to be a targeted thing, but a brand new concept.  This is coming from the main AuthZ improvements issue: https://github.com/aspnet/Security/issues/1359, and https://github.com/aspnet/Security/issues/1469 for more context
The new core concept we've been iterating on is AuthenticationPolicies and the ability to have logical schemes, aka VirtualSchemes, the two scenarios you listed are specific examples of why you would use policies.   Basically keeping VirtualSchemes a separate thing means authentication policies are only "VirtualSchemes", while integrating them means any auth handler using our base classes (including our built in handlers, and all existing custom handlers) will be able to take advantage of the new policy concept without having to add any new schemes.
The main thing that is fundamentally broken today with [Authorize] without AuthenticationPolicies is the whole multiple AuthenticationSchemes being unable to effectively express what we want.  Going forward now that we have policies, we can safely state that [Authorize] and AuthorizationPolicies in general should only ever point to a single AuthenticationScheme, if apps need to compose different schemes or do anything more advanced, they can use the new AuthenticationPolicy/VirtualScheme/Forwarding stuff we are adding. And in 3.0, we can probably look at deprecating the comma splitting/ability to specify multiple schemes entirely from [Authorize]/AuthorizationPolicy

Note, the default schemes we have in AuthenticationOptions are similarly broken to [Authorize], we could consider deprecating those as well in 3.0, and only support setting a single DefaultScheme, and require them to use the virtual scheme stuff instead.


Safe Observable#subscribe

const observable = new Observable(subscriber => {
  subscriber.next(1);
});

const subscription = observable.subscribe(value => console.log(value)); // prints 1

subscription.next(2); // prints 2

Subscribe method returns Subscriber object while Subscription expected
I fixed UB

Yeah. This is a known issue as a leaked implementation detail. I'm not sure if we should tackle it now, or simply wait to migrate to AbortSignal as it becomes ubiquitous as a cancelation mechanism.


Bug: content script cannot be loaded when using relative path

The original problem is displayed here
I found the problem lies in the reload extension.

Some manifest changes aren't reflected even after a reload - Is this what you are referring to?

Yes, it seemed so.

Currently some changes to the manifest.json can't be reloaded due to the nature of Chrome's API


adds support for stream sink into any argument

StreamSink currently has to be the first argument. This PR makes it work in any place.
Examples:
use flutter_rust_bridge::StreamSink;

pub fn tick(a: u32, b: u32, sink: StreamSink<i32>) -> Result<(), anyhow::Error> {
    todo!()
}

pub fn tick_2(a: u32, sink: StreamSink<i32>, b: u32) -> Result<(), anyhow::Error> {
    todo!()
}

pub fn tick_3(sink: StreamSink<i32>, a: u32, b: u32) -> Result<(), anyhow::Error> {
    todo!()
}

pub fn tick_4(sink: StreamSink<i32>) -> Result<(), anyhow::Error> {
    todo!()
}

PS: this is a draft. I'll erase the test files and the mess once the PR is approved
Closes #541

I should have left this stuff out but wondered if you wanted to try the PR locally and easily. Anyways, in the next PRs I'll gitignore them

wondered if you wanted to try the PR locally and easily

Indeed I look at the CI outputs :)

Does it make sense to have the bridge_generated.dart files in the example? It's nice for newcomers looking to see how it works internally without running the code but it's painful when you want to merge something and have to deal with these generated files while merging

have to deal with these generated files while merging

No, do not manually deal with it. But simply re-run code generator after merging to get the latest version.

It's ok for some codegen tests to fail right? The generated code is the same in Flutter

It's ok for some codegen tests to fail right?

No, all CI should pass

But you can ignore "Codacy Static Code Analysis"

I deleted the generated code just to be sure it was regenerating. The only possible problem should be formatting. Let's see on the next run

@all-contributors please add @lattice0 for code

Ready to merge once CI passes


Invalid Char 65279 at position 0

Describe your problem here.

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

Character JSON is broken

Fix the syntax error or create it from scratch

how?

edit the file

all my char file?

i edit the file but this appeared


DatePicker Re-rendering after "value" changes

Is your feature request related to a problem? Please describe.
We would like the datepicker input box to re-render once the value change. In our case, we want to set the value for the second datepicker once we click on the first one. It is happening but the datepicker is not re-rendering.

Describe the solution you'd like
we would like the datepicker to re-render once the value of the "value" parameter changes. We believe a listener could be added to this parameter or the firstUpdate function could be modify in order to achieve this.
Additional context
Our Code

Wrong component


Add skeletal PPP for Tze Kin

Added a skeletal PPP for Tze Kin.

Codecov Report

Merging #33 (6dd2bdb) into master (0b28751) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #33   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


net: lwm2m: Ensure string termination

When writing string data to resources which are string types, we should count in the terminating character into the data length.
Corner cases exist where LwM2M resource type is opaque but lwm2m_get_string() or lwm2m_set_string() are used to read/write the data. We must ensure string termination on those case, but terminating character must not be stored in the engine buffer or counted in the data length as this might be considered as part of the binary data.
Fixes #59196

Fixed the remarks and rebased.


Fix error when creating signed cert for Kubernetes

This script fails in the last line due to the following validation error:
error: error validating "STDIN": error validating data: [apiVersion not set, kind not set]; if you choose to ignore these errors, turn validation off with --validate=false
I changed it to instantly create the secret in the given namespace instead of piping the result of the dry-run.
Follow up of #5473

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: andraxylia
Assign the PR to them by writing /assign @andraxylia in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @idoshamun. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/assign @andraxylia

/ok-to-test

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: andraxylia
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [andraxylia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@idoshamun: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
92467fba0353439bbd571931394b095679eda4a9
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@idoshamun: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
92467fba0353439bbd571931394b095679eda4a9
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
92467fba0353439bbd571931394b095679eda4a9
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@idoshamun: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
92467fba0353439bbd571931394b095679eda4a9
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
92467fba0353439bbd571931394b095679eda4a9
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
92467fba0353439bbd571931394b095679eda4a9
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This script is no longer in use. We should try to delete it.

@yusuoh documentation states to use this script to install the webhook for the sidecar injection. I couldn't follow it, this is why I suggests this fix

@andraxylia doshamun The documentation for webhook installation is already updated for 0.8.  See
https://preliminary.istio.io/docs/setup/kubernetes/sidecar-injection.html#installing-the-webhook

@yusuoh If the script does not work as expected, we should fix it (i.e. merge this since @andraxylia
already approved) ASAP.
If the script is indeed no longer needed, we should delete it and clean up the doc on istio.io.

SGTM
@idoshamun are you going to update this PR and delete the script instead?

Yap, as soon as I can
On Wed, May 16, 2018, 20:31 Andy Lai<EMAIL_ADDRESS>wrote:

SGTM
@idoshamun https://github.com/idoshamun are you going to update this PR
and delete the script instead?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/5493#issuecomment-389601993, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB5qHb4q74l3cO78RFpZO40uMjNGnrLXks5tzGKLgaJpZM4T35AB
.

sounds good to me.

New changes are detected. LGTM label has been removed.

@hklai @andraxylia PR is ready :)

/lgtm

@idoshamun: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
92467fba0353439bbd571931394b095679eda4a9
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
26a67e89cb3077897ec34d6422d21bbca85d2038
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Create ProxyAdmin.sol

Unify proxy admins under one admin contract.

Notable proxies to link ownership:

AutID
GlobalParameters
HubRegistry

Open question: should the proxies of Membership, Participation, and TaskManager all be owned by AutID?  Or some other entity?


chore: editable email chip merchant requirement

Type of Change

[ ] Bugfix
[ ] New feature
[x] Enhancement
[ ] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description

Motivation and Context

How did you test it?

Checklist

[x] I ran npm run re:build
[x] I reviewed submitted code
[ ] I added unit tests for my changes where possible

The main issue persists even after making the chip editable: the "Add User" button remains disabled.


spatial airr data

Description of feature
Apparently this is a thing now (e.g. 10x spatial transcriptomics + mixcr, e.g. in this paper).
@giovp is there anything we need to do to leverage squidpy + scirpy together for this kind of data?
Can we account for this type of data in the design of the new data structure (#327)?
CC @FFinotello

One thing to add here would be that in case this is to be represented as a MuData object, we would like to provide an interface for this in muon.spatial relying on squidpy.

https://twitter.com/soph_liu/status/1579913561215639554

https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>6865v1

From https://www.nature.com/articles/s41592-024-02243-4 (review on single-cell immune repertoire analysis)

Although there is considerable interest in spatial profiling of TCR/BCR, this field is very new. Parenthetically, downstream analysis options are limited. A common approach to spatial TCR-seq is by using MiXCR14 to perform TCR reconstruction from the spatial sequencing data generated from full-length cDNA libraries. Engblom et al.96 developed two protocols for spatial TCR/BCR-seq (Spatial VDJ) to capture paired-chain BCR and TCR sequences, as an extension of the 10x Genomics Visium spatial transcriptomics platform. The long-read version is compatible for capturing full-length BCR and TCR sequences, while the short-read version is only for TCR96. For the long-read Spatial VDJ data, relevant reads were prepared into fastq files and MiXCR was used for gene annotation. Short-read Spatial VDJ data were processed using pRESTO99 before analyzing with MiXCR. Spatial barcodes were appended to the MiXCR outputs using custom R scripts, and downstream clonotyping analysis was primarily achieved by leveraging the Immcantation19 workflow. Similarly, the recently described SPTCR-seq95 method includes a bespoke probe-based library preparation protocol that leverages the fact that several commercially available spatial transcriptomics technologies generate full-length cDNA libraries at some point in their respective protocols, allowing them to sensitively and specifically capture and reconstruct full-length TCR sequences using long-read sequencing. SPTCR-seq also includes a computational pipeline to extract the TCR-seq data, which includes annotation with IgBLAST against IMGT references and their SPATAimmune R package to import and visualize the SPTCR-seq data. Overall, while we note that capturing spatial TCR/BCR information can potentially provide additional resolution of spatially relevant immunological partners and immune response, there is a general lack of dedicated computational frameworks or tool kits that can carry out quality-control checks or perform integrated analysis of spatial information, RNA and TCR/BCR data. It also remains to be determined whether the appropriate data structures are available or suitable for analyzing these new data modalities.

For supporting spatial AIRR data we need to distinguish between

spot-based (visium-like) data and
data with cellular or subcellular resolution.

For spot-based data, several steps in the workflow need to be adapted which I'll detail in a separate issue. For spatial data with single-cell resolution, the existing workflow should work as is, but we'd need to think about how to integrate well with squidpy and SpatialData.


Need help adjusting SamAutomaticMaskGenerator.

I am trying to use SamAutomaticMaskGenerator to generate masks for some skin lesion images recently and it seems that the automatically generated masks do not work well on these types of images as the border is not very clear. There are plenty of parameters that could be adjusted in SamAutomaticMaskGenerator but I did not really get a better result from them. Are there some suggestions on how the arguments in SamAutomaticMaskGenerator should be set for this task?
An example of the image acquired from SamAutomaticMaskGenerator is shown below.
Input image:

Output mask (grayscale):

Any help is appreciated. Thank you!

You can use the Box tool to segment the middle region


Cleanups & Zipkin addon

Removing unused files and directories.
Adding zipkin service addon. Documentation to follow.

Jenkins job istio/presubmit passed

Jenkins job istio/presubmit passed


Fix typo in comment

seperate -> separate
seperately -> separately

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?

This is in an external dependency, submit it there: https://github.com/david942j/patchelf.rb

@reitermarkus Thanks! I'll try it.


OCPBUGS-14762: remove readiness check for cache exclusion

This readiness check is causing issues when adding and removing nodes from the cluster. See kubernetes-sigs/cloud-provider-azure#4230 for details.
Upstream have set a milestone to fix this for 1.28, but we need it in 1.27 and 1.26 so will merge here and create a backport for the in-tree provider for 1.26.

/approve


Remove unnecessary branching from bundle insertion

Objective
Speed up bundle insertion and spawning from a bundle.
Solution
Use the same technique used in #6800 to remove the branch on storage type when writing components from a Bundle into storage.

Add a StorageType argument to the closure on Bundle::get_components.
Pass C::Storage::STORAGE_TYPE into that argument.
Match on that argument instead of reading from a Vec<StorageType> in BundleInfo.
Marked all implementations of Bundle::get_components as inline to encourage dead code elimination.

The Vec<StorageType> in BundleInfo was also removed as it's no longer needed. If users were reliant on this, they can either use the compile time constants or fetch the information from Components. Should save a rather negligible amount of memory.
Performance
Microbenchmarks show a slight improvement to inserting components into existing entities, as well as spawning from a bundle. Ranging about 8-16% faster depending on the benchmark.
group                                          main                                    soft-constant-write-components
-----                                          ----                                    ------------------------------
add_remove/sparse_set                          1.08  1019.0±80.10µs        ? ?/sec     1.00   944.6±66.86µs        ? ?/sec
add_remove/table                               1.07  1343.3±20.37µs        ? ?/sec     1.00  1257.3±18.13µs        ? ?/sec
add_remove_big/sparse_set                      1.08  1132.4±263.10µs        ? ?/sec    1.00  1050.8±240.74µs        ? ?/sec
add_remove_big/table                           1.02      2.6±0.05ms        ? ?/sec     1.00      2.5±0.08ms        ? ?/sec
get_or_spawn/batched                           1.15   401.4±17.76µs        ? ?/sec     1.00   349.3±11.26µs        ? ?/sec
get_or_spawn/individual                        1.13   732.1±43.35µs        ? ?/sec     1.00   645.6±41.44µs        ? ?/sec
insert_commands/insert                         1.12   623.9±37.48µs        ? ?/sec     1.00   557.4±34.99µs        ? ?/sec
insert_commands/insert_batch                   1.16   401.4±17.00µs        ? ?/sec     1.00   347.4±12.87µs        ? ?/sec
insert_simple/base                             1.08    416.9±5.60µs        ? ?/sec     1.00    385.2±4.14µs        ? ?/sec
insert_simple/unbatched                        1.06   934.5±44.58µs        ? ?/sec     1.00   881.3±47.86µs        ? ?/sec
spawn_commands/2000_entities                   1.09   190.7±11.41µs        ? ?/sec     1.00    174.7±9.15µs        ? ?/sec
spawn_commands/4000_entities                   1.10   386.5±25.33µs        ? ?/sec     1.00   352.3±18.81µs        ? ?/sec
spawn_commands/6000_entities                   1.10   586.2±34.42µs        ? ?/sec     1.00   535.3±27.25µs        ? ?/sec
spawn_commands/8000_entities                   1.08   778.5±45.15µs        ? ?/sec     1.00   718.0±33.66µs        ? ?/sec
spawn_world/10000_entities                     1.04  1026.4±195.46µs        ? ?/sec    1.00  985.8±253.37µs        ? ?/sec
spawn_world/1000_entities                      1.06   103.8±20.23µs        ? ?/sec     1.00    97.6±18.22µs        ? ?/sec
spawn_world/100_entities                       1.15     11.4±4.25µs        ? ?/sec     1.00      9.9±1.87µs        ? ?/sec
spawn_world/10_entities                        1.05  1030.8±229.78ns        ? ?/sec    1.00  986.2±231.12ns        ? ?/sec
spawn_world/1_entities                         1.01   105.1±23.33ns        ? ?/sec     1.00   104.6±31.84ns        ? ?/sec

Changelog
Changed: Bundle::get_components now takes a FnMut(StorageType, OwningPtr). The provided storage type must be correct for the component being fetched.

Manual implementations of Bundle are unsupported, so a migration guide should be unnecessary.

documentation on how this works for mixed storage type bundles

The safety comments mention that it uses the per-component constants so it will still work for mixed bundles.

bors r+


Encourage use of partial and lambda?

It's somewhat disappointing when you see inconsistent handling of *args and **kwargs across SciPy. For example ode and odeint accept only *args for user-supplied methods. But the passing of extra parameters is actually a solved problem using lambdas or functools.partial.
In MATLAB this is the new method they are encouraging (see http://www.mathworks.nl/matlabcentral/newsreader/view_thread/308285#837860).

lambdas in Python are disgusting anyways.


Error deduplication rebase

Reduces total warnings from ~485 to 66.
I'd review this PR by each individual error message (and commit message), as I don't recommend all changes equally. I suspect you may not agree with 'deduplicating' with particularly '03006'.
The most logically complex error was 03003.
De-depuplication of error 03003
-Reduces the quantity of EC:03003 from 354 to 12
-This is a recommended deduplication
De-depuplication of error 03004
-Reduces the quantity of EC:03004 from 43 to 15
-This is a maybe-recommended deduplication.
De-duplication of error 03006
-Reduces quantity of EC:03006 from 83 to 27. The method involves reclassifying all non-direct descendants of the profile.type to a lower level warning (‘info’)
-Not necessarily a recommended deduplication. Those lower level elements are also valid warnings that should be resolved…

Rebased on top of master.

This PR is getting a little unwieldy, and it is becoming hard to organize updates and suggestions. Closing and splitting to a pair of PRs:
https://github.com/standardhealth/shr-fhir-export/pull/90
https://github.com/standardhealth/shr-fhir-export/pull/91


Karpenter does not respect reasons in budgets

Description
Karpenter does not respect reasons in budgets. In my configuration i don't have budgets which would deny all three reasons.
Observed Behavior:
57m         Normal    DisruptionBlocked            nodepool/eks-prodau-linux-amd64                                 No allowed disruptions for disruption reason Underutilized due to blocking budget
57m         Normal    DisruptionBlocked            nodepool/eks-prodau-linux-amd64                                 No allowed disruptions for disruption reason Empty due to blocking budget
57m         Normal    DisruptionBlocked            nodepool/eks-prodau-linux-amd64                                 No allowed disruptions for disruption reason Drifted due to blocking budget

Expected Behavior:
The expected behavior is Karpenter to respect reasons in budgets and make a differentiation as described.
This rule assumes disruptions for Empty and Drifted reasons allowed by one node at a time and denied for Underutilized nodes.
spec:
  disruption:
    budgets:
    - nodes: "2"
    - duration: 20h
      nodes: "1"
      reasons:
      - Empty
      - Drifted
      schedule: 0 7 * * *
    - duration: 20h
      nodes: "0"
      reasons:
      - Underutilized
      schedule: 0 7 * * *
    consolidateAfter: 30m
    consolidationPolicy: WhenEmptyOrUnderutilized

Reproduction Steps (Please include YAML):
Versions:

Chart Version:  1.0.0
Kubernetes Version (kubectl version): 1.29

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

+1 facing similar issue. Budgets are not being honoured and nodes are terminated even within budget window schedule

+1 Facing the same issue as utk231.

I'm not 100% sure, but from what I observe after update to 1.0.8, karpenter doesn't respect schedule in general, not reasons.
I.e. in our case this disruption budget works partially (no Drifted actions happen, but Empty, Underutilized could happen any time).
  disruption:
    consolidationPolicy: WhenEmptyOrUnderutilized
    consolidateAfter: 0s
    budgets:
      - schedule: 0 8 * * mon-fri # working days and hours
        duration: 8h
        nodes: 10%
        reasons: [Empty, Underutilized]
      - nodes: "0"
        reasons: [Drifted] # disable drift disruption


Disable compression of nodegit

System information

node version: v14.15.0
npm or yarn version: 6.14.10
OS/version/architecture: darwin
Applicable nodegit version: 20.2.0

Hi, I am sorry if this is not the right place to ask, but I am trying to disable the compression/packing in nodegit. Git has a config called config.compression which isn't supported by libgit2. Does anyone have an idea how I can disable this via nodegit, or is this a question exclusively for libgit2?
Thanks!

@Githubber2021 NodeGit is a wrapper around libgit2 so you should probably take this up with them.

@Githubber2021 NodeGit is a wrapper around libgit2 so you should probably take this up with them.

Allright, thank you!

Allright, thank you!


Need a chorus-opensearch-edition.dev.o19s.com DNS entry

Let's have a DNS name for demoing...

Okay, we have http://chorus-opensearch-edition.dev.o19s.com alive...  so http://chorus-opensearch-edition.dev.o19s.com:4000/ for the front end for example...


questions about training

Dear author, I see your new work Meteor, its so awesome! But I still have questions with MoAI. Sorry to bother again.
The first one:
in the paper, you mentioned you used beamsearch=3 in generation, but I see the demo you used top_p=0.95. Is beamsearch=3 used in training? But In training, using beamsearch seems not common.
The second one:
What type of initialization is used for MoE (the six experts) in the second training step?

Text generation is not involved in training
Therefore, beam search is only depending on inference
For the demo, we set topp and temperature for diverse text generation


LilyGO T-Internet POE REBOT NOT WORKING

Hardware
LilyGO T-Internet POE
Firmware version
V.2.4.6
Application version
V.2.4.6
What happened? What did you expect to happen?
when i press   reboot command the board  going to loop and not rebooting  i need  to make restart from the POE cable
its do from HA and ESPSOMFY RTS WEB

OR  if i change  setting  and press  save its same problem  the board do loop and stacking

Thanks for your  job  🙏
How to reproduce it (step by step)
1. i trying  from the web application

2. i trying  from Home Assistant

Logs
No response

Please double check the documentation for your version of the board.  I have read that the Power pin may have changed to GPIO 4 for later versions.

Its working but after X Time it's stop working.
And when trying to reboot or update setting its stack.
בתאריך יום ג׳, 22 באוק׳ 2024 ב-20:52 מאת rstrouse @.***

:

Please double check the documentation for your version of the board. I
have read that the Power pin may have changed to GPIO 4 for later versions.
—
Reply to this email directly, view it on GitHub
https://github.com/rstrouse/ESPSomfy-RTS/issues/481#issuecomment-2429901155,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALPOXPPWFQAPLTUQIZFUZI3Z42GF7AVCNFSM6AAAAABQBPZ5MSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRZHEYDCMJVGU
.
You are receiving this because you authored the thread.Message ID:
@.***>


[Question] Can customize-cra help override postcss plugins in cra2 webpack config?

I'm looking to add tailwindcss to a non-ejected cra2 app, and to have tw processed by postcss. I could fork react-scripts, but would prefer to simply leverage customize-cra if I can. Thanks in advance for any help / guidance.

You can probably add it here. Is it a Babel plugin?

Hey @arackaf sincere thanks for your response and sorry I wasn't able to respond in turn sooner. It turns out I don't need customize-cra in order to do what I needed. Using babel-plugin-macros (which is included in CRA2) I'm able to leverage tailwind and emotion. Good luck w/ the project!


Users profile header will show their personal best stats (top rope/boulder highest grades)

It could also show total sends, ... etc other stats, I don't think the design is solidified yet.
Tasks for this requirement:

[ ] (devs fill in here with a link to your issues)
[ ] 2
[ ] 3

is this done? I think @abrugal did this ages ago

Yeah this is done


CET-13421 Adobe performance with Backstage on Bird's Eye report

Change description
CET-13421 Adobe performance with Backstage on Bird's Eye report
Requires BE: https://github.com/cortexapps/brain-backend/pull/8087
Changed fetching owners for entities to fetch only those for entities for which we have scores for scorecard.
Type of change

[ ] Bug fix (fixes an issue)
[ ] New feature (adds functionality)
[x] Improvement (improves codebase without changing functionality)

Checklists
Development

[x] The changelog has been updated as appropriate
[x] Lint rules pass locally
[x] Application changes have been tested thoroughly
[x] Automated tests covering modified code pass

Security

[x] Security impact of change has been considered
[x] Code follows company security practices and guidelines

Code review

[x] Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
[x] "Ready for review" label attached and reviewers assigned
[ ] Changes have been reviewed by at least one other contributor
[x] Pull request linked to task tracker where applicable

One thing we actually want to do is swap this over to /scores/compact which sends a way smaller data structure that is reconstructed on the frontend.
That may be worth doing opposed to this.

@browniefed

One thing we actually want to do is swap this over to /scores/compact which sends a way smaller data structure that is reconstructed on the frontend.
That may be worth doing opposed to this.

Actually the main problem is not the amount of entities to fetch the owners for but resolving ownerships on BE. This will be resolved with the graph for long-term.


binary is xz not gzip

On rhel7 I had to use this:
tar Jxf postgrest-<IP_ADDRESS>-centos.tar.xz
Instead of this (from install doc):
tar zxf postgrest-[version]-[platform].tar.xz
I'm not a unix wizard so I could be missing something

Oh you're right, J is the right option for xz. Want to send a PR?


which paper to cite?

Love this repo, helps me a lot! is there any paper of yours I can cite?

Hey @anonymous-author-here! I'm really glad it's helpful! :)
You can cite the original paper mentioned in README, or the repo directly if you want to refer to the implementation ✌


feat(wikipedia): add option for redirect highlight

🔧 What does this fix? 🔧
This puts the green redirect highlight behind an option, as it does not seem to be Wikipedia's default behavior and feels opinionated.
I've done this instead of outright requesting to remove it, as the contributing guide does not seem to outright prevent this since it's just a color change. However, it feels against the spirit of the opinionated section to me, and I also just don't like the green 🙃
On (previously the only behavior):

Off (added in this PR):

🗒 Checklist 🗒

[x] I have read and followed Catppuccin's contributing guidelines.
[x] I have updated the version appropriately in the ==UserStyle== header of the catppuccin.user.css file.

This puts the green redirect highlight behind an option, as it does not seem to be Wikipedia's default behavior and feels opinionated.

I actually quite like this and the implementation you went with works pretty well. Thank you.


BillingType.cs from #53

BillingType.cs
using System.Runtime.Serialization;

namespace WebApi.Entities;

public enum BillingType
{
    [EnumMember(Value = "None")]None,
    [EnumMember(Value = "Stripe")]Stripe,
    [EnumMember(Value = "Invoice")]Invoice,
    [EnumMember(Value = "PayPal")]PayPal,
    [EnumMember(Value = "Other")]Other,
    [EnumMember(Value = "DD")]DD,
    [EnumMember(Value = "Shopify")]Shopify,
    [EnumMember(Value = "CreditAccount")]CreditAccount
}

Originally posted by @danijeljw-RPC in https://github.com/OptechX/users.api/issues/53#issuecomment-1435945220

Resolved in https://github.com/OptechX/users.api/commit/3ee196314fea9774cb84825c3ca41c3a66a06eb5


Make the PR template simpler

Nowadays people usually don't follow the current PR template. They either delete the whole thing and add the description text, or they add the description on top of the prefilled template.
This PR makes the template simpler and the only ask from author is to add proper labels. This will be super helpful during the release phase. I had to go over 300 commits one by one and let's say the experience wasn't pleasant ;)
I added all PMC members as reviewers for this PR to get a consensus on it and afterwards committers as well as reviewers should follow the new simple process.

This is great, the labels can also be used to drive github actions.

Thanks for starting this, @sajjad-moradi . The original set of instructions/checkbox/description was meant for people to apply the right label to every PR, but clearly fell short of its goals. I am totally supportive of this, in any language to help achieve that goal. It is a pity if committers have to spend  lots of time going through individual commits. (soon, we will not find any volunteers :)
As committers, can we agree to ensure that the PRs we merge follow these instructions?

Short of any automation (which would have been ideal here), my suggestion/vote would be towards:

Document guidelines on how PRs should be labelled.
The reviewers who would review / merge the PR should ensure that the PRs are labelled correctly, given that contributors won't have permissions to do so. Also, adding too much process might work adversely for first time contributors.

(If I understand correctly, this is also what @richardstartin is saying).

As part of the flow, I feel we can also introduce the ci check on the PR title/description and fail automatically if any required field is missing. Example on superset side: https://github.com/apache/superset/blob/master/.github/workflows/pr-lint.yml


Edited the "weekContainer" gap to 24px in the PDF Midweek Meeting template.

Description
I adjusted the spacing in the template to make it look more impressive. Currently, the spacing in the layout is 5 pixels, which is too close.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[ ] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

:tada: This PR is included in version 2.130.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[stable/fluentd] fluentd chart is too coupled with elasticsearch

Describe the bug
Currently the fluentd chart is having the hard-coded environment variables and default values for outputs to ES:
https://github.com/helm/charts/blob/master/stable/fluentd/templates/deployment.yaml#L50-L61
https://github.com/helm/charts/blob/master/stable/fluentd/values.yaml#L115-L139
Not everybody is using elasticsearch as output sink, some people may uses kafka, stackdriver, etc.
I think the fluentd chart should be neutral for the output destination, hard code a bunch of environment variables is strange.

anyone?


Cannot destructure property 'request_id' of 'response' as it is undefined

I just installed llm-vscode and did "Llm: Login" using my hugging face token (read-only).
When I try "Llm: After Insert" (which I assume is the completion command), I get an error message dialog:

Command 'Llm: After Insert' resulted in an error
Cannot destructure property 'request_id' of 'response' as it is undefined.

VS code version: 1.84.1
OS: Ubuntu 23.10
llm-vscode: 0.1.6
I have tried with starcoder and codellma as Config Template.

If that is not the completion command, what is? I would like to trigger it manually as sometimes my llm response time is very low and I want to make sure that it actually triggerred. I feel like llm-vscode sometimes does not trigger automatically

Completion is currently bound to the following keybinding:
 {
   "key": "cmd+shift+l",
   "command": "editor.action.inlineSuggest.trigger"
 },


Publish actual source in packages

Some packagers will give you warnings like,
Could not load source file "../../src/thread/index.ts" in source map of<EMAIL_ADDRESS>
We should package the actually TS source with the releases too (or maybe something just needs an update in the package.json if they already are).

We can include the typescript sources in our output npm package, but this will increase the size of our bundle (not a huge issue), and isn't helpful outside of source mapping. Maybe we should just not include the source maps in our outputs instead? They really mostly useful for local dev right?

yeah exactly. either both all or neither.
it would only increase the download size right? it shouldn't increase final app sizes?
one benefit of adding them is for our own cross lib development it may be nice for tracking down real issues contained in releases more quickly. yet to be seen though

Ok, I'll look into adding the sources for now, and then maybe we pull them once we have a more stable ecosystem and are more concerned about release size and things like that. And yes, it shouldn't affect bundle size unless someone is building a dev bundle, in which case, they aren't all that concerned about size anyway.


Roll Flutter Engine from 30327eae0802 to 3cfcdebe8623 (1 revision)

https://github.com/flutter/engine/compare/30327eae0802...3cfcdebe8623
2023-11-15<EMAIL_ADDRESS>[Impeller] some clang tidies in impeller (flutter/engine#48077)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


[16.x] Add root variant to track_features

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

As requested at https://github.com/conda-forge/clangdev-feedstock/issues/265

Can you please bump the build number as well?

Can you please bump the build number as well?

Sure! Apologies as I am still not sure about which changes need to trigger a bump in the build number (I guess anything that requires a rerender maybe?)


Remove IE11 focus timeouts in tests

Fixes #395
Not sure why those timeouts were at the first place, but tests are passing in every browser including IE11

This change is

Obviously removing assertions from tests instead of fixing them, makes the build pass.
A test without any assertion is useless.
Please don't merge this to master :-1:

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Oops, sorry. I didn't notice assertions without the expect keyword.

Review status: 0 of 4 files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable


Add AnalysisError handler to Driver and Context to OutputFunc interface [phab:D428]

Created by schroederc at 2015-07-27 17:09:59:

schroederc wrote at 2015-07-27 17:11:12:
Fix lint

schroederc wrote at 2015-07-27 17:12:55:
Fix dep

shahms accepted this revision at 2015-07-27 22:19:38

schroederc closed via commit 9f1071c45eb04aae3c4215fdaf02b1770bc292cc at 2015-07-27 23:03:22