String operation warnings on GCC 8.1 (#420 revisited)

(I thought I could re-open a bug, but apparently not. This is from #420)
I've run into this now compiling jansson 2.12.0 under the xtensa-esp32-elf 8.2.0 compiler. It's because -Wformat-truncation is passed in from the upper level Makefile. I also threw in a warning about an unused function :)
[https://developers.redhat.com/blog/2018/05/24/detecting-string-truncation-with-gcc-8/] is a decent article about handling the issue. Although personally I'd be inclined to use
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wformat-truncation"
...
#pragma GCC diagnostic pop

Error message:
[redacted]/components/jansson/hashtable_seed.c:48:17: warning: 'buf_to_uint32' defined but not used [-Wunused-function]
 static uint32_t buf_to_uint32(char *data) {
                 ^~~~~~~~~~~~~
CC build/jansson/load.o
CC build/freemodbus/port/portserial.o
[redacted]/components/jansson/load.c: In function 'error_set':
[redacted]/components/jansson/load.c:118:29: error: ' near '' directive output may be truncated writing 7 bytes into a region of size between 1 and 160 [-Werror=format-truncation=]
                          "%s near '%s'", msg_text, saved_text);
                             ^~~~~~~
[redacted]/components/jansson/load.c:117:17: note: 'snprintf' output 9 or more bytes (assuming 168) into a destination of size 160
                 snprintf(msg_with_context, JSON_ERROR_TEXT_LENGTH,
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                          "%s near '%s'", msg_text, saved_text);
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[redacted]/components/jansson/load.c:135:29: error: ' near end of file' directive output may be truncated writing 17 bytes into a region of size between 1 and 160 [-Werror=format-truncation=]
                          "%s near end of file", msg_text);
                             ^~~~~~~~~~~~~~~~~
[redacted]/components/jansson/load.c:134:17: note: 'snprintf' output between 18 and 177 bytes into a destination of size 160
                 snprintf(msg_with_context, JSON_ERROR_TEXT_LENGTH,
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                          "%s near end of file", msg_text);
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[1]: *** [load.o] Error 1
make: *** [component-jansson-build] Error 2
make: *** Waiting for unfinished jobs....

I'm not in support of making such a change.  The problem is that you are providing incompatible CFLAGS to the jansson build.  I recommend using the following to configure jansson:
CFLAGS="$CFLAGS -Wno-format-truncation" ./configure [arguments...]

Setting CFLAGS in this way will override the incompatible -Wformat-truncation provided by the parent Makefile while allowing other CFLAGS overrides to be honored (such as -Werror which you also seem to be adding).

Those warnings are there for a reason, aren't they? (buffer-overflow any one?) And at least two are easily solved by increasing msg_with_context's size.


tooltip text grabbing broken

Issue Type: Bug
Hover over any tooltip generating text. Grabbing text with mouse doesn't work.
VS Code version: Code 1.56.2 (054a9295330880ed74ceaedda236253b4f39a335, 2021-05-12T16:45:26.313Z)
OS version: Linux x64 5.0.0-32-generic

Which tooltips are you looking at? Native OS tooltips have never been copiable.

The issue is with vscode hover tooltips - such as shown in this attachment:

I've always been able to copy from them, and now grabbing doesnt work at all.

Check that you didn't disable editor.hover.sticky

Hi - it seems that the problem was my chosen theme (the vscode solarized light) highlight color just didn't indicate that text was being grabbed with the grayish overlay color usually present - this has never been a problem. I assume this means that this wouldn't be considered an issue with vscode? If so, where should I submit issues with builtin vscode themes?

@misolori @aeschli Do you know who owns this theme and its color for selected text? It looks like the selected text color (not the editor selected text color) is the same as the hover background:
https://user-images.githubusercontent.com/5047891/120210337-f5eaf680-c22f-11eb-9761-8c2f1c75cce5.mp4

Same reason as #123044. Looks like the workbench selection color defined by the theme is now used by Electron, but wasn't before. Fixing the color...
The color id is "selection.background"


Run workflow job based on files committed

Closes #480
GitHub Actions actually makes this not too bad to do using outputs.
We add another job in both workflows called check-diff that runs before all other jobs. check-diff determines if frontend/ or cloud-functions/ was altered by the previous commit. If one of the directories was altered, an output with its name is set  (see here for a general example).  Later jobs check the outputs and only execute if the correct output was set. The fronted jobs will only run if frontend/ or config/ changed in the previous commit and the firebase jobs only run if cloud-functions/ or config/ changed in the previous commit.
For example, in this run, I only changed the workflow file, so none of the frontend or cloud functions jobs ran.

Closes #480
GitHub Actions actually makes this not too bad to do using outputs.
We add another job in both workflows called check-diff that runs before all other jobs. check-diff determines if frontend/ or cloud-functions/ was altered by the previous commit. If one of the directories was altered, an output with its name is set (see here for a general example). Later jobs check the outputs and only execute if the correct output was set. The fronted jobs will only run if frontend/ or config/ changed in the previous commit and the firebase jobs only run if cloud-functions/ or config/ changed in the previous commit.
For example, in this run, I only changed the workflow file, so none of the frontend or cloud functions jobs ran.

One issue this approach might cause is if those jobs don't run, but are considered "required" before merge by our branch protection rule, it might not allow us to merge (without an admin override).
One way we might solve that is to check within the tests "if CI, if <cloud-functions/frontend> not in check-diff output, pass-all-tests (or don't run tests, or some sort of jest hack)"
On the other hand, maybe branch protection rules are smart enough to account for this. May as well try this simpler approach first, and then if it doesn't work with the protection rules try this other one I just laid out.

That makes sense. Once this is approved we can see if it will let us merge. If not, we can rework.

Yep, something is still off for sure. I’ll take a look when I get internet back at my house (commenting from mobile).

Based on DM's w/ @colbymorrison: It seems as though all of our tinkering threw GitHub actions into a weird state. Closing this, replaced by https://github.com/covidwatchorg/portal/pull/516/.


Possible regression in overloads with optional this types in callbacks

Bug Report
I believe #52838 #52387 is the cause of a “regression” in Ember’s type test suite, but I also am very willing to believe that this is a bug in how Ember’s types are written which this change caught, but I wanted to flag it up.
Here's the type test (source):
expectTypeOf(
  bind(foo, function (_foo: number, _bar: boolean, _baz?: string): number {
    expectTypeOf(this).toEqualTypeOf<Foo>();
    return 1;
  })
).toEqualTypeOf<(foo: number, bar: boolean, baz?: string) => number | void>();

Here's the set of overloads, including the implementation overload (source):
export function bind<
  T,
  F extends (this: T, ...args: any[]) => any,
  A extends PartialParams<Parameters<F>>
>(
  target: T,
  method: F,
  ...args: A
): (...args: RemainingParams<A, Parameters<F>>) => ReturnType<F> | void;
export function bind<F extends AnyFn, A extends PartialParams<Parameters<F>>>(
  method: F,
  ...args: A
): (...args: RemainingParams<A, Parameters<F>>) => ReturnType<F> | void;
export function bind<
  T,
  U extends keyof T,
  A extends T[U] extends AnyFn ? PartialParams<Parameters<T[U]>> : []
>(
  target: T,
  method: U,
  ...args: A
): T[U] extends AnyFn
  ? (...args: RemainingParams<A, Parameters<T[U]>>) => ReturnType<T[U]> | void
  : never;
export function bind(...curried: any[]): any {
  // ...
}

Prior to this change, this type checked. After this change, it reports:
No overload matches this call.
  Argument of type '[]' is not assignable to parameter of type 'never'.
  Overload 2 of 3, '(method: AnyFn, ...args: never): (...args: never) => any', gave the following error.
    Argument of type 'Foo' is not assignable to parameter of type 'AnyFn'.
  Overload 3 of 3, '(target: Foo, method: "test"): (_foo: number, _bar: boolean, _baz?: string | undefined) => number | void', gave the following error.
    Argument of type '(this: Foo, _foo: number, _bar: boolean, _baz?: string | undefined) => number' is not assignable to parameter of type '"test"'.ts(2769)
index.ts(295, 17): The call would have succeeded against this implementation, but implementation signatures of overloads are not externally visible.

Prior to this change, it was resolving against the first overload:
export function bind<
  T,
  F extends (this: T, ...args: any[]) => any,
  A extends PartialParams<Parameters<F>>
>(
  target: T,
  method: F,
  ...args: A
): (...args: RemainingParams<A, Parameters<F>>) => ReturnType<F> | void;

I have tried adding an overload which has the same form but does not explicitly include the this type on the F constraint, but at that point I'm in overload-ordering hell.
🔎 Search Terms

overloads
this type

🕗 Version & Regression Information
This changed between versions 5.1.0-dev.20230301 and 5.1.0-dev.20230302.
⏯ Playground Link
Playground link with relevant code
💻 Code
import { expectTypeOf } from 'expect-type';

// ----- TEST CODE ----- //
class Foo {
  literallyAnythingToAvoidAnEmptyClass() {}
}

let foo = new Foo();

expectTypeOf(
  bind(foo, function (_foo: number, _bar: boolean, _baz?: string): number {
    expectTypeOf(this).toEqualTypeOf<Foo>();
    return 1;
  })
).toEqualTypeOf<(foo: number, bar: boolean, baz?: string) => number | void>();

// ----- OVERLOAD DEFINITIONS ----- //

export function bind<
  T,
  F extends (this: T, ...args: any[]) => any,
  A extends PartialParams<Parameters<F>>
>(
  target: T,
  method: F,
  ...args: A
): (...args: RemainingParams<A, Parameters<F>>) => ReturnType<F> | void;
export function bind<F extends AnyFn, A extends PartialParams<Parameters<F>>>(
  method: F,
  ...args: A
): (...args: RemainingParams<A, Parameters<F>>) => ReturnType<F> | void;
export function bind<
  T,
  U extends keyof T,
  A extends T[U] extends AnyFn ? PartialParams<Parameters<T[U]>> : []
>(
  target: T,
  method: U,
  ...args: A
): T[U] extends AnyFn
  ? (...args: RemainingParams<A, Parameters<T[U]>>) => ReturnType<T[U]> | void
  : never;
// overload implementation
export function bind(...curried: any[]): any {
  // ...
}

// ----- TYPE UTILITIES ----- //

export type AnyFn = (...args: any[]) => any;

type PartialParams<P extends any[]> = P extends [infer First, ...infer Rest]
  ? [] | [First] | [First, ...PartialParams<Rest>]
  : // This is necessary to handle optional tuple values
  Required<P> extends [infer First, ...infer Rest]
  ? [] | [First | undefined] | [First | undefined, ...PartialParams<Partial<Rest>>]
  : never;

type RemainingParams<PartialParams extends any[], All extends any[]> = PartialParams extends [
  infer First,
  ...infer Rest
]
  ? All extends [infer AllFirst, ...infer AllRest]
    ? First extends AllFirst
      ? RemainingParams<Rest, AllRest>
      : never
    : // This is necessary to handle optional tuple values
    Required<All> extends [infer AllFirst, ...infer AllRest]
    ? First extends AllFirst | undefined
      ? Partial<RemainingParams<Rest, AllRest>>
      : never
    : never
  : PartialParams extends []
  ? All
  : never;

🙁 Actual behavior
Wellllll the overload isn't working anymore.
🙂 Expected behavior
I think I expected this overload to keep working.

If you replace never with [] within your PartialParams then it starts to work again: TS playground

Thanks!

While this got fixed in Ember types... I wonder how many more such reports we will get. Hopefully not many, I think this case was slightly off from the beginning but it was also relatively easy to make such a mistake. The time will tell.

I agree that the original implementation was wrong, but unfortunately I suspect it’s semi-common, as the contributor who landed it in our types drew heavily on a Stack Overflow answer. I reviewed it when it landed, but did not notice the underlying issue originally or even when re-evaluating it yesterday. It’s quite subtle and it required basically doing the full “type check” pass mentally to see the issue.

While this got fixed in Ember types... I wonder how many more such reports we will get. Hopefully not many, I think this case was slightly off from the beginning but it was also relatively easy to make such a mistake. The time will tell.

And this is why we're merging all of this ASAP 😄


Release planning for 2206.0.0

We have decided to make the next release a major release, due to expected breaking changes. Items to complete before release:

[x] #17
[x] #60
[x] #62
- [ ] #63
[x] #53
[x] #33

Closed via #81 and #92


I hear writing tests is a good plan

Probably reasonable to have a small integration test suite that can test against providers but it sure as crap needs to work hard to clean up after itself. (And of course you'll need to supply API keys to run it).
Could against a docker container for ssh bits in theory... But setting that up on mac is unfun
Unit tests will be a fine first line. I think I remember python-digitalocean having some mock responses already which helps

Well, there's a test suite now .This will solve itself : )


docs(anchor): fix AnchorLink props desc

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (40c2068) 61.08% compared to head (c5e0e19) 61.08%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             docs    #5641   +/-   ##
=======================================
  Coverage   61.08%   61.08%
=======================================
  Files        1107     1107
  Lines       23618    23618
  Branches     6186     6186
=======================================
+ Hits        14426    14428    +2
  Misses       7598     7598
+ Partials     1594     1592    -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[1.19.2 Request] - Support for IC2 Classic

Hello, love this mod for its convenience and accessibility.
Since IC2:C has been ported to 1.19.2, I was hoping that the support for EU would be enabled for the generators.
I'd love to see some way to hook up a transformer to the generator if the packets are too large for the cable or the machine.
Thank you for this incredible mod, I plan to use it as my main source of power. <3

No promises, but i'll look at it at some point.

Added with version <IP_ADDRESS>
You have 5 tiers of output modules that you can add to generators (LV/MV/HV/EV/IV) and they will produce the appropriate power packets for IC2 cables/machines of that tier.


Year View

Thanks for your project.
As enhancement,
a year view which just shows every month with their respective days and when you tap the month it just cycles to the monthly view of the selected month :)

+1 year view with 12 months

+1 year view with months

how to create this feature?


Move window with shortcuts

Using Ctrl plus a numpad number should move the window on the current screen to a point.

[x] Ctrl + 1 moves the window to the bottom left
[x] Ctrl + 2 moves the window to the center bottom
[x] Ctrl + 3 moves the window to the bottom right
[x] Ctrl + 4 moves the window to the center left
[x] Ctrl + 5 moves the window to the center
[x] Ctrl + 6 moves the window to the center right
[x] Ctrl + 7 moves the window to the top left
[x] Ctrl + 8 moves the window to the center top
[x] Ctrl + 9 moves the window to the top right

Ctrl + num only works with the keypad numbers.
Also added Alt + num, these only work with the the alpha numeric keys. the ones on top of the letters


Python 3 Support

Currently mafan only supports Python 2 (not sure which versions). mafan's dependencies (jieba and jianfan) don't offer Python 3 support yet. jieba has jieba3k, however, it is a fork and isn't incorporated into jieba's master branch. I already submitted a Python 2 and 3 compatible version of jianfan to its developer.
Even though jieba doesn't support Python 3 yet, I think it would be good for mafan to be ready for it.
A first step could be using only unicode strings internally via adding:
from __future__ import unicode_literals
to every module and dropping all 'u' prefixes from strings.
@hermanschaaf What do you think?

Is this still in progress? If so, how can I assist?

@lucaskjaero Despite volunteering to help with this, I never made any progress. It was just one of those things that got added to my list, but never looked at again. You might see if @hermanschaaf has any news on this.

@lucaskjaero @tsroten I don't have any news on this :) But if someone wants to put some time into it, a pull request is welcome, I'll be sure to get it merged. Otherwise, it is something I can put on my personal backlog this month.

I'll take a crack at it!

Finally this was fixed by https://github.com/hermanschaaf/mafan/pull/17 and the pypi version updated. Let me know if you run into any issues!


refactor: pythonic code style, tests for Function class

Refactored class Function to be written mostly in Idiomatic Python,
following PEP8 recommendations. Code should be better readable and
more compact.

pep8
python-guide.org

Thanks!

You're welcome. I actually quite enjoy doing it. Helps me understand the code, sharpen python and test writing skills and maybe even help other people understand the code better.
What a wise guy once said, really changed the way I think about coding:

code is written once but read many times

But this is easier said than done. I often wonder myself "is this the best way to do it?".


After installing the script the changes i make in admin panel are not saved.

I did a new installation. When setting up my site in admin panel, it does not save the changes. When i click save it just defaults back to where it was. I tried different browsers and cleared my cache

I'd suggest you check this with your hosting provider. Most people who had this problem got it solved by asking their hosting provider. I can't exactly tell you what did change because people are hungry to ask for help but aren't nice enough to give us the feedback once they get the problem solved.

Thank you for your reply. I called my hosting company and they resolved the issue, It is sad however that no one comes back and notify other people on how to resolve the issue.
So here goes:

Go to your C-Panel of your hosting
Look for the Security tab
Under Security click on MOD security
Disable MOD security

Problem resolved

Hi,
If you look into the docs of pH7CMS you would see that we clearly say that ModSecurity can cause many issue with pH7CMS.
Recommended:
_JRE (Java Runtime Environment) - 1.6 or higher (used for compressing static files. The option is disabled by default and uses our homemade compressor instead. However, if you have Java installed on your server, it would be nicer to enable that option).
Apache mod_security/mod_security2 disabled - pH7CMS may not work correctly if enabled, so it's advisable to disable it for your domain (just ask your Web host or do it through cPanel)._

If you like pH7CMS could you give us a star on gitHub and write a nice review on sourceforge ?

If you problem is solved, you can close the issue.


Maid 2238 - persist log file path

Persist the log file path after initialisation.
Add options to enable/disable rust logs, to register scheme with OS and also to pass path for loading the native libraries.

Coverage increased (+1.06%) to 82.399% when pulling c1457bf5118b7f451ad5e87c7a1c17c3c0c33e8d on krishnaIndia:options into 32530ec0e9948c605c8d54f48f8844bc82183fac on maidsafe:master.

Coverage increased (+1.01%) to 82.353% when pulling 99d897eaddaa90dda63245a38dd284e24c6f6988 on krishnaIndia:options into 32530ec0e9948c605c8d54f48f8844bc82183fac on maidsafe:master.

Coverage increased (+1.01%) to 82.353% when pulling 99d897eaddaa90dda63245a38dd284e24c6f6988 on krishnaIndia:options into 32530ec0e9948c605c8d54f48f8844bc82183fac on maidsafe:master.

Coverage increased (+1.03%) to 82.368% when pulling 3a5c9d60f2fdf8f71cd00076149d7072caa8322b on krishnaIndia:options into 32530ec0e9948c605c8d54f48f8844bc82183fac on maidsafe:master.

Coverage increased (+1.03%) to 82.368% when pulling 3a5c9d60f2fdf8f71cd00076149d7072caa8322b on krishnaIndia:options into 32530ec0e9948c605c8d54f48f8844bc82183fac on maidsafe:master.

Coverage increased (+1.01%) to 82.353% when pulling d39cc8a2fc623df82163b64d5b64ae2842fe6a2d on krishnaIndia:options into 32530ec0e9948c605c8d54f48f8844bc82183fac on maidsafe:master.

Coverage increased (+18.05%) to 82.241% when pulling 9eb16aa7f1faee1621090d06f461a3eb38171c9d on krishnaIndia:options into bc6ce37ec7f6723fa715233283dd07296ef618a8 on maidsafe:master.

Coverage increased (+18.05%) to 82.241% when pulling 9eb16aa7f1faee1621090d06f461a3eb38171c9d on krishnaIndia:options into bc6ce37ec7f6723fa715233283dd07296ef618a8 on maidsafe:master.


Setting: Make new tasks appear at top of column

Hi there, would it be possible, to integrate an board option to make new tasks appear at the top rather than the bottom of a column? The reason beeing that we have a rather long list of tasks, and we tend to "forget" tasks, that are newly created and thus far down the list.
At any rate: +1 for this cool application!

Actually, I'm pretty sure there's an issue to allow sorting tasks by creation date, due date, etc. Let me see... found it #77 and it's scheduled for v0.4.0.

Well, I think #77 aims for a different thing. As it should always be possible to "sort-by-hand", this comes into play when adding a long list of tasks. You wish to sort by hand.
But no problem- was just an suggestion :D

I think I see what you're saying. There should be an option to use with the default sort (user-determined position) that makes new items start at position 0 instead of position items+1.
Right?

Jep. For starters you could add a simple option like this:

Of course this only makes sense when sorting "manually" (or user-determined as you said).

+1


[Needs Repro] Task - In task, single character description is not shown.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.67-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Go to https://staging.new.expensify.com/home
Tap on a report
Tap plus icon -- assign task
Enter title
Enter single character description and tap next
Note description is not shown
Tap back
Note single character description remains in the description field
Replace it with single number description and tap next
Note description is shown now

Expected Result:
In task, single character description must be shown.
Actual Result:
In task, single character description is not shown but single number description is shown.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/9aa8c572-1f26-48f4-897d-d476c42709fa

View all open jobs on GitHub

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Testing on Pixel 6 w/Chrome on staging I am unable to repro this.

Scheduled for retesting.

Tested this again myself and still non-reproducible. Closing.


#90 e2e tests.

Current Behavior:

ingest the fedramp rev4 and rev5 baselines and validate that all keys are mapped to a value within the oscal types file.
Ingest the fedramp rev4 and rev5, unmarshal to the versioned OscalCompleteSchema struct and then marshal and validate data integrity against OG file.

@brandtkeller Yes Ill look into pulling some from other sources so that we have complete model support


Fix rich version for ansible-lint

Ansible-lint prior to v5.3.1 has issue with reach version >=11.0.0.
In order to cherry-pick fix to stable branches we fix rich version.
This should be reverted with ansible-lint version bump.
Signed-off-by: Dmitriy Rabotyagov<EMAIL_ADDRESS>

jenkins test centos-container-update

@Mergifyio backport stable-5.0


How to get the TAN ?

Your Question

Source File: .
Line(s): .
Question: I want to import my German certificate into the Wallet App but I'm asked to input a TAN. Where can I get it from?

@maluueu Germany has not implemented this functionality. Please use CovPass, it can scan certificate QR codes to import them.

@daniel-eder thank you for quick answer. I was just curious if one could also import the German certificate into this app.
BTW: Why are German DGCs shown as invalid in the Verifier App?

@maluueu There may be a range of possible issues, but I suspect the issue could be missing public keys. There's already a few related issues open - the member states are working together with us to ensure these issues are sorted out, so it should only be a matter of days.
If issues persist, feel free to open an issue so this can be looked into more closely!


Teach members to use GitHub.

If you have any questions or want to do any test on GitHub, you can do what you want on this issue.

Question

Question

Answer


Should detect requireMavenVersion by rules not by id

When maven-enforcer-plugin configured like this,
            <execution>
              <id>enforce-require-maven-version</id>
              <goals>
                <goal>enforce</goal>
              </goals>
              <configuration>
                <rules>
                  <requireMavenVersion>
                    <version>[3.6.3,)</version>
                  </requireMavenVersion>
                </rules>
              </configuration>
            </execution>

The display-plugin-updates complains.
[ERROR] Project requires an incorrect minimum version of Maven.
[ERROR] Update the pom.xml to contain maven-enforcer-plugin to
[ERROR] force the Maven version which is needed to build this project.
[ERROR] See https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
[ERROR] Using the minimum version of Maven: 3.2.5

I managed to find the cause. I need to change the execution id like this.
            <execution>
              <id>enforce-maven</id> <!-- this is required -->
              <goals>
                <goal>enforce</goal>
              </goals>
              <configuration>
                <rules>
                  <requireMavenVersion>
                    <version>[3.6.3,)</version>
                  </requireMavenVersion>
                </rules>
              </configuration>
            </execution>

Should find the requireMavenVersion rule not seeking the execution id

Execution ID should be not matter.
I don't see usage of execution ID in code:
https://github.com/mojohaus/versions/blob/master/versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/MinimalMavenBuildVersionFinder.java
But to be sure we can prapare a UnitTest or change excution ID in existing IT.

@slawekjaranowski Thank you for your comment.
I created a simple repository contains two pom files, namely pom1.xml and pom2.xml.
https://github.com/onacit/mojohaus-versions-issues-1034
diff pom1.xml pom2.xml
379,380c379,380
<               <id>enforce-require-maven-version</id>
<               <!--id>enforce-maven</id-->
---
>               <!--id>enforce-require-maven-version</id-->
>               <id>enforce-maven</id>

I could reproduce the different output.
$ mvn -f pom1.xml versions:display-plugin-updates
...
[ERROR] Project requires an incorrect minimum version of Maven.
[ERROR] Update the pom.xml to contain maven-enforcer-plugin to
[ERROR] force the Maven version which is needed to build this project.
[ERROR] See https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
[ERROR] Using the minimum version of Maven: 3.2.5
...

$ mvn -f pom2.xml versions:display-plugin-updates
...
[INFO] BUILD SUCCESS
...

@onacit thanks for reproduce.
Can you clear your examples poms to have only enforcer configuration without parent and any other stuff.

@slawekjaranowski The parent! Yes, the parent might the problem.
That's why I keep getting the warning message for all my repositories which each refers the same parent.
Can we resolve this issue, with the parent configured, as a specific case?

Hi. I have looked into this, but I can't seem to be able to reproduce the reported issue. Please try to isolate the issue, create a small pom.xml without any parent. If you insist of testing a case with a parent, please create two pom.xml files, one being a parent of another, and test using them. Please don't refer to any files in any remote repository. Thanks.


Hide the default person cards

I'd like to remove the person cards from the home screen, though it doesn't seem that there is a way currently, is that right?

Yes, you are correct. There is no way to hide the person cards.
I think the person cards add a bit of personalization and I personally do track my members just to see where they are at.
Can you give an argument to sway me?

Well, I'm trying out this integration for the home assistant server at my family's home, and they use the home assistant app regularly. This integration would be incredible to reduce the amount of maintenance time I spend on their sever, though the person cards would a dealbreaker.
Everyone in the family is uncomfortable that others family members can track their location through HA, though fortunately here, they aren't great with tech. So I've hidden the person entity cards and map tab, so that locations can still be used for automations. Technically they could still view locations if they knew where to look, but they don't and they haven't tried.

Everyone in the family is uncomfortable that others family members can track their location through HA...

I'm not the code owner, but this makes sense to me.
Hiding (person) cards by configuration wouldn't be much of a hassle, I think. We could do it the same way as we hide/override the areas in the next release.

I would appreciate having the ability to exclude specific individuals from the persons card.
Currently, the device tracker captures all our visitors, and simply hiding them is does not remove them - disabling them is the only way to exclude them from the view.  This however leads to complications with some of my automations, rendering them dysfunctional.

Fixed


Statuses of the sync process dependency

The syncing can have multiple different status messages, from Synced to Syncing... up to the Since July 2022 (13 months). The best possible way how to implement this is to create a TCA dependency that can evaluate the message, also easily testable.
https://www.figma.com/file/vYQD6uZtkPgtmgJ3zfauq0/Zashi-UI?type=design&node-id=149-7962&mode=design&t=hQYH4zwFDImxBT4s-0

Statuses like this are not actionable at the moment for several reasons. The biggest reason is missing support from the rust/FFI (backend). Even with such value coming in (probably a timestemp) we would be still missing a full specification of possible formats. The Figma presents only one possible out of many.
Examples: what if the last sync was:

yesterday, should we present "yesterday" or "17 hours ago"?
last week, should we present "last week" or "9 days ago"?
January 17th, 1:34pm, should we present "since January" or "45 days ago"?
etc.

@nuttycom also mentioned this will probably never be possible because we scan in non-linear order.
@true-jared so far I explained why the proposed design is very likely not possible to do or impossible in coming days. We need a fallback solution, something else. The label is there so we either keep it and then please specify what to present and when. Or get rid of it.
To help you understand, there are many states in the synchronization and we very likely don't want to present all. @nuttycom was talking about just 2, synced and syncing....
To me syncing... proposed in this way is a collapse of some states into this one. Not sure if it will work for all cases.
States of synchronization:

unprepared (the synchronizer is not ready)
synced (synchronization is idle, done, up to date)
syncing... in a way it really operates, downloads blocks, scans, validates, etc.
stopped (a client app called stop() to the SDK, only start() will spin up the sycnrhonization back to work again). Zashi calls it with app going to the background OR when servers (host + port) are switched so there may be a moment when the synchronizer is stopped until it continues (usually 10-30s later)
error (ZcashError is thrown with some short explanation of what is wrong)

Simplified language to be either "Synced" or "Synching" and added an error message that says, "Zashi encountered an error while syncing,
attempting to resolve..." @LukasKorba @true-jared

Thank you @adjyrichard ! @LukasKorba assigned back to you, let us know if there is anything else you need.


Fix "unloak potential section" for Mobile screen

Description
The Unlock potentital section is not proper for teh mobile screen
It should be responsive to make the user experience best on all devices...
Screenshots

i would love to contribute to this project please assign this to me
Checklist

[X] I have checked the existing issues.
[X] I have read the Contributing Guidelines
[X] I have read the Code Of Conduct
[X] The changes don't break the code

@Agarwalvidu This is one of the issue that needed to be fixed and i would love to fix it under GSSOC

Assigning!


Allow setting of user- and system-prompt

Is there any reason why the user shouldn't be able to set both? I think it's quite a normal thing to do

The reason for this is that some models have a dedicated system prompt, while others do not. I added the prompt as a regular message to accommodate models without a system prompt. Initially, I thought that having both a true system prompt and a "first message as system prompt" might confuse the user, so I decided against allowing both. However, I might have been overly cautious. We can remove this restriction and allow both prompts to be set. Perhaps we could add a warning if both are configured?

I thought that having both a true system prompt and a "first message as system prompt" might confuse the user, so I decided against allowing both

I think this is quite normal to have both, where the system prompt describes general behaviour, and the user prompt describes some specific task:
prompt = """
SYSTEM: you are a helpful assistant.

USER: Help me this this specific task...
"""

so hopefully the user won't be confused by this 😄

Yeah, you're right. I overthought this too much. :joy:  Let's remove the check and let the users decide for themselves.


Questions about portal mode

In portal mode, all of my notes for the day are referenced, not just TODO's

Hi! Although I aim to improve the Portal mode's specificity, as of right now it is just a demo showing and testing the convenience of portals. RemNote's default behavior of portals causes some non-todos to be portaled in as well due to the parent rems being shown.
This will go away in the future if the RemNote SDK implements a way for plugins to specify exactly what is shown and hidden in a portal. (I imagine white/blacklist style.)
So in summary, it's planned to not do what you are seeing. Ideally, it is supposed to be just Todos, but there are some current limitations.

Closing this for now, feel free to comment a followup here tho


restart support in java bindings

Tried to support restart operation in java.

Looks good.
Have you been able to get this all to compile and verify reception?

there was a mistake when checking warm restart support and it is fixed now. I compiled and tested it on windows.

Will get this merged before 2.3.0-RC1.  It looks like the code generator has some non-determinism which causes tons of erroneous diffs.

After making the JNI code generator output deterministic, I redid this PR here:
https://github.com/automatak/dnp3/pull/275


Fixing some possible python 3 issues.

Status
READY
Description
Fixing some possible python 3 compatibility issues.

Pull Request Test Coverage Report for Build 389

10 of 11 (90.91%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.3%) to 68.924%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

icetea_lib/tools/tools.py
10
11
90.91%

Files with Coverage Reduction
New Missed Lines
%

icetea_lib/LogManager.py
2
79.07%

Totals

Change from base Build 376:
0.3%

Covered Lines:
4815

Relevant Lines:
6986

💛  - Coveralls


Does it work with AWS Cognito?

I am trying to use it with AWS Cognito it always throws this error:
{
    "title": "OpenSSL error: error:0906D06C:PEM routines:PEM_read_bio:no start line",
    "type": "about:blank",
    "status": 401
}

Is there any way I can use it?

I have no idea how AWS Cognito works. Google search suggest the error has something to do with .pem files.


[SPARK-12724] SQL generation support for persisted data source tables

This PR implements SQL generation support for persisted data source tables.  A new field metastoreTableIdentifier: Option[TableIdentifier] is added to LogicalRelation.  When a LogicalRelation representing a persisted data source relation is created, this field holds the database name and table name of the relation.

Test build #49189 has started for PR 10712 at commit c45bb66.

Test build #49190 has started for PR 10712 at commit 0436a17.

Test build #49190 has finished for PR 10712 at commit 0436a17.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49190/
Test FAILed.

Merged build finished. Test FAILed.

I'm confused by the Scala style failure. It complains about wrong import ordering, but the ordering is actually correct.  On the other hand, it seems that import statements with braces can be problematic.

I think @vanzin knows more about the current status of the import ordering stylechecker rule.

I guess I figured out why. IntelliJ import organizer thinks that { is greater than alphabetic characters while the Scala style checker thinks the opposite. So the following imports
import a.b.C
import a.b.{D, E}

must be reordered into
import a.b.{D, E}
import a.b.c

Let me see whether I can configure the behavior of IntelliJ.

Unfortunately it seems that this behavior cannot be configured in neither ScalaStyle checker nor IntelliJ.  Actually I think this is a bug of ScalaStyle (see ImportChecker.compareName).
I'll adjust the ordering by hand to workaround the build failure for now.

Test build #49189 has finished for PR 10712 at commit c45bb66.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49189/
Test PASSed.

Test build #49238 has started for PR 10712 at commit d53d540.

Test build #49238 has finished for PR 10712 at commit d53d540.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49238/
Test PASSed.

re: import ordering, in my view the enforcer is correct (i.e. that import should be at the top not at the bottom of the o.a.s imports). I don't use IntelliJ so can't comment about its capabilities.

@vanzin Hm, but ASCII value of { is greater than those of all alphabetic characters?

It's not about ASCII. It's about org.apache.spark coming before than org.apache.spark.someOtherSubPackageOfSpark.

Test build #49253 has started for PR 10712 at commit d0d7a2d.

Test build #49253 has finished for PR 10712 at commit d0d7a2d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49253/
Test PASSed.

LGTM

@vanzin Oh I see. Thanks for the explanation!

@cloud-fan Thanks for the review! I'm merging this to master.


Final QA: Module 3

Check Module 3 for final problems we missed.
Then we're ready to publish!

@jesseilev I went over Module 3 and besides some some spelling errors, table alignment and the instructions for Class 2 Studio everything else seems ok.
Possible Issues:

On the Module Home page the dates are still TBD but are up on the Calendar. https://github.com/LaunchCodeEducation/cs50x-live/tree/feature/module3/calendar/cs50/unit1-fundamentals/module3#steps
On the Calendar, Modules 1 and 2 are hyperlinks, but Module 3 is not. - https://github.com/LaunchCodeEducation/cs50x-live/tree/feature/module3/calendar#unit-1-fundamentals
Issue #146 is open (minor)

Some of the Changes:

Updated links to House of Tires on Prep for Class 1 schedule - https://github.com/LaunchCodeEducation/cs50x-live/commit/76c5554b8a3ef7b0fccdb57d3eef46e865bee5e7.
Spelling fix - https://github.com/LaunchCodeEducation/cs50x-live/commit/10ddbc608340800a735893ae6eb34efdbf1c25cd
Updated instructions for Sigma Breakdown Resource in class 2 prep - https://github.com/LaunchCodeEducation/cs50x-live/commit/0595ce8181b98a7374650462a630f60805dbc6a9
Fixed the quotes for algorithmic-efficiency quiz (Somehow the quotes show up funny and when it is copied to the IDE, it gives an error) - https://github.com/LaunchCodeEducation/cs50x-live/commit/e4994c9bc8e9095697891ab99ca4ac97fffb8da8
There were a couple more, but small fixes, you can take a look at them here - https://github.com/LaunchCodeEducation/cs50x-live/commits/feature/module3/calendar/cs50/unit1-fundamentals/module3

awesome


IDs Should Be Derived From ResourceIDs on Arm Api Management template

When running test on arm template that creates Api Managment instance getting this error:
IDs Should Be Derived From ResourceIDs (329 ms) Property: "resourceId" must use one of the following expressions for an resourceId property: extensionResourceId,resourceId,subscriptionResourceId,tenantResourceId,if,parameters,reference,variables,subscription,guid
Template snippet where is happing is bellow:
{   "name": "[concat('ApiApp_', parameters('webServiceName')]",   "type": "backends",   "apiVersion": "2020-06-01-preview",   "dependsOn": [     "[resourceId('Microsoft.ApiManagement/service', variables('apiManagementInstanceName'))]"   ],   "properties": {     "description": "[parameters('webServiceName')]",     "resourceId": "[concat('https://management.azure.com', resourceId('Microsoft.Web/sites', parameters('webServiceName')))]",     "url": "[concat('https://', reference(resourceId('Microsoft.Web/sites', parameters('webServiceName')), '2020-09-01').defaultHostName)]",     "protocol": "http"   } }
This obviously can be correct behavior from arm-ttk perspective. If that is case I'm open to suggestions how to construct correctly that resourceId  property to remove this error when running against arm-ttk .

@konjp - thanks for the issue, this is a good one that I don't have a good solution for (at the moment).  The property is incorrectly named by the RP (that should be resourceUri) but that doesn't help anyone now.
I think the path for this might be to except the property named "resourceId" when it falls under a backend resource but that's a more significant change to the test so we'll have to schedule that work...

@konjp - thanks for the issue, this is a good one that I don't have a good solution for (at the moment).  The property is incorrectly named by the RP (that should be resourceUri) but that doesn't help anyone now.
I think the path for this might be to except the property named "resourceId" when it falls under a backend resource but that's a more significant change to the test so we'll have to schedule that work...

I have encountered the same problem. It also fails the test:
[-] DeploymentTemplate Must Not Contain Hardcoded Uri (11 ms)
Found hardcoded reference to management.azure.com Index:3793
As @konjp mentions it could be working as intended. But I have also not been able to find any other way to set the management url :/

@SuperKoelle - can you open a new/different issue for your case?  Though from the sound of it, I think you need to use the environment() function to get the endpoint (would have to see your template to be sure)

Correct. It was fixed with the environment() function.
I still encounter the exact same issue as @konjp though.

Related to exempting properties based on the full json path - not just the property name.  Note we'll have to except this as the path+property combined, not separately (Though that seems obvious now that I type it). e.g.  something like
resourceType/properties/resourceId
Which isn't the actual json path, so we'd have to combine with type - current test has examples on how to exclude based on type, but not this targeted.


Merging: Progress bar not working

I updated to v1.5 (Win10 64)
After downloading there is the merging stage. During that time the progress bar doesn't seem to work. Its showing 0.0 until the next stage is started (processing).
Everything else is working. No errors and videos are working, too.

WTF,

I am an idiot... 1.5.1 incoming... I actually don't use the Processing Service at all. I forgot to delete ConcatParts and ConvertVideo from TwitchService....


the script not work

The Script not working i made it like this
public IEnumerator WaitAnim(){

    yield return new WaitForAnimationToFinish(characterDynamicObject.animator, NameOfCharacterAnimation);
    Debug.Log($"Animation Finish");
}

then
public void RunAnimation()
{
    for (int i = 0; i < dynamicAnimation.Count; i++)
    {

         dynamicAnimation[i].animator = characterDynamicObject.DynamicObject;
         dynamicAnimation[i].animator.SetBool(dynamicAnimation[i].AnimationName  , dynamicAnimation[i].AnimtionBoolean);

         if (dynamicAnimation[i].publicdynamicAnimation.Count > 0)
         {
            for (int ii = 0; ii < dynamicAnimation[i].publicdynamicAnimation.Count; ii++)
            {
                dynamicAnimation[i].publicdynamicAnimation[ii].PublicDynamicObjectAnimator.SetBool(dynamicAnimation[i].publicdynamicAnimation[ii].AnimationName
                ,dynamicAnimation[i].publicdynamicAnimation[ii].AnimtionBoolean );
            }

         }

         characterDynamicObject.animator.SetBool( NameOfCharacterAnimationArgument ,BoolOfCharacterAnimation );
         StartCoroutine(WaitAnim());
    }

}

Hi. Sorry, I'm not quite sure what your issue is. Do you get the "Animation Finish" log before you expect it? Did you want the inner ii loop to pause until the animation is complete? I need more info to help you.

In general issues about bugs usually take the shape of:

I was doing X
I Wanted Y to happen
But instead Z happened

To me it seems like the bug is in your code here, not in the package. I will close this issue. If you feel like the bug really is on my side, please open another issue with the proper information.


Add documentation about integrating APIs with security

Signed-off-by: Tyler Ohlsen<EMAIL_ADDRESS>opensearch-security pull request intake form
Please provide as much details as possible to get feedback/acceptance on your PR quickly

Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
Documentation

Github Issue # or road-map entry, if available:
N/A

Description of changes:
Adding a section in the README with instructions on how to onboard/integrate new APIs with security.

Why these changes are required?
For consistency and faster development of different plugins wanting to integrate new or existing APIs with security.

What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)
N/A

Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)
N/A

TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)
N/A

Is it backport from main branch? (If yes, please add backport PR # and commits #)
N/A

By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thanks for the PR @ohltyler. Apologies for not the long delay in the review... especially as we've since updated the README :( Could you please update to move section down right before the Contributing header as git auto-resolving the conflicts is placing it at the very beginning? Thanks!

Codecov Report

Merging #1460 (2c7eb61) into main (61869e7) will decrease coverage by 0.35%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1460      +/-   ##
============================================
- Coverage     64.66%   64.30%   -0.36%
+ Complexity     3220     3213       -7
============================================
  Files           247      247
  Lines         17351    17342       -9
  Branches       3082     3068      -14
============================================
- Hits          11220    11152      -68
- Misses         4581     4639      +58
- Partials       1550     1551       +1

Impacted Files
Coverage Δ

...ava/com/amazon/dlic/auth/ldap2/MakeJava9Happy.java
8.69% <0.00%> (-34.79%)
:arrow_down:

...t/keybyoidc/AuthenticatorUnavailableException.java
0.00% <0.00%> (-20.00%)
:arrow_down:

...org/opensearch/security/rest/TenantInfoAction.java
77.94% <0.00%> (-10.30%)
:arrow_down:

...com/amazon/dlic/auth/ldap2/PrivilegedProvider.java
44.26% <0.00%> (-6.56%)
:arrow_down:

...ic/auth/ldap/backend/LDAPAuthorizationBackend.java
53.59% <0.00%> (-4.36%)
:arrow_down:

.../auth/http/jwt/keybyoidc/SelfRefreshingKeySet.java
59.85% <0.00%> (-3.53%)
:arrow_down:

...ic/auth/http/jwt/AbstractHTTPJwtAuthenticator.java
55.81% <0.00%> (-3.49%)
:arrow_down:

...ecurity/configuration/ConfigurationRepository.java
73.07% <0.00%> (-2.20%)
:arrow_down:

.../org/opensearch/security/support/ConfigHelper.java
80.39% <0.00%> (-1.97%)
:arrow_down:

...security/configuration/DlsFlsFilterLeafReader.java
59.76% <0.00%> (-0.71%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61869e7...2c7eb61. Read the comment docs.

Is there any issue tracking this effort to apply these documentation changes consistently on all plugins?

I don't believe this is documented in any plugins. The idea of adding it here, is so all plugins can have a central place to refer to.

I think this is a good starting point, lets add it for now and then we can figure out the best mechanism to get this information out.
@ohltyler Could you create a follow up issue in the plugins repo to track centralized practices / tutorial / documentation that would make sense to link this to?

I like this idea, created a tracking issue in opensearch-plugins and assigned myself - https://github.com/opensearch-project/opensearch-plugins/issues/146

@ohltyler Looks like we need this change to be rebased so it can pass all of our new CI systems, could you do that so we can merge?


Fix Sqlite ToString example in 6.0 what's new

Fixes #3210

@roji Have you run the code and verified that this change is correct?

Apart from the ordering of the projection columns (which I just fixed), yeah, it seems right. Am I missing something?

C# code
await using var ctx = new BlogContext();
await ctx.Database.EnsureDeletedAsync();
await ctx.Database.EnsureCreatedAsync();

_ = ctx.Users.Where(u => EF.Functions.Like(u.PhoneNumber.ToString(), "%555%")).ToList();

public class BlogContext : DbContext
{
    public DbSet<User> Users { get; set; }

    static ILoggerFactory ContextLoggerFactory
        => LoggerFactory.Create(b => b.AddConsole().AddFilter("", LogLevel.Information));

    protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        => optionsBuilder
            .UseSqlite("Filename=/tmp/test.sqlite")
            .EnableSensitiveDataLogging()
            .UseLoggerFactory(ContextLoggerFactory);
}

public class User
{
    public int Id { get; set; }
    public string Username { get; set; }
    public long PhoneNumber { get; set; }
}

SQL
      SELECT "u"."Id", "u"."PhoneNumber", "u"."Username"
      FROM "Users" AS "u"
      WHERE CAST("u"."PhoneNumber" AS TEXT) LIKE '%555%'

@roji Just wanted to check that you actually ran the sample code and verified that this is the SQL that is generated, since I always copy-paste the generated SQL, I never guess. So this must have been a copy-paste error on my side, but that seems weird; where did I get the incorrect SQL?

I'm guessing maybe a previous version had Count() in the LINQ, and it was later removed or something? I mean, looking at the LINQ and SQL in the current page, it's very clear they're out of sync...


Does this nice event tickets tutorial works with v3?

Hi.
Does this code for event tickets still work with Snipcart v3? I'm having trouble getting one item per row, always showing a classic cart with plus-minus buttons.
Cheers.

I can see that many things don't work with v3 and that's a shame, many of us could benefit from these examples.


Update migration-interop-guidance-for-teams-with-skype.md

https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/3225
Added note.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@LanaChin PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

The add-in is removed on purpose. Please open a ticket to discuss with a support engineer if experiencing this issue.


Missed a deprecation tag for one of our methods.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[x] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

No modification for Ruby

 https://github.com/Azure/azure-sdk-for-python/pull/1057

 https://github.com/Azure/azure-sdk-for-node/pull/2113


When I add the declaration property and try to execute unbuild, I get an error

it's error
miracle@MiracledeMacBook-Pro publish % pnpm build

><EMAIL_ADDRESS>build /Users/miracle/workspace/titan/packages/publish
> unbuild

ℹ Building @titanjs/publish                                                                                23:26:29
Error building /Users/miracle/workspace/titan/packages/publish: Error: Transform failed with 1 error:
<stdin>:1:8: ERROR: Expected ";" but found "const"
Error: Transform failed with 1 error:
<stdin>:1:8: ERROR: Expected ";" but found "const"
    at failureErrorWithLog (/Users/miracle/workspace/titan/node_modules/.pnpm/esbuild@0.15.12/node_modules/esbuild/lib/main.js:1566:15)
    at /Users/miracle/workspace/titan/node_modules/.pnpm/esbuild@0.15.12/node_modules/esbuild/lib/main.js:805:29
    at responseCallbacks.<computed> (/Users/miracle/workspace/titan/node_modules/.pnpm/esbuild@0.15.12/node_modules/esbuild/lib/main.js:671:9)
    at handleIncomingPacket (/Users/miracle/workspace/titan/node_modules/.pnpm/esbuild@0.15.12/node_modules/esbuild/lib/main.js:726:9)
    at Socket.readFromStdout (/Users/miracle/workspace/titan/node_modules/.pnpm/esbuild@0.15.12/node_modules/esbuild/lib/main.js:647:7)
    at Socket.emit (node:events:390:28)
    at addChunk (node:internal/streams/readable:315:12)
    at readableAddChunk (node:internal/streams/readable:289:9)
    at Socket.Readable.push (node:internal/streams/readable:228:10)
    at Pipe.onStreamRead (node:internal/stream_base_commons:199:23) {
  errors: [
    {
      detail: undefined,
      id: '',
      location: [Object],
      notes: [],
      pluginName: '',
      text: 'Expected ";" but found "const"'
    }
  ],
  warnings: [],
  code: 'PLUGIN_ERROR',
  plugin: 'esbuild',
  hook: 'renderChunk'
}
 ELIFECYCLE  Command failed with exit code 1.

unbuild doesn't export type declarations by default, so I added declaration: true,  When I add it and try to execute unbuild, I get an error。
it's my config
import { defineBuildConfig } from 'unbuild'
export default defineBuildConfig({
  entries: ['src/index'],
  clean: true,
  failOnWarn: false,
  declaration: true,
  rollup: {
    inlineDependencies: true,
    esbuild: {
      minify: true
    }
  },
  alias: {
  },
  hooks: {
    'rollup:options'(ctx, options) {
      if (!options.plugins) {
        options.plugins = []
      }
    }
  }
})

my node version 16.18.0， unbuild version is 0.9.4

Oh, wait! Maybe this issue is the same as https://github.com/unjs/unbuild/issues/112. If so it is probably an issue using esbuild minify and declaration: true together.

I have added declaration to the min+ sourcemap fixture (https://github.com/unjs/unbuild/commit/7dcda3f8279d20df8ff4fb2c37735d135ef34685) and seems to be working fine on latest main (upcoming release)
Please let me know if you still had issues to reopen and track.


Cannot install on laravel 5.8.35

Using version ^0.6.1 for genealabs/laravel-maps
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.
Problem 1
- Installation request for genealabs/laravel-maps ^0.6.1 -> satisfiable by genealabs/laravel-maps[0.6.1].
- Conclusion: remove laravel/framework v5.8.35
- Conclusion: don't install laravel/framework v5.8.35
- genealabs/laravel-maps 0.6.1 requires illuminate/support ^6.0 -> satisfiab
le by illuminate/support[6.x-dev, v6.0.0, v6.0.1, v6.0.2, v6.0.3, v6.0.4, v6.1.0
, v6.2.0, v6.3.0, v6.4.1, v6.5.0, v6.5.1, v6.5.2, v6.6.0].
- don't install illuminate/support 6.x-dev|don't install laravel/framework v
5.8.35
- don't install illuminate/support v6.0.0|don't install laravel/framework v5
.8.35
- don't install illuminate/support v6.0.1|don't install laravel/framework v5
.8.35
- don't install illuminate/support v6.0.2|don't install laravel/framework v5
.8.35
- don't install illuminate/support v6.0.3|don't install laravel/framework v5
.8.35
- don't install illuminate/support v6.0.4|don't install laravel/framework v5
.8.35
- don't install illuminate/support v6.1.0|don't install laravel/framework v5
.8.35
- don't install illuminate/support v6.2.0|don't install laravel/framework v5
.8.35
- don't install illuminate/support v6.3.0|don't install laravel/framework v5
.8.35
- don't install illuminate/support v6.4.1|don't install laravel/framework v5
.8.35
- don't install illuminate/support v6.5.0|don't install laravel/framework v5
.8.35
- don't install illuminate/support v6.5.1|don't install laravel/framework v5
.8.35
- don't install illuminate/support v6.5.2|don't install laravel/framework v5
.8.35
- don't install illuminate/support v6.6.0|don't install laravel/framework v5
.8.35
- Installation request for laravel/framework (locked at v5.8.35, required as
5.8.*) -> satisfiable by laravel/framework[v5.8.35].
Installation failed, reverting ./composer.json to its original content.

I no longer support Laravel 5.8, sorry.


Focus ring

https://www.sarasoueidan.com/blog/focus-indicators/
Also see comments of ItsLearning UX Team

[ ] Focus ring with more contrast and flexibility in design

https://codepen.io/dianabroeders/pen/ZEmzyPY


How to send an HTTP request "curl: (6) Could not resolve host" on Windows

The Firebase Web Codelab was essential for me to learn how to use Firebase. I wouldn't be able to do something simple like hosting JavaScript libraries in Firebase without it.
I'm spending the time to write this in hopes it helps someone down the line. I hope this is the appropriate place for this post.
Problem
I ran into this issue when trying to get curl to send an HTTP request during step 10. Show Notifications.
After installing curl on Windows (in the end, my attempt with this link's method doesn't work) and testing that curl is installed (input: curl output: curl: try 'curl --help' or 'curl --manual' for more information), curl in cmd.exe won't properly execute the tutorial's curl command. You get lots of garbage out, but I think a good error to use as a reference for this is curl: (6) Could not resolve host.
Here's a reference to the command before replacing the key and token, found at the bottom of https://codelabs.developers.google.com/codelabs/firebase-web/#9:
curl -H "Content-Type: application/json" \
     -H "Authorization: key=YOUR_SERVER_KEY" \
     -d '{
           "notification": {
             "title": "New chat message!",
             "body": "There is a new message in FriendlyChat",
             "icon": "/images/profile_placeholder.png",
             "click_action": "http://localhost:5000"
           },
           "to": "YOUR_DEVICE_TOKEN"
         }' \
     https://fcm.googleapis.com/fcm/send

After replacing the key and token, it doesn't matter if:

the command is run as-is
the Linux bash style continue-command-to-next-lines (\) are replaced with the Windows's style (^)
the Linux bash style continue-command-to-next-lines (\) are removed and all lines are joined
throwing shots (various curl -options) in the dark and hoping for a lucky hack
adding "http://localhost:5000" to the front
moving "https://fcm.googleapis.com/fcm/send" to the front
replacing the double quotes (") inside the data option string with double double quotes ("") then replacing the start and end single quotes (') with double quotes (")

Solution
I got it to work by following http://www.oracle.com/webfolder/technetwork/tutorials/obe/cloud/objectstorage/installing_cURL/installing_cURL_on_Cygwin_on_Windows.html#section1 ([download instructions] Installing cURL on Cygwin on Windows.pdf). As long as you use cygwin.bat, then you can follow the Firebase Web Codelab instructions as-is.
I'm not sure if libcurl in additional to curl was the missing piece or Cygwin or both, but having both works.
This might be a potential problem for Firebase users outside of the friendlychat-web Codelab as well: https://www.youtube.com/watch?v=AAZyQ4Ymkpc&lc=Ugh2f4aY_nz8tHgCoAEC (this linked comment has a reply with a potential solution to try, but at least in my case it wasn't the answer, nor did going down other rabbit holes related to the advice do it for me)
I'm not sure if I overlooked any documentation during my attempt to learn web development that I surely should've run into before becoming aware of Firebase. But depending on if this is a one-off case, it may be a good idea to have documentation or links to known working documentation on any non-Firebase skills similar to sending HTTP requests with curl that are required for learning and using Firebase.
For my purposes, I don't need to keep this issue open. You can close it if you like or keep it open if you feel it appropriate.

I solve this problem by installing PostMan and followind the example of the HTTP request shown in the "Show Notificaction" example

FYI I just stomped upon this website: https://onlinecurl.com/
It's a hosted version of curl and you can simply paste the cURL command. Pretty cool. I'll be adding a link to that from the codelab for windows users (or in general if cURL is hard to install on your machine). With the caveat that it's unsecure to share your server key with a thrid party service but for tests/ development it's OK :)

Remove space after colon in header.
curl -H "Content-Type:application/json"
-H "Authorization:key=YOUR_SERVER_KEY"
-d '{
"notification": {
"title": "New chat message!",
"body": "There is a new message in FriendlyChat",
"icon": "/images/profile_placeholder.png",
"click_action": "http://localhost:5000"
},
"to": "YOUR_DEVICE_TOKEN"
}'
https://fcm.googleapis.com/fcm/send

Thanks @KingOfThePirates, I followed the instructions on http://www.oracle.com/webfolder/technetwork/tutorials/obe/cloud/objectstorage/installing_cURL/installing_cURL_on_Cygwin_on_Windows.html#section1 and my cUrl request worked perfectly.
10/10 from me


Polish localisation - very unfortunate translation!

in the polish (pl.json) localization the term "Unbond" has very wrong translation:
144:    "unbond": "Zwiąż",
this translation means exactly opposite to the orginal meaning. "Zwiąż" means in polish: Bond, not Unbond (that is why I was searching for unbonding feature for 3-4 minutes before I switched to english and noticed this bug
Correct wording for that should be:
144: "unbond": "Odwiąż", (means that You can untie something that is hanging from something or is attached to something) - preferred translation
or
144: "unbond": "Rozwiąż", (nearly the same meaning as above but has even better correlation to another polish wordings close to this subject) (this means that You can untie something what is tied: the rope for example)
You can substitute this word also with "Odwołaj" (Cancel) or "Wycofaj" (Withdraw)
Current wording is totally wrong, because it has opposite meaning to the desired one.

Thanks for pointing this out! Will be sure to address it.

@cryptonetD Does "unbonding": "rozwiązywane" also need to change?


Ignore possible untagged lines after IDLE and DONE commands

Hi,
If you use mailbox.org as the imap server and you get a lot of emails to the inbox the server can send an untagged response after the  DONE or IDLE commands and the function will fail.
Example:
>> DONE
<< * 1 RECENT
<< TAG18 OK Idle completed (0.591 + 0.590 + 0.590 secs).

I propose to ignore the untagged status updates from the server after the DONE and IDLE commands.
@Webklex What do you think of this solution?

Thank you for the patch, it fixes the issue I was getting:
>> TAG4 IDLE
<< + idling

<< * 4 FETCH (FLAGS ())
>> DONE
<< TAG4 OK Idle completed (38.853 + 38.853 + 38.852 secs).
>> TAG5 IDLE
<< + idling
<< * 4 FETCH (FLAGS (\Seen))
>> DONE
<< TAG5 OK Idle completed (17.763 + 17.763 + 17.762 secs).
>> TAG6 IDLE
<< + idling

<< * 5 EXISTS
>> DONE
<< * 1 RECENT
>> DONE
<< TAG6 OK Idle completed (30.118 + 30.014 + 30.117 secs).
>> TAG7 IDLE
<< DONE BAD Error in IMAP command: Invalid command name (0.001 + 0.000 secs).

In ImapProtocol.php line 1063:

  [Webklex\PHPIMAP\Exceptions\RuntimeException]
  idle failed

Exception trace:
  at /application/vendor/webklex/php-imap/src/Connection/Protocols/ImapProtocol.php:1063
 Webklex\PHPIMAP\Connection\Protocols\ImapProtocol->idle() at /application/vendor/webklex/php-imap/src/Folder.php:406

Here's the commit rebased on the latest master with conflicts fixed: https://github.com/adrienbrault/php-imap/commit/b7f669eb8a00ac5b75aad3b24078558b580fb3a7

I guess this PR is now obsolete. I'll see what I can do with the current version

@adrienbrault Did you upgrade to the 5.0 version?

I am no longer using imap/this lib


flarectl: 0.97.0 -> 0.98.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/flarectl/versions.
meta.description for flarectl is: CLI application for interacting with a Cloudflare account
meta.homepage for flarectl is: https://github.com/cloudflare/cloudflare-go
meta.changelog for flarectl is: https://github.com/cloudflare/cloudflare-go/blob/v0.98.0/CHANGELOG.md
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.98.0 in filename of file in /nix/store/wl5qfljb8hkxwr39qwk6hz69rg8dy1wp-flarectl-0.98.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

flarectl

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/wl5qfljb8hkxwr39qwk6hz69rg8dy1wp-flarectl-0.98.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A flarectl https://github.com/r-ryantm/nixpkgs/archive/2673432cb8f524e05082cc8428da7b2e8dd702e9.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/2673432cb8f524e05082cc8428da7b2e8dd702e9#flarectl

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/wl5qfljb8hkxwr39qwk6hz69rg8dy1wp-flarectl-0.98.0
ls -la /nix/store/wl5qfljb8hkxwr39qwk6hz69rg8dy1wp-flarectl-0.98.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

flarectl

Maintainer pings
cc @jmbaur for testing.

@NixOS/nixpkgs-merge-bot merge


RFC: the road to "Active Job" - a queue/worker abstraction layer

Hi all,
This is a "request for comments" issue. Please feel free to add comments, pointers, ideas under this thread.
I'd like to use this issue to define a goal:

Create an abstraction layer for concrete queue implementations for background jobs to provide cheaper, easier, or "reuse existing infra" alternatives to Redis.

Although current solution based on sidekiq-rs is fantastic and really, everyone should have some kind of access to a Redis instance, there is some value in abstracting over this infrastructure.
We'd like to create a provider-based implementation for this area, just like our Storage and Cache subsystems. Prior work in Rails is ActiveJob, which manifested AMQP based workers (which I was the author of), and other kinds of queue providers.
People may want to use solutions other than Redis primarily because they already "have something" running in their organization. Then, other people may have different security, or other operational requirements which require a different system to plug jobs into.

Leading options:

Mainly deal with building a trait-providers sub system, then have Redis as the primary concrete provider. Async and Foreground remain "exception to the rule" and bypass the provider system, as it is today.
The Processor can be a tough point to abstract. Either way, each provider must implement a processor.

Notes:

The main alternative to Redis should be Postgres. Selecting this provider should create a "one in a box" system where you only need a server and postgres to build apps. This can be implemented with postgres push or polling a table.
Secondly, Sqlite (which can be done with the same postgres implementation, jobs table, etc) - will create a "no dependencies" single binary deployment for every app. This can be implemented with polling a table.
The rest of providers: SQS, AMQP, etc. should come as first-come first-serve.

I really like the idea of supporting more job queue implementations, namely the Postgres backed one (SQLite as well). I think that the Oban Elixir job queue is a good one to reference. I don't have much experience with SQS or others so I can't speak to those.

Yes, already Redis is awsome, somethings we don't need that much power.  We just need to schedule a few non-timing-critical tasks, and want to have things "Just Work."

#797 now implements this RFC.
It's been quite challenging to implement polymorphism at the worker level since both the worker and the args are polymorphic and Rust has the 'trait as object' limitations (traits cannot be with generics), and so I've resorted to enum as a way to implement the "provider" pattern.
This means that every additional provider will hit the main enum match clauses.
Currently Redis via existing sidekiq is supported, with modified and better abstration, and a from-scratch postgres based queue (using sqlx).

@jondot - If we support SQLite as a backend for the database, we should also support it as a backend for the new job system. I don't think SQLite has UPDATE SKIP LOCKED, but I believe it only supports one reader at a time so that might not be needed?

Yes this logic makes sense. And you’re correct SQLite has a different mechanism (but really close in terms of query)
Only reason I did I not do it is thinking SQLite is not naturally central or supports distributed jobs so what would be the point.
but I can check and see if I can go for it in the sake of feature parity as you mention.

I think it would be a nice support feature to allow those who want to run a bundled app on a single server, given Rust's runtime characteristics it would be nice to support that.
Another nice to have in a job queue system is the ability to schedule jobs for a future time. I had a PR open in the last job system to do that and don't mind implementing that again 😄

It should be super easy with all the new infra
I’m finishing up some API design and will ping you

Main reason for us not to want queues in redis, is that we generally run redis in-memory only (primary for cache) which means that when it reboots etc, the current queue will get lost.
It would also be amazing if the queue drivers all support the concept of chaining ("run job y after this job completes") and batch chaining (enqueue 10 jobs and once all of them have been processed, run job y).

0.10.0 now released with the new workers subsystem.
we would happily accepts improvements to the new pg worker and an addition of an sqlite queue provider.


Update to support latest kit version

Update dependencies to latest version. The resulting package should be compatible with the latest SvelteKit version.

Fixes https://github.com/Rich-Harris/svelte-knobby/issues/28 from my tests. I was facing a few issues with pnpm's handling of the yooutils and other dependencies, needed to shamefully hoist those to work correctly.

Thanks for this!  Would love to be able to use this with svelte-kit.  When I try to install your fork, I get this error when importing svelte-knobby:
> Build failed with 1 error:
node_modules/.pnpm/vite@2.8.6_sass@1.49.9/node_modules/vite/dist/node/chunks/dep-9c153816.js:29537:10:
ERROR: [plugin: vite:dep-scan] Failed to resolve entry for package "svelte-knobby". The package may have incorrect main/module/exports specified in its package.json: Failed to resolve entry for package "svelte-knobby". The package may have incorrect main/module/exports specified in its package.json.

Should I fork your fork and build it first if I want to use it?

Hey @FractalHQ! Yes, I'm basically including my fork as a git submodule and building it locally before my svelte-kit builds. You can check out either https://github.com/jpaquim/svelte-webgl-fluid-simulation or https://github.com/jpaquim/svelte-webgpu for examples of usage.
I'd assume that when integrated upstream (this repo) this manual build process won't be necessary anymore, but there still may be some details I'm overlooking...


Disable Hex Input Autocomplete in ColorWrap

Hello!
I'm using SketchPicker
When I type the hex color, it autocompletes... for example:
If I type ccd it autocompletes to ccccdd, even before I had the chance to type the rest of hex code I wanted, let's say ccd912
How can I disable this behaviour ?

I am also experiencing issues with this behaviour.
I'm using the TwitterPicker and closing it as soon as the user picks a color. The autocomplete behaviour causes the issue @rafaelcorreiapoli described when using the manual input.
I haven't found a good way to work around the issue, since I haven't seen any way to differentiate between when a user picked a color using the swatches and input the color using the text field.

+1 on this.
I'm expecting users to type a hex color more often than using the few swatches on the <BlockPicker> and this module closing after 3 digits doesn't work for me. Especially when editing the the hex later closes after every change

Ah, yes this is part of a bigger problem. All of the input box changes get pumped right into Tinycolor on every change: https://github.com/casesandberg/react-color/blob/master/src/helpers/color.js#L22
The inputs need to not be controlled by the actual state when they are in focus and replaced with the real value when blurred.

Will this problem be fixed? I have the same one.

@casesandberg why don't you provide a way to disable 3 digit hex values using this? https://github.com/casesandberg/react-color/blob/master/src/helpers/color.js#L47

I have created a version with the fix here: https://github.com/shreshthmohan/react-color
I have made a PR too. #625 (currently a work in progress)
But those of you who wish to disallow 3 digit hex values can use my repo.
npm install shreshthmohan/react-color (or equivalent yarn command)

I am interested in solving this as well. I wonder what are people thought about just disabling it?

I am interested in solving this as well. I wonder what are people thought about just disabling it?

I am also currently working on this. Is there a solution yet?


Embed README in index.rst

Related to: https://github.com/NCAR/CUPiD/issues/38#issuecomment-1946567725
Summary of changes:

fixes some small warnings/typos in README.md
embeds README.md in docs/index.rst by copying CUPiD/README.md into the docs directory in docs/conf.py and removes the logo in the top header because having an image in the heading puts it in the sidebar toc tree, which looks really weird.
Adds copied docs/README.md to the .gitignore because it should only be created/edited automatically during documentation generation and not actually committed to the repo
Removes separate installation page for now, since the information is on the home page

See local results:

Just to clarify, is the docs/README automatically generated and added to the documentation any time the normal README gets updated? If it's actually a copy that needs to be manually updated, maybe we could adjust that; if it's automatically maintained then I think this should be good to merge in...


I dont know what is happening, when i load the bot up, this happens.

Addon "Assistance" loaded
Addon "Blah" loaded
Addon "Err" loaded
Addon "Events" loaded
Addon "Extras" loaded
Loading fc.sqlite
Addon "FriendCode" loaded
addons.kickban failed to load.
ModuleNotFoundError: No module named 'pyaes'
Addon "Load" loaded
Addon "Lockdown" loaded
Addon "Logs" loaded
addons.loop failed to load.
ModuleNotFoundError: No module named 'feedparser'
Addon "Memes" loaded
Addon "Helper_list" loaded
Addon "ModStaff" loaded
Addon "ModWarn" loaded
Addon "Modwatch" loaded
Addon "Mod" loaded
Addon "NXErr" loaded
Addon "Rules" loaded
addons.xkcdparse failed to load.
ModuleNotFoundError: No module named 'xkcd'
Bot directory:  C:\Users\Alistair Deane-Wake\Desktop\Kurisu-master
NukeMusic has started! NukeFX OLD has 8 members!
Task exception was never retrieved
future: <Task finished coro=<Client._run_event() done, defined at C:\Users\Alistair Deane-Wake\AppData\Local\Programs\Python\Python36\lib\site-packages\discord\client.py:304> exception=IndexError('tuple index out of range',)>
Traceback (most recent call last):
File "C:\Users\Alistair Deane-Wake\AppData\Local\Programs\Python\Python36\lib\site-packages\discord\client.py", line 307, in _run_event
yield from getattr(self, event)(*args, **kwargs)
File "run.py", line 259, in on_ready
await bot.send_message(bot.helpers_channel, msg)
File "C:\Users\Alistair Deane-Wake\AppData\Local\Programs\Python\Python36\lib\site-packages\discord\client.py", line 1144, in send_message
channel_id, guild_id = yield from self._resolve_destination(destination)
File "C:\Users\Alistair Deane-Wake\AppData\Local\Programs\Python\Python36\lib\site-packages\discord\client.py", line 289, in _resolve_destination
raise InvalidArgument(fmt.format(destination))
discord.errors.InvalidArgument: Destination must be Channel, PrivateChannel, User, or Object. Received NoneType
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\Alistair Deane-Wake\AppData\Local\Programs\Python\Python36\lib\site-packages\discord\client.py", line 312, in _run_event
yield from self.on_error(event, *args, **kwargs)
File "run.py", line 140, in on_error
if isinstance(args[0], commands.errors.CommandNotFound):
IndexError: tuple index out of range

If you read what's in the README you would know that this is not a bot for general usage but rather a higly customized for a specific server.

"Although it is open source, this bot is not really designed to be used in other setups at the moment; the source is mainly just available for those interested in how it works on the Nintendo Homebrew server."

install the modules listed, and make sure you have replacements for all of the roles in run.py. or edit the source to replace the channels.


Fix particle issues with chemistry equation editor

I don't think we need the extra menu items? The outputting of e as an available symbol for electron seems to already be fixed on master, and we don't actually want to have two sets of everything in the default menu.
What were they added for?

Are they actually getting generated? Those are simply to catch cases where e or electron are specified as available symbols. I don't filter duplicates because if a content editor enters a symbol twice with the two names, they deserve to have the duplicated symbol :)


Fix package name for Ubuntu

This library currently using a manually installed version of GLFW because the current version 3.2.1 has bugs on Mac and Linux that were causing issues that are fixed in 3.3 which wasn't available yet through apt. When you install it manually it doesn't have the "-dev" suffix that is added by the apt tool.
There are also short comings in the Swift Package manager that are being worked on around trying to integrate better with system libraries with various paths and names on different operating systems. Supposedly you can use an option that talks to pkgconfig (I think that is what it is called) that is a program that can be installed that helps abstract the names and paths out of the Package.swift file but I don't think it is something that is as easy as it sounds as it is not something that is installed by default especially on macOS.
In the mean time I would like to keep this as is and require a manual install of GLFW. I will be looking at this again when Swift 5 comes out and hopefully there are better options by then or at least GLFW will be fully on version 3.3 and things will be easier.

I just realized the docs are not updated to reflect what I just said, sorry about that. I am helping out with keeping things current with newer Swift versions but have had limited time to make things as polished as they could be.


Set date on confirmation only

Is it possible to set the date (populate the textfield input) only on confirmation? I mean, by clicking a "ok" button in the date picker footer, for example?

+1


macOS notarization

Hi @jarmitage,
Take a look at step 3 on this page: https://learn.flucoma.org/installation/sc
Let me know if you're still having problems!
Cheers,
Ted

Ok, I see.
It would be handy if the installation instructions could be linked from this repo's README.

Good call, we'll make something that better points towards this in our docs. Thanks for raising an issue.

Fixed in https://github.com/flucoma/flucoma-sc/pull/54


Task/vue updates

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 48.684%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
444

Relevant Lines:
912

💛  - Coveralls


Q1 2019 / 2019 plans

Hi, hello, could you please update readme with what's planned for Q1 2019, and perhaps say something about what's planned for 2019 in general?
I especially look forward for news on https://github.com/angular/material2/pull/7835 and whether this https://github.com/angular/material2/issues/4444 is something you plan on looking into, now that Ivy is finishing.
Thank you!

@jelbourn any news? 😉

I'll try to update the readme shortly, but TL;DR most of the team is on loan helping with Ivy


Refactor/remove misc files

Description
Cleans up some excess crud. Also moves all upgrading notes to one location
Type of change

Refactoring (improvements to code design or tooling that don't change behaviour)

Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

[ ] Tests have been added for any changes to behaviour of the code
[ ] New and existing tests are passing locally and on CI
[ ] bundle exec rubocop reports no offenses
[ ] RDoc comments have been updated
[x] CHANGELOG.md has been updated

🧹 Wonderful cleanup!


NEXT-20875 - Fix product API does not output names of variants

1. Why is this change necessary?
The /api/product endpoint does not return names of variants if they are the same as the parents name.
2. What does this change do, exactly?
Full output of the variant data including the data inherited from the parent
3. Describe each step to reproduce the issue or behaviour.
Setup a product with a variant, do not adjust the name of the variant. Query the products at /api/product use Header sw-inheritance 1
4. Please link to the relevant issues (if any).
https://issues.shopware.com/issues/NEXT-20875
5. Checklist

[x] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

That is intended so. When its null it will be inherited from parent product.
You can use sw-inheritance: 1 as header to get your expected result

That is intended so. When its null it will be inherited from parent product. You can use sw-inheritance: 1 as header to get your expected result

header sw-inheritance: 1  might not working here, please try to reproduce according to the ticket description to see.

its under translated see


Fix for using ->fromTable() & ->withColumns()

Merges the tableColumn property from the generated table column into the manually specified column.

Thanks @ConnorHowell. Glad it wasn't too much trouble.

I don't know why but this update creates an issue. Undefine array key

I also have the same issue. Now if one tries to append new columns to the export using ->withColumns() and is using ->fromTable() of course, their names don't appear as keys in the table's columns list.

Thanks for bumping this. Missed this on the weekend. I'll write a fix.

This should be fixed by #113


ARROW-4804: [Rust] Parse Date32 and Date64 in CSV reader

This PR partly handles the issue https://issues.apache.org/jira/browse/ARROW-4804.
Things to discuss:

Date32 currently assumes to have DateUnit::Day and Date64 assumes DateUnit::Millisecond respectively.
Dates have to be in ISO format YYY-MM-DD or YYY-MM-DDTHH:MM:SS. I'm not sure if this is a reasonable assumption. It should also be noted that the C++ implementation does not strictly follow the ISO format because it uses YYY-MM-DD HH:MM:SS instead (without the T). The difference is also a point that has to be discussed before merging.
I'm using std::mem::transmute_copy to convert i32 and i64 to T::Native. I struggled with Rust's type system here and I'd appreciate suggestions on how to do this in a less-unsafe way.

Things that are not part of this PR:

Handling of other temporal types like timestamp and time.
No list of columns for temporal types (reference: "To keep inference performant. user should provide a Vec of which columns to try convert to a temporal array")

Just saw https://github.com/apache/arrow/pull/8609 and num_cast() might actually be the thing I was looking for to convert i64 to T::Native?

Truly it is. Otherwise platform native primitives mightn't fit into the return types.

Thanks for the feedback @vertexclique and @jorgecarleitao!
I'll update the PR when #8609 is merged.

Date32 currently assumes to have DateUnit::Day and Date64 assumes DateUnit::Millisecond respectively.

I think this is fine as long as reasonable errors (unsupported XXX) are produced if alternate types are used

@alamb I can't respond to your comment.
I see you're using T::Native::from_i32(since(days, from_ymd(1970, 1, 1)).num_days() as i32). Shouldn't there be a way for us to get the desired value from chrono without introducing a fallible cast/conversion?

@nevi-me  -- good call -- I was simply copy/pasting what was in this PR in terms of as i32 without looking carefully enough. I updated https://github.com/alamb/arrow/tree/alamb/less-unsafe with a new commit that doesn't use as i32 and instead uses try_into()
https://github.com/apache/arrow/commit/86741de18ad148589873cf43c7e0d4ea7f9c5233

Hi @Jibbow , I think we need not wait for #8609 before you can update this PR

@Jibbow, are you blocked or need help here? Let us know if that is the case so that we can help.

Benchmarks on master are failing as the csv parser doesn't support date32 / date64 related to this addition: https://github.com/apache/arrow/pull/8892
@Jibbow any plans on finishing the PR? Would be really nice to add!

Benchmarks on master are failing as the csv parser doesn't support date32 / date64 related to this addition: #8892
@Jibbow any plans on finishing the PR? Would be really nice to add!

Sorry that I broke this. I had been running my benchmarks with Parquet so did not notice. I am working with Andy to uplift the tests to catch this kind of issue.

FYI we have incorporated this code in via https://github.com/apache/arrow/pull/8913 - thanks for the help @Jibbow . I am going to close this PR for now as it has a conflict and we are trying to clean up the PR queue -- please let me know if that was a mistake.

Sorry for being so quiet the last weeks. I had a research paper deadline coming up. Thanks @Dandandan for taking over!


Hard normals

@lasalvavida Just opening a pull request here so we can keep track of what needs to be done to get this in.
CC @pjcozzi

This is ready for review. Adds support for stripping off existing normals with -r and generating face normals with -f. I've run 2CylinderEngine through and below are some screenshots to highlight the difference between the existing smooth normals and the added hard normals.
Smooth Normals:

Hard Normals:

Note: the material generation in generateNormals may be changed or removed entirely when I finish adding model material common generation, but for now I think that it is acceptable.

Thanks @lasalvavida.
@tfili once you confirm that this meets your needs, @lilleyse can review and merge.

@lasalvavida this looks pretty good. The one issue we saw was you can't run this twice in a row because it either generates an invalid technique or we are missing an if check when processing a technique.

@lasalvavida After a little digging the culprit seems to be the remove normals step. It removes the technique from the material so it can be regenerated, but there are stages before that happens that expect the technique to exist.

Okay, I should have some time tomorrow to take a look at this.

This should be fixed now

@tfili let me know when this is all good from your end and I'll do a review.

@tfili let me know when this is all good from your end and I'll do a review.

@tfili is this ready for review?

@pjcozzi @lilleyse This looks good to me.

@lilleyse please merge when you are happy with the code.

@lilleyse I fixed you last 2 suggestions. Let me know if there is anything else.

Thanks @tfili that should be it.