fix headers destination installed by ament_auto_package

See https://github.com/ament/ament_cmake/pull/540. This is a copy of it.

Can you review this?
(I don't have the rights to assign reviewers)
@youtalk @xmfcx @VRichardJP

Running docker-build-and-push-main on my fork(no rights to running in awf repo)
https://github.com/HansRobo/autoware/actions/runs/9791930338

https://github.com/HansRobo/autoware/actions/runs/9792120819/job/27037305038#step:8:1500

Error: buildx bake failed with: ERROR: failed to solve: failed to configure registry cache exporter: invalid reference format: repository name (HansRobo/autoware-buildcache) must be lowercase

It looks like the test failed by completely unrelated error. So I'll test it in my forked repository.

I have found that the current changes are insufficient, and am looking into ways to fix them.
The change in this PR also means that improper descriptions that did not previously cause errors will now cause errors, so some packages will need to be revised.
For example, previously ament_cmake_auto could be used even if it was missing in the build_tool_depend tag in package.xml, but once this PR is merged, it will no longer work properly without it.

I am not sure I understand how this change solves the underlay/overlay problem, but I will assume it does.
The lanelet2_extension package compilation error is due to the include directory of autoware_utils package not being correctly exported:
  # export and install include directory of this package if it has one
  if(EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/include")
    ament_export_include_directories("include")
    install(DIRECTORY include/ DESTINATION include/${PROJECT_NAME})
  endif()

The files are installed (= copied) to include/${PROJECT_NAME}, but "exported" to install include directory. So what downstream packages include is $install_prefix/include (e.g. -isystem /home/sig/autoware/install/autoware_utils/include) instead of $install_prefix/include/$package_name (e.g. -isystem /home/sig/autoware/install/autoware_utils/include/autoware_utils). The fix is simple:
  # export and install include directory of this package if it has one
  if(EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/include")
    ament_export_include_directories("include/${PROJECT_NAME}")  # <- This!
    install(DIRECTORY include/ DESTINATION include/${PROJECT_NAME})
  endif()

@HansRobo Can you let me know if the following is somehow related to this?
https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/directory-structure/#exporting-headers
Here we are suggesting the developers to export their headers with the following structure in their include folder.
autoware_gnss_poser
└─ include
    └─ autoware
        └─ gnss_poser
            └─ exported_header.hpp

This is a manual suggestion and we are planning to enforce this structure for all packages within autoware directory.
Would this partially solve this issue? Or is it not related at all?


Clarify public properties are serialized/deserialized

Issue #, if available:
Description of changes:
The Dotnet QLDB driver integration test was inserting a C# object using the object mapper serializer but it showed up as an empty struct in the database. After investigation, it was found that the object we were inserting had a property with default access modifier (internal) and it was not serialized into Ion binary.
e.g.
  class ParameterObject
  {
      string Name //<- this was not being serialized.
      {
          get
          {
              return Constants.SingleDocumentValue;
          }
      }

This PR is to update the spec to mention that only public properties are serialized/deserialized.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closing this PR.
We clarified during standup that we should expect properties with public/internal/protected internal access modifiers to be serialized/deserialized.


quiz answer

how to shuffle options,it takes default option for answer .how to change please inform

Right now we have kept it as constant, if you want to shuffle the correct option you may have to write your custom logic.


Temporarily disable coverage collection

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

Let's go 🚀
/approve


Reorganise UI for component pages

Is your feature request related to a problem? Please describe.
At first glance, the page is a little hard to understand and takes some time working out what you need to do.  The order of tasks on the page doesn't match the order that you need to complete the tasks.  I also never noticed the warning at the top of the create component page regarding titles. It would be helpful to place this onto the component editing page underneath where the titles are shown. There is information on the page that is reserved for special use cases that could be hidden so as to not confuse the user (for example component name. I needed it explained to me that this was dev specific and I don't need to know about it as a designer). Some of the helper text copy isn't easy to understand at first. Ultimately all of these small things add up to more time spent trying to understand the page and less time completing the task.
Describe the solution you'd like
Organising tasks/input fields in order of use, including moving component name section into a details component since it isn't often used.
Moving the helper text about titles to the component editing page and making it visually distinct to help users understand an important constraint of adding titles.
Small adjustments to the UI, including title sizes to increase readability of the page at first glance.
Some changes to helper text copy.
See images for before and after, plus annotated image of the suggested changes.
Additional context
Before:

After:

Annotated:

Having a go at implementing some of this now ❤
Thanks for the really clear and aesthetic suggestions, should be fun to work on! 💯

Having a go at implementing some of this now ❤
Thanks for the really clear and aesthetic suggestions, should be fun to work on! 💯

That's great! Thank you! The radio page is just an example, but I think it more or less applies to each component page. I haven't been through each page yet though to see what is needed individually!


Update .npmignore

Trimming the npm release a little further, following general guidelines from npm needs a personal trainer.

As a quick point, the failing Travis tests have nothing to do with this PR.

Yes I know. That's fixed in 2.0.0. Don't sweat it :wink:

Cherry-picked. Thanks!


[Documentation] Maven Central Badge

Description
This adds maven central badge to the readme.
Review checklist

[x] PR is split into meaningful commits for the ease of reviewing
[x] Description contains clear instructions on how to test the feature (where applicable)
[x] Tests have been written
[x] Appropriate labels have been applied

Codecov Report

Merging #42 (1d80f07) into main (6e304dc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #42   +/-   ##
=========================================
  Coverage     100.0%   100.0%
  Complexity       39       39
=========================================
  Files             9        9
  Lines            61       61
  Branches          9        9
=========================================
  Hits             61       61


State Model V3

RocksDB can (probably) provide an exact set of live keys per version, so... let's redo the state model, again.
A lot of things we'd want to do on the DEX, for example, are difficult to accomplish without data indexing.
Some of the staking and governance implementation could be simplified with this as well.

[ ] Fill in design writeup (@hdevalence)
[ ] Refactor (someone else? @zbuc @aubrika)

Replaced by https://github.com/penumbra-zone/penumbra/issues/1454


Add network option for Ephemery Testnet

[x] Confirm anything outstanding for release with other maintainers on #besu-release in Discord
[x] Update changelog if necessary, and merge a PR for it to main

[x] Notify maintainers about updating changelog for in-flight PRs

[x]  Optional: for hotfixes, create a release branch and cherry-pick, e.g. release-<version>-hotfix
[x]  Optional: create a PR into main from the hotfix branch to see the CI checks pass
[x]  On the appropriate branch/commit, create a calver tag for the release candidate, format example: 24.4.0-RC2
[x] Sign-off with team; confirm tag is correct in #besu-release in Discord
[x] Consensys staff start burn-in using the proposed release  tag
[x] Sign off burn-in; convey burn-in results in #besu-release in Discord
[x] Using the same git sha, create a calver tag for the FULL RELEASE, example format 24.4.0
[x] Using the FULL RELEASE tag, create a release in github to trigger the workflows. Once published:

this is now public and notifies subscribed users
makes the release "latest" in github
publishes artefacts and version-specific docker tags
publishes the docker latest tag variants

[x] Check binary SHAs are correct on the release page
[x] Check "Container Verify" GitHub workflow has run successfully
[x] Create homebrew release - run https://github.com/hyperledger/homebrew-besu/actions/workflows/update-version.yml
[x] Create besu-docs release - https://github.com/hyperledger/besu-docs/releases/new

Copy release notes from besu
If publishing the release in github doesn't automatically trigger this workflow, then manually run https://github.com/hyperledger/besu-docs/actions/workflows/update-version.yml

[x] Social announcements

There is currently no support for Ephemery using the --network=ephemery flag.
In addition to adding the genesis flag the Ephemery implementation also requires a genesis reset function.

Please re-open using a plain issue template, this is for releases.

Alright thanks will do that

I just recreated the issue now on a plain template.
https://github.com/hyperledger/besu/issues/7404
Please assign it to me. Thank you


how to reproduce your experimental results completely

Thank you for your nice codes.

Can you please open source your code regarding the part of DDQN?
I cannot reproduce your experimental results by training DDQN (from other repo) following the setup in the paper in INFOCOM20.

Can you please open source your code regarding the part of DDQN?
I cannot reproduce your experimental results by training DDQN (from other repo) following the setup in the paper in INFOCOM20.

do you have the completely code?

Can you please open source your code regarding the part of DDQN? I cannot reproduce your experimental results by training DDQN (from other repo) following the setup in the paper in INFOCOM20.

do you have the completely code?


Create add to wish list method in facade

Add a new facade method to add and one to remove entry in the wish list.

PR: https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/5454


How to specify memory resources in lima/nerdctl

I'm trying to a run an Oracle  Database in a Docker image in a lima environment on macOS and get a lot of errors related to the shm volume.
lima nerdctl run --detach --name="oracledb" --network="oraclenet" --memory="4g" --publish="1521:1521" --volume="/dev/shm" --tmpfs="/dev/shm:rw,exec,size=1g" qualiant/database

I did not find documentation that explains how memory resources are allocated in lima and wanted to ask a few specific questions:

Docker Desktop for macOS have an overall limit for memory consumption on the container. Where can I find this in lima?
nerdctl support the --memory option but how does this relate to lima? Is it guaranteed that the container gets 4g when using the --memory="4g" flag independently from lima?

Thank you!

When you started the virtual machine, there was a YAML file to edit. It included fields like "cpu" and memory"
? Creating an instance "default"  [Use arrows to move, type to filter]
> Proceed with the default configuration
  Open an editor to override the configuration
  Exit

After it has been started, it is saved as ~/.lima/default/lima.yaml
# CPUs: if you see performance issues, try limiting cpus to 1.
# Default: 4
cpus: 4

# Memory size
# Default: "4GiB"
memory: "4GiB"

# Disk size
# Default: "100GiB"
disk: "100GiB"

You need to restart it for changes to take effect. View changes with list.
Resizing the disk image is be a bit trickier, and requires manual commands.

Thank you for your feedback.
Could you please elaborate (or point me to the appropriate documentation) on how the memory option in the configuration file interacts with the container memory options when using nerdctl? What exactly does the memory configuration option of lima describe? Why do I not seem to get an error when starting a container with a memory command line option larger than the one in the lima configuration file?

I think it is just a limit, you might run into hardware limitations (even virtual ones) before hitting such a software limit

What exactly does the memory configuration option of lima describe?

It is the total amount of memory available to the virtual machine created.
You can see how much is "left" after the kernel and other system processes:
$ lima free -h
               total        used        free      shared  buff/cache   available
Mem:           3.8Gi       208Mi       3.2Gi       1.0Mi       485Mi       3.4Gi
Swap:             0B          0B          0B

So we allocated 4.0 to the VM, where 3.8 was "usable" and 3.4 is "available".
So if you want to start a process (container) with 4.0, total needs to be 4.6+


could I use docker run -p 10024:80 to bind a port to host in .drone.yml?Thanks!

@bradrydzewski
could I use docker run -p 10024:80 to bind a port to host in .drone.yml without wrapdocker  ?
I found an article here:
http://paislee.io/how-to-build-and-deploy-docker-images-with-drone/
Thanks!

http://discourse.drone.io is our mailing list for these sort of questions


Python Version Isn't Set?

Hey! I'm a new fish shell user, so I apolgize if this is a noob question.
I've installed pyenv via fisherman, and everything works with one exception: using pyenv global 3.6.3 has no effect on my default python version in the shell.
For instance, if I run pyenv global I see the correct version (3.6.3) being returned, but when I run python --version on the CLI, I see Python 2.7.14 (my system version).
I've installed this tool as instructed. Here's my ~/.config/fish/conf.d/000-env.fish file:
set -x PYENV_ROOT $HOME/.pyenv
set -x PATH $PYENV_ROOT/bin $PATH

Any suggestions of what I might be missing?

Have you tried running a pyenv rehash?

Also note you'll need to spawn a new shell for the changes to PATH to get picked up.

I think you should set -U fish_user_paths $PYENV_ROOT/shims $fish_user_paths
include $PYENV_ROOT/shims to your $PATH

So, quick update. I got this working after nuking my shell process. Sorry about that.

Awesome.
And no, you shouldn't have to manually add the shims to your PATH, the plugin takes care of that: https://github.com/fisherman/pyenv/blob/master/conf.d/pyenv.fish#L15-L18

@daenney you're right.
I just open terminal as non login.

@daenney  i think this behaviour is observed because fish says its a non-login shell even though it clearly is.

~ chsh
Password:
Changing the login shell for dev
Enter the new value, or press ENTER for the default
	Login Shell [/usr/bin/fish]:
~ status
This is not a login shell


Notes. Includes cutting-plane methods. Issue #104.

Coverage remained the same at 25.034% when pulling 0529b82bdfed95edcf798fe4b1adcd937ce5e8ba on davidjwu:master into e139cb8fc8887f98724eb8670de930230280976f on chengsoonong:master.


Roll Flutter Engine from 099ed6c62d04 to c472346deab4 (2 revisions)

https://github.com/flutter/engine/compare/099ed6c62d04...c472346deab4
2023-04-18<EMAIL_ADDRESS>Roll Skia from 476ee3fd54cc to 84630c3c18b2 (5 revisions) (flutter/engine#41316)
2023-04-18<EMAIL_ADDRESS>Double zip FlutterMacOS.framework.zip. (flutter/engine#41306)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Global username issue

I tried using the GUI script to unlock daily packs and the set tokens script but the tools all told me they failed to get my username. In the devtools console it tells me that the tools' process of accessing certain sources from Blooklet is against the security restrictions on the items.
This may also be since I'm using a school computer on a highly restrictive network. Everything else runs well though.

Use @Minesraft2's stuff, it works.
This doesn't.

ok thanks

it says the same thing for me

where do you put it

where do you put it

where do you put it

you copy and paste in the inspect in the console area you can get to the inspect by double clicking and it should be on the bottom when you double click

ty  villians rule

Can I get the addie
Get Outlook for iOShttps://aka.ms/o0ukef

From: Liam Owen @.>
Sent: Wednesday, April 26, 2023 11:25:59 AM
To: therealgliz/blooket-hacks @.>
Cc: Subscribed @.***>
Subject: Re: [therealgliz/blooket-hacks] Global username issue (Issue #515)
Closed #515https://github.com/therealgliz/blooket-hacks/issues/515 as completed.
—
Reply to this email directly, view it on GitHubhttps://github.com/therealgliz/blooket-hacks/issues/515#event-9104969765, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7I5SPKOWXE6SMMNRQU6BT3XDE5APANCNFSM6AAAAAAUUHKMOY.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Contrast improvements

Big number of small contrast improvements:

Dark theme got more prominent UI colors
Light theme got darker foreground color
Errors in explorer have highlight color matching the themes
Search in explorer is fixed
Ident guides in light theme got a bit fainter
Ident guides in the explorer match those in the editor
Active tab in bordered version lost bottom border
Hover/Selection in status bar matches the themes
Sidebar group titles got borders
Icons throughout the editor have consistent colors
Some other tweaks I can't recall...

@teabyii can you please check this and publish if you like it?

For me, with the dark one, sometimes it's a little hard to see icons in the left sidebar:

However, everything is better now. Nice job.


CI isn't running on pull requests

CI action should run on all pull requests to ensure that build + test is passing before merging.
.github/workflows/ci.yaml

Hey @tehmantra! The workflow must run on every pull request instead of push. Please can I work on this?


feat(Condensed): explicit sheaf condition for light condensed sets

[x] depends on: #13501

Thanks!
bors d+

bors merge


Update golang.org/x/net

CVE https://github.com/advisories/GHSA-4v7x-pqxf-cx7m
Description of changes
Update golang.org/x/net to v0.26.0

/cherry-pick release-2.9
/cherry-pick release-2.10
/cherry-pick main

/cherry-pick release-2.10

/cherry-pick main


Added menu page gallery animation.

Added menu page gallery animation

Looks good, I feel like 7s is a bit long for the animation to change, I find 3-4s better.

Good job so far @Aurazor


Mail is not deleted from source server after being deleted from Mail

The mail aggregator does not actually delete mail from the source server when it is deleted from the aggregator. This occurs with both the Docker mail server component (when fully integrated into Community Server) and when aggregating mail from an external mail server with IMAP.
If a mailbox on the local Docker mail server receives mail, and you delete that mail, the messages are not cleared from the mailbox folder in /var/vmail/vmail1/domain/s/o/m/some.mailbox/Maildir/new.
When using the Docker mail server, this is worse, as this is not actually aggregation but a "real" hosted mail service (but one that is being accessed by an aggregator when Community Server should really have an IMAP client), and there is no other access into those mailboxes, so delete should actually delete, but it doesn't.
It's possible that the IMAP purge is not being issued, but on another mail system, the messages deleted from Community Server Mail did not even show as deleted (struck through) and waiting purge.
OO <IP_ADDRESS>3

Hello @Daniel-Beardsmore we released this in 10.0 version of Community Server. Also plans to implement work directly with the Mail Server, without an aggregator.

10 doesn't appear to be released yet; what did you change?

10 doesn't appear to be released yet; what did you change?
(I notice that https://helpcenter.onlyoffice.com/server/community/changelog.aspx is also out of date.)

I meant that it is not showing the latest v9 release (let alone 10).

9.6.4 is our latest release, with minor bugfix. We will update this in changelog. Changes of 10.0 will published after release of this.


add replace struct tag

Allows items to be replaced when the value is a non-zero entry. Useful for using it with a semi-populated struct before hand.

Hi @JakeMakesStuff
Thank you for the PR. IIUC, you want to force-overwrite struct fields even if they are already populated? Can you tell me more about the use case?

Hi @JakeMakesStuff
Thank you for the PR. IIUC, you want to force-overwrite struct fields even if they are already populated? Can you tell me more about the use case?

Hi @sethvargo, a use case is using env vars to replace variables in a (semi-)populated configuration loaded from a file

I see - so you want values from the env to take precedences over values from the file, but you already have a half-populated struct from the file contents? Are you also providing options via a CLI? The reason I ask is that https://github.com/spf13/viper might be a better choice for your use case.

Got it. I'm okay with adding this as long as we document it appropriately. I also think "overwrite" might be a better name. WDYT?

Yeah that sgtm, I will make the adjustments to the PR now!

Thanks!


Question: Do I need to do anything to keep the CSV files from growing too large?

Loving Metrics.NET as it's helping us see inside of some of our most complicated multi-threaded applications. Is there a means to limit the size of the CSV files so that they act like rolling logs?

Closing this for now, feel free to re-open if more information can be added.


Don't use styles in angular for now

I find it very restrictive at the moment because it basically limits the ability to add global styles. So maybe for now we should go back to the way we did styles in the angular-start project where we would compile all our less into one css file and handle modules in less.

Angular2 is using shadow DOM (albeit an emulated version atm) to encapsulate components as this is part of the web component standard in general, to make components more portable and re-usable.
Good article on this here:
http://blog.thoughtram.io/angular/2015/06/29/shadow-dom-strategies-in-angular2.html
I think it makes sense to use this for specific component styles in place of the modules/ we had before, as the encapsulation would help us there. Can't we combine this technique with global styles too, so we have our core styles like type, grid etc. compiled as before?

Nice article, I understand the advantages and my initial thought to add global styles was to use both but thought it would be confusing using both component styles and global styles but I don't mind trying both.

so i agree we should be using styles in components to replace our previous "{device-type}/modules" folder in less.


could this be installed on a shared Hosting environment such as Godaddy or Bluehost

could this be installed on a shared Hosting environment such as Godaddy or Bluehost?

could this be installed on a shared Hosting environment such as Godaddy or Bluehost?

Hello!!
First of all, I would like to request  you to go through the readme section as I have already mentioned there that it is a prototype and since it is made open source,you can always take the initiative to improve the accessibility of the project.
Thank you.
P.S:-
For requesting development works from the original creator , please respond with "Requesting Development Services" or create another thread with the same .

could this be installed on a shared Hosting environment such as Godaddy or Bluehost?

Hello!!
First of all, I would like to request  you to go through the readme section as I have already mentioned there that it is a prototype and since it is made open source,you can always take the initiative to improve the accessibility of the project.
Thank you.
P.S:-
For requesting development works from the original creator , please respond with "Requesting Development Services" or create another thread with the same .


Improve list conversation performance

We're seeing the app freeze frequently for users. On export it appears there is some performance issues with importing and listing conversations
Some stats

1:51:21 PM | DEBUG : [XmtpRN] Imported 846 exported conversations into client in 66.073s
1:51:36 PM | DEBUG : [XmtpRN] Listing 0 conversations for 0x2659aBe3F33c3BA20B9F440f24b746A22b1d53F7 took 14.756 seconds
1:51:37 PM | DEBUG : [XmtpRN] Listing 846 conversations for 0xf0EA7663233F99D0c12370671abBb6Cca980a490 took 81.935 seconds

This parallelizes some stuff during import and converts known topics to a set to help with performance.
The SDK lists 2k conversations in ~ 10s so 14 seconds to load 0 conversations looks like potentially an issue in this code somewhere.

curious - what device did you capture those logs on? I just tried on my Android Pixel and got (on main branch just for comparison sake)
[XmtpRN] Listing 1995 conversations for 0x209fAEc92D9B072f3E03d6115002d6652ef563cd took 28.53 seconds
...
[XmtpRN] Listing 0 conversations for 0x94f3099AE62E5dA07113016144aef87929683bEf took 0.414 seconds

@cameronvoell these logs are from @saulmc device when he saw the device frozen. Logs in slack.


unchecking 'execute robocop on save' setting does not prevent robocop from being executed on save

Hey @rodeezy , could you please provide your workspace settings?

I am also seeing this issue, after todays VSCode update
https://github.com/microsoft/vscode/issues/221489

I think I have found a possible reason: https://github.com/Shopify/ruby-lsp/commit/176254330d27c515b0921d2d26772360f71a9aaf
Disabling the Ruby LSP extension may help.

im pretty sure i had ruby-lsp installed! sounds like could be it! @chinghanho 💡


[WIP] Checked annotation for structs

This introduces the ability to write checked(:tests) on T::Struct definitions to avoid potentially expensive recursive type checking on struct fields at runtime:
class Foo < T::Struct
   checked(:tests)
   prop :foo, String
end

f = Foo.new(foo: 12) # only throws in tests
f.foo = 43 # only throws in tests

Motivation
We profiled some of our code and found that adding checked(:tests) to sigs still resulted in lot's of runtime type checks. The code in question makes heavy use of structs, hence this PR.
Test plan
I included some automated tests, let me know if I need to add more elsewhere.

@jez has opinions on this and it's my EOD at the moment, so bouncing to him.

Closing this for now as it didn't have the desired impact.


ionic serve taking extremely long to start

Short description of the problem:
Not 100% sure if this is the correct repo to discuss the issue, and if not - apologies.
I have an ionic 1 project, using ionic cli 3.4.0, and as far as I can see I don't use ionic-app-scripts directly, but I guess that it's an integrated part of the cli? When I run ionic serve, it seems like nothing is happening for about 4-5 minutes. When I run it with verbose, I can see what is happening.
mac-mini:mobile jacques$ ionic serve -b --verbose
[DEBUG] Loading global plugin @ionic/cli-plugin-proxy
[DEBUG] Throwing PLUGIN_NOT_INSTALLED for global @ionic/cli-plugin-proxy
[DEBUG] Detected ./gulpfile.js in project directory
[DEBUG] Loading local plugin @ionic/cli-plugin-cordova
[DEBUG] Loading local plugin @ionic/cli-plugin-gulp
[DEBUG] Loading local plugin @ionic/cli-plugin-ionic1
[DEBUG] Loading local plugin @ionic/cli-plugin-proxy
[DEBUG] Getting plugin info for ionic
[DEBUG] Getting plugin info for @ionic/cli-plugin-cordova
[DEBUG] Getting plugin info for @ionic/cli-plugin-gulp
[DEBUG] Getting plugin info for @ionic/cli-plugin-ionic1
[DEBUG] Getting plugin info for @ionic/cli-plugin-proxy
[DEBUG] Checking for latest plugin version of ionic@latest.
[DEBUG] Checking for latest plugin version of @ionic/cli-plugin-cordova@latest.
[DEBUG] Checking for latest plugin version of @ionic/cli-plugin-gulp@latest.
[DEBUG] Checking for latest plugin version of @ionic/cli-plugin-ionic1@latest.
[DEBUG] Checking for latest plugin version of @ionic/cli-plugin-proxy@latest.
[DEBUG] Latest version of ionic@latest is 3.4.0.
[DEBUG] Latest version of @ionic/cli-plugin-proxy@latest is 1.3.1.
[DEBUG] Latest version of @ionic/cli-plugin-ionic1@latest is 2.0.0.
[DEBUG] Latest version of @ionic/cli-plugin-gulp@latest is 1.0.1.
[DEBUG] Latest version of @ionic/cli-plugin-cordova@latest is 1.4.0.

What behavior are you expecting?
I expect that ionic serve should pretty much just run immediately and not wait to check for the latest versions, because in some cases this takes incredibly long. Happy to see an info message if one of the scripts is out of date, but it should definitely not hang the entire process for me to run up a server.
Which @ionic/app-scripts version are you using?
Running ionic info displays:
global packages:
@ionic/cli-plugin-proxy : 1.3.1
@ionic/cli-utils        : 1.4.0
Cordova CLI             : 7.0.1
Gulp CLI                : CLI version 3.9.1 Local version 3.9.1
Ionic CLI               : 3.4.0

local packages:
@ionic/cli-plugin-cordova : 1.4.0
@ionic/cli-plugin-gulp    : 1.0.1
@ionic/cli-plugin-ionic1  : 2.0.0
Cordova Platforms         : android 6.2.3 ios 4.4.0
Ionic Framework           : unknown

System:
Node       : v6.11.0
OS         : macOS Sierra
Xcode      : Xcode 8.3.3 Build version 8E3004b
ios-deploy : 1.9.1
ios-sim    : not installed
npm        : 3.10.10

Any help is appreciated.

Not 100% sure if this is the correct repo to discuss the issue, and if not - apologies.

The output you see is generated by the CLI directly I think, so you might want to open an issue over there: https://github.com/ionic-team/ionic-cli/issues
Maybe there already is a flag or config to skip the update checks, I am not sure - best ask in the issue over at the CLI as well then.
Do you get the output you posted over time or all at once after waiting for x minutes? Is your connection really slow, so is there a reason why it takes so long, or is this also mysterious?

Thanks @janpio.
The output gets posted over time, and no my connection is not slow. It happens once every week or so (but I have only been using the updated CLI for three weeks now). I realise that it may happen in a time when my connection is slow for some reason, but I would prefer to control those updates. Will close this and create a new issue in the correct repo.

There is probably a check in the CLI that it doesn't check for updated versions every time it runs - and these could be the ones that are slow for you. Ask for it in the other issue as well.


(Low Priority) OnehotEncoder doesn't seem to consistently encode columns

Description
When using the boston housing data, column like zn and indus are recognized as Categorical and OneHotEncoder is chosen to encode the data. indus column is expanded to indus_1, indus_2 and more but zn is not. The only difference is that indus is handled by a pipeline with uncommonvalue_resolve but zn is not. Need to figure out if this is normal.

No longer a concern.


Fix inconsistent sorting of search results

Fixes https://github.com/etsy/hound/issues/281

The commit was merged with #290


Fix v2.0.5 unit tests compile error by adding create_yield_function

Change Description
Compiling the unit tests when running EOSIO v2.0.5 results in the error described in issue #487
I've seen them being wrapped in abi_serializer::create_yield_function calls in the eosio/eos repo, so I did the same here.
There's no compile error now but I run into a boost linking error on Mac, see the issue. Not sure if this is related. Would be great if someone could test

@MrToph, thanks for submitting the fixes. I did not encounter any linking errors. The jury is still out though on which one is the right thing to do: fixing the unit tests or restoring backward compatibility. If they decide to not fix it on the EOSIO side, I'll merge the PR.

The decision was to restore backward compatibility in abi_serializer. However, these fixes still need to be merged, only to a release branch. Would you be able to create a clone of this PR against the release/1.9.x branch in this repo? (I tried to change the base branch for this PR but that didn't work out)
And while you're at it, could you please apply a similar fix to line 141 in tests/eosio.msig_tests.cpp? That piece of code is commented out, but it would be nice to keep it compilable in case it's ever uncommented.

HI @revl , is it even worth continuing this PR if the decision to make it backwards-compatible was made?

Yes, even though the compatibility was restored, the methods with old signatures were reintroduced as [[deprecated]]. This PR contains changes that reflect the new way of setting the time limit - using a yield function. So the changes from this PR need to be merged, but they must go into the release/1.9.x branch, not master. Would you be able to create a new PR against release/1.9.x with the same fixes?

I see, okay I'll create a PR branching off release/1.9.x

Thank you!

We don't merge directly to master, so I created https://github.com/EOSIO/eosio.contracts/pull/501 to merge an identical change that had been committed earlier into release/1.9.x.


Make qt-webengine an optional dependency

Comment:
I understand that some people might want to use qt-webengine with pyside2. Would it be acceptable to make qt-webengine an optional dependency? it would save ~100MB for most users that don't need it.
Thank you for your thoughts.

I agree it should be optional

@conda-forge-admin please rerender

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I rerendered the recipe in conda-forge/pyside2-feedstock#147.


missing return

get_class() expects parameter 1 to be object, string given
Each pull request should address a single issue and have a meaningful title.
Description
Explain what you have changed, and why.
Checklist:

[ ] Securely signed commits
[ ] Component(s) with PHPdocs
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[ ] Conforms to style guide

---------Remove from here down in your description----------
Notes

Pull requests must be in English
If the PR solves an issue, reference it with a suitable verb and the issue number
(e.g. fixes 12345)
Unsolicited pull requests will be considered, but there is no guarantee of acceptance
Pull requests should be from a feature branch in the contributor's fork of the repository
to the develop branch of the project repository

Good catch on the documentation error, but your PR description is totally irrelevant! Please be more mindful of that in future!


Fixed memory leak in evpmd

This memory leak is detected by gcc-sanitizers (enabled by configuring LD_FLAGS to -sanitize=address)

Any plans to merge this?


Add a Codacy badge to README.md

Coverage remained the same at 100.0% when pulling f6e02b317515d3046d6cff71113c29ea6ac588ba on codacy-badger:codacy-badge into 7ff05bf3435e31f2b531d89d184b151ef7c54d64 on ONSdigital:develop.


Remove adventure-specific "Spin Tale" action

Closes https://github.com/foundryvtt/pf2e/issues/5705

Probably needs a migration.

Probably needs a migration.

Closing this PR in favor of https://github.com/foundryvtt/pf2e/pull/5708


Zeitwerk Name Error (Rails 7.1)

Fairly new to Ruby/Rails, but have gotten most of this migrated.  I'm however getting this error when deploying to Heroku:
Zeitwerk::NameError: expected file /tmp/build_209785a3/vendor/bundle/ruby/3.3.0/bundler/gems/spree_reviews-0bbcaa96f2ac/app/overrides/add_reviews_after_product_properties.rb to define constant AddReviewsAfterProductProperties, but didn't (Zeitwerk::NameError)
Any suggestions?

also have this error


Test SnarkyJS against real networks on CI

This PR provides required updates to run initial tests against the real network.
Unfortunately there are still some code duplications due to current GitHub Actions limitations, specifically:

Inability to dynamically set the services Docker image name within single Job (based on some conditions);
Inability to setup and run "services" in composite mode.

I also planning to replace wait-for-docker-services.sh script with the JS code as part of the work on https://github.com/o1-labs/quality-and-testing/issues/121

Closes #1035

I guess I'm late but here's my review

Thank you and no worries. Your points will be addressed in future PR.


Inductor dev

Updated the file names based on discussion

@leochand101 after pre-commit, you have to commit the changes again. That command modifies your files. Did you check that early?

Checks have passed!

Thanks @leochand101 !
@ryanrocket Can you please review?

@leochand101 thanks for the PR. I have added some comments.
We can discuss them this Friday or another time if it is too long to address.

Addressed the fixes with commit 77638c5e78481ec31637685ef8acf6e05ebe63dc
Pushing fixes to the fork of mabrains repo as well, added pins to 3 inductors.

@leochand101 do you think you can work on the dco and updates to this PR?


Can we make the class open instead of public which prevent to be subclassed ?

Thanks for your feedback @glussian-luna ! We made it open in version 1.0.6.


Missing setter for FormRequestMode in compiled/released JAR

Description
I upgraded the dependency logbook-spring-boot-starter to the latest version (2.1.2). When I wanted to set the formRequestMode via logbook.filter.form-request-mode, I was greeted with the following message on startup:
***************************
APPLICATION FAILED TO START
***************************

Description:

Failed to bind properties under 'logbook.filter' to org.zalando.logbook.autoconfigure.LogbookProperties$Filter:

    Property: logbook.filter.form-request-mode
    Value: parameter
    Origin: class path resource [application.yml]:76:29
    Reason: No setter found for property: form-request-mode

I was a little confused since the code contains a @Setter lombok annotation. But checking the decompiled class code shows the following:
public final class LogbookProperties {

[...]

    public static class Filter {
        private final FormRequestMode formRequestMode = FormRequestMode.fromProperties();

        public Filter() {
        }

        @Generated
        public FormRequestMode getFormRequestMode() {
            return this.formRequestMode;
        }
    }
}

Turns out, the setter is actually missing.
Expected Behavior

Lombok setter annotation is processed correctly
configuration works as intended

Actual Behavior

configuring the form-request-mode results in the application not starting up.

Possible Fix
Remove final from the respective variable.
Steps to Reproduce

Use dependency of logbook-spring-boot-starter in version 2.1.2
Configure logbook.filter.form-request-mode
Try to start spring boot application.
Application does not start.

Your Environment

Version used: 2.1.2

Appended a PR for the fix. Feel free to merge.

Appended a PR for the fix. Feel free to merge.

PR is in the wrong repo. Happy to merge if you open it here 😉

Should be correct now, used to old bitbucket UI and github confused me with its defaults :D


chore: orgenaize tx_args macro to follow order

Make the order of the parameters in the macro match the struct: InvokeTxArgs etc.

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.71%. Comparing base (5488256) to head (ac84a7f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1794   +/-   ##
=======================================
  Coverage   75.71%   75.71%
=======================================
  Files          61       61
  Lines        8675     8675
  Branches     8675     8675
=======================================
  Hits         6568     6568
  Misses       1675     1675
  Partials      432      432

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

+reviewer:@MohammadNassar1


Adding an option to disable esc.

Adding an option called disableEsc for being able to prevent closing modal on ESC keypress.

Seconding this PR!
Would be extremely useful for me in a few places (i.e mandatory age confirmation popups for certain e-com sites)

Seconding this PR!
Would be extremely useful for me in a few places (i.e mandatory age confirmation popups for certain e-com sites)

I also need this feature for my usage.
Please consider integrating it.
Thanks a lot

Really need this feature me too!

Yes, adding another bump for this!


podMetadata for prometheus & alertmanager still broken for first install

What happened?
First prometheus-operator deployment with v0.37.0
podMetadata present in Helm Release, not in custom resources alertmanager & prometheuses.
Other (older) deployments were upgraded without issue.
Did you expect to see something different?
I expected to see pod annotations propagated to PODs and present in custom resources
How to reproduce it (as minimally and precisely as possible):
Deploy prometheus-operator for the first time
Environment

Prometheus Operator version:
quay.io/coreos/prometheus-operator:v0.37.0

Kubernetes version information:
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.0", GitCommit:"641856db18352033a0d96dbc99153fa3b27298e5", GitTreeState:"clean", BuildDate:"2019-03-25T15:53:57Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15+", GitVersion:"v1.15.9-gke.9", GitCommit:"a9973cbb2722793e2ea08d20880633ca61d3e669", GitTreeState:"clean", BuildDate:"2020-02-07T22:35:02Z", GoVersion:"go1.12.12b4", Compiler:"gc", Platform:"linux/amd64"}

Anything else we need to know?:
I deleted Alertmanager resource, which deleted alertmanager PODs which was expected.
Then, operator re-created Alertmanager custom resource.
Annotations are back in the custom resource and in PODs.
I suspect a race condition at custom resource instanciation, or an issue with older CRDs (didn't check wether I already had CRDs, but I don't think so)

cc @pgier

Deleting Prometheuses custom resource and recreating it also fixed the issue for prometheus

Might happen because of Helm Chart providing "old" CRDs.
PR to fix it: https://github.com/helm/charts/pull/21499

That would make sense :) looks like we can close this here?

Not sure I fully understand why 0.36.0 CRDs could lead to that kind of issue.
But, yes, if you think it's clearly linked, I agree we can close this


Multiple types returns

I have a typescript error with that code (from v2) after upgrading to v3. Is there correct migration procedure?
const time = entry[i][0];
      const open = calculator.evaluate(paramsOpen);
      const high = calculator.evaluate(paramsHigh);
      const low = calculator.evaluate(paramsLow);
      const close = calculator.evaluate(paramsClose);

      kData.push([
        time,
        String(open),
        String(open >= close ? Math.max(high, open) : Math.max(high, close)),
        String(open >= close ? Math.min(low, close) : Math.min(low, open)),
        String(close),
        String(volume),
      ]);

 Argument of type 'number | number[]' is not assignable to parameter of type 'number'.

UPD.
At this moment I made a cast workaround
const close = formula.evaluate(params.close) as number;
const open = formula.evaluate(params.open) as number;
const high = formula.evaluate(params.high) as number;
const low = formula.evaluate(params.low) as number;
const volume = formula.evaluate(params.volume) as number;

Hi,
Thanks for pointing that out, and sorry for the inconvenience. Before the v3 version, this lib was plain JavaScript without TypeScript types. As of 3.0, I migrated to TypeScript, which now (correctly) defines the return value of evaluate() as number|number[].
The reason for this is that you can call evaluate() with an array of input values, instead of a single value: by doing so, evaluate also returns an array of results, one for each input.
So the return type is correct, but was not defined before. Hope you can live with that, your workaround is a reasonable way to go in this case.


feat(bottom-bar): count number of form-errors

Fixes TECH-1405
Pretty simple implementation, with a entryForm zustand-store. Another approach would be to share the form-ref in a context, like @HendrikThePendric proposed earlier. Or we could just put it in the same zustand-store. Not sure what you think is best.
Sharing form-ref could be beneficial if we eg. want to focus the first errored-field when the user clicks on the "Invalid"-icon or something?

My expectation is that we will not see anything change in the UI, for the following reasons:

You are right, I just tested this and nothing happens. form.focus is there to tell RFF that the field received focus, not to actually focus it. For that you would need the ref, as you suggest.
Setting the highlighted field would be easy. But I think one benefit of focusing the field is that it would scroll that field into view. Maybe we could do both? And do eg document.getElementByName(fieldName)[0]?.scrollIntoView()?


Import data without rapids_code, add registration information

closes #100
Description

Add registration_organization_name and state to the occupation_standards table; collect data upon import
Removed ability to update a DataImport record except to modify the description. It was not clear to the admin what updating the file or associated user would do, so we should just implement an "undo" feature if needed. Otherwise the admin can just upload an updated file as a new upload.
Moved much of the import logic into the admin data_import controller rather than on an after_save hook in order to allow for partial file uploads
Created a service to process chunks of rows for the partial file upload feature
Removed description requirement for work process (is this okay? I removed it because it was missing from many rows in the example file, but I can add it back in if needed)

QA

[x] Log in as admin<EMAIL_ADDRESS>[x] Go to Data Imports -> Create new
[x] Upload the file attached in #100
[x] Should be successful except for two errors: (1) organization name missing, (2) work process with two different hour amounts for the same occupation standard
[x] Look through the Occupation Standard table, make sure the records look correct
[x] Verify that new occupations got added, since the rapids/onet codes did not exist in the db
[x] Go to Data Imports -> Create new
[x] Upload this test file which contains one and only one bad data row
[x] Verify that no Data Import record is created, and the error is returned to the admin
[x] Go to Data Imports -> Create new
[x] Fill in form without selecting user and/or kind. Verify you get an error.

@littleforest i got 3 errors

There's a few other things that seemed off but i need to dig through the spreadsheet to see if that's the source of the issue or the import. This is good to merge for now so we can unblock @jhash with more data.


asynchronous suspension error, lost connection to device error

When i build on windows gave me this error.
Lost connection to device.
Exited (sigterm)
I tried;
flutter clean
flutter build
flutter pub get
flutter build windows
 #0      throwToolExit (package:flutter_tools/src/base/common.dart:10:3)
           #1      RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:722:9)
           <asynchronous suspension>
           #2      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1257:27)
           <asynchronous suspension>
           #3      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #4      CommandRunner.runCommand (package:args/command_runner.dart:209:13)
           <asynchronous suspension>
           #5      FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:283:9)
           <asynchronous suspension>
           #6      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #7      FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:229:5)
           <asynchronous suspension>
           #8      run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:64:9)
           <asynchronous suspension>
           #9      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #10     main (package:flutter_tools/executable.dart:91:3)
           <asynchronous suspension>

flutter build -v ;
[  +12 ms] FinalizeBuildStatus:
[        ]   Deleting file "x64\Debug\INSTALL\INSTALL.tlog\unsuccessfulbuild".
[        ]   Touching "x64\Debug\INSTALL\INSTALL.tlog\INSTALL.lastbuildstate".
[        ] Done Building Project "D:\ATAKAN\Projects\myself\build\windows\INSTALL.vcxproj" (default targets).
[   +5 ms] Build succeeded.
[        ]     0 Warning(s)
[        ]     0 Error(s)
[        ] Time Elapsed 00:00:19.15
[  +24 ms] Building Windows application... (completed in 21,8s)
[ +330 ms] Observatory URL on device: http://<IP_ADDRESS>:60989/ILtHU2wu7eE=/
[   +3 ms] Caching compiled dill
[  +38 ms] Connecting to service protocol: http://<IP_ADDRESS>:60989/ILtHU2wu7eE=/
[ +108 ms] Launching a Dart Developer Service (DDS) instance at http://<IP_ADDRESS>:0, connecting to VM service at http://<IP_ADDRESS>:60989/ILtHU2wu7eE=/.
[  +77 ms] DDS is listening at http://<IP_ADDRESS>:60992/Lvx5EKtYYgw=/.
[  +57 ms] Successfully connected to service protocol: http://<IP_ADDRESS>:60989/ILtHU2wu7eE=/
[  +13 ms] flutter: saat 2023-04-15 20:30:57.984461
[   +1 ms] flutter: geçen zaman : false
[  +12 ms] DevFS: Creating new filesystem on the device (null)
[  +23 ms] DevFS: Created new filesystem on the device (file:///C:/Users/Dinibh/AppData/Local/Temp/myselfc7b23d8c/myself/)
[   +2 ms] Updating assets
[ +152 ms] Manifest contained wildcard assets. Inserting missing file into build graph to force rerun. for more information see #56466.
[   +4 ms] Syncing files to device Windows...
[   +2 ms] Compiling dart to kernel with 0 updated files
[        ] Processing bundle.
[   +2 ms] <- recompile package:myself/main.dart 9246e8cc-623d-45c8-bd10-464f949efd61
[        ] <- 9246e8cc-623d-45c8-bd10-464f949efd61
[   +2 ms] Bundle processing done.
[ +157 ms] Updating files.
[        ] DevFS: Sync finished
[   +4 ms] Syncing files to device Windows... (completed in 167ms)
[   +4 ms] Synced 0.0MB.
[   +9 ms] <- accept
[   +3 ms] Connected to _flutterView/0x22e860c2430.
[   +4 ms] Flutter run key commands.
[   +5 ms] r Hot reload.
[   +1 ms] R Hot restart.
[        ] h List all available interactive commands.
[        ] d Detach (terminate "flutter run" but leave application running).
[        ] c Clear the screen
[        ] q Quit (terminate the application on the device).
[        ]  Running with sound null safety
[   +1 ms] An Observatory debugger and profiler on Windows is available at: http://<IP_ADDRESS>:60992/Lvx5EKtYYgw=/
[  +86 ms] flutter: deviceId->4C4C4544-0048-3310-8044-C7C04F474A33
[   +1 ms] flutter: expiryDate :2023-04-16 08:14:58.000
[  +37 ms] The Flutter DevTools debugger and profiler on Windows is available at: http://<IP_ADDRESS>:9101?uri=http://<IP_ADDRESS>:60992/Lvx5EKtYYgw=/
[+6305 ms] Service protocol connection closed.
[        ] Lost connection to device.
[   +1 ms] DevFS: Deleting filesystem on the device (file:///C:/Users/Dinibh/AppData/Local/Temp/myselfc7b23d8c/myself/)
[ +261 ms] Ignored error while cleaning up DevFS: TimeoutException after 0:00:00.250000: Future not completed
[   +3 ms] "flutter run" took 31.864ms.
[ +194 ms] ensureAnalyticsSent: 191ms
[   +1 ms] Running 1 shutdown hook
[  +13 ms] Shutdown hooks complete
[   +1 ms] exiting with code 0

@darshankawar / Windows 11
[√] Flutter (Channel stable, 3.7.11, on Microsoft Windows [Version 10.0.22621.1555], locale tr-TR)
• Flutter version 3.7.11 on channel stable at C:\src\flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision f72efea43c (6 days ago), 2023-04-11 11:57:21 -0700
• Engine revision 1a65d409c7
• Dart version 2.19.6
• DevTools version 2.20.1
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
• Android SDK at C:\Users\Dinibh\AppData\Local\Android\sdk
• Platform android-33-ext5, build-tools 33.0.2
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-9505619)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.5.4)
• Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
• Visual Studio Community 2022 version 17.5.33530.505
• Windows 10 SDK version 10.0.22000.0
[√] Android Studio (version 2022.1)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-9505619)
[√] Connected device (3 available)
• Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22621.1555]
• Chrome (web)      • chrome  • web-javascript • Google Chrome 112.0.5615.86
• Edge (web)        • edge    • web-javascript • Microsoft Edge 112.0.1722.46
[√] HTTP Host Availability
• All required HTTP hosts are available
• No issues found!

Do you get this error consistently everytime you run flutter build windows ?
If you create new Flutter app and run the same command, do you still get same error ?
Do you have any anti-virus enabled ?

Do you get this error consistently everytime you run flutter build windows ? If you create new Flutter app and run the same command, do you still get same error ? Do you have any anti-virus enabled ?

Hi Darshan. I'm having a similar problem. Everything is fine when I executed 'flutter doctor'.
I was able to build the windows app, but whenever I hot reload/hot restart, I get
"Lost connection to device.
Exited(sigterm)"
in the Debug console.
It only happens when I use vscode. I had no problems while running the app using Android Studio.
The flutter version I'm using is 3.7.0. OS: Windows 11 Home. SDK: Windows 11. I have McAfee enabled.
I whitelisted code.exe in my antivirus software, but the issue still persists.


Deep merge ( aka jQuery.extend() )

Yesterday I was coding some stuff in Python and I was searching for something that is doing a deep merge of two native dictionaries, and I found this https://www.xormedia.com/recursively-merge-dictionaries-in-python/
Is working awesomely and is doing exactly what jQuery.extend() is doing also. Are you going to merge this awesome stuff in your library as well? The only that I missed while I was reading the README was exactly this.
I'm pretty much sure that this will make it more and more awesome :) Thanks in advice!

Suggestion:
Consider using using the plus operator ('+')  for merging addict with a dictionary / with other addicts.
'+' is not implemented for standard dictionaries:
{}+{}
(TypeError: unsupported operand type(s) for +: 'dict' and 'dict')
but you can implement "+", in a similar way:
class Dict:
    ...
    def __add__(self, d):
        self.update(extend(self, d))    # totally NOT a working example

In that case, you could write:
new_addict = addict_obj + normal_dict
Which makes perfect sense (to me, and to some others).

Suggestion:
Consider using using the plus operator ('+')  for merging addict with a dictionary / with other addicts.
'+' is not implemented for standard dictionaries:
{}+{}
(TypeError: unsupported operand type(s) for +: 'dict' and 'dict')
but you can implement "+", in a similar way:
class Dict:
    ...
    def __add__(self, d):
        self.update(extend(self, d))    # totally NOT a working example

In that case, you could write:
new_addict = addict_obj + normal_dict
Which makes perfect sense (to me, and to some others).

Wow, amazing suggestion! +1

Wow, amazing suggestion! +1

What would be the expected behavior for this test case?
    prop = Dict({'a': 1, 'b': 'string', 'c': [1,2,3], 'd': {'a': 1}})
    result = prop + {'a': 2, 'c': [1], 'b': 'another string', 'd': {'b': 2}}

Would you replace or reject the value of a from the rhs?
Do you append the string, or replace it?
Does c get replaced or extended? A string is just an array of chars :)
I think d is the most straightforward with d == {'a': 1, 'b': 2}

Here is a hacked up version:
    @classmethod
    def _merge(self, lhs, rhs):
        for key, value in lhs.iteritems():
            if not key in rhs:
                rhs[key] = value
            elif isinstance(value, dict):
                self._merge(value, rhs[key])
        return rhs

    def __add__(self, rhs):
        return self._merge(self.to_dict(), rhs)

And a test:
def test_plus_operator_with_dict(self):
        prop = Dict({'a': 1, 'b': 'string', 'c': [1,2,3], 'd': {'a': 1}})
        result = prop + {'a': 2, 'c': [1], 'b': 'another string', 'd': {'b': 2}}
        self.assertDictEqual(result, {'a': 2, 'b': 'another string', 'c': [1,2,3,1], 'd': {'a': 1, 'b': 2}})

Let me know how you guys want to go forward, I can clean up and send a PR

OOPS, i didn't think of merging different data-types :(
it turns merging into a very UNDEFINED, and can be implemented in different ways, each with its own reasons.
I just tested your (sabhiram's) code in jQuery's Extend (with "true" as first argument).
it MERGED the list items; i.e. [1,2,3] + [1] ==> [1,2,3]     and also   [1] + [1,2,3] ==> [1,2,3] .
You suggested to EXTEND the lists, i.e. [1]+[1,2,3] ==> [1,2,3,1]  (although i don't see where it's done in your code snippet).
singletons were repalced with the newer dictionary, as in update().
i'd expect sets to be merged, too.
but it's not that obvious, isn't it?

Yea we could end up special casing all those types I suppose, but it would stop being pythonic I feel. I suppose we could allow some flexibility in what is merged and what is replaced, but again adds complexity in the callee.

+1 to extend

Hey guys,
Great discussion going on here. As I've previously stated, I'm not entirely certain where I stand on this. To me, the standard [dict update] (https://docs.python.org/2/library/stdtypes.html#dict.update) is quite clear, whereas I feel that the the extend is a bit hard to grasp, see @sabhiram's and @shula's comments. With that said, I guess the extend could be a nice complementary function to the update, if the functionality and use case is clearly documented. I welcome pull requests and further discussion around the subject.
Again, thanks for contributing!

I stumbled across this thread (and addict) while trying to find a solution to my own version of $.extend().
I see that you added it to addict, but what was the outcome of merging two different types? For my version I just overwrite the first type with the second. So if new.a = ['a','list'] and newer.a = 'a string' then newest = extend(new, newer), newest.a = 'a string'.

Hey @the4tress, we have not yet added it to addict. But we just got a new update function from #44, and I think addict is ready for this as well. I encourage everyone (@julianxhokaxhiu, @shula and @sabhiram, @the4tress  +++) to work on it if they have the time. I will probably have a look myself.
I am not sure how to answer this question as it is not yet implemented, so we could def. need help in planning the method and it's output. Thanks!

I forked and added a slightly modified version of my extend(). I'm not sure how to update the object though. Right now I'm using a = a.extend() when I should just use a.extend().
My version also has some list options. There are several examples in the way-too-long block comment.
Let me know what you think. This is my first time contributing to somebody else's project so go easy on me. I'll clean up and PEP8 the code later.
Here is my version: https://github.com/the4tress/addict/blob/master/addict/addict.py

So, at first glance, I must say that it looks like a very thorough job. Well done, @the4tress  :+1:
I'd like to take some time to go through the code, and in the meantime encourage you to write some test cases for this. As I take a look, I'd also like to engage @burk, @sabhiram, @shula and @julianxhokaxhiu get their opinions on this implementation.

Sorry @mewwts this period I'm really having no time to spend on this, but I'll look at this asap. But it's a good thing that now we have something concrete to analyze :)
What I can say for now is that my expectations are that is working like jQuery extend is working. But if it has plus features like a smarter way to merge, than it's more than welcome.
I'll give you a more dev friendly feedback asap :) Thanks in advice for everything guys!

Sorry, between a new job, school and twin two-year-olds I can't commit any time to this for a few weeks. I know this probably needs a lot of work and maybe has some features you don't really need/want, but I was just hoping to get a sample out there for you guys to improve on.
I take my CCNA Sec in a couple weeks. After that I should have more time to write tests and clean up the code.
What am I doing wrong where I can't use a.extend()?
Also, I just realized my examples in the comment block don't really match up. I was testing as I was writing at the same time but it should give an idea how its supposed to work.

@the4tress @julianxhokaxhiu no worries, I'll try to squeeze in a couple of hours on this in the coming week. The only issue is that I'm not the one requesting this feature so the usecases aren't completely clear to me. I'm more used to using assign in Javascript.

Isn't assign part of ES6? I haven't played with it much, but I don't think it does a deep merge. I could be wrong.


Disable enable_mem_pattern not working

Description
Hi all,
recently I encountered an issue when I implemented the onnx model, it would consume too much memory. Please check the issue that it seems a feature of onnxruntime. Hence, we can disable this optimized feature by this (solution).
For example,
session_option = onnxruntime.SessionOptions()
session_option.enable_mem_pattern = False
decoder = onnxruntime.InferenceSession(decoder_path, session_option)

We can set this enable_mem_pattern parameter to disable it.
So, I checked the README of onnxruntime_backend of Triton repository that I found there is a way to disable this feature on the Triton inference server.
Please check Model Config Options.
According to my understanding, we only need to set it in the model configuration.
For example, here is the config.pbtxt of my model.
name : "text_model"
platform: "onnxruntime_onnx"
max_batch_size: 0

input [
  {
    name: "sample"
    data_type: TYPE_FP32
    dims: [1, 3, -1, -1]
  },
  {
    name: "patches"
    data_type: TYPE_FP32
    dims: [-1, -1, -1]
  }
]

output [
{
    name: "density_map"
    data_type: TYPE_FP32
    dims: [-1, 1, -1, -1]
  }
]

instance_group [
  {
    count: 2
    kind: KIND_GPU
  }
]

optimization {
  graph : {
    level : 1
}}

parameters { key: "enable_mem_pattern" value: { string_value: "0" } }

I expect after I add these line codes, it should work. However, after I restart to Triton inference server and deploy it again, it seems not to work that the model still take a lot of GPU memory during inference. The GPU memory utilization is compared with purely Onnxruntime implementation.
Triton Information
Pull the image from NGC, and Version: nvcr.io/nvidia/tritonserver:22.07-py3
I am wondering whether I miss something setting. It will be grateful if there is any suggestions or idea about it.
Many thanks in advance!

Env info
My GPU driver version : 470

I have tried the latest GPU version (515) with Triton version nvcr.io/nvidia/tritonserver:22.07-py3, but it seems not working.

I am not sure whether it will show the configuration in this area if we set it correctly and it works well.


[questions] cpackget init

According to the help:
$ cpackget init --help
Initializes a pack root folder specified by -R/--pack-root command line
or via the CMSIS_PACK_ROOT environment variable with the following contents:
  - .Download/
  - .Local/
  - .Web/
  - .Web/index.pidx (downloaded from <index-url>)

But:
$ cpackget init -R ./packroot/
I: Using pack root: "./packroot/"
W: "packroot\.Web\index.pidx" not found. Creating a new one.

$ tree -a
.
|-- .Download
|-- .Local
`-- .Web
    `-- index.pidx

3 directories, 1 file

$ cat .Web/index.pidx
<?xml version="1.0" encoding="UTF-8"?>
<index schemaVersion="1.1.0">
 <vendor>packroot\.Web\index</vendor>
 <url></url>
 <pindex></pindex>
</index>

[Q1] .Web/index.pidx ==> where is it downloaded from ? What is <index-url> ?
Then we can install a pack:
$ cpackget pack add https://xxxxx/STMicroelectronics.STM32U5xx_DFP.0.1.0-alpha1.pack -R .
I: Using pack root: "."
I: Adding pack "STMicroelectronics.STM32U5xx_DFP.0.1.0-alpha1"
I: Downloading STMicroelectronics.STM32U5xx_DFP.0.1.0-alpha1.pack 100% || (2.2/2.2 MB, 1.414 MB/s)
I: Extracting files to STMicroelectronics\STM32U5xx_DFP\0.1.0-alpha1 100% || (49/49, 185 it/s)

And we end up with :
$ tree -a
.
|-- .Download
|   |-- STMicroelectronics.STM32U5xx_DFP.0.1.0-alpha1.pack
|   `-- STMicroelectronics.STM32U5xx_DFP.0.1.0-alpha1.pdsc
|-- .Local
|   `-- STMicroelectronics.STM32U5xx_DFP.pdsc
|-- .Web
|   `-- index.pidx
|-- STMicroelectronics
|   `-- STM32U5xx_DFP
|       `-- 0.1.0-alpha1
|           |-- Flash
|           |-- Include
|           |-- STMicroelectronics.STM32U5xx_DFP.pdsc
|           `-- Source
`-- pack.idx

[Q2] Why this architecture with files duplication ?
The .pack is kept in .Download, why ?
The .pdsc is present in multiple places, why ? Why in .local especially ?
Also:
$ cat pack.idx

[Q3] What is pack.idx ? Why is it empty ?
[Q4] As you know, we also want the possibility to have standalone projects with a local copy of packs. Will we have to apply this structure ? We want to follow our own files organization.

[Q1] I am not sure whether it is intentional that the 'init' command is not enforcing to specify the download location for the public pack index file. According to the usage: the index-url is optional
cpackget init [--pack-root <pack root>] [index-url] [flags]
The public pack index maintained by Arm is located here:
https://www.keil.com/pack/index.pidx
cpackget init --pack-root ./mypackroot https://www.keil.com/pack/index.pidx
[Q2] Duplication in .download is just a download cache. This allows you to install/uninstall a pack without the need to download it again.
Duplication of the pdsc file into .local is done for all packs that get installed that are not listed in the .Web/index.pidx (public packs). When checking for updates the  tag in the pdsc file stored in the .local folder are used to copy a new version of the pdsc to see whether there is new pack versions available. This allows to have PLM of "internal" / "local" packs. You need to install a pack once and can then check for updates of it.
[Q3] The file pack.idx is used by the IDE to find out whether packs have been added/removed. In this case the IDE will reread the  list of installed packs.
[Q4] In order for different tools sharing a single CMSIS-PACK repository we should all agree on the same folder structure.
I believe that standalone/self-contained projects do not require any of these additional folders (.Web/, .Local/, .Download, pack.idx) as these are considered local pack version folders. This means you simply reference a project relative pdsc file. If you were to update this pack version to a newer version, you would need to delete the containing folder and replace it with a copy of the extracted new pack version. This functionality is not supported by cpackget.

The file format is clearly something we can look at and the current implementation was driven by CMSIS-Build.
$cbuildgen packlist
command was developed write a file containing download url that would be read by a shell script (cp_install.sh) to do the actual download and unzip (.cp_install)
We replaced the shell script more recently with cpackget while maintaining the filename and format (1 url per line)
Did you know that you can simply pass a file with a list of packIDs (.)  and the above command would install the latest version of these.
So rather than supporting an xml format as input file to cpackget you should write a script to extract just vendor + name from an pidx formatted file and pass that to the cpackget.
BTW: I cannot think of many circumstances I would want to download all available packs. We are doing it for the online tools and it is huge.

BTW: I cannot think of many circumstances I would want to download all available packs. We are doing it for the online tools and it is huge.

I was thinking about ACI tests

@jeromecoutant do you see a strong requirement for cpackget to support pidx as input format?
Or do you think that cpackget should even have a command that creates and maintains a CMSIS-PACK folder with all published packs installed (either latest versions only or even all available versions?).
I personally think this is not the most typical use case and could be achieved by some scripting relatively easily using the existing features.

and could be achieved by some scripting relatively easily using the existing features.

I agree, and already partially done on my side :-)

@fred-r are you happy with the answers provided and can we close the issue?

Hi @jeromecoutant  and @jkrech ,
regarding the point raised by Jérôme : to me OpenCMSIS aims at providing the vanilla tooling for using the Open-CMSIS-pack-spec concepts.
So, I am more in favor of "atomic services", then the IDE or ACI using it can implement the exact required "advanced behavior".
If we implement to high level services the chances are high that it does not match the exact expectations of the users and that the feature becomes obsolete.
For the other questions: ok, I understand the structure now.
I think it makes sense for an IDE (what do you think @slhultgren @VGRSTM ?).
But, for a "standalone project" with local copies of packs, it might be overkill.
I do not know how you plan to address this point ?
Will it be in the scope of cpackget?

@fred-r the cpackget currently only deals with the CMSIS_PACK_ROOT folder and this is how I currently intend to keep it and have a clear separation of concern.
Depending on the use cases we should think about a utility that allows to "privatize" specific or all packs used by a solution / project / layer etc.  From my perspective this should be a copy operation from CMSIS_PACK_ROOT/ -> project destination -> adding PackID and path to the csolution.
Could you raise a new issue for this topic in Open-CMSIS-Pack-Spec and how you anticipate processing this?
We should close the issue here. Would you agree?

[Q3] pack.idx (sorry, bad name for historic reasons) is 'touched' by cpackget whenever a pack was added or removed. A running IDE session may decide based on this "activity" to reread the installed packs. E.g. the user may have installed a more recent version of a pack and the effective component selection may change to a new version of the component from this new pack.
The more critical scenario is, in case a pack being used by a project currently loaded in the IDE gets removed and as a result running e.g. a build of the project is going to fail.

Hi Joachim,
I worked with cpackget and uvision but this is not what I observe:
$ tree -L 2
.
|-- ARM
|   |               `-- CMSIS
|   |               `-- CMSIS-Driver
|   |               `-- PSA
|                   `-- mbedTLS
|-- Keil
|   |               `-- ARM_Compiler
|   |               `-- MDK-Middleware
|   |               `-- NUCLEO-L552ZE-Q_BSP
|   |               `-- STM32F4xx_DFP
|   |               `-- STM32H7xx_DFP
|   |               `-- STM32L4xx_DFP
|   |               `-- STM32L552E-EV_BSP
|   |               `-- STM32L562E-DK_BSP
|   |               `-- STM32L5xx_DFP
|   |               `-- STM32L5xx_TFM-PF
|   |               `-- STM32NUCLEO_BSP
|                   `-- STM32U5xx_DFP
|-- STMicroelectronics
|   |               `-- Example_HAL_GPIO_Toggle
|   |               `-- STM32U5xx_DFP
|   |               `-- STM32U5xx_Drivers
|                   `-- board_resources_B-U585I-IOT02A
`-- pack.idx

23 directories, 1 file

frq09468@LMECWL0888 MINGW64 /c/CMSIS_PACKS
$ cat pack.idx

frq09468@LMECWL0888 MINGW64 /c/CMSIS_PACKS

On my side, pack.idx is empty.

Any further questions, before we can close this issue?
@fred-r @VGRSTM

I'm fine to close. Thanks.


"Unknown variable $label" error during the generation

Hello, I have an "Unknown variable $label" error during the generation of the diagram. It seems that something is wrong in the C4.plum $getPerson. Please see the attached screen.
How to reproduce:

run c4builder new
run c4builder
Result:
no diagrams will be generated because of the error: https://ibb.co/Dzg81f0

Hi, this happens because of the PlantUML version.
Try to generate a diagram with only
@startuml
version
@enduml

Check the version. Most likely you are generating diagrams using the local jar file and the latest version of C4-PlantUML breaks because it supports the online plantuml server (1.2020.07).
Run config again and choose your version. Also, inside the diagrams, change the line
!include https://raw.githubusercontent.com/adrianvlupu/C4-PlantUML/latest/...

to
!include https://raw.githubusercontent.com/adrianvlupu/C4-PlantUML/1.2019.09/...

Hi,
first thanks for your work.
Unfortunately, I have the same problem here
plantuml -v
(0.000 - 481 Mo) 466 Mo - PlantUML Version 1.2020.07

@startuml
!include https://raw.githubusercontent.com/adrianvlupu/C4-PlantUML/1.2020.07/C4_Container.puml
@enduml

!include https://raw.githubusercontent.com/adrianvlupu/C4-PlantUML/1.2019.09
Thank you @adrianvlupu  for your work and for help with the issue.
The issue with a local rendering for plantuml v1.2019.09 was resolved by using the above-mentioned link.
@Whax try to use the link above.


migrate interface to a more specialized module

ok so. firstly, why? mainly because i don't really understand the bubbletea framework and i need something more robust; therefore, i'll be rewriting the entire thing. Isn't that great...

ok so got all the commands down but a few bugfixes are required:

[ ] fix exec command not showing output
[ ] fix list_clients not showing connected clients the first time
[ ] fix dialog command not showing output

there are a couple features i'd like to add:

[ ] add clear command
[ ] make text appear under the prompt sorta like the old server

yeah...

i'm currently considering migrating the CUI to ishell but that'll probably have to wait until after my finals are over as rewriting the entire server while i have an exam in 2 days doesn't sound so sexy

okay maybe not ishell since it's still in active development


[TF 2.0 API Docs] tf.keras.backend.random_uniform

URL(s) with the issue:
https://www.tensorflow.org/versions/r2.0/api_docs/python/tf/keras/backend/random_uniform
Description of issue (what needs changing):
The function has no usage example and there are no errors raised.
Raises listed and defined
No raises listed or defined.
Usage example
No usage example
Submit a pull request?
No.

@mwinel , Hello, why do you think that these random function need examples?


How to point the doczrc.js src to components in dependency package in a monorepo?

Question
How can I config docz to use components from other packages in monorepo?
Description
I am using a monorepo which has a package containing all the components. In the monorepo,  I have another package which wants to document these components. I am using gatsby with docz v2.0.0-rc.55.
So far using relative path to point to the components package (like this ../components-package/src/component) in the monorepo worked but that would be an anti-pattern to do so. I would prefer docz could reach into the node_modules which has components package as dependency.  Below is what I want
export default {
  menu: [
    { name: 'Docs home', route: 'docs/' },
  ],
  src: 'components-package/src/components', // components-package exists in the node_modules here
  files: '**/*.{mdx}',
}

However, when I navigate to http://localhost:8000/docs/, I got an error

and GraphQL error like Cannot query field "allDoczEntries" on type "Query". Did you mean "allDoczDb"?
I am wondering if this is possible to do with docz.
Give more information about your doubt

Twitter: If it's just a quick question you can ping me on Twitter: https://twitter.com/pedronauck

I think the filterComponents and docgenConfig.searchPath flags in doczrc.js would help for your use case.
Check out this monorepo example of a docs package used to document other peer packages : https://github.com/doczjs/docz/tree/master/examples/monorepo-separate-docs

I got it! Thank you very much


create pass-through writer and iowriter

As discussed with @SteveLasker , this is the first of 2-3 PRs expanding the capabilities of the store package.
There are two additions here:

PassthroughWriter that lets you wrap any other underlying store (e.g. file, memory) and have a processor function in the middle. Thus if I wanted to decrypt the content in transit, or uncompress, or any other action, I have a simple framework for doing so.
IoWriter is very similar to FileStore, except instead of taking a directory and opening files, it takes an actual io.Writer and passes it through. I have used it to, e.g. write directly to block devices, and to write to another stream over a network. It is more fine-grained control as you can pass it any io.Writer you want.

Once these are in, I have two more that take advantage of the PassthroughWriter: GunzipWriter and UntarWriter.

Thanks for rebasing on master @jdolitsky . Any other comments on it?

@deitch code lgtm - can we add a few unit tests for these? Or I suppose they can be added w/ the Gunzip/Untar writers?

Yeah, that is a good idea. At least for the io.Writer one. I will find some time to do it.

A bit odd to do, but I think this works for the test.

@deitch can you check failing CI?

@jdolitsky I ran it multiple times locally, I cannot see the failure. Could be transient. I am repushing to kick off again

Nope that failed too. The failure doesn't appear to have anything to do with this PR, but I am not sure.
--- FAIL: TestORASTestSuite (0.27s)
    --- FAIL: TestORASTestSuite/Test_0_Push (0.09s)
    --- FAIL: TestORASTestSuite/Test_1_Pull (0.06s)
    --- PASS: TestORASTestSuite/Test_2_MediaType (0.05s)
    --- PASS: TestORASTestSuite/Test_3_Conditional_Pull (0.05s)

Any ideas? Here is the output https://github.com/deislabs/oras/pull/182/checks?check_run_id=1210937435

What is wrong with the CI run @jdolitsky ?

@jdolitsky I rebased onto master, but also took advantage to simplify the interface, which ended up simplifying the code and blocksize stuff materially, while hewing much more closely to the classic golang style. Take a look, and let's get this in? It has been open for a good few weeks.

And CI is all clean. Even better.

Shoot. It deleted all my changes! I have to recreate them!

Phew. Managed to recover it all. Back at you @jdolitsky

And CI is green.

Excellent.
I have gunzip and untar writers ready to go based on this.


Change name of two groups for readability

This commit is to change the existing group name from "pr-{pre/post}-all"
to "pr-{pre/post}-group" to improve readability and clarify the meaning of
group name (e.g., prebuild group and postbuild group).
Signed-off-by: Geunsik Lim<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200324. Thank you for submitting PR #620. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

INFO: You can read if there are syntax errors in the our shellcheck report. Please read http://nnsuite.mooo.com/TAOS-CI/ci/repo-workers/pr-checker/620-202003260735190.81004405021667-1f675c34bf30926f4717fab57341fc67b7e7f158/report/shellcheck_syntax_result.txt.


Proposal for Configuration File Support in Wasmtime

Feature
Wasmtime's configurability is flexible such as the pooling allocation strategy or enable/disable parallel compilation. However, this configurations can also be programmatically set using the wasmtime::Config struct. I am proposing to add support for a configuration file that Wasmtime can consume.
Benefit
Services (such as containerd wasmtime-shim) that uses wasmtime APIs to compile and execute Wasm components today rely on environment variables to configure Wasmtime engine. Whether it is to disable parallel compilation or change the pooling allocation strategy. With the huge number of configuration options that wasmtime provides, it is difficult for users and service providers to maintain these dynamic configuration options. We suggest using a TOML or YAML file for the configuration file due to their readability.
Implementation

Parsing Configuration File:
Implement a parser to read and deserialize the configuration file into a wasmtime::Config struct.

Applying Configuration:
Extend the wasmtime::Config struct with methods to apply settings from the deserialized configuration.

Alternatives
Interestingly, wasmtime CLI has a config command in which you can use it to create a new config.
$ wasmtime config new
Successfully created a new configuration file at '/home/mossaka/.config/wasmtime/config.toml'.

However, this config command is used ONLY for cache configuration, which is a tiny fraction of the total configuration options that wasmtime provides.

Extending the existing cache-config TOML for general Wasmtime options makes sense to me.
We probably want to refactor our config and CLI and (now) TOML code such that there is one source of truth that automatically makes knobs for each configurable thing in all those various places.

This seems like a good idea to me - thanks @Mossaka. Agreed with Nick.

Thanks, I might get someone to help with this or do it myself.


Document security considerations

As a developer adopting and configuring the json-proxy-service, I would like to understand what makes it secure, under what circumstances it is secure, and what I need to do properly in the configuration and in the implementation of the backing JSON web service to comport with the security model.
(This came up at 2015-06-17 f2f MyUW portal developers' meeting.)

Please provide more detail of what you want, or better yet a PR. Thanks.


Event renaming

For example, node/add event name for the event fired from some Model, looks improper, so we probably should rename event to model/add-node.
So, draft variant:

Model: node/add → model/add-node
Model: node/remove → model/remove-node
Node: inlet/add → node/add-inlet
Node: inlet/remove → node/remove-inlet
Node: outlet/add → node/add-outlet
Node: outlet/remove → node/remove-outlet

Also, model/new event is not "compatible" with node/prepare / node/ready events. Probably there should be events:

network/add-model
model/initialize
node/initialize instead of node/ready, since ready is a condition instead of verb

Relates to #112

model/inputs → model/set-inputs
model/outputs → model/set-outputs

In general, try to stay with subject/verb.

model/active → model/enter & model/exit

https://speakerdeck.com/jmorrell/jsconf-uy-flux-those-who-forget-the-past-dot-dot-dot-1
Since we (seem to) match the Flux pattern, probably verbs should be in past tense?

Model: node/add → model/node-added
Model: node/remove → model/node-removed
Model: model/enter → model/entered
Model: model/exit → model/exited
Node: inlet/add → node/inlet-added
Node: inlet/remove → node/inlet-removed
Node: outlet/add → node/outlet-added
Node: outlet/remove → node/outlet-removed

If we use past tense, some events like node/process or model/render could lose their meaning.

What we have now:
Network:

network/add-patch

Patch:

patch/ready
patch/enter
patch/exit
patch/render
patch/inputs
patch/outputs
patch/refer
patch/project
patch/add-node
patch/remove-node

Node:

node/turn-on
node/turn-off
node/ready
node/process
node/add-inlet
node/remove-inlet
node/add-outlet
node/remove-outlet

Inlet:

inllet/update

Outlet:

outlet/update
outlet/connect
outlet/disconnect

Link:

link/enable
link/disable
link/pass
link/adapt

Possible change:
Network:

network/add-patch → network/patch-added

Patch:

patch/ready → patch/prepared
patch/enter → patch/entered
patch/exit → patch/exited
patch/render → patch/render-requested
patch/inputs → patch/inputs-set
patch/outputs → patch/outputs-set
patch/refer → patch/referred
patch/project → patch/projected
patch/add-node → patch/node-added
patch/remove-node → patch/node-removed

Node:

node/turn-on → node/turned-on
node/turn-off → node/turned-off
node/ready → node/prepared
node/process → node/process-requested
node/add-inlet → node/inlet-added
node/remove-inlet → node/inlet-removed
node/add-outlet → node/outlet-added
node/remove-outlet → node/outlet-removed

Inlet:

inlet/update → inlet/updated (inlet/value-updated?)

Outlet:

outlet/update → outlet/updated (outlet/value-updated?)
outlet/connect → outlet/connected (outlet/connected-to-inlet?)
outlet/disconnect outlet/disconnected (outlet/disconnected-from-inlet?)

Link:

link/enable → link/enabled
link/disable → link/disabled
link/pass → link/received-value
link/adapt → link/adapted-value

Add:

patch/created (before patch/prepared)
node/created (before node/prepared)

patch/render could actually be moved away from public event bus to private instance stream

I decided not to convert events to Past Tense yet, it looks a bit weird, though may be I will have a second thought later, so I moved it to issue #131


Allow substitution to matrix variable

My main use case is that the Python docker image have the form "python:3.5" but for the tox build system they have the form "py35". So for now I have to use the 'include' close to define two variables but it will be great if I could have a PYTHON_VERSION=3.5 and use ${PYHTON_VERSION/.//}

Are you sure that http://docs.drone.io/substitution/#string-operations doesn't work for matrix variables?

Sorry my bad, when I tried the first time, I did not notice that I made a mistake in the expression.


env variable DOCKER_XXX not available in pipeline script

pipeline script:
node("test") {
  stage 'execute robot test cases'
  sh "export"
  echo "${env.DOCKER_CONTAINER_ID}"
}

console output:
[Pipeline] sh
[abc] Running shell script
+ export
export BUILD_DISPLAY_NAME='#18'
export BUILD_ID='18'
export BUILD_NUMBER='18'
export BUILD_TAG='jenkins-abc-18'
export BUILD_URL='http://<IP_ADDRESS>:8000/job/abc/18/'
export EXECUTOR_NUMBER='0'
export HOME='/home/jenkins'
export HUDSON_COOKIE='4adaf6a1-1c7e-4c9d-86db-d5fb15ddac3f'
export HUDSON_HOME='/var/jenkins_home'
export HUDSON_SERVER_COOKIE='d3f1a8628256127e'
export HUDSON_URL='http://<IP_ADDRESS>:8000/'
export JENKINS_HOME='/var/jenkins_home'
export JENKINS_SERVER_COOKIE='durable-75856e1293359a7a00e531e58e5e39b6'
export JENKINS_URL='http://<IP_ADDRESS>:8000/'
export JOB_BASE_NAME='abc'
export JOB_NAME='abc'
export JOB_URL='http://<IP_ADDRESS>:8000/job/abc/'
export LANG='C.UTF-8'
export LANGUAGE='en_US:en'
export LC_ALL='C.UTF-8'
export LOGNAME='jenkins'
export MAIL='/var/mail/jenkins'
export NODE_NAME='RF-HOST1-26d4e0f2827d'
export OLDPWD='/home/jenkins'
export PATH='/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games'
export PWD='/home/jenkins/workspace/abc'
export SHELL='/bin/bash'
export SHLVL='1'
export SSH_CLIENT='<IP_ADDRESS> 50854 22'
export SSH_CONNECTION='<IP_ADDRESS> 50854 <IP_ADDRESS> 22'
export _='/usr/bin/java'
[Pipeline] echo
null
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline

They are injected by environmentContributor

https://github.com/KostyaSha/yet-another-docker-plugin/blob/master/yet-another-docker-plugin/src/main/java/com/github/kostyasha/yad/DockerBuildVariableContributor.java#L26
Right it uses AbstractBuild, will try think how to use Job type.

#62 let's check whether it works

Resolved via #62

Released

oh, i update to  0.1.0-rc18, but my pipeline job not work, need special config?
pipeline output, DOCKER_XXX not in env
Started by user admin
[Pipeline] node
Still waiting to schedule task
Waiting for next available executor
Running on RF-HOST1-5bf30fc46782 in /home/jenkins/workspace/admin/eee
[Pipeline] {
[Pipeline] stage (环境变量)
Entering stage 环境变量
Proceeding
[Pipeline] sh
[eee] Running shell script
+ export
export BUILD_DISPLAY_NAME='#1'
export BUILD_ID='1'
export BUILD_NUMBER='1'
export BUILD_TAG='jenkins-admin-eee-1'
export BUILD_URL='http://<IP_ADDRESS>:8000/job/admin/job/eee/1/'
export EXECUTOR_NUMBER='0'
export HOME='/home/jenkins'
export HUDSON_COOKIE='26fcc18c-93bf-4881-ad49-aa9332c19d85'
export HUDSON_HOME='/var/jenkins_home'
export HUDSON_SERVER_COOKIE='d3f1a8628256127e'
export HUDSON_URL='http://<IP_ADDRESS>:8000/'
export JENKINS_HOME='/var/jenkins_home'
export JENKINS_SERVER_COOKIE='durable-2b86087b96c9a80603b800e1640139c1'
export JENKINS_URL='http://<IP_ADDRESS>:8000/'
export JOB_BASE_NAME='eee'
export JOB_NAME='admin/eee'
export JOB_URL='http://<IP_ADDRESS>:8000/job/admin/job/eee/'
export LANG='C.UTF-8'
export LANGUAGE='en_US:en'
export LC_ALL='C.UTF-8'
export LOGNAME='jenkins'
export MAIL='/var/mail/jenkins'
export NODE_NAME='RF-HOST1-5bf30fc46782'
export OLDPWD='/home/jenkins'
export PATH='/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games'
export PWD='/home/jenkins/workspace/admin/eee'
export SHELL='/bin/bash'
export SHLVL='1'
export SSH_CLIENT='<IP_ADDRESS> 47471 22'
export SSH_CONNECTION='<IP_ADDRESS> 47471 <IP_ADDRESS> 22'
export TZ='Asia/Shanghai'
export USER='jenkins'
export _='/usr/bin/java'
... ...

freeStyleJob output:
Started by user admin
[EnvInject] - Loading node environment variables.
Building remotely on RF-HOST1-e2548d31b02a (robot) in workspace /home/jenkins/workspace/test-dsl
[YAD-PLUGIN] Injecting DOCKER_CONTAINER_ID variable.
[YAD-PLUGIN] Injecting JENKINS_CLOUD_ID variable.
[YAD-PLUGIN] DOCKER_HOST variable.
Checking out a fresh workspace because there's no workspace at /home/jenkins/workspace/test-dsl
Cleaning local Directory .
Checking out https://<IP_ADDRESS>/svn/Version/RF/jenkins/DSL/ at revision '2016-08-16T16:59:30.912 +0800'
A         JobFactory.groovy
At revision 1026

No changes for https://<IP_ADDRESS>/svn/Version/RF/jenkins/DSL/TestCaseJob since the previous build
[YAD-PLUGIN] Injecting DOCKER_CONTAINER_ID variable.
[YAD-PLUGIN] Injecting JENKINS_CLOUD_ID variable.
[YAD-PLUGIN] DOCKER_HOST variable.
[YAD-PLUGIN] Injecting DOCKER_CONTAINER_ID variable.
[YAD-PLUGIN] Injecting JENKINS_CLOUD_ID variable.
[YAD-PLUGIN] DOCKER_HOST variable.
... ...

that strange...

Maybe         final Executor executor = run.getExecutor(); doesn't return executor for workflowrun.
Could you debug (if you have java skill)?

Bug? https://issues.jenkins-ci.org/browse/JENKINS-33511
cc @abayer

@mytliulei would you be able to parse JSON in pipeline code? I will create special DSL method then.

@KostyaSha Likely run.getExecutor() does not behave as you expect. Pipeline has fly-weight executors, and they are not guaranteed to run on the same node as the node from the node() command

@oleg-nenashev env call happens in node scope, EnvironmentContributor must be called in this scope.

Yes, env() is supposed to work correctly. But I doubt it takes the workspace information from the execution. Not 100% sure

Calling @jglick that suggested to use EnvironmentContributor

[16:26]  <jglick> KostyaSha: EnvironmentContributor sets job- and build-wide environment variables and works fine on Pipeline jobs & builds AFAIK. There is nothing in that API that refers to nodes.

Could be reworked via [16:27]  <danielbeck> KostyaSha http://javadoc.jenkins-ci.org/hudson/slaves/NodeProperty.html#buildEnvVars-hudson.EnvVars-hudson.model.TaskListener-  as template configuration supports NodeProperties already.

Is it still actual?

@KostyaSha A bit late to the show here, but I am experiencing this exact issue using Jenkins ver. 2.30 and YAD v 0.1.0-rc30 Using
node("test") {
  stage 'execute robot test cases'
  echo "${env.DOCKER_CONTAINER_ID}"
}

yields only null. Is there a workaround that I haven't seen?

I can try check whether it possible inject variable via NodeProperty in https://github.com/KostyaSha/yet-another-docker-plugin/pull/105

But according to https://github.com/KostyaSha/yet-another-docker-plugin/issues/61#issuecomment-241412886 it should be executed. Pipeline uses so hacked APIs that i forgot with what my research end.

@KostyaSha Might be that Pipeline aggressively removes variables? The [YAD-PLUGIN] DOCKER_HOST variable. is nowhere to be found in the console output for sure. Found this one funny btw https://github.com/jenkinsci/docker-plugin/pull/450

@KostyaSha Okey, found a workaround. Seems like the variations of the Pipeline plugin removes the DOCKER_HOST by some means or overrides the YAD-plugin. If I would take a guess I think the Docker Pipeline plugin is involved in some way.
My workaround was to explicitly add DOCKER_HOST as a node environment variable, repeating the Docker URL, in the setup for YAD in Jenkins settings

Same problem... YAD-PLUGIN is not run when for pipelined docker build:
node('docker-agent') {
  stage 'Print Debug'
  sh 'env | sort'
}

My workaround was to explicitly add DOCKER_HOST as a node environment variable, repeating the Docker URL, in the setup for YAD in Jenkins settings

Sounds very strange.
There is WIP that probably will help https://github.com/KostyaSha/yet-another-docker-plugin/pull/105

Still having this problem today. A pipeline build (using scripted pipeline) does not have the DOCKER_HOST variable set.

Did you enable docker specific properties in node properties?

You mean in the pipeline or in the YAD config?

Ah, wait, yes.

Well, then workflow has bug for EnvironmentContributor's

envy is not exported in pipelines by default in my experience.  You must use a withEnv wrapper.

when you take node() it must resolve NodeEnv contributors. Try fill bug to @jglick if it not happening.

Okay. setting the DOCKER_HOST manually works.
Do you have any hint where these information need to be added or are getting lost in the automatic fashion? With this I could do some debugging work.


MAISTRA-1399 default to NetworkPolicy if an unknown network type is in use

This simply removes the allowlist check and defaults to NetworkPolicy.
Signed-off-by: rcernich<EMAIL_ADDRESS>

I guess LGTM is right; in line 105 we're introducing another err var that is shadowing the one from func scope


[api change] Make additionalProperties a Record

Sorry I didn't make this work when introducing this feature, but I didn't know enough TypeScript. Anyhow, Record type is better here, since it makes checking keys much more efficient.
Also, a couple of additional quality-of-life-changes:

expose AliKey as part of public API,
expose additionalProperties on Group (things like ArtboardData are on Group, not Layer).

Let me know WDYT :)

That is odd. Object.fromEntries() is available in Node 14 according to node.green. Maybe there is a problem with our ESLint or TypeScript?


Script fix

Added in a user agent header to the session to stop the 403 errors from letting BeautifulSoup do its beautiful work. Also added in a pause since I know from experience (not this script, JPod's own mass downloader for podcast applications) that you can get IP-banned for requesting too many file downloads. May have corrected a comment here or there too...

Made few tests, it does work.
Good job David.

No problem, happy to help! :)


Change command that adds Heroku add-ons

This PR fixes the following message:

WARNING: heroku addons:add has been deprecated. Please use heroku addons:create instead.

Hi @ddomingues, one test is failing. To make it pass you need to update the mock to reflect the new command in https://github.com/Helabs/pah/blob/master/features/support/bin/heroku#L15-L18.
And update the test to reflect the output from the mock in https://github.com/Helabs/pah/blob/c024b21a6c2eb2baddabd75114b0f505ae39dce1/features/runner.feature#L31-L54.
Basically change the references of  addons:add to addons:create in these files.

Hi @marcioj. I'm sorry for this. I didn't see the tests in features, only when the travis build failed. :disappointed:
I made the changes. :smile:

Sorry for the delay, can you rebase your changes?

Hi @marcioj. Changes rebased! :+1:

:clap: LGTM

Thank you @ddomingues !


Request to add Special patches (Mushrooms, Belladonna)

As the title says,
would it be possible to add trackers for the Mushroom patch and Belladonna patches?

Duplicate of https://github.com/queicherius/runelite-time-tracking-reminder/issues/25