Add package for BitKeeper-7.3

Motivation for this change
Easier access to BitKeeper for nixpkg users.
Things done

[X] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[X] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Needed to update URLs for tomcrypt and tommath libraries.
Updated tommath to a more recent version, but the one other
package in nixpkgs that uses it still works fine.

OK added a cset that attempts to address the issues mentioned above.
Bear with me, git and github are unfamiliar to me.  (I have been in bitkeeper-land... )
Should I create 2 new pull requests for the libtom* changes or just refactor this branch into 3 csets (tomcrypt, tommath, bitkeeper) ?

@wscott it's not paramount, but typically, each bump/addition is its own commit; so this PR would be a sequence of bumps of the dependencies, one commit per bump, and finally the addition of bitkeeper. There's no need to submit separate PRs if these changes are logically related, but if the bumps are unrelated they should be separate PRs (ideally).

travis failure: /run/user/1001/nix-build-bitkeeper-7.3ce.drv-0/ccgapBj5.s: Fatal error: can't write 36 bytes to section .text of rclone.o because: 'No space left on device'
Don't see how I can help this.

On Wed, Jul 13, 2016, at 10:33 PM, Wayne Scott wrote:

travis failure:
/run/user/1001/nix-build-bitkeeper-7.3ce.drv-0/ccgapBj5.s: Fatal error:
can't write 36 bytes to section .text of rclone.o because: 'No space left
on device'
Don't see how I can help this.
Just ignore it


Fix ZMQ & handle messages

Details

[!NOTE]
ZMQ is not working right now

When it is, time to parse the messages
Reuse current parsers from multicast if possible.
Capture output of messages and ensure ESP32 standard and status are all available and in usable format from the decoder and sync scripts

Proposed Changelog to fix this
ZMTP Protocol Implementation

Added proper ZMTP handshake sequence with greeting
Implemented correct message framing for ZMQ protocol
Added buffer handling for incomplete messages

Subscription Fixes:

Removed incorrect closing braces from topic strings
Changed subscription format to match dragonsync.py exactly
Added initial empty subscription ("") to receive all messages
Fixed telemetry topics: ["{"AUX_ADV_IND"", "{"DroneID""]

Message Validation:

Added validation for AUX_ADV_IND messages (checking aa == 0x8e89bed6)
Added DroneID message validation
Improved message processing to match dragonsync.py's parsing

Connection Handling:

Added connection drop detection
Implemented automatic reconnection logic
Added max retry attempts (3 times)
Added reconnection delay (5 seconds)
Added proper connection state management
Added cleanup on disconnect

General Improvements:

Added better error handling and logging
Improved message buffer management
Added proper cleanup of resources
Added connection status tracking
Added error reporting to UI

Solution
A better option was using SwiftyZeroMQ5. With some changes we are able to use it with latest Xcode and macOS architectures. These are done locally to the Xcode project and pod config.
Changes
e2021447ba9fe7bf0a99c982e206b830fa057ddd aims to address #8 #4 and provide an extensible solution for zmq support. It can easily send and receive messages, make further development more agile and streamlined for all.
TODO
• Test using hardware over the local network and confirm message receipt
• Reformatting of parsing structure where necessary
• Inspect packets from Wireshark to ensure we aren’t dropping the connection as it did before
• Attempt to build a library for the iOS simulator so it doesn’t all have to be tested on-device.

Status messages are working. ZMQ is a go. Closing and moving to work on drone messsges


[BUG] Encountered a problem when using SparseSelfAttention.

Hi there,
I attempt to use SparseSelfAttention class to calculate matrix multiplication as following code:
result_layer = self.sparse_self_attention(query_layer,
key_layer,
value_layer,
key_padding_mask=None)
Two months ago, the thing was oke but now I run the same code again and an error is triggered as shown below:
ImportError: cannot import name 'MatMul' from 'deepspeed.ops.sparse_attention' (/usr/local/lib/python3.7/dist-packages/deepspeed/ops/sparse_attention/init.py)
Please help me fix that error.
Many thanks!
P/s: Deepspeed was successfully installed via ds_report.txt.
ds_report.txt

Hi @AngThanos,
this problem might be due to the changes we imported from the new version of Triton. I will try this and let you know if I repro this. If you could provide me some test for this, that would be awesome.
We will push a fix for this soon.
Thanks,
Reza

Hi Im having the same error when I try
from deepspeed.ops.sparse_attention import MatMul, Softmax
The error -
ImportError: cannot import name 'MatMul' from 'deepspeed.ops.sparse_attention' (/opt/conda/lib/python3.7/site-packages/deepspeed/ops/sparse_attention/__init__.py)
my 'ds_report' is:
--------------------------------------------------
DeepSpeed C++/CUDA extension op report
--------------------------------------------------
NOTE: Ops not installed will be just-in-time (JIT) compiled at
      runtime if needed. Op compatibility means that your system
      meet the required dependencies to JIT install the op.
--------------------------------------------------
JIT compiled ops requires ninja
ninja .................. [OKAY]
--------------------------------------------------
op name ................ installed .. compatible
--------------------------------------------------
cpu_adam ............... [NO] ....... [OKAY]
cpu_adagrad ............ [NO] ....... [OKAY]
fused_adam ............. [NO] ....... [OKAY]
fused_lamb ............. [NO] ....... [OKAY]
sparse_attn ............ [YES] ...... [OKAY]
transformer ............ [NO] ....... [OKAY]
stochastic_transformer . [NO] ....... [OKAY]
async_io ............... [NO] ....... [OKAY]
utils .................. [NO] ....... [OKAY]
quantizer .............. [NO] ....... [OKAY]
transformer_inference .. [NO] ....... [OKAY]
--------------------------------------------------
DeepSpeed general environment info:
torch install path ............... ['/opt/conda/lib/python3.7/site-packages/torch']
torch version .................... 1.11.0
torch cuda version ............... 11.3
torch hip version ................ None
nvcc version ..................... 11.3
deepspeed install path ........... ['/opt/conda/lib/python3.7/site-packages/deepspeed']
deepspeed info ................... 0.6.2+0149bd4f, 0149bd4f, master
deepspeed wheel compiled w. ...... torch 1.11, cuda 11.3, hip 0.0

Hi Im having the same error when I try from deepspeed.ops.sparse_attention import MatMul, Softmax
The error - ImportError: cannot import name 'MatMul' from 'deepspeed.ops.sparse_attention' (/opt/conda/lib/python3.7/site-packages/deepspeed/ops/sparse_attention/__init__.py)
my 'ds_report' is:
--------------------------------------------------
DeepSpeed C++/CUDA extension op report
--------------------------------------------------
NOTE: Ops not installed will be just-in-time (JIT) compiled at
      runtime if needed. Op compatibility means that your system
      meet the required dependencies to JIT install the op.
--------------------------------------------------
JIT compiled ops requires ninja
ninja .................. [OKAY]
--------------------------------------------------
op name ................ installed .. compatible
--------------------------------------------------
cpu_adam ............... [NO] ....... [OKAY]
cpu_adagrad ............ [NO] ....... [OKAY]
fused_adam ............. [NO] ....... [OKAY]
fused_lamb ............. [NO] ....... [OKAY]
sparse_attn ............ [YES] ...... [OKAY]
transformer ............ [NO] ....... [OKAY]
stochastic_transformer . [NO] ....... [OKAY]
async_io ............... [NO] ....... [OKAY]
utils .................. [NO] ....... [OKAY]
quantizer .............. [NO] ....... [OKAY]
transformer_inference .. [NO] ....... [OKAY]
--------------------------------------------------
DeepSpeed general environment info:
torch install path ............... ['/opt/conda/lib/python3.7/site-packages/torch']
torch version .................... 1.11.0
torch cuda version ............... 11.3
torch hip version ................ None
nvcc version ..................... 11.3
deepspeed install path ........... ['/opt/conda/lib/python3.7/site-packages/deepspeed']
deepspeed info ................... 0.6.2+0149bd4f, 0149bd4f, master
deepspeed wheel compiled w. ...... torch 1.11, cuda 11.3, hip 0.0

This was due to a wrong import. The correct import is.
 from deepspeed.ops.sparse_attention.matmul import MatMul

Closing as the issue is stale given the updates to DeepSpeed and triton.


Need to rebuild the mobile launcher app to support VR apps

I will probably move it into its own repo too.
https://github.com/the-expanse/SideQuest/pull/609

done!


Possible explanation slower early steps

Re: https://github.com/KellerJordan/modded-nanogpt/blob/e1343685254e498c3a069c4d8b6a3ab8aec0a18c/train_gpt2.py#L464C7-L464C90
I assume it's due to torch.compile not being AOT.
Frankly, I would argue that this should be included in the total training time. Reason being that changing the size of the attention window or batch size in the middle of training does require a recompile. Stopping the timer for each recompile opens the door to a whole lot of untimed "this is not gradient descent"-type calculations.
Anyways, do what feels right for you. I really like this repo and the idea behind it.

The reason I'm not interested in including compilation time in the final timing is as follows:

It varies a lot - the very first run on a new machine will have longer compilation time than subsequent runs

In theory it can be completely gotten rid of. For example, Karpathy's llm.c has virtually zero compilation time. So, including compilation it in the timing would probably just force the run to be rewritten in CUDA, which isn't something I'm interested in

You're right that this is a problem for anything which would need an intermediate recompile. Well, I'd be interested in taking that on a case by case basis
Thanks -Keller


Error in building the application

While deploying the app engine standared service(Java17), we got the below issue. This is annoying. it does have all the permissions

kindly support if you guys know something on this?

There's has been an incident that affected new AppEngine deployments and caused this error. This has just been mitigated, so I would expect it to work now.


Weird mix of repos?

It looks like some versions of this repo (laravel-shopify) are actually snapshots of the basic-api repo, unless I'm missing something here. Here's an example: https://github.com/osiset/laravel-shopify/blob/22155b425180655645dff729f6262bfa715904bc/composer.json#L2
Is this a bug or is this on purpose? If it's on purpose how is it effecting upgrading the packge through composer? I want to upgrade but a bit afraid.
Thanks!
Amos

Hey @amosmos
This Laravel-Shopify uses the basic-shopify-api package for accessing data in Shopify. Both of these packages are developed by the same author.
You can use only basic-shopify-api package if you want to take care of auth, billing other features.
When you access Shopify data using this app, it always uses basic-shopify-api package.
There will be no issue if you upgrade it.
Thanks.

Hey @Hujjat  - thanks for responding.
I know about basic-shopify-api and use it in some projects as well.
The issue here is that somehow that package got mixed in this repository, as I showed in the example.
Thanks

@amosmos Where did you find this? May have been a mistake somewhere, but I see https://github.com/osiset/laravel-shopify/blob/master/composer.json#L2 is correct.

Hey @osiset - Any chance you can remove the wrong tags?
It's v6.1.0 to v6.1.3.
It's messing our apps every time we upgrade our dependencies


Ambiguous address in "Enable DNS over HTTPS" guides

In both the Edge and Firefox guide it says in the text to point to anycast.censurfridns.dk but the images show https://anycast.uncensoreddns.org/dns-query.
Which address is correct?
Below is the relevant screen shots from the guides.

Edge screenshot showing https://anycast.uncensoreddns.org/dns-query

Firefox screenshot showing https://anycast.uncensoreddns.org/dns-query

Both are equally correct. Danish speakers might prefer the censurfridns.dk domain and english speakers might prefer the uncensoreddns.org domain. Both work equally well, both are in all the certificates and can be used interchangably.

Gotcha! Thanks
So the protocol and path part is also interchangeable? E.g. https or without and /dns-query or root path.

Entering anycast.censurfridns.dk like mentioned in the guide doesn't work for me using Firefox 105.0.2 on Linux. It simply ignores the setting and falls back to using the system-wide DNS resolver, so I think the protocol and/or path is required.
It works when using https://anycast.uncensoreddns.org/dns-query or https://anycast.censurfridns.dk/dns-query.
I made a pull request to change the Firefox guide: https://github.com/censurfridns/client-configs/pull/12
The same change might be needed for Edge, however I don't have a Windows machine available for testing right now.

merged - thanks! :)


Move implementation to a folder more suited according to linux conventions

@ihudak thanks for your review, but considering the conflicts, im not sure how to salvage this branch/PR. i will take the diff and redo it when the bulk of the other PRs is merged

@ihudak i will open a new PR and add u as a reviewer when all open PRs are merged


Small enhancements to time component

Based on investigating a couple of Dave B's comments, these changes were some "quick" wins.  Do we want to add these now, or after the first major release is out as a second major release?

Finally figured out why they actually needed flex, should've explored all options of the demo :(  This seems to work though


Add Brazilian Portuguese translation (volunteer)

I'd like to volunteer to translate stat.ink to Brazilian Portuguese pt-BR. The translation would be done following the current state of the English version of the website with corrections if needed. I've already translated Splatoon 3 Gear Seed Checker and Sendou.ink to my language as well.
Thank you very much.

Thank you.
You can pick one of the messages directories and copy it to the pt-BR directory to work on, or you can use the contents of the branch I have created as a base.
(You do not necessarily need to use this branch.)
No need to finish all translations at once.

No worries! I'll take my time to make sure everything is okay.
Thank you very much for providing the base. Here I go!

#1346

@Ant-Spl
Thank you again,
PR #1346 has been merged and deployed.
If you have additional translations, please create another PR.
Also, I'm reflecting translations from you guys and from the Spanish catalog to create and reflect translations for a private project that creates thumbnail images, etc. for the top page and details page.
If you have any suggestions, please let me know.
for battle results
<?php

declare(strict_types=1);

return [
    'DEFEAT' => 'Derrota',
    'DRAW' => 'Empate',
    'KNOCKOUT!' => 'Knockout!',
    'Score: {count}' => 'Pontuação: {count}',
    'VICTORY' => 'Vitória',
    '{percent}%' => '{percent} %',
    '{point}p' => '{point} p',
];

for salmon run results
<?php

declare(strict_types=1);

return [
    'Clear!' => 'Victoria!',
    'Defeat' => 'Derrota...',
    'Hazard Level' => 'Nível de Hazard',
    'Hazard Level MAX!' => 'Nível de Hazard MÁX!',
    'High Tide' => 'Maré alta',
    'Low Tide' => 'Maré baixa',
    'Normal' => 'Maré média',
    'Private Job' => 'Partida Privada',
    'Wave {waveNumber}' => '',
    'XTRAWAVE' => '',
];


Increase the usage of augmented assignment statements

:eyes: Some source code analysis tools can help to find opportunities for improving software components.
:thought_balloon: I propose to increase the usage of augmented assignment statements accordingly.
Would you like to integrate anything from a transformation result which can be generated by a command like the following?
(:point_right: Please check also for questionable change suggestions because of an evolving search pattern.)
[Markus_Elfring@fedora lokal]$ perl -p -i.orig -0777 -e 's/^(?<indentation>\s+)(?<target>\S+)\s*=\s*\k<target>[ \t]*(?<operator>[+\-%&|^@]|\*\*?|\/\/?|<<|>>)/$+{indentation}$+{target} $+{operator}=/gm' $(find ~/Projekte/mne-python/lokal -name '*.py')

maybe I'm missing something, but this seems like a pretty low performance / maintainability gain, in exchange for a fair amount of developer time making sure the suggested changes are appropriate.  Personally I think we are in general quite far from needing this degree of optimization, though I'm happy to be convinced otherwise if other devs disagree.
Out of curiosity, did you already run this on our source repo @elfring?  How many lines does it end up changing?

…, though I'm happy to be convinced otherwise …

How do you think about to support any collateral evolution according to information from the Python enhancement proposal 577 (from 2018-05-14)? :thinking:

…, did you already run this on our source repo … ?

Yes.
:thought_balloon: Under which circumstances would you dare to try an adjusted Perl command variant out on the source files in another test repository?

I am not sure to follow what you suggest. I think we use these often to do
inplace operations with numpy and if we don't it's to have a copy (on
purpose).
do I miss something?

:thought_balloon: Would you like to reconsider any computation details where special programming interfaces like NumPy would be also affected?

sorry I don't get what you have in mind

As @agramfort and @drammock have already explained, we cannot blindly replace statements like x = x + 1 with x += 1, because their behavior is different. I'm closing this discussion, but if you can explain what exactly you would like to change and why you think this is a good idea we're of course open for any input.

:thought_balloon: Do you care which assignment targets may use in-place operations?

…, because their behavior is different. …

Can you accept the explanation from the Python documentation?
“…
In the augmented version, x is only evaluated once. Also, when possible, the actual operation is performed in-place, meaning that rather than creating a new object and assigning that to the target, the old object is modified instead.
…”

… and why you think this is a good idea we're of course open for any input.

:thought_balloon: Do you accordingly expect positive effects for the software run time characteristics?

it's not a matter of speed but of correctness.
when we do
def func(x):
x = x + 1
return x
and x is a numpy array we don't modify the input parameter. Blindly
changing:
def func(x):
x += 1
return x
would be a disaster as now the function alters its parameters.

… would be a disaster as now the function alters its parameters.

I suggest to reconsider such a view once more.
:thought_balloon: How many factors do still hinder the wider application of functionality which became generally available with Python 2?


Added Troubleshooting Step About Local Database

I found out that in https://github.com/HubPress/hubpress.io/issues/87, you can only resync HubPress on Mobile if you clear app data and cache. This addition may help others with the same issue, until a more permanent fix can be implemented.

:+1:


Could Not Post Ad

Receive the error:
kijiji_repost_headless\__main__.py:67: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
  data = yaml.load(f)
Image upload success on try #1
Image upload success on try #1
Image upload success on try #1
Image upload success on try #1
Image upload success on try #1
Traceback (most recent call last):
  File "C:\Users\windowshopr\AppData\Local\Programs\Python\Python36\lib\runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "C:\Users\windowshopr\AppData\Local\Programs\Python\Python36\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "kijiji_repost_headless\__main__.py", line 195, in <module>
    main()
  File "kijiji_repost_headless\__main__.py", line 51, in main
    args.function(args)
  File "kijiji_repost_headless\__main__.py", line 95, in post_ad
    api.post_ad_using_data(data, image_files)
  File "kijiji_repost_headless\kijiji_api.py", line 204, in post_ad_using_data
    raise KijijiApiException("Could not post ad.", resp.text)
kijiji_api.KijijiApiException: Could not post ad.
See kijijiapi_dump_20190509T084704.html in current directory for latest dumpfile.

Running Python3 on windows 10. Dump file doesn't load. Any ideas?

Having the exact same problem, and not sure how to diagnose.  Dump file is busted because of XCORS

I believe this is a duplicate of Issue #112

"YAMLLoadWarning" is not related to "kijiji_api.KijijiApiException: Could not post ad."
You can see the warning doesn't stop the process.  I've opened an issue #139 to track that seperately.
It's pending a PR.

The dump file is just an HTML text file - you should be able to open it in a browser and view it. Check to see if the Kijiji page shows any error text in red somewhere on the page. This may happen if Kijiji expected to get an additional ad parameter that wasn't passed to it. Some ad postings have additional radio buttons or text fields that aren't automatically included in the yaml ad file.

It's been a while since #139 has been merged. I'm closing this for now. Feel free to re-open if you're still facing the same issue @windowshopr


sync mainnet error (version 1.5.0)

Hey guys:
I'm trying to sync cardano network using cardano-rosetta(ver.1.5).
When I sync testnet, everything is fine. my instance can catch up to the latest block.
But when I'm trying to sync mainnet, I got failed, twice.
Here is my operations:

Start a clean EC2 instance on AWS.
install docker (the latest version)
start node with this command:

docker run \
  --name cardano-rosetta \
  -p 8080:8080 \
  -v cardano-rosetta:/data \
  --shm-size=2g \
  inputoutput/cardano-rosetta:1.5.0

It worked fine in the beginning. but after a night, sync stopped at height 5027522,
//request
//........:8080/network/status
{
    "network_identifier": {
        "blockchain": "cardano",
        "network": "mainnet"
    }
}
//response
{
    "current_block_identifier": {
        "index": 5027522,
        "hash": "2da879ab54e31c8b33dc4e663b961dfc59387c2bbad6317be79f50884d4fbb27"
    },
    "current_block_timestamp":<PHONE_NUMBER>000,
    "genesis_block_identifier": {
        "index": 0,
        "hash": "5f20df933584822601f9e3f8c024eb5eb252fe8cefb24d1317dc3d432e940ebb"
    },
    "peers": [
        {
            "peer_id": "relays-new.cardano-mainnet.iohk.io"
        }
    ]
}

I checked the log, and found the following error.
[db-sync-node.Subscription:Error:45722] [2021-11-21 08:49:19.12 UTC] Identity Connection Attempt Exception, destination LocalAddress "/ipc/node.socket" exception: Network.Socket.connect: <socket: 22>: does not exist (No such file or directory)
[db-sync-node.ErrorPolicy:Warning:6] [2021-11-21 08:49:19.12 UTC] IP LocalAddress "/ipc/node.socket" ErrorPolicySuspendPeer (Just (ConnectionExceptionTrace Network.Socket.connect: <socket: 22>: does not exist (No such file or directory))) 20s 20s
[db-sync-node.Subscription:Warning:64] [2021-11-21 08:49:19.15 UTC] Identity Failed to start all required subscriptions
[db-sync-node.Subscription:Notice:64] [2021-11-21 08:49:20.33 UTC] Identity Restarting Subscription after 1.210283857s desired valency 1 current valency 0

I noticed the same issue has been raised on version 1.2.1, and marked as solved. But I'm working on version 1.5.0

this might caused by short of memory.
Some process was killed for OOM error. even the ssh server process.
After update memory of EC2 instance. everything goes smoothly so far.


Fixed #35667 -- Improved deprecation warning handling by replacing stacklevel with skip_file_prefixes.

Trac ticket number

ticket-35667
Branch description
Improved the handling of deprecation warnings by replacing the use of stacklevel with skip_file_prefixes. This change ensures that deprecation warnings accurately reference the offending call site, enhancing clarity and maintainability. The update leverages the new warnings.warn(skip_file_prefixes: tuple[str] | None) feature introduced in Python 3.12, and includes a fallback mechanism for compatibility with Python 3.11.
Checklist

[x] This PR targets the main branch.
[x] The commit message is written in past tense, mentions the ticket number, and ends with a period.
[x] I have checked the "Has patch" ticket flag in the Trac system.
[x] I have added or updated relevant tests.
[ ] I have added or updated relevant docs, including release notes if applicable.
[ ] I have attached screenshots in both light and dark modes for any UI changes.

I plan to apply the related methods to the file once the review is mostly complete.

I think this basically looks right as a way forward, given that we're gonna be waiting a while for prefixes otherwise. @JaeHyuckSa I think you should do the work to change up all the places that need changing up with this version, so that the PR could be mergable if everyone else agrees.
@charettes you might have an opinion on this, given you were dealing with this issue as well and had the previous stack level work. This version, unlike a general "find stack level" function, would avoid extra work in 3.12+, which feels nice. But maybe it's a bit too awkward.

I think this basically looks right as a way forward, given that we're gonna be waiting a while for prefixes otherwise. @JaeHyuckSa I think you should do the work to change up all the places that need changing up with this version, so that the PR could be mergable if everyone else agrees.
@charettes you might have an opinion on this, given you were dealing with this issue as well and had the previous stack level work. This version, unlike a general "find stack level" function, would avoid extra work in 3.12+, which feels nice. But maybe it's a bit too awkward.

@rtpg Thank you for the reminder and for reviewing this PR! I actually went ahead and completed all the necessary work on this already.
You can check it out in the PR here: https://github.com/django/django/pull/18595
To ensure a smooth review process, I’ve held off on applying this change across all files for now. I plan to continue once it seems like this method has been reviewed thoroughly enough to proceed with further updates.

@nessita in the end I think we should use skip_file_prefixes in cases where we emit a warning but it's hard or impossible to provide a stacklevel that will adequately point at a call site that is actionable by the users. On Python > 3.12 I'm not entirely convinced it's worth providing a shim but I could see it being useful particularly in the case that are impossible to to emulate with stacklevel.
To give concrete examples here, when I think of hard to emulate via stacklevel I think of cases like _check_deprecated_find_param
https://github.com/django/django/blob/3d819e23240ab6f903eb60d76237628981fd52b5/django/contrib/staticfiles/finders.py#L21-L43
and when I think of impossible I think of cases like BaseCache.validate_key
https://github.com/django/django/blob/3d819e23240ab6f903eb60d76237628981fd52b5/django/core/cache/backends/base.py#L111-L118
and the warning emitted when a database query is attempted before apps are loaded
https://github.com/django/django/blob/3d819e23240ab6f903eb60d76237628981fd52b5/django/db/backends/utils.py#L66-L67
Most of impossible cases today do not use stacklevel for obvious reasons but would the ones that benefit the most from skip_file_prefixes on Python 3.12. For example, the warning emitted when attempting to perform queries at module level time doesn't point the problematic code today unless you elevate the warning to an error.

Most of impossible cases today do not use stacklevel for obvious reasons but would the ones that benefit the most from skip_file_prefixes on Python 3.12. For example, the warning emitted when attempting to perform queries at module level time doesn't point the problematic code today unless you elevate the warning to an error.

Thank you @charettes for your comments, and sorry because my example was incomplete: stacklevel could be None and should be handled accordingly by not passing at all (on Python <3.12). I think this would solve the impossible cases, but I do fail to see why this would be an issue for the hard case? I'm definitely missing something!
Assuming I'm not completely off track here, and after as second look, I think I would much rather an "abstraction layer" to emit warnings instead of a helper to calculate kwargs for warnings.warn. I mean something like this:
def emit_warning(msg, category=None, stacklevel=2):
    # TODO: Remove stacklevel when dropping support for PY311.
    if PY312:
        caller_frame = inspect.stack()[1]
        caller_file = caller_frame.frame.f_globals.get("__file__")
        kwargs = {"skip_file_prefixes": (os.path.dirname(caller_file),)}
    elif stacklevel is not None:
        kwargs = {"stacklevel": stacklevel + 1}
    else:
        kwargs = {}

    warnings.warn(msg, category, **kwargs)

I've pushed this to a PR with passing tests in Python 3.11 but with 3 failures in Python 3.13 which I haven't had the time to debug yet... We may better validate the approach before digging into that.
If we were to pursue a solution like this, we should split the work in two commits:

the introduction of the emit_warning helper, and
the support for skip_file_prefixes on Python 3.12+


FormView - Use new updateValue, value and formattedValue APIs

Closes Apollo 116
Note this PR affected by some known issues:
Apollo 233
Apollo 240

Are value and formattedValue guaranteed to be in sync with each other?

As far as I've seen so far, yes they are.

I think I've responded to all of your feedback. No code changes so far. Ready for re-review.


Fix SessNoopStore

Errors other than ErrNoSessionData are not handled properly: program just hangs

Ok, ErrNoSessionData seems better here.

program just hangs
But under what conditions? Currently SessNoopStore is used to open secondary connections. They use the same session with the main connection, so SessNoopStore.Load() will not be called. Or will it?

program just hangs

But under what conditions? Currently SessNoopStore is used to open secondary connections. They use the same session with the main connection, so SessNoopStore.Load() will not be called. Or will it?

If SessNoopStore is used to open primary connection (with NewTGClientExt in particular)


[DO NOT MERGE] Re-write Storage

This is a rough-cut to sanity check the concept. Docstrings and full tests still missing.
New:

client.Storage is an abstract base class.
locked_storage.LockedStorage provides locking based on context managers and defaults to threading.Lock.
locked_storage.threadsafe is a class-level decorator to provide thread safety. This is applied to FileStorage and KeyringStorage.

Changed:

All Storage subclasses have been updated to use the new base class.
file.Storage renamed to file_storage.FileStorage.
keyring_storage.Storage renamed to keyring_storage.KeyringStorage.
django_orm.Storage renamed to django_orm.DjangoOrmStorage.

Questionable changes
As mentioned in a comment on #344, Credentials has the unfortunate behavior of using the Storage's lock to prevent concurrently refreshing the credentials. IMO, Refresh locking should be handled as a separate concern. For now, Storage implements a no-op lock().

@dhermes I tried to keep this small, but I wanted to make sure all existing tests still pass. Sorry if I missed the mark.

Ha. 13 files != small Which mark did you hope you hadn't missed?

I wanted to land somewhere between "small" and "please don't make me look at this".

IMO, Refresh locking should be handled as a separate concern

How should it be handled? The user never even sees a _refresh occur, it just happens automatically on a 401 from the server.

Okay, point of contention brought up by myself and @waprin. I could use some thoughts here.
I initially thought locking was only to prevent concurrent calls to get, set, and delete. It seemed better to pull locking into a separate concern from storage. However, this is not the case as locking is also used to prevent concurrent refreshing of the access token.
So, the previous design made these assumptions:

Storage is responsible for locking get, put, and delete.
Credentials are responsible for holding the storage lock during refresh.
A Storage instance is inherently designed to store a single Credentials instance..
FileStorage and KeyringStorage made the incorrect assumption of always using threading.Lock and providing no clear way for users to override them.
Other storage classes provided no way to provide locking.

I don't consider 1, 2, and 3 bad, but I'm willing to reconsider if someone else has better ideas. I do consider 4 & 5 the core of the problem here.
So I think we should design the replacement to Storage to:

Accept a context manager for locking and default to a no-op context manager.
Provide the public interface get, put, delete, and lock. get, put, and delete are responsible for locking and then calling the respective private method.
Private methods _get, _put, _delete are implemented by sub-classes. I'm not a fan of this, but I'm struggling to come up with a better solution.
lock is a context manager used by Credentials.refresh to hold the lock during refresh.

So basically more or less what I have now just with absorbing LockedStorage into the base class.

I'm having a hard time following about the locks, but the thought of having one single lock that is used both within Storage and outside it does tickle some abstraction code smells to me. If Storage is just going to be an interface, it probably shouldn't make any specification other than "instances of this class must be safe for use from concurrent threads" or "instances of this class need not be safe for use from concurrent threads".
When we talk about some code being smart enough to want to ensure that only one credentials-refresh is going on, that seems smart but it also seems decoupled from the idea of locally storing and retrieving the credentials, and that decoupling, to me, suggests an independent lock.
What's the expected concurrent use of get, put, and delete that motivates a Storage-internal lock? Why should instances of Storage (for the moment considering just those three methods) have an internal lock?

I'm starting to see why other oauth libraries don't provide storage.

What's the expected concurrent use of get, put, and delete

If you think in terms of concrete storage classes, locking these methods individually is rarely needed. For example, database-backed storage classes don't need to this as the database itself handles the concurrency. The session-based storage for Flask, Django, and Bottle will use the framework's session object which in all cases is a context (thread/greenlet) local, so no need for locking there either. Local file storage may need this, though.
In terms of supporting locking during credential refresh, the use case here is that there are multiple processes (threads, processes, instances, etc.) that are using the same set of credentials. Imagine a multithreaded program that downloads all of the user's files from Google Drive. If this runs for more than an hour the credentials will be invalid and need to be refreshed. The first thread to notice this should refresh and store the credentials. The remaining threads will block until the refresh is done and then continue using the new credentials. Without the lock, each thread would end up refreshing the credentials.
Now that I'm getting a clearer picture of usage here, it seems that having storage just for the purpose of storing credentials seems pointless. You can do that with .to_json() and .from_json() and any database. It seems the purpose of storage is to ensure that refreshing credentials happen once and that all processes using those credentials can obtain the new access token.

FYI, oauth2lib does appear to do any locking. It just provides a way for you to specify a function to save the new credentials. link
from requests_oauthlib import OAuth2Session

def token_saver(token):
    # write to database.
    pass

client = OAuth2Session(
     client_id, token=token, auto_refresh_url=refresh_url,
     auto_refresh_kwargs=extra, token_updater=token_saver)

@jonparrott Sorry I thought we were on the same page about why Credentials.set_store and Credentials._refresh needed to be best pals.

@dhermes just when I think I understand this library it beats me over the head.
I'm not sure where to go from here. My proposal of adding a no-op lock() to the Storage base class seems like the easiest way to go forward without changing the fundamental relationship of _refresh and Storage.

Yeah. I think you should leave this alone for now, get your original PR merged and then we discuss the plan outside of that design.

The LockedStorage part of my original PR is the issue. Should I just merge it's capabilities into the base class in the other PR and we can continue from there? Seems like the best way forward.

@nathanielmanistaatgoogle WDYT?

@jonparrott: yes, I think merging LockedStorage into the base class in the other pull request is a fine way forward for now.


Venue Safety - risks / fire / evacuation plans

Description:
To ensure the safety and compliance of all venues used for the in-person sessions, we need to thoroughly review fire safety and evacuation plans. This task involves gathering fire safety documentation from each venue, identifying any specific risks or requirements, and compiling a comprehensive fire safety guide for our communities. Accessibility will also be investigated to guarantee that all participants can safely access and evacuate the venues.
Acceptance Criteria:

[ ] Review all provided venue documents to locate fire safety and evacuation information.
[ ] Email venues to request missing or unclear fire safety and evacuation information.
[ ] Compile a document outlining general fire safety compliance requirements for all venues.
[ ] Identify specific fire safety requirements and risks for each venue.
[ ] Investigate the accessibility of each venue, ensuring it meets safety and inclusion standards.
[ ] Distribute fire safety and evacuation plans to each community using the venues and add to the appropriate Canvas.
[ ] Provide an estimated timeline for completing the fire safety review and documentation process.

London Office:

Received Fire Escape Plan from Ben Wintour (Integrated Spaces)
Updated 14 Bedford Row Office Guidelines document
Updated Venues Management Spreadsheet for internal use
Updated london-office-14-bedford-row-holborn canvas
Updated ITP Slack: London Office Holborn

Aston University:

Contacted Tony Beaumont for Fire Escape Plan & Accessibility. He sent me an Accessibility doc from 2017
Tony is checking if Aston uni can send us a more up-to-date version for Accessibility and if there is a Fire Escape Plan

DF Capital - Manchester

Contacted Tony Reilly-Romo and Vicki Marsh (both DF Capital). Vicki will send documents

Created a Project Plan Document
DF Capital - Received documents. Saved in Shared drives and updated in Venues Management - Internal Spreadsheet.
Sheffield Learn Create Sell, Zak contacted. He will send an email with documents and information next week 28.10
London - Brixton (new building). Added to both Venues Management - Internal spreadsheet. Requested Ben Wintour for Fire Escape Plan and Accessibility information.
Manchester SeaSaw building: No Action taken yet

DF Capital: Need to update #north-west-volunteers canvas.
DF Capital: Do I need to copy the same information in #north-west?

@cynthimicallef101  You can link one canvas to multiple channels

@cynthimicallef101 are there any updates on this?

I am blocking time for this tomorrow (Tuesday) morning.

Thanks @cynthimicallef101
Please could all remaining venue information be gathered by Friday the 15th November

@AmyCYF

DF Capital information updated in ITP Slack: #North-West Volunteer Canvas
Strathclyde University: reminded Katie Bharaj to send Fire safety and access information
Sheffield: Learn, Create, Sell: reminded Zak to send Fire safety and access information

@cynthimicallef101 I created tracking tickets for each of the associated tasks for this ticket.
Regarding the below:
Strathclyde University:  I saw Katie Bharaj replied and said she could talk you through it. Have you set up a call to get this information? ONce she has talked you through it please put the details on the  Scotland canvas.
Sheffield: Learn, Create, Sell: I remember Liliana saying it was best to call Zak - have you called him for this information? Another option is to ask CJ (the Sheffield volunteer) if there is anything on site that we can reference (such as a fire escape plan)


NIFI-3739: Added ConsumeKafkaRecord_0_10 and PublishKafkaRecord_0_10 …

…processors
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@joewitt agreed on all fronts. Will push a new commit.

can we update this message "ConsumeKafkaRecord_0_10[id=b28c1bea-015b-1000-db37-08c3c0beaeee] Failed to parse message from Kafka using the configured Record Reader. Will route message as its own FlowFile to the 'parse.failure' relationship: org.apache.nifi.schema.access.SchemaNotFoundException: Schema Encoding appears to be of an incompatible version. The latest known Protocol is Version 1 but the data was encoded with version 80
"
to indicate that either the encoded version is a given value or the data is not encoded in this form at all.

one more observation and cannot recall if I mentioned this yet.  But here is some original JSON we'd get from provenance.  This is before turning into avro and then turning back into json.
{code}
{
"eventId":"3ddbed75-c436-4112-a2bd-bbdd05320b23",
"eventOrdinal":13720400,
"eventType":"CREATE",
"timestampMillis":1493439571667,
"timestamp":"2017-04-29T04:19:31.667Z",
"durationMillis":-1,
"lineageStart":1493439571667,
"componentId":"b259f36c-015b-1000-3ca6-c664e156cdf7",
"componentType":"GenerateFlowFile",
"componentName":"GenerateFlowFile",
"entityId":"2ab3c2d8-cb45-44ae-bd45-72080aff3e78",
"entityType":"org.apache.nifi.flowfile.FlowFile",
"entitySize":0,
"updatedAttributes":
{
"path":"./",
"uuid":"2ab3c2d8-cb45-44ae-bd45-72080aff3e78",
"filename":"464576540850588"
},
"previousAttributes":{},
"actorHostname":"<IP_ADDRESS>",
"contentURI":"http://<IP_ADDRESS>:8080/nifi-api/provenance-events/13720400/content/output",
"previousContentURI":"http://<IP_ADDRESS>:8080/nifi-api/provenance-events/13720400/content/input",
"parentIds":[],
"childIds":[],
"platform":"nifi",
"application":"NiFi Flow"
}
{code}
Here is the after avro and then back to json view
{code}
{
"eventId" : "edf16cc9-b50d-4cbb-9356-58eb4cf8fd3e",
"eventOrdinal" : 13585491,
"eventType" : "CREATE",
"timestampMillis" : "2017-04-29 04:18:50",
"durationMillis" : -1,
"lineageStart" : "2017-04-29 04:18:50",
"details" : null,
"componentId" : "b259f36c-015b-1000-3ca6-c664e156cdf7",
"componentType" : "GenerateFlowFile",
"componentName" : "GenerateFlowFile",
"entityId" : "ef12f52c-4ae4-46be-bc45-698200f08e54",
"entityType" : "org.apache.nifi.flowfile.FlowFile",
"entitySize" : 0,
"previousEntitySize" : null,
"updatedAttributes" : {
"path" : "./",
"filename" : "464535310815392",
"uuid" : "ef12f52c-4ae4-46be-bc45-698200f08e54"
},
"previousAttributes" : { },
"actorHostname" : "<IP_ADDRESS>",
"contentURI" : "http://<IP_ADDRESS>:8080/nifi-api/provenance-events/13585491/content/output",
"previousContentURI" : "http://<IP_ADDRESS>:8080/nifi-api/provenance-events/13585491/content/input",
"parentIds" : [ ],
"childIds" : [ ],
"platform" : "nifi",
"application" : "NiFi Flow",
"transitUri" : null
}
{code}
Notice timestamp millis.  Seems like we should let json and csv writing use the timestamp like it would be in an avro 'timestamp-millis' sort of way rather than a formatted date/time string.  We'd want to do this consistently on reading and writing.  The current default changes its representation i think and makes it a bit tougher to do math with.

@joewitt agreed. Pushed a new commit.

@markap14 can you please squash at this point and rebase with master (now conflicts).  Thanks

ok i think we're there now.  Will merge shortly.  +1

@joewitt excellent! Thanks for such a diligent review & testing - you're certainly keeping me on my toes! ;-)


Editor window does not activate when breakpoint hit.

 Must manually find window and breakpoint.

Window should come to front/activate (if open) or open and activate if not opened. Line containing current breakpoint should be visible in the editor window.

Duplicate of https://github.com/Microsoft/vscode/issues/21111

Not a duplicate of 21111. Issue 21111 specifies debugging two apps at the same time. I am only debugging a single application.

Ok, let's reopen to investigate

@JeffJustJeff works for me on my win10 machine. It nicely blinks in the status bar as being activated.
Can you please try reproducing this behavior with our smoke test application in the following 3 steps

clone https://github.com/Microsoft/vscode-smoketest-express
npm install
open in vscode, set breakpoint in index.js line 6, start debugging
open your browser at localhost:3000
does vscode get nicely activated?

If still does not work then it might be an electron issue on your WinNT

Closing until more data is provided. Once we have more information I can reopen to continue investigating


[vicuna.py] Keep past key values on device

The past key values are only used within the models themselves and can be kept on device. For vulkan int4, this gives 44 tok/s (for the first prompt) and settles at around 26 tok/s on 7900xtx.

Failure looks unrelated
RuntimeError: Failed to import transformers.models.llama.modeling_llama because of the following error (look up to see its traceback):
Failed to import transformers.generation.utils because of the following error (look up to see its traceback):
api_export.__init__() got an unexpected keyword argument 'allow_multiple_exports'

Is there someone who knows whether this is fine?

Ok looks like everything is throwing this failure. I'm just going to merge this then.


Can't find uncommon pokemon

Expected Behavior
Find and catch uncommon pokemon
Actual Behavior
When first starting my bot, I sometimes check Go Radar app, which recently told me of a Snorlax; I obtained the correct lat & long data and started the bot in that location, but it cannot find it. I also decreased the walk speed to 1-5 (min-max) but still nothing.
This same process works with pokemon like dratini, growlithe, Ivysaur, Wartortle (which are those I also tried the same "trick").
Is there any particular config to find uncommon pokemon?

I made some more test, and also tried increasing refresh cell rate (https://github.com/PokemonGoF/PokemonGo-Bot/issues/5409), but Snorlax is not found... Looks like an api issue?

It could've been a fake Pokemon. These exist, because Niantic places uncommon and rare Pokemon on the server for scanners, maps, radars, etc to pick up, but they're actually not there. GoRadar retrieves information from users using te Jailbreak tweak Poke Go++. That tweak retrieves game data from the server. If you are playing, and see an uncommon or rare Pokemon show up on the side, tap it, and when it arrives at where the server said it was, it could've just been a bot lure.

Ok, thank you


docs: Update events.md to include reference to createEventBuilder

I couldn't find any reference to createEventBuilder anywhere in the docs site, and it took me spelunking in the Console repo to find out what i was missing creating Events
I don't really know the full ins and outs of how createEventBuilder worked so i added it as an example here rather than give a full section for it.

Also, while i'm here, we seem to have found a weird edge case here when trying to publish multiple events in a Promise.all, see the discussion on discord. but it breaks down to creating the payload inside the async loop sends the same payload 3 times, but creating the payload and then looping to publish works fine.
// This example ends up executing the event handler lambda function 3 times with the same payload

async function publishEvent () {
  await Events.Created.publish({
    id: crypto.randomUUID()
  })
}

export async function produceEvents () {
  await Promise.all([
    publishEvent(),
    publishEvent(),
    publishEvent()
  ])
}

whereas this example works:
// this example works as expected, where the event handler lambda function runs 3 times, but each time with a different event

async function publishEvent (eventPayload) {
  await Events.Created.publish(eventPayload)
}

export async function produceEvents () {

  const eventPayloads = [
    { id: crypto.randomUUID() },
    { id: crypto.randomUUID() },
    { id: crypto.randomUUID() },
  ]

  await Promise.all(eventPayloads.map(payload => publishEvent(payload)))
}

thanks to @srodriki (can't find their github handle, sorry) for helping identify the issue
@srodriki thought this was unlikely to be a SST issue, but i thought it might be nice to add a warning somewhere in this doc (or perhaps somewhere else?) explaining the edge case and how to avoid?

We are transition this repo to https://github.com/sst/v2 and are closing this issue for now. If it is still relevant please reopen it there - sorry for the trouble


What is AMAZON_ASSOC_TAG

amazon = AmazonAPI(AMAZON_ACCESS_KEY, AMAZON_SECRET_KEY, AMAZON_ASSOC_TAG)

It's a unique identifier required by Amazon.  You need to sign up and get your own.  Check the Amazon docs:
http://docs.aws.amazon.com/AWSECommerceService/latest/DG/AssociateTag.html

so where I can find that ASSOC_TAG


Hide List with .Skip(0)

Instead of yielding the elements in a foreach loop, zero elements are skipped. Technically the result is the same with the benefit that the LINQ implementation can internally generate a type that keeps track of count of the enumerable. Consecutive operators can benefit from that knowledge.

Please add a unit test asserting that Skip(0) won't be optimized into a nop in the future. I like how the name Hide is intention revealing, what is it's disadvantage?

I've added a unit test to check that the internal list gets really hidden.


Update

I updated dependencies to latest versions, added some useful scalac options, marked BrowserWindow.loadUrl as deprecated and created BrowserWindow.loadURL

That looks good. Why is loadUrl deprecated in favor of loadURL?

I don't know, but if you look at the documentation, there's only loadURL() method.

in that case, let's remove loadUrl all together rather than deprecate it.

Great, thanks for your contribution!


Example 1b Compilation fails

Hi,
I'm trying to run the example with sbcl and sdl2 from the Ubuntu 13.10 repository. When I compile it I get the following error. Example 1 does not work either
CL-USER> (ql:quickload :cepl)
To load "cepl":
Load 1 ASDF system:
cepl
; Loading "cepl"
...................
(:CEPL)
CL-USER> (cepl:repl)
CEPL-REPL

NIL
CEPL>
; compiling file "~/quicklisp/local-projects/cepl/examples/1b.lisp" (written 22 MAR 2014 11:42:59 AM):
; file: ~/quicklisp/local-projects/cepl/examples/1b.lisp
; in: DEFPIPELINE PROG-1
;     ((VERT VERT-DATA))
;
; caught ERROR:
;   illegal function call
;     (LET ((LERP-VALUE (/ (Y GL-FRAG-COORD) 500.0)))
;       (OUT OUTPUTCOLOR (MIX THE-COLOR (VEC4 0.2 0.2 0.2 1.0) LERP-VALUE)))
;
; note: deleting unreachable code
;     (:FRAGMENT
;      (LET ((LERP-VALUE (/ # 500.0)))
;        (OUT OUTPUTCOLOR (MIX THE-COLOR (VEC4 0.2 0.2 0.2 1.0) LERP-VALUE))))
;
; note: deleting unreachable code
;     (POS VERT)
;
; note: deleting unreachable code
;
; caught ERROR:
;   READ error during COMPILE-FILE:
;
;     Symbol "COLLECT-EVENT-TYPES" not found in the SDL2 package.
;
;       Line: 27, Column: 52, File-Position: 1090
;
;       Stream: #<SB-SYS:FD-STREAM
;                 for "file /home/jonas/quicklisp/local-projects/cepl/examples/1b.lisp"
;                 {1004CE2603}>
;
; compilation unit aborted
;   caught 1 fatal ERROR condition
;   caught 2 ERROR conditions
;   printed 3 notes
; compilation aborted after 0:00:00.015
5 compiler notes:
/home/jonas/quicklisp/local-projects/cepl/examples/1b.lisp:228
error: illegal function call
/home/jonas/quicklisp/local-projects/cepl/examples/1b.lisp:350
note: deleting unreachable code
/home/jonas/quicklisp/local-projects/cepl/examples/1b.lisp:339
note: deleting unreachable code
/home/jonas/quicklisp/local-projects/cepl/examples/1b.lisp:276
note: deleting unreachable code
/home/jonas/quicklisp/local-projects/cepl/examples/1b.lisp:1091
read-error: READ error during COMPILE-FILE:
Symbol "COLLECT-EVENT-TYPES" not found in the SDL2 package.
Line: 27, Column: 52, File-Position: 1090

Stream: #<SB-SYS:FD-STREAM
          for "file /home/jonas/quicklisp/local-projects/cepl/examples/1b.lisp"
          {1004CE2603}>

OH damn, I am so sorry I didnt see this issue. Jesus I gotta check this more. Well if you are interested I have a big new release coming in the next couple of weeks. Total rework of gpu function definition, pipeline composing, support for UBO's new texture sampling techniques plenty of upgrade to the compiler etc.
Thanks for your interest in the project, and sorry I'm so crap at checking this stuff!


[Constraint solver] Use a constraint system to apply all function builders

When type checking the body of a function declaration that has a function
builder on it (e.g., @ViewBuilder var body: some View { ... }), create a
constraint system that is responsible for constraint generation and
application, sending function declarations through the same code paths
used by closures.

@swift-ci please smoke test

@swift-ci please test source compatibility


libunwind-sys fails to compile on macOS

Output of cargo build:
error: failed to run custom build command for `unwind-sys v0.1.3`

Caused by:
  process didn't exit successfully: `/Users/jordydickinson/Documents/Projects/geode/runtime/target/debug/build/unwind-sys-5d5614cc26fe5642/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-env-changed=LIBUNWIND_GENERIC_NO_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64-apple-darwin
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64_apple_darwin
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG
  cargo:rerun-if-env-changed=LIBUNWIND_GENERIC_STATIC
  cargo:rerun-if-env-changed=LIBUNWIND_GENERIC_DYNAMIC
  cargo:rerun-if-env-changed=PKG_CONFIG_ALL_STATIC
  cargo:rerun-if-env-changed=PKG_CONFIG_ALL_DYNAMIC
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64-apple-darwin
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64_apple_darwin
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64-apple-darwin
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64_apple_darwin
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64-apple-darwin
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64_apple_darwin
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR

  --- stderr
  thread 'main' panicked at /Users/jordydickinson/.cargo/registry/src/index.crates.io-6f17d22bba15001f/unwind-sys-0.1.3/build.rs:11:50:
  called `Result::unwrap()` on an `Err` value: `PKG_CONFIG_ALLOW_SYSTEM_CFLAGS="1" PKG_CONFIG_ALLOW_SYSTEM_LIBS="1" "pkg-config" "--libs" "--cflags" "libunwind-generic"` did not exit successfully: exit status: 1
  error: could not find system library 'libunwind-generic' required by the 'unwind-sys' crate

  --- stderr
  Package libunwind-generic was not found in the pkg-config search path.
  Perhaps you should add the directory containing `libunwind-generic.pc'
  to the PKG_CONFIG_PATH environment variable
  No package 'libunwind-generic' found

  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

You need to have libunwind installed. I don't believe it supports macOS.

From what I've read, macOS has its own libunwind based on LLVM's libunwind. I've successfully modified the build scripts to compile using macOS's version of libunwind, which links with -lSystem and has include files in /usr/local/Cellar/libunwind-headers/201/include (when libunwind-headers is installed via Homebrew). But I don't know what the version number is (the Homebrew headers are version "201") so I can't set those cargo variables, and it appears macOS's version of libunwind doesn't support remote unwinding via the standard libunwind API, and the API it does support is only for processes on the same machine.


Rename mask_rom_epmp.S file so it doesn't overlap mask_rom_epmp.c

Duplicated C and assembly filenames causes confusion for autogenerated makefile rules.   Rename mask_rom_epmp.S file to not collide:
PR #10295
Also added autogeneration of header files in top level meson build so all headers are in one directory

Done in #10295


How the operator handles migration of StatefulSet from node to node

Hi team,
I'm planning to use this operator to manage over 10000 flink clusters on k8s. But I have one concern that is how the operator handles a running flink cluster when the node it runs on were not available, it seems without proper orchestration, it could result in data loss.

I think this is generally out of scope for the operator. This would be better handled by Flink's Kubernetes HA Services.

@nickcaballero Thanks Nick! I adopted the official flink operator which natively supports HA.

Better HA support will come soon as well for us. Thanks for raising this.


Dictionary key name consistency

We need consistent key names for dictionary outputs. This patch helps to make lbrynet's API consistent.
nouts should always be called nouts, not nOuts and n.
Key names are lower case separated by underscores.

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.

          1 Message

:book:
See http://keepachangelog.com/en/0.3.0/ for details on good changelog guidelines

  Generated by :no_entry_sign: Danger

return amount as string encoded decimal


Type annotations and models

Added more type annotations
Use E factory in models instead of extension code

Would you mind adding a return type annotation of -> str to the str and unicode methods of the Entry class in osctiny/utils/changelog.py

I was hoping you would not notice that oversight because __str__ and __unicode__ are kind of obvious, but it certainly would be most consequent. :+1: Done.

I have to admit that the use of ElementMaker is a bit tricky to understand, but I get it now and it does reduce some code duplication (if not total LOC, alas), so I'm fine with it.
LGTM!


previous identification/synonym solution

Publishing through an Occurrence Core you could put the synonyms in previousIdentifications (https://dwc.tdwg.org/terms/#dwc:previousIdentifications), but even better in terms of richness would be to include an Identification History extension (https://tools.gbif.org/dwca-validator/extension.do?id=dwc:Identification). That would allow you to capture richer information about the names, if desired, but more importantly, one per row in the extension, and multiple rows per Occurrence, if necessary. fyi @teleaslamellatus

https://dwc.tdwg.org/terms/#dwc:previousIdentifications


Netrw cannot write remote files (E382)

When editing a remote file using :e scp://user@host/file, netrw sets buftype=nofile which causes error E382 to be raised when trying to write changes. According to :h buftype, instead of using bt=nofile, netrw should use bt=acwrite.
I can replicate the issue with a fresh built version of vim isolated from the system runtime launched with /opt/vim/bin/vim -u NORC --cmd 'set nocompatible' and an empty ~/.vim. The exact steps to reproduce are as follows:

vim scp://<user>@<host>/<filepath> or :edit scp://<user>@<host>/<filepath>
:write
"E382: Cannot write, 'buftype' option is set"

A temporary workaround I have found is to manually :set bt=acwrite before any write or to write using :Nwrite. Note, that netrw will reset to bt=nofile as part of every write.

I encountered this myself as well - it seems the culprit commit is b0d45e7f5, which bumped up the netrw runtime files.

As a permanent workaround
autocmd BufRead scp://* :set bt=acwrite
can be added to vimrc

@tagwint

autocmd BufRead scp://* :set bt=acwrite
can be added to vimrc

To me this only solves it for the first write, after that the same problem appears again.

FWIW this workaround works indefinitely for me.

I've been using set bt= with the BufWritePost event and that's worked for me.

For me it took the combination of using set bt= with both the BufRead and BufWritePost events.  The BufRead takes care of when the file is opened and first read.  The BufWritePost takes care of all writes.

@gmackey

For me it took the combination of using set bt= with both the BufRead and BufWritePost events.

This did it for me, however the buffer closes after :w (which it also did before), which is sort of annoying.

I encountered this too, and lost my edit. (I did :xa but the remote file wasn't saved like before.)

Encountered this too while editing files under a samba directory.

+1

This has been driving me nuts.

try to get the most recent netrw version from Charles page http://www.drchip.org/astronaut/vim/index.html#NETRW
If this still happens, have a look at :h netrw-debug

I think this was a bug of Netrw v162 and it had many troubles. So Bram reverted it and now v156 is included in the vim repository. (I'm not sure this is fixed in v163b.)

v165b seems to be working fine for me. I had some issues with the version packaged with vim 8.0.1283

Okay, since this problem seems to be fixed upstream, I'll go ahead and close it. I suppose Charles will send an update soon, since netrw hasn't been updated in a while.

I face this problem when trying to save particular local files. If you are like me, you might only need to run :set bt= or :set buftype= command in vim to solve the problem once and for all for that particular file.

@imambungo
have you updated your netrw version and tested with that? http://www.drchip.org/astronaut/vim/index.html#NETRW

@chrisbra I never updated netrw manually, but I do update vim regularly. My vim version:
VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Mar 01 2020 17:17:52)

so please try with the latest development version, to provide feedback to the author @cecamp.

I've tried the latest development version, nothing happens. I think in my case the problem wasn't caused by netrw. For your information, I encountered the error (E382) when trying to save .vimrc and .bachrc, just these 2 files. I guess it was caused when I try to install some plugin, I don't know.

I face this problem when trying to save particular local files. If you are like me, you might only need to run :set bt= or :set buftype= command in vim to solve the problem once and for all for that particular file.

I think I just found the cause, it's related to #4738.
How to reproduce:

Open a file that has some URLs in it.
Try to save the file (it should work).
Try to open a URL with gx, encounter this behavior.
Open the file again, try to save it, encounter error E382.
Fix the error with :set bt=.
Repeat.


align images is missing?

I'm trying to run the collab at https://colab.research.google.com/github/tg-bomze/Face-Image-Motion-Model/blob/master/Face_Image_Motion_Model_(Photo_2_Video)_Eng.ipynb#scrollTo=cdO_RxQZLahB
but that gives an error during pulling for align.zip?
Cloning into 'first_order_model'...
remote: Enumerating objects: 259, done.
remote: Total 259 (delta 0), reused 0 (delta 0), pack-reused 259
Receiving objects: 100% (259/259), 72.13 MiB | 32.00 MiB/s, done.
Resolving deltas: 100% (131/131), done.
/content/first_order_model
curl: (7) Failed to connect to srv-file22.gofile.io port 443: Connection refused
--2021-04-11 22:30:33--  https://srv-file22.gofile.io/download/SUyfwc/vox-cpk.pth.tar
Resolving srv-file22.gofile.io (srv-file22.gofile.io)... <IP_ADDRESS>
Connecting to srv-file22.gofile.io (srv-file22.gofile.io)|<IP_ADDRESS>|:443... failed: Connection refused.
--2021-04-11 22:30:33--  https://srv-file22.gofile.io/download/SUyfwc/shape_predictor_68_face_landmarks.dat.bz2
Resolving srv-file22.gofile.io (srv-file22.gofile.io)... <IP_ADDRESS>
Connecting to srv-file22.gofile.io (srv-file22.gofile.io)|<IP_ADDRESS>|:443... failed: Connection refused.
--2021-04-11 22:30:33--  https://srv-file22.gofile.io/download/SUyfwc/align.zip
Resolving srv-file22.gofile.io (srv-file22.gofile.io)... <IP_ADDRESS>
Connecting to srv-file22.gofile.io (srv-file22.gofile.io)|<IP_ADDRESS>|:443... failed: Connection refused.
Archive:  align.zip
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of align.zip or
align.zip.zip, and cannot find align.zip.ZIP, period.

I'm not the author of that notebook, post this issue in the related repository.


build(main): release 1.2.1

:robot: I have created a release beep boop
1.2.1 (2024-09-21)
Documentation

Fix CHANGELOG.md (1aff623)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.2.1
:sunflower:


autosuggestions

Anyone have autosuggestions working with YADR?
I can't seem to get any suggestions whatever I do to try to enable it.

Working for me. We haven't changed anything in our code so unless a submodule broke for some reason (in which case nothing we could do as well), it must be something on your end.


Complete out-of-tree OpenThread build

I've been working recently on improving Zephyr/OpenThread integration at a build system level, and I faced a problem with complete out-of-tree build of OpenThread.
My goal is to build OpenThread completely out-of-tree (from Zephyr project build directory) so that the original repository remains intact. While it works perfectly fine to call the configure script and build the libraries from the external directory, I could not find a way to initiate the autotools with a bootstrap script from the outside. Is that even possible to call the bootstrap from the external directory, so that it produces any output into that directory? I'm not sure if it's the autotools limitation or do I simply miss something.

@rlubos, unfortunately, I am not aware of any way to perform ./bootstrap out-of-tree.

Thank you for the answer, I suppose we can close the issue then.


Day 1 code, Imputer issues

DeprecationWarning: Class Imputer is deprecated; Imputer was deprecated in version 0.20 and will be removed in 0.22. Import impute.SimpleImputer from sklearn instead.
warnings.warn(msg, category=DeprecationWarning)
I tried with both Imputer and SimpleImputer but its not working, can I get any advise how can i fix it

Here is a working example.
`import numpy as np
import pandas as pd
dataset = pd.read_csv('data.csv')
X = dataset.iloc[ : , :-1].values
Y = dataset.iloc[ : , 3].values
from sklearn.impute import SimpleImputer
imputer = SimpleImputer(missing_values = np.nan, strategy = "mean")
imputer = imputer.fit(X[ : , 1:3])
X[ : , 1:3] = imputer.transform(X[ : , 1:3])`
The class Imputer is deprecated and you need to use the new one SimpleImputer, if you want to suppress those warnings. Also, note that in SimpleImputer class 'axis' is not defined.

i used the new code but i get error below that i don't understand. Please help me understand.
ValueError                                Traceback (most recent call last)
 in
1 from sklearn.impute import SimpleImputer
2 imputer = SimpleImputer(missing_values = np.nan, strategy = "mean")
----> 3 imputer = imputer.fit(X[ : , 1:3])
4 X[ : , 1:3] = imputer.transform(X[ : , 1:3])
~/PycharmProjects/100_days_of_ML/venv/lib/python3.6/site-packages/sklearn/impute/_base.py in fit(self, X, y)
266         self : SimpleImputer
267         """
--> 268         X = self._validate_input(X)
269         super()._fit_indicator(X)
270
~/PycharmProjects/100_days_of_ML/venv/lib/python3.6/site-packages/sklearn/impute/_base.py in _validate_input(self, X)
238                 new_ve = ValueError("Cannot use {} strategy with non-numeric "
239                                     "data:\n{}".format(self.strategy, ve))
--> 240                 raise new_ve from None
241             else:
242                 raise ve
ValueError: Cannot use mean strategy with non-numeric data:
could not convert string to float: 'Male'


Please expose SkEncoder and derived classes

In Skia, we can use the SkJpegEncoder and other SkEncoder derived classes to tweak the options of the image encoders.
For example, we need to disable chroma subsampling when exporting high quality JPEGs.
However, these classes are not exposed in SkiaSharp.
Now it seems they are not exposed in the official Skia C API either, so maybe convincing Google to make these part of the C API would be a first step?
Thanks,
Peter

Ouch, this is already exposed through https://docs.microsoft.com/en-us/dotnet/api/skiasharp.skjpegencoderoptions?view=skiasharp-1.68.1
Closing

Have fun! Thanks for opening the issue and letting me know you are using this cool library!

Thanks! I'm actually evaluating SkiaSharp for a customer, a major player in the customized photo product printing business. We will be using SkiaSharp in the cloud (CPU rendering), using a linear colorspace rendering workflow (16-bit float per channel). So far so good!

That's good to hear! Feel free to open any issues when you find you need a feature or find some problems. I am going to make the the BEST library for all things graphics!


Latest Dockerfiles seem to have broken RewriteValve

I've been using the tomcat 8.5 dockers for some time, and started using the rewritevalve about a year ago to facilitate a migration.  It worked fine in 8.5.51, but when I upgraded to the latest 8.5.57, my rewrites stopped working.  The rewrite was getting applied (checking the access log, and my rewrite rules add a request parameter), but they always 404'ed.
Attached is a simple example, that I think reproduces the problem.  After building and running this docker, /examples works, and /placeholder gets rewritten to /examples, but 404s:
<IP_ADDRESS> - - [07/Aug/2020:20:39:15 +0000] "GET /examples HTTP/1.1" 302 -
<IP_ADDRESS> - - [07/Aug/2020:20:39:20 +0000] "GET /examples HTTP/1.1" 404 682
That's from the localhost_access log.  The first request was directly to /examples, the second to /placeholder.
tc8test.zip
I worked around this by modifying the old 8.5.51 Dockerfile to install 8.5.57.  My rewrites work in that image.
Also, it looks like my 8.5.51 Dockerfile was a modified version of about an 8.5.4x (pre-ddist) Dockerfile.  So, that's what I'm still using, modified more to work with 8.5.57.

Looking through the changes the only thing we've altered was present in the 8.5.50 and 8.5.51 images https://github.com/docker-library/tomcat/pull/181
https://github.com/docker-library/official-images/pull/7226

Found it.  The problem is webapps.dist.  The rewrites don't work if there's no ROOT  in webapps.  I added:
mv webapps.dist/ROOT webapps/
to the RUN in my Dockerfile, and now the rewrites work as expected (and as before).


Configure validation schema

This allows us to pass in custom validation rules for Twiglet

/dobby version minor

/dobby thank you!


citation key as template string

Absolutely great plugin, I was looking for something like this for years now.
Here's a small request: It would be really helpful when we could add the citation key as a template string into the Todoist title or comment.

Yeah, that's something I've meant to add in for myself but haven't gotten to yet. Shouldn't be too hard.

As a small update, I'm trying to figure out how to get this field from items. It only exists if you have better-bibtex/similar installed, so the documentation for its access is nonexistent (or at least I haven't found it yet).

I recently used this on a plugin of my own, and based it on this:
   getBBTCiteKey(item) {
        if (typeof Zotero.BetterBibTeX === 'object' && Zotero.BetterBibTeX !== null) {
            var bbtItem = Zotero.BetterBibTeX.KeyManager.get(item.getField('id')),
                bbtCiteKey = bbtItem.citekey;
            return bbtCiteKey;
        }
        return false;
    }

Ah, fantastic! Thank you; I'll incorporate this now.

Thanks again, @argenos! The template string key citekey is now included in v0.6.0.


PSR HTTP Message dependency

Hello Daniel,
I am trying to install this package as follows:
composer require odan/session:^6.0
I got the following error message:
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires odan/session ^6.0 -> satisfiable by odan/session[6.0.0, 6.1.0].
    - odan/session[6.0.0, ..., 6.1.0] require psr/http-message ^1 -> found psr/http-message[1.0, 1.0.1, 1.1] but the package is fixed to 2.0 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

When I installed using the --with-all-dependencies option, I see this happening:
Downgrading psr/http-message (2.0 => 1.1): Extracting archive

I am not familiar with the PSR HTTP Message 2.0 standard and what differences it imposes.  But I am wondering whether there is any impact to my application overall by downgrading.  From what I can tell, my applications dependency on the Google API library upgraded the http-message to 2.0 but it seems functional with 1.1 as well.
Thanks in advance for your feedback.

Hi! Thanks for reporting. This should be fixed now in the latest version 6.2.0.


Mips target

r? @therealprof
Hi all,
Willing to add some basic support for MIPS cores? This patch enables the Peripheral Singleton. I use svd2rust to create PACs for PIC32MX microcontroller.
Best regards,
Stephan

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @therealprof (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Add test if it is possible and update changelog, please.

if possible, add some svd2rust-regress targets as well, not necessary but appreciated.

svd2rust-regresstarget added.
CHANGELOG.md updated
Reviewing all the code motivated me to move the core access stuff to a new crate mips_mcu to separate it from the startup routine and the ISR tables. I changed my svd2rust patch accordingly.

Here also, please:
https://github.com/rust-embedded/svd2rust/blob/master/ci/script.sh

Here also, please:
https://github.com/rust-embedded/svd2rust/blob/master/ci/script.sh

done.

Update this line and squash commits:
https://github.com/rust-embedded/svd2rust/blob/6bfc843f7fb8d5ea91e85fdc04d6c37e4dda63fb/.github/workflows/ci.yml#L17

Looks good to me

Looks good to me

Yes, the tests passed. In the meantime, I created PACs that include Peripherals::take().
Would be great if you could merge it.

I still wait you squash commits.

I didn't realize that there was still an open point because I was not familiar with "squashing" commits. Now everything should be in one single commit.

bors r+

Cool. @burrbull, thanks a lot for your help and patience.


Repro bulk docs error, will pass when fixed

This is caused by a bug in pouchdb-wrappers not correctly passing new_edits in bulkDocs requests.

@marten-de-vries I'm in a bit of a hurry and didn't have time to figure out bazaar, but there is a bug in pouchdb-wrappers that is causing this, and it breaks replication when using transform-pouch. Could you apply this fix when you get a chance? The patch is here:
*** index.js	2015-04-26 09:48:16.000000000 -0400
--- index.js	2015-05-27 01:15:56.000000000 -0400
***************
*** 176,185 ****
--- 176,188 ----

  wrapperBuilders.bulkDocs = function (db, bulkDocs, handlers) {
    return function (docs, options, callback) {
      var args = parseBaseArgs(db, this, options, callback);
      //support the deprecated signature.
+     if ('new_edits' in docs) {
+       args.options.new_edits = docs.new_edits;
+     }
      args.docs = docs.docs || docs;
      return callHandlers(handlers, args, function () {
        return bulkDocs.call(this, args.docs, args.options);
      });
    };

Basically this issue pops up when we use the format:
db.bulkDocs({docs: docs, new_edits: false});

The replicator actually uses this format. Yes, I know, even though it is supposed to be deprecated. :stuck_out_tongue:

I should move Python-PouchDB & the plug-ins it includes to Github now Launchpad can just sync with a git branch for the Ubuntu package building... Anyway, updated pouchdb-wrappers.

First Travis test passes, so that's confirmation the patch works.

Thanks @marten-de-vries !


Feat/llama cpp

Description
Fix #1640

Related Issues

Checklist

[ ] Is this code covered by new or existing unit tests or integration tests?
[ ] Did you run make unit-testing and make integration-testing successfully?
[ ] Do new classes, functions, methods and parameters all have docstrings?
[ ] Were existing docstrings updated, if necessary?
[ ] Was external documentation updated, if necessary?

Additional Notes or Comments

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (34830a7) 80.33% compared to head (3c266c4) 65.47%.
 Consider uploading reports for the commit cce7be7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1753       +/-   ##
===========================================
- Coverage   80.33%   65.47%   -14.87%
===========================================
  Files          95      124       +29
  Lines        6602     8998     +2396
===========================================
+ Hits         5304     5891      +587
- Misses       1298     3107     +1809

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


added some integration tests

mmm, yes I think the coverage take into account the integration tests too. Just done a test, put the coverage back 100% in this PR and the coverage reach 100%. Might we want to ask if 100% coverage is too high as there may be code that does not need to be tested (have no business logic). I think HMRC require at leat 86% (but cannot be 100% sure of this), but I have see some other repo put it at 90%

mmm, yes I think the coverage take into account the integration tests too. Just done a test, put the coverage back 100% in this PR and the coverage reach 100%. Might we want to ask if 100% coverage is too high as there may be code that does not need to be tested (have no business logic). I think HMRC require at leat 86% (but cannot be 100% sure of this), but I have see some other repo put it at 90%

Did you take out the documentation exclude I added to the CodeCoverageSettings.scala as well as updating to 100% because otherwise that package won't be considered in the results?

yes, I run the tests without the integration test and did not pass the coverage. Put the integration test back and it pass the coverage


Error detected while processing function neomake#MakeHandler

Issue:

init.vim contents
let g:neomake_cpp_cpplint_maker = {
            \ 'exe': 'cpplint'
            \ }
let g:neomake_cpp_enabled_makers = ['cpplint']

:autocmd! BufWritePost,VimEnter *.java Neomake
:autocmd! BufWritePost,VimEnter,InsertLeave *.cpp Neomake

The error is random, it happens every so often.  Why would I get this error?

I think this is a duplicate of #291

OK, how do I apply the fix?  I have updated the plug-ins....

OK, thanks, I also use neovim and vim-plugged, but, I tend to update plug-ins often, so I think I will just leave my hand editing and watch for a merge.


Fullscreen causes monitor error to appear.

Changing to fullscreen causes my monitor to display: "Incorrect cable. Please use the dual link DVI cable that came with your monitor."
Alt+Enter or changing in Graphics/Sound options yields the same result.
I've tested with other games such as League of Legends, Osu, and Monster Hunter World. Those games run as expected in fullscreen.
Windows 10 64bit.
v.0.68.1

Poor quality image but you get the point. Message pops up over the fullscreen game.

In the graphics settings, pick a resolution that is the same size as your monitor when using fullscreen, as this will reduce issues with toggling fullscreen itself.
You may also try changing renderers: /Save/Preferences.ini -> VideoRenderers= and swap the choices
Alternatively, use borderless fullscreen and pick your fullscreen resolution. You may notice typical windowed input lag when doing this, however.

Changing res to monitor size works great, thanks a lot for the help. 👍


Introduce security group mechanism

Implement security groups that can have various constraints and can be assigned to weblinks.
Example constraints are

Source IP-Range
Query Parameter
HTTP Header

HTTP-Basic authentication was mentioned in a meeting too.

Query parameter and http header constraints are still outstanding, but since there is currently no need for that..


starting fire with stick is almost impossible

reported on discord.
note for myself:

actually, i know what this is - vanilla game had that hard-coded 500s embers when you start new fire, and allowed to cook on embers (as they where only 500s and one time).
when i've changed this, i've disable cooking on ember state (as it would be op) and also, removed that 500s embers on fire start - this is why stick is useless now
ok, have idea how to compromise it - on starting new fire, will force duration to be 10 minutes if auto-calculated is less - will fix this at quickest time.
this will allow to start fire with stick easily (as same as in vanilla) but will not increase it's fuel value.

resolved in v1.7.2


HIVE-25166: Query with multiple count(distinct) fails

What changes were proposed in this pull request?
Add GROUP__ID virtual column to all Aggregate. RelFieldTrimmer will remove it if it is not projected.
Why are the changes needed?
Some queries having count(distinct) are rewritten to Group by a single grouping set and a case expression is projected using GroupId.
Does this PR introduce any user-facing change?
Yes. Queries with multiple count(distinct) won't fail.
How was this patch tested?
mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=groupby_grouping_id1.q,count_dist_1.q -pl itests/qtest -Pitests

This is not the right approach now because it adds and extra column to shuffle which is not always necessary.
Closing this. See #2334 for fix the original issue.


DISTX-681: Switch DE templates to use temporaryStorage as ephemeral volumes

DISTX-681: Switch DE templates to use temporaryStorage as ephemeral volumes
This commit changes the instance type for compute and worker nodes of Data engineering cluster templates for AWS.

Shouldn't these changes be added to the 7.2.15 templates as well?

Will be adding to other templates going forward.

How does this show up on the UI? The default for the 'compute' group for these templates will be r5d.4xlarge, and ephemeral? OR does it still end up attaching some EBS volumes?

On UI Defaults for 'compute' will show "r5d.2xlarge"/"r5d.4xlarge" for non-ha/ha respectively with "ephemeral" Storage Type. EBS will not be attached.
On UI Defaults for 'worker' will show "r5d.2xlarge"/"r5d.4xlarge" for non-ha/ha respectively with "General Purpose (SSD)" Storage Type. EBS will be attached.

are you sure that this is the right ephemeral config ?

are you sure that this is the right ephemeral config ?

Yes, @doktoric

This is what I see on aws

This is what I see on aws

Yes, this was discussed with @shwethags and @rbalamohan

@doktoric @nadamdb  could you review? I don't see any current approval


#239: Split whitespace into multiple rules

Resolves #239.
WhitespaceTest has also been subdivided into multiple tests.

Current coverage is 89.11%

Merging #251 into master will increase coverage by +0.12% as of 6552c7b

Powered by Codecov. Updated on successful CI builds.

Would it possible for you to rename the branch to include the issue number?

Its possible, but I'd have to delete this pull request and create a new one


Deleted repetition "/// (We return the string)" from the Documentation of DartObject.toSymbolValue

…n of DartObject.toSymbolValue
Deleted "/// (We return the string)" from the documentation of DartObject.toSymbolValue because it is a repetition of the first sentence and it seems to be a residue of a internal temporary description. If the "/// (We return the string" was meant to stay here, then the closing ")" is missing.

Can we have a review, please?

Sorry for the delay, but thanks for bringing this to our attention. Unfortunately there's absolutely no signal when a PR is converted to a CL, so there's no automatic way for us to know when there's something waiting for a review. I have approved the CL and it is currently running on the bots. Assuming that the bots test it will be landed.