scheduling-framework.md: update Reserve and Unreserve descriptions

This doc update depends on the following API changes:

https://github.com/kubernetes/kubernetes/pull/92200
https://github.com/kubernetes/kubernetes/pull/92391

tl;dr: Reserve and Unreserve plugins have been merged into one plugin called a Reserve plugin. These plugins must implement both extension points. Also, since reserve extension points may fail, after https://github.com/kubernetes/kubernetes/pull/92391, we will trigger the unreserve extension point in the event of such failures. The extension points are no longer merely informational; they can have state changes + side effects such as allocating resources.
/cc @alculquicondor
/cc @ahg-g
/sig scheduling
/hold

Previous PR: https://github.com/kubernetes/website/pull/22035

I left some comments on the previous PR before it was closed, could you address them? Transfer the conversation here if needed.

/milestone 1.19

previous comments:

It shouldn't be used to allocate resources. Such actions are usually costly and should be done in PreBind.

Originally posted by @alculquicondor in https://github.com/kubernetes/website/pull/22035
Done.

We are actually packing information pertaining to the other extension points here.
It should be more like:
"If it succeeds, the binding routine is initiated, where Permit is the first extension point to run."

Originally posted by @alculquicondor in https://github.com/kubernetes/website/pull/22035
Done.
PTAL, thanks.

/approve

/assign @sftim

Switched to Reserve when referring to the method and Reserve (with no backticks) when referring to the phase/plugin name. To refer to the act of reserving something (the verb), "reserve" without the uppercase R is used.

lgtm (leaving the official one to @Huang-Wei)
Thanks!

Thanks @adtac !
/lgtm
ping @sftim for editorial review.

Based on https://github.com/kubernetes/website/pull/22038#issuecomment-656210330 plus (minimal) subsequent changes:
/lgtm

/hold cancel

/approve


3.5.6+: Workflow stuck Running when failed resource template

Pre-requisites

[X] I have double-checked my configuration
[X] I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
[X] I have searched existing issues and could not find a match for this bug
[ ] I'd like to contribute the fix myself (see contributing guide)

What happened/what did you expect to happen?
When running a workflow that includes a Kubernetes Resource step, if that step fails the workflow is stuck in Running phase even while using continueOn: error and continueOn: failed.
This issue started occurring when we upgraded from v3.4.8 to v3.5.8. I have confirmed the issue is not preset on v3.4.8.
Edit: on further investigation the issue seems to have started since v3.5.6 (v3.5.5 is working fine)
I have reproduced the issue using the latest image for the controller.
Example workflow using continueOn: failed:

Metadata present on the workflow stuck in the Running phase
The following labels are present on the Workflow:
workflows.argoproj.io/completed: 'false'
workflows.argoproj.io/phase: Running
The following label is present on the WorkflowTaskResult:
workflows.argoproj.io/report-outputs-completed: 'false'
The conditions have only one entry: PodRunning: false
progress: 1/2
taskResultsCompletionStatus:
    sligo-bug-2486207007: false
    sligo-bug-2605594679: true

All pods created for each step are removed from the namespace
The full yaml for the node running the kubernetes resource step is:
    sligo-bug-2486207007:
      boundaryID: sligo-bug
      children:
        - sligo-bug-2988043323
      displayName: check-k8-resource
      finishedAt: '2024-07-04T09:49:44Z'
      hostNodeName: aks-default-65748190-vmss000008
      id: sligo-bug-2486207007
      message: Error (exit code 1)
      name: sligo-bug[0].check-k8-resource
      outputs:
        exitCode: '1'
      phase: Failed
      progress: 0/1
      resourcesDuration:
        cpu: 0
        memory: 2
      startedAt: '2024-07-04T09:49:39Z'
      templateName: check-mongo-ready
      templateScope: local/sligo-bug
      type: Pod

Comparison using container step instead of kubernetes resource step
If we replace the template for the kubernetes resource step check-mongo-ready with a container step such as intentional-fail taken from examples the workflow finishes fine (it does not get stuck in Running phase):
  - name: intentional-fail
    container:
      image: alpine:latest
      command: [sh, -c]
      args: ["echo intentional failure; exit 1"]

Version
v3.5.8
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
To avoid RBAC issues with this workflow, you need these permissions:
  - verbs:
      - get
    apiGroups:
      - apps
    resources:
      - statefulsets

metadata:
  name: sligo-bug
  namespace: argo-wf
spec:
  entrypoint: main
  templates:
  - name: main
    steps:
      - - name: check-k8-resource
          template: check-mongo-ready
          arguments: {}
          continueOn:
            error: true
            failed: true
      - - name: B
          template: finish
          arguments: {}
  - name: check-mongo-ready
    resource:
      action: get
      manifest: |
        apiVersion: apps/v1
        kind: StatefulSet
        metadata:
          name: myapp-mongodb
      # we expect this to fail because the resource does not exist
      successCondition: status.readyReplicas > 0
      failureCondition: status.readyReplicas < 1
  - name: finish
    container:
      name: ''
      image: docker/whalesay:latest
      command:
        - cowsay
      args:
        - hello world; exit 0
  ttlStrategy:
    secondsAfterCompletion: 300
  podGC:
    strategy: OnPodCompletion

Logs from the workflow controller
{"Phase":"","ResourceVersion":"1708512","level":"info","msg":"Processing workflow","namespace":"argo-wf","time":"2024-07-04T09:49:39.515Z","workflow":"sligo-bug"}
{"level":"info","msg":"Task-result reconciliation","namespace":"argo-wf","numObjs":0,"time":"2024-07-04T09:49:39.526Z","workflow":"sligo-bug"}
{"level":"info","msg":"Updated phase  -\u003e Running","namespace":"argo-wf","time":"2024-07-04T09:49:39.526Z","workflow":"sligo-bug"}
{"level":"warning","msg":"Node was nil, will be initialized as type Skipped","namespace":"argo-wf","time":"2024-07-04T09:49:39.526Z","workflow":"sligo-bug"}
{"level":"info","msg":"was unable to obtain node for , letting display name to be nodeName","namespace":"argo-wf","time":"2024-07-04T09:49:39.526Z","workflow":"sligo-bug"}
{"level":"info","msg":"Steps node sligo-bug initialized Running","namespace":"argo-wf","time":"2024-07-04T09:49:39.527Z","workflow":"sligo-bug"}
{"level":"info","msg":"StepGroup node sligo-bug-3055300894 initialized Running","namespace":"argo-wf","time":"2024-07-04T09:49:39.527Z","workflow":"sligo-bug"}
{"level":"warning","msg":"Node was nil, will be initialized as type Skipped","namespace":"argo-wf","time":"2024-07-04T09:49:39.527Z","workflow":"sligo-bug"}
{"level":"info","msg":"Pod node sligo-bug-2486207007 initialized Pending","namespace":"argo-wf","time":"2024-07-04T09:49:39.527Z","workflow":"sligo-bug"}
{"level":"info","msg":"Created pod: sligo-bug[0].check-k8-resource (sligo-bug-check-mongo-ready-2486207007)","namespace":"argo-wf","time":"2024-07-04T09:49:39.589Z","workflow":"sligo-bug"}
{"level":"info","msg":"Workflow step group node sligo-bug-3055300894 not yet completed","namespace":"argo-wf","time":"2024-07-04T09:49:39.589Z","workflow":"sligo-bug"}
{"level":"info","msg":"TaskSet Reconciliation","namespace":"argo-wf","time":"2024-07-04T09:49:39.589Z","workflow":"sligo-bug"}
{"level":"info","msg":"reconcileAgentPod","namespace":"argo-wf","time":"2024-07-04T09:49:39.589Z","workflow":"sligo-bug"}
{"level":"info","msg":"Workflow update successful","namespace":"argo-wf","phase":"Running","resourceVersion":"1708515","time":"2024-07-04T09:49:39.601Z","workflow":"sligo-bug"}
{"Phase":"Running","ResourceVersion":"1708515","level":"info","msg":"Processing workflow","namespace":"argo-wf","time":"2024-07-04T09:49:49.590Z","workflow":"sligo-bug"}
{"level":"info","msg":"Task-result reconciliation","namespace":"argo-wf","numObjs":1,"time":"2024-07-04T09:49:49.591Z","workflow":"sligo-bug"}
{"level":"info","msg":"task-result changed","namespace":"argo-wf","nodeID":"sligo-bug-2486207007","time":"2024-07-04T09:49:49.591Z","workflow":"sligo-bug"}
{"displayName":"check-k8-resource","level":"info","msg":"Pod failed: Error (exit code 1)","namespace":"argo-wf","pod":"sligo-bug-check-mongo-ready-2486207007","templateName":"check-mongo-ready","time":"2024-07-04T09:49:49.591Z","workflow":"sligo-bug"}
{"level":"info","msg":"node changed","namespace":"argo-wf","new.message":"Error (exit code 1)","new.phase":"Failed","new.progress":"0/1","nodeID":"sligo-bug-2486207007","old.message":"","old.phase":"Pending","old.progress":"0/1","time":"2024-07-04T09:49:49.591Z","workflow":"sligo-bug"}
{"level":"info","msg":"Step group node sligo-bug-3055300894 successful","namespace":"argo-wf","time":"2024-07-04T09:49:49.592Z","workflow":"sligo-bug"}
{"level":"info","msg":"node sligo-bug-3055300894 phase Running -\u003e Succeeded","namespace":"argo-wf","time":"2024-07-04T09:49:49.592Z","workflow":"sligo-bug"}
{"level":"info","msg":"node sligo-bug-3055300894 finished: 2024-07-04 09:49:49.592112732 +0000 UTC","namespace":"argo-wf","time":"2024-07-04T09:49:49.592Z","workflow":"sligo-bug"}
{"level":"info","msg":"StepGroup node sligo-bug-2988043323 initialized Running","namespace":"argo-wf","time":"2024-07-04T09:49:49.592Z","workflow":"sligo-bug"}
{"level":"info","msg":"SG Outbound nodes of sligo-bug-2486207007 are [sligo-bug-2486207007]","namespace":"argo-wf","time":"2024-07-04T09:49:49.592Z","workflow":"sligo-bug"}
{"level":"warning","msg":"Node was nil, will be initialized as type Skipped","namespace":"argo-wf","time":"2024-07-04T09:49:49.592Z","workflow":"sligo-bug"}
{"level":"info","msg":"Pod node sligo-bug-2605594679 initialized Pending","namespace":"argo-wf","time":"2024-07-04T09:49:49.592Z","workflow":"sligo-bug"}
{"level":"info","msg":"Created pod: sligo-bug[1].B (sligo-bug-finish-2605594679)","namespace":"argo-wf","time":"2024-07-04T09:49:49.614Z","workflow":"sligo-bug"}
{"level":"info","msg":"Workflow step group node sligo-bug-2988043323 not yet completed","namespace":"argo-wf","time":"2024-07-04T09:49:49.614Z","workflow":"sligo-bug"}
{"level":"info","msg":"TaskSet Reconciliation","namespace":"argo-wf","time":"2024-07-04T09:49:49.615Z","workflow":"sligo-bug"}
{"level":"info","msg":"reconcileAgentPod","namespace":"argo-wf","time":"2024-07-04T09:49:49.615Z","workflow":"sligo-bug"}
{"level":"info","msg":"Workflow update successful","namespace":"argo-wf","phase":"Running","resourceVersion":"1708590","time":"2024-07-04T09:49:49.629Z","workflow":"sligo-bug"}
{"action":"deletePod","key":"argo-wf/sligo-bug-check-mongo-ready-2486207007/deletePod","level":"info","msg":"cleaning up pod","time":"2024-07-04T09:49:54.631Z"}
{"Phase":"Running","ResourceVersion":"1708590","level":"info","msg":"Processing workflow","namespace":"argo-wf","time":"2024-07-04T09:49:59.616Z","workflow":"sligo-bug"}
{"level":"info","msg":"Task-result reconciliation","namespace":"argo-wf","numObjs":2,"time":"2024-07-04T09:49:59.618Z","workflow":"sligo-bug"}
{"level":"info","msg":"task-result changed","namespace":"argo-wf","nodeID":"sligo-bug-2486207007","time":"2024-07-04T09:49:59.618Z","workflow":"sligo-bug"}
{"level":"info","msg":"task-result changed","namespace":"argo-wf","nodeID":"sligo-bug-2605594679","time":"2024-07-04T09:49:59.618Z","workflow":"sligo-bug"}
{"level":"info","msg":"node changed","namespace":"argo-wf","new.message":"","new.phase":"Succeeded","new.progress":"0/1","nodeID":"sligo-bug-2605594679","old.message":"","old.phase":"Pending","old.progress":"0/1","time":"2024-07-04T09:49:59.618Z","workflow":"sligo-bug"}
{"level":"info","msg":"SG Outbound nodes of sligo-bug-2486207007 are [sligo-bug-2486207007]","namespace":"argo-wf","time":"2024-07-04T09:49:59.619Z","workflow":"sligo-bug"}
{"level":"info","msg":"Step group node sligo-bug-2988043323 successful","namespace":"argo-wf","time":"2024-07-04T09:49:59.620Z","workflow":"sligo-bug"}
{"level":"info","msg":"node sligo-bug-2988043323 phase Running -\u003e Succeeded","namespace":"argo-wf","time":"2024-07-04T09:49:59.620Z","workflow":"sligo-bug"}
{"level":"info","msg":"node sligo-bug-2988043323 finished: 2024-07-04 09:49:59.620324699 +0000 UTC","namespace":"argo-wf","time":"2024-07-04T09:49:59.620Z","workflow":"sligo-bug"}
{"level":"info","msg":"Outbound nodes of sligo-bug-2605594679 is [sligo-bug-2605594679]","namespace":"argo-wf","time":"2024-07-04T09:49:59.620Z","workflow":"sligo-bug"}
{"level":"info","msg":"Outbound nodes of sligo-bug is [sligo-bug-2605594679]","namespace":"argo-wf","time":"2024-07-04T09:49:59.620Z","workflow":"sligo-bug"}
{"level":"info","msg":"node sligo-bug phase Running -\u003e Succeeded","namespace":"argo-wf","time":"2024-07-04T09:49:59.620Z","workflow":"sligo-bug"}
{"level":"info","msg":"node sligo-bug finished: 2024-07-04 09:49:59.620749704 +0000 UTC","namespace":"argo-wf","time":"2024-07-04T09:49:59.620Z","workflow":"sligo-bug"}
{"level":"info","msg":"TaskSet Reconciliation","namespace":"argo-wf","time":"2024-07-04T09:49:59.620Z","workflow":"sligo-bug"}
{"level":"info","msg":"reconcileAgentPod","namespace":"argo-wf","time":"2024-07-04T09:49:59.620Z","workflow":"sligo-bug"}
{"level":"info","msg":"Workflow update successful","namespace":"argo-wf","phase":"Running","resourceVersion":"1708676","time":"2024-07-04T09:49:59.636Z","workflow":"sligo-bug"}
{"action":"deletePod","key":"argo-wf/sligo-bug-finish-2605594679/deletePod","level":"info","msg":"cleaning up pod","time":"2024-07-04T09:50:04.637Z"}
{"Phase":"Running","ResourceVersion":"1708676","level":"info","msg":"Processing workflow","namespace":"argo-wf","time":"2024-07-04T09:50:14.667Z","workflow":"sligo-bug"}
{"level":"info","msg":"Task-result reconciliation","namespace":"argo-wf","numObjs":2,"time":"2024-07-04T09:50:14.668Z","workflow":"sligo-bug"}
{"level":"info","msg":"task-result changed","namespace":"argo-wf","nodeID":"sligo-bug-2486207007","time":"2024-07-04T09:50:14.668Z","workflow":"sligo-bug"}
{"level":"info","msg":"task-result changed","namespace":"argo-wf","nodeID":"sligo-bug-2605594679","time":"2024-07-04T09:50:14.668Z","workflow":"sligo-bug"}
{"level":"info","msg":"TaskSet Reconciliation","namespace":"argo-wf","time":"2024-07-04T09:50:14.668Z","workflow":"sligo-bug"}
{"level":"info","msg":"reconcileAgentPod","namespace":"argo-wf","time":"2024-07-04T09:50:14.668Z","workflow":"sligo-bug"}
{"level":"info","msg":"Workflow update successful","namespace":"argo-wf","phase":"Running","resourceVersion":"1708676","time":"2024-07-04T09:50:14.685Z","workflow":"sligo-bug"}

Logs from in your workflow's wait container
Edit: There is no wait container for Resource type pods. These logs are for the step that uses a container
{"level":"info","msg":"Starting Workflow Executor","time":"2024-07-04T09:55:13.015Z","version":"v3.5.8"}
{"Duration":1000000000,"Factor":1.6,"Jitter":0.5,"Steps":5,"level":"info","msg":"Using executor retry strategy","time":"2024-07-04T09:55:13.018Z"}
{"deadline":"2024-07-05T01:55:00Z","includeScriptOutput":false,"level":"info","msg":"Executor initialized","namespace":"argo-wf","podName":"sligo-bug-vj8v4-finish-1000479478","templateName":"finish","time":"2024-07-04T09:55:13.018Z","version":"\u0026Version{Version:v3.5.8,BuildDate:2024-06-18T03:43:17Z,GitCommit:3bb637c0261f8c08d4346175bb8b1024719a1f11,GitTag:v3.5.8,GitTreeState:clean,GoVersion:go1.21.10,Compiler:gc,Platform:linux/amd64,}"}
W0704 09:55:13.045324       1 warnings.go:70] Use tokens from the TokenRequest API or manually created secret-based tokens instead of auto-generated secret-based tokens.
{"level":"info","msg":"Starting deadline monitor","time":"2024-07-04T09:55:13.046Z"}
{"error":null,"level":"info","msg":"Main container completed","time":"2024-07-04T09:55:16.047Z"}
{"level":"info","msg":"No Script output reference in workflow. Capturing script output ignored","time":"2024-07-04T09:55:16.047Z"}
{"level":"info","msg":"No output parameters","time":"2024-07-04T09:55:16.047Z"}
{"level":"info","msg":"No output artifacts","time":"2024-07-04T09:55:16.047Z"}
W0704 09:55:16.061106       1 warnings.go:70] Use tokens from the TokenRequest API or manually created secret-based tokens instead of auto-generated secret-based tokens.
W0704 09:55:16.068093       1 warnings.go:70] Use tokens from the TokenRequest API or manually created secret-based tokens instead of auto-generated secret-based tokens.
{"level":"info","msg":"Alloc=8106 TotalAlloc=13731 Sys=19557 NumGC=4 Goroutines=8","time":"2024-07-04T09:55:16.068Z"}
W0704 09:55:16.074405       1 warnings.go:70] Use tokens from the TokenRequest API or manually created secret-based tokens instead of auto-generated secret-based tokens.

Can you ensure that the service account for the workflow pods has the correct RBAC: https://argo-workflows.readthedocs.io/en/latest/workflow-rbac/

Can you ensure that the service account for the workflow pods has the correct RBAC: https://argo-workflows.readthedocs.io/en/latest/workflow-rbac/

Yes we have the correct RBAC for both workflowtaskresults (create/patch) & statefulsets (get)

 View full Role YAML
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
  name: argo-wf-argo-workflows-workflow
rules:
  - verbs:
      - get
    apiGroups:
      - apps
    resources:
      - statefulsets
  - verbs:
      - create
      - patch
    apiGroups:
      - argoproj.io
    resources:
      - workflowtaskresults
  - verbs:
      - list
      - watch
    apiGroups:
      - argoproj.io
    resources:
      - workflowtasksets
  - verbs:
      - get
    apiGroups:
      - '*'
    resources:
      - secrets
  - verbs:
      - patch
    apiGroups:
      - argoproj.io
    resources:
      - workflowtasksets/status
  - verbs:
      - get
      - list
      - watch
    apiGroups:
      - kubernetes.dask.org
    resources:
      - daskclusters
      - daskworkergroups
      - daskworkergroups/scale
      - daskjobs
      - daskautoscalers
  - verbs:
      - get
      - list
      - watch
    apiGroups:
      - ''
    resources:
      - pods
      - pods/status
      - services

v3.5.5 (chart version 0.41.0) seems to be the last version where the workflow provided completes and is not stuck in Running phase.
The issue starts to arise with v3.5.6 (chart: 0.41.2)

Thanks for the super detailed bug report! ❤

The following label is present on the WorkflowTaskResult:
workflows.argoproj.io/report-outputs-completed: 'false'

Does this part happen in 3.5.5 too?
#12544 was in 3.5.5, so I'm guessing the bug results from that combined with #12574 in 3.5.6 -- if the reports are never marked as completed.
If the resource template gets an error, it would trigger the HandleError line before the FinalizeOutputs line. But that would only not continue during a panic specifically, which I would think this would not cause 🤔
@BarryOwensDigital could you provide the logs of the main container as well?
@shuangkun could you take a look here?

Does this part happen in 3.5.5 too?

Seems like in 3.5.5 we get workflows.argoproj.io/report-outputs-completed: 'true'. The workflowtask is removed quickly on this version
Logs from the main container (v3.5.8). We expect myapp-mongodb not found here:
time="2024-07-04T16:27:32 UTC" level=info msg="Starting Workflow Executor" version=v3.5.8
time="2024-07-04T16:27:32 UTC" level=info msg="Using executor retry strategy" Duration=1s Factor=1.6 Jitter=0.5 Steps=5
time="2024-07-04T16:27:32 UTC" level=info msg="Executor initialized" deadline="2024-07-05 08:27:28 +0000 UTC" includeScriptOutput=false namespace=jenkins podName=sligo-bug2-check-mongo-ready-2523367045 templateName=check-mongo-ready version="&Version{Version:v3.5.8,BuildDate:2024-06-18T03:43:17Z,GitCommit:3bb637c0261f8c08d4346175bb8b1024719a1f11,GitTag:v3.5.8,GitTreeState:clean,GoVersion:go1.21.10,Compiler:gc,Platform:linux/amd64,}"
W0704 16:27:32.689976      14 warnings.go:70] Use tokens from the TokenRequest API or manually created secret-based tokens instead of auto-generated secret-based tokens.
time="2024-07-04T16:27:32 UTC" level=info msg="Loading manifest to /tmp/manifest.yaml"
time="2024-07-04T16:27:32 UTC" level=info msg="kubectl get -f /tmp/manifest.yaml -o json"
Warning: Use tokens from the TokenRequest API or manually created secret-based tokens instead of auto-generated secret-based tokens.
Error from server (NotFound): statefulsets.apps "myapp-mongodb" not found
{"argo":true,"error":null,"level":"info","msg":"sub-process exited","time":"2024-07-04T16:27:33.620Z"}
Error: exit status 1

Also agree this might be related to https://github.com/argoproj/argo-workflows/pull/12544, when I enable the debug logs we get this log on the controller:
...msg="taskresults of workflow are incomplete or still have daemon nodes, so can't mark workflow completed" fromPhase=Running namespace=jenkins toPhase=Succeeded ...

Seems like in 3.5.5 we get workflows.argoproj.io/report-outputs-completed: 'true'

Huh. So the problem is that it's not being marked complete for some reason in 3.5.6+. But you also have no errors... 🤔
The diff between 3.5.5 and 3.5.6 has no relevant changes to the Executor though (the tiny changes are for when task result RBAC is not granted, which does not apply here).
I'm wondering if something else is changing the task result or something or if there's a wonky dep change or something

Also agree this might be related to #12544, when I enable the debug logs we get this log on the controller:

Yea though it is correct in this case; if the task result was marked complete this wouldn't happen

So the problem is that it's not being marked complete for some reason in 3.5.6+

I've checked again, I might have been mistaken earlier looking at incorrect WorkflowTaskResult.
In 3.5.5 the WorkflowTaskResult does still have workflows.argoproj.io/report-outputs-completed: 'false'
apiVersion: argoproj.io/v1alpha1
kind: WorkflowTaskResult
metadata:
  generation: 1
  labels:
    workflows.argoproj.io/report-outputs-completed: 'false'
    workflows.argoproj.io/workflow: sligo-bug

Maybe this is the reason #12103 (comment).

That issue looks to be different. We have no workflows running and the example workflow provided can reproduce the issue when a Workflow is started on 3.5.6+

I reproduce this issue with your demo...The main container exited with code 1 because of RBAC problems

Additional RBAC is required for that example workflow. I have added rules to the above example. Regardless, on 3.5.5 if the step fails due to RBAC problems but has continueOn.error and continueOn.failed the workflow does not get stuck in Running phase.

Pod of Resource type do not have the wait container, why do you have the logs of wait container.

Thanks for confirming, I didn't realise it didn't have a wait container until now. The wait container logs above are for the second step in the provided example workflow, not the step using the Resource type. I have added a note above

Sorry I'm not familiar with FinalizeOutput but this sounds like continueOn.error will not work as expected then?

workflows.argoproj.io/report-outputs-completed will be set to true in function FinalizeOutput, workflow will stuck in Running if it did not execute.
Can you provide the logs of the main container in the pod of Resource type? I think it might also exit midway.

...msg="taskresults of workflow are incomplete or still have daemon nodes, so can't mark workflow completed" fromPhase=Running namespace=jenkins toPhase=Succeeded ...

This line of log already shows the reason for this issue.
The root cause is as I analyzed above: FinalizeOutput will not be executed if the main container exits midway., which the log you privided Error: exit status 1 has proved.

This line of log already shows the reason for this issue.

Just confirming, we in agreement then that there is an issue in 3.5.6+?
The error is expected and the workflow is expected to handle that and continue to completion since we have continueOn.error.
"FinalizeOutput will not be executed if the main container exits midway" - this poses an issue since this means continueOn.error will not work for steps of type Resource.
To compare, we can swap out the Resource type with a Container type that exits midway. This finishes fine and as it probably runs FinalizeOutput even if there is an error midway.

 show example workflow using no Container Type with continuesOn.error and exit midway
metadata:
  name: container-with-intentional-fail
  namespace: jenkins
spec:
  entrypoint: main
  templates:
  - name: main
    steps:
      - - name: intentional-fail
          template: intentional-fail
          arguments: {}
          continueOn:
            error: true
            failed: true
  - name: intentional-fail
    container:
      image: alpine:latest
      command: [sh, -c]
      args: ["echo intentional failure; exit 1"]

Logs from main
intentional failure
{"argo":true,"error":null,"level":"info","msg":"sub-process exited","time":"2024-07-05T14:22:33.391Z"}
Error: exit status 1

@jswxstw yes, I already mentioned FinalizeOutputs not being run in my very first comment here. But, per that comment, it seemed like it should still run unless there's a panic in HandleError? Unless I'm misunderstanding how Go defer works
In any case, FinalizeOutputs must still run if there's an error. It shouldn't be stuck ever (unless there is a bug).

I've checked again, I might have been mistaken earlier looking at incorrect WorkflowTaskResult.
In 3.5.5 the WorkflowTaskResult does still have workflows.argoproj.io/report-outputs-completed: 'false'

@BarryOwensDigital ok, that makes a lot more sense. That means the code from #12544 has a bug in it in the error case.
Also would you mind adding syntax highlighting to your code blocks? i.e. ```yaml. I've been editing all your comments to add it 😅

@jswxstw yes, I already mentioned FinalizeOutputs not being run in my very first comment here. But, per that comment, it seemed like it should still run unless there's a panic in HandleError? Unless I'm misunderstanding how Go defer works

It seems the main container exited by os.Exit(1), thus defer function will not be executed.

Yes, though I wonder what's running os.Exit(1) since we have error handling throughout runKubectlCmd -- that would suggest that client-go itself is perhaps doing that instead of returning an error?? 🤔

Oh dear, I see the problem. We're not using client-go at all, but straight up calling the kubectl code as a library, which, as a CLI, will of course have exits 😕
If we want to keep doing that, we'd have to do what their tests do and catch exits. But tbh, I don't think we should run like that, I would think using client-go directly would make more sense. Although idk if the flags field would work the same that way


[Bug] Fix Dr. Who Score

Add "Greatest Time Lord" to the highscore titles list.

Fixed with 3.1.0


Remove direct access to static config in code

Remove direct access to KaldbConfig.get() in the code since it introduces tight coupling between classes and makes it harder to test code. Instead, pass the protobuf object around instead.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Suman Karumuri seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

I think we need to fix Kaldb#start method - this still uses a static reference KaldbConfig.get() - this is important to remove since we want to be able to finally reuse Kaldb.java in test cases rather than create bespoke servers for testing that have different threading models than production.

What's to stop us from mistakenly calling KaldbConfig#get and accessing the value statically ? Shouldn't _instance not be a static anymore?

Looks like CLA assistant is unhappy as well

I think there are 4 references to KaldbConfig.initFromConfigObject in the tests that we need to remove - Those calls were made to workaround the problem that we had one static config. I'd be curious to know if the tests still pass once this is removed.

Removed the calls to initFromConfigObject from everywhere and made it a private method.

I think we need to fix Kaldb#start method - this still uses a static reference KaldbConfig.get() - this is important to remove since we want to be able to finally reuse Kaldb.java in test cases rather than create bespoke servers for testing that have different threading models than production.

Good point. Removed.

What's to stop us from mistakenly calling KaldbConfig#get and accessing the value statically ? Shouldn't _instance not be a static anymore?
Moved KaldbConfig into server config and made this method package private. So, no one outside the package should be able to call KaldbConfig.get from the rest of the code.


Allow additional unary/streaming server interceptors

Description of change
This allows injecting additional interceptors into GRPC Server.
Checklist

[x] Tested in playground or other setup
[ ] Screenshot (Grafana) from playground added to PR for 15+ minute run

Summary by CodeRabbit
New Feature

Added the ability to inject additional unary and streaming interceptors into a GRPC Server in pkg/net/grpc/server.go. This enhancement allows for greater flexibility and customization of server behavior.

Here's to the code that now takes flight,
With new features shining bright.
Interceptors join the fray,
Making our server sway 🎉.
In the realm of GRPC,
We dance with joy and glee 💃🕺.


Using Golang templates for config files

In this PR we are using the golang template for the config file where the placeholders gets replaced by the environment variables

@MayankGandhe in summary please:

[ ] move the templating tests out of j8a1.yml to j8a3.yml and create a new config file for these tests.
[ ] add a unit test for envToMap, revisit error handling and test for edge cases. This could break server startup.
[ ] Create a new integration test in the circleci pipeline for a server that has to successfully start using a merged secret and a merged port. You can use your new config file for this server. Add the secrets to env for the integration test pipeline. You need to add a new server under "intjob" in .circleci/config.yml to make this work

@simonmittag yes all points looks valid to me , but the first point and second point would be irrelevant in my case since I have not made any changes to the existing files and created a new yaml config files for template test cases in location "./integration/template/" you can also view the new files in PR


Remove unused RefresherRelatsMixin and find_relats_vc_data method

@jrafanie and I were investigating making link_ems_inventory faster, and in doing so, found that the RefresherRelatsMixin is no longer actually used.  It used to be used by KVM, the original SCVMM, and some others, but technically was never needed for RHEVM.
In addition, a copy-paste version of that method in the VMware refresher is also not used at all.
@blomquisg Please review
cc @gmcculloug

cc @dmetzger57

Wow ... If this is the same thing I'm thinking of, I remember coming across this almost 2 years ago and trying to figure out who was using it ... I couldn't find anything, but I convinced myself something must be calling it with some .send(constructed_method_name.to_sym) construct.
Glad to see unused code go!  :smile:

...but I convinced myself something must be calling it with some .send(constructed_method_name.to_sym) construct

This is why I avoid sends unless I can't come up with something better.
:fire: dead code :fire:


feat: add Layout component

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a4a52bf) 32.35% compared to head (cbc5c6a) 32.70%.

:exclamation: Current head cbc5c6a differs from pull request most recent head 3c61fdf. Consider uploading reports for the commit 3c61fdf to get more accurate results

Files
Patch %
Lines

src/previews/components/layout/top-side-2.tsx
84.61%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
+ Coverage   32.35%   32.70%   +0.35%
==========================================
  Files         283      285       +2
  Lines        2108     2122      +14
  Branches      448      463      +15
==========================================
+ Hits          682      694      +12
- Misses       1426     1428       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


improve shape accuracy in transform output by providing better tooling

Some transforms, notably and TensorParallel ones, change shapes, but currently do not completely update them (it does for the linear that follows, but not for the activation etc.).
We might consider either making it easy for the transform to update the shapes on the fly or at the end of the transform by providing a mechanism similar / based on to the interpret_trace_to_trace introduced in #1164 (which would then become stricter by default).
cc: @crcrpar
cc @carmocca @borda

Not updating the shapes is odd; curious why this is an 'enhancement' vs. a real bug. marking triage review to discuss!

I don't object to having it labeled bug, but I don't think typically users will hit it today:
For things needing gradients, the augmented forward pass will fix it. I'm not sure that Tensor Parallel sees heavy use in inference just yet.
Among the things I found while doing #1164, it seems one of the milder issues.

Some transforms, notably and TensorParallel ones, change shapes, but currently do not completely update them (it does for the linear that follows, but not for the activation etc.).

I thought the logic implemented in https://github.com/Lightning-AI/lightning-thunder/blob/f70b0fe22d27a2e2a0a6ac31cf2c52c9d4e4e35d/thunder/distributed/tensor_parallel/common.py#L118 did update shapes automatically. but it isn't?

Yeah, @crcrpar, so this is why I mentioned better tooling, maybe using the visitor transform pattern more is the solution. Looking at the code, I would probably have the same expectation as you, but if I take out this
https://github.com/Lightning-AI/lightning-thunder/blob/f70b0fe22d27a2e2a0a6ac31cf2c52c9d4e4e35d/thunder/core/trace_interpreter.py#L120-L127
there seem to be inconsistencies.
Maybe it is some other part (and I certainly anything I wrote will have the problem) that does not update shapes fully.

Looking at what happened: I think while the visitor re-executes all things not replaced, it does so with the old outputs, not the new ones (in contrast to interpret_trace / interpret_trace_to_trace which have the env thing  to keep track of what to swap).
To my mind, it will be worthwhile to see whether an extended visitor pattern or perhaps the interpret_trace_to_trace itself will be best to solve this. WDYT?


Project tests are failing

Warious errors:
https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/blob/a7b1643407f94084f5c9e3aa21e87fafcf97d028/dm/templates/project/project.py#L69
https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/blob/a7b1643407f94084f5c9e3aa21e87fafcf97d028/dm/templates/project/project.py#L76
https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/blob/a7b1643407f94084f5c9e3aa21e87fafcf97d028/dm/templates/project/project.py#L81
https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/blob/a7b1643407f94084f5c9e3aa21e87fafcf97d028/dm/templates/project/project.py#L347
They are all missing the context.env['name'] prefix which was added to the api names

Note: The project tests are passing, however there is an issue with deletion of the Shared VPC Lien.


build(exteranl): add HARDENED_CFLAG ext mingw

Signed-off-by: pingkai<EMAIL_ADDRESS>

Codecov Report

Merging #261 into develop will decrease coverage by 4.21%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #261      +/-   ##
===========================================
- Coverage    68.68%   64.47%   -4.22%
===========================================
  Files          207      207
  Lines        11239    11239
===========================================
- Hits          7720     7246     -474
- Misses        3519     3993     +474

Impacted Files
Coverage Δ

framework/tests/dataSource/ipList.h
0.00% <0.00%> (-100.00%)
:arrow_down:

framework/tests/demuxer/demuxerUnitTest.cpp
0.00% <0.00%> (-100.00%)
:arrow_down:

mediaPlayer/SuperMediaPlayerDataSourceListener.h
0.00% <0.00%> (-100.00%)
:arrow_down:

framework/tests/decoder/decoderUnitTest.cpp
0.00% <0.00%> (-93.62%)
:arrow_down:

framework/tests/dataSource/dataSourceUnitTest.cpp
0.00% <0.00%> (-93.39%)
:arrow_down:

framework/tests/demuxer/demuxerUtils.cpp
0.00% <0.00%> (-76.00%)
:arrow_down:

framework/data_source/ffmpeg_data_source.cpp
7.50% <0.00%> (-57.50%)
:arrow_down:

framework/demuxer/AVBSF.cpp
25.27% <0.00%> (-42.86%)
:arrow_down:

framework/data_source/curl/CURLShareInstance.cpp
69.44% <0.00%> (-27.78%)
:arrow_down:

framework/data_source/curl/CURLConnection.cpp
55.52% <0.00%> (-11.34%)
:arrow_down:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d46589...cb2191a. Read the comment docs.


Angular drag and drop issue with nested content and connectedList

Hello!!
I have been trying to solve this issue for days but i didnt found a solution.
My problem is trying to create a dropList that contains inside other dropLists.
Almost behavior is correct, the problem is when i try to reorder items inside the nested dropList, it can not be posible.
I created in stackblitz an example of the bug.
https://stackblitz.com/edit/angular-rsvmbj

Duplicate of https://github.com/angular/components/issues/16671.


Move test resources to test directory.

Addresses #463.

@ming13 Thanks for the PR!
IIRC these files are used in unit tests so simply deleting them will break the tests. I believe the best fix for this is to move them into the test directory as mentioned in https://github.com/googlemaps/android-maps-utils/issues/463#issuecomment-410360845.

@barbeau, yeah, I read about that but neither code search or Save Delete option in IJ have found any usage. Renamed the PR and adjusted the change.
BTW, does anybody run tests? I had to fix a bunch of them to be green. And CI is not running them (and running at all as it seems). This is scary.

CI issue is discussed in https://github.com/googlemaps/android-maps-utils/issues/371.
Yes, the project probably needs some updating to run tests correctly in Android Studio.  Let's split those changes out to their own PRs though so each serves it's own purpose.
Looking at my old comment the KML files are used in library/tests/src/com/google/maps/android/kml/Kml*Test.java classes - I don't believe Android Studio will flag them via a Find on the files.

@barbeau, maybe it’ll be fine to merge moving files and fixing tests together? I mean, it literally makes tests runnable, it wouldn’t be even possible to merge this PR if the CI would be configured properly to run tests.

@jpoehnelt, @friederbluemle, please take a look. We had open questions so I’m just waiting for the clarification.

I've only just started taking a look at this repo(we may have some more resources to help out soon). I don't see anything of note from a quick glance but I would like to run locally before approving. I'll try to get to it by mid next week. Thanks again!

@jpoehnelt - Merging the base branch into the PR head branch won't help here - There are a few code changes required to properly fix the test setup on the latest master branch. Should I open a PR?

Hm, seems like Travis passed, but seems like it doesn’t run tests for now.

@friederbluemle, since you’ve resolved test issues separately — I think it would be better to merge your changes first and I’ll rebase mine on top. Also — can I ask to add the test Gradle task in Travis configuration on your branch? Don’t want to break anything and it is better to have CI check that.

@ming13 - Sure, I'll open a PR with just the test setup fixes. 👍
I definitely agree this is something that should run on CI with every PR. There are more test updates and fixes on the way, hopefully we'll get there soon. Right now, running the test task wouldn't do much more than the existing check task does. The tests are setup as "instrumented" tests, and require a connected Android device (something that unfortunately is not that straight forward on Travis CI).

@friederbluemle, testDebugUnitTest then? I think that tests both of us fixed can be run on the JVM.

@ming13 - Yes, you are right, it should be possible to run the tests on the JVM only. There are no real "UI" tests involved. However, since the code tested does contain imports from the Android framework, it may require non trivial additional changes to the test setup, so it might be better to have a separate PR for that.

Good news @ming13 - Your branch rebases cleanly onto the latest master (with #550 merged). All you need to do is remove the defaultConfig block from build.gradle. :)

@jpoehnelt, @friederbluemle, rebased and squashed! Tests passed locally: 184 of 184.

Awesome, thanks @ming13 👏


fix Weblium site builder detection

Hi,
in my previous PR (https://github.com/AliasIO/wappalyzer/pull/3947) I missed with JS detection - this detection is too wide.
Please merge this PR too and sorry about inconvenience

Hi @AliasIO
Cloud you merge this, please?

@AlexeyKhristov The pattern seems valid, why is it too wide?

Hi @AliasIO
it was my initial mistake:
We have used WEBLIUM_DOMAIN not only in Weblium-built sites, but in other White-label builders, like draftium.com
and even in custom built sites. WEBLIUM_DOMAIN is an artifact of our internal libraries.
Please merge this PR - checking WEBLIUM_DOMAIN in js code can cause "false positive" event in non-weblium sites

Cheers!


Add more CodeChecker commands

Description

Nothing special, more useful Codechecker commands were added.
Areas of interest

The added logic and the interface. If there are any questions related to the help messages please point them out.
I would be extremely happy, if this could be tested on some active projects.
This version of East is available on the test PyPi:
pip install -i https://test.pypi.org/simple/ east-tool==0.15.9

If you are able to do that, please ask me to make you a new product page on our CodeChecker server.
You will need it for testing.
Checklist

[x] Source code documentation for all newly added or changed functions was added/updated.
[x] All customer facing technical documentation was updated.

Related issues

Related to #86
After-review steps

Code author will merge the PR by himself/herself.

Current dependencies on/for this PR:

dev

PR #90   👈

This comment was auto-generated by Graphite.

Merge Activity

Sep 25, 2:42 AM: @MarkoSagadin started a stack merge that includes this pull request via Graphite.


Infinite loop looking up regions

Hello,
I've been using this library for a while and I've just updated the latest version. I am having problems with an infinite loop looking up regions. I've tried this with HBase 1.2.4 and 1.3.1 - both on a large cluster and on my local machine with the same results.  It works fine simply recompiling with the older version. Any ideas?
go version go1.8 linux/amd64
hbase
create 'doug','c'
put 'doug','boo','c:hoo',':-('

main.go
package main
import (
"context"
"log"
"github.com/tsuna/gohbase"
"github.com/tsuna/gohbase/hrpc" )
func main() {
client := gohbase.NewClient("localhost")
getRequest, err := hrpc.NewGetStr(context.Background(), "doug", "boo")
if err != nil {
	log.Printf("%s", err.Error())
}
getRsp, err := client.Get(getRequest)
log.Printf("found results %v", getRsp)

}

Hello @dougklein, thanks for reporting, this is a know issue, I'm looking into it.

Actually, you are probably hitting a different issue as I wasn't able to reproduce the infinite loop with the code you provided. Could you add logrus.SetLevel(logrus.DebugLevel) before creating the client and post your output here. Thanks!

Here you are - debug level with the working library and not latest one.
works.txt
notworks.txt

Ok, I think I was able to reproduce the issue you are seeing. Looks the version of https://github.com/cznic/b you have (dependency of gohbase) is out of date. There was a fix for the Prev() method without which I'm seeing the same notworks output as you are. Can you try updating that library to confirm that this is the issue?

That fixes the problem. Thank you!
Will of course let you know if we run into other issues.

Doug


STL in C++

All about Vectors (dynamic array) in c++ standard template library
What type of PR is this? (check all applicable)

[ ] 🚀 Added Name
[ ] ✨ Feature
[ ] 🌟 stared the repo
[ ] 🐛 Grammatical Error
[x] 📝 Documentation Update
[ ] 🚩 Other

Description
Add Link of GitHub Profile

added vector_STL


Fix single frame image is decoded even cached

This PR fixed unnecessary repeated decoding of a single frame image. We have encountered the problem of repeated decoding of pictures when using Image.network(), even if it is a picture that has been cached, _decodeNextFrameAndSchedule will still be executed in MultiFrameImageStreamCompleter.addListener() during building a new image widget.
Flutter use ImageCache to cache ImageStreamCompleter.

For single frame image (jpg, png and one frmae gif or webp), most of cached completer has a not null _currentImage and frame need be decoded only when _currentImage is null. Decoding is expensive and should not happen when we already known result.
For multi frame image, which _codec!.frameCount > 1, just decode as usual.

Png, jpg, single-frame gif(duration 0 or 0.1s), multi-frame gif was tested and works fine.
fixed #82532
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ Googlers: Go here for more info.

@googlebot I signed it!

@omgseven To ensure that we never break this functionality again we require tests before we can merge a PR. Can you please add some tests that cover this scenario? Thanks!

(PR triage) @omgseven  Do you still have plans to come back to this PR?

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.
ℹ Googlers: Go here for more info.
@googlebot I fixed it.

(PR triage) @omgseven Do you still have plans to come back to this PR?

A test is added here

It seems that Windows build_test_2_3 is failed at download dependencies, this PR should not affect windows build.


SmartRouter, RegExpRouter dynamically registering and removing routes.

 TrieRouter achieves the expected behavior.
new Hono({
  router: new TrieRouter(),
});

The situation:
A plugin system that supports dynamic route registration.  p.s. don't care about security issues.

MESSAGE_MATCHER_IS_ALREADY_BUILT

It is unavoidable that those routers throw MESSAGE_MATCHER_IS_ALREADY_BUILT because of performance reasons. If you don't like it, you can use a TrieRouter as you said.


Fix linking error with Win10 SDK in WIN32_OVERRIDE_ALLOCATORS mode

Thanks for the patch. Can you please elaborate a bit on why recalloc_base needs to be overridden as well? Something is calling it ?

Yes. _recalloc_base is called by CRT internally. The linker will complain about one or more multiply defined symbols found in libucrt if we don't override it.


[tests-only] [full-ci] Test expected-failures newline-at-end

WIP

https://drone.cernbox.cern.ch/cs3org/reva/5280/10/6
./tests/acceptance/run.sh --type api
Script path: /drone/src/tmp/testrunner/tests/acceptance
Checking expected failures in /drone/src/tests/acceptance/expected-failures-on-OCIS-storage.md
Expected failures file /drone/src/tests/acceptance/expected-failures-on-OCIS-storage.md must end with a newline
Put a newline at the end of the last line and try again
Makefile:211: recipe for target 'test-acceptance-api' failed
make: *** [test-acceptance-api] Error 1

I purposely introduced that problem, and the run.sh test-runner script correctly detects it and fails the pipeline.

https://drone.cernbox.cern.ch/cs3org/reva/5280/16/7
S3NG pipelines do not have this problem. I purposely did not introduce the problem to that expected-failures file. Good.

core PR works. Closing here.


Possibility to override the default table name

This allow user to change the name of the default table name created by the bundle.
By default the bundle will add a new table to your database called ktw_menu_items.
This PR allow user to change the table name using a new configuration key:
# app/config/config.yml
ktw_database_menu:
    table_name: menu_items

Thank you for the pull request.  I appreciate your help.
Could you please add some unit tests for the MappingListener?

Hi, I will update my PR with some Unit tests as soon as possible.

Hi @kevintweber, I just got a weird error, when I reload my webpage, I got an exception except the 1st time.
It seems the MappingListener, or an other component try to add each time a new entry in the database.
Error message:
SQLSTATE[23000]: Integrity constraint violation: 19 UNIQUE constraint failed: menu_items.name").

The temporary fix I found is to surround with a try/catch like:
$this->objectManager->persist($menu);
try {
    $this->objectManager->flush();
}
    catch (\Exception $e) {
}

However it's not a good idea!
So, if you have some time to help it would be great! Thanks


Feature/dont replace nonexistant files

🌈
^ the rainbow of compliance :)
I came across some difficulty earlier today as a rails generator was attempting to inject into a file that didn't exist in my project. The error was relatively clear but I was surprised to find that Thor didn't handle this issue. My pull request helps that a little, hopefully, and would address at least this guy's issue.
Please let me know if the specs are inadequate or if this needs documentation.

Specs pass for me. If someone wants to give me a tip on why CI is failing I'll happily address.

LGTM :+1:

Thanks! I was just wondering about this pull request a couple days ago

Hi @rafaelfranca! I've addressed your comments in the recent commit. Thanks for taking the time to take a look at this. 👍

Let me know if you'd like to see any other changes @rafaelfranca


Inconsistency and Usability Issues in Current Navigation Menu

The current implementation of our navigation menu has significant inconsistencies in design and user experience, particularly when compared to refined examples such as the navigation menu in Azure DevOps. Our menu's visual and functional aspects are lacking in providing a cohesive and intuitive user interface.
Reference for Comparison:
Azure DevOps Menu:

Details:
The primary issues revolve around the positioning and functionality of the settings button and sidebar toggle. The current layout does not effectively utilize space and fails to provide a clear navigation experience. The NavMenuLink component's restrictive properties limit our ability to mirror more dynamic and user-friendly designs, such as combining multiple icons in a single interactive element.
Proposed Solution:
PR #1031 has been created to address these concerns. It repositions the settings button and sidebar toggle to the bottom of the navigation menu, emulating the layout found in Azure DevOps. This change aims to enhance the usability and aesthetic appeal of our navigation system.
Expected Outcome:
With the implementation of PR #1031, the navigation menu will offer a more streamlined and intuitive interface, akin to the Azure DevOps example. The settings and toggle functionalities will be more accessible and visually distinct, significantly improving the user experience.
Screenshots of Proposed Changes:
NavMenu Expanded:

NavMenu Closed:

Looks great tbh. 👍

@leslierichardson95 - Are we taking in proposed changes here? Based on PR discussion, I see no conclusive answer.

The design has changed quite a bit, I'm going to close this for now. @josephaw1022 feel free to reopen a new issue with new design suggestions.


Fix PCBS integration tests for Spark-3.4

This fixes https://github.com/NVIDIA/spark-rapids/issues/7216 .
Spark-3.4 added a new config flag to enable TIMESTAMP_NTZ and added that in class ParquetToSparkSchemaConverter
Updated the code such that Spark-3.4 shim takes that into consideration. With this fix, the PCBS tests pass in Spark-3.4.
========================================================= 580 passed, 81 warnings in 168.18s (0:02:48) =========================================================
Starting with OOM injection seed:<PHONE_NUMBER>. Set env variable SPARK_RAPIDS_TEST_INJECT_OOM_SEED to override.
2023-04-19 16:11:25 INFO     Executing global initialization tasks before test launches

Marking it as draft. Holding it off until Databricks-11.3 shim is in.

build

build


Display overlapped

Looks like this UI is still work in progress.

Hi @VivekBuzruk thanks for your note. Yes, the UI is still in progress, but we'll get this overlap sorted out soon!

Noted and fixed in PR.


[iOS]Fix image comparison failed on Xcode 14.1

Image data comparison failed even though the data is the same on Xcode 14.1.
Fixes #573

Cool, thanks @alanchenboy for the fix and @mwilsnd for the review. I'm excited to see our ios-ci green again!

I restarted the ios-ci build due to this weird issue file I/O issue:
https://github.com/maplibre/maplibre-gl-native/actions/runs/3696507920/jobs/6260295754#step:14:3099
NSFileHandle couldn't write. Error: Error Domain=NSCocoaErrorDomain Code=512 "The file couldn’t be saved." UserInfo={NSUnderlyingError=0x6000009d9140 {Error Domain=NSPOSIXErrorDomain Code=32 "Broken pipe"}}
Test Suite iosapp UITests.xctest started
[3087](https://github.com/maplibre/maplibre-gl-native/actions/runs/3696507920/jobs/6260295754#step:14:3088)
iosapp_UITests
[3088](https://github.com/maplibre/maplibre-gl-native/actions/runs/3696507920/jobs/6260295754#step:14:3089)
/Library/Ruby/Gems/2.6.0/gems/xcpretty-0.3.0/lib/xcpretty/parser.rb:434:in `===': invalid byte sequence in US-ASCII (ArgumentError)
[3089](https://github.com/maplibre/maplibre-gl-native/actions/runs/3696507920/jobs/6260295754#step:14:3090)
	from /Library/Ruby/Gems/2.6.0/gems/xcpretty-0.3.0/lib/xcpretty/parser.rb:434:in `update_test_state'
[3090](https://github.com/maplibre/maplibre-gl-native/actions/runs/3696507920/jobs/6260295754#step:14:3091)
	from /Library/Ruby/Gems/2.6.0/gems/xcpretty-0.3.0/lib/xcpretty/parser.rb:307:in `parse'
[3091](https://github.com/maplibre/maplibre-gl-native/actions/runs/3696507920/jobs/6260295754#step:14:3092)
	from /Library/Ruby/Gems/2.6.0/gems/xcpretty-0.3.0/lib/xcpretty/formatters/formatter.rb:88:in `pretty_format'
[3092](https://github.com/maplibre/maplibre-gl-native/actions/runs/3696507920/jobs/6260295754#step:14:3093)
	from /Library/Ruby/Gems/2.6.0/gems/xcpretty-0.3.0/lib/xcpretty/printer.rb:19:in `pretty_print'
[3093](https://github.com/maplibre/maplibre-gl-native/actions/runs/3696507920/jobs/6260295754#step:14:3094)
	from /Library/Ruby/Gems/2.6.0/gems/xcpretty-0.3.0/bin/xcpretty:84:in `block in <top (required)>'
[3094](https://github.com/maplibre/maplibre-gl-native/actions/runs/3696507920/jobs/6260295754#step:14:3095)
	from /Library/Ruby/Gems/2.6.0/gems/xcpretty-0.3.0/bin/xcpretty:83:in `each_line'
[3095](https://github.com/maplibre/maplibre-gl-native/actions/runs/3696507920/jobs/6260295754#step:14:3096)
	from /Library/Ruby/Gems/2.6.0/gems/xcpretty-0.3.0/bin/xcpretty:83:in `<top (required)>'
[3096](https://github.com/maplibre/maplibre-gl-native/actions/runs/3696507920/jobs/6260295754#step:14:3097)
	from /usr/local/bin/xcpretty:23:in `load'
[3097](https://github.com/maplibre/maplibre-gl-native/actions/runs/3696507920/jobs/6260295754#step:14:3098)
	from /usr/local/bin/xcpretty:23:in `<main>'
[3098](https://github.com/maplibre/maplibre-gl-native/actions/runs/3696507920/jobs/6260295754#step:14:3099)
2022-12-14 16:05:39.076 xcodebuild[82042:37411378] NSFileHandle couldn't write. Error: Error Domain=NSCocoaErrorDomain Code=512 "The file couldn’t be saved." UserInfo={NSUnderlyingError=0x6000017a0180 {Error Domain=NSPOSIXErrorDomain Code=32 "Broken pipe"}}
[3099](https://github.com/maplibre/maplibre-gl-native/actions/runs/3696507920/jobs/6260295754#step:14:3100)
2022-12-14 16:05:39.105 xcodebuild[82042:37411378] NSFileHandle couldn't write. Error: Error Domain=NSCocoaErrorDomain Code=512 "The file couldn’t be saved." UserInfo={NSUnderlyingError=0x6000009e7600 {Error Domain=NSPOSIXErrorDomain Code=32 "Broken pipe"}}

I'm not sure it's worth root causing, but I did restart the build from main to ensure we go green.  And indeed this action is now showing green.

Thank for contributing to FOSS4G, @alanchenboy!!

Hi @roblabs, The failing CI is caused by the main branch, and I already fix it https://github.com/maplibre/maplibre-gl-native/pull/599.
After rebasing all Unit tests passed.


Please merge revision 00396f5df0b2a9c471a760af9e55cbe5a5acb39b into dev channel

@whesse @mit-mit @kasperl
This updates dartdoc to a version with a fix for annotations showing up as raw html. Better docs for the sdk.
rev 00396f5df0b2a9c471a760af9e55cbe5a5acb39b

@keertip, can you share some more details on what was resolved here (like a screenshot of the incorrect output or something like that). We are trying to access the impact of this issue.

On methods that return Future with no generics, the return type does not show up in the docs.

Annotations sometimes show up as raw html.

The first issue is more prevalent and would be good to get fixed.

Merged to dev 426edff01629bb92ac8e88f27ae25404c35f769b


Request-password protect, prevent closing? Repeat...

Hello, thanks for you program..I want ask you about this issue...https://github.com/hovancik/stretchly/issues/286
Is it possible? For child computer, not only sysadmin..

Hi @itProfi , can you specify how do you imagine it would work?
The issue, in general, is that Stretchly is regular app, thus user/child can easily close the app from Task manager or command line and such.
I think approach would be to try to find some app that prevents child from closing specific app? I am not sure whether such a thing exists.

Hi @itProfi , can you specify how do you imagine it would work?
The issue, in general, is that Stretchly is regular app, thus user/child can easily close the app from Task manager or command line and such.
I think approach would be to try to find some app that prevents child from closing specific app? I am not sure whether such a thing exists.


WIP: Adds Replicate LLM

Current implementation supports public endpoints (like the one used in the example). I couldn't find a way to not get a stream.
For deployments I have another implementation that works, but not with public deployments:
    self.deployment = replicate.deployments.get(endpoint_url)
    def _text_generation_with_backoff(self, prompt: str) -> Any:
        prediction = self.deployment.predictions.create(
            input={
                "prompt": prompt,
                "max_new_tokens": self.max_new_tokens,
                "temperature": self.temperature,
            },
        )
        prediction.wait()
        return prediction.output

I think we should support both public (the easiest for newcomers) and private deployments.

Hi here! I'm tackling this now, and I'm afraid the output will most likely be an iterator so we'll need to wrap it around with list(output), see the lines below from replicate-python
https://github.com/replicate/replicate-python/blob/cd09db0691a96c3c299e1f9ac374d420bb4adbdd/replicate/run.py#L46-L47
But w.r.t. the stream, we can just pass the flag stream=False, I'll open a PR later today so that you can review!


[Fix] Add option to disable authenticate() for some browsers as temporary fix

Currently we have few wallets, which doesnt work correctly :

Metamask internal browser can't work correctly with attestation.id
Android Alphawallet cant sign data when private key was imported

so we need some way to notify user that current browser not supported and throw error if user use it. We need this check at step clientInstance.authenticate()
example code by @snowwhitedev to find out that its wallet-internal-browser is:
https://github.com/AlphaWallet/attestation.id/pull/152/files
so in case if we find out that some browser have problem then we can add it to the list and stop user use it until we fix issue.
@AW-STJ @micwallace @BastianAlpha

Thanks @oleggrib, I'll look into this in the current sprint.

@snowwhitedev , did you test your code snippet?  https://github.com/AlphaWallet/attestation.id/pull/152/files
Does it separate Android Chrome from Metamask internal wallet?

@snowwhitedev , did you test your code snippet? https://github.com/AlphaWallet/attestation.id/pull/152/files Does it separate Android Chrome from Metamask internal wallet?

Yeah. I tested it in Android Metamask internal browser

Yeah. I tested it in Android Metamask internal browser

yes, but it matches Android Chrome too, so we cant use this way to detect Wallet Internal browser @snowwhitedev

@nicktaras , I updated your script to detect MEW, Alphawallet, Metamask, ImToken
https://testshop.antopolbus.rv.ua/agent/agent.html
you can use it in TokenNegotiator.
just have to note that window.ethereum.isMetaMask == true for multiple wallet browsers, so it can help us prevent to use untested wallet browsers
@micwallace @AW-STJ

Closing this ticket, we not have fixes and this fall back logic in place to inform users when their browser is not supported.


Fix typo in AsciiPrinter

Found a misspelling.
Please consider using typos.

hi, thanks for taking the time to create these pull requests. I'm closing them however as this package is nowhere near ready for contributions of any kind, they will only get overwritten. if you subsequently use this package in the future, feel free to make pull requests against it :slightly_smiling_face:


[Bug] Problematic logging while using multiple jwtbearer schemes

Which version of Microsoft.IdentityModel are you using?
Note that to get help, you need to run the latest version.
8.0.0
Where is the issue?

[X] M.IM.JsonWebTokens

Is this a new or an existing app?
a. It's an old application, previously using custom authentication technique. Now it's being migrated to utilize mechanisms provided in this repo.
Repro
private static void AddXXXScheme(this AuthenticationBuilder builder, SecurityTokenServer tokenServer)
{
    builder.AddJwtBearer(tokenServer.Id, _ =>
    {
        _.Authority = tokenServer.ServerAddress.ToLower();
        _.Audience = tokenServer.Audience;
        _.RequireHttpsMetadata = !tokenServer.AllowHTTP;
        _.MapInboundClaims = false;
        _.TokenValidationParameters = new()
        {
            RequireExpirationTime = true,
            RequireSignedTokens = true,
            ValidateLifetime = true,

            ValidateAudience = !string.IsNullOrEmpty(tokenServer.Audience),
            ValidateIssuer = false,

            NameClaimType = XXXClaims.IdentityName,
        };
        _.Events = new()
        {
            OnTokenValidated = JwtBearerEventHandlers.OnTokenValidated(tokenServer),
        };
    });
}

(...)

public static AuthenticationBuilder AddFcoAuthentication(this IServiceCollection services, IConfiguration configuration)
{
    var builder = services.AddAuthentication(JwtBearerDefaults.AuthenticationScheme);

    foreach (var tokenServer in AuthenticationConfiguration.TokenServers)
    {
        builder.AddXXXScheme(tokenServer);
    }

    return builder;
}

Expected behavior
When token is authenticated by one of the schemes, no exceptions are logged.
Actual behavior
Too many exceptions are logged which makes unnecessary mess in Application Insights.
Proof:
Green boxes shows that 3 out of 4 schemes do not authenticate provided token.

Can be closed....


Minor RNAseq test improvements (resolves #352)

dedup some of the URLs
more robust assertions and clean-up

Nice! LGTM — Thanks for the "piggybacking" explanation.

small error on line 14: log = logging.getLogget(__name__)

I'm clearly f'ing this up royally …


SyncErrorCategory.resolve

Add SyncErrorCategory.resolve, SyncResolveError and SyncResolveErrorCode for network resolution errors when sync.
The error is handled at syncErrorHandler in FlexibleSyncConfiguration.
Fixes #676

Todo: add more tests after https://github.com/realm/realm-core/issues/6015 is fixed.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 6 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 89.036%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/src/configuration.dart
0
6
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
2826

Relevant Lines:
3174

💛  - Coveralls


fix(Tabset): refactored tabs to avoid flicker

I was experiencing some bad flicker, whereby adding a new tab would cause content from both the new tab and the previous tab to appear at the same time, until the 'active' class had been removed from the old pane.
I believe the cause of the issue was due to the chained usage of tab.active to call tab.active on all the other tabs. Besides from solving the flicker issue, having Tabset coordinate the tabs via listening to tab events and then updating the other tabs makes more sense to me. ie. A tab should be aware of itself only, and the the tabset is aware of all tabs.

hey, I got your idea, but tabs should be rewritten to use @ViewChildren stuf :)

@valorkin I'm happy to do it. Do you agree with this method - http://juristr.com/blog/2016/02/learning-ng2-creating-tab-component/ ??

@jhuntoo it will be so cool if you can do it :D

Closing it for now


Fix typo in tracking_response.rb

Fixes possible typo on line 85

Thanks!

In general, you could roll these all up into one PR. #401 #402 #403


Add overloads of OperationTelemetry Start/Stop extension methods

Background:
In https://github.com/Microsoft/ApplicationInsights-aspnetcore/pull/343 I mentioned that it would be useful to have overloads of Start and Stop which take a timestamp so that we can use the timestamps already supplied by the diagnostic listeners and avoid additional calls to Stopwatch.GetTimestamp()
Once this is available in ApplicationInsights-dotnet, it can be consumed in ApplicationInsights-aspnetcore.

Hi @pharring, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Paul Harrington). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


neomutt installing with no sidebars

NeoMutt 20160916 (1.7.0)
configure options end up:
Configure options: '--disable-dependency-tracking' '--disable-warnings' '--prefix=/usr/local/Cellar/neomutt/20160916' '--with-ssl=/usr/local/opt/openssl' '--with-sasl' '--with-gss' '--enable-imap' '--enable-smtp' '--enable-pop' '--enable-hcache' '--with-tokyocabinet' '--disable-nls' '--disable-debug' 'CC=clang'
What's missing there is --enable-sidebar, for some reason, although the version of neomutt built does include the patches.
I tried to look at the underlying .rb file used, but I'm not familiar enough with homebrew to understand how to fix it.
My somewhat blind stab-in-the-dark guess is that it's the disparity between line 11:
https://github.com/neomutt/homebrew-neomutt/blob/master/Formula/neomutt.rb#L11 where the option is set as "with-sidebar-patch" but down in line 57:
https://github.com/neomutt/homebrew-neomutt/blob/master/Formula/neomutt.rb#L57 seems to be expecting "sidebar-patch" as the option?  If that is the problem, it looks like notmuch will have the same one.

The options are passed to configure if the formula is built with the corresponding flags, for example:
$ brew install neomutt --with-sidebar-patch --with-notmuch-patch

Closing as I think this has been addressed. Please leave a comment if this isn't the case.

I just started using Neomutt and it took me a little time to realize that the sidebar patch wasn't applied by default... I may be mistaken but aren't those patches the whole point of using Neomutt instead of vanilla Mutt? Is there a reason to not include those patches by default?

I think the point is more that those patches are available, and that NeoMutt is very much more open to accepting additional patches. Still, I get your point (I always include the sidebar patch), so I've opened issue #16 to discuss.

I hate to raise an issue from the grave here, but @telemachus points out in issue #16 that

as of 1.7.0 mutt has merged the sidebar patch

yet I still need to specify --with-sidebar-patch when installing neomutt (v1.8.2) to get it enabled (otherwise, set sidebar_visible throws the following error:
sidebar_visible: unknown variable

I can confirm that vanilla mutt indeed features the sidebar (had it working just before replacing mutt with neomutt), whereas neomutt somehow needs the patch applied to get it?

The sidebar code is in both upstream Mutt and NeoMutt, it's just not enabled by default.
The Homebrew option is a little misleading, it's not patching anything, it's just enabling code.
NeoMutt is planning to enable some features by default as long as they don't have any build dependencies.

Ah, I was confused then because I didn't have to set any install flags to get the sidebar in vanilla mutt – its homebrew formula must include the sidebar option by default.
Thanks for the clarification.


Incomplete example/instruction

I'm trying to check if I can make this works but I found a minor issue and a bigger one looking at the example https://rithvikvibhu.github.io/GHLocalApi/#section/Google-Home-Local-API/Example
The minor one is that isn't reported jq as a prerequisite.
The bigger one is that I can't find any info about the content of /path/to/protos in
./grpcurl -H 'authorization: Bearer ya29.a0Af****' \
  -import-path /path/to/protos \
  -proto /path/to/protos/google/internal/home/foyer/v1.proto \
  googlehomefoyer-pa.googleapis.com:443 \
  google.internal.home.foyer.v1.StructuresService/GetHomeGraph | jq '.home.devices[] | {deviceName, localAuthToken}'

I was lucky enought to find https://github.com/rithvikvibhu/GHLocalApi/issues/39#issuecomment-644959103
I don't know why the protos aren't available or mentioned elsewere (that I can found) but it was pretty hard to figure it out as I never user grpcurl
I think that the instruction should be updated. Let me know if I can work on a PR

isn't reported jq as a prerequisite

Ah yes, I think there was another issue about jq not being installed. Will add a comment with each example.

can't find any info about the content of /path/to/protos

The drive link is listed under prerequisites. Maybe adding a note that /path/to/protos/ should point to the Proto files folder will clear things up.

Let me know if I can work on a PR

Yes, please. I'll merge it when you make one.


app.hide() needs to be implemented in the aggro ux

                app_name = str(app.bundleIdentifier())
                app_bundle = str(app.bundleURL())
                if app_bundle:
                    # The app bundle contains file://, quoted path and trailing slashes
                    app_bundle_path = unquote(urlparse(app_bundle).path).rstrip('\/')
                    # Add Software Update pane or macOS upgrade app to acceptable app list
                    if app_bundle_path == PATH_TO_APP:
                        ACCEPTABLE_APPS.append(app_name)
                else:
                    # Some of the apps from NSWorkspace don't have bundles, so force empty string
                    app_bundle_path = ''
                # Hide any apps that are not in acceptable list or are not the macOS upgrade app
                if (app_name not in ACCEPTABLE_APPS) or (app_bundle_path != PATH_TO_APP):
                    app.hide()
                    # Race condition with NSWorkspace. Python is faster :)
                    time.sleep(0.001)```

Fixed with: https://github.com/macadmins/nudge/pull/79


How to spin it up

Adds "how to spin it up" section to the README and updates to @mapbox/cloudfriend
resolves #2
cc @rclark

This repo is public -- can we change the directions to use cfn-config instead of mbxcli?

@rclark yep I can do that - how do you suggest viewing logs? Just through the UI task by task?

Yeah, UI is probably the most common / straightforward approach?

@rclark great- updated the README with cfn-config (good catch 😅 )

Thanks @mapsam!

Here we go!


[Feature]: Support latest stable version of Yarn by default

What problem does this feature solve?
As of writing, the latest version of Yarn is v4.3.1.

https://github.com/yarnpkg/berry/releases

Your quickstart says using Yarn is an option:

https://rspress.dev/guide/start/getting-started

But Yarn v4.3.1 uses Yarn PnP https://yarnpkg.com/features/pnp for node packages installation strategy by default, which Rspack does not seem to support.
Feature request:

Short term, until Rspack supports Yarn PnP: Detect if project was initialized with yarn create rspress and create .yarnrc.yml with content nodeLinker: node-modules. This will tell Yarn to use the node default node-modules directory for installing node packages. Then yarn run dev works.
Long term: Support Yarn PnP.

Repro short recipe, using Yarn v4.3.1, everything default
yarn create rspress@latest
cd .\rspress-site\
yarn install
yarn run dev

With output on my system
PowerShell Core v7.4.3 x64
PS C:\Users\olav.birkeland\Desktop\tes> yarn create rspress@latest
➤ YN0000: · Yarn 4.3.1
➤ YN0000: ┌ Resolution step
➤ YN0085: │ + create-rspress@npm:1.26.0
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0013: │ A package was added to the project (+ 383.84 KiB).
➤ YN0000: └ Completed
➤ YN0000: ┌ Link step
➤ YN0000: └ Completed
➤ YN0000: · Done in 0s 213ms

√ Project folder ... rspress-site
√ Site Title ... Rspress
√ Site Description ... Rspack-based Static Site Generator

Done. Now run:

cd rspress-site

yarn install

yarn run dev

PS C:\Users\olav.birkeland\Desktop\tes> cd .\rspress-site\
PS C:\Users\olav.birkeland\Desktop\tes\rspress-site> yarn install
! The local project doesn't define a 'packageManager' field. Corepack will now add one referencing<EMAIL_ADDRESS>! For more details about this field, consult the documentation at https://nodejs.org/api/packages.html#packagemanager

➤ YN0000: · Yarn 4.3.1
➤ YN0000: ┌ Resolution step
➤ YN0085: │ + @types/node@npm:16.18.101, rspress@npm:1.26.0, @babel/runtime@npm:7.24.7, and 479 more.
➤ YN0000: └ Completed in 1s 943ms
➤ YN0000: ┌ Post-resolution validation
➤ YN0086: │ Some peer dependencies are incorrectly met by dependencies; run yarn explain peer-requirements for details.
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0013: │ A package was added to the project (+ 294.16 KiB).
➤ YN0000: └ Completed in 0s 215ms
➤ YN0000: ┌ Link step
➤ YN0000: │ ESM support for PnP uses the experimental loader API and is therefore experimental
➤ YN0007: │ core-js@npm:3.37.1 must be built because it never has been before or the last one failed
➤ YN0000: └ Completed in 6s 528ms
➤ YN0000: · Done with warnings in 8s 770ms
PS C:\Users\olav.birkeland\Desktop\tes\rspress-site> yarn run dev
🔥 Rspress v1.26.0

  > Network:  http://<IP_ADDRESS>:3000/
  > Network:  http://localhost:3000/
  > Network:  http://<IP_ADDRESS>:3000/

start   Compiling...
error   Compile error:
Failed to compile, check the errors for troubleshooting.
× Resolve error: Can't resolve 'C:\Users\olav.birkeland\AppData\Local\Yarn\Berry\cache\<EMAIL_ADDRESS>in 'C:\Users\olav.birkeland\Desktop\tes\rspress-site'

× Resolve error: Can't resolve 'C:\Users\olav.birkeland\AppData\Local\Yarn\Berry\cache\<EMAIL_ADDRESS>in 'C:\Users\olav.birkeland\Desktop\tes\rspress-site'

× Resolve error: Can't resolve 'C:\Users\olav.birkeland\Desktop\tes\rspress-site\.yarn\__virtual__\@rspack-plugin-react-refresh-virtual-e774b93185\4\AppData\Local\Yarn\Berry\cache\<EMAIL_ADDRESS>in 'C:\Users\olav.birkeland\Desktop\tes\rspress-site'

× Resolve error: Can't resolve 'C:\Users\olav.birkeland\AppData\Local\Yarn\Berry\cache\<EMAIL_ADDRESS>in 'C:\Users\olav.birkeland\Desktop\tes\rspress-site'

× Error: [html-rspack-plugin]: Child compilation failed:
  │   × Resolve error: Can't resolve 'C:\Users\olav.birkeland\AppData\Local\Yarn\Berry\cache\<EMAIL_ADDRESS>in 'C:\Users\olav.birkeland\Desktop\tes\rspress-site'
  │
  │     at C:\Users\olav.birkeland\Desktop\tes\rspress-site\.yarn\__virtual__\html-rspack-plugin-virtual-ad2ec0b608\4\AppData\Local\Yarn\Berry\cache\html-rspack-plugin-npm-6.0.0-beta.3-e2e78ff833-10c0.zip\node_modules\html-rspack-plugin\lib\child-compiler.js:174:18
  │     at finalCallback (C:\Users\olav.birkeland\Desktop\tes\rspress-site\.yarn\__virtual__\@rspack-core-virtual-b1014f7446\4\AppData\Local\Yarn\Berry\cache\@rspack-core-npm-1.0.0-alpha.2-a7f9e1c38a-10c0.zip\node_modules\@rspack\core\dist\Compiler.js:348:17)
  │     at C:\Users\olav.birkeland\Desktop\tes\rspress-site\.yarn\__virtual__\@rspack-core-virtual-b1014f7446\4\AppData\Local\Yarn\Berry\cache\@rspack-core-npm-1.0.0-alpha.2-a7f9e1c38a-10c0.zip\node_modules\@rspack\core\dist\Compiler.js:375:20
  │     at C:\Users\olav.birkeland\Desktop\tes\rspress-site\.yarn\__virtual__\@rspack-core-virtual-b1014f7446\4\AppData\Local\Yarn\Berry\cache\@rspack-core-npm-1.0.0-alpha.2-a7f9e1c38a-10c0.zip\node_modules\@rspack\core\dist\Compiler.js:471:28
  │     at done (C:\Users\olav.birkeland\AppData\Local\Yarn\Berry\cache\@rspack-lite-tapable-npm-1.0.0-alpha.2-cf220543eb-10c0.zip\node_modules\@rspack\lite-tapable\dist\index.js:478:13)
  │     at AsyncSeriesHook.callAsyncStageRange (C:\Users\olav.birkeland\AppData\Local\Yarn\Berry\cache\@rspack-lite-tapable-npm-1.0.0-alpha.2-cf220543eb-10c0.zip\node_modules\@rspack\lite-tapable\dist\index.js:485:20)
  │     at AsyncSeriesHook.callAsync (C:\Users\olav.birkeland\AppData\Local\Yarn\Berry\cache\@rspack-lite-tapable-npm-1.0.0-alpha.2-cf220543eb-10c0.zip\node_modules\@rspack\lite-tapable\dist\index.js:88:21)
  │     at C:\Users\olav.birkeland\Desktop\tes\rspress-site\.yarn\__virtual__\@rspack-core-virtual-b1014f7446\4\AppData\Local\Yarn\Berry\cache\@rspack-core-npm-1.0.0-alpha.2-a7f9e1c38a-10c0.zip\node_modules\@rspack\core\dist\Compiler.js:467:41
  │     at C:\Users\olav.birkeland\Desktop\tes\rspress-site\.yarn\__virtual__\@rspack-core-virtual-b1014f7446\4\AppData\Local\Yarn\Berry\cache\@rspack-core-npm-1.0.0-alpha.2-a7f9e1c38a-10c0.zip\node_modules\@rspack\core\dist\Compiler.js:534:23

PS C:\Users\olav.birkeland\Desktop\tes\rspress-site>

What does the proposed API look like?
I have no idea.

Thanks, we can add .yarnrc.yml before Rspack supports PnP. PR welcome 😄
Related Rspack issue: https://github.com/web-infra-dev/rspack/issues/2236


ssh-agent management plugin

Feature: sshagent management
Reference implementation of ssh-agent manager plugin. when you enable it, it keeps an agent alive across all your sessions.

opinionated pid management using file in ~/.ssh
support for shared filesystem { the file contains hostname :) }
I've been using it since 2015 :)

Closing this since the implementation is tracked in #1017.
Thanks for the contribution!


Fix signup message url check

Whats changed
This pull request updates the signup message logic displayed on the signup form. Previously, the message would still be displayed even when the signupURL value was empty.
Why this is necessary
Application that do not want people to signup (Think about invite only applications) probably do not want people to make their own account and will probably disable user registration in the ory console.

The problem is that in Ory Elements in the UserAuthCard component there will still be a message telling people that they could signup bringing some confusion because the URL will either not work or not lead to anywhere.

This PR will not define the message when additionalProps.signupURL is undefined.
This is what the expected end result would look like:

Checklist

[x] I have read the contributing guidelines and signed the CLA.
[ ] I have referenced an issue containing the design document if my change introduces a new feature.
[x] I have read the security policy.
[x] I confirm that this pull request does not address a security vulnerability.
If this pull request addresses a security vulnerability,
I confirm that I got green light (please contact<EMAIL_ADDRESS>from the maintainers to push the changes.
[x] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added necessary documentation within the code base (if appropriate).

Further comments
Since I am making this PR on windows I wasn't able to get storybooks running which is why I had to upgrade the version to 7.0.4.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @Copystrike,
Thank you for your efforts on this PR. I am unfortunately not going to accept this PR since it changes a lot of configs for vite which we use to bundle the components into libraries.
There is also another PR open which has a similar implementation with minimal code changes here (https://github.com/ory/elements/pull/109).


Invalid Name: More exact error message

Names are not allowed to contain uppercase letters. Explicitly state this in the error message.

Thanks! Merged :)


HOW TO GET LIST OF BUCKETS

How to get list of all buckets in my aws account using API call?

Hi @mkhan3088 ,
You can find sample code for simple api uses in this repo.
Hope this helps and next time please use the issue templates.


Handle interupts on PHP7

Fix for https://github.com/Behat/Behat/issues/832
It appears that the scoping of the declare statement prevents ticks from being emitted on PHP7. This PR decorates StepTester to declare ticks during step testing and therefore allow interrupts to occur mid-spec.
I initially looked at decorating a class in Testwork so that this code was closer to the SigintController but Testwork only goes as far as the suite level if I have understood things correctly.
On reading the documentation for declare(ticks = 1) it almost seems like the behaviour prior to PHP7 may have been a bug, and things are now behaving as expected (might explain the lack of response on the PHP bug filed?).

:+1:

:+1:

👍


xcode error: libobjc.A.dylib`objc_msgSend

I'm not sure what's causing this, but I started getting this error in Xcode when I tried running my app. I have gotten the plugin to work, but now I get this error. It happens right after the "Resetting Plugins due to page load" message in Xcode.
Anyone know what this is?
libobjc.A.dylib`objc_msgSend:
0x305cef60 <+0>:  cbz    r0, 0x305cef9e            ; <+62>
0x305cef62 <+2>:  ldr.w  r9, [r0]
->  0x305cef66 <+6>:  ldrh.w r12, [r9, #0xc]
0x305cef6a <+10>: ldr.w  r9, [r9, #0x8]
0x305cef6e <+14>: and.w  r12, r12, r1
0x305cef72 <+18>: add.w  r9, r9, r12, lsl #3
0x305cef76 <+22>: ldr.w  r12, [r9]
0x305cef7a <+26>: teq.w  r12, r1
0x305cef7e <+30>: bne    0x305cef86                ; <+38>
0x305cef80 <+32>: ldr.w  r12, [r9, #0x4]
0x305cef84 <+36>: bx     r12
0x305cef86 <+38>: cmp.w  r12, #0x1
0x305cef8a <+42>: blo    0x305cef98                ; <+56>
0x305cef8c <+44>: it     eq
0x305cef8e <+46>: ldreq.w r9, [r9, #0x4]
0x305cef92 <+50>: ldr    r12, [r9, #8]!
0x305cef96 <+54>: b      0x305cef7a                ; <+26>
0x305cef98 <+56>: ldr.w  r9, [r0]
0x305cef9c <+60>: b      0x305cf1e0                ; _objc_msgSend_uncached
0x305cef9e <+62>: mov.w  r1, #0x0
0x305cefa2 <+66>: bx     lr
0x305cefa4 <+68>: nop
0x305cefa6 <+70>: nop
0x305cefa8 <+72>: nop
0x305cefaa <+74>: nop
0x305cefac <+76>: nop
0x305cefae <+78>: nop
0x305cefb0 <+80>: nop
0x305cefb2 <+82>: nop
0x305cefb4 <+84>: nop
0x305cefb6 <+86>: nop
0x305cefb8 <+88>: nop
0x305cefba <+90>: nop
0x305cefbc <+92>: nop
0x305cefbe <+94>: nop

I turned on NSZombie because of this stackoverflow suggestion:
http://stackoverflow.com/questions/5386160/how-to-enable-nszombie-in-xcode
It now gives me this error:
2015-08-28 12:30:31.941 Fridge Alive[1224:198565] *** -[UIViewAnimationState _accessibilitySetAnimationsInProgress:]: message sent to deallocated instance 0x1864ca90
Anyone know what that is?

@zenmanenergy I haven't ever seen this. Can you provide a reproduction scenario?

I did quite a bit of googling on this and so far the best solution I had, which sucks, was to remove the IOS platform from cordova, then add it again. Basically rebuild the project from scratch. Now I'm not getting the errors.
I'm not convinced it had anything to do with the plugin, just something funky with xcode and it just happened to occur after I switched to this plugin. I'm going to close this issue for now.


Avatar from network

Hi,
Thanks for open sourcing this kit. I was wondering if it supports loading images from a network. I couldn't get that to work. Is there some widget that could be extended or something? Thanks.

Instead of using Image.asset, you just can just use Image.network. Or you can use any library you want. I use cached_network_image

Does the kit provide an API to change that, or do I have to fork this kit?

Why would you want to fork for this? You can do it exactly like it is done in the example application. Copy paste the code from chat_message_image.dart, change to use any library or loader that you like and use that Widget just like shown in chat_screen.dart.

Is it the groupAvatarBuilder property? BTW, I'm not willing to fork just for the this, only if there was no other way.

I figured it out. Thanks so much.


Addition of auto-comment.yml file

We need to add an auto-comment.yml that will automatically welcome, greet and provide necessary information to the contributors when they create new issues, PR, and when these will get assigned or merged respectively. This will promote motivation and performance
@codervivek5
Please assign me this issue under gssoc'23

Hey @codervivek5
I want to work on this issue if it is inactive.
Please assign me the same

Hello @abhinav-m22 I am working on this.


Unit test panel editAdmin

Coverage increased (+3.7%) to 100.0% when pulling c46606ec15a8ac06abde5a47fda8ceb10ca7dd88 on panel_editAdmin into b04b926f4c02337c8228847c6fee969744705782 on master.


Select branch for statistics

Depending on the development workflow the master branch could not be the most active one, or the one that makes sense to use for statistics. It would be nice the be able to select the branch on which to run git_stats.
If no one can take care of this I could be able to come up with a patch in the future. No guaranteed timeframe, though :)

I would be definitely interested in using this branch selecting. Any progress in this?


refactoring plus small fixes

Another small update with the following changes:

added a DMSRindexLOCAL.html (for dev/testing) with local JS and CSS files, but remote 3rd party libs
added/changed all console.logs in fetch.catch() with console.errors
fixed redirect after uploading in FSExplorer
fixed min. voltage in dashboard for 1 phase installations
restored width gauges
some other small fixes, see commits

You can ignore the new LOCAL.html. It was in one of the early commits and i dont know how to skip specific commits for pull-requests.