Add better error output to Epub.Write() for file retreval errors.

Just a first pass to debug an issue I had with an ebook generator I am making, but this makes Epub.Write give more detailed error messages by way of creating a type that implements error and returning it in place of ErrRetrievingFile

Coverage decreased (-0.3%) to 81.018% when pulling 6da030a84c0ad8eb5c7b95dab198b89ed4cace17 on AmandaCameron:more-detailed-errors into a35bddad17b51d5cb94f482014fdb417ea481944 on bmaupin:master.

This looks great!
Since the error can be thrown from the library's public interface, should it be public so users of the library can test for it?

I'll have to come up with another name for the type, in that case, because replacing ErrRetrievingFile with a type instead of a constant will be problematic for backwards compatibly.

Just pushed a commit that renames the type to FileRetrevialError and makes the fields in it public. This will let the user extract both the underlying error as well as the source file that had the error.
If there's any qualms about the name, I'm open to a better one, but since just usurping ErrRetrevingFile would cause problems, I opted for this instead.

Sorry it's taken me so long to get back to you. I had a few thoughts:

I'll have to come up with another name for the type, in that case, because replacing ErrRetrievingFile with a type instead of a constant will be problematic for backwards compatibly.

I agree. The version number is still going to need to be bumped since the public interface is going to change. As a side note, this is why I haven't tagged the library as v1.0 yet since I anticipated there'd be some breaking changes if anyone else used it.

Since this is the only place where ErrRetrievingFile is used, it should be removed as well

Since we're changing one of the errors, it might be best to go ahead and change all 3. That way they're the same type and can be tested the same way. This ensures consistency and predictability for users.

This isn't as important, but it'd probably be good to add either tests or examples (or both) so it's clear how these errors could be checked for. I had to spend a few minutes looking into this myself since it isn't as straightforward as err == ErrRetrievingFile. But this could be added later.

Unless all of the breaking changes can be done in one commit, would it be better to do the work in a separate branch?

What are your thoughts?
Thanks for your help!

...by the way, I'm not asking you to do all of this yourself. I'm mostly looking for feedback from someone else who is using the library.
Of course if you'd actually like to do the work you're more than welcome to. If not, I can probably get to it later next week since I'll be pretty busy the next few days.
Thanks again!

The Equivilent to err == ErrRetreivingFile would be something like if fileErr, ok := err.(*FileRetrevalError); ok { // fileErr is now a *FileRetrevalError }
I've just removed the ErrRetreivingFile,  but it required adding an ErrInvalidSource since it was actually used in addMedia in the case of an invalid file being passed.

Since we're changing one of the errors, it might be best to go ahead and change all 3. That way they're the same type and can be tested the same way. This ensures consistency and predictability for users.

As for this, I'm not so sure, although I'll be happy to change FileRetrevalError into something else, and use it as I did with the addMedia change.
As for testing, I'll be honetst: I"ve never been very good at isolating exaclty what needs testing.

No problem. If you don't mind waiting a little bit longer, once I've got some time later next week I'll take what you've done and then apply it to the other errors, add some tests, and tag a new release.
Thanks!

Certinely, no problem. I've already been using my fork ( andthis branch) in
my own project which needed this, so I'm in no rush. :)
On Sat, Sep 15, 2018 at 2:15 PM Bryan Maupin<EMAIL_ADDRESS>wrote:

No problem. If you don't mind waiting a little bit longer, once I've got
some time later next week I'll take what you've done and then apply it to
the other errors, add some tests, and tag a new release.
Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bmaupin/go-epub/pull/9#issuecomment-421610343, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAG_zgmAu8gL8_LLh-7GiEKfidDHfBWNks5ubUOjgaJpZM4WiSqc
.

I merged your commits, cleaned up a couple things, changed the other errors as well, and tagged a new release (v0.4.0). Thanks for your help!


Please add license

I would like to use this plugin but I don't see a license.  Can you please add one?
Perhaps Apache License 2.0
Thanks in advance

Excellent callout. MIT license just added


Docs Changes Needed from dbt-core Issue #10301

At a minimum, update body to include a link to the page on docs.getdbt.com requiring updates and what part(s) of the page you would like to see updated.

Closing as duplicate of https://github.com/dbt-labs/docs.getdbt.com/issues/5805


Add stripPathBefore option

This option allows the user to remove everything up to a certain point in the path when the module/file name are created. It comes in handy when you need more control over the paths.

It fixes the use case initially described in https://github.com/javoire/browserify-ng-html2js/issues/13 and may help on https://github.com/javoire/browserify-ng-html2js/issues/22

Great

would you mind adding this to the readme? https://github.com/javoire/browserify-ng-html2js#b-with-gulp

As you have already merged the PR, I created a new one with the addition in README.md.

Great. Yeah I was a bit quick ;)


Question about comparing 2 SQL queries with Numeric Only values

Hi Cédric,
This is question, not an actual issue, but I wan't sure where else to ask it (I couldn't find your contact details anywhere).
If I am using NBI to compare 2 SQL queries against each other, how can I specify that the columns in the results are always Numeric?
By default it assumes the column is text. So for example: my query 1 returns "4460.8700" which  does not equal "4460.87" (which my query 2 returns).
In the documentation (http://www.nbi.io/docs/compare-equivalence-resultsets/) it says:
"By default, NBi will take the assumption that the first column is a key (text) and the other columns are values (numeric without tolerance). This will influence the comparison’s result. If you want to override this configuration, you should read the documentation about 'result-set’s comparison configuration'."
Then I checked the link (http://www.nbi.io/docs/compare-equivalence-resultsets/) and it explains the different types of roles for columns. But it does not explain where to set up Numeric Only columns if I am comparing 2 SQL queries together.
I tried using the following test suite file (MyTestProject.nbits), but this does not work when I run it in NUnit:
(Please Note: I have removed the connection strings and the SQL queries from the example below):
`

     ...

     ...

`
This is the error I get when I try to run it in NUnit:
NBi.NUnit.Runtime.TestSuite.ExecuteTestCases:
System.ArgumentException : The test suite is not valid. Check with the XSD. 9 errors have been found during the validation of the test-suite:
At line 6: The 'index' attribute is not declared.
At line 6: The 'role' attribute is not declared.
At line 6: The 'type' attribute is not declared.
At line 6: The 'tolerance' attribute is not declared.
At line 6: The required attribute 'table' is missing.
At line 6: The required attribute 'perspective' is missing.
At line 6: The required attribute 'caption' is missing.
At line 8: The element 'system-under-test' in namespace 'http://NBi/TestSuite' has invalid child element 'execution' in namespace 'http://NBi/TestSuite'.
At line 29: The element 'equalTo' in namespace 'http://NBi/TestSuite' has invalid child element 'data-type' in namespace 'http://NBi/TestSuite'. List of possible elements expected: 'column, resultSet, query, xml-source' in namespace 'http://NBi/TestSuite'.
I also tried adding the "column"  tag inside the "query" tag but that didn't work either.
I have tried to look at NBi-TestSuite.xsd to see if that would help.
Can you please explain how to compare 2 SQL queries and specify that the columns in the results are Numeric?
Thanks.
Dave

Never mind, was able to figure this out.
Have to add the "column" tag(s) inside the "equalTo" tag


Access to static Java classes

There's currently no way to access static fields of a class without creating an instance of that class. The solution is most likely to create a parallel function to construct_java_object, construct_java_class, which just gets you a Python version of the class plus static methods + fields. This will require changes in core.py as well as in ZMQServer.java

Commenting on this to make @marktsuchida aware of the problem.  His new API design often makes use of static "Builder" classes to generate objects (such as the Coordinates builder), rather than give direct access to a Builder, Constructor, or have a method to generate the needed object.  Currently, there are deprecates methods that still make it possible to get things to work, but the planned API design combined with the current inability of Pycro-Manager to access static fields and methods is not a good thing.  I can not oversee how difficult it is to implement the changes you describe, but I would know how to avoid static fields an methods in the MM Java API.

It's certainly doable, though would take a bit of testing. However, I think that the static "Builder" paradigm is not something one encounters much in Python, and as such I wouldn't expect this to be very intuitive to someone with only Python experience. So in the interest of making this API more accessible it might be worth considering a regular constructor paradigm.

@nicost I'm not sure I understand what you mean by 'makes use of static "Builder" classes ... rather than give direct access to a Builder ...'. Are you referring to the fact that DefaultCoords and DefaultCoords.Builder are not in the public API and the fact that Coordinates.builder() is a static method? What would be the alternative?
I think there might be other possibility for the specific case of Coords, but surely you are not proposing that we eliminate all static (fields and) methods from the MMStudio Java API, are you?
Am I understanding correctly that this issue is about static fields and methods, rather than "static classes"?
Could you fill me in on what exactly is the technical difficulty in accessing static fields and methods? To me (without being aware of details) the approach @henrypinkard suggested above (of providing a proxy for the Java class object) makes perfect sense, especially because normal classes are also objects in Python -- it should feel natural (or as natural as cross-language access can be). It might also be useful to take a look at how other Python-to-Java interfaces (e.g. JPype) provide access to static fields and methods.

The fact that Coordinates.builder() is a static method.  Alternative is to have a non-static method that is part of the DataManager class, such as mm.data().coordsBuilder() (or similar).
Any solution is fine with me, and it would be simplest to have non-static methods available on the Java side to provide these Builders.  Also fine to patch pycro-manager to give access to static Java classes and methods, but that is certainly not something I would know how to do.  Given the cool things that pycromanager accomplishes, I do believe it should be a priority to ensure that the full MM api is available through this interface.

Hmm, I see. I guess it would be relatively harmless to re-add a coordsBuilder() to DataManager, as long as we keep the static Coordinates.builder(), though it's not ideal to have two ways to do the same simple thing.
Also, we could perhaps complement most, if not all, of the "collection of static methods" type of classes with instance versions. I haven't thought this through, but if we do this under uniform rules it should be cleaner than adding to the already crowded "managers". (Although I would prefer to have a good Java-oriented reason to do this, because it is anti-DRY.)
But it's hard enough to design a good API without arbitrary restrictions. I would be much more willing to help fix pycro-manager than try to contort the MMStudio API to fit these requirements in all cases.
Is there any particular technical difficulty in accessing static methods, or is it just work that needs to be done?

Work that needs to done but doesn't seem likely to be done any time soon

Not sure if this is useful to you (popped up on JPype search),   JPype uses Python class wrappers which are represent the class, its constructors, array contructors, and all static member fields.   The constructors are actually in a meta class one level up so that they don't appear in the instance type.  The instances of those classes hold the instance fields and methods and because they are class instances they inherit the static methods and fields.   The class actually has the instance methods and non static fields but those use the bound method pattern as descriptors in Python.   So if you give them a class instance they could be called statically from the class wrapper.  Last because JPype is to represent Java structures there is a property called class_ which is an instance of java.lang.Class holding all the reflection.   All of these are generated dynamically via reflection and Python meta class programming.
Most of this is given in great deal in the developer guide if you are interested in creating a similar wrapper type structure for your IPC based model (guessing based on the project description).
This does allow for builder type APIs to be used in Python.   The readability of this in Python is pretty high but as noted here may not be the most familiar to Python programmers.,
For example some code using a proprietary gamma ray radiation detection library that I develop
from gov.llnl.rtk.test import SampleGenerator
...
sgb = SampleGenerator.newBuilder(gsm)
b0 = sgb.add(bkg[0]).setTime(300).scaleToRate(1000).create()

Hope it helps.


Fix License format in settings.xml

The license section on top of settings.xml was breaking the build with the following message:

[ERROR] 1 problem was encountered while building the effective settings
[FATAL] Non-parseable settings /home/fstephany/.cache/bazel/_bazel_fstephany/27c3a2bea20cb16a5910ae7660b43507/external/com_android_support_appcompat_v7_27_0_0/settings.xml: processing instruction can not have PITarget with reserveld xml name (position: START_DOCUMENT seen ...\n<?xml ... @14:7)  @ /home/fstephany/.cache/bazel/_bazel_fstephany/27c3a2bea20cb16a5910ae7660b43507/external/com_android_support_appcompat_v7_27_0_0/settings.xml, line 14, column 7

oops, thank you.

No worries, thanks for the quick merge :)


Unzip bridge for android

The pkpass file is really just a zip file. We need to unzip it and store it to the file system.
We need a bridge which takes a function
unzip(zipFilePath: string, unzipFilePath: string) :Promise<string>

Let's try to use react-native-zip-archive first


[BUG] issues with Hertzbeat Security docs

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
The link to report a security issue on https://github.com/apache/hertzbeat/issues/new/choose is not ASF standard practice. It is my understanding that all security issues relating to ASF projects and podlings need to be reported to an ASF mailing list. The default is<EMAIL_ADDRESS>but some well established projects have mailing lists of form<EMAIL_ADDRESS>These mails are visible to the ASF Security team and this allows independent monitoring of whether ASF teams are dealing with reports.
I also think that https://github.com/apache/hertzbeat?tab=security-ov-file#readme should be updated to explicitly link to https://www.apache.org/security/ and to be much more explicit about the need to keep the issue private until the project team gets to look at the issue and if necessary, attempt a fix.
fyi @raboof
Expected Behavior
Follow standard ASF Security practices
Steps To Reproduce
No response
Environment
HertzBeat version(s):

Debug logs
No response
Anything else?
No response

Hi, thanks for pointing out that. We will update these docs.

The link to report a security issue on https://github.com/apache/hertzbeat/issues/new/choose is not ASF standard practice. It is my understanding that all security issues relating to ASF projects and podlings need to be reported to an ASF mailing list. The default is<EMAIL_ADDRESS>but some well established projects have mailing lists of form<EMAIL_ADDRESS>These mails are visible to the ASF Security team and this allows independent monitoring of whether ASF teams are dealing with reports.

Yes, we should disable the option to report security issues through GitHub Private Vulnerability Reporting, because it currently does not leave the correct audit log. Before disabling GitHub Private Vulnerability Reporting for Hertzbeat, though, we should double-check the issues reported through this mechanism have since been dealt with the ASF way. @tomsun28 can you (and the rest of the PPMC) double-check this?
Looking further ahead, we do want to enable projects to opt-in into accepting security issues through GitHub Private Vulnerability Reporting. However, before we can enable this, we must put into place the proper audit mechanisms. This is tracked in https://issues.apache.org/jira/browse/INFRA-25020 (private link).

I also think that https://github.com/apache/hertzbeat?tab=security-ov-file#readme should be updated to explicitly link to https://www.apache.org/security/

I agree that would be good. This might also be a good place to describe Hertzbeat's security model - see https://cwiki.apache.org/confluence/display/SECURITY/Documenting+your+security+model for more information on that.

Yes, we should disable the option to report security issues through GitHub Private Vulnerability Reporting, because it currently does not leave the correct audit log. Before disabling GitHub Private Vulnerability Reporting for Hertzbeat, though, we should double-check the issues reported through this mechanism have since been dealt with the ASF way. @tomsun28 can you (and the rest of the PPMC) double-check this?

Hi raboof thanks suggest. I have double checked that all security vulnerability reports since HertzBeat joined ASF incubator are been dealt with the ASF way. It seems that we dont have the permission to disable this option. I will ask infra team for help.

I agree that would be good. This might also be a good place to describe Hertzbeat's security model - see https://cwiki.apache.org/confluence/display/SECURITY/Documenting+your+security+model for more information on that.

yes we have just added the HertzBeat's security model doc. https://hertzbeat.apache.org/docs/help/security_model

Yes, we should disable the option to report security issues through GitHub Private Vulnerability Reporting, because it currently does not leave the correct audit log. Before disabling GitHub Private Vulnerability Reporting for Hertzbeat, though, we should double-check the issues reported through this mechanism have since been dealt with the ASF way. @tomsun28 can you (and the rest of the PPMC) double-check this?

Hi raboof thanks suggest. I have double checked that all security vulnerability reports since HertzBeat joined ASF incubator are been dealt with the ASF way. It seems that we dont have the permission to disable this option. I will ask infra team for help.

Thanks - I have disabled the feature.

I agree that would be good. This might also be a good place to describe Hertzbeat's security model - see https://cwiki.apache.org/confluence/display/SECURITY/Documenting+your+security+model for more information on that.

yes we have just added the HertzBeat's security model doc. https://hertzbeat.apache.org/docs/help/security_model

Awesome! It might be nice to add the documentation on how to privately report an issue to that page as well? Then you can replace the 'Security' link in the main menu with a link to that page.

Awesome! It might be nice to add the documentation on how to privately report an issue to that page as well? Then you can replace the 'Security' link in the main menu with a link to that page.

ok i will update these doc.


How does StarCoder-15b generates concept, instruction, and responses?

Is StarCoder-15b an instruct model itself? If not, how does it is utilized in concept, instruction, and response generation?

Hi, StarCoder-15b is a base model, and we use it to generate data and create starcoder2-instruct. The main pipeline code is here: https://github.com/bigcode-project/selfcodealign/blob/46749cceeb84cf1773deb5c157b04930acebc5cd/src/star_align/self_ossinstruct.py.

Thank you for getting back to me. I saw the code. Given a code snippet, isn't it hard to generate concepts/instructions for a base model? I saw the code and realized the prompt was quite simple and straight-forward. Did you evaluate how well the base model in generating concepts/instructions? Any analysis or findings from earlier experiments?

You can find the instructions from an earlier selfcodealign, starcoder2-instruct. Sorry the instructions for the new version has not been updated yet. It's mostly compatible with the old one, but we will release an updated README soon.
Regarding the analysis, the section 4.1 (Self-Alignment with Different Models) in our paper might be of your interest.


Gradients are not averaged when using GradientDescentOptimizer

When using the GradientDescentOptimizer the weights are updated using var.device(d) -= grad * lr();. The gradients are not averaged as we could expect. That why my model was working fine with a mini-batch gradient descent but not with the batch gradient descent.
The trick is to use GradientDescentOptimizer(1/m * 0.01) where m is the size of the batch.
The corresponding StackOverflow issue is here: http://stackoverflow.com/questions/43027109/tensorflow-weights-increasing-when-using-the-full-dataset-for-the-gradient-desce

The problem isn't the Optimizer, it's your loss. It should return the mean loss, not the sum. If you're doing an L2 regression, for instance, it should look like this:
l_value = tf.pow(tf.abs(ground_truth - predict), 2) # distance for each individual position of the output matrix of shape = (n_examples, example_data_size)
regression_loss = tf.reduce_sum(l_value, axis=1, name='regression_loss') # distance per example, shape = (n_examples, 1)
total_regression_loss = tf.reduce_mean(regression_loss, name='total_regression_loss') # mean distance of all examples, shape = (1)

My bad (facepalm).


Add a canonical set of performance tests.

Refactor setup_perf_cluster.sh to include a function for running
canonical tests.
Add a new "run_canonical_perf_tests.sh" for running a standard set of
perf tests.
Add a python file for converting the multiple json files into csv
format for use in spreadsheets. This gets called from within
"run_canonical_perf_tests.sh".

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
988abd5497fc3f59269564ccdd134c166f4b2920
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
988abd5497fc3f59269564ccdd134c166f4b2920
link
/test istio-unit-tests

prow/istio-presubmit.sh
988abd5497fc3f59269564ccdd134c166f4b2920
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
988abd5497fc3f59269564ccdd134c166f4b2920
link
/test istio-presubmit

prow/istio-unit-tests.sh
988abd5497fc3f59269564ccdd134c166f4b2920
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/hold

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
988abd5497fc3f59269564ccdd134c166f4b2920
link
/test istio-presubmit

prow/istio-unit-tests.sh
672982451f301d077490dd08f9585ae5f060fd49
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
672982451f301d077490dd08f9585ae5f060fd49
link
/test istio-unit-tests

prow/istio-presubmit.sh
672982451f301d077490dd08f9585ae5f060fd49
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Had to reintroduce the escaped percentages in the buckets list, as the previous one didn't work.

/retest

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-presubmit

prow/istio-unit-tests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-unit-tests

prow/istio-presubmit.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-presubmit

prow/istio-unit-tests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake can you update your review / unblock this - it's incremental progress and not claiming to be finished ?

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-unit-tests

prow/istio-presubmit.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake, could you PTAL and yay or nay? I'd like to make forward progress on this.
Thanks

/retest

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly , can I get another /lgtm?

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Good idea. I'll do that.
On Wed, Mar 7, 2018 at 10:53 AM Istio Auto Merge Robot <
<EMAIL_ADDRESS>wrote:

/test all [submit-queue is verifying that this PR is safe to merge]
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/3809#issuecomment-371237926, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQR8IyvAfYUXqjyifb-PxRt0nkVh0gWoks5tcCgogaJpZM4SVef6
.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Ok, updated Readme.md. PTAL.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
512c1a82cde59adb534d185455584c1dcc04a8a3
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
512c1a82cde59adb534d185455584c1dcc04a8a3
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
512c1a82cde59adb534d185455584c1dcc04a8a3
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
6bf916a0ba081240c8c306ed2a23735c85618f66
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
512c1a82cde59adb534d185455584c1dcc04a8a3
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
512c1a82cde59adb534d185455584c1dcc04a8a3
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
512c1a82cde59adb534d185455584c1dcc04a8a3
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
512c1a82cde59adb534d185455584c1dcc04a8a3
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
512c1a82cde59adb534d185455584c1dcc04a8a3
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
512c1a82cde59adb534d185455584c1dcc04a8a3
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
512c1a82cde59adb534d185455584c1dcc04a8a3
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

made a small change the the readme. will merge once the button gets green

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
512c1a82cde59adb534d185455584c1dcc04a8a3
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
512c1a82cde59adb534d185455584c1dcc04a8a3
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
3e19aff648b8ea09ea0cd0e366084d2035e5c6df
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
512c1a82cde59adb534d185455584c1dcc04a8a3
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
3e19aff648b8ea09ea0cd0e366084d2035e5c6df
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
3e19aff648b8ea09ea0cd0e366084d2035e5c6df
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
512c1a82cde59adb534d185455584c1dcc04a8a3
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
3e19aff648b8ea09ea0cd0e366084d2035e5c6df
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
3e19aff648b8ea09ea0cd0e366084d2035e5c6df
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
512c1a82cde59adb534d185455584c1dcc04a8a3
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
3e19aff648b8ea09ea0cd0e366084d2035e5c6df
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
3e19aff648b8ea09ea0cd0e366084d2035e5c6df
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
3e19aff648b8ea09ea0cd0e366084d2035e5c6df
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
3e19aff648b8ea09ea0cd0e366084d2035e5c6df
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
3e19aff648b8ea09ea0cd0e366084d2035e5c6df
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


make manager NT only

The manager seems to have a significant impact on performance; dry_run takes about 30% longer.  Let's disable it when we are not running on Windows.

Coverage decreased (-1.5%) to 82.637% when pulling 72b1c50423dddc78c6ea62d8435e241a80fb5539 on matt/manager_opt into d5edebaac201f3c9d4282a4af4204358cd5a672e on master.

Coverage decreased (-0.07%) to 84.086% when pulling 110d754b5d26b954e2ea458cd73b28f65a615320 on matt/manager_opt into d5edebaac201f3c9d4282a4af4204358cd5a672e on master.

Lgtm on green


Other circumstance change predictions besides income?

Would more alimony cause, etc. cause a cliff effect? Should there be other inputs one can change on the prediction section? It could be an option to add field, and then chose from a drop down with other input they want to edit.

That's definitely one of our wish-list items, and concrete wire frames about what that could look like would certainly be welcome.

Because this would be such a big change and would take so much work to implement, I'm putting this on the wish list and removing it from current issues. Thank you for the brainstorming!


Move chai-as-promised from prod to dev dependencies

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @paulmelnikow!

  Generated by :no_entry_sign: dangerJS against 1bb42fcd588d427d88ccfc360e4444ad61de7168


Two fields have autovalues, one overrides the other

Two of the fields in my collection have an autovalue, "score" and "rank".
The rank field uses the value of the score field for its calculation.
Whenever I run clean(), I first see the correct value of score in the console, but this is then overridden as soon as the logs of the rank autovalue come up.
Please see this issue for code and more details.

Yeah, autovalue isn't a great solution here. You can't predict the order in which they will run. I suggest a pre-save hook or some other solution outside of the schema.


BluetoothLEAdvertisementWatcher Received notifications stop

My UWP application runs in RPI 3 as a BLE GATT client. When started, the BluetoothLEAdvertisementWatcher correctly detects advertisements from the peripheral BLE devices to handle in its Received event handler. But persistently after about one hour the advertisements stop to be detected despite that I manually start the peripheral devices advertising.   I tried to solve this problem by looking at the BLE filters settings, etc. but nothing worked. Finally I made an application based on the BluetoothAdvertisement Scenario1_Watcher sample code and set up a timer to trace the BluetoothLEAdvertisementWatcher status. Even this simple application continued to show exactly the same problem. After the BluetoothLEAdvertisementWatcher stopped detecting advertisements, on a timer event I verified the BluetoothLEAdvertisementWatcher status. The status was still "Started".  No useful information was shown in the watcher object properties to help finding the reason for this behavior. Only a complete RPI power OFF-ON can reset the BLE stack to a working state and I have to restart my application in order to start detecting the peripheral devices advertisements for a while. Please advise me how to solve this problem.
Here is an update: the above described problem does not happen with the Dragonboard 410C.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 19628977-4829-d46d-d5c5-d4675f3c3f07
Version Independent ID: b091c621-c26f-e678-2f80-946b68172854
Content: Bluetooth Advertisements - UWP app developer
Content Source: windows-apps-src/devices-sensors/ble-beacon.md
Product: windows
GitHub Login: @msatranjr
Microsoft Alias: misatran

Ive seen this same thing.

Hi @ljfischer - This is not a developer doc issue, please try to find assistance from one of the following:

For developer issues, or suspected product bugs, there's Microsoft Support; a support engineer will look at the repro and see whether the issue is a Microsoft product bug, or something else. If it's a bug with a Microsoft product then the ticket will be free of charge.
The Feedback Hub app is the right place to lobby for a change, a feature, or to make a suggestion.
For community assistance with development questions, there are our forums, and StackOverflow.
The Windows developer support site explains other support options.
The Visual Studio developer community is available, and responsive. The former User Voice feature is now there on the Suggest a feature tab, if you want to lobby for a change, a feature, or to make a suggestion.

If you receive assistance via any support resource, and you believe that information would help us improve the docs, then please and let us know through this issue.


[BugFix] Fix bug MV refresh lose MAXVALUE

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #12270
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

[FE PR Coverage Check]
:disappointed: fail : 4 / 6 (66.67%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/scheduler/PartitionBasedMaterializedViewRefreshProcessor.java
4
6
66.67%
[293, 637]

run starrocks_admit_test

https://github.com/Mergifyio backport branch-2.4


Implement card refactor for editor-dom renderer

do not merge
Feedback welcome. Merging this needs to be coordinated with changes to other codebases as described in #235
fixes #236

seems good.


Add ssh tunnel support for kubernetes

Change-type: minor

@resin-ci retest

@hedss heya dude! Really good comments, and thanks for pointing them out! (That was a rather quick first approach.) Cheers!

Thanks m8!


ArcsExplorer using WebRTC for transport

A patch allowing connecting WebShell to a remote ArcsExplorer (different tab, machine, network, country). Can be useful for debugging of your colleagues issues, or to connect to a Shell loaded into a WebView on a device.
How to use:

Open https://servingpoint/shells/web-shell?remote-explore-key=yourkeyhere
Open https://servingpoint/devtools?remote-explore-key=yourkeyhere

Change yourkeyhere to something you would hope is unique.
This patch got re-written to no longer use external libraries. WebRTC signaling is done via firebase and WebRTC is used through native APIs.
There are some hacks introduced to work around message size limits. There will be a follow up patch that deals with this issue properly.

Things added with the new commit:

WebShell sends heartbeat to Explorer every 1 second. If Explorer doesn't receive it for 5 seconds it warns the user of lost connection and proposes a reload to connect again. This is intended to fix the issue of WebView killed/reloaded/restarted and stuck waiting for Explorer to appear, while developer is not aware what's happening.

WebShell is now lenient about disappearing Explorer. It will also change the status bar if that happens to reflect the state.

@sjmiles Could you please take a look at my changes to the WebShell? If remote Arcs Explorer is requested I'm only instantiating WebShell once explorer has connected.

@mmandlis could you take a look? @mykmartin is quite busy right now and I would like to get this in before I go on leave, so that Ray can use devtools with arcs-live...

@mmandlis You're too kind with such a quick review! Thanks a lot!!!


Purge feature does not work when installing EnMasse using OLM

Describe the bug
When installing EnMasse using OLM, the purge feature does not work.
This is due to missing permissions for the agent service account to create tokenreviews.

I note that the code with this defect has not been released, so was not part of release-0.31.


There are no instructions on how to create a pipeline when you are not the AD-admin of your organization

When choosing the "Docker, Build and push and image to Azure Container Registry" option under "Configure", I get the error "Failed to create an app in Azure Active Directory. Error: Insufficient privileges to complete the operation. Ensure that the user has permissions to create an Azure Active Directory Application.".
I don't have the privileges to create an Azure AD application in my organization, so I have to apply to my AD admin to have this application registered. I can not find any instructions on how this app should be registered, and how I can add it to my pipeline in order to allow access to my Container Registry. Is it at all possible to add a service connection to Azure Container Registry without having an Azure AD admin adding it through the DevOps dialog?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 45ba2ebe-27c4-111b-18b4-0192d8c3fb3a
Version Independent ID: f48fdf00-e04f-b406-93f3-20b7fad568be
Content: Build and push to Azure Container Registry - Azure Pipelines
Content Source: docs/pipelines/ecosystems/containers/acr-template.md
Product: devops
Technology: devops-cicd-ecosystems
GitHub Login: @azooinmyluggage
Microsoft Alias: atulmal

Thanks for your question. It looks like you're working through an issue with your scenario or implementation. Here are a couple of options where you might consider asking your question:

Azure DevOps Support Bot
Azure DevOps on Stack Overflow

cc @azooinmyluggage for awareness

Hi @mochr,
Did you ever find a way around this?
I'm up against the same thing.


3.8.0 Starting a new profile with Easy Start allows for 1 purchase of anything sold by a trader with max rep

General information:
Project issue is for:
In Game
Expected result:
Traders to have items/barters available for their loyalty level
Actual result:
Upon starting a new profile with Easy Start edition, every trader will allow for a one time purchase of any item they sell at max loyalty level, regardless of current loyalty level.
How to reproduce:

Create new profile with Easy Start edition
Go to Traders

Screenshots:

Attachments

server-2024-02-02.log (87 KiB)
LogOutput.log (12 KiB)
2024.02.02_23-19-55_<IP_ADDRESS>.28476 traces.log (46 KiB)
Screenshot_5.png (3040 KiB)
Screenshot_6.png (3035 KiB)

Originally written by Xotichl

We set easy start traders to level 4 on creation, this needs to be adjusted to 2.
Above wont work for mechanic/ragman as they're Level 1, will need some thought.

Originally written by chomp

Fixed with: https://dev.sp-tarkov.com/SPT-AKI/Server/commit/b6a57553de9ed051d703b51b73d2e238a36af83f

Originally written by chomp


[EAGLE-66] Typesafe Streaming DSL and KeyValue based Grouping

https://issues.apache.org/jira/browse/EAGLE-66

Deprecated pull request, will close soon, please just ignore.


create default schemer/seeder

schema done, trying to remember how to seed is taking longer cos im a dummy


Fix example

What:
I've fixed the code of the main example.
Why:
Because as I explain in this post, the custom-hook of the main example wouldn't work correctly otherwise.
How:
I just used the function overload of setState.
Checklist:

Yep

[X] Documentation updated
[X] Ready to be merged
[X] Added myself to contributors table

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #47   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          44     44
  Branches        4      4
=====================================
  Hits           44     44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d4d3d2...68cca1c. Read the comment docs.

Nice observation.


Feature: normalize and average

Changes proposed in this pull request:
Adds normalize and average to pyfar.dsp
Our new team member Basti wanted to work on averaging and normalizing signals. I thus merged the latest version of the work from the pyfar-semiar. Please review, so we see what is left to do...

Ist das Kunst, oder kann das weg? ;)

We wanted to leave this as Kunst until the to other branches are merged. Then it kann weg


Sync issue with darwin calendar server

This issue was moved from the issue tracker at GitLab.

I am trying creating a todo and then syncing it with darwin calendar server.
That fails with following error from darwin calendar server:
2016-04-15 02:55:17+0300 [-] [caldav-1]  [-] [twistedcaldav.method.put_common#error] Invalid calendar data: Calendar data had unfixable problems:
2016-04-15 02:55:17+0300 [-] [caldav-1]           [VTODO] Missing or too many required property: DTSTAMP

What I did:

I installed current version of todoman with pip.
Set up sync with darwin calendar server with vdirsyncer. Setup works (I can sync calendar/todo items, edit todos created from other sources, etc).
Tried to create new todo with following line: todo new -l calendar "test todo"
Todo is created locally and can be seen/modified
Sync fails with quoted error in server logs.

Resulting file (and file with same summary, but created from android "tasks" application, that syncs successfully are attached.
fail.ics
success.ics
The successful one does contain DTSTAMP field.

Indeed, it looks like DTSTART is a required field for VTODO entries, however, RFC5545 doesn't seem to specify what it should contain (and there's no coherent value I can think of either).
I'll try to look into this.

DTSTAMP vs DTSTART.

I found it here: http://www.ietf.org/rfc/rfc2445.txt and here: http://www.kanzaki.com/docs/ical/vtodo.html
Property Name: DTSTAMP
Purpose: The property indicates the date/time that the instance of
the iCalendar object was created.

Sorry, I mixed up DTSTAMP and DTSTART. It makes sense now.

I wonder if we could make the case that icalendar should generate DTSTAMP implicitly. Otherwise it would create invalid iCalendars by default.
On 17 April 2016 14:24:14 CEST, Hugo Osvaldo Barrera<EMAIL_ADDRESS>wrote:

Sorry, I mixed up DTSTAMP and DTSTART. It makes sense now.

You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/pimutils/todoman/issues/15#issuecomment-211010155

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

I've created collective/icalendar#193, to see if this can eventually be fixed upstream.


PAN-724 Parentheses in FROM clause

Closing this PR because of opening another: https://github.com/contiamo/calcite/pull/32 against contiamo-calcite-1.21


improvement(IDemuxer): add const for some IDemuxer method

Codecov Report

Merging #333 into develop will decrease coverage by 4.26%.
The diff coverage is 88.88%.

@@             Coverage Diff             @@
##           develop     #333      +/-   ##
===========================================
- Coverage    66.66%   62.40%   -4.27%
===========================================
  Files          212      212
  Lines        11542    11541       -1
===========================================
- Hits          7695     7202     -493
- Misses        3847     4339     +492

Impacted Files
Coverage Δ

framework/demuxer/IDemuxer.cpp
72.00% <ø> (ø)

framework/demuxer/IDemuxer.h
0.00% <0.00%> (ø)

framework/demuxer/avFormatDemuxer.cpp
76.55% <ø> (-2.08%)
:arrow_down:

framework/demuxer/avFormatDemuxer.h
0.00% <ø> (ø)

framework/demuxer/avFormatSubtitleDemuxer.h
92.30% <ø> (ø)

framework/demuxer/demuxer_service.cpp
85.45% <ø> (+0.60%)
:arrow_up:

framework/demuxer/demuxer_service.h
100.00% <ø> (ø)

framework/demuxer/play_list/AbstractStream.h
0.00% <ø> (ø)

framework/demuxer/play_list/HLSManager.h
100.00% <ø> (ø)

framework/demuxer/play_list/HLSStream.cpp
68.22% <ø> (-1.44%)
:arrow_down:

... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae81991...cf9840e. Read the comment docs.


Update recommend acceptance message with track eics team

🚧 ⚠  Merge after JOSS Tracks feature is shipped and all the track EiCs teams are created

cc/ @arfon

Teams now exist.


Sweeping Algorithm To Process Overdubs into Master

Overview
Each recording can have an arbitrary number of overdubs which are consolidated into a master timeline for the recording. Given that overdubs can either overwrite or overlay, the algorithm must be able to efficiently handle all layers. Since all overdubs must be layered overtime, we must rely on the server to sort the creation of each overdub creation by time. This means the server will be stateful w.r.t. to the clients who have created an overdub first. Since reliance on a connected server might be annoying, we can default to offline mode if there is no connection or something.

 Sweeping Algorithm for Processing Overdubs


New users see permissions and important dates when they shouldn't

If you create a new user, when you sign up, you see more permissions that you should.
Specifically, you see:

user and group permissions
staff / superuser
important dates

These should be visible to super users, but not end users.
### Where this seems to be occuring
I think this is down to the admin page being overridden here, where there are explicit listings of admin widgets.
https://github.com/thegreenwebfoundation/greenwebfoundation-admin/blob/master/apps/accounts/admin.py#L58-L71
I say this because there don't seem to be permissions associated with the hosting group that would list these widgets otherwise.

I believe that you would need to change this -> https://github.com/django/django/blob/master/django/contrib/auth/admin.py#L65

Closed with the PR in #58


♻ Refactor usage of internal number_of_trials variable, it was not being used, fix typo

Fix the typo "worflow" to "workflow" in README.md.
Use the number_of_trials variable in the for loop to improve consistency and maintainability in the file latest_changes/main.py.

Good catch, thank you @nghiahsgs! :rocket: :cake:


Fixed "Attacks prevented" taking string

You said they are bitsets. Can they be represented with the bitset tuple? or something custom for some safety?

Reason to leave it int was because there's no bitset option for level closures.
There's an example of illidanChannel ability, it has set/presetOptions with int, but ChannelAbilityPreset package implements bitset wrapping for it. So I'm just supporting what this package is about.

@Frotty, it's different from armor, movetype etc. in the way that you can't set AttacksPrevented to all the options you need if there's >1 without additional variable. I could do it, but it sounds not right.
So, I guess you just merge this.

i know, hence we have the bitset tuple, right? But ok, I will merge for now.


Use geth for nightly runs as well

Parity shows some problems, let's switch to geth for now.

Force-merging to see effect in nightlies.

Force-merging to see effect in nightlies.


client-event log spamming

Description
The issue is potentially caused by the Bearer Token becoming stale (see issue: "Avoid stale headers by supplying them as a function #33" https://github.com/Azure/fetch-event-source/issues/33)
As the fetch-event-source code is 4 years stale this is an attempt to replace with extended-eventsource (see issue "Resurrect repo #74" https://github.com/Azure/fetch-event-source/issues/74)
Initial testing appears to "work" - waited 15 minutes
Resolves #(issue)
Web-browser Network console being filled with client-event notifications ad nauseum.

There are issues, by design, that you cannot have two or more tabs open on the app (against the same server).  The server will force disconnect a user if they connect with a different EventSource (ie the other tab) and then vicious circle of repeating force disconnecting.

The Bearer Token is definitely refreshing correctly - in the server logs (which I augmented locally) I can see the client establish a new connection.  I will test the old code on the weekend to see if this occurred.


The Shopware Responsive Theme only shows the british and the german language flag in the storefront

PHP Version: 8.3   | Shopware Version: <IP_ADDRESS>  | Affected area / extension: Platform(Default)

Expected behaviour:
The flag symbol in the storefront should show the flag of the ISO code of the choosen language.
Actual behaviour:
If the ISO code of the language is not de-DE or en-GB, the flag symbol in the storefront is a white Rectangle.
How to reproduce:
I added a new language with locale = "Deutsch, Schweiz" and ISO Code = "de-CH".
After that i added a new url to my sales channel with this language. The flag symbol in the storefront is a white rectangle. It is also a white rectangle with all other ISO codes except the de-DE and en-GB codes.

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-38333
[created from NEXT-38333, comment 495753]

To be very honest: I personally don't believe in the concept of language flags at all as it can cause political ambiguity and even insults, see https://en.wikipedia.org/wiki/Flag_icons_for_languages#Criticism, not to talk about a11y, yet. In this manner, I believe that country flags shouldn't be shown in language selection at all.

Thanks, I came to the same conclusion as all our languages are targeted towards Swiss customers anyway  :)
We only need to switch the language, not the region/country.
I also got the information that I should create a "custom template" or edit the Theme to properly change such things in the frontend.
Once I read into that a bit more I'll post an update.
For now I'll try by renaming the flag images so they don't show at all and editing the languages to show as DE/EN/IT/FR.
I got this info from support:
The name is taken from the name of the language in Einstellungen > Shop > Sprachen.
(+ recompile Theme and clear cache)
Flag SVGs location:
/custom/plugins/SwagLanguagePack/src/Resources/public/static/flags

Important note:
Supposedly this issue is solved after version 6.6, but everyone (except for Shopware- and Plugin-developers/support) seems to think it's better to stay on 6.5..

[public]

Priority changed to: High

Thank you for your report. Based on the information in this report, we have decided to investigate this issue in more detail and are planning to provide a fix for this issue. Although we are always eager to solve such problems as soon as we can, we can't give you a more specific time frame right now. We appreciate your patience and thank you for your understanding.
[created from NEXT-38333, comment 529143]


Sabnzbd component logs type error

Home Assistant release with the issue:

0.66.1
Python release:
3.5.3
Last working Home Assistant release (if known):
?
Operating environment (Hass.io/Docker/Windows/etc.):

Debian 9, Python Virtual Environment
Component/platform:

https://www.home-assistant.io/components/sensor.sabnzbd/
Description of problem:
Although the SABNZBD sensors seem to work, there is an error logged (see stack trace).
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
sensor:
  - platform: sabnzbd
    host: <IP_ADDRESS>
    port: 8080
    api_key: !secret sabnzbd_api_key
    monitored_variables:
      - 'speed'
      - 'queue_size'
      - 'queue_remaining'
      - 'queue_count'

Traceback (if applicable):
ERROR (MainThread) [homeassistant.components.sensor] Error while setting up platform sabnzbd
Traceback (most recent call last):
  File "/opt/homeassistant/lib/python3.5/site-packages/homeassistant/helpers/entity_platform.py", line 82, in async_setup
    SLOW_SETUP_MAX_WAIT, loop=hass.loop)
  File "/usr/lib/python3.5/asyncio/tasks.py", line 400, in wait_for
    return fut.result()
  File "/usr/lib/python3.5/asyncio/futures.py", line 293, in result
    raise self._exception
  File "/usr/lib/python3.5/asyncio/tasks.py", line 239, in _step
    result = coro.send(None)
  File "/opt/homeassistant/lib/python3.5/site-packages/homeassistant/components/sensor/sabnzbd.py", line 152, in async_setup_platform
    if not (yield from async_check_sabnzbd(SabnzbdApi, base_url, api_key)):
  File "/opt/homeassistant/lib/python3.5/site-packages/homeassistant/components/sensor/sabnzbd.py", line 62, in async_check_sabnzbd
    yield from sab_api.check_available()
  File "/opt/homeassistant/lib/python3.5/site-packages/pysabnzbd/__init__.py", line 61, in check_available
    await self.call(params)
  File "/opt/homeassistant/lib/python3.5/site-packages/pysabnzbd/__init__.py", line 19, in call
    resp = await session.get(self.api_url, params=api_params)
  File "/opt/homeassistant/lib/python3.5/site-packages/aiohttp/client.py", line 312, in _request
    ssl=ssl, proxy_headers=proxy_headers)
  File "/opt/homeassistant/lib/python3.5/site-packages/aiohttp/client_reqrep.py", line 181, in __init__
    url2 = url.with_query(params)
  File "/opt/homeassistant/lib/python3.5/site-packages/yarl/__init__.py", line 851, in with_query
    new_query = self._get_str_query(*args, **kwargs)
  File "/opt/homeassistant/lib/python3.5/site-packages/yarl/__init__.py", line 819, in _get_str_query
    "should be str or int, got {!r}".format(v))
TypeError: Invalid variable type: mapping value should be str or int, got None

Additional information:

SABnzbd integration has now moved to being a component.  Has anyone got this running properly?  On the HA home page I see it under the Configurator.  I've entered the API key multiple times and still it doesn't get configured.  I've then added the appropriate entry in configuration.yaml but it still shows up in the Configurator, and no sensors are displayed.
Here's my configuration.yaml entry for any interested:
sabnzbd:
api_key: !secret sabnzbd_api_key
host: <IP_ADDRESS>
port: 9092
ssl: true
sensors:
- current_status
- queue_remaining
- queue_count


Stable null safety release of protobuf

To make Github Actions happy, protoc_plugin should be prepared for a release in follow up PR once protobuf is published


cowboy_req:read_body(Req0) timeout

Hello,
creating simple http-amqp gateway I have problem reading request body. Using function (mostly) copied from cowboy documentation
fetch_body(Rq) ->
    case cowboy_req:has_body(Rq) of
        true ->
            {ok, Body} = fetch_body(Rq, <<>>),
            Body;
        false ->
            <<>>
    end.

fetch_body(Req0, Acc) ->
    case cowboy_req:read_body(Req0) of
        {ok, Data, Req} ->
            {ok, <<Acc/binary, Data/binary>>, Req};
        {more, Data, Req} ->
            fetch_body(Req, <<Acc/binary, Data/binary>>)
    end.

testing with simple curl request shell script
$ cat test/post.sh
#!/bin/dash

curl -v -i --ipv4 \
    -H "Content-Type: application/json" \
    -X POST \
    --data @simple.json \
    'http://localhost:8567/mqw/v1/pub/raw'

The file simple.json is 2 line textfile. Erlang error follows:
=CRASH REPORT==== 7-Mar-2018::15:38:45 ===
  crasher:
    initial call: cowboy_stream_h:request_process/3
    pid: <0.365.0>
    registered_name: []
    exception exit: {{timeout,
                         {gen_server,call,
                             [amqcwb_publish,
                              {handle_http_request,
                                  #{bindings => #{},
                                    body_length => 73,
                                    has_body => true,
                                    headers => #{<<"accept">> => <<"*/*">>,
                                      <<"content-length">> => <<"73">>,
                                      <<"content-type">> => <<"application/json">>,
                                      <<"host">> => <<"localhost:8567">>,
                                      <<"user-agent">> => <<"curl/7.52.1">>},
                                    host => <<"localhost">>,
                                    host_info => undefined,
                                    method => <<"POST">>,
                                    path => <<"/mqw/v1/pub/raw">>,
                                    path_info => undefined,
                                    peer => {{127,0,0,1},57152},
                                    pid => <0.364.0>,
                                    port => 8567,
                                    qs => <<>>,
                                    ref => http_server_cowboy,
                                    scheme => <<"http">>,
                                    streamid => 1,
                                    version => 'HTTP/1.1'},
                                  []}]}},
                     [{gen_server,call,2,[{file,"gen_server.erl"},{line,204}]},
                      {cowboy_handler,execute,2,
                          [{file,
                               "/home/x/work/DS/amqpCowboy/_build/default/lib/cowboy/src/cowboy_handler.erl"},
                           {line,37}]},
                      {cowboy_stream_h,execute,3,
                          [{file,
                               "/home/x/work/DS/amqpCowboy/_build/default/lib/cowboy/src/cowboy_stream_h.erl"},
                           {line,205}]},
                      {cowboy_stream_h,request_process,3,
                          [{file,
                               "/home/x/work/DS/amqpCowboy/_build/default/lib/cowboy/src/cowboy_stream_h.erl"},
                           {line,184}]},
                      {proc_lib,init_p_do_apply,3,
                          [{file,"proc_lib.erl"},{line,247}]}]}
      in function  gen_server:call/2 (gen_server.erl, line 204)
      in call from cowboy_handler:execute/2 (/home/x/work/DS/amqpCowboy/_build/default/lib/cowboy/src/cowboy_handler.erl, line 37)
      in call from cowboy_stream_h:execute/3 (/home/x/work/DS/amqpCowboy/_build/default/lib/cowboy/src/cowboy_stream_h.erl, line 205)
      in call from cowboy_stream_h:request_process/3 (/home/x/work/DS/amqpCowboy/_build/default/lib/cowboy/src/cowboy_stream_h.erl, line 184)
    ancestors: [<0.364.0>,<0.349.0>,<0.348.0>,ranch_sup,<0.297.0>]
    messages: [{request_body,#Ref<<IP_ADDRESS>7>,fin,73,
                                <<"{ \"empty\": {\"one\": 1, \"two\": \"two\"}, \"full\": {\"one\": 1, \"two\": \"three\"} }">>}]
    links: [<0.364.0>]
    dictionary: []
    trap_exit: false
    status: running
    heap_size: 987
    stack_size: 27
    reductions: 313
  neighbours:

Output from curl script:
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to localhost (<IP_ADDRESS>) port 8567 (#0)
> POST /mqw/v1/pub/raw?from=meteo HTTP/1.1
> Host: localhost:8567
> User-Agent: curl/7.52.1
> Accept: */*
> Content-Type: application/json
> Content-Length: 73
>
* upload completely sent off: 73 out of 73 bytes
< HTTP/1.1 500 Internal Server Error
HTTP/1.1 500 Internal Server Error
< content-length: 0
content-length: 0

<
* Curl_http_done: called premature == 0
* Connection #0 to host localhost left intact

The application is rebar3 app, I did try cowboy v2.0.0, v2.1.0 and v2.2.2 from hex.pm, application runs using rebar3 shell. Well, can you help me? Do you need more information?

I tried v2.2.2 from github
{cowboy, {git, "https://github.com/ninenines/cowboy", {tag, "2.2.2"}}}

same result though :-/

Hmm it says the timeout is in a gen_server:call(amqcwb_publish, ...), that's not Cowboy.

To be clearer it appears that this is this gen_server:call function that timeouts, not Cowboy reading the body.

The gen_server:call(amqcwb_publish, waits (hangs) on calling the mentioned function:
handle_call({?HTTPRQ, InReq, HttpState}, _From, #pubst{} = State) ->
    ?L_DEBUG("Incoming HTTP request."),
    Resp = cowboy_req:reply(200,
                           #{<<"content-type">> => <<"text/plain">>},
                           build_test_body(InReq), InReq),
    {reply, {ok, Resp, HttpState}, State}.

build_test_body(InReq) ->
    #{method := Method, path := Path, qs := Qs, has_body := HB} = InReq,
    URI = iolist_to_binary(cowboy_req:uri(InReq)),
    Body = case HB of
                true ->
                    fetch_body(InReq);   %%%% <<-- call to the function with cowboy_req:read_body(Req0)
                _ ->
                    <<" - no body - ">>
           end,
    R4 = <<"Hello Erlang!",
           "\nMethod: ", Method/binary,
           "\nPath: ", Path/binary,
           "\nQuery: ", Qs/binary,
           "\nURI: ", URI/binary,
           "\nBody:\n", Body/binary,
           "\n">>,
    R4.

OK I think I see what you mean. Can you produce a sample repository that demonstrates the issue?

Ok, I've created repository
https://github.com/loudferret/iss1269_cowboy_timeout
compile with rebar3 compile, run with rebar3 shell
I've just found out that it does timeout from amqcwb_publish genserver but works ok directly from amqcwb_cwb. I don't know why. There are two scripts in test/:

post_err.sh - calls read_body/1 in gen_server and timeouts
post_ok.sh - calls read_body/1 directly within the handler and works ok

Thanks a lot.

Thanks! I'll check it when I can spare the time. Might not be before Monday.

Ah, I see what you are trying to do. Well that's not going to work. The few calls that allow performing operations must be done from the process that own the Req, ie the request process.
Maybe it could be useful in the future to allow changing this owner process, or to remove this restriction entirely. I don't know. But right now you can't do that. What you can do instead is do these operations in your handler and then pass the result to your own backend. And that will always work.

@essen : I did exactly what you're suggesting and, as I wrote, it works.
I am not aware about ownership of data - Req in this case - in Erlang. Can you pls explain that in detail.
From my point of view the issue can be closed. The correct solution must be decided by yourself.
thanks for help.

It's just Cowboy assuming that the request process is the only one that's going to perform operations on this request/response. It doesn't check for some operations though, like replying, but is explicitly sending the request body to the request process (that is, your gen_server doesn't send its own pid when asking for the request body).
I think for Cowboy 2 it'll stay this way (a fix would be a breaking change) but I'll keep it in mind if other people run into this for a Cowboy 3 or later.
Cheers.


Arrange RibbonBar in more robust fashion. Should have an method to madness.

Currently I think maybe Controller and Preferences should be renamed and tasked. Preferences are specifically the Driver Preferences of the current device and Controller monitors the Output of the current Device.

Better - but I would suggest:

Start Job -> Execute Job
Compile and Simulate -> Simulate
Controller I am fine with.
Preferences -> Configuration
Settings -> Preferences
Group: Main -> Project
Group: Window -> Control
Move Console to the end of Main group.
Move Pause (/Resume) to the right of Spooler - or with the big Stop / Home buttons at the bottom (not showing in the pic above)
Settings and Preferences should have different icons.
Usb button - see previous discussion about debug - don't you get the same info in an optional panel of the controller window? Can we dispense with this?

Fetching a new icon took the most time. Though I did find a nice ram chip icon. Not sure what it'll be used for but it's clearly perfect for something.

Also, of interest. This is a lot of real estate for 17 buttons.

I lean towards this a bit. Mostly because Devices are a real thing now. And they basically setup the Spooler, Config, and Controller.  Maybe Navigator would want to move too leaving camera all alone in Window.

I still think pause is like the emergency cancel or home panels. And Devices and Config definitely belong in Settings. And Spooler and Controller seem to fit with Navigation and Camera into a set of laser controls.
So I preferred the previous design plus my changes to this.

My thinking is more about what buttons get used when i.e. user centric.

Well I couldn't get the ribbon bar to minimize but I made the little arrow there let you get the taskbar thing for it and consequently close it. I added a couple panes like navigation for show. These could be disabled or put where-ever, though highly customizable some consideration needs to be given towards initial arrangements.

https://user-images.githubusercontent.com/3302478/119372953-c014a380-bc6c-11eb-8370-198b0b092cd1.mp4

The problem I have is that config and controller change in other devices. They might even be absent. That's because classwise those really are devices.
We could throw away pause and do that in a pane if folks wanted such a thing. It's a pretty easy change. In fact, done.

I quite like the idea that you can move the buttonbar anywhere or close it - can we have that as standard?
And I see we now have View/Panes/stuff which is great.
So dispense with the up/down arrow, and if possible move the help button to the end of the menu bar - or if not add a Help menu which has a variety of places to go for help.

I like that more than a button on the button bar. Does it switch to a resume icon when you click it?
If Config and Controller change with the device, (understandable) and if the other device doesn't have these, then we simply grey out the buttons or remove them.

Help is a on the menu bar, language goes last because it's added dynamically if there are translations. But, help is always there and launches the wiki stuff etc.
It didn't... but now it does.
Doesn't update though if something else changes it.

Currently the buttons launch a weird thing that says there's no gui for this thing. But, others like File or TCP might well be better off with a different icon and name. Or a different button that is turned on and the other turned off as needed.

https://user-images.githubusercontent.com/3302478/119376254-965d7b80-bc70-11eb-83c0-f53efbfd06db.mp4

I'll get to whatever ideas you have in due course, heading to bed. I'm pretty close to having optimization working. I need a few more tweaks but the simulation is generally kinda reasonable. I did set passes to 3 and it went a bit crazy. But, that might be a side-effect bug. And the rotary scaling effects the main scene, and a couple more known bugs. But, it's almost to big old bug-hunt time.


Let AKSampler propagate exceptions

I think it would be a good idea to be able to get more information when the various loading functions for AKSampler fail. This changes the APIs to let the methods throw any raised exceptions.
Also cleaned up a little bit what was being sent to AKLog() for consistency.

Other than forcing the tries in the example I'm all for this kind of change.


Change setting name prefixes from AAD to AZURE

AZURE_CLIENT_ID and AZURE_CLIENT_SECRET is what DefaultAzureCredential/ServicePrincipalCredential in the Azure.Identity SDK use to find the application information.

@SvenAelterman : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"


working setup of flink via kuttl

Signed-off-by: Ken Sipe<EMAIL_ADDRESS>

Let's update this to use a recent version of flink-demo that uses KUDO's dependency feature. With that, most setup steps aren't necessary anymore, the flink-demo operator will take care of installing it's dependencies. Furthermore, it isn't necessary to change anything regarding local storage in kind (as done in 01-update-storage-class.yaml), because this is part of a default cluster. IMO, if I'm not missing something, the test could be as simple as running kubectl kudo install ../../financial-fraud/demo-operator --instance flink-demo and waiting for the flink-demo Instance to complete. Checking that the dependencies have been installed is also a great test. So it's what currently done in step 3,4,5,6, without steps 1,2. Though all of these assert in 3,4,5,6 can be done in a single step, because they should all be true once the flink-demo instance is complete.

One thing might be a problem though: We already install O/OVs for a lot of operators as part of the test setup: https://github.com/kudobuilder/operators/blob/master/kuttl-test.yaml. We should run this test in a separate namespace to ensure that new O/OVs are installed for the flink-demo operator and its dependencies.

@nfnt unless kuttl is configured to run in a specific namespace... a new namespace is create for each test


Expose Collection.name

Allows to get and set names for Collections (missing api for LegacyGrpc)
Necessary to allow exporting named custom results to VTU.

@PProfizi is it straightforward to add it in legacy grpc as well? We now have big customers using it, if we could prevent having too  many differences between our server config I think it would be good

@PProfizi is it straightforward to add it in legacy grpc as well? We now have big customers using it, if we could prevent having too many differences between our server config I think it would be good

Hey @cbellot000, the goal is to implement it for all types on connections, hence the testing being activated for all 3 types. Now it works for InProcess, my next step will be to implement changes so it is available via gRPC too.


Even if X-Not-Sampled is set, the incoming endpoints should create a span

X-Not-Sampled is a misnomer now, and maybe that has caused us to fall into a trap. We still want the log correlations, even for spans that are not going to be exported.

Duh! My mistake. All working as expected.


Filtering for EDA

Hi
Before applying the cvxEDA algorithm you are filtering the signal. According to the cvxEDA paper this is not necessary: "As a result, the method does not require pre-processing of the observed SC signal (e.g., bandpass filtering) nor post-processing of the inferred phasic and tonic components (e.g., to deal with negative neural activations)."

@Eichhof as you can turn off the cvxEDA algorithm, a bit of filtering is indeed done by default. I had some good results with it (mainly to clean some serious artifacts to ease the subsequent cvxEDA computation).
However, if you have reasons to think this could be a bad thing (the cvxEDA must be run on raw data), I believe we could either change it (and add the option to select between "traditional" filtering and cvxEDA) or a parameter to turn off the prefiltering.
What are your thoughts?

Actually, I have just seen that in eda_process() you pass the raw (unfiltered and unsmoothed) signal to cvxEDA.


Ensure PowerShellGet functions always call the latest PackageManagement functions

Resolves Issue 227.  Will need test automation to complete in order to verify for WMF4.

@mgreenegit please take a look at https://github.com/PowerShell/PowerShellGet/issues/227#issuecomment-364561493.


URL detection issue

"google.com", "google.uk" is not detected as a URL

+1
As a temporary solution, you can provide a custom regex which would suite your needs via ActiveType.custom(pattern:).


fix(post): small spelling typo

I'm guessing my github user doesnt have the correct auth to have the job run on Travis:
In this PR's Travis config:
"global_env": null,

In a recent PR's Travis config from @orta:
"global_env": "GIT_NAME=[secure] GIT_EMAIL=[secure] GH_TOKEN=[secure]",

Yep - correct @cogell 👍 the red is fine - thanks


Limit the blog post title length to 3 rows ~70 characters

This PR Closes Issue closes
https://github.com/AnguHashBlog/angular-primeng/issues/30
Description
1.Limit the blog post title length to 3 rows ~70 characters
2.Created a custom pipe name (truncate) ,takes  input (optional) for truncating the string to the desired length, and at the at the end of the string, added "..." .
3.used the truncate pipe in series and post components for post title.
What type of PR is this? (check all applicable)

[✓] 🅰 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Mobile & Desktop Screenshots/Recordings
[Attach screenshots or recordings if applicable]
Steps to QA
Added to documentation?

[ ] 📜 README.md
[ ] 🙅 no documentation needed

[Optional] Post-deployment tasks
[Specify any post-deployment tasks that need to be performed]
[Optional] What gif best describes this PR or how it makes you feel?
[Embed gif or describe the feeling in plain text]

@DongreJaipal thank you :)


WIP feat: initial app

 Here is an overview of what got changed by this pull request:

Clones added
============
- src/models/Reaction.js  2
- src/models/Message.js  1
- src/models/Score.js  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- tests/mocks/factory.js  4
- src/models/Message.js  1
- tests/index.test.js  1
- src/models/Reaction.js  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- src/models/Message.js  1
- tests/mocks/factory.js  4
- tests/index.test.js  1
- src/database/Mongo.js  1
- src/models/Reaction.js  1
- tests/utils.js  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- src/database/Mongo.js  1
- tests/mocks/factory.js  4
- tests/index.test.js  1
- tests/utils.js  1
- src/models/Message.js  1
- src/models/Reaction.js  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- src/models/Message.js  1
- tests/mocks/factory.js  4
- src/database/Mongo.js  1
- src/models/Reaction.js  1
- tests/index.test.js  1
- tests/utils.js  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- src/controllers/ScoreController.js  2
- src/models/Reaction.js  1
- src/database/Mongo.js  1
- src/models/Message.js  1
- tests/index.test.js  1
- tests/mocks/factory.js  4
- tests/utils.js  1
- src/controllers/AchievementController.js  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- src/controllers/ScoreController.js  4
- tests/utils.js  1
- tests/index.test.js  1
- src/models/Message.js  1
- src/models/Reaction.js  1
- tests/mocks/factory.js  4
- src/controllers/AchievementController.js  2
- src/database/Mongo.js  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- src/database/Mongo.js  1
- tests/index.test.js  1
- src/controllers/ScoreController.js  2
- tests/mocks/factory.js  4
- src/models/Message.js  1
- src/controllers/AchievementController.js  2
- src/models/Reaction.js  1
- tests/utils.js  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- src/controllers/AchievementController.js  2
- tests/index.test.js  1
- src/controllers/RankingController/index.js  2
- src/controllers/ScoreController.js  6
- src/models/Message.js  1
- tests/utils.js  1
- src/database/Mongo.js  1
- tests/mocks/factory.js  4
- src/models/Reaction.js  1
- src/routes/miner.js  1
- src/routes/api.js  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- src/database/Mongo.js  1
- src/controllers/RankingController/index.js  2
- tests/index.test.js  1
- src/routes/api.js  1
- src/models/Reaction.js  1
- src/models/Message.js  1
- tests/mocks/factory.js  4
- tests/utils.js  1
- src/routes/miner.js  1
- src/controllers/BotController.js  2
- src/controllers/AchievementController.js  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- tests/mocks/factory.js  4
- src/controllers/BotController.js  2
- src/models/Reaction.js  1
- src/models/Message/schema.js  1
- src/controllers/AchievementController.js  2
- tests/index.test.js  1
- src/routes/api.js  1
- src/routes/miner.js  1
- src/controllers/RankingController/index.js  2
- src/database/Mongo.js  1
- tests/utils.js  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- src/controllers/BotController.js  2
- tests/index.test.js  1
- src/controllers/RankingController/index.js  2
- src/database/Mongo.js  1
- src/controllers/AchievementController.js  2
- src/routes/miner.js  1
- src/models/Reaction.js  1
- src/models/Message/schema.js  1
- tests/utils.js  1
- src/routes/api.js  1
- tests/mocks/factory.js  4

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- src/controllers/AchievementController.js  2
- src/routes/api.js  1
- src/controllers/BotController.js  2
- src/models/Message/schema.js  1
- tests/utils.js  1
- src/database/Mongo.js  1
- src/routes/miner.js  1
- src/controllers/RankingController/index.js  2
- tests/index.test.js  1
- tests/mocks/factory.js  4
- src/models/Reaction.js  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- src/routes/api.js  1
- src/controllers/RankingController/index.js  2
- src/controllers/AchievementController.js  2
- tests/index.test.js  1
- src/models/Message/schema.js  1
- src/controllers/BotController.js  2
- src/models/Reaction.js  1
- src/routes/miner.js  1
- tests/mocks/factory.js  4

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- src/routes/miner.js  1
- src/routes/api.js  1
- src/controllers/BotController.js  2
- tests/index.test.js  1
- src/models/Reaction.js  1
- tests/mocks/factory.js  4
- src/controllers/RankingController/index.js  2
- src/controllers/AchievementController.js  2
- src/models/Message/schema.js  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- tests/mocks/factory.js  4
- src/controllers/RankingController/index.js  2
- src/controllers/AchievementController.js  2
- src/models/Message/schema.js  1
- src/controllers/BotController.js  2
- src/routes/miner.js  1
- tests/index.test.js  1
- src/models/Reaction.js  1
- src/routes/api.js  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- src/models/Message/schema.js  1
- src/models/Reaction.js  1
- tests/mocks/factory.js  4
- src/controllers/RankingController/index.js  2
- src/controllers/AchievementController.js  2
- src/routes/miner.js  1
- src/controllers/BotController.js  2
- tests/index.test.js  1
- src/routes/api.js  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- src/models/Reaction.js  1
- tests/index.test.js  1
- src/controllers/RankingController/index.js  2
- tests/mocks/factory.js  4
- src/routes/miner.js  1
- src/controllers/AchievementController.js  2
- src/routes/api.js  1
- src/models/Message/schema.js  1
- src/controllers/BotController.js  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- src/controllers/RankingController/index.js  2
- tests/index.test.js  1
- tests/mocks/factory.js  4
- src/controllers/AchievementController.js  2
- src/models/Reaction.js  1
- src/routes/miner.js  1
- src/models/Message/schema.js  1
- src/controllers/BotController.js  2
- src/routes/api.js  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- src/controllers/BotController.js  2
- tests/index.test.js  1
- src/routes/api.js  1
- src/routes/miner.js  1
- src/models/Reaction.js  1
- src/models/Message/schema.js  1
- src/controllers/RankingController/index.js  2
- tests/mocks/factory.js  4
- src/controllers/AchievementController.js  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- src/controllers/AchievementController.js  2
- src/routes/api.js  1
- src/controllers/RankingController/index.js  2
- src/models/Reaction.js  1
- tests/mocks/factory.js  4
- src/models/Message/schema.js  1
- src/controllers/BotController.js  2
- src/routes/miner.js  1
- tests/index.test.js  1

See the complete overview on Codacy


Add reason when cast vote

Fixes Issue #3147
Changes in this PR:

submit vote with reason
query votes with reason
display vote reason if not empty

How to test and review this PR?
you can vote on any proposal with reason and then check the result.
Screenshot:

Potential related issue:
it seems the API didn't return newest reason after user change their vote option. (newest option but not newest reason).

Thanks for your contribution @twodam, here is some feedback:

The input currently look like this:

But this doesn't follow the style that we have on others inputs, we should change to a style like this (taken from space settings page):

As you can see in this example the background is different, padding too, there isn't any outline too.

Here we should use the icon annotation from Heroicons and not the information-circle icon, also the size should be the same as the sign icon next to it.

For the issue on the hub it will be fixed on next update.

Thanks for your contribution @twodam, here is some feedback:

The input currently look like this:

But this doesn't follow the style that we have on others inputs, we should change to a style like this (taken from space settings page):

As you can see in this example the background is different, padding too, there isn't any outline too.

Here we should use the icon annotation from Heroicons and not the information-circle icon, also the size should be the same as the sign icon next to it.

For the issue on the hub it will be fixed on next update.

how can I add icon annotation? do I need to upload things in src/assets/fonts?

I found five different style for TextareaAutosize, what do you want?

class="s-input !rounded-3xl"
class="input w-full text-left"
class="no-scrollbar w-full !overflow-x-scroll whitespace-pre font-mono text-sm"
class="input w-full text-left"
class="input h-full w-full text-left"

@samuveth @bonustrack thanks for detailed feedback, I updated those place, can you review again?

The arrow is off-center

@twodam I've fixed my remaining issues and I've given it to final review.


Update docs to access database from ec2 bastion host

Describe the issue
The current documentation segment "Connecting to the Database" of the directory live/core is outdated and might generate confusions, we should update the correct variable names an proper steps to achieve the connection between the bastion host and the RDS instance
Links
https://github.com/nanlabs/terraform-aws-starter/tree/main/live/core

It is up to date now!


How to Use it Stand Alone?

I want to use it with PHP not composer how to install it in my PHP script?

With the addition of #34 you should now be able to follow the instructions here: https://github.com/google/recaptcha#manual-installation

okay, thanks


[Embeddingapi] Add autocase for XWalkCookieManager apis

-Add autocase for XWalkCookieManager apis
-Cover the XWalkActivity and XWalkInitializer two ways
Impacted tests(approved): new 14, update 0, delete 0
Unit test platform: [Android]
Unit test result summary: pass 14, fail 0, block 0
https://crosswalk-project.org/jira/browse/XWALK-3528

@jennycao  please help to review it.

LGTM


LOADED_IMAGE is not marshaled correctly

https://github.com/AArnott/pinvoke/blob/918b9e4cabcb29f151c79aae20233eeb5bd61bef/src/DbgHelp/DbgHelp%2BLOADED_IMAGE.cs#L65-L79
The fields fSystemImage, fDOSImage, and fReadOnly must be marshaled as 1-byte BOOLEAN values; please use UnmanagedType.U1 for them.  At present they are marshaled as 4-byte BOOL values (UnmanagedType.Bool), which corrupts data in the LOADED_IMAGE structure.  In addition, it would be better to change the type of the SizeOfImage field to uint.

Thanks for your report, @AntonLapounov


Having problem with permissions

Hi, I am new to linux. How I can give the permissions to download at opt folder??

In most cases with the prefix sudo.

I tried to use sudo but it says I should be a root user

I'm not sure want you exactly want to do.
You can try sudo su. Now you are root user (administrator).
Use exit to leave this mode.


windows 7 powershell 2.0 version issue

This line of code doesn't work under powershell 2.0 version.
$timestamp_unix = $timestamp_unix -shl (64+29)
After modifying the code, it can barely execute normally.
$timestamp_unix = $timestamp_unix *<PHONE_NUMBER>283042199192993792

Thank you for your feedback! I have added PowerShell 2.0 support.


Use Managed monad in CLI

Currently Language.Spectacle.Interaction.Options uses a file Handle to write model checker logs to a file if the user provides an output path with --output/-o and is subsequently closed when CLI is completed in Language.Spectacle.Interaction.CLI.
Manually managing this handle is error-prone. @ixmatus noted using the Managed monad to handle cleanup of file Handles would be an improvement.

Some other ideas to consider:

Follow the withFile style instead of openFile:
-handleFrom :: OutputOpt -> IO Handle
+withHandleFrom :: OutputOpt -> (Handle -> IO a) -> IO a

resourcet is similar to managed, but it lets you free resources early (managed holds onto resources until you leave the Managed monad).


Commander should be more CommanderWindow independent

To use Commander.scala in another context it would be interesting to have it more independent from CommanderWindow
Especially (from what I understood), it is required to launch the call def run(window: CommanderWindow)  method (at least to init the node list L112).
My first tests are working with Commander.run(new CommanderWindow()) but it may cause some problems on more complicated use cases.
Is it possible to add a new method to "run" the commander without CommanderWindow ?
(or allow to pass null as parameter)

The commander was initially intended to be used with the UI. But it could be used by a REPL for agentv. I'll do some refactoring and perhaps add a REPL too.

@bmaggi, I've refactored the Commander to be independent from the UI. Take a look at the new implementation and at how the CommanderWindow leverages it.
Notice that if you are interested in receiving notification you'll have to implement the interface  AgentvEventListener. Also notice that the Commander is no more a Scala Object, it is now a class.
In any case the take a look at the CommanderWindow  to get a sense of how you may use the new commander.

I am closing the issue as the refactoring addresses it.